Re: [PATCH net-next 0/1] Support for VLAN interface over HSR/PRP

2020-09-09 Thread Murali Karicheri
Hi Willem, On 9/8/20 1:51 PM, Willem de Bruijn wrote: On Tue, Sep 8, 2020 at 6:55 PM Murali Karicheri wrote: Hi Willem, On 9/4/20 11:52 AM, Willem de Bruijn wrote: On Thu, Sep 3, 2020 at 12:30 AM Murali Karicheri wrote: All, On 9/2/20 12:14 PM, Murali Karicheri wrote: All, On 9/1/20

Re: [PATCH net-next 0/1] Support for VLAN interface over HSR/PRP

2020-09-08 Thread Murali Karicheri
Hi Willem, On 9/4/20 11:52 AM, Willem de Bruijn wrote: On Thu, Sep 3, 2020 at 12:30 AM Murali Karicheri wrote: All, On 9/2/20 12:14 PM, Murali Karicheri wrote: All, On 9/1/20 3:54 PM, Murali Karicheri wrote: This series add support for creating VLAN interface over HSR or PRP interface

Re: [PATCH net-next 1/1] net: hsr/prp: add vlan support

2020-09-08 Thread Murali Karicheri
Hi Willem, Thanks for the response! On 9/4/20 11:45 AM, Willem de Bruijn wrote: On Tue, Sep 1, 2020 at 9:54 PM Murali Karicheri wrote: This patch add support for creating vlan interfaces over hsr/prp interface. Signed-off-by: Murali Karicheri --- net/hsr/hsr_device.c | 4 net/hsr

Re: [PATCH net-next 0/1] Support for VLAN interface over HSR/PRP

2020-09-02 Thread Murali Karicheri
All, On 9/2/20 12:14 PM, Murali Karicheri wrote: All, On 9/1/20 3:54 PM, Murali Karicheri wrote: This series add support for creating VLAN interface over HSR or PRP interface. Typically industrial networks uses VLAN in deployment and this capability is needed to support these networks

Re: [PATCH net-next 0/1] Support for VLAN interface over HSR/PRP

2020-09-02 Thread Murali Karicheri
All, On 9/1/20 3:54 PM, Murali Karicheri wrote: This series add support for creating VLAN interface over HSR or PRP interface. Typically industrial networks uses VLAN in deployment and this capability is needed to support these networks. This is tested using two TI AM572x IDK boards connected

[PATCH net-next 1/1] net: hsr/prp: add vlan support

2020-09-01 Thread Murali Karicheri
This patch add support for creating vlan interfaces over hsr/prp interface. Signed-off-by: Murali Karicheri --- net/hsr/hsr_device.c | 4 net/hsr/hsr_forward.c | 16 +--- 2 files changed, 13 insertions(+), 7 deletions(-) diff --git a/net/hsr/hsr_device.c b/net/hsr

[PATCH net-next 0/1] Support for VLAN interface over HSR/PRP

2020-09-01 Thread Murali Karicheri
/NxF83yZFDX/ Logs for IDK-2 at https://pastebin.ubuntu.com/p/YBXBcsPgVK/ Murali Karicheri (1): net: hsr/prp: add vlan support net/hsr/hsr_device.c | 4 net/hsr/hsr_forward.c | 16 +--- 2 files changed, 13 insertions(+), 7 deletions(-) -- 2.17.1

[PATCH net v4] net: ethernet: ti: cpsw_new: fix error handling in cpsw_ndo_vlan_rx_kill_vid()

2020-08-27 Thread Murali Karicheri
based driver part 1 - dual-emac") Signed-off-by: Murali Karicheri --- v4 - updated error message with name of the function failed. v3 - updated commit description to describe error check related to port vlan VID v2 - updated comments from Grygorii, also return error code if VID d

[PATCH net v4] net: ethernet: ti: cpsw_new: fix error handling in cpsw_ndo_vlan_rx_kill_vid()

2020-08-27 Thread Murali Karicheri
based driver part 1 - dual-emac") Signed-off-by: Murali Karicheri --- v4 - updated error message with name of the function failed. v3 - updated commit description to describe error check related to port vlan VID v2 - updated comments from Grygorii, also return error code if VID d

Re: [net v3 PATCH] net: ethernet: ti: cpsw_new: fix error handling in cpsw_ndo_vlan_rx_kill_vid()

2020-08-27 Thread Murali Karicheri
Hi Dave, On 8/25/20 12:36 PM, David Miller wrote: From: Murali Karicheri Date: Mon, 24 Aug 2020 13:01:00 -0400 + ret = cpsw_ale_del_vlan(cpsw->ale, vid, 0); + if (ret) + dev_err(priv->dev, "%s: failed %d: ret %d\n", + __func_

[net v3 PATCH] net: ethernet: ti: cpsw_new: fix error handling in cpsw_ndo_vlan_rx_kill_vid()

2020-08-24 Thread Murali Karicheri
based driver part 1 - dual-emac") Signed-off-by: Murali Karicheri --- v3 - updated commit description to describe error check related to port vlan VID v2 - updated comments from Grygorii, also return error code if VID match with port_vlan vid. drivers/net/ethernet/ti/cpsw_

[net v2 PATCH] net: ethernet: ti: cpsw_new: fix error handling in cpsw_ndo_vlan_rx_kill_vid()

2020-08-24 Thread Murali Karicheri
. return zero in these cases as these are not real error case, but only serve to catch ALE table update related issues and help address the same in the driver. Fixes: ed3525eda4c4 ("net: ethernet: ti: introduce cpsw switchdev based driver part 1 - dual-emac") Signed-off-by: Murali

[net v3 PATCH 2/2] net: ethernet: ti: cpsw_new: fix clean up of vlan mc entries for host port

2020-08-24 Thread Murali Karicheri
the VLAN interface. cpsw_ale_flush_multicast() calls cpsw_ale_flush_mcast which expects a port mask to do the job. Fixes: ed3525eda4c4 ("net: ethernet: ti: introduce cpsw switchdev based driver part 1 - dual-emac") Signed-off-by: Murali Karicheri --- v3: added Fixes tag as per comment v2: D

[net v3 PATCH 1/2] net: ethernet: ti: cpsw: fix clean up of vlan mc entries for host port

2020-08-24 Thread Murali Karicheri
the VLAN interface. cpsw_ale_flush_multicast() calls cpsw_ale_flush_mcast which expects a port mask to do the job. Fixes: 15180eca569b ("net: ethernet: ti: cpsw: fix vlan mcast") Signed-off-by: Murali Karicheri --- v3: added Fixes tag as per comment v2: Dropped 3/3 and re-sending as it need

Re: [net v2 PATCH 2/2] net: ethernet: ti: cpsw_new: fix clean up of vlan mc entries for host port

2020-08-24 Thread Murali Karicheri
On 8/21/20 4:00 PM, Jesse Brandeburg wrote: Murali Karicheri wrote: To flush the vid + mc entries from ALE, which is required when a VLAN interface is removed, driver needs to call cpsw_ale_flush_multicast() with ALE_PORT_HOST for port mask as these entries are added only for host port

Re: [PATCH iproute2 v5 0/2] iplink: hsr: add support for creating PRP device

2020-08-21 Thread Murali Karicheri
Stephen, On 8/19/20 5:21 PM, Murali Karicheri wrote: Hi, Stephen, On 8/17/20 5:17 PM, Murali Karicheri wrote: This series enhances the iproute2 iplink module to add support for creating PRP device similar to HSR. The kernel part of this is already merged to v5.9 master v5 - addressed comment

[net v2 PATCH 2/2] net: ethernet: ti: cpsw_new: fix clean up of vlan mc entries for host port

2020-08-21 Thread Murali Karicheri
the VLAN interface. cpsw_ale_flush_multicast() calls cpsw_ale_flush_mcast which expects a port mask to do the job. Signed-off-by: Murali Karicheri --- v2: Dropped 3/3 and re-sending as it need more work drivers/net/ethernet/ti/cpsw_new.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff

[net v2 PATCH 1/2] net: ethernet: ti: cpsw: fix clean up of vlan mc entries for host port

2020-08-21 Thread Murali Karicheri
the VLAN interface. cpsw_ale_flush_multicast() calls cpsw_ale_flush_mcast which expects a port mask to do the job. Signed-off-by: Murali Karicheri --- v2: Dropped 3/3 and re-sending as it need more work drivers/net/ethernet/ti/cpsw.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git

Re: [PATCH iproute2 v5 0/2] iplink: hsr: add support for creating PRP device

2020-08-19 Thread Murali Karicheri
Hi, Stephen, On 8/17/20 5:17 PM, Murali Karicheri wrote: This series enhances the iproute2 iplink module to add support for creating PRP device similar to HSR. The kernel part of this is already merged to v5.9 master v5 - addressed comment from Stephen Hemminger - Sending

[PATCH iproute2 v5 2/2] ip: iplink: prp: update man page for new parameter

2020-08-17 Thread Murali Karicheri
PRP support requires a proto parameter which is 0 for hsr and 1 for prp. Default is hsr and is backward compatible. Signed-off-by: Murali Karicheri --- man/man8/ip-link.8.in | 9 - 1 file changed, 8 insertions(+), 1 deletion(-) diff --git a/man/man8/ip-link.8.in b/man/man8/ip-link.8

[PATCH iproute2 v5 1/2] iplink: hsr: add support for creating PRP device similar to HSR

2020-08-17 Thread Murali Karicheri
to differentiate the two protocols. Signed-off-by: Murali Karicheri --- ip/iplink_hsr.c | 17 +++-- 1 file changed, 15 insertions(+), 2 deletions(-) diff --git a/ip/iplink_hsr.c b/ip/iplink_hsr.c index 7d9167d4e6a3..da2d03d4bcbc 100644 --- a/ip/iplink_hsr.c +++ b/ip/iplink_hsr.c @@ -25,7

[PATCH iproute2 v5 0/2] iplink: hsr: add support for creating PRP device

2020-08-17 Thread Murali Karicheri
if possible. v3 of the series is rebased to iproute2-next/master at git://git.kernel.org/pub/scm/network/iproute2/iproute2-next and send as v4. Please apply this if looks good. Murali Karicheri (2): iplink: hsr: add support for creating PRP device similar to HSR ip: iplink: prp: update man page

Re: [net-next iproute2 PATCH v4 1/2] iplink: hsr: add support for creating PRP device similar to HSR

2020-08-17 Thread Murali Karicheri
On 8/16/20 6:46 PM, Stephen Hemminger wrote: On Thu, 6 Aug 2020 16:37:11 -0400 Murali Karicheri wrote: + + print_int(PRINT_ANY, + "proto", + "proto %d ", + rta_getattr_u8(

Re: [net-next iproute2 PATCH v4 0/2] iplink: hsr: add support for creating PRP device

2020-08-10 Thread Murali Karicheri
iproute2 maintainers, On 8/6/20 4:37 PM, Murali Karicheri wrote: This series enhances the iproute2 iplink module to add support for creating PRP device similar to HSR. The kernel part of this is already merged to net-next and the same can be referenced at https://www.spinics.net/lists/linux-api

[net-next iproute2 PATCH v4 0/2] iplink: hsr: add support for creating PRP device

2020-08-06 Thread Murali Karicheri
at git://git.kernel.org/pub/scm/network/iproute2/iproute2-next and send as v4. Please apply this if looks good. Murali Karicheri (2): iplink: hsr: add support for creating PRP device similar to HSR ip: iplink: prp: update man page for new parameter ip/iplink_hsr.c | 19

[net-next iproute2 PATCH v4 2/2] ip: iplink: prp: update man page for new parameter

2020-08-06 Thread Murali Karicheri
PRP support requires a proto parameter which is 0 for hsr and 1 for prp. Default is hsr and is backward compatible. Signed-off-by: Murali Karicheri --- man/man8/ip-link.8.in | 9 - 1 file changed, 8 insertions(+), 1 deletion(-) diff --git a/man/man8/ip-link.8.in b/man/man8/ip-link.8

[net-next iproute2 PATCH v4 1/2] iplink: hsr: add support for creating PRP device similar to HSR

2020-08-06 Thread Murali Karicheri
to differentiate the two protocols. Signed-off-by: Murali Karicheri --- ip/iplink_hsr.c | 19 +-- 1 file changed, 17 insertions(+), 2 deletions(-) diff --git a/ip/iplink_hsr.c b/ip/iplink_hsr.c index 7d9167d4e6a3..6ea138a23cbc 100644 --- a/ip/iplink_hsr.c +++ b/ip/iplink_hsr.c @@ -25,7

Re: [net-next iproute2 PATCH v3 1/2] iplink: hsr: add support for creating PRP device similar to HSR

2020-08-06 Thread Murali Karicheri
On 8/6/20 1:12 PM, David Ahern wrote: On 8/6/20 10:04 AM, Murali Karicheri wrote: that the maintainers are different than the netdev maintainers. My bad. The PRP driver support in kernel is merged by Dave to net-next and this iproute2 change has to go with it. So please review and apply

Re: [net-next iproute2 PATCH v3 1/2] iplink: hsr: add support for creating PRP device similar to HSR

2020-08-06 Thread Murali Karicheri
Hi Stephen, Alexey, On 7/17/20 11:22 AM, Murali Karicheri wrote: This patch enhances the iplink command to add a proto parameters to create PRP device/interface similar to HSR. Both protocols are quite similar and requires a pair of Ethernet interfaces. So re-use the existing HSR iplink command

Re: [net-next iproute2 PATCH v3 1/2] iplink: hsr: add support for creating PRP device similar to HSR

2020-08-04 Thread Murali Karicheri
All, On 7/30/20 9:47 AM, Murali Karicheri wrote: Hi Dave, On 7/17/20 11:22 AM, Murali Karicheri wrote: This patch enhances the iplink command to add a proto parameters to create PRP device/interface similar to HSR. Both protocols are quite similar and requires a pair of Ethernet interfaces

Re: [net-next v5 PATCH 0/7] Add PRP driver

2020-08-04 Thread Murali Karicheri
Hi Dave, On 7/30/20 9:41 AM, Murali Karicheri wrote: Hi Dave, On 7/27/20 3:21 PM, David Miller wrote: From: Murali Karicheri Date: Wed, 22 Jul 2020 10:40:15 -0400 This series is dependent on the following patches sent out to netdev list. All (1-3) are already merged to net/master

Re: [net-next iproute2 PATCH v3 1/2] iplink: hsr: add support for creating PRP device similar to HSR

2020-07-30 Thread Murali Karicheri
Hi Dave, On 7/17/20 11:22 AM, Murali Karicheri wrote: This patch enhances the iplink command to add a proto parameters to create PRP device/interface similar to HSR. Both protocols are quite similar and requires a pair of Ethernet interfaces. So re-use the existing HSR iplink command to create

Re: [net-next v5 PATCH 0/7] Add PRP driver

2020-07-30 Thread Murali Karicheri
Hi Dave, On 7/27/20 3:21 PM, David Miller wrote: From: Murali Karicheri Date: Wed, 22 Jul 2020 10:40:15 -0400 This series is dependent on the following patches sent out to netdev list. All (1-3) are already merged to net/master as of sending this, but not on the net-next master branch. So

Re: [net-next v5 PATCH 0/7] Add PRP driver

2020-07-27 Thread Murali Karicheri
Dave, On 7/24/20 6:21 PM, David Miller wrote: From: Murali Karicheri Date: Fri, 24 Jul 2020 08:27:01 -0400 If there are no more comments, can we consider merging this to net-next? I could re-base and repost if there is any conflict. I can't apply them until I next merge net into net-next

Re: [net-next v5 PATCH 0/7] Add PRP driver

2020-07-24 Thread Murali Karicheri
Hi Dave, On 7/22/20 10:40 AM, Murali Karicheri wrote: Hello, This series is dependent on the following patches sent out to netdev list. All (1-3) are already merged to net/master as of sending this, but not on the net-next master branch. So need to apply them to net-next before applying

[net-next v5 PATCH 2/7] net: hsr: introduce common code for skb initialization

2020-07-22 Thread Murali Karicheri
As a preparatory patch to introduce PRP protocol support in the driver, refactor the skb init code to a separate function. Signed-off-by: Murali Karicheri --- net/hsr/hsr_device.c | 41 - 1 file changed, 28 insertions(+), 13 deletions(-) diff --git a/net

[net-next v5 PATCH 7/7] net: prp: enhance debugfs to display PRP info

2020-07-22 Thread Murali Karicheri
Print PRP specific information from node table as part of debugfs node table display. Also display the node as DAN-H or DAN-P depending on the info from node table. Signed-off-by: Murali Karicheri --- net/hsr/hsr_debugfs.c | 31 ++- 1 file changed, 22 insertions

[net-next v5 PATCH 4/7] net: prp: add supervision frame generation utility function

2020-07-22 Thread Murali Karicheri
used for PRP supervision frame. Signed-off-by: Murali Karicheri --- net/hsr/hsr_device.c | 64 ++- net/hsr/hsr_forward.c | 4 ++- net/hsr/hsr_main.h| 22 +++ 3 files changed, 88 insertions(+), 2 deletions(-) diff --git a/net/hsr

[net-next v5 PATCH 3/7] net: hsr: introduce protocol specific function pointers

2020-07-22 Thread Murali Karicheri
nce() to call proto_ops->send_sv_frame(). Signed-off-by: Murali Karicheri --- net/hsr/hsr_device.c | 70 net/hsr/hsr_main.h | 6 2 files changed, 45 insertions(+), 31 deletions(-) diff --git a/net/hsr/hsr_device.c b/net/hsr/hsr_device.c

[net-next v5 PATCH 5/7] net: hsr: define and use proto_ops ptrs to handle hsr specific frames

2020-07-22 Thread Murali Karicheri
As a preparatory patch to introduce PRP, refactor the code specific to handling HSR frames into separate functions and call them through proto_ops function pointers. Signed-off-by: Murali Karicheri --- net/hsr/hsr_device.c | 5 +++- net/hsr/hsr_forward.c | 63

[net-next v5 PATCH 0/7] Add PRP driver

2020-07-22 Thread Murali Karicheri
: initial version posted and discussed at https://www.spinics.net/lists/netdev/msg656229.html Murali Karicheri (7): hsr: enhance netlink socket interface to support PRP net: hsr: introduce common code for skb initialization net: hsr: introduce protocol specific function pointers net:

[net-next v5 PATCH 1/7] hsr: enhance netlink socket interface to support PRP

2020-07-22 Thread Murali Karicheri
to explicitly state that the driver files also handles PRP protocol as well. Signed-off-by: Murali Karicheri --- include/uapi/linux/hsr_netlink.h | 2 +- include/uapi/linux/if_link.h | 12 +- net/hsr/Kconfig | 35 +++-- net/hsr/hsr_debugfs.c

[net-next v5 PATCH 6/7] net: prp: add packet handling support

2020-07-22 Thread Murali Karicheri
-off-by: Murali Karicheri --- net/hsr/hsr_device.c | 20 ++- net/hsr/hsr_forward.c | 272 - net/hsr/hsr_forward.h | 7 ++ net/hsr/hsr_framereg.c | 94 +++--- net/hsr/hsr_framereg.h | 29 - net/hsr/hsr_main.h | 73 ++- net/hsr

Re: [net-next v4 PATCH 1/7] hsr: enhance netlink socket interface to support PRP

2020-07-22 Thread Murali Karicheri
Hi Randy On 7/20/20 2:37 PM, Randy Dunlap wrote: On 7/20/20 9:57 AM, Murali Karicheri wrote: diff --git a/net/hsr/Kconfig b/net/hsr/Kconfig index 8095b034e76e..e2e396870230 100644 --- a/net/hsr/Kconfig +++ b/net/hsr/Kconfig @@ -4,24 +4,35 @@ # config HSR - tristate "

[net-next v4 PATCH 6/7] net: prp: add packet handling support

2020-07-20 Thread Murali Karicheri
-off-by: Murali Karicheri --- net/hsr/hsr_device.c | 20 ++- net/hsr/hsr_forward.c | 273 - net/hsr/hsr_forward.h | 7 ++ net/hsr/hsr_framereg.c | 94 +++--- net/hsr/hsr_framereg.h | 29 - net/hsr/hsr_main.h | 73 ++- net/hsr

[net-next v4 PATCH 4/7] net: prp: add supervision frame generation utility function

2020-07-20 Thread Murali Karicheri
used for PRP supervision frame. Signed-off-by: Murali Karicheri --- net/hsr/hsr_device.c | 64 ++- net/hsr/hsr_forward.c | 4 ++- net/hsr/hsr_main.h| 22 +++ 3 files changed, 88 insertions(+), 2 deletions(-) diff --git a/net/hsr

[net-next v4 PATCH 1/7] hsr: enhance netlink socket interface to support PRP

2020-07-20 Thread Murali Karicheri
to explicitly state that the driver files also handles PRP protocol as well. Signed-off-by: Murali Karicheri --- include/uapi/linux/hsr_netlink.h | 2 +- include/uapi/linux/if_link.h | 12 +- net/hsr/Kconfig | 37 --- net/hsr/hsr_debugfs.c

[net-next v4 PATCH 5/7] net: hsr: define and use proto_ops ptrs to handle hsr specific frames

2020-07-20 Thread Murali Karicheri
As a preparatory patch to introduce PRP, refactor the code specific to handling HSR frames into separate functions and call them through proto_ops function pointers. Signed-off-by: Murali Karicheri --- net/hsr/hsr_device.c | 5 +++- net/hsr/hsr_forward.c | 63

[net-next v4 PATCH 7/7] net: prp: enhance debugfs to display PRP info

2020-07-20 Thread Murali Karicheri
Print PRP specific information from node table as part of debugfs node table display. Also display the node as DAN-H or DAN-P depending on the info from node table. Signed-off-by: Murali Karicheri --- net/hsr/hsr_debugfs.c | 31 ++- 1 file changed, 22 insertions

[net-next v4 PATCH 3/7] net: hsr: introduce protocol specific function pointers

2020-07-20 Thread Murali Karicheri
nce() to call proto_ops->send_sv_frame(). Signed-off-by: Murali Karicheri --- net/hsr/hsr_device.c | 70 net/hsr/hsr_main.h | 6 2 files changed, 45 insertions(+), 31 deletions(-) diff --git a/net/hsr/hsr_device.c b/net/hsr/hsr_device.c

[net-next v4 PATCH 0/7] Add PRP driver

2020-07-20 Thread Murali Karicheri
ket interface with an added parameter proto for identifying PRP. - Use function pointers using a proto_ops struct to do things differently for PRP vs HSR. RFC: initial version posted and discussed at https://www.spinics.net/lists/netdev/msg656229.html Murali

[net-next v4 PATCH 2/7] net: hsr: introduce common code for skb initialization

2020-07-20 Thread Murali Karicheri
As a preparatory patch to introduce PRP protocol support in the driver, refactor the skb init code to a separate function. Signed-off-by: Murali Karicheri --- net/hsr/hsr_device.c | 41 - 1 file changed, 28 insertions(+), 13 deletions(-) diff --git a/net

[PATCH] net: hsr: check for return value of skb_put_padto()

2020-07-20 Thread Murali Karicheri
skb_put_padto() can fail. So check for return type and return NULL for skb. Caller checks for skb and acts correctly if it is NULL. Fixes: 6d6148bc78d2 ("net: hsr: fix incorrect lsdu size in the tag of HSR frames for small frames") Signed-off-by: Murali Karicheri --- net/hsr/hsr

Re: [PATCH 1/2 v2] net: hsr: fix incorrect lsdu size in the tag of HSR frames for small frames

2020-07-20 Thread Murali Karicheri
Hi Grygoii, On 7/20/20 10:08 AM, Murali Karicheri wrote: Grygorii, On 7/17/20 1:39 PM, Grygorii Strashko wrote: On 17/07/2020 17:55, Murali Karicheri wrote: For small Ethernet frames with size less than minimum size 66 for HSR vs 60 for regular Ethernet frames, hsr driver currently doesn't

Re: [PATCH 1/2 v2] net: hsr: fix incorrect lsdu size in the tag of HSR frames for small frames

2020-07-20 Thread Murali Karicheri
Grygorii, On 7/17/20 1:39 PM, Grygorii Strashko wrote: On 17/07/2020 17:55, Murali Karicheri wrote: For small Ethernet frames with size less than minimum size 66 for HSR vs 60 for regular Ethernet frames, hsr driver currently doesn't pad the frame to make it minimum size. This results

Re: [net-next PATCH v3 2/7] net: hsr: introduce common code for skb initialization

2020-07-20 Thread Murali Karicheri
On 7/17/20 9:56 PM, David Miller wrote: From: Murali Karicheri Date: Fri, 17 Jul 2020 11:15:06 -0400 +static void send_hsr_supervision_frame(struct hsr_port *master, + u8 type, u8 hsr_ver) +{ + struct sk_buff *skb; + struct hsr_tag *hsr_tag

Re: [net-next PATCH v3 1/7] hsr: enhance netlink socket interface to support PRP

2020-07-20 Thread Murali Karicheri
On 7/17/20 9:56 PM, David Miller wrote: From: Murali Karicheri Date: Fri, 17 Jul 2020 11:15:05 -0400 @@ -32,7 +33,9 @@ static int hsr_newlink(struct net *src_net, struct net_device *dev, struct netlink_ext_ack *extack) { struct net_device *link[2

[net-next iproute2 PATCH v3 2/2] ip: iplink: prp: update man page for new parameter

2020-07-17 Thread Murali Karicheri
PRP support requires a proto parameter which is 0 for hsr and 1 for prp. Default is hsr and is backward compatible. Signed-off-by: Murali Karicheri --- dependent on the series "[net-next PATCH v3 0/7] Add PRP driver" man/man8/ip-link.8.in | 9 - 1 file changed, 8 insert

[net-next iproute2 PATCH v3 1/2] iplink: hsr: add support for creating PRP device similar to HSR

2020-07-17 Thread Murali Karicheri
to differentiate the two protocols. Signed-off-by: Murali Karicheri --- dependent on the series "[net-next PATCH v3 0/7] Add PRP driver" include/uapi/linux/if_link.h | 12 +++- ip/iplink_hsr.c | 19 +-- 2 files changed, 28 insertions(+), 3 deletions(-)

[net-next PATCH v3 7/7] net: prp: enhance debugfs to display PRP info

2020-07-17 Thread Murali Karicheri
Print PRP specific information from node table as part of debugfs node table display. Also display the node as DAN-H or DAN-P depending on the info from node table. Signed-off-by: Murali Karicheri --- net/hsr/hsr_debugfs.c | 31 ++- 1 file changed, 22 insertions

[net-next PATCH v3 4/7] net: prp: add supervision frame generation utility function

2020-07-17 Thread Murali Karicheri
used for PRP supervision frame. Signed-off-by: Murali Karicheri --- net/hsr/hsr_device.c | 64 ++- net/hsr/hsr_forward.c | 4 ++- net/hsr/hsr_main.h| 22 +++ 3 files changed, 88 insertions(+), 2 deletions(-) diff --git a/net/hsr

[net-next PATCH v3 1/7] hsr: enhance netlink socket interface to support PRP

2020-07-17 Thread Murali Karicheri
to explicitly state that the driver files also handles PRP protocol as well. Signed-off-by: Murali Karicheri --- include/uapi/linux/hsr_netlink.h | 2 +- include/uapi/linux/if_link.h | 12 +- net/hsr/Kconfig | 37 --- net/hsr/hsr_debugfs.c

[net-next PATCH v3 2/7] net: hsr: introduce common code for skb initialization

2020-07-17 Thread Murali Karicheri
As a preparatory patch to introduce PRP protocol support in the driver, refactor the skb init code to a separate function. Signed-off-by: Murali Karicheri --- net/hsr/hsr_device.c | 41 - 1 file changed, 28 insertions(+), 13 deletions(-) diff --git a/net

[net-next PATCH v3 5/7] net: hsr: define and use proto_ops ptrs to handle hsr specific frames

2020-07-17 Thread Murali Karicheri
As a preparatory patch to introduce PRP, refactor the code specific to handling HSR frames into separate functions and call them through proto_ops function pointers. Signed-off-by: Murali Karicheri --- net/hsr/hsr_device.c | 5 +++- net/hsr/hsr_forward.c | 63

[net-next PATCH v3 6/7] net: prp: add packet handling support

2020-07-17 Thread Murali Karicheri
-off-by: Murali Karicheri --- net/hsr/hsr_device.c | 20 ++- net/hsr/hsr_forward.c | 268 - net/hsr/hsr_forward.h | 7 ++ net/hsr/hsr_framereg.c | 94 --- net/hsr/hsr_framereg.h | 29 - net/hsr/hsr_main.h | 73 ++- net/hsr

[net-next PATCH v3 3/7] net: hsr: introduce protocol specific function pointers

2020-07-17 Thread Murali Karicheri
nce() to call proto_ops->send_sv_frame(). Signed-off-by: Murali Karicheri --- net/hsr/hsr_device.c | 74 net/hsr/hsr_main.h | 6 2 files changed, 47 insertions(+), 33 deletions(-) diff --git a/net/hsr/hsr_device.c b/net/hsr/hsr_device.c

[net-next PATCH v3 0/7] Add PRP driver

2020-07-17 Thread Murali Karicheri
y for PRP vs HSR. RFC: initial version posted and discussed at https://www.spinics.net/lists/netdev/msg656229.html Murali Karicheri (7): hsr: enhance netlink socket interface to support PRP net: hsr: introduce common code for skb initialization net: hsr: introduce protocol

[PATCH 1/2 v2] net: hsr: fix incorrect lsdu size in the tag of HSR frames for small frames

2020-07-17 Thread Murali Karicheri
to the minimum size applicable for HSR. Signed-off-by: Murali Karicheri --- no change from original version Sending this bug fix ahead of PRP patch series as per comment net/hsr/hsr_forward.c | 3 +++ 1 file changed, 3 insertions(+) Sending this bug fix ahead of PRP patch series as per comment diff

[PATCH 2/2 v2] net: hsr: validate address B before copying to skb

2020-07-17 Thread Murali Karicheri
Validate MAC address before copying the same to outgoing frame skb destination address. Since a node can have zero mac address for Link B until a valid frame is received over that link, this fix address the issue of a zero MAC address being in the packet. Signed-off-by: Murali Karicheri

[PATCH 1/2] net: hsr: fix incorrect lsdu size in the tag of HSR frames for small frames

2020-07-17 Thread Murali Karicheri
to the minimum size applicable for HSR. Signed-off-by: Murali Karicheri --- Sending this bug fix ahead of PRP patch series as per comment net/hsr/hsr_forward.c | 3 +++ 1 file changed, 3 insertions(+) Sending this bug fix ahead of PRP patch series as per comment diff --git a/net/hsr/hsr_forward.c b/net

[PATCH 2/2] net: hsr/prp: validate address B before copying to skb

2020-07-17 Thread Murali Karicheri
Validate MAC address before copying the same to outgoing frame skb destination address. Since a node can have zero mac address for Link B until a valid frame is received over that link, this fix address the issue of a zero MAC address being in the packet. Signed-off-by: Murali Karicheri

Re: [net-next PATCH v2 0/9] Add PRP driver and bug fixes

2020-07-17 Thread Murali Karicheri
, and add appropriate Fixes tags? Sure thing. I will send out the first two so that it gets merged. Spin v3 without it so that it can go to net/next. Wondering if you would be able to test PRP? Any other volunteers? Thanks. -- Murali Karicheri Texas Instruments

[net-next PATCH v2 0/9] Add PRP driver and bug fixes

2020-07-15 Thread Murali Karicheri
y for PRP vs HSR. RFC: initial version posted and discussed at https://www.spinics.net/lists/netdev/msg656229.html Murali Karicheri (9): net: hsr: fix incorrect lsdu size in the tag of HSR frames for small frames net: hsr/prp: validate address B before copying to skb hsr

[net-next PATCH v2 2/9] net: hsr/prp: validate address B before copying to skb

2020-07-15 Thread Murali Karicheri
Validate MAC address before copying the same to outgoing frame skb destination address. Signed-off-by: Murali Karicheri Reviewed-by: Grygorii Strashko --- net/hsr/hsr_framereg.c | 5 - 1 file changed, 4 insertions(+), 1 deletion(-) diff --git a/net/hsr/hsr_framereg.c b/net/hsr

[net-next PATCH v2 9/9] net: prp: enhance debugfs to display PRP info

2020-07-15 Thread Murali Karicheri
Print PRP specific information from node table as part of debugfs node table display. Also display the node as DAN-H or DAN-P depending on the info from node table. Signed-off-by: Murali Karicheri --- net/hsr/hsr_debugfs.c | 31 ++- 1 file changed, 22 insertions

[net-next PATCH v2 3/9] hsr: enhance netlink socket interface to support PRP

2020-07-15 Thread Murali Karicheri
to explicitly state that the driver files also handles PRP protocol as well. Signed-off-by: Murali Karicheri --- include/uapi/linux/hsr_netlink.h | 2 +- include/uapi/linux/if_link.h | 12 +- net/hsr/Kconfig | 37 --- net/hsr/hsr_debugfs.c

[net-next PATCH v2 5/9] net: hsr: introduce protocol specific function pointers

2020-07-15 Thread Murali Karicheri
nce() to call proto_ops->send_sv_frame(). Signed-off-by: Murali Karicheri --- net/hsr/hsr_device.c | 74 net/hsr/hsr_main.h | 6 2 files changed, 47 insertions(+), 33 deletions(-) diff --git a/net/hsr/hsr_device.c b/net/hsr/hsr_device.c

[net-next iproute2 PATCH v2 2/2] ip: iplink: prp: update man page for new parameter

2020-07-15 Thread Murali Karicheri
PRP support requires a proto parameter which is 0 for hsr and 1 for prp. Default is hsr and is backward compatible. Signed-off-by: Murali Karicheri --- man/man8/ip-link.8.in | 9 - 1 file changed, 8 insertions(+), 1 deletion(-) diff --git a/man/man8/ip-link.8.in b/man/man8/ip-link.8

[net-next PATCH v2 6/9] net: prp: add supervision frame generation utility function

2020-07-15 Thread Murali Karicheri
used for PRP supervision frame. Signed-off-by: Murali Karicheri --- net/hsr/hsr_device.c | 64 ++- net/hsr/hsr_forward.c | 4 ++- net/hsr/hsr_main.h| 22 +++ 3 files changed, 88 insertions(+), 2 deletions(-) diff --git a/net/hsr

[net-next PATCH v2 7/9] net: hsr: define and use proto_ops ptrs to handle hsr specific frames

2020-07-15 Thread Murali Karicheri
As a preparatory patch to introduce PRP, refactor the code specific to handling HSR frames into separate functions and call them through proto_ops function pointers. Signed-off-by: Murali Karicheri --- net/hsr/hsr_device.c | 5 +++- net/hsr/hsr_forward.c | 63

[net-next PATCH v2 8/9] net: prp: add packet handling support

2020-07-15 Thread Murali Karicheri
-off-by: Murali Karicheri --- net/hsr/hsr_device.c | 20 ++- net/hsr/hsr_forward.c | 268 - net/hsr/hsr_forward.h | 7 ++ net/hsr/hsr_framereg.c | 94 --- net/hsr/hsr_framereg.h | 29 - net/hsr/hsr_main.h | 73 ++- net/hsr

[net-next iproute2 PATCH v2 1/2] iplink: hsr: add support for creating PRP device similar to HSR

2020-07-15 Thread Murali Karicheri
to differentiate the two protocols. Signed-off-by: Murali Karicheri --- include/uapi/linux/if_link.h | 12 +++- ip/iplink_hsr.c | 19 +-- 2 files changed, 28 insertions(+), 3 deletions(-) diff --git a/include/uapi/linux/if_link.h b/include/uapi/linux/if_link.h index

[net-next PATCH v2 1/9] net: hsr: fix incorrect lsdu size in the tag of HSR frames for small frames

2020-07-15 Thread Murali Karicheri
to the minimum size applicable for HSR. Signed-off-by: Murali Karicheri Reviewed-by: Grygorii Strashko --- net/hsr/hsr_forward.c | 3 +++ 1 file changed, 3 insertions(+) diff --git a/net/hsr/hsr_forward.c b/net/hsr/hsr_forward.c index ed13760463de..e42fd356f073 100644 --- a/net/hsr/hsr_forward.c +++ b

[net-next PATCH v2 4/9] net: hsr: introduce common code for skb initialization

2020-07-15 Thread Murali Karicheri
As a preparatory patch to introduce PRP protocol support in the driver, refactor the skb init code to a separate function. Signed-off-by: Murali Karicheri --- net/hsr/hsr_device.c | 41 - 1 file changed, 28 insertions(+), 13 deletions(-) diff --git a/net

Re: [net-next RFC PATCH 00/13] net: hsr: Add PRP driver

2020-05-26 Thread Murali Karicheri
Hi Vinicius, On 5/26/20 2:56 PM, Vinicius Costa Gomes wrote: Murali Karicheri writes: Hi Vinicius, On 5/21/20 1:31 PM, Vinicius Costa Gomes wrote: Murali Karicheri writes: Snip- So, I see this as different methods of achieving the same result, which makes me

Re: [net-next RFC PATCH 00/13] net: hsr: Add PRP driver

2020-05-26 Thread Murali Karicheri
Hi Vladimir On 5/26/20 2:25 PM, Vladimir Oltean wrote: Hi Murali, On Tue, 26 May 2020 at 17:12, Murali Karicheri wrote: Hi Vladimir, I haven't looked the spec for 802.1CB. If they re-use HSR/PRP Tag in the L2 protocol it make sense to enhance the driver. Else I don't see any re-use

Re: [net-next RFC PATCH 00/13] net: hsr: Add PRP driver

2020-05-26 Thread Murali Karicheri
Hi Vladimir, On 5/25/20 5:37 PM, Vladimir Oltean wrote: Hi Vinicius, On Thu, 21 May 2020 at 20:33, Vinicius Costa Gomes wrote: Murali Karicheri writes: This RFC series add support for Parallel Redundancy Protocol (PRP) as defined in IEC-62439-3 in the kernel networking subsystem. PRP

Re: [net-next RFC PATCH 00/13] net: hsr: Add PRP driver

2020-05-25 Thread Murali Karicheri
Hi Vinicius, On 5/21/20 1:31 PM, Vinicius Costa Gomes wrote: Murali Karicheri writes: Snip- - prefix all common code with hsr_prp - net/hsr -> renamed to net/hsr-prp - All common struct types, constants, functions renamed with hsr{HSR}_prp{PRP} pre

Re: [net-next RFC PATCH 00/13] net: hsr: Add PRP driver

2020-05-21 Thread Murali Karicheri
Hi David, et all, On 5/13/20 8:27 AM, Murali Karicheri wrote: Hello netdev experts, On 5/6/20 12:30 PM, Murali Karicheri wrote: This RFC series add support for Parallel Redundancy Protocol (PRP) as defined in IEC-62439-3 in the kernel networking subsystem. PRP Uses a Redundancy Control

Re: [EXT] Re: [v1,net-next, 1/2] ethtool: add setting frame preemption of traffic classes

2020-05-13 Thread Murali Karicheri
Hi Vinicius, On 3/18/20 10:07 AM, Murali Karicheri wrote: Hi Vinicius, On 03/12/2020 07:34 PM, Vinicius Costa Gomes wrote: Hi, Po Liu writes: Hi Vinicius, Br, Po Liu -Original Message- From: Vinicius Costa Gomes Sent: 2020年2月22日 5:44 To: Po Liu ; da...@davemloft.net

[PATCH net-next 1/2] ethernet: ti: am65-cpts: add routines to support taprio offload

2020-05-13 Thread Murali Karicheri
update is needed or to get actual state of oper/admin schedule. Signed-off-by: Ivan Khoronzhuk Signed-off-by: Murali Karicheri --- drivers/net/ethernet/ti/am65-cpts.c | 48 + drivers/net/ethernet/ti/am65-cpts.h | 24 +++ 2 files changed, 72 insertions(+) diff

[PATCH net-next 2/2] ethernet: ti: am65-cpsw-qos: add TAPRIO offload support

2020-05-13 Thread Murali Karicheri
an Khoronzhuk Signed-off-by: Murali Karicheri --- drivers/net/ethernet/ti/Kconfig | 9 + drivers/net/ethernet/ti/Makefile| 2 +- drivers/net/ethernet/ti/am65-cpsw-ethtool.c | 12 +- drivers/net/ethernet/ti/am65-cpsw-nuss.c| 9 + drivers/net/ethernet/ti/am6

[PATCH net-next 0/2] am65-cpsw: add taprio/EST offload support

2020-05-13 Thread Murali Karicheri
AM65 CPSW h/w supports Enhanced Scheduled Traffic (EST – defined in P802.1Qbv/D2.2 that later got included in IEEE 802.1Q-2018) configuration. EST allows express queue traffic to be scheduled (placed) on the wire at specific repeatable time intervals. In Linux kernel, EST configuration is done

Re: [net-next RFC PATCH 00/13] net: hsr: Add PRP driver

2020-05-13 Thread Murali Karicheri
Hello netdev experts, On 5/6/20 12:30 PM, Murali Karicheri wrote: This RFC series add support for Parallel Redundancy Protocol (PRP) as defined in IEC-62439-3 in the kernel networking subsystem. PRP Uses a Redundancy Control Trailer (RCT) the format of which is similar to HSR Tag. This is used

Re: [net PATCH v2] net: hsr: fix incorrect type usage for protocol variable

2020-05-07 Thread Murali Karicheri
Hi David, On 5/6/20 5:31 PM, Murali Karicheri wrote: Fix following sparse checker warning:- net/hsr/hsr_slave.c:38:18: warning: incorrect type in assignment (different base types) net/hsr/hsr_slave.c:38:18:expected unsigned short [unsigned] [usertype] protocol net/hsr/hsr_slave.c:38:18

[net PATCH v2] net: hsr: fix incorrect type usage for protocol variable

2020-05-06 Thread Murali Karicheri
/hsr_slave.c:39:25: warning: restricted __be16 degrades to integer net/hsr/hsr_slave.c:39:57: warning: restricted __be16 degrades to integer Signed-off-by: Murali Karicheri Acked-by: Vinicius Costa Gomes --- v2 : Added Acked-by from Vinicius Costa Gomes net/hsr/hsr_slave.c | 2 +- 1 file changed, 1

Re: [net-next PATCH] net: hsr: fix incorrect type usage for protocol variable

2020-05-06 Thread Murali Karicheri
Hi Vinicius, On 5/6/20 1:33 PM, Vinicius Costa Gomes wrote: Hi Murali, Murali Karicheri writes: Fix following sparse checker warning:- net/hsr/hsr_slave.c:38:18: warning: incorrect type in assignment (different base types) net/hsr/hsr_slave.c:38:18:expected unsigned short [unsigned

[net-next RFC PATCH 0/2] iproute2: Add PRP support

2020-05-06 Thread Murali Karicheri
This is the RFC patch series to add prp link type in iproute2. This is dependent on the kernel patch series with subject line "[net-next RFC PATCH 00/13] net: hsr: Add PRP driver Murali Karicheri (2): add support for PRP similar to HSR prp: update man page for PRP include/uapi/

[net-next RFC PATCH 1/2] add support for PRP similar to HSR

2020-05-06 Thread Murali Karicheri
duplication and use a unified netlink interface for both HSR and PRP Signed-off-by: Murali Karicheri --- include/uapi/linux/if_link.h | 16 - ip/Makefile | 5 +- ip/iplink_hsr.c | 111 +++--- ip/iplink_hsr_prp_common.c | 114

[net-next RFC PATCH 2/2] prp: update man page for PRP

2020-05-06 Thread Murali Karicheri
This update man page for PRP support Signed-off-by: Murali Karicheri --- man/man8/ip-link.8.in | 29 + 1 file changed, 29 insertions(+) diff --git a/man/man8/ip-link.8.in b/man/man8/ip-link.8.in index 939e2ad49f4e..56d95a79eac5 100644 --- a/man/man8/ip-link.8

  1   2   3   4   5   6   7   8   9   10   >