Re: [PATCH v4 0/2] ARM: Add Rockchip rk3288w support

Hello Heiko, On 6/17/20 10:58 AM, Heiko Stuebner wrote: On Tue, 2 Jun 2020 10:06:42 +0200, Mylène Josserand wrote: Context --- Here is my V4 of my patches that add the support for the Rockchip RK3288w which is a revision of the RK3288. It is mostly the same SOC except for, at least, one

Re: [PATCH v3 1/1] clk: rockchip: rk3288: Handle clock tree for rk3288w

Hi Heiko, Thank you very much for your quick review! On 6/1/20 10:09 PM, Heiko Stübner wrote: Hi Mylène, Am Montag, 1. Juni 2020, 17:14:42 CEST schrieb Mylène Josserand: The revision rk3288w has a different clock tree about "hclk_vio" clock, according to the BSP kernel code. This patch

Re: [PATCH v2 1/2] Input: edt-ft5x06 - Add support for regulator

Hello Dmitry, Le Tue, 23 Jan 2018 09:58:29 -0800, Dmitry Torokhov <dmitry.torok...@gmail.com> a écrit : > On Tue, Jan 23, 2018 at 10:10:55AM +0100, Mylene Josserand wrote: > > Hello Dimitry, > > > > Thank you for the review! > > > > Le Mon, 22 Jan 2

Re: [PATCH v2 1/2] Input: edt-ft5x06 - Add support for regulator

Hello Dmitry, Le Tue, 23 Jan 2018 09:58:29 -0800, Dmitry Torokhov a écrit : > On Tue, Jan 23, 2018 at 10:10:55AM +0100, Mylene Josserand wrote: > > Hello Dimitry, > > > > Thank you for the review! > > > > Le Mon, 22 Jan 2018 09:42:08 -0800, > > Dmi

Re: [PATCH v4 1/2] Input: Add driver for Cypress Generation 5 touchscreen

Hi Dmitry, Thank you for the review. Le Mon, 22 Jan 2018 20:15:03 -0800, Dmitry Torokhov a écrit : > Hi Mylène, > > On Fri, Dec 01, 2017 at 04:39:56PM +0100, Mylène Josserand wrote: > > This is the basic driver for the Cypress TrueTouch Gen5 touchscreen > >

Re: [PATCH v4 1/2] Input: Add driver for Cypress Generation 5 touchscreen

Hi Dmitry, Thank you for the review. Le Mon, 22 Jan 2018 20:15:03 -0800, Dmitry Torokhov a écrit : > Hi Mylène, > > On Fri, Dec 01, 2017 at 04:39:56PM +0100, Mylène Josserand wrote: > > This is the basic driver for the Cypress TrueTouch Gen5 touchscreen > > controllers. This driver supports

Re: [PATCH v4 1/2] Input: Add driver for Cypress Generation 5 touchscreen

Hello Marcus, Thank you for the review. Le Mon, 22 Jan 2018 21:11:09 +0100, Marcus Folkesson a écrit : > Mylene, > > On Fri, Dec 01, 2017 at 04:39:56PM +0100, Mylène Josserand wrote: > > +++ b/drivers/input/touchscreen/cyttsp5.c > > @@ -0,0 +1,1110 @@ > > +/* > > +

Re: [PATCH v4 1/2] Input: Add driver for Cypress Generation 5 touchscreen

Hello Marcus, Thank you for the review. Le Mon, 22 Jan 2018 21:11:09 +0100, Marcus Folkesson a écrit : > Mylene, > > On Fri, Dec 01, 2017 at 04:39:56PM +0100, Mylène Josserand wrote: > > +++ b/drivers/input/touchscreen/cyttsp5.c > > @@ -0,0 +1,1110 @@ > > +/* > > + * Parade TrueTouch(TM)

Re: [PATCH v2 1/2] Input: edt-ft5x06 - Add support for regulator

Hello Lothar, Le Tue, 23 Jan 2018 09:04:14 +0100, Lothar Waßmann a écrit : > Hi, > > On Mon, 22 Jan 2018 09:42:08 -0800 Dmitry Torokhov wrote: > > Hi Mylène, > > > > On Thu, Dec 28, 2017 at 8:33 AM, Mylène Josserand > > wrote:

Re: [PATCH v2 1/2] Input: edt-ft5x06 - Add support for regulator

Hello Lothar, Le Tue, 23 Jan 2018 09:04:14 +0100, Lothar Waßmann a écrit : > Hi, > > On Mon, 22 Jan 2018 09:42:08 -0800 Dmitry Torokhov wrote: > > Hi Mylène, > > > > On Thu, Dec 28, 2017 at 8:33 AM, Mylène Josserand > > wrote: > > > Add the support of regulator to use it as VCC source. > >

Re: [PATCH v2 1/2] Input: edt-ft5x06 - Add support for regulator

Hello Dimitry, Thank you for the review! Le Mon, 22 Jan 2018 09:42:08 -0800, Dmitry Torokhov a écrit : > Hi Mylène, > > On Thu, Dec 28, 2017 at 8:33 AM, Mylène Josserand > wrote: > > Add the support of regulator to use it as VCC

Re: [PATCH v2 1/2] Input: edt-ft5x06 - Add support for regulator

Hello Dimitry, Thank you for the review! Le Mon, 22 Jan 2018 09:42:08 -0800, Dmitry Torokhov a écrit : > Hi Mylène, > > On Thu, Dec 28, 2017 at 8:33 AM, Mylène Josserand > wrote: > > Add the support of regulator to use it as VCC source. > > > > Signed-off-by: Mylène Josserand > > --- > >

Re: [PATCH v2 0/5] Sunxi: Add SMP support on A83T

Hello, Le Fri, 29 Dec 2017 11:55:01 +0100, Mylène Josserand a écrit : > Hello everyone, > > This is a V2 of my series that adds SMP support for Allwinner sun8i-a83t > with MCPM (Multi-Cluster Power Management). > Based on last linux-next (next-20171222). >

Re: [PATCH v2 0/5] Sunxi: Add SMP support on A83T

Hello, Le Fri, 29 Dec 2017 11:55:01 +0100, Mylène Josserand a écrit : > Hello everyone, > > This is a V2 of my series that adds SMP support for Allwinner sun8i-a83t > with MCPM (Multi-Cluster Power Management). > Based on last linux-next (next-20171222). > > Changes since v1: > - Add Chen

Re: [PATCH 0/4] Sunxi: Add SMP support on A83T

Hello Corentin, Le Thu, 28 Dec 2017 21:31:25 +0100, Corentin Labbe a écrit : [...] > Hello > > With the .config that you give me in private, everything seems to work. > But with mine, the stacktrace still happen. > After some research, this is due to the following

Re: [PATCH 0/4] Sunxi: Add SMP support on A83T

Hello Corentin, Le Thu, 28 Dec 2017 21:31:25 +0100, Corentin Labbe a écrit : [...] > Hello > > With the .config that you give me in private, everything seems to work. > But with mine, the stacktrace still happen. > After some research, this is due to the following code: >

Re: [PATCH v2 0/2] sun8i-a83t: Add touchscreen support on TBS A711

Hello, Le Thu, 28 Dec 2017 17:33:34 +0100, Mylène Josserand a écrit : > Hello everyone, > > This is a V2 of the patch series that adds touchscreen support > (FocalTech EDT-FT5x06 Polytouch) for TBS A711 (Allwinner sun8i-a83t SoC). > Based on last linux-next

Re: [PATCH v2 0/2] sun8i-a83t: Add touchscreen support on TBS A711

Hello, Le Thu, 28 Dec 2017 17:33:34 +0100, Mylène Josserand a écrit : > Hello everyone, > > This is a V2 of the patch series that adds touchscreen support > (FocalTech EDT-FT5x06 Polytouch) for TBS A711 (Allwinner sun8i-a83t SoC). > Based on last linux-next (next-20171222). > > Changes since

Re: [PATCH 0/4] Sunxi: Add SMP support on A83T

Hello Corentin, Le Fri, 15 Dec 2017 07:10:46 +0100, Corentin Labbe a écrit : > On Tue, Dec 12, 2017 at 09:24:25AM +0100, Maxime Ripard wrote: > > Hi, > > > > On Mon, Dec 11, 2017 at 08:35:34PM +0100, Corentin Labbe wrote: > > > On Mon, Dec 11, 2017 at 08:49:57AM

Re: [PATCH 0/4] Sunxi: Add SMP support on A83T

Hello Corentin, Le Fri, 15 Dec 2017 07:10:46 +0100, Corentin Labbe a écrit : > On Tue, Dec 12, 2017 at 09:24:25AM +0100, Maxime Ripard wrote: > > Hi, > > > > On Mon, Dec 11, 2017 at 08:35:34PM +0100, Corentin Labbe wrote: > > > On Mon, Dec 11, 2017 at 08:49:57AM +0100, Mylène Josserand wrote:

Re: [PATCH] pinctrl: axp209: dereference pointer after it's been set

Hello Quentin, Le Wed, 13 Dec 2017 09:55:03 +0100, Quentin Schulz a écrit : > The number of GPIOs is gotten from a field within the structure > referenced in the of_device.data but it was actually read before it was > retrieved, thus it was dereferencing a

Re: [PATCH] pinctrl: axp209: dereference pointer after it's been set

Hello Quentin, Le Wed, 13 Dec 2017 09:55:03 +0100, Quentin Schulz a écrit : > The number of GPIOs is gotten from a field within the structure > referenced in the of_device.data but it was actually read before it was > retrieved, thus it was dereferencing a null pointer. > > Set the number of

Re: [PATCH 0/4] Sunxi: Add SMP support on A83T

Le Tue, 12 Dec 2017 10:40:25 +0100, Mylene JOSSERAND <mylene.josser...@free-electrons.com> a écrit : [...] > I have done further tests. > > I booted a previous kernel that I know it was working fine (kernel > v4.13) then, I booted the kernel with this series and it worked just

Re: [PATCH 0/4] Sunxi: Add SMP support on A83T

Le Tue, 12 Dec 2017 10:40:25 +0100, Mylene JOSSERAND a écrit : [...] > I have done further tests. > > I booted a previous kernel that I know it was working fine (kernel > v4.13) then, I booted the kernel with this series and it worked just > fine. > > Only after a p

Re: [PATCH 0/4] Sunxi: Add SMP support on A83T

Hi, Le Mon, 11 Dec 2017 20:35:34 +0100, Corentin Labbe a écrit : > On Mon, Dec 11, 2017 at 08:49:57AM +0100, Mylène Josserand wrote: > > Hello everyone, > > > > This series adds SMP support for Allwinner Sun8i-a83t > > with MCPM (Multi-Cluster Power Management). > >

Re: [PATCH 0/4] Sunxi: Add SMP support on A83T

Hi, Le Mon, 11 Dec 2017 20:35:34 +0100, Corentin Labbe a écrit : > On Mon, Dec 11, 2017 at 08:49:57AM +0100, Mylène Josserand wrote: > > Hello everyone, > > > > This series adds SMP support for Allwinner Sun8i-a83t > > with MCPM (Multi-Cluster Power Management). > > Series information: > >

Re: [PATCH 0/4] Sunxi: Add SMP support on A83T

Hello Corentin, Le Mon, 11 Dec 2017 20:35:34 +0100, Corentin Labbe a écrit : > On Mon, Dec 11, 2017 at 08:49:57AM +0100, Mylène Josserand wrote: > > Hello everyone, > > > > This series adds SMP support for Allwinner Sun8i-a83t > > with MCPM (Multi-Cluster Power

Re: [PATCH 0/4] Sunxi: Add SMP support on A83T

Hello Corentin, Le Mon, 11 Dec 2017 20:35:34 +0100, Corentin Labbe a écrit : > On Mon, Dec 11, 2017 at 08:49:57AM +0100, Mylène Josserand wrote: > > Hello everyone, > > > > This series adds SMP support for Allwinner Sun8i-a83t > > with MCPM (Multi-Cluster Power Management). > > Series

Re: [PATCH 0/5] sun8i-a83t: Add touchscreen support on TBS A711

Hi, Le Fri, 8 Dec 2017 22:54:14 +0100, Mylène Josserand a écrit : > Hello everyone, > > This patch series adds touchscreen support (FocalTech EDT-FT5x06 > Polytouch) for TBS A711 (Allwinner sun8i-a83t SoC). > This touchscreen is using i2c so this series

Re: [PATCH 0/5] sun8i-a83t: Add touchscreen support on TBS A711

Hi, Le Fri, 8 Dec 2017 22:54:14 +0100, Mylène Josserand a écrit : > Hello everyone, > > This patch series adds touchscreen support (FocalTech EDT-FT5x06 > Polytouch) for TBS A711 (Allwinner sun8i-a83t SoC). > This touchscreen is using i2c so this series adds support of this bus > on A83T. >

Re: [PATCH] clk: sunxi-ng: a83t: Fix i2c buses bits

Hello, Le Fri, 3 Nov 2017 08:11:00 -0700, Stephen Boyd a écrit : > On 11/03, Mylène Josserand wrote: > > i2c1 and i2c2 bits for CCU are not bit 0 but bit 1 and bit 2. > > Because of that, the i2c0 (bit 0) was not correctly configured. > > Fixed the correct bits for i2c1

Re: [PATCH] clk: sunxi-ng: a83t: Fix i2c buses bits

Hello, Le Fri, 3 Nov 2017 08:11:00 -0700, Stephen Boyd a écrit : > On 11/03, Mylène Josserand wrote: > > i2c1 and i2c2 bits for CCU are not bit 0 but bit 1 and bit 2. > > Because of that, the i2c0 (bit 0) was not correctly configured. > > Fixed the correct bits for i2c1 and i2c2. > > > >

Re: [PATCH v2 1/3] media: V3s: Add support for Allwinner CSI.

Hello Yong, Thank you for these drivers! I tested it with an OV5640 camera on an Nanopi M1 plus (Allwinner H3) and I noticed that I got a frame correctly displayed only on a half of the frame's size. It is related to your "sun6i_csi_set_window" function (see below). > Allwinner V3s SoC have

Re: [PATCH v2 1/3] media: V3s: Add support for Allwinner CSI.

Hello Yong, Thank you for these drivers! I tested it with an OV5640 camera on an Nanopi M1 plus (Allwinner H3) and I noticed that I got a frame correctly displayed only on a half of the frame's size. It is related to your "sun6i_csi_set_window" function (see below). > Allwinner V3s SoC have

Re: [PATCH v3] phy: allwinner: phy-sun4i-usb: Add log when probing

Hi, On 04/07/2017 14:37, Quentin Schulz wrote: When phy-sun4i-usb's probing fails, it does not print the reason in kernel log, forcing the developer to edit this driver to add info logs. This commit makes the kernel print the reason of phy-sun4i-usb's probing failure or a success message.

Re: [PATCH v3] phy: allwinner: phy-sun4i-usb: Add log when probing

Hi, On 04/07/2017 14:37, Quentin Schulz wrote: When phy-sun4i-usb's probing fails, it does not print the reason in kernel log, forcing the developer to edit this driver to add info logs. This commit makes the kernel print the reason of phy-sun4i-usb's probing failure or a success message.

Re: [PATCH 2/2] Documentation: DT: bindings: input: Add documentation for cyttsp5

Hi Dmitry, Thank you for the review! On 07/06/2017 22:40, Dmitry Torokhov wrote: On Wed, Jun 07, 2017 at 03:26:03PM -0500, Rob Herring wrote: On Mon, May 29, 2017 at 04:45:38PM +0200, Mylène Josserand wrote: Add the Cypress TrueTouch Generation 5 touchscreen device tree bindings

Re: [PATCH 2/2] Documentation: DT: bindings: input: Add documentation for cyttsp5

Hi Dmitry, Thank you for the review! On 07/06/2017 22:40, Dmitry Torokhov wrote: On Wed, Jun 07, 2017 at 03:26:03PM -0500, Rob Herring wrote: On Mon, May 29, 2017 at 04:45:38PM +0200, Mylène Josserand wrote: Add the Cypress TrueTouch Generation 5 touchscreen device tree bindings

Re: [PATCH 2/2] Documentation: DT: bindings: input: Add documentation for cyttsp5

Hi Rob, Thank you for the review. On 07/06/2017 22:26, Rob Herring wrote: On Mon, May 29, 2017 at 04:45:38PM +0200, Mylène Josserand wrote: Add the Cypress TrueTouch Generation 5 touchscreen device tree bindings documentation. It can use I2C or SPI bus. This touchscreen can handle some

Re: [PATCH 2/2] Documentation: DT: bindings: input: Add documentation for cyttsp5

Hi Rob, Thank you for the review. On 07/06/2017 22:26, Rob Herring wrote: On Mon, May 29, 2017 at 04:45:38PM +0200, Mylène Josserand wrote: Add the Cypress TrueTouch Generation 5 touchscreen device tree bindings documentation. It can use I2C or SPI bus. This touchscreen can handle some

Re: [PATCH 1/2] Input: Add driver for Cypress Generation 5 touchscreen

Maxime, On 06/06/2017 14:04, Maxime Ripard wrote: On Tue, Jun 06, 2017 at 10:03:48AM +0200, Mylene Josserand wrote: +static int cyttsp5_hid_output_bl_launch_app(struct cyttsp5 *ts) +{ + int rc, t; + u8 cmd[HID_OUTPUT_BL_LAUNCH_APP]; + u16 crc; + + mutex_lock

Re: [PATCH 1/2] Input: Add driver for Cypress Generation 5 touchscreen

Maxime, On 06/06/2017 14:04, Maxime Ripard wrote: On Tue, Jun 06, 2017 at 10:03:48AM +0200, Mylene Josserand wrote: +static int cyttsp5_hid_output_bl_launch_app(struct cyttsp5 *ts) +{ + int rc, t; + u8 cmd[HID_OUTPUT_BL_LAUNCH_APP]; + u16 crc; + + mutex_lock

Re: [PATCH 1/2] Input: Add driver for Cypress Generation 5 touchscreen

Hello Thomas, On 30/05/2017 10:43, Thomas Petazzoni wrote: Hello, A few more comments :) Thank you for the review! On Mon, 29 May 2017 16:45:37 +0200, Mylène Josserand wrote: +struct cyttsp5 { + struct device *dev; + struct mutex system_lock; + struct mutex btn_lock; +

Re: [PATCH 1/2] Input: Add driver for Cypress Generation 5 touchscreen

Hello Thomas, On 30/05/2017 10:43, Thomas Petazzoni wrote: Hello, A few more comments :) Thank you for the review! On Mon, 29 May 2017 16:45:37 +0200, Mylène Josserand wrote: +struct cyttsp5 { + struct device *dev; + struct mutex system_lock; + struct mutex btn_lock; +

Re: [PATCH 1/2] Input: Add driver for Cypress Generation 5 touchscreen

Hello Maxime, Thank you for the review! On 30/05/2017 10:02, Maxime Ripard wrote: Hi Mylene, On Mon, May 29, 2017 at 04:45:37PM +0200, Mylène Josserand wrote: +static int cyttsp5_read(struct cyttsp5 *ts, u8 *buf, u32 max) +{ + int rc; + u32 size; + + if (!buf) +

Re: [PATCH 1/2] Input: Add driver for Cypress Generation 5 touchscreen

Hello Maxime, Thank you for the review! On 30/05/2017 10:02, Maxime Ripard wrote: Hi Mylene, On Mon, May 29, 2017 at 04:45:37PM +0200, Mylène Josserand wrote: +static int cyttsp5_read(struct cyttsp5 *ts, u8 *buf, u32 max) +{ + int rc; + u32 size; + + if (!buf) +

Re: [PATCH 1/2] ASoC: sun8i-codec: Add ADC support for a33

Hi Chen-Yu, Thank you for the review! On 03/05/2017 19:13, Chen-Yu Tsai wrote: Hi, On Wed, May 3, 2017 at 9:56 PM, Mylène Josserand wrote: Add ADC support for the sun8i-codec driver. This driver uses all the microphones widgets and routes provided by

Re: [PATCH 1/2] ASoC: sun8i-codec: Add ADC support for a33

Hi Chen-Yu, Thank you for the review! On 03/05/2017 19:13, Chen-Yu Tsai wrote: Hi, On Wed, May 3, 2017 at 9:56 PM, Mylène Josserand wrote: Add ADC support for the sun8i-codec driver. This driver uses all the microphones widgets and routes provided by the analog part (sun8i-codec-analog).

Re: [PATCH 0/2] ASoC: sunxi: Add ADC support for A33

Hello, On 03/05/2017 15:56, Mylène Josserand wrote: Hello everyone, This is a first version of a serie to add ADC support for Sun8i-A33. Based on asoc/for-next branch, last commit: 20d5c84bef067b7e804a163e2abca16c47125bad. The first patch adds the support of ADC and microphones in the digital

Re: [PATCH 0/2] ASoC: sunxi: Add ADC support for A33

Hello, On 03/05/2017 15:56, Mylène Josserand wrote: Hello everyone, This is a first version of a serie to add ADC support for Sun8i-A33. Based on asoc/for-next branch, last commit: 20d5c84bef067b7e804a163e2abca16c47125bad. The first patch adds the support of ADC and microphones in the digital

Re: [PATCH v3 1/5] ASoC: sun8i-codec: Remove analog "HP" widget

Mark, On 20/03/2017 18:39, Mark Brown wrote: On Sat, Mar 18, 2017 at 08:55:05AM +0100, Mylène Josserand wrote: The "HP" widget is already present and take part to the analog part (sun8i-codec-analog). Remove it from the digital part as it is unnecessary. I know I said to send against Linus'

Re: [PATCH v3 1/5] ASoC: sun8i-codec: Remove analog "HP" widget

Mark, On 20/03/2017 18:39, Mark Brown wrote: On Sat, Mar 18, 2017 at 08:55:05AM +0100, Mylène Josserand wrote: The "HP" widget is already present and take part to the analog part (sun8i-codec-analog). Remove it from the digital part as it is unnecessary. I know I said to send against Linus'

Re: [PATCH v3 1/5] ASoC: sun8i-codec: Remove analog "HP" widget

Hi Mark, On 20/03/2017 18:39, Mark Brown wrote: On Sat, Mar 18, 2017 at 08:55:05AM +0100, Mylène Josserand wrote: The "HP" widget is already present and take part to the analog part (sun8i-codec-analog). Remove it from the digital part as it is unnecessary. I know I said to send against

Re: [PATCH v3 1/5] ASoC: sun8i-codec: Remove analog "HP" widget

Hi Mark, On 20/03/2017 18:39, Mark Brown wrote: On Sat, Mar 18, 2017 at 08:55:05AM +0100, Mylène Josserand wrote: The "HP" widget is already present and take part to the analog part (sun8i-codec-analog). Remove it from the digital part as it is unnecessary. I know I said to send against

Re: [PATCH v3 2/5] ASoC: sun8i-codec: Update mixer to use SOC_DAPM_DOUBLE

Hi Chen-Yu, On 20/03/2017 12:46, Chen-Yu Tsai wrote: On Sat, Mar 18, 2017 at 3:55 PM, Mylène Josserand wrote: Update the driver to use the new SOC_DAPM_DOUBLE definition on the digital DAC mixer. Update the names accordingly as, when they are shared, the

Re: [PATCH v3 2/5] ASoC: sun8i-codec: Update mixer to use SOC_DAPM_DOUBLE

Hi Chen-Yu, On 20/03/2017 12:46, Chen-Yu Tsai wrote: On Sat, Mar 18, 2017 at 3:55 PM, Mylène Josserand wrote: Update the driver to use the new SOC_DAPM_DOUBLE definition on the digital DAC mixer. Update the names accordingly as, when they are shared, the controls are not prefixed with the

Re: Applied "ASoC: sun8i-codec: Update mixer to use SOC_DAPM_DOUBLE" to the asoc tree

Hello, On 16/03/2017 15:06, Mark Brown wrote: On Wed, Mar 15, 2017 at 10:15:22PM +0800, Chen-Yu Tsai wrote: It depends on the second half of commit 4aa8146c89f3 ("ASoC: sun8i-codec: Remove analog "HP" widget"), which is also a cleanup. Would it be OK to pick these two over to fixes then? Or

Re: Applied "ASoC: sun8i-codec: Update mixer to use SOC_DAPM_DOUBLE" to the asoc tree

Hello, On 16/03/2017 15:06, Mark Brown wrote: On Wed, Mar 15, 2017 at 10:15:22PM +0800, Chen-Yu Tsai wrote: It depends on the second half of commit 4aa8146c89f3 ("ASoC: sun8i-codec: Remove analog "HP" widget"), which is also a cleanup. Would it be OK to pick these two over to fixes then? Or

Re: [PATCH 4/4] ASoC: sun8i-codec: Convert to use SND_SOC_DAPM_AIF_IN

Hi Chen-Yu, Thank you for the review. On 06/03/2017 10:56, Chen-Yu Tsai wrote: On Fri, Feb 10, 2017 at 5:41 PM, Mylène Josserand wrote: Update the driver to use SND_SOC_DAPM_AIF_IN instead of SND_SOC_DAPM_DAC. Set the route names so it must be updated on

Re: [PATCH 4/4] ASoC: sun8i-codec: Convert to use SND_SOC_DAPM_AIF_IN

Hi Chen-Yu, Thank you for the review. On 06/03/2017 10:56, Chen-Yu Tsai wrote: On Fri, Feb 10, 2017 at 5:41 PM, Mylène Josserand wrote: Update the driver to use SND_SOC_DAPM_AIF_IN instead of SND_SOC_DAPM_DAC. Set the route names so it must be updated on the device tree too. Signed-off-by:

Re: [PATCH v4 1/8] ASoC: sun4i-i2s: Update binding documentation to include A31

Hello Mark Brown, Thank you to have applied my patches! On 02/02/2017 10:24, Mylène Josserand wrote: Add a new compatible for sun4i-i2s driver to handle some SoCs that have a reset line that must be asserted/deasserted. This new compatible, "allwinner,sun6i-a31-i2s", requires the property

Re: [PATCH v4 1/8] ASoC: sun4i-i2s: Update binding documentation to include A31

Hello Mark Brown, Thank you to have applied my patches! On 02/02/2017 10:24, Mylène Josserand wrote: Add a new compatible for sun4i-i2s driver to handle some SoCs that have a reset line that must be asserted/deasserted. This new compatible, "allwinner,sun6i-a31-i2s", requires the property

Re: [PATCH v4 3/8] ASoC: Add sun8i digital audio codec

Hi Chen-Yu, On 07/02/2017 09:39, Chen-Yu Tsai wrote: Hi, On Thu, Feb 2, 2017 at 5:24 PM, Mylène Josserand wrote: Add the sun8i audio codec which handles the digital register of A33 codec. The driver handles only the basic playback from the DAC to

Re: [PATCH v4 3/8] ASoC: Add sun8i digital audio codec

Hi Chen-Yu, On 07/02/2017 09:39, Chen-Yu Tsai wrote: Hi, On Thu, Feb 2, 2017 at 5:24 PM, Mylène Josserand wrote: Add the sun8i audio codec which handles the digital register of A33 codec. The driver handles only the basic playback from the DAC to headphones. All other features (microphone,

Re: [PATCH v3 1/8] ASoC: sun4i-i2s: Update binding documentation to include A31

Hi, On 01/02/2017 12:59, Mark Brown wrote: On Wed, Feb 01, 2017 at 08:44:56AM +0100, Mylene Josserand wrote: On 31/01/2017 22:17, Mark Brown wrote: On Tue, Jan 31, 2017 at 11:05:45AM +0100, Mylène Josserand wrote: Add a new compatible for sun4i-i2s driver to handle some SoCs that have

Re: [PATCH v3 1/8] ASoC: sun4i-i2s: Update binding documentation to include A31

Hi, On 01/02/2017 12:59, Mark Brown wrote: On Wed, Feb 01, 2017 at 08:44:56AM +0100, Mylene Josserand wrote: On 31/01/2017 22:17, Mark Brown wrote: On Tue, Jan 31, 2017 at 11:05:45AM +0100, Mylène Josserand wrote: Add a new compatible for sun4i-i2s driver to handle some SoCs that have

Re: [PATCH v3 1/8] ASoC: sun4i-i2s: Update binding documentation to include A31

Hello, On 31/01/2017 22:17, Mark Brown wrote: On Tue, Jan 31, 2017 at 11:05:45AM +0100, Mylène Josserand wrote: Add a new compatible for sun4i-i2s driver to handle some SoCs that have a reset line that must be asserted/deasserted. This doesn't apply against current code, please check and

Re: [PATCH v3 1/8] ASoC: sun4i-i2s: Update binding documentation to include A31

Hello, On 31/01/2017 22:17, Mark Brown wrote: On Tue, Jan 31, 2017 at 11:05:45AM +0100, Mylène Josserand wrote: Add a new compatible for sun4i-i2s driver to handle some SoCs that have a reset line that must be asserted/deasserted. This doesn't apply against current code, please check and

Re: [PATCH v2 07/10] dt-bindings: sound: Add sun8i audio documentation

Hi, On 17/01/2017 17:50, Mark Brown wrote: On Tue, Jan 17, 2017 at 03:02:27PM +0100, Mylène Josserand wrote: Add the documentation for dt-binding of the digital audio codec driver and the audio card driver for Sun8i SoCs. Please submit patches using subject lines reflecting the style for

Re: [PATCH v2 07/10] dt-bindings: sound: Add sun8i audio documentation

Hi, On 17/01/2017 17:50, Mark Brown wrote: On Tue, Jan 17, 2017 at 03:02:27PM +0100, Mylène Josserand wrote: Add the documentation for dt-binding of the digital audio codec driver and the audio card driver for Sun8i SoCs. Please submit patches using subject lines reflecting the style for

Re: [PATCH v2 03/10] dt-bindings: sound: Add new reset compatible for sun4i-i2s

Hi, On 17/01/2017 17:46, Maxime Ripard wrote: On Tue, Jan 17, 2017 at 03:02:23PM +0100, Mylène Josserand wrote: Add a new compatible for sun4i-i2s driver to handle some SoCs that have a reset line that must be asserted/deasserted. This new compatible, "allwinner,sun6i-a31-i2s", requires two

Re: [PATCH v2 03/10] dt-bindings: sound: Add new reset compatible for sun4i-i2s

Hi, On 17/01/2017 17:46, Maxime Ripard wrote: On Tue, Jan 17, 2017 at 03:02:23PM +0100, Mylène Josserand wrote: Add a new compatible for sun4i-i2s driver to handle some SoCs that have a reset line that must be asserted/deasserted. This new compatible, "allwinner,sun6i-a31-i2s", requires two

Re: [PATCH v2 02/10] clk: ccu-sun8i-a33: Add CLK_SET_RATE_PARENT to ac-dig

Hi, On 17/01/2017 17:44, Maxime Ripard wrote: Hi, On Tue, Jan 17, 2017 at 03:02:22PM +0100, Mylène Josserand wrote: The audio DAI needs to set the clock rates of the ac-dig clock. To make it possible, the parent PLL audio clock rates should also be changed. This is possible via

Re: [PATCH v2 02/10] clk: ccu-sun8i-a33: Add CLK_SET_RATE_PARENT to ac-dig

Hi, On 17/01/2017 17:44, Maxime Ripard wrote: Hi, On Tue, Jan 17, 2017 at 03:02:22PM +0100, Mylène Josserand wrote: The audio DAI needs to set the clock rates of the ac-dig clock. To make it possible, the parent PLL audio clock rates should also be changed. This is possible via

Re: [PATCH v2 05/10] ASoC: Add sun8i digital audio codec

Hello everyone, On 17/01/2017 15:02, Mylène Josserand wrote: Add the sun8i audio codec which handles the digital register of A33 codec. The driver handles only the basic playback from the DAC to headphones. All other features (microphone, capture, etc) will be added later. Signed-off-by:

Re: [PATCH v2 05/10] ASoC: Add sun8i digital audio codec

Hello everyone, On 17/01/2017 15:02, Mylène Josserand wrote: Add the sun8i audio codec which handles the digital register of A33 codec. The driver handles only the basic playback from the DAC to headphones. All other features (microphone, capture, etc) will be added later. Signed-off-by:

Re: [PATCH 08/14] dt-bindings: sound: Add sun8i analog codec documentation

Hello, On 05/10/2016 04:59, Chen-Yu Tsai wrote: On Wed, Oct 5, 2016 at 12:24 AM, Maxime Ripard wrote: Hi, On Tue, Oct 04, 2016 at 11:46:21AM +0200, Mylène Josserand wrote: Add the documentation for dt-binding of the analog audiocodec driver for SUN8I SoC.

Re: [PATCH 08/14] dt-bindings: sound: Add sun8i analog codec documentation

Hello, On 05/10/2016 04:59, Chen-Yu Tsai wrote: On Wed, Oct 5, 2016 at 12:24 AM, Maxime Ripard wrote: Hi, On Tue, Oct 04, 2016 at 11:46:21AM +0200, Mylène Josserand wrote: Add the documentation for dt-binding of the analog audiocodec driver for SUN8I SoC. Signed-off-by: Mylène Josserand

Re: [PATCH 06/14] ASoC: Add sun8i digital audio codec

Hello, On 04/10/2016 14:40, Thomas Petazzoni wrote: Hello, On Tue, 4 Oct 2016 11:46:19 +0200, Mylène Josserand wrote: Add the digital sun8i audio codec which handles the base register (without DAI). I'm not sure what you mean by "which handles the base register". I wanted to explain

Re: [PATCH 06/14] ASoC: Add sun8i digital audio codec

Hello, On 04/10/2016 14:40, Thomas Petazzoni wrote: Hello, On Tue, 4 Oct 2016 11:46:19 +0200, Mylène Josserand wrote: Add the digital sun8i audio codec which handles the base register (without DAI). I'm not sure what you mean by "which handles the base register". I wanted to explain

Re: [PATCH 03/14] ASoC: sun4i-i2s: Add apb reset

Hello, On 04/10/2016 17:42, Maxime Ripard wrote: Hi, On Tue, Oct 04, 2016 at 02:15:16PM +0200, Thomas Petazzoni wrote: Hello, On Tue, 4 Oct 2016 11:46:16 +0200, Mylène Josserand wrote: #include #include @@ -589,6 +590,7 @@ static int sun4i_i2s_probe(struct platform_device *pdev) {

Re: [PATCH 03/14] ASoC: sun4i-i2s: Add apb reset

Hello, On 04/10/2016 17:42, Maxime Ripard wrote: Hi, On Tue, Oct 04, 2016 at 02:15:16PM +0200, Thomas Petazzoni wrote: Hello, On Tue, 4 Oct 2016 11:46:16 +0200, Mylène Josserand wrote: #include #include @@ -589,6 +590,7 @@ static int sun4i_i2s_probe(struct platform_device *pdev) {

Re: [PATCH 02/14] clk: ccu-sun8i-a33: Add CLK_SET_RATE_PARENT to ac-dig

Hello Thomas, On 04/10/2016 14:12, Thomas Petazzoni wrote: Hello, On Tue, 4 Oct 2016 11:46:15 +0200, Mylène Josserand wrote: Add the flag CLK_SET_RATE_PARENT to 'ac-dig' clock. There is no need to repeat the commit title inside the commit log itself. What would be more useful is to

Re: [PATCH 02/14] clk: ccu-sun8i-a33: Add CLK_SET_RATE_PARENT to ac-dig

Hello Thomas, On 04/10/2016 14:12, Thomas Petazzoni wrote: Hello, On Tue, 4 Oct 2016 11:46:15 +0200, Mylène Josserand wrote: Add the flag CLK_SET_RATE_PARENT to 'ac-dig' clock. There is no need to repeat the commit title inside the commit log itself. What would be more useful is to

[PATCH 1/2] rtc: abx80x: handle autocalibration

s/class/rtc/rtc0/device/oscillator Activate an autocalibration every 512 seconds echo 512 > /sys/class/rtc/rtc0/device/autocalibration Signed-off-by: Mylene JOSSERAND <mylene.josser...@free-electrons.com> --- drivers/rtc/rtc-abx80x.c | 219 +++ 1 file chan

[PATCH 1/2] rtc: abx80x: handle autocalibration

s/class/rtc/rtc0/device/oscillator Activate an autocalibration every 512 seconds echo 512 > /sys/class/rtc/rtc0/device/autocalibration Signed-off-by: Mylene JOSSERAND --- drivers/rtc/rtc-abx80x.c | 219 +++ 1 file changed, 219 insertions(+) diff --git a/drive

[PATCH 2/2] rtc: abx80x: handle the oscillator failure bit

Handle the Oscillator Failure ('OF') bit from Oscillator Status register (0x1D). This bit is cleared on set_time function and is read each time the date/time is read, but only in case of XT Oscillator selection. In RC mode, this bit is always set. Signed-off-by: Mylene JOSSERAND <mylene.jos

[PATCH 2/2] rtc: abx80x: handle the oscillator failure bit

Handle the Oscillator Failure ('OF') bit from Oscillator Status register (0x1D). This bit is cleared on set_time function and is read each time the date/time is read, but only in case of XT Oscillator selection. In RC mode, this bit is always set. Signed-off-by: Mylene JOSSERAND --- drivers/rtc

[PATCH 0/2] rtc: abx80x: Handle autocalibration and oscillator failure

The current patches handle the autocalibration and the oscillator failure for ABX80X RTC. The autocalibration is handled using sysfs entries and the oscillator failure bit is handled only for the XT Oscillator. Mylene JOSSERAND (2): rtc: abx80x: handle autocalibration rtc: abx80x: handle

[PATCH 0/2] rtc: abx80x: Handle autocalibration and oscillator failure

The current patches handle the autocalibration and the oscillator failure for ABX80X RTC. The autocalibration is handled using sysfs entries and the oscillator failure bit is handled only for the XT Oscillator. Mylene JOSSERAND (2): rtc: abx80x: handle autocalibration rtc: abx80x: handle

[PATCH] mmc: sdhci-tegra: convert to use GPIO descriptors

Modify the driver to handle GPIOs using the descriptor API. Signed-off-by: Mylene JOSSERAND --- drivers/mmc/host/sdhci-tegra.c | 32 1 file changed, 8 insertions(+), 24 deletions(-) diff --git a/drivers/mmc/host/sdhci-tegra.c b/drivers/mmc/host/sdhci-tegra.c

[PATCH] mmc: sdhci-tegra: convert to use GPIO descriptors

Modify the driver to handle GPIOs using the descriptor API. Signed-off-by: Mylene JOSSERAND josserand.myl...@gmail.com --- drivers/mmc/host/sdhci-tegra.c | 32 1 file changed, 8 insertions(+), 24 deletions(-) diff --git a/drivers/mmc/host/sdhci-tegra.c b

Re: [I2C] informations + advice about messages handling

Hi Jean, Le 24/05/2013 14:20, Jean Delvare a écrit : > On Fri, 24 May 2013 11:52:54 +0200, Mylene Josserand wrote: >> - an audio codec tlv320aic3204 : There is a driver for this device but >> for some reasons, we did not use it. Did not find a "SMBus compliant&

Re: [I2C] informations + advice about messages handling

Hi Jean, Le 24/05/2013 14:20, Jean Delvare a écrit : On Fri, 24 May 2013 11:52:54 +0200, Mylene Josserand wrote: - an audio codec tlv320aic3204 : There is a driver for this device but for some reasons, we did not use it. Did not find a SMBus compliant in its datasheet. The tlv320aic32x4

Re: [I2C] informations + advice about messages handling

Le 24/05/2013 11:07, Jean Delvare a écrit : > On Fri, 24 May 2013 10:54:11 +0200, Mylene Josserand wrote: >> Ah okay ! And if there are not SMBus compliant, what function I will >> have to use ? > > i2c_transfer() Okay, logic name ;) >> What is it doing if I us

Re: [I2C] informations + advice about messages handling

Thanks, both of you, for your answers ! It helps me a lot to understand it ! Le 24/05/2013 09:22, anish singh a écrit : > On Fri, May 24, 2013 at 12:41 PM, Mylene Josserand > wrote: >> Hi all, >> >> >> I am learning how i2c is working and I read that, to w

Re: [I2C] informations + advice about messages handling

Thanks, both of you, for your answers ! It helps me a lot to understand it ! Le 24/05/2013 09:22, anish singh a écrit : On Fri, May 24, 2013 at 12:41 PM, Mylene Josserand mylene.josser...@navocap.com wrote: Hi all, I am learning how i2c is working and I read that, to write in an i2c

Re: [I2C] informations + advice about messages handling

Le 24/05/2013 11:07, Jean Delvare a écrit : On Fri, 24 May 2013 10:54:11 +0200, Mylene Josserand wrote: Ah okay ! And if there are not SMBus compliant, what function I will have to use ? i2c_transfer() Okay, logic name ;) What is it doing if I use this function and that my device