[PATCH v2 4/4] media: i2c: tvp5150: Use parentheses for sizeof

2018-04-02 Thread Nasser Afshin
This patch resolves a checkpatch.pl warning: WARNING: sizeof *cap should be sizeof(*cap) Signed-off-by: Nasser Afshin <afshin.nas...@gmail.com> --- drivers/media/i2c/tvp5150.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/media/i2c/tvp5150.c b/drivers/med

[PATCH v2 4/4] media: i2c: tvp5150: Use parentheses for sizeof

2018-04-02 Thread Nasser Afshin
This patch resolves a checkpatch.pl warning: WARNING: sizeof *cap should be sizeof(*cap) Signed-off-by: Nasser Afshin --- drivers/media/i2c/tvp5150.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/media/i2c/tvp5150.c b/drivers/media/i2c/tvp5150.c index

[PATCH v2 2/4] media: i2c: tvp5150: Use the correct comment style

2018-04-02 Thread Nasser Afshin
This patch resolves checkpatch.pl warnings: WARNING: Block comments use * on subsequent lines WARNING: Block comments use a trailing */ on a separate line Signed-off-by: Nasser Afshin <afshin.nas...@gmail.com> --- drivers/media/i2c/tvp5150.c | 19 --- 1 file chang

[PATCH v2 2/4] media: i2c: tvp5150: Use the correct comment style

2018-04-02 Thread Nasser Afshin
This patch resolves checkpatch.pl warnings: WARNING: Block comments use * on subsequent lines WARNING: Block comments use a trailing */ on a separate line Signed-off-by: Nasser Afshin --- drivers/media/i2c/tvp5150.c | 19 --- 1 file changed, 12 insertions(+), 7 deletions

[PATCH v2 1/4] media: i2c: tvp5150: Add a space after commas

2018-04-02 Thread Nasser Afshin
This patch resolves checkpatch.pl errors: ERROR: space required after that ',' (ctx:VxV) Signed-off-by: Nasser Afshin <afshin.nas...@gmail.com> --- drivers/media/i2c/tvp5150.c | 134 ++-- 1 file changed, 67 insertions(+), 67 deletions(-) diff

[PATCH v2 3/4] media: i2c: tvp5150: Fix open brace placement codding style

2018-04-02 Thread Nasser Afshin
This patch resolves the following checkpatch.pl error: ERROR: that open brace { should be on the previous line Signed-off-by: Nasser Afshin <afshin.nas...@gmail.com> --- drivers/media/i2c/tvp5150.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/drivers/med

[PATCH v2 1/4] media: i2c: tvp5150: Add a space after commas

2018-04-02 Thread Nasser Afshin
This patch resolves checkpatch.pl errors: ERROR: space required after that ',' (ctx:VxV) Signed-off-by: Nasser Afshin --- drivers/media/i2c/tvp5150.c | 134 ++-- 1 file changed, 67 insertions(+), 67 deletions(-) diff --git a/drivers/media/i2c/tvp5150

[PATCH v2 3/4] media: i2c: tvp5150: Fix open brace placement codding style

2018-04-02 Thread Nasser Afshin
This patch resolves the following checkpatch.pl error: ERROR: that open brace { should be on the previous line Signed-off-by: Nasser Afshin --- drivers/media/i2c/tvp5150.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/drivers/media/i2c/tvp5150.c b/drivers/media/i2c

[PATCH v2 0/4] media: i2c: tvp5150: resolve checkpatch errors

2018-04-02 Thread Nasser Afshin
This patch series tries to resolve some checkpatch.pl errors and warnings. Nasser Afshin (4): media: i2c: tvp5150: Add a space after commas media: i2c: tvp5150: Use the correct comment style media: i2c: tvp5150: Fix open brace placement codding style media: i2c: tvp5150: Use parentheses

[PATCH v2 0/4] media: i2c: tvp5150: resolve checkpatch errors

2018-04-02 Thread Nasser Afshin
This patch series tries to resolve some checkpatch.pl errors and warnings. Nasser Afshin (4): media: i2c: tvp5150: Add a space after commas media: i2c: tvp5150: Use the correct comment style media: i2c: tvp5150: Fix open brace placement codding style media: i2c: tvp5150: Use parentheses

[PATCH 3/3] media: i2c: tvp5150: Use parentheses for sizeof

2018-04-02 Thread Nasser Afshin
This patch resolves a checkpatch.pl warning Signed-off-by: Nasser Afshin <afshin.nas...@gmail.com> --- drivers/media/i2c/tvp5150.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/media/i2c/tvp5150.c b/drivers/media/i2c/tvp5150.c index d561d87d219a..d528fddbea16

[PATCH 3/3] media: i2c: tvp5150: Use parentheses for sizeof

2018-04-02 Thread Nasser Afshin
This patch resolves a checkpatch.pl warning Signed-off-by: Nasser Afshin --- drivers/media/i2c/tvp5150.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/media/i2c/tvp5150.c b/drivers/media/i2c/tvp5150.c index d561d87d219a..d528fddbea16 100644 --- a/drivers/media/i2c

[PATCH 1/3] media: i2c: tvp5150: Add a space after commas

2018-04-02 Thread Nasser Afshin
This patch resolves checkpatch.pl errors: ERROR: space required after that ',' (ctx:VxV) Signed-off-by: Nasser Afshin <afshin.nas...@gmail.com> --- drivers/media/i2c/tvp5150.c | 134 ++-- 1 file changed, 67 insertions(+), 67 deletions(-) diff

[PATCH 1/3] media: i2c: tvp5150: Add a space after commas

2018-04-02 Thread Nasser Afshin
This patch resolves checkpatch.pl errors: ERROR: space required after that ',' (ctx:VxV) Signed-off-by: Nasser Afshin --- drivers/media/i2c/tvp5150.c | 134 ++-- 1 file changed, 67 insertions(+), 67 deletions(-) diff --git a/drivers/media/i2c/tvp5150

[PATCH 2/3] media: i2c: tvp5150: Use the correct comment style

2018-04-02 Thread Nasser Afshin
This patch resolves some checkpatch.pl warnings about comments. Signed-off-by: Nasser Afshin <afshin.nas...@gmail.com> --- drivers/media/i2c/tvp5150.c | 23 ++- 1 file changed, 14 insertions(+), 9 deletions(-) diff --git a/drivers/media/i2c/tvp5150.c b/drivers/med

[PATCH 2/3] media: i2c: tvp5150: Use the correct comment style

2018-04-02 Thread Nasser Afshin
This patch resolves some checkpatch.pl warnings about comments. Signed-off-by: Nasser Afshin --- drivers/media/i2c/tvp5150.c | 23 ++- 1 file changed, 14 insertions(+), 9 deletions(-) diff --git a/drivers/media/i2c/tvp5150.c b/drivers/media/i2c/tvp5150.c index af56a5a6db65

[PATCH 0/3] media: i2c: tvp5150: resolve checkpatch errors

2018-04-02 Thread Nasser Afshin
This patch series tries to resolve some checkpatch.pl errors and warnings. Nasser Afshin (3): media: i2c: tvp5150: Add a space after commas media: i2c: tvp5150: Use the correct comment style media: i2c: tvp5150: Use parentheses for sizeof drivers/media/i2c/tvp5150.c | 159

[PATCH 0/3] media: i2c: tvp5150: resolve checkpatch errors

2018-04-02 Thread Nasser Afshin
This patch series tries to resolve some checkpatch.pl errors and warnings. Nasser Afshin (3): media: i2c: tvp5150: Add a space after commas media: i2c: tvp5150: Use the correct comment style media: i2c: tvp5150: Use parentheses for sizeof drivers/media/i2c/tvp5150.c | 159

Re: [PATCH] media: i2c: tvp5150: fix color burst lock instability on some hardware

2018-03-29 Thread Nasser
On Thu, Mar 29, 2018 at 12:02:40PM -0300, Mauro Carvalho Chehab wrote: > Em Thu, 29 Mar 2018 19:04:35 +0430 > Nasser <afshin.nas...@gmail.com> escreveu: > > > On Tue, Mar 27, 2018 at 02:59:21AM +0430, Nasser wrote: > > Hi Mauro, > > > > Thank you for takin

Re: [PATCH] media: i2c: tvp5150: fix color burst lock instability on some hardware

2018-03-29 Thread Nasser
On Thu, Mar 29, 2018 at 12:02:40PM -0300, Mauro Carvalho Chehab wrote: > Em Thu, 29 Mar 2018 19:04:35 +0430 > Nasser escreveu: > > > On Tue, Mar 27, 2018 at 02:59:21AM +0430, Nasser wrote: > > Hi Mauro, > > > > Thank you for taking time to review my patch.

Re: [PATCH] media: i2c: tvp5150: fix color burst lock instability on some hardware

2018-03-29 Thread Nasser
On Tue, Mar 27, 2018 at 02:59:21AM +0430, Nasser wrote: Hi Mauro, Thank you for taking time to review my patch. May be I should rephrase the commit message to something like: Use the default register values as suggested in TVP5150AM1 datasheet As this is not a hardware-dependent issue

Re: [PATCH] media: i2c: tvp5150: fix color burst lock instability on some hardware

2018-03-29 Thread Nasser
On Tue, Mar 27, 2018 at 02:59:21AM +0430, Nasser wrote: Hi Mauro, Thank you for taking time to review my patch. May be I should rephrase the commit message to something like: Use the default register values as suggested in TVP5150AM1 datasheet As this is not a hardware-dependent issue

Re: [PATCH] media: i2c: tvp5150: fix color burst lock instability on some hardware

2018-03-26 Thread Nasser
On Mon, Mar 26, 2018 at 06:43:53AM -0300, Mauro Carvalho Chehab wrote: > Hi Nasser, > > Em Mon, 26 Mar 2018 03:26:33 +0430 > Nasser Afshin <afshin.nas...@gmail.com> escreveu: > > > According to the datasheet, INTREQ/GPCL/VBLK should have a pull-up/down > &g

Re: [PATCH] media: i2c: tvp5150: fix color burst lock instability on some hardware

2018-03-26 Thread Nasser
On Mon, Mar 26, 2018 at 06:43:53AM -0300, Mauro Carvalho Chehab wrote: > Hi Nasser, > > Em Mon, 26 Mar 2018 03:26:33 +0430 > Nasser Afshin escreveu: > > > According to the datasheet, INTREQ/GPCL/VBLK should have a pull-up/down > > resistor if it's been disabled. On

[PATCH] media: i2c: tvp5150: fix color burst lock instability on some hardware

2018-03-25 Thread Nasser Afshin
According to the datasheet, INTREQ/GPCL/VBLK should have a pull-up/down resistor if it's been disabled. On hardware that does not have such resistor, we should use the default output enable value. This prevents the color burst lock instability problem. Signed-off-by: Nasser Afshin <afshin.

[PATCH] media: i2c: tvp5150: fix color burst lock instability on some hardware

2018-03-25 Thread Nasser Afshin
According to the datasheet, INTREQ/GPCL/VBLK should have a pull-up/down resistor if it's been disabled. On hardware that does not have such resistor, we should use the default output enable value. This prevents the color burst lock instability problem. Signed-off-by: Nasser Afshin --- drivers

S5PV210 boot problem

2016-10-31 Thread Nasser
Dear friends, I have problem booting my custom HW (around s5pv210 SoC) using the latest stable kernel release (v4.8.5). Of course this is the first DT based kernel I'm trying to boot with in this HW. I chose s5pv210_defconfig and by checking CONFIG_ARM_APPENDED_DTB, appended the DTB

S5PV210 boot problem

2016-10-31 Thread Nasser
Dear friends, I have problem booting my custom HW (around s5pv210 SoC) using the latest stable kernel release (v4.8.5). Of course this is the first DT based kernel I'm trying to boot with in this HW. I chose s5pv210_defconfig and by checking CONFIG_ARM_APPENDED_DTB, appended the DTB

Urgent Assistance from Syria

2014-08-23 Thread Abdul Nasser Sokariah
-- Good Day From Syria, My name is Abdul Nasser Sokariah and I am writing you from Syria, I choose to contact you directly as I need a reliable person to trust who can help me make claims to my huge deposit with a vault company in AFRICA, and based on my present situation in Syria, I need you

Urgent Assistance from Syria

2014-08-23 Thread Abdul Nasser Sokariah
-- Good Day From Syria, My name is Abdul Nasser Sokariah and I am writing you from Syria, I choose to contact you directly as I need a reliable person to trust who can help me make claims to my huge deposit with a vault company in AFRICA, and based on my present situation in Syria, I need you

Kind Regards

2014-01-26 Thread Abdul Nasser
Greetings, My name is Abdul Nasser Sokariah and I am writing you from Syria, I choose to contact you directly as I need a reliable person to trust who can help me handle my huge deposit with a vault company in EUROPE, and based on my present situation in Syria, I need you urgently to take

Kind Regards

2014-01-26 Thread Abdul Nasser
Greetings, My name is Abdul Nasser Sokariah and I am writing you from Syria, I choose to contact you directly as I need a reliable person to trust who can help me handle my huge deposit with a vault company in EUROPE, and based on my present situation in Syria, I need you urgently to take

Kind Regards

2014-01-26 Thread Abdul Nasser
Greetings, My name is Abdul Nasser Sokariah and I am writing you from Syria, I choose to contact you directly as I need a reliable person to trust who can help me handle my huge deposit with a vault company in EUROPE, and based on my present situation in Syria, I need you urgently to take

Kind Regards

2014-01-26 Thread Abdul Nasser
Greetings, My name is Abdul Nasser Sokariah and I am writing you from Syria, I choose to contact you directly as I need a reliable person to trust who can help me handle my huge deposit with a vault company in EUROPE, and based on my present situation in Syria, I need you urgently to take

Kind Regards

2014-01-26 Thread Abdul Nasser
Greetings, My name is Abdul Nasser Sokariah and I am writing you from Syria, I choose to contact you directly as I need a reliable person to trust who can help me handle my huge deposit with a vault company in EUROPE, and based on my present situation in Syria, I need you urgently to take

Kind Regards

2014-01-26 Thread Abdul Nasser
Greetings, My name is Abdul Nasser Sokariah and I am writing you from Syria, I choose to contact you directly as I need a reliable person to trust who can help me handle my huge deposit with a vault company in EUROPE, and based on my present situation in Syria, I need you urgently to take