Re: [PATCH 0/2] tracing: Fully silence instance of -Wstring-compare

2024-03-19 Thread Nathan Chancellor
On Tue, Mar 19, 2024 at 06:15:09PM -0400, Steven Rostedt wrote: > On Tue, 19 Mar 2024 09:07:51 -0700 > Nathan Chancellor wrote: > > > Hi all, > > > > This series fully resolves the new instance of -Wstring-compare from > > within the __assign_str() macro.

[PATCH 2/2] tracing: Ignore -Wstring-compare with diagnostic macros

2024-03-19 Thread Nathan Chancellor
heck") Reported-by: Linux Kernel Functional Testing Closes: https://lore.kernel.org/all/CA+G9fYs=otkazs6g1p1ewadfr0qoe6lgovsohqkxmfxoteo...@mail.gmail.com/ Signed-off-by: Nathan Chancellor --- include/trace/stages/stage6_event_callback.h | 5 + 1 file changed, 5 insertions(+) diff -

[PATCH 0/2] tracing: Fully silence instance of -Wstring-compare

2024-03-19 Thread Nathan Chancellor
rge window so that this warning does not proliferate into other trees that base on -rc1. --- Nathan Chancellor (2): compiler_types: Ensure __diag_clang() is always available tracing: Ignore -Wstring-compare with diagnostic macros include/linux/compiler_types.h | 4 +++

[PATCH 1/2] compiler_types: Ensure __diag_clang() is always available

2024-03-19 Thread Nathan Chancellor
and compiler-gcc.h. Add an empty stub for __diag_clang() in compiler_types.h, so that it is always defined and just becomes a no-op when using GCC. Fixes: f014a00bbeb0 ("compiler-clang.h: Add __diag infrastructure for clang") Signed-off-by: Nathan Chancellor --- include/linux/compiler_t

Re: net/sunrpc/sched.c: error: result of comparison against a string literal is unspecified (use an explicit string comparison function instead)

2024-03-18 Thread Nathan Chancellor
Hi Naresh, On Mon, Mar 18, 2024 at 02:55:54PM +0530, Naresh Kamboju wrote: > The following build warnings / errors noticed on x86 kselftests build with > clang nightly / clang-17 on Linux next tag next-20240318. > > This build config is generated from kselftest merge configs [1]. > >

Re: [PATCH] tracing: Use strcmp() in __assign_str() WARN_ON() check

2024-03-13 Thread Nathan Chancellor
On Tue, Mar 12, 2024 at 11:30:02AM -0400, Steven Rostedt wrote: > From: "Steven Rostedt (Google)" > > The WARN_ON() check in __assign_str() to catch where the source variable > to the macro doesn't match the source variable to __string() gives an > error in clang: > > >>

Re: [PATCH 1/6] tools/rtla: Fix Makefile compiler options for clang

2024-02-06 Thread Nathan Chancellor
On Tue, Feb 06, 2024 at 12:05:29PM +0100, Daniel Bristot de Oliveira wrote: > The following errors are showing up when compiling rtla with clang: > > $ make HOSTCC=clang CC=clang LLVM_IAS=1 > [...] > > clang -O -g -DVERSION=\"6.8.0-rc1\" -flto=auto -ffat-lto-objects > -fexceptions

[PATCH] eventfs: Use ERR_CAST() in eventfs_create_events_dir()

2023-10-18 Thread Nathan Chancellor
("eventfs: Remove eventfs_file and just use eventfs_inode") Signed-off-by: Nathan Chancellor --- fs/tracefs/event_inode.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/fs/tracefs/event_inode.c b/fs/tracefs/event_inode.c index 1ccd100bc565..9f19b6608954 100644 --- a/

Re: [PATCH 5/5] kbuild: unify no-compiler-targets and no-sync-config-targets

2023-10-09 Thread Nathan Chancellor
On Mon, Oct 09, 2023 at 09:42:10PM +0900, Masahiro Yamada wrote: > Now that vdso_install does not depend on any in-tree build artifact, > it no longer invokes a compiler, making no-compiler-targets the same > as no-sync-config-targets. > > Signed-off-by: Masahiro Yamada > --- > > Makefile | 13

Re: [PATCH rebased] kbuild: rpm-pkg: Fix build with non-default MODLIB

2023-10-06 Thread Nathan Chancellor
Signed-off-by: Michal Suchanek This appears to work for me. Reviewed-by: Nathan Chancellor > --- > scripts/package/kernel.spec | 8 > scripts/package/mkspec | 1 + > 2 files changed, 5 insertions(+), 4 deletions(-) > > diff --git a/scripts/package/kerne

Re: [patch 11/12] gcov: clang: fix clang-11+ build

2021-04-19 Thread Nathan Chancellor
On Fri, Apr 16, 2021 at 03:46:23PM -0700, Andrew Morton wrote: > From: Johannes Berg > Subject: gcov: clang: fix clang-11+ build > > With clang-11+, the code is broken due to my kvmalloc() conversion (which > predated the clang-11 support code) leaving one vmalloc() in place. Fix > that. > >

[tip: perf/core] x86/events/amd/iommu: Fix sysfs type mismatch

2021-04-16 Thread tip-bot2 for Nathan Chancellor
The following commit has been merged into the perf/core branch of tip: Commit-ID: de5bc7b425d4c27ae5faa00ea7eb6b9780b9a355 Gitweb: https://git.kernel.org/tip/de5bc7b425d4c27ae5faa00ea7eb6b9780b9a355 Author:Nathan Chancellor AuthorDate:Wed, 14 Apr 2021 17:11:11 -07:00

[tip: perf/core] perf/amd/uncore: Fix sysfs type mismatch

2021-04-16 Thread tip-bot2 for Nathan Chancellor
The following commit has been merged into the perf/core branch of tip: Commit-ID: 5deac80d4571dffb51f452f0027979d72259a1b9 Gitweb: https://git.kernel.org/tip/5deac80d4571dffb51f452f0027979d72259a1b9 Author:Nathan Chancellor AuthorDate:Wed, 14 Apr 2021 17:11:12 -07:00

[tip: perf/core] x86/events/amd/iommu: Fix sysfs type mismatch

2021-04-16 Thread tip-bot2 for Nathan Chancellor
The following commit has been merged into the perf/core branch of tip: Commit-ID: bccae9d7b013bd708ece414f74defaee56790e1d Gitweb: https://git.kernel.org/tip/bccae9d7b013bd708ece414f74defaee56790e1d Author:Nathan Chancellor AuthorDate:Wed, 14 Apr 2021 17:11:11 -07:00

[tip: perf/core] perf/amd/uncore: Fix sysfs type mismatch

2021-04-16 Thread tip-bot2 for Nathan Chancellor
The following commit has been merged into the perf/core branch of tip: Commit-ID: b04c0cddff6d1d6656c7f7c08c0b8f07eb287564 Gitweb: https://git.kernel.org/tip/b04c0cddff6d1d6656c7f7c08c0b8f07eb287564 Author:Nathan Chancellor AuthorDate:Wed, 14 Apr 2021 17:11:12 -07:00

[PATCH] drm/tegra: Fix shift overflow in tegra_shared_plane_atomic_update

2021-04-15 Thread Nathan Chancellor
bit and will not overflow. Fixes: 7b6f846785f4 ("drm/tegra: Support sector layout on Tegra194") Link: https://github.com/ClangBuiltLinux/linux/issues/1351 Signed-off-by: Nathan Chancellor --- drivers/gpu/drm/tegra/hub.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/dr

Re: [PATCH 1/2] x86/events/amd/iommu: Fix sysfs type mismatch

2021-04-15 Thread Nathan Chancellor
On Thu, Apr 15, 2021 at 08:53:35AM +0100, Christoph Hellwig wrote: > On Wed, Apr 14, 2021 at 05:11:11PM -0700, Nathan Chancellor wrote: > > dev_attr_show() calls _iommu_event_show() via an indirect call but > > _iommu_event_show()'s type does not currently match the type of the &g

Re: [PATCH 2/3] habanalabs: support legacy and new pll indexes

2021-04-15 Thread Nathan Chancellor
On Sun, Mar 21, 2021 at 10:11:29PM +0200, Oded Gabbay wrote: > From: Ohad Sharabi > > In order to use minimum of hard coded values common to LKD and F/W > a dynamic method to work with PLLs is introduced in this patch. > Formerly asic specific PLL numbering is now common for all asics. > To be

Re: [PATCH] arm64: alternatives: Move length validation in alternative_{insn,endif}

2021-04-15 Thread Nathan Chancellor
On Thu, Apr 15, 2021 at 10:17:43AM +0100, Catalin Marinas wrote: > Hi Nathan, > > On Tue, Apr 13, 2021 at 05:08:04PM -0700, Nathan Chancellor wrote: > > After commit 2decad92f473 ("arm64: mte: Ensure TIF_MTE_ASYNC_FAULT is > > set atomically"), LLVM's integrated a

Re: [PATCH v2] arm64: vdso32: drop -no-integrated-as flag

2021-04-14 Thread Nathan Chancellor
> remove those too. > > To test building: > $ ARCH=arm64 CROSS_COMPILE=aarch64-linux-gnu- \ > CROSS_COMPILE_COMPAT=arm-linux-gnueabi- make LLVM=1 LLVM_IAS=1 \ > defconfig arch/arm64/kernel/vdso32/ > > Suggested-by: Nathan Chancellor > Signed-off-by: Nick Desaulni

[PATCH 2/2] perf/amd/uncore: Fix sysfs type mismatch

2021-04-14 Thread Nathan Chancellor
perf/amd/uncore: Prepare to scale for more attributes that vary per family") Signed-off-by: Nathan Chancellor --- arch/x86/events/amd/uncore.c | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/arch/x86/events/amd/uncore.c b/arch/x86/events/amd/uncore.c index 7f014d

[PATCH 1/2] x86/events/amd/iommu: Fix sysfs type mismatch

2021-04-14 Thread Nathan Chancellor
d75 ("perf/x86/amd: AMD IOMMU Performance Counter PERF uncore PMU implementation") Signed-off-by: Nathan Chancellor --- arch/x86/events/amd/iommu.c | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/arch/x86/events/amd/iommu.c b/arch/x86/events/amd/iommu.

Re: [PATCH 03/13] Makefile: Generate CLANG_FLAGS even in GCC builds

2021-04-14 Thread Nathan Chancellor
Hi Miguel, On Wed, Apr 14, 2021 at 08:45:54PM +0200, oj...@kernel.org wrote: > From: Miguel Ojeda > > To support Rust under GCC-built kernels, we need to save the flags that > would have been passed if the kernel was being compiled with Clang. > > The reason is that bindgen -- the tool we use

[PATCH] arm64: alternatives: Move length validation in alternative_{insn,endif}

2021-04-13 Thread Nathan Chancellor
sn has not shown any issue yet but it appears that it could have the same issue in the future so just preemptively change it. Cc: sta...@vger.kernel.org Fixes: f7b93d42945c ("arm64/alternatives: use subsections for replacement sequences") Link: https://github.com/ClangBuiltLinux/linux/iss

Re: [PATCH] arm64: vdso32: drop -no-integrated-as flag

2021-04-13 Thread Nathan Chancellor
On Tue, Apr 13, 2021 at 04:06:06PM -0700, Nick Desaulniers wrote: > Clang can assemble these files just fine; this is a relic from the top > level Makefile conditionally adding this. > > To test building: > $ ARCH=arm64 CROSS_COMPILE=aarch64-linux-gnu- \ >

Re: arch/arm64/kvm/perf.c:58:36: error: implicit declaration of function 'perf_num_counters'

2021-04-13 Thread Nathan Chancellor
On Fri, Mar 26, 2021 at 08:27:13PM +0800, kernel test robot wrote: > Hi Marc, > > FYI, the error/warning still remains. > > tree: https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git > master > head: db24726bfefa68c606947a86132591568a06bfb4 > commit:

[PATCH] crypto: arm/curve25519 - Move '.fpu' after '.arch'

2021-04-09 Thread Nathan Chancellor
: d8f1308a025f ("crypto: arm/curve25519 - wire up NEON implementation") Link: https://github.com/ClangBuiltLinux/continuous-integration2/issues/118 Reported-by: Arnd Bergmann Suggested-by: Arnd Bergmann Suggested-by: Jessica Clarke Signed-off-by: Nathan Chancellor --- arch/arm/crypto/

[PATCH] MIPS: generic: Update node names to avoid unit addresses

2021-04-09 Thread Nathan Chancellor
://source.denx.de/u-boot/u-boot/-/commit/79af75f7776fc20b0d7eb6afe1e27c00fdb4b9b4 Link: https://source.denx.de/u-boot/u-boot/-/commit/3f04db891a353f4b127ed57279279f851c6b4917 Suggested-by: Simon Glass Signed-off-by: Nathan Chancellor --- arch/mips/generic/board-boston.its.S | 10 +- arch

[PATCH] block: Disable -Walign-mismatch for blk-mq.c

2021-04-08 Thread Nathan Chancellor
ld4@archlinux-ax161/ Link: https://lore.kernel.org/r/20210330230249.709221-1-jian...@google.com/ Signed-off-by: Nathan Chancellor --- block/Makefile | 1 + 1 file changed, 1 insertion(+) diff --git a/block/Makefile b/block/Makefile index 8d841f5f986f..d69ac0bd8e61 100644 --- a/block/Makefil

Re: [PATCH] blk-mq: fix alignment mismatch.

2021-04-08 Thread Nathan Chancellor
3:06 PM Nick Desaulniers > wrote: > > > > On Wed, Mar 31, 2021 at 2:58 PM Nathan Chancellor wrote: > > > > > > On Wed, Mar 31, 2021 at 02:27:03PM -0700, Jian Cai wrote: > > > > > > > > I just realized you already proposed solutio

Re: [PATCH v9] pgo: add clang's Profile Guided Optimization infrastructure

2021-04-07 Thread Nathan Chancellor
html#profile-guided-optimization > > Signed-off-by: Sami Tolvanen > Co-developed-by: Bill Wendling > Signed-off-by: Bill Wendling > Tested-by: Nick Desaulniers > Reviewed-by: Nick Desaulniers > Reviewed-by: Fangrui Song Few small nits below, not sure they warrant a v10 ver

[PATCH] ACPI / CPPC: Replace cppc_attr with kobj_attribute

2021-04-07 Thread Nathan Chancellor
e delivered performance") Link: https://github.com/ClangBuiltLinux/linux/issues/1343 Signed-off-by: Nathan Chancellor --- drivers/acpi/cppc_acpi.c | 14 +++--- 1 file changed, 3 insertions(+), 11 deletions(-) diff --git a/drivers/acpi/cppc_acpi.c b/drivers/acpi/cppc_acpi.c index 6905

Re: [PATCH 2/2] gcov: re-drop support for clang-10

2021-04-07 Thread Nathan Chancellor
GCOV support. > > Signed-off-by: Nick Desaulniers Reviewed-by: Nathan Chancellor > --- > kernel/gcov/clang.c | 40 > 1 file changed, 40 deletions(-) > > diff --git a/kernel/gcov/clang.c b/kernel/gcov/clang.c > index 1747204541bf..78c

Re: [PATCH 1/2] gcov: re-fix clang-11+ support

2021-04-07 Thread Nathan Chancellor
ular, in clang-11, the additional checksum is no longer optional. > > Link: https://reviews.llvm.org/rG25544ce2df0daa4304c07e64b9c8b0f7df60c11d > Cc: sta...@vger.kernel.org #5.4+ > Reported-by: Prasad Sodagudi > Tested-by: Prasad Sodagudi > Signed-off-by: Nick Desaulniers Review

Re: CFI violation in drivers/infiniband/core/sysfs.c

2021-04-03 Thread Nathan Chancellor
On Fri, Apr 02, 2021 at 04:03:30PM -0700, Kees Cook wrote: > On Fri, Apr 02, 2021 at 12:52:41PM -0700, Nathan Chancellor wrote: > > Hi all, > > > > I am testing the Clang Control Flow Integrity series that is being > > worked on right now [1] and I encounter a

Re: [PATCH 3/3] kbuild: fix false-positive modpost warning when all symbols are trimmed

2021-04-02 Thread Nathan Chancellor
, show only >the first 10, and also the number of suppressed warnings. > > [1]: > https://git.kernel.org/pub/scm/linux/kernel/git/history/history.git/commit/?id=1cc0e0529569bf6a94f6d49770aa6d4b599d2c46 > > Reported-by: Nathan Chancellor > Signed-off-by: Masahi

Re: [PATCH v5 00/18] Add support for Clang CFI

2021-04-02 Thread Nathan Chancellor
iles changed, 759 insertions(+), 113 deletions(-) > create mode 100644 include/linux/cfi.h > create mode 100644 kernel/cfi.c > > > base-commit: 6905b1dc3c32a094f0da61bd656a740f0a97d592 > -- > 2.31.0.208.g409f899ff0-goog > Hi Sami, I booted this series on Equinix's c1.large.arm (2x Cavium ThunderX CN8890) and c2.large.arm (1x Ampere eMAG 8180) servers [1] and my Raspberry Pi 4B. I ran them through LTP's read_all test case on both /proc and /sys and a few compile workloads, only uncovering one issue [2]. Consider this series: Tested-by: Nathan Chancellor [1]: https://metal.equinix.com/developers/docs/servers/ [2]: https://lore.kernel.org/r/20210402195241.gahc5w25gezluw7p@archlinux-ax161/ Cheers, Nathan

CFI violation in drivers/infiniband/core/sysfs.c

2021-04-02 Thread Nathan Chancellor
Hi all, I am testing the Clang Control Flow Integrity series that is being worked on right now [1] and I encounter a violation in the Infiniband sysfs core (drivers/infiniband/core/sysfs.c) on an arm64 server with mlx5: $ cat /sys/class/infiniband/mlx5_bond_0/ports/1/hw_counters/lifespan 12 $

Re: [PATCH] qemu_fw_cfg: Make fw_cfg_rev_attr a proper kobj_attribute

2021-04-02 Thread Nathan Chancellor
On Fri, Apr 02, 2021 at 11:25:42AM -0700, Kees Cook wrote: > On Fri, Apr 02, 2021 at 08:42:07AM +0200, Sedat Dilek wrote: > > On Thu, Feb 25, 2021 at 10:25 PM Kees Cook wrote: > > > > > > On Thu, 11 Feb 2021 12:42:58 -0700, Nathan Chancellor wrote: > &g

Re: [PATCH] ARM: OMAP: Fix use of possibly uninitialized irq variable

2021-04-01 Thread Nathan Chancellor
^ > = 0 > 1 warning generated. > > The patch provides a default value to the `irq` variable > along with a validity check. > Might be worth a fixes tag: Fixes: b75ca5217743 ("ARM: OMAP: replace setup_irq() by request_irq()") > S

Re: [PATCH] usb: isp1301-omap: Add missing gpiod_add_lookup_table function

2021-04-01 Thread Nathan Chancellor
e3d ("usb: isp1301-omap: Convert to use GPIO descriptors") > Link: https://github.com/ClangBuiltLinux/linux/issues/1325 Thanks for the patch! Reviewed-by: Nathan Chancellor > --- > arch/arm/mach-omap1/board-h2.c | 4 +++- > 1 file changed, 3 insertions(+), 1 deletion(-) >

Re: [PATCH] ARM: OMAP1: ams-delta: remove unused function ams_delta_camera_power

2021-04-01 Thread Nathan Chancellor
ki > Fixes: ce548396a433 ("media: mach-omap1: board-ams-delta.c: remove soc_camera > dependencies") > Link: https://github.com/ClangBuiltLinux/linux/issues/1326 Thanks for the patch! Reviewed-by: Nathan Chancellor > --- > arch/arm/mach-omap1/board-ams-delta.c | 14 -

Re: [PATCH] blk-mq: fix alignment mismatch.

2021-03-31 Thread Nathan Chancellor
r 30, 2021 at 6:31 PM Jian Cai wrote: > > > > Thanks for all the information. I'll check for similar instances and > > send an updated version. > > > > > > On Tue, Mar 30, 2021 at 5:26 PM Guenter Roeck wrote: > > > > > > On 3/30/21 4:29 PM, Nathan C

Re: [PATCH] blk-mq: fix alignment mismatch.

2021-03-30 Thread Nathan Chancellor
Hi Jian, On Tue, Mar 30, 2021 at 04:02:49PM -0700, Jian Cai wrote: > This fixes the mismatch of alignments between csd and its use as an > argument to smp_call_function_single_async, which causes build failure > when -Walign-mismatch in Clang is used. > > Link: > http://crrev.com/c/1193732 > >

Re: [PATCH] riscv: Use $(LD) instead of $(CC) to link vDSO

2021-03-26 Thread Nathan Chancellor
tree, kindly drop us a note. > And when submitting patch, we suggest to use '--base' as documented in > https://git-scm.com/docs/git-format-patch] > > url: > https://github.com/0day-ci/linux/commits/Nathan-Chancellor/riscv-Use-LD-instead-of-CC-to-link-vDSO/20210326-055421 > base:

[tip: x86/build] efi/libstub: Add $(CLANG_FLAGS) to x86 flags

2021-03-26 Thread tip-bot2 for Nathan Chancellor
The following commit has been merged into the x86/build branch of tip: Commit-ID: 58d746c119dfa28e72fc35aacaf3d2a3ac625cd0 Gitweb: https://git.kernel.org/tip/58d746c119dfa28e72fc35aacaf3d2a3ac625cd0 Author:Nathan Chancellor AuthorDate:Thu, 25 Mar 2021 17:04:35 -07:00

[tip: x86/build] x86/boot: Add $(CLANG_FLAGS) to compressed KBUILD_CFLAGS

2021-03-26 Thread tip-bot2 for Nathan Chancellor
The following commit has been merged into the x86/build branch of tip: Commit-ID: d5cbd80e302dfea59726c44c56ab7957f822409f Gitweb: https://git.kernel.org/tip/d5cbd80e302dfea59726c44c56ab7957f822409f Author:Nathan Chancellor AuthorDate:Thu, 25 Mar 2021 17:04:34 -07:00

Re: [PATCH 0/3] Fix CONFIG_FUNCTION_TRACER with clang

2021-03-26 Thread Nathan Chancellor
On Fri, Mar 26, 2021 at 09:37:55AM +0100, Sedat Dilek wrote: > On Thu, Mar 25, 2021 at 11:38 PM Nathan Chancellor wrote: > > > > Hi all, > > > > This series fixes function tracing with clang. > > > > Patch 1 adjusts the mcount regex in scripts/recordmcou

[PATCH 3/3] efi/libstub: Add $(CLANG_FLAGS) to x86 flags

2021-03-25 Thread Nathan Chancellor
that cross compiling works as expected. Signed-off-by: Nathan Chancellor --- drivers/firmware/efi/libstub/Makefile | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/drivers/firmware/efi/libstub/Makefile b/drivers/firmware/efi/libstub/Makefile index c23466e05e60..d0537573501e 100644

[PATCH 2/3] x86/boot: Add $(CLANG_FLAGS) to compressed KBUILD_CFLAGS

2021-03-25 Thread Nathan Chancellor
as expected. Signed-off-by: Nathan Chancellor --- arch/x86/boot/compressed/Makefile | 1 + 1 file changed, 1 insertion(+) diff --git a/arch/x86/boot/compressed/Makefile b/arch/x86/boot/compressed/Makefile index e0bc3988c3fa..6e5522aebbbd 100644 --- a/arch/x86/boot/compressed/Makefile +++ b/arch/x86/boot

[PATCH 0/3] Fix cross compiling x86 with clang

2021-03-25 Thread Nathan Chancellor
this on an ARM based server with both defconfig and allmodconfig, where the build now passes. Please let me know if there are any problems. Cheers, Nathan John Millikin (1): x86: Propagate $(CLANG_FLAGS) to $(REALMODE_FLAGS) Nathan Chancellor (2): x86/boot: Add $(CLANG_FLAGS) to compressed

[PATCH 1/3] x86: Propagate $(CLANG_FLAGS) to $(REALMODE_FLAGS)

2021-03-25 Thread Nathan Chancellor
  parse certain GNU extensions. Signed-off-by: John Millikin Tested-by: Sedat Dilek Signed-off-by: Nathan Chancellor --- arch/x86/Makefile | 1 + 1 file changed, 1 insertion(+) diff --git a/arch/x86/Makefile b/arch/x86/Makefile index 2d6d5a28c3bf..9a73e0cea19c 100644 --- a/arch/x86/Makefile +++ b

[PATCH 3/3] riscv: Select HAVE_DYNAMIC_FTRACE when -fpatchable-function-entry is available

2021-03-25 Thread Nathan Chancellor
("riscv: Using PATCHABLE_FUNCTION_ENTRY instead of MCOUNT") Link: https://github.com/ClangBuiltLinux/linux/issues/1268 Reported-by: kernel test robot Signed-off-by: Nathan Chancellor --- arch/riscv/Kconfig | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/arch/riscv/Kcon

[PATCH 2/3] riscv: Workaround mcount name prior to clang-13

2021-03-25 Thread Nathan Chancellor
ng version is 10.0.1. To avoid build errors and to gain a working function tracer, adjust the name of the mcount symbol for older versions of clang in mount.S and recordmcount.pl. Cc: sta...@vger.kernel.org Link: https://github.com/ClangBuiltLinux/linux/issues/1331 Signed-off-by: Nathan Chancellor ---

[PATCH 1/3] scripts/recordmcount.pl: Fix RISC-V regex for clang

2021-03-25 Thread Nathan Chancellor
is properly generated and function tracing still works. Cc: sta...@vger.kernel.org Link: https://github.com/ClangBuiltLinux/linux/issues/1331 Signed-off-by: Nathan Chancellor --- scripts/recordmcount.pl | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/scripts/recordmcount.pl b/scripts

[PATCH 0/3] Fix CONFIG_FUNCTION_TRACER with clang

2021-03-25 Thread Nathan Chancellor
ackported (patches 1 and 2 are already marked for stable). This series has been build tested with gcc-8 through gcc-10 and clang-11 through clang-13 with defconfig and nommu_virt_defconfig plus CONFIG_FTRACE=y and CONFIG_FUNCTION_TRACER=y then boot tested under QEMU. Cheers, Nathan Nathan Chanc

[PATCH] riscv: Use $(LD) instead of $(CC) to link vDSO

2021-03-25 Thread Nathan Chancellor
dified, use the $(OBJCOPY) variable instead of an open coded $(CROSS_COMPILE)objcopy so that the user's choice of objcopy binary is respected. Link: https://github.com/ClangBuiltLinux/linux/issues/803 Link: https://github.com/ClangBuiltLinux/linux/issues/970 Signed-off-by: Nathan Chancellor --

Re: [PATCH] arm64: move --fix-cortex-a53-843419 linker test to Kconfig

2021-03-24 Thread Nathan Chancellor
once, and store it in the > .config file. The build and installation steps that follow do not need > to test the liniker over again. > > Reported-by: Nathan Chancellor > Signed-off-by: Masahiro Yamada Tested-by: Nathan Chancellor Reviewed-by: Nathan Chancellor Thanks for the q

Re: [PATCH v5] x86/Hyper-V: Support for free page reporting

2021-03-23 Thread Nathan Chancellor
. This patch adds the support to hook into the free > page reporting infrastructure and leverage the Hyper-V cold memory > discard hint hypercall to report/free these pages back to the host. > > Signed-off-by: Sunil Muthuswamy > Tested-by: Matheus Castello Tested-by: Nathan

Re: [PATCH] Makefile: fix GDB warning with CONFIG_RELR

2021-03-23 Thread Nathan Chancellor
e about these numbers; it determines the > location of the RELR section using symbols defined by a linker script. > > Link: https://github.com/ClangBuiltLinux/linux/issues/1057 > Suggested-by: Peter Collingbourne > Signed-off-by: Nick Desaulniers Reviewed-by: Nathan Chancellor > --- &g

Re: [PATCH] pinctrl: qcom: fix unintentional string concatenation

2021-03-23 Thread Nathan Chancellor
o22", >^ > Add the missing comma that must have accidentally been removed. > > Fixes: ac43c44a7a37 ("pinctrl: qcom: Add SDX55 pincontrol driver") > Signed-off-by: Arnd Bergmann Reviewed-by: Na

Re: [PATCH] clang-format: Update ColumnLimit

2021-03-19 Thread Nathan Chancellor
On Fri, Mar 19, 2021 at 07:37:14PM +0100, Ansuel Smith wrote: > Update ColumnLimit value, changed from 80 to 100. > > Signed-off-by: Ansuel Smith > --- > .clang-format | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/.clang-format b/.clang-format > index

Re: Clang: powerpc: kvm/book3s_hv_nested.c:264:6: error: stack frame size of 2480 bytes in function 'kvmhv_enter_nested_guest'

2021-03-19 Thread Nathan Chancellor
Hi Naresh, Thank you for the testing and report. On Fri, Mar 19, 2021 at 12:50:42PM +0530, Naresh Kamboju wrote: > Linux mainline master build breaks for powerpc defconfig. > There are multiple errors / warnings with clang-12 and clang-11 and 10. > - powerpc (defconfig) with clang-12 > -

Re: [PATCH 4/4] kbuild: include Makefile.compiler only when compiler is required

2021-03-18 Thread Nathan Chancellor
On Sun, Feb 28, 2021 at 03:10:28PM +0900, Masahiro Yamada wrote: > Since commit f2f02ebd8f38 ("kbuild: improve cc-option to clean up all > temporary files"), running 'make kernelversion' in a read-only source > tree emits a bunch of warnings: > > mkdir: cannot create directory '.tmp_12345':

Re: [PATCH v2 2/2] gcov: clang: drop support for clang-10 and older

2021-03-15 Thread Nathan Chancellor
; interested in GCOV support. > > Link: https://reviews.llvm.org/rGcdd683b516d147925212724b09ec6fb792a40041 > Link: https://reviews.llvm.org/rG13a633b438b6500ecad9e4f936ebadf3411d0f44 > Suggested-by: Nathan Chancellor > Signed-off-by: Nick Desaulniers Reviewed-by: Nathan Chancel

Re: [PATCH v2 1/2] gcov: fix clang-11+ support

2021-03-15 Thread Nathan Chancellor
00ecad9e4f936ebadf3411d0f44 > Cc: sta...@vger.kernel.org # 5.4 > Reported-by: Prasad Sodagudi > Suggested-by: Nathan Chancellor > Reviewed-by: Fangrui Song > Signed-off-by: Nick Desaulniers > Tested-by: Nathan Chancellor Reviewed-by: Nathan Chancellor > --- > Cha

Re: [PATCH v2 2/3] kbuild: check the minimum assembler version in Kconfig

2021-03-15 Thread Nathan Chancellor
plemented scripts/as-version.sh to > check the assembler version in Kconfig time. > > $ scripts/as-version.sh gcc > GNU 23501 > $ scripts/as-version.sh clang -no-integrated-as > GNU 23501 > $ scripts/as-version.sh clang -integrated-as > LLVM 0 > > [1]: https://

Re: [PATCH] staging: andriod: ashmem: Declared file operation with const keyword

2021-03-13 Thread Nathan Chancellor
On Sat, Mar 13, 2021 at 10:59:43PM +0530, B K Karthik wrote: > On Sat, Mar 13, 2021 at 10:57 PM namratajanawade > wrote: > > > > Warning found by checkpatch.pl script. > > That doesn't tell what you did or why you did it. Please write an > appropriate commit description and resend the patch. >

Re: [PATCH] gcov: fix clang-11+ support

2021-03-12 Thread Nathan Chancellor
On Fri, Mar 12, 2021 at 01:57:47PM -0800, 'Nick Desaulniers' via Clang Built Linux wrote: > On Fri, Mar 12, 2021 at 12:51 PM Nathan Chancellor wrote: > > > > On Fri, Mar 12, 2021 at 12:14:42PM -0800, Nick Desaulniers wrote: > > > On Fri, Mar 12, 2021 at 11:58 AM Nathan

Re: [PATCH] gcov: fix clang-11+ support

2021-03-12 Thread Nathan Chancellor
On Fri, Mar 12, 2021 at 12:14:42PM -0800, Nick Desaulniers wrote: > On Fri, Mar 12, 2021 at 11:58 AM Nathan Chancellor wrote: > > > > On Fri, Mar 12, 2021 at 11:21:39AM -0800, Nick Desaulniers wrote: > > > LLVM changed the expected function signatures

Re: [PATCH] gcov: fix clang-11+ support

2021-03-12 Thread Nathan Chancellor
saulniers I can reproduce the panic (as a boot hang) in QEMU before this patch and it is resolved after it so: Tested-by: Nathan Chancellor However, the duplication hurts :( would it potentially be better to just do the full update to clang-11+ and require it for CONFIG_GCOV_KERNEL?

Re: [PATCH] kbuild: fix ld-version.sh to not be affected by locale

2021-03-12 Thread Nathan Chancellor
_ALL is set on the user's environment. > > Link: https://bugzilla.kernel.org/show_bug.cgi?id=212105 > Reported-by: Marco Scardovi > Signed-off-by: Masahiro Yamada LGTM, this is Debian's recommendation as well: https://wiki.debian.org/Locale Reviewed-by: Nathan Chancellor > --- > >

[PATCH] ARM: Make UNWINDER_ARM depend on ld.bfd or ld.lld 11.0.0+

2021-03-10 Thread Nathan Chancellor
Suggested-by: Nick Desaulniers Signed-off-by: Nathan Chancellor --- arch/arm/Kconfig.debug | 2 ++ 1 file changed, 2 insertions(+) diff --git a/arch/arm/Kconfig.debug b/arch/arm/Kconfig.debug index 9e0b5e7f12af..64c1f8a46ab5 100644 --- a/arch/arm/Kconfig.debug +++ b/arch/arm/Kconfig.debug

Re: -Walign-mismatch in block/blk-mq.c

2021-03-10 Thread Nathan Chancellor
On Wed, Mar 10, 2021 at 02:03:56PM -0700, Jens Axboe wrote: > On 3/10/21 1:52 PM, Nathan Chancellor wrote: > > On Wed, Mar 10, 2021 at 01:40:25PM -0700, Jens Axboe wrote: > >> On 3/10/21 1:33 PM, Nathan Chancellor wrote: > >>> On Wed, Mar 10, 2021 at 01:21:52PM -0700,

Re: -Walign-mismatch in block/blk-mq.c

2021-03-10 Thread Nathan Chancellor
On Wed, Mar 10, 2021 at 01:40:25PM -0700, Jens Axboe wrote: > On 3/10/21 1:33 PM, Nathan Chancellor wrote: > > On Wed, Mar 10, 2021 at 01:21:52PM -0700, Jens Axboe wrote: > >> On 3/10/21 11:23 AM, Nathan Chancellor wrote: > >>> Hi Jens, > >>>

Re: -Walign-mismatch in block/blk-mq.c

2021-03-10 Thread Nathan Chancellor
On Wed, Mar 10, 2021 at 01:21:52PM -0700, Jens Axboe wrote: > On 3/10/21 11:23 AM, Nathan Chancellor wrote: > > Hi Jens, > > > > There is a new clang warning added in the development branch, > > -Walign-mismatch, which shows an instance in block/blk-mq.c: > > &

-Walign-mismatch in block/blk-mq.c

2021-03-10 Thread Nathan Chancellor
Hi Jens, There is a new clang warning added in the development branch, -Walign-mismatch, which shows an instance in block/blk-mq.c: block/blk-mq.c:630:39: warning: passing 8-byte aligned argument to 32-byte aligned parameter 2 of 'smp_call_function_single_async' may result in an unaligned

[PATCH v2 2/2] Makefile: Only specify '--prefix=' when building with clang + GNU as

2021-03-09 Thread Nathan Chancellor
07@Ryzen-5-4500U.localdomain/ Signed-off-by: Nathan Chancellor --- v1 -> v2: * Fix position of -no-integrated-as flag to fix native build (thanks to Masahiro for catching it and sorry for the breakage). * Add Fangrui's comments about what GNU binaries clang can spawn at Masahir

[PATCH v2 1/2] Makefile: Remove '--gcc-toolchain' flag

2021-03-09 Thread Nathan Chancellor
nc' and '-nostdlib'. This has been verified with self compiled LLVM 10.0.1 and LLVM 13.0.0 as well as a distribution version of LLVM 11.1.0 without binutils in the LLVM toolchain locations. Link: https://reviews.llvm.org/D97902 Signed-off-by: Nathan Chancellor --- v1 -> v2: * Improve commit

Re: [PATCH] kbuild: dummy-tools: adjust to scripts/cc-version.sh

2021-03-09 Thread Nathan Chancellor
t; > Fixes: aec6c60a01d3 ("kbuild: check the minimum compiler version in Kconfig") > Signed-off-by: Masahiro Yamada Reviewed-by: Nathan Chancellor Tested-by: Nathan Chancellor > --- > > Perhaps, Jiri may have already noticed this issue, and have a similar patch. >

Re: [PATCH] Fix ld-version.sh script if LLD was built with LLD_VENDOR

2021-03-09 Thread Nathan Chancellor
nce LLD_VENDOR can contain spaces, the > LLD identifier isn't guaranteed to be $2 either. > > Adjust the version checker to handle such versions of lld. > > Link: > https://lore.kernel.org/lkml/20210302221211.1620858-1-b...@lindev.ch/ > Signed-off-by: Bernhar

Re: [PATCH 3/4] kbuild: check the minimum assembler version in Kconfig

2021-03-06 Thread Nathan Chancellor
On Sat, Mar 06, 2021 at 02:48:38AM +0900, Masahiro Yamada wrote: > On Fri, Mar 5, 2021 at 10:26 AM Nick Desaulniers > wrote: > > > > On Wed, Mar 3, 2021 at 10:34 AM Masahiro Yamada > > wrote: > > > > > > Documentation/process/changes.rst defines the minimum assembler version > > > (binutils

Re: [PATCH] KVM: arm64: Don't use cbz/adr with external symbols

2021-03-06 Thread Nathan Chancellor
ces hyp_panic > >>> defined in vmlinux.o > > This is because with LTO, the compiler ends up placing hyp_panic() > more than 1MB away from __guest_enter(). Use an unconditional branch > and adr_l instead to fix the issue. > > Link: https://github.com/ClangBuiltLinux/linux/is

Re: [PATCH v2] certs: Fix wrong kconfig option used for x509_revocation_list

2021-03-04 Thread Nathan Chancellor
g/keyrings/eda280f9-f72d-4181-93c7-cdbe95976...@oracle.com/T/#m07e258bf019ccbac23820fad5192ceffa74fc6ab > > Reported-by: Randy Dunlap > Signed-off-by: Eric Snowberg This seems to fix my build errors. Tested-by: Nathan Chancellor > --- > v2 changes: > Use the

Re: [PATCH v2] MIPS: Make MIPS32_O32 depends on !CC_IS_CLANG

2021-03-03 Thread Nathan Chancellor
s on !CC_IS_CLANG. > > [1] https://www.kernel.org/doc/html/latest/kbuild/llvm.html > [2] https://bugs.llvm.org/show_bug.cgi?id=38063 > > Signed-off-by: Tiezhu Yang I don't know if Nick will have any comments but for me: Acked-by: Nathan Chancellor I have added this patch and

Re: [PATCH] MIPS: Add comment about CONFIG_MIPS32_O32 in loongson3_defconfig when build with Clang

2021-03-03 Thread Nathan Chancellor
On Thu, Mar 04, 2021 at 11:48:09AM +0800, Tiezhu Yang wrote: > On 03/04/2021 10:02 AM, Nathan Chancellor wrote: > > On Thu, Mar 04, 2021 at 09:15:44AM +0800, Tiezhu Yang wrote: > > > When build kernel with Clang [1]: > > > > > > $ make CC=clang loongson3_defcon

Re: [PATCH] MIPS: Add comment about CONFIG_MIPS32_O32 in loongson3_defconfig when build with Clang

2021-03-03 Thread Nathan Chancellor
On Thu, Mar 04, 2021 at 09:15:44AM +0800, Tiezhu Yang wrote: > When build kernel with Clang [1]: > > $ make CC=clang loongson3_defconfig > $ make CC=clang > > there exists the following error: > > Checking missing-syscalls for O32 > CALLscripts/checksyscalls.sh > error: ABI 'o32' is not

Re: [PATCH 4/4] kbuild: dwarf: use AS_VERSION instead of test_dwarf5_support.sh

2021-03-03 Thread Nathan Chancellor
F v5 from > C code is as follows: > > - gcc + binutils as -> requires gcc 5.0+ (but 7.0+ for full support) > - clang + binutils as -> requires binutils 2.35.2+ > - clang + integrated as -> OK > > Signed-off-by: Masahiro Yamada Reviewed-by: Nathan Chancellor

Re: [PATCH 3/4] kbuild: check the minimum assembler version in Kconfig

2021-03-03 Thread Nathan Chancellor
On Thu, Mar 04, 2021 at 03:33:32AM +0900, Masahiro Yamada wrote: > Documentation/process/changes.rst defines the minimum assembler version > (binutils version), but we have never checked it in the build time. > > Kbuild never invokes 'as' directly because all assembly files in the > kernel tree

Re: [PATCH 1/4] kbuild: remove LLVM=1 test from HAS_LTO_CLANG

2021-03-03 Thread Nathan Chancellor
uot;${LLVM}" = 1 > echo $? > 1 > > $ test -n "${LLVM}" > $ echo $? > 1 > > Signed-off-by: Masahiro Yamada Yes, there is not too much point of checking if $(LLVM) is set or not because we already check for the other tools. Reviewed-by: Nathan Chancel

Re: [PATCH 2/4] kbuild: collect minimum tool versions into scripts/tool-version.sh

2021-03-03 Thread Nathan Chancellor
h binutils > 2.23.0 > $ scripts/tool-version.sh foo > foo: unknown tool > > Signed-off-by: Masahiro Yamada Reviewed-by: Nathan Chancellor Two comments below. > --- > > scripts/cc-version.sh | 20 +--- > scripts/ld-version.sh | 11

Re: [PATCH 3/4] certs: Add ability to preload revocation certs

2021-03-03 Thread Nathan Chancellor
On Thu, Feb 25, 2021 at 08:58:55PM +, David Howells wrote: > From: Eric Snowberg > > Add a new Kconfig option called SYSTEM_REVOCATION_KEYS. If set, > this option should be the filename of a PEM-formated file containing > X.509 certificates to be included in the default blacklist keyring. >

Re: [PATCH] Fix ld-version.sh script if LLD was built with LLD_VENDOR

2021-03-03 Thread Nathan Chancellor
On Wed, Mar 03, 2021 at 08:38:06PM +0900, Masahiro Yamada wrote: > On Wed, Mar 3, 2021 at 1:02 PM Nathan Chancellor wrote: > > > > Hi Bernhard, > > > > I have added the ClangBuiltLinux mailing list, kbuild mailing list, and > > Masahiro and Nick to CC. Maybe ld-ve

Re: [PATCH] Fix ld-version.sh script if LLD was built with LLD_VENDOR

2021-03-03 Thread Nathan Chancellor
Hi Bernhard, I have added the ClangBuiltLinux mailing list, kbuild mailing list, and Masahiro and Nick to CC. Maybe ld-version.sh and cc-version.sh should be added to a MAINTAINERS entry to make sure we get CC'd (I can send one along tomorrow). On Tue, Mar 02, 2021 at 11:12:11PM +0100, Bernhard

[PATCH 1/2] Makefile: Remove '--gcc-toolchain' flag

2021-03-02 Thread Nathan Chancellor
. Signed-off-by: Nathan Chancellor --- Makefile | 4 1 file changed, 4 deletions(-) diff --git a/Makefile b/Makefile index f9b54da2fca0..c20f0ad8be73 100644 --- a/Makefile +++ b/Makefile @@ -568,10 +568,6 @@ ifneq ($(CROSS_COMPILE),) CLANG_FLAGS+= --target=$(notdir $(CROSS_COMPILE

[PATCH 2/2] Makefile: Only specify '--prefix=' when building with clang + GNU as

2021-03-02 Thread Nathan Chancellor
does not depend on the value of '--prefix='. Sharing commands to reproduce issues becomes a little bit easier without a '--prefix=' value because that '--prefix=' value is specific to a user's machine due to it being an absolute path. Signed-off-by: Nathan Chancellor --- Makefile | 4 ++-- 1 file

[PATCH] powerpc/prom: Mark identical_pvr_fixup as __init

2021-03-02 Thread Nathan Chancellor
;). Fixes: 14b3d926a22b ("[POWERPC] 4xx: update 440EP(x)/440GR(x) identical PVR issue workaround") Link: https://github.com/ClangBuiltLinux/linux/issues/1316 Signed-off-by: Nathan Chancellor --- arch/powerpc/kernel/prom.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a

[PATCH] powerpc/fadump: Mark fadump_calculate_reserve_size as __init

2021-03-02 Thread Nathan Chancellor
it is worthwhile since commit 889b3c1245de ("compiler: remove CONFIG_OPTIMIZE_INLINING entirely"). Fixes: 11550dc0a00b ("powerpc/fadump: reuse crashkernel parameter for fadump memory reservation") Link: https://github.com/ClangBuiltLinux/linux/issues/1300 Signed-off-by: Nathan Chancel

Re: [PATCH RFC] x86: remove toolchain check for X32 ABI capability

2021-02-27 Thread Nathan Chancellor
On Sat, Feb 27, 2021 at 11:49:36PM -0700, Nathan Chancellor wrote: > On Sun, Feb 28, 2021 at 12:15:16PM +0900, Masahiro Yamada wrote: > > On Sun, Feb 28, 2021 at 3:41 AM Masahiro Yamada > > wrote: > > > > > > This commit reverts 0bf6276392e9 ("x32: Wa

Re: [PATCH RFC] x86: remove toolchain check for X32 ABI capability

2021-02-27 Thread Nathan Chancellor
On Sun, Feb 28, 2021 at 12:15:16PM +0900, Masahiro Yamada wrote: > On Sun, Feb 28, 2021 at 3:41 AM Masahiro Yamada wrote: > > > > This commit reverts 0bf6276392e9 ("x32: Warn and disable rather than > > error if binutils too old"). > > > > The help text in arch/x86/Kconfig says enabling the X32

  1   2   3   4   5   6   7   8   9   10   >