Re: [PATCH] tty/serial: fix config dependencies for samsung serial

2014-09-03 Thread Naveen Krishna Ch
Hi Arnd, On 2 September 2014 21:16, Arnd Bergmann wrote: > On Tuesday 02 September 2014 20:52:00 Naveen Krishna Chatradhi wrote: >> Make the config symbols SERIAL_SAMSUNG_UARTS_4 and >> SERIAL_SAMSUNG_UARTS depend on SERIAL_SAMSUNG rather than >> PLAT_SAMSUNG. > > Please always describe why you

Re: [PATCH] tty/serial: fix config dependencies for samsung serial

2014-09-03 Thread Naveen Krishna Ch
Hi Arnd, On 2 September 2014 21:16, Arnd Bergmann a...@arndb.de wrote: On Tuesday 02 September 2014 20:52:00 Naveen Krishna Chatradhi wrote: Make the config symbols SERIAL_SAMSUNG_UARTS_4 and SERIAL_SAMSUNG_UARTS depend on SERIAL_SAMSUNG rather than PLAT_SAMSUNG. Please always describe why

Re: [PATCHv6 0/4] iio: adc: exynos_adc: Support Exynos3250 ADC and code clean

2014-07-18 Thread Naveen Krishna Ch
Hello All, On 18 July 2014 15:43, Naveen Krishna Ch wrote: > Hello Arnd, > > On 18 July 2014 15:08, Arnd Bergmann wrote: >> On Friday 18 July 2014 14:59:42 Chanwoo Choi wrote: >>> This patchset support Exynos3250 ADC (Analog Digital Converter) because >>> Exynos

Re: [PATCHv6 0/4] iio: adc: exynos_adc: Support Exynos3250 ADC and code clean

2014-07-18 Thread Naveen Krishna Ch
Hello Arnd, On 18 July 2014 15:08, Arnd Bergmann wrote: > On Friday 18 July 2014 14:59:42 Chanwoo Choi wrote: >> This patchset support Exynos3250 ADC (Analog Digital Converter) because >> Exynos3250 has additional special clock for ADC IP. >> > > by coincidence, I have just looked at the same

Re: [PATCHv6 1/4] iio: adc: exynos_adc: Add exynos_adc_data structure to improve readability

2014-07-18 Thread Naveen Krishna Ch
Hello Arnd, On 18 July 2014 15:12, Arnd Bergmann wrote: > On Friday 18 July 2014 14:59:43 Chanwoo Choi wrote: >> This patchset add 'exynos_adc_data' structure which includes some functions >> to control ADC operation and specific data according to ADC version (v1 or >> v2). >> > > This new

Re: [PATCHv6 1/4] iio: adc: exynos_adc: Add exynos_adc_data structure to improve readability

2014-07-18 Thread Naveen Krishna Ch
Hello Arnd, On 18 July 2014 15:12, Arnd Bergmann a...@arndb.de wrote: On Friday 18 July 2014 14:59:43 Chanwoo Choi wrote: This patchset add 'exynos_adc_data' structure which includes some functions to control ADC operation and specific data according to ADC version (v1 or v2). This new

Re: [PATCHv6 0/4] iio: adc: exynos_adc: Support Exynos3250 ADC and code clean

2014-07-18 Thread Naveen Krishna Ch
Hello Arnd, On 18 July 2014 15:08, Arnd Bergmann a...@arndb.de wrote: On Friday 18 July 2014 14:59:42 Chanwoo Choi wrote: This patchset support Exynos3250 ADC (Analog Digital Converter) because Exynos3250 has additional special clock for ADC IP. by coincidence, I have just looked at the

Re: [PATCHv6 0/4] iio: adc: exynos_adc: Support Exynos3250 ADC and code clean

2014-07-18 Thread Naveen Krishna Ch
Hello All, On 18 July 2014 15:43, Naveen Krishna Ch naveenkrishna...@gmail.com wrote: Hello Arnd, On 18 July 2014 15:08, Arnd Bergmann a...@arndb.de wrote: On Friday 18 July 2014 14:59:42 Chanwoo Choi wrote: This patchset support Exynos3250 ADC (Analog Digital Converter) because Exynos3250

Re: [PATCH 1/4 v2] iio: exyno-adc: use syscon for PMU register access

2014-07-17 Thread Naveen Krishna Ch
Hello Sachin, On 17 July 2014 17:24, Sachin Kamat wrote: > Hi Naveen, > > On Thu, Jul 17, 2014 at 4:49 PM, Naveen Krishna Chatradhi > wrote: >> This patch updates the IIO based ADC driver to use syscon and regmap >> APIs to access and use PMU registers instead of remapping the PMU >> registers

Re: [PATCH 0/4] iio: exynos-adc: use syscon instead of ioremap

2014-07-17 Thread Naveen Krishna Ch
Hello Jonathan, On 15 July 2014 23:45, Jonathan Cameron wrote: > On 15/07/14 19:13, Jonathan Cameron wrote: >> >> On 11/07/14 10:06, Naveen Krishna Chatradhi wrote: >>> >>> This patch does the following >>> 1. Use the syscon and Regmap API instead of ioremappaing the >>> ADC_PHY register

Re: [PATCH 0/4] iio: exynos-adc: use syscon instead of ioremap

2014-07-17 Thread Naveen Krishna Ch
Hello Jonathan, On 15 July 2014 23:45, Jonathan Cameron ji...@kernel.org wrote: On 15/07/14 19:13, Jonathan Cameron wrote: On 11/07/14 10:06, Naveen Krishna Chatradhi wrote: This patch does the following 1. Use the syscon and Regmap API instead of ioremappaing the ADC_PHY register from

Re: [PATCH 1/4 v2] iio: exyno-adc: use syscon for PMU register access

2014-07-17 Thread Naveen Krishna Ch
Hello Sachin, On 17 July 2014 17:24, Sachin Kamat spk.li...@gmail.com wrote: Hi Naveen, On Thu, Jul 17, 2014 at 4:49 PM, Naveen Krishna Chatradhi ch.nav...@samsung.com wrote: This patch updates the IIO based ADC driver to use syscon and regmap APIs to access and use PMU registers instead of

Re: [PATCH 2/4] Documentation: dt-bindings: move exynos-adc.txt to more iio/adc/

2014-07-11 Thread Naveen Krishna Ch
Hello Sachin, On 11 July 2014 14:47, Sachin Kamat wrote: > Hi Naveen, > > On Fri, Jul 11, 2014 at 2:36 PM, Naveen Krishna Chatradhi > wrote: >> The DT bindings in exynos-adc.txt applies to the ADC >> driver (exynos-adc.c) developed based on IIO framework. >> >> The bindings are more appropriate

Re: [PATCH v7 0/4] ARM: Exynos: PMU cleanup and refactoring for using DT

2014-07-11 Thread Naveen Krishna Ch
Hello Pankaj, On 9 July 2014 09:30, Pankaj Dubey wrote: > This patch series, modifies Exynos Power Management Unit (PMU) related code > for converting it into a platform_driver. This is also preparation for moving > PMU related code out of machine folder into a either "drivers/mfd", or >

Re: [PATCH v7 0/4] ARM: Exynos: PMU cleanup and refactoring for using DT

2014-07-11 Thread Naveen Krishna Ch
Hello Pankaj, On 9 July 2014 09:30, Pankaj Dubey pankaj.du...@samsung.com wrote: This patch series, modifies Exynos Power Management Unit (PMU) related code for converting it into a platform_driver. This is also preparation for moving PMU related code out of machine folder into a either

Re: [PATCH 2/4] Documentation: dt-bindings: move exynos-adc.txt to more iio/adc/

2014-07-11 Thread Naveen Krishna Ch
Hello Sachin, On 11 July 2014 14:47, Sachin Kamat spk.li...@gmail.com wrote: Hi Naveen, On Fri, Jul 11, 2014 at 2:36 PM, Naveen Krishna Chatradhi ch.nav...@samsung.com wrote: The DT bindings in exynos-adc.txt applies to the ADC driver (exynos-adc.c) developed based on IIO framework. The

Re: [PATCH 2/3] ARM: DTS: Add NTC thermistor nodes to Exynos5250 based Snow

2014-06-26 Thread Naveen Krishna Ch
Hello Doug and Kukjin, On 26 June 2014 21:16, Doug Anderson wrote: > Naveen, > > On Thu, Jun 26, 2014 at 5:19 AM, Naveen Krishna Chatradhi > wrote: >> Exynos5250 based Snow board has 4 NTC thermistors to measure >> temperatures at various points on the board. >> >> IIO based ADC becomes the

Re: [PATCH 0/3] ARM: DTS: create common dtsi for Peach pit and pi boards

2014-06-26 Thread Naveen Krishna Ch
Hello Javier, On 26 June 2014 20:51, Javier Martinez Canillas wrote: > Hello Naveen, > > On Thu, Jun 26, 2014 at 2:19 PM, Naveen Krishna Chatradhi > wrote: >> This patchset does the following >> 1. Create a common dtsi file cros-exynos-peach.dtsi for >>exynos5420-peach-pit.dts and

Re: [PATCH v4 00/14] Add Maxim 77802 PMIC support

2014-06-26 Thread Naveen Krishna Ch
Hello Javier, On 26 June 2014 00:33, Javier Martinez Canillas wrote: > MAX77802 is a PMIC that contains 10 high efficiency Buck regulators, > 32 Low-dropout (LDO) regulators, two 32kHz buffered clock outputs, > a Real-Time-Clock (RTC) and a I2C interface to program the individual > regulators,

Re: [PATCH v4 00/14] Add Maxim 77802 PMIC support

2014-06-26 Thread Naveen Krishna Ch
Hello Javier, On 26 June 2014 00:33, Javier Martinez Canillas javier.marti...@collabora.co.uk wrote: MAX77802 is a PMIC that contains 10 high efficiency Buck regulators, 32 Low-dropout (LDO) regulators, two 32kHz buffered clock outputs, a Real-Time-Clock (RTC) and a I2C interface to program

Re: [PATCH 0/3] ARM: DTS: create common dtsi for Peach pit and pi boards

2014-06-26 Thread Naveen Krishna Ch
Hello Javier, On 26 June 2014 20:51, Javier Martinez Canillas jav...@dowhile0.org wrote: Hello Naveen, On Thu, Jun 26, 2014 at 2:19 PM, Naveen Krishna Chatradhi ch.nav...@samsung.com wrote: This patchset does the following 1. Create a common dtsi file cros-exynos-peach.dtsi for

Re: [PATCH 2/3] ARM: DTS: Add NTC thermistor nodes to Exynos5250 based Snow

2014-06-26 Thread Naveen Krishna Ch
Hello Doug and Kukjin, On 26 June 2014 21:16, Doug Anderson diand...@chromium.org wrote: Naveen, On Thu, Jun 26, 2014 at 5:19 AM, Naveen Krishna Chatradhi ch.nav...@samsung.com wrote: Exynos5250 based Snow board has 4 NTC thermistors to measure temperatures at various points on the board.

Re: [PATCH 2/2] i2c: exynos5: fix minor styling nits

2014-06-25 Thread Naveen Krishna Ch
Hello Sachin, On 25 June 2014 16:19, Sachin Kamat wrote: > Hi Naveen, > > On Wed, Jun 25, 2014 at 4:08 PM, Naveen Krishna Chatradhi > wrote: >> This patch removes an extra line and fixes a styling nit >> in exynos5_i2c_message_start() >> >> Signed-off-by: Naveen Krishna Chatradhi >> --- >>

Re: [PATCH 2/2] i2c: exynos5: fix minor styling nits

2014-06-25 Thread Naveen Krishna Ch
Hello Sachin, On 25 June 2014 16:19, Sachin Kamat spk.li...@gmail.com wrote: Hi Naveen, On Wed, Jun 25, 2014 at 4:08 PM, Naveen Krishna Chatradhi ch.nav...@samsung.com wrote: This patch removes an extra line and fixes a styling nit in exynos5_i2c_message_start() Signed-off-by: Naveen

Re: [PATCHv4 2/4] iio: adc: exynos_adc: Control special clock of ADC to support Exynos3250 ADC

2014-06-19 Thread Naveen Krishna Ch
Hello Tomasz, On 20 June 2014 06:00, Tomasz Figa wrote: > On 20.06.2014 02:28, Chanwoo Choi wrote: >> On 06/20/2014 09:24 AM, Tomasz Figa wrote: >>> On 20.06.2014 02:22, Chanwoo Choi wrote: Hi Tomasz, On 06/18/2014 04:58 PM, Tomasz Figa wrote: > Hi Chanwoo, > > On

Re: [PATCHv4 2/4] iio: adc: exynos_adc: Control special clock of ADC to support Exynos3250 ADC

2014-06-19 Thread Naveen Krishna Ch
Hello Tomasz, On 20 June 2014 06:00, Tomasz Figa tomasz.f...@gmail.com wrote: On 20.06.2014 02:28, Chanwoo Choi wrote: On 06/20/2014 09:24 AM, Tomasz Figa wrote: On 20.06.2014 02:22, Chanwoo Choi wrote: Hi Tomasz, On 06/18/2014 04:58 PM, Tomasz Figa wrote: Hi Chanwoo, On 18.06.2014

Re: [PATCHv4 3/4] iio: devicetree: Add DT binding documentation for Exynos3250 ADC

2014-06-18 Thread Naveen Krishna Ch
Hello Chanwoo, On 18 June 2014 07:51, Chanwoo Choi wrote: > This patch add DT binding documentation for Exynos3250 ADC IP. Exynos3250 has > special clock ('sclk_tsadc') for ADC which provide clock to internal ADC. > > Signed-off-by: Chanwoo Choi > Acked-by: Kyungmin Park Changes look good to

Re: [PATCHv4 3/4] iio: devicetree: Add DT binding documentation for Exynos3250 ADC

2014-06-18 Thread Naveen Krishna Ch
Hello Chanwoo, On 18 June 2014 07:51, Chanwoo Choi cw00.c...@samsung.com wrote: This patch add DT binding documentation for Exynos3250 ADC IP. Exynos3250 has special clock ('sclk_tsadc') for ADC which provide clock to internal ADC. Signed-off-by: Chanwoo Choi cw00.c...@samsung.com Acked-by:

Re: [PATCHv4 1/4] iio: adc: exynos_adc: Add exynos_adc_ops structure to improve readability

2014-06-17 Thread Naveen Krishna Ch
Hello Chanwoo, On 18 June 2014 07:50, Chanwoo Choi wrote: > This patchset add 'exynos_adc_ops' structure which includes some functions > to control ADC operation according to ADC version (v1 or v2). > > Signed-off-by: Chanwoo Choi > Acked-by: Kyungmin Park This is a good piece of change,

Re: [PATCHv4 1/4] iio: adc: exynos_adc: Add exynos_adc_ops structure to improve readability

2014-06-17 Thread Naveen Krishna Ch
Hello Chanwoo, On 18 June 2014 07:50, Chanwoo Choi cw00.c...@samsung.com wrote: This patchset add 'exynos_adc_ops' structure which includes some functions to control ADC operation according to ADC version (v1 or v2). Signed-off-by: Chanwoo Choi cw00.c...@samsung.com Acked-by: Kyungmin Park

Re: [PATCH] i2c: exynos5: Initialise Samsung High Speed I2C controller early

2014-05-21 Thread Naveen Krishna Ch
Hello Wolfram, On 21 May 2014 15:55, Wolfram Sang wrote: > On Fri, May 09, 2014 at 03:54:25PM +0100, Mark Brown wrote: >> On Fri, May 09, 2014 at 08:12:47PM +0530, Naveen Krishna Ch wrote: >> > On 9 May 2014 19:21, Mark Brown wrote: >> > > On Fri, May 09, 20

Re: [PATCH] i2c: exynos5: add support for HSI2C on Exynos5260 SoC

2014-05-21 Thread Naveen Krishna Ch
Hello Wolfram, On 21 May 2014 16:04, Wolfram Sang wrote: > On Mon, Apr 28, 2014 at 02:29:58PM +0530, Naveen Krishna Chatradhi wrote: >> HSI2C module on Exynos5260 differs from current modules in >> following ways: >> 1. HSI2C on Exynos5260 has fifo_depth of 16bytes >> 2. Module needs to be

Re: [PATCH] i2c: exynos5: add support for HSI2C on Exynos5260 SoC

2014-05-21 Thread Naveen Krishna Ch
Hello Wolfram, On 21 May 2014 16:04, Wolfram Sang w...@the-dreams.de wrote: On Mon, Apr 28, 2014 at 02:29:58PM +0530, Naveen Krishna Chatradhi wrote: HSI2C module on Exynos5260 differs from current modules in following ways: 1. HSI2C on Exynos5260 has fifo_depth of 16bytes 2. Module needs

Re: [PATCH] i2c: exynos5: Initialise Samsung High Speed I2C controller early

2014-05-21 Thread Naveen Krishna Ch
Hello Wolfram, On 21 May 2014 15:55, Wolfram Sang w...@the-dreams.de wrote: On Fri, May 09, 2014 at 03:54:25PM +0100, Mark Brown wrote: On Fri, May 09, 2014 at 08:12:47PM +0530, Naveen Krishna Ch wrote: On 9 May 2014 19:21, Mark Brown broo...@kernel.org wrote: On Fri, May 09, 2014 at 05:50

Re: [PATCH] i2c: exynos5: Initialise Samsung High Speed I2C controller early

2014-05-09 Thread Naveen Krishna Ch
Hello Mark, On 9 May 2014 19:21, Mark Brown wrote: > On Fri, May 09, 2014 at 05:50:00PM +0530, Naveen Krishna Ch wrote: >> On 24 April 2014 21:55, Mark Brown wrote: > >> >> Such solution has been proposed by Mark Brown to fix the problem of >> >>

Re: [PATCH] i2c: exynos5: Initialise Samsung High Speed I2C controller early

2014-05-09 Thread Naveen Krishna Ch
Hello Mark, On 24 April 2014 21:55, Mark Brown wrote: > On Thu, Apr 24, 2014 at 08:18:36PM +0530, Naveen Krishna Chatradhi wrote: >> This patch moves initialization code to subsys_initcall() to ensure >> that the i2c bus is available early so the regulators can be quickly >> probed and available

Re: [PATCH] i2c: exynos5: Initialise Samsung High Speed I2C controller early

2014-05-09 Thread Naveen Krishna Ch
Hello Mark, On 24 April 2014 21:55, Mark Brown broo...@kernel.org wrote: On Thu, Apr 24, 2014 at 08:18:36PM +0530, Naveen Krishna Chatradhi wrote: This patch moves initialization code to subsys_initcall() to ensure that the i2c bus is available early so the regulators can be quickly probed

Re: [PATCH] i2c: exynos5: Initialise Samsung High Speed I2C controller early

2014-05-09 Thread Naveen Krishna Ch
Hello Mark, On 9 May 2014 19:21, Mark Brown broo...@kernel.org wrote: On Fri, May 09, 2014 at 05:50:00PM +0530, Naveen Krishna Ch wrote: On 24 April 2014 21:55, Mark Brown broo...@kernel.org wrote: Such solution has been proposed by Mark Brown to fix the problem of the regulators

Re: [PATCH 0/7 v8] crypto:s5p-sss: Add Device tree and Exynos support

2014-04-30 Thread Naveen Krishna Ch
Hello Herbert, On 30 April 2014 17:44, Herbert Xu wrote: > On Wed, Apr 30, 2014 at 04:38:05PM +0530, Naveen Krishna Ch wrote: >> Hello All, >> >> On 28 April 2014 16:14, Naveen Krishna Chatradhi >> wrote: >> > SSS module on Exynos4210, Exynos5250 and Exy

Re: [PATCH 0/7 v8] crypto:s5p-sss: Add Device tree and Exynos support

2014-04-30 Thread Naveen Krishna Ch
Hello All, On 28 April 2014 16:14, Naveen Krishna Chatradhi wrote: > SSS module on Exynos4210, Exynos5250 and Exynos5420 SoCs has added > features to the one on S5PV210. However with minor changes the s5p-sss.c > driver can be reused to support SSS modules on Exynos4 and 5 SoCs. > > This patch

Re: [PATCH 0/7 v8] crypto:s5p-sss: Add Device tree and Exynos support

2014-04-30 Thread Naveen Krishna Ch
Hello All, On 28 April 2014 16:14, Naveen Krishna Chatradhi ch.nav...@samsung.com wrote: SSS module on Exynos4210, Exynos5250 and Exynos5420 SoCs has added features to the one on S5PV210. However with minor changes the s5p-sss.c driver can be reused to support SSS modules on Exynos4 and 5

Re: [PATCH 0/7 v8] crypto:s5p-sss: Add Device tree and Exynos support

2014-04-30 Thread Naveen Krishna Ch
Hello Herbert, On 30 April 2014 17:44, Herbert Xu herb...@gondor.apana.org.au wrote: On Wed, Apr 30, 2014 at 04:38:05PM +0530, Naveen Krishna Ch wrote: Hello All, On 28 April 2014 16:14, Naveen Krishna Chatradhi ch.nav...@samsung.com wrote: SSS module on Exynos4210, Exynos5250

Re: [PATCH 1/2 v4] i2c: exynos5: add support for HSI2C on Exynos5260 SoC

2014-04-28 Thread Naveen Krishna Ch
Hello Wolfram, On 13 March 2014 00:48, Wolfram Sang wrote: > On Fri, Feb 07, 2014 at 10:12:51AM +0530, Naveen Krishna Chatradhi wrote: >> This patch adds a new compatible and uses variant struct to support >> HSI2C module on Exynos5260. Updates the Documentation dt bindings. >> Also resets the

Re: [PATCH 2/2 v4] i2c: exynos5: configure fifo_depth based on HSI2C module variant

2014-04-28 Thread Naveen Krishna Ch
Hello Wolfram, On 13 March 2014 00:50, Wolfram Sang wrote: > On Fri, Feb 07, 2014 at 10:13:15AM +0530, Naveen Krishna Chatradhi wrote: >> fifo_depth of the HSI2C is not constant >> Exynos5420 and Exynos5250 supports fifo_depth of 64bytes >> Exynos5260 supports fifo_depth of 16bytes. >> >> This

Re: [PATCH 2/2 v4] i2c: exynos5: configure fifo_depth based on HSI2C module variant

2014-04-28 Thread Naveen Krishna Ch
Hello Wolfram, On 13 March 2014 00:50, Wolfram Sang w...@the-dreams.de wrote: On Fri, Feb 07, 2014 at 10:13:15AM +0530, Naveen Krishna Chatradhi wrote: fifo_depth of the HSI2C is not constant Exynos5420 and Exynos5250 supports fifo_depth of 64bytes Exynos5260 supports fifo_depth of 16bytes.

Re: [PATCH 1/2 v4] i2c: exynos5: add support for HSI2C on Exynos5260 SoC

2014-04-28 Thread Naveen Krishna Ch
Hello Wolfram, On 13 March 2014 00:48, Wolfram Sang w...@the-dreams.de wrote: On Fri, Feb 07, 2014 at 10:12:51AM +0530, Naveen Krishna Chatradhi wrote: This patch adds a new compatible and uses variant struct to support HSI2C module on Exynos5260. Updates the Documentation dt bindings. Also

Re: [PATCH 1/5] iio: exynos_adc: use indio_dev->dev structure to handle child nodes

2014-04-26 Thread Naveen Krishna Ch
n Fri, Apr 25, 2014 at 3:14 AM, Naveen Krishna Chatradhi >> wrote: >>> >>> From: Naveen Krishna Ch >>> >>> Using pdev->dev with device_for_each_child() would iterate over all >>> of the children of the platform device and delete them. >

Re: [PATCH 1/5] iio: exynos_adc: use indio_dev-dev structure to handle child nodes

2014-04-26 Thread Naveen Krishna Ch
wrote: From: Naveen Krishna Ch ch.nav...@samsung.com Using pdev-dev with device_for_each_child() would iterate over all of the children of the platform device and delete them. Thus, causing crashes during module unload. We should be using the indio_dev-dev structure for registering

Re: [PATCH v11 0/4] thermal: samsung: Clean up and add support for Exynos5420

2014-03-19 Thread Naveen Krishna Ch
Hello Tomasz, On 20 March 2014 00:58, Tomasz Figa wrote: > Hi Leela, > > > On 19.03.2014 12:19, Leela Krishna Amudala wrote: >> >> Hi All, >> >> I didn't see this series in mainline, Any comments for this ? > > > Naveen had posted v12 of this series and I believe all the patches got my >

Re: [PATCH 0/9 v7] crypto:s5p-sss: Add DT and Exynos support

2014-03-19 Thread Naveen Krishna Ch
for which ARCH code is under review) >> I couldn't test on Exynos4412 and Exynos4210 boards, Should be able to >> test with addition of DT node and clocks support. >> >> Naveen Krishna Ch (7): [crypto-2.6.git] >> crypto:s5p-sss: Use platform_get_irq() instead of

Re: [PATCH 0/9 v7] crypto:s5p-sss: Add DT and Exynos support

2014-03-19 Thread Naveen Krishna Ch
, Should be able to test with addition of DT node and clocks support. Naveen Krishna Ch (7): [crypto-2.6.git] crypto:s5p-sss: Use platform_get_irq() instead of _byname() crypto:s5p-sss: Kconfig: Let Exynos SoCs select SSS driver crypto:s5p-sss: Look for the next request in the queue

Re: [PATCH v11 0/4] thermal: samsung: Clean up and add support for Exynos5420

2014-03-19 Thread Naveen Krishna Ch
Hello Tomasz, On 20 March 2014 00:58, Tomasz Figa t.f...@samsung.com wrote: Hi Leela, On 19.03.2014 12:19, Leela Krishna Amudala wrote: Hi All, I didn't see this series in mainline, Any comments for this ? Naveen had posted v12 of this series and I believe all the patches got my

Re: [PATCH 6/9 v6] ARM: dts: exynos5250/5420: add dt node for sss module

2014-02-17 Thread Naveen Krishna Ch
Hello Tomasz, On 14 February 2014 16:24, Tomasz Figa wrote: > Hi Kukjin, > > > On 14.02.2014 00:28, Kukjin Kim wrote: >> >> On 02/07/14 14:24, Naveen Krishna Chatradhi wrote: >>> >>> This patch adds the device tree node for SSS module >>> found on Exynos5420 and Exynos5250 >>> >>> Signed-off-by:

Re: [PATCH 6/9 v6] ARM: dts: exynos5250/5420: add dt node for sss module

2014-02-17 Thread Naveen Krishna Ch
Hello Tomasz, On 14 February 2014 16:24, Tomasz Figa t.f...@samsung.com wrote: Hi Kukjin, On 14.02.2014 00:28, Kukjin Kim wrote: On 02/07/14 14:24, Naveen Krishna Chatradhi wrote: This patch adds the device tree node for SSS module found on Exynos5420 and Exynos5250 Signed-off-by:

Re: [PATCH 6/9 v6] ARM: dts: exynos5250/5420: add dt node for sss module

2014-02-13 Thread Naveen Krishna Ch
Hello Kukjin, On 14 February 2014 05:02, Kukjin Kim wrote: > On 02/14/14 08:28, Kukjin Kim wrote: >> >> On 02/07/14 14:24, Naveen Krishna Chatradhi wrote: >>> >>> This patch adds the device tree node for SSS module >>> found on Exynos5420 and Exynos5250 >>> >>> Signed-off-by: Naveen Krishna

Re: [PATCH 6/9 v6] ARM: dts: exynos5250/5420: add dt node for sss module

2014-02-13 Thread Naveen Krishna Ch
Hello Kukjin, On 14 February 2014 05:02, Kukjin Kim kgene@samsung.com wrote: On 02/14/14 08:28, Kukjin Kim wrote: On 02/07/14 14:24, Naveen Krishna Chatradhi wrote: This patch adds the device tree node for SSS module found on Exynos5420 and Exynos5250 Signed-off-by: Naveen Krishna

Re: [PATCH] thermal: exynos: handle gate clock for misplaced TRIMINFO register

2014-02-10 Thread Naveen Krishna Ch
Hello Mark, On 10 February 2014 16:37, Mark Rutland wrote: > On Mon, Feb 10, 2014 at 10:50:01AM +0000, Naveen Krishna Ch wrote: >> Hello Mark, >> >> On 10 February 2014 16:03, Mark Rutland wrote: >> > On Thu, Nov 07, 2013 at 12:42:34PM +, Naveen Krishna Chatra

Re: [PATCH] thermal: exynos: handle gate clock for misplaced TRIMINFO register

2014-02-10 Thread Naveen Krishna Ch
Hello Mark, On 10 February 2014 16:03, Mark Rutland wrote: > On Thu, Nov 07, 2013 at 12:42:34PM +, Naveen Krishna Chatradhi wrote: >> On Exynos5420 the TMU(4) for GPU has a seperate clock enable bit from >> the other TMU channels(0 ~ 3). Hence, accessing TRIMINFO for base_second >> should be

Re: [PATCH] thermal: exynos: handle gate clock for misplaced TRIMINFO register

2014-02-10 Thread Naveen Krishna Ch
Hello Mark, On 10 February 2014 16:03, Mark Rutland mark.rutl...@arm.com wrote: On Thu, Nov 07, 2013 at 12:42:34PM +, Naveen Krishna Chatradhi wrote: On Exynos5420 the TMU(4) for GPU has a seperate clock enable bit from the other TMU channels(0 ~ 3). Hence, accessing TRIMINFO for

Re: [PATCH] thermal: exynos: handle gate clock for misplaced TRIMINFO register

2014-02-10 Thread Naveen Krishna Ch
Hello Mark, On 10 February 2014 16:37, Mark Rutland mark.rutl...@arm.com wrote: On Mon, Feb 10, 2014 at 10:50:01AM +, Naveen Krishna Ch wrote: Hello Mark, On 10 February 2014 16:03, Mark Rutland mark.rutl...@arm.com wrote: On Thu, Nov 07, 2013 at 12:42:34PM +, Naveen Krishna

Re: [PATCH v12 2/4] thermal: samsung: change base_common to more meaningful base_second

2014-02-07 Thread Naveen Krishna Ch
Hello All, On 19 December 2013 11:36, Naveen Krishna Chatradhi wrote: > On Exynos5440 and Exynos5420 there are registers common > across the TMU channels. > > To support that, we introduced a ADDRESS_MULTIPLE flag in the > driver and the 2nd set of register base and size are provided > in the

Re: [PATCH v12 3/4] thermal: samsung: Add TMU support for Exynos5420 SoCs

2014-02-07 Thread Naveen Krishna Ch
Hello All, On 19 December 2013 17:04, Tomasz Figa wrote: > On Thursday 19 of December 2013 11:36:31 Naveen Krishna Chatradhi wrote: >> Exynos5420 has 5 TMU channels, the TRIMINFO register is >> misplaced for TMU channels 2, 3 and 4 >> TRIMINFO at 0x1006c000 contains data for TMU channel 3 >>

Re: [PATCH] thermal: exynos: handle gate clock for misplaced TRIMINFO register

2014-02-07 Thread Naveen Krishna Ch
Hello All, On 2 January 2014 11:37, Zhang Rui wrote: > On Thu, 2013-11-07 at 18:12 +0530, Naveen Krishna Chatradhi wrote: >> On Exynos5420 the TMU(4) for GPU has a seperate clock enable bit from >> the other TMU channels(0 ~ 3). Hence, accessing TRIMINFO for base_second >> should be acompanied

Re: [PATCH v12 1/4] thermal: samsung: replace inten_ bit fields with intclr_

2014-02-07 Thread Naveen Krishna Ch
Hello All, On 2 January 2014 08:03, Zhang Rui wrote: > On Thu, 2013-12-19 at 11:35 +0530, Naveen Krishna Chatradhi wrote: >> This patch replaces the inten_rise_shift/mask and inten_fall_shift/mask >> with intclr_rise_shift/mask and intclr_fall_shift/mask respectively. >> Currently,

Re: [PATCH 1/2] i2c-s3c2410: Leave the bus disabled unless it is in use

2014-02-07 Thread Naveen Krishna Ch
Hello Wolfram, Sorry for a replying after really long time. On 24 January 2013 17:50, Wolfram Sang wrote: > On Thu, Nov 29, 2012 at 10:35:34AM +0530, Naveen Krishna Chatradhi wrote: >> From: Simon Glass >> >> There is a rather odd feature of the exynos i2c controller that if it >> is left

Re: [PATCH 1/2] i2c-s3c2410: Leave the bus disabled unless it is in use

2014-02-07 Thread Naveen Krishna Ch
Hello Wolfram, Sorry for a replying after really long time. On 24 January 2013 17:50, Wolfram Sang w.s...@pengutronix.de wrote: On Thu, Nov 29, 2012 at 10:35:34AM +0530, Naveen Krishna Chatradhi wrote: From: Simon Glass s...@chromium.org There is a rather odd feature of the exynos i2c

Re: [PATCH] thermal: exynos: handle gate clock for misplaced TRIMINFO register

2014-02-07 Thread Naveen Krishna Ch
Hello All, On 2 January 2014 11:37, Zhang Rui rui.zh...@intel.com wrote: On Thu, 2013-11-07 at 18:12 +0530, Naveen Krishna Chatradhi wrote: On Exynos5420 the TMU(4) for GPU has a seperate clock enable bit from the other TMU channels(0 ~ 3). Hence, accessing TRIMINFO for base_second should be

Re: [PATCH v12 1/4] thermal: samsung: replace inten_ bit fields with intclr_

2014-02-07 Thread Naveen Krishna Ch
Hello All, On 2 January 2014 08:03, Zhang Rui rui.zh...@intel.com wrote: On Thu, 2013-12-19 at 11:35 +0530, Naveen Krishna Chatradhi wrote: This patch replaces the inten_rise_shift/mask and inten_fall_shift/mask with intclr_rise_shift/mask and intclr_fall_shift/mask respectively. Currently,

Re: [PATCH v12 3/4] thermal: samsung: Add TMU support for Exynos5420 SoCs

2014-02-07 Thread Naveen Krishna Ch
Hello All, On 19 December 2013 17:04, Tomasz Figa t.f...@samsung.com wrote: On Thursday 19 of December 2013 11:36:31 Naveen Krishna Chatradhi wrote: Exynos5420 has 5 TMU channels, the TRIMINFO register is misplaced for TMU channels 2, 3 and 4 TRIMINFO at 0x1006c000 contains data for TMU

Re: [PATCH v12 2/4] thermal: samsung: change base_common to more meaningful base_second

2014-02-07 Thread Naveen Krishna Ch
Hello All, On 19 December 2013 11:36, Naveen Krishna Chatradhi ch.nav...@samsung.com wrote: On Exynos5440 and Exynos5420 there are registers common across the TMU channels. To support that, we introduced a ADDRESS_MULTIPLE flag in the driver and the 2nd set of register base and size are

Re: [PATCH 8/8 v4] crypto:s5p-sss: Use clk_prepare/clk_unprepare

2014-01-28 Thread Naveen Krishna Ch
Hello Sylwester, On 23 January 2014 16:11, Sylwester Nawrocki wrote: > Hi, > > On 23/01/14 11:18, Naveen Krishna Ch wrote: >> Hello All, >> >> On 15 January 2014 14:47, Naveen Krishna Chatradhi >> wrote: >>> This patch set adds use of clk_prepare/clk_

Re: [PATCH 8/8 v4] crypto:s5p-sss: Use clk_prepare/clk_unprepare

2014-01-28 Thread Naveen Krishna Ch
Hello Sylwester, On 23 January 2014 16:11, Sylwester Nawrocki s.nawro...@samsung.com wrote: Hi, On 23/01/14 11:18, Naveen Krishna Ch wrote: Hello All, On 15 January 2014 14:47, Naveen Krishna Chatradhi ch.nav...@samsung.com wrote: This patch set adds use of clk_prepare/clk_unprepare

Re: [PATCH 2/8 v4] crypto:s5p-sss: Add device tree support

2014-01-23 Thread Naveen Krishna Ch
Hello All, On 15 January 2014 14:44, Naveen Krishna Chatradhi wrote: > This patch adds device tree support to the s5p-sss.c crypto driver. > > Also, Documentation under devicetree/bindings added. > > Signed-off-by: Naveen Krishna Ch > CC: Herbert Xu > CC: David S. M

Re: [PATCH 5/8 v4] clk: samsung: exynos5250/5420: Add gate clock for SSS module

2014-01-23 Thread Naveen Krishna Ch
Hello All, On 15 January 2014 14:46, Naveen Krishna Chatradhi wrote: > This patch adds gating clock for SSS(Security SubSystem) > module on Exynos5250/5420. > > Signed-off-by: Naveen Krishna Chatradhi > TO: > TO: Tomasz Figa > CC: Kukjin Kim > CC: > --- > Changes since v3: > 1. Rebased on

Re: [PATCH 1/8 v4] crypto:s5p-sss: Use platform_get_irq() instead of _byname()

2014-01-23 Thread Naveen Krishna Ch
Hello All, On 15 January 2014 14:44, Naveen Krishna Chatradhi wrote: > From: Naveen Krishna Ch > > This patch uses the platform_get_irq() instead of the > platform_get_irq_byname(). Making feeder control interrupt > as resource "0" and hash interrupt as "1"

Re: [PATCH 7/8 v4] crypto:s5p-sss: validate iv before memcpy

2014-01-23 Thread Naveen Krishna Ch
Hello All, On 15 January 2014 14:47, Naveen Krishna Chatradhi wrote: > This patch adds code to validate "iv" buffer before trying to > memcpy the contents > > Signed-off-by: Naveen Krishna Chatradhi > --- > Changes since v3: > None > > drivers/crypto/s5p-sss.c |3 ++- > 1 file changed, 2

Re: [PATCH 6/8 v4] ARM: dts: exynos5250/5420: add dt node for sss module

2014-01-23 Thread Naveen Krishna Ch
Hello All, On 15 January 2014 14:46, Naveen Krishna Chatradhi wrote: > This patch adds the device tree node for SSS module > found on Exynos5420 and Exynos5250 > > Signed-off-by: Naveen Krishna Chatradhi > Reviewed-by: Tomasz Figa > TO: > CC: Kukjin Kim > CC: > --- > Changes since v3: > 1.

Re: [PATCH 8/8 v4] crypto:s5p-sss: Use clk_prepare/clk_unprepare

2014-01-23 Thread Naveen Krishna Ch
Hello All, On 15 January 2014 14:47, Naveen Krishna Chatradhi wrote: > This patch set adds use of clk_prepare/clk_unprepare as > required by generic clock framework. > > Signed-off-by: Naveen Krishna Chatradhi > Reviewed-by: Tomasz Figa > --- > Changes since v3: > None > >

Re: [PATCH 8/8 v4] crypto:s5p-sss: Use clk_prepare/clk_unprepare

2014-01-23 Thread Naveen Krishna Ch
Hello All, On 15 January 2014 14:47, Naveen Krishna Chatradhi ch.nav...@samsung.com wrote: This patch set adds use of clk_prepare/clk_unprepare as required by generic clock framework. Signed-off-by: Naveen Krishna Chatradhi ch.nav...@samsung.com Reviewed-by: Tomasz Figa t.f...@samsung.com

Re: [PATCH 6/8 v4] ARM: dts: exynos5250/5420: add dt node for sss module

2014-01-23 Thread Naveen Krishna Ch
Hello All, On 15 January 2014 14:46, Naveen Krishna Chatradhi ch.nav...@samsung.com wrote: This patch adds the device tree node for SSS module found on Exynos5420 and Exynos5250 Signed-off-by: Naveen Krishna Chatradhi ch.nav...@samsung.com Reviewed-by: Tomasz Figa t.f...@samsung.com TO:

Re: [PATCH 1/8 v4] crypto:s5p-sss: Use platform_get_irq() instead of _byname()

2014-01-23 Thread Naveen Krishna Ch
Hello All, On 15 January 2014 14:44, Naveen Krishna Chatradhi ch.nav...@samsung.com wrote: From: Naveen Krishna Ch ch.nav...@samsung.com This patch uses the platform_get_irq() instead of the platform_get_irq_byname(). Making feeder control interrupt as resource 0 and hash interrupt as 1

Re: [PATCH 7/8 v4] crypto:s5p-sss: validate iv before memcpy

2014-01-23 Thread Naveen Krishna Ch
Hello All, On 15 January 2014 14:47, Naveen Krishna Chatradhi ch.nav...@samsung.com wrote: This patch adds code to validate iv buffer before trying to memcpy the contents Signed-off-by: Naveen Krishna Chatradhi ch.nav...@samsung.com --- Changes since v3: None drivers/crypto/s5p-sss.c |

Re: [PATCH 5/8 v4] clk: samsung: exynos5250/5420: Add gate clock for SSS module

2014-01-23 Thread Naveen Krishna Ch
Hello All, On 15 January 2014 14:46, Naveen Krishna Chatradhi ch.nav...@samsung.com wrote: This patch adds gating clock for SSS(Security SubSystem) module on Exynos5250/5420. Signed-off-by: Naveen Krishna Chatradhi ch.nav...@samsung.com TO: linux-samsung-...@vger.kernel.org TO: Tomasz Figa

Re: [PATCH 2/8 v4] crypto:s5p-sss: Add device tree support

2014-01-23 Thread Naveen Krishna Ch
Hello All, On 15 January 2014 14:44, Naveen Krishna Chatradhi ch.nav...@samsung.com wrote: This patch adds device tree support to the s5p-sss.c crypto driver. Also, Documentation under devicetree/bindings added. Signed-off-by: Naveen Krishna Ch ch.nav...@samsung.com CC: Herbert Xu herb

Re: [PATCH 5/8 v3] clk:exynos-5250: Add gate clock for SSS module

2014-01-15 Thread Naveen Krishna Ch
Hello Tomasz, On 10 January 2014 21:28, Tomasz Figa wrote: > Hi Naveen, > > > On 10.01.2014 12:43, Naveen Krishna Chatradhi wrote: >> >> This patch adds gating clock for SSS(Security SubSystem) >> module on Exynos5250. >> >> Signed-off-by: Naveen Krishna Chatradhi >> --- >> Changes since v2: >>

Re: [PATCH 5/8 v3] clk:exynos-5250: Add gate clock for SSS module

2014-01-15 Thread Naveen Krishna Ch
Hello Tomasz, On 10 January 2014 21:28, Tomasz Figa t.f...@samsung.com wrote: Hi Naveen, On 10.01.2014 12:43, Naveen Krishna Chatradhi wrote: This patch adds gating clock for SSS(Security SubSystem) module on Exynos5250. Signed-off-by: Naveen Krishna Chatradhi ch.nav...@samsung.com ---

Re: [PATCH 7/8 v3] crypto:s5p-sss: validate iv before memcpy

2014-01-14 Thread Naveen Krishna Ch
Hello Tomasz, On 10 January 2014 21:33, Tomasz Figa wrote: > Hi Naveen, > > > On 10.01.2014 12:45, Naveen Krishna Chatradhi wrote: >> >> This patch adds code to validate "iv" buffer before trying to >> memcpy the contents >> >> Signed-off-by: Naveen Krishna Chatradhi >> --- >> Changes since v2:

Re: [PATCH 7/8 v3] crypto:s5p-sss: validate iv before memcpy

2014-01-14 Thread Naveen Krishna Ch
Hello Tomasz, On 10 January 2014 21:33, Tomasz Figa t.f...@samsung.com wrote: Hi Naveen, On 10.01.2014 12:45, Naveen Krishna Chatradhi wrote: This patch adds code to validate iv buffer before trying to memcpy the contents Signed-off-by: Naveen Krishna Chatradhi ch.nav...@samsung.com ---

Re: [PATCH 3/8 v3] crypto:s5p-sss: Add support for SSS module on Exynos

2014-01-13 Thread Naveen Krishna Ch
hi wrote: >>> >>> This patch adds new compatible and variant struct to support the SSS >>> module on Exynos4 (Exynos4210), Exynos5 (Exynos5420 and Exynos5250) >>> for which >>> 1. AES register are at an offset of 0x200 and >>> 2. hash interrupt

Re: [PATCH 3/8 v3] crypto:s5p-sss: Add support for SSS module on Exynos

2014-01-13 Thread Naveen Krishna Ch
and variant struct to support the SSS module on Exynos4 (Exynos4210), Exynos5 (Exynos5420 and Exynos5250) for which 1. AES register are at an offset of 0x200 and 2. hash interrupt is not available Signed-off-by: Naveen Krishna Ch ch.nav...@samsung.com CC: Herbert Xu herb...@gondor.apana.org.au CC

Re: [PATCH 2/6 v2] crypto:s5p-sss: Add device tree support

2014-01-09 Thread Naveen Krishna Ch
o, Documentation under devicetree/bindings added. >> >> Signed-off-by: Naveen Krishna Ch >> CC: Herbert Xu >> CC: David S. Miller >> CC: Vladimir Zapolskiy >> TO: >> CC: >> --- >> Changes since v1: >> 1. Added description of t

Re: [PATCH 2/6 v2] crypto:s5p-sss: Add device tree support

2014-01-09 Thread Naveen Krishna Ch
. Signed-off-by: Naveen Krishna Ch ch.nav...@samsung.com CC: Herbert Xu herb...@gondor.apana.org.au CC: David S. Miller da...@davemloft.net CC: Vladimir Zapolskiy vzapols...@gmail.com TO: linux-cry...@vger.kernel.org CC: linux-samsung-...@vger.kernel.org --- Changes since v1: 1. Added

Re: [PATCH 4/5] crypto:s5p-sss: Exynos5 SoCs too can select SSS driver

2014-01-08 Thread Naveen Krishna Ch
Hello Tomasz, On 8 January 2014 06:00, Tomasz Figa wrote: > On Tuesday 07 of January 2014 17:21:48 Naveen Krishna Ch wrote: >> This patch modifies Kconfig such that ARCH_EXYNOS5 SoCs >> can also select Samsung SSS(Security SubSystem) driver. >> >> Signed-off-by: Naveen

Re: [PATCH 5/5] ARM: exynos5420: add dt node for sss module

2014-01-08 Thread Naveen Krishna Ch
Hello Tomasz, On 8 January 2014 06:02, Tomasz Figa wrote: > On Tuesday 07 of January 2014 17:21:49 Naveen Krishna Ch wrote: >> From: Naveen Krishna Chatradhi >> >> this patch adds the device tree nodes for SSS module found on Exynos5420 > > nit: Sentences in English

Re: [PATCH 5/5] ARM: exynos5420: add dt node for sss module

2014-01-08 Thread Naveen Krishna Ch
Hello Tomasz, On 8 January 2014 06:02, Tomasz Figa tomasz.f...@gmail.com wrote: On Tuesday 07 of January 2014 17:21:49 Naveen Krishna Ch wrote: From: Naveen Krishna Chatradhi ch.nav...@samsung.com this patch adds the device tree nodes for SSS module found on Exynos5420 nit: Sentences

Re: [PATCH 4/5] crypto:s5p-sss: Exynos5 SoCs too can select SSS driver

2014-01-08 Thread Naveen Krishna Ch
Hello Tomasz, On 8 January 2014 06:00, Tomasz Figa tomasz.f...@gmail.com wrote: On Tuesday 07 of January 2014 17:21:48 Naveen Krishna Ch wrote: This patch modifies Kconfig such that ARCH_EXYNOS5 SoCs can also select Samsung SSS(Security SubSystem) driver. Signed-off-by: Naveen Krishna Ch

[PATCH 0/5] crypto:s5p-sss: Add DT and Exynos5 support

2014-01-07 Thread Naveen Krishna Ch
device tree node to Exynos5420 4. Also adds the DT binding documentation Naveen Krishna Ch (4): [crypto-2.6.git] crypto:s5p-sss: Use platform_get_irq() instead of _byname() crypto:s5p-sss: Add device tree and Exynos5 support crypto:s5p-sss: Add support for SSS module on Exynos5 crypto:s5p-sss

[PATCH 2/5] crypto:s5p-sss: Add device tree and Exynos5 support

2014-01-07 Thread Naveen Krishna Ch
This patch adds device tree support along with a new compatible string to support Exynos5 SoCs (SSS_VER_5). Also, Documentation under devicetree/bindings added. Signed-off-by: Naveen Krishna Ch CC: Herbert Xu CC: David S. Miller CC: Vladimir Zapolskiy TO: CC: --- .../devicetree/bindings

[PATCH 3/5] crypto:s5p-sss: Add support for SSS module on Exynos5

2014-01-07 Thread Naveen Krishna Ch
The differences between SSS modules on S5PV210 and Exynos5 (AFA the driver supports) 1. AES register are at an offset of 0x200 on Exynos5 2. hash interrupt is no longer needed on Exynos5 This patch adds code needed to address the above changes. Signed-off-by: Naveen Krishna Ch CC: Herbert Xu

[PATCH 5/5] ARM: exynos5420: add dt node for sss module

2014-01-07 Thread Naveen Krishna Ch
From: Naveen Krishna Chatradhi this patch adds the device tree nodes for SSS module found on Exynos5420 Signed-off-by: Naveen Krishna Chatradhi TO: CC: Kukjin Kim CC: --- arch/arm/boot/dts/exynos5420.dtsi | 10 ++ 1 file changed, 10 insertions(+) diff --git

  1   2   3   >