Re: [RFC V2 04/12] i2c: opal: make use of the new infrastructure for quirks

2015-03-10 Thread Neelesh Gupta
On 03/11/2015 04:42 AM, Benjamin Herrenschmidt wrote: On Tue, 2015-03-10 at 22:43 +0530, Neelesh Gupta wrote: I tested the i2c opal driver after updating the patch as below. Basically I think we can also support write-then-{read/write} for the number of messages = 2. Ben, any issues if we

Re: [RFC V2 04/12] i2c: opal: make use of the new infrastructure for quirks

2015-03-10 Thread Neelesh Gupta
I tested the i2c opal driver after updating the patch as below. Basically I think we can also support write-then-{read/write} for the number of messages = 2. Ben, any issues if we support both write plus read/write in the opal driver ? Regards, Neelesh drivers/i2c/busses/i2c-opal.c | 20

Re: [RFC V2 04/12] i2c: opal: make use of the new infrastructure for quirks

2015-03-10 Thread Neelesh Gupta
I tested the i2c opal driver after updating the patch as below. Basically I think we can also support write-then-{read/write} for the number of messages = 2. Ben, any issues if we support both write plus read/write in the opal driver ? Regards, Neelesh drivers/i2c/busses/i2c-opal.c | 20

Re: [RFC V2 04/12] i2c: opal: make use of the new infrastructure for quirks

2015-03-10 Thread Neelesh Gupta
On 03/11/2015 04:42 AM, Benjamin Herrenschmidt wrote: On Tue, 2015-03-10 at 22:43 +0530, Neelesh Gupta wrote: I tested the i2c opal driver after updating the patch as below. Basically I think we can also support write-then-{read/write} for the number of messages = 2. Ben, any issues if we

[PATCH v2] hwmon: (ibmpowernv) Use platform 'id_table' to probe the device

2014-11-05 Thread Neelesh Gupta
if the device present or not. Signed-off-by: Neelesh Gupta --- Changes in v2 = - Improve readability in error case if 'sensors' not found, also log the using 'pr_err'. arch/powerpc/platforms/powernv/opal-sensor.c | 20 drivers/hwmon/ibmpowernv.c | 67

[PATCH v2] hwmon: (ibmpowernv) Use platform 'id_table' to probe the device

2014-11-05 Thread Neelesh Gupta
if the device present or not. Signed-off-by: Neelesh Gupta neele...@linux.vnet.ibm.com --- Changes in v2 = - Improve readability in error case if 'sensors' not found, also log the using 'pr_err'. arch/powerpc/platforms/powernv/opal-sensor.c | 20 drivers/hwmon/ibmpowernv.c

Re: [PATCH] hwmon: (ibmpowernv) Use platform 'id_table' to probe the device

2014-11-04 Thread Neelesh Gupta
On 11/04/2014 07:58 PM, Guenter Roeck wrote: On 11/03/2014 11:30 PM, Neelesh Gupta wrote: The current driver probe() function assumes the sensor device to be alwary present and gets executed every time if the driver is loaded, but the appropriate hardware could not be present. So, move

Re: [PATCH] hwmon: (ibmpowernv) Use platform 'id_table' to probe the device

2014-11-04 Thread Neelesh Gupta
On 11/04/2014 07:58 PM, Guenter Roeck wrote: On 11/03/2014 11:30 PM, Neelesh Gupta wrote: The current driver probe() function assumes the sensor device to be alwary present and gets executed every time if the driver is loaded, but the appropriate hardware could not be present. So, move

[PATCH] hwmon: (ibmpowernv) Use platform 'id_table' to probe the device

2014-11-03 Thread Neelesh Gupta
if the device present or not. Signed-off-by: Neelesh Gupta --- arch/powerpc/platforms/powernv/opal-sensor.c | 20 drivers/hwmon/ibmpowernv.c | 67 +++--- 2 files changed, 39 insertions(+), 48 deletions(-) diff --git a/arch/powerpc/platforms/powernv/opal

[PATCH] hwmon: (ibmpowernv) Use platform 'id_table' to probe the device

2014-11-03 Thread Neelesh Gupta
if the device present or not. Signed-off-by: Neelesh Gupta neele...@linux.vnet.ibm.com --- arch/powerpc/platforms/powernv/opal-sensor.c | 20 drivers/hwmon/ibmpowernv.c | 67 +++--- 2 files changed, 39 insertions(+), 48 deletions(-) diff --git a/arch

Re: [PATCH 1/2] hwmon: (ibmpowernv) Quieten when probing finds no device

2014-11-01 Thread Neelesh Gupta
On 10/31/2014 06:51 PM, Guenter Roeck wrote: On 10/31/2014 02:41 AM, Jean Delvare wrote: Hi Michael, On Fri, 31 Oct 2014 17:45:22 +1100, Michael Ellerman wrote: Because we build kernels with drivers built in for many platforms, it's normal for the ibmpowernv driver to be loaded on systems

Re: [PATCH 1/2] hwmon: (ibmpowernv) Quieten when probing finds no device

2014-11-01 Thread Neelesh Gupta
On 10/31/2014 06:51 PM, Guenter Roeck wrote: On 10/31/2014 02:41 AM, Jean Delvare wrote: Hi Michael, On Fri, 31 Oct 2014 17:45:22 +1100, Michael Ellerman wrote: Because we build kernels with drivers built in for many platforms, it's normal for the ibmpowernv driver to be loaded on systems