[PATCH] asoc: soc-core: fix coccinelle warnings

2014-03-03 Thread Nenghua Cao
From: Nenghua Cao sound/soc/soc-core.c:2708:6-13: WARNING: Assignment of bool to 0/1 sound/soc/soc-core.c:2726:3-10: WARNING: Assignment of bool to 0/1 More information about semantic patching is available at http://coccinelle.lip6.fr/ Signed-off-by: Nenghua Cao --- sound/soc/soc-core.c

Re: [PATCH 1/2] driver: regmap: add regmap_parse_val api

2014-03-03 Thread Nenghua Cao
On 02/20/2014 09:42 PM, Mark Brown wrote: > On Thu, Feb 20, 2014 at 08:09:51PM +0800, Nenghua Cao wrote: > >> My intention is not chasing you. I am just afraid if there is any >> other mistake when submitting this patch to open source. Please do what >> you want

Re: [PATCH 1/2] driver: regmap: add regmap_parse_val api

2014-03-03 Thread Nenghua Cao
On 02/20/2014 09:42 PM, Mark Brown wrote: On Thu, Feb 20, 2014 at 08:09:51PM +0800, Nenghua Cao wrote: My intention is not chasing you. I am just afraid if there is any other mistake when submitting this patch to open source. Please do what you want to do. Thanks! It's certainly fine

[PATCH] asoc: soc-core: fix coccinelle warnings

2014-03-03 Thread Nenghua Cao
From: Nenghua Cao nh...@marvell.com sound/soc/soc-core.c:2708:6-13: WARNING: Assignment of bool to 0/1 sound/soc/soc-core.c:2726:3-10: WARNING: Assignment of bool to 0/1 More information about semantic patching is available at http://coccinelle.lip6.fr/ Signed-off-by: Nenghua Cao nh

Re: [PATCH 2/2] asoc: soc-core: fix coccinelle warnings

2014-02-23 Thread Nenghua Cao
On 02/22/2014 10:52 AM, Mark Brown wrote: > On Fri, Feb 21, 2014 at 04:06:10PM +0800, Nenghua Cao wrote: > >> --- a/sound/soc/soc-core.c >> +++ b/sound/soc/soc-core.c >> @@ -2413,7 +2413,7 @@ struct snd_kcontrol *snd_soc_cnew(const struct >> snd_kcontrol_

Re: [PATCH 2/2] asoc: soc-core: fix coccinelle warnings

2014-02-23 Thread Nenghua Cao
On 02/22/2014 10:52 AM, Mark Brown wrote: On Fri, Feb 21, 2014 at 04:06:10PM +0800, Nenghua Cao wrote: --- a/sound/soc/soc-core.c +++ b/sound/soc/soc-core.c @@ -2413,7 +2413,7 @@ struct snd_kcontrol *snd_soc_cnew(const struct snd_kcontrol_new *_template, struct snd_kcontrol *kcontrol

[PATCH 2/2] asoc: soc-core: fix coccinelle warnings

2014-02-21 Thread Nenghua Cao
From: Nenghua Cao sound/soc/soc-core.c:2708:6-13: WARNING: Assignment of bool to 0/1 sound/soc/soc-core.c:2726:3-10: WARNING: Assignment of bool to 0/1 sound/soc/soc-core.c:2264:1-7: Replace memcpy with struct assignment More information about semantic patching is available at http

[PATCH 1/2] driver: regmap: fix coccinelle warnings

2014-02-21 Thread Nenghua Cao
From: Nenghua Cao /drivers/base/regmap/regmap.c:717:6-33: WARNING: Comparison to bool. More information about semantic patching is available at http://coccinelle.lip6.fr/ Signed-off-by: Nenghua Cao --- drivers/base/regmap/regmap.c |2 +- 1 files changed, 1 insertions(+), 1

[PATCH 2/2] asoc: soc-core: fix coccinelle warnings

2014-02-21 Thread Nenghua Cao
From: Nenghua Cao nh...@marvell.com sound/soc/soc-core.c:2708:6-13: WARNING: Assignment of bool to 0/1 sound/soc/soc-core.c:2726:3-10: WARNING: Assignment of bool to 0/1 sound/soc/soc-core.c:2264:1-7: Replace memcpy with struct assignment More information about semantic patching is available

[PATCH 1/2] driver: regmap: fix coccinelle warnings

2014-02-21 Thread Nenghua Cao
From: Nenghua Cao nh...@marvell.com /drivers/base/regmap/regmap.c:717:6-33: WARNING: Comparison to bool. More information about semantic patching is available at http://coccinelle.lip6.fr/ Signed-off-by: Nenghua Cao nh...@marvell.com --- drivers/base/regmap/regmap.c |2 +- 1 files

Re: [PATCH 1/2] driver: regmap: add regmap_parse_val api

2014-02-20 Thread Nenghua Cao
On 02/20/2014 04:55 PM, Mark Brown wrote: > On Thu, Feb 20, 2014 at 04:24:06PM +0800, Nenghua Cao wrote: > >> Do you still have any other problem which have impact on evaluating >> these two patches? > > You're chasing me for a reply after a day - that's way

Re: [PATCH 1/2] driver: regmap: add regmap_parse_val api

2014-02-20 Thread Nenghua Cao
Hi, Mark: Do you still have any other problem which have impact on evaluating these two patches? BR Nenghua On 02/19/2014 06:44 PM, Nenghua Cao wrote: > From: Nenghua Cao > > In some cases, we need regmap's format parse_val function > to do be/le translation accordin

Re: [PATCH 1/2] driver: regmap: add regmap_parse_val api

2014-02-20 Thread Nenghua Cao
Hi, Mark: Do you still have any other problem which have impact on evaluating these two patches? BR Nenghua On 02/19/2014 06:44 PM, Nenghua Cao wrote: From: Nenghua Cao nh...@marvell.com In some cases, we need regmap's format parse_val function to do be/le translation according

Re: [PATCH 1/2] driver: regmap: add regmap_parse_val api

2014-02-20 Thread Nenghua Cao
On 02/20/2014 04:55 PM, Mark Brown wrote: On Thu, Feb 20, 2014 at 04:24:06PM +0800, Nenghua Cao wrote: Do you still have any other problem which have impact on evaluating these two patches? You're chasing me for a reply after a day - that's way too soon, please allow a reasonable

Re: [PATCH 1/2] driver: regmap: add regmap_parse_val api

2014-02-19 Thread Nenghua Cao
On 02/19/2014 03:50 PM, Mark Brown wrote: > On Wed, Feb 19, 2014 at 01:28:43PM +0800, Nenghua Cao wrote: >>Update Liam and Mark's mail. > > I can't do anything useful with patches that are quoted, sorry. None of > the tools know how to strip out quotes. > Hi ,Mark

[PATCH 2/2] asoc: soc-core: use regmap's parse_val to do endian translation

2014-02-19 Thread Nenghua Cao
From: Nenghua Cao In snd_soc_bytes_put function, it forces cpu to do cpu_to_be translation, but for mmio bus which uses REGMAP_ENDIAN_NATIVE, it doesn't need to do endian translation. So it is better to use regmap's api which can decide if this translation is needed according to bus

[PATCH 1/2] driver: regmap: add regmap_parse_val api

2014-02-19 Thread Nenghua Cao
From: Nenghua Cao In some cases, we need regmap's format parse_val function to do be/le translation according to the bus configuration. For example, snd_soc_bytes_put() uses regmap to write/read values, and use cpu_to_be() directly to covert MASK into big endian. This is a defect, and should

[PATCH 1/2] driver: regmap: add regmap_parse_val api

2014-02-19 Thread Nenghua Cao
From: Nenghua Cao nh...@marvell.com In some cases, we need regmap's format parse_val function to do be/le translation according to the bus configuration. For example, snd_soc_bytes_put() uses regmap to write/read values, and use cpu_to_be() directly to covert MASK into big endian

[PATCH 2/2] asoc: soc-core: use regmap's parse_val to do endian translation

2014-02-19 Thread Nenghua Cao
From: Nenghua Cao nh...@marvell.com In snd_soc_bytes_put function, it forces cpu to do cpu_to_be translation, but for mmio bus which uses REGMAP_ENDIAN_NATIVE, it doesn't need to do endian translation. So it is better to use regmap's api which can decide if this translation is needed

Re: [PATCH 1/2] driver: regmap: add regmap_parse_val api

2014-02-19 Thread Nenghua Cao
On 02/19/2014 03:50 PM, Mark Brown wrote: On Wed, Feb 19, 2014 at 01:28:43PM +0800, Nenghua Cao wrote: Update Liam and Mark's mail. I can't do anything useful with patches that are quoted, sorry. None of the tools know how to strip out quotes. Hi ,Mark Sorry for giving you

Re: [PATCH 2/2] asoc: soc-core: use regmap's parse_val to do endian translation

2014-02-18 Thread Nenghua Cao
Update Liam and Mark's mail. On 02/19/2014 01:20 PM, Nenghua Cao wrote: > From: Nenghua Cao > > In snd_soc_bytes_put function, it forces cpu to do cpu_to_be translation, > but for mmio bus which uses REGMAP_ENDIAN_NATIVE, it doesn't need to do > endian translation. So it i

Re: [PATCH 1/2] driver: regmap: add regmap_parse_val api

2014-02-18 Thread Nenghua Cao
Update Liam and Mark's mail. On 02/19/2014 01:19 PM, Nenghua Cao wrote: > From: Nenghua Cao > > In some cases, we need regmap's format parse_val function > to do be/le translation according to the bus configuration. > For example, snd_soc_bytes_put() uses regmap to wr

[PATCH 1/2] driver: regmap: add regmap_parse_val api

2014-02-18 Thread Nenghua Cao
From: Nenghua Cao In some cases, we need regmap's format parse_val function to do be/le translation according to the bus configuration. For example, snd_soc_bytes_put() uses regmap to write/read values, and use cpu_to_be() directly to covert MASK into big endian. This is a defect, and should

[PATCH 2/2] asoc: soc-core: use regmap's parse_val to do endian translation

2014-02-18 Thread Nenghua Cao
From: Nenghua Cao In snd_soc_bytes_put function, it forces cpu to do cpu_to_be translation, but for mmio bus which uses REGMAP_ENDIAN_NATIVE, it doesn't need to do endian translation. So it is better to use regmap's api which can decide if this translation is needed according to bus

[PATCH 2/2] asoc: soc-core: use regmap's parse_val to do endian translation

2014-02-18 Thread Nenghua Cao
From: Nenghua Cao nh...@marvell.com In snd_soc_bytes_put function, it forces cpu to do cpu_to_be translation, but for mmio bus which uses REGMAP_ENDIAN_NATIVE, it doesn't need to do endian translation. So it is better to use regmap's api which can decide if this translation is needed

[PATCH 1/2] driver: regmap: add regmap_parse_val api

2014-02-18 Thread Nenghua Cao
From: Nenghua Cao nh...@marvell.com In some cases, we need regmap's format parse_val function to do be/le translation according to the bus configuration. For example, snd_soc_bytes_put() uses regmap to write/read values, and use cpu_to_be() directly to covert MASK into big endian

Re: [PATCH 1/2] driver: regmap: add regmap_parse_val api

2014-02-18 Thread Nenghua Cao
Update Liam and Mark's mail. On 02/19/2014 01:19 PM, Nenghua Cao wrote: From: Nenghua Cao nh...@marvell.com In some cases, we need regmap's format parse_val function to do be/le translation according to the bus configuration. For example, snd_soc_bytes_put() uses regmap to write/read

Re: [PATCH 2/2] asoc: soc-core: use regmap's parse_val to do endian translation

2014-02-18 Thread Nenghua Cao
Update Liam and Mark's mail. On 02/19/2014 01:20 PM, Nenghua Cao wrote: From: Nenghua Cao nh...@marvell.com In snd_soc_bytes_put function, it forces cpu to do cpu_to_be translation, but for mmio bus which uses REGMAP_ENDIAN_NATIVE, it doesn't need to do endian translation. So

Re: [alsa-devel] [PATCH] ASoC: dpcm: don't do hw_param when BE has done hw_param

2014-01-10 Thread Nenghua Cao
On 01/10/2014 08:29 PM, Liam Girdwood wrote: > On Fri, 2014-01-10 at 13:01 +0100, Takashi Iwai wrote: >> At Fri, 10 Jan 2014 19:59:42 +0800, >> Nenghua Cao wrote: >>> >>> On 01/10/2014 07:47 PM, Liam Girdwood wrote: >>>> On Fri, 2014-01-10 at 19:21 +08

Re: [alsa-devel] [PATCH] ASoC: dpcm: don't do hw_param when BE has done hw_param

2014-01-10 Thread Nenghua Cao
On 01/10/2014 08:01 PM, Takashi Iwai wrote: > At Fri, 10 Jan 2014 19:59:42 +0800, > Nenghua Cao wrote: >> >> On 01/10/2014 07:47 PM, Liam Girdwood wrote: >>> On Fri, 2014-01-10 at 19:21 +0800, Nenghua Cao wrote: >>>> On 01/10/2014 06:55 PM, Takashi Iwai

Re: [alsa-devel] [PATCH] ASoC: dpcm: don't do hw_param when BE has done hw_param

2014-01-10 Thread Nenghua Cao
On 01/10/2014 07:47 PM, Liam Girdwood wrote: > On Fri, 2014-01-10 at 19:21 +0800, Nenghua Cao wrote: >> On 01/10/2014 06:55 PM, Takashi Iwai wrote: >>> [Corrected mail addresses of both Mark and Liam] >>> >> Hi, Takashi: >> Thanks for correcting my mistake.

Re: [alsa-devel] [PATCH] ASoC: dpcm: don't do hw_param when BE has done hw_param

2014-01-10 Thread Nenghua Cao
On 01/10/2014 06:55 PM, Takashi Iwai wrote: > [Corrected mail addresses of both Mark and Liam] > Hi, Takashi: Thanks for correcting my mistake. > At Fri, 10 Jan 2014 13:36:35 +0800, > Nenghua Cao wrote: >> >> From: Nenghua Cao >> >> It fixes the fol

Re: [alsa-devel] [PATCH] ASoC: dpcm: don't do hw_param when BE has done hw_param

2014-01-10 Thread Nenghua Cao
On 01/10/2014 06:55 PM, Takashi Iwai wrote: [Corrected mail addresses of both Mark and Liam] Hi, Takashi: Thanks for correcting my mistake. At Fri, 10 Jan 2014 13:36:35 +0800, Nenghua Cao wrote: From: Nenghua Cao nh...@marvell.com It fixes the following case: Two FEs connects

Re: [alsa-devel] [PATCH] ASoC: dpcm: don't do hw_param when BE has done hw_param

2014-01-10 Thread Nenghua Cao
On 01/10/2014 07:47 PM, Liam Girdwood wrote: On Fri, 2014-01-10 at 19:21 +0800, Nenghua Cao wrote: On 01/10/2014 06:55 PM, Takashi Iwai wrote: [Corrected mail addresses of both Mark and Liam] Hi, Takashi: Thanks for correcting my mistake. At Fri, 10 Jan 2014 13:36:35 +0800, Nenghua Cao

Re: [alsa-devel] [PATCH] ASoC: dpcm: don't do hw_param when BE has done hw_param

2014-01-10 Thread Nenghua Cao
On 01/10/2014 08:01 PM, Takashi Iwai wrote: At Fri, 10 Jan 2014 19:59:42 +0800, Nenghua Cao wrote: On 01/10/2014 07:47 PM, Liam Girdwood wrote: On Fri, 2014-01-10 at 19:21 +0800, Nenghua Cao wrote: On 01/10/2014 06:55 PM, Takashi Iwai wrote: [Corrected mail addresses of both Mark and Liam

Re: [alsa-devel] [PATCH] ASoC: dpcm: don't do hw_param when BE has done hw_param

2014-01-10 Thread Nenghua Cao
On 01/10/2014 08:29 PM, Liam Girdwood wrote: On Fri, 2014-01-10 at 13:01 +0100, Takashi Iwai wrote: At Fri, 10 Jan 2014 19:59:42 +0800, Nenghua Cao wrote: On 01/10/2014 07:47 PM, Liam Girdwood wrote: On Fri, 2014-01-10 at 19:21 +0800, Nenghua Cao wrote: On 01/10/2014 06:55 PM, Takashi Iwai

[PATCH] ASoC: dpcm: don't do hw_param when BE has done hw_param

2014-01-09 Thread Nenghua Cao
From: Nenghua Cao It fixes the following case: Two FEs connects the same BE; FE1 & BE path has been opened and hw_paramed. At this momment, FE2 & BE path is being opened and hw_paramed. The BE dai will do hw_param again even if it has done hw_param. It is not reasona

[PATCH] ASoC: dpcm: don't do hw_param when BE has done hw_param

2014-01-09 Thread Nenghua Cao
From: Nenghua Cao nh...@marvell.com It fixes the following case: Two FEs connects the same BE; FE1 BE path has been opened and hw_paramed. At this momment, FE2 BE path is being opened and hw_paramed. The BE dai will do hw_param again even if it has done hw_param. It is not reasonable

RE: Your message to Alsa-devel awaits moderator approval

2013-07-11 Thread Nenghua Cao
can help me to push this activity further. Thanks! BR Nenghua > -Original Message- > From: alsa-devel-boun...@alsa-project.org > [mailto:alsa-devel-boun...@alsa-project.org] > Sent: 2013年7月2日 17:43 > To: Nenghua Cao > Subject: Your message to Alsa-devel awaits moderator

RE: Your message to Alsa-devel awaits moderator approval

2013-07-11 Thread Nenghua Cao
can help me to push this activity further. Thanks! BR Nenghua -Original Message- From: alsa-devel-boun...@alsa-project.org [mailto:alsa-devel-boun...@alsa-project.org] Sent: 2013年7月2日 17:43 To: Nenghua Cao Subject: Your message to Alsa-devel awaits moderator approval Your mail

[PATCH] ASOC: pcm: support fe dapm widget derived from codec_dai

2013-07-02 Thread Nenghua Cao
From: nhcao In some chips, the codec_dai in cpu is abstracted as one dapm widget. Enhance the framework to use codec_dai as fe widget. Change-Id: I1b545bd1e2f24288f4508a7c6d4efbcfe1e03c5b Signed-off-by: nhcao --- sound/soc/soc-pcm.c | 24 ++-- 1 files changed, 22

[PATCH] ASOC: pcm: support fe dapm widget derived from codec_dai

2013-07-02 Thread Nenghua Cao
From: nhcao nh...@marvell.com In some chips, the codec_dai in cpu is abstracted as one dapm widget. Enhance the framework to use codec_dai as fe widget. Change-Id: I1b545bd1e2f24288f4508a7c6d4efbcfe1e03c5b Signed-off-by: nhcao nh...@marvell.com --- sound/soc/soc-pcm.c | 24