[PATCH] csiostor:Fix error handling in the function csio_hws_ready

2015-08-04 Thread Nicholas Krause
From: Nicholas Krause This fixes error handling in the function csio_hws_ready for when this function calls csio_scim_cleanup_io to cleanup outstanding commands by checking if it cleaned a error code to signal internal failure and if so tell the user we are unable to clean up the outstanding io

[PATCH] ipv6:Fix concurrent access issue in the function inet6_rtm_deladdr

2015-08-04 Thread Nicholas Krause
From: Nicholas Krause This fixes the issue with conncurrent access when calling the function inte6_addr_del due to this function using non locked wrapper versions of certain functions by locking the routing mutex before and after this call with rtnl_lock/unlock. After the unlocking just return

[PATCH] csiostor:Fix error handling in the function csio_hws_ready

2015-08-04 Thread Nicholas Krause
From: Nicholas Krause xerofo...@gmail.com This fixes error handling in the function csio_hws_ready for when this function calls csio_scim_cleanup_io to cleanup outstanding commands by checking if it cleaned a error code to signal internal failure and if so tell the user we are unable to clean up

[PATCH] ipv6:Fix concurrent access issue in the function inet6_rtm_deladdr

2015-08-04 Thread Nicholas Krause
From: Nicholas Krause xerofo...@gmail.com This fixes the issue with conncurrent access when calling the function inte6_addr_del due to this function using non locked wrapper versions of certain functions by locking the routing mutex before and after this call with rtnl_lock/unlock. After

[PATCH] arm: Remove read of issue in sa1111.c in sa1111_resume

2014-09-27 Thread Nicholas Krause
This removes the FIXME message and issue with reading in this driver before resuming in the function, sa_resume. Signed-off-by: Nicholas Krause --- arch/arm/common/sa.c | 2 -- 1 file changed, 2 deletions(-) diff --git a/arch/arm/common/sa.c b/arch/arm/common/sa.c index

[PATCH] wireless: Remove unnessary write over of register 11 in rt2800lib.c

2014-09-27 Thread Nicholas Krause
This removes the unnecessary overwrite of register 11 in the function, rt2800_config_channel as we are already writing a correct value to the register with rt2800_rfcsr_write(rt2x00dev,11.rfcsr). Signed-off-by: Nicholas Krause --- drivers/net/wireless/rt2x00/rt2800lib.c | 2 -- 1 file changed

[PATCH] wireless: Remove unnessary write over of register 11 in rt2800lib.c

2014-09-27 Thread Nicholas Krause
This removes the unnecessary overwrite of register 11 in the function, rt2800_config_channel as we are already writing a correct value to the register with rt2800_rfcsr_write(rt2x00dev,11.rfcsr). Signed-off-by: Nicholas Krause yoc...@gmail.com --- drivers/net/wireless/rt2x00/rt2800lib.c | 2

[PATCH] arm: Remove read of issue in sa1111.c in sa1111_resume

2014-09-27 Thread Nicholas Krause
This removes the FIXME message and issue with reading in this driver before resuming in the function, sa_resume. Signed-off-by: Nicholas Krause yoc...@gmail.com --- arch/arm/common/sa.c | 2 -- 1 file changed, 2 deletions(-) diff --git a/arch/arm/common/sa.c b/arch/arm/common

Re: FIXMEs in rt2800lib.c

2014-09-26 Thread Nicholas Krause
On Fri, Sep 26, 2014 at 8:22 AM, Stanislaw Gruszka wrote: > On Thu, Sep 25, 2014 at 01:52:43PM -0400, nick wrote: >> I seem to be hitting to fix mes in the file I listed in the subject. Would >> someone tell me if it's Ok to remove >> the lines that over write certain registers. > > No, as long

Re: FIXMEs in rt2800lib.c

2014-09-26 Thread Nicholas Krause
On Fri, Sep 26, 2014 at 8:22 AM, Stanislaw Gruszka sgrus...@redhat.com wrote: On Thu, Sep 25, 2014 at 01:52:43PM -0400, nick wrote: I seem to be hitting to fix mes in the file I listed in the subject. Would someone tell me if it's Ok to remove the lines that over write certain registers.

Re: [PATCH] parisc:Remove unnecessary FIXMES in init.c

2014-09-24 Thread Nicholas Krause
On Wed, Sep 24, 2014 at 8:42 AM, John David Anglin wrote: > On 24-Sep-14, at 7:42 AM, nick wrote: > >> >> >> On 14-09-24 01:30 AM, Guenter Roeck wrote: >>> >>> On Tue, Sep 23, 2014 at 09:49:43PM -0400, Nicholas Krause wrote: >>>> >>>

Re: [PATCH] parisc:Remove unnecessary FIXMES in init.c

2014-09-24 Thread Nicholas Krause
On Wed, Sep 24, 2014 at 8:42 AM, John David Anglin dave.ang...@bell.net wrote: On 24-Sep-14, at 7:42 AM, nick wrote: On 14-09-24 01:30 AM, Guenter Roeck wrote: On Tue, Sep 23, 2014 at 09:49:43PM -0400, Nicholas Krause wrote: This removes the two fixmes in the file, init.c for compiler

[PATCH] parisc:Remove unnecessary FIXMES in init.c

2014-09-23 Thread Nicholas Krause
This removes the two fixmes in the file, init.c for compiler hints for comments related to compiler hints in linux_gateway_page_addr and map_hpux_gateway_page to change from FIXME to HINT in order for people reading this code to understand that these are compiler hints. Signed-off-by: Nicholas

Re: FIX Me in pgtable.h

2014-09-23 Thread Nicholas Krause
I don't have any hardware to test this over, however I can emulate a arm system over qemu if needed. I was just trying to help out if we need hardware I can't test and again I am sorry for the terrible patches. It was never my goal to be a nuisance. Nick On Tue, Sep 23, 2014 at 9:46 AM, Krzysztof

Re: FIX Me in pgtable.h

2014-09-23 Thread Nicholas Krause
I don't have any hardware to test this over, however I can emulate a arm system over qemu if needed. I was just trying to help out if we need hardware I can't test and again I am sorry for the terrible patches. It was never my goal to be a nuisance. Nick On Tue, Sep 23, 2014 at 9:46 AM, Krzysztof

[PATCH] parisc:Remove unnecessary FIXMES in init.c

2014-09-23 Thread Nicholas Krause
This removes the two fixmes in the file, init.c for compiler hints for comments related to compiler hints in linux_gateway_page_addr and map_hpux_gateway_page to change from FIXME to HINT in order for people reading this code to understand that these are compiler hints. Signed-off-by: Nicholas

[PATCH] v4l2: Change call of function in videobuf2-core.c

2014-08-03 Thread Nicholas Krause
This patch changes the call of vb2_buffer_core to use VB2_BUFFER_STATE_ACTIVE inside the for instead of not setting in correctly to VB2_BUFFER_STATE_ERROR. Signed-off-by: Nicholas Krause --- drivers/media/v4l2-core/videobuf2-core.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff

[PATCH] v4l2: Change call of function in videobuf2-core.c

2014-08-03 Thread Nicholas Krause
This patch changes the call of vb2_buffer_core to use VB2_BUFFER_STATE_ACTIVE inside the for instead of not setting in correctly to VB2_BUFFER_STATE_ERROR. Signed-off-by: Nicholas Krause xerofo...@gmail.com --- drivers/media/v4l2-core/videobuf2-core.c | 2 +- 1 file changed, 1 insertion(+), 1

[PATCH] scatterlist.h: Change CONFIG_DEBUG_SG for ifdef statement in sg_set_bf

2014-08-02 Thread Nicholas Krause
This changes the ifdef statement in sg_set_bg to !CONFIG_DEBUG_SG in order to avoid a bug with xhci dequence/enquence functions. Signed-off-by: Nicholas Krause --- include/linux/scatterlist.h | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/include/linux/scatterlist.h b

[PATCH] scatterlist.h: Change CONFIG_DEBUG_SG for ifdef statement in sg_set_bf

2014-08-02 Thread Nicholas Krause
This changes the ifdef statement in sg_set_bg to !CONFIG_DEBUG_SG in order to avoid a bug with xhci dequence/enquence functions. Signed-off-by: Nicholas Krause xerofo...@gmail.com --- include/linux/scatterlist.h | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/include/linux

[PATCH] Add support to check for FALLOC_FL_COLLAPSE_RANGE and FALLOC_FL_ZERO_RANGE crap modes

2014-07-31 Thread Nicholas Krause
This adds checks for the stated modes as if they are crap we will return error not supported. Signed-off-by: Nicholas Krause --- fs/btrfs/file.c |3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/fs/btrfs/file.c b/fs/btrfs/file.c index 1f2b99c..599495a 100644 --- a/fs

[PATCH] Add support to check for FALLOC_FL_COLLAPSE_RANGE and FALLOC_FL_ZERO_RANGE crap modes

2014-07-31 Thread Nicholas Krause
This adds checks for the stated modes as if they are crap we will return error not supported. Signed-off-by: Nicholas Krause xerofo...@gmail.com --- fs/btrfs/file.c |3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/fs/btrfs/file.c b/fs/btrfs/file.c index 1f2b99c..599495a

[PATCH] Remove certain calls for releasing page cache

2014-07-30 Thread Nicholas Krause
-by: Nicholas Krause --- fs/btrfs/compression.c | 17 + 1 file changed, 1 insertion(+), 16 deletions(-) diff --git a/fs/btrfs/compression.c b/fs/btrfs/compression.c index 1daea0b..b55b0e1 100644 --- a/fs/btrfs/compression.c +++ b/fs/btrfs/compression.c @@ -1,4 +1,5

[PATCH] Remove certain calls for releasing page cache

2014-07-30 Thread Nicholas Krause
-by: Nicholas Krause xerofo...@gmail.com --- fs/btrfs/compression.c | 17 + 1 file changed, 1 insertion(+), 16 deletions(-) diff --git a/fs/btrfs/compression.c b/fs/btrfs/compression.c index 1daea0b..b55b0e1 100644 --- a/fs/btrfs/compression.c +++ b/fs/btrfs/compression.c @@ -1,4 +1,5

[PATCH] staging: Remove checkpatch errors in InterfaceMarcos.h

2014-07-23 Thread Nicholas Krause
This removes the two errors I get when running checkpatch on this file. The first being not to use C99 comments and the second to remove spacing issues with the define statement on line 7. Signed-off-by: Nicholas Krause --- drivers/staging/bcm/InterfaceMacros.h | 4 ++-- 1 file changed, 2

[PATCH] staging: Join lines in IntefaceIdleMode.c

2014-07-23 Thread Nicholas Krause
This joins two lines that need to be joined as this improves the coding style and makes it much easier to read. Signed-off-by: Nicholas Krause --- drivers/staging/bcm/InterfaceIdleMode.c | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) diff --git a/drivers/staging/bcm

[PATCH] staging: Fix space issues for header of headers.h

2014-07-23 Thread Nicholas Krause
This patch fixes the space errors checkpatch gives on this file for the header of this file. Signed-off-by: Nicholas Krause --- drivers/staging/bcm/headers.h | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/staging/bcm/headers.h b/drivers/staging/bcm/headers.h index

[PATCH] staging: Add blank line in sync.c

2014-07-23 Thread Nicholas Krause
This patch adds a blank line after line 708 as declared when running checkpatch on this file. Signed-off-by: Nicholas Krause --- drivers/staging/android/sync.c | 1 + 1 file changed, 1 insertion(+) diff --git a/drivers/staging/android/sync.c b/drivers/staging/android/sync.c index e7b2e02

[PATCH] staging: Add blank lines in sw_sync.c

2014-07-23 Thread Nicholas Krause
This adds two blank lines as stated by checkpatch before lines, 100 and 159 respectively. Signed-off-by: Nicholas Krause --- drivers/staging/android/sw_sync.c | 2 ++ 1 file changed, 2 insertions(+) diff --git a/drivers/staging/android/sw_sync.c b/drivers/staging/android/sw_sync.c index

[PATCH] staging: Remove checkpatch error from ion.c

2014-07-23 Thread Nicholas Krause
This patch removes a checkpatch error by adding a line below the definitions of the character array buf and the pointer path. Signed-off-by: Nicholas Krause --- drivers/staging/android/ion/ion.c | 1 + 1 file changed, 1 insertion(+) diff --git a/drivers/staging/android/ion/ion.c b/drivers

[PATCH] staging: Change kzalloc to kcalloc

2014-07-23 Thread Nicholas Krause
This changes the call to kzalloc to kcalloc in ion_dummy_driver for allocating the heap. Signed-off-by: Nicholas Krause --- drivers/staging/android/ion/ion_dummy_driver.c | 5 ++--- 1 file changed, 2 insertions(+), 3 deletions(-) diff --git a/drivers/staging/android/ion/ion_dummy_driver.c b

[PATCH] staging: Remove checkpatch errors in ion.c for android staging

2014-07-23 Thread Nicholas Krause
allocated in ion_dma_buf_kmap. Signed-off-by: Nicholas Krause --- drivers/staging/android/ion/ion.c | 2 ++ 1 file changed, 2 insertions(+) diff --git a/drivers/staging/android/ion/ion.c b/drivers/staging/android/ion/ion.c index 389b8f6..934d55d 100644 --- a/drivers/staging/android/ion/ion.c +++ b

[PATCH] avr32: Remove unnessary variables from page.h

2014-07-23 Thread Nicholas Krause
This removes the unneeded variables memory_start and memory_end in order to fix this fix me message. Signed-off-by: Nicholas Krause --- arch/avr32/include/asm/page.h | 2 -- 1 file changed, 2 deletions(-) diff --git a/arch/avr32/include/asm/page.h b/arch/avr32/include/asm/page.h index f805d1c

[PATCH] avr32: Remove unnessary variables from page.h

2014-07-23 Thread Nicholas Krause
This removes the unneeded variables memory_start and memory_end in order to fix this fix me message. Signed-off-by: Nicholas Krause xerofo...@gmail.com --- arch/avr32/include/asm/page.h | 2 -- 1 file changed, 2 deletions(-) diff --git a/arch/avr32/include/asm/page.h b/arch/avr32/include/asm

[PATCH] staging: Remove checkpatch errors in ion.c for android staging

2014-07-23 Thread Nicholas Krause
allocated in ion_dma_buf_kmap. Signed-off-by: Nicholas Krause xerofo...@gmail.com --- drivers/staging/android/ion/ion.c | 2 ++ 1 file changed, 2 insertions(+) diff --git a/drivers/staging/android/ion/ion.c b/drivers/staging/android/ion/ion.c index 389b8f6..934d55d 100644 --- a/drivers/staging/android

[PATCH] staging: Change kzalloc to kcalloc

2014-07-23 Thread Nicholas Krause
This changes the call to kzalloc to kcalloc in ion_dummy_driver for allocating the heap. Signed-off-by: Nicholas Krause xerofo...@gmail.com --- drivers/staging/android/ion/ion_dummy_driver.c | 5 ++--- 1 file changed, 2 insertions(+), 3 deletions(-) diff --git a/drivers/staging/android/ion

[PATCH] staging: Remove checkpatch error from ion.c

2014-07-23 Thread Nicholas Krause
This patch removes a checkpatch error by adding a line below the definitions of the character array buf and the pointer path. Signed-off-by: Nicholas Krause xerofo...@gmail.com --- drivers/staging/android/ion/ion.c | 1 + 1 file changed, 1 insertion(+) diff --git a/drivers/staging/android/ion

[PATCH] staging: Add blank lines in sw_sync.c

2014-07-23 Thread Nicholas Krause
This adds two blank lines as stated by checkpatch before lines, 100 and 159 respectively. Signed-off-by: Nicholas Krause xerofo...@gmail.com --- drivers/staging/android/sw_sync.c | 2 ++ 1 file changed, 2 insertions(+) diff --git a/drivers/staging/android/sw_sync.c b/drivers/staging/android

[PATCH] staging: Add blank line in sync.c

2014-07-23 Thread Nicholas Krause
This patch adds a blank line after line 708 as declared when running checkpatch on this file. Signed-off-by: Nicholas Krause xerofo...@gmail.com --- drivers/staging/android/sync.c | 1 + 1 file changed, 1 insertion(+) diff --git a/drivers/staging/android/sync.c b/drivers/staging/android/sync.c

[PATCH] staging: Fix space issues for header of headers.h

2014-07-23 Thread Nicholas Krause
This patch fixes the space errors checkpatch gives on this file for the header of this file. Signed-off-by: Nicholas Krause xerofo...@gmail.com --- drivers/staging/bcm/headers.h | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/staging/bcm/headers.h b/drivers/staging

[PATCH] staging: Join lines in IntefaceIdleMode.c

2014-07-23 Thread Nicholas Krause
This joins two lines that need to be joined as this improves the coding style and makes it much easier to read. Signed-off-by: Nicholas Krause xerofo...@gmail.com --- drivers/staging/bcm/InterfaceIdleMode.c | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) diff --git a/drivers/staging/bcm

[PATCH] staging: Remove checkpatch errors in InterfaceMarcos.h

2014-07-23 Thread Nicholas Krause
This removes the two errors I get when running checkpatch on this file. The first being not to use C99 comments and the second to remove spacing issues with the define statement on line 7. Signed-off-by: Nicholas Krause xerofo...@gmail.com --- drivers/staging/bcm/InterfaceMacros.h | 4 ++-- 1

[PATCH] microblaze: Add comment for defines

2014-07-22 Thread Nicholas Krause
This adds a comment for and removes a fix me by labeling these defines as memory cache definitions. Signed-off-by: Nicholas Krause --- arch/microblaze/include/asm/pvr.h | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/arch/microblaze/include/asm/pvr.h b/arch/microblaze

[PATCH] m68k: Remove printk statement and add return statement in q40ints.c

2014-07-22 Thread Nicholas Krause
This removes the printk statement for irqs not defined by the hardware in function q40_irq_startup and instead returns -ENXIO as stated by the fix me message. Signed-off-by: Nicholas Krause --- arch/m68k/q40/q40ints.c | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) diff --git a/arch

[PATCH] x86: Remove Fix me in main.c and add include statement for kvm_para.h

2014-07-22 Thread Nicholas Krause
This patch removes a fix me by including linux/types.h in kvm_para.h as stated by the fix me in main.c and also removes the comment from main.c too. Signed-off-by: Nicholas Krause --- arch/x86/kernel/cpu/mtrr/main.c | 2 +- include/linux/kvm_para.h| 3 +-- 2 files changed, 2 insertions

[PATCH] drbd: Remove fix me statements

2014-07-22 Thread Nicholas Krause
This removes no longer needed fix me statements as the spinlocks are needed to protect against other users of the list accessing it when items on it are being moved off it. Signed-off-by: Nicholas Krause --- drivers/block/drbd/drbd_worker.c | 4 ++-- 1 file changed, 2 insertions(+), 2

[PATCH] s390: Fix me in dasd_eer.c

2014-07-22 Thread Nicholas Krause
This patch changes return type to EMEDUIMTYPE in function, dasd_eer_enable for when checking if the medium has no errors according to this function. Signed-off-by: Nicholas Krause --- drivers/s390/block/dasd_eer.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/s390

[PATCH] s390: Fix me in dasd_eer.c

2014-07-22 Thread Nicholas Krause
This patch changes return type to EMEDUIMTYPE in function, dasd_eer_enable for when checking if the medium has no errors according to this function. Signed-off-by: Nicholas Krause xerofo...@gmail.com --- drivers/s390/block/dasd_eer.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff

[PATCH] drbd: Remove fix me statements

2014-07-22 Thread Nicholas Krause
This removes no longer needed fix me statements as the spinlocks are needed to protect against other users of the list accessing it when items on it are being moved off it. Signed-off-by: Nicholas Krause xerofo...@gmail.com --- drivers/block/drbd/drbd_worker.c | 4 ++-- 1 file changed, 2

[PATCH] x86: Remove Fix me in main.c and add include statement for kvm_para.h

2014-07-22 Thread Nicholas Krause
This patch removes a fix me by including linux/types.h in kvm_para.h as stated by the fix me in main.c and also removes the comment from main.c too. Signed-off-by: Nicholas Krause xerofo...@gmail.com --- arch/x86/kernel/cpu/mtrr/main.c | 2 +- include/linux/kvm_para.h| 3 +-- 2 files

[PATCH] m68k: Remove printk statement and add return statement in q40ints.c

2014-07-22 Thread Nicholas Krause
This removes the printk statement for irqs not defined by the hardware in function q40_irq_startup and instead returns -ENXIO as stated by the fix me message. Signed-off-by: Nicholas Krause xerofo...@gmail.com --- arch/m68k/q40/q40ints.c | 3 +-- 1 file changed, 1 insertion(+), 2 deletions

[PATCH] microblaze: Add comment for defines

2014-07-22 Thread Nicholas Krause
This adds a comment for and removes a fix me by labeling these defines as memory cache definitions. Signed-off-by: Nicholas Krause xerofo...@gmail.com --- arch/microblaze/include/asm/pvr.h | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/arch/microblaze/include/asm/pvr.h b

[PATCH] edac: Remove fixmes in e7xxx_edac.c

2014-07-21 Thread Nicholas Krause
This removes two Page shift fixs me in this file and not checking if row is -1 in process_ce as it cannot be this value or be must exit this function by returning. Signed-off-by: Nicholas Krause --- drivers/edac/e7xxx_edac.c | 10 +- 1 file changed, 5 insertions(+), 5 deletions(-) diff

[PATCH] edac: Remove fixmes in e7xxx_edac.c

2014-07-21 Thread Nicholas Krause
This removes two Page shift fixs me in this file and not checking if row is -1 in process_ce as it cannot be this value or be must exit this function by returning. Signed-off-by: Nicholas Krause xerofo...@gmail.com --- drivers/edac/e7xxx_edac.c | 10 +- 1 file changed, 5 insertions(+), 5

[PATCH] arm: Fix me in bios32.c

2014-07-19 Thread Nicholas Krause
This fixs a fix me in bios32.c for pci_fixup_it8152 as this if statement is incorrect needs to be checked against the class bits not the whole address for the two or conditions and since they don't have define statements outside of their numeratical value. Signed-off-by: Nicholas Krause

[PATCH] arm: Fix me in bios32.c

2014-07-19 Thread Nicholas Krause
This fixs a fix me in bios32.c for pci_fixup_it8152 as this if statement is incorrect needs to be checked against the class bits not the whole address for the two or conditions and since they don't have define statements outside of their numeratical value. Signed-off-by: Nicholas Krause xerofo

[PATCH] mips: Remove uneeded line in cmp_smp_finish

2014-07-18 Thread Nicholas Krause
This patch removes a unneeded line from this file as stated by the fix me in this file. Signed-off-by: Nicholas Krause --- arch/mips/kernel/smp-cmp.c | 2 -- 1 file changed, 2 deletions(-) diff --git a/arch/mips/kernel/smp-cmp.c b/arch/mips/kernel/smp-cmp.c index fc8a515..61bfa20 100644

[PATCH] parisc: Remove FIXME comment

2014-07-18 Thread Nicholas Krause
The comment for size of frame not being needed is incorrect , the function called needs this parameter. Signed-off-by: Nicholas Krause --- arch/parisc/kernel/signal.c | 1 - 1 file changed, 1 deletion(-) diff --git a/arch/parisc/kernel/signal.c b/arch/parisc/kernel/signal.c index 1cba8f2

[PATCH] usb-core: Remove Fix mes in file hcd.c

2014-07-18 Thread Nicholas Krause
I am removing two fix mes in this file as after dicussing then it seems there is no reason to check against Null for usb_device as it can never be NULL and this is check is therefore not needed. Signed-off-by: Nicholas Krause --- drivers/usb/core/hcd.c | 4 1 file changed, 4 deletions

[PATCH] usb-core: Remove Fix mes in file hcd.c

2014-07-18 Thread Nicholas Krause
I am removing two fix mes in this file as after dicussing then it seems there is no reason to check against Null for usb_device as it can never be NULL and this is check is therefore not needed. Signed-off-by: Nicholas Krause xerofo...@gmail.com --- drivers/usb/core/hcd.c | 4 1 file

[PATCH] parisc: Remove FIXME comment

2014-07-18 Thread Nicholas Krause
The comment for size of frame not being needed is incorrect , the function called needs this parameter. Signed-off-by: Nicholas Krause xerofo...@gmail.com --- arch/parisc/kernel/signal.c | 1 - 1 file changed, 1 deletion(-) diff --git a/arch/parisc/kernel/signal.c b/arch/parisc/kernel/signal.c

[PATCH] mips: Remove uneeded line in cmp_smp_finish

2014-07-18 Thread Nicholas Krause
This patch removes a unneeded line from this file as stated by the fix me in this file. Signed-off-by: Nicholas Krause xerofo...@gmail.com --- arch/mips/kernel/smp-cmp.c | 2 -- 1 file changed, 2 deletions(-) diff --git a/arch/mips/kernel/smp-cmp.c b/arch/mips/kernel/smp-cmp.c index fc8a515

[PATCH] ia64: Fix me add register r8

2014-07-17 Thread Nicholas Krause
The function user_stack_pointer was not returning the correct value \ as stated by a Fix Me message before the function declaration. I fixed the return value to add register r8 as that register stores dirty pages. Signed-off-by: Nicholas Krause --- arch/ia64/include/asm/ptrace.h | 3 +-- 1 file

[PATCH] ia64: Fix me add register r8

2014-07-17 Thread Nicholas Krause
The function user_stack_pointer was not returning the correct value \ as stated by a Fix Me message before the function declaration. I fixed the return value to add register r8 as that register stores dirty pages. Signed-off-by: Nicholas Krause xerofo...@gmail.com --- arch/ia64/include/asm

[PATCH] m68k: Remove unneeded FIXME message in sun3_pgalloc.h

2014-07-16 Thread Nicholas Krause
This removes a FIX ME message due to this file not compiling. Now that this message is no longer needed I am removing it from sun3_pgalloc.h. Signed-off-by: Nicholas Krause --- arch/m68k/include/asm/sun3_pgalloc.h | 2 -- 1 file changed, 2 deletions(-) diff --git a/arch/m68k/include/asm

[PATCH] m68k: Remove unneeded FIXME message in sun3_pgalloc.h

2014-07-16 Thread Nicholas Krause
This removes a FIX ME message due to this file not compiling. Now that this message is no longer needed I am removing it from sun3_pgalloc.h. Signed-off-by: Nicholas Krause xerofo...@gmail.com --- arch/m68k/include/asm/sun3_pgalloc.h | 2 -- 1 file changed, 2 deletions(-) diff --git a/arch/m68k

[PATCH 2/4] alpha: checkpatch errors in mkbb for if statements

2014-07-15 Thread Nicholas Krause
This patch fixes all errors related to no space between if and parthesises to remove this errors when running checkpatch against this file. --- arch/alpha/boot/tools/mkbb.c | 14 +++--- 1 file changed, 7 insertions(+), 7 deletions(-) diff --git a/arch/alpha/boot/tools/mkbb.c

[PATCH 3/4] alpha: Indent if Statements properly

2014-07-15 Thread Nicholas Krause
This patch removes the errors this file gets with checkpatch due to errors relating to if statements and their enclosing statements not being indented properly. --- arch/alpha/boot/tools/mkbb.c | 34 +- 1 file changed, 17 insertions(+), 17 deletions(-) diff --git

[PATCH 1/4] alpha: Converse all space errors into tabs in mkbb.c

2014-07-15 Thread Nicholas Krause
This patch fixes all the checkpatch errors I get when running it on mkbb.c for spaces at beginning of lines. I converted then all to tabs to fix these checkpatch warnings. --- arch/alpha/boot/tools/mkbb.c | 124 +-- 1 file changed, 61 insertions(+), 63

[PATCH 4/4] alpha: Remove checkpatch error in mkk.b

2014-07-15 Thread Nicholas Krause
This removes a error I get when I run checkpatch on this file, relating to the asterisk for declaritations needing to be next to the name of the variable/structure and not the type of variable/structure. --- arch/alpha/boot/tools/mkbb.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff

[PATCH 6/6 v2] alpha: Join lines and merge strings for the two lines

2014-07-15 Thread Nicholas Krause
This patch merges lines 92 and 93. In addition it merges the strings on both lines by removing the quotes around the seperate strings. This is needed to remove the final checkpatch error I get from running it on bootpz.c Signed-off-by: Nicholas Krause --- arch/alpha/boot/bootpz.c | 3 +-- 1

[PATCH 2/5] alpha: Fix spacing in misc.c

2014-07-15 Thread Nicholas Krause
Due to errors with checkpatch in this file I am checking certain defintions spacing to pass checkpatch for spacing issues. --- arch/alpha/boot/misc.c | 23 --- 1 file changed, 12 insertions(+), 11 deletions(-) diff --git a/arch/alpha/boot/misc.c b/arch/alpha/boot/misc.c index

[PATCH 5/5] alpha: Fix while statement

2014-07-15 Thread Nicholas Krause
This fixes the if statement on line 147 of misc.c to have parthesises around itself removing a checkpatch error on this line. --- arch/alpha/boot/misc.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/arch/alpha/boot/misc.c b/arch/alpha/boot/misc.c index 886e469..56c3325

[PATCH 4/5] alpha: Fix complex marco definitions

2014-07-15 Thread Nicholas Krause
This patch fixes all macro defintions that need parthesises as stated by checkpatch when run against this file. --- arch/alpha/boot/misc.c | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/arch/alpha/boot/misc.c b/arch/alpha/boot/misc.c index 174b7c6..886e469 100644 ---

[PATCH 3/5] alpha: Remove whitespace errors that cleanfile missed

2014-07-15 Thread Nicholas Krause
This patch removes the whitespace error that cleanfile missed when I ran it on this file. --- arch/alpha/boot/misc.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/arch/alpha/boot/misc.c b/arch/alpha/boot/misc.c index 119d500..174b7c6 100644 --- a/arch/alpha/boot/misc.c +++

[PATCH 1/5] alpha: checkpatch whitespace errors in misc.c

2014-07-15 Thread Nicholas Krause
This patch runs cleanfile against this file in order to remove all outstanding whitespace errors caught when I ran checkpatch on it. --- arch/alpha/boot/misc.c | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/arch/alpha/boot/misc.c b/arch/alpha/boot/misc.c index

[PATCH 4/6] alpha: Remove bracket errors in bootpz.c

2014-07-15 Thread Nicholas Krause
This patch removes all errors related to brackets not being placed correctly in this file as declared when running checkpatch on it. --- arch/alpha/boot/bootpz.c | 18 ++ 1 file changed, 6 insertions(+), 12 deletions(-) diff --git a/arch/alpha/boot/bootpz.c

[PATCH 5/6] alpha: Add line below declartion on line 287

2014-07-15 Thread Nicholas Krause
This patch adds a line before the declartion of asm_sp in order to fix a checkpatch error I get when running it on this file. --- arch/alpha/boot/bootpz.c | 1 + 1 file changed, 1 insertion(+) diff --git a/arch/alpha/boot/bootpz.c b/arch/alpha/boot/bootpz.c index 6dd34e4..6fc840d 100644 ---

[PATCH 3/6] alpha: Remove all errors for checkpatch foo* bar

2014-07-15 Thread Nicholas Krause
This patch changes all issues with checkpatch relating to the asterisk not being put next to the variable or structrue name and rather the type of the declaring statement. --- arch/alpha/boot/bootpz.c | 12 ++-- 1 file changed, 6 insertions(+), 6 deletions(-) diff --git

[PATCH 6/6] alpha: Join lines 90 and 91

2014-07-15 Thread Nicholas Krause
This fixes the checkpatch error I get in this file relating to a quoted string needed to be joined to the line above it. --- arch/alpha/boot/bootpz.c | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) diff --git a/arch/alpha/boot/bootpz.c b/arch/alpha/boot/bootpz.c index 6fc840d..a9e127b

[PATCH 2/6] alpha: Fix spaces to tabs

2014-07-15 Thread Nicholas Krause
This patch fixes all errors for this file related to using spaces instead of tabs. --- arch/alpha/boot/bootpz.c | 8 1 file changed, 4 insertions(+), 4 deletions(-) diff --git a/arch/alpha/boot/bootpz.c b/arch/alpha/boot/bootpz.c index 64a0da6..15c16fe 100644 ---

[PATCH 1/6] alpha: Remove whiterrors related to uneeded characters and lines

2014-07-15 Thread Nicholas Krause
This file has multipe cleanpatch errors. This patch is the first in a series to clean them up. This one removes uneeded characters and lines from this file. --- arch/alpha/boot/bootpz.c | 12 ++-- 1 file changed, 6 insertions(+), 6 deletions(-) diff --git a/arch/alpha/boot/bootpz.c

[PATCH 1/6] alpha: Remove whiterrors related to uneeded characters and lines

2014-07-15 Thread Nicholas Krause
This file has multipe cleanpatch errors. This patch is the first in a series to clean them up. This one removes uneeded characters and lines from this file. --- arch/alpha/boot/bootpz.c | 12 ++-- 1 file changed, 6 insertions(+), 6 deletions(-) diff --git a/arch/alpha/boot/bootpz.c

[PATCH 2/6] alpha: Fix spaces to tabs

2014-07-15 Thread Nicholas Krause
This patch fixes all errors for this file related to using spaces instead of tabs. --- arch/alpha/boot/bootpz.c | 8 1 file changed, 4 insertions(+), 4 deletions(-) diff --git a/arch/alpha/boot/bootpz.c b/arch/alpha/boot/bootpz.c index 64a0da6..15c16fe 100644 ---

[PATCH 6/6] alpha: Join lines 90 and 91

2014-07-15 Thread Nicholas Krause
This fixes the checkpatch error I get in this file relating to a quoted string needed to be joined to the line above it. --- arch/alpha/boot/bootpz.c | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) diff --git a/arch/alpha/boot/bootpz.c b/arch/alpha/boot/bootpz.c index 6fc840d..a9e127b

[PATCH 3/6] alpha: Remove all errors for checkpatch foo* bar

2014-07-15 Thread Nicholas Krause
This patch changes all issues with checkpatch relating to the asterisk not being put next to the variable or structrue name and rather the type of the declaring statement. --- arch/alpha/boot/bootpz.c | 12 ++-- 1 file changed, 6 insertions(+), 6 deletions(-) diff --git

[PATCH 4/6] alpha: Remove bracket errors in bootpz.c

2014-07-15 Thread Nicholas Krause
This patch removes all errors related to brackets not being placed correctly in this file as declared when running checkpatch on it. --- arch/alpha/boot/bootpz.c | 18 ++ 1 file changed, 6 insertions(+), 12 deletions(-) diff --git a/arch/alpha/boot/bootpz.c

[PATCH 5/6] alpha: Add line below declartion on line 287

2014-07-15 Thread Nicholas Krause
This patch adds a line before the declartion of asm_sp in order to fix a checkpatch error I get when running it on this file. --- arch/alpha/boot/bootpz.c | 1 + 1 file changed, 1 insertion(+) diff --git a/arch/alpha/boot/bootpz.c b/arch/alpha/boot/bootpz.c index 6dd34e4..6fc840d 100644 ---

[PATCH 1/5] alpha: checkpatch whitespace errors in misc.c

2014-07-15 Thread Nicholas Krause
This patch runs cleanfile against this file in order to remove all outstanding whitespace errors caught when I ran checkpatch on it. --- arch/alpha/boot/misc.c | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/arch/alpha/boot/misc.c b/arch/alpha/boot/misc.c index

[PATCH 5/5] alpha: Fix while statement

2014-07-15 Thread Nicholas Krause
This fixes the if statement on line 147 of misc.c to have parthesises around itself removing a checkpatch error on this line. --- arch/alpha/boot/misc.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/arch/alpha/boot/misc.c b/arch/alpha/boot/misc.c index 886e469..56c3325

[PATCH 4/5] alpha: Fix complex marco definitions

2014-07-15 Thread Nicholas Krause
This patch fixes all macro defintions that need parthesises as stated by checkpatch when run against this file. --- arch/alpha/boot/misc.c | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/arch/alpha/boot/misc.c b/arch/alpha/boot/misc.c index 174b7c6..886e469 100644 ---

[PATCH 3/5] alpha: Remove whitespace errors that cleanfile missed

2014-07-15 Thread Nicholas Krause
This patch removes the whitespace error that cleanfile missed when I ran it on this file. --- arch/alpha/boot/misc.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/arch/alpha/boot/misc.c b/arch/alpha/boot/misc.c index 119d500..174b7c6 100644 --- a/arch/alpha/boot/misc.c +++

[PATCH 2/5] alpha: Fix spacing in misc.c

2014-07-15 Thread Nicholas Krause
Due to errors with checkpatch in this file I am checking certain defintions spacing to pass checkpatch for spacing issues. --- arch/alpha/boot/misc.c | 23 --- 1 file changed, 12 insertions(+), 11 deletions(-) diff --git a/arch/alpha/boot/misc.c b/arch/alpha/boot/misc.c index

[PATCH 6/6 v2] alpha: Join lines and merge strings for the two lines

2014-07-15 Thread Nicholas Krause
This patch merges lines 92 and 93. In addition it merges the strings on both lines by removing the quotes around the seperate strings. This is needed to remove the final checkpatch error I get from running it on bootpz.c Signed-off-by: Nicholas Krause xerofo...@gmail.com --- arch/alpha/boot

[PATCH 4/4] alpha: Remove checkpatch error in mkk.b

2014-07-15 Thread Nicholas Krause
This removes a error I get when I run checkpatch on this file, relating to the asterisk for declaritations needing to be next to the name of the variable/structure and not the type of variable/structure. --- arch/alpha/boot/tools/mkbb.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff

[PATCH 3/4] alpha: Indent if Statements properly

2014-07-15 Thread Nicholas Krause
This patch removes the errors this file gets with checkpatch due to errors relating to if statements and their enclosing statements not being indented properly. --- arch/alpha/boot/tools/mkbb.c | 34 +- 1 file changed, 17 insertions(+), 17 deletions(-) diff --git

[PATCH 1/4] alpha: Converse all space errors into tabs in mkbb.c

2014-07-15 Thread Nicholas Krause
This patch fixes all the checkpatch errors I get when running it on mkbb.c for spaces at beginning of lines. I converted then all to tabs to fix these checkpatch warnings. --- arch/alpha/boot/tools/mkbb.c | 124 +-- 1 file changed, 61 insertions(+), 63

[PATCH 2/4] alpha: checkpatch errors in mkbb for if statements

2014-07-15 Thread Nicholas Krause
This patch fixes all errors related to no space between if and parthesises to remove this errors when running checkpatch against this file. --- arch/alpha/boot/tools/mkbb.c | 14 +++--- 1 file changed, 7 insertions(+), 7 deletions(-) diff --git a/arch/alpha/boot/tools/mkbb.c

[PATCH 2/5] alpha: Checkpatch warnings on lines 71 and 72

2014-07-14 Thread Nicholas Krause
In bootp.c I am hitting lots of warnings this fixes two on lines 71,72 in order to pass checkpatch and follow kernel coding style. --- arch/alpha/boot/bootp.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/arch/alpha/boot/bootp.c b/arch/alpha/boot/bootp.c index

[PATCH 3/5] alpha: Remove whitespace issues and turn spaces into tabs

2014-07-14 Thread Nicholas Krause
This patch removes all the whitespace an tab issues that this file has when running checkpatch --- arch/alpha/boot/bootp.c | 10 +- 1 file changed, 5 insertions(+), 5 deletions(-) diff --git a/arch/alpha/boot/bootp.c b/arch/alpha/boot/bootp.c index 3ee529d..6227e4f 100644 ---

  1   2   3   >