On Wed, Apr 14, 2021 at 12:04 PM Eric Biggers wrote:
>
> On Wed, Apr 14, 2021 at 11:53:51AM -0700, Nick Terrell wrote:
> > On Wed, Apr 14, 2021 at 11:35 AM Eric Biggers wrote:
> > >
> > > On Wed, Apr 14, 2021 at 11:01:29AM -0700, Nick Terrell wrote:
> > > &
On Wed, Apr 14, 2021 at 11:35 AM Eric Biggers wrote:
>
> On Wed, Apr 14, 2021 at 11:01:29AM -0700, Nick Terrell wrote:
> > Hi all,
> >
> > I would really like to make some progress on this and get it merged.
> > This patchset offsers:
> > * 15-30% better decom
On Fri, Apr 9, 2021 at 2:39 PM Nick Terrell wrote:
>
> What can I do to help get this merged?
>
> Cristoph, is this new patch series with the kernel wrapper API satisfactory?
>
> Best,
> Nick
>
> On Tue, Mar 30, 2021 at 3:45 PM Nick Terrell wrote:
> >
> > From:
w
have been ignored.
[0] https://www.mail-archive.com/linux-kernel@vger.kernel.org/msg2532407.html
Best,
Nick Terrell
> Cheers,
> Miguel
What can I do to help get this merged?
Cristoph, is this new patch series with the kernel wrapper API satisfactory?
Best,
Nick
On Tue, Mar 30, 2021 at 3:45 PM Nick Terrell wrote:
>
> From: Nick Terrell
>
> Please pull from
>
> g...@github.com:terrelln/linux.git t
> On Apr 7, 2021, at 6:53 AM, Masahiro Yamada wrote:
>
> On Thu, Apr 1, 2021 at 4:21 AM Nick Terrell wrote:
>>
>>
>>
>>> On Mar 31, 2021, at 10:48 AM, Oleksandr Natalenko
>>> wrote:
>>>
>>> Hello.
>&g
> On Apr 1, 2021, at 12:54 AM, torv...@mailbox.org wrote:
>
> Thanks Piotr, good work!
> Question: Is `-T0` really faster in this particular case than the default
> `-T1`? Are modules installed sequentially?
The zstd CLI produces deterministic output regardless of the number of threads
> On Mar 31, 2021, at 10:48 AM, Oleksandr Natalenko
> wrote:
>
> Hello.
>
> On Wed, Mar 31, 2021 at 05:39:25PM +, Nick Terrell wrote:
>>
>>
>>> On Mar 30, 2021, at 4:50 AM, Oleksandr Natalenko
>>> wrote:
>>>
>>> On Tu
, which
will use a
window size of up to 2MB, to match the XZ command. Note that if the file is
smaller than
the window size, it will be shrunk to the smallest power of two at least as
large as the file.
Best,
Nick Terrell
>> + endif # CONFIG_MODULE_COMPRESS_ZSTD
>> endif # CONFIG_MODUL
From: Nick Terrell
Adds decompress_sources.h which includes every .c file necessary for
zstd decompression. This is used in decompress_unzstd.c so the internal
structure of the library isn't exposed.
This allows us to upgrade the zstd library version without modifying any
callers. Instead we
From: Nick Terrell
This patch:
- Moves `include/linux/zstd.h` -> `include/linux/zstd_lib.h`
- Updates modified zstd headers to yearless copyright
- Adds a new API in `include/linux/zstd.h` that is functionally
equivalent to the in-use subset of the current API. Functions are
renamed to av
From: Nick Terrell
Please pull from
g...@github.com:terrelln/linux.git tags/v9-zstd-1.4.10
to get these changes. Alternatively the patchset is included.
This patchset upgrades the zstd library to the latest upstream release. The
current zstd version in the kernel is a modified version
On Sat, Mar 27, 2021 at 2:48 PM Oleksandr Natalenko
wrote:
>
> Hello.
>
> On Sat, Mar 27, 2021 at 05:48:01PM +0800, kernel test robot wrote:
> > >> ERROR: modpost: "ZSTD_maxCLevel" [fs/f2fs/f2fs.ko] undefined!
>
> Since f2fs can be built as a module, the following correction seems to
> be needed:
> https://github.com/0day-ci/linux/commits/Nick-Terrell/Update-to-zstd-1-4-10/20210327-031827
> base:
> https://git.kernel.org/pub/scm/linux/kernel/git/herbert/cryptodev-2.6.git
> master
> config: um-allmodconfig (attached as .config)
> compiler: gcc-9 (Debian 9.3.0-22) 9
From: Nick Terrell
Adds decompress_sources.h which includes every .c file necessary for
zstd decompression. This is used in decompress_unzstd.c so the internal
structure of the library isn't exposed.
This allows us to upgrade the zstd library version without modifying any
callers. Instead we
From: Nick Terrell
Please pull from
g...@github.com:terrelln/linux.git tags/v8-zstd-1.4.10
to get these changes. Alternatively the patchset is included.
This patchset upgrades the zstd library to the latest upstream release. The
current zstd version in the kernel is a modified version
From: Nick Terrell
This patch:
- Moves `include/linux/zstd.h` -> `include/linux/zstd_lib.h`
- Adds a new API in `include/linux/zstd.h` that is functionally
equivalent to the in-use subset of the current API. Functions are
renamed to avoid symbol collisions with zstd, to make it cl
> On Dec 16, 2020, at 5:23 PM, Michał Mirosław wrote:
>
> On Wed, Dec 16, 2020 at 10:07:38PM +0000, Nick Terrell wrote:
> [...]
>> It is very large. If it helps, in the commit message I’ve provided this link
>> [0],
>> which provides the diff between upstream zs
> On Dec 16, 2020, at 10:50 AM, David Sterba wrote:
>
> On Wed, Dec 16, 2020 at 11:58:07AM +1100, Herbert Xu wrote:
>> On Wed, Dec 16, 2020 at 12:48:51AM +0000, Nick Terrell wrote:
>>>
>>> Thanks for the advice! The first zstd patches went through Herbert’s
> On Dec 15, 2020, at 4:58 PM, Herbert Xu wrote:
>
> On Wed, Dec 16, 2020 at 12:48:51AM +0000, Nick Terrell wrote:
>>
>> Thanks for the advice! The first zstd patches went through Herbert’s tree,
>> which is
>> why I’ve sent them this way.
>
>
> On Dec 15, 2020, at 4:00 PM, Eric Biggers wrote:
>
> On Tue, Dec 15, 2020 at 08:58:52PM +0000, Nick Terrell via Linux-f2fs-devel
> wrote:
>>
>>
>>> On Dec 3, 2020, at 12:51 PM, Nick Terrell wrote:
>>>
>>> From: Nick Terrell
>>
> On Dec 3, 2020, at 12:51 PM, Nick Terrell wrote:
>
> From: Nick Terrell
>
> Please pull from
>
> g...@github.com:terrelln/linux.git tags/v7-zstd-1.4.6
>
> to get these changes. Alternatively the patchset is included.
Is it possible to get this patchset merg
> On Dec 2, 2020, at 9:03 PM, Michał Mirosław wrote:
>
> On Thu, Dec 03, 2020 at 03:59:21AM +0000, Nick Terrell wrote:
>> On Dec 2, 2020, at 7:14 PM, Michał Mirosław wrote:
>>> On Thu, Dec 03, 2020 at 01:42:03AM +, Nick Terrell wrote:
>>>> On Dec
From: Nick Terrell
Adds decompress_sources.h which includes every .c file necessary for
zstd decompression. This is used in decompress_unzstd.c so the internal
structure of the library isn't exposed.
This allows us to upgrade the zstd library version without modifying any
callers. Instead we
From: Nick Terrell
This patch:
- Moves `include/linux/zstd.h` -> `include/linux/zstd_lib.h`
- Adds a new API in `include/linux/zstd.h` that is functionally
equivalent to the in-use subset of the current API. Functions are
renamed to avoid symbol collisions with zstd, to make it cl
From: Nick Terrell
Please pull from
g...@github.com:terrelln/linux.git tags/v7-zstd-1.4.6
to get these changes. Alternatively the patchset is included.
This patchset upgrades the zstd library to the latest upstream release. The
current zstd version in the kernel is a modified version
> On Dec 2, 2020, at 9:03 PM, Michał Mirosław wrote:
>
> On Thu, Dec 03, 2020 at 03:59:21AM +0000, Nick Terrell wrote:
>> On Dec 2, 2020, at 7:14 PM, Michał Mirosław wrote:
>>> On Thu, Dec 03, 2020 at 01:42:03AM +, Nick Terrell wrote:
>>>> On Dec
> On Dec 2, 2020, at 7:14 PM, Michał Mirosław wrote:
>
> On Thu, Dec 03, 2020 at 01:42:03AM +0000, Nick Terrell wrote:
>>
>>
>>> On Dec 2, 2020, at 5:16 PM, Michał Mirosław wrote:
>>>
>>> On Wed, Dec 02, 2020 at 12:32:40PM -0
> On Dec 2, 2020, at 5:16 PM, Michał Mirosław wrote:
>
> On Wed, Dec 02, 2020 at 12:32:40PM -0800, Nick Terrell wrote:
>> From: Nick Terrell
>>
>> This patch:
>> - Moves `include/linux/zstd.h` -> `lib/zstd/zstd.h`
>> - Adds a new API in `
From: Nick Terrell
Adds decompress_sources.h which includes every .c file necessary for
zstd decompression. This is used in decompress_unzstd.c so the internal
structure of the library isn't exposed.
This allows us to upgrade the zstd library version without modifying any
callers. Instead we
From: Nick Terrell
Please pull from
g...@github.com:terrelln/linux.git tags/zstd-1.4.6-v6
to get these changes. Alternatively the patchset is included.
This patchset upgrades the zstd library to the latest upstream release. The
current zstd version in the kernel is a modified version
to memmove() for sure
> considering it's an undefined behavior according to the standard
> and some unique optimization already exists in the kernel.
>
> [1] https://github.com/lz4/lz4/commit/33cb8518ac385835cc17be9a770b27b40cd0e15b
> [2] https://github.com/lz4/lz4/pull/717#issueco
> On Nov 10, 2020, at 10:39 AM, Christoph Hellwig wrote:
>
> On Mon, Nov 09, 2020 at 02:01:41PM -0500, Chris Mason wrote:
>> You do consistently ask for a shim layer, but you haven???t explained what
>> we gain by diverging from the documented and tested API of the upstream zstd
>> project.
> On Nov 10, 2020, at 7:25 AM, David Sterba wrote:
>
> On Mon, Nov 09, 2020 at 02:01:41PM -0500, Chris Mason wrote:
>> On 6 Nov 2020, at 13:38, Christoph Hellwig wrote:
>>> You just keep resedning this crap, don't you? Haven't you been told
>>> multiple times to provide a proper kernel API by
> On Nov 6, 2020, at 9:15 AM, Josef Bacik wrote:
>
> On 11/3/20 1:05 AM, Nick Terrell wrote:
>> From: Nick Terrell
>> Please pull from
>> g...@github.com:terrelln/linux.git tags/v5-zstd-1.4.6
>> to get these changes. Alternatively the patchset is incl
> On Nov 6, 2020, at 9:10 AM, Josef Bacik wrote:
>
> On 11/3/20 1:05 AM, Nick Terrell wrote:
>> From: Nick Terrell
>> Move away from the compatibility wrapper to the zstd-1.4.6 API. This
>> code is functionally equivalent.
>> Signed-off-by: Nick Terrell
From: Nick Terrell
Move away from the compatibility wrapper to the zstd-1.4.6 API. This
code is functionally equivalent.
Signed-off-by: Nick Terrell
---
fs/btrfs/zstd.c | 48
1 file changed, 28 insertions(+), 20 deletions(-)
diff --git a/fs
From: Nick Terrell
Move away from the compatibility wrapper to the zstd-1.4.6 API. This
code is functionally equivalent.
Signed-off-by: Nick Terrell
---
lib/decompress_unzstd.c | 40 ++--
1 file changed, 14 insertions(+), 26 deletions(-)
diff --git a/lib
From: Nick Terrell
All callers have been transitioned to the new zstd-1.4.6 API. There are
no more callers of the zstd compatibility wrapper, so delete it.
Signed-off-by: Nick Terrell
---
include/linux/zstd_compat.h | 116
1 file changed, 116 deletions
From: Nick Terrell
Please pull from
g...@github.com:terrelln/linux.git tags/v5-zstd-1.4.6
to get these changes. Alternatively the patchset is included.
This patchset upgrades the zstd library to the latest upstream release. The
current zstd version in the kernel is a modified version
From: Nick Terrell
Move away from the compatibility wrapper to the zstd-1.4.6 API. This
code is functionally equivalent.
Signed-off-by: Nick Terrell
---
fs/squashfs/zstd_wrapper.c | 9 -
1 file changed, 4 insertions(+), 5 deletions(-)
diff --git a/fs/squashfs/zstd_wrapper.c b/fs
From: Nick Terrell
Move away from the compatibility wrapper to the zstd-1.4.6 API. This
code is more efficient because it uses the single-pass API instead of
the streaming API. The streaming API is not necessary because the whole
input and output buffers are available. This saves memory because
From: Nick Terrell
Move away from the compatibility wrapper to the zstd-1.4.6 API. This
code is functionally equivalent.
Signed-off-by: Nick Terrell
---
crypto/zstd.c | 24 +++-
1 file changed, 11 insertions(+), 13 deletions(-)
diff --git a/crypto/zstd.c b/crypto/zstd.c
From: Nick Terrell
Adds decompress_sources.h which includes every .c file necessary for
zstd decompression. This is used in decompress_unzstd.c so the internal
structure of the library isn't exposed.
This allows us to upgrade the zstd library version without modifying any
callers. Instead we
From: Nick Terrell
Adds zstd_compat.h which provides the necessary functions from the
current zstd.h API. It is only active for zstd versions 1.4.6 and newer.
That means it is disabled currently, but will become active when a later
patch in this series updates the zstd library in the kernel
> On Oct 1, 2020, at 3:18 AM, David Sterba wrote:
>
> On Wed, Sep 30, 2020 at 08:49:49PM +0000, Nick Terrell wrote:
>>> On Sep 29, 2020, at 11:53 PM, Nick Terrell wrote:
>>>
>>> From: Nick Terrell
>>
>> It has been brought to my attention tha
> On Sep 29, 2020, at 11:53 PM, Nick Terrell wrote:
>
> From: Nick Terrell
It has been brought to my attention that patch 3 hasn’t made it to patchwork,
likely because it is too large. I’ll include a pull request in the next cover
letter,
together with the patches (if needed).
Pl
upstream's API, to upstream's API.
-Nick
> On Tue, Sep 29, 2020 at 11:53:09PM -0700, Nick Terrell wrote:
>> From: Nick Terrell
>>
>> This patchset upgrades the zstd library to the latest upstream release. The
>> current zstd version in the kernel is a modified version
From: Nick Terrell
Move away from the compatibility wrapper to the zstd-1.4.6 API. This
code is functionally equivalent.
Signed-off-by: Nick Terrell
---
lib/decompress_unzstd.c | 40 ++--
1 file changed, 14 insertions(+), 26 deletions(-)
diff --git a/lib
From: Nick Terrell
All callers have been transitioned to the new zstd-1.4.6 API. There are
no more callers of the zstd compatibility wrapper, so delete it.
Signed-off-by: Nick Terrell
---
include/linux/zstd_compat.h | 116
1 file changed, 116 deletions
From: Nick Terrell
Move away from the compatibility wrapper to the zstd-1.4.6 API. This
code is functionally equivalent.
Signed-off-by: Nick Terrell
---
fs/btrfs/zstd.c | 48
1 file changed, 28 insertions(+), 20 deletions(-)
diff --git a/fs
From: Nick Terrell
Move away from the compatibility wrapper to the zstd-1.4.6 API. This
code is functionally equivalent.
Signed-off-by: Nick Terrell
---
fs/squashfs/zstd_wrapper.c | 9 -
1 file changed, 4 insertions(+), 5 deletions(-)
diff --git a/fs/squashfs/zstd_wrapper.c b/fs
From: Nick Terrell
Move away from the compatibility wrapper to the zstd-1.4.6 API. This
code is more efficient because it uses the single-pass API instead of
the streaming API. The streaming API is not necessary because the whole
input and output buffers are available. This saves memory because
From: Nick Terrell
Move away from the compatibility wrapper to the zstd-1.4.6 API. This
code is functionally equivalent.
Signed-off-by: Nick Terrell
---
crypto/zstd.c | 24 +++-
1 file changed, 11 insertions(+), 13 deletions(-)
diff --git a/crypto/zstd.c b/crypto/zstd.c
From: Nick Terrell
Adds zstd_compat.h which provides the necessary functions from the
current zstd.h API. It is only active for zstd versions 1.4.6 and newer.
That means it is disabled currently, but will become active when a later
patch in this series updates the zstd library in the kernel
From: Nick Terrell
This patchset upgrades the zstd library to the latest upstream release. The
current zstd version in the kernel is a modified version of upstream zstd-1.3.1.
At the time it was integrated, zstd wasn't ready to be used in the kernel as-is.
But, it is now possible to use upstream
From: Nick Terrell
Adds decompress_sources.h which includes every .c file necessary for
zstd decompression. This is used in decompress_unzstd.c so the internal
structure of the library isn't exposed.
This allows us to upgrade the zstd library version without modifying any
callers. Instead we
> On Sep 28, 2020, at 11:02 AM, Nick Terrell wrote:
>
>
>
>> On Sep 28, 2020, at 1:55 AM, Feng Tang wrote:
>>
>> Hi Nick,
>>
>> 0day has found some kernel decomprssion failure case since 5.9-rc1 (X86_32
>> build), and it could be rela
> On Sep 28, 2020, at 1:55 AM, Feng Tang wrote:
>
> Hi Nick,
>
> 0day has found some kernel decomprssion failure case since 5.9-rc1 (X86_32
> build), and it could be related with ZSTD code, though initially we bisected
> to some other commits.
>
> The error messages are:
>
>
cryptodev/master crypto/master]
> [If your patch is applied to the wrong git tree, kindly drop us a note.
> And when submitting patch, we suggest to use '--base' as documented in
> https://git-scm.com/docs/git-format-patch]
>
> url:
> https://github.com/0day-ci/linux/commits/
From: Nick Terrell
Move away from the compatibility wrapper to the zstd-1.4.6 API. This
code is functionally equivalent.
Signed-off-by: Nick Terrell
---
fs/squashfs/zstd_wrapper.c | 9 -
1 file changed, 4 insertions(+), 5 deletions(-)
diff --git a/fs/squashfs/zstd_wrapper.c b/fs
From: Nick Terrell
Move away from the compatibility wrapper to the zstd-1.4.6 API. This
code is more efficient because it uses the single-pass API instead of
the streaming API. The streaming API is not necessary because the whole
input and output buffers are available. This saves memory because
From: Nick Terrell
All callers have been transitioned to the new zstd-1.4.6 API. There are
no more callers of the zstd compatibility wrapper, so delete it.
Signed-off-by: Nick Terrell
---
include/linux/zstd_compat.h | 116
1 file changed, 116 deletions
From: Nick Terrell
Move away from the compatibility wrapper to the zstd-1.4.6 API. This
code is functionally equivalent.
Signed-off-by: Nick Terrell
---
lib/decompress_unzstd.c | 40 ++--
1 file changed, 14 insertions(+), 26 deletions(-)
diff --git a/lib
From: Nick Terrell
Move away from the compatibility wrapper to the zstd-1.4.6 API. This
code is functionally equivalent.
Signed-off-by: Nick Terrell
---
fs/btrfs/zstd.c | 48
1 file changed, 28 insertions(+), 20 deletions(-)
diff --git a/fs
From: Nick Terrell
Move away from the compatibility wrapper to the zstd-1.4.6 API. This
code is functionally equivalent.
Signed-off-by: Nick Terrell
---
crypto/zstd.c | 24 +++-
1 file changed, 11 insertions(+), 13 deletions(-)
diff --git a/crypto/zstd.c b/crypto/zstd.c
From: Nick Terrell
Adds decompress_sources.h which includes every .c file necessary for
zstd decompression. This is used in decompress_unzstd.c so the internal
structure of the library isn't exposed.
This allows us to upgrade the zstd library version without modifying any
callers. Instead we
From: Nick Terrell
Adds zstd_compat.h which provides the necessary functions from the
current zstd.h API. It is only active for zstd versions 1.4.6 and newer.
That means it is disabled currently, but will become active when a later
patch in this series updates the zstd library in the kernel
From: Nick Terrell
This patchset upgrades the zstd library to the latest upstream release. The
current zstd version in the kernel is a modified version of upstream zstd-1.3.1.
At the time it was integrated, zstd wasn't ready to be used in the kernel as-is.
But, it is now possible to use upstream
From: Nick Terrell
Move away from the compatibility wrapper to the zstd-1.4.6 API. This
code is functionally equivalent.
Signed-off-by: Nick Terrell
---
crypto/zstd.c | 24 +++-
1 file changed, 11 insertions(+), 13 deletions(-)
diff --git a/crypto/zstd.c b/crypto/zstd.c
From: Nick Terrell
Move away from the compatibility wrapper to the zstd-1.4.6 API. This
code is functionally equivalent.
Signed-off-by: Nick Terrell
---
fs/squashfs/zstd_wrapper.c | 9 -
1 file changed, 4 insertions(+), 5 deletions(-)
diff --git a/fs/squashfs/zstd_wrapper.c b/fs
From: Nick Terrell
All callers have been transitioned to the new zstd-1.4.6 API. There are
no more callers of the zstd compatibility wrapper, so delete it.
Signed-off-by: Nick Terrell
---
include/linux/zstd_compat.h | 116
1 file changed, 116 deletions
From: Nick Terrell
Move away from the compatibility wrapper to the zstd-1.4.6 API. This
code is more efficient because it uses the single-pass API instead of
the streaming API. The streaming API is not necessary because the whole
input and output buffers are available. This saves memory because
From: Nick Terrell
Move away from the compatibility wrapper to the zstd-1.4.6 API. This
code is functionally equivalent.
Signed-off-by: Nick Terrell
---
lib/decompress_unzstd.c | 40 ++--
1 file changed, 14 insertions(+), 26 deletions(-)
diff --git a/lib
From: Nick Terrell
Move away from the compatibility wrapper to the zstd-1.4.6 API. This
code is functionally equivalent.
Signed-off-by: Nick Terrell
---
fs/btrfs/zstd.c | 48
1 file changed, 28 insertions(+), 20 deletions(-)
diff --git a/fs
From: Nick Terrell
This patchset upgrades the zstd library to the latest upstream release. The
current zstd version in the kernel is a modified version of upstream zstd-1.3.1.
At the time it was integrated, zstd wasn't ready to be used in the kernel as-is.
But, it is now possible to use upstream
From: Nick Terrell
Adds zstd_compat.h which provides the necessary functions from the
current zstd.h API. It is only active for zstd versions 1.4.6 and newer.
That means it is disabled currently, but will become active when a later
patch in this series updates the zstd library in the kernel
From: Nick Terrell
Adds decompress_sources.h which includes every .c file necessary for
zstd decompression. This is used in decompress_unzstd.c so the internal
structure of the library isn't exposed.
This allows us to upgrade the zstd library version without modifying any
callers. Instead we
> On Sep 17, 2020, at 6:47 PM, Chao Yu wrote:
>
> On 2020/9/18 3:34, Nick Terrell wrote:
>>> On Sep 17, 2020, at 11:00 AM, Nick Terrell wrote:
>>>
>>>
>>>
>>>> On Sep 16, 2020, at 11:31 PM, Chao Yu wrote:
>>>>
>>
> On Sep 17, 2020, at 11:00 AM, Nick Terrell wrote:
>
>
>
>> On Sep 16, 2020, at 11:31 PM, Chao Yu wrote:
>>
>> Hi Nick,
>>
>> On 2020/9/17 2:39, Nick Terrell wrote:
>>>> On Sep 15, 2020, at 11:31 PM, Chao Yu wrote:
>>
> On Sep 16, 2020, at 11:31 PM, Chao Yu wrote:
>
> Hi Nick,
>
> On 2020/9/17 2:39, Nick Terrell wrote:
>>> On Sep 15, 2020, at 11:31 PM, Chao Yu wrote:
>>>
>>> Hi Nick,
>>>
>>> remove not related mailing list.
>>>
> On Sep 17, 2020, at 7:28 AM, Chris Mason wrote:
>
> On 17 Sep 2020, at 6:04, Christoph Hellwig wrote:
>
>> On Wed, Sep 16, 2020 at 09:35:51PM -0400, Rik van Riel wrote:
One possibility is to have a kernel wrapper on top of the zstd API to
make it
more ergonomic. I personally
> On Sep 16, 2020, at 1:48 AM, Christoph Hellwig wrote:
>
> On Tue, Sep 15, 2020 at 08:42:54PM -0700, Nick Terrell wrote:
>> From: Nick Terrell
>>
>> Adds zstd_compat.h which provides the necessary functions from the
>> current zstd.h API. It is only active
> On Sep 16, 2020, at 7:46 AM, Christoph Hellwig wrote:
>
> On Wed, Sep 16, 2020 at 10:43:04AM -0400, Chris Mason wrote:
>> Otherwise we just end up with drift and kernel-specific bugs that are harder
>> to debug. To the extent those APIs make us contort the kernel code, I???m
>> sure Nick is
> On Sep 15, 2020, at 8:42 PM, Nick Terrell wrote:
>
> From: Nick Terrell
>
> Upgrade to the latest upstream zstd version 1.4.6.
>
> This patch is 100% generated from upstream zstd commit c4763f087c2b [0].
>
> This patch is very large because it is transitioning fr
> On Sep 15, 2020, at 11:31 PM, Chao Yu wrote:
>
> Hi Nick,
>
> remove not related mailing list.
>
> On 2020/9/16 11:43, Nick Terrell wrote:
>> From: Nick Terrell
>> Move away from the compatibility wrapper to the zstd-1.4.6 API. This
>> code is mo
From: Nick Terrell
Move away from the compatibility wrapper to the zstd-1.4.6 API. This
code is functionally equivalent.
Signed-off-by: Nick Terrell
---
crypto/zstd.c | 24 +++-
1 file changed, 11 insertions(+), 13 deletions(-)
diff --git a/crypto/zstd.c b/crypto/zstd.c
From: Nick Terrell
Move away from the compatibility wrapper to the zstd-1.4.6 API. This
code is functionally equivalent.
Signed-off-by: Nick Terrell
---
fs/squashfs/zstd_wrapper.c | 9 -
1 file changed, 4 insertions(+), 5 deletions(-)
diff --git a/fs/squashfs/zstd_wrapper.c b/fs
From: Nick Terrell
All callers have been transitioned to the new zstd-1.4.6 API. There are
no more callers of the zstd compatibility wrapper, so delete it.
Signed-off-by: Nick Terrell
---
include/linux/zstd_compat.h | 112
1 file changed, 112 deletions
From: Nick Terrell
Move away from the compatibility wrapper to the zstd-1.4.6 API. This
code is functionally equivalent.
Signed-off-by: Nick Terrell
---
lib/decompress_unzstd.c | 40 ++--
1 file changed, 14 insertions(+), 26 deletions(-)
diff --git a/lib
From: Nick Terrell
Adds decompress_sources.h which includes every .c file necessary for
zstd decompression. This is used in decompress_unzstd.c so the internal
structure of the library isn't exposed.
This allows us to upgrade the zstd library version without modifying any
callers. Instead we
From: Nick Terrell
Move away from the compatibility wrapper to the zstd-1.4.6 API. This
code is more efficient because it uses the single-pass API instead of
the streaming API. The streaming API is not necessary because the whole
input and output buffers are available. This saves memory because
From: Nick Terrell
Move away from the compatibility wrapper to the zstd-1.4.6 API. This
code is functionally equivalent.
Signed-off-by: Nick Terrell
---
fs/btrfs/zstd.c | 48
1 file changed, 28 insertions(+), 20 deletions(-)
diff --git a/fs
From: Nick Terrell
Adds zstd_compat.h which provides the necessary functions from the
current zstd.h API. It is only active for zstd versions 1.4.6 and newer.
That means it is disabled currently, but will become active when a later
patch in this series updates the zstd library in the kernel
From: Nick Terrell
This patchset upgrades the zstd library to the latest upstream release. The
current zstd version in the kernel is a modified version of upstream zstd-1.3.1.
At the time it was integrated, zstd wasn't ready to be used in the kernel as-is.
But, it is now possible to use upstream
r than
> 8MB was disabled on 32-bit platforms.
>
> Signed-off-by: Petr Malat
Reviewed-by: Nick Terrell
Thanks for the fix! I looked upstream and this fix corresponds to this
upstream commit:
https://github.com/facebook/zstd/commit/8a5c0c98ae5a7884694589d7a69bc99011add94d
Thanks,
Nick Terre
it as big as possible without having the end address overflow.
> + */
> if (out_len == 0)
> - out_len = LONG_MAX; /* no limit */
> + out_len = UINTPTR_MAX - (uintptr_t)out_buf;
Great, that works for me. Thanks for fixing this!
Reviewed-by: Nick Terrell
> if (fill == NULL && flush == NULL)
> /*
> --
> 2.28.0
>
in this way. A better
solution might be to pass MAX_ADDRESS_PTR - OUTPUT_PTR as
the size to the __decompress() call. Or some other size that won’t
overflow the pointer.
Best,
Nick
> Signed-off-by: Paul Cercueil
> Reviewed-by: Nick Terrell
> ---
>
> Notes:
>v2: Change limit t
> On Aug 24, 2020, at 2:05 PM, Paul Cercueil wrote:
>
>
>
> Le lun. 24 août 2020 à 20:11, Nick Terrell a écrit :
>>> On Aug 21, 2020, at 9:29 AM, Paul Cercueil wrote:
>>> The zstd decompression code, as it is right now, will have internal
>>&
> On Aug 24, 2020, at 2:02 PM, Paul Cercueil wrote:
>
> Hi Nick,
>
> Le lun. 24 août 2020 à 19:51, Nick Terrell a écrit :
>>> On Aug 21, 2020, at 9:29 AM, Paul Cercueil wrote:
>>> Add support for self-extracting kernels with a ZSTD compression.
>&g
1 - 100 of 289 matches
Mail list logo
