Le 20/01/2021 à 14:28, Menglong Dong a écrit :
[snip]
>>> For that reason, make sysctl_wmem_max and sysctl_rmem_max
>>> per-namespace.
>>
>> I think having those values be restricted by init netns is a desirable
>> property.
>
> I just thought that having these values per-namespace can be more fle
t;
>> gcc --version
> gcc (SUSE Linux) 7.5.0
I tried with a (very old) gcc and I did not reproduce this error:
$ gcc --version
gcc (Debian 4.9.2-10+deb8u2) 4.9.2
>
> This patch:
>
> commit 9efd6a3cecdde984d67e63d17fe6af53c7c50968
> Author: Nicolas Dichtel
> Date: Wed
Le 28/08/2020 à 00:07, Lach a écrit :
> This dependency was added in 63dca2c0b0e7a92cb39d1b1ecefa32ffda201975,
> because this commit had dependency on
> ipv6_find_hdr, which was located in iptables-specific code
>
> But it is no longer required, because
> f8f626754ebeca613cf1af2e6f890cfde0e74d5b
Le 17/09/2019 à 17:53, George G. Davis a écrit :
[snip]
> Ping, "Linux 5.3" kernel has been released [1] and it appears that the
> 5.4 merge window is open. The patch [2] remains unchanged since my initial
> post. Please consider applying it.
net-next is closed:
http://vger.kernel.org/~davem/net-n
Le 26/07/2019 à 10:03, Jia-Ju Bai a écrit :
> In vti6_link_config(), there is an if statement on line 649 to check
> whether rt is NULL:
> if (rt)
>
> When rt is NULL, it is used on line 651:
> ip6_rt_put(rt);
> dst_release(&rt->dst);
>
> Thus, a possible null-pointer dereference
Le 26/07/2019 à 04:25, Jia-Ju Bai a écrit :
> In inet_csk_rebuild_route(), rt is assigned to NULL on line 1071.
> On line 1076, rt is used:
> return &rt->dst;
> Thus, a possible null-pointer dereference may occur.>
> To fix this bug, rt is checked before being used.
>
> This bug is found by a
Le 11/04/2019 à 10:52, Rolf Eike Beer a écrit :
> Am Donnerstag, 11. April 2019, 10:39:40 CEST schrieb Nicolas Dichtel:
>> In case of cross-compilation, there may be two pkg-config tools, one for
>> the host and one for the target. Enable to override the default name.
>>
&
In case of cross-compilation, there may be two pkg-config tools, one for
the host and one for the target. Enable to override the default name.
Fixes: 056d28d135bc ("objtool: Query pkg-config for libelf location")
Signed-off-by: Nicolas Dichtel
---
Makefile | 3 ++-
too
tatic entries.
>
> Signed-off-by: Callum Sinclair
Except two minor comments (see below),
Acked-by: Nicolas Dichtel
[snip]
> +/* MRT6_FLUSH optional flags */
> +#define MRT6_FLUSH_MFC 1 /* Flush multicast entries */
> +#define MRT6_FLUSH_MFC_STATIC2 /*
Le 12/02/2019 à 04:12, Callum Sinclair a écrit :
[snip]
> /* Wipe the cache */
> - list_for_each_entry_safe(c, tmp, &mrt->mfc_cache_list, list) {
> - if (!all && (c->mfc_flags & MFC_STATIC))
> - continue;
> - rhltable_remove(&mrt->mfc_hash, &c->
Le 11/02/2019 à 04:54, Callum Sinclair a écrit :
> v1 -> v2:
> Implemented additional flags for static entries
> v2 -> v3:
> Cleaned up flag logic so any combination of routes can be cleared.
> Fixed style errors
> Fixed incorrect flag values
nit: those lines are usually put after the '---', thus t
Le 08/02/2019 à 15:43, Nikolay Aleksandrov a écrit :
> On 08/02/2019 16:18, Nicolas Dichtel wrote:
>> Le 08/02/2019 à 05:11, Callum Sinclair a écrit :
>>> Currently the only way to clear the mfc cache was to delete the entries
>> mfc stands for 'multicast forwarding ca
Le 08/02/2019 à 05:11, Callum Sinclair a écrit :
> Currently the only way to clear the mfc cache was to delete the entries
mfc stands for 'multicast forwarding cache', so 'mfc cache' is a bit strange.
> one by one using the MRT_DEL_MFC socket option or to destroy and
> recreate the socket.
Note th
nlmsg_multicast() consumes always the skb, thus the original skb must be
freed only when this function is called with a clone.
Fixes: cb9f7a9a5c96 ("netlink: ensure to loop over all netns in
genlmsg_multicast_allns()")
Reported-by: Ben Hutchings
Signed-off-by: Nicolas Dichtel
---
n
Le 13/03/2018 à 01:04, Ben Hutchings a écrit :
> On Fri, 2018-03-09 at 16:18 -0800, Greg Kroah-Hartman wrote:
>> 4.4-stable review patch. If anyone has any objections, please let me know.
>>
>> ------
>>
>> From: Nicolas Di
Le 26/01/2018 à 09:36, Jiri Benc a écrit :
> On Fri, 26 Jan 2018 00:34:51 +0100, Nicolas Dichtel wrote:
>> Why meaningful? The user knows that the answer is like if if was done in
>> another
>> netns. It enables to have only one netlink socket instead of one per netns.
>
Le 25/01/2018 à 23:30, Jiri Benc a écrit :
> On Thu, 25 Jan 2018 15:20:59 +0100, Nicolas Dichtel wrote:
>> Hmm, I don't agree. For me, it would be the correct answer. If user has a
>> socket
>> in ns_a and targets a RTM_GETLINK in ns_b, the answer he gets should be lik
Le 24/01/2018 à 17:35, Jiri Benc a écrit :
> On Wed, 24 Jan 2018 16:24:34 +0100, Nicolas Dichtel wrote:
>> I wonder if it would be possible to do something in the netlink framework,
>> like
>> NETLINK_LISTEN_ALL_NSID.
>> Having some ancillary data at the netlink socke
Hi,
Le 24/01/2018 à 15:26, Christian Brauner a écrit :
> Hi,
>
> Based on the previous discussion this enables passing a IFLA_IF_NETNSID
> property along with RTM_SETLINK and RTM_DELLINK requests. The patch for
> RTM_NEWLINK will be sent out in a separate patch since there are more
> corner-cases
Le 23/01/2018 à 18:08, Jiri Benc a écrit :
> On Tue, 23 Jan 2018 17:37:11 +0100, Nicolas Dichtel wrote:
>> When a virtual interface moves to another netns, the netlink RTM_DELLINK
>> message
>> contains the attribute IFLA_NEW_NETNSID, which identifies where the interface
>
Le 23/01/2018 à 11:26, Wolfgang Bumiller a écrit :
> On Tue, Jan 23, 2018 at 10:30:09AM +0100, Jiri Benc wrote:
>> On Mon, 22 Jan 2018 23:25:41 +0100, Christian Brauner wrote:
>>> This is not necessarily true in scenarios where I move a network device
>>> via RTM_NEWLINK + IFLA_NET_NS_PID into a ne
Le 22/01/2018 à 23:06, Jiri Benc a écrit :
[snip]
> Btw, we have one missing piece here: when an interface is moved to a
> name space that does not have netnsid attached, we want to find out
> where the interface was moved to. But there's currently no reliable way
> to do it. For veth, the other en
to revert that is the
>> commit ID you referenced.
>
> I think there was a misunderstanding. I asked you to queue the
> commit with that ID to stable on Dec 23 (this commit ID is the
> revert of the buggy patch). This commit was included to stable
> on Jan 4 then:
>
> https://www.
Le 13/06/2017 à 19:08, Julien Gomes a écrit :
> Add Netlink notifications on cache reports in ipmr, in addition to the
> existing igmpmsg sent to mroute_sk.
> Send RTM_NEWCACHEREPORT notifications to RTNLGRP_IPV4_MROUTE.
>
> MSGTYPE, VIF_ID, SRC_ADDR and DST_ADDR Netlink attributes contain the
> s
ng of all those mechanisms.
After the fix of the typo in the commitlog:
Acked-by: Nicolas Dichtel
> Fixes: 61562f981e92 ("uapi: export all arch specifics directories")
> Reported-by: Dan Williams
> Signed-off-by: Masahiro Yamada
Thank you for the patch.
Acked-by: Nicolas Dichtel
Le 08/05/2017 à 01:17, Masahiro Yamada a écrit :
Hi Masahiro,
[snip]
> I will send pull-requests for v4.12 in a few days.
>
> I need to fix a complex conflict reported by
> https://lkml.org/lkml/2017/4/10/1208
>
> I rebased linux-kbuild/uapi on commit 13e0988140
> (dropping 08/12 "cryptouser.h:
Signed-off-by: Nicolas Dichtel
---
arch/cris/include/arch-v10/arch/Kbuild | 1 -
arch/cris/include/arch-v32/arch/Kbuild | 1 -
arch/tile/include/arch/Kbuild | 1 -
3 files changed, 3 deletions(-)
delete mode 100644 arch/cris/include/arch-v10/arch/Kbuild
delete mode 100644 arch/cris
This header file is exported, but from a userland pov, it's just a wrapper
to asm-generic/setup.h.
Signed-off-by: Nicolas Dichtel
Reviewed-by: Tobias Klauser
---
arch/nios2/include/uapi/asm/Kbuild | 1 +
1 file changed, 1 insertion(+)
diff --git a/arch/nios2/include/uapi/asm/Kbuild
b
This patch prepares the uapi export by fixing the following error:
.../linux/smc_diag.h:6:27: fatal error: rdma/ib_verbs.h: No such file or
directory
#include
Signed-off-by: Nicolas Dichtel
---
include/rdma/ib_verbs.h | 3 +--
include/uapi/linux/smc_diag.h | 2 +-
include/uapi
ip to get all
subdirs with a pure makefile command.
For the record, note that exported files for asm directories are a mix of
files listed by:
- include/uapi/asm-generic/Kbuild.asm;
- arch//include/uapi/asm/Kbuild;
- arch//include/asm/Kbuild.
Signed-off-by: Nicolas Dichtel
Acked-by: Daniel V
ies of the specified arch.
Note that only cris and tile have more directories than only asm:
- arch-v[10|32] for cris;
- arch for tile.
Signed-off-by: Nicolas Dichtel
---
Documentation/kbuild/makefiles.txt | 15 +--
Makefile | 6 +++---
arch/cris/includ
/bnxt_re-abi.h:45: found __[us]{8,16,32,64} type without
#include
Signed-off-by: Nicolas Dichtel
---
include/uapi/linux/bcache.h | 2 +-
include/uapi/linux/btrfs_tree.h | 2 ++
include/uapi/linux/cryptouser.h | 2 ++
include/uapi/linux/pr.h | 2 ++
include/uapi/linux/qrtr.h | 1
ared here (not in
a function)
__u8 uuid[BTRFS_UUID_SIZE];
^
.../linux/btrfs_tree.h:796:16: error: ‘BTRFS_DEV_STAT_VALUES_MAX’ undeclared
here (not in a function)
__le64 values[BTRFS_DEV_STAT_VALUES_MAX];
Signed-off-by: Nicolas Dichtel
---
include/uapi/linux/btrfs_tree.h | 1
After the last three patches, all exported headers are under uapi/, thus
input-files2 are not needed anymore.
The side effect is that input-files1-name is exactly header-y.
Note also that input-files3-name is genhdr-y.
Signed-off-by: Nicolas Dichtel
---
scripts/Makefile.headersinst | 38
This option was added in commit c7bb349e7c25 ("kbuild: introduce destination-y
for exported headers") but never used in-tree.
Signed-off-by: Nicolas Dichtel
Acked-by: Paul Bolle
---
Documentation/kbuild/makefiles.txt | 23 ---
scripts/Makefile.headersinst
Even if this file was not in an uapi directory, it was exported because
it was listed in the Kbuild file.
Fixes: b72e7464e4cf ("x86/uapi: Do not export as part of the
user API headers")
Suggested-by: Borislav Petkov
CC: Ingo Molnar
Signed-off-by: Nicolas Dichtel
Acked-by: Ingo Mol
Patches #1 and #2 are just cleanup: some exported headers were still under
a non-uapi directory. Patch #3 is a fix to avoid exporting a file that was
not under an uapi directory.
After these three patches, all exported headers are under an uapi directory:
path #4 stops searching files in non uapi
This header file is exported, thus move it to uapi.
Signed-off-by: Nicolas Dichtel
---
arch/h8300/include/asm/bitsperlong.h | 14 --
arch/h8300/include/uapi/asm/bitsperlong.h | 14 ++
2 files changed, 14 insertions(+), 14 deletions(-)
delete mode 100644 arch/h8300
This patch prepares the uapi export by fixing the following error:
.../linux/cryptouser.h:58:16: error: ‘CRYPTO_MAX_ALG_NAME’ undeclared here (not
in a function)
char cru_name[CRYPTO_MAX_ALG_NAME];
Signed-off-by: Nicolas Dichtel
Acked-by: Herbert Xu
---
include/linux/crypto.h | 2
Hi Masahiro,
Le 27/03/2017 à 07:27, Masahiro Yamada a écrit :
> Hi Nicolas,
>
>
> 2017-03-14 21:54 GMT+09:00 Nicolas Dichtel :
>> diff --git a/arch/cris/include/uapi/asm/Kbuild
>> b/arch/cris/include/uapi/asm/Kbuild
>> index d0c5471856e0..b15bf6bc0e94 100644
>&
Le 27/03/2017 à 07:31, Masahiro Yamada a écrit :
[snip]
>> -#endif /* __ASM_H8300_BITS_PER_LONG */
>> diff --git a/arch/h8300/include/uapi/asm/bitsperlong.h
>> b/arch/h8300/include/uapi/asm/bitsperlong.h
>> new file mode 100644
>> index ..e56cf72369b6
>> --- /dev/null
>> +++ b/arch/h83
Hi Masahiro,
Le 27/03/2017 à 07:26, Masahiro Yamada a écrit :
> Hi Nocolas,
>
>
> 2017-03-24 18:03 GMT+09:00 Nicolas Dichtel :
[snip]
>
>
> As a whole, this series is amazing. Thanks for your great work!
Thank you. And thank you for taking time to review it.
>
&g
Hi Masahiro,
Le 27/03/2017 à 07:53, Masahiro Yamada a écrit :
> Hi Nicolas,
>
>
> 2017-03-14 21:54 GMT+09:00 Nicolas Dichtel :
[snip]
>> diff --git a/include/uapi/linux/btrfs_tree.h
>> b/include/uapi/linux/btrfs_tree.h
>> index 6a261cb52d95..6a754ada59af 1006
Le 24/03/2017 à 09:42, Masahiro Yamada a écrit :
> Hi Nicolas,
>
>
> 2017-03-24 17:32 GMT+09:00 Nicolas Dichtel :
>> Le 14/03/2017 à 13:54, Nicolas Dichtel a écrit :
>>> Patches #1 and #2 are just cleanup: some exported headers were still under
>>> a non-
Le 14/03/2017 à 13:54, Nicolas Dichtel a écrit :
> Patches #1 and #2 are just cleanup: some exported headers were still under
> a non-uapi directory. Patch #3 is a fix to avoid exporting a file that was
> not under an uapi directory.
> After these three patches, all exported headers
ip to get all
subdirs with a pure makefile command.
For the record, note that exported files for asm directories are a mix of
files listed by:
- include/uapi/asm-generic/Kbuild.asm;
- arch//include/uapi/asm/Kbuild;
- arch//include/asm/Kbuild.
Signed-off-by: Nicolas Dichtel
Acked-by: Daniel V
Even if this file was not in an uapi directory, it was exported because
it was listed in the Kbuild file.
Fixes: b72e7464e4cf ("x86/uapi: Do not export as part of the
user API headers")
Suggested-by: Borislav Petkov
CC: Ingo Molnar
Signed-off-by: Nicolas Dichtel
Acked-by: Ingo Mol
This option was added in commit c7bb349e7c25 ("kbuild: introduce destination-y
for exported headers") but never used in-tree.
Signed-off-by: Nicolas Dichtel
Acked-by: Paul Bolle
---
Documentation/kbuild/makefiles.txt | 23 ---
scripts/Makefile.headersinst
This patch prepares the uapi export by fixing the following error:
.../linux/smc_diag.h:6:27: fatal error: rdma/ib_verbs.h: No such file or
directory
#include
Signed-off-by: Nicolas Dichtel
---
include/rdma/ib_verbs.h | 3 +--
include/uapi/linux/smc_diag.h | 2 +-
include/uapi
ared here (not in
a function)
__u8 uuid[BTRFS_UUID_SIZE];
^
.../linux/btrfs_tree.h:796:16: error: ‘BTRFS_DEV_STAT_VALUES_MAX’ undeclared
here (not in a function)
__le64 values[BTRFS_DEV_STAT_VALUES_MAX];
Signed-off-by: Nicolas Dichtel
---
include/uapi/linux/btrfs_tree.h | 1
/bnxt_re-abi.h:45: found __[us]{8,16,32,64} type without
#include
Signed-off-by: Nicolas Dichtel
---
include/uapi/linux/bcache.h | 2 +-
include/uapi/linux/btrfs_tree.h | 2 ++
include/uapi/linux/cryptouser.h | 2 ++
include/uapi/linux/pr.h | 2 ++
include/uapi/linux/qrtr.h | 1
This header file is exported, but from a userland pov, it's just a wrapper
to asm-generic/setup.h.
Signed-off-by: Nicolas Dichtel
Reviewed-by: Tobias Klauser
---
arch/nios2/include/uapi/asm/Kbuild | 1 +
1 file changed, 1 insertion(+)
diff --git a/arch/nios2/include/uapi/asm/Kbuild
b
This patch prepares the uapi export by fixing the following error:
.../linux/cryptouser.h:58:16: error: ‘CRYPTO_MAX_ALG_NAME’ undeclared here (not
in a function)
char cru_name[CRYPTO_MAX_ALG_NAME];
Signed-off-by: Nicolas Dichtel
Acked-by: Herbert Xu
---
include/linux/crypto.h | 2
This header file is exported, thus move it to uapi.
Signed-off-by: Nicolas Dichtel
---
arch/h8300/include/asm/bitsperlong.h | 14 --
arch/h8300/include/uapi/asm/bitsperlong.h | 14 ++
2 files changed, 14 insertions(+), 14 deletions(-)
delete mode 100644 arch/h8300
ies of the specified arch.
Note that only cris and tile have more directories than only asm:
- arch-v[10|32] for cris;
- arch for tile.
Signed-off-by: Nicolas Dichtel
---
Documentation/kbuild/makefiles.txt | 15 +--
Makefile | 6 +++---
arch/cris/includ
After the last three patches, all exported headers are under uapi/, thus
input-files2 are not needed anymore.
The side effect is that input-files1-name is exactly header-y.
Note also that input-files3-name is genhdr-y.
Signed-off-by: Nicolas Dichtel
---
scripts/Makefile.headersinst | 38
Patches #1 and #2 are just cleanup: some exported headers were still under
a non-uapi directory. Patch #3 is a fix to avoid exporting a file that was
not under an uapi directory.
After these three patches, all exported headers are under an uapi directory:
path #4 stops searching files in non uapi
Le 14/03/2017 à 06:38, Masahiro Yamada a écrit :
> Ni Nicolas,
>
>
> 2017-03-14 1:57 GMT+09:00 Nicolas Dichtel :
>>> BTW, this series does not apply cleanly.
>>>
>>> If you could rebase it onto v4.11-rc1 tag,
>>> it would be helpful.
>> You
Le 11/03/2017 à 06:43, Masahiro Yamada a écrit :
[snip]
>
> I will take care of this.
Thank you.
>
>
>
>> kbuild tree has not been updated since two months (4.10-rc1) :/
>
> Michal's tree is not active these days.
Ok, I didn't know that.
> Going forward, I will queue up Kbuild patches in my
Le 02/03/2017 à 17:56, Nicolas Dichtel a écrit :
> Patches #1 and #2 are just cleanup: some exported headers were still under
> a non-uapi directory. Patch #3 is a fix to avoid exporting a file that was
> not under an uapi directory.
> After these three patches, all exported headers
Le 02/03/2017 à 17:56, Nicolas Dichtel a écrit :
> Patches #1 and #2 are just cleanup: some exported headers were still under
> a non-uapi directory. Patch #3 is a fix to avoid exporting a file that was
> not under an uapi directory.
> After these three patches, all exported headers
pure makefile command.
For the record, note that exported files for asm directories are a mix of
files listed by:
- include/uapi/asm-generic/Kbuild.asm;
- arch//include/uapi/asm/Kbuild;
- arch//include/asm/Kbuild.
Signed-off-by: Nicolas Dichtel
Acked-by: Daniel Vetter
Acked-by: Russell King
Ack
Even if this file was not in an uapi directory, it was exported because
it was listed in the Kbuild file.
Fixes: b72e7464e4cf ("x86/uapi: Do not export as part of the
user API headers")
Suggested-by: Borislav Petkov
CC: Ingo Molnar
Signed-off-by: Nicolas Dichtel
Acked-by: Ingo Mol
This patch prepares the uapi export by fixing the following error:
.../linux/smc_diag.h:6:27: fatal error: rdma/ib_verbs.h: No such file or
directory
#include
Signed-off-by: Nicolas Dichtel
---
include/rdma/ib_verbs.h | 3 +--
include/uapi/linux/smc_diag.h | 2 +-
include/uapi
This patch prepares the uapi export by fixing the following error:
.../linux/cryptouser.h:58:16: error: ‘CRYPTO_MAX_ALG_NAME’ undeclared here (not
in a function)
char cru_name[CRYPTO_MAX_ALG_NAME];
Signed-off-by: Nicolas Dichtel
---
include/linux/crypto.h | 2 +-
include/uapi
This header file is exported, but from a userland pov, it's just a wrapper
to asm-generic/setup.h.
Signed-off-by: Nicolas Dichtel
Reviewed-by: Tobias Klauser
---
arch/nios2/include/uapi/asm/Kbuild | 1 +
1 file changed, 1 insertion(+)
diff --git a/arch/nios2/include/uapi/asm/Kbuild
b
ared here (not in
a function)
__u8 uuid[BTRFS_UUID_SIZE];
^
.../linux/btrfs_tree.h:796:16: error: ‘BTRFS_DEV_STAT_VALUES_MAX’ undeclared
here (not in a function)
__le64 values[BTRFS_DEV_STAT_VALUES_MAX];
Signed-off-by: Nicolas Dichtel
---
include/uapi/linux/btrfs_tree.h | 1
This header file is exported, thus move it to uapi.
Signed-off-by: Nicolas Dichtel
---
arch/h8300/include/asm/bitsperlong.h | 14 --
arch/h8300/include/uapi/asm/bitsperlong.h | 14 ++
2 files changed, 14 insertions(+), 14 deletions(-)
delete mode 100644 arch/h8300
Patches #1 and #2 are just cleanup: some exported headers were still under
a non-uapi directory. Patch #3 is a fix to avoid exporting a file that was
not under an uapi directory.
After these three patches, all exported headers are under an uapi directory:
path #4 stops searching files in non uapi
After the last four patches, all exported headers are under uapi/, thus
input-files2 are not needed anymore.
The side effect is that input-files1-name is exactly header-y.
Note also that input-files3-name is genhdr-y.
Signed-off-by: Nicolas Dichtel
---
scripts/Makefile.headersinst | 34
ies of the specified arch.
Note that only cris and tile have more directories than only asm:
- arch-v[10|32] for cris;
- arch for tile.
Signed-off-by: Nicolas Dichtel
---
Documentation/kbuild/makefiles.txt | 15 +--
Makefile | 6 +++---
arch/cris/includ
This option was added in commit c7bb349e7c25 ("kbuild: introduce destination-y
for exported headers") but never used in-tree.
Signed-off-by: Nicolas Dichtel
Acked-by: Paul Bolle
---
Documentation/kbuild/makefiles.txt | 23 ---
scripts/Makefile.headersinst
/bnxt_re-abi.h:45: found __[us]{8,16,32,64} type without
#include
Signed-off-by: Nicolas Dichtel
---
include/uapi/linux/bcache.h | 2 +-
include/uapi/linux/btrfs_tree.h | 2 ++
include/uapi/linux/cryptouser.h | 2 ++
include/uapi/linux/pr.h | 2 ++
include/uapi/linux/qrtr.h | 1
/bnxt_re-abi.h:45: found __[us]{8,16,32,64} type without
#include
Signed-off-by: Nicolas Dichtel
---
include/uapi/linux/bcache.h | 2 +-
include/uapi/linux/btrfs_tree.h | 2 ++
include/uapi/linux/cryptouser.h | 2 ++
include/uapi/linux/pr.h | 2 ++
include/uapi/linux/qrtr.h | 1
This patch prepares the uapi export by fixing the following error:
.../linux/cryptouser.h:58:16: error: ‘CRYPTO_MAX_ALG_NAME’ undeclared here (not
in a function)
char cru_name[CRYPTO_MAX_ALG_NAME];
Signed-off-by: Nicolas Dichtel
---
include/linux/crypto.h | 2 +-
include/uapi/linux
After the last four patches, all exported headers are under uapi/, thus
input-files2 are not needed anymore.
The side effect is that input-files1-name is exactly header-y.
Note also that input-files3-name is genhdr-y.
Signed-off-by: Nicolas Dichtel
---
scripts/Makefile.headersinst | 34
This header file is exported, thus move it to uapi.
Signed-off-by: Nicolas Dichtel
---
arch/h8300/include/asm/bitsperlong.h | 14 --
arch/h8300/include/uapi/asm/bitsperlong.h | 14 ++
2 files changed, 14 insertions(+), 14 deletions(-)
delete mode 100644 arch/h8300
This patch prepares the uapi export by fixing the following error:
.../linux/smc_diag.h:6:27: fatal error: rdma/ib_verbs.h: No such file or
directory
#include
Signed-off-by: Nicolas Dichtel
---
include/rdma/ib_verbs.h | 3 +--
include/uapi/linux/smc_diag.h | 2 +-
include/uapi
ies of the specified arch.
Note that only cris and tile have more directories than only asm:
- arch-v[10|32] for cris;
- arch for tile.
Signed-off-by: Nicolas Dichtel
---
Documentation/kbuild/makefiles.txt | 15 +--
Makefile | 6 +++---
arch/cris/includ
ared here (not in
a function)
__u8 uuid[BTRFS_UUID_SIZE];
^
.../linux/btrfs_tree.h:796:16: error: ‘BTRFS_DEV_STAT_VALUES_MAX’ undeclared
here (not in a function)
__le64 values[BTRFS_DEV_STAT_VALUES_MAX];
Signed-off-by: Nicolas Dichtel
---
include/uapi/linux/btrfs_tree.h | 1
This option was added in commit c7bb349e7c25 ("kbuild: introduce destination-y
for exported headers") but never used in-tree.
Signed-off-by: Nicolas Dichtel
Acked-by: Paul Bolle
---
Documentation/kbuild/makefiles.txt | 23 ---
scripts/Makefile.headersinst
Patches #1 and #2 are just cleanup: some exported headers were still under
a non-uapi directory. Patch #3 is a fix to avoid exporting a file that was
not under an uapi directory.
After these three patches, all exported headers are under an uapi directory:
path #4 stops searching files in non uapi
Even if this file was not in an uapi directory, it was exported because
it was listed in the Kbuild file.
Fixes: b72e7464e4cf ("x86/uapi: Do not export as part of the
user API headers")
Suggested-by: Borislav Petkov
CC: Ingo Molnar
Signed-off-by: Nicolas Dichtel
Acked-by: Ingo Mol
This header file is exported, but from a userland pov, it's just a wrapper
to asm-generic/setup.h.
Signed-off-by: Nicolas Dichtel
Reviewed-by: Tobias Klauser
---
arch/nios2/include/uapi/asm/Kbuild | 1 +
1 file changed, 1 insertion(+)
diff --git a/arch/nios2/include/uapi/asm/Kbuild
b
pure makefile command.
For the record, note that exported files for asm directories are a mix of
files listed by:
- include/uapi/asm-generic/Kbuild.asm;
- arch//include/uapi/asm/Kbuild;
- arch//include/asm/Kbuild.
Signed-off-by: Nicolas Dichtel
Acked-by: Daniel Vetter
Acked-by: Russell King
Ack
Le 28/02/2017 à 03:48, Dmitry V. Levin a écrit :
> On Mon, Feb 27, 2017 at 05:01:55PM +0100, Nicolas Dichtel wrote:
[snip]
>> Is there any chance to get this series in before the rc1?
>
> Note that the following newly exported headers have userspace compilation
> errors:
>
Le 24/02/2017 à 17:49, Nicolas Dichtel a écrit :
> Regularly, when a new header is created in include/uapi/, the developer
> forgets to add it in the corresponding Kbuild file. This error is usually
> detected after the release is out.
>
> In fact, all headers under uapi direct
This option was added in commit c7bb349e7c25 ("kbuild: introduce destination-y
for exported headers") but never used in-tree.
Signed-off-by: Nicolas Dichtel
Acked-by: Paul Bolle
---
Documentation/kbuild/makefiles.txt | 23 ---
scripts/Makefile.headersinst
Even if this file was not in an uapi directory, it was exported because
it was listed in the Kbuild file.
Fixes: b72e7464e4cf ("x86/uapi: Do not export as part of the
user API headers")
Suggested-by: Borislav Petkov
CC: Ingo Molnar
Signed-off-by: Nicolas Dichtel
Acked-by: Ingo Mol
This header file is exported, but from a userland pov, it's just a wrapper
to asm-generic/setup.h.
Signed-off-by: Nicolas Dichtel
Reviewed-by: Tobias Klauser
---
arch/nios2/include/uapi/asm/Kbuild | 1 +
1 file changed, 1 insertion(+)
diff --git a/arch/nios2/include/uapi/asm/Kbuild
b
pure makefile command.
For the record, note that exported files for asm directories are a mix of
files listed by:
- include/uapi/asm-generic/Kbuild.asm;
- arch//include/uapi/asm/Kbuild;
- arch//include/asm/Kbuild.
Signed-off-by: Nicolas Dichtel
Acked-by: Daniel Vetter
Acked-by: Russell King
Ack
Here is the v7 of this series.
Patches #1 and #2 are just cleanup: some exported headers were still under
a non-uapi directory. Patch #3 is a fix to avoid exporting a file that was
not under an uapi directory.
After these three patches, all exported headers are under an uapi directory:
path #4 st
This header file is exported, thus move it to uapi.
Signed-off-by: Nicolas Dichtel
---
arch/h8300/include/asm/bitsperlong.h | 14 --
arch/h8300/include/uapi/asm/bitsperlong.h | 14 ++
2 files changed, 14 insertions(+), 14 deletions(-)
delete mode 100644 arch/h8300
/bnxt_re-abi.h:45: found __[us]{8,16,32,64} type without
#include
Signed-off-by: Nicolas Dichtel
---
include/uapi/linux/bcache.h | 2 +-
include/uapi/linux/btrfs_tree.h | 2 ++
include/uapi/linux/cryptouser.h | 2 ++
include/uapi/linux/pr.h | 2 ++
include/uapi/linux/qrtr.h | 1
After the last four patches, all exported headers are under uapi/, thus
input-files2 are not needed anymore.
The side effect is that input-files1-name is exactly header-y.
Note also that input-files3-name is genhdr-y.
Signed-off-by: Nicolas Dichtel
---
scripts/Makefile.headersinst | 34
ies of the specified arch.
Note that only cris and tile have more directories than only asm:
- arch-v[10|32] for cris;
- arch for tile.
Signed-off-by: Nicolas Dichtel
---
Documentation/kbuild/makefiles.txt | 15 +--
Makefile | 6 +++---
arch/cris/includ
Le 20/02/2017 à 11:14, Arnd Bergmann a écrit :
> On Mon, Feb 20, 2017 at 10:32 AM, Nicolas Dichtel
> wrote:
>> Le 13/02/2017 à 08:49, Christoph Hellwig a écrit :
>>>> linux/genwqe/..install.cmd
>>>> linux/genwqe/.install
>>>
>>> Third time:
Le 13/02/2017 à 08:49, Christoph Hellwig a écrit :
>> linux/genwqe/..install.cmd
>> linux/genwqe/.install
>
> Third time: NAK on exporting internal kbuild metadata.
>
And for the third time: this is not related to this series. Those files are
there before my series and the goal of the series has
Even if this file was not in an uapi directory, it was exported because
it was listed in the Kbuild file.
Fixes: b72e7464e4cf ("x86/uapi: Do not export as part of the
user API headers")
Suggested-by: Borislav Petkov
CC: Ingo Molnar
Signed-off-by: Nicolas Dichtel
Acked-by: I
1 - 100 of 315 matches
Mail list logo