Re: [PATCH 1/3] dt-bindings: mmc: iproc-sdhci: Convert to json-schema

2021-04-12 Thread nicolas saenz julienne
On Mon, 2021-04-12 at 09:52 +0200, Ulf Hansson wrote: > On Tue, 6 Apr 2021 at 12:48, Nicolas Saenz Julienne wrote: > > > > Convert the brcm,iproc-sdhci binding to DT schema format using json-schema > > > > Signed-off-by: Nicolas Saenz Julienne > > Applied

[PATCH] mailmap: Update email address for Nicolas Saenz

2021-04-09 Thread Nicolas Saenz Julienne
Add my kernel.org address for old email address. Signed-off-by: Nicolas Saenz Julienne --- .mailmap | 2 ++ 1 file changed, 2 insertions(+) diff --git a/.mailmap b/.mailmap index 78835e80214a..b407e1192fb3 100644 --- a/.mailmap +++ b/.mailmap @@ -260,6 +260,8 @@ Nguyen Anh Quynh Nicolas

Re: [PATCH 4/4] ARM: dts: Fix-up EMMC2 controller's frequency

2021-04-09 Thread Nicolas Saenz Julienne
Hi again, On Wed, 2021-04-07 at 16:37 -0400, Alan Cooper wrote: > Nicolas, > > I got a better description of the failure and it looks like the bus > clock needs to be limited to 300KHz for a 500MHz core clock. > What's happening is that an internal reset sequence is needed after a > command

[PATCH] MAINTAINERS: Update BCM2711/BCM2335 maintainer's mail

2021-04-09 Thread Nicolas Saenz Julienne
The @kernel.org e-mail address is likely to last longer than the current one, so use it. Signed-off-by: Nicolas Saenz Julienne --- MAINTAINERS | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/MAINTAINERS b/MAINTAINERS index d269763af39d..c8f32b7c1e06 100644 --- a/MAINTAINERS

Re: [PATCH 4/4] ARM: dts: Fix-up EMMC2 controller's frequency

2021-04-09 Thread Nicolas Saenz Julienne
Hi Al, On Wed, 2021-04-07 at 16:37 -0400, Alan Cooper wrote: > Nicolas, > > I got a better description of the failure and it looks like the bus > clock needs to be limited to 300KHz for a 500MHz core clock. > What's happening is that an internal reset sequence is needed after a > command timeout

[PATCH] pwm: raspberrypi-poe: Fix mailbox message initialization

2021-04-09 Thread Nicolas Saenz Julienne
Signed-off-by: Nicolas Saenz Julienne --- @arndb: This was just meged into the arm-soc tree some days ago. Should I prepare a second PR once it's been reviewed? drivers/pwm/pwm-raspberrypi-poe.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/pwm/pwm-raspberrypi-poe.c

Re: [PATCH 2/3] mmc: sdhci-iproc: Cap min clock frequency on BCM2711

2021-04-07 Thread Nicolas Saenz Julienne
On Tue, 2021-04-06 at 19:59 +0200, Stefan Wahren wrote: > Hi Nicolas, > > Am 06.04.21 um 12:48 schrieb Nicolas Saenz Julienne: > > There is a known bug on BCM2711's SDHCI core integration where the > > controller will hang when the difference between the core clock and the

[PATCH 3/3] mmc: sdhci-iproc: Set SDHCI_QUIRK_CAP_CLOCK_BASE_BROKEN on BCM2711

2021-04-06 Thread Nicolas Saenz Julienne
The controller doesn't seem to pick-up on clock changes, so set the SDHCI_QUIRK_CAP_CLOCK_BASE_BROKEN flag to query the clock frequency directly from the clock. Fixes: f84e411c85be ("mmc: sdhci-iproc: Add support for emmc2 of the BCM2711") Signed-off-by: Nicolas Saenz Julienne --- d

[PATCH 2/3] mmc: sdhci-iproc: Cap min clock frequency on BCM2711

2021-04-06 Thread Nicolas Saenz Julienne
/#m11f2783a09b581da6b8a15f302625b43a6ecdeca Fixes: f84e411c85be ("mmc: sdhci-iproc: Add support for emmc2 of the BCM2711") Signed-off-by: Nicolas Saenz Julienne --- drivers/mmc/host/sdhci-iproc.c | 18 ++ 1 file changed, 18 insertions(+) diff --git a/drivers/mmc/host/sdhci-iproc.c b/drivers/mmc/host/sdhci-ipr

[PATCH 1/3] dt-bindings: mmc: iproc-sdhci: Convert to json-schema

2021-04-06 Thread Nicolas Saenz Julienne
Convert the brcm,iproc-sdhci binding to DT schema format using json-schema Signed-off-by: Nicolas Saenz Julienne --- .../bindings/mmc/brcm,iproc-sdhci.yaml| 63 +++ .../bindings/mmc/brcm,sdhci-iproc.txt | 37 --- 2 files changed, 63 insertions(+), 37

[PATCH 0/3] BCM2711 sdhci-iproc improvements

2021-04-06 Thread Nicolas Saenz Julienne
s an extra to this I also include a small fix, and convert the controller's bindings to yaml. Regards, Nicolas [1] https://lore.kernel.org/linux-mmc/20210322185816.27582-1-nsa...@kernel.org/ --- Nicolas Saenz Julienne (3): dt-bindings: mmc: iproc-sdhci: Convert to json-schema mmc: sdhci-ipro

Re: [PATCH] clk: Mark fwnodes when their clock provider is added

2021-04-05 Thread Nicolas Saenz Julienne
On Wed, 2021-03-31 at 12:25 -0700, Stephen Boyd wrote: > Quoting Geert Uytterhoeven (2021-03-31 00:05:00) > > On Wed, Mar 31, 2021 at 4:22 AM Stephen Boyd wrote: > > > > > Does it have any use? > > > > > > > > of_clk_del_provider() removes the first provider found with node == > > > > NULL. > >

Re: [PATCH 4/4] ARM: dts: Fix-up EMMC2 controller's frequency

2021-04-05 Thread Nicolas Saenz Julienne
Hi Alan, On Thu, 2021-04-01 at 11:23 -0400, Alan Cooper wrote: > Nicolas, > > Sorry, I just noticed this thread. > This is a known bug in some newer Arasan cores. > The problem happens when the difference between the core clock and the bus > clock is too great. > Limiting the clock to 200KHz

Re: [PATCH 4/4] ARM: dts: Fix-up EMMC2 controller's frequency

2021-03-26 Thread Nicolas Saenz Julienne
On Thu, 2021-03-25 at 20:11 +0100, Stefan Wahren wrote: > Am 24.03.21 um 16:34 schrieb Nicolas Saenz Julienne: > > Hi Stefan, > > > > On Wed, 2021-03-24 at 16:16 +0100, Stefan Wahren wrote: > > > Hi Nicolas, > > > > > > Am 22.03.21 um 19:58 schri

[PATCH] clk: bcm: rpi: Don't register as OF provider if !dev->np

2021-03-25 Thread Nicolas Saenz Julienne
Signed-off-by: Nicolas Saenz Julienne --- drivers/clk/bcm/clk-raspberrypi.c | 10 ++ 1 file changed, 6 insertions(+), 4 deletions(-) diff --git a/drivers/clk/bcm/clk-raspberrypi.c b/drivers/clk/bcm/clk-raspberrypi.c index f89b9cfc4309..27e85687326f 100644 --- a/drivers/clk/bcm/clk-raspberry

Re: [PATCH] clk: Mark fwnodes when their clock provider is added

2021-03-25 Thread Nicolas Saenz Julienne
On Thu, 2021-03-25 at 14:31 +0100, Marek Szyprowski wrote: > Hi > > On 10.02.2021 12:44, Tudor Ambarus wrote: > > This is a follow-up for: > > commit 3c9ea42802a1 ("clk: Mark fwnodes when their clock provider is > > added/removed") > > > > The above commit updated the deprecated

Re: [PATCH 1/4] dt-bindings: mmc: iproc-sdhci: Convert to json-schema

2021-03-24 Thread Nicolas Saenz Julienne
On Wed, 2021-03-24 at 09:27 -0700, Scott Branden wrote: > On 2021-03-23 2:24 p.m., Nicolas Saenz Julienne wrote: > > On Tue, 2021-03-23 at 15:08 -0600, Rob Herring wrote: > > > On Mon, Mar 22, 2021 at 12:11:29PM -0700, Scott Branden wrote: > > > > On 2021-03-22 11:5

Re: [PATCH 4/4] ARM: dts: Fix-up EMMC2 controller's frequency

2021-03-24 Thread Nicolas Saenz Julienne
Hi Stefan, On Wed, 2021-03-24 at 16:16 +0100, Stefan Wahren wrote: > Hi Nicolas, > > Am 22.03.21 um 19:58 schrieb Nicolas Saenz Julienne: > > From: Nicolas Saenz Julienne > > > > Force emmc2's frequency to 150MHz as the default 100MHz (set by FW) > > seems to

Re: [PATCH 1/4] dt-bindings: mmc: iproc-sdhci: Convert to json-schema

2021-03-23 Thread Nicolas Saenz Julienne
On Tue, 2021-03-23 at 15:08 -0600, Rob Herring wrote: > On Mon, Mar 22, 2021 at 12:11:29PM -0700, Scott Branden wrote: > > On 2021-03-22 11:58 a.m., Nicolas Saenz Julienne wrote: > > > Convert the brcm,iproc-sdhci binding to DT schema format using json-schema > > > &

Re: [PATCH 4/4] ARM: dts: Fix-up EMMC2 controller's frequency

2021-03-22 Thread Nicolas Saenz Julienne
On Mon, 2021-03-22 at 12:06 -0700, Scott Branden wrote: > 1st line of commit should be ARM: dts: bcm2711 Ouch, of course... Sorry for that. Regards, Nicolas signature.asc Description: This is a digitally signed message part

Re: [PATCH 1/4] dt-bindings: mmc: iproc-sdhci: Convert to json-schema

2021-03-22 Thread Nicolas Saenz Julienne
On Mon, 2021-03-22 at 12:11 -0700, Scott Branden wrote: > On 2021-03-22 11:58 a.m., Nicolas Saenz Julienne wrote: > > Convert the brcm,iproc-sdhci binding to DT schema format using json-schema > > > > Signed-off-by: Nicolas Saenz Julienne > > --- > >  .../b

[PATCH 4/4] ARM: dts: Fix-up EMMC2 controller's frequency

2021-03-22 Thread Nicolas Saenz Julienne
From: Nicolas Saenz Julienne Force emmc2's frequency to 150MHz as the default 100MHz (set by FW) seems to interfere with the VPU clock when setup at frequencies bigger than 500MHz (a pretty common case). This ends up causing unwarranted SDHCI CMD hangs when no SD card is present. Signed-off

[PATCH 2/4] dt-bindings: mmc: iproc-sdhci: Add clock-frequency support

2021-03-22 Thread Nicolas Saenz Julienne
Users might want to choose a different clock frequency than whatever the bootloader provided at probe time. Add 'clock-frequency' bindings. Signed-off-by: Nicolas Saenz Julienne --- Documentation/devicetree/bindings/mmc/brcm,iproc-sdhci.yaml | 6 ++ 1 file changed, 6 insertions(+) diff

[PATCH 3/4] mmc: sdhci-iproc: Set clock frequency as per DT

2021-03-22 Thread Nicolas Saenz Julienne
From: Nicolas Saenz Julienne devicetree might request a clock frequency different from whatever is set-up by the bootloader. Make sure to setup the new rate. Signed-off-by: Nicolas Saenz Julienne --- drivers/mmc/host/sdhci-iproc.c | 10 ++ 1 file changed, 10 insertions(+) diff --git

[PATCH 1/4] dt-bindings: mmc: iproc-sdhci: Convert to json-schema

2021-03-22 Thread Nicolas Saenz Julienne
Convert the brcm,iproc-sdhci binding to DT schema format using json-schema Signed-off-by: Nicolas Saenz Julienne --- .../bindings/mmc/brcm,iproc-sdhci.yaml| 58 +++ .../bindings/mmc/brcm,sdhci-iproc.txt | 37 2 files changed, 58 insertions(+), 37

[PATCH 0/4] BCM2711's sdhci-iproc CMD timeouts

2021-03-22 Thread Nicolas Saenz Julienne
configured at 500MHz or more, lower clocks are OK. There is no specific command that will time out, it seems random. I found out that by bumping the controller's frequency to 150MHz the issue disapears. So let's do that. Regards, Nicolas --- Nicolas Saenz Julienne (4): dt-bindings: mmc: iproc

Re: [PATCH v3 2/2] arm64: mm: reserve CMA and crashkernel in ZONE_DMA32

2021-03-22 Thread Nicolas Saenz Julienne
On Mon, 2021-03-22 at 14:40 -0400, Jon Masters wrote: > On 3/22/21 2:34 PM, Jon Masters wrote: > > Hi Nicolas, > > > > On 11/7/19 4:56 AM, Nicolas Saenz Julienne wrote: > > > With the introduction of ZONE_DMA in arm64 we moved the default CMA and > > >

Re: [PATCH] dt-bindings: Drop type references on common properties

2021-03-18 Thread Nicolas Saenz Julienne
On Tue, 2021-03-16 at 13:48 -0600, Rob Herring wrote: > Users of common properties shouldn't have a type definition as the > common schemas already have one. Drop all the unnecessary type > references in the tree. > > A meta-schema update to catch these is pending. > > Cc: N

Re: [PATCH v8 11/11] pwm: Add Raspberry Pi Firmware based PWM bus

2021-03-15 Thread Nicolas Saenz Julienne
Hi Uwe, On Fri, 2021-03-12 at 21:12 +0100, Uwe Kleine-König wrote: > Hello Nicolas, > > +// SPDX-License-Identifier: GPL-2.0 > > +/* > > + * Copyright 2020 Nicolas Saenz Julienne > > 2021? Yes. > > + * For more information on Raspberry Pi's PoE hat see: &g

Re: [PATCH] nvmem: rmem: fix undefined reference to memremap

2021-03-15 Thread Nicolas Saenz Julienne
t > Signed-off-by: Srinivas Kandagatla > --- Reviewed-by: Nicolas Saenz Julienne Thanks! >  drivers/nvmem/Kconfig | 1 + >  1 file changed, 1 insertion(+) > > diff --git a/drivers/nvmem/Kconfig b/drivers/nvmem/Kconfig > index 642ddc699fd1..dd2019006838 100644 > --- a/driv

[PATCH v8 11/11] pwm: Add Raspberry Pi Firmware based PWM bus

2021-03-12 Thread Nicolas Saenz Julienne
Adds support to control the PWM bus available in official Raspberry Pi PoE HAT. Only RPi's co-processor has access to it, so commands have to be sent through RPi's firmware mailbox interface. Signed-off-by: Nicolas Saenz Julienne --- Changes since v7: - Remove unwarranted RPI_PWM_DEF_DUTY_REG

[PATCH v8 10/11] DO NOT MERGE: ARM: dts: Add RPi's official PoE hat support

2021-03-12 Thread Nicolas Saenz Julienne
This is an example on how to enable the fan on top of RPi's official PoE hat. Signed-off-by: Nicolas Saenz Julienne --- arch/arm/boot/dts/bcm2711-rpi-4-b.dts | 54 +++ 1 file changed, 54 insertions(+) diff --git a/arch/arm/boot/dts/bcm2711-rpi-4-b.dts b/arch/arm/boot

[PATCH v8 09/11] dt-bindings: pwm: Add binding for RPi firmware PWM bus

2021-03-12 Thread Nicolas Saenz Julienne
The PWM bus controlling the fan in RPi's official PoE hat can only be controlled by the board's co-processor. Signed-off-by: Nicolas Saenz Julienne Reviewed-by: Rob Herring --- Changes since v4: - Rename compatible string to be more explicit with the bus' limitations Changes since v3: - Fix

[PATCH v8 05/11] reset: raspberrypi: Release firmware handle on unbind

2021-03-12 Thread Nicolas Saenz Julienne
Use devm_rpi_firmware_get() so as to make sure we release RPi's firmware interface when unbinding the device. Signed-off-by: Nicolas Saenz Julienne Reviewed-by: Florian Fainelli --- drivers/reset/reset-raspberrypi.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers

[PATCH v8 04/11] gpio: raspberrypi-exp: Release firmware handle on unbind

2021-03-12 Thread Nicolas Saenz Julienne
Use devm_rpi_firmware_get() so as to make sure we release RPi's firmware interface when unbinding the device. Signed-off-by: Nicolas Saenz Julienne Reviewed-by: Florian Fainelli Acked-by: Bartosz Golaszewski --- drivers/gpio/gpio-raspberrypi-exp.c | 2 +- 1 file changed, 1 insertion(+), 1

[PATCH v8 06/11] soc: bcm: raspberrypi-power: Release firmware handle on unbind

2021-03-12 Thread Nicolas Saenz Julienne
Use devm_rpi_firmware_get() so as to make sure we release RPi's firmware interface when unbinding the device. Signed-off-by: Nicolas Saenz Julienne Reviewed-by: Florian Fainelli --- drivers/soc/bcm/raspberrypi-power.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers

[PATCH v8 07/11] staging: vchiq: Release firmware handle on unbind

2021-03-12 Thread Nicolas Saenz Julienne
Use devm_rpi_firmware_get() so as to make sure we release RPi's firmware interface when unbinding the device. Signed-off-by: Nicolas Saenz Julienne Reviewed-by: Florian Fainelli Reviewed-by: Greg Kroah-Hartman --- drivers/staging/vc04_services/interface/vchiq_arm/vchiq_arm.c | 2 +- 1 file

[PATCH v8 03/11] clk: bcm: rpi: Release firmware handle on unbind

2021-03-12 Thread Nicolas Saenz Julienne
Use devm_rpi_firmware_get() so as to make sure we release RPi's firmware interface when unbinding the device. Signed-off-by: Nicolas Saenz Julienne Reviewed-by: Florian Fainelli Acked-by: Stephen Boyd drivers/clk/bcm/clk-raspberrypi.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion

[PATCH v8 02/11] firmware: raspberrypi: Introduce devm_rpi_firmware_get()

2021-03-12 Thread Nicolas Saenz Julienne
It'll simplify the firmware handling for most consumers. Suggested-by: Bartosz Golaszewski Signed-off-by: Nicolas Saenz Julienne Reviewed-by: Florian Fainelli Reviewed-by: Bartosz Golaszewski --- Changes since v4: - Rearrange function calls for clarity, same functionality Changes since v2

[PATCH v8 08/11] input: raspberrypi-ts: Release firmware handle when not needed

2021-03-12 Thread Nicolas Saenz Julienne
There is no use for the firmware interface after getting the touch buffer address, so release it. Signed-off-by: Nicolas Saenz Julienne Acked-by: Dmitry Torokhov Reviewed-by: Florian Fainelli --- Changes since v5: - Correct commit message Changes since v3: - Release firmware handle

[PATCH v8 01/11] firmware: raspberrypi: Keep count of all consumers

2021-03-12 Thread Nicolas Saenz Julienne
unbinding consumer drivers. Suggested-by: Uwe Kleine-König Signed-off-by: Nicolas Saenz Julienne Reviewed-by: Florian Fainelli Reviewed-by: Stephen Boyd Reviewed-by: Bartosz Golaszewski --- Changes since v5: - Add comment to avoid people blindly switching the memory allocation to the devm

[PATCH v8 00/11] Raspberry Pi PoE HAT fan support

2021-03-12 Thread Nicolas Saenz Julienne
e devm function - Fix touchscreen function - Use kref Changes since v2: - Introduce devm_rpi_firmware_get() - Small cleanups in PWM driver Changes since v1: - Address PWM driver changes - Fix binding, now with 2 cells Nicolas Saenz Julienne (11): firmware: raspberrypi: Keep count of al

Re: [PATCH v7 11/11] pwm: Add Raspberry Pi Firmware based PWM bus

2021-03-11 Thread Nicolas Saenz Julienne
On Thu, 2021-03-11 at 14:18 +0100, Uwe Kleine-König wrote: > Hello Nicolas, > > On Thu, Mar 11, 2021 at 02:01:00PM +0100, Nicolas Saenz Julienne wrote: > > On Wed, 2021-03-10 at 12:50 +0100, Uwe Kleine-König wrote: > > > On Mon, Jan 18, 2021 at 01:32:44PM +0100, Nico

Re: [PATCH v7 11/11] pwm: Add Raspberry Pi Firmware based PWM bus

2021-03-11 Thread Nicolas Saenz Julienne
Hi Uwe, thanks for taking the time to look into this. :) On Wed, 2021-03-10 at 12:50 +0100, Uwe Kleine-König wrote: > Hello Nicolas, > > On Mon, Jan 18, 2021 at 01:32:44PM +0100, Nicolas Saenz Julienne wrote: [...] > > + /* > > +* This sets the default duty

Re: [PATCH v7 11/11] pwm: Add Raspberry Pi Firmware based PWM bus

2021-03-09 Thread Nicolas Saenz Julienne
On Mon, 2021-01-18 at 13:32 +0100, Nicolas Saenz Julienne wrote: > Adds support to control the PWM bus available in official Raspberry Pi > PoE HAT. Only RPi's co-processor has access to it, so commands have to > be sent through RPi's firmware mailbox interface. > > Signed-off-by

Re: [PATCH] hwrng: bcm2835: set quality to 1000

2021-03-04 Thread Nicolas Saenz Julienne
On Wed, 2021-03-03 at 10:29 +0100, Álvaro Fernández Rojas wrote: > Hi Herbert, > > > El 3 mar 2021, a las 10:20, Herbert Xu > > escribió: > > > > On Sat, Feb 20, 2021 at 08:12:45PM +0100, Álvaro Fernández Rojas wrote: > > > > > > I ran rngtest and this is what I got: > > > > This is

Re: [PATCH stable v5.10 0/7] arm64: Default to 32-bit wide ZONE_DMA

2021-03-04 Thread Nicolas Saenz Julienne
On Thu, 2021-03-04 at 15:17 +0100, Greg KH wrote: > On Thu, Mar 04, 2021 at 03:05:32PM +0100, Nicolas Saenz Julienne wrote: > > Hi Greg. > > > > On Thu, 2021-03-04 at 14:46 +0100, Greg KH wrote: > > > On Wed, Mar 03, 2021 at 03:33:12PM +0800, Jing Xiangfeng wrote:

Re: [PATCH stable v5.10 0/7] arm64: Default to 32-bit wide ZONE_DMA

2021-03-04 Thread Nicolas Saenz Julienne
Hi Greg. On Thu, 2021-03-04 at 14:46 +0100, Greg KH wrote: > On Wed, Mar 03, 2021 at 03:33:12PM +0800, Jing Xiangfeng wrote: > > Using two distinct DMA zones turned out to be problematic. Here's an > > attempt go back to a saner default. > > What problem does this solve? How does this fit into

Re: [PATCH v3 1/2] dt-bindings: rng: bcm2835: document reset support

2021-03-04 Thread Nicolas Saenz Julienne
On Thu, 2021-03-04 at 13:18 +0100, Álvaro Fernández Rojas wrote: > > > El 4 mar 2021, a las 13:07, Nicolas Saenz Julienne > > escribió: > > > > Hi Alvaro, > > > > On Tue, 2021-02-23 at 18:00 +0100, Álvaro Fernández Rojas wrote: > > > Some

Re: [PATCH v5 1/2] dt-bindings: rng: bcm2835: document reset support

2021-03-04 Thread Nicolas Saenz Julienne
Sorry Alvaro I missed you sent a v5 already. See my comments in v3. Regards, Nicolas On Thu, 2021-03-04 at 08:33 +0100, Álvaro Fernández Rojas wrote: > Some devices may need to perform a reset before using the RNG, such as the > BCM6368. > > Signed-off-by: Álvaro Fernández Rojas > --- >  v5:

Re: [PATCH v3 1/2] dt-bindings: rng: bcm2835: document reset support

2021-03-04 Thread Nicolas Saenz Julienne
Hi Alvaro, On Tue, 2021-02-23 at 18:00 +0100, Álvaro Fernández Rojas wrote: > Some devices may need to perform a reset before using the RNG, such as the > BCM6368. > > Signed-off-by: Álvaro Fernández Rojas > --- >  v3: make resets required if brcm,bcm6368-rng. >  v2: document reset support. >

Re: [RFC 02/13] driver core: Introduce MMIO configuration

2021-03-02 Thread Nicolas Saenz Julienne
Hi Robin, On Tue, 2021-03-02 at 11:29 +, Robin Murphy wrote: > On 2021-02-26 14:02, Nicolas Saenz Julienne wrote: > > Some devices might inadvertently sit on buses that don't support 64bit > > MMIO access, and need a mechanism to query these limitations without > > pre

Re: [RFC 10/13] iommu/arm-smmu-impl: Get rid of Marvell's implementation details

2021-03-02 Thread Nicolas Saenz Julienne
On Tue, 2021-03-02 at 11:40 +, Robin Murphy wrote: > On 2021-02-26 14:03, Nicolas Saenz Julienne wrote: > > arm-smmu can now deal with integrations on buses that don't support > > 64bit MMIO accesses. No need to create a special case for that on > > Marvell's integrat

Re: [RFC 09/13] iommu/arm-smmu: Make use of dev_64bit_mmio_supported()

2021-03-02 Thread Nicolas Saenz Julienne
Hi Robin, thanks for taking the time to look at this. On Tue, 2021-03-02 at 11:07 +, Robin Murphy wrote: > On 2021-02-26 14:03, Nicolas Saenz Julienne wrote: > > Some arm SMMU implementations might sit on a bus that doesn't support > > 64bit memory accesses. In that case d

Re: [RFC 09/13] iommu/arm-smmu: Make use of dev_64bit_mmio_supported()

2021-03-02 Thread Nicolas Saenz Julienne
Hi Arnd, thanks for the reviews! On Tue, 2021-03-02 at 10:32 +0100, Arnd Bergmann wrote: > On Fri, Feb 26, 2021 at 3:03 PM Nicolas Saenz Julienne > wrote: > > > if (smmu->impl && unlikely(smmu->impl->write_reg)) > > smmu-&g

[RFC 11/13] arm64: Mark ARCH_BCM2835 as needing broken 64bit MMIO support

2021-02-26 Thread Nicolas Saenz Julienne
The PCIe bus present in BCM2711 can't handle 64bit accesses on device memory. So select 'ARCH_HAS_64BIT_MMIO_BROKEN.' Signed-off-by: Nicolas Saenz Julienne --- arch/arm64/Kconfig.platforms | 1 + 1 file changed, 1 insertion(+) diff --git a/arch/arm64/Kconfig.platforms b/arch/arm64

[RFC 13/13] scsi: megaraid: Make use of dev_64bit_mmio_supported()

2021-02-26 Thread Nicolas Saenz Julienne
Instead of relying on defines use dev_64bit_mmio_supported(), which provides the same functionality. On top of that convert the implementation to lo_hi_writeq(), for a cleaner end result. Signed-off-by: Nicolas Saenz Julienne --- drivers/scsi/megaraid/megaraid_sas_fusion.c | 23

[RFC 07/13] arm64: Mark ARCH_MVEBU as needing broken 64bit MMIO support

2021-02-26 Thread Nicolas Saenz Julienne
The bus AP806's IOMMU sits on can't handle 64bit MMIO accesses[1]. So select 'ARCH_HAS_64BIT_MMIO_BROKEN' for the platform. Signed-off-by: Nicolas Saenz Julienne [1] See Armada-AP806 erratum #582743 --- arch/arm64/Kconfig.platforms | 1 + 1 file changed, 1 insertion(+) diff --git a/arch/arm64

[RFC 12/13] ARM: dts: bcm2711: Mark PCIe bus as 64bit-mmio-broken

2021-02-26 Thread Nicolas Saenz Julienne
The bus implementation can't handle 64bit MMIO accesses. Signed-off-by: Nicolas Saenz Julienne --- arch/arm/boot/dts/bcm2711.dtsi | 1 + 1 file changed, 1 insertion(+) diff --git a/arch/arm/boot/dts/bcm2711.dtsi b/arch/arm/boot/dts/bcm2711.dtsi index 462b1dfb0385..825abdbc0d76 100644

[RFC 10/13] iommu/arm-smmu-impl: Get rid of Marvell's implementation details

2021-02-26 Thread Nicolas Saenz Julienne
arm-smmu can now deal with integrations on buses that don't support 64bit MMIO accesses. No need to create a special case for that on Marvell's integration. Signed-off-by: Nicolas Saenz Julienne --- drivers/iommu/arm/arm-smmu/arm-smmu-impl.c | 21 - 1 file changed, 21

[RFC 09/13] iommu/arm-smmu: Make use of dev_64bit_mmio_supported()

2021-02-26 Thread Nicolas Saenz Julienne
Some arm SMMU implementations might sit on a bus that doesn't support 64bit memory accesses. In that case default to using hi_lo_{readq, writeq}() and BUG if such platform tries to use AArch64 formats as they rely on writeq()'s atomicity. Signed-off-by: Nicolas Saenz Julienne --- drivers/iommu

[RFC 05/13] pci: Introduce pci_mmio_configure()

2021-02-26 Thread Nicolas Saenz Julienne
The function will traverse the pci device's bus hierarchy and set the relevant MMIO access flags. Signed-off-by: Nicolas Saenz Julienne --- drivers/pci/pci-driver.c | 26 ++ 1 file changed, 26 insertions(+) diff --git a/drivers/pci/pci-driver.c b/drivers/pci/pci

[RFC 06/13] device core: Introduce dev_64bit_mmio_supported()

2021-02-26 Thread Nicolas Saenz Julienne
This helper function will be help drivers ascertain whether they can use 64-bit memory accesses. Signed-off-by: Nicolas Saenz Julienne --- include/linux/device.h | 17 + 1 file changed, 17 insertions(+) diff --git a/include/linux/device.h b/include/linux/device.h index

[RFC 08/13] arm64: dts: marvell: armada-ap80x: Mark config-space bus as 64bit-mmio-broken

2021-02-26 Thread Nicolas Saenz Julienne
As per Marvell's Armada-AP806 erratum #582743 the bus can't handle 64bit MMIO accesses. Signed-off-by: Nicolas Saenz Julienne --- arch/arm64/boot/dts/marvell/armada-ap80x.dtsi | 1 + 1 file changed, 1 insertion(+) diff --git a/arch/arm64/boot/dts/marvell/armada-ap80x.dtsi b/arch/arm64/boot

[RFC 04/13] driver core: plafrom: Introduce platform_mmio_configure()

2021-02-26 Thread Nicolas Saenz Julienne
The function will traverse the platform device's bus hierarchy and set the relevant MMIO access flags. Signed-off-by: Nicolas Saenz Julienne --- drivers/base/platform.c | 9 + 1 file changed, 9 insertions(+) diff --git a/drivers/base/platform.c b/drivers/base/platform.c index

[RFC 03/13] of: device: Introduce of_mmio_configure()

2021-02-26 Thread Nicolas Saenz Julienne
The function will traverse a device's bus hierarchy looking for MMIO limited buses. If found it'll populate the relevant struct device quirks. Signed-off-by: Nicolas Saenz Julienne --- drivers/of/device.c | 19 +++ include/linux/of_device.h | 8 2 files changed

[RFC 00/13] Generic way of dealing with broken 64-bit buses

2021-02-26 Thread Nicolas Saenz Julienne
approach. Regards, Nicolas [1] https://lore.kernel.org/linux-arm-kernel/c188698ca0de3ed6c56a0cf7880e1578aa753077.ca...@suse.de/ --- Nicolas Saenz Julienne (13): dt-bindings: Introduce 64bit-mmio-broken driver core: Introduce MMIO configuration of: device: Introduce of_mmio_configure

[RFC 02/13] driver core: Introduce MMIO configuration

2021-02-26 Thread Nicolas Saenz Julienne
will take care of populating the relevant device properties based on the bus' limitations. Signed-off-by: Nicolas Saenz Julienne --- arch/Kconfig | 8 drivers/base/dd.c | 6 ++ include/linux/device.h | 3 +++ include/linux/device/bus.h | 3 +++ 4 files

[RFC 01/13] dt-bindings: Introduce 64bit-mmio-broken

2021-02-26 Thread Nicolas Saenz Julienne
Some buses might not be able to handle 64-bit sized MMIO accesses, on otherwise 64-bit systems. Introduce a boolean property to cater for this limitation. Signed-off-by: Nicolas Saenz Julienne --- .../devicetree/bindings/common-properties.txt | 15 +++ 1 file changed, 15

[RFC 2/2] mmc: sdhci-iproc: Set clock frequency as per DT

2021-02-25 Thread Nicolas Saenz Julienne
devicetree might request a clock frequency different from whatever is set-up by the bootloader. Make sure to setup the new rate. Signed-off-by: Nicolas Saenz Julienne --- drivers/mmc/host/sdhci-iproc.c | 10 ++ 1 file changed, 10 insertions(+) diff --git a/drivers/mmc/host/sdhci

[RFC 1/2] ARM: dts: Fix-up EMMC2 controller's frequency

2021-02-25 Thread Nicolas Saenz Julienne
Force emmc2's frequency to 150MHz as the default 100MHz (set by FW) seems to interfere with the VPU clock when setup at frequencies bigger than 500MHz, causing unwarranted SDHCI CMD hangs when no SD card is present. Signed-off-by: Nicolas Saenz Julienne --- arch/arm/boot/dts/bcm2711-rpi-4-b.dts

[RFC 0/2] sdhci-iproc CMD timeouts

2021-02-25 Thread Nicolas Saenz Julienne
75023 emmc2149882908 pllc 299988 pllc_core0 6 vpu 49998 Nicolas Saenz Julienne (2): ARM: dts

Re: [PATCH -next] nvmem: Fix return value check in rmem_read()

2021-02-23 Thread Nicolas Saenz Julienne
rved memory as nvmem") > Reported-by: Hulk Robot > Signed-off-by: Wei Yongjun > --- Acked-by: Nicolas Saenz Julienne Thanks! signature.asc Description: This is a digitally signed message part

[PATCH v3 15/15] arm64: config: Enable DRM_V3D

2021-02-17 Thread Nicolas Saenz Julienne
BCM2711, the SoC used on the Raspberry Pi 4 has a different GPU than its predecessors. Enable it. Signed-off-by: Nicolas Saenz Julienne --- arch/arm64/configs/defconfig | 1 + 1 file changed, 1 insertion(+) diff --git a/arch/arm64/configs/defconfig b/arch/arm64/configs/defconfig index

[PATCH v3 14/15] ARM: configs: Enable DRM_V3D

2021-02-17 Thread Nicolas Saenz Julienne
BCM2711, the SoC used on the Raspberry Pi 4 has a different GPU than its predecessors. Enable it. Signed-off-by: Nicolas Saenz Julienne --- arch/arm/configs/multi_v7_defconfig | 1 + 1 file changed, 1 insertion(+) diff --git a/arch/arm/configs/multi_v7_defconfig b/arch/arm/configs

[PATCH v3 13/15] ARM: dts: bcm2711: Enable V3D

2021-02-17 Thread Nicolas Saenz Julienne
This enables V3D for bcm2711 (used in the Raspberry Pi 4). Signed-off-by: Nicolas Saenz Julienne --- Changes since v1: - Correct node's name address arch/arm/boot/dts/bcm2711.dtsi | 12 1 file changed, 12 insertions(+) diff --git a/arch/arm/boot/dts/bcm2711.dtsi b/arch/arm

[PATCH v3 12/15] drm/v3d: Add support for bcm2711

2021-02-17 Thread Nicolas Saenz Julienne
Add compatible string and Kconfig options for bcm2711. Signed-off-by: Nicolas Saenz Julienne --- drivers/gpu/drm/v3d/Kconfig | 2 +- drivers/gpu/drm/v3d/v3d_drv.c | 1 + 2 files changed, 2 insertions(+), 1 deletion(-) diff --git a/drivers/gpu/drm/v3d/Kconfig b/drivers/gpu/drm/v3d/Kconfig

[PATCH v3 11/15] drm/v3d: Get rid of pm code

2021-02-17 Thread Nicolas Saenz Julienne
n with V3D on BCM2711 (Raspberry Pi 4), get rid of the PM code. PM will be reinstated once we figure out the underlying issues. Signed-off-by: Nicolas Saenz Julienne --- drivers/gpu/drm/v3d/v3d_debugfs.c | 18 +- drivers/gpu/drm/v3d/v3d_drv.c | 11 --- drivers/gpu/drm/v3d

[PATCH v3 06/15] mfd: bcm2835-pm: Use 'reg-names' to get resources

2021-02-17 Thread Nicolas Saenz Julienne
If available in firmware, find resources by their 'reg-names' position instead of relying on hardcoded offsets. Care is taken to support old firmware nonetheless. Signed-off-by: Nicolas Saenz Julienne --- Changes since v2: - correct names drivers/mfd/bcm2835-pm.c | 55

[PATCH v3 10/15] dt-bindings: gpu: v3d: Add BCM2711's compatible

2021-02-17 Thread Nicolas Saenz Julienne
BCM2711, Raspberry Pi 4's SoC, contains a V3D core. So add its specific compatible to the bindings. Signed-off-by: Nicolas Saenz Julienne Reviewed-by: Rob Herring --- Documentation/devicetree/bindings/gpu/brcm,bcm-v3d.yaml | 1 + 1 file changed, 1 insertion(+) diff --git a/Documentation

[PATCH v3 05/15] ARM: dts: bcm2711: Use proper compatible in PM/Watchdog node

2021-02-17 Thread Nicolas Saenz Julienne
A new compatible string was introduced specifically for BCM2711, so make use of it. Signed-off-by: Nicolas Saenz Julienne --- arch/arm/boot/dts/bcm2711.dtsi | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/arch/arm/boot/dts/bcm2711.dtsi b/arch/arm/boot/dts/bcm2711.dtsi index

[PATCH v3 07/15] mfd: bcm2835-pm: Add support for BCM2711

2021-02-17 Thread Nicolas Saenz Julienne
into 'bcm2835-power,' which will take care of selecting which one to use accordingly. Since the RPiVid ASB's resources were being provided prior to formalizing the bindings[1], also support the old firmwares that didn't use 'reg-names.' Signed-off-by: Nicolas Saenz Julienne [1] See: 7dbe8c62ceeb ("ARM

[PATCH v3 09/15] soc: bcm: bcm2835-power: Bypass power_on/off() calls

2021-02-17 Thread Nicolas Saenz Julienne
Bypass power_on/power_off() when running on BCM2711 as they are not needed. Signed-off-by: Nicolas Saenz Julienne --- Changes since v2: - Correct names drivers/soc/bcm/bcm2835-power.c | 8 1 file changed, 8 insertions(+) diff --git a/drivers/soc/bcm/bcm2835-power.c b/drivers/soc

[PATCH v3 08/15] soc: bcm: bcm2835-power: Add support for BCM2711's RPiVid ASB

2021-02-17 Thread Nicolas Saenz Julienne
ich will select the correct ASB register base, based on whether we're trying to access V3D and which platform we're on. Signed-off-by: Nicolas Saenz Julienne --- Changes since v2: - Correct names again Changes since v1: - Correct names drivers/soc/bcm/bcm2835-power.c |

[PATCH v3 04/15] ARM: dts: bcm2835/bcm2711: Introduce reg-names in watchdog node

2021-02-17 Thread Nicolas Saenz Julienne
bcm2835-pm's bindings now support explicitly setting 'reg-names,' so use them. Signed-off-by: Nicolas Saenz Julienne --- arch/arm/boot/dts/bcm2711.dtsi| 1 + arch/arm/boot/dts/bcm2835-common.dtsi | 1 + 2 files changed, 2 insertions(+) diff --git a/arch/arm/boot/dts/bcm2711.dtsi b/arch

[PATCH v3 03/15] dt-bindings: soc: bcm: bcm2835-pm: Add support for bcm2711

2021-02-17 Thread Nicolas Saenz Julienne
-by: Nicolas Saenz Julienne Reviewed-by: Rob Herring --- Changes since v2: - Correct names s/argon/rpivid/ .../devicetree/bindings/soc/bcm/brcm,bcm2835-pm.yaml | 11 +++ 1 file changed, 7 insertions(+), 4 deletions(-) diff --git a/Documentation/devicetree/bindings/soc/bcm/brcm,bcm2835

[PATCH v3 02/15] dt-bindings: soc: bcm: bcm2835-pm: Introduce reg-names

2021-02-17 Thread Nicolas Saenz Julienne
Anticipating the introduction of BCM2711, of which we'll need to support its new RPiVid ASB, introduce reg-names into bcm2835-pm's binding. This will help to have a consistent mapping between resources and their meaning. Signed-off-by: Nicolas Saenz Julienne --- .../devicetree/bindings/soc/bcm

[PATCH v3 00/15] Raspberry PI 4 V3D enablement

2021-02-17 Thread Nicolas Saenz Julienne
e experience using mesa 20.3.4 and X11/Gnome. Regards, Nicolas --- Changes since v2: - Correct ASB names - Address dt-binding comments Changes since v1: - Use 'reg-names' - Correct ASB names - Add missing binding patch for V3D - Address Stefan's comments Nicolas Saenz Julienne (15): dt-

[PATCH v3 01/15] dt-bindings: soc: bcm: bcm2835-pm: Convert bindings to DT schema

2021-02-17 Thread Nicolas Saenz Julienne
This converts the brcm,bcm2835-pm bindings from text to proper schema. Signed-off-by: Nicolas Saenz Julienne --- Changes since v2: - Slightly change things to make it less dependent on next commits .../bindings/soc/bcm/brcm,bcm2835-pm.txt | 46 --- .../bindings/soc/bcm/brcm

Re: [PATCH] Revert "ARM: dts: bcm2711: Add the BSC interrupt controller"

2021-02-16 Thread Nicolas Saenz Julienne
or now which will mean that HDMI I2C will be > polled, like it was before. > > Reported-by: Dave Stevenson > Signed-off-by: Florian Fainelli Acked-by: Nicolas Saenz Julienne Regards, Nicolas signature.asc Description: This is a digitally signed message part

Re: [PATCH] spi: Skip zero-length transfers in spi_transfer_one_message()

2021-02-12 Thread Nicolas Saenz Julienne
On Fri, 2021-02-12 at 12:31 +, Mark Brown wrote: > On Thu, Feb 11, 2021 at 07:08:20PM +0100, Nicolas Saenz Julienne wrote: > > > - if (xfer->tx_buf || xfer->rx_buf) { > > + if ((xfer->tx_buf || xfer->rx_buf) && xfer->len) { >

Re: [PATCH v2 14/15] ARM: dts: bcm2711: Add the BSC interrupt controller

2021-02-12 Thread Nicolas Saenz Julienne
On Wed, 2021-02-10 at 10:49 -0800, Florian Fainelli wrote: > On 2/10/21 7:49 AM, Dave Stevenson wrote: > > Hi Marc. > > > > On Wed, 10 Feb 2021 at 15:30, Marc Zyngier wrote: > > > > > > Hi Maxime, > > > > > > On 2021-02-10 14:40, Maxime Ripard wrote: > > > > Hi Dave, > > > > > > > > On Tue,

[PATCH] spi: Skip zero-length transfers in spi_transfer_one_message()

2021-02-11 Thread Nicolas Saenz Julienne
ion itself, use a bigger hammer and skip zero-length transfers altogether for drivers using the default transfer_one_message() implementation. Reported-by: Phil Elwell Fixes: 26751de25d25 ("spi: bcm2835: Micro-optimise FIFO loops") Signed-off-by: Nicolas Saenz Julienne [1] https://github.c

Re: bcm2711_thermal: Kernel panic - not syncing: Asynchronous SError Interrupt

2021-02-10 Thread Nicolas Saenz Julienne
Hi Robin, On Wed, 2021-02-10 at 16:25 +, Robin Murphy wrote: > On 2021-02-10 13:15, Nicolas Saenz Julienne wrote: > > [ Add Robin, Catalin and Florian in case they want to chime in ] > > > > Hi Juerg, thanks for the report! > > > > On Wed, 2021-02-10 at 1

Re: bcm2711_thermal: Kernel panic - not syncing: Asynchronous SError Interrupt

2021-02-10 Thread Nicolas Saenz Julienne
[ Add Robin, Catalin and Florian in case they want to chime in ] Hi Juerg, thanks for the report! On Wed, 2021-02-10 at 11:48 +0100, Juerg Haefliger wrote: > Trying to dump the BCM2711 registers kills the kernel: > > # cat /sys/kernel/debug/regmap/dummy-avs-monitor\@fd5d2000/range > 0-efc > #

Re: [PATCH] staging: bcm2835-audio: Replace unsafe strcpy() with strscpy()

2021-02-09 Thread Nicolas Saenz Julienne
e: insmod[1959] exited with preempt_count 1 > [ 58.791921] --------[ cut here ] > > For the sake of it, replace all the other occurences of strcpy() under > bcm2835-audio/ as well. > > Signed-off-by: Juerg Haefliger > --- Reviewed-by: Nicolas Saenz Julienne Regards, Nicolas signature.asc Description: This is a digitally signed message part

Re: [RFC/PATCH v2 09/16] soc: bcm: bcm2835-power: Add support for BCM2711's Argon ASB

2021-02-09 Thread Nicolas Saenz Julienne
Hi Phil, On Tue, 2021-02-09 at 16:38 +, Phil Elwell wrote: > Nicolas, > > > > Please don't refer to this block as ARGON - it is the IP of Raspberry > > > Pi Trading and it's name is RPiVid. > > > > OK, sorry for that. I, again, mixed both ASB names. I'll rename the Argon > > ASB > > to

Re: [RFC/PATCH v2 09/16] soc: bcm: bcm2835-power: Add support for BCM2711's Argon ASB

2021-02-09 Thread Nicolas Saenz Julienne
On Tue, 2021-02-09 at 13:19 +, Phil Elwell wrote: > Hi Nicolas, > > On Tue, 9 Feb 2021 at 13:00, Nicolas Saenz Julienne > wrote: > > > > In BCM2711 the new ARGON ASB took over V3D. The old ASB is still present > > with the ISP and H264 bits, and V3D is in

[RFC/PATCH v2 15/16] ARM: configs: Enable DRM_V3D

2021-02-09 Thread Nicolas Saenz Julienne
BCM2711, the SoC used on the Raspberry Pi 4 has a different GPU than its predecessors. Enable it. Signed-off-by: Nicolas Saenz Julienne --- arch/arm/configs/multi_v7_defconfig | 1 + 1 file changed, 1 insertion(+) diff --git a/arch/arm/configs/multi_v7_defconfig b/arch/arm/configs

[RFC/PATCH v2 16/16] arm64: config: Enable DRM_V3D

2021-02-09 Thread Nicolas Saenz Julienne
BCM2711, the SoC used on the Raspberry Pi 4 has a different GPU than its predecessors. Enable it. Signed-off-by: Nicolas Saenz Julienne --- arch/arm64/configs/defconfig | 1 + 1 file changed, 1 insertion(+) diff --git a/arch/arm64/configs/defconfig b/arch/arm64/configs/defconfig index

  1   2   3   4   5   6   7   8   9   10   >