Den 31.07.2020 14.51, skrev Oleksandr Andrushchenko:
> From: Oleksandr Andrushchenko
>
> Add YUYV to supported formats, so the frontend can work with the
> formats used by cameras and other HW.
>
> Signed-off-by: Oleksandr Andrushchenko
> ---
Acked-by: Noralf Trønnes
>
> Signed-off-by: Oleksandr Andrushchenko
> ---
Acked-by: Noralf Trønnes
Den 26.05.2020 11.08, skrev dillon min:
> Hi Andy,
>
> Thanks for input.
>
> On Tue, May 26, 2020 at 3:46 PM Andy Shevchenko
> wrote:
>>
>> On Mon, May 25, 2020 at 6:46 AM wrote:
>>>
>>> From: dillon min
>>>
>>> This driver combine tiny/ili9341.c mipi_dbi_interface driver
>>> with
Den 01.10.2019 12.58, skrev Noralf Trønnes:
>
>
> Den 27.09.2019 19.42, skrev Ulf Magnusson:
>> Commit 554b3529fe01 ("thermal/drivers/core: Remove the module Kconfig's
>> option") changed the type of THERMAL from tristate to bool, so
>> THERMA
Den 2019-05-27 07:53, skrev Tony Lindgren:
Hi,
* Sebastian Reichel [190523 09:33]:
Hi,
On Thu, May 23, 2019 at 11:09:26AM +0200, Pavel Machek wrote:
> This was greeting me overnight... I don't yet know how reproducible it
> is, it happened once so far.
Please pipe the stacktrace into
Den 28.04.2019 11.51, skrev kernel test robot:
> FYI, we noticed the following commit (built with gcc-7):
>
> commit: 09ded8af57bcef7287b8242087d3e7556380de62 ("drm/i915/fbdev: Move
> intel_fb_initial_config() to fbdev helper")
>
Den 05.04.2019 11.52, skrev Gerd Hoffmann:
> Simliar to drm_fb_xrgb_to_rgb565_dstclip() but converts to rgb888
Simliar -> Similar
> instead of rgb565.
>
> Signed-off-by: Gerd Hoffmann
> ---
Reviewed-by: Noralf Trønnes
then initialize the
> ttm object, and finally attach just created object to the fence for the
> command in case it didn't finish yet.
>
> Signed-off-by: Gerd Hoffmann
> ---
Acked-by: Noralf Trønnes
M_PL_FLAG_NO_EVICT so ttm knows. Doesn't change much for the moment
> as virtio-gpu supports TTM_PL_FLAG_TT only so there is no opportunity to
> move around objects. That'll probably change in the future though.
>
> Signed-off-by: Gerd Hoffmann
> ---
Acked-by: Noralf Trønnes
nevertheless.
>
> Signed-off-by: Gerd Hoffmann
Acked-by: Noralf Trønnes
Den 27.02.2019 15.44, skrev Gerd Hoffmann:
> Sync gem vm_node.start with ttm vm_node.start,
> then we can just call drm_gem_prime_mmap().
>
> Signed-off-by: Gerd Hoffmann
> ---
Acked-by: Noralf Trønnes
; void virtgpu_gem_prime_unpin(struct drm_gem_object *obj)
> {
> - WARN_ONCE(1, "not implemented");
> + /* nothing */
> }
You can just remove these dummies the callbacks are optional. See
drm_gem_pin().
With that:
Reviewed-by: Noralf Trønnes
>
> void *virtgpu_gem_prime_vmap(struct drm_gem_object *obj)
>
Den 21.02.2019 12.35, skrev Gerd Hoffmann:
> It'll be useful for other drivers too, so move it to drm_fb_helper.c
> (and rename it of course). Also add docs.
>
> Signed-off-by: Gerd Hoffmann
> ---
> include/drm/drm_fb_helper.h | 2 ++
> drivers/gpu/drm/drm_fb_helper.c | 39
Den 01.02.2019 09.01, skrev Gerd Hoffmann:
> On Thu, Jan 31, 2019 at 11:47:38AM +0100, Noralf Trønnes wrote:
>>
>>
>> Den 30.01.2019 10.43, skrev Gerd Hoffmann:
>>> Add 3d resource parameters to virtio_gpu_object_params struct. Wit
With that in place virtio_gpu_object_attach() will never be called with
> an object which is not yet created, so the extra
> virtio_gpu_object_attach() calls done after
> virtio_gpu_cmd_create_resource() is not needed any more.
>
> Signed-off-by: Gerd Hoffmann
> ---
Acked-by: Noralf Trønnes
re is no need to wait for completion too. Which
> btw is different from resource destroy, where we have to make sure the
> host has seen the destroy and thus doesn't use it any more before
> releasing the pages backing the resource.
>
> Signed-off-by: Gerd Hoffmann
> ---
Acked-by: Noralf Trønnes
Den 30.01.2019 10.43, skrev Gerd Hoffmann:
> Add 3d resource parameters to virtio_gpu_object_params struct. With
> that in place we can use it for virtio_gpu_cmd_resource_create_3d()
> calls.
>
> Signed-off-by: Gerd Hoffmann
> ---
You don't remove the struct virtio_gpu_resource_create_3d
Den 30.01.2019 10.43, skrev Gerd Hoffmann:
> Add format, width and height fields to the virtio_gpu_object_params
> struct. With that in place we can use the parameter struct for
> virtio_gpu_cmd_create_resource() calls too.
>
> Signed-off-by: Gerd Hoffmann
> ---
Acked-by: Noralf Trønnes
params = { 0 };
> int ret;
> uint32_t pitch;
> uint32_t format;
> @@ -96,7 +97,9 @@ int virtio_gpu_mode_dumb_create(struct drm_file *file_priv,
> args->size = pitch * args->height;
> args->size = ALIGN(args->size, PAGE_SIZE)
e calls from the
> move_notify() callback.
>
> With that in place the move and move_notify callbacks are not
> needed any more, so drop them.
>
> Signed-off-by: Gerd Hoffmann
> ---
Acked-by: Noralf Trønnes
Den 29.01.2019 09.25, skrev Gerd Hoffmann:
> qxl device will not dma, so we don't need ttm_dma_tt. Go use ttm_tt
> instead, to avoid wasting resources (swiotlb bounce buffers for
> example).
>
> Signed-off-by: Gerd Hoffmann
> ---
Acked-by: Noralf Trønnes
Den 28.01.2019 09.59, skrev Gerd Hoffmann:
> On Fri, Jan 25, 2019 at 06:25:27PM +0100, Noralf Trønnes wrote:
>>
>>
>> Den 18.01.2019 13.20, skrev Gerd Hoffmann:
>>> Switch qxl over to the new generic fbdev emulation.
>>>
>>> Signed-off-by:
e the
> commit message with that.
>
This is actually my first review of a driver that I'm not familiar with.
I'm not quite sure how much in depth understanding that is required to
put my ack on it. Going further into the patchset I realised that
there's no way that I can verify the logic without being intimate with
the driver. So I have tried to verify things from a kms point of view.
I liked your expanded explanation better.
Noralf.
>> Acked-by: Noralf Trønnes
>
> thanks,
> Gerd
>
t; drivers/gpu/drm/qxl/qxl_draw.c | 232 ---
>>> drivers/gpu/drm/qxl/qxl_fb.c | 300
>>> -
>>> drivers/gpu/drm/qxl/Makefile | 2 +-
>>> 4 files changed, 1 insertion(+), 554 deletions(-)
>>> delete mode 100644
Den 18.01.2019 13.20, skrev Gerd Hoffmann:
> Add all standard modes from the kernel's video mode data base.
> Keep a few non-standard modes in the qxl mode list.
>
> Signed-off-by: Gerd Hoffmann
> ---
Acked-by: Noralf Trønnes
Den 18.01.2019 13.20, skrev Gerd Hoffmann:
> Add a helper function to add custom video modes to a connector.
>
> Signed-off-by: Gerd Hoffmann
> ---
Acked-by: Noralf Trønnes
are too big will not be added to the mode list in the first place.
>
> Signed-off-by: Gerd Hoffmann
> ---
Acked-by: Noralf Trønnes
Den 18.01.2019 13.20, skrev Gerd Hoffmann:
> Signed-off-by: Gerd Hoffmann
> ---
Acked-by: Noralf Trønnes
---
> drivers/gpu/drm/qxl/Makefile | 2 +-
> 4 files changed, 1 insertion(+), 554 deletions(-)
> delete mode 100644 drivers/gpu/drm/qxl/qxl_fb.c
>
Nice!
Acked-by: Noralf Trønnes
goto modeset_cleanup;
>
> + drm_fb_helper_remove_conflicting_pci_framebuffers(pdev, 0, "qxl");
I couldn't find that this was part of old fbdev code, so it would be
nice to mention it in the commit message.
Acked-by: Noralf Trønnes
> + drm_fbdev_generic_setup(>ddev, 32);
> return 0;
>
> modeset_cleanup:
>
is balanced.
>
> Signed-off-by: Gerd Hoffmann
> ---
Just a note: You catch the one-to-many kmap type of unbalance, but not
the one-too-many kunmap situation.
Acked-by: Noralf Trønnes
> drivers/gpu/drm/qxl/qxl_drv.h| 1 +
> drivers/gpu/drm/qxl/qxl_object.c | 6 ++
> d
ernel doesn't need to dereference pointers each time it
> needs the value, and when reading the code you don't have to trace where
> and why qdev->monitors_config->max_allowed is set.
>
> Signed-off-by: Gerd Hoffmann
> ---
Acked-by: Noralf Trønnes
user_bo->shadow->surf = user_bo->surf;
> + if (user_bo->shadow != qdev->dumb_shadow_bo) {
> + if (user_bo->shadow) {
> + drm_gem_object_put_unlocked
> + (_bo->shadow
pot anything suspicious
looking.
Acked-by: Noralf Trønnes
_io_create_primary().
>
> Signed-off-by: Gerd Hoffmann
> ---
Acked-by: Noralf Trønnes
Den 18.01.2019 13.20, skrev Gerd Hoffmann:
> Signed-off-by: Gerd Hoffmann
> ---
Acked-by: Noralf Trønnes
condition, but
the condition for applying the cursor is changed from bo_old->is_primary
to !bo->is_primary.
It probably makes sense to someone that knows the driver.
Acked-by: Noralf Trønnes
Den 18.01.2019 13.20, skrev Gerd Hoffmann:
> The shadow bo is used as qxl surface, so allocate it as
> QXL_GEM_DOMAIN_SURFACE. Should usually be allocated in
> PRIV ttm domain then, so this reduces VRAM memory pressure.
>
> Signed-off-by: Gerd Hoffmann
> ---
Acked-by: Noralf Trønnes
s which must be allocated there.
>
> Signed-off-by: Gerd Hoffmann
> ---
Acked-by: Noralf Trønnes
Den 18.01.2019 13.20, skrev Gerd Hoffmann:
> dumb buffers are used as qxl surfaces, so allocate them as
> QXL_GEM_DOMAIN_SURFACE. Should usually be allocated in
> PRIV ttm domain then, so this reduces VRAM memory pressure.
>
> Signed-off-by: Gerd Hoffmann
> ---
Acked-by: Noralf Trønnes
s are rare enough by pure luck.
>
> Signed-off-by: Gerd Hoffmann
> ---
Acked-by: Noralf Trønnes
Den 18.01.2019 13.20, skrev Gerd Hoffmann:
> slot_id_bits and slot_gen_bits can be read directly from qxlrom instead.
> va_slot_mask is never used anywhere.
>
> Signed-off-by: Gerd Hoffmann
> ---
Acked-by: Noralf Trønnes
ebased, adapted to upstream changes ]
>
> Signed-off-by: Gerd Hoffmann
> ---
Acked-by: Noralf Trønnes
Den 18.01.2019 13.20, skrev Gerd Hoffmann:
> Drop pointless indirection, remove the mem_slots array and index
> variables, drop dynamic allocation. Store memslots in qxl_device
> instead.
>
> Signed-off-by: Gerd Hoffmann
> ---
Looks sane:
Acked-by: Noralf Trønnes
Den 18.01.2019 13.19, skrev Gerd Hoffmann:
> Signed-off-by: Gerd Hoffmann
> ---
Acked-by: Noralf Trønnes
Den 18.01.2019 13.19, skrev Gerd Hoffmann:
> Not used, is always NULL.
>
> Signed-off-by: Gerd Hoffmann
> ---
Acked-by: Noralf Trønnes
Den 11.01.2019 22.19, skrev Sam Ravnborg:
> Hi Jagan.
>
> Gave this another more detailed read - triggered some additional comments.
> Depite the comments it looks good, and this is all more or
> less cosmetic improvements.
>
> Sam
>
>> +struct st7701_panel_desc {
>> +const struct
Den 11.01.2019 11.25, skrev Daniel Vetter:
> On Fri, Jan 11, 2019 at 05:49:15PM +0800, CK Hu wrote:
>> Hi, Daniel:
>>
>> On Fri, 2019-01-11 at 10:20 +0100, Daniel Vetter wrote:
>>> On Fri, Jan 11, 2019 at 11:20:09AM +0800, CK Hu wrote:
Hi, Daniel:
On Thu, 2019-01-10 at 21:02
Den 10.01.2019 11.16, skrev Gerd Hoffmann:
> Hi,
>
>>> - drm_fb_helper_set_suspend_unlocked(>fb.helper, 1);
>>
>> The generic fbdev emulation doesn't take care of suspend/resume. You
>> could do this:
>> drm_fb_helper_set_suspend_unlocked(drm_dev->fb_helper, 1);
>
> Additional to
Den 10.01.2019 09.28, skrev Gerd Hoffmann:
> Not needed any more, bochs uses the generic emulation now.
>
> Signed-off-by: Gerd Hoffmann
> Reviewed-by: Oleksandr Andrushchenko
> Acked-by: Daniel Vetter
> ---
> drivers/gpu/drm/bochs/bochs.h | 9 ---
>
Den 05.01.2019 19.25, skrev Noralf Trønnes:
>
>
> Den 24.12.2018 16.03, skrev Peter Wu:
>> On Mon, Dec 24, 2018 at 03:52:55PM +0100, Noralf Trønnes wrote:
>>>
>>>
>>> Den 24.12.2018 00.10, skrev Peter Wu:
>>>> On Sun,
in include/drm/
>
> To prepare tinydrm/ for this add dependencies that
> othwewise was pulled in by drmP.h from drm_gem_cma_helper.h
>
> To avoid that tinydrm.h became "include everything",
> push include files to the individual drivers.
>
> Signed-off-by: Sam Ravnborg
> Cc: Maxime Ripard
> Cc: Sean Paul
> Cc: David Airlie
> Cc: Daniel Vetter
> ---
Acked-by: Noralf Trønnes
n Gaignard
> Cc: Vincent Abriou
> Cc: David Airlie
> Cc: Daniel Vetter
> ---
Acked-by: Noralf Trønnes
in include/drm/
>
> To prepare arc/ for this add dependencies that
> othwewise was pulled in by drmP.h from drm_gem_cma_helper.h
>
> Signed-off-by: Sam Ravnborg
> Cc: Alexey Brodkin
> Cc: Daniel Vetter
> Cc: David Airlie
> ---
Acked-by: Noralf Trønnes
Den 30.12.2018 18.48, skrev Sam Ravnborg:
> No further changes required.
>
> Signed-off-by: Sam Ravnborg
> Cc: Maarten Lankhorst
> Cc: Maxime Ripard
> Cc: Sean Paul
> Cc: David Airlie
> Cc: Daniel Vetter
> ---
Acked-by: Noralf Trønnes
pler to remove drmP.h includes
>
> Signed-off-by: Sam Ravnborg
> Cc: Jani Nikula
> Cc: Daniel Vetter
> Cc: Maarten Lankhorst
> Cc: Maxime Ripard
> Cc: Sean Paul
> Cc: David Airlie
> ---
Acked-by: Noralf Trønnes
uct drm_framebuffer;
> struct drm_file;
> struct drm_device;
> +struct drm_clip_rect;
I think you can add drm_gem_object to this list.
>
> /**
> * struct drm_framebuffer_funcs - framebuffer hooks
>
Acked-by: Noralf Trønnes
Den 24.12.2018 16.03, skrev Peter Wu:
On Mon, Dec 24, 2018 at 03:52:55PM +0100, Noralf Trønnes wrote:
Den 24.12.2018 00.10, skrev Peter Wu:
On Sun, Dec 23, 2018 at 02:55:52PM +0100, Noralf Trønnes wrote:
Den 23.12.2018 01.55, skrev Peter Wu:
After drm_fb_helper_fbdev_setup calls
Den 24.12.2018 00.10, skrev Peter Wu:
On Sun, Dec 23, 2018 at 02:55:52PM +0100, Noralf Trønnes wrote:
Den 23.12.2018 01.55, skrev Peter Wu:
After drm_fb_helper_fbdev_setup calls drm_fb_helper_init,
"dev->fb_helper" will be initialized (and thus drm_fb_helper_fini will
hav
bdev_setup/teardown()")
Reported-by: kernel test robot
Cc: Noralf Trønnes
Signed-off-by: Peter Wu
---
drivers/gpu/drm/drm_fb_helper.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/gpu/drm/drm_fb_helper.c b/drivers/gpu/drm/drm_fb_helper.c
index 9d64f874f965..432e
Den 19.12.2018 09.18, skrev Oleksandr Andrushchenko:
On 12/18/18 9:20 PM, Noralf Trønnes wrote:
Den 27.11.2018 11.32, skrev Oleksandr Andrushchenko:
From: Oleksandr Andrushchenko
When GEM backing storage is allocated with drm_gem_get_pages
the backing pages may be cached, thus making
Den 27.11.2018 11.32, skrev Oleksandr Andrushchenko:
From: Oleksandr Andrushchenko
When GEM backing storage is allocated with drm_gem_get_pages
the backing pages may be cached, thus making it possible that
the backend sees only partial content of the buffer which may
lead to screen
-by: Oleksandr Andrushchenko
---
Reviewed-by: Noralf Trønnes
Den 26.09.2018 21.38, skrev Arnd Bergmann:
The variable is declared in an #ifdef section, but the user is
now unconditional, which leads to a build failure:
drivers/gpu/drm/imx/imx-drm-core.c: In function 'imx_drm_bind':
drivers/gpu/drm/imx/imx-drm-core.c:264:6: error: 'legacyfb_depth'
Den 26.09.2018 21.38, skrev Arnd Bergmann:
The variable is declared in an #ifdef section, but the user is
now unconditional, which leads to a build failure:
drivers/gpu/drm/imx/imx-drm-core.c: In function 'imx_drm_bind':
drivers/gpu/drm/imx/imx-drm-core.c:264:6: error: 'legacyfb_depth'
Den 08.08.2018 10.32, skrev Sam Ravnborg:
Hi Noralf.
On Tue, Aug 07, 2018 at 07:35:30PM +0200, Noralf Trønnes wrote:
Den 02.08.2018 21.45, skrev Sam Ravnborg:
Add driver for the winstar wg160160 display.
The driver utilises pardata-dbi that
again utilise the pardata subsystem.
Signed-off
Den 08.08.2018 10.32, skrev Sam Ravnborg:
Hi Noralf.
On Tue, Aug 07, 2018 at 07:35:30PM +0200, Noralf Trønnes wrote:
Den 02.08.2018 21.45, skrev Sam Ravnborg:
Add driver for the winstar wg160160 display.
The driver utilises pardata-dbi that
again utilise the pardata subsystem.
Signed-off
rm/ili9341.c
new file mode 100644
index ..2ce4244a68c3
--- /dev/null
+++ b/drivers/gpu/drm/tinydrm/ili9341.c
@@ -0,0 +1,239 @@
+// SPDX-License-Identifier: GPL-2.0+
+/*
+ * DRM driver for Ilitek ILI9341 panels
+ *
+ * Copyright 2018 David Lechner <da...@lechnology.com>
+ *
+ * B
@@ -0,0 +1,239 @@
+// SPDX-License-Identifier: GPL-2.0+
+/*
+ * DRM driver for Ilitek ILI9341 panels
+ *
+ * Copyright 2018 David Lechner
+ *
+ * Based on mi0283qt.c:
+ * Copyright 2016 Noralf Trønnes
+ */
+
+#include
+#include
+#include
+#include
+#include
+#include
+#include
+
+
Den 15.05.2018 03.43, skrev David Lechner:
This adds a new binding for Ilitek ILI9341 display panels. It includes
a compatible string for one display (more can be added in the future).
The vendor prefix "noname" is used because the vendor is not known.
The YX240QV29-T panel[1] is found, for
Den 15.05.2018 03.43, skrev David Lechner:
This adds a new binding for Ilitek ILI9341 display panels. It includes
a compatible string for one display (more can be added in the future).
The vendor prefix "noname" is used because the vendor is not known.
The YX240QV29-T panel[1] is found, for
Den 15.05.2018 03.43, skrev David Lechner:
This fixes the path to the ilitek,ili9225 device tree binding file.
Signed-off-by: David Lechner <da...@lechnology.com>
---
Reviewed-by: Noralf Trønnes <nor...@tronnes.org>
MAINTAINERS | 2 +-
1 file changed, 1 insertion(+), 1 delet
Den 15.05.2018 03.43, skrev David Lechner:
This fixes the path to the ilitek,ili9225 device tree binding file.
Signed-off-by: David Lechner
---
Reviewed-by: Noralf Trønnes
MAINTAINERS | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/MAINTAINERS b/MAINTAINERS
index
Den 04.04.2018 19.56, skrev Daniel Vetter:
On Wed, Apr 4, 2018 at 7:41 PM, Noralf Trønnes <nor...@tronnes.org> wrote:
Den 04.04.2018 00.42, skrev Rob Clark:
Add an atomic helper to implement dirtyfb support. This is needed to
support DSI command-mode panels with x11 userspace (ie. w
Den 04.04.2018 19.56, skrev Daniel Vetter:
On Wed, Apr 4, 2018 at 7:41 PM, Noralf Trønnes wrote:
Den 04.04.2018 00.42, skrev Rob Clark:
Add an atomic helper to implement dirtyfb support. This is needed to
support DSI command-mode panels with x11 userspace (ie. when we can't
rely
Den 04.04.2018 00.42, skrev Rob Clark:
Add an atomic helper to implement dirtyfb support. This is needed to
support DSI command-mode panels with x11 userspace (ie. when we can't
rely on pageflips to trigger a flush to the panel).
To signal to the driver that the async atomic update needs to
Den 04.04.2018 00.42, skrev Rob Clark:
Add an atomic helper to implement dirtyfb support. This is needed to
support DSI command-mode panels with x11 userspace (ie. when we can't
rely on pageflips to trigger a flush to the panel).
To signal to the driver that the async atomic update needs to
these functions are re-used where possible
(e.g. in mipi_dbi_init()).
Cc: Noralf Trønnes <nor...@tronnes.org>
Suggested-by: Noralf Trønnes <nor...@tronnes.org>
Signed-off-by: David Lechner <da...@lechnology.com>
---
This is a follow up from the mail thread "tinydrm: page allocation f
these functions are re-used where possible
(e.g. in mipi_dbi_init()).
Cc: Noralf Trønnes
Suggested-by: Noralf Trønnes
Signed-off-by: David Lechner
---
This is a follow up from the mail thread "tinydrm: page allocation failure" [1].
I actually got an allocation failure a few times even when
Den 24.01.2018 17.41, skrev Meghana Madhyastha:
Replace of_find_backlight_by_node and of the code around it
with of_find_backlight helper to avoid repetition of code.
Signed-off-by: Meghana Madhyastha <meghana.madhyas...@gmail.com>
---
Reviewed-by: Noralf Trønnes <nor...@tr
Den 24.01.2018 17.41, skrev Meghana Madhyastha:
Replace of_find_backlight_by_node and of the code around it
with of_find_backlight helper to avoid repetition of code.
Signed-off-by: Meghana Madhyastha
---
Reviewed-by: Noralf Trønnes
Changes in v19:
-Changed to devm version
Den 23.01.2018 18.41, skrev Noralf Trønnes:
Den 23.01.2018 17.55, skrev Meghana Madhyastha:
On Tue, Jan 23, 2018 at 03:37:38PM +0100, Noralf Trønnes wrote:
Den 22.01.2018 15.56, skrev Meghana Madhyastha:
Replace of_find_backlight_by_node and of the code around it
with of_find_backlight
Den 23.01.2018 18.41, skrev Noralf Trønnes:
Den 23.01.2018 17.55, skrev Meghana Madhyastha:
On Tue, Jan 23, 2018 at 03:37:38PM +0100, Noralf Trønnes wrote:
Den 22.01.2018 15.56, skrev Meghana Madhyastha:
Replace of_find_backlight_by_node and of the code around it
with of_find_backlight
Den 23.01.2018 17.55, skrev Meghana Madhyastha:
On Tue, Jan 23, 2018 at 03:37:38PM +0100, Noralf Trønnes wrote:
Den 22.01.2018 15.56, skrev Meghana Madhyastha:
Replace of_find_backlight_by_node and of the code around it
with of_find_backlight helper to avoid repetition of code.
Signed-off
Den 23.01.2018 17.55, skrev Meghana Madhyastha:
On Tue, Jan 23, 2018 at 03:37:38PM +0100, Noralf Trønnes wrote:
Den 22.01.2018 15.56, skrev Meghana Madhyastha:
Replace of_find_backlight_by_node and of the code around it
with of_find_backlight helper to avoid repetition of code.
Signed-off
to avoid
repetition of code and also to enforce a uniform and consistent
way to enable/disable a backlight device.
Signed-off-by: Meghana Madhyastha <meghana.madhyas...@gmail.com>
---
Acked-by: Daniel Thompson <daniel.thomp...@linaro.org>
Reviewed-by: Noralf Trønnes <nor...@tronnes.org>
to avoid
repetition of code and also to enforce a uniform and consistent
way to enable/disable a backlight device.
Signed-off-by: Meghana Madhyastha
---
Acked-by: Daniel Thompson
Reviewed-by: Noralf Trønnes
Reviewed-by: Sean Paul
Just in case there's another spin... the additional tags are normally
Den 22.01.2018 15.56, skrev Meghana Madhyastha:
Replace of_find_backlight_by_node and of the code around it
with of_find_backlight helper to avoid repetition of code.
Signed-off-by: Meghana Madhyastha
---
Changes in v18:
-Fixed warnings resulting from passing
Den 22.01.2018 15.56, skrev Meghana Madhyastha:
Replace of_find_backlight_by_node and of the code around it
with of_find_backlight helper to avoid repetition of code.
Signed-off-by: Meghana Madhyastha
---
Changes in v18:
-Fixed warnings resulting from passing device_node* to
Den 22.01.2018 15.55, skrev Meghana Madhyastha:
Replace of_find_backlight_by_node and of the code around it
with of_find_backlight helper to avoid repetition of code.
Signed-off-by: Meghana Madhyastha <meghana.madhyas...@gmail.com>
---
Reviewed-by: Noralf Trønnes<nor...@tr
Den 22.01.2018 15.55, skrev Meghana Madhyastha:
Replace of_find_backlight_by_node and of the code around it
with of_find_backlight helper to avoid repetition of code.
Signed-off-by: Meghana Madhyastha
---
Reviewed-by: Noralf Trønnes
Changes in v18:
-Fixed warnings resulting from passing
viewed-by: Noralf Trønnes<nor...@tronnes.org>
drivers/gpu/drm/omapdrm/displays/panel-dpi.c | 11 ++-
1 file changed, 2 insertions(+), 9 deletions(-)
diff --git a/drivers/gpu/drm/omapdrm/displays/panel-dpi.c
b/drivers/gpu/drm/omapdrm/displays/panel-dpi.c
index e065f7e10..ac95
Den 22.01.2018 15.54, skrev Meghana Madhyastha:
Use backlight_enable/disable helpers instead of changing
the property and calling backlight_update_status for cleaner
and simpler code and also to avoid repetitions.
Signed-off-by: Meghana Madhyastha
---
Reviewed-by: Noralf Trønnes
viewed-by: Noralf Trønnes <nor...@tronnes.org>
drivers/gpu/drm/panel/panel-innolux-p079zca.c | 6 ++
drivers/gpu/drm/panel/panel-jdi-lt070me05000.c | 6 ++
drivers/gpu/drm/panel/panel-sharp-lq101r1sx01.c | 10 ++
drivers/gpu/drm/panel/panel-sharp-ls043t
Den 22.01.2018 15.54, skrev Meghana Madhyastha:
Use backlight_enable/disable helpers instead of changing
the property and calling backlight_update_status for cleaner
and simpler code and also to avoid repetitions.
Signed-off-by: Meghana Madhyastha
---
Reviewed-by: Noralf Trønnes
com>
---
Reviewed-by: Noralf Trønnes <nor...@tronnes.org>
changes in v17:
-rebase with drm-misc-next
-convert st7735r callers from tinydrm specific helpers
to new generic backlight helpers
-remove select BACKLIGHT_LCD_SUPPORT
and select BACKLIGHT_CLASS_DEVICE from
tinydrm/Kconfi
Den 19.01.2018 11.42, skrev Meghana Madhyastha:
Add of_find_backlight, a helper function which is a generic version
of tinydrm_of_find_backlight that can be used by other drivers to avoid
repetition of code and simplify things.
Signed-off-by: Meghana Madhyastha
---
Reviewed-by: Noralf
Den 19.01.2018 11.46, skrev Meghana Madhyastha:
Call devm_of_find_backlight (the devres version) instead of
of_find_backlight.
Signed-off-by: Meghana Madhyastha <meghana.madhyas...@gmail.com>
---
I already put my r-b on this one in the previous version, but now also:
Tested-by:
Den 19.01.2018 11.46, skrev Meghana Madhyastha:
Call devm_of_find_backlight (the devres version) instead of
of_find_backlight.
Signed-off-by: Meghana Madhyastha
---
I already put my r-b on this one in the previous version, but now also:
Tested-by: Noralf Trønnes
I did also test
1 - 100 of 806 matches
Mail list logo