IL PROTECTED]>
>
> Agreed.
>
> Acked-by: Masahide NAKAMURA <[EMAIL PROTECTED]>
I also agreed.
Acked-by: Noriaki TAKAMIYA <[EMAIL PROTECTED]>
--
Noriaki TAKAMIYA
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to [EMAIL PROTECTED]
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/
if dst
was NULL.
Since dst being NULL doesn't seem to be possible at this point this
patch removes the NULL check.
Signed-off-by: Adrian Bunk [EMAIL PROTECTED]
Agreed.
Acked-by: Masahide NAKAMURA [EMAIL PROTECTED]
I also agreed.
Acked-by: Noriaki TAKAMIYA [EMAIL PROTECTED
ifdef CONFIG_XFRM"
> than changing kernel config depends. Does it make sense?
>
> Please review the attached patch.
>
> --
> Masahide NAKAMURA
--
Noriaki TAKAMIYA
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to [EMAIL PROTECTED]
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/
.
--
Masahide NAKAMURA
--
Noriaki TAKAMIYA
-
To unsubscribe from this list: send the line unsubscribe linux-kernel in
the body of a message to [EMAIL PROTECTED]
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/
_get_serial_port_data() should check
> > the argument for the other drivers.
>
> I don't think it is really necessary, do you?
I see.
--
Noriaki TAKAMIYA
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to [EMAIL PROTECTED
the argument for the other drivers.
I don't think it is really necessary, do you?
I see.
--
Noriaki TAKAMIYA
-
To unsubscribe from this list: send the line unsubscribe linux-kernel in
the body of a message to [EMAIL PROTECTED]
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please
as already fixed.
>
> Great, thanks for testing. So I guess both of these patches are no
> longer necessary, right?
I think so. But I wonder if usb_get_serial_port_data() should check
the argument for the other drivers.
Regards,
--
Noriaki TAKAMIYA
-
To unsubscribe from this list: send th
both of these patches are no
longer necessary, right?
I think so. But I wonder if usb_get_serial_port_data() should check
the argument for the other drivers.
Regards,
--
Noriaki TAKAMIYA
-
To unsubscribe from this list: send the line unsubscribe linux-kernel in
the body of a message
-git snapshots that have come out
> after 2.6.21-rc4. Can you test them to verify this?
Yes, this problem was already fixed.
Thanks.
--
Noriaki TAKAMIYA
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to [EMAIL PROTECTED]
if (!serial->port[i])
+ continue;
priv = usb_get_serial_port_data(serial->port[i]);
if (priv) {
pl2303_buf_free(priv->buf);
--
1.4.4
--
Noriaki TAKAMIYA
-
To unsubscribe from this list: send
Sorry for resending.
While booting, this entry is set to NULL in destroy_serial(),
but serial->port is referred again in pl2303_shutdown() via
serial->type->shutdown.
Signed-off-by: Noriaki TAKAMIYA <[EMAIL PROTECTED]>
---
drivers/usb/serial/pl2303.c |2 ++
1 f
return dev_get_drvdata(>dev);
+ else
+ return NULL;
}
static inline void usb_set_serial_port_data (struct usb_serial_port *port,
void *data)
--
1.4.4
--
Noriaki TAKAMIYA
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of
serial->num_ports; ++i) {
+ if (!serial->port[i])
+ continue;
priv = usb_get_serial_port_data(serial->port[i]);
if (priv) {
pl2303_buf_free(priv->buf);
--
1.4.4
--
Noriaki TAKAMIYA
-
To unsubscribe from thi
Hi,
When I boot using linux-2.6.21-rc4 on ThinkPad T41 with pl2303 USB
serial device plugged in, the kernel crashes.
The reason is struct usb_serial_port is referenced without checking
whether it is NULL or not.
Regards,
--
Noriaki TAKAMIYA
-
To unsubscribe from this list: send
Sorry for resending.
Hi,
This patch fixes to skip serial->port[i] if it is set NULL.
Signed-off-by: Noriaki TAKAMIYA <[EMAIL PROTECTED]>
---
include/linux/usb/serial.h |5 -
1 files changed, 4 insertions(+), 1 deletions(-)
diff --git a/include/linux/usb/serial.h b/include/
Sorry for resending.
Hi,
This patch fixes to skip serial-port[i] if it is set NULL.
Signed-off-by: Noriaki TAKAMIYA [EMAIL PROTECTED]
---
include/linux/usb/serial.h |5 -
1 files changed, 4 insertions(+), 1 deletions(-)
diff --git a/include/linux/usb/serial.h b/include/linux/usb
Hi,
When I boot using linux-2.6.21-rc4 on ThinkPad T41 with pl2303 USB
serial device plugged in, the kernel crashes.
The reason is struct usb_serial_port is referenced without checking
whether it is NULL or not.
Regards,
--
Noriaki TAKAMIYA
-
To unsubscribe from this list: send
])
+ continue;
priv = usb_get_serial_port_data(serial-port[i]);
if (priv) {
pl2303_buf_free(priv-buf);
--
1.4.4
--
Noriaki TAKAMIYA
-
To unsubscribe from this list: send the line unsubscribe linux-kernel in
the body
Sorry for resending.
While booting, this entry is set to NULL in destroy_serial(),
but serial-port is referred again in pl2303_shutdown() via
serial-type-shutdown.
Signed-off-by: Noriaki TAKAMIYA [EMAIL PROTECTED]
---
drivers/usb/serial/pl2303.c |2 ++
1 files changed, 2 insertions
)
+ return dev_get_drvdata(port-dev);
+ else
+ return NULL;
}
static inline void usb_set_serial_port_data (struct usb_serial_port *port,
void *data)
--
1.4.4
--
Noriaki TAKAMIYA
-
To unsubscribe from this list: send the line unsubscribe linux-kernel in
the body of a message
) {
+ if (!serial-port[i])
+ continue;
priv = usb_get_serial_port_data(serial-port[i]);
if (priv) {
pl2303_buf_free(priv-buf);
--
1.4.4
--
Noriaki TAKAMIYA
-
To unsubscribe from this list: send the line unsubscribe linux-kernel
2.6.21-rc4. Can you test them to verify this?
Yes, this problem was already fixed.
Thanks.
--
Noriaki TAKAMIYA
-
To unsubscribe from this list: send the line unsubscribe linux-kernel in
the body of a message to [EMAIL PROTECTED]
More majordomo info at http://vger.kernel.org/majordomo-info.html
22 matches
Mail list logo
