Re: [PATCH v4 2/3] leds: sy7802: Add support for Silergy SY7802 flash LED controller

2024-06-17 Thread Pavel Machek
On Sun 2024-06-16 20:55:41, Markus Elfring wrote: > > The SY7802 is a current-regulated charge pump which can regulate two > > current levels for Flash and Torch modes. > > > > It is a high-current synchronous boost converter with 2-channel high > > side current sources. Each channel is able to del

Re: [ANNOUNCE] 5.10.214-rt106

2024-04-19 Thread Pavel Machek
Hi! > The tag is there in the repository: > > > https://git.kernel.org/pub/scm/linux/kernel/git/rt/linux-stable-rt.git/commit/?h=v5.10.214-rt106-rebase > > When I released 5.10.215-rt107 (and its -rebase counterpart), > 5.10.214-rt106-rebase > was no longer pointing to a commit inside that

Re: [ANNOUNCE] 5.10.214-rt106

2024-04-19 Thread Pavel Machek
Hi! > I'm pleased to announce the 5.10.214-rt106 stable release. > > This release is simply an update to the new stable 5.10.214 version and no > RT-specific changes have been performed. > > You can get this release via the git tree at: > > git://git.kernel.org/pub/scm/linux/kernel/git/rt/lin

Re: [ANNOUNCE] 5.10.213-rt105

2024-04-15 Thread Pavel Machek
Hi! > I'm pleased to announce the 5.10.213-rt105 stable release. > > This release is an update to the new stable 5.10.213 version and no extra > changes have been performed. Thanks for release. I see v5.10.214-rt106-rc1 is out there and now v5.10.215-rt107-rc1, but I don't see v5.10.214-rt106 (

Re: [PATCHv3 2/2] usb: typec: anx7688: Add driver for ANX7688 USB-C HDMI bridge

2024-04-09 Thread Pavel Machek
but having basic support > > in mainline is needed to be able to work on the other stuff > > (networking, cameras, power management). > > > > Signed-off-by: Ondrej Jirman > > Co-developed-by: Martijn Braam > > Co-developed-by: Samuel Holland > > Signed-of

Re: [PATCHv3 1/2] dt-bindings: usb: typec: anx7688: start a binding document

2024-04-08 Thread Pavel Machek
Hi! > > Add binding for anx7688 usb type-c bridge. I don't have a datasheet, > > but I did best I could. > > > > Signed-off-by: Pavel Machek > > ... > > > + cabledet-gpios: > > +maxItems: 1 > > +description: GPIO co

[PATCHv3 2/2] usb: typec: anx7688: Add driver for ANX7688 USB-C HDMI bridge

2024-04-08 Thread Pavel Machek
ainline is needed to be able to work on the other stuff (networking, cameras, power management). Signed-off-by: Ondrej Jirman Co-developed-by: Martijn Braam Co-developed-by: Samuel Holland Signed-off-by: Pavel Machek --- v2: Fix checkpatch stuff. Some cleanups, adapt to dts format in 1/2. v3:

[PATCHv3 1/2] dt-bindings: usb: typec: anx7688: start a binding document

2024-04-08 Thread Pavel Machek
Add binding for anx7688 usb type-c bridge. I don't have a datasheet, but I did best I could. Signed-off-by: Pavel Machek --- v2: implement review feedback v3: fix single character pointed by robot diff --git a/Documentation/devicetree/bindings/usb/analogix,anx7688.yaml b/Document

Re: [PATCHv2 2/2] usb: typec: anx7688: Add driver for ANX7688 USB-C HDMI bridge

2024-03-21 Thread Pavel Machek
Hi! > I'm sorry to keep you waiting. Thanks for comments. > > + struct gpio_desc *gpio_reset; > > + struct gpio_desc *gpio_cabledet; > > + > > + uint32_t src_caps[8]; > > Use u32 instead of uint32_t. Will replace globally. > > +static int anx7688_reg_read(struct anx7688 *anx7688, u8 reg

Re: [PATCHv2 2/2] usb: typec: anx7688: Add driver for ANX7688 USB-C HDMI bridge

2024-03-11 Thread Pavel Machek
here, but having basic support > in mainline is needed to be able to work on the other stuff > (networking, cameras, power management). > > Signed-off-by: Ondrej Jirman > Co-developed-by: Martijn Braam > Co-developed-by: Samuel Holland > Signed-off

Re: [PATCHv2 1/2] dt-bindings: usb: typec: anx7688: start a binding document

2024-03-11 Thread Pavel Machek
Hi! > Add binding for anx7688 usb type-c bridge. I don't have a datasheet, > but I did best I could. > > Signed-off-by: Pavel Machek Any more comments here? Automatic system told me I need to replace one character

[PATCHv2 2/2] usb: typec: anx7688: Add driver for ANX7688 USB-C HDMI bridge

2024-02-23 Thread Pavel Machek
ainline is needed to be able to work on the other stuff (networking, cameras, power management). Signed-off-by: Ondrej Jirman Co-developed-by: Martijn Braam Co-developed-by: Samuel Holland Signed-off-by: Pavel Machek --- v2: Fix checkpatch stuff. Some cleanups, adapt to dts format in 1/2. di

[PATCHv2 1/2] dt-bindings: usb: typec: anx7688: start a binding document

2024-02-23 Thread Pavel Machek
Add binding for anx7688 usb type-c bridge. I don't have a datasheet, but I did best I could. Signed-off-by: Pavel Machek --- v2: implement review feedback diff --git a/Documentation/devicetree/bindings/usb/analogix,anx7688.yaml b/Documentation/devicetree/bindings/usb/analogix,anx7688

Re: [PATCH] dt-bindings: usb: typec: anx7688: start a binding document

2024-02-21 Thread Pavel Machek
Hi! > > + reset-gpios: > > +maxItems: 1 > > blank line > > > + avdd10-supply: > > +description: > > + 1.0V power supply > > Keep description in one line and add a blank line. This code is not that > readable. > > > + i2c-supply: > > +description: > > + Power supply >

Re: [PATCH] dt-bindings: usb: typec: anx7688: start a binding document

2024-02-12 Thread Pavel Machek
Hi! > > Add binding for anx7688 usb type-c bridge. I don't have a datasheet, > > but I did best I could. > > > > Signed-off-by: Pavel Machek > > > > You miss proper diffstat which makes reviewing difficult. > Actually entire patch is corrupte

[PATCH] dt-bindings: usb: typec: anx7688: start a binding document

2024-02-09 Thread Pavel Machek
Add binding for anx7688 usb type-c bridge. I don't have a datasheet, but I did best I could. Signed-off-by: Pavel Machek diff --git a/Documentation/devicetree/bindings/usb/analogix,anx7688.yaml b/Documentation/devicetree/bindings/usb/analogix,anx7688.yaml new file mode 100644

Re: [PATCH] usb: typec: anx7688: Add driver for ANX7688 USB-C HDMI bridge

2024-02-09 Thread Pavel Machek
Hi! > > From: Ondrej Jirman > > > > This is driver for ANX7688 USB-C HDMI, with flashing and debugging > > features removed. ANX7688 is rather criticial piece on PinePhone, > > there's no display and no battery charging without it. > > Don't remove the flashing part. Some Pinephones come withou

Re: [PATCH] usb: typec: anx7688: Add driver for ANX7688 USB-C HDMI bridge

2024-02-02 Thread Pavel Machek
Hi! > > --- /dev/null > > +++ b/drivers/usb/typec/anx7688.c > > @@ -0,0 +1,1866 @@ > > +/* > > + * ANX7688 USB-C HDMI bridge/PD driver > > + * > > > > Did this pass checkpatch? I need a spdx line for new files please, > don't force us to go back and guess in the future, that isn't nice. Thank

[PATCH] usb: typec: anx7688: Add driver for ANX7688 USB-C HDMI bridge

2024-02-01 Thread Pavel Machek
ainline is needed to be able to work on the other stuff (networking, cameras, power management). Signed-off-by: Ondrej Jirman Signed-off-by: Martijn Braam Signed-off-by: Samuel Holland Signed-off-by: Pavel Machek diff --git a/drivers/usb/typec/Kconfig b/drivers/usb/typec/Kconfig index 2f

Re: [ANNOUNCE] 5.10.204-rt100

2024-01-31 Thread Pavel Machek
Hi! > > We (as in cip project), are trying to do -cip-rt releases > > once a month. Are there any plans for 5.10-rt release any time soon? > > That would help us ;-). > > I already pushed v5.10-rt-next (containing v5.10.209-rt101-rc1) to > kernel.org and kernelci should pick that up for comprehen

Re: [ANNOUNCE] 5.10.204-rt100

2024-01-30 Thread Pavel Machek
Hi! We (as in cip project), are trying to do -cip-rt releases once a month. Are there any plans for 5.10-rt release any time soon? That would help us ;-). Best regards, Pavel -- DENX Software Engineering GmbH,Managing Direct

Re: Front camera on pinephone

2024-01-24 Thread Pavel Machek
Hi! > Isn't this simply the case of picking the gc2145 bits from Megis tree? > > https://megous.com/git/linux/tree/arch/arm64/boot/dts/allwinner/sun50i-a64-pinephone.dtsi?h=orange-pi-5.10#n410 Well, that, adjusting dts bits to the new driver, testing and submitting the patch. And it looks someon

Front camera on pinephone

2024-01-16 Thread Pavel Machek
Hi! In 6.8-rc0, driver for gc2145 (front camera on pinephone) was merged, but we don't have corresponding dts entries. Does anyone have setup where they can fix it easily? [If you have hints how to set-up pinephone for kernel development, that would be welcome. Currently I have mobian with rather

Re: [PATCH v3 0/3] media: i2c: gc2145: GC2145 sensor support

2023-11-11 Thread Pavel Machek
Hi! > This serie adds support for the GalaxyCore GC2145 sensor. > Initialization is based on scripts provided by GalaxyCore, > allowing 3 fixed configurations supported for the time being. There is another version of the driver, from Ondrej Jirman, floating around. See mail "gc2145 camera driver

Re: [ANNOUNCE] 5.10.199-rt97

2023-11-11 Thread Pavel Machek
Hi! > I'm pleased to announce the 5.10.199-rt97 stable release. > > This release is an update to the new stable 5.10.199 version and no > RT-specific changes were made, with the exception of a fix to a build > failure due to upstream changes affecting only the PREEMPT_RT code. Thanks for the rel

Re: [PATCH 0/2] arm64: dts: qcom: longcheer l8910 and l9100: Enable RGB LED

2023-10-28 Thread Pavel Machek
Hi! > With the driver for ktd2026 recently applied to linux-leds[1], the LED > can be enabled on longcheer l8910 and l9100. Please make sure sysfs name is consistent with notification LED on other phones, as documented by well-known-leds.txt. Best regards,

Re: droid4 -- weird behaviour when attempting to use usb host

2023-09-27 Thread Pavel Machek
Hi! > > I'm having some fun with usb host. Good news is it works with > > externally powered hub... after a while. I get some error messages > > about inability to go host mode, but with enough patience it > > eventually does enter host mode and I see my keyboard/mouse. > > > > And usually in tha

droid4 -- weird behaviour when attempting to use usb host

2023-09-25 Thread Pavel Machek
Hi! I'm having some fun with usb host. Good news is it works with externally powered hub... after a while. I get some error messages about inability to go host mode, but with enough patience it eventually does enter host mode and I see my keyboard/mouse. And usually in that process, one of my cpu

Re: [PATCH 5.11 007/122] dmaengine: idxd: Fix clobbering of SWERR overflow bit on writeback

2021-04-20 Thread Pavel Machek
Hi! > Current code blindly writes over the SWERR and the OVERFLOW bits. Write > back the bits actually read instead so the driver avoids clobbering the > OVERFLOW bit that comes after the register is read. I believe this is incorrect. Changelog explains that we need to preserve bits in the regist

Re: [PATCH 5.10 043/103] net: tipc: Fix spelling errors in net/tipc module

2021-04-19 Thread Pavel Machek
Hi! > [ Upstream commit a79ace4b312953c5835fafb12adc3cb6878b26bd ] > > These patches fix a series of spelling errors in net/tipc module. This should not be in -stable, it just cleans up comments. Best regards, Pavel

Re: [PATCH 5.10 000/103] 5.10.32-rc1 review

2021-04-19 Thread Pavel Machek
Apr 2021 13:05:09 +. > Anything received after that time might be too late. CIP testing did not find any problems here: https://gitlab.com/cip-project/cip-testing/linux-stable-rc-ci/-/tree/linux-5.10.y Tested-by: Pavel Machek

Re: [PATCH 5.10 042/103] net/rds: Avoid potential use after free in rds_send_remove_from_sock

2021-04-19 Thread Pavel Machek
Hi! > [ Upstream commit 0c85a7e87465f2d4cbc768e245f4f45b2f299b05 ] > > In case of rs failure in rds_send_remove_from_sock(), the 'rm' resource > is freed and later under spinlock, causing potential use-after-free. > Set the free pointer to NULL to avoid undefined behavior. This patch is crazy. T

Re: [PATCH AUTOSEL 5.10 41/46] net/rds: Avoid potential use after free in rds_send_remove_from_sock

2021-04-19 Thread Pavel Machek
Hi! > From: Aditya Pakki > > [ Upstream commit 0c85a7e87465f2d4cbc768e245f4f45b2f299b05 ] > > In case of rs failure in rds_send_remove_from_sock(), the 'rm' resource > is freed and later under spinlock, causing potential use-after-free. > Set the free pointer to NULL to avoid undefined behavior

Re: [PATCH] base: power: runtime.c: Remove a unnecessary space

2021-04-18 Thread Pavel Machek
On Sun 2021-04-18 09:11:43, Sebastian Fricke wrote: > Hey Joe, > > On 18.04.2021 00:09, Joe Perches wrote: > >On Sun, 2021-04-18 at 06:08 +, Sebastian Fricke wrote: > >>Remove a redundant space to improve the quality of the comment. > > > >I think this patch is not useful. > > > >It's not redu

Re: [PATCH 4.19 00/13] 4.19.188-rc1 review

2021-04-15 Thread Pavel Machek
here: (some boards are unavailable) https://gitlab.com/cip-project/cip-testing/linux-stable-rc-ci/-/tree/linux-4.19.y Tested-by: Pavel Machek (CIP) Best regards, Pavel

Re: [PATCH 5.10 00/25] 5.10.31-rc1 review

2021-04-15 Thread Pavel Machek
here: (some boards are unavailable) https://gitlab.com/cip-project/cip-testing/linux-stable-rc-ci/-/tree/linux-4.4.y https://gitlab.com/cip-project/cip-testing/linux-stable-rc-ci/-/tree/linux-4.19.y https://gitlab.com/cip-project/cip-testing/linux-stable-rc-ci/-/tree/linux-5.10.y Tested-by: Pavel

Re: [PATCH 4.4 00/38] 4.4.267-rc1 review

2021-04-15 Thread Pavel Machek
here: https://gitlab.com/cip-project/cip-testing/linux-stable-rc-ci/-/tree/linux-4.4.y Tested-by: Pavel Machek (CIP) Best regards, Pavel -- DENX Software Engineering GmbH,

Re: [PATCH 5.10 000/188] 5.10.30-rc1 review

2021-04-13 Thread Pavel Machek
here: https://gitlab.com/cip-project/cip-testing/linux-stable-rc-ci/-/tree/linux-5.10.y Tested-by: Pavel Machek (CIP) Best regards, Pavel -- DENX Software Engineering GmbH, Managing Director: Wolfgang Denk HRB 165235 Munich, Office:

Re: [PATCH 4.19 00/66] 4.19.187-rc1 review

2021-04-13 Thread Pavel Machek
here: https://gitlab.com/cip-project/cip-testing/linux-stable-rc-ci/-/tree/linux-4.19.y Tested-by: Pavel Machek (CIP) Best regards, Pavel -- DENX Software Engineering GmbH, Managing Director: Wolfgang Denk HRB 165235 Munich, Office:

Re: [PATCH 4/4] rtc:abx80x: Enable xt digital calibration

2021-04-09 Thread Pavel Machek
Hi! > The XT digital calibration feature allows to improve the RTC accuracy, > using a Distributed Digital Calibration function. > See ch. 5.9.1 of AB08XX Series Ultra Low Power RTC IC User's Guide > https://abracon.com/realtimeclock/AB08XX-Application-Manual.pdf > > Signed-off-by: Kirill Kaprano

Re: [PATCH 5.10 06/41] net: pxa168_eth: Fix a potential data race in pxa168_eth_remove

2021-04-09 Thread Pavel Machek
't want that to run with clock being disabled and DMA being unmapped. We certainly don't want phy_disconnect() being undone by phy_connect_direct() running in the workqueue. IOW this patch is not enough to fix the bugs, and at least fix below is needed to get something reasonable. Signed

Re: [PATCHv2] gnss: motmdm: Add support for Motorola Mapphone MDM6600 modem

2021-04-07 Thread Pavel Machek
Hi! > > Could I get some comments on the gnss patch? It is fairly simple, and > > I believe it is ready for merge. > > Let's get the mux driver in shape first. Well, gnss driver is now completely independent of that in the new versions. > > Here's new version of the serdev multiplexing patch fo

Re: [PATCH 4.4 00/28] 4.4.265-rc1 review

2021-04-07 Thread Pavel Machek
here: https://gitlab.com/cip-project/cip-testing/linux-stable-rc-ci/-/tree/linux-4.4.y Tested-by: Pavel Machek (CIP) Best regards, Pavel -- DENX Software Engineering GmbH, Managing Director: Wolfgang Denk HRB 165235 Munich, Office: Kir

Re: [PATCH 4.19 00/56] 4.19.185-rc1 review

2021-04-07 Thread Pavel Machek
roblems here: (Siemens boards are unavailable) https://gitlab.com/cip-project/cip-testing/linux-stable-rc-ci/-/tree/linux-4.19.y Tested-by: Pavel Machek (CIP) Best regards, Pavel -- DENX Software Engineering GmbH, Managing Director: W

Re: [PATCH 5.10 000/126] 5.10.28-rc1 review

2021-04-07 Thread Pavel Machek
roblems here: (Siemens boards are unavailable) https://gitlab.com/cip-project/cip-testing/linux-stable-rc-ci/-/tree/linux-5.10.y Tested-by: Pavel Machek (CIP) Best regards, Pavel -- DENX Software Engineering GmbH, Managing Director: W

Re: [PATCH 5.10 079/126] drm/tegra: sor: Grab runtime PM reference across reset

2021-04-06 Thread Pavel Machek
Hi! > > > However, these functions alone don't provide any guarantees at the > > > system level. Drivers need to ensure that the only a single consumer has > > > access to the reset at the same time. In order for the SOR to be able to > > > exclusively access its reset, it must therefore ensure th

Re: [PATCH 5.10 079/126] drm/tegra: sor: Grab runtime PM reference across reset

2021-04-05 Thread Pavel Machek
sure that the SOR > power domain is not powered off by holding on to a runtime PM reference > to that power domain across the reset assert/deassert operation. Yeah, but it should not leak the PM reference in the error handling. Signed-off-by: Pavel Mach

Re: [PATCH 5.10 048/126] net: ethernet: aquantia: Handle error cleanup of start on open

2021-04-05 Thread Pavel Machek
Hi! > From: Nathan Rossi > > [ Upstream commit 8a28af7a3e85ddf358f8c41e401a33002f7a9587 ] > > The aq_nic_start function can fail in a variety of cases which leaves > the device in broken state. > > An example case where the start function fails is the > request_threaded_irq which can be interr

Re: [PATCH 5.10 047/126] ath10k: hold RCU lock when calling ieee80211_find_sta_by_ifaddr()

2021-04-05 Thread Pavel Machek
); > } The switch only takes the lock in 3 branches, but it is released unconditionally at the end. Something like this? Best regards, Pavel Signed-off-by: Pavel Machek (CIP) diff --git a/drivers/net/wireless/ath/ath10k/wmi-tl

Re: [PATCH 5.10 039/126] can: dev: move driver related infrastructure into separate subdir

2021-04-05 Thread Pavel Machek
Hi! > From: Marc Kleine-Budde > > [ Upstream commit 3e77f70e734584e0ad1038e459ed3fd2400f873a ] > > This patch moves the CAN driver related infrastructure into a separate subdir. > It will be split into more files in the coming patches. I don't think this is suitable for stable. I don't think a

Re: [PATCH 5.10 004/126] ext4: shrink race window in ext4_should_retry_alloc()

2021-04-05 Thread Pavel Machek
Hi! > From: Eric Whitney > A per filesystem percpu counter exported via sysfs is added to allow > users or developers to track the number of times the retry limit is > exceeded without resorting to debugging methods. This should provide > some insight into worst case retry behavior. This adds

Re: [PATCH] mmc: dw_mmc-k3: use the correct HiSilicon copyright

2021-03-30 Thread Pavel Machek
Hi! > On Tue, 30 Mar 2021 at 08:43, Hao Fang wrote: > > > > s/Hisilicon/HiSilicon/g. > > It should use capital S, according to > > https://www.hisilicon.com/en/terms-of-use. > > > > Signed-off-by: Hao Fang > > /* > > * Copyright (c) 2013 Linaro Ltd. > > - * Copyright (c) 2013 Hisilicon Limit

Re: [PATCH 4.4 00/33] 4.4.264-rc1 review

2021-03-29 Thread Pavel Machek
here: https://gitlab.com/cip-project/cip-testing/linux-stable-rc-ci/-/tree/linux-4.4.y https://gitlab.com/cip-project/cip-testing/linux-stable-rc-ci/-/tree/linux-4.19.y https://gitlab.com/cip-project/cip-testing/linux-stable-rc-ci/-/tree/linux-5.10.y Tested-by: Pavel Machek (CIP)

[PATCH] ASoC: audio-graph-card: Add audio mixer for Motorola mdm6600

2021-03-28 Thread Pavel Machek
ny's, bugs are probably Pavel's. Signed-off-by: Pavel Machek Co-authored-by: Tony Lindgren --- v2: Fix compile error. --- sound/soc/codecs/Kconfig| 8 + sound/soc/codecs/Makefile | 4 + sound/soc/codecs/motmdm-state.c | 177 sound/soc/codecs/motmdm.c | 6

Re: [PATCH -next] drivers: net: CONFIG_ATH9K select LEDS_CLASS

2021-03-27 Thread Pavel Machek
On Fri 2021-03-26 16:13:51, Zhang Jianhua wrote: > If CONFIG_ATH9K=y, the following errors will be seen while compiling > gpio.c > > drivers/net/wireless/ath/ath9k/gpio.o: In function `ath_deinit_leds': > gpio.c:(.text+0x604): undefined reference to `led_classdev_unregister' > gpio.c:(.text+0x604)

Re: [PATCH 17/17] auxdisplay: ht16k33: Add segment display LED support

2021-03-27 Thread Pavel Machek
Hi! > > > > > - err = ht16k33_brightness_set(priv, MAX_BRIGHTNESS); > > > > > + of_property_read_u32(node, "color", &color); > > > > > + seg->led.name = devm_kasprintf(dev, GFP_KERNEL, > > > > > + DRIVER_NAME ":%s:" LED_FUNCTION_BACKLIGHT, > > > > > +

Re: [PATCH v2 2/2] leds: leds-multi-gpio: Add multiple GPIOs LED driver

2021-03-26 Thread Pavel Machek
Hi! > Introduce a new multiple GPIOs LED driver. This LED will made of > multiple GPIOs (up to 8) and will map different brightness to different > GPIOs states which defined in dts file. > > Signed-off-by: Hermes Zhang > index ..7aef82701f86 > --- /dev/null > +++ b/drivers/leds/sim

[PATCH] remove Dan Murphy from TI from MAINTAINERS

2021-03-26 Thread Pavel Machek
Dan's address bounces, and has been bouncing for some time as he moved to other projects. I believe TI should be more careful with this, and should assign alternate contacts for their drivers. Anyway what we can do now is to remove the obsolete address. Signed-off-by: Pavel Machek ---

Re: [PATCH v3 2/2] leds: rt4505: Add support for Richtek RT4505 flash LED controller

2021-03-26 Thread Pavel Machek
Hi! > Add support for RT4505 flash LED controller. It can support up to 1.5A > flash current with hardware timeout and low input voltage protection. > > Signed-off-by: ChiYuan Huang > Acked-by: Jacek Anaszewski Thank you, applied and pushed out. Best regards,

Re: linux-next: Signed-off-by missing for commit in the leds tree

2021-03-25 Thread Pavel Machek
Hi! > Commit > > feac7685def1 ("leds: Kconfig: LEDS_CLASS is usually selected.") > > is missing a Signed-off-by from its author and committer. Thank you, fixed. Pavel -- http://www.livejournal.com/~pavelmachek signature.asc

Re: [PATCH 2/2] dt-binding: leds: Document leds-multi-gpio bindings

2021-03-25 Thread Pavel Machek
Hi! > See below. Please trim. > > + led-gpios: > > +description: Array of one or more GPIOs pins used to control the LED. > > +minItems: 1 > > +maxItems: 8 # Should be enough > > We also have a case with multi color LEDs (which is probably a more common > than multi intensity LED.

Re: [PATCH v2 1/1] leds: lgm: Improve Kconfig help

2021-03-25 Thread Pavel Machek
Hi! > Remove unnecessary Kconfig symbol LEDS_BLINK > Improve Kconfig help text to make it more useful. > > Signed-off-by: Rahul Tanwar Thanks for the patch, I applied it by hand. > +++ b/drivers/leds/blink/leds-lgm-sso.c > @@ -1,8 +1,8 @@ > // SPDX-License-Identifier: GPL-2.0 > /* > - * Inte

Re: [PATCH v2 1/2] leds: rt4505: Add support for Richtek RT4505 flash LED controller

2021-03-25 Thread Pavel Machek
On Thu 2021-03-25 18:19:03, ChiYuan Huang wrote: > Pavel Machek 於 2021年3月25日 週四 下午6:01寫道: > > > > Hi! > > > > > > > create mode 100644 drivers/leds/flash/Kconfig > > > > > create mode 100644 drivers/leds/flash/Makefile > > &g

Re: [PATCH v2 1/2] leds: rt4505: Add support for Richtek RT4505 flash LED controller

2021-03-25 Thread Pavel Machek
Hi! > > > create mode 100644 drivers/leds/flash/Kconfig > > > create mode 100644 drivers/leds/flash/Makefile > > > create mode 100644 drivers/leds/flash/leds-rt4505.c > > > > Acked-by: Jacek Anaszewski > > > Any problem with this patch? Do I need to submit it again? It won't apply on curre

Re: [PATCH 5.10 000/150] 5.10.26-rc3 review

2021-03-24 Thread Pavel Machek
here: https://gitlab.com/cip-project/cip-testing/linux-stable-rc-ci/-/tree/linux-5.10.y Tested-by: Pavel Machek (CIP) Best regards, Pavel -- DENX Software Engineering GmbH, Managing Director: Wolfgang Denk HRB 165235 Munich, Office:

Re: [PATCH 1/2] leds: leds-multi-gpio: Add multiple GPIOs LED driver

2021-03-24 Thread Pavel Machek
Hi! > > + of_property_read_string(node, "default-state", &state); > > + if (!strcmp(state, "on")) > > + multi_gpio_led_set(&priv->cdev, LED_FULL); > > + else > > + multi_gpio_led_set(&priv->cdev, LED_OFF); > > Again LED_FULL and LED_OFF... > What about default-state = "k

Re: [PATCH 1/2] leds: leds-multi-gpio: Add multiple GPIOs LED driver

2021-03-24 Thread Pavel Machek
On Wed 2021-03-24 15:56:30, Hermes Zhang wrote: > From: Hermes Zhang > > Introduce a new multiple GPIOs LED driver. This LED will made of > multiple GPIOs (up to 8) and will map different brightness to different > GPIOs states which defined in dts file. > > Signed-off-by: Hermes Zhang > --- >

Re: [PATCH 1/2] leds: leds-multi-gpio: Add multiple GPIOs LED driver

2021-03-24 Thread Pavel Machek
Hi! > > From: Hermes Zhang > > > > Introduce a new multiple GPIOs LED driver. This LED will made of > > multiple GPIOs (up to 8) and will map different brightness to different > > GPIOs states which defined in dts file. > > I wonder how many boards have such LEDs. > > Also if it wouldn't be be

Re: [PATCH v3] dt-binding: leds: Document leds-multi-gpio bindings

2021-03-24 Thread Pavel Machek
On Wed 2021-03-24 06:58:21, Alexander Dahl wrote: > Hello Hermes, > > > Hermes Zhang hat am 24.03.2021 03:48 geschrieben: > > > > > > From: Hermes Zhang > > > > Document the device tree bindings of the multiple GPIOs LED driver > > Documentation/devicetree/bindings/leds/leds-multi-gpio.yaml.

Re: [PATCH 3/6] dt-bindings: serdev: ngsm: Add binding for GNSS child node

2021-03-23 Thread Pavel Machek
On Fri 2021-03-05 11:52:38, Johan Hovold wrote: > On Fri, Mar 05, 2021 at 11:46:35AM +0100, Pavel Machek wrote: > > Hi! > > > > > > > For motorola modem case, we may have a GNSS device on channel 4. > > > > > Let's add that to the binding and

Re: [PATCH 17/17] auxdisplay: ht16k33: Add segment display LED support

2021-03-23 Thread Pavel Machek
Hi! > CC linux-leds (which I intended, but forgot to add) > > cover letter at > https://lore.kernel.org/linux-devicetree/20210322144848.1065067-1-ge...@linux-m68k.org/ Still does not tell me... riscv on fpga with 4 character display. What is this? :-). > On Tue, Mar 23, 2021 at 11:08 AM Robin

Re: [PATCH 10/11] pragma once: delete few backslashes

2021-03-23 Thread Pavel Machek
Hi! > > index e201b4b1655a..46704c341b17 100644 > > --- a/arch/arc/include/asm/cacheflush.h > > +++ b/arch/arc/include/asm/cacheflush.h > > @@ -112,6 +112,6 @@ do { > > \ > > } while (0) > > > > #define copy_from_user_page(vma,

Re: [PATCH 00/11] pragma once: treewide conversion

2021-03-23 Thread Pavel Machek
Hi! > > > (a) the traditional include guard optimization HAS NO HIDDEN SEMANTIC > > > MEANING. It's a pure optimization that doesn't actually change > > > anything else. If you don't do the optimization, absolutely nothing > > > changes. > > > > And if the parser is well written the optimisation

Re: [PATCH 4.4 00/14] 4.4.263-rc1 review

2021-03-22 Thread Pavel Machek
here: https://gitlab.com/cip-project/cip-testing/linux-stable-rc-ci/-/tree/linux-4.4.y Tested-by: Pavel Machek (CIP) Best regards, Pavel -- DENX Software Engineering GmbH,

Re: [PATCH 4.19 00/43] 4.19.183-rc1 review

2021-03-22 Thread Pavel Machek
here: https://gitlab.com/cip-project/cip-testing/linux-stable-rc-ci/-/tree/linux-4.19.y Tested-by: Pavel Machek (CIP) Best regards, Pavel -- DENX Software Engi

Re: [PATCH 5.10 000/156] 5.10.26-rc2 review

2021-03-22 Thread Pavel Machek
here: https://gitlab.com/cip-project/cip-testing/linux-stable-rc-ci/-/tree/linux-5.10.y Tested-by: Pavel Machek (CIP) Best regards, Pavel -- DENX Software Engineering GmbH, Managing Director: Wolfgang Denk HRB 165235 Munich, Office:

Re: Getting Rust to work

2021-03-21 Thread Pavel Machek
Hi! > > First try was on x86-32. It took me a whlie to figure out the problem, > > hence the diff below. > > Thanks a lot for trying it out and for the feedback! :-) Thanks for your work :-). > The supported architectures are in > Documentation/rust/arch-support.rst, so we should link to that.

Getting Rust to work

2021-03-21 Thread Pavel Machek
Hi! First try was on x86-32. It took me a whlie to figure out the problem, hence the diff below. Next I was not sure what to do with rustup. I'm not sure if advice below is good. Then I got failure because libclang (?) was not installed. I installed it. But I guess that should be mentioned in do

vDPA: explain in Kconfig what vDPA is, capitalise it consistenly

2021-03-21 Thread Pavel Machek
Not everyone knows what vDPA stands for, explain it in Kconfig. Signed-off-by: Pavel Machek (CIP) diff --git a/drivers/vdpa/Kconfig b/drivers/vdpa/Kconfig index ffd1e098bfd2..8cb37b3dd279 100644 --- a/drivers/vdpa/Kconfig +++ b/drivers/vdpa/Kconfig @@ -3,9 +3,9 @@ menuconfig VDPA

net/dev: fix information leak to userspace

2021-03-21 Thread Pavel Machek
dev_get_mac_address() does not always initialize whole structure. Unfortunately, other code copies such structure to userspace, leaking information. Fix it. Signed-off-by: Pavel Machek (CIP) Cc: sta...@kernel.org diff --git a/net/core/dev.c b/net/core/dev.c index 6c5967e80132..28283a9eb63a

vDPA: explain in Kconfig what vDPA is, capitalise it consistenly

2021-03-21 Thread Pavel Machek
Not everyone knows what vDPA stands for, explain it in Kconfig. Signed-off-by: Pavel Machek (CIP) diff --git a/drivers/vdpa/Kconfig b/drivers/vdpa/Kconfig index ffd1e098bfd2..8cb37b3dd279 100644 --- a/drivers/vdpa/Kconfig +++ b/drivers/vdpa/Kconfig @@ -3,9 +3,9 @@ menuconfig VDPA

enetc: fix bitfields, we are clearing wrong bits

2021-03-21 Thread Pavel Machek
Bitfield manipulation in enetc_mac_config() looks wrong. Fix it. Untested. Signed-off-by: Pavel Machek (CIP) diff --git a/drivers/net/ethernet/freescale/enetc/enetc_pf.c b/drivers/net/ethernet/freescale/enetc/enetc_pf.c index 224fc37a6757..b85079493933 100644 --- a/drivers/net/ethernet

Trojan horses on various lists was Re: EDAC list as Trojan Horse distribution ??

2021-03-20 Thread Pavel Machek
Hi! > > I assume this is just to install a trojan horse when opening the > > attached zip (also I assume most of you will work on linux and it > > might not be a Problem for you anyhow   ;-) . > > > >  Virus total reports a Trojan horse, but only for with 2 out of 61 > > virus scan engines (and I

Re: [PATCH 5.10 00/13] 5.10.25-rc1 review

2021-03-19 Thread Pavel Machek
here: https://gitlab.com/cip-project/cip-testing/linux-stable-rc-ci/-/tree/linux-5.10.y Tested-by: Pavel Machek (CIP) Best regards, Pavel -- DENX Software Engineering GmbH,

Re: [PATCH 4.19 0/8] 4.19.182-rc1 review

2021-03-19 Thread Pavel Machek
here: https://gitlab.com/cip-project/cip-testing/linux-stable-rc-ci/-/tree/linux-4.19.y Tested-by: Pavel Machek (CIP) Best regards, Pavel -- DENX Software Engineering GmbH, Managing Director: Wolfgang Denk HRB 165235 Munich, Office:

Re: [PATCH] ACPI: video: Add missing callback back for Sony VPCEH3U1E

2021-03-19 Thread Pavel Machek
On Fri 2021-03-19 17:44:32, Rafael J. Wysocki wrote: > On Sat, Mar 13, 2021 at 11:27 AM Pavel Machek wrote: > > > > On Fri 2021-03-12 11:24:30, chris.c...@canonical.com wrote: > > > From: Chris Chiu > > > > > > The .callback of the quirk for Sony VPCEH3U

Re: [PATCH 1/1] leds: lgm: Improve Kconfig help

2021-03-18 Thread Pavel Machek
Hi! > > > help > > > - Parallel to serial conversion, which is also called SSO > > > controller, > > > - can drive external shift register for LED outputs. > > > - This enables LED support for Serial Shift Output controller(SSO). > > > + This option enables support for LEDs connected to GPI

Re: [PATCH 5.10 041/290] net: enetc: force the RGMII speed and duplex instead of operating in inband mode

2021-03-18 Thread Pavel Machek
rving just IFMODE bits, then ors the IFMODE bits with new values. I believe this is needed: Signed-off-by: Pavel Machek (CIP) Pavel diff --git a/drivers/net/ethernet/freescale/enetc/enetc_pf.c b/drivers/net/ethernet/freescal

Re: [PATCH 1/1] leds: lgm: Improve Kconfig help

2021-03-18 Thread Pavel Machek
Hi! > Remove unnecessary Kconfig symbol LEDS_BLINK > Improve Kconfig help text to make it more useful. > > Signed-off-by: Rahul Tanwar > +++ b/drivers/leds/blink/Kconfig > @@ -1,21 +1,19 @@ > -menuconfig LEDS_BLINK > - bool "LED Blink support" > - depends on LEDS_CLASS > - hel

Re: [PATCH v3 2/2] rockchip: rk3399: Add support for FriendlyARM NanoPi R4S

2021-03-16 Thread Pavel Machek
On Tue 2021-03-16 16:34:50, Geert Uytterhoeven wrote: > Hi Tianling, > > CC Jacek, Pavel > > On Tue, Mar 16, 2021 at 4:00 PM Tianling Shen wrote: > > On 2021-03-16 02:23 Geert Uytterhoeven wrote: > > > Personally, I'm not so fond of the -%u node names, and prefer > > > -. With the former, it's

Re: [PATCH 5.10 154/290] PCI/LINK: Remove bandwidth notification

2021-03-16 Thread Pavel Machek
Hi! > From: Greg Kroah-Hartman > > From: Bjorn Helgaas Dup. > Remove the bandwidth change notifications for now. Hopefully we can add > this back when we have a better understanding of why this happens and how > we can make the messages useful instead of overwhelming. This is stable, and ev

Re: [PATCH 4.19 012/120] tcp: annotate tp->write_seq lockless reads

2021-03-16 Thread Pavel Machek
Hi! > > From: Greg Kroah-Hartman > > > > From: Eric Dumazet > > Dup. Aha, sorry, crossed mails. Still I wonder if hiding assignment into macro is good: > > --- a/net/ipv4/tcp_minisocks.c > > +++ b/net/ipv4/tcp_minisocks.c > > @@ -510,7 +510,7 @@ struct sock *tcp_create_openreq_child(co > >

Re: [PATCH 4.19 012/120] tcp: annotate tp->write_seq lockless reads

2021-03-16 Thread Pavel Machek
Hi! > From: Greg Kroah-Hartman > > From: Eric Dumazet Dup. > We need to add READ_ONCE() annotations, and also make > sure write sides use corresponding WRITE_ONCE() to avoid > store-tearing. > @@ -1037,7 +1037,7 @@ new_segment: > sk->sk_wmem_queued += copy; > sk_

Re: [PATCH 4.19 011/120] tcp: annotate tp->copied_seq lockless reads

2021-03-16 Thread Pavel Machek
Hi! > From: Greg Kroah-Hartman > > From: Eric Dumazet Two From: fields here. > [ Upstream commit 7db48e983930285b765743ebd665aecf9850582b ] > > There are few places where we fetch tp->copied_seq while > this field can change from IRQ or other cpu. And there are few such places even after th

Re: [PATCH 5.10 000/290] 5.10.24-rc1 review

2021-03-15 Thread Pavel Machek
roblems here: (Renesas boards are still unavailable) https://gitlab.com/cip-project/cip-testing/linux-stable-rc-ci/-/tree/linux-5.10.y Tested-by: Pavel Machek (CIP) Best regards,

Re: [PATCH 4.19 000/120] 4.19.181-rc1 review

2021-03-15 Thread Pavel Machek
roblems here: (Renesas boards are still unavailable) https://gitlab.com/cip-project/cip-testing/linux-stable-rc-ci/-/tree/linux-4.4.y https://gitlab.com/cip-project/cip-testing/linux-stable-rc-ci/-/tree/linux-4.19.y https://gitlab.com/cip-project/cip-testing/linux-stable-rc-ci/-/tree/linux-5.10.y Test

Re: [PATCH 4.4 00/75] 4.4.262-rc1 review

2021-03-15 Thread Pavel Machek
here: https://gitlab.com/cip-project/cip-testing/linux-stable-rc-ci/-/tree/linux-4.4.y Tested-by: Pavel Machek (CIP) Best regards, Pavel -- DENX Software Engineering GmbH, Managing Director: Wolfgang Denk HRB 165235 Munich, Office:

Re: [PATCH 2/4] leds: simatic-ipc-leds: add new driver for Siemens Industial PCs

2021-03-15 Thread Pavel Machek
Hi! > > I would also be happy to include a fix to that script. My suggestion > > would be to allow bus=platform, in which case a "devicename" will be > > required and is allowed to have any value. > > Furthermore it might be good to catch that in the led core instead of > that script. Maybe warn(

Re: [PATCH 2/4] leds: simatic-ipc-leds: add new driver for Siemens Industial PCs

2021-03-15 Thread Pavel Machek
Hi! > Maybe you explain the idea behind choosing only from that namespace? My > guess would be high-level software being able to toggle leds totally > indep of the device it runs on. Such software would have to do some > really nasty directory listing, name parsing, dealing with multiple > hits. D

Re: [PATCH v2 2/4] leds: simatic-ipc-leds: add new driver for Siemens Industial PCs

2021-03-15 Thread Pavel Machek
> > + struct led_classdev cdev; > > +}; > > + > > +static struct simatic_ipc_led simatic_ipc_leds_io[] = { > > + {1 << 15, "simatic-ipc:green:" LED_FUNCTION_STATUS "-1" }, > > + {1 << 7, "simatic-ipc:yellow:" LED_FUNCTION_STATUS "-1" }, > > + {1 << 14, "simatic-ipc:red:" L

  1   2   3   4   5   6   7   8   9   10   >