Re: [PATCH] leds: tlc591xx: fix device_node_continue.cocci warnings (fwd)

2018-12-06 Thread Pavel Machek
ssage -- > Date: Thu, 6 Dec 2018 19:48:54 +0800 > From: kbuild test robot > To: kbu...@01.org > Cc: Julia Lawall > Subject: [PATCH] leds: tlc591xx: fix device_node_continue.cocci warnings > > CC: kbuild-...@01.org > TO: Jyri Sarha > CC: Peter Ujfalusi

Re: [PATCH] Revert "exec: make de_thread() freezable (was: Re: Linux 4.20-rc4)

2018-12-06 Thread Pavel Machek
Hi! > > On 12/04, Ingo Molnar wrote: > > > > > > * Oleg Nesterov wrote: > > > > > > > we really need to narrow the (huge) scope of ->cred_guard_mutex in exec > > paths. > > > > > > > > my attempt to fix this was nacked, and nobody suggested a better > > > > solution > > so far. > > > > > > Any

Re: [PATCH] leds: 88pm860x: Use of_node_name_eq for node name comparisons

2018-12-05 Thread Pavel Machek
ive comparisons. This should not matter for any FDT based > system which this is. > > Cc: Jacek Anaszewski Acked-by: Pavel Machek -- (english) http://www.livejournal.com/~pavelmachek (cesky, pictures) http://atrey.karlin.mff.cuni.cz/~pavel/picture/horses/blog.html signature.asc Description: Digital signature

Re: [PATCH] Revert "exec: make de_thread() freezable (was: Re: Linux 4.20-rc4)

2018-12-04 Thread Pavel Machek
On Tue 2018-12-04 09:31:11, Linus Torvalds wrote: > On Tue, Dec 4, 2018 at 1:58 AM Michal Hocko wrote: > > > > AFAIU both suspend and hibernation require the system to enter quiescent > > state with no task potentially interfering with suspended devices. And > > in this particular case those

Re: [PATCH] Revert "exec: make de_thread() freezable (was: Re: Linux 4.20-rc4)

2018-12-04 Thread Pavel Machek
On Tue 2018-12-04 10:33:10, Ingo Molnar wrote: > > * Michal Hocko wrote: > > > I dunno. I do not use hibernation. I am a heavy user of the suspend > > though. I s2ram all the time. And I have certainly experienced cases > > where suspend has failed and I onlyi found out later when I've picked

Re: [PATCH] Revert "exec: make de_thread() freezable (was: Re: Linux 4.20-rc4)

2018-12-04 Thread Pavel Machek
Hi! > * Michal Hocko wrote: > > > > Do we actually have reports of this happening for people outside > > > Android? > > > > Not that I am aware of. > > I'd say outside of Android 99% of the use of hibernation is the fail-safe > that distributions offer on laptops with very low battery

Re: [PATCH] Revert "exec: make de_thread() freezable (was: Re: Linux 4.20-rc4)

2018-12-03 Thread Pavel Machek
On Mon 2018-12-03 09:06:18, Linus Torvalds wrote: > On Mon, Dec 3, 2018 at 6:17 AM Michal Hocko wrote: > > > > This argument just doesn't make any sense. Rare bugs are maybe even more > > annoying because you do not expect them to happen. > > Absolutely. > > And valid lockdep complaints are a

Re: [PATCH] Revert "exec: make de_thread() freezable (was: Re: Linux 4.20-rc4)

2018-12-03 Thread Pavel Machek
On Mon 2018-12-03 15:17:37, Michal Hocko wrote: > On Mon 03-12-18 15:14:59, Pavel Machek wrote: > > On Mon 2018-12-03 14:53:51, Michal Hocko wrote: > > > On Mon 03-12-18 14:10:06, Pavel Machek wrote: > > > > On Mon 2018-12-03 13:38:57, Michal Hocko wrote: > >

Re: [PATCH] Revert "exec: make de_thread() freezable (was: Re: Linux 4.20-rc4)

2018-12-03 Thread Pavel Machek
On Mon 2018-12-03 14:53:51, Michal Hocko wrote: > On Mon 03-12-18 14:10:06, Pavel Machek wrote: > > On Mon 2018-12-03 13:38:57, Michal Hocko wrote: > > > On Mon 03-12-18 13:31:49, Oleg Nesterov wrote: > > > > On 12/03, Michal Hocko wrote: > > > >

Re: [PATCH] Revert "exec: make de_thread() freezable (was: Re: Linux 4.20-rc4)

2018-12-03 Thread Pavel Machek
On Mon 2018-12-03 13:38:57, Michal Hocko wrote: > On Mon 03-12-18 13:31:49, Oleg Nesterov wrote: > > On 12/03, Michal Hocko wrote: > > > > > > Now, I wouldn't mind to revert this because the code is really old and > > > we haven't seen many bug reports about failing suspend yet. But what is > > >

Re: [PATCH] driver core: remove define_genpd_open_function() and define_genpd_debugfs_fops()

2018-12-03 Thread Pavel Machek
uot;, so". > Signed-off-by: Yangtao Li Otherwise looks good. Acked-by: Pavel Machek -- (english) http://www.livejournal.com/~pavelmachek (cesky, pictures) http://atrey.karlin.mff.cuni.cz/~pavel/picture/horses/blog.html signature.asc Description: Digital signature

Re: [PATCH v4 0/20] MMP platform fixes

2018-12-02 Thread Pavel Machek
Hi! > > > The patch set has been tested on an OLPC XO-1.75 laptop. > > > > Excellent! > > OOooh, I have one of those... somewhere. Time to find it :-). It is still pretty great machine, can last 8? hours on battery, sunlight readable screen, and if you meet a tiger you can hit him on the head

Re: [regression, bisected] Keyboard not responding after resuming from suspend/hibernate

2018-12-02 Thread Pavel Machek
On Fri 2018-11-30 15:44:55, Numan Demirdöğen wrote: > Sun, 28 Oct 2018 22:06:54 +0300 tarihinde > Numan Demirdöğen yazdı: > > >Thu, 25 Oct 2018 09:49:03 +0200 tarihinde > >Pavel Machek yazdı: > > > >> Hi! > >> > >&

Re: [PATCH v2 1/2] power: supply: add input voltage limit property.

2018-12-01 Thread Pavel Machek
Hi! > >> We have a problem with USBPD chargers which under certain conditions > >> can result in system overheating if the voltage provided by the USBPD > >> port is too high. While the preferred means to control this would be > >> through devicetree or ACPI settings, this is not always possible,

Re: [PATCH v4 19/20] USB: phy-mv-usb: use phy-pxa-usb

2018-12-01 Thread Pavel Machek
On Fri 2018-11-30 15:42:05, Olof Johansson wrote: > On Wed, Nov 28, 2018 at 06:53:23PM +0100, Lubomir Rintel wrote: > > Use a proper PHY driver, instead of hooks to a board support package. > > > > Signed-off-by: Lubomir Rintel > > Tested-by: Pavel Machek > &

Re: [PATCH v4 12/20] irqchip/mmp: do not use of_address_to_resource() to get mux regs

2018-12-01 Thread Pavel Machek
.75 machine, the muxes are children of the intc, not the > axi bus, and thus of_address_to_resource() won't work. We should treat > the values as mere integers as opposed to bus addresses. > > Signed-off-by: Lubomir Rintel Comment in the code and big warning in the dts description would

Re: [PATCH 04/24] dt-bindings: leds: Add function and color properties

2018-11-30 Thread Pavel Machek
Hi! > > Pavel gave following examples: > > > > eth0:green:link > > adsl0:green:link > > adsl0:red:error > > > > So we would have e.g.: > > > > associated-vl42-device = <>; > > associated-network-device = <>; > > associated-block-device = <>; > > Variable property names are kind of a pain to

Re: [PATCH RFC 4/5] gnss: sirf: add a separate supply for a lna

2018-11-30 Thread Pavel Machek
On Fri 2018-11-30 07:38:04, Andreas Kemnade wrote: > Hi, > > On Tue, 27 Nov 2018 19:03:57 +0100 > Pavel Machek wrote: > > > Hi! > > > > > Devices might have a separate lna between antenna output of the gps > > > chip and the antenna which might

Re: [PATCH v4 0/20] MMP platform fixes

2018-11-28 Thread Pavel Machek
Hi! > > this series contains contains a bunch of MMP2 platform fixes. > > > > Previous spins of the patch set were sent out over the course of last > > three months to the MMP platform maintainers, with Arnd and > > linux-arm-ker...@lists.infradead.org on copy. > > > > Unfortunatelly, MMP

Re: [RFC PATCH v4 01/13] ktask: add documentation

2018-11-27 Thread Pavel Machek
Hi! > Motivates and explains the ktask API for kernel clients. > > Signed-off-by: Daniel Jordan > --- > Documentation/core-api/index.rst | 1 + > Documentation/core-api/ktask.rst | 213 +++ > 2 files changed, 214 insertions(+) > create mode 100644

Re: [PATCH RFC 4/5] gnss: sirf: add a separate supply for a lna

2018-11-27 Thread Pavel Machek
Hi! > Devices might have a separate lna between antenna output of the gps > chip and the antenna which might have a separate supply Might have. > @@ -340,6 +349,12 @@ static int sirf_probe(struct serdev_device *serdev) > goto err_put_device; > } > > + data->lna =

Re: [PATCH] Add /proc/pid_generation

2018-11-25 Thread Pavel Machek
On Fri 2018-11-23 11:14:17, David Laight wrote: > From: Kevin Easton > > Sent: 22 November 2018 11:20 > > > > On Wed, Nov 21, 2018 at 12:14:44PM -0800, Daniel Colascione wrote: > > > This change adds a per-pid-namespace 64-bit generation number, > > > incremented on PID rollover, and exposes it

Re: [PATCH 5/5] power: supply: sc27xx: Save last battery capacity

2018-11-25 Thread Pavel Machek
Hi! > Our charger manager can optimize the battery capacity periodically, so > we can save last battery capacity into registers. Then next system > power-on, we can read the last saved battery capacity as the initial > battery capacity, which can make the battery capacity more accurate. > >

Re: [PATCH 3/5] power: supply: sc27xx: Add fuel gauge low voltage alarm

2018-11-25 Thread Pavel Machek
On Wed 2018-11-14 17:07:06, Baolin Wang wrote: > From: Yuanjiang Yu > > Add low voltage alarm support to make sure the battery capacity > more accurate in lower voltage stage. > > Signed-off-by: Yuanjiang Yu > Signed-off-by: Baolin Wang Should we also shut down the system when that happens,

Re: [PATCH v4] staging: olpc_dcon: olpc_dcon_xo_1.c: Switch to the gpio descriptor interface

2018-11-25 Thread Pavel Machek
Hi! > Use the gpiod interface instead of the deprecated old non-descriptor > interface in olpc_dcon_xo_1.c. > > Signed-off-by: Nishad Kamdar You may want to cc: lkund...@v3.sk, he was doing great work on OLPC lately... Best regards,

Re: [PATCH 00/16] x86/microcode/AMD: Improve container verification

2018-11-25 Thread Pavel Machek
On Wed 2018-11-07 18:02:02, Borislav Petkov wrote: > From: Borislav Petkov > > Hi all, > > this is work which got started by Maciej a while ago. I have finally had > the time to redo all the ideas properly, split it in self-contained, > logical chunks and test it. > > Reveiew and comments are

Re: [PATCH 1/3] x86: add support for Huawei WMI hotkeys.

2018-11-25 Thread Pavel Machek
On Wed 2018-10-31 15:19:36, Ayman Bagabas wrote: > This driver adds support for missing hotkeys on some Huawei laptops. > Currently, only Huawei Matebook X Pro is supported. The driver > recognizes the following keys: brightness keys, micmute, wlan, and > Huawei special key. The brightness keys

Re: [PATCH v3 3/3] ALSA: hda: add support for Huawei WMI micmute LED

2018-11-24 Thread Pavel Machek
Hi! > > > > > > > > > You have general-purpose LED, yet you are treating it as > > > > > > > > > "something > > > > > > > > > special". That means ugly code (quoted above) and lack of > > > > > > > > > flexibility. > > > > > > > > > > > > > > > I'd prefer this to be normal LED and "mic muted"

Re: [PATCH v3 3/3] ALSA: hda: add support for Huawei WMI micmute LED

2018-11-23 Thread Pavel Machek
place in LED subsystem... or maybe thinkpad x60 is wrong machine to test on. Anyway, it looks less ugly than current code in alsa. We should not really be using mixer settings to turn LED on and off. Plus, it works in similar way triggers and LEDs "usually" do, and has all the flexibility.

Re: [PATCH v2 1/2] power: supply: add input voltage limit property.

2018-11-23 Thread Pavel Machek
Hi! > We have a problem with USBPD chargers which under certain conditions > can result in system overheating if the voltage provided by the USBPD > port is too high. While the preferred means to control this would be > through devicetree or ACPI settings, this is not always possible, and > we

Re: [PATCH v3 3/3] ALSA: hda: add support for Huawei WMI micmute LED

2018-11-23 Thread Pavel Machek
HI! > > > > > > > You have general-purpose LED, yet you are treating it as > > > > > > > "something > > > > > > > special". That means ugly code (quoted above) and lack of > > > > > > > flexibility. > > > > > > > > > > > > > > For example, if my notebook lacks HDD LED, I can use scrollock > >

Re: [PATCH v3 3/3] ALSA: hda: add support for Huawei WMI micmute LED

2018-11-22 Thread Pavel Machek
On Thu 2018-11-22 13:36:43, Andy Shevchenko wrote: > On Tue, Nov 20, 2018 at 2:19 PM Takashi Iwai wrote: > > > > On Tue, 20 Nov 2018 12:51:59 +0100, > > Pavel Machek wrote: > > > > > > Hi! > > > > > > > > You have general-purpo

Re: [PATCH v3 3/3] ALSA: hda: add support for Huawei WMI micmute LED

2018-11-22 Thread Pavel Machek
On Tue 2018-11-20 13:19:26, Takashi Iwai wrote: > On Tue, 20 Nov 2018 12:51:59 +0100, > Pavel Machek wrote: > > > > Hi! > > > > > > You have general-purpose LED, yet you are treating it as "something > > > > special". T

Re: [PATCH v2] Document /proc/pid PID reuse behavior

2018-11-20 Thread Pavel Machek
On Tue 2018-11-20 09:49:50, Jonathan Corbet wrote: > On Tue, 20 Nov 2018 10:05:21 +0100 > Vlastimil Babka wrote: > > > Why can't the documentation describe the current implementation, and > > change in the future if the implementation changes? I doubt somebody > > would ever rely on the pid

Re: [PATCH v3 3/3] ALSA: hda: add support for Huawei WMI micmute LED

2018-11-20 Thread Pavel Machek
Hi! > > You have general-purpose LED, yet you are treating it as "something > > special". That means ugly code (quoted above) and lack of flexibility. > > > > For example, if my notebook lacks HDD LED, I can use scrollock LED for > > that instead. Or, in reverse way, maybe "mic mute" LED is not

Re: [PATCH v3 3/3] ALSA: hda: add support for Huawei WMI micmute LED

2018-11-20 Thread Pavel Machek
On Tue 2018-11-20 10:23:25, Takashi Iwai wrote: > On Tue, 20 Nov 2018 10:10:39 +0100, > Pavel Machek wrote: > > > > On Tue 2018-11-20 08:07:09, Takashi Iwai wrote: > > > On Tue, 20 Nov 2018 00:57:13 +0100, > > > Pavel Machek wrote: > > > >

Re: [PATCH] ACPI / battery: Fix reporting "Not charging" when capacity is 100%

2018-11-20 Thread Pavel Machek
Hi! > > > Anyways this ultimately is Rafael's call. If Rafael is ok with this > > > patch then I would like to see Pavel's comment addressed and otherwise > > > it is fine with me. > > > > > If we can get to an agreement on this I'll send a v2 without division. > > > > Note that we will still

Re: [PATCH v3 3/3] ALSA: hda: add support for Huawei WMI micmute LED

2018-11-20 Thread Pavel Machek
On Tue 2018-11-20 08:07:09, Takashi Iwai wrote: > On Tue, 20 Nov 2018 00:57:13 +0100, > Pavel Machek wrote: > > > > > +#if IS_ENABLED(CONFIG_HUAWEI_LAPTOP) > > > +#include > > > + > > > +static int (*huawei_wmi_micmute_led_set_func)(b

Re: UBSAN: Undefined behaviour in mm/page_alloc.c

2018-11-19 Thread Pavel Machek
Hi1 > --- a/mm/page_alloc.c > +++ b/mm/page_alloc.c > @@ -4364,6 +4353,15 @@ __alloc_pages_nodemask(gfp_t gfp_mask, unsigned > int order, int preferred_nid, > gfp_t alloc_mask; /* The gfp_t that was actually used for > allocation */ > struct

Re: [PATCH v3 3/3] ALSA: hda: add support for Huawei WMI micmute LED

2018-11-19 Thread Pavel Machek
Hi! > Some of Huawei laptops come with a LED in the micmute key. This patch > enables and disable this LED accordingly. > > Signed-off-by: Ayman Bagabas NAK. We already have a LED subsystem. > +#if IS_ENABLED(CONFIG_HUAWEI_LAPTOP) > +#include > + > +static int

Re: [PATCH v1 7/8] PM / Hibernate: use pfn_to_online_page()

2018-11-19 Thread Pavel Machek
On Mon 2018-11-19 11:16:15, David Hildenbrand wrote: > Let's use pfn_to_online_page() instead of pfn_to_page() when checking > for saveable pages to not save/restore offline memory sections. > > Cc: "Rafael J. Wysocki" Acked-by: Pavel Machek -- (english) http

Re: [PATCHv4 5/6] drm/omap: add framedone interrupt support

2018-11-19 Thread Pavel Machek
Hi! > > > @@ -217,6 +239,9 @@ static irqreturn_t omap_irq_handler(int irq, void > > > *arg) > > > > > > if (irqstatus & > > > priv->dispc_ops->mgr_get_sync_lost_irq(priv->dispc, channel)) > > > omap_crtc_error_irq(crtc, irqstatus); > > > + > > > + if

Re: [PATCH] slab.h: Avoid using & for logical and of booleans

2018-11-19 Thread Pavel Machek
On Mon 2018-11-05 12:40:00, Bart Van Assche wrote: > This patch suppresses the following sparse warning: > > ./include/linux/slab.h:332:43: warning: dubious: x & !y > > Fixes: 1291523f2c1d ("mm, slab/slub: introduce kmalloc-reclaimable caches") > Cc: Vlastimil Babka > Cc: Mel Gorman > Cc:

Re: [PATCH v2] Document /proc/pid PID reuse behavior

2018-11-19 Thread Pavel Machek
On Mon 2018-11-05 13:22:05, Daniel Colascione wrote: > State explicitly that holding a /proc/pid file descriptor open does > not reserve the PID. Also note that in the event of PID reuse, these > open file descriptors refer to the old, now-dead process, and not the > new one that happens to be

Re: [PATCH 06/15] Platform: OLPC: Add XO-1.75 EC driver

2018-11-19 Thread Pavel Machek
Hi! > > > +#include > > > +#include > > > +#include > > > +#include > > > +#include > > > +#include > > > +#include > > > +#include > > > +#include > > > +#include > > > +#include > > > +#include > > > +#include > > > +#include > > > > Easy to maintain when it's sorted. No / it

Re: [RFC PATCH v8 1/4] media: Media Device Allocator API

2018-11-19 Thread Pavel Machek
On Thu 2018-11-01 18:31:30, sh...@kernel.org wrote: > From: Shuah Khan > > Media Device Allocator API to allows multiple drivers share a media device. > Using this API, drivers can allocate a media device with the shared struct > device as the key. Once the media device is allocated by a driver,

Re: [PATCH 02/24] leds: core: Add support for composing LED class device names

2018-11-13 Thread Pavel Machek
On Tue 2018-11-13 22:38:49, Geert Uytterhoeven wrote: > Hi Pavel, > > On Mon, Nov 12, 2018 at 11:07 PM Pavel Machek wrote: > > Not really, I'm afraid. Hard drives have no red LEDs on them (and the > > LED would not be visible, anyway) so the "device" symlink in su

Re: [RFC PATCH] Implement /proc/pid/kill

2018-11-12 Thread Pavel Machek
Hi! > Add a simple proc-based kill interface. To use /proc/pid/kill, just > write the signal number in base-10 ASCII to the kill file of the > process to be killed: for example, 'echo 9 > /proc/$$/kill'. > > Semantically, /proc/pid/kill works like kill(2), except that the > process ID comes from

LEDs on USB keyboards was Re: [PATCH 02/24] leds: core: Add support for composing LED class device names

2018-11-12 Thread Pavel Machek
Hi! > > Couldn't we have here multiple variants that would then be chosen based > > on device tree definition? > > It needs to be subsystem specific or something. > What you say make sense for things based on device > tree. > > The problem hit me on an Intel laptop with several > USB keyboards.

Re: [PATCH 02/24] leds: core: Add support for composing LED class device names

2018-11-12 Thread Pavel Machek
On Mon 2018-11-12 21:11:32, Jacek Anaszewski wrote: > On 11/12/2018 08:05 PM, Pavel Machek wrote: > > Hi! > > > >>>>> My system looks like this: > >>>>> > >>>>> input16::capslocktpacpi::bay_activetpacpi::standby

Re: [PATCH 02/24] leds: core: Add support for composing LED class device names

2018-11-12 Thread Pavel Machek
Hi! > >>> My system looks like this: > >>> > >>> input16::capslocktpacpi::bay_activetpacpi::standby > >>> input16::numlock tpacpi::dock_active tpacpi::thinklight > >>> input16::scrolllock tpacpi::dock_batt tpacpi::thinkvantage > >>> input5::capslock

Re: [PATCH 02/24] leds: core: Add support for composing LED class device names

2018-11-12 Thread Pavel Machek
Hi! > >> It's overcomplicating the naming again. In every case you can tweak > >> the function name to eth0_link, eth1_link etc. > > > > Well, but in such case it would be good to keep existing scheme. > > > > My system looks like this: > > > > input16::capslocktpacpi::bay_active

Re: [PATCH v2] exec: make de_thread() freezable

2018-11-12 Thread Pavel Machek
read_group_leader(tsk))" branch. >(reported by Oleg) > > Suggested-by: Oleg Nesterov > Signed-off-by: Chanho Min Acked-by: Pavel Machek -- (english) http://www.livejournal.com/~pavelmachek (cesky, pictures) http://atrey.karlin.mff.cuni.cz/~pavel/picture/horses/blog.html signature.asc Description: Digital signature

Re: [PATCH 03/24] leds: dt-bindings: Add LED_FUNCTION definitions

2018-11-11 Thread Pavel Machek
Hi! > >> +#define LED_FUNCTION_BACKLIGHT "backlight" > >> +#define LED_FUNCTION_BACKLIGHT_CLUSTER "backlight_cluster" > > > > Sounds like one of backlight and backlight_cluster should be deprecated? > > I think so. Agreed. > >> +#define LED_FUNCTION_DEBUG "debug" > >> +#define

Re: [PATCH 02/24] leds: core: Add support for composing LED class device names

2018-11-11 Thread Pavel Machek
Hi! > >> diff --git a/Documentation/leds/leds-class.txt > >> b/Documentation/leds/leds-class.txt > >> index 836cb16..e9009c4 100644 > >> --- a/Documentation/leds/leds-class.txt > >> +++ b/Documentation/leds/leds-class.txt > >> @@ -43,7 +43,7 @@ LED Device Naming > >> > >> Is currently of the

Re: [PATCH 06/24] leds: sc27xx-blt: Use led_compose_name()

2018-11-11 Thread Pavel Machek
On Tue 2018-11-06 23:07:14, Jacek Anaszewski wrote: > Switch to using generic LED support for composing LED class > device name. > > Signed-off-by: Jacek Anaszewski > Cc: Xiaotong Lu > Cc: Baolin Wang Acked-by: Pavel Machek -- (english) http://www.livejournal.com/~

Re: [driver-core PATCH v5 5/9] driver core: Establish clear order of operations for deferred probe and remove

2018-11-11 Thread Pavel Machek
Hi! > > One change I made in addition is I replaced the use of "bool X:1" to define > > the bitfield to a "u8 X:1" setup in order to resolve some checkpatch > > warnings. > > Please use "bool X:1" instead of "u8 X:1". I think it was a bad idea to make > checkpatch complain about "bool X:1" since

Re: [PATCH 12/24] leds: lm3692x: Use led_compose_name()

2018-11-11 Thread Pavel Machek
On Tue 2018-11-06 23:07:20, Jacek Anaszewski wrote: > Switch to using generic LED support for composing LED class > device name. > > Signed-off-by: Jacek Anaszewski > Cc: Dan Murphy Acked-by: Pavel Machek -- (english) http://www.livejournal.com/~pavelmachek (cesky,

Re: [PATCH 05/24] dt-bindings: sc27xx-blt: Add function and color properties

2018-11-11 Thread Pavel Machek
On Tue 2018-11-06 23:07:13, Jacek Anaszewski wrote: > Refer to new "function" and "color" properties and mark "label" > as deprecated. > > Signed-off-by: Jacek Anaszewski > Cc: Xiaotong Lu > Cc: Baolin Wang Don't you want to keep both color and label? New dts on old kernel should still

Re: [PATCH] ACPI / battery: Fix reporting "Not charging" when capacity is 100%

2018-11-11 Thread Pavel Machek
On Sun 2018-11-11 12:57:12, Hans de Goede wrote: > Hi, > > On 11/7/18 5:53 AM, Daniel Drake wrote: > >On Mon, Nov 5, 2018 at 1:19 AM Pavel Machek wrote: > >>Plus, I don't think "100% charge" is right test for "battery full". At > >

Re: [PATCH 02/24] leds: core: Add support for composing LED class device names

2018-11-11 Thread Pavel Machek
Hi! > Add public led_compose_name() API for composing LED class device > name basing on fwnode_handle data. The function composes device name > according to either a new pattern or the legacy > pattern. The decision on using the > particular pattern is made basing on whether fwnode contains new

Re: [PATCH 03/24] leds: dt-bindings: Add LED_FUNCTION definitions

2018-11-11 Thread Pavel Machek
Hi! > Add common LED function definitions for use in Device Tree. > The function names were extracted from existing dts files > after eliminating oddities. Thanks for doing this. > diff --git a/include/dt-bindings/leds/functions.h > b/include/dt-bindings/leds/functions.h > new file mode 100644

Re: [PATCH 01/24] leds: class: Improve LED and LED flash class registration API

2018-11-11 Thread Pavel Machek
f the struct led_init_data. > > Signed-off-by: Jacek Anaszewski > Cc: Baolin Wang > Cc: Daniel Mack > Cc: Dan Murphy > Cc: Linus Walleij > Cc: Oleh Kravchenko > Cc: Sakari Ailus > Cc: Simon Shields > Cc: Xiaotong Lu With Baolin's c

Re: [PATCH v5 04/27] x86/fpu/xstate: Add XSAVES system states for shadow stack

2018-11-11 Thread Pavel Machek
> > > > +/* > > > > + * State component 12 is Control flow Enforcement kernel states > > > > + */ > > > > +struct cet_kernel_state { > > > > + u64 kernel_ssp; /* kernel shadow stack */ > > > > + u64 pl1_ssp;/* ring-1 shadow stack */ > > > > + u64 pl2_ssp;/* ring-2 shadow

Re: [PATCH] ACPI / battery: Fix reporting "Not charging" when capacity is 100%

2018-11-11 Thread Pavel Machek
Hi! > > >* was plugged in and the device thus did not start a new charge > > > cycle. > > >*/ > > > if ((battery_ac_is_broken || power_supply_is_system_supplied()) && > > > - battery->rate_now == 0) > > > + battery->rate_now == 0) { > > > + if

Re: [PATCH v5 04/27] x86/fpu/xstate: Add XSAVES system states for shadow stack

2018-11-11 Thread Pavel Machek
> > Just write "privilege level" everywhere - not "ring". > > > > Btw, do you see how the type and the name of all those other fields in > > that file are tabulated? Except yours... > > I will fix it. Don't. It is not broken. -- (english) http://www.livejournal.com/~pavelmachek (cesky,

Re: [PATCH] PM / QoS: Change to use DEFINE_SHOW_ATTRIBUTE macro

2018-11-11 Thread Pavel Machek
On Tue 2018-11-06 09:38:06, Yangtao Li wrote: > Use DEFINE_SHOW_ATTRIBUTE macro to simplify the code. > > Signed-off-by: Yangtao Li Acked-by: Pavel Machek -- (english) http://www.livejournal.com/~pavelmachek (cesky, pictures) http://atrey.karlin.mff.cuni.cz/~pavel/picture/horses/

Re: [PATCH] ARM: OMAP1: ams-delta: Provide GPIO lookup table for LED device

2018-11-11 Thread Pavel Machek
On Tue 2018-11-06 00:23:49, Janusz Krzysztofik wrote: > Global GPIO numbers no longer have to be passed to leds-gpio driver, > replace their assignment with a lookup table. > > Signed-off-by: Janusz Krzysztofik Acked-by: Pavel Machek -- (english) http://www.livejournal.com/

Re: [PATCH v3 1/3] mfd: upboard: Add UP2 platform controller driver

2018-11-11 Thread Pavel Machek
Hi! > +static void __reg_io_start(const struct upboard_ddata * const ddata) > +{ > + /* > + * CLEAR signal must be pulsed low before any register access. > + * This resets internal counters in the controller and marks > + * the start of a new register access. > + */ > +

Re: [PATCH v14 1/2] leds: core: Introduce LED pattern trigger

2018-11-09 Thread Pavel Machek
On Wed 2018-11-07 11:23:52, Baolin Wang wrote: > Hi Geert, > > On 6 November 2018 at 23:57, Geert Uytterhoeven wrote: > > Hi Baolin, > > > > On Tue, Oct 2, 2018 at 6:39 PM Baolin Wang wrote: > >> This patch adds one new led trigger that LED device can configure > >> the software or hardware

Re: [PATCH 4.18 30/34] x86, hibernate: Fix nosave_regions setup for hibernation

2018-11-09 Thread Pavel Machek
0.00] BIOS-e820: [mem 0x0001-0x00041edf] usable > > Fix this problem by changing pfn limit from max_low_pfn to max_pfn. > This fix does not impact 64bit system because on 64bit max_low_pfn > is the same as max_pfn. > > Signed-off-by: Zhimin Gu > Ac

Re: [PATCH 3.18 053/144] ARM: OMAP2+: Fix n900 board name for legacy user space

2018-11-08 Thread Pavel Machek
me in > /proc/cpuinfo to work properly for the Hardware entry. > > For other boards this should not be an issues and they > can use the generic Hardware entry. > > Let's fix the issue by adding a custom DT_MACHINE_START > for n900. > > Tested-by: Pali Rohár > Ack

v4.20-rc1: list_del corruption on thinkpad x220

2018-11-08 Thread Pavel Machek
Hi! My machine locked hard (thinkpad x220). After reboot, I found this in syslog: Sounds like memory corruption..? Does not sound like easy to debug. ...otoh, it still looks like an addres, so maybe it is "just" race in GPU drivers? Any ideas?

Re: [PATCH trivial] Documentation: ABI: led-trigger-pattern: Fix typos

2018-11-07 Thread Pavel Machek
On Wed 2018-11-07 14:45:24, Geert Uytterhoeven wrote: > - Spelling s/brigntess/brightness/, > - Double "use". > > Signed-off-by: Geert Uytterhoeven Acked-by: Pavel Machek -- (english) http://www.livejournal.com/~pavelmachek (cesky, pictures) http://atrey.kar

Re: [PATCH 1/2] dt-bindings: himax,hx8837: add HiMax HX8837 bindings

2018-11-05 Thread Pavel Machek
the description of connections to the LCD > controller and the panel. Maybe it would be a good idea to plug in it > betweend the two in a manner described in "between" > . Acked-by: Pavel Machek Pavel -- (e

Re: [PATCH 05/14] ARM: ttc_dkb: add an instance of pxa-usb-phy

2018-11-05 Thread Pavel Machek
On Wed 2018-08-22 22:42:58, Lubomir Rintel wrote: > This will replace the ttc_usb_pdata.phy_{de,}init()> ">" -> "."? > Signed-off-by: Lubomir Rintel Acked-by: Pavel Machek > arch/arm/mach-mmp/ttc_dkb.c | 4 > 1 file changed, 4 insertions(+) >

Re: [PATCH] ACPI / battery: Fix reporting "Not charging" when capacity is 100%

2018-11-05 Thread Pavel Machek
On Fri 2018-11-02 23:57:32, João Paulo Rechi Vita wrote: > Commit 19fffc8450d4378580a8f019b195c4617083176f fixed reporting > "Discharging" on some machines when AC was connected but the battery was > not charging. But now on these machines the battery status is reported > as "Not charging" even

Re: [PATCH 07/11] [media] marvell-ccic: drop unused stuff

2018-11-05 Thread Pavel Machek
On Mon 2018-11-05 08:30:50, Lubomir Rintel wrote: > Remove structure members and headers that are not actually used. Saves > us from some noise in subsequent cleanup commits. > > Signed-off-by: Lubomir Rintel Acked-by: Pavel Machek -- (english) http://www.livejournal.com/~pavelm

Re: [PATCH 15/15] power: supply: olpc_battery: Add OLPC XO 1.75 support

2018-11-04 Thread Pavel Machek
On Wed 2018-10-10 19:23:00, Lubomir Rintel wrote: > The battery and the protocol are essentially the same as OLPC XO 1.5, > but the responses from the EC are LSB first. > > Signed-off-by: Lubomir Rintel Acked-by: Pavel Machek -- (english) http://www.livejournal.com/~pavelm

Re: [PATCH 14/15] power: supply: olpc_battery: Avoid using platform_info

2018-11-04 Thread Pavel Machek
On Wed 2018-10-10 19:22:59, Lubomir Rintel wrote: > This wouldn't work on the DT-based ARM platform. Let's read the EC version > directly from the EC driver instead. > > This makes the driver no longer x86 specific. > > Signed-off-by: Lubomir Rintel Acked-by: Pavel Machek

Re: [PATCH 13/15] power: supply: olpc_battery: Move priv data to a struct

2018-11-04 Thread Pavel Machek
Hi! > The global variables for private data are not too nice. I'd like some > more, and that would clutter the global name space even further. > > Signed-off-by: Lubomir Rintel > Reviewed-by: Andy Shevchenko Ok... > - olpc_bat = power_supply_register(>dev, _bat_desc, NULL); > - if

Re: [PATCH 12/15] power: supply: olpc_battery: Use DT to get battery version

2018-11-04 Thread Pavel Machek
On Wed 2018-10-10 19:22:57, Lubomir Rintel wrote: > Avoid using the x86 OLPC platform specific call to get the board > version. It won't work on FDT-based ARM MMP2 platform. > > Signed-off-by: Lubomir Rintel > Reviewed-by: Andy Shevchenko Acked-by: Pavel Machek AFAICT, this sh

Re: [PATCH 11/15] x86, olpc: Use a correct version when making up a battery node

2018-11-04 Thread Pavel Machek
On Wed 2018-10-10 19:22:56, Lubomir Rintel wrote: > The XO-1 and XO-1.5 batteries apparently differ in an ability to report > ambient temperature. Add a different compatible string to the 1.5 > battery. > > Signed-off-by: Lubomir Rintel Acked-by: Pavel Machek > --- > a

Re: [PATCH 10/15] dt-bindings: olpc_battery: Add XO-1.5 battery

2018-11-04 Thread Pavel Machek
On Wed 2018-10-10 19:22:55, Lubomir Rintel wrote: > The XO-1 and XO-1.5 batteries apparently differ in an ability to report > ambient temperature. > > Signed-off-by: Lubomir Rintel > Reviewed-by: Rob Herring Acked-by: Pavel Machek Rob, can you

Re: [PATCH 08/15] Platform: OLPC: Move EC-specific functionality out from x86

2018-11-04 Thread Pavel Machek
On Wed 2018-10-10 19:22:53, Lubomir Rintel wrote: > It is actually plaform independent. Move it to the olpc-ec driver from > the X86 OLPC platform, so that it could be used by the ARM based laptops > too. > > Signed-off-by: Lubomir Rintel Acked-by: Pavel Machek --

Re: [PATCH 07/15] Platform: OLPC: Avoid a warning if the EC didn't register yet

2018-11-04 Thread Pavel Machek
On Wed 2018-10-10 19:22:52, Lubomir Rintel wrote: > Just return ENODEV, so that whoever attempted to use the EC call can > defer their work. > > Signed-off-by: Lubomir Rintel Acked-by: Pavel Machek > --- > drivers/platform/olpc/olpc-ec.c | 7 +-- > 1 file change

Re: [PATCH 05/15] Platform: OLPC: Move OLPC config symbol out of x86 tree

2018-11-04 Thread Pavel Machek
On Wed 2018-10-10 19:22:50, Lubomir Rintel wrote: > There are ARM OLPC machines that use mostly the same drivers, including > EC infrastructure, DCON and Battery. > > While at that, fix Kconfig to allow building this as a module. > > Signed-off-by: Lubomir Rintel Acke

Re: [PATCH 04/15] Platform: OLPC: Remove an unused include

2018-11-04 Thread Pavel Machek
On Wed 2018-10-10 19:22:49, Lubomir Rintel wrote: > Also, the header is x86 specific, while there are non-x86 OLPC machines. > > Signed-off-by: Lubomir Rintel Acked-by: Pavel Machek > --- > drivers/platform/olpc/olpc-ec.c | 1 - > 1 file changed, 1 deletion(-) > &

Re: [PATCH 03/15] dt-bindings: olpc,xo1.75-ec: Add OLPC XO-1.75 EC bindings

2018-11-04 Thread Pavel Machek
nd when does it wish to respond with a command (the > cmd-gpio property). > > Signed-off-by: Lubomir Rintel Acked-by: Pavel Machek > --- > .../bindings/misc/olpc,xo1.75-ec.txt | 24 +++ > 1 file changed, 24 insertions(+) > create mode 100644 Docum

Re: [PATCH 11/11] spi: pxa2xx: Deal with the leftover garbage in TXFIFO

2018-11-04 Thread Pavel Machek
the firmware should do this instead. > > Other than that, there's not much we can do other than complain loudly > until the garbage gets drained and discard the actual data... For the > OLPC EC this will work just fine and pushing more data to TXFIFO would > break further transactions

Re: [PATCH 10/11] spi: pxa2xx: Add ready signal

2018-11-04 Thread Pavel Machek
Rintel Acked-by: Pavel Machek > --- > drivers/spi/spi-pxa2xx.c | 12 > drivers/spi/spi-pxa2xx.h | 3 +++ > 2 files changed, 15 insertions(+) > > diff --git a/drivers/spi/spi-pxa2xx.c b/drivers/spi/spi-pxa2xx.c > index 3848842d68fd..a3b4b12c1077 100644 > --- a/d

Re: [PATCH 09/11] dt-bindings: spi/spi-pxa2xx: Add ready GPIO signal

2018-11-04 Thread Pavel Machek
e, that happens to be a SPI master. > > Signed-off-by: Lubomir Rintel Acked-by: Pavel Machek > --- > Documentation/devicetree/bindings/spi/spi-pxa2xx.txt | 2 ++ > 1 file changed, 2 insertions(+) > > diff --git a/Documentation/devicetree/bindings/spi/spi-pxa2xx.txt > b/Do

Re: [PATCH 08/11] spi: pxa2xx: Add slave mode support

2018-11-04 Thread Pavel Machek
On Wed 2018-10-10 19:09:33, Lubomir Rintel wrote: > Tested on an OLPC XO-1.75 machine, where the Embedded Controller happens > to be a SPI master. > > Signed-off-by: Lubomir Rintel Acked-by: Pavel Machek -- (english) http://www.livejournal.com/~pavelmachek (cesky, pic

Re: [PATCH 07/11] spi: Deal with slaves that return from transfer_one() unfinished

2018-11-04 Thread Pavel Machek
nsfer to finish with wait_for_completion_timeout(). For slaves, we > don't want the transaction to time out as it can complete in a long time > in future. Use wait_for_completion_interruptible() instead. > > Signed-off-by: Lubomir Rintel Acked-by: Pavel Machek > @@ -993,6 +993,44 @@

Re: [PATCH 06/11] dt-bindings: spi/spi-pxa2xx: Add spi-slave property

2018-11-04 Thread Pavel Machek
On Wed 2018-10-10 19:09:31, Lubomir Rintel wrote: > This is used to indicate that the chip attached to this controller is a SPI > master. > > Signed-off-by: Lubomir Rintel > Reviewed-by: Rob Herring Acked-by: Pavel Machek Rob

Re: [PATCH 05/11] DT: marvell,mmp2: Add SSP1 and SSP3

2018-11-04 Thread Pavel Machek
ubomir Rintel Acked-by: Pavel Machek -- (english) http://www.livejournal.com/~pavelmachek (cesky, pictures) http://atrey.karlin.mff.cuni.cz/~pavel/picture/horses/blog.html signature.asc Description: Digital signature

Re: [PATCH 04/11] spi: pxa2xx: Add devicetree support

2018-11-04 Thread Pavel Machek
On Wed 2018-10-10 19:09:29, Lubomir Rintel wrote: > The MMP2 platform, that uses device tree, has this controller. Let's add > devicetree alongside platform & PCI. > > Signed-off-by: Lubomir Rintel Acked-by: Pavel Machek -- (english) http://www.livejournal.com/~pavelmachek

Re: [PATCH 03/11] spi: pxa2xx: Use an enum for type

2018-11-04 Thread Pavel Machek
On Wed 2018-10-10 19:09:28, Lubomir Rintel wrote: > That seems to be the correct type. > > Signed-off-by: Lubomir Rintel Acked-by: Pavel Machek -- (english) http://www.livejournal.com/~pavelmachek (cesky, pictures) http://atrey.karlin.mff.cuni.cz/~pavel/picture/horses/

Re: [PATCH v2 02/11] PCI: Provide pci_match_id() with CONFIG_PCI=n

2018-11-04 Thread Pavel Machek
ff-by: Lubomir Rintel Acked-by: Pavel Machek Pavel -- (english) http://www.livejournal.com/~pavelmachek (cesky, pictures) http://atrey.karlin.mff.cuni.cz/~pavel/picture/horses/blog.html signature.asc Description: Digital signature

Re: [PATCH v2 01/11] dt-bindings: spi/spi-pxa2xx: add PXA2xx SSP SPI Controller

2018-11-04 Thread Pavel Machek
On Wed 2018-10-10 19:09:26, Lubomir Rintel wrote: > This is the SPI controller found on Marvel MMP2 and perhaps more > platforms. > > Reviewed-by: Rob Herring > Signed-off-by: Lubomir Rintel Acked-by: Pavel Machek Rob, do yo

  1   2   3   4   5   6   7   8   9   10   >