Re: [PATCH v2 1/3] mux: gpio: Use bitmap API instead of direct assignment

2021-03-31 Thread Peter Rosin
ike it's done in the driver might be error prone. > Fix this by using bitmap API. > > Signed-off-by: Andy Shevchenko > Acked-by: Peter Rosin > --- > v2: left blank line untouched (Peter) > drivers/mux/gpio.c | 6 -- > 1 file changed, 4 insertions(+), 2 deletions(-) &g

Re: [PATCH v1 3/3] mux: gpio: Simplify code by using dev_err_probe()

2021-03-30 Thread Peter Rosin
one here and there. Sorry to be a pest, but coding-style.rst agrees with me: "The preferred limit on the length of a single line is 80 columns." So, with that changed, Acked-by: Peter Rosin Cheers, Peter > WARN_ON(pins != mux_gpio->gpios->ndescs); > mux_chip->mux->states = BIT(pins); > >

Re: [PATCH v1 2/3] mux: gpio: Make it OF independent

2021-03-30 Thread Peter Rosin
.h sorts before module.h. With that changed, Acked-by: Peter Rosin Cheers, Peter > #include > -#include > #include > #include > > @@ -97,7 +97,7 @@ static int mux_gpio_probe(struct platform_device *pdev) > static struct platform_driver mux_gpio_driver = { > .dri

Re: [PATCH v1 1/3] mux: gpio: Use bitmap API instead of direct assignment

2021-03-30 Thread Peter Rosin
git a/drivers/mux/gpio.c b/drivers/mux/gpio.c > index 02c1f2c014e8..891ee0274733 100644 > --- a/drivers/mux/gpio.c > +++ b/drivers/mux/gpio.c > @@ -6,7 +6,7 @@ > * > * Author: Peter Rosin > */ > - Nit, please keep the empty line here. With that, Acked-by: Peter Rosi

Re: [RESEND PATCH v3 1/2] i2c: i2c-mux-gpio: Factor out pdev->dev in _probe_dt()

2021-01-15 Thread Peter Rosin
or >dev to dev refactor (Peter) > > drivers/i2c/muxes/i2c-mux-gpio.c | 5 +++-- > 1 file changed, 3 insertions(+), 2 deletions(-) Acked-by: Peter Rosin (this patch doesn't make much sense without 2/2) Cheers, Peter

Re: [RESEND PATCH v3 2/2] i2c: i2c-mux-gpio: Enable this driver in ACPI land

2021-01-15 Thread Peter Rosin
that area. I would greatly appreciate Andy following through with his line of thinking... So, if we ignore Andys review comments, then: Acked-by: Peter Rosin Cheers, Peter

Re: [PATCH 4/7] dt-bindings: ti-serdes-mux: Add defines for AM64 SoC

2021-01-08 Thread Peter Rosin
J7200 sections have a blank line here, between the header comment and the actual defines. But mehh... Acked-by: Peter Rosin Cheers, Peter > +#define AM64_SERDES0_LANE0_PCIE0 0x0 > +#define AM64_SERDES0_LANE0_USB 0x1 > + > #endif /* _DT_BINDINGS_MUX_TI_SERDES */ >

Re: [PATCH] drm/fb-helper: Add missed unlocks in setcmap_legacy()

2020-12-03 Thread Peter Rosin
> Signed-off-by: Chuhong Yuan Yup, my patch fumbled the locking. Sorry, and thanks for cleaning up my mess! Acked-by: Peter Rosin (Spelled that as Ached-by at first, what does that mean??) Cheers, Peter > --- > drivers/gpu/drm/drm_fb_helper.c | 15 ++- > 1 file c

Re: [PATCH v2] i2c: i2c-mux-gpio: Enable this driver in ACPI land

2020-10-15 Thread Peter Rosin
Hi! On 2020-10-15 03:02, Evan Green wrote: > Enable i2c-mux-gpio devices to be defined via ACPI. The idle-state > property translates directly to a fwnode_property_*() call. The child > reg property translates naturally into _ADR in ACPI. > > The i2c-parent binding is a relic from the days when

Re: using one gpio for multiple dht22 sensors

2020-10-14 Thread Peter Rosin
On 2020-10-14 11:12, Peter Rosin wrote: > Hi Rasnus, Rasmus. *Blush* Cheers, Peter

Re: using one gpio for multiple dht22 sensors

2020-10-14 Thread Peter Rosin
Hi Rasnus, On 2020-10-13 23:34, Rasmus Villemoes wrote: > Hi Peter > > Since you're the author of io-channel-mux.txt, gpio-mux.txt and > mux-controller.txt, I hope you don't mind me asking some perhaps silly > questions. Right, I ended up being the maintainer for a bunch of code I needed to do

Re: [PATCH] i2c: i2c-mux-gpio: Enable this driver in ACPI land

2020-10-10 Thread Peter Rosin
Hi! On 2020-10-10 00:43, Evan Green wrote: > Enable i2c-mux-gpio devices to be defined via ACPI. The idle-state > property translates directly to a fwnode_property_*() call. The child > reg property translates naturally into _ADR in ACPI. > > The i2c-parent is a little trickier, since of's

Re: [PATCH v4 1/6] dt-bindings: ti-serdes-mux: Add defines for J7200 SoC

2020-09-29 Thread Peter Rosin
Hi! On 2020-09-21 16:39, Roger Quadros wrote: > There are 4 lanes in each J7200 SERDES. Each SERDES lane mux can > select upto 4 different IPs. Define all the possible functions. > > Cc: Peter Rosin > Signed-off-by: Roger Quadros Acked-by: Peter Rosin Thanks for taking care o

Re: [PATCH] arm64: dts: ti: k3-j721e: Rename mux header and update macro names

2020-09-17 Thread Peter Rosin
GMII_LANE6 0x2 > + > +#define J721E_SERDES4_LANE2_EDP_LANE20x0 > +#define J721E_SERDES4_LANE2_QSGMII_LANE7 0x2 > + > +#define J721E_SERDES4_LANE3_EDP_LANE30x0 > +#define J721E_SERDES4_LANE3_QSGMII_LANE8 0x2 > + > +#endif /* _DT_BINDINGS_TI_SERDES_MUX */ > The J7200-series listed *all* possible mux values, some with names like BLA_BLA_UNUSED. Why is that different here? Some dt-files using the J7200 then ended up using these "unused" entries (for idle-states) so maybe thoes values are useful here as well? The choice of using _UNUSED for entries that end up being used can of course also be debated :-) If it is ill-adviced to use the values not listed above, that's another matter of course... I don't know the answer to the above, and will not be impacted in the least, I'm just throwing out questions. So, either way: Acked-by: Peter Rosin Cheers, Peter

Re: [PATCH v3 1/6] dt-bindings: mux-j7200-wiz: Add lane function defines

2020-09-17 Thread Peter Rosin
On 2020-09-17 14:27, Nishanth Menon wrote: > On 11:45-20200917, Peter Rosin wrote: > [...] >> >>>> Should not the defines start with J7200_WIZ? SERDES0 seems like a too >>>> generic prefix, at least to me. >>> >>> Thanks, good point. I a

Re: [PATCH v3 1/6] dt-bindings: mux-j7200-wiz: Add lane function defines

2020-09-17 Thread Peter Rosin
Hi! On 2020-09-17 14:00, Roger Quadros wrote: > Hi Peter & Nishanth, > > On 16/09/2020 18:45, Nishanth Menon wrote: >> On 06:52-20200916, Peter Rosin wrote: >>> Hi, >>> >>> Sorry for the delay. >>> >>> On 2020-09-15 13:20,

Re: [PATCH v3 1/6] dt-bindings: mux-j7200-wiz: Add lane function defines

2020-09-17 Thread Peter Rosin
Hi! On 2020-09-16 17:45, Nishanth Menon wrote: > On 06:52-20200916, Peter Rosin wrote: >> Hi, >> >> Sorry for the delay. >> >> On 2020-09-15 13:20, Roger Quadros wrote: >>> Each SERDES lane mux can select upto 4 different IPs. >>>

Re: [PATCH v3 1/6] dt-bindings: mux-j7200-wiz: Add lane function defines

2020-09-15 Thread Peter Rosin
Hi, Sorry for the delay. On 2020-09-15 13:20, Roger Quadros wrote: > Each SERDES lane mux can select upto 4 different IPs. > There are 4 lanes in each J7200 SERDES. Define all > the possible functions in this file. > > Cc: Peter Rosin > Signed-off-by: Roger Quadros &

Re: [PATCH v3 08/18] iio: adc: stm32: Simplify with dev_err_probe()

2020-09-09 Thread Peter Rosin
Hi! On 2020-09-09 21:57, Krzysztof Kozlowski wrote: > On Wed, 9 Sep 2020 at 20:36, Jonathan Cameron wrote: >> >> On Sat, 29 Aug 2020 08:47:16 +0200 >> Krzysztof Kozlowski wrote: >> >>> Common pattern of handling deferred probe can be simplified with >>> dev_err_probe(). Less code and also it

Re: [PATCH 8/9] i2c: mux: gpmux: Simplify with dev_err_probe()

2020-09-02 Thread Peter Rosin
On 2020-09-02 17:06, Krzysztof Kozlowski wrote: > Common pattern of handling deferred probe can be simplified with > dev_err_probe(). Less code and the error value gets printed. > > Signed-off-by: Krzysztof Kozlowski Acked-by: Peter Rosin Cheers, Peter

Re: [PATCH 9/9] i2c: mux: reg: Simplify with dev_err_probe()

2020-09-02 Thread Peter Rosin
On 2020-09-02 17:06, Krzysztof Kozlowski wrote: > Common pattern of handling deferred probe can be simplified with > dev_err_probe(). Less code and the error value gets printed. > > Signed-off-by: Krzysztof Kozlowski Acked-by: Peter Rosin Cheers, Peter

Re: [PATCH v3 18/18] iio: multiplexer: iio-mux: Simplify with dev_err_probe()

2020-08-29 Thread Peter Rosin
On 2020-08-29 08:47, Krzysztof Kozlowski wrote: > Common pattern of handling deferred probe can be simplified with > dev_err_probe(). Less code and also it prints the error value. > > Signed-off-by: Krzysztof Kozlowski > Reviewed-by: Andy Shevchenko Acked-by: Peter Rosin Cheers, Peter

Re: [PATCH v3 12/18] iio: dac: dpot-dac: Simplify with dev_err_probe()

2020-08-29 Thread Peter Rosin
On 2020-08-29 08:47, Krzysztof Kozlowski wrote: > Common pattern of handling deferred probe can be simplified with > dev_err_probe(). Less code and also it prints the error value. > > Signed-off-by: Krzysztof Kozlowski > Reviewed-by: Andy Shevchenko Acked-by: Peter Rosin Cheers, Peter

Re: [PATCH v3 09/18] iio: afe: iio-rescale: Simplify with dev_err_probe()

2020-08-29 Thread Peter Rosin
On 2020-08-29 08:47, Krzysztof Kozlowski wrote: > Common pattern of handling deferred probe can be simplified with > dev_err_probe(). Less code and also it prints the error value. > > Signed-off-by: Krzysztof Kozlowski > Reviewed-by: Andy Shevchenko Acked-by: Peter Rosin Cheers, Peter

Re: [PATCH v3 03/18] iio: adc: envelope-detector: Simplify with dev_err_probe()

2020-08-29 Thread Peter Rosin
On 2020-08-29 08:47, Krzysztof Kozlowski wrote: > Common pattern of handling deferred probe can be simplified with > dev_err_probe(). Less code and also it prints the error value. > > Signed-off-by: Krzysztof Kozlowski > Reviewed-by: Andy Shevchenko Thanks for the re-spin.

Re: [PATCH v2 09/18] iio: afe: iio-rescale: Simplify with dev_err_probe()

2020-08-28 Thread Peter Rosin
On 2020-08-28 09:03, Krzysztof Kozlowski wrote: > On Fri, 28 Aug 2020 at 08:58, Peter Rosin wrote: >>>> I'm not a huge fan of adding *one* odd line breaking the 80 column >>>> recommendation to any file. I like to be able to fit multiple >>>> windows si

Re: [PATCH v2 09/18] iio: afe: iio-rescale: Simplify with dev_err_probe()

2020-08-28 Thread Peter Rosin
On 2020-08-28 10:25, Andy Shevchenko wrote: > On Fri, Aug 28, 2020 at 12:46 AM Peter Rosin wrote: >> On 2020-08-27 21:26, Krzysztof Kozlowski wrote: > > ... > >> I'm not a huge fan of adding *one* odd line breaking the 80 column >> recommendation to any file. I l

Re: [PATCH v2 09/18] iio: afe: iio-rescale: Simplify with dev_err_probe()

2020-08-28 Thread Peter Rosin
On 2020-08-28 08:24, Krzysztof Kozlowski wrote: > On Thu, Aug 27, 2020 at 11:46:40PM +0200, Peter Rosin wrote: >> On 2020-08-27 21:26, Krzysztof Kozlowski wrote: >>> Common pattern of handling deferred probe can be simplified with >>> dev_err_probe(). Less code a

Re: [PATCH v2 18/18] iio: magnetometer: iio-mux: Simplify with dev_err_probe()

2020-08-27 Thread Peter Rosin
Hi! Wrong subject. Made me overlook it on the first pass... On 2020-08-27 21:26, Krzysztof Kozlowski wrote: > Common pattern of handling deferred probe can be simplified with > dev_err_probe(). Less code and also it prints the error value. > > Signed-off-by: Krzysztof Kozlowski > --- >

Re: [PATCH v2 09/18] iio: afe: iio-rescale: Simplify with dev_err_probe()

2020-08-27 Thread Peter Rosin
On 2020-08-27 21:26, Krzysztof Kozlowski wrote: > Common pattern of handling deferred probe can be simplified with > dev_err_probe(). Less code and also it prints the error value. > > Signed-off-by: Krzysztof Kozlowski > > --- > > Changes since v1: > 1. Wrap dev_err_probe() lines at 100

Re: [PATCH] iio: dpot-dac: fix code comment in dpot_dac_read_raw()

2020-08-26 Thread Peter Rosin
On 2020-08-26 16:17, Gustavo A. R. Silva wrote: >> And just to be explicit, this fix is for 5.9. >> >> Acked-by: Peter Rosin >> > > If you don't mind I can add this to my tree for 5.9-rc4 > and send it directly to Linus. Fine by me, Jonathan might think differen

Re: [PATCH] iio: dpot-dac: fix code comment in dpot_dac_read_raw()

2020-08-26 Thread Peter Rosin
. > > Reported-by: Peter Rosin > Signed-off-by: Gustavo A. R. Silva Excellent, thanks for the quick turnaround! And just to be explicit, this fix is for 5.9. Acked-by: Peter Rosin Cheers, Peter

Re: [GIT PULL] fallthrough pseudo-keyword macro conversions for 5.9-rc3

2020-08-25 Thread Peter Rosin
On 2020-08-23 22:48, Gustavo A. R. Silva wrote: > Hi Linus, > > Please, pull the following tree-wide patch that replaces tons (2484) of > /* fall through */ comments, and its variants, with the new pseudo-keyword > macro fallthrough[1]. Also, remove unnecessary fall-through markings when > it is

Re: include/linux/bits.h:25:21: error: first argument to '__builtin_choose_expr' not a constant

2020-08-12 Thread Peter Rosin
On 2020-08-11 06:27, Andrew Morton wrote: > On Sat, 8 Aug 2020 08:03:38 +0800 kernel test robot wrote: > >> tree: https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git >> master >> head: 30185b69a2d533c4ba6ca926b8390ce7de495e29 >> commit:

Re: [PATCH 1/2] iio: afe: rescale: Add support for converting scale avail table

2020-07-27 Thread Peter Rosin
Hi! On 2020-02-10 23:54, Paul Cercueil wrote: > When the IIO channel has a scale_available attribute, we want the values > contained to be properly converted the same way the scale value is. > > Signed-off-by: Paul Cercueil > --- > drivers/iio/afe/iio-rescale.c | 125

Re: [PATCH 2/2] iio: afe: rescale: Implement write_raw

2020-07-27 Thread Peter Rosin
Hi! Sorry for the delay. Vacation... On 2020-07-26 14:41, Jonathan Cameron wrote: > On Tue, 21 Jul 2020 01:16:55 +0200 > Paul Cercueil wrote: > >> Hi Jonathan, >> >> Le sam. 15 févr. 2020 à 18:32, Jonathan Cameron a >> écrit : >>> On Mon, 10 Feb 2020 19:54:38 -0300 >>> Paul Cercueil wrote:

Re: [PATCH v3 4/8] mux: sparx5: Add Sparx5 SPI mux driver

2020-07-02 Thread Peter Rosin
Hi! On 2020-07-02 12:13, Lars Povlsen wrote: > The Sparx5 mux driver may be used to control selecting between two > alternate SPI bus segments connected to the SPI controller > (spi-dw-mmio). > > Signed-off-by: Lars Povlsen > --- > drivers/mux/Makefile | 2 + > drivers/mux/sparx5-spi.c |

Re: [PATCH 1/2] i2c: mux: pca9541: Change to correct bus control commands

2020-06-02 Thread Peter Rosin
On 2020-06-02 14:12, Quentin Strydom wrote: > Change current bus commands to match the pca9541a datasheet > (see table 12 on page 14 of > https://www.nxp.com/docs/en/data-sheet/PCA9541A.pdf). Also > where entries are marked as no change the current control > command is repeated as the current

[PATCH] mux: adgs1408: Add mod_devicetable.h and remove of_match_ptr

2020-05-29 Thread Peter Rosin
("spi: Add generic SPI multiplexer") Reported-by: kbuild test robot Signed-off-by: Andy Shevchenko Signed-off-by: Peter Rosin --- drivers/mux/adgs1408.c | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) Hi Greg, Here's a single mux patch. It's been in -next for a coup

Re: [PATCH v1] mux: adgs1408: Add mod_devicetable.h and remove of_match_ptr

2020-05-25 Thread Peter Rosin
On 2020-05-20 14:01, Andy Shevchenko wrote: > Enables probing via the ACPI PRP0001 route but more is mostly about > removing examples of this that might get copied into new drivers. > > Also fixes > drivers/mux/adgs1408.c:112:34: warning: unused variable 'adgs1408_of_match > as has been

[PATCH] spi: mux: repair mux usage

2020-05-25 Thread Peter Rosin
not happening in the original setting where this driver was developed, but it is said to be a generic SPI mux. Also, the mux framework will short out the actual low level muxing operation when/if that is possible. Fixes: e9e40543ad5b ("spi: Add generic SPI multiplexer") Signed-off-by: P

Re: [PATCH v1] mux: adgs1408: Add mod_devicetable.h and remove of_match_ptr

2020-05-22 Thread Peter Rosin
On 2020-05-22 14:52, Andy Shevchenko wrote: > On Wed, May 20, 2020 at 03:01:22PM +0300, Andy Shevchenko wrote: >> Enables probing via the ACPI PRP0001 route but more is mostly about >> removing examples of this that might get copied into new drivers. >> >> Also fixes >>

Re: [PATCH] i2c: mux: demux-pinctrl: Fix an error handling path in 'i2c_demux_pinctrl_probe()'

2020-05-12 Thread Peter Rosin
On 2020-05-12 15:08, Wolfram Sang wrote: > On Wed, May 06, 2020 at 09:21:00PM +0200, Christophe JAILLET wrote: >> A call to 'i2c_demux_deactivate_master()' is missing in the error handling >> path, as already done in the remove function. >> >> Fixes: 50a5ba876908 ("i2c: mux: demux-pinctrl: add

Re: [PATCH] i2c: mux: Replace zero-length array with flexible-array

2020-05-07 Thread Peter Rosin
On 2020-05-07 20:53, Gustavo A. R. Silva wrote: > The current codebase makes use of the zero-length array language > extension to the C90 standard, but the preferred mechanism to declare > variable-length types such as these ones is a flexible array member[1][2], > introduced in C99: > > struct

Re: [PATCH v5 0/9] i2c: add support for filters

2019-10-21 Thread Peter Rosin
licable only to digital filter >>> - created new binding i2c-digital-filter-width-ns for analog filters. >> >> Hello Wolfram and Peter, >> >> Are you happy with the changes in this version? I haven't heard from you >> since this latest update. >> I am in

Re: [PATCH v5 3/9] i2c: add support for filters optional properties

2019-10-21 Thread Peter Rosin
On 2019-09-11 10:24, eugen.hris...@microchip.com wrote: > From: Eugen Hristev > > i2c-digital-filter-width-ns: > This optional timing property specifies the width of the spikes on the i2c > lines (in ns) that can be filtered out by built-in digital filters which are > embedded in some i2c

Re: [v4,2/2] i2c: mux: pca954x: support property idle-state

2019-10-21 Thread Peter Rosin
On 2019-10-21 10:00, Biwen Li wrote: > This supports property idle-state > You should expand this a little bit to explain that idle-state, if present, overrides i2c-mux-idle-disconnect. You could also mention your use case where you need to avoid disconnects on probe/resume. > Signed-off-by:

Re: [v3,2/2] i2c: mux: pca954x: support property idle-state

2019-10-17 Thread Peter Rosin
On 2019-10-16 06:09, Biwen Li wrote: > This supports property idle-state > > Signed-off-by: Biwen Li > --- > Change in v3: > - update subject and description > - add a helper function pca954x_calculate_chan() > > Change in v2: > - update subject and description > - add

Re: [v3,1/2] dt-bindings: i2c: support property idle-state

2019-10-17 Thread Peter Rosin
On 2019-10-16 06:09, Biwen Li wrote: > This supports property idle-state > > Signed-off-by: Biwen Li > --- > Change in v3: > - update subject and description > - add some information for property idle-state > > Change in v2: > - update subject and description > - add

Re: [v2,1/2] dt-bindings: i2c: add property idle-state

2019-10-15 Thread Peter Rosin
On 2019-10-15 06:48, Biwen Li wrote: > This adds property idle-state > > Signed-off-by: Biwen Li > --- > Change in v2: > - update subject and description > - add property idle-state > > Documentation/devicetree/bindings/i2c/i2c-mux-pca954x.txt | 1 + > 1 file changed, 1

Re: [v2,2/2] i2c: mux: pca954x: add property idle-state

2019-10-15 Thread Peter Rosin
On 2019-10-15 06:48, Biwen Li wrote: > This adds property idle-state > > Signed-off-by: Biwen Li > --- > Change in v2: > - update subject and description > - add property idle-state > > drivers/i2c/muxes/i2c-mux-pca954x.c | 47 ++--- > 1 file changed, 30

Re: [PATCH 2/2] i2c: mux: pca954x: replace property i2c-mux-idle-disconnect

2019-10-14 Thread Peter Rosin
On 2019-10-14 13:25, Biwen Li wrote: > This replaces property i2c-mux-idle-disconnect with idle-state > > Signed-off-by: Biwen Li > --- > drivers/i2c/muxes/i2c-mux-pca954x.c | 44 - > 1 file changed, 31 insertions(+), 13 deletions(-) > > diff --git

Re: [PATCH 1/2] dt-bindings: i2c: replace property i2c-mux-idle-disconnect

2019-10-14 Thread Peter Rosin
On 2019-10-14 13:25, Biwen Li wrote: > This replaces property i2c-mux-idle-disconnect with idle-state > > Signed-off-by: Biwen Li > --- > Documentation/devicetree/bindings/i2c/i2c-mux-pca954x.txt | 4 +--- > 1 file changed, 1 insertion(+), 3 deletions(-) > > diff --git

Re: [EXT] Re: [v2,2/2] dt-bindings: i2c-mux-pca954x: Add optional property i2c-mux-never-disable

2019-10-14 Thread Peter Rosin
On 2019-10-14 06:16, Biwen Li wrote: >> >>> >>> On Mon, Sep 30, 2019 at 11:25:03AM +0800, Biwen Li wrote: The patch adds an optional property i2c-mux-never-disable Signed-off-by: Biwen Li --- Change in v2: - update documentation

Re: [EXT] Re: [PATCH] i2c: pca954x: Add property to skip disabling PCA954x MUX device

2019-09-29 Thread Peter Rosin
On 2019-09-30 04:43, Biwen Li wrote: >> >> On 2019-09-29 12:36, Biwen Li wrote: >>> On some Layerscape boards like LS2085ARDB and LS2088ARDB, input >>> pull-up resistors on PCA954x MUX device are missing on board, So, if >>> MUX are disabled after powered-on, input lines will float leading to >>>

Re: [PATCH] i2c: pca954x: Add property to skip disabling PCA954x MUX device

2019-09-29 Thread Peter Rosin
On 2019-09-29 12:36, Biwen Li wrote: > On some Layerscape boards like LS2085ARDB and LS2088ARDB, > input pull-up resistors on PCA954x MUX device are missing on board, > So, if MUX are disabled after powered-on, input lines will float > leading to incorrect functionality. Hi! Are you saying that

Re: [PATCH] dt-bindings: at24: convert the binding document to yaml

2019-09-23 Thread Peter Rosin
On 2019-09-23 20:34, Bartosz Golaszewski wrote: > pon., 23 wrz 2019 o 20:30 Peter Rosin napisał(a): >> >> which is no longer allowed. That might be a problem? The previous binding >> also allows less e.g. >> >> compatible = "atmel,24c00",

Re: [PATCH] dt-bindings: at24: convert the binding document to yaml

2019-09-23 Thread Peter Rosin
On 2019-09-23 19:52, Bartosz Golaszewski wrote: > From: Bartosz Golaszewski > > Convert the binding document for at24 EEPROMs from txt to yaml. The > compatible property uses a regex pattern to address all the possible > combinations of "vendor,model" strings. > > Signed-off-by: Bartosz

Re: [PATCH] of: restore old handling of cells_name=NULL in of_*_phandle_with_args()

2019-09-18 Thread Peter Rosin
- drivers/soc/rockchip/pm_domains.c > - sound/soc/fsl/imx-audmix.c > - sound/soc/fsl/imx-audmix.c > - sound/soc/meson/axg-card.c > - sound/soc/samsung/tm2_wm5110.c > - sound/soc/samsung/tm2_wm5110.c > > Thanks to Geert Uytterhoeven for reporting the issue, Peter Rosin for >

Re: [PATCH v1 2/2] of: Let of_for_each_phandle fallback to non-negative cell_count

2019-09-17 Thread Peter Rosin
On 2019-09-17 12:13, Uwe Kleine-König wrote: > Hello Geert, > > On Tue, Sep 17, 2019 at 11:40:25AM +0200, Geert Uytterhoeven wrote: >> Hi Rob, Uwe, >> >> On Fri, Sep 13, 2019 at 11:58 PM Rob Herring wrote: >>> On Sat, 24 Aug 2019 15:28:46 +0200, =?UTF-8?q?Uwe=20Kleine-K=C3=B6nig?= >>>

Re: [PATCH v3 1/1] i2c: qcom-geni: Provide an option to disable DMA processing

2019-09-05 Thread Peter Rosin
On 2019-09-05 15:49, Wolfram Sang wrote: > Hi Lee, > > I understand you are in a hurry, but please double check before > sending... Linus indicated that an rc8 is coming up, which should provide an extra week. https://lwn.net/Articles/798152/ > On Thu, Sep 05, 2019 at 11:22:47AM +0100, Lee

Re: [RFC,v2 2/6] i2c: add I2C Address Translator (ATR) support

2019-09-04 Thread Peter Rosin
Hi! [ Sorry about my absence. I've been meaning to comment on this series for a long time, but work and family keep interfering... ] On 2019-09-03 09:31, Luca Ceresoli wrote: > Hi Jacopo, > > thanks for your feedback. > > On 01/09/19 16:31, jacopo mondi wrote: >> Hi Luca, >>thanks for

Re: [PATCH v4 2/9] dt-bindings: i2c: add bindings for i2c analog and digital filter

2019-09-02 Thread Peter Rosin
On 2019-09-02 16:15, eugen.hris...@microchip.com wrote: > > > On 02.09.2019 13:49, Peter Rosin wrote: > >> On 2019-09-02 12:12, eugen.hris...@microchip.com wrote: >>> From: Eugen Hristev >>> >>> Some i2c controllers have a built-in digital or ana

Re: [PATCH v4 2/9] dt-bindings: i2c: add bindings for i2c analog and digital filter

2019-09-02 Thread Peter Rosin
On 2019-09-02 12:12, eugen.hris...@microchip.com wrote: > From: Eugen Hristev > > Some i2c controllers have a built-in digital or analog filter. > This is specifically required depending on the hardware PCB/board. > Some controllers also allow specifying the maximum width of the > spikes that

Re: [PATCH v4 1/9] dt-bindings: i2c: at91: add new compatible

2019-09-02 Thread Peter Rosin
On 2019-09-02 12:11, eugen.hris...@microchip.com wrote: > From: Eugen Hristev > > Add compatible for new Microchip SoC, sam9x60 > > Reviewed-by: Rob Herring > Signed-off-by: Eugen Hristev > --- > Documentation/devicetree/bindings/i2c/i2c-at91.txt | 3 ++- > 1 file changed, 2 insertions(+), 1

[PATCH 0/2] Add possibility to specify the number of displayed logos

2019-08-23 Thread Peter Rosin
he display to only one logo instead of one for each CPU core. Cheers, Peter Peter Rosin (2): fbdev: fix numbering of fbcon options fbdev: fbmem: allow overriding the number of bootup logos Documentation/fb/fbcon.rst | 13 + drivers/video/fbdev/core/fbcon.c | 7 +++ dri

[PATCH 1/2] fbdev: fix numbering of fbcon options

2019-08-23 Thread Peter Rosin
Three shall be the number thou shalt count, and the number of the counting shall be three. Four shalt thou not count... One! Two! Five! Fixes: efb985f6b265 ("[PATCH] fbcon: Console Rotation - Add framebuffer console documentation") Signed-off-by: Peter Rosin --- Documentation/fb/fbc

[PATCH 2/2] fbdev: fbmem: allow overriding the number of bootup logos

2019-08-23 Thread Peter Rosin
Probably most useful if you only want one logo regardless of how many CPU cores you have. Signed-off-by: Peter Rosin --- Documentation/fb/fbcon.rst | 5 + drivers/video/fbdev/core/fbcon.c | 7 +++ drivers/video/fbdev/core/fbmem.c | 5 - include/linux/fb.h | 1

Re: [PATCH v2 3/9] dt-bindings: i2c: at91: add binding for enable-dig-filtr

2019-06-25 Thread Peter Rosin
On 2019-06-25 10:04, eugen.hris...@microchip.com wrote: > From: Eugen Hristev > > Add binding specificatoin for digital filter inside the i2c controller > > Signed-off-by: Eugen Hristev > --- > Documentation/devicetree/bindings/i2c/i2c-at91.txt | 4 > 1 file changed, 4 insertions(+) > >

Re: [PATCH v2 6/9] dt-bindings: i2c: at91: add binding for enable-ana-filt

2019-06-25 Thread Peter Rosin
On 2019-06-25 10:05, eugen.hris...@microchip.com wrote: > From: Eugen Hristev > > Add binding specification for analogic filter inside the i2c controller s/analogic/the analog/ > Signed-off-by: Eugen Hristev > --- > Documentation/devicetree/bindings/i2c/i2c-at91.txt | 4 > 1 file

Re: [PATCH v2 9/9] ARM: dts: at91: sama5d4_xplained: add analogic filter for i2c

2019-06-25 Thread Peter Rosin
On 2019-06-25 10:05, eugen.hris...@microchip.com wrote: > From: Eugen Hristev > > Add property for digital filter for i2c0 node sama5d4_xplained This does not match the below hunk. Cheers, Peter > Signed-off-by: Eugen Hristev > --- > arch/arm/boot/dts/at91-sama5d4_xplained.dts | 1 + > 1

Re: [PATCH v2 13/28] drivers: Introduce class_find_device_by_of_node() helper

2019-06-24 Thread Peter Rosin
On 2019-06-24 10:34, Suzuki K Poulose wrote: > Hi Peter, > > On 22/06/2019 06:25, Peter Rosin wrote: >> On 2019-06-14 19:54, Suzuki K Poulose wrote: >>> Add a wrapper to class_find_device() to search for a device >>> by the of_node pointer, reusing the generic

Re: [PATCH v2 13/28] drivers: Introduce class_find_device_by_of_node() helper

2019-06-21 Thread Peter Rosin
her > Cc: linux-f...@vger.kernel.org > Cc: Peter Rosin > Cc: Mark Brown > Cc: Florian Fainelli > Cc: Heiner Kallweit > Cc: "David S. Miller" > Cc: Andrew Lunn > Cc: Liam Girdwood > Cc: Greg Kroah-Hartman > Cc: "Rafael J. Wysocki" > Cc: Jir

Re: [PATCH V2] i2c: tegra: disable irq in tegra_i2c_xfer_msg

2019-06-18 Thread Peter Rosin
On 2019-06-18 10:42, Bitan Biswas wrote: > tegra_i2c_xfer_msg initiates the I2C transfer in DMA > or PIO mode. It involves steps that need FIFO register > access, DMA API calls like dma_sync_single_for_device, etc. > Tegra I2C ISR has calls to tegra_i2c_empty_rx_fifo in PIO mode > and in DMA/PIO

Re: [PATCH v4 4/5] phy: ti: Add a new SERDES driver for TI's AM654x SoC

2019-06-18 Thread Peter Rosin
Hi, Sorry for the late reply, $-work interfered... On 2019-06-13 12:21, Kishon Vijay Abraham I wrote: > Hi, > > On 13/06/19 1:22 PM, Peter Rosin wrote: >> Hi, >> >> On 2019-06-13 06:57, Kishon Vijay Abraham I wrote: >>> Hi Peter, >>> >&g

Re: [PATCH] i2c: mux-gpio: Use "mux" con_id to find channel GPIOs

2019-06-16 Thread Peter Rosin
On 2019-06-16 01:24, Serge Semin wrote: > On Sat, Jun 15, 2019 at 02:43:09PM +0300, Andy Shevchenko wrote: >> On Sat, Jun 15, 2019 at 12:51 AM Serge Semin wrote: >>> >>> Recent patch - ("i2c: mux/i801: Switch to use descriptor passing") >>> altered the i2c-mux-gpio driver to use the

Re: [PATCH v2 2/3] i2c-mux-gpio: Unpin the platform-specific GPIOs request code

2019-06-14 Thread Peter Rosin
On 2019-06-14 18:31, Serge Semin wrote: > Hello Peter, > > On Sun, Jun 09, 2019 at 09:34:54PM +0000, Peter Rosin wrote: >> On 2019-04-26 01:20, Serge Semin wrote: >>> The GPIOs request loop can be safely moved to a separate function. >>> First of all it s

Re: [PATCH v4 4/5] phy: ti: Add a new SERDES driver for TI's AM654x SoC

2019-06-13 Thread Peter Rosin
Hi! [I know this has already been merged upstream, but I only just now noticed the code and went to the archives to find the originating mail. I hope I managed to set in-reply-to correctly...] The mux handling is problematic and does not follow the rules. It needs to be fixed, or you may face

Re: [PATCH v4 4/5] phy: ti: Add a new SERDES driver for TI's AM654x SoC

2019-06-13 Thread Peter Rosin
Hi, On 2019-06-13 06:57, Kishon Vijay Abraham I wrote: > Hi Peter, > > On 13/06/19 4:20 AM, Peter Rosin wrote: >> Hi! >> >> [I know this has already been merged upstream, but I only just >> now noticed the code and went to the archives to find the >> or

[RESEND PATCH 0/2] mux: a couple of patches for 5.3-rc1

2019-06-12 Thread Peter Rosin
Hi Greg, (For Greg, this is not a resend, since I apparently forgot to include him last time [1]. My mistake, sorry about that) A small addition to the mmio mux so that it can handle non-syscon regmaps. The bindings patch should probably have had Robs tag, but after a bit of back and forth I

[RESEND PATCH 2/2] mux: mmio: add generic regmap bitfield-based multiplexer

2019-06-12 Thread Peter Rosin
From: Pankaj Bansal Generic register bitfield-based multiplexer that controls the multiplexer producer defined under a parent node. The driver corresponding to parent node provides register read/write capabilities. Signed-off-by: Pankaj Bansal Signed-off-by: Peter Rosin --- drivers/mux

[RESEND PATCH 1/2] dt-bindings: add register based devices' mux controller DT bindings

2019-06-12 Thread Peter Rosin
. Signed-off-by: Pankaj Bansal Signed-off-by: Peter Rosin --- Documentation/devicetree/bindings/mux/mmio-mux.txt | 60 -- Documentation/devicetree/bindings/mux/reg-mux.txt | 129 + 2 files changed, 129 insertions(+), 60 deletions(-) delete mode 100644 Documentation

Re: [PATCH v1 3/3] dt-bindings: iio: afe: Add hwmon example

2019-06-11 Thread Peter Rosin
On 2019-06-11 11:56, Mylène Josserand wrote: > With the support of CHAN_INFO_PROCESSED in voltage-divider, > it is possible to read the processed values directly from iio's > sysfs entries or by using iio-hwmon. Add an example for this last > use case. As I wrote in response to the cover letter,

Re: [PATCH v1 1/3] iio: afe: rescale: Move scale conversion to new function

2019-06-11 Thread Peter Rosin
On 2019-06-11 11:56, Mylène Josserand wrote: > To prepare the support of processed value, create a function > to convert the scale according to the voltage-divider node > used in the device-tree. > > Signed-off-by: Mylène Josserand > --- > drivers/iio/afe/iio-rescale.c | 54 >

Re: [PATCH v1 0/3] iio: afe: rescale: Add INFO_PROCESSED support

2019-06-11 Thread Peter Rosin
On 2019-06-11 11:56, Mylène Josserand wrote: > Hello everyone, > > You will find a small series that add the support of processed values > for iio-rescale driver. > Thanks to that, it is possible to read processed values in sysfs instead > of getting only raw and scale values. > > Here is an

Re: [PATCH] i2c: mux: pinctrl: use flexible-array member and struct_size() helper

2019-06-11 Thread Peter Rosin
On 2019-06-03 16:53, Gustavo A. R. Silva wrote: > Update the code to use a flexible array member instead of a pointer in > structure i2c_mux_pinctrl and use the struct_size() helper. > > Also, make use of the struct_size() helper instead of an open-coded > version in order to avoid any potential

Re: [PATCH] i2c: mux: Use struct_size() in devm_kzalloc()

2019-06-11 Thread Peter Rosin
On 2019-05-29 18:20, Gustavo A. R. Silva wrote: > One of the more common cases of allocation size calculations is finding > the size of a structure that has a zero-sized array at the end, along > with memory for some number of elements for that array. For example: > > struct foo { > int

Re: [PATCH v2 2/3] i2c-mux-gpio: Unpin the platform-specific GPIOs request code

2019-06-09 Thread Peter Rosin
On 2019-04-26 01:20, Serge Semin wrote: > The GPIOs request loop can be safely moved to a separate function. > First of all it shall improve the code readability. Secondly the > initialization loop at this point is used for both of- and > platform_data-based initialization paths, but it will be

Re: [PATCH v2 1/3] i2c-mux-gpio: Unpin a platform-based device initialization

2019-06-09 Thread Peter Rosin
Thanks for your patches, and sorry for the slow review... On 2019-04-26 01:20, Serge Semin wrote: > We can unpin a code specific for i2c-mux-gpio device declared Unpin? I think the common phrase is "factor out"? That unpin is also present in the subject. BTW, I prefer the subject to start with

Re: [PATCH V4] drivers: i2c: tegra: fix checkpatch defects

2019-06-06 Thread Peter Rosin
On 2019-06-06 09:35, Bitan Biswas wrote: > Fix checkpatch.pl warning(s)/error(s)/check(s) in i2c-tegra.c > > Remove redundant BUG_ON calls or replace with WARN_ON_ONCE > as needed. Replace BUG() with error handling code. > Define I2C_ERR_UNEXPECTED_STATUS for error handling. > > Signed-off-by:

Re: [RFC PATCH 39/57] drivers: mux: Use class_find_device_by_of_node helper

2019-06-03 Thread Peter Rosin
I will try to address it in the next revision. For the record, that patch references some other new function "device_match_of_node" for which I do not have a definition. But with the above link, I was able to find it without too much effort. All looks ok to me, so, if you fix that blank

Re: [RFC PATCH 39/57] drivers: mux: Use class_find_device_by_of_node helper

2019-06-03 Thread Peter Rosin
helper to find a device matching the of_node. > > Cc: Peter Rosin > Signed-off-by: Suzuki K Poulose > --- > drivers/mux/core.c | 8 +--- > 1 file changed, 1 insertion(+), 7 deletions(-) > > diff --git a/drivers/mux/core.c b/drivers/mux/core.c > index d1271c1..3

Re: [PATCH v2 0/3] i2c-mux-gpio: Split plat- and dt-specific code up

2019-05-07 Thread Peter Rosin
On 2019-05-07 11:02, Serge Semin wrote: > Hello folks, > > Any updates on this patchset status? I haven't got any comment on v2, but > instead a notification about the status change was sent to me: > >> * linux-i2c: [v2,1/3] i2c-mux-gpio: Unpin a platform-based device >> initialization >> -

[PATCH 3/3] lib/test_string: add some testcases for strchr and strnchr

2019-05-06 Thread Peter Rosin
Make sure that the trailing NUL is considered part of the string and can be found. Signed-off-by: Peter Rosin --- lib/test_string.c | 77 +++ 1 file changed, 77 insertions(+) diff --git a/lib/test_string.c b/lib/test_string.c index

[PATCH 2/3] lib/test_string: avoid masking memset16/32/64 failures

2019-05-06 Thread Peter Rosin
by always setting a random unused bit in the result on failure. Fixes: 03270c13c5ff ("lib/string.c: add testcases for memset16/32/64") Signed-off-by: Peter Rosin --- lib/test_string.c | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/lib/test_string.c b/lib/test_stri

[PATCH RESEND 3/3] lib/test_string: add some testcases for strchr and strnchr

2019-05-06 Thread Peter Rosin
Make sure that the trailing NUL is considered part of the string and can be found. Signed-off-by: Peter Rosin --- lib/test_string.c | 77 +++ 1 file changed, 77 insertions(+) diff --git a/lib/test_string.c b/lib/test_string.c index

[PATCH RESEND 2/3] lib/test_string: avoid masking memset16/32/64 failures

2019-05-06 Thread Peter Rosin
by always setting a random unused bit in the result on failure. Fixes: 03270c13c5ff ("lib/string.c: add testcases for memset16/32/64") Signed-off-by: Peter Rosin --- lib/test_string.c | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/lib/test_string.c b/lib/test_stri

[PATCH RESEND 1/3] lib/string: allow searching for NUL with strnchr

2019-05-06 Thread Peter Rosin
strchr considers the terminating NUL to be part of the string, and NUL can thus be searched for with that function. For consistency, do the same with strnchr. Signed-off-by: Peter Rosin --- lib/string.c | 11 ++- 1 file changed, 10 insertions(+), 1 deletion(-) diff --git a/lib/string.c

[PATCH RESEND 0/3] lib/string: search for NUL with strchr/strnchr

2019-05-06 Thread Peter Rosin
that signed-off on the memset16/32/64 bug... Cheers, Peter Peter Rosin (3): lib/string: allow searching for NUL with strnchr lib/test_string: avoid masking memset16/32/64 failures lib/test_string: add some testcases for strchr and strnchr lib/string.c | 11 +++- lib/test_string.c

[PATCH 0/3] lib/string: search for NUL with strchr/strnchr

2019-05-06 Thread Peter Rosin
/64 bug... Cheers, Peter Peter Rosin (3): lib/string: allow searching for NUL with strnchr lib/test_string: avoid masking memset16/32/64 failures lib/test_string: add some testcases for strchr and strnchr lib/string.c | 11 +++- lib/test_string.c | 83

  1   2   3   4   5   6   7   8   9   10   >