Re: [PATCH] x32: Mask away the x32 syscall bit in the ptrace codepath

2014-05-28 Thread Philipp Kern
it is set as that's the only identifier it has to deduce that the binary is running in x32 mode. Out of range syscall numbers certainly do not work for auditing right now, hence my attempt to patch around it. Kind regards and thanks Philipp Kern -- To unsubscribe from this list: send the line "uns

Re: [PATCH] x32: Mask away the x32 syscall bit in the ptrace codepath

2014-05-28 Thread Philipp Kern
On Wed, May 28, 2014 at 10:47 PM, Andy Lutomirski wrote: > On 05/28/2014 05:19 AM, Philipp Kern wrote: > > audit_filter_syscall uses the syscall number to reference into a > > bitmask (e->rule.mask[word]). Not removing the x32 bit before passing > > the number to this

[PATCH] x32: Mask away the x32 syscall bit in the ptrace codepath

2014-05-28 Thread Philipp Kern
ing on the syscall path. Cc: linux-kernel@vger.kernel.org Cc: H. J. Lu Cc: Eric Paris Signed-off-by: Philipp Kern --- arch/x86/kernel/ptrace.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/arch/x86/kernel/ptrace.c b/arch/x86/kernel/ptrace.c index 678c0ad..166a3c7 100644 --- a/arch/

Re: [PATCH] x32: Mask away the x32 syscall bit in the ptrace codepath

2014-05-28 Thread Philipp Kern
On Wed, May 28, 2014 at 10:47 PM, Andy Lutomirski l...@amacapital.net wrote: On 05/28/2014 05:19 AM, Philipp Kern wrote: audit_filter_syscall uses the syscall number to reference into a bitmask (e-rule.mask[word]). Not removing the x32 bit before passing the number to this architecture

Re: [PATCH] x32: Mask away the x32 syscall bit in the ptrace codepath

2014-05-28 Thread Philipp Kern
is set as that's the only identifier it has to deduce that the binary is running in x32 mode. Out of range syscall numbers certainly do not work for auditing right now, hence my attempt to patch around it. Kind regards and thanks Philipp Kern -- To unsubscribe from this list: send the line

[PATCH] x32: Mask away the x32 syscall bit in the ptrace codepath

2014-05-28 Thread Philipp Kern
depending on the syscall path. Cc: linux-kernel@vger.kernel.org Cc: H. J. Lu hjl.to...@gmail.com Cc: Eric Paris epa...@redhat.com Signed-off-by: Philipp Kern pk...@google.com --- arch/x86/kernel/ptrace.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/arch/x86/kernel/ptrace.c b/arch

[PATCH] x32: Mask the syscall number before passing it to audit

2014-05-26 Thread Philipp Kern
nel if the out of bound location is not mapped: BUG: unable to handle kernel paging request at 8800e5446630 IP: [] audit_filter_syscall+0x90/0xf0 Cc: linux-kernel@vger.kernel.org Cc: H. J. Lu Signed-off-by: Philipp Kern --- arch/x86/kernel/entry_64.S | 3 +++ 1 file changed, 3 inserti

[PATCH] x32: Mask the syscall number before passing it to audit

2014-05-26 Thread Philipp Kern
if the out of bound location is not mapped: BUG: unable to handle kernel paging request at 8800e5446630 IP: [810fcdd0] audit_filter_syscall+0x90/0xf0 Cc: linux-kernel@vger.kernel.org Cc: H. J. Lu hjl.to...@gmail.com Signed-off-by: Philipp Kern pk...@google.com --- arch/x86/kernel

Re: [PATCH] net: move "IPv6: sending pkt_too_big to self" to NETDEBUG

2012-07-29 Thread Philipp Kern
On Sat, Jul 28, 2012 at 10:29:20AM -0700, Joe Perches wrote: > On Sat, 2012-07-28 at 17:06 +0200, Philipp Kern wrote: > > ip6_xmit checks if the outgoing packet is larger than the path MTU and > > emits ICMPv6 packet too big locally if this is the case. Logging this, > &g

Re: [PATCH] net: move IPv6: sending pkt_too_big to self to NETDEBUG

2012-07-29 Thread Philipp Kern
On Sat, Jul 28, 2012 at 10:29:20AM -0700, Joe Perches wrote: On Sat, 2012-07-28 at 17:06 +0200, Philipp Kern wrote: ip6_xmit checks if the outgoing packet is larger than the path MTU and emits ICMPv6 packet too big locally if this is the case. Logging this, even at KERN_DEBUG, confuses

[PATCH] net: move "IPv6: sending pkt_too_big to self" to NETDEBUG

2012-07-28 Thread Philipp Kern
this event. Hence move this message to LIMIT_NETDEBUG, as suggested by Andi Kleen back in 2001 (<20010215231715.26...@colin.muc.de>). Signed-off-by: Philipp Kern --- net/ipv6/ip6_output.c |2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/net/ipv6/ip6_output.c b/ne

[PATCH] net: move IPv6: sending pkt_too_big to self to NETDEBUG

2012-07-28 Thread Philipp Kern
this event. Hence move this message to LIMIT_NETDEBUG, as suggested by Andi Kleen back in 2001 (20010215231715.26...@colin.muc.de). Signed-off-by: Philipp Kern pk...@debian.org --- net/ipv6/ip6_output.c |2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/net/ipv6/ip6_output.c b/net