Re: [PATCH 2/3] ARM: tegra: apalis-tk1: Add SPDX license (GPL-2.0 OR X11) identifiers

2018-07-19 Thread Philippe Ombredanne
git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git/tree/LICENSES/other/X11?h=v4.18-rc5 [2] https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git/tree/LICENSES/preferred/MIT?h=v4.18-rc5 -- Cordially Philippe Ombredanne

Re: [PATCH 2/4] clocksource: timer-imx-gpt: Switch to SPDX identifier

2018-05-29 Thread Philippe Ombredanne
(C) 2006-2007 Pavel Pisa (pp...@pikron.com) >> +// Copyright (C) 2008 Juergen Beisert (ker...@pengutronix.de) > > Hi Philippe, > > I went through the code and didn't find any information about the format > of the lines following the SPDX, it seems it is relatively free. > >

Re: [patch V2 7/7] scripts: Add SPDX checker script

2018-05-14 Thread Philippe Ombredanne
ull kernel tree. > > It checks whether the license expression syntax is correct and also > validates whether the license identifiers used in the expressions are > available in the LICENSES files. Looking good to me! And the use of ply is sleek. -- Cordially Philippe Ombredanne

Re: [PATCH v3] ata: add Amiga Gayle PATA controller driver

2018-03-23 Thread Philippe Ombredanne
Tejun, On Mon, Mar 19, 2018 at 7:41 AM, Tejun Heo <t...@kernel.org> wrote: > Hello, > > On Sat, Mar 17, 2018 at 10:24:18PM -0700, Philippe Ombredanne wrote: >> > v2: >> > - clarify license version (it should be GPL 2.0) >> > - use SPDX header >> &g

Re: [PATCH 1/5 v4] add compression algorithm zBeWalgo

2018-03-21 Thread Philippe Ombredanne
d mean GPL-2.0+ (e.g. or any later version) and this would not match your top level license tag. I know this may seem confusing, but there is little hope we can change the MODULE_LICENSE tags that are used by many external module loaders. Comments in module.h explain it all. -- Cordially Philippe Ombredanne

Re: [PATCH 1/5 v4] add compression algorithm zBeWalgo

2018-03-20 Thread Philippe Ombredanne
ame thing in the MODULE_LICENSE and your SPDX tags. [1] https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git/tree/Documentation/process/license-rules.rst [2] https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git/tree/include/linux/module.h#n175 -- Cordially Philippe Ombredanne

Re: [PATCH v3] ata: add Amiga Gayle PATA controller driver

2018-03-17 Thread Philippe Ombredanne
il.com> > Cc: Geert Uytterhoeven <ge...@linux-m68k.org> > Cc: Philippe Ombredanne <pombreda...@nexb.com> > Cc: Andy Shevchenko <andy.shevche...@gmail.com> > Signed-off-by: Bartlomiej Zolnierkiewicz <b.zolnier...@samsung.com> > --- > v3: > - fix minor is

Re: [PATCH v0 1/3] livepatch: add sample cumulative patch

2018-03-01 Thread Philippe Ombredanne
Miroslav, On Tue, Feb 27, 2018 at 3:54 AM, Miroslav Benes <mbe...@suse.cz> wrote: > On Sat, 24 Feb 2018, Philippe Ombredanne wrote: > >> Joe, >> >> On Fri, Feb 23, 2018 at 1:33 PM, Joe Lawrence <joe.lawre...@redhat.com> >> wrote: >> > Add a s

Re: [PATCH v6 03/20] firmware: arm_scmi: add basic driver infrastructure for SCMI

2018-02-26 Thread Philippe Ombredanne
ore details. > + * > + * You should have received a copy of the GNU General Public License along > + * with this program. If not, see <http://www.gnu.org/licenses/>. > + */ Would you consider using the SPDX tags [1] instead of this legalese? Thanks! [1] https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git/tree/Documentation/process/license-rules.rst -- Cordially Philippe Ombredanne

Re: [PATCH v0 1/3] livepatch: add sample cumulative patch

2018-02-24 Thread Philippe Ombredanne
Joe, On Fri, Feb 23, 2018 at 1:33 PM, Joe Lawrence wrote: > Add a simple atomic replace / cumulative livepatch example. > > Signed-off-by: Joe Lawrence > --- > samples/livepatch/Makefile | 1 + >

Re: [PATCH 08/10] gpio: Add gpio driver for Actions OWL S900 SoC

2018-02-19 Thread Philippe Ombredanne
E_LICENSE("GPL v2"); Please sync this with your SPDX id above. nodule.h has the doc on the meaning of MODULE_LICENSE macros. Here you have stated a combo of GPL-2.0 and GPL-2.0 or later -- Cordially Philippe Ombredanne

Re: [PATCH 04/10] pinctrl: actions: Add Actions S900 pinctrl driver

2018-02-19 Thread Philippe Ombredanne
ll > +++ b/drivers/pinctrl/actions/pinctrl-s900.c > @@ -0,0 +1,2536 @@ > +// SPDX-License-Identifier: GPL-2.0+ > +MODULE_LICENSE("GPL v2"); This does not match your license above. Per module.h "GPL v2" means GPL-2.0 where you license above GPL-2.0+ means or later -- Cordially Philippe Ombredanne

Re: [PATCH v3 2/2] net: ethernet: nixge: Add support for National Instruments XGE netdev

2018-02-19 Thread Philippe Ombredanne
/dev/null > +++ b/drivers/net/ethernet/ni/nixge.c > @@ -0,0 +1,1352 @@ > +// SPDX-License-Identifier: GPL-2.0 > +MODULE_LICENSE("GPL"); This does not match your license above. Per module.h "GPL" would mean "GPL-2.0+" Can you use one or the other an\d ensure both of these are in sync? -- Cordially Philippe Ombredanne

Re: [PATCH] auxdisplay: Replace licenses with SPDX identifiers

2018-02-19 Thread Philippe Ombredanne
On Sun, Feb 18, 2018 at 9:18 PM, Joe Perches <j...@perches.com> wrote: > On Sun, 2018-02-18 at 20:37 +0100, Geert Uytterhoeven wrote: >> Hi Philippe, >> >> On Sun, Feb 18, 2018 at 8:04 PM, Philippe Ombredanne >> <pombreda...@nexb.com> wrote: >> &g

Re: [RFCv4 09/21] v4l2: add request API support

2018-02-19 Thread Philippe Ombredanne
/scm/linux/kernel/git/torvalds/linux.git/tree/Documentation/process/license-rules.rst -- Cordially Philippe Ombredanne

Re: [PATCH v7 15/61] xarray: Add xa_load

2018-02-19 Thread Philippe Ombredanne
our group! [1] https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git/tree/Documentation/process/license-rules.rst -- Cordially Philippe Ombredanne

Re: [v3,04/11] watchdog/hpwdt: white space changes

2018-02-19 Thread Philippe Ombredanne
you can redistribute it and/or >> * modify it under the terms of the GNU General Public License It would be awesome if you could adopt SPDX ids here and in all HPE existing and future contributions [1] rather than this fine legalese. [1] https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git/tree/Documentation/process/license-rules.rst -- Cordially Philippe Ombredanne

Re: [PATCH 05/17] trace doc: convert trace/ftrace.txt to rst format

2018-02-19 Thread Philippe Ombredanne
+:Author: Steven Rostedt <srost...@redhat.com> > +:License: The GNU Free Documentation License, Version 1.2 > + (dual licensed under the GPL v2) Do you mind using an SPDX id per [1] rather that this? Steven, are you OK with this? Can you ack? [1] https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git/tree/Documentation/process/license-rules.rst -- Cordially Philippe Ombredanne

Re: [PATCH 2/4] ARM: OMAP2+: Introduce low-level suspend code for AM43XX

2018-02-19 Thread Philippe Ombredanne
Do you mind using SPDX tags per [1] rather that this fine but long legalese here and in the whole patch set? Unless you are a legalese lover of course! [1] https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git/tree/Documentation/process/license-rules.rst -- Cordially Philippe Ombredanne

Re: [PATCH] auxdisplay: Replace licenses with SPDX identifiers

2018-02-18 Thread Philippe Ombredanne
kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git/tree/Documentation/process/license-rules.rst -- Cordially Philippe Ombredanne

Re: [PATCH v4] rtc: isl12026: Add driver.

2018-02-18 Thread Philippe Ombredanne
icense-Identifier: GPL-2.0 > +MODULE_LICENSE("GPL"); Your MODULE_LICENSE does not match your SPDX tag. Per module.h, GPL would mean GPL-2.0+ not GPL-2.0 It would be best if you can sync the two. -- Cordially Philippe Ombredanne

Re: [PATCH v3 6/7] arm64: tegra: Add Tegra194 chip device tree

2018-02-16 Thread Philippe Ombredanne
tegra194-reset.h > @@ -0,0 +1,155 @@ > +/* > + * Copyright (c) 2018, NVIDIA CORPORATION. All rights reserved. > + * > + * SPDX-License-Identifier: GPL-2.0 > + */ Same as above -- Cordially Philippe Ombredanne

Re: [PATCH v2 1/1] clk: npcm7xx: add clock controler. fixed clock at DT

2018-02-16 Thread Philippe Ombredanne
s... This has been discussed on list and is what Linus prefers. [1] https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git/tree/Documentation/process/license-rules.rst -- Cordially Philippe Ombredanne

Re: [PATCHv4 2/4] ASoC: codec: cpcap: new codec

2018-02-15 Thread Philippe Ombredanne
ou notice above is GPL-2.0, not "or later" [1] https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git/tree/Documentation/process/license-rules.rst -- Cordially Philippe Ombredanne

Re: [PATCH v5 10/12] drm/sun4i: Implement A83T HDMI driver

2018-02-14 Thread Philippe Ombredanne
.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git/tree/Documentation/process/license-rules.rst -- Cordially Philippe Ombredanne

Re: [PATCH v3 4/8] MIPS: mscc: Add initial support for Microsemi MIPS SoCs

2018-02-14 Thread Philippe Ombredanne
repeats the SPDX-License-Identifier: (GPL-2.0 OR MIT) line in a less clear and precise way. The whole purpose of the SPDX things is to make licensing eventually as clear ass possible Thanks! -- Cordially Philippe Ombredanne

Re: [PATCH v3 1/2] ASoC: codecs: Add support for AK4458 DAC driver

2018-02-14 Thread Philippe Ombredanne
codecs/ak4458.h b/sound/soc/codecs/ak4458.h > new file mode 100644 > index 000..16d9d22 > --- /dev/null > +++ b/sound/soc/codecs/ak4458.h > @@ -0,0 +1,86 @@ > +// SPDX-License-Identifier: GPL-2.0 As weird as it sounds the style should be plain /* SPDX-License-Identifier: GPL-2.0 /* here per [1] [1] https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git/tree/Documentation/process/license-rules.rst -- Cordially Philippe Ombredanne

Re: [PATCH 1/3] HID: add driver for Valve Steam Controller

2018-02-14 Thread Philippe Ombredanne
option) >> + * any later version. >> + */ Rodrigo, Since you used the proper SPDX tag (in the proper style as explained in the doc), you can remove this boilerplate alright as it does double duty with the tag. -- Cordially Philippe Ombredanne

Re: [PATCH 05/15] ARM64: dts: Add R-Car Salvator-x M3-N support

2018-02-14 Thread Philippe Ombredanne
- /dev/null >> +++ b/arch/arm64/boot/dts/renesas/r8a77965.dtsi >> @@ -0,0 +1,495 @@ >> +// SPDX-License-Identifier: GPL-2. This should be GPL-2.0 too. -- Cordially Philippe Ombredanne

Re: [PATCH 4/4] staging: iio: accel: Move adis16201 driver out of staging

2018-02-12 Thread Philippe Ombredanne
On Mon, Feb 12, 2018 at 3:37 PM, Himanshu Jha <himanshujha199...@gmail.com> wrote: > On Mon, Feb 12, 2018 at 03:10:56PM +0100, Philippe Ombredanne wrote: >> On Mon, Feb 12, 2018 at 12:54 PM, Himanshu Jha >> <himanshujha199...@gmail.com> wrote: >> > Move

Re: [PATCH] ata: add Amiga Gayle PATA controller driver

2018-02-12 Thread Philippe Ombredanne
ENSE("GPL"); > +MODULE_ALIAS("platform:amiga-gayle-ide"); > +MODULE_VERSION(DRV_VERSION); > and while doing it please make sure your MODULE_LICENSE matches the license. Here for instance it is not clear to me if this a GPL-2.0 or a GPL-2.0+ Thanks! [1] https://gi

Re: [PATCH 2/6] mfd: Add ST Multi-Function eXpander core driver

2018-02-12 Thread Philippe Ombredanne
of the licensing > agreement. Also, please grep for "SPDX". You can check the doc for the (fairly new) way to remove legalese boilerplate at Documentation/process/license-rules.rst or [1] It helps keep the focus on the code and less on licensing! [1] https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git/tree/Documentation/process/license-rules.rst -- Cordially Philippe Ombredanne

Re: [PATCH 4/4] staging: iio: accel: Move adis16201 driver out of staging

2018-02-12 Thread Philippe Ombredanne
); > +MODULE_LICENSE("GPL v2"); > +MODULE_ALIAS("spi:adis16201"); Your MODULE_LICENSE does not match your SPDX license id. MODULE_LICENSE("GPL v2"); means SPDX GPL-2.0 MODULE_LICENSE("GPL"); means SPDX GPL-2.0+ -- Cordially Philippe Ombredanne

Re: [RFC PATCH] soc: zynqmp: Add support for tap delay settings

2018-02-12 Thread Philippe Ombredanne
icenses/>. > + */ Dear Manish, Why not using the SPDX ids there too and elsewhere? You are using them alright in many other places in this patch. See Documentation/process/license-rules.rst for details -- Cordially Philippe Ombredanne

Re: [PATCH 14/17] s390/kexec_file: Add kexec_file_load system call

2018-02-12 Thread Philippe Ombredanne
-2.0 See Documentation/process/license-rules.rst for why. -- Cordially Philippe Ombredanne

Re: [PATCH v3 2/3] arm64: dts: sdm845: Add minimal dts files for sdm845 SoC/MTP

2018-02-12 Thread Philippe Ombredanne
Linux Foundation. All rights reserved. > + */ This is more cosmetic, but since there is only a single line of copyright statement and no other comments, it would make sense to use C++ style // for that line too IMHO (and other similar cases) -- Cordially Philippe Ombredanne

Re: [PATCH v2 04/11] watchdog/hpwdt: white space changes

2018-02-12 Thread Philippe Ombredanne
updating the licensing to use the new concise SPDX ids instead? [1] And you get a big good karma bonus if you can also do the same for all HPE-copyrighted files, tree-wide ;) and/or spread the word inside your team. Thank you for your kind consideration! [1] https://git.kernel.org/pub/sc

Re: [PATCH v5 01/11] scsi: ufs: sysfs: attribute group for existing sysfs entries.

2018-02-12 Thread Philippe Ombredanne
then we can fix it with a patch ;) CC: Russell King <r...@armlinux.org.uk> CC: Christoph Hellwig <h...@infradead.org> CC: Thomas Gleixner <t...@linutronix.de> [1] https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git/tree/Documentation/process/license-rules.rst -- Cordially Philippe Ombredanne

Re: [linux-sunxi] [PATCH v2 5/6] arm64: allwinner: h6: add the basical Allwinner H6 DTSI file

2018-02-12 Thread Philippe Ombredanne
* SPDX-License-Identifier: (GPL-2.0+ or MIT) >> + */ Thank you for using SPDX ids: this needs to be on the first line though! [1] and eventually some special comments style. [1] https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git/tree/Documentation/process/license-rules.rst -- Cordially Philippe Ombredanne

Re: [PATCH 2/6] genalloc: selftest

2018-02-11 Thread Philippe Ombredanne
00 @@ > +/* SPDX-License-Identifier: GPL-2.0 And for a comment in .c this line should use C++ style as the first line: > +// SPDX-License-Identifier: GPL-2.0 Please check the docs for this (I know this can feel surprising but this has been debated at great length on list) Thank you! -- Cordially Philippe Ombredanne

Re: [PATCH] watchdog: coh901327: make license text and module licence match

2018-02-10 Thread Philippe Ombredanne
<linus.wall...@stericsson.com> > */ > @@ -420,5 +420,5 @@ MODULE_DESCRIPTION("COH 901 327 Watchdog"); > module_param(margin, uint, 0); > MODULE_PARM_DESC(margin, "Watchdog margin in seconds (default 60s)"); > > -MODULE_LICENSE("GPL"); > +MODULE_LICENSE("GPL v2"); > MODULE_ALIAS("platform:coh901327-watchdog"); Thank you! Reviewed-by: Philippe Ombredanne <pombreda...@nexb.com> -- Cordially Philippe Ombredanne

Re: [PATCH 5/6] ARM: dts: tegra: apalis-tk1: copyright period, spurious newlines

2018-02-10 Thread Philippe Ombredanne
proper. That's the way to go and thank you for this. Do not hesitate to ping here or privately if there is any legal concern that comes up. -- Cordially Philippe Ombredanne

Re: [PATCH v3 01/11] dt-bindings: clock: Add Actions S900 clock bindings

2018-02-09 Thread Philippe Ombredanne
el code: incredible, right? Thank you for helping make the kernel a mostly legalese-free codebase and saving trees at the same time! [1] https://www.sierraclub.org/sierra/2014-4-july-august/green-life/how-much-paper-does-one-tree-produce -- Cordially Philippe Ombredanne

Re: [PATCH 5/6] ARM: dts: tegra: apalis-tk1: copyright period, spurious newlines

2018-02-09 Thread Philippe Ombredanne
And you will get extra good karma point if you feel like doing the same for every Toradex-copyrighted files ;) The (still new and fresh) license documentation contributed by tglx --the only real-time docu-mentalist-- is in: Documentation/process/license-rules.rst Thanks! -- Cordially Philippe Ombredanne

Re: [PATCH 1/2] dt-bindings: clock: reset: Add AXG AO Clock and Reset Bindings

2018-02-09 Thread Philippe Ombredanne
fier: (GPL-2.0+ OR BSD) */ nit... BSD is not a valid license id as documented in LICENSES [1] : please use one of these: BSD-2-Clause or BSD-3-Clause Thank you! [1] https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git/tree/LICENSES/preferred -- Cordially Philippe Ombredanne

Re: [PATCH v6] checkpatch.pl: Add SPDX license tag check

2018-02-08 Thread Philippe Ombredanne
} >> > + >> > + if ($comment !~ /^$/ && >> > + $rawline !~ /^\+\Q$comment\E >> > SPDX-License-Identifier: /) { >> > + WARN("SPDX_LICENSE_TAG", >> > +"Missing or malformed >> > SPDX-License-Identifier tag in line $checklicenseline\n" . $herecurr); >> > + } >> > + } >> > + } >> > + >> > # check we are in a valid source file if not then ignore this hunk >> > next if ($realfile !~ /\.(h|c|s|S|sh|dtsi|dts)$/); >> > BTW I forgot this if you like to add it: Acked-by: Philippe Ombredanne <pombreda...@nexb.com>

Re: [PATCH v6] checkpatch.pl: Add SPDX license tag check

2018-02-08 Thread Philippe Ombredanne
Joe, On Thu, Feb 8, 2018 at 6:24 PM, Joe Perches <j...@perches.com> wrote: > On Thu, 2018-02-08 at 15:35 +0100, Philippe Ombredanne wrote: >> However checking that licenses ids are known and listed in the kernel >> doc is essential IMHO to avoid drift and insulate the kernel

Re: [PATCH v2] drm/bridge/synopsys: dsi: Adopt SPDX identifiers

2018-02-08 Thread Philippe Ombredanne
0+" following comments from Laurent > Pinchart, Benjamin Gaignard & Philippe Ombredanne. > > drivers/gpu/drm/bridge/synopsys/dw-mipi-dsi.c | 6 +- > 1 file changed, 1 insertion(+), 5 deletions(-) > > diff --git a/drivers/gpu/drm/bridge/synopsys/dw-mipi-dsi.c > b/d

Re: [PATCH v2 05/16] arm64: dts: mt7622: add PMIC MT6380 related nodes

2018-02-08 Thread Philippe Ombredanne
to resue the configuration. > > Signed-off-by: Sean Wang <sean.w...@mediatek.com> > Cc: Mark Brown <broo...@kernel.org> > Cc: Matthias Brugger <matthias@gmail.com> > Cc: Philippe Ombredanne <pombreda...@nexb.com> Thank you for the use of SPDX licenses ids! Acked-by: Philippe Ombredanne <pombreda...@nexb.com>

Re: [PATCH v6] checkpatch.pl: Add SPDX license tag check

2018-02-08 Thread Philippe Ombredanne
e I'm too optimistic about what can be taken as legal advice or not, > but I would expect that a warning about unmatched license type does not > constitute legal advice. > > Is it too optimistic? :-D That's very reasonable IMHO and this not legal advice alright to me. This would be just a tool that warns you that your license expression does not match known licenses in the kernel. -- Cordially Philippe Ombredanne

Re: [PATCH v6] checkpatch.pl: Add SPDX license tag check

2018-02-08 Thread Philippe Ombredanne
I tried to fight these as much as I could. One id for one license at a time is the only sane way to go. -- Cordially Philippe Ombredanne

Re: [PATCH v6] checkpatch.pl: Add SPDX license tag check

2018-02-08 Thread Philippe Ombredanne
ate the doc accordingly. and until we update ALL the GPL-2.0 to GPL-2.0-only eventually which is best done at once. Otherwise, this is going to be a total mess on top of a complicated topic that requires quite a bit of maintainer energy! [1] https://github.com/nexB/license-expression/ -- Cordially Philippe Ombredanne

Re: [PATCH] checkpatch.pl: Add SPDX license tag check

2018-02-08 Thread Philippe Ombredanne
> comment style for the file type. > > Cc: Andy Whitcroft <a...@canonical.com> > Cc: Joe Perches <j...@perches.com> > Cc: Greg Kroah-Hartman <gre...@linuxfoundation.org> > Cc: Thomas Gleixner <t...@linutronix.de> > Cc: Philippe Ombredanne <pombreda...@nex

Re: [PATCH] PCI: Add SPDX GPL-2.0+ to replace implicit GPL v2 or later statement

2018-02-08 Thread Philippe Ombredanne
t; +// SPDX-License-Identifier: GPL-2.0+ > /* > * PCI Hot Plug Controller Driver for System z > * > @@ -5,8 +6,6 @@ > * > * Author(s): > * Jan Glauber <j...@linux.vnet.ibm.com> > - * > - * License: GPL > */ > > #define KMSG_COMPONENT "zpci" Thanks! I have CCed too: Jan Glauber <j...@linux.vnet.ibm.com> too just in case! Reviewed-by: Philippe Ombredanne <pombreda...@nexb.com>

Re: [PATCH] PCI: Add SPDX tag for s390_pci_hpc.c

2018-02-08 Thread Philippe Ombredanne
xt e.g. here GPL-2.0+ rather than a less common GPL-1.0+ Thank you for your efforts there! -- Cordially Philippe Ombredanne

Re: [PATCH 0/4] PCI: Add SPDX tags

2018-02-08 Thread Philippe Ombredanne
left it unchanged. This is the way to go when there are ambiguities alright. One interpretation of a bare GPL is GPL-1.0+ but the context matters a lot! -- Cordially Philippe Ombredanne

Re: [PATCH] drm/bridge/synopsys: dsi: Adopt SPDX identifiers

2018-02-08 Thread Philippe Ombredanne
ined in Documentation/ >> process/license-rules.txt. The file might get updated to use GPL-2.0-or-later >> and GPL-2.0-only later, and kernel sources will likely then get patched in >> one >> go. > > + Philippe O. to check what I'm writing just below. > > In -next branch I only see reference to GPL-2.0+ identifier so for me > it fine to use it here. > Is that right ? or should we use GPL-2.0-or-later keyword ? Sorry for the late reply! IMHO it is essential to stick to what is in the kernel doc, meaning that you should not use the GPL-2.0-or-later identifier until it is part of the kernel doc. Otherwise this is going to be a mess ;) Consistency matters a lot. -- Cordially Philippe Ombredanne

Re: [PATCH 2/8] thermal/drivers/cpu_cooling: Add Software Package Data Exchange (SPDX)

2018-02-08 Thread Philippe Ombredanne
Daniel, On Tue, Jan 23, 2018 at 4:34 PM, Daniel Lezcano <daniel.lezc...@linaro.org> wrote: > For license auditing purpose, let's add the SPDX tag. > > Cc: Philippe Ombredanne <pombreda...@nexb.com> > Signed-off-by: Daniel Lezcano <daniel.lezc...@linaro.org> > ---

Re: [PATCH 05/12] arm64: dts: mt7622: add PMIC MT6380 related nodes

2018-01-23 Thread Philippe Ombredanne
/ > 4) > no issue, Makefile, or Kconfig, definitely applied with "# " at head That's the correct way. So the net-net is that these "style bugs" should be fixed. -- Cordially Philippe Ombredanne

Re: [PATCH v6 15/15] MIPS: ingenic: Initial GCW Zero support

2018-01-23 Thread Philippe Ombredanne
Paul: On Wed, Jan 10, 2018 at 11:59 PM, Paul Cercueil <p...@crapouillou.net> wrote: > Hi Philippe, > > Le dim. 7 janv. 2018 à 17:18, Philippe Ombredanne <pombreda...@nexb.com> a > écrit : >> >> On Fri, Jan 5, 2018 at 7:25 PM, Paul Cercueil <p...@crapouill

Re: [PATCH v4 3/9] v4l: platform: Add Renesas CEU driver

2018-01-23 Thread Philippe Ombredanne
On Fri, Jan 12, 2018 at 2:38 PM, jacopo mondi <jac...@jmondi.org> wrote: > Hi Philippe, Laurent, Geert, > > On Fri, Jan 12, 2018 at 11:36:31AM +0100, Philippe Ombredanne wrote: >> On Tue, Jan 9, 2018 at 5:25 PM, Jacopo Mondi <jacopo+rene...@jmondi.org> >> w

Re: [PATCH v4 3/9] v4l: platform: Add Renesas CEU driver

2018-01-12 Thread Philippe Ombredanne
nstead: > +MODULE_LICENSE("GPL v2"); ... to match your > +// SPDX-License-Identifier: GPL-2.0 I know this can be confusing, but updating the MODULE_LICENSE tags definitions in module.h to match SPDX tags is unlikely to happen as it would create mayhem for everyone and every module loader relying on this established convention. -- Cordially Philippe Ombredanne

Re: [PATCH v3 07/13] arm64: Add skeleton to harden the branch predictor against aliasing attacks

2018-01-09 Thread Philippe Ombredanne
sider using the new SDPX tags [1] instead of this long legalese? Thanks! [1] https://lkml.org/lkml/2017/12/28/323 -- Cordially Philippe Ombredanne

Re: [RFC PATCH 2/2] drivers: clk: Add ZynqMP clock driver

2018-01-09 Thread Philippe Ombredanne
Jolly, On Mon, Jan 8, 2018 at 11:16 PM, Jolly Shah wrote: > This patch adds CCF compliant clock driver for ZynqMP. > Clock driver queries supported clock information from > firmware and regiters pll and output clocks with CCF. > > Signed-off-by: Jolly Shah

Re: [RFC PATCH] drivers: soc: xilinx: Add ZynqMP power domain driver

2018-01-09 Thread Philippe Ombredanne
support > + * > + * Copyright (C) 2014-2017 Xilinx, Inc. > + * > + * Davorin Mista <davorin.mi...@aggios.com> > + * Jolly Shah <jol...@xilinx.com> > + * Rajan Vaja <raj...@xilinx.com> > + * > + * SPDX-License-Identifier: GPL-2.0+ > + */ This

Re: [PATCH] drivers: firmware: xilinx: Add ZynqMP firmware driver

2018-01-09 Thread Philippe Ombredanne
> > --- /dev/null > +++ b/drivers/firmware/xilinx/Kconfig > @@ -0,0 +1,4 @@ > +# SPDX-License-Identifier: GPL-2.0+ Thank you++ for using the SPDX tags: here is my cheerful ack for this: Acked-by: Philippe Ombredanne <pombreda...@nexb.com>

Re: [PATCH v6 4/9] drm: Add some HDCP related #defines

2018-01-09 Thread Philippe Ombredanne
C) 2017 Google, Inc. > + * > + * Authors: > + * Sean Paul <seanp...@chromium.org> > + */ Thank you++ for using the SPDX tags! Acked-by: Philippe Ombredanne <pombreda...@nexb.com> -- Cordially Philippe Ombredanne

Re: [PATCH v4] selftest/vm: Move the 128 TB mmap boundary test to the generic VM directory

2018-01-08 Thread Philippe Ombredanne
but > + * WITHOUT ANY WARRANTY; without even the implied warranty of > + * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. > + * > + */ Would you mind using an SPDX tag instead of this fine legalese? See Thomas doc [1] for details. Thanks! [1] https://lkml.org/lkml/2017/12/28/323 -- Cordially Philippe Ombredanne

Re: [PATCH v5 5/9] drm/i915: Add HDCP framework + base implementation

2018-01-08 Thread Philippe Ombredanne
of this fine but long legalese? See Thomas doc [1] for details. Thanks! [1] https://lkml.org/lkml/2017/12/28/323 -- Cordially Philippe Ombredanne

Re: [PATCH v3 1/3] PCI/AER: factor out error reporting from AER

2018-01-08 Thread Philippe Ombredanne
> + * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the > + * GNU General Public License for more details. > + */ Do you mind using an SPDX tag there instead of this fine legalese? -- Cordially Philippe Ombredanne

Re: [PATCH 6/7] arm64: allwinner: h6: add the basical Allwinner H6 DTSI file

2018-01-07 Thread Philippe Ombredanne
N ACTION OF CONTRACT, TORT OR OTHERWISE, ARISING > + * FROM, OUT OF OR IN CONNECTION WITH THE SOFTWARE OR THE USE OR > + * OTHER DEALINGS IN THE SOFTWARE. > + */ Icenowy, This is a very long legalese indeed! Do you mind using the new concise SPDX tags instead here and in the rest of your patch? See Thomas doc [1] Thanks! [1] https://lkml.org/lkml/2017/12/28/323 -- Cordially Philippe Ombredanne

Re: [PATCH v6 15/15] MIPS: ingenic: Initial GCW Zero support

2018-01-07 Thread Philippe Ombredanne
custom CROSS_COMPILE from defconfig > v6: Add "model" property in devicetree For the use of SPDX tags for the whole patch set: thank you! Acked-by: Philippe Ombredanne <pombreda...@nexb.com> -- Cordially Philippe Ombredanne

Re: [PATCH v2 01/27] staging: ccree: SPDXify driver

2018-01-07 Thread Philippe Ombredanne
Gilad, On Sun, Jan 7, 2018 at 11:13 AM, Gilad Ben-Yossef <gi...@benyossef.com> wrote: > On Wed, Jan 3, 2018 at 5:01 PM, Philippe Ombredanne > <pombreda...@nexb.com> wrote: >> Gilad, >> >> On Wed, Jan 3, 2018 at 2:35 PM, Gilad Ben-Yossef <gi...@benyossef.

Re: [PATCH v3 1/1] runchecks: Generalize make C={1,2} to support multiple checkers

2018-01-07 Thread Philippe Ombredanne
t;>> > +# >>> > +# This program is free software; you can redistribute it and/or modify >>> > +# it under the terms of the GNU General Public License version 2 >>> > +# as published by the Free Software Foundation. >>> > + but then please DRY: do not add this extra legalese which is redundant. -- Cordially Philippe Ombredanne

Re: [PATCH v2 1/6] ARM: at91: add TCB registers definitions

2018-01-07 Thread Philippe Ombredanne
See the GNU General Public License for > + * more details. > + * > + * You should have received a copy of the GNU General Public License along > with > + * this program. If not, see <http://www.gnu.org/licenses/>. > + */ Alexandre, Would you mind using SPDx tags here like you did in /drivers/clocksource/timer-atmel-tcb.c ? Thanks! -- Cordially Philippe Ombredanne

Re: [PATCH 05/12] arm64: dts: mt7622: add PMIC MT6380 related nodes

2018-01-05 Thread Philippe Ombredanne
Sean, On Fri, Jan 5, 2018 at 4:42 AM, Sean Wang <sean.w...@mediatek.com> wrote: > On Thu, 2018-01-04 at 11:27 +0100, Philippe Ombredanne wrote: >> Sean, >> >> On Thu, Jan 4, 2018 at 10:40 AM, <sean.w...@mediatek.com> wrote: >> > From: Sean Wang <s

Re: [PATCH] of: Use SPDX license tag for DT files

2018-01-04 Thread Philippe Ombredanne
ed by the Free Software Foundation. > */ > #ifndef __LINUX_OF_GRAPH_H > #define __LINUX_OF_GRAPH_H > diff --git a/include/linux/of_pdt.h b/include/linux/of_pdt.h > index 7e09244bb679..d0b183ab65c6 100644 > --- a/include/linux/of_pdt.h > +++ b/include/linux/of_pdt.h > @@ -1,13 +1,9 @@ > +/* SPDX-License-Identifier: GPL-2.0+ */ > /* > * Definitions for building a device tree by calling into the > * Open Firmware PROM. > * > * Copyright (C) 2010 Andres Salomon <dilin...@queued.net> > - * > - * This program is free software; you can redistribute it and/or > - * modify it under the terms of the GNU General Public License > - * as published by the Free Software Foundation; either version > - * 2 of the License, or (at your option) any later version. > */ > > #ifndef _LINUX_OF_PDT_H > diff --git a/include/linux/of_platform.h b/include/linux/of_platform.h > index fb908e598348..84a966623e78 100644 > --- a/include/linux/of_platform.h > +++ b/include/linux/of_platform.h > @@ -1,14 +1,9 @@ > +/* SPDX-License-Identifier: GPL-2.0+ */ > #ifndef _LINUX_OF_PLATFORM_H > #define _LINUX_OF_PLATFORM_H > /* > *Copyright (C) 2006 Benjamin Herrenschmidt, IBM Corp. > * <b...@kernel.crashing.org> > - * > - * This program is free software; you can redistribute it and/or > - * modify it under the terms of the GNU General Public License > - * as published by the Free Software Foundation; either version > - * 2 of the License, or (at your option) any later version. > - * > */ > > #include > -- > 2.14.1 > Reviewed-by: Philippe Ombredanne <pombreda...@nexb.com> FWIW, I also checked that there were no mismatch with any MODULE_LICENSE in these file (that do not have one anyway). -- Cordially Philippe Ombredanne

Re: [patch V5 02/11] LICENSES: Add the GPL 2.0 license

2018-01-04 Thread Philippe Ombredanne
tually this could happen in the future, but not out of order with actual patches to update the code and tooling and certainly not now. -- Cordially Philippe Ombredanne

Re: [PATCH V2] perf script: add script to profile and resolve physical mem type

2018-01-04 Thread Philippe Ombredanne
path, search all >> + f.seek(0, 0) >> + for j in f: >> + m = re.split('-|:',j,2) >> + if long(m[0], 16) <= phys_addr <= long(m[1], 16): >> + return m[2] >> + return "N/A" >> + >> +def process_event(param_dict): >> + name = param_dict["ev_name"] >> + sample = param_dict["sample"] >> + phys_addr = sample["phys_addr"] >> + >> + global event_name >> + if event_name == None: >> + event_name = name >> + load_mem_type_cnt[find_memory_type(phys_addr)] += 1 >> diff --git a/tools/perf/util/scripting-engines/trace-event-python.c >> b/tools/perf/util/scripting-engines/trace-event-python.c >> index c7187f0..8cd6317 100644 >> --- a/tools/perf/util/scripting-engines/trace-event-python.c >> +++ b/tools/perf/util/scripting-engines/trace-event-python.c >> @@ -500,6 +500,8 @@ static PyObject *get_perf_sample_dict(struct >> perf_sample *sample, >> PyLong_FromUnsignedLongLong(sample->time)); >> pydict_set_item_string_decref(dict_sample, "period", >> PyLong_FromUnsignedLongLong(sample->period)); >> + pydict_set_item_string_decref(dict_sample, "phys_addr", >> + PyLong_FromUnsignedLongLong(sample- >> >phys_addr)); >> set_sample_read_in_dict(dict_sample, sample, evsel); >> pydict_set_item_string_decref(dict, "sample", dict_sample); >> >> -- >> 2.7.4 > -- Cordially Philippe Ombredanne

Re: [PATCH 05/12] arm64: dts: mt7622: add PMIC MT6380 related nodes

2018-01-04 Thread Philippe Ombredanne
Also if you could spread the word in your team, this would earn you good karma points. Thank you! [1] https://lkml.org/lkml/2017/12/28/323 -- Cordially Philippe Ombredanne

Re: [PATCH 6/6] add test for aio poll and io_pgetevents

2018-01-04 Thread Philippe Ombredanne
nk you! [1] https://lkml.org/lkml/2017/12/28/323 -- Cordially Philippe Ombredanne, your kernel licensing scruffy

Re: [PATCH bpf-next v5 3/4] libbpf: add missing SPDX-License-Identifier

2018-01-04 Thread Philippe Ombredanne
@@ > +/* SPDX-License-Identifier: LGPL-2.1 */ > + > /* > * Common eBPF ELF object loading operations. > * > -- > 2.15.1 > Reviewed-by: Philippe Ombredanne <pombreda...@nexb.com> Thank you for using the SPDX tags! -- Cordially Philippe Ombredanne

Re: [PATCH v2 01/27] staging: ccree: SPDXify driver

2018-01-03 Thread Philippe Ombredanne
. This cannot happen any other way or this would defeat the whole purpose to have clear licensing kernel-wide: using the latest and greatest introduces variations and creates a mess that we want to avoid in the first place. CC: Thomas Gleixner <t...@linutronix.de> [1] https://lkml.org/lkml/2017/12/28/323 -- Cordially Philippe Ombredanne

Re: [PATCH 01/26] staging: ccree: SPDXify driver

2018-01-01 Thread Philippe Ombredanne
file the style should be C comments as explained in Thomas doc patches. .e.g. > +/* SPDX-License-Identifier: GPL-2.0 */ And then it might makes sense there too: > +/* Copyright (C) 2012-2017 ARM Limited or its affiliates. */ -- Cordially Philippe Ombredanne

Re: [PATCH] input: pxrc: new driver for PhoenixRC Flight Controller Adapter

2017-12-31 Thread Philippe Ombredanne
PL 2.0 only. Could you make sure they are in sync? -- Cordially Philippe Ombredanne

Re: [PATCHv2 1/8] MIPS: Loongson64: cleanup all cs5536 files to use SPDX Identifier

2017-12-31 Thread Philippe Ombredanne
On Sun, Dec 31, 2017 at 2:14 PM, Jiaxun Yang <jiaxun.y...@flygoat.com> wrote: > On 2017-12-31 Sun 12:17 +0100,Philippe Ombredanne wrote: >> Did you CC the original authors? You would need their signoff or at >> least an ack IMHO > > Yeah, I CC Huacai Chen in v1 as the

Re: [PATCH bpf-next v4 2/3] libbpf: add error reporting in XDP

2017-12-31 Thread Philippe Ombredanne
author (i.e.Thomas Graf) to get a more streamlined thing such as this: > +// SPDX-License-Identifier: LGPL-2.1 > +// NETLINK Netlink attributes > +// Copyright (c) 2003-2013 Thomas Graf <tg...@suug.ch> -- Cordially Philippe Ombredanne

Re: [PATCHv2 1/8] MIPS: Loongson64: cleanup all cs5536 files to use SPDX Identifier

2017-12-31 Thread Philippe Ombredanne
d/or modify it > - * under the terms of the GNU General Public License as published by the > - * Free Software Foundation; either version 2 of the License, or (at your > - * option) any later version. > */ Did you CC the original authors? You would need their signoff or at least an ack IMHO -- Cordially Philippe Ombredanne

Re: [PATCH V2] ARM: imx: introduce imx_l2c310_write_sec

2017-12-30 Thread Philippe Ombredanne
*/ or > +/* SPDX-License-Identifier: GPL-2.0 */ > +/* > + * Copyright 2017 NXP > + */ > +#ifndef __IMX_SIP_SMC_H_ > +#define __IMX_SIP_SMC_H_ > + > +#include > + > +#define IMX_SIP_SMC_VAL(func) ARM_SMCCC_CALL_VAL(ARM_SMCCC_FAST_CALL, \ > +ARM_SMCCC_SMC_32, \ > +ARM_SMCCC_OWNER_SIP, \ > +(func)) > + > +#define IMX_L2C310 0x1 > + > +#define IMX_SIP_SMC_L2C310 IMX_SIP_SMC_VAL(IMX_L2C310) > + > +#endif > -- > 2.14.1 > -- Cordially Philippe Ombredanne

Re: [patch V5 01/11] Documentation: Add license-rules.rst to describe how to properly identify file licenses

2017-12-29 Thread Philippe Ombredanne
first place and are ugly warts. It could very well be that these are not really GPL-compliant notices FWIW: keeping notices and copyrights is quite different from a restriction of altering things by moving them around which is exactly what is happening with the SPDX-ification here. [1] https://git.ker

Re: [PATCH v2 1/5] ARM: sun9i: Support SMP on A80 with Multi-Cluster Power Management (MCPM)

2017-12-29 Thread Philippe Ombredanne
> + * > + * This program is free software; you can redistribute it and/or modify > + * it under the terms of the GNU General Public License version 2 as > + * published by the Free Software Foundation. > + */ Would you mind using a concise SPDX tag instead, as documented by Thomas doc patches? Thank you for your kind consideration! -- Cordially Philippe Ombredanne

Re: [patch V5 00/11] LICENSES: Add documentation and initial License files

2017-12-29 Thread Philippe Ombredanne
ar: 2018 is going to be The Year of The Penguin [1] in my personal revised version of the Chinese calendar. "Intelligent, curious, and social, those born under the sign of the Penguin love nothing more than coming up with creative solutions to any kind of problem. This is the sign of thinker

Re: [patch V5 02/11] LICENSES: Add the GPL 2.0 license

2017-12-29 Thread Philippe Ombredanne
AOFm3uEzRMf261+O-Nm+9HDoEn9RbFjH=5j9i1c2ggmug2g...@mail.gmail.com > > Add the required tags for reference and tooling. > > Signed-off-by: Thomas Gleixner <t...@linutronix.de> > Reviewed-by: Greg Kroah-Hartman <gre...@linuxfoundation.org> > Reviewed-by: Phili

Re: [patch V5 01/11] Documentation: Add license-rules.rst to describe how to properly identify file licenses

2017-12-29 Thread Philippe Ombredanne
o (LICENSES/). > > Thanks to Kate and Greg for review and editing and Jonas for the > suggestions concerning the meta tags in the licenses files. > > Signed-off-by: Thomas Gleixner <t...@linutronix.de> > Reviewed-by: Jonas Oberg <jo...@fsfe.org> > Reviewed-by: Jonathan Corbet &

Re: [PATCH] ARM: imx: introduce imx_l2c310_write_sec

2017-12-29 Thread Philippe Ombredanne
mind using a simpler SPDX identifier instead of this longer legalese boilerplate? This is documented in Thomas doc patches. If you could also spread the word in your team that would be much welcomed. Thanks! -- Cordially Philippe Ombredanne

Re: [PATCH v4 06/15] clk: Add Ingenic jz4770 CGU driver

2017-12-29 Thread Philippe Ombredanne
pply to your entire patch set. Thank you for your kind consideration! -- Cordially Philippe Ombredanne

Re: [PATCH v2 6/9] v4l: i2c: Copy ov772x soc_camera sensor driver

2017-12-29 Thread Philippe Ombredanne
version 2 as > + * published by the Free Software Foundation. > + */ Do you mind using a simpler SPDX identifier instead of this long legalese boilerplate? This is documented in Thomas doc patches. This applies to your entire patch set of course. Thanks! -- Cordially Philippe Ombredanne

Re: [PATCH v5 05/16] media: rkisp1: add Rockchip ISP1 subdev driver

2017-12-29 Thread Philippe Ombredanne
ACTION OF CONTRACT, TORT OR OTHERWISE, ARISING FROM, OUT OF OR IN > + * CONNECTION WITH THE SOFTWARE OR THE USE OR OTHER DEALINGS IN THE > + * SOFTWARE. > + */ Do you mind using a simpler SPDX identifier instead of this long legalese boilerplate? This is documented in Thomas doc patches. This applies to your entire patch set of course. Thanks! -- Cordially Philippe Ombredanne

Re: [PATCH 1/7] MIPS: Loongson64: cleanup all cs5536 files to use SPDX Identifier

2017-12-29 Thread Philippe Ombredanne
ongson64/common/cs5536/cs5536_isa.c > @@ -1,3 +1,5 @@ > +/* SPDX-License-Identifier: GPL-2.0 */ And this is the correct comment style for .h files. Thanks! -- Cordially Philippe Ombredanne

Re: [PATCH bpf-next v3 3/3] libbpf: add missing SPDX-License-Identifier

2017-12-29 Thread Philippe Ombredanne
> * > diff --git a/tools/lib/bpf/libbpf.h b/tools/lib/bpf/libbpf.h > index e42f96900318..f85906533cdd 100644 > --- a/tools/lib/bpf/libbpf.h > +++ b/tools/lib/bpf/libbpf.h > @@ -1,3 +1,5 @@ > +/* SPDX-License-Identifier: LGPL-2.1 */ > + > /* > * Common eBPF ELF object loading operations. > * > -- > 2.15.1 > -- Cordially Philippe Ombredanne

  1   2   3   >