Re: [PATCH v2 00/30] HID: wacom: cleanup/EKR/LED

Hi Jiri, This patchset has gone through two rounds of testing/review. It is also a necessary set to support future userland LED configuration features. Do you see any issues with the patches? Cheers, Ping On Wed, Jul 13, 2016 at 2:36 PM, Aaron Armstrong Skomra wrote: > On

Re: [PATCH v2 00/30] HID: wacom: cleanup/EKR/LED

Hi Jiri, This patchset has gone through two rounds of testing/review. It is also a necessary set to support future userland LED configuration features. Do you see any issues with the patches? Cheers, Ping On Wed, Jul 13, 2016 at 2:36 PM, Aaron Armstrong Skomra wrote: > On Wed, Jul 13, 2016

Re: [PATCH v2 02/30] HID: wacom: store the type in wacom->shared for INTUOSHT and INTUOSHT2

tricky part. > Untested. Aaron tested it. So, your code is safe ;). > Signed-off-by: Benjamin Tissoires <benjamin.tissoi...@redhat.com> The whole set is Acked-by: Ping Cheng <pi...@wacom.com> Thanks for your effort! Ping > --- > > No changes in v2 > --- &g

Re: [PATCH v2 02/30] HID: wacom: store the type in wacom->shared for INTUOSHT and INTUOSHT2

on tested it. So, your code is safe ;). > Signed-off-by: Benjamin Tissoires The whole set is Acked-by: Ping Cheng Thanks for your effort! Ping > --- > > No changes in v2 > --- > drivers/hid/wacom_sys.c | 5 +++-- > 1 file changed, 3 insertions(+), 2 deletions(-) > > d

Re: [PATCH] Input: wacom_w8001 - Ignore bogus idx values in interrupt

On Mon, May 23, 2016 at 9:52 AM, Dmitry Torokhov <dmitry.torok...@gmail.com> wrote: > On Sun, May 22, 2016 at 10:21:45PM -0700, Ping Cheng wrote: >> Hi Chris, >> >> On Sun, May 22, 2016 at 6:42 PM, Chris J Arges >> <christopherar...@gmail.com> wrote: >&

Re: [PATCH] Input: wacom_w8001 - Ignore bogus idx values in interrupt

On Mon, May 23, 2016 at 9:52 AM, Dmitry Torokhov wrote: > On Sun, May 22, 2016 at 10:21:45PM -0700, Ping Cheng wrote: >> Hi Chris, >> >> On Sun, May 22, 2016 at 6:42 PM, Chris J Arges >> wrote: >> > I've noticed crashes when using my x60t using a coreboot

Re: [PATCH] Input: wacom_w8001 - Ignore bogus idx values in interrupt

Hi Chris, On Sun, May 22, 2016 at 6:42 PM, Chris J Arges wrote: > I've noticed crashes when using my x60t using a coreboot bios. When using > the pen I can produce a crash simply by tapping a few times. This > generates an event which has an idx of 0xc. This in turn

Re: [PATCH] Input: wacom_w8001 - Ignore bogus idx values in interrupt

Hi Chris, On Sun, May 22, 2016 at 6:42 PM, Chris J Arges wrote: > I've noticed crashes when using my x60t using a coreboot bios. When using > the pen I can produce a crash simply by tapping a few times. This > generates an event which has an idx of 0xc. This in turn crashes the > machine because

Re: [PATCH] HID: wacom: fix Bamboo ONE oops

ical pad connected to it. > The weird part is that the pad is still sending events and given that > there is no input node connected to it, we get anull pointer exception. > > Link: https://bugzilla.redhat.com/show_bug.cgi?id=1317116 > > Signed-off-by: Benjamin Tissoires <benjami

Re: [PATCH] HID: wacom: fix Bamboo ONE oops

The weird part is that the pad is still sending events and given that > there is no input node connected to it, we get anull pointer exception. > > Link: https://bugzilla.redhat.com/show_bug.cgi?id=1317116 > > Signed-off-by: Benjamin Tissoires Acked-by: Ping Cheng Thank you Benjamin

Re: [PATCH v2] hid: usbhid: hid-core: fix recursive deadlock

Hi Jiri, On Tue, Dec 1, 2015 at 8:36 AM, Jiri Kosina wrote: > On Fri, 20 Nov 2015, Ioan-Adrian Ratiu wrote: > >> The critical section protected by usbhid->lock in hid_ctrl() is too >> big and because of this it causes a recursive deadlock. "Too big" means >> the case statement and the call to

Re: [PATCH v2] hid: usbhid: hid-core: fix recursive deadlock

Hi Jiri, On Tue, Dec 1, 2015 at 8:36 AM, Jiri Kosina wrote: > On Fri, 20 Nov 2015, Ioan-Adrian Ratiu wrote: > >> The critical section protected by usbhid->lock in hid_ctrl() is too >> big and because of this it causes a recursive deadlock. "Too big" means >> the case statement

Re: [PATCH 1/3] HID: wacom: Do not add suffix to name of devices with an unknown type

n't > any of these types (e.g. the "Cintiq 24HDT Monitor Control"). This patch > updates the logic so that no suffix will be added to the device name if > the device type is unknown. > > Signed-off-by: Jason Gerecke Reviewed-by: Ping Cheng for the whole set. Cheers, Ping >

Re: [PATCH 1/3] HID: wacom: Do not add suffix to name of devices with an unknown type

aren't any of these types (e.g. the Cintiq 24HDT Monitor Control). This patch updates the logic so that no suffix will be added to the device name if the device type is unknown. Signed-off-by: Jason Gerecke jason.gere...@wacom.com Reviewed-by: Ping Cheng pi...@wacom.com for the whole set. Cheers

Re: [PATCH] HID: wacom: check for wacom->shared before following the pointer

On Thu, Mar 5, 2015 at 2:36 PM, Benjamin Tissoires wrote: > 486b908 (HID: wacom: do not send pen events before touch is up/forced out) > introduces a kernel oops when plugging a tablet without touch. Thank you for the catch. You must have tried an Intuos 4 or earlier model.

Re: [PATCH] HID: wacom: check for wacom-shared before following the pointer

On Thu, Mar 5, 2015 at 2:36 PM, Benjamin Tissoires benjamin.tissoi...@redhat.com wrote: 486b908 (HID: wacom: do not send pen events before touch is up/forced out) introduces a kernel oops when plugging a tablet without touch. Thank you for the catch. You must have tried an Intuos 4 or earlier

Re: [PATCH v3 2/2] HID: wacom: add full support of the Wacom Bamboo PAD

Tested-by: Josep Sanchez Ferreres > Signed-off-by: Benjamin Tissoires Acked-by: Ping Cheng for the series. Cheers, Ping > --- > changes in v3: > - store touch_down information to not send pen events before the touch has > been > released > > changes

Re: [PATCH v3 2/2] HID: wacom: add full support of the Wacom Bamboo PAD

...@est.fib.upc.edu Signed-off-by: Benjamin Tissoires benjamin.tissoi...@redhat.com Acked-by: Ping Cheng pi...@wacom.com for the series. Cheers, Ping --- changes in v3: - store touch_down information to not send pen events before the touch has been released changes in v2: - re-route the pen

Re: [PATCH v2 2/2] HID: wacom: add full support of the Wacom Bamboo PAD

On Wed, Feb 25, 2015 at 8:43 AM, Benjamin Tissoires wrote: > The stylus of this device works just fine out of the box. > The touch is seen by default as a mouse with relative events and some > gestures. > The wireless and the wired version have slightly different firmwares, but > the debug mode 2

Re: [PATCH v2 2/2] HID: wacom: add full support of the Wacom Bamboo PAD

On Wed, Feb 25, 2015 at 8:43 AM, Benjamin Tissoires benjamin.tissoi...@redhat.com wrote: The stylus of this device works just fine out of the box. The touch is seen by default as a mouse with relative events and some gestures. The wireless and the wired version have slightly different

Re: [PATCH] HID: wacom: do not directly use input_mt_report_pointer_emulation

in this driver, it is better to > use input_mt_sync_frame(). It is sensible to me, except I think you meant input_mt_slot() instead of input_mt_assign_slot(). > Signed-off-by: Benjamin Tissoires Reviewed-by: Ping Cheng Ping > --- > drivers/hid/wacom_wac.c | 10 +- > 1 fi

Re: [PATCH] HID: wacom: do not directly use input_mt_report_pointer_emulation

input_mt_assign_slot() in this driver, it is better to use input_mt_sync_frame(). It is sensible to me, except I think you meant input_mt_slot() instead of input_mt_assign_slot(). Signed-off-by: Benjamin Tissoires benjamin.tissoi...@redhat.com Reviewed-by: Ping Cheng pi...@wacom.com Ping --- drivers/hid

Re: [PATCH] hid: Initialize battery_no to -1 & correct its format string

Hi Benjamin, The relevant code was introduced by d70420b914c98a3758674c6e9858810e0ab4ea30. Can you take a look and let us know if Aniroop's patch fits your original thought or not? Thanks, Ping On Tue, Jan 6, 2015 at 6:32 AM, Aniroop Mathur wrote: > Dear Mr. Jason and Mr. Ping, > > Please

Re: [PATCH] hid: Initialize battery_no to -1 correct its format string

Hi Benjamin, The relevant code was introduced by d70420b914c98a3758674c6e9858810e0ab4ea30. Can you take a look and let us know if Aniroop's patch fits your original thought or not? Thanks, Ping On Tue, Jan 6, 2015 at 6:32 AM, Aniroop Mathur aniroop.mat...@gmail.com wrote: Dear Mr. Jason and

Fwd: [PATCH] HID: wacom: make the WL connection friendly for the desktop

and was rejected, we may have to keep clients confused. With that said, the patch is > > This way, tablets connected through WL can be used from the user point of > view in the same way they are used while connected through wire. > > Signed-off-by: Benjamin Tissoires Reviewed-by:

Fwd: [PATCH] HID: wacom: make the WL connection friendly for the desktop

-by: Ping Cheng pi...@wacom.com Cheers, Ping --- Hi guys, to continue on Ping's work regarding the Wireless reciever, here is a patch which allows to have the same user experience regardless the transport layer. Unfortunately, a libwacom patch is also required, but once both are applied

Re: [PATCH v2] Input - wacom: update the ABI doc according to latest changes

. > For OLEDs, Bluetooth devices handle only 1-bit images instead of 4 for USB. > The documentation has been updated to match this. > > Signed-off-by: Benjamin Tissoires Reviewed-by: Ping Cheng Ping > Documentation/ABI/testing/sysfs-driver-wacom | 70 > +++---

Re: [PATCH v2] Input - wacom: update the ABI doc according to latest changes

devices handle only 1-bit images instead of 4 for USB. The documentation has been updated to match this. Signed-off-by: Benjamin Tissoires benjamin.tissoi...@redhat.com Reviewed-by: Ping Cheng pi...@wacom.com Ping Documentation/ABI/testing/sysfs-driver-wacom | 70

Re: [PATCH] Input - wacom: update the ABI doc according to latest changes

On Tue, Aug 5, 2014 at 2:34 PM, Benjamin Tissoires wrote: > Hi Ping, > > On Aug 05 2014 or thereabouts, Ping Cheng wrote: >> Thank you Benjamin for updating the ABI docs. My comments are inline. >> >> With those lines updated, this patch is: >> >&

Re: [PATCH] Input - wacom: update the ABI doc according to latest changes

Thank you Benjamin for updating the ABI docs. My comments are inline. With those lines updated, this patch is: Reviewed-by: Ping Cheng Cheers, Ping On Tue, Aug 5, 2014 at 8:34 AM, Benjamin Tissoires wrote: > Now the devices show up under hid no matter the connection. So update the >

Re: [PATCH] Input - wacom: update the ABI doc according to latest changes

Thank you Benjamin for updating the ABI docs. My comments are inline. With those lines updated, this patch is: Reviewed-by: Ping Cheng pi...@wacom.com Cheers, Ping On Tue, Aug 5, 2014 at 8:34 AM, Benjamin Tissoires benjamin.tissoi...@redhat.com wrote: Now the devices show up under hid

Re: [PATCH] Input - wacom: update the ABI doc according to latest changes

On Tue, Aug 5, 2014 at 2:34 PM, Benjamin Tissoires benjamin.tissoi...@redhat.com wrote: Hi Ping, On Aug 05 2014 or thereabouts, Ping Cheng wrote: Thank you Benjamin for updating the ABI docs. My comments are inline. With those lines updated, this patch is: Reviewed-by: Ping Cheng pi

Re: [PATCH v3 4/7] Input - wacom: Check for bluetooth protocol while setting OLEDs

t;bus == BUS_BLUETOOTH) { >> + len = 256; >> + xfer_id = WAC_CMD_ICON_BT_XFER; >> + } else { >> + len = 1024; >> + xfer_id = WAC_CMD_ICON_XFER; >> + } >> + >> + if (count != len) >>

Re: [PATCH v3 4/7] Input - wacom: Check for bluetooth protocol while setting OLEDs

; mutex_lock(wacom-lock); - err = wacom_led_putimage(wacom, button_id, buf); + err = wacom_led_putimage(wacom, button_id, xfer_id, len, buf); mutex_unlock(wacom-lock); Signed-off-by: Przemo Firszt prz...@firszt.eu Reviewed-by: Ping Cheng pi...@wacom.com I'll test the whole series

Re: [PATCH v2 07/10] Input - wacom: handle Graphire BT tablets in wacom.ko

entally - the patch is still sound as far as I > am concerned. I will wait a bit for other to chime in with comments or > acks before applying this series. Thank you Benjamin and Dmitry for your support. The whole series is: Acked-by: Ping Cheng Cheers, Ping -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/

Re: [PATCH v2 07/10] Input - wacom: handle Graphire BT tablets in wacom.ko

about doing it incrementally - the patch is still sound as far as I am concerned. I will wait a bit for other to chime in with comments or acks before applying this series. Thank you Benjamin and Dmitry for your support. The whole series is: Acked-by: Ping Cheng pi...@wacom.com Cheers, Ping

Re: [PATCH] Input - wacom: split out the pad device for the wireless receiver

ency, the function wacom_register_input() is renamed into > wacom_register_input(). wacom_register_inputs(). > > Signed-off-by: Benjamin Tissoires Reviewed-by: Ping Cheng . Ping > --- > > Hi, > > I noticed this afternoon that the "pad-in-a-separate-device" was missing the >

Re: [PATCH] Input - wacom: split out the pad device for the wireless receiver

, the function wacom_register_input() is renamed into wacom_register_input(). wacom_register_inputs(). Signed-off-by: Benjamin Tissoires benjamin.tissoi...@redhat.com Reviewed-by: Ping Cheng pi...@wacom.com. Ping --- Hi, I noticed this afternoon that the pad-in-a-separate-device was missing

Re: [PATCH 1/5] Input - wacom: create a separate input device for pads

Unless you plan to use other means to tell userland those events are from PAD tool, ABS_MISC is necessary and is a reasonable way to group PAD events. So, I do not think it is for backward compatibility. It is there to stay. With that said, the whole patchset is > Signed-off-by: Benj

Re: [PATCH 1/5] Input - wacom: create a separate input device for pads

, ABS_MISC is necessary and is a reasonable way to group PAD events. So, I do not think it is for backward compatibility. It is there to stay. With that said, the whole patchset is Signed-off-by: Benjamin Tissoires benjamin.tissoi...@redhat.com Reviewed-by: Ping Cheng pi...@wacom.com Thank you

Re: [PATCH] Input - wacom: put a flag when the led are initialized

Hi Benjamin, On Monday, June 16, 2014, Benjamin Tissoires wrote: > > Hi Ping, > > On Jun 13 2014 or thereabouts, Ping Cheng wrote: > > Hi Benjamin, > > > > On Fri, Jun 13, 2014 at 1:29 PM, Benjamin Tissoires > > wrote: > > > This solves a bug with t

Re: [PATCH] Input - wacom: put a flag when the led are initialized

Hi Benjamin, On Monday, June 16, 2014, Benjamin Tissoires benjamin.tissoi...@redhat.com wrote: Hi Ping, On Jun 13 2014 or thereabouts, Ping Cheng wrote: Hi Benjamin, On Fri, Jun 13, 2014 at 1:29 PM, Benjamin Tissoires benjamin.tissoi...@redhat.com wrote: This solves a bug

Re: [PATCH] Input - wacom: put a flag when the led are initialized

ected. > Signed-off-by: Benjamin Tissoires Thank you for your support. But, sorry NAKed-by: Ping Cheng Ping > --- > drivers/input/tablet/wacom.h | 1 + > drivers/input/tablet/wacom_sys.c | 6 ++ > 2 files changed, 7 insertions(+) > > diff --git a/drivers/input/tablet/

Re: [PATCH] Input - wacom: put a flag when the led are initialized

-by: Benjamin Tissoires benjamin.tissoi...@redhat.com Thank you for your support. But, sorry NAKed-by: Ping Cheng pi...@wacom.com Ping --- drivers/input/tablet/wacom.h | 1 + drivers/input/tablet/wacom_sys.c | 6 ++ 2 files changed, 7 insertions(+) diff --git a/drivers/input/tablet

Re: wacom: Fixes for stylus pressure values for Thinkpad Yoga

Hi Carl, Thank you for the heads up. I believe Jason's patchset 4 of 4 (http://www.spinics.net/lists/linux-input/msg29435.html) fixed the issue for your device and for other's. The patch was submitted last month. If you can test the set on your device and give us a Tested-by here, it will help

Re: wacom: Fixes for stylus pressure values for Thinkpad Yoga

Hi Carl, Thank you for the heads up. I believe Jason's patchset 4 of 4 (http://www.spinics.net/lists/linux-input/msg29435.html) fixed the issue for your device and for other's. The patch was submitted last month. If you can test the set on your device and give us a Tested-by here, it will help

[PATCH] input - input.h: Add a new switch event

One of Wacom's pen and touch capable models added a switch for users to turn on/off touch events. We need to report the state of this switch to userland. But, there is no existing switch event defined for this purpose. Luckily enough, there is a room for a new switch event. Signed-off-by: Ping

[PATCH] input - input.h: Add a new switch event

One of Wacom's pen and touch capable models added a switch for users to turn on/off touch events. We need to report the state of this switch to userland. But, there is no existing switch event defined for this purpose. Luckily enough, there is a room for a new switch event. Signed-off-by: Ping

Re: [PATCH v3 16/20] HID: Only dump input if someone is listening

a555fa58a79b6ecbb6c531b8bab0650778d: > > Linux 3.6-rc4 (2012-09-01 10:39:58 -0700) > > are available in the git repository at: > > git://github.com/rydberg/linux.git maybe This branch is tested with a Wacom Bamboo3 and an Intuos 5 M. Tested-by: Ping Cheng Ping > fo

Re: [PATCH v3 16/20] HID: Only dump input if someone is listening

3.6-rc4 (2012-09-01 10:39:58 -0700) are available in the git repository at: git://github.com/rydberg/linux.git maybe This branch is tested with a Wacom Bamboo3 and an Intuos 5 M. Tested-by: Ping Cheng pi...@wacom.com Ping for you to fetch changes up

Re: [PATCH 09/19] Input: MT - Handle frame synchronization in core

On Thu, Aug 16, 2012 at 11:07 AM, Henrik Rydberg wrote: > On Wed, Aug 15, 2012 at 04:28:17PM -0700, Ping Cheng wrote: >> On Sun, Aug 12, 2012 at 2:42 PM, Henrik Rydberg wrote: >> > Collect common frame synchronization tasks in a new function, >> > input_mt_sync_fram

Re: [PATCH 09/19] Input: MT - Handle frame synchronization in core

On Thu, Aug 16, 2012 at 11:07 AM, Henrik Rydberg wrote: > On Wed, Aug 15, 2012 at 04:28:17PM -0700, Ping Cheng wrote: >> On Sun, Aug 12, 2012 at 2:42 PM, Henrik Rydberg wrote: >> > Collect common frame synchronization tasks in a new function, >> > input_mt_sync_fram

Re: [PATCH 09/19] Input: MT - Handle frame synchronization in core

On Thu, Aug 16, 2012 at 11:07 AM, Henrik Rydberg rydb...@euromail.se wrote: On Wed, Aug 15, 2012 at 04:28:17PM -0700, Ping Cheng wrote: On Sun, Aug 12, 2012 at 2:42 PM, Henrik Rydberg rydb...@euromail.se wrote: Collect common frame synchronization tasks in a new function, input_mt_sync_frame

Re: [PATCH 09/19] Input: MT - Handle frame synchronization in core

On Thu, Aug 16, 2012 at 11:07 AM, Henrik Rydberg rydb...@euromail.se wrote: On Wed, Aug 15, 2012 at 04:28:17PM -0700, Ping Cheng wrote: On Sun, Aug 12, 2012 at 2:42 PM, Henrik Rydberg rydb...@euromail.se wrote: Collect common frame synchronization tasks in a new function, input_mt_sync_frame

Re: [PATCH 09/19] Input: MT - Handle frame synchronization in core

On Sun, Aug 12, 2012 at 2:42 PM, Henrik Rydberg wrote: > Collect common frame synchronization tasks in a new function, > input_mt_sync_frame(). Depending on the flags set, it drops > unseen contacts and performs pointer emulation. > > Signed-off-by: Henrik Rydberg I went through the patchset

Re: [PATCH 09/19] Input: MT - Handle frame synchronization in core

On Sun, Aug 12, 2012 at 2:42 PM, Henrik Rydberg rydb...@euromail.se wrote: Collect common frame synchronization tasks in a new function, input_mt_sync_frame(). Depending on the flags set, it drops unseen contacts and performs pointer emulation. Signed-off-by: Henrik Rydberg

Re: [PATCH 02/19] Input: Improve the events-per-packet estimate

On Tue, Aug 14, 2012 at 2:12 PM, Dmitry Torokhov wrote: > >> On Sun, Aug 12, 2012 at 2:42 PM, Henrik Rydberg > >> wrote: > >> > Many MT devices send a number of keys along with the mt information. > >> > This patch makes sure that there is room for them in the packet > >> > buffer. >> >> So,

Re: [PATCH 02/19] Input: Improve the events-per-packet estimate

On Tue, Aug 14, 2012 at 1:01 PM, Henrik Rydberg wrote: > Hi Ping, > > Long time no see. :-) > >> > + /* Make room for KEY and MSC events */ >> > + events += 7; >> >> It is nice to get rid of the redundant pieces and to incorporate >> common functions. Thank you. >> >> I have a

Re: [PATCH 02/19] Input: Improve the events-per-packet estimate

On Tue, Aug 14, 2012 at 12:53 PM, Dmitry Torokhov wrote: > On Tuesday, August 14, 2012 12:32:21 PM Ping Cheng wrote: >> On Sun, Aug 12, 2012 at 2:42 PM, Henrik Rydberg wrote: >> > Many MT devices send a number of keys along with the mt information. >> > This patch ma

Re: [PATCH 02/19] Input: Improve the events-per-packet estimate

On Sun, Aug 12, 2012 at 2:42 PM, Henrik Rydberg wrote: > Many MT devices send a number of keys along with the mt information. > This patch makes sure that there is room for them in the packet > buffer. > > Signed-off-by: Henrik Rydberg > --- > drivers/input/input.c | 10 +++--- > 1 file

Re: [PATCH 02/19] Input: Improve the events-per-packet estimate

On Sun, Aug 12, 2012 at 2:42 PM, Henrik Rydberg rydb...@euromail.se wrote: Many MT devices send a number of keys along with the mt information. This patch makes sure that there is room for them in the packet buffer. Signed-off-by: Henrik Rydberg rydb...@euromail.se ---

Re: [PATCH 02/19] Input: Improve the events-per-packet estimate

On Tue, Aug 14, 2012 at 12:53 PM, Dmitry Torokhov dmitry.torok...@gmail.com wrote: On Tuesday, August 14, 2012 12:32:21 PM Ping Cheng wrote: On Sun, Aug 12, 2012 at 2:42 PM, Henrik Rydberg rydb...@euromail.se wrote: Many MT devices send a number of keys along with the mt information

Re: [PATCH 02/19] Input: Improve the events-per-packet estimate

On Tue, Aug 14, 2012 at 1:01 PM, Henrik Rydberg rydb...@euromail.se wrote: Hi Ping, Long time no see. :-) + /* Make room for KEY and MSC events */ + events += 7; It is nice to get rid of the redundant pieces and to incorporate common functions. Thank you. I have a question

Re: [PATCH 02/19] Input: Improve the events-per-packet estimate

On Tue, Aug 14, 2012 at 2:12 PM, Dmitry Torokhov dmitry.torok...@gmail.com wrote: On Sun, Aug 12, 2012 at 2:42 PM, Henrik Rydberg rydb...@euromail.se wrote: Many MT devices send a number of keys along with the mt information. This patch makes sure that there is room for them in the