using spi-mem interface.
Suggested-by: Boris Brezillon
Signed-off-by: Piotr Bugalski
---
drivers/mtd/spi-nor/Kconfig | 9 -
drivers/mtd/spi-nor/Makefile | 1 -
drivers/spi/Kconfig | 9 +
drivers/spi/Makefile
using spi-mem interface.
Suggested-by: Boris Brezillon
Signed-off-by: Piotr Bugalski
---
drivers/mtd/spi-nor/Kconfig | 9 -
drivers/mtd/spi-nor/Makefile | 1 -
drivers/spi/Kconfig | 9 +
drivers/spi/Makefile
Code used for previous interface is no longer needed.
This change just removes obsolete code.
Suggested-by: Boris Brezillon
Signed-off-by: Piotr Bugalski
---
drivers/mtd/spi-nor/atmel-quadspi.c | 388
1 file changed, 388 deletions(-)
diff --git a/drivers
This patch adds new interface to existing driver. New code is not used yet,
it will be enabled later.
Changes are prepared in small steps to keep patches readable.
Suggested-by: Boris Brezillon
Signed-off-by: Piotr Bugalski
---
drivers/mtd/spi-nor/atmel-quadspi.c | 211
range checkng for 4-bytes addressing
- use timeout to avoid infinite waiting
Piotr Bugalski (6):
mtd: spi-nor: atmel-quaspi: Typo fix
mtd: spi-nor: atmel-quadspi: Add spi-mem support to atmel-quadspi
mtd: spi-nor: atmel-quadspi: Use spi-mem interface for atmel-quadspi
driver
mtd: s
Atmel SAMA5D2 QuadSPI driver was moved from mtd to spi subsystem,
this change is just moving DT-binding documentation.
Suggested-by: Boris Brezillon
Signed-off-by: Piotr Bugalski
---
Documentation/devicetree/bindings/{mtd => spi}/atmel-quadspi.txt | 0
1 file changed, 0 insertions(+)
This patch adds new interface to existing driver. New code is not used yet,
it will be enabled later.
Changes are prepared in small steps to keep patches readable.
Suggested-by: Boris Brezillon
Signed-off-by: Piotr Bugalski
---
drivers/mtd/spi-nor/atmel-quadspi.c | 211
range checkng for 4-bytes addressing
- use timeout to avoid infinite waiting
Piotr Bugalski (6):
mtd: spi-nor: atmel-quaspi: Typo fix
mtd: spi-nor: atmel-quadspi: Add spi-mem support to atmel-quadspi
mtd: spi-nor: atmel-quadspi: Use spi-mem interface for atmel-quadspi
driver
mtd: s
Atmel SAMA5D2 QuadSPI driver was moved from mtd to spi subsystem,
this change is just moving DT-binding documentation.
Suggested-by: Boris Brezillon
Signed-off-by: Piotr Bugalski
---
Documentation/devicetree/bindings/{mtd => spi}/atmel-quadspi.txt | 0
1 file changed, 0 insertions(+)
Code used for previous interface is no longer needed.
This change just removes obsolete code.
Suggested-by: Boris Brezillon
Signed-off-by: Piotr Bugalski
---
drivers/mtd/spi-nor/atmel-quadspi.c | 388
1 file changed, 388 deletions(-)
diff --git a/drivers
Just minor typo fix. Fixed in preparation of new driver.
Signed-off: Piotr Bugalski
---
drivers/mtd/spi-nor/atmel-quadspi.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/drivers/mtd/spi-nor/atmel-quadspi.c
b/drivers/mtd/spi-nor/atmel-quadspi.c
index 820048726b4f
Previously added spi-mem interface is now used instead of older approach.
Suggested-by: Boris Brezillon
Signed-off-by: Piotr Bugalski
---
drivers/mtd/spi-nor/atmel-quadspi.c | 91 -
1 file changed, 18 insertions(+), 73 deletions(-)
diff --git a/drivers/mtd
Just minor typo fix. Fixed in preparation of new driver.
Signed-off: Piotr Bugalski
---
drivers/mtd/spi-nor/atmel-quadspi.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/drivers/mtd/spi-nor/atmel-quadspi.c
b/drivers/mtd/spi-nor/atmel-quadspi.c
index 820048726b4f
Previously added spi-mem interface is now used instead of older approach.
Suggested-by: Boris Brezillon
Signed-off-by: Piotr Bugalski
---
drivers/mtd/spi-nor/atmel-quadspi.c | 91 -
1 file changed, 18 insertions(+), 73 deletions(-)
diff --git a/drivers/mtd
Hi Alexandre,
Thank you for you comment.
On Tue, 3 Jul 2018, Alexandre Belloni wrote:
Hi,
On 27/06/2018 15:16:04+0200, Piotr Bugalski wrote:
Just minor typo fix. Fixed in preparation of new driver.
Signed-off: Piotr Bugalski
This SoB line must match the author. It doesn't matter which
Hi Alexandre,
Thank you for you comment.
On Tue, 3 Jul 2018, Alexandre Belloni wrote:
Hi,
On 27/06/2018 15:16:04+0200, Piotr Bugalski wrote:
Just minor typo fix. Fixed in preparation of new driver.
Signed-off: Piotr Bugalski
This SoB line must match the author. It doesn't matter which
Hi Tudor,
On Thu, 28 Jun 2018, Tudor Ambarus wrote:
Hi, Piotr,
On 06/27/2018 10:52 AM, Piotr Bugalski wrote:
General things to consider for the limitation in performance:
- is the serial flash memory operating in Quad SPI?
Yes, I've checked signal using logic analyzer, data
Hi Tudor,
On Thu, 28 Jun 2018, Tudor Ambarus wrote:
Hi, Piotr,
On 06/27/2018 10:52 AM, Piotr Bugalski wrote:
General things to consider for the limitation in performance:
- is the serial flash memory operating in Quad SPI?
Yes, I've checked signal using logic analyzer, data
Just minor typo fix. Fixed in preparation of new driver.
Signed-off: Piotr Bugalski
---
drivers/mtd/spi-nor/atmel-quadspi.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/drivers/mtd/spi-nor/atmel-quadspi.c
b/drivers/mtd/spi-nor/atmel-quadspi.c
index 6c5708bacad8
Just minor typo fix. Fixed in preparation of new driver.
Signed-off: Piotr Bugalski
---
drivers/mtd/spi-nor/atmel-quadspi.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/drivers/mtd/spi-nor/atmel-quadspi.c
b/drivers/mtd/spi-nor/atmel-quadspi.c
index 6c5708bacad8
Previously added spi-mem interface is now used instead of older approach.
Suggested-by: Boris Brezillon
Signed-off-by: Piotr Bugalski
---
drivers/mtd/spi-nor/atmel-quadspi.c | 91 -
1 file changed, 18 insertions(+), 73 deletions(-)
diff --git a/drivers/mtd
Previously added spi-mem interface is now used instead of older approach.
Suggested-by: Boris Brezillon
Signed-off-by: Piotr Bugalski
---
drivers/mtd/spi-nor/atmel-quadspi.c | 91 -
1 file changed, 18 insertions(+), 73 deletions(-)
diff --git a/drivers/mtd
Atmel SAMA5D2 QuadSPI driver was moved from mtd to spi subsystem,
this change is just moving DT-binding documentation.
Suggested-by: Boris Brezillon
Signed-off-by: Piotr Bugalski
---
Documentation/devicetree/bindings/{mtd => spi}/atmel-quadspi.txt | 0
1 file changed, 0 insertions(+)
This patch adds new interface to existing driver. New code is not used yet,
it will be enabled later.
Changes are prepared in small steps to keep patches readable.
Suggested-by: Boris Brezillon
Signed-off-by: Piotr Bugalski
---
drivers/mtd/spi-nor/atmel-quadspi.c | 205
Atmel SAMA5D2 QuadSPI driver was moved from mtd to spi subsystem,
this change is just moving DT-binding documentation.
Suggested-by: Boris Brezillon
Signed-off-by: Piotr Bugalski
---
Documentation/devicetree/bindings/{mtd => spi}/atmel-quadspi.txt | 0
1 file changed, 0 insertions(+)
This patch adds new interface to existing driver. New code is not used yet,
it will be enabled later.
Changes are prepared in small steps to keep patches readable.
Suggested-by: Boris Brezillon
Signed-off-by: Piotr Bugalski
---
drivers/mtd/spi-nor/atmel-quadspi.c | 205
Code used for previous interface is no longer needed.
This change just removes obsolete code.
Suggested-by: Boris Brezillon
Signed-off-by: Piotr Bugalski
---
drivers/mtd/spi-nor/atmel-quadspi.c | 389
1 file changed, 389 deletions(-)
diff --git a/drivers
using spi-mem interface.
Suggested-by: Boris Brezillon
Signed-off-by: Piotr Bugalski
---
drivers/mtd/spi-nor/Kconfig | 9 -
drivers/mtd/spi-nor/Makefile | 1 -
drivers/spi/Kconfig | 9 +
drivers/spi/Makefile
Code used for previous interface is no longer needed.
This change just removes obsolete code.
Suggested-by: Boris Brezillon
Signed-off-by: Piotr Bugalski
---
drivers/mtd/spi-nor/atmel-quadspi.c | 389
1 file changed, 389 deletions(-)
diff --git a/drivers
using spi-mem interface.
Suggested-by: Boris Brezillon
Signed-off-by: Piotr Bugalski
---
drivers/mtd/spi-nor/Kconfig | 9 -
drivers/mtd/spi-nor/Makefile | 1 -
drivers/spi/Kconfig | 9 +
drivers/spi/Makefile
finite waiting
Piotr Bugalski (6):
mtd: spi-nor: atmel-quaspi: Typo fix
mtd: spi-nor: atmel-quadspi: Add spi-mem support to atmel-quadspi
mtd: spi-nor: atmel-quadspi: Use spi-mem interface for atmel-quadspi
driver
mtd: spi-nor: atmel-quadspi: Remove unused code from atmel-quadspi
driver
finite waiting
Piotr Bugalski (6):
mtd: spi-nor: atmel-quaspi: Typo fix
mtd: spi-nor: atmel-quadspi: Add spi-mem support to atmel-quadspi
mtd: spi-nor: atmel-quadspi: Use spi-mem interface for atmel-quadspi
driver
mtd: spi-nor: atmel-quadspi: Remove unused code from atmel-quadspi
driver
Hi Tudor,
Thank you very much for comments.
On Tue, 26 Jun 2018, Tudor Ambarus wrote:
Hi, Piotr,
General things to consider for the limitation in performance:
- is the serial flash memory operating in Quad SPI?
Yes, I've checked signal using logic analyzer, data is transferred using
all
Hi Tudor,
Thank you very much for comments.
On Tue, 26 Jun 2018, Tudor Ambarus wrote:
Hi, Piotr,
General things to consider for the limitation in performance:
- is the serial flash memory operating in Quad SPI?
Yes, I've checked signal using logic analyzer, data is transferred using
all
Hi Boris,
I'm a bit allergic to personal preferences in coding style, anyway
thank you for comments and some important findings.
On Thu, 21 Jun 2018, Boris Brezillon wrote:
Hi Piotr,
On Mon, 18 Jun 2018 18:21:23 +0200
Piotr Bugalski wrote:
Kernel contains QSPI driver strongly tied
Hi Boris,
I'm a bit allergic to personal preferences in coding style, anyway
thank you for comments and some important findings.
On Thu, 21 Jun 2018, Boris Brezillon wrote:
Hi Piotr,
On Mon, 18 Jun 2018 18:21:23 +0200
Piotr Bugalski wrote:
Kernel contains QSPI driver strongly tied
Hi Boris,
On Wed, 20 Jun 2018, Boris Brezillon wrote:
Hi Piotr,
On Mon, 18 Jun 2018 18:21:24 +0200
Piotr Bugalski wrote:
Documentation for DT-binding change.
Suggested-by: Boris Brezillon
I'm pretty sure I didn't make a single suggestion about the DT
bindings you use here ;-).
Ok
Hi Boris,
On Wed, 20 Jun 2018, Boris Brezillon wrote:
Hi Piotr,
On Mon, 18 Jun 2018 18:21:24 +0200
Piotr Bugalski wrote:
Documentation for DT-binding change.
Suggested-by: Boris Brezillon
I'm pretty sure I didn't make a single suggestion about the DT
bindings you use here ;-).
Ok
Hi Boris,
Thank you very much for quick response.
On Wed, 20 Jun 2018, Boris Brezillon wrote:
Hi Piotr,
On Mon, 18 Jun 2018 18:21:22 +0200
Piotr Bugalski wrote:
Hello,
Atmel SAMA5D2 is equipped with two QSPI interfaces. These interfaces can
work as in SPI-compatible mode or use two
Hi Boris,
Thank you very much for quick response.
On Wed, 20 Jun 2018, Boris Brezillon wrote:
Hi Piotr,
On Mon, 18 Jun 2018 18:21:22 +0200
Piotr Bugalski wrote:
Hello,
Atmel SAMA5D2 is equipped with two QSPI interfaces. These interfaces can
work as in SPI-compatible mode or use two
Hi Mark,
Thank you very much for quick answer.
On Tue, 19 Jun 2018, Mark Brown wrote:
On Mon, Jun 18, 2018 at 06:21:23PM +0200, Piotr Bugalski wrote:
+static int atmel_qspi_adjust_op_size(struct spi_mem *mem, struct spi_mem_op
*op)
+{
+ return 0;
+}
If this can be empty should we
Hi Mark,
Thank you very much for quick answer.
On Tue, 19 Jun 2018, Mark Brown wrote:
On Mon, Jun 18, 2018 at 06:21:23PM +0200, Piotr Bugalski wrote:
+static int atmel_qspi_adjust_op_size(struct spi_mem *mem, struct spi_mem_op
*op)
+{
+ return 0;
+}
If this can be empty should we
Documentation for DT-binding change.
Suggested-by: Boris Brezillon
Signed-off-by: Piotr Bugalski
---
.../devicetree/bindings/spi/spi_atmel-qspi.txt | 41 ++
1 file changed, 41 insertions(+)
create mode 100644 Documentation/devicetree/bindings/spi/spi_atmel-qspi.txt
Documentation for DT-binding change.
Suggested-by: Boris Brezillon
Signed-off-by: Piotr Bugalski
---
.../devicetree/bindings/spi/spi_atmel-qspi.txt | 41 ++
1 file changed, 41 insertions(+)
create mode 100644 Documentation/devicetree/bindings/spi/spi_atmel-qspi.txt
using spi-mem interface.
Suggested-by: Boris Brezillon
Signed-off-by: Piotr Bugalski
---
drivers/spi/Kconfig | 9 +
drivers/spi/Makefile | 1 +
drivers/spi/spi-atmel-qspi.c | 480 +++
3 files changed, 490 insertions(+)
create mode
using spi-mem interface.
Suggested-by: Boris Brezillon
Signed-off-by: Piotr Bugalski
---
drivers/spi/Kconfig | 9 +
drivers/spi/Makefile | 1 +
drivers/spi/spi-atmel-qspi.c | 480 +++
3 files changed, 490 insertions(+)
create mode
help with performance
improvement is highly welcome, especially for NAND-flash memories which
offers higher capacity than NOR-flash used with previous driver.
Best Regards,
Piotr
Piotr Bugalski (2):
spi: Add QuadSPI driver for Atmel SAMA5D2
dt-bindings: spi: QuadSPI driver for Atmel SAMA5D2
help with performance
improvement is highly welcome, especially for NAND-flash memories which
offers higher capacity than NOR-flash used with previous driver.
Best Regards,
Piotr
Piotr Bugalski (2):
spi: Add QuadSPI driver for Atmel SAMA5D2
dt-bindings: spi: QuadSPI driver for Atmel SAMA5D2
48 matches
Mail list logo
