[PATCH v2 2/2] media: i2c: imx219: Balance runtime PM use-count

2021-03-11 Thread Lad Prabhakar
("media: i2c: Add driver for Sony IMX219 sensor") Reported-by: Pavel Machek Signed-off-by: Lad Prabhakar --- drivers/media/i2c/imx219.c | 32 +--- 1 file changed, 17 insertions(+), 15 deletions(-) diff --git a/drivers/media/i2c/imx219.c b/drivers/media/i2

[PATCH v2 0/2] media: i2c: imx219: Trivial Fixes

2021-03-11 Thread Lad Prabhakar
Hi All, This patch series fixes trivial issues found in imx219 driver. Cheers, Prabhakar Changes for v2: * Dropped serialization patch * Moved locking/unlocking of controls to imx219_start/imx219_stop as suggested by Laurent. * Moved incrementing/decrementing to imx219_start/imx219_stop as

[PATCH v2 1/2] media: i2c: imx219: Move out locking/unlocking of vflip and hflip controls from imx219_set_stream

2021-03-11 Thread Lad Prabhakar
("media: i2c: Add driver for Sony IMX219 sensor") Reported-by: Pavel Machek Signed-off-by: Lad Prabhakar --- drivers/media/i2c/imx219.c | 19 +-- 1 file changed, 13 insertions(+), 6 deletions(-) diff --git a/drivers/media/i2c/imx219.c b/drivers/media/i2c/imx219.c index 6e

Re: [PATCH 1/3] media: i2c: imx219: Enable vflip and hflip controls on stream stop

2021-03-10 Thread Lad, Prabhakar
Hi Laurent, Thank you for the review. On Wed, Mar 10, 2021 at 12:45 PM Laurent Pinchart wrote: > > Hi Prabhakar, > > Thank you for the patch. > > On Wed, Mar 10, 2021 at 12:20:12PM +0000, Lad Prabhakar wrote: > > Enable vflip and hflip controls in resume error path when

Re: [PATCH 3/3] media: i2c: imx219: Balance runtime PM use-count in resume callback

2021-03-10 Thread Lad, Prabhakar
Hi Laurent, Thank you for the review. On Wed, Mar 10, 2021 at 12:49 PM Laurent Pinchart wrote: > > Hi Prabhakar, > > Thank you for the patch. > > On Wed, Mar 10, 2021 at 12:20:14PM +0000, Lad Prabhakar wrote: > > The runtime PM use-count gets incremented in imx219_se

Re: [PATCH 2/3] media: i2c: imx219: Serialize during stream start/stop

2021-03-10 Thread Lad, Prabhakar
Hi Laurent, On Wed, Mar 10, 2021 at 12:54 PM Laurent Pinchart wrote: > > Hi Prabhakar, > > On Wed, Mar 10, 2021 at 12:46:39PM +, Lad, Prabhakar wrote: > > On Wed, Mar 10, 2021 at 12:40 PM Laurent Pinchart wrote: > > > On Wed, Mar 10, 2021 at 12:20:13PM

Re: [PATCH 2/3] media: i2c: imx219: Serialize during stream start/stop

2021-03-10 Thread Lad, Prabhakar
Hi Laurent, Thank you for the review. On Wed, Mar 10, 2021 at 12:40 PM Laurent Pinchart wrote: > > Hi Prabhakar, > > Thank you for the patch. > > On Wed, Mar 10, 2021 at 12:20:13PM +0000, Lad Prabhakar wrote: > > Serialize during stream start/stop in suspend/resume

[PATCH 3/3] media: i2c: imx219: Balance runtime PM use-count in resume callback

2021-03-10 Thread Lad Prabhakar
vel Machek Signed-off-by: Lad Prabhakar --- drivers/media/i2c/imx219.c | 3 +++ 1 file changed, 3 insertions(+) diff --git a/drivers/media/i2c/imx219.c b/drivers/media/i2c/imx219.c index 87c021de1460..afffc85cd265 100644 --- a/drivers/media/i2c/imx219.c +++ b/drivers/media/i2c/imx219.c @@ -1184

[PATCH 2/3] media: i2c: imx219: Serialize during stream start/stop

2021-03-10 Thread Lad Prabhakar
Serialize during stream start/stop in suspend/resume callbacks. Signed-off-by: Lad Prabhakar --- drivers/media/i2c/imx219.c | 5 + 1 file changed, 5 insertions(+) diff --git a/drivers/media/i2c/imx219.c b/drivers/media/i2c/imx219.c index f0cf1985a4dc..87c021de1460 100644 --- a/drivers

[PATCH 0/3] media: i2c: imx219: Trivial Fixes

2021-03-10 Thread Lad Prabhakar
Hi All, This patch series fixes trivial issues found in imx219 driver. Cheers, Prabhakar Lad Prabhakar (3): media: i2c: imx219: Enable vflip and hflip controls on stream stop media: i2c: imx219: Serialize during stream start/stop media: i2c: imx219: Balance runtime PM use-count in resume

[PATCH 1/3] media: i2c: imx219: Enable vflip and hflip controls on stream stop

2021-03-10 Thread Lad Prabhakar
Enable vflip and hflip controls in resume error path when streaming is stopped. Fixes: 1283b3b8f82b9 ("media: i2c: Add driver for Sony IMX219 sensor") Reported-by: Pavel Machek Signed-off-by: Lad Prabhakar --- drivers/media/i2c/imx219.c | 2 ++ 1 file changed, 2 insertions(+) di

Re: [PATCH] include: media: davinci: Fixed up few trivial spellings in the file isif.h

2021-02-21 Thread Lad, Prabhakar
, 4 deletions(-) > Acked-by: Lad Prabhakar Cheers, Prabhakar > diff --git a/include/media/davinci/isif.h b/include/media/davinci/isif.h > index e66589c4022d..8369acd26e7e 100644 > --- a/include/media/davinci/isif.h > +++ b/include/media/davinci/isif.h > @@ -177,7 +177,7 @@ str

RE: [RESEND PATCH v2] dt-bindings: pci: rcar-pci-ep: Document r8a7795

2021-02-11 Thread Prabhakar Mahadev Lad
+rene...@gmail.com; Yoshihiro Shimoda > ; bhelg...@google.com; robh...@kernel.org; > Prabhakar Mahadev Lad > > Subject: [RESEND PATCH v2] dt-bindings: pci: rcar-pci-ep: Document r8a7795 > > Document the support for R-Car PCIe EP on R8A7795 SoC device. > > Signed-off-by: Yuya Ha

Re: [PATCH] media: i2c/Kconfig: Select FWNODE for OV772x sensor

2021-01-20 Thread Lad, Prabhakar
On Wed, Jan 20, 2021 at 11:09 AM Kieran Bingham wrote: > > On 20/01/2021 10:36, Sakari Ailus wrote: > > On Wed, Jan 20, 2021 at 10:17:14AM +, Kieran Bingham wrote: > >> Hi Lad, > >> > >> On 20/01/2021 09:01, Lad Prabhakar wrote: > >>> Fix OV

Re: [PATCH] media: i2c/Kconfig: Select FWNODE for OV772x sensor

2021-01-20 Thread Lad, Prabhakar
Hi Sakari and Kieran, On Wed, Jan 20, 2021 at 10:36 AM Sakari Ailus wrote: > > On Wed, Jan 20, 2021 at 10:17:14AM +, Kieran Bingham wrote: > > Hi Lad, > > > > On 20/01/2021 09:01, Lad Prabhakar wrote: > > > Fix OV772x build breakage by selecting V4L2_FWNODE

[PATCH] media: i2c/Kconfig: Select FWNODE for OV772x sensor

2021-01-20 Thread Lad Prabhakar
ference to `v4l2_fwnode_endpoint_free' ia64-linux-ld: ov772x.c:(.text+0x2212): undefined reference to `v4l2_fwnode_endpoint_alloc_parse' Fixes: 8a10b4e3601e ("media: i2c: ov772x: Parse endpoint properties") Reported-by: kernel test robot Signed-off-by: Lad Prabhakar --- drivers/media/i2c/Kc

[PATCH] spi: rpc-if: Gaurd .pm assignment with CONFIG_PM_SLEEP #ifdef check

2021-01-07 Thread Lad Prabhakar
cadc0 ("spi: rpc-if: Remove CONFIG_PM_SLEEP ifdefery") Reported-by: Geert Uytterhoeven Suggested-by: Pavel Machek Signed-off-by: Lad Prabhakar --- drivers/spi/spi-rpc-if.c | 2 ++ 1 file changed, 2 insertions(+) diff --git a/drivers/spi/spi-rpc-if.c b/drivers/spi/spi-rpc-if.c ind

Re: [PATCH 2/2] spi: rpc-if: Remove CONFIG_PM_SLEEP ifdefery

2021-01-04 Thread Lad, Prabhakar
Hi Geert, Thank you for the review. On Mon, Jan 4, 2021 at 12:34 PM Geert Uytterhoeven wrote: > > Hi Prabhakar, > > On Wed, Dec 30, 2020 at 4:00 PM Lad Prabhakar > wrote: > > Use __maybe_unused for the suspend()/resume() hooks and get rid of > > the CONFIG_PM_SLEEP i

Re: [PATCH] can: rcar: Update help description for CAN_RCAR_CANFD config

2021-01-04 Thread Lad, Prabhakar
Hi Geert, Thank you for the review. On Mon, Jan 4, 2021 at 10:51 AM Geert Uytterhoeven wrote: > > Hi Prabhakar, > > On Thu, Dec 31, 2020 at 5:00 PM Lad Prabhakar > wrote: > > The rcar_canfd driver supports R-Car Gen3 and RZ/G2 SoC's, update the > > description

[PATCH v2] gpio: Kconfig: Update help description for GPIO_RCAR config

2021-01-04 Thread Lad Prabhakar
The gpio-rcar driver also supports RZ/G SoC's, update the description to reflect this. Signed-off-by: Lad Prabhakar --- v1->v2 * Dropped SoC version numbers --- drivers/gpio/Kconfig | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/drivers/gpio/Kconfig b/driv

[PATCH v2] can: rcar: Update help description for CAN_RCAR config

2021-01-04 Thread Lad Prabhakar
The rcar_can driver also supports RZ/G SoC's, update the description to reflect this. Signed-off-by: Lad Prabhakar --- v1->v2 * Dropped SoC version numbers. --- drivers/net/can/rcar/Kconfig | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/drivers/net/can/rcar/K

[PATCH] can: rcar: Update help description for CAN_RCAR_CANFD config

2020-12-31 Thread Lad Prabhakar
The rcar_canfd driver supports R-Car Gen3 and RZ/G2 SoC's, update the description to reflect this. Signed-off-by: Lad Prabhakar --- drivers/net/can/rcar/Kconfig | 8 1 file changed, 4 insertions(+), 4 deletions(-) diff --git a/drivers/net/can/rcar/Kconfig b/drivers/net/can

[PATCH] can: rcar: Update help description for CAN_RCAR config

2020-12-31 Thread Lad Prabhakar
The rcar_can driver supports R-Car Gen{1,2,3} and RZ/G{1,2} SoC's, update the description to reflect this. Signed-off-by: Lad Prabhakar --- drivers/net/can/rcar/Kconfig | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/drivers/net/can/rcar/Kconfig b/drivers/net/can

[PATCH] gpio: Kconfig: Update help description for GPIO_RCAR

2020-12-31 Thread Lad Prabhakar
The gpio-rcar driver supports R-Car Gen{1,2,3} and RZ/G{1,2} SoC's, update the description to reflect this. Signed-off-by: Lad Prabhakar --- drivers/gpio/Kconfig | 5 +++-- 1 file changed, 3 insertions(+), 2 deletions(-) diff --git a/drivers/gpio/Kconfig b/drivers/gpio/Kconfig

[PATCH] gpio: rcar: Remove redundant compatible values

2020-12-31 Thread Lad Prabhakar
The mandatory compatible values 'renesas,rcar-gen{1,2,3}-gpio' have been already added to all the respective R-Car Gen{1,2,3} SoC DTSI files, remove the redundant device specific values from the driver. Signed-off-by: Lad Prabhakar --- drivers/gpio/gpio-r

Re: [PATCH -next] media: platform: davinci: Use DEFINE_SPINLOCK() for spinlock

2020-12-31 Thread Lad, Prabhakar
rm/davinci/vpif.c | 3 +-- > 1 file changed, 1 insertion(+), 2 deletions(-) > Reviewed-by: Lad Prabhakar Cheers, Prabhakar > diff --git a/drivers/media/platform/davinci/vpif.c > b/drivers/media/platform/davinci/vpif.c > index 5e67994e62cc..f1ce10828b8e 100644 > --- a/driver

Re: [PATCH 1/2] spi: rpc-if: Avoid use of C++ style comments

2020-12-30 Thread Lad, Prabhakar
Hi Sergei, On Wed, Dec 30, 2020 at 4:27 PM Sergei Shtylyov wrote: > > On 12/30/20 5:57 PM, Lad Prabhakar wrote: > > > Replace C++ style comment with C style. > >Note that the switch to // was made following the SPI maintainer's > request... > Thanks for

[PATCH 2/2] spi: rpc-if: Remove CONFIG_PM_SLEEP ifdefery

2020-12-30 Thread Lad Prabhakar
Use __maybe_unused for the suspend()/resume() hooks and get rid of the CONFIG_PM_SLEEP ifdefery to improve the code. Suggested-by: Pavel Machek Signed-off-by: Lad Prabhakar --- drivers/spi/spi-rpc-if.c | 11 +++ 1 file changed, 3 insertions(+), 8 deletions(-) diff --git a/drivers/spi

[PATCH 0/2] spi: rpc-if: Trivial fixes

2020-12-30 Thread Lad Prabhakar
Hi All, These patches are trivial fixes for rpc-if SPI driver. Cheers, Prabhakar Lad Prabhakar (2): spi: rpc-if: Avoid use of C++ style comments spi: rpc-if: Remove CONFIG_PM_SLEEP ifdefery drivers/spi/spi-rpc-if.c | 25 ++--- 1 file changed, 10 insertions(+), 15

[PATCH 1/2] spi: rpc-if: Avoid use of C++ style comments

2020-12-30 Thread Lad Prabhakar
Replace C++ style comment with C style. Signed-off-by: Lad Prabhakar --- drivers/spi/spi-rpc-if.c | 14 +++--- 1 file changed, 7 insertions(+), 7 deletions(-) diff --git a/drivers/spi/spi-rpc-if.c b/drivers/spi/spi-rpc-if.c index 3579675485a5..bf64da322e67 100644 --- a/drivers/spi/spi

[PATCH] PCI: Drop PCIE_RCAR config option

2020-12-29 Thread Lad Prabhakar
All the defconfig files have replaced PCIE_RCAR config option with PCIE_RCAR_HOST config option which built the same driver, so we can now safely drop PCIE_RCAR config option. Signed-off-by: Lad Prabhakar --- Hi All, This patch is exact similar to [1], as all the defconfig files enabling

Re: [PATCH v3 2/2] ARM: dts: r8a7742-iwg21d-q7-dbcm-ca: Add support for 8-bit ov7725 sensors

2020-12-15 Thread Lad, Prabhakar
Hi Jacopo, Thank you for the review. On Tue, Dec 15, 2020 at 11:49 AM Jacopo Mondi wrote: > > Hello, > > On Thu, Nov 26, 2020 at 10:30:53AM +, Lad Prabhakar wrote: > > The 8-bit ov7725 sensors can also be connected to the camera daughter > > board. > > > >

Re: [PATCH] mtd: spi-nor: winbond: Add support for w25m512jw

2020-12-08 Thread Lad, Prabhakar
Hi Tudor, On Mon, Dec 7, 2020 at 5:27 PM wrote: > > Hi, Lad, > > On 10/16/20 2:55 PM, Lad Prabhakar wrote: > > EXTERNAL EMAIL: Do not click links or open attachments unless you know the > > content is safe > > > > This chip is (nearly) identical to the Wi

RE: [PATCH v5 09/19] dt-bindings: usb: renesas-xhci: Refer to the usb-xhci.yaml file

2020-12-06 Thread Prabhakar Mahadev Lad
Hi Serge, Thank you for the patch. > -Original Message- > From: Serge Semin > Sent: 05 December 2020 15:24 > To: Mathias Nyman ; Felipe Balbi ; > Krzysztof Kozlowski > ; Greg Kroah-Hartman ; Rob > Herring ; > Chunfeng Yun ; Prabhakar Mahadev Lad > lad...

[RESEND TAKE 2 PATCH] dt-bindings: ata: renesas,rcar-sata: Add r8a774e1 support

2020-12-04 Thread Lad Prabhakar
Document SATA support for the RZ/G2H, no driver change required. Signed-off-by: Lad Prabhakar Reviewed-by: Marian-Cristian Rotariu Acked-by: Rob Herring Reviewed-by: Geert Uytterhoeven --- Hi All, This patch is part of series [1] (original patch [2]) where rest of the patches have been

Re: [PATCH v2 0/5] memory: renesas-rpc-if: Trivial fixes

2020-12-04 Thread Lad, Prabhakar
Hi Krzysztof, On Thu, Dec 3, 2020 at 1:19 PM Krzysztof Kozlowski wrote: > > On Thu, Dec 03, 2020 at 10:41:54AM +, Lad, Prabhakar wrote: > > Hi Krzysztof, > > > > On Thu, Nov 26, 2020 at 7:11 PM Lad Prabhakar > > wrote: > > > > > > Hi All, &g

RE: [PATCH v2 0/5] memory: renesas-rpc-if: Trivial fixes

2020-12-03 Thread Prabhakar Mahadev Lad
Hi Geert, > -Original Message- > From: Geert Uytterhoeven > Sent: 03 December 2020 10:52 > To: Lad, Prabhakar > Cc: Krzysztof Kozlowski ; Sergei Shtylyov > ; Prabhakar > Mahadev Lad ; Philipp Zabel > ; Jiri > Kosina ; Mark Brown ; Linux-Renesas > s...@

Re: [PATCH v2 0/5] memory: renesas-rpc-if: Trivial fixes

2020-12-03 Thread Lad, Prabhakar
Hi Krzysztof, On Thu, Nov 26, 2020 at 7:11 PM Lad Prabhakar wrote: > > Hi All, > > This patch series fixes trivial issues in RPC-IF driver. > > Changes for v2: > * Balanced PM in rpcif_disable_rpm > * Fixed typo in patch 4/5 > * Dropped C++ style fixes patch >

Re: [PATCH/RFC] dt-bindings: pci: rcar-pci-ep: Document missing interrupts property

2020-11-30 Thread Lad, Prabhakar
representing PCIe controllers configured in > host mode, which describe the same hardware... > --- > Documentation/devicetree/bindings/pci/rcar-pci-ep.yaml | 9 +++++ > 1 file changed, 9 insertions(+) > Reviewed-by: Lad Prabhakar Cheers, Prabhakar > diff --git a/Documentation/d

RE: [PATCH v2 5/5] memory: renesas-rpc-if: Export symbols as GPL

2020-11-28 Thread Prabhakar Mahadev Lad
Hi Krzysztof, Thank you for the review. > -Original Message- > From: Krzysztof Kozlowski > Sent: 28 November 2020 11:42 > To: Prabhakar Mahadev Lad > Cc: Sergei Shtylyov ; Philipp Zabel > ; Jiri Kosina > ; Mark Brown ; > linux-renesas-...@vger.kernel.org

[PATCH v2 1/5] memory: renesas-rpc-if: Return correct value to the caller of rpcif_manual_xfer()

2020-11-26 Thread Lad Prabhakar
in error path. Also now we ignore the value returned by reset_control_reset() in the error path and instead print a error message when it fails. Fixes: ca7d8b980b67f ("memory: add Renesas RPC-IF driver") Reported-by: Pavel Machek Signed-off-by: Lad Prabhakar Cc: sta...@vger.kernel.org R

[PATCH v2 5/5] memory: renesas-rpc-if: Export symbols as GPL

2020-11-26 Thread Lad Prabhakar
Renesas RPC-IF driver is licensed under GPL2.0, to be in sync export the symbols as GPL. Suggested-by: Pavel Machek Signed-off-by: Lad Prabhakar Reviewed-by: Sergei Shtylyov --- drivers/memory/renesas-rpc-if.c | 10 +- 1 file changed, 5 insertions(+), 5 deletions(-) diff --git a

[PATCH v2 3/5] memory: renesas-rpc-if: Fix a reference leak in rpcif_probe()

2020-11-26 Thread Lad Prabhakar
Release the node reference by calling of_node_put(flash) in the probe. Fixes: ca7d8b980b67f ("memory: add Renesas RPC-IF driver") Reported-by: Pavel Machek Signed-off-by: Lad Prabhakar Cc: sta...@vger.kernel.org Reviewed-by: Sergei Shtylyov --- drivers/memory/renesas-rpc-if.c | 2

[PATCH v2 4/5] memory: renesas-rpc-if: Make rpcif_enable/disable_rpm() as static inline

2020-11-26 Thread Lad Prabhakar
Define rpcif_enable_rpm() and rpcif_disable_rpm() as static inline in the header instead of exporting them. Suggested-by: Pavel Machek Signed-off-by: Lad Prabhakar --- drivers/memory/renesas-rpc-if.c | 13 - include/memory/renesas-rpc-if.h | 13 +++-- 2 files changed, 11

[PATCH v2 2/5] memory: renesas-rpc-if: Fix unbalanced pm_runtime_enable in rpcif_{enable,disable}_rpm

2020-11-26 Thread Lad Prabhakar
rpcif_enable_rpm calls pm_runtime_enable, so rpcif_disable_rpm needs to call pm_runtime_disable and not pm_runtime_put_sync. Fixes: ca7d8b980b67f ("memory: add Renesas RPC-IF driver") Reported-by: Reported-by: Geert Uytterhoeven Signed-off-by: Lad Prabhakar Cc: sta...@vger.

[PATCH v2 0/5] memory: renesas-rpc-if: Trivial fixes

2020-11-26 Thread Lad Prabhakar
Hi All, This patch series fixes trivial issues in RPC-IF driver. Changes for v2: * Balanced PM in rpcif_disable_rpm * Fixed typo in patch 4/5 * Dropped C++ style fixes patch * Included RB tags from Sergei Cheers, Prabhakar Lad Prabhakar (5): memory: renesas-rpc-if: Return correct value to

RE: [PATCH v4 1/2] ARM: dts: r8a7742-iwg21d-q7-dbcm-ca: Separate out ov5640 nodes

2020-11-26 Thread Prabhakar Mahadev Lad
Hi Geert, > -Original Message- > From: Geert Uytterhoeven > Sent: 26 November 2020 13:41 > To: Prabhakar ; Magnus Damm > ; Rob Herring > > Cc: Biju Das ; linux-renesas-...@vger.kernel.org; > devicet...@vger.kernel.org; linux-kernel@vger.kernel.org; Prabh

[PATCH v3 1/2] ARM: dts: r8a7742-iwg21d-q7-dbcm-ca: Separate out ov5640 nodes

2020-11-26 Thread Lad Prabhakar
The camera daughter board can also be connected to 8-bit ov7725 sensors, so in preparation for configurable option to choose depending on the camera's connected separate out ov5640 nodes in a dtsi file. Signed-off-by: Lad Prabhakar Reviewed-by: Biju Das --- .../boot/dts/r8a7742-iwg21d-q7

[PATCH v3 2/2] ARM: dts: r8a7742-iwg21d-q7-dbcm-ca: Add support for 8-bit ov7725 sensors

2020-11-26 Thread Lad Prabhakar
The 8-bit ov7725 sensors can also be connected to the camera daughter board. This patch creates a separate dtsi file for ov7725 sensors and is included in r8a7742-iwg21d-q7-dbcm-ca.dts. The user can set VINx_SENSOR depending on the cameras connected. Signed-off-by: Lad Prabhakar Reviewed-by

[PATCH v3 0/2] r8a7742-iwg21d-q7-dbcm: Add support for ov7725 sensors

2020-11-26 Thread Lad Prabhakar
cameras connected to VINx interfaces. Changes for v2: * Separated out ov5640 ep into a new dtsi v1: https://patchwork.kernel.org/project/linux-renesas-soc/patch/ 20201120151343.24175-1-prabhakar.mahadev-lad...@bp.renesas.com/ Cheers, Prabhakar Lad Prabhakar (2): ARM: dts: r8a7742-iwg21d-q7-dbcm

Re: [PATCH v2 0/2] r8a7742-iwg21d-q7-dbcm: Add support for ov7725 sensors

2020-11-25 Thread Lad, Prabhakar
Hi Geert, On Wed, Nov 25, 2020 at 4:32 PM Geert Uytterhoeven wrote: > > Hi Prabhakar, > > On Wed, Nov 25, 2020 at 5:26 PM Prabhakar Mahadev Lad > wrote: > > > -Original Message- > > > From: Geert Uytterhoeven > > > Sent: 25 November 2020 16:21

RE: [PATCH v2 0/2] r8a7742-iwg21d-q7-dbcm: Add support for ov7725 sensors

2020-11-25 Thread Prabhakar Mahadev Lad
Hi Geert, > -Original Message- > From: Geert Uytterhoeven > Sent: 25 November 2020 16:21 > To: Prabhakar Mahadev Lad > Cc: Magnus Damm ; Rob Herring ; > Linux-Renesas renesas-...@vger.kernel.org>; open list:OPEN FIRMWARE AND FLATTENED DEVICE > TREE BINDINGS

Re: [PATCH 2/5] memory: renesas-rpc-if: Make rpcif_enable/disable_rpm() as static inline

2020-11-25 Thread Lad, Prabhakar
Hi Geert, Thank you for the review. On Tue, Nov 24, 2020 at 3:43 PM Geert Uytterhoeven wrote: > > Hi Prabhakar, > > On Tue, Nov 24, 2020 at 12:27 PM Lad Prabhakar > wrote: > > Define rpcif_enable_rpm() and rpcif_disable_rpm() as static > > inline in the hea

Re: [PATCH 0/5] memory: renesas-rpc-if: Trivial fixes

2020-11-25 Thread Lad, Prabhakar
On Tue, Nov 24, 2020 at 6:25 PM Sergei Shtylyov wrote: > > On 11/24/20 2:34 PM, Lad, Prabhakar wrote: > > [...] > >> This patch series fixes trivial issues in RPC-IF driver. > >> > >> Cheers, > >> Prabhakar > >> > >> Lad Prabhak

[PATCH v2 1/2] ARM: dts: r8a7742-iwg21d-q7-dbcm-ca: Separate out ov5640 nodes

2020-11-25 Thread Lad Prabhakar
The camera daughter board can also be connected to 8-bit ov7725 sensors, so in preparation for configurable option to choose depending on the camera's connected separate out ov5640 nodes in a dtsi file. Signed-off-by: Lad Prabhakar Reviewed-by: Biju Das --- .../boot/dts/r8a7742-iwg21d-q7

[PATCH v2 2/2] ARM: dts: r8a7742-iwg21d-q7-dbcm-ca: Add support for 8-bit ov7725 sensors

2020-11-25 Thread Lad Prabhakar
The 8-bit ov7725 sensors can also be connected to the camera daughter board. This patch creates a separate dtsi file for ov7725 sensors and is included in r8a7742-iwg21d-q7-dbcm-ca.dts (which is commented out as by default ov5640 is enabled) Signed-off-by: Lad Prabhakar Reviewed-by: Biju Das

[PATCH v2 0/2] r8a7742-iwg21d-q7-dbcm: Add support for ov7725 sensors

2020-11-25 Thread Lad Prabhakar
: https://patchwork.kernel.org/project/linux-renesas-soc/patch/ 20201120151343.24175-1-prabhakar.mahadev-lad...@bp.renesas.com/ Cheers, Prabhakar Lad Prabhakar (2): ARM: dts: r8a7742-iwg21d-q7-dbcm-ca: Separate out ov5640 nodes ARM: dts: r8a7742-iwg21d-q7-dbcm-ca: Add support for 8-bit

Re: [PATCH] ARM: dts: r8a7742-iwg21d-q7-dbcm-ca: Add OV7725 nodes

2020-11-24 Thread Lad, Prabhakar
Hi Geert, Thank you for the review. On Tue, Nov 24, 2020 at 9:04 AM Geert Uytterhoeven wrote: > > Hi Prabhakar, > > On Fri, Nov 20, 2020 at 4:13 PM Lad Prabhakar > wrote: > > Add the ov7725 endpoint nodes to the camera daughter board. The ov7725 > > sensors can

Re: [PATCH 0/5] memory: renesas-rpc-if: Trivial fixes

2020-11-24 Thread Lad, Prabhakar
Hi Sergei, On Tue, Nov 24, 2020 at 11:26 AM Lad Prabhakar wrote: > > Hi All, > > This patch series fixes trivial issues in RPC-IF driver. > > Cheers, > Prabhakar > > Lad Prabhakar (5): > memory: renesas-rpc-if: Return correct value to the caller of > rpcif_

[PATCH 1/5] memory: renesas-rpc-if: Return correct value to the caller of rpcif_manual_xfer()

2020-11-24 Thread Lad Prabhakar
in error path. Also now we ignore the value returned by reset_control_reset() in the error path and instead print a error message when it fails. Fixes: ca7d8b980b67f ("memory: add Renesas RPC-IF driver") Reported-by: Pavel Machek Signed-off-by: Lad Prabhakar Cc: sta...@vger.

[PATCH 5/5] memory: renesas-rpc-if: Fix a reference leak in rpcif_probe()

2020-11-24 Thread Lad Prabhakar
Release the node reference by calling of_node_put(flash) in the probe. Fixes: ca7d8b980b67f ("memory: add Renesas RPC-IF driver") Reported-by: Pavel Machek Signed-off-by: Lad Prabhakar Cc: sta...@vger.kernel.org --- drivers/memory/renesas-rpc-if.c | 2 ++ 1 file changed, 2 insertion

[PATCH 4/5] memory: renesas-rpc-if: Avoid use of C++ style comments

2020-11-24 Thread Lad Prabhakar
Replace C++ style comment with C style. While at it also replace the tab with a space between struct and struct name. Suggested-by: Pavel Machek Signed-off-by: Lad Prabhakar --- include/memory/renesas-rpc-if.h | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/include

[PATCH 3/5] memory: renesas-rpc-if: Export symbols as GPL

2020-11-24 Thread Lad Prabhakar
Renesas RPC-IF driver is licensed under GPL2.0, to be in sync export the symbols as GPL. Suggested-by: Pavel Machek Signed-off-by: Lad Prabhakar --- drivers/memory/renesas-rpc-if.c | 10 +- 1 file changed, 5 insertions(+), 5 deletions(-) diff --git a/drivers/memory/renesas-rpc-if.c b

[PATCH 2/5] memory: renesas-rpc-if: Make rpcif_enable/disable_rpm() as static inline

2020-11-24 Thread Lad Prabhakar
Define rpcif_enable_rpm() and rpcif_disable_rpm() as static inline in the header instead of exporting it. Suggested-by: Pavel Machek Signed-off-by: Lad Prabhakar --- drivers/memory/renesas-rpc-if.c | 13 - include/memory/renesas-rpc-if.h | 13 +++-- 2 files changed, 11

[PATCH 0/5] memory: renesas-rpc-if: Trivial fixes

2020-11-24 Thread Lad Prabhakar
Hi All, This patch series fixes trivial issues in RPC-IF driver. Cheers, Prabhakar Lad Prabhakar (5): memory: renesas-rpc-if: Return correct value to the caller of rpcif_manual_xfer() memory: renesas-rpc-if: Make rpcif_enable/disable_rpm() as static inline memory: renesas-rpc-if

[PATCH] ARM: dts: r8a7742-iwg21d-q7-dbcm-ca: Add OV7725 nodes

2020-11-20 Thread Lad Prabhakar
out. Signed-off-by: Lad Prabhakar Reviewed-by: Biju Das --- Hi All, This patch is based on top of [1]. [1] https://git.kernel.org/pub/scm/linux/kernel/git/geert/ renesas-devel.git/log/?h=renesas-arm-dt-for-v5.11 Cheers, Prabhakar --- .../boot/dts/r8a7742-iwg21d-q7-dbcm-ca.dts| 93

Re: [PATCH 1/4] pinctrl: renesas: r8a77990: Add QSPI[01] pins, groups and functions

2020-11-20 Thread Lad, Prabhakar
Hi Geert, Thank you for the review. On Fri, Nov 20, 2020 at 9:20 AM Geert Uytterhoeven wrote: > > On Thu, Nov 19, 2020 at 2:09 PM Lad Prabhakar > wrote: > > Add pins, groups and functions for QSPIO[01]. > > > > Signed-off-by: Lad Prabhakar > > Reviewed-by:

[PATCH 3/4] pinctrl: renesas: r8a7796: Add QSPI[01] pins, groups and functions

2020-11-19 Thread Lad Prabhakar
Add pins, groups and functions for QSPIO[01]. Signed-off-by: Lad Prabhakar Reviewed-by: Biju Das --- drivers/pinctrl/renesas/pfc-r8a7796.c | 75 ++- 1 file changed, 73 insertions(+), 2 deletions(-) diff --git a/drivers/pinctrl/renesas/pfc-r8a7796.c b/drivers/pinctrl

[PATCH 4/4] pinctrl: renesas: r8a77965: Add QSPI[01] pins, groups and functions

2020-11-19 Thread Lad Prabhakar
Add pins, groups and functions for QSPIO[01]. Signed-off-by: Lad Prabhakar Reviewed-by: Biju Das --- drivers/pinctrl/renesas/pfc-r8a77965.c | 75 +- 1 file changed, 73 insertions(+), 2 deletions(-) diff --git a/drivers/pinctrl/renesas/pfc-r8a77965.c b/drivers/pinctrl

[PATCH 1/4] pinctrl: renesas: r8a77990: Add QSPI[01] pins, groups and functions

2020-11-19 Thread Lad Prabhakar
Add pins, groups and functions for QSPIO[01]. Signed-off-by: Lad Prabhakar Reviewed-by: Biju Das --- drivers/pinctrl/renesas/pfc-r8a77990.c | 75 +- 1 file changed, 73 insertions(+), 2 deletions(-) diff --git a/drivers/pinctrl/renesas/pfc-r8a77990.c b/drivers/pinctrl

[PATCH 0/4] Renesas add QSPI{0,1} pins to r8a77{96,951,965,990} SoC

2020-11-19 Thread Lad Prabhakar
Hi All, This patch series adds QSPI{0,1} pins to r8a77{96,951,965,990} SoC. Patches are based on top of [1]. [1] https://git.kernel.org/pub/scm/linux/kernel/git/geert/ renesas-drivers.git/log/?h=renesas-pinctrl-for-v5.11 Cheers, Prabhakar Lad Prabhakar (4): pinctrl: renesas: r8a77990

[PATCH 2/4] pinctrl: renesas: r8a77951: Add QSPI[01] pins, groups and functions

2020-11-19 Thread Lad Prabhakar
Add pins, groups and functions for QSPIO[01]. Signed-off-by: Lad Prabhakar Reviewed-by: Biju Das --- drivers/pinctrl/renesas/pfc-r8a77951.c | 75 +- 1 file changed, 73 insertions(+), 2 deletions(-) diff --git a/drivers/pinctrl/renesas/pfc-r8a77951.c b/drivers/pinctrl

RE: [RESEND PATCH] dt-bindings: pci: rcar-pci: Add device tree support for r8a774e1

2020-11-19 Thread Prabhakar Mahadev Lad
Hi Lorenzo, > -Original Message- > From: Lorenzo Pieralisi > Sent: 19 November 2020 11:27 > To: Prabhakar Mahadev Lad > Cc: Bjorn Helgaas ; Marek Vasut > ; Yoshihiro > Shimoda ; Rob Herring ; > linux- > p...@vger.kernel.org; linux-renesas-...@

[PATCH v4] clk: renesas: r8a774c0: Add RPC clocks

2020-11-16 Thread Lad Prabhakar
), parent and the divider is set based on the register value CPG_RPCCKCR[4:3] which has been set prior to booting the kernel. Signed-off-by: Lad Prabhakar Reviewed-by: Biju Das --- v3->v4 * Dropped cross verification of clock source * Changed DEF_FIXED_RPCSRC_E3 macro so that SoC specific div can

Re: [PATCH v3] clk: renesas: r8a774c0: Add RPC clocks

2020-11-16 Thread Lad, Prabhakar
Hi Geert, Thank you for the review. On Mon, Nov 16, 2020 at 8:34 AM Geert Uytterhoeven wrote: > > Hi Prabhakar, > > On Tue, Nov 10, 2020 at 1:56 PM Lad Prabhakar > wrote: > > Describe the RPCSRC internal clock and the RPC[D2] clocks derived from it, > > as well as

Re: [PATCH] mtd: spi-nor: winbond: Add support for w25m512jw

2020-11-10 Thread Lad, Prabhakar
On Tue, Nov 10, 2020 at 12:58 PM Vignesh Raghavendra wrote: > > > > On 10/16/20 5:25 PM, Lad Prabhakar wrote: > > This chip is (nearly) identical to the Winbond w25m512jv which is > > already supported by Linux. Compared to the w25m512jv, the 'jw' > > has

[PATCH v3] clk: renesas: r8a774c0: Add RPC clocks

2020-11-10 Thread Lad Prabhakar
s PLL1 0 1 00 -> RPCSRC CLK source is PLL1 1 0 11 -> RPCSRC CLK source is PLL1 x x xx -> For any other values RPCSRC CLK source is PLL0 Signed-off-by: Lad Prabhakar Reviewed-by: Biju Das --- v2->v3 * Implemented as a fixed clo

RE: [PATCH] arm64: dts: renesas: hihope-rev4: Add a comment explaining switch SW2404 required for audio_clk_b

2020-11-09 Thread Prabhakar Mahadev Lad
Hi Geert, Thank you for the review. > -Original Message- > From: Geert Uytterhoeven > Sent: 09 November 2020 10:09 > To: Prabhakar Mahadev Lad > Cc: Magnus Damm ; Rob Herring ; > Linux-Renesas renesas-...@vger.kernel.org>; open list:OPEN FIRMWARE AND FLATTENED DE

RE: [PATCH] arm64: dts: renesas: r8a774e1: Add missing audio_clk_b

2020-11-09 Thread Prabhakar Mahadev Lad
Hi Geert, > -Original Message- > From: Geert Uytterhoeven > Sent: 09 November 2020 10:10 > To: Prabhakar Mahadev Lad > Cc: Magnus Damm ; Rob Herring ; > Linux-Renesas renesas-...@vger.kernel.org>; open list:OPEN FIRMWARE AND FLATTENED DEVICE > TREE BINDINGS

RE: [PATCH] arm64: dts: renesas: r8a774e1: Add missing audio_clk_b

2020-11-09 Thread Prabhakar Mahadev Lad
Hi Geert, Thank you for the review. > -Original Message- > From: Geert Uytterhoeven > Sent: 09 November 2020 10:02 > To: Prabhakar Mahadev Lad > Cc: Magnus Damm ; Rob Herring ; > Linux-Renesas renesas-...@vger.kernel.org>; open list:OPEN FIRMWARE AND FLATTENED DE

[PATCH] arm64: dts: renesas: hihope-rev4: Add a comment explaining switch SW2404 required for audio_clk_b

2020-11-05 Thread Lad Prabhakar
Switch SW2404 should be at poistion 1 so that clock output from CS2000 is connected to AUDIO_CLKB_A. Signed-off-by: Lad Prabhakar Reviewed-by: Chris Paterson --- arch/arm64/boot/dts/renesas/hihope-rev4.dtsi | 6 +- 1 file changed, 5 insertions(+), 1 deletion(-) diff --git a/arch/arm64

Re: [RESEND PATCH] dt-bindings: ata: renesas,rcar-sata: Add r8a774e1 support

2020-11-05 Thread Lad, Prabhakar
Hi Jens, On Mon, Sep 21, 2020 at 8:22 AM Lad Prabhakar wrote: > > Document SATA support for the RZ/G2H, no driver change required. > > Signed-off-by: Lad Prabhakar > Reviewed-by: Marian-Cristian Rotariu > > Acked-by: Rob Herring > Reviewed-by: Geert Uytterhoeven

[PATCH] arm64: dts: renesas: r8a774e1: Add missing audio_clk_b

2020-11-04 Thread Lad Prabhakar
Add audio_clk_b configured as 0 Hz, this will be overridden by the boards providing the audio clock. Fixes: 8183a7938cfec ("arm64: dts: renesas: r8a774e1: Add audio support") Reported-by: Nobuhiro Iwamatsu Signed-off-by: Lad Prabhakar --- Hi Geert, I have rebased this patch on rene

Re: [PATCH v2] clk: renesas: r8a774c0: Add RPC clocks

2020-10-30 Thread Lad, Prabhakar
Hi Geert, Thank you for the review. On Thu, Oct 29, 2020 at 2:29 PM Geert Uytterhoeven wrote: > > Hi Prabhakar, > > On Thu, Oct 29, 2020 at 11:55 AM Lad Prabhakar > wrote: > > Describe the RPCSRC internal clock and the RPC[D2] clocks derived from it, > > as well as

[PATCH v2] clk: renesas: r8a774c0: Add RPC clocks

2020-10-29 Thread Lad Prabhakar
1 0 11 -> RPCSRC CLK source is PLL1 x x xx -> For any other values RPCSRC CLK source is PLL0 R-Car Gen3 manual Rev.2.20 has in-correct information related to determining the clock source for RPCSRC. Signed-off-by: Lad Prabhakar Reviewed-by: Biju Das --- Hi

Re: [PATCH 0/2] RZ/G2x add optee node

2020-10-27 Thread Lad, Prabhakar
Hi Geert, On Fri, Oct 23, 2020 at 8:55 AM Lad Prabhakar wrote: > > Hi All, > > This patch series adds optee node to HiHope RZ/G2{HMN} and EK874 boards. > > This patch series applies on top of [1]. > > [1] https://git.kernel.org/pub/scm/linux/kernel/git/geert/ >

[PATCH] PCI: pcie-rcar-host: Drop unused members from struct rcar_pcie_host

2020-10-23 Thread Lad Prabhakar
Drop unused members dev and base from struct rcar_pcie_host. Signed-off-by: Lad Prabhakar --- drivers/pci/controller/pcie-rcar-host.c | 2 -- 1 file changed, 2 deletions(-) diff --git a/drivers/pci/controller/pcie-rcar-host.c b/drivers/pci/controller/pcie-rcar-host.c index cdc0963f154e

Re: [PATCH 4/4] clk: renesas: r8a774c0: Add RPC clocks

2020-10-23 Thread Lad, Prabhakar
Hi Geert, Thank you for the review. On Thu, Oct 22, 2020 at 3:09 PM Geert Uytterhoeven wrote: > > Hi Prabhakar, > > On Fri, Oct 16, 2020 at 2:17 PM Lad Prabhakar > wrote: > > Describe the RPCSRC internal clock and the RPC[D2] clocks derived from it, > > as well as

RE: [PATCH v2 3/4] arm64: dts: renesas: Add support for MIPI Adapter V2.1 connected to HiHope RZ/G2M

2020-10-23 Thread Prabhakar Mahadev Lad
Hi Geert, Thank you for the review. > -Original Message- > From: Geert Uytterhoeven > Sent: 23 October 2020 08:50 > To: Prabhakar Mahadev Lad > Cc: Geert Uytterhoeven ; Magnus Damm > ; Rob Herring ; > Linux-Renesas ; open list:OPEN FIRMWARE > AND FLATTE

[PATCH 2/2] arm64: dts: renesas: r8a774c0-ek874: Add optee node

2020-10-23 Thread Lad Prabhakar
Add optee device tree node to EK874 board. Signed-off-by: Lad Prabhakar Reviewed-by: Biju Das --- arch/arm64/boot/dts/renesas/r8a774c0-ek874.dts | 7 +++ 1 file changed, 7 insertions(+) diff --git a/arch/arm64/boot/dts/renesas/r8a774c0-ek874.dts b/arch/arm64/boot/dts/renesas/r8a774c0

[PATCH 1/2] arm64: dts: renesas: hihope-common: Add optee node

2020-10-23 Thread Lad Prabhakar
Add optee device tree node to HiHope RZ/G2{HMN} boards. Signed-off-by: Lad Prabhakar Reviewed-by: Biju Das --- arch/arm64/boot/dts/renesas/hihope-common.dtsi | 7 +++ 1 file changed, 7 insertions(+) diff --git a/arch/arm64/boot/dts/renesas/hihope-common.dtsi b/arch/arm64/boot/dts/renesas

[PATCH 0/2] RZ/G2x add optee node

2020-10-23 Thread Lad Prabhakar
Hi All, This patch series adds optee node to HiHope RZ/G2{HMN} and EK874 boards. This patch series applies on top of [1]. [1] https://git.kernel.org/pub/scm/linux/kernel/git/geert/ renesas-devel.git/log/?h=renesas-arm-dt-for-v5.11 Cheers, Prabhakar Lad Prabhakar (2): arm64: dts: renesas

Re: [PATCH] ARM: dts: r8a7742-iwg21d-q7-dbcm-ca: Enable VIN instances

2020-10-22 Thread Lad, Prabhakar
Hi Geert, Thank you for the review. On Thu, Oct 22, 2020 at 12:43 PM Geert Uytterhoeven wrote: > > Hi Prabhakar, > > On Wed, Oct 14, 2020 at 4:56 PM Lad Prabhakar > wrote: > > Enable VIN instances along with OV5640 as endpoints on the adapter board. > > >

[PATCH v2 4/4] arm64: dts: renesas: Add support for MIPI Adapter V2.1 connected to HiHope RZ/G2N

2020-10-20 Thread Lad Prabhakar
Add support for AISTARVISION MIPI Adapter V2.1 board connected to HiHope RZ/G2N board. Signed-off-by: Lad Prabhakar Reviewed-by: Biju Das --- v1->v2 - No change --- arch/arm64/boot/dts/renesas/Makefile | 1 + .../r8a774b1-hihope-rzg2n-ex-mipi-2.1.dts|

[PATCH v2 1/4] arm64: dts: renesas: aistarvision-mipi-adapter-2.1: Add parent macro for each sensor

2020-10-20 Thread Lad Prabhakar
For HiHope RZ/G2H the OV5645 sensor is populated on i2c2 whereas the imx219 sensor is populated on i2c3 so add support for handling such cases by adding a parent macro for each sensor. Also update r8a774c0-ek874-mipi-2.1.dts to incorporate the changes. Signed-off-by: Lad Prabhakar Reviewed-by

[PATCH v2 2/4] arm64: dts: renesas: Add support for MIPI Adapter V2.1 connected to HiHope RZ/G2H

2020-10-20 Thread Lad Prabhakar
CSI40. Signed-off-by: Lad Prabhakar Reviewed-by: Biju Das --- v1->v2 - No change --- arch/arm64/boot/dts/renesas/Makefile | 1 + ...rzg2-ex-aistarvision-mipi-adapter-2.1.dtsi | 109 ++ .../r8a774e1-hihope-rzg2h-ex-mipi-2.1.dts | 16 +++ 3 files changed,

[PATCH v2 0/4] HiHope RZ/G2x add MIPI Adapter board support

2020-10-20 Thread Lad Prabhakar
Hi All, This patch series adds support for MIPI Adapter V2.1 connected to HiHope RZ/G2{HMN}. Patches apply on top of [1]. [1] https://git.kernel.org/pub/scm/linux/kernel/git/geert/ renesas-devel.git/log/?h=renesas-arm-dt-for-v5.11 Cheers, Prabhakar Changes for v2: * patches {1,2,4}/4

[PATCH v2 3/4] arm64: dts: renesas: Add support for MIPI Adapter V2.1 connected to HiHope RZ/G2M

2020-10-20 Thread Lad Prabhakar
Add support for AISTARVISION MIPI Adapter V2.1 board connected to HiHope RZ/G2M board. Signed-off-by: Lad Prabhakar Reviewed-by: Biju Das --- v1->v2 * Disabled CSI40 amd imx219 nodes * Added a comment wrt CSI40 as it supports only 4 lane mode --- arch/arm64/boot/dts/renesas/Makef

[PATCH 1/4] clk: renesas: rcar-gen3: Add support to pass custom RPCSRC div table

2020-10-16 Thread Lad Prabhakar
PCSRC. Signed-off-by: Lad Prabhakar Reviewed-by: Biju Das --- drivers/clk/renesas/rcar-gen3-cpg.c| 2 ++ drivers/clk/renesas/renesas-cpg-mssr.h | 6 ++ 2 files changed, 8 insertions(+) diff --git a/drivers/clk/renesas/rcar-gen3-cpg.c b/drivers/clk/renesas/rcar-gen3-cpg.c index 488f8b3

[PATCH 3/4] clk: renesas: r8a774b1: Add RPC clocks

2020-10-16 Thread Lad Prabhakar
ff-by: Lad Prabhakar --- drivers/clk/renesas/r8a774b1-cpg-mssr.c | 8 1 file changed, 8 insertions(+) diff --git a/drivers/clk/renesas/r8a774b1-cpg-mssr.c b/drivers/clk/renesas/r8a774b1-cpg-mssr.c index f436691271ec..6f04c40fe237 100644 --- a/drivers/clk/renesas/r8a774b1-cpg-mssr.c +++ b/d

  1   2   3   4   5   6   7   8   9   10   >