From: "Lad, Prabhakar"
this patch does the following:
a> uses devm_kzalloc() instead of kzalloc and cleanup the error path
b> uses devm_ioremap() instead of ioremap and cleanup the error path
c> uses devm_request_irq() instead of request_irq and cleanup the error path
Signed-off-by: Lad,
From: Lad, Prabhakar prabhakar.cse...@gmail.com
this patch does the following:
a uses devm_kzalloc() instead of kzalloc and cleanup the error path
b uses devm_ioremap() instead of ioremap and cleanup the error path
c uses devm_request_irq() instead of request_irq and cleanup the error path
On Tue, Jan 13, 2015 at 1:39 PM, Maxime Ripard
wrote:
> On Tue, Jan 13, 2015 at 11:53:01AM +0000, Prabhakar Lad wrote:
>> On Tue, Jan 13, 2015 at 11:43 AM, Tomi Valkeinen
>> wrote:
>> > On 08/01/15 10:17, Lad, Prabhakar wrote:
>> >> this patch checks the
lting in a garbage error code...
>
Agreed I have just aligned this to rest of the code in this function.
Maxime if you are OK I'll post a patch returning error then and there ?
Thanks,
--Prabhakar Lad
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majord...@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/
then and there ?
Thanks,
--Prabhakar Lad
--
To unsubscribe from this list: send the line unsubscribe linux-kernel in
the body of a message to majord...@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/
On Tue, Jan 13, 2015 at 1:39 PM, Maxime Ripard
maxime.rip...@free-electrons.com wrote:
On Tue, Jan 13, 2015 at 11:53:01AM +, Prabhakar Lad wrote:
On Tue, Jan 13, 2015 at 11:43 AM, Tomi Valkeinen tomi.valkei...@ti.com
wrote:
On 08/01/15 10:17, Lad, Prabhakar wrote:
this patch checks
e to utilize my holidays
in proper way :D
Thanks,
--Prabhakar Lad
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majord...@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/
to utilize my holidays
in proper way :D
Thanks,
--Prabhakar Lad
--
To unsubscribe from this list: send the line unsubscribe linux-kernel in
the body of a message to majord...@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org
;> > here, but for the sanity of gcc output explicitly initialize it.
>> > Same goes for the 'end' variable.
>>
>> Prabhakar Lad also sent a patch for this already, which was lacking
>> a good patch description. Your patch does this slightly better but
>> still fai
, but for the sanity of gcc output explicitly initialize it.
Same goes for the 'end' variable.
Prabhakar Lad also sent a patch for this already, which was lacking
a good patch description. Your patch does this slightly better but
still fails to explain how you concluded it was safe and you don't
really explain
still accepted for
> 3.19.
>
OK will post a v4 tonight fixing all the below issues.
FYI: Looking at the response of Mauro on 'soc-camera: 1st set for 3.19'
he wont accept it!
Thanks,
--Prabhakar Lad
> On 12/04/2014 12:12 AM, Lad, Prabhakar wrote:
>> From: Benoit Parrot
>>
>&
accepted for
3.19.
OK will post a v4 tonight fixing all the below issues.
FYI: Looking at the response of Mauro on 'soc-camera: 1st set for 3.19'
he wont accept it!
Thanks,
--Prabhakar Lad
On 12/04/2014 12:12 AM, Lad, Prabhakar wrote:
From: Benoit Parrot bpar...@ti.com
This patch adds Video
; Please explain why the compiler thinks there is a bug, why you
> are sure that there isn't, and why you picked '0' as the
> initialization value.
>
Its a false positive, to suppress the warning '0' was picked.
Thanks,
--Prabhakar Lad
--
To unsubscribe from this list: send the line &
are sure that there isn't, and why you picked '0' as the
initialization value.
Its a false positive, to suppress the warning '0' was picked.
Thanks,
--Prabhakar Lad
--
To unsubscribe from this list: send the line unsubscribe linux-kernel in
the body of a message to majord...@vger.kernel.org
a_res.start;
>
> This does look quite ugly... Where does the warning come from in the
> first place. Isn't vga_res.start (resource_size_t) the size of a pointer?
>
Yes looks ugly, I am not sure what you meant from 'where does this warning
come from' its in the commit message.
Thanks,
of a pointer?
Yes looks ugly, I am not sure what you meant from 'where does this warning
come from' its in the commit message.
Thanks,
--Prabhakar Lad
--
To unsubscribe from this list: send the line unsubscribe linux-kernel in
the body of a message to majord...@vger.kernel.org
More majordomo info
virtio64)cpu_to_le64(val);
> + else
> + return (__force __virtio64)val;
> +}
> +
Nitpicking, could remove the else for the all above functions and
align the return appropriately ?
Apart from that patch looks good.
Acked-by: Lad, Prabhakar
Thanks,
--Prabha
3 Sequence: 119 Field: None Timestamp: 76.711771s
test MMAP: OK
test USERPTR: OK (Not Supported)
test DMABUF: Cannot test, specify --expbuf-device
Total: 42, Succeeded: 42, Failed: 0, Warnings: 0
Thanks,
--Prabhakar Lad
--
To unsubscribe from this list: send the line "unsub
Hi Michal,
On Tue, Dec 2, 2014 at 9:36 AM, Michal Simek wrote:
> On 12/02/2014 10:31 AM, Prabhakar Lad wrote:
>> Hi Michal,
>>
>> Thanks for the patch.
>>
>> On Mon, Dec 1, 2014 at 1:00 PM, Michal Simek wrote:
>>> Modules can use this function for cr
| 1 +
> 1 file changed, 1 insertion(+)
>
don’t you need to add an entry in include/linux/genalloc.h ?
Thanks,
--Prabhakar Lad
> diff --git a/lib/genalloc.c b/lib/genalloc.c
> index cce4dd68c40d..2e65d206b01c 100644
> --- a/lib/genalloc.c
> +++ b/lib/genalloc.c
> @@ -598,6 +598,7
/genalloc.c | 1 +
1 file changed, 1 insertion(+)
don’t you need to add an entry in include/linux/genalloc.h ?
Thanks,
--Prabhakar Lad
diff --git a/lib/genalloc.c b/lib/genalloc.c
index cce4dd68c40d..2e65d206b01c 100644
--- a/lib/genalloc.c
+++ b/lib/genalloc.c
@@ -598,6 +598,7 @@ struct
Hi Michal,
On Tue, Dec 2, 2014 at 9:36 AM, Michal Simek michal.si...@xilinx.com wrote:
On 12/02/2014 10:31 AM, Prabhakar Lad wrote:
Hi Michal,
Thanks for the patch.
On Mon, Dec 1, 2014 at 1:00 PM, Michal Simek michal.si...@xilinx.com wrote:
Modules can use this function for creating pool
Sequence: 119 Field: None Timestamp: 76.711771s
test MMAP: OK
test USERPTR: OK (Not Supported)
test DMABUF: Cannot test, specify --expbuf-device
Total: 42, Succeeded: 42, Failed: 0, Warnings: 0
Thanks,
--Prabhakar Lad
--
To unsubscribe from this list: send the line
?
Apart from that patch looks good.
Acked-by: Lad, Prabhakar prabhakar.cse...@gmail.com
Thanks,
--Prabhakar Lad
--
To unsubscribe from this list: send the line unsubscribe linux-kernel in
the body of a message to majord...@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo
Hi Hans,
On Mon, Dec 1, 2014 at 11:26 PM, Laurent Pinchart
wrote:
> Hi Prabhakar,
>
> On Sunday 30 November 2014 21:30:35 Prabhakar Lad wrote:
>> On Sun, Nov 30, 2014 at 9:16 PM, Laurent Pinchart wrote:
>> > On Sunday 30 November 2014 21:05:50 Prabhakar Lad wrote:
>>
Hi Hans,
On Tue, Dec 2, 2014 at 7:32 AM, Hans Verkuil wrote:
> On 12/01/2014 11:27 PM, Prabhakar Lad wrote:
>> Hi Hans,
>>
>> On Mon, Dec 1, 2014 at 11:00 AM, Hans Verkuil wrote:
>>> On 12/01/2014 11:11 AM, Hans Verkuil wrote:
>>>> Hi all,
>&
Hi Hans,
On Tue, Dec 2, 2014 at 7:26 AM, Hans Verkuil wrote:
> On 12/01/2014 11:17 PM, Prabhakar Lad wrote:
>> Hi Hans,
>>
>> Thanks for the review.
>>
>> On Mon, Dec 1, 2014 at 10:11 AM, Hans Verkuil wrote:
>>> Hi all,
>>>
ion, unrelated to this patch series:
>
> Prabhakar, would it make sense to look at the various existing TI sources
> as well and rename them to make it more explicit for which SoCs they are
> meant? Most are pretty vague with variations on vpe, vpif, vpfe, etc. but
> no reference to th
Hi Hans,
Thanks for the review.
On Mon, Dec 1, 2014 at 10:11 AM, Hans Verkuil wrote:
> Hi all,
>
> Thanks for the patch, review comments are below.
>
> For the next version I would appreciate if someone can test this driver with
> the latest v4l2-compliance from the v4l-utils git repo. If
Hi Hans,
Thanks for the review.
On Mon, Dec 1, 2014 at 10:11 AM, Hans Verkuil hverk...@xs4all.nl wrote:
Hi all,
Thanks for the patch, review comments are below.
For the next version I would appreciate if someone can test this driver with
the latest v4l2-compliance from the v4l-utils git
series
dm6467/dm6467t/omapl138/am1808)
vpfe - under davinci is common for (Davinci series dm36x/dm6446/dm355)
I am falling short of names for renaming this common drivers :)
Thanks,
--Prabhakar Lad
--
To unsubscribe from this list: send the line unsubscribe linux-kernel in
the body of a message
Hi Hans,
On Tue, Dec 2, 2014 at 7:26 AM, Hans Verkuil hverk...@xs4all.nl wrote:
On 12/01/2014 11:17 PM, Prabhakar Lad wrote:
Hi Hans,
Thanks for the review.
On Mon, Dec 1, 2014 at 10:11 AM, Hans Verkuil hverk...@xs4all.nl wrote:
Hi all,
Thanks for the patch, review comments are below
Hi Hans,
On Tue, Dec 2, 2014 at 7:32 AM, Hans Verkuil hverk...@xs4all.nl wrote:
On 12/01/2014 11:27 PM, Prabhakar Lad wrote:
Hi Hans,
On Mon, Dec 1, 2014 at 11:00 AM, Hans Verkuil hverk...@xs4all.nl wrote:
On 12/01/2014 11:11 AM, Hans Verkuil wrote:
Hi all,
Thanks for the patch, review
Hi Hans,
On Mon, Dec 1, 2014 at 11:26 PM, Laurent Pinchart
laurent.pinch...@ideasonboard.com wrote:
Hi Prabhakar,
On Sunday 30 November 2014 21:30:35 Prabhakar Lad wrote:
On Sun, Nov 30, 2014 at 9:16 PM, Laurent Pinchart wrote:
On Sunday 30 November 2014 21:05:50 Prabhakar Lad wrote
--
> include/uapi/linux/virtio_scsi.h | 74
>
> include/uapi/linux/Kbuild| 1 +
Probably worth making a separate patch for this ? as it doesnt
match with patch description aswel.
Apart from that patch looks good.
Acked-by: Lad, Prabhakar
Hi Laurent,
On Sun, Nov 30, 2014 at 9:16 PM, Laurent Pinchart
wrote:
> On Sunday 30 November 2014 21:05:50 Prabhakar Lad wrote:
>> On Sat, Nov 29, 2014 at 7:12 PM, Laurent Pinchart wrote:
>> > Hi Prabhakar,
>>
>> [Snip]
>>
>> >> > Sure. Tha
t; configuration store. The userspace subdev API would use the configuration
> store from the file handle.
>
are planning to work/post any time soon ? Or are you OK with suggestion from
Hans ?
Thanks,
--Prabhakar Lad
--
To unsubscribe from this list: send the line "unsubscribe linux-k
subdev API would use the configuration
store from the file handle.
are planning to work/post any time soon ? Or are you OK with suggestion from
Hans ?
Thanks,
--Prabhakar Lad
--
To unsubscribe from this list: send the line unsubscribe linux-kernel in
the body of a message to majord
Hi Laurent,
On Sun, Nov 30, 2014 at 9:16 PM, Laurent Pinchart
laurent.pinch...@ideasonboard.com wrote:
On Sunday 30 November 2014 21:05:50 Prabhakar Lad wrote:
On Sat, Nov 29, 2014 at 7:12 PM, Laurent Pinchart wrote:
Hi Prabhakar,
[Snip]
Sure. That's a better choice than removing
, Prabhakar prabhakar.cse...@gmail.com
Regards,
--Prabhakar Lad
--
To unsubscribe from this list: send the line unsubscribe linux-kernel in
the body of a message to majord...@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org
lly wrote them like that in order to avoid writing essentially the
> same code three times over. If there will be more targets, the same repeats
> further, should one write those functions open for all different macro
> arguments. That's why it was a macro to begin with.
>
>> In add
Hi Laurent,
On Sat, Nov 29, 2014 at 6:11 PM, Laurent Pinchart
wrote:
> Hi Prabhakar,
>
> On Friday 28 November 2014 17:06:52 Prabhakar Lad wrote:
>> On Thu, Nov 27, 2014 at 9:32 PM, Laurent Pinchart wrote:
>> > Hi Prabhakar,
>>
>> [Snip]
>>
>> &g
Hi Laurent,
On Sat, Nov 29, 2014 at 6:11 PM, Laurent Pinchart
laurent.pinch...@ideasonboard.com wrote:
Hi Prabhakar,
On Friday 28 November 2014 17:06:52 Prabhakar Lad wrote:
On Thu, Nov 27, 2014 at 9:32 PM, Laurent Pinchart wrote:
Hi Prabhakar,
[Snip]
+ queue-queue.lock = queue
back then AFAIR.
But any functional changes here need to be Acked by Laurent first.
How do you want me to proceed on this ?
Thanks,
--Prabhakar Lad
--
To unsubscribe from this list: send the line unsubscribe linux-kernel in
the body of a message to majord...@vger.kernel.org
More majordomo info
e usb_autopm_get/put_interface() calls which I am not aware of.
Thanks,
--Prabhakar Lad
>> ret = vb2_queue_init(>queue);
>> if (ret)
>> return ret;
>
> --
> Regards,
>
> Laurent Pinchart
>
--
To unsubscribe from this list: send
not aware of.
Thanks,
--Prabhakar Lad
ret = vb2_queue_init(queue-queue);
if (ret)
return ret;
--
Regards,
Laurent Pinchart
--
To unsubscribe from this list: send the line unsubscribe linux-kernel in
the body of a message to majord...@vger.kernel.org
More majordomo info
t; The queue lock field isn't initialized by the uvcvideo driver, so you can't
> use vb2_ops_wait_prepare|finish().
>
Oops not sure what happened here I just took the patch from [1]
and added commit message. anyway will post a single patch v3.
[1] https://patchwork.kernel.org/patch/5327451/
T
by the uvcvideo driver, so you can't
use vb2_ops_wait_prepare|finish().
Oops not sure what happened here I just took the patch from [1]
and added commit message. anyway will post a single patch v3.
[1] https://patchwork.kernel.org/patch/5327451/
Thanks,
--Prabhakar Lad
Signed-off-by: Lad, Prabhakar
Hi,
On Tue, Nov 25, 2014 at 3:18 PM, Prabhakar Lad
wrote:
> Hi Mauro,
>
> On Tue, Nov 25, 2014 at 3:04 PM, Mauro Carvalho Chehab
> wrote:
>> Em Tue, 18 Nov 2014 10:57:48 +
> [Snip]
>>
>> -static u32 get_plane_info(struct gsc_frame *frm, u32 addr, u32 *ind
t;Plane address is wrong");
> return -EINVAL;
> }
> + return 0;
the control wont reach here! may be you can remove the complete else
part outside ?
with that change,
Reported-by: Lad, Prabhakar
Acked-by: Lad, Prabhakar
Thanks,
--Prabhakar Lad
> }
>
reach here! may be you can remove the complete else
part outside ?
with that change,
Reported-by: Lad, Prabhakar prabhakar.cse...@gmail.com
Acked-by: Lad, Prabhakar prabhakar.cse...@gmail.com
Thanks,
--Prabhakar Lad
}
void gsc_set_prefbuf(struct gsc_dev *gsc, struct gsc_frame *frm
Hi,
On Tue, Nov 25, 2014 at 3:18 PM, Prabhakar Lad
prabhakar.cse...@gmail.com wrote:
Hi Mauro,
On Tue, Nov 25, 2014 at 3:04 PM, Mauro Carvalho Chehab
mche...@osg.samsung.com wrote:
Em Tue, 18 Nov 2014 10:57:48 +
[Snip]
-static u32 get_plane_info(struct gsc_frame *frm, u32 addr, u32
the
> __V4L2_SUBDEV_MK_GET_TRY
> is removed and these three try functions are just written as proper
> static inlines. I find it very obfuscated code.
>
the functions were initially inline itself which were changes into
macro's later.
> In addition, because it is a macro you won't f
its way. It would be nice
> to see a real changelog on the patch, though.
>
Sorry there is no movement of code to other file. And I dont see any
reason why anybody reading will go haywire its a standard v4l2 thing.
The subject explains it all, If you still want me to elaborate I can
to see a real changelog on the patch, though.
Sorry there is no movement of code to other file. And I dont see any
reason why anybody reading will go haywire its a standard v4l2 thing.
The subject explains it all, If you still want me to elaborate I can
post a v2.
Thanks,
--Prabhakar Lad
you won't find the function definitions
if you grep on the function name.
But any functional changes here need to be Acked by Laurent first.
Yes, ill probably wait until Laurent is back from his holidays.
Thanks,
--Prabhakar Lad
--
To unsubscribe from this list: send the line unsubscribe linux
gt;> @@ -642,7 +642,6 @@ struct v4l2_subdev_fh {
>> #define to_v4l2_subdev_fh(fh) \
>> container_of(fh, struct v4l2_subdev_fh, vfh)
>>
>> -#if defined(CONFIG_VIDEO_V4L2_SUBDEV_API)
>
>
> Wouldn't you need to drop these from struct v4l2_subdev_fh as well? The
v4l2_subdev_fh, vfh)
-#if defined(CONFIG_VIDEO_V4L2_SUBDEV_API)
Wouldn't you need to drop these from struct v4l2_subdev_fh as well? The code
won't compile if the fields aren't there.
Ah missed it, thanks for the catch!
Thanks,
--Prabhakar Lad
#define __V4L2_SUBDEV_MK_GET_TRY(rtype
For all the above,
Acked-by: Lad, Prabhakar
Thanks,
--Prabhakar Lad
> drivers/media/i2c/vs6624.c| 18
> 46 files changed, 382 insertions(+), 382 deletions(-)
>
> diff --git a/drivers/media/i2c/adv7170.c b/drivers/media/i2c/adv7170.c
> index 04bb297..40a1a95 10
+-
[snip]
> include/media/davinci/vpbe.h | 2 +-
> include/media/davinci/vpbe_venc.h | 5 +-
For all the above.
Acked-by: Lad, Prabhakar
Thanks,
--Prabhakar Lad
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message
avinci_vpfe/dm365_ipipeif.c | 100
> ++---
> drivers/staging/media/davinci_vpfe/dm365_isif.c| 90 +--
> drivers/staging/media/davinci_vpfe/dm365_resizer.c | 98 ++--
> .../staging/media/davinci_vpfe/vpfe_mc_capture.c | 18 ++--
For all the above
Acked
Acked-by: Lad, Prabhakar prabhakar.cse...@gmail.com
Thanks,
--Prabhakar Lad
drivers/staging/media/omap4iss/iss_csi2.c | 62 ++---
drivers/staging/media/omap4iss/iss_ipipe.c | 16 ++--
drivers/staging/media/omap4iss/iss_ipipeif.c | 28 +++---
drivers/staging
]
include/media/davinci/vpbe.h | 2 +-
include/media/davinci/vpbe_venc.h | 5 +-
For all the above.
Acked-by: Lad, Prabhakar prabhakar.cse...@gmail.com
Thanks,
--Prabhakar Lad
--
To unsubscribe from this list: send the line unsubscribe linux-kernel
| 10 ++---
For all the above,
Acked-by: Lad, Prabhakar prabhakar.cse...@gmail.com
Thanks,
--Prabhakar Lad
drivers/media/i2c/vs6624.c| 18
46 files changed, 382 insertions(+), 382 deletions(-)
diff --git a/drivers/media/i2c/adv7170.c b/drivers/media/i2c/adv7170.c
Hi,
Thanks for the patch!
On Thu, Nov 6, 2014 at 1:04 PM, Sudip Mukherjee
wrote:
> we are getting struct clk using clk_get before calling
> clk_prepare_enable. but if clk_prepare_enable fails, then we are
> jumping to fail_mutex_unlock where we are just unlocking the mutex,
> but we are not
Hi,
Thanks for the patch!
On Thu, Nov 6, 2014 at 1:04 PM, Sudip Mukherjee
sudipm.mukher...@gmail.com wrote:
we are getting struct clk using clk_get before calling
clk_prepare_enable. but if clk_prepare_enable fails, then we are
jumping to fail_mutex_unlock where we are just unlocking the
thers for 3.19. Just post
> an
> updated version for this one and I'll pick it up later.
>
I fixed it and posted the patch. To avoid conflicts I have rebased the patch on
for-v3.19a branch of your tree.
Thanks,
--Prabhakar Lad
--
To unsubscribe from this list: send the line &quo
for this one and I'll pick it up later.
I fixed it and posted the patch. To avoid conflicts I have rebased the patch on
for-v3.19a branch of your tree.
Thanks,
--Prabhakar Lad
--
To unsubscribe from this list: send the line unsubscribe linux-kernel in
the body of a message to majord...@vger.kernel.org
apture.ko] undefined!
>
> That's because vpif_lock symbol is not exported.
>
Acked-by: Lad, Prabhakar
Regards,
--Prabhakar Lad
> Reported-by: Stephen Rothwell
> Signed-off-by: Mauro Carvalho Chehab
>
> diff --git a/drivers/media/platform/davinci/vpif.c
> b/drivers/media/pl
!
That's because vpif_lock symbol is not exported.
Acked-by: Lad, Prabhakar prabhakar.cse...@gmail.com
Regards,
--Prabhakar Lad
Reported-by: Stephen Rothwell s...@canb.auug.org.au
Signed-off-by: Mauro Carvalho Chehab m.che...@samsung.com
diff --git a/drivers/media/platform/davinci/vpif.c
b
Hi Mauro,
Please pull the following patches for davinci media which include
trivial cleanups.
Thanks,
--Prabhakar Lad
The following changes since commit 3c0d394ea7022bb9666d9df97a5776c4bcc3045c:
[media] dib8000: improve the message that reports per-layer locks
(2014-07-07 09:59:01 -0300
at least one PHY's child is defined in DT, otherwise rollback to
> mdiobus_register().
>
> Reviewed-by: Santosh Shilimkar
> Acked-by: Mugunthan V N
> Signed-off-by: Grygorii Strashko
Reviewed-by: Lad, Prabhakar
Thanks,
--Prabhakar Lad
> ---
> Hi Santosh,
>
> I hav
em
> See http://www.ti.com/lit/ug/spruhj5/spruhj5.pdf
>
> Hence, reuse Davinci MDIO driver for Keystone 2 and
> enable TI networking for Keystone 2 devices
>
> Reviewed-by: Santosh Shilimkar
> Acked-by: Mugunthan V N
> Signed-off-by: Grygorii Strashko
Reviewed-by: L
grygorii.stras...@ti.com
Reviewed-by: Lad, Prabhakar prabhakar.cse...@gmail.com
Thanks,
--Prabhakar Lad
---
.../devicetree/bindings/net/davinci-mdio.txt |8
drivers/net/ethernet/ti/Kconfig|4 ++--
2 files changed, 6 insertions(+), 6 deletions(-)
diff
Thanks,
--Prabhakar Lad
---
Hi Santosh,
I haven't changed style for long-comments, because Networking subsystem
requires first line of comment not to be empty:
WARNING:NETWORKING_BLOCK_COMMENT_STYLE: networking block comments don't use
an empty /* line, use /* Comment...
drivers/net
Hi Mauro,
Please pull the following patches for davinci media which include
trivial cleanups.
Thanks,
--Prabhakar Lad
The following changes since commit 3c0d394ea7022bb9666d9df97a5776c4bcc3045c:
[media] dib8000: improve the message that reports per-layer locks
(2014-07-07 09:59:01 -0300
fig that would build that code. But i believe
> that warning is still better than misbehaviour.
>
It wont cause any compile warning.
Applied for v3.17
Thanks,
--Prabhakar Lad
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majord...@v
REQ) += exynos-cpufreq.o
>> obj-$(CONFIG_ARM_EXYNOS4210_CPUFREQ) += exynos4210-cpufreq.o
>
> It took one year and 5 kernel releases to catch this again?
>
For a long time I was been working on DA850 itself, so couldn’t
notice it :(.
> Acked-by: Viresh Kumar
Thanks!
R
?
For a long time I was been working on DA850 itself, so couldn’t
notice it :(.
Acked-by: Viresh Kumar viresh.ku...@linaro.org
Thanks!
Regards,
--Prabhakar Lad
--
To unsubscribe from this list: send the line unsubscribe linux-kernel in
the body of a message to majord...@vger.kernel.org
More majordomo info
that code. But i believe
that warning is still better than misbehaviour.
It wont cause any compile warning.
Applied for v3.17
Thanks,
--Prabhakar Lad
--
To unsubscribe from this list: send the line unsubscribe linux-kernel in
the body of a message to majord...@vger.kernel.org
More majordomo info
t;> - KBUILD_MODNAME)) {
>> - dev_err(>dev, "resource unavailable\n");
>> + if (irq <= 0) {
>> ret = -ENODEV;
>> - goto exit_free_clk;
>> + goto exit;
>> }
&g
) {
- dev_err(pdev-dev, failed to map can port\n);
- ret = -ENOMEM;
- goto exit_release_mem;
I've moved the mem = platform_get_resource() for slightly better
readability here
Thanks makes sense.
Regards,
--Prabhakar Lad
+ addr = devm_ioremap_resource
led cppcheck.
>
> Signed-off-by: Rickard Strandqvist
The commit message and header needs to be improved, apart from that rest of the
patch looks good.
Acked-by: Lad, Prabhakar
Regards,
--Prabhakar Lad
> ---
> drivers/media/v4l2-core/v4l2-dv-timings.c |4 ++--
> 1 file changed, 2
program called cppcheck.
Signed-off-by: Rickard Strandqvist rickard_strandqv...@spectrumdigital.se
The commit message and header needs to be improved, apart from that rest of the
patch looks good.
Acked-by: Lad, Prabhakar prabhakar.cse...@gmail.com
Regards,
--Prabhakar Lad
---
drivers/media
Hi Paul,
Thanks for the patch.
On Thu, May 22, 2014 at 8:42 PM, Paul Bolle wrote:
> A check for CONFIG_DM644X_VIDEO_PORT_ENABLE was added in v2.6.32. The
> related Kconfig symbol was never added so this check has always
> evaluated to false. Remove that check.
>
Applied.
Thanks,
,
--Prabhakar Lad
Signed-off-by: Paul Bolle pebo...@tiscali.nl
---
Untested.
Related, trivial, cleanup: make ccdc_enable_vport() a oneliner.
drivers/media/platform/davinci/dm644x_ccdc.c | 5 -
1 file changed, 5 deletions(-)
diff --git a/drivers/media/platform/davinci/dm644x_ccdc.c
b
t; Why to remove those parameters? Please _ALWAYS_ describe your patches.
>
My bad! will take care next time.
Thanks,
--Prabhakar Lad
> My crystal ball is malfunctioning today, so I was unable to scry the
> reasons for this patch.
>
> Thanks,
> Mauro
>
>> ---
>> dr
k so will take me at-least
2-3 weeks for me to get back the boards and get in action.
Regards,
--Prabhakar Lad
> Regards,
>
> Hans
>
> On 05/16/2014 03:33 PM, Lad, Prabhakar wrote:
>> From: "Lad, Prabhakar"
>>
>> Hi,
>>
>> This p
vpif_config_addr(ch, ret);
>> + /* Get the next frame from the buffer queue */
>> + common->next_frm = common->cur_frm =
>> + list_entry(common->dma_queue.next,
>> + struct vpif_disp_buffer, list);
>
.
It happens twice in this driver and in both cases the assignment can be
removed.
OK, will drop this.
Regards,
--Prabhakar Lad
--
To unsubscribe from this list: send the line unsubscribe linux-kernel in
the body of a message to majord...@vger.kernel.org
More majordomo info at http://vger.kernel.org
weeks for me to get back the boards and get in action.
Regards,
--Prabhakar Lad
Regards,
Hans
On 05/16/2014 03:33 PM, Lad, Prabhakar wrote:
From: Lad, Prabhakar prabhakar.cse...@gmail.com
Hi,
This patch series upgrades the vpif capture display
driver with the all the helpers
-ENOPATCHDESCRIPTION
Why to remove those parameters? Please _ALWAYS_ describe your patches.
My bad! will take care next time.
Thanks,
--Prabhakar Lad
My crystal ball is malfunctioning today, so I was unable to scry the
reasons for this patch.
Thanks,
Mauro
---
drivers/media/platform
On Wed, May 21, 2014 at 1:04 AM, Andrew Morton
wrote:
> On Tue, 20 May 2014 16:49:00 +0100 Mel Gorman wrote:
>
>> Prabhakar Lad reported the following problem
>>
>> I see following issue on DA850 evm,
>> git bisect points me to
>> commit id: 975c
On Wed, May 21, 2014 at 1:04 AM, Andrew Morton
a...@linux-foundation.org wrote:
On Tue, 20 May 2014 16:49:00 +0100 Mel Gorman mgor...@suse.de wrote:
Prabhakar Lad reported the following problem
I see following issue on DA850 evm,
git bisect points me to
commit id
Supported)
>> test VIDIOC_S_FMT: OK (Not Supported)
>> test VIDIOC_G_SLICED_VBI_CAP: OK (Not Supported)
>>
>> Codec ioctls:
>> test VIDIOC_(TRY_)ENCODER_CMD: OK (Not Supported)
>> test VIDIOC_G_EN
' option is available
to
test streaming from a specific input.
BTW the output is with -s option set.
Thanks,
--Prabhakar Lad
--
To unsubscribe from this list: send the line unsubscribe linux-kernel in
the body of a message to majord...@vger.kernel.org
More majordomo info at http
You might want split this patch so that others can pick it
> up
>
Thanks for picking it up.
Thanks,
--Prabhakar Lad
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majord...@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/
; Cc: Florian Fainelli
> Cc: Sergei Shtylyov
> Cc: Lad, Prabhakar
> Cc: David S. Miller
> Cc: net...@vger.kernel.org
Acked-by: Lad, Prabhakar
Thanks,
--Prabhakar Lad
> ---
> drivers/net/phy/mdio_bus.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git
...@gmail.com
Cc: Sergei Shtylyov sergei.shtyl...@cogentembedded.com
Cc: Lad, Prabhakar prabhakar.cse...@gmail.com
Cc: David S. Miller da...@davemloft.net
Cc: net...@vger.kernel.org
Acked-by: Lad, Prabhakar prabhakar.cse...@gmail.com
Thanks,
--Prabhakar Lad
---
drivers/net/phy/mdio_bus.c | 2
that others can pick it
up
Thanks for picking it up.
Thanks,
--Prabhakar Lad
--
To unsubscribe from this list: send the line unsubscribe linux-kernel in
the body of a message to majord...@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http
1 - 100 of 1285 matches
Mail list logo
