[PATCH] fbdev: goldfishfb: use devres api

2015-02-20 Thread Prabhakar Lad
From: Lad, Prabhakar prabhakar.cse...@gmail.com this patch does the following: a uses devm_kzalloc() instead of kzalloc and cleanup the error path b uses devm_ioremap() instead of ioremap and cleanup the error path c uses devm_request_irq() instead of request_irq and cleanup the error path

Re: [PATCH 2/2] fbdev: ssd1307fb: check return value while setting offset

2015-01-13 Thread Prabhakar Lad
then and there ? Thanks, --Prabhakar Lad -- To unsubscribe from this list: send the line unsubscribe linux-kernel in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/

Re: [PATCH 2/2] fbdev: ssd1307fb: check return value while setting offset

2015-01-13 Thread Prabhakar Lad
On Tue, Jan 13, 2015 at 1:39 PM, Maxime Ripard maxime.rip...@free-electrons.com wrote: On Tue, Jan 13, 2015 at 11:53:01AM +, Prabhakar Lad wrote: On Tue, Jan 13, 2015 at 11:43 AM, Tomi Valkeinen tomi.valkei...@ti.com wrote: On 08/01/15 10:17, Lad, Prabhakar wrote: this patch checks

Re: [PATCH] media: ti-vpe: Use mem-to-mem ioctl helpers

2014-12-19 Thread Prabhakar Lad
to utilize my holidays in proper way :D Thanks, --Prabhakar Lad -- To unsubscribe from this list: send the line unsubscribe linux-kernel in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org

Re: [PATCH] misc: ioc4: fix variable may be used uninitialized warning

2014-12-08 Thread Prabhakar Lad
, but for the sanity of gcc output explicitly initialize it. Same goes for the 'end' variable. Prabhakar Lad also sent a patch for this already, which was lacking a good patch description. Your patch does this slightly better but still fails to explain how you concluded it was safe and you don't really explain

Re: [PATCH v3] media: platform: add VPFE capture driver support for AM437X

2014-12-05 Thread Prabhakar Lad
accepted for 3.19. OK will post a v4 tonight fixing all the below issues. FYI: Looking at the response of Mauro on 'soc-camera: 1st set for 3.19' he wont accept it! Thanks, --Prabhakar Lad On 12/04/2014 12:12 AM, Lad, Prabhakar wrote: From: Benoit Parrot bpar...@ti.com This patch adds Video

Re: [PATCH] misc: suppress build warning

2014-12-04 Thread Prabhakar Lad
are sure that there isn't, and why you picked '0' as the initialization value. Its a false positive, to suppress the warning '0' was picked. Thanks, --Prabhakar Lad -- To unsubscribe from this list: send the line unsubscribe linux-kernel in the body of a message to majord...@vger.kernel.org

Re: [PATCH 1/3] video: fbdev: vt8623fb: suppress build warning

2014-12-03 Thread Prabhakar Lad
of a pointer? Yes looks ugly, I am not sure what you meant from 'where does this warning come from' its in the commit message. Thanks, --Prabhakar Lad -- To unsubscribe from this list: send the line unsubscribe linux-kernel in the body of a message to majord...@vger.kernel.org More majordomo info

Re: [PATCH v1] lib/genalloc.c: Export devm_gen_pool_create for modules

2014-12-02 Thread Prabhakar Lad
/genalloc.c | 1 + 1 file changed, 1 insertion(+) don’t you need to add an entry in include/linux/genalloc.h ? Thanks, --Prabhakar Lad diff --git a/lib/genalloc.c b/lib/genalloc.c index cce4dd68c40d..2e65d206b01c 100644 --- a/lib/genalloc.c +++ b/lib/genalloc.c @@ -598,6 +598,7 @@ struct

Re: [PATCH v1] lib/genalloc.c: Export devm_gen_pool_create for modules

2014-12-02 Thread Prabhakar Lad
Hi Michal, On Tue, Dec 2, 2014 at 9:36 AM, Michal Simek michal.si...@xilinx.com wrote: On 12/02/2014 10:31 AM, Prabhakar Lad wrote: Hi Michal, Thanks for the patch. On Mon, Dec 1, 2014 at 1:00 PM, Michal Simek michal.si...@xilinx.com wrote: Modules can use this function for creating pool

Re: [PATCH v2] media: platform: add VPFE capture driver support for AM437X

2014-12-02 Thread Prabhakar Lad
Sequence: 119 Field: None Timestamp: 76.711771s test MMAP: OK test USERPTR: OK (Not Supported) test DMABUF: Cannot test, specify --expbuf-device Total: 42, Succeeded: 42, Failed: 0, Warnings: 0 Thanks, --Prabhakar Lad -- To unsubscribe from this list: send the line

Re: [PATCH v8 08/50] virtio: memory access APIs

2014-12-02 Thread Prabhakar Lad
? Apart from that patch looks good. Acked-by: Lad, Prabhakar prabhakar.cse...@gmail.com Thanks, --Prabhakar Lad -- To unsubscribe from this list: send the line unsubscribe linux-kernel in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo

Re: [PATCH] media: platform: add VPFE capture driver support for AM437X

2014-12-01 Thread Prabhakar Lad
Hi Hans, Thanks for the review. On Mon, Dec 1, 2014 at 10:11 AM, Hans Verkuil hverk...@xs4all.nl wrote: Hi all, Thanks for the patch, review comments are below. For the next version I would appreciate if someone can test this driver with the latest v4l2-compliance from the v4l-utils git

Re: [PATCH] media: platform: add VPFE capture driver support for AM437X

2014-12-01 Thread Prabhakar Lad
series dm6467/dm6467t/omapl138/am1808) vpfe - under davinci is common for (Davinci series dm36x/dm6446/dm355) I am falling short of names for renaming this common drivers :) Thanks, --Prabhakar Lad -- To unsubscribe from this list: send the line unsubscribe linux-kernel in the body of a message

Re: [PATCH] media: platform: add VPFE capture driver support for AM437X

2014-12-01 Thread Prabhakar Lad
Hi Hans, On Tue, Dec 2, 2014 at 7:26 AM, Hans Verkuil hverk...@xs4all.nl wrote: On 12/01/2014 11:17 PM, Prabhakar Lad wrote: Hi Hans, Thanks for the review. On Mon, Dec 1, 2014 at 10:11 AM, Hans Verkuil hverk...@xs4all.nl wrote: Hi all, Thanks for the patch, review comments are below

Re: [PATCH] media: platform: add VPFE capture driver support for AM437X

2014-12-01 Thread Prabhakar Lad
Hi Hans, On Tue, Dec 2, 2014 at 7:32 AM, Hans Verkuil hverk...@xs4all.nl wrote: On 12/01/2014 11:27 PM, Prabhakar Lad wrote: Hi Hans, On Mon, Dec 1, 2014 at 11:00 AM, Hans Verkuil hverk...@xs4all.nl wrote: On 12/01/2014 11:11 AM, Hans Verkuil wrote: Hi all, Thanks for the patch, review

Re: [PATCH] media: v4l2-subdev.h: drop the guard CONFIG_VIDEO_V4L2_SUBDEV_API for v4l2_subdev_get_try_*()

2014-12-01 Thread Prabhakar Lad
Hi Hans, On Mon, Dec 1, 2014 at 11:26 PM, Laurent Pinchart laurent.pinch...@ideasonboard.com wrote: Hi Prabhakar, On Sunday 30 November 2014 21:30:35 Prabhakar Lad wrote: On Sun, Nov 30, 2014 at 9:16 PM, Laurent Pinchart wrote: On Sunday 30 November 2014 21:05:50 Prabhakar Lad wrote

Re: [PATCH] media: v4l2-subdev.h: drop the guard CONFIG_VIDEO_V4L2_SUBDEV_API for v4l2_subdev_get_try_*()

2014-11-30 Thread Prabhakar Lad
subdev API would use the configuration store from the file handle. are planning to work/post any time soon ? Or are you OK with suggestion from Hans ? Thanks, --Prabhakar Lad -- To unsubscribe from this list: send the line unsubscribe linux-kernel in the body of a message to majord

Re: [PATCH] media: v4l2-subdev.h: drop the guard CONFIG_VIDEO_V4L2_SUBDEV_API for v4l2_subdev_get_try_*()

2014-11-30 Thread Prabhakar Lad
Hi Laurent, On Sun, Nov 30, 2014 at 9:16 PM, Laurent Pinchart laurent.pinch...@ideasonboard.com wrote: On Sunday 30 November 2014 21:05:50 Prabhakar Lad wrote: On Sat, Nov 29, 2014 at 7:12 PM, Laurent Pinchart wrote: Hi Prabhakar, [Snip] Sure. That's a better choice than removing

Re: [PATCH v7 44/46] virtio_scsi: export to userspace

2014-11-30 Thread Prabhakar Lad
, Prabhakar prabhakar.cse...@gmail.com Regards, --Prabhakar Lad -- To unsubscribe from this list: send the line unsubscribe linux-kernel in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org

Re: [PATCH v3] media: usb: uvc: use vb2_ops_wait_prepare/finish helper

2014-11-29 Thread Prabhakar Lad
Hi Laurent, On Sat, Nov 29, 2014 at 6:11 PM, Laurent Pinchart laurent.pinch...@ideasonboard.com wrote: Hi Prabhakar, On Friday 28 November 2014 17:06:52 Prabhakar Lad wrote: On Thu, Nov 27, 2014 at 9:32 PM, Laurent Pinchart wrote: Hi Prabhakar, [Snip] + queue-queue.lock = queue

Re: [PATCH] media: v4l2-subdev.h: drop the guard CONFIG_VIDEO_V4L2_SUBDEV_API for v4l2_subdev_get_try_*()

2014-11-29 Thread Prabhakar Lad
back then AFAIR. But any functional changes here need to be Acked by Laurent first. How do you want me to proceed on this ? Thanks, --Prabhakar Lad -- To unsubscribe from this list: send the line unsubscribe linux-kernel in the body of a message to majord...@vger.kernel.org More majordomo info

Re: [PATCH v3] media: usb: uvc: use vb2_ops_wait_prepare/finish helper

2014-11-28 Thread Prabhakar Lad
not aware of. Thanks, --Prabhakar Lad ret = vb2_queue_init(queue-queue); if (ret) return ret; -- Regards, Laurent Pinchart -- To unsubscribe from this list: send the line unsubscribe linux-kernel in the body of a message to majord...@vger.kernel.org More majordomo info

Re: [PATCH v2 11/11] media: usb: uvc: use vb2_ops_wait_prepare/finish helper

2014-11-26 Thread Prabhakar Lad
by the uvcvideo driver, so you can't use vb2_ops_wait_prepare|finish(). Oops not sure what happened here I just took the patch from [1] and added commit message. anyway will post a single patch v3. [1] https://patchwork.kernel.org/patch/5327451/ Thanks, --Prabhakar Lad Signed-off-by: Lad, Prabhakar

Re: [PATCH] media: exynos-gsc: fix build warning

2014-11-25 Thread Prabhakar Lad
reach here! may be you can remove the complete else part outside ? with that change, Reported-by: Lad, Prabhakar prabhakar.cse...@gmail.com Acked-by: Lad, Prabhakar prabhakar.cse...@gmail.com Thanks, --Prabhakar Lad } void gsc_set_prefbuf(struct gsc_dev *gsc, struct gsc_frame *frm

Re: [PATCH] media: exynos-gsc: fix build warning

2014-11-25 Thread Prabhakar Lad
Hi, On Tue, Nov 25, 2014 at 3:18 PM, Prabhakar Lad prabhakar.cse...@gmail.com wrote: Hi Mauro, On Tue, Nov 25, 2014 at 3:04 PM, Mauro Carvalho Chehab mche...@osg.samsung.com wrote: Em Tue, 18 Nov 2014 10:57:48 + [Snip] -static u32 get_plane_info(struct gsc_frame *frm, u32 addr, u32

Re: [PATCH 06/12] media: marvell-ccic: use vb2_ops_wait_prepare/finish helper

2014-11-18 Thread Prabhakar Lad
to see a real changelog on the patch, though. Sorry there is no movement of code to other file. And I dont see any reason why anybody reading will go haywire its a standard v4l2 thing. The subject explains it all, If you still want me to elaborate I can post a v2. Thanks, --Prabhakar Lad

Re: [PATCH] media: v4l2-subdev.h: drop the guard CONFIG_VIDEO_V4L2_SUBDEV_API for v4l2_subdev_get_try_*()

2014-11-18 Thread Prabhakar Lad
you won't find the function definitions if you grep on the function name. But any functional changes here need to be Acked by Laurent first. Yes, ill probably wait until Laurent is back from his holidays. Thanks, --Prabhakar Lad -- To unsubscribe from this list: send the line unsubscribe linux

Re: [PATCH] media: v4l2-subdev.h: drop the guard CONFIG_VIDEO_V4L2_SUBDEV_API for v4l2_subdev_get_try_*()

2014-11-17 Thread Prabhakar Lad
v4l2_subdev_fh, vfh) -#if defined(CONFIG_VIDEO_V4L2_SUBDEV_API) Wouldn't you need to drop these from struct v4l2_subdev_fh as well? The code won't compile if the fields aren't there. Ah missed it, thanks for the catch! Thanks, --Prabhakar Lad #define __V4L2_SUBDEV_MK_GET_TRY(rtype

Re: [PATCH v3 08/10] staging: media: Make use of MEDIA_BUS_FMT_ definitions

2014-11-08 Thread Prabhakar Lad
Acked-by: Lad, Prabhakar prabhakar.cse...@gmail.com Thanks, --Prabhakar Lad drivers/staging/media/omap4iss/iss_csi2.c | 62 ++--- drivers/staging/media/omap4iss/iss_ipipe.c | 16 ++-- drivers/staging/media/omap4iss/iss_ipipeif.c | 28 +++--- drivers/staging

Re: [PATCH v3 06/10] [media] platform: Make use of media_bus_format enum

2014-11-08 Thread Prabhakar Lad
] include/media/davinci/vpbe.h | 2 +- include/media/davinci/vpbe_venc.h | 5 +- For all the above. Acked-by: Lad, Prabhakar prabhakar.cse...@gmail.com Thanks, --Prabhakar Lad -- To unsubscribe from this list: send the line unsubscribe linux-kernel

Re: [PATCH v3 04/10] [media] i2c: Make use of media_bus_format enum

2014-11-08 Thread Prabhakar Lad
| 10 ++--- For all the above, Acked-by: Lad, Prabhakar prabhakar.cse...@gmail.com Thanks, --Prabhakar Lad drivers/media/i2c/vs6624.c| 18 46 files changed, 382 insertions(+), 382 deletions(-) diff --git a/drivers/media/i2c/adv7170.c b/drivers/media/i2c/adv7170.c

Re: [PATCH] media: davinci: vpbe: missing clk_put

2014-11-07 Thread Prabhakar Lad
Hi, Thanks for the patch! On Thu, Nov 6, 2014 at 1:04 PM, Sudip Mukherjee sudipm.mukher...@gmail.com wrote: we are getting struct clk using clk_get before calling clk_prepare_enable. but if clk_prepare_enable fails, then we are jumping to fail_mutex_unlock where we are just unlocking the

Re: [PATCH 10/15] media: davinci: vpbe: add support for VIDIOC_CREATE_BUFS

2014-10-22 Thread Prabhakar Lad
for this one and I'll pick it up later. I fixed it and posted the patch. To avoid conflicts I have rebased the patch on for-v3.19a branch of your tree. Thanks, --Prabhakar Lad -- To unsubscribe from this list: send the line unsubscribe linux-kernel in the body of a message to majord...@vger.kernel.org

Re: [PATCH 3/3] [media] vpif: Fix compilation with allmodconfig

2014-09-09 Thread Prabhakar Lad
! That's because vpif_lock symbol is not exported. Acked-by: Lad, Prabhakar prabhakar.cse...@gmail.com Regards, --Prabhakar Lad Reported-by: Stephen Rothwell s...@canb.auug.org.au Signed-off-by: Mauro Carvalho Chehab m.che...@samsung.com diff --git a/drivers/media/platform/davinci/vpif.c b

Re: [PATCH v2 1/2] net: davinci_mdio: reuse for keystone2 arch

2014-07-16 Thread Prabhakar Lad
grygorii.stras...@ti.com Reviewed-by: Lad, Prabhakar prabhakar.cse...@gmail.com Thanks, --Prabhakar Lad --- .../devicetree/bindings/net/davinci-mdio.txt |8 drivers/net/ethernet/ti/Kconfig|4 ++-- 2 files changed, 6 insertions(+), 6 deletions(-) diff

Re: [PATCH v2 2/2] net: davinci_mdio: allow to create phys from dt

2014-07-16 Thread Prabhakar Lad
Thanks, --Prabhakar Lad --- Hi Santosh, I haven't changed style for long-comments, because Networking subsystem requires first line of comment not to be empty: WARNING:NETWORKING_BLOCK_COMMENT_STYLE: networking block comments don't use an empty /* line, use /* Comment... drivers/net

[GIT PULL FOR v3.17] Davinci Media

2014-07-16 Thread Prabhakar Lad
Hi Mauro, Please pull the following patches for davinci media which include trivial cleanups. Thanks, --Prabhakar Lad The following changes since commit 3c0d394ea7022bb9666d9df97a5776c4bcc3045c: [media] dib8000: improve the message that reports per-layer locks (2014-07-07 09:59:01 -0300

Re: [PATCH] cpufreq: Makefile: fix compilation for davinci platform

2014-07-08 Thread Prabhakar Lad
? For a long time I was been working on DA850 itself, so couldn’t notice it :(. Acked-by: Viresh Kumar viresh.ku...@linaro.org Thanks! Regards, --Prabhakar Lad -- To unsubscribe from this list: send the line unsubscribe linux-kernel in the body of a message to majord...@vger.kernel.org More majordomo info

Re: [PATCH] [media] davinci-vpfe: Fix retcode check

2014-07-08 Thread Prabhakar Lad
that code. But i believe that warning is still better than misbehaviour. It wont cause any compile warning. Applied for v3.17 Thanks, --Prabhakar Lad -- To unsubscribe from this list: send the line unsubscribe linux-kernel in the body of a message to majord...@vger.kernel.org More majordomo info

Re: [PATCH] can: c_can: convert to use devm * api

2014-06-22 Thread Prabhakar Lad
) { - dev_err(pdev-dev, failed to map can port\n); - ret = -ENOMEM; - goto exit_release_mem; I've moved the mem = platform_get_resource() for slightly better readability here Thanks makes sense. Regards, --Prabhakar Lad + addr = devm_ioremap_resource

Re: [PATCH] media: v4l2-core: v4l2-dv-timings.c: Cleaning up code that putting values to the same variable twice

2014-06-10 Thread Prabhakar Lad
program called cppcheck. Signed-off-by: Rickard Strandqvist rickard_strandqv...@spectrumdigital.se The commit message and header needs to be improved, apart from that rest of the patch looks good. Acked-by: Lad, Prabhakar prabhakar.cse...@gmail.com Regards, --Prabhakar Lad --- drivers/media

Re: [PATCH] [media] dm644x_ccdc: remove check for CONFIG_DM644X_VIDEO_PORT_ENABLE

2014-06-09 Thread Prabhakar Lad
, --Prabhakar Lad Signed-off-by: Paul Bolle pebo...@tiscali.nl --- Untested. Related, trivial, cleanup: make ccdc_enable_vport() a oneliner. drivers/media/platform/davinci/dm644x_ccdc.c | 5 - 1 file changed, 5 deletions(-) diff --git a/drivers/media/platform/davinci/dm644x_ccdc.c b

Re: [PATCH v5 04/49] media: davinci: vpif_display: release buffers in case start_streaming() call back fails

2014-05-23 Thread Prabhakar Lad
. It happens twice in this driver and in both cases the assignment can be removed. OK, will drop this. Regards, --Prabhakar Lad -- To unsubscribe from this list: send the line unsubscribe linux-kernel in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org

Re: [PATCH v5 00/49] DaVinci: vpif: upgrade with v4l helpers and v4l compliance fixes

2014-05-23 Thread Prabhakar Lad
weeks for me to get back the boards and get in action. Regards, --Prabhakar Lad Regards, Hans On 05/16/2014 03:33 PM, Lad, Prabhakar wrote: From: Lad, Prabhakar prabhakar.cse...@gmail.com Hi, This patch series upgrades the vpif capture display driver with the all the helpers

Re: [PATCH v5 41/49] media: davinci: vpif_capture: drop unneeded module params

2014-05-23 Thread Prabhakar Lad
-ENOPATCHDESCRIPTION Why to remove those parameters? Please _ALWAYS_ describe your patches. My bad! will take care next time. Thanks, --Prabhakar Lad My crystal ball is malfunctioning today, so I was unable to scry the reasons for this patch. Thanks, Mauro --- drivers/media/platform

Re: [PATCH] mm: non-atomically mark page accessed during page cache allocation where possible -fix

2014-05-21 Thread Prabhakar Lad
On Wed, May 21, 2014 at 1:04 AM, Andrew Morton a...@linux-foundation.org wrote: On Tue, 20 May 2014 16:49:00 +0100 Mel Gorman mgor...@suse.de wrote: Prabhakar Lad reported the following problem I see following issue on DA850 evm, git bisect points me to commit id

Re: [PATCH v4 1/2] media: davinci: vpif capture: upgrade the driver with v4l offerings

2014-05-14 Thread Prabhakar Lad
' option is available to test streaming from a specific input. BTW the output is with -s option set. Thanks, --Prabhakar Lad -- To unsubscribe from this list: send the line unsubscribe linux-kernel in the body of a message to majord...@vger.kernel.org More majordomo info at http

Re: [PATCH] mdio_bus: fix devm_mdiobus_alloc_size export

2014-05-09 Thread Prabhakar Lad
...@gmail.com Cc: Sergei Shtylyov sergei.shtyl...@cogentembedded.com Cc: Lad, Prabhakar prabhakar.cse...@gmail.com Cc: David S. Miller da...@davemloft.net Cc: net...@vger.kernel.org Acked-by: Lad, Prabhakar prabhakar.cse...@gmail.com Thanks, --Prabhakar Lad --- drivers/net/phy/mdio_bus.c | 2

Re: [PATCH v2] ARM: configs: drop CONFIG_COMMON_CLK_DEBUG

2014-05-09 Thread Prabhakar Lad
that others can pick it up Thanks for picking it up. Thanks, --Prabhakar Lad -- To unsubscribe from this list: send the line unsubscribe linux-kernel in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http

Re: [PATCH] ARM: configs: drop CONFIG_COMMON_CLK_DEBUG

2014-04-29 Thread Prabhakar Lad
option has been removed from two of them on my branch by savedefconfig, and we will address the remaining one in another patch. OK will post the updated patch dropping these 3 files. Regards, --Prabhakar Lad -- To unsubscribe from this list: send the line unsubscribe linux-kernel in the body

Re: [PATCH v5 2/8] cpufreq: Use cpufreq_for_each_* macros for frequency table iteration

2014-04-26 Thread Prabhakar Lad
have no functional changes. Signed-off-by: Stratos Karafotis strat...@semaphore.gr For patches 1 2: Acked-by: Lad, Prabhakar prabhakar.cse...@gmail.com and for patch 3: Acked-and-tested-by: Lad, Prabhakar prabhakar.cse...@gmail.com Thanks, --Prabhakar lad --- drivers/cpufreq/acpi-cpufreq.c

Re: [PATCH v4 2/8] cpufreq: Use cpufreq_for_each_* macros for frequency table iteration

2014-04-25 Thread Prabhakar Lad
=] pr_debug(table entry %lu: %u kHz\n, pos - table, freq); Thanks, --Prabhakar Lad Signed-off-by: Stratos Karafotis strat...@semaphore.gr --- drivers/cpufreq/acpi-cpufreq.c | 9 +++--- drivers/cpufreq/arm_big_little.c | 16 +-- drivers/cpufreq/cpufreq_stats.c | 24

Re: [PATCH v2 0/4] introduce devm_mdiobus_alloc/free and clean up davinci mdio

2014-04-19 Thread Prabhakar Lad
/devm_mdiobus_free net: davinci_mdio: use devm_* api net: davinci_mdio: drop pinctrl_pm_select_default_state from probe net: davinci_mdio: simplify IO memory mapping Tested on DA850EVM. Acked-and-tested-by: Lad, Prabhakar prabhakar.cse...@gmail.com Regards, --Prabhakar Lad Documentation

Re: [PATCH] v4l2-pci-skeleton: fix typo while retrieving the skel_buffer

2014-04-02 Thread Prabhakar Lad
is called 'vb', so this should be correct. Oops may be I overlooked, sorry for the noise. Thanks, --Prabhakar Lad -- To unsubscribe from this list: send the line unsubscribe linux-kernel in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo

Re: [PATCH 1/2] media: davinci: vpif capture: upgrade the driver with v4l offerings

2014-03-31 Thread Prabhakar Lad
vpif_cap_buffer *buf = to_vpif_buffer(vb); INIT_LIST_HEAD(buf-list); return 0; } Is this really necessary? I think vpif_buffer_init can just be removed. Ditto for vpif_display.c. Yes can be dropped, will remove in next version. Thanks, --Prabhakar Lad -- To unsubscribe from

[PATCH] devicetree: bindings: gpio-davinic: fix documentation

2014-03-05 Thread Prabhakar Lad
From: Lad, Prabhakar prabhakar.cse...@gmail.com This patch adds missing #gpio-cells and also adds a usage example for leds. Reported-by: Alexander Holler hol...@ahsoftware.de Signed-off-by: Lad, Prabhakar prabhakar.cse...@gmail.com --- .../devicetree/bindings/gpio/gpio-davinci.txt | 21

Re: [PATCH][RESEND] [media] davinci: vpfe: remove deprecated IRQF_DISABLED

2014-02-24 Thread Prabhakar Lad
Hi Michael, On Mon, Feb 24, 2014 at 11:01 AM, Prabhakar Lad prabhakar.cse...@gmail.com wrote: Hi Michael, On Thu, Feb 20, 2014 at 6:47 PM, Michael Opdenacker michael.opdenac...@free-electrons.com wrote: Hi Laurent, On 02/20/2014 12:36 PM, Laurent Pinchart wrote: Hi Michael, What's

Re: [PATCH][RESEND] [media] davinci: vpfe: remove deprecated IRQF_DISABLED

2014-02-23 Thread Prabhakar Lad
(or removing the definition of IRQF_DISABLED) may be the final solution. I hope to be able to answer your question by the end of the week. gentle ping. should I pick it up ? Regards, --Prabhakar Lad -- To unsubscribe from this list: send the line unsubscribe linux-kernel in the body of a message

[PATCH 3/3] media: omap3isp: rename the variable names in description

2014-02-21 Thread Prabhakar Lad
From: Lad, Prabhakar prabhakar.cse...@gmail.com this patch renames the variable in the description to match it appropriately to function definition. Signed-off-by: Lad, Prabhakar prabhakar.cse...@gmail.com --- drivers/media/platform/omap3isp/isp.h| 12 ++--

[PATCH 2/3] media: omap3isp: ispccdc: remove unwanted comments

2014-02-21 Thread Prabhakar Lad
From: Lad, Prabhakar prabhakar.cse...@gmail.com this patch removes the description of members which does not exists for ispccdc_lsc structure. Signed-off-by: Lad, Prabhakar prabhakar.cse...@gmail.com --- drivers/media/platform/omap3isp/ispccdc.h |6 -- 1 file changed, 6 deletions(-)

[PATCH 0/3] media: omap3isp: trivial cleanup

2014-02-21 Thread Prabhakar Lad
From: Lad, Prabhakar prabhakar.cse...@gmail.com This patch series include fixing some typos and removal of unwanted comments. Lad, Prabhakar (3): media: omap3isp: fix typos media: omap3isp: ispccdc: remove unwanted comments media: omap3isp: rename the variable names in description

[PATCH 1/3] media: omap3isp: fix typos

2014-02-21 Thread Prabhakar Lad
From: Lad, Prabhakar prabhakar.cse...@gmail.com Signed-off-by: Lad, Prabhakar prabhakar.cse...@gmail.com --- drivers/media/platform/omap3isp/isp.c|2 +- drivers/media/platform/omap3isp/ispccdc.c|2 +- drivers/media/platform/omap3isp/ispccp2.c|4 ++--

[PATCH] video: da8xx-fb: fix typos

2014-02-20 Thread Prabhakar Lad
From: Lad, Prabhakar prabhakar.cse...@gmail.com This patch fixes couple of typos in the comments for da8xx-fb.c file. Signed-off-by: Lad, Prabhakar prabhakar.cse...@gmail.com --- drivers/video/da8xx-fb.c |6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git

Re: [PATCH] media: i2c: Kconfig: create dependency to MEDIA_CONTROLLER for adv7*

2014-02-06 Thread Prabhakar Lad
on VIDEO_V4L2_SUBDEV_API config and if you see VIDEO_V4L2_SUBDEV_API depends on MEDIA_CONTROLLER config so there is no point in adding this dependency. Thanks, --Prabhakar Lad Signed-off-by: Marcus Folkesson marcus.folkes...@gmail.com --- drivers/media/i2c/Kconfig |6 +++--- 1 file changed, 3 insertions(+), 3

Re: [PATCH 1/2] [media] v4l2: Add settings for Horizontal and Vertical MV Search Range

2014-02-06 Thread Prabhakar Lad
...@samsung.com Acked-by: Lad, Prabhakar prabhakar.cse...@gmail.com Regards, --Prabhakar Lad --- Documentation/DocBook/media/v4l/controls.xml | 20 drivers/media/v4l2-core/v4l2-ctrls.c |6 ++ include/uapi/linux/v4l2-controls.h |2 ++ 3 files changed

[PATCH] ARM: davinci: fix typo

2014-02-05 Thread Prabhakar Lad
From: Lad, Prabhakar prabhakar.cse...@gmail.com this patch fixes a typo in mach/hardware.h, by replacing ths to this. Signed-off-by: Lad, Prabhakar prabhakar.cse...@gmail.com --- arch/arm/mach-davinci/include/mach/hardware.h |2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git

[no subject]

2014-01-23 Thread Prabhakar Lad
in .init_machine but results the same. Any pointer would be helpfull. Thanks, --Prabhakar Lad -- To unsubscribe from this list: send the line unsubscribe linux-kernel in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ

[PATCH] ARM: davinci: defconfig: drop CONFIG_REGULATOR_DUMMY

2014-01-23 Thread Prabhakar Lad
From: Lad, Prabhakar prabhakar.cse...@gmail.com This patch drops CONFIG_REGULATOR_DUMMY as this obsolete. Signed-off-by: Lad, Prabhakar prabhakar.cse...@gmail.com --- arch/arm/configs/da8xx_omapl_defconfig |1 - 1 file changed, 1 deletion(-) diff --git

[PATCH] lib/genalloc.c: add check gen_pool_dma_alloc() if dma pointer is not NULL

2014-01-23 Thread Prabhakar Lad
From: Lad, Prabhakar prabhakar.cse...@gmail.com In the gen_pool_dma_alloc() the dma pointer can be NULL and while assigning gen_pool_virt_to_phys(pool, vaddr) to dma caused the following crash on da850 evm, Unable to handle kernel NULL pointer dereference at virtual address pgd =

Re: [PATCH] lib/genalloc.c: add check gen_pool_dma_alloc() if dma pointer is not NULL

2014-01-23 Thread Prabhakar Lad
Hi Sachin, On Thu, Jan 23, 2014 at 3:38 PM, Sachin Kamat sachin.ka...@linaro.org wrote: Hi Prabhakar, On 23 January 2014 15:26, Prabhakar Lad prabhakar.cse...@gmail.com wrote: From: Lad, Prabhakar prabhakar.cse...@gmail.com In the gen_pool_dma_alloc() the dma pointer can be NULL and while

Re: Kconfig errors

2014-01-22 Thread Prabhakar Lad
Hi Russell, On Fri, Jan 17, 2014 at 1:07 PM, Prabhakar Lad prabhakar.cse...@gmail.com wrote: Hi, On Linux-next branch I see following errors for davinci_all_defconfig da8xx_omapl_defconfig configs, arch/arm/Kconfig:1966:error: recursive dependency detected! arch/arm/Kconfig:1966

Re: Kconfig errors

2014-01-22 Thread Prabhakar Lad
On Wed, Jan 22, 2014 at 5:56 PM, Russell King - ARM Linux li...@arm.linux.org.uk wrote: On Wed, Jan 22, 2014 at 05:54:29PM +0530, Prabhakar Lad wrote: Hi Russell, On Fri, Jan 17, 2014 at 1:07 PM, Prabhakar Lad prabhakar.cse...@gmail.com wrote: Hi, On Linux-next branch I see following

Re: [PATCH] [media] s5p-mfc: Add Horizontal and Vertical search range for Video Macro Blocks

2014-01-22 Thread Prabhakar Lad
to split up into two, first adding a v4l control and second one using it up in the driver. Regards, --Prabhakar Lad -- To unsubscribe from this list: send the line unsubscribe linux-kernel in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo

[PATCH v2] media: i2c: mt9p031: Check return value of clk_prepare_enable/clk_set_rate

2014-01-20 Thread Prabhakar Lad
From: Lad, Prabhakar prabhakar.cse...@gmail.com clk_set_rate(), clk_prepare_enable() functions can fail, so check the return values to avoid surprises. Signed-off-by: Lad, Prabhakar prabhakar.cse...@gmail.com --- Changes for v2: 1: Called regulator_bulk_disable() in the error path

[PATCH] media: i2c: mt9p031: Check return value of clk_prepare_enable/clk_set_rate

2014-01-17 Thread Prabhakar Lad
From: Lad, Prabhakar prabhakar.cse...@gmail.com clk_set_rate(), clk_prepare_enable() functions can fail, so check the return values to avoid surprises. Signed-off-by: Lad, Prabhakar prabhakar.cse...@gmail.com --- drivers/media/i2c/mt9p031.c | 12 +--- 1 file changed, 9 insertions(+),

[PATCH] media: i2c: mt9v032: Check return value of clk_prepare_enable/clk_set_rate

2014-01-17 Thread Prabhakar Lad
From: Lad, Prabhakar prabhakar.cse...@gmail.com clk_set_rate(), clk_prepare_enable() functions can fail, so check the return values to avoid surprises. Signed-off-by: Lad, Prabhakar prabhakar.cse...@gmail.com --- drivers/media/i2c/mt9v032.c | 10 -- 1 file changed, 8 insertions(+), 2

Re: [PATCH] mtd: davinci_nand: Remove unnecessary labels from error path

2014-01-16 Thread Prabhakar Lad
Hi Brian, On Fri, Jan 17, 2014 at 3:02 AM, Brian Norris computersforpe...@gmail.com wrote: On Wed, Jan 15, 2014 at 01:38:26PM +0530, Prabhakar Lad wrote: From: Lad, Prabhakar prabhakar.cse...@gmail.com This patch removes the unnecessary labels from the error path in probe function which did

Kconfig errors

2014-01-16 Thread Prabhakar Lad
by ZBOOT_ROM # # configuration written to .config # Regards, --Prabhakar Lad -- To unsubscribe from this list: send the line unsubscribe linux-kernel in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http

Re: [PATCH] mtd: davinci_nand: Remove unnecessary labels from error path

2014-01-16 Thread Prabhakar Lad
Hi Brain, On Fri, Jan 17, 2014 at 10:46 AM, Prabhakar Lad prabhakar.cse...@gmail.com wrote: Hi Brian, On Fri, Jan 17, 2014 at 3:02 AM, Brian Norris computersforpe...@gmail.com wrote: On Wed, Jan 15, 2014 at 01:38:26PM +0530, Prabhakar Lad wrote: From: Lad, Prabhakar prabhakar.cse

[PATCH] mtd: davinci_nand: Remove unnecessary labels from error path

2014-01-15 Thread Prabhakar Lad
From: Lad, Prabhakar prabhakar.cse...@gmail.com This patch removes the unnecessary labels from the error path in probe function which did nothing than just returning error values, Thus simplifying code path and improved readability. Signed-off-by: Lad, Prabhakar prabhakar.cse...@gmail.com ---

[PATCH] net: davinci_mdio: Fix sparse warning

2014-01-15 Thread Prabhakar Lad
From: Lad, Prabhakar prabhakar.cse...@gmail.com This patch fixes following sparse warning davinci_mdio.c:85:27: warning: symbol 'default_pdata' was not declared. Should it be static? Also makes the default_pdata as a constant. Signed-off-by: Lad, Prabhakar prabhakar.cse...@gmail.com ---

Re: [PATCH v3 2/2] gpio: davinci: reuse for Keystone SoC

2013-12-25 Thread Prabhakar Lad
On Tue, Dec 24, 2013 at 6:57 PM, Grygorii Strashko grygorii.stras...@ti.com wrote: On 12/24/2013 01:20 PM, Prabhakar Lad wrote: Hi Grygorii, Thanks for the patch. On Tue, Dec 24, 2013 at 5:11 PM, Grygorii Strashko grygorii.stras...@ti.com wrote: The similar GPIO HW block is used

Re: [PATCH v3 2/2] gpio: davinci: reuse for Keystone SoC

2013-12-24 Thread Prabhakar Lad
(davinci_gpio_ids), + dev); Sorry didn't notice that earlier the data structure of_match_ptr() protects is always compiled in. so of_match_ptr() is not needed. While you are at it you can also fix it in davinci_gpio_driver structure as a sperate patch. Regards, --Prabhakar Lad

Re: [PATCH v2 1/2] gpio: davinci: don't create irq_domain in case of unbanked irqs

2013-12-21 Thread Prabhakar Lad
Acked-by: Lad, Prabhakar prabhakar.cse...@gmail.com Regards, --Prabhakar Lad -- To unsubscribe from this list: send the line unsubscribe linux-kernel in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http

Re: [PATCH v2 2/2] gpio: davinci: reuse for Keystone SoC

2013-12-21 Thread Prabhakar Lad
-by: Grygorii Strashko grygorii.stras...@ti.com Acked-by: Lad, Prabhakar prabhakar.cse...@gmail.com Regards, --Prabhakar Lad -- To unsubscribe from this list: send the line unsubscribe linux-kernel in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org

Re: [PATCH] media: davinci_vpfe: fix build error

2013-12-20 Thread Prabhakar Lad
: error: implicit declaration of function ‘msleep’ Will you pick this patch or shall I go ahead and issue a pull to Mauro ? Regards, --Prabhakar Lad -- To unsubscribe from this list: send the line unsubscribe linux-kernel in the body of a message to majord...@vger.kernel.org More majordomo info

Re: [PATCH] media: davinci_vpfe: fix build error

2013-12-20 Thread Prabhakar Lad
in linux-media but its present DLOS [1]. I posted it the same day when you pinged me about this issue. Anyway your patch too didnt reach me and I also cannot find it in the ML. May be you directly issued the pull ? [1] https://patchwork.kernel.org/patch/3362211/ Regards, --Prabhakar Lad

Re: [PATCH] media: davinci_vpfe: fix build error

2013-12-20 Thread Prabhakar Lad
Hi Hans, On Fri, Dec 20, 2013 at 7:00 PM, Hans Verkuil hverk...@xs4all.nl wrote: Hi Prabhakar, On 12/20/2013 02:02 PM, Prabhakar Lad wrote: Hi Hans, On Fri, Dec 20, 2013 at 6:23 PM, Hans Verkuil hverk...@xs4all.nl wrote: I just made a patch myself that I added to the pull request I just

Re: [PATCH v7] gpio: davinci: use {readl|writel}_relaxed() instead of __raw_*

2013-12-12 Thread Prabhakar Lad
Hi Linus, On Fri, Dec 13, 2013 at 2:01 AM, Linus Walleij linus.wall...@linaro.org wrote: On Wed, Dec 11, 2013 at 6:52 PM, Prabhakar Lad prabhakar.cse...@gmail.com wrote: From: Lad, Prabhakar prabhakar.cse...@gmail.com This patch replaces the __raw_readl/writel with {readl|writel}_relaxed

[PATCH v7] gpio: davinci: use {readl|writel}_relaxed() instead of __raw_*

2013-12-11 Thread Prabhakar Lad
From: Lad, Prabhakar prabhakar.cse...@gmail.com This patch replaces the __raw_readl/writel with {readl|writel}_relaxed(), Altough the code runs on ARMv5 based SOCs, changing this will help copying the code for other uses. Signed-off-by: Lad, Prabhakar prabhakar.cse...@gmail.com --- This patch

Re: [RFC v1 0/9] gpio: davinci: reuse for keystone arch

2013-12-11 Thread Prabhakar Lad
: - up to 32 GPIO lines; - only unbanked irqs; See Documentation: Keystone - http://www.ti.com/lit/ug/sprugv1/sprugv1.pdf [1] Depends on patch: [PATCH 1/2] gpio: davinci: Fix a check for unbanked gpio https://lkml.org/lkml/2013/11/8/22 [2] and depends on series from Prabhakar Lad: [PATCH v6 0

Re: [PATCH v6 0/6] gpio: daVinci: cleanup and feature enhancement

2013-11-29 Thread Prabhakar Lad
Hi Linus, On Fri, Nov 29, 2013 at 1:17 PM, Linus Walleij linus.wall...@linaro.org wrote: On Thu, Nov 21, 2013 at 7:15 PM, Prabhakar Lad prabhakar.cse...@gmail.com wrote: From: Lad, Prabhakar prabhakar.cse...@gmail.com This patch series does the following 1 Ports the driver to use irqdomain

Re: [PATCH v6 4/6] gpio: davinci: add OF support

2013-11-26 Thread Prabhakar Lad
Hi Sekhar, Thanks for the review. On Mon, Nov 25, 2013 at 4:30 PM, Sekhar Nori nsek...@ti.com wrote: On Thursday 21 November 2013 11:45 PM, Prabhakar Lad wrote: From: KV Sujith sujit...@ti.com This patch adds OF parser support for davinci gpio driver and also appropriate documentation

Re: [PATCH v6 1/6] gpio: davinci: use readl/writel instead of __raw_*

2013-11-26 Thread Prabhakar Lad
Hi Sekhar, On Mon, Nov 25, 2013 at 4:04 PM, Sekhar Nori nsek...@ti.com wrote: Prabhakar, On Monday 25 November 2013 09:42 AM, Prabhakar Lad wrote: Hi Taras, On Fri, Nov 22, 2013 at 3:38 PM, Taras Kondratiuk taras.kondrat...@linaro.org wrote: On 21 November 2013 20:15, Prabhakar Lad

Re: [PATCH 1/2] gpio: davinci: get rid of DAVINCI_N_GPIO

2013-11-26 Thread Prabhakar Lad
-by: Grygorii Strashko grygorii.stras...@ti.com Acked-by: Lad, Prabhakar prabhakar.cse...@gmail.com Regards, --Prabhakar Lad -- To unsubscribe from this list: send the line unsubscribe linux-kernel in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org

Re: [PATCH 2/2] gpio: introduce GPIO_DAVINCI kconfig option

2013-11-26 Thread Prabhakar Lad
driver for Keystone SoCs when needed. At same time, kept Davinci GPIO driver enabled for Davinci SoCs by default. Signed-off-by: Grygorii Strashko grygorii.stras...@ti.com Acked-by: Lad, Prabhakar prabhakar.cse...@gmail.com Regards, --Prabhakar Lad -- To unsubscribe from this list: send

Re: [PATCH v6 1/6] gpio: davinci: use readl/writel instead of __raw_*

2013-11-24 Thread Prabhakar Lad
Hi Taras, On Fri, Nov 22, 2013 at 3:38 PM, Taras Kondratiuk taras.kondrat...@linaro.org wrote: On 21 November 2013 20:15, Prabhakar Lad prabhakar.cse...@gmail.com wrote: From: Lad, Prabhakar prabhakar.cse...@gmail.com This patch replaces the __raw_readl/writel with readl and writel, Altough

Re: [PATCH v5 5/7] gpio: davinci: add OF support

2013-11-11 Thread Prabhakar Lad
Hi Grygorii, Thanks for the review. On Mon, Nov 11, 2013 at 8:48 PM, Grygorii Strashko grygorii.stras...@ti.com wrote: On 11/08/2013 12:11 PM, Prabhakar Lad wrote: [Snip] @@ -134,6 +137,40 @@ davinci_gpio_set(struct gpio_chip *chip, unsigned offset, int value) writel((1 offset

Re: [PATCH v5 1/7] gpio: davinci: remove unnecessary printk

2013-11-11 Thread Prabhakar Lad
Hi Grygorii, Thanks for the review. On Fri, Nov 8, 2013 at 9:09 PM, Grygorii Strashko grygorii.stras...@ti.com wrote: On 11/08/2013 12:11 PM, Prabhakar Lad wrote: From: Lad, Prabhakar prabhakar.cse...@gmail.com the devm_*() helper prints error messages in case of errors no need to do

  1   2   3   4   5   6   7   >