Re: [PATCH] arm: kgdb: fix NUMREGBYTES so that gdb_regs[] is the correct size

2018-04-05 Thread Rabin Vincent
runcated register 19 in remote 'g' packet" > > This also causes the register serialization/deserialization logic to > overflow gdb_regs[], overwriting whatever follows. > > Fixes: 834b2964b7ab ("kgdb,arm: fix register dump") > Cc: <sta...@vger.kernel.org> # 2.6.37+ &g

[PATCH for v4.9-stable] sched: fix softirq time accounting

2017-12-13 Thread Rabin Vincent
From: Rabin Vincent <rab...@axis.com> softirq time accounting is broken on v4.9.x if ksoftirqd runs. With CONFIG_IRQ_TIME_ACCOUNTING=y # CONFIG_VIRT_CPU_ACCOUNTING_GEN is not set this test code: struct tasklet_struct tasklet; static void delay_tasklet(un

Re: [PATCH 1/2] arm64: mm: abort uaccess retries upon fatal signal

2017-11-13 Thread Rabin Vincent
On Tue, Aug 22, 2017 at 10:45:24AM +0100, Will Deacon wrote: > On Mon, Aug 21, 2017 at 02:42:03PM +0100, Mark Rutland wrote: > > On Tue, Jul 11, 2017 at 03:58:49PM +0100, Will Deacon wrote: > > > On Tue, Jul 11, 2017 at 03:19:22PM +0100, Mark Rutland wrote: > > > > When there's a fatal signal

[PATCH] CIFS: fix circular locking dependency

2017-06-29 Thread Rabin Vincent
From: Rabin Vincent <rab...@axis.com> When a CIFS filesystem is mounted with the forcemand option and the following command is run on it, lockdep warns about a circular locking dependency between CifsInodeInfo::lock_sem and the inode lock. while echo foo > hello; do :; done & w

Re: [4.9.28] vmscan: shrink_slab: ext4_es_scan+0x0/0x150 negative objects to delete nr=-2147483624

2017-06-12 Thread Rabin Vincent
On Thu, May 18, 2017 at 07:21:49AM +0200, Marc Burkhardt wrote: > tonight my dmesg was flooded with mesages like > > vmscan: shrink_slab: ext4_es_scan+0x0/0x150 negative objects to delete > nr=-2147483624 > > Is that an integer overflow happening in ext4? > > It's the first time I see this

[PATCH v4] ubifs: allow userspace to map mounts to volumes

2017-05-31 Thread Rabin Vincent
From: Rabin Vincent <rab...@axis.com> There currently appears to be no way for userspace to find out the underlying volume number for a mounted ubifs file system, since ubifs uses anonymous block devices. The volume name is present in /proc/mounts but UBI volumes can be renamed after the

Re: Setting ->s_dev to a char device (Was: Re: [PATCH v2] ubifs: allow userspace to map mounts to volumes)

2017-05-29 Thread Rabin Vincent
t; valid volume name, anyway? That would seem to be the obvious approach... The following patch works for me, if it's OK to show options that can't actually be used when mounting: 8<--- >From 19797334f9c87a2e0c90fe2c93f29cce397b6230 Mon Sep 17 00:00:00 2001 Fro

[PATCH v2] ubifs: allow userspace to map mounts to volumes

2017-05-29 Thread Rabin Vincent
From: Rabin Vincent <rab...@axis.com> There currently appears to be no way for userspace to find out the underlying volume number for a mounted ubifs file system, since ubifs uses anonymous block devices. The volume name is present in /proc/mounts but UBI volumes can be renamed after the

[PATCH] ubifs: allow userspace to map mounts to volumes

2017-05-24 Thread Rabin Vincent
From: Rabin Vincent <rab...@axis.com> There currently appears to be no way for userspace to find out the underlying volume number for a mounted ubifs file system, since ubifs uses anonymous block devices. The volume name is present in /proc/mounts but UBI volumes can be renamed after the

[PATCH] CIFS: fix oplock break deadlocks

2017-05-03 Thread Rabin Vincent
From: Rabin Vincent <rab...@axis.com> When the final cifsFileInfo_put() is called from cifsiod and an oplock break work is queued, lockdep complains loudly: = [ INFO: possible recursive locking detected ] 4.11.0+ #21 Not t

[PATCH] CIFS: silence lockdep splat in cifs_relock_file()

2017-05-03 Thread Rabin Vincent
From: Rabin Vincent <rab...@axis.com> cifs_relock_file() can perform a down_write() on the inode's lock_sem even though it was already performed in cifs_strict_readv(). Lockdep complains about this. AFAICS, there is no problem here, and lockdep just needs to be told that this nesting

[PATCH] Makefile: evaluate LDFLAGS_BUILD_ID only once

2017-04-30 Thread Rabin Vincent
2 119 sched:sched_process_exec + 1 878 sched:sched_process_exec - 1,238817018 seconds time elapsed + 0,971020553 seconds time elapsed Signed-off-by: Rabin Vincent <ra...@rab.in> --- Makefile | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/Makefile b/Makefile inde

[PATCH] mm: prevent NR_ISOLATE_* stats from going negative

2017-04-20 Thread Rabin Vincent
From: Rabin Vincent <rab...@axis.com> Commit 6afcf8ef0ca0 ("mm, compaction: fix NR_ISOLATED_* stats for pfn based migration") moved the dec_node_page_state() call (along with the page_is_file_cache() call) to after putback_lru_page(). But page_is_file_cache() can change after

[PATCH] printk: fix lost last line in kmsg dump

2017-04-19 Thread Rabin Vincent
From: Rabin Vincent <rab...@axis.com> kmsg_dump_get_buffer() selects the youngest log messages which fit into the provided buffer. When that function determines the correct start index, by looping and calling msg_print_text() with a NULL buffer, it allows the youngest log messages to comp

[PATCH] MIPS: perf: fix deadlock

2017-04-05 Thread Rabin Vincent
From: Rabin Vincent <rab...@axis.com> mipsxx_pmu_handle_shared_irq() calls irq_work_run() while holding the pmuint_rwlock for read. irq_work_run() can, via perf_pending_event(), call try_to_wake_up() which can try to take rq->lock. However, perf can also call perf_pmu_enable() (and

Re: [PATCH] arm: ftrace: fix dynamic ftrace with DEBUG_RODATA and !FRAME_POINTER

2017-03-18 Thread Rabin Vincent
Move the override out of that ifdef and into the CONFIG_DYNAMIC_FTRACE > ifdef where it belongs. > > Fixes: 80d6b0c2eed2a ("ARM: mm: allow text and rodata sections to be > read-only") > > Suggested-by: Nicolai Stange <nicsta...@gmail.com> > Suggested-by: Rabin Vinc

Re: [PATCHv5] arm: ftrace: Adds support for CONFIG_DYNAMIC_FTRACE_WITH_REGS

2017-03-04 Thread Rabin Vincent
On Sat, Mar 04, 2017 at 12:51:12AM +, Abel Vesa wrote: > diff --git a/arch/arm/kernel/entry-ftrace.S b/arch/arm/kernel/entry-ftrace.S > index c73c403..93f9abb 100644 > --- a/arch/arm/kernel/entry-ftrace.S > +++ b/arch/arm/kernel/entry-ftrace.S > @@ -92,12 +92,78 @@ > 2: mcount_exit > .endm

Re: DIfferent BogoMIPS value after bbaa06702719 ("clocksource/drivers/arm_global_timer: Register delay timer")

2017-03-02 Thread Rabin Vincent
On Thu, Mar 02, 2017 at 02:36:23PM +0100, Rafał Miłecki wrote: > I just updated kernel on my SmartRG SR400ac (bcm4708-smartrg-sr400ac.dts) from > 4.4 to 4.9 and noticed that this part of the log: > [0.020820] Calibrating delay loop... 1594.16 BogoMIPS (lpj=7970816) > (...) > [0.190806]

Re: [PATCH] printk: fix printk.devkmsg sysctl

2017-01-30 Thread Rabin Vincent
On Fri, Jan 27, 2017 at 07:19:30PM +0100, Borislav Petkov wrote: > On Fri, Jan 27, 2017 at 04:42:30PM +0100, Rabin Vincent wrote: > > proc_dostring() eats the '\n' and stops > > Not a problem, see diff below. Would it be possible for you to please submit it as a patch yourself so

Re: [PATCH] printk: fix printk.devkmsg sysctl

2017-01-27 Thread Rabin Vincent
On Fri, Jan 27, 2017 at 04:01:41PM +0100, Borislav Petkov wrote: > On Fri, Jan 27, 2017 at 02:11:46PM +0100, Rabin Vincent wrote: > > @@ -177,7 +177,7 @@ int devkmsg_sysctl_set_loglvl(struct ctl_table *table, > > int write, > > * Do not accept an unknown str

[PATCH] printk: fix printk.devkmsg sysctl

2017-01-27 Thread Rabin Vincent
From: Rabin Vincent <rab...@axis.com> The comment says that it doesn't want to accept trailing crap but that's just what it allows: # echo -n offX > /proc/sys/kernel/printk_devkmsg # while at the same time it rejects legitimate uses: # echo -n off > /proc/sys/kernel/printk_

Re: Synopsys Ethernet QoS Driver

2016-11-19 Thread Rabin Vincent
On Fri, Nov 18, 2016 at 02:20:27PM +, Joao Pinto wrote: > For now we are interesting in improving the synopsys QoS driver under > /nect/ethernet/synopsys. For now the driver structure consists of a single > file > called dwc_eth_qos.c, containing synopsys ethernet qos common ops and platform

Re: [PATCH] ARM: ftrace: fix syscall name matching

2016-11-15 Thread Rabin Vincent
On Mon, Nov 14, 2016 at 10:40:08AM -0500, Steven Rostedt wrote: > On Mon, 14 Nov 2016 13:40:17 + > Russell King - ARM Linux <li...@armlinux.org.uk> wrote: > > On Mon, Nov 14, 2016 at 02:03:45PM +0100, Rabin Vincent wrote: > > > +static inline bool arch_syscall_mat

[tip:perf/core] perf callchain: Fixup help/config for no-unwinding

2016-11-15 Thread tip-bot for Rabin Vincent
Commit-ID: c56cb33b56c13493eeb95612f80e4dd6e35cd109 Gitweb: http://git.kernel.org/tip/c56cb33b56c13493eeb95612f80e4dd6e35cd109 Author: Rabin Vincent <rab...@axis.com> AuthorDate: Wed, 10 Aug 2016 15:52:28 +0200 Committer: Arnaldo Carvalho de Melo <a...@redhat.com> CommitDate

[PATCHv2] ARM: ftrace: fix syscall name matching

2016-11-15 Thread Rabin Vincent
From: Rabin Vincent <rab...@axis.com> ARM has a few system calls (most notably mmap) for which the names of the functions which are referenced in the syscall table do not match the names of the syscall tracepoints. As a consequence of this, these tracepoints are not made available. Imp

[PATCH] ARM: ftrace: fix syscall name matching

2016-11-14 Thread Rabin Vincent
From: Rabin Vincent <rab...@axis.com> ARM has a few system calls (most notably mmap) for which the names of the functions which are referenced in the syscall table do not match the names of the syscall tracepoints. As a consequence of this, these tracepoints are not made available. Imp

[PATCH] dm crypt: fix crash on exit

2016-09-21 Thread Rabin Vincent
From: Rabin Vincent <rab...@axis.com> As the documentation for kthread_stop() says, "if threadfn() may call do_exit() itself, the caller must ensure task_struct can't go away". dm-crypt does not ensure this and therefore crashes when crypt_dtr() calls kthread_stop(). The cr

Re: [PATCH v3] scripts: add script for translating stack dump function

2016-09-19 Thread Rabin Vincent
On Mon, Sep 19, 2016 at 12:15:42PM -0700, Linus Torvalds wrote: > Hmm. Would you mind if I change the > > addr2line -fpie $objfile $hexaddr | sed "s;$dir_prefix;;" > > into > > addr2line -fpie $objfile $hexaddr | > sed "s; at $dir_prefix\(\./\)*; at ;" > >

Re: [PATCH v2] scripts: add script for translating stack dump function offsets

2016-09-17 Thread Rabin Vincent
On Fri, Sep 16, 2016 at 04:26:56PM -0500, Josh Poimboeuf wrote: > + addr2line -ie $objfile $hexaddr Could you pass in -f and -p too to addr2line? Before: $ scripts/faddr2line ~/dev/kvm2/vmlinux free_reserved_area+0x90 /home/rabin/dev/linux/include/linux/compiler.h:222

Re: [PATCH] pstore/core: drop cmpxchg based updates

2016-09-08 Thread Rabin Vincent
> Cc: Kees Cook <keesc...@chromium.org> > Cc: Tony Luck <tony.l...@intel.com> > Signed-off-by: Sebastian Andrzej Siewior <bige...@linutronix.de> Tested-by: Rabin Vincent <rab...@axis.com> This patch is needed for pstore to work on (most?) ARMv7 chips. See this

Re: [PATCH] bdev: fix NULL pointer dereference in sync()/close() race

2016-08-27 Thread Rabin Vincent
On Sat, Aug 27, 2016 at 09:07:28AM +0200, Vegard Nossum wrote: > I got this with syzkaller: > > general protection fault: [#1] PREEMPT SMP KASAN > Dumping ftrace buffer: >(ftrace buffer empty) > CPU: 0 PID: 11941 Comm: syz-executor Not tainted 4.8.0-rc2+ #169 >

[PATCH] perf callchain: fixup help/config for no-unwinding

2016-08-10 Thread Rabin Vincent
From: Rabin Vincent <rab...@axis.com> Since 841e3558b2d ("perf callchain: Recording 'dwarf' callchains do not need DWARF unwinding support"), --call-graph dwarf is allowed in perf record even without unwind support. A couple of other places don't reflect this yet though: the

[PATCH] perf unwind: check symsrc ELF for .debug_frame

2016-08-10 Thread Rabin Vincent
From: Rabin Vincent <rab...@axis.com> When using split debug info, the file without debug info may not have a .debug_frame section, so we need to check the symsrc ELF also, since that's the file we actually read the unwind information from. Signed-off-by: Rabin Vincent <rab...

Re: debug tip after earlycon is closed?

2016-08-08 Thread Rabin Vincent
On Thu, Jul 28, 2016 at 01:20:22PM +0100, Russell King - ARM Linux wrote: > To me, what this means is that the DT parsing of linux,stdout is > broken - while it may look nice from a design point of view, the > design is wrong and fails to take account of non-UART consoles in > the system. Note

Re: [QUESTION] Is there a better way to get ftrace dump on guest?

2016-06-28 Thread Rabin Vincent
On Tue, Jun 28, 2016 at 03:33:18PM +0900, Namhyung Kim wrote: > On Tue, Jun 28, 2016 at 3:25 PM, Namhyung Kim wrote: > > I'm running some guest machines for kernel development. For debugging > > purpose, I use lots of trace_printk() since it's faster than normal > >

Faster incremental builds with Ninja

2016-06-27 Thread Rabin Vincent
Ninja is a small build system with a focus on speed. More details at https://ninja-build.org/. I made an experimental Ninja build file generator for the kernel. The purpose was to see how much we could decrease compile times (especially to detect errors) for single file changes. Results on my

[PATCH 2/2] kbuild: add shell cache

2016-06-27 Thread Rabin Vincent
&& perf stat -r5 make kernelversion Before: 0,252219929 seconds time elapsed ( +- 0,39% ) After: 0,008607464 seconds time elapsed ( +- 0,50% ) Signed-off-by: Rabin Vincent <ra...@rab.in> --- Makefile | 15 --- scripts/Kbuil

[PATCH 1/2] Makefile: evaluate LDFLAGS_BUILD_ID only once

2016-06-27 Thread Rabin Vincent
) After: 0,864487173 seconds time elapsed ( +- 0,35% ) Signed-off-by: Rabin Vincent <ra...@rab.in> --- Makefile | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/Makefile b/Makefile index 6471f20ca400..91baa282f3fa 100644 --- a/Makefile +++ b/Makefile @@ -814,7 +814,7 @@

Re: [PATCH] tracing: add support for tracing MMIO helpers

2016-04-29 Thread Rabin Vincent
On Tue, Apr 26, 2016 at 09:14:47PM +0200, Arnd Bergmann wrote: > On Tuesday 26 April 2016 21:04:42 Rabin Vincent wrote: > > The support is added via and as such is only > > available on the archs which use that header. > > Why that limitation? I think only few archit

[PATCH] tracing: add support for tracing MMIO helpers

2016-04-26 Thread Rabin Vincent
racing must be explicitly enabled in the required driver source files by #defining TRACE_MMIO_HELPERS at the top of the file. The support is added via and as such is only available on the archs which use that header. Signed-off-by: Rabin Vincent <ra...@rab.in>

[tip:sched/core] sched/debug: Don't dump sched debug info in SysRq-W

2016-04-13 Thread tip-bot for Rabin Vincent
Commit-ID: fb90a6e93c0684ab2629a42462400603aa829b9c Gitweb: http://git.kernel.org/tip/fb90a6e93c0684ab2629a42462400603aa829b9c Author: Rabin Vincent <rab...@axis.com> AuthorDate: Mon, 4 Apr 2016 15:42:02 +0200 Committer: Ingo Molnar <mi...@kernel.org> CommitDate: Wed, 13 Ap

[PATCH] sched: don't dump sched debug info in SysRq-W

2016-04-04 Thread Rabin Vincent
From: Rabin Vincent <rab...@axis.com> sysrq_sched_debug_show() can dump a lot of information. Don't print out all that if we're just trying to get a list of blocked tasks (SysRq-W). The information is still accessible with SysRq-T. Signed-off-by: Rabin Vincent <rab...@axis.com>

Re: [PATCH] clockevents/drivers/arm_global_timer: Fix erratum 740657 workaround

2016-04-04 Thread Rabin Vincent
On Tue, Mar 29, 2016 at 05:13:05PM +0100, Marc Zyngier wrote: > - What if my timer is not connected to a controller that implements this > API? Something that is not a GIC, for example? As you know irq_set_irqchip_state() does nothing in that case, and the erratum is thus presumably not worked

Re: [PATCH] clockevents/drivers/arm_global_timer: Fix erratum 740657 workaround

2016-04-04 Thread Rabin Vincent
On Tue, Mar 29, 2016 at 04:21:03PM +0200, Daniel Lezcano wrote: > On 03/29/2016 10:08 AM, Rabin Vincent wrote: > > -0 [001] d.h2 99.850527: irq_handler_entry: irq=16 name=gt > > -0 [001] d.h2 99.850538: irq_handler_exit: irq=16 ret=handled > > -0 [001] d.H2 99.850540: irq_

[PATCH] clockevents/drivers/arm_global_timer: Fix erratum 740657 workaround

2016-03-29 Thread Rabin Vincent
From: Rabin Vincent <rab...@axis.com> According to the errata document for the Cortex A9 MPCore, the correct code sequence in the interrupt handler to workaround erratum 740657 "Global Timer can send two interrupts for the same event" is: (1) Read the ICCIAR (Interrupt Acknowled

Re: [PATCH v2] ARM: DMA: Fix kzalloc flags in __dma_alloc

2016-03-19 Thread Rabin Vincent
locator unhappy. > > Signed-off-by: Alexandre Courbot <acour...@nvidia.com> > Cc: Rabin Vincent <ra...@rab.in> > --- > Changes since v1: > - Filter flags that may cause problem instead of forcing GFP_KERNEL > (and risk sleeping in atomic context), as suggested by Rabin. Acked-by: Rabin Vincent <ra...@rab.in> Thanks.

Re: [PATCH] ARM: DMA: Fix kzalloc flags in __dma_alloc

2016-03-19 Thread Rabin Vincent
On Fri, Mar 18, 2016 at 11:12:26AM +0900, Alexandre Courbot wrote: > Commit 19e6e5e5392b ("ARM: 8547/1: dma-mapping: store buffer > information") allocates a structure meant for internal buffer management > with the GFP flags of the buffer itself. This can trigger the following > safeguard in the

Re: [PATCH] block: protect iterate_bdevs() against concurrent close

2016-03-14 Thread Rabin Vincent
(fixed Jens' address) On Thu, Mar 10, 2016 at 06:37:27PM +0100, Jan Kara wrote: > On Thu 10-03-16 13:26:03, Rabin Vincent wrote: > > If a block device is closed while iterate_bdevs() is handling it, the > > following NULL pointer dereference occurs because bdev-

[PATCH] splice: handle zero nr_pages in splice_to_pipe()

2016-03-10 Thread Rabin Vincent
Cc: sta...@vger.kernel.org Signed-off-by: Rabin Vincent <ra...@rab.in> --- fs/splice.c | 3 +++ 1 file changed, 3 insertions(+) diff --git a/fs/splice.c b/fs/splice.c index 82bc0d64fc38..19e0b103d253 100644 --- a/fs/splice.c +++ b/fs/splice.c @@ -185,6 +185,9 @@ ssize_t splice_to_pipe(struct

[PATCH] block: protect iterate_bdevs() against concurrent close

2016-03-10 Thread Rabin Vincent
From: Rabin Vincent <rab...@axis.com> If a block device is closed while iterate_bdevs() is handling it, the following NULL pointer dereference occurs because bdev->b_disk is NULL in bdev_get_queue(), which is called from blk_get_backing_dev_info() (in tu

Re: [PATCH 2/2] ARM: dma-mapping: fix alloc/free for coherent + CMA + gfp=0

2016-02-23 Thread Rabin Vincent
On Fri, Feb 19, 2016 at 02:50:52PM +0100, Michal Nazarewicz wrote: > I haven’t looked closely at the code, but why not: > > struct cma *cma = > if (!cma_release(dev_get_cma_area(dev), page, size >> PAGE_SHIFT)) { > // ... do whatever other non-CMA free > } The

Re: [PATCH 2/2] ARM: dma-mapping: fix alloc/free for coherent + CMA + gfp=0

2016-02-23 Thread Rabin Vincent
On Fri, Feb 19, 2016 at 02:06:00PM +, Russell King - ARM Linux wrote: > On Fri, Feb 19, 2016 at 09:12:04AM +0100, Rabin Vincent wrote: > > Given a device which uses arm_coherent_dma_ops and on which > > dev_get_cma_area(dev) returns non-NULL, the following usage of the DMA >

[PATCH] regulator: gpio: don't print error on EPROBE_DEFER

2016-02-19 Thread Rabin Vincent
Don't print out an error with the driver sees EPROBE_DEFER when attempting to get the gpio. These errors are usually transient; the probe will be retried later. Signed-off-by: Rabin Vincent <rabin.vinc...@axis.com> --- drivers/regulator/gpio-regulator.c | 6 -- 1 file changed, 4 inse

[PATCH 1/2] mm: cma: split out in_cma check to separate function

2016-02-19 Thread Rabin Vincent
Split out the logic in cma_release() which checks if the page is in the contiguous area to a new function which can be called separately. ARM will use this. Signed-off-by: Rabin Vincent <rabin.vinc...@axis.com> --- include/linux/cma.h | 12 mm/cma.c

[PATCH 2/2] ARM: dma-mapping: fix alloc/free for coherent + CMA + gfp=0

2016-02-19 Thread Rabin Vincent
, so fix it by using the new in_cma() function to determine if a buffer was allocated with CMA, similar to how we check for __in_atomic_pool(). Fixes: 21caf3a7 ("ARM: 8398/1: arm DMA: Fix allocation from CMA for coherent DMA") Signed-off-by: Rabin Vincent <rabin.vinc...@axis.com> ---

Re: [PATCH] clocksource: arm_global_timer: register delay timer

2016-02-16 Thread Rabin Vincent
On Thu, Aug 20, 2015 at 09:03:04PM +0200, Daniel Lezcano wrote: > On 08/19/2015 03:43 PM, Rabin Vincent wrote: > > Provide a delay timer using the lower 32-bits of the global timer so > > that we can use that instead of having to calibrating delays. > > > > Signed-off-by

Re: [PATCH] recordmcount: arm: Implement make_nop

2016-02-02 Thread Rabin Vincent
On Mon, Feb 01, 2016 at 11:44:32AM -0800, Stephen Boyd wrote: > On 01/30, Rabin Vincent wrote: > > For __gnu_mcount_nc, wouldn't it be better to replace both the push {lr} > > and the bl with nop instructions, instead of keeping a (useless) push + > > pop sequence? > >

Re: [PATCH v2] recordmcount: arm: Implement make_nop

2016-02-02 Thread Rabin Vincent
On Mon, Feb 01, 2016 at 04:06:23PM -0800, Stephen Boyd wrote: > In similar spirit to x86 and arm64 support, add a make_nop_arm() > to replace calls to mcount with nops in sections that aren't > traced. > > Cc: Russell King <li...@arm.linux.org.uk> > Cc: Rabin Vincent <

Re: [PATCH] recordmcount: arm: Implement make_nop

2016-01-30 Thread Rabin Vincent
On Fri, Jan 29, 2016 at 05:18:06PM -0800, Stephen Boyd wrote: > diff --git a/scripts/recordmcount.c b/scripts/recordmcount.c > index e167592793a7..0b16d14c54fb 100644 > --- a/scripts/recordmcount.c > +++ b/scripts/recordmcount.c > @@ -206,6 +206,52 @@ static int make_nop_x86(void *map, size_t

[PATCH] net: filter: make JITs zero A for SKF_AD_ALU_XOR_X

2016-01-05 Thread Rabin Vincent
a helper to determine if A needs to be cleared given the first instruction in a filter, and use this in the JITs. Except for ARM, the rest have only been compile-tested. Fixes: 3480593131e0 ("net: filter: get rid of BPF_S_* enum") Signed-off-by: Rabin Vincent <ra...@rab.in> -

Re: [PATCH] net: filter: make JITs zero A for SKF_AD_ALU_XOR_X

2016-01-05 Thread Rabin Vincent
On Tue, Jan 05, 2016 at 08:00:45AM -0800, Eric Dumazet wrote: > On Tue, 2016-01-05 at 16:23 +0100, Rabin Vincent wrote: > > The SKF_AD_ALU_XOR_X ancillary is not like the other ancillary data > > instructions since it XORs A with X while all the others replace A with > > so

Re: [PATCH V7 02/24] coresight: associating path with session rather than tracer

2016-01-05 Thread Rabin Vincent
On Mon, Jan 04, 2016 at 11:24:14AM -0700, Mathieu Poirier wrote: > On 20 December 2015 at 08:29, Rabin Vincent <ra...@rab.in> wrote: > > This patch introduces a use-after-free/double kfree() if the sink is > > disabled after the source. > > > > With this command

Re: [PATCH] null_blk: don't enable irqs when in irq

2015-12-28 Thread Rabin Vincent
On Mon, Dec 28, 2015 at 11:52:24AM -0700, Jens Axboe wrote: > Something like this should work, can you test it? Spits out a bunch of the following. It's this assertion: static inline void queue_lockdep_assert_held(struct request_queue *q) { if (q->queue_lock)

Re: [PATCH] null_blk: don't enable irqs when in irq

2015-12-28 Thread Rabin Vincent
On Mon, Dec 28, 2015 at 12:11:17PM -0700, Jens Axboe wrote: > On 12/28/2015 12:07 PM, Rabin Vincent wrote: > >On Mon, Dec 28, 2015 at 11:52:24AM -0700, Jens Axboe wrote: > >>Something like this should work, can you test it? > > > >Spits out a bunch of the f

[PATCH] null_blk: don't enable irqs when in irq

2015-12-25 Thread Rabin Vincent
1c0 [] __generic_file_write_iter+0x190/0x1f0 [] blkdev_write_iter+0x7b/0x100 [] __vfs_write+0xaa/0xe0 [] vfs_write+0x95/0x100 [] ? __fget_light+0x6f/0x90 [] SyS_pwrite64+0x77/0x90 [] entry_SYSCALL_64_fastpath+0x12/0x76 ---[ end trace 39b7df36fb237be1 ]--- Signed-off-by: Rabin Vincent

Re: [PATCH V7 04/24] coresight: moving PM runtime operations to core framework

2015-12-24 Thread Rabin Vincent
On Wed, Dec 23, 2015 at 09:27:28AM -0700, Mathieu Poirier wrote: > On 19 December 2015 at 10:13, Rabin Vincent <ra...@rab.in> wrote: > > It should presumably be using pm_runtime_put() instead. > > That's a first - what platform did you test on? If I send you fixes > wil

Re: [PATCH V7 02/24] coresight: associating path with session rather than tracer

2015-12-20 Thread Rabin Vincent
On Fri, Dec 18, 2015 at 01:58:58PM -0700, Mathieu Poirier wrote: > When using the Coresight framework from the sysFS interface a > tracer is always handling a single session and as such, a path > can be associated with a tracer. But when supporting multiple > session per tracer there is no

Re: [PATCH V7 24/24] perf tools: adding coresight etm PMU record capabilities

2015-12-19 Thread Rabin Vincent
On Fri, Dec 18, 2015 at 01:59:20PM -0700, Mathieu Poirier wrote: > +struct auxtrace_record > +*auxtrace_record__init(struct perf_evlist *evlist, int *err) > +{ > + struct perf_pmu *cs_etm_pmu; > + struct perf_evsel *evsel; > + bool found_etm = false; > + > + cs_etm_pmu =

Re: [PATCH V7 04/24] coresight: moving PM runtime operations to core framework

2015-12-19 Thread Rabin Vincent
On Fri, Dec 18, 2015 at 01:59:00PM -0700, Mathieu Poirier wrote: > @@ -415,9 +418,13 @@ struct list_head *coresight_build_path(struct > coresight_device *csdev) > */ > void coresight_release_path(struct list_head *path) > { > + struct coresight_device *csdev; > struct coresight_node

Re: [PATCH V7 17/24] coresight: etb10: implementing AUX space API

2015-12-19 Thread Rabin Vincent
On Fri, Dec 18, 2015 at 01:59:13PM -0700, Mathieu Poirier wrote: > +static void etb_update_buffer(struct coresight_device *csdev, > + struct perf_output_handle *handle, > + void *sink_config) > +{ > + int i, cur; > + u32 *buf_ptr; ... >

Re: [PATCH V7 00/24] Coresight integration with perf

2015-12-19 Thread Rabin Vincent
On Fri, Dec 18, 2015 at 01:58:56PM -0700, Mathieu Poirier wrote: > This patchset aims to integrate configuration and control of > the Coresight tracers with the perf sub-system. > > The goal is to use PMUs to represent tracers and the auxiliary > buffer enhancement to collect processor traces.

Re: [PATCHv2 3/3] perf: add helper makefile for cross compiling libs

2015-11-06 Thread Rabin Vincent
On Thu, Oct 29, 2015 at 10:46:49AM +0100, Ingo Molnar wrote: > Would it be possible to add a gcc and glibc building portion as well? That > would > make it entirely self-hosting. Yes, but: - Those that intend to run the built binary on a target would presumably already have a cross-compiler

[tip:perf/core] tools build: Fix libiberty feature detection

2015-10-30 Thread tip-bot for Rabin Vincent
Commit-ID: 3af6ed84eb43c587beb5f325e39e65d08c61 Gitweb: http://git.kernel.org/tip/3af6ed84eb43c587beb5f325e39e65d08c61 Author: Rabin Vincent <rabin.vinc...@axis.com> AuthorDate: Thu, 29 Oct 2015 08:49:37 +0100 Committer: Arnaldo Carvalho de Melo <a...@redhat.com> Com

[tip:perf/core] perf unwind: Pass symbol source to libunwind

2015-10-30 Thread tip-bot for Rabin Vincent
Commit-ID: 7ed4915ad60788d6b846e2cd034f49ee15698143 Gitweb: http://git.kernel.org/tip/7ed4915ad60788d6b846e2cd034f49ee15698143 Author: Rabin Vincent <rabin.vinc...@axis.com> AuthorDate: Thu, 29 Oct 2015 08:49:36 +0100 Committer: Arnaldo Carvalho de Melo <a...@redhat.com> Com

[PATCHv2 3/3] perf: add helper makefile for cross compiling libs

2015-10-29 Thread Rabin Vincent
-dwarf-unwind: [ OFF ] ... zlib: [ on ] ... lzma: [ on ] ... get_cpuid: [ OFF ] Signed-off-by: Rabin Vincent <rabin.vinc...@axis.com> --- v2: expand commit message, add comments in Makefile, rename to Makefile.cross tools/

[PATCHv2 2/3] tools: build: fix libiberty feature detection

2015-10-29 Thread Rabin Vincent
`bfd_errmsg': bfd.c:(.text+0x168): undefined reference to `xstrerror' bbfd.a(opncls.o): In function `_bfd_new_bfd': opncls.c:(.text+0xe8): undefined reference to `objalloc_create' ... Signed-off-by: Rabin Vincent <rabin.vinc...@axis.com> --- v2: rewrite commit message tools/build/f

[PATCHv2 1/3] perf: unwind: pass symbol source to libunwind

2015-10-29 Thread Rabin Vincent
Even if --symfs is used to point to the debug binaries, we send in the non-debug filenames to libunwind, which leads to libunwind not finding the debug frame. Fix this by preferring the file in --symfs, if it is available. Signed-off-by: Rabin Vincent <rabin.vinc...@axis.com> --- v2: fal

Re: [PATCH] arm: Omit fixmap calls in text patching code if CONFIG_MMU=n

2015-10-26 Thread Rabin Vincent
-off-by: Geert Uytterhoeven <ge...@linux-m68k.org> Since both DEBUG_SET_MODULE_RONX and DEBUG_RODATA depend on MMU, we'll never get to this code on !MMU so this ifdef build fix should be ok. Acked-by: Rabin Vincent <ra...@rab.in> Thanks. -- To unsubscribe from this list: send the

Re: Build regressions/improvements in v4.3-rc7

2015-10-25 Thread Rabin Vincent
On Mon, Oct 26, 2015 at 12:33:18AM +0530, Afzal Mohammed wrote: > On Sun, Oct 25, 2015 at 06:38:18PM +0100, Geert Uytterhoeven wrote: > > I think we should have at least one arm-nommu platform in the upstream > > kernel, > > with a suitable defconfig, so 0build will catch regressions. > > afaik,

Re: Build regressions/improvements in v4.3-rc7

2015-10-25 Thread Rabin Vincent
39:2 > > + /home/kisskb/slave/src/arch/arm/kernel/patch.c: error: 'L_PTE_XN' > > undeclared (first use in this function): => 39:2 > > + /home/kisskb/slave/src/arch/arm/kernel/patch.c: error: 'L_PTE_YOUNG' > > undeclared (first use in this function): => 39:2 >

[tip:perf/core] perf callchain: Use debug_frame if eh_frame is unusable

2015-10-14 Thread tip-bot for Rabin Vincent
Commit-ID: 8eac1d5e9256260b9cc3bfcdd9b8b995990950f5 Gitweb: http://git.kernel.org/tip/8eac1d5e9256260b9cc3bfcdd9b8b995990950f5 Author: Rabin Vincent <rabin.vinc...@axis.com> AuthorDate: Sun, 27 Sep 2015 20:37:57 +0200 Committer: Arnaldo Carvalho de Melo <a...@redhat.com> Com

[tip:perf/core] perf callchains: Fix unw_word_t pointer casts

2015-10-14 Thread tip-bot for Rabin Vincent
Commit-ID: 186c6cfb32beae66140bc3c3fe4a519ee0234e33 Gitweb: http://git.kernel.org/tip/186c6cfb32beae66140bc3c3fe4a519ee0234e33 Author: Rabin Vincent <rabin.vinc...@axis.com> AuthorDate: Sun, 27 Sep 2015 20:37:55 +0200 Committer: Arnaldo Carvalho de Melo <a...@redhat.com> Com

Re: [PATCH 5/5] perf: add Makefile.deps for easier cross compiling

2015-10-13 Thread Rabin Vincent
On Mon, Oct 12, 2015 at 01:42:29PM +0200, Jiri Olsa wrote: > On Sun, Sep 27, 2015 at 08:37:59PM +0200, Rabin Vincent wrote: > > In order to make it easier for people to qucikly get up and running with > > a fairly full featured cross-compiled mainline perf, provide a > >

Re: [PATCH 4/5] tools: build: fix libiberty feature detection

2015-10-13 Thread Rabin Vincent
On Mon, Oct 12, 2015 at 01:35:02PM +0200, Jiri Olsa wrote: > We have FEATURE_CHECK_CFLAGS/FEATURE_CHECK_LDFLAGS variables > to pass CFLAGS/LDFLAGS to feature detection build > > Could you also be more specific on what is missing > to make the libiberty check compile? We don't need any special

Re: [PATCH 2/5] perf: unwind: pass symbol source to libunwind

2015-10-13 Thread Rabin Vincent
On Mon, Oct 12, 2015 at 02:35:08PM +0200, Namhyung Kim wrote: > On Mon, Oct 12, 2015 at 8:24 PM, Jiri Olsa <jo...@redhat.com> wrote: > > On Sun, Sep 27, 2015 at 08:37:56PM +0200, Rabin Vincent wrote: > >> Even if --symfs is used to point to the debug binaries, we se

Re: [PATCH 1/5] perf: unwind: fix unw_word_t pointer casts

2015-10-10 Thread Rabin Vincent
Hi Arnaldo, Do you have any comments on this patch set? Thanks. On Sun, Sep 27, 2015 at 08:37:55PM +0200, Rabin Vincent wrote: > unw_word_t is uint64_t even on 32-bit MIPS. Cast it to uintptr_t before > the cast to void *p to get rid of the following errors: > > util/unwind

[PATCH 2/5] perf: unwind: pass symbol source to libunwind

2015-09-27 Thread Rabin Vincent
Even if --symfs is used to point to the debug binaries, we send in the non-debug filenames to libunwind, which leads to libunwind not finding the debug frame. Fix this. Signed-off-by: Rabin Vincent <rabin.vinc...@axis.com> --- tools/perf/util/unwind-libunwind.c |2 +- 1 file chan

[PATCH 4/5] tools: build: fix libiberty feature detection

2015-09-27 Thread Rabin Vincent
): undefined reference to `xstrerror' bbfd.a(opncls.o): In function `_bfd_new_bfd': opncls.c:(.text+0xe8): undefined reference to `objalloc_create' ... Signed-off-by: Rabin Vincent <rabin.vinc...@axis.com> --- tools/build/feature/Makefile |4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-)

[PATCH 1/5] perf: unwind: fix unw_word_t pointer casts

2015-09-27 Thread Rabin Vincent
] util/unwind-libunwind.c:475:2: error: cast to pointer from integer of different size [-Werror=int-to-pointer-cast] cc1: all warnings being treated as errors make[3]: *** [util/unwind-libunwind.o] Error 1 Signed-off-by: Rabin Vincent <rabin.vinc...@axis.com> --- tools/perf/util/unwind-libun

[PATCH 3/5] perf: unwind: use debug_frame if eh_frame is unusable

2015-09-27 Thread Rabin Vincent
When NO_LIBUNWIND_DEBUG_FRAME=0, use the .debug_frame if the .eh_frame doesn't contain the approprate unwind tables. Signed-off-by: Rabin Vincent <rabin.vinc...@axis.com> --- tools/perf/util/unwind-libunwind.c | 10 ++ 1 file changed, 6 insertions(+), 4 deletions(-) diff --git a

[PATCH 5/5] perf: add Makefile.deps for easier cross compiling

2015-09-27 Thread Rabin Vincent
libslang: [ on ] ... libunwind: [ on ] ...libdw-dwarf-unwind: [ OFF ] ... zlib: [ on ] ... lzma: [ on ] Signed-off-by: Rabin Vincent <rabin.vinc...@axis.com> --- tools/perf/Make

Re: [PATCH 0/2] perf tools: Add MIPS userspace DWARF callchains.

2015-09-27 Thread Rabin Vincent
On Wed, Apr 08, 2015 at 01:58:45AM +0200, Ralf Baechle wrote: > This is a refresh of a David Daney's patch set to implement MIPS support > for perf. It has been posted before but not received any comments or > (N)Acks. > > This series depends on > > http://patchwork.linux-mips.org/patch/5246/

Re: [PATCH] arm: insn: use set_fixmap_offset to make it more clear

2015-08-27 Thread Rabin Vincent
On Wed, Aug 26, 2015 at 09:24:26AM +0800, yalin wang wrote: A little change to patch_map() function, use set_fixmap_offset() to make code more clear. Signed-off-by: yalin wang yalin.wang2...@gmail.com --- arch/arm/kernel/patch.c | 5 ++--- 1 file changed, 2 insertions(+), 3 deletions(-)

[PATCH] clocksource: arm_global_timer: register delay timer

2015-08-19 Thread Rabin Vincent
Provide a delay timer using the lower 32-bits of the global timer so that we can use that instead of having to calibrating delays. Signed-off-by: Rabin Vincent rabin.vinc...@axis.com --- drivers/clocksource/arm_global_timer.c | 17 + 1 file changed, 17 insertions(+) diff --git

Re: Problem with ftrace uprobes on ARM

2015-08-12 Thread Rabin Vincent
On Wed, Aug 12, 2015 at 11:27:35AM +0200, Christian Ascheberg wrote: Is there any documentation regarding limitations of perf/ftrace support on ARM (compared to x86)? There's Documentation/features/ which lists the status of architecture support for various kernel options. I don't know of any

[PATCH] writeback: fix initial dirty limit

2015-08-05 Thread Rabin Vincent
The initial value of global_wb_domain.dirty_limit set by writeback_set_ratelimit() is zeroed out by the memset in wb_domain_init(). Signed-off-by: Rabin Vincent rabin.vinc...@axis.com --- mm/page-writeback.c |4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/mm/page

[PATCH?] Non-throttling of mkfs leads to OOM

2015-08-05 Thread Rabin Vincent
Hi, I received some reports of mkfs.ext4 on an SD card triggering the OOM killer on a swapless system with a low amount of free memory. I have made a reproducible setup of this by using null_blk with a large completion delay. The problem appears to be that we do not throttle to the level of

[PATCH 3/6] CRIS v32: dev88: add GPIO, LEDs, RTC, temp sensor

2015-08-03 Thread Rabin Vincent
Add the GPIO driver to the device tree and, using it, support for the LEDs and the RTC chip (via I2C-GPIO), as well as the temperature sensor (via SPI-GPIO). Signed-off-by: Rabin Vincent ra...@rab.in --- arch/cris/boot/dts/dev88.dts| 49 + arch/cris

[PATCH 4/6] CRIS v32: add ARTPEC-3 and P1343 device trees

2015-08-03 Thread Rabin Vincent
Add a device tree for the Axis P1343 with the ARTPEC-3 SoC and on-board LEDs and RTC. Signed-off-by: Rabin Vincent ra...@rab.in --- arch/cris/boot/dts/artpec3.dtsi | 46 + arch/cris/boot/dts/p1343.dts| 76 + 2 files changed, 122

[PATCH 1/6] CRIS v32: increase NR_IRQS

2015-08-03 Thread Rabin Vincent
Increase NR_IQRS so we can fit in GPIO interrupts. Signed-off-by: Rabin Vincent ra...@rab.in --- arch/cris/arch-v32/kernel/irq.c | 4 ++-- arch/cris/include/arch-v32/arch/irq.h | 2 +- 2 files changed, 3 insertions(+), 3 deletions(-) diff --git a/arch/cris/arch-v32/kernel/irq.c b/arch

  1   2   3   >