Re: [PATCH v1 1/1] ACPI: Switch to use list_entry_is_head() helper

2022-03-02 Thread Rafael J. Wysocki
On Wed, Mar 2, 2022 at 4:50 PM Andy Shevchenko wrote: > > On Fri, Feb 11, 2022 at 01:04:23PM +0200, Andy Shevchenko wrote: > > Since we got list_entry_is_head() helper in the generic header, > > we may switch the ACPI modules to use it. This eliminates the > > need in additional variable. In some

Re: [PATCH v1 1/1] ACPI: NFIT: Import GUID before use

2021-12-17 Thread Rafael J. Wysocki
On Mon, Dec 13, 2021 at 9:46 PM Andy Shevchenko wrote: > > Strictly speaking the comparison between guid_t and raw buffer > is not correct. Import GUID to variable of guid_t type and then > compare. > > Signed-off-by: Andy Shevchenko Dan, are you going to take care of this or should I? > --- >

Re: [PATCH] base: power: runtime.c: Remove a unnecessary space

2021-04-19 Thread Rafael J. Wysocki
On Sun, Apr 18, 2021 at 11:22 AM Joe Perches wrote: > > On Sun, 2021-04-18 at 09:11 +, Sebastian Fricke wrote: > > Hey Joe, > > Hi Sebastian. > > > On 18.04.2021 00:09, Joe Perches wrote: > > > On Sun, 2021-04-18 at 06:08 +, Sebastian Fricke wrote: > > > > Remove a redundant space to

Re: [PATCH] ACPI: PM: s2idle: Invoke _PTS for s2idle

2021-04-19 Thread Rafael J. Wysocki
On Mon, Apr 19, 2021 at 11:08 AM Kai-Heng Feng wrote: > > HP EliteBook 840 G8 reboots on s2idle resume, and HP EliteBook 845 G8 > wakes up immediately on s2idle. Both are caused by the XMM7360 WWAN PCI > card. > > There's a WWAN specific method to really turn off the WWAN via EC: > Method

Re: [PATCH v1 1/1] PM / wakeup: use dev_set_name() directly

2021-04-15 Thread Rafael J. Wysocki
On Wed, Apr 14, 2021 at 2:53 PM Andy Shevchenko wrote: > > We have open coded dev_set_name() implementation, replace that > with a direct call. > > Signed-off-by: Andy Shevchenko > --- > drivers/base/power/wakeup_stats.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git

[GIT PULL] ACPI fix for v5.12-rc8

2021-04-15 Thread Rafael J. Wysocki
d434405aaab7d0ebc516b68a8fc4100922d7f5ef Linux 5.12-rc7 to receive an ACPI fix for 5.12-rc8. This restores the initrd-based ACPI table override functionality broken by one of the recent fixes. Thanks! --- Rafael J. Wysocki (1): ACPI: x86: Call acpi_boot_table_init() after acpi_table_upgrade

Re: "Reporting issues" document feedback

2021-04-14 Thread Rafael J. Wysocki
On Wed, Apr 14, 2021 at 3:22 PM w4v3 wrote: > > Hi Thorsten, > > Thanks for the quick and illuminating response :) > > > Links to your bug report and the thread on the mailing list would have > > helped here to understand better what's going on, but whatever, they are > > not that important. > >

Re: [PATCH] ACPI: x86: Call acpi_boot_table_init() after acpi_table_upgrade()

2021-04-14 Thread Rafael J. Wysocki
On Wed, Apr 14, 2021 at 10:13 AM Mike Rapoport wrote: > > On Wed, Apr 14, 2021 at 09:42:01AM +0200, David Hildenbrand wrote: > > On 13.04.21 19:53, Rafael J. Wysocki wrote: > > > On Tue, Apr 13, 2021 at 7:43 PM David Hildenbrand > > > wrote: > > > > &g

Re: [PATCH] xen: Remove support for PV ACPI cpu/memory hotplug

2021-04-13 Thread Rafael J. Wysocki
s was > in November 2015 and has gone unnoticed for over 5 year. > > It is now clear that this code is of no interest to anyone and therefore > should be removed. > > Signed-off-by: Boris Ostrovsky Acked-by: Rafael J. Wysocki Thanks for doing this! > --- &g

Re: [PATCH] ACPI: x86: Call acpi_boot_table_init() after acpi_table_upgrade()

2021-04-13 Thread Rafael J. Wysocki
On Tue, Apr 13, 2021 at 7:43 PM David Hildenbrand wrote: > > On 13.04.21 16:01, Rafael J. Wysocki wrote: > > From: Rafael J. Wysocki > > > > Commit 1a1c130ab757 ("ACPI: tables: x86: Reserve memory occupied by > > ACPI tables") attempted to address an issu

[PATCH] ACPI: x86: Call acpi_boot_table_init() after acpi_table_upgrade()

2021-04-13 Thread Rafael J. Wysocki
From: Rafael J. Wysocki Commit 1a1c130ab757 ("ACPI: tables: x86: Reserve memory occupied by ACPI tables") attempted to address an issue with reserving the memory occupied by ACPI tables, but it broke the initrd-based table override mechanism relied on by multiple users. To restore

Re: [PATCH v2 2/2] ACPI: utils: Capitalize abbreviations in the comments

2021-04-13 Thread Rafael J. Wysocki
On Tue, Apr 13, 2021 at 1:21 AM Andy Shevchenko wrote: > > The DSDT and ACPI should be capitalized. > > Signed-off-by: Andy Shevchenko > --- > v2: split from patch 1 as per Rafael's request > drivers/acpi/utils.c | 4 ++-- > 1 file changed, 2 insertions(+), 2 deletions(-) > > diff --git

Re: [PATCH v2 1/1] ACPI: bus: Introduce acpi_dev_get() and reuse it in ACPI code

2021-04-13 Thread Rafael J. Wysocki
On Tue, Apr 13, 2021 at 12:24 AM Andy Shevchenko wrote: > > Introduce acpi_dev_get() to have a symmetrical API with acpi_dev_put() > and reuse both in ACPI code under drivers/acpi folder. > > While at it, use acpi_bus_put_acpi_device() in one place rather than above. > > Signed-off-by: Andy

Re: [PATCH v1 1/1] ACPI: bus: Introduce acpi_dev_get() and reuse it in ACPI code

2021-04-12 Thread Rafael J. Wysocki
On Mon, Apr 12, 2021 at 8:10 PM Andy Shevchenko wrote: > > On Mon, Apr 12, 2021 at 9:05 PM Rafael J. Wysocki wrote: > > > > On Mon, Apr 12, 2021 at 7:47 PM Andy Shevchenko > > wrote: > > > > > > On Mon, Apr 12, 2021 at 8:32 PM Rafael J. Wysocki >

Re: [PATCH v1 1/1] ACPI: bus: Introduce acpi_dev_get() and reuse it in ACPI code

2021-04-12 Thread Rafael J. Wysocki
On Mon, Apr 12, 2021 at 7:47 PM Andy Shevchenko wrote: > > On Mon, Apr 12, 2021 at 8:32 PM Rafael J. Wysocki wrote: > > On Sat, Apr 10, 2021 at 3:47 PM Andy Shevchenko > > wrote: > > ... > > > > static void get_acpi_device(void

Re: [PATCH v1 1/1] ACPI: scan: Utilize match_string() API

2021-04-12 Thread Rafael J. Wysocki
On Sat, Apr 10, 2021 at 4:02 PM Andy Shevchenko wrote: > > We have already an API to match a string in the array of strings. > Utilize it instead of open coded analogues. > > Signed-off-by: Andy Shevchenko > --- > drivers/acpi/scan.c | 22 ++ > 1 file changed, 10

Re: [PATCH v1 1/1] ACPI: bus: Introduce acpi_dev_get() and reuse it in ACPI code

2021-04-12 Thread Rafael J. Wysocki
On Sat, Apr 10, 2021 at 3:47 PM Andy Shevchenko wrote: > > Introduce acpi_dev_get() to have a symmetrical API with acpi_dev_put() > and reuse both in ACPI code under drivers/acpi folder. > > While at it, use acpi_bus_put_acpi_device() in one place rather than above. > > Signed-off-by: Andy

Re: [PATCH v1 1/1] ACPI: utils: Document for_each_acpi_dev_match() macro

2021-04-12 Thread Rafael J. Wysocki
On Sat, Apr 10, 2021 at 3:29 PM Andy Shevchenko wrote: > > The macro requires to call acpi_dev_put() on each iteration. > Due to this it doesn't tolerate sudden disappearence of the devices. > > Document all these nuances to prevent users blindly call it without > understanding the possible

[GIT PULL] ACPI fix for v5.12-rc7

2021-04-09 Thread Rafael J. Wysocki
Hi Linus, Please pull from the tag git://git.kernel.org/pub/scm/linux/kernel/git/rafael/linux-pm.git \ acpi-5.12-rc7 with top-most commit fa26d0c778b432d3d9814ea82552e813b33eeb5c ACPI: processor: Fix build when CONFIG_ACPI_PROCESSOR=m on top of commit

Re: [PATCH 1/6] PM: runtime: enable wake irq after runtime_suspend hook called

2021-04-09 Thread Rafael J. Wysocki
On Fri, Apr 9, 2021 at 10:36 AM Chunfeng Yun wrote: > > On Fri, 2021-04-09 at 08:39 +0300, Tony Lindgren wrote: > > * Chunfeng Yun [210409 01:54]: > > > On Thu, 2021-04-08 at 19:41 +0200, Rafael J. Wysocki wrote: > > > > On Thu, Apr 8, 2021 at 11:3

Re: [GIT PULL] cpuidle for v5.13-rc1

2021-04-08 Thread Rafael J. Wysocki
On Thu, Apr 8, 2021 at 8:02 PM Daniel Lezcano wrote: > > On 08/04/2021 19:24, Rafael J. Wysocki wrote: > > On Thu, Apr 8, 2021 at 5:10 PM Daniel Lezcano > > wrote: > >> > >> > >> Hi Rafael, > >> > >> please consider pul

Re: [PATCH] ACPI / CPPC: Replace cppc_attr with kobj_attribute

2021-04-08 Thread Rafael J. Wysocki
On Wed, Apr 7, 2021 at 11:32 PM Nathan Chancellor wrote: > > All of the CPPC sysfs show functions are called via indirect call in > kobj_attr_show(), where they should be of type > > ssize_t (*show)(struct kobject *kobj, struct kobj_attribute *attr, char *buf); > > because that is the type of the

Re: [PATCH 1/6] PM: runtime: enable wake irq after runtime_suspend hook called

2021-04-08 Thread Rafael J. Wysocki
On Thu, Apr 8, 2021 at 11:35 AM Chunfeng Yun wrote: > > When the dedicated wake irq is level trigger, enable it before > calling runtime_suspend, will trigger an interrupt. > > e.g. > for a low level trigger type, it's low level at running time (0), > and becomes high level when enters suspend

Re: [PATCH -next] PM: fix typos in comments

2021-04-08 Thread Rafael J. Wysocki
On Thu, Apr 8, 2021 at 10:14 AM Lu Jialin wrote: > > Change occured to occurred in kernel/power/autosleep.c. > Change consiting to consisting in kernel/power/snapshot.c. > Change avaiable to available in kernel/power/swap.c. > No functionality changed. > > Signed-off-by: Lu Jialin > --- >

Re: [GIT PULL] devfreq next for v5.13

2021-04-08 Thread Rafael J. Wysocki
On Thu, Apr 8, 2021 at 8:12 AM Chanwoo Choi wrote: > > Dear Rafael, > > This is devfreq-next pull request for v5.13-rc1. I add detailed description of > this pull request on the following tag. Please pull devfreq with following > updates. > - tag name : devfreq-next-for-5.12 > > This pull

Re: [GIT PULL] cpuidle for v5.13-rc1

2021-04-08 Thread Rafael J. Wysocki
On Thu, Apr 8, 2021 at 5:10 PM Daniel Lezcano wrote: > > > Hi Rafael, > > please consider pulling the following change for cpuidle on ARM for > v5.13-rc1 > > Thanks > > -- Daniel > > > The following changes since commit dde8740bd9b505c58ec8b2277d5d55c6951b7e42: > > Merge branch

Re: [PATCH -next] PM: runtime: Replace inline function pm_runtime_callbacks_present()

2021-04-08 Thread Rafael J. Wysocki
On Fri, Apr 2, 2021 at 8:14 AM YueHaibing wrote: > > commit 9a7875461fd0 ("PM: runtime: Replace pm_runtime_callbacks_present()") > forget to change the inline version. > > Fixes: 9a7875461fd0 ("PM: runtime: Replace pm_runtime_callbacks_present()") > Signed-off-by: YueHaibing > --- >

Re: [PATCH -next] freezer: Remove unused inline function try_to_freeze_nowarn()

2021-04-08 Thread Rafael J. Wysocki
On Thu, Apr 1, 2021 at 7:58 PM YueHaibing wrote: > > There is no caller in tree, so can remove it. > > Signed-off-by: YueHaibing > --- > include/linux/freezer.h | 1 - > 1 file changed, 1 deletion(-) > > diff --git a/include/linux/freezer.h b/include/linux/freezer.h > index

Re: [PATCH] linux/intel_rapl.h: Modify struct declaration

2021-04-08 Thread Rafael J. Wysocki
On Tue, Mar 30, 2021 at 8:40 AM Wan Jiabing wrote: > > struct rapl_package is declared twice. One has been declared > at 80th line. > By reviewing the code, it should declare struct rapl_domain > rather than rapl_package. Modify it. > > Signed-off-by: Wan Jiabing > --- >

Re: [PATCH v5 1/1] use crc32 instead of md5 for hibernation e820 integrity check

2021-04-08 Thread Rafael J. Wysocki
On Thu, Apr 8, 2021 at 5:26 PM Eric Biggers wrote: > > On Thu, Apr 08, 2021 at 03:32:38PM +0200, Rafael J. Wysocki wrote: > > On Thu, Apr 8, 2021 at 3:15 PM Chris von Recklinghausen > > wrote: > > > > > > Suspend fails on a system in fips mode because md5

Re: [PATCH v2 1/6] software node: Free resources explicitly when swnode_register() fails

2021-04-08 Thread Rafael J. Wysocki
On Thu, Apr 8, 2021 at 5:18 PM Andy Shevchenko wrote: > > On Thu, Apr 08, 2021 at 05:04:32PM +0200, Rafael J. Wysocki wrote: > > On Thu, Apr 8, 2021 at 4:50 PM Andy Shevchenko > > wrote: > > > On Thu, Apr 08, 2021 at 04:15:37PM +0200, Rafael J. Wysocki wrote: > >

Re: [PATCH v2] ACPI / hotplug / PCI: fix memory leak in enable_slot()

2021-04-08 Thread Rafael J. Wysocki
returns a PCI device. > > Signed-off-by: Feilong Lin > Signed-off-by: Zhiqiang Liu > -- > v2: rewrite subject and commit log as suggested by Bjorn Helgaas. The fix is correct AFAICS, so Reviewed-by: Rafael J. Wysocki Bjorn, has this been applied already? If not, do you want me

Re: [PATCH v2 1/6] software node: Free resources explicitly when swnode_register() fails

2021-04-08 Thread Rafael J. Wysocki
On Thu, Apr 8, 2021 at 4:50 PM Andy Shevchenko wrote: > > On Thu, Apr 08, 2021 at 04:15:37PM +0200, Rafael J. Wysocki wrote: > > On Wed, Mar 31, 2021 at 1:06 PM Heikki Krogerus > > wrote: > > > > > > On Mon, Mar 29, 2021 at 06:12:02PM +0300, Andy Shevche

Re: [PATCH v3 00/12] acpi: fix some coding style issues

2021-04-08 Thread Rafael J. Wysocki
On Sat, Mar 27, 2021 at 1:11 PM Xiaofei Tan wrote: > > Fix some coding style issues reported by checkpatch.pl. > Only cleanup and no function changes. > > Differences from v2 to v3: > - Remove the modifications that may cause function change. > > Differences from v1 to v2: > - Add subsystem and

Re: [PATCH v2] ACPI: AC: fix some coding style issues

2021-04-08 Thread Rafael J. Wysocki
On Sat, Mar 27, 2021 at 4:50 AM Xiaofei Tan wrote: > > Fix some coding style issues reported by checkpatch.pl, including > following types: > > ERROR: "foo * bar" should be "foo *bar" > ERROR: code indent should use tabs where possible > WARNING: Block comments use a trailing */ on a separate

Re: [PATCH v2 1/6] software node: Free resources explicitly when swnode_register() fails

2021-04-08 Thread Rafael J. Wysocki
On Wed, Mar 31, 2021 at 1:06 PM Heikki Krogerus wrote: > > On Mon, Mar 29, 2021 at 06:12:02PM +0300, Andy Shevchenko wrote: > > Currently we have a slightly twisted logic in swnode_register(). > > It frees resources that it doesn't allocate on error path and > > in once case it relies on the

Re: [PATCH v5 1/1] use crc32 instead of md5 for hibernation e820 integrity check

2021-04-08 Thread Rafael J. Wysocki
On Thu, Apr 8, 2021 at 3:15 PM Chris von Recklinghausen wrote: > > Suspend fails on a system in fips mode because md5 is used for the e820 > integrity check and is not available. Use crc32 instead. > > This patch changes the integrity check algorithm from md5 to > crc32. This integrity check is

Re: [PATCH v1 0/5] cpuidle: Take possible negative "sleep length" values into account

2021-04-07 Thread Rafael J. Wysocki
On Mon, Mar 29, 2021 at 8:38 PM Rafael J. Wysocki wrote: > > Hi All, > > As follows from the discussion triggered by the patch at > > https://lore.kernel.org/lkml/20210311123708.23501-2-frede...@kernel.org/ > > the cpuidle governors using tick_nohz_get_sleep_length() assu

Re: [PATCH 3/7] PM: runtime: remove kernel-doc warnings

2021-04-07 Thread Rafael J. Wysocki
On Thu, Apr 1, 2021 at 4:13 PM Pierre-Louis Bossart wrote: > > > > On 4/1/21 8:40 AM, Rafael J. Wysocki wrote: > > On Thu, Apr 1, 2021 at 1:26 AM Pierre-Louis Bossart > > wrote: > >> > >> remove make W=1 warnings > >> > >> d

Re: [PATCH] include: linux: pm: Remove duplicate declaration

2021-04-07 Thread Rafael J. Wysocki
On Wed, Mar 24, 2021 at 8:30 AM Wan Jiabing wrote: > > struct device is declared twice.So remove the duplicate. > > Signed-off-by: Wan Jiabing > --- > include/linux/pm.h | 1 - > 1 file changed, 1 deletion(-) > > diff --git a/include/linux/pm.h b/include/linux/pm.h > index

Re: [PATCH v3] ACPI: processor: Fix build when CONFIG_ACPI_PROCESSOR=m

2021-04-07 Thread Rafael J. Wysocki
n into a > new function and exporting it instead is better. > > Reported-by: kernel test robot > Fixes: 8c182bd7 ("CPI: processor: Fix CPU0 wakeup in > acpi_idle_play_dead()") > Cc: # 5.10+ > Signed-off-by: Vitaly Kuznetsov Applied as 5.12-rc material, thanks!

[PATCH v1 0/5] ACPI: scan: acpi_bus_check_add() simplifications

2021-04-07 Thread Rafael J. Wysocki
Hi, This series simplifies acpi_bus_check_add() and related code. It mostly is not expected to alter functionality, except for patch [4/5] that unifies the handling of device and processor objects. Please refer to the patch changelogs for details. Thanks!

[PATCH v1 1/5] ACPI: scan: Fold acpi_bus_type_and_status() into its caller

2021-04-07 Thread Rafael J. Wysocki
From: Rafael J. Wysocki There is only one caller of acpi_bus_type_and_status() which is acpi_bus_check_add(), so fold the former into the latter and use the observation that the initial status of the device is ACPI_STA_DEFAULT in all cases except for ACPI_BUS_TYPE_PROCESSOR to simplify the code

[PATCH v1 2/5] ACPI: scan: Rearrange checks in acpi_bus_check_add()

2021-04-07 Thread Rafael J. Wysocki
From: Rafael J. Wysocki Rearrange the checks in acpi_bus_check_add() to avoid checking the "type" twice and take "check_dep" into account only for ACPI_TYPE_DEVICE objects. No intentional functional impact. Signed-off-by: Rafael J. Wysocki --- driver

[PATCH v1 3/5] ACPI: scan: Drop sta argument from acpi_add_single_object()

2021-04-07 Thread Rafael J. Wysocki
From: Rafael J. Wysocki Move the initial status check for ACPI_BUS_TYPE_PROCESSOR objects into acpi_add_single_object() so it is not necessary to pass the "sta" argument to it, get rid of that argument from there and update the callers of that function accordingly. No intentional

[PATCH v1 4/5] ACPI: scan: Drop sta argument from acpi_init_device_object()

2021-04-07 Thread Rafael J. Wysocki
From: Rafael J. Wysocki Use the observation that the initial status check for ACPI_BUS_TYPE_PROCESSOR objects can be carried out in the same way as for ACPI_BUS_TYPE_DEVICE objects and it is not necessary to fail acpi_add_single_object() if acpi_bus_get_status_handle() returns an error

[PATCH v1 5/5] ACPI: scan: Call acpi_get_object_info() from acpi_set_pnp_ids()

2021-04-07 Thread Rafael J. Wysocki
From: Rafael J. Wysocki Notice that it is not necessary to call acpi_get_object_info() from acpi_add_single_object() in order to pass the pointer returned by it to acpi_init_device_object() and from there to acpi_set_pnp_ids(). It is more straightforward to call acpi_get_object_info() from

[PATCH] cpufreq: intel_pstate: Simplify intel_pstate_update_perf_limits()

2021-04-07 Thread Rafael J. Wysocki
From: Rafael J. Wysocki Because pstate.max_freq is always equal to the product of pstate.max_pstate and pstate.scaling and, analogously, pstate.turbo_freq is always equal to the product of pstate.turbo_pstate and pstate.scaling, the result of the max_policy_perf computation

Re: [PATCH] resource: Prevent irqresource_disabled() from erasing flags

2021-04-07 Thread Rafael J. Wysocki
On Wed, Apr 7, 2021 at 1:01 PM Angela Czubak wrote: > > On Tue, Mar 30, 2021 at 5:50 PM Mika Westerberg > wrote: > > > > Hi, > > > > On Tue, Mar 30, 2021 at 05:09:42PM +0200, Rafael J. Wysocki wrote: > > > On 3/29/2021 9:52 PM, Angela Czubak wrote:

Re: [bug report] Memory leak from acpi_ev_install_space_handler()

2021-04-06 Thread Rafael J. Wysocki
On Tue, Apr 6, 2021 at 5:51 PM John Garry wrote: > > Hi guys, > > On next-20210406, I enabled CONFIG_DEBUG_KMEMLEAK and > CONFIG_DEBUG_TEST_DRIVER_REMOVE for my arm64 system, and see this: Why exactly do you think that acpi_ev_install_space_handler() leaks memory? > root@debian:/home/john# more

Re: [PATCH v2] ACPI: processor: Fix build when CONFIG_ACPI_PROCESSOR=m

2021-04-06 Thread Rafael J. Wysocki
On Tue, Apr 6, 2021 at 5:39 PM Vitaly Kuznetsov wrote: > > "Rafael J. Wysocki" writes: > > > On Tue, Apr 6, 2021 at 4:01 PM Vitaly Kuznetsov wrote: > >> > >> Commit 8c182bd7 ("ACPI: processor: Fix CPU0 wakeup in > >> acpi_idle_pl

Re: [PATCH v2] ACPI: processor: Fix build when CONFIG_ACPI_PROCESSOR=m

2021-04-06 Thread Rafael J. Wysocki
me wakeup_cpu0() to cond_wakeup_cpu0() and fold wakeup_cpu0() in > as it has no other users [Rafael J. Wysocki] > --- > arch/x86/include/asm/smp.h| 2 +- > arch/x86/kernel/smpboot.c | 24 ++-- > drivers/acpi/processor_idle.c | 4 +--- > 3 files ch

Re: [PATCH] ACPI: processor: Fix build when CONFIG_ACPI_PROCESSOR=m

2021-04-06 Thread Rafael J. Wysocki
On Tue, Apr 6, 2021 at 2:50 PM Vitaly Kuznetsov wrote: > > Commit 8c182bd7 ("ACPI: processor: Fix CPU0 wakeup in > acpi_idle_play_dead()") tried to fix CPU0 hotplug breakage by copying > wakeup_cpu0() + start_cpu0() logic from hlt_play_dead()//mwait_play_dead() > into acpi_idle_play_dead().

Re: linux-next: build warning after merge of the pm tree

2021-04-02 Thread Rafael J. Wysocki
On Wednesday, March 31, 2021 8:22:54 AM CEST Vitaly Kuznetsov wrote: > Stephen Rothwell writes: > > > Hi all, > > > > After merging the pm tree, today's linux-next build (x86_64 allmodconfig) > > produced this warning: > > > > drivers/acpi/processor_idle.c: In function 'acpi_idle_play_dead': > >

[GIT PULL] Power management fixes for v5.12-rc6

2021-04-02 Thread Rafael J. Wysocki
Hi Linus, Please pull from the tag git://git.kernel.org/pub/scm/linux/kernel/git/rafael/linux-pm.git \ pm-5.12-rc6 with top-most commit ac1790ad78f8f0cf9a588ffb530c700ad758e8b6 Merge branch 'pm-cpufreq' on top of commit a5e13c6df0e41702d2b2c77c8ad41677ebb065b3 Linux 5.12-rc5 to receive

Re: [PATCH 1/1] use crc32 instead of md5 for hibernation e820 integrity check

2021-04-01 Thread Rafael J. Wysocki
On Thu, Apr 1, 2021 at 3:34 PM Rafael J. Wysocki wrote: > > On Thu, Apr 1, 2021 at 2:25 PM Chris von Recklinghausen > wrote: > > > > Suspend fails on a system in fips mode because md5 is used for the e820 > > integrity check and is not available. Use crc32 instead.

Re: Fix hibernation in FIPS mode?

2021-04-01 Thread Rafael J. Wysocki
On Thu, Apr 1, 2021 at 3:54 PM Ard Biesheuvel wrote: > > On Thu, 1 Apr 2021 at 15:38, Rafael J. Wysocki wrote: > > > > On Thu, Apr 1, 2021 at 10:47 AM Ard Biesheuvel wrote: > > > > > > On Tue, 30 Mar 2021 at 21:56, Simo Sorce wrote: > > > >

Re: [PATCH 3/7] PM: runtime: remove kernel-doc warnings

2021-04-01 Thread Rafael J. Wysocki
On Thu, Apr 1, 2021 at 1:26 AM Pierre-Louis Bossart wrote: > > remove make W=1 warnings > > drivers/base/power/runtime.c:926: warning: Function parameter or > member 'timer' not described in 'pm_suspend_timer_fn' > > drivers/base/power/runtime.c:926: warning: Excess function parameter > 'data'

Re: Fix hibernation in FIPS mode?

2021-04-01 Thread Rafael J. Wysocki
On Thu, Apr 1, 2021 at 10:47 AM Ard Biesheuvel wrote: > > On Tue, 30 Mar 2021 at 21:56, Simo Sorce wrote: > > > > On Tue, 2021-03-30 at 21:45 +0200, Ard Biesheuvel wrote: > > > On Tue, 30 Mar 2021 at 20:05, Simo Sorce wrote: > > > > On Tue, 2021-03-30

Re: Fix hibernation in FIPS mode?

2021-04-01 Thread Rafael J. Wysocki
On Thu, Apr 1, 2021 at 6:22 PM Simo Sorce wrote: > > On Thu, 2021-04-01 at 18:02 +0200, Rafael J. Wysocki wrote: > > On Thu, Apr 1, 2021 at 3:54 PM Ard Biesheuvel wrote: > > > On Thu, 1 Apr 2021 at 15:38, Rafael J. Wysocki wrote: > > > > On Thu, Apr 1, 2021

Re: [PATCH] drivers core: don't do anything in device_del() when device_add() fail

2021-04-01 Thread Rafael J. Wysocki
On Thu, Apr 1, 2021 at 2:56 PM Yufen Yu wrote: > > Recently, our syzbot test reported NULL pointer dereference in > device_del() by injecting memory allocation fail in device_add(). > > For now, callers of device_add(), such as add_disk(), may ignore > device_add()'s fail and go on working. In

Re: [PATCH 1/1] use crc32 instead of md5 for hibernation e820 integrity check

2021-04-01 Thread Rafael J. Wysocki
On Thu, Apr 1, 2021 at 3:59 PM Ard Biesheuvel wrote: > > On Thu, 1 Apr 2021 at 15:34, Rafael J. Wysocki wrote: > > > > On Thu, Apr 1, 2021 at 2:25 PM Chris von Recklinghausen > > wrote: > > > > > > Suspend fails on a system in fips mode because md5

Re: [PATCH v2 04/15] ACPI: table: replace __attribute__((packed)) by __packed

2021-04-01 Thread Rafael J. Wysocki
On Thu, Apr 1, 2021 at 11:00 AM David Laight wrote: > > From: Bjorn Helgaas > > Sent: 31 March 2021 18:22 > > > > On Wed, Mar 31, 2021 at 11:55:08PM +0800, Zhang Rui wrote: > > > ... > > > > > From e18c942855e2f51e814d057fff4dd951cd0d0907 Mon Sep 17 00:00:00 2001 > > > From: Zhang Rui > > >

Re: [PATCH 1/1] use crc32 instead of md5 for hibernation e820 integrity check

2021-04-01 Thread Rafael J. Wysocki
On Thu, Apr 1, 2021 at 2:25 PM Chris von Recklinghausen wrote: > > Suspend fails on a system in fips mode because md5 is used for the e820 > integrity check and is not available. Use crc32 instead. > > Fixes: 62a03defeabd ("PM / hibernate: Verify the consistent of e820 memory map >by md5

Re: [PATCH v2 04/15] ACPI: table: replace __attribute__((packed)) by __packed

2021-04-01 Thread Rafael J. Wysocki
On Thu, Apr 1, 2021 at 4:23 PM David Laight wrote: > > From: Rafael J. Wysocki > > Sent: 01 April 2021 14:50 > ... > > So what exactly is wrong with using "packed"? It is way easier to > > understand for a casual reader of the code. > >

Re: [PATCH] PCI: ACPI: PM: Fix debug message in acpi_pci_set_power_state()

2021-04-01 Thread Rafael J. Wysocki
On Wed, Mar 31, 2021 at 11:09 PM Bjorn Helgaas wrote: > > On Thu, Mar 25, 2021 at 07:57:51PM +0100, Rafael J. Wysocki wrote: > > From: Rafael J. Wysocki > > > > If PCI_D3cold is passed to acpi_pci_set_power_state() as the second > > argument and there is no ACP

Re: linux-next: Tree for Mar 31 (acpi build warning)

2021-03-31 Thread Rafael J. Wysocki
On Wed, Mar 31, 2021 at 5:32 PM Randy Dunlap wrote: > > On 3/31/21 2:43 AM, Stephen Rothwell wrote: > > Hi all, > > > > News: there will be no linux-next release on Friday or the following > > Monday. > > > > Changes since 20210330: > > > > ../drivers/acpi/processor_idle.c:542:15: warning: extra

Re: [PATCH] ACPI: processor: Fix build when !CONFIG_HOTPLUG_CPU

2021-03-30 Thread Rafael J. Wysocki
On Tue, Mar 30, 2021 at 12:27 PM Vitaly Kuznetsov wrote: > > Kernel test robot reports build breakage with commit 5f5e49e999ac > ("ACPI: processor: Fix CPU0 wakeup in acpi_idle_play_dead()") when > !CONFIG_HOTPLUG_CPU/!CONFIG_SMP. wakeup_cpu0() is defined under > CONFIG_SMP and start_cpu0() under

Re: [PATCH v2 04/15] ACPI: table: replace __attribute__((packed)) by __packed

2021-03-30 Thread Rafael J. Wysocki
On Tue, Mar 30, 2021 at 10:15 AM David Laight wrote: > > From: Zhang Rui > > Sent: 30 March 2021 09:00 > > To: Xiaofei Tan ; David Laight > > ; r...@rjwysocki.net; > > l...@kernel.org; bhelg...@google.com > > Cc: linux-a...@vger.kernel.org; linux-kernel@vger.kernel.org; > >

Re: [PATCH] resource: Prevent irqresource_disabled() from erasing flags

2021-03-30 Thread Rafael J. Wysocki
On 3/29/2021 9:52 PM, Angela Czubak wrote: Do not overwrite flags as it leads to erasing triggering and polarity information which might be useful in case of hard-coded interrupts. This way the information can be read later on even though mapping to APIC domain failed. Signed-off-by: Angela

Re: [PATCH v1 5/5] cpuidle: menu: Take negative "sleep length" values into account

2021-03-30 Thread Rafael J. Wysocki
On Tue, Mar 30, 2021 at 4:00 AM Zhou Ti (x2019cwm) wrote: > > On Mon 2021-03-29 14:37 Rafael J. Wysocki wrote: > > Make the menu governor check the tick_nohz_get_next_hrtimer() > > return value so as to avoid dealing with negative "sleep length" > > values and ma

Re: Fix hibernation in FIPS mode?

2021-03-30 Thread Rafael J. Wysocki
On Tue, Mar 30, 2021 at 12:14 AM Dexuan Cui wrote: > > Hi, > MD5 was marked incompliant with FIPS in 2009: > a3bef3a31a19 ("crypto: testmgr - Skip algs not flagged fips_allowed in fips > mode") > a1915d51e8e7 ("crypto: testmgr - Mark algs allowed in fips mode") > > But hibernation_e820_save() is

Re: [Devel] Re: [PATCH] ACPICA: Fix a typo

2021-03-30 Thread Rafael J. Wysocki
On Tue, Mar 30, 2021 at 2:19 AM Kaneda, Erik wrote: > > > > > -Original Message- > > From: Rafael J. Wysocki > > Sent: Monday, March 29, 2021 5:48 AM > > To: Bhaskar Chowdhury ; Kaneda, Erik > > > > Cc: Wysocki, Rafael J ; ACPI Dev

[PATCH v1 1/5] tick/nohz: Improve tick_nohz_get_next_hrtimer() kerneldoc

2021-03-29 Thread Rafael J. Wysocki
From: "Rafael J. Wysocki" Make the tick_nohz_get_next_hrtimer() kerneldoc comment state clearly that the function may return negative numbers. Signed-off-by: Rafael J. Wysocki --- kernel/time/tick-sched.c |6 +- 1 file changed, 5 insertions(+), 1 deletion(-) Index: linux

[PATCH v1 0/5] cpuidle: Take possible negative "sleep length" values into account

2021-03-29 Thread Rafael J. Wysocki
Hi All, As follows from the discussion triggered by the patch at https://lore.kernel.org/lkml/20210311123708.23501-2-frede...@kernel.org/ the cpuidle governors using tick_nohz_get_sleep_length() assume it to always return positive values which is not correct in general. To address this issues,

[RFC][PATCH 1/5] tick/nohz: Improve tick_nohz_get_next_hrtimer() kerneldoc

2021-03-29 Thread Rafael J. Wysocki
From: "Rafael J. Wysocki" Make the tick_nohz_get_next_hrtimer() kerneldoc comment state clearly that the function may return negative numbers. Signed-off-by: Rafael J. Wysocki --- kernel/time/tick-sched.c |6 +- 1 file changed, 5 insertions(+), 1 deletion(-) Index: linux

[PATCH v1 4/5] cpuidle: teo: Take negative "sleep length" values into account

2021-03-29 Thread Rafael J. Wysocki
From: "Rafael J. Wysocki" Modify the TEO governor to take possible negative return values of tick_nohz_get_next_hrtimer() into account by changing the data type of some variables used by it to s64 which allows it to carry out computations without potentially problematic data type c

[PATCH v1 2/5] cpuidle: Use s64 as exit_latency_ns and target_residency_ns data type

2021-03-29 Thread Rafael J. Wysocki
From: "Rafael J. Wysocki" Subsequent changes will cause the exit_latency_ns and target_residency_ns fields in struct cpuidle_state to be used in computations in which data type conversions to u64 may turn a negative number close to zero into a verly large positive number leading to

[PATCH v1 3/5] cpuidle: teo: Adjust handling of very short idle times

2021-03-29 Thread Rafael J. Wysocki
From: "Rafael J. Wysocki" If the time till the next timer event is shorter than the target residency of the first idle state (state 0), the TEO governor does not update its metrics for any idle states, but arguably it should record a "hit" for idle state 0 in that case

[PATCH v1 5/5] cpuidle: menu: Take negative "sleep length" values into account

2021-03-29 Thread Rafael J. Wysocki
From: "Rafael J. Wysocki" Subject: [PATCH] cpuidle: menu: Take negative "sleep length" values into account Make the menu governor check the tick_nohz_get_next_hrtimer() return value so as to avoid dealing with negative "sleep length" values and make it use tha

Re: [PATCH] ACPI: processor: Fix CPU0 wakeup in acpi_idle_play_dead()

2021-03-29 Thread Rafael J. Wysocki
On Wed, Mar 24, 2021 at 4:37 PM Rafael J. Wysocki wrote: > > On Wed, Mar 24, 2021 at 4:23 PM Vitaly Kuznetsov wrote: > > > > Commit 496121c02127 ("ACPI: processor: idle: Allow probing on platforms > > with one ACPI C-state") broke CPU0 hotplug on certa

Re: [PATCH v3 00/12] acpi: fix some coding style issues

2021-03-29 Thread Rafael J. Wysocki
On Sat, Mar 27, 2021 at 1:11 PM Xiaofei Tan wrote: > > Fix some coding style issues reported by checkpatch.pl. > Only cleanup and no function changes. > > Differences from v2 to v3: > - Remove the modifications that may cause function change. > > Differences from v1 to v2: > - Add subsystem and

Re: [PATCH] ACPICA: Fix a typo

2021-03-29 Thread Rafael J. Wysocki
On Fri, Mar 26, 2021 at 1:22 AM Bhaskar Chowdhury wrote: > > > s/optimzation/optimization/ > > Signed-off-by: Bhaskar Chowdhury > --- > include/acpi/acoutput.h | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/include/acpi/acoutput.h b/include/acpi/acoutput.h > index

Re: 回复: [PATCH 01/10] tick/nohz: Prevent tick_nohz_get_sleep_length() from returning negative value

2021-03-29 Thread Rafael J. Wysocki
On Fri, Mar 26, 2021 at 11:53 PM Zhou Ti (x2019cwm) wrote: > > On Fri, 26 Mar 2021 19:54:26 +0100, Rafael J. Wysocki wrote: > > On Fri, Mar 26, 2021 at 6:53 PM Zhou Ti (x2019cwm) wrote: > > > > > > On Fri, 26 Mar 2021 18:01:47 +0100, Rafael J. Wysocki wrote: > &

Re: 回复: [PATCH 01/10] tick/nohz: Prevent tick_nohz_get_sleep_length() from returning negative value

2021-03-26 Thread Rafael J. Wysocki
On Fri, Mar 26, 2021 at 6:53 PM Zhou Ti (x2019cwm) wrote: > > On Fri, 26 Mar 2021 18:01:47 +0100, Rafael J. Wysocki wrote: > > On Thu, Mar 25, 2021 at 9:37 PM Zhou Ti (x2019cwm) wrote: > > > > > > On March 25, 2021 15:50, Rafael J. Wysocki wrote: > > > &g

Re: 回复: [PATCH 01/10] tick/nohz: Prevent tick_nohz_get_sleep_length() from returning negative value

2021-03-26 Thread Rafael J. Wysocki
On Thu, Mar 25, 2021 at 9:37 PM Zhou Ti (x2019cwm) wrote: > > On March 25, 2021 15:50, Rafael J. Wysocki wrote: > > On Thu, Mar 25, 2021 at 8:18 PM Zhou Ti (x2019cwm) wrote: > > > > > > On March 25, 2021 14:56, Rafael J. Wysocki wrote: > > > > On Thursd

Re: [PATCH] thermal/drivers/netlink: Add the temperature when crossing a trip point

2021-03-26 Thread Rafael J. Wysocki
On Thu, Mar 25, 2021 at 8:38 PM Daniel Lezcano wrote: > > The slope of the temperature increase or decrease can be high and when > the temperature crosses the trip point, there could be a significant > difference between the trip temperature and the measured temperatures. > > That forces the

[GIT PULL] ACPI fixes for v5.12-rc5

2021-03-26 Thread Rafael J. Wysocki
Hi Linus, Please pull from the tag git://git.kernel.org/pub/scm/linux/kernel/git/rafael/linux-pm.git \ acpi-5.12-rc5 with top-most commit e1db18b59729e24f001459b98955019344d5b12b Merge branches 'acpi-video' and 'acpi-scan' on top of commit 0d02ec6b3136c73c09e7859f0d0e4e2c4c07b49b Linux

[GIT PULL] Power management fixes for v5.12-rc5

2021-03-26 Thread Rafael J. Wysocki
to RPM_SUSPENDED (Rafael Wysocki). - Change the Energy Model code to prevent it from attempting to create its main debugfs directory too early (Lukasz Luba). Thanks! --- Lukasz Luba (1): PM: EM: postpone creating the debugfs dir till fs_initcall Rafael J. Wysocki (1): PM

Re: 回复: [PATCH 01/10] tick/nohz: Prevent tick_nohz_get_sleep_length() from returning negative value

2021-03-25 Thread Rafael J. Wysocki
On Thu, Mar 25, 2021 at 8:18 PM Zhou Ti (x2019cwm) wrote: > > On March 25, 2021 14:56, Rafael J. Wysocki wrote: > > On Thursday, March 25, 2021 2:14:00 PM CET Frederic Weisbecker wrote: > > > On Tue, Mar 16, 2021 at 04:08:08PM +, Zhou Ti (x2019cwm) wrote: > > > &

[PATCH] PCI: ACPI: PM: Fix debug message in acpi_pci_set_power_state()

2021-03-25 Thread Rafael J. Wysocki
From: Rafael J. Wysocki If PCI_D3cold is passed to acpi_pci_set_power_state() as the second argument and there is no ACPI D3cold support for the given device, the debug message printed by that function will state that the device power state has been changed to D3cold, while in fact

Re: 回复: [PATCH 01/10] tick/nohz: Prevent tick_nohz_get_sleep_length() from returning negative value

2021-03-25 Thread Rafael J. Wysocki
On Thursday, March 25, 2021 2:14:00 PM CET Frederic Weisbecker wrote: > On Tue, Mar 16, 2021 at 04:08:08PM +, Zhou Ti (x2019cwm) wrote: > > But I don't think it's a good idea to handle this in callers, because > > logically the function shouldn't return negative values. Returning 0 > >

Re: [PATCH 1/4] PCI: acpi_pcihp: Correct acpi_pci_check_ejectable() function name in the header

2021-03-25 Thread Rafael J. Wysocki
On Thu, Mar 25, 2021 at 8:50 AM Xiongfeng Wang wrote: > > Fixes the following W=1 kernel build warning(s): > > drivers/pci/hotplug/acpi_pcihp.c:167: warning: expecting prototype for > acpi_pcihp_check_ejectable(). Prototype was for acpi_pci_check_ejectable() > instead > > Reported-by: Hulk

Re: [PATCH 2/4] PCI/AER: Correct function names in the header

2021-03-25 Thread Rafael J. Wysocki
On Thu, Mar 25, 2021 at 8:50 AM Xiongfeng Wang wrote: > > Fixes the following W=1 kernel build warning(s): > > drivers/pci/pcie/aer.c:138: warning: expecting prototype for > enable_ercr_checking(). Prototype was for enable_ecrc_checking() instead > drivers/pci/pcie/aer.c:162: warning:

Re: [PATCH] ACPI: AC: fix some errors and warnings reported by checkpatch.pl

2021-03-24 Thread Rafael J. Wysocki
On Tue, Mar 23, 2021 at 2:01 PM Xiaofei Tan wrote: > > Fix some errors and warnings reported by checkpatch.pl, including > following five types: Well, they are coding style issues rather than errors. > ERROR: "foo * bar" should be "foo *bar" > ERROR: code indent should use tabs where possible >

Re: [PATCH] ACPI: tables: x86: Reserve memory occupied by ACPI tables

2021-03-24 Thread Rafael J. Wysocki
On Wed, Mar 24, 2021 at 4:42 PM George Kennedy wrote: > > > > On 3/24/2021 9:27 AM, Rafael J. Wysocki wrote: > > On Wed, Mar 24, 2021 at 9:24 AM Mike Rapoport wrote: > >> On Tue, Mar 23, 2021 at 08:26:52PM +0100, Rafael J. Wysocki wrote: > >>> From: Rafae

Re: [PATCH] PCI: PM: Do not read power state in pci_enable_device_flags()

2021-03-24 Thread Rafael J. Wysocki
On Mon, Mar 22, 2021 at 3:32 PM Rafael J. Wysocki wrote: > > On Tue, Mar 16, 2021 at 4:52 PM Rafael J. Wysocki wrote: > > > > From: Rafael J. Wysocki > > > > It should not be necessary to update the current_state field of > > struct pci_dev in pci_

Re: [PATCH] ACPI: processor: Fix CPU0 wakeup in acpi_idle_play_dead()

2021-03-24 Thread Rafael J. Wysocki
On Wed, Mar 24, 2021 at 4:23 PM Vitaly Kuznetsov wrote: > > Commit 496121c02127 ("ACPI: processor: idle: Allow probing on platforms > with one ACPI C-state") broke CPU0 hotplug on certain systems, e.g. > I'm observing the following on AWS Nitro (e.g r5b.xlarge but other > instance types are

Re: [PATCH] ACPI: tables: x86: Reserve memory occupied by ACPI tables

2021-03-24 Thread Rafael J. Wysocki
On Wed, Mar 24, 2021 at 9:24 AM Mike Rapoport wrote: > > On Tue, Mar 23, 2021 at 08:26:52PM +0100, Rafael J. Wysocki wrote: > > From: Rafael J. Wysocki > > > > The following problem has been reported by George Kennedy: > > > > Since commit 7fef431be9c9

[PATCH] ACPI: tables: x86: Reserve memory occupied by ACPI tables

2021-03-23 Thread Rafael J. Wysocki
From: Rafael J. Wysocki The following problem has been reported by George Kennedy: Since commit 7fef431be9c9 ("mm/page_alloc: place pages to tail in __free_pages_core()") the following use after free occurs intermittently when ACPI tables are accessed. BUG: KASAN: use-

  1   2   3   4   5   6   7   8   9   10   >