Re: [PATCH] cpuidle: Add 'above' and 'below' idle state metrics

2018-12-07 Thread Rafael J. Wysocki
On Friday, December 7, 2018 1:02:05 PM CET Quentin Perret wrote: > Hi Rafael, > > On Friday 07 Dec 2018 at 12:57:00 (+0100), Rafael J. Wysocki wrote: > > --- linux-pm.orig/Documentation/ABI/testing/sysfs-devices-system-cpu > > +++ linux-pm/Documentation/ABI/testing/sys

Re: [RFC/RFT,v7] cpuidle: New timer events oriented governor for tickless systems

2018-12-07 Thread Rafael J. Wysocki
On Fri, Dec 7, 2018 at 9:00 AM Chen, Hu wrote: > > From: Chen Hu > > Hi Rafael, > > I run several popular Android performance benchmarks on teov7, using kernel > 4.19.0 as my baseline because I happen to work on it. To backport teov7 to > kernel 4.19.0, I also backport patch 5f26bdc: "cpuidle:

Re: Linux 4.20-rc5: Lab setup broken by build-related x86 change

2018-12-06 Thread Rafael J. Wysocki
On Wednesday, December 5, 2018 3:33:03 PM CET Borislav Petkov wrote: > On Wed, Dec 05, 2018 at 01:15:10PM +0100, Rafael J. Wysocki wrote: > > After commit > > > > commit 4cd24de3a0980bf3100c9dcb08ef65ca7c31af48 > > Author: Zhenzhong Duan > > Date: Fri Nov 2 01:

Re: [PATCH][next] drivers: base: remove need for a temporary string for the node name

2018-12-06 Thread Rafael J. Wysocki
On Thu, Dec 6, 2018 at 3:57 PM Greg Kroah-Hartman wrote: > > On Thu, Nov 29, 2018 at 06:08:44PM +, Colin King wrote: > > From: Colin Ian King > > > > Currently the node name is being formatting into a temporary string > > node_name, however, kobject_init_and_add allows one to format up > > a

Re: [RFC/RFT][PATCH v6] cpuidle: New timer events oriented governor for tickless systems

2018-12-06 Thread Rafael J. Wysocki
On Thu, Dec 6, 2018 at 12:06 AM Doug Smythies wrote: > > On 2018.12.03 03:48 Rafael J. Wysocki wrote: > > >>> There is an additional issue where if idle state 0 is disabled (with the > >>> above suggested code patch), > >>> idle state usage see

Re: [PATCH] x86/kernel: Fix more -Wmissing-prototypes warnings

2018-12-05 Thread Rafael J. Wysocki
hrough includes. > > asm/trace/ changes courtesy of Steven Rostedt . > > Signed-off-by: Borislav Petkov Acked-by: Rafael J. Wysocki for the ACPI and cpufreq bits.

Re: Linux 4.20-rc5: Lab setup broken by build-related x86 change

2018-12-05 Thread Rafael J. Wysocki
On Monday, December 3, 2018 12:30:24 AM CET Linus Torvalds wrote: > Hmm.. I'd like to say it was a normal week, but I'd be lying. rc5 is > the biggest rc so far (with the obvious exception of rc1), and it > looks fairly unusual in the diffstat too, with almost a third being > arch updates. Yes,

[GIT PULL] Power management fix for v4.20-rc6

2018-12-05 Thread Rafael J. Wysocki
Linux 4.20-rc5 to receive a power management fix for 4.20-rc6. This reverts a problematic recent commit that attempted to fix a system-wide suspend issue related to the freezer. Thanks! ------- Rafael J. Wysocki (1): Revert "exec: make de_thread() freezable" ---

Re: [PATCH 05/12] PCI: aardvark: add suspend to RAM support

2018-12-04 Thread Rafael J. Wysocki
On Tuesday, December 4, 2018 10:45:58 AM CET Lorenzo Pieralisi wrote: > On Mon, Dec 03, 2018 at 11:00:20PM +0100, Rafael J. Wysocki wrote: > > On Monday, December 3, 2018 4:38:46 PM CET Miquel Raynal wrote: > > > Hi Lorenzo, > > > > > > Lorenzo Pieralisi wro

[RFC/RFT][PATCH v7] cpuidle: New timer events oriented governor for tickless systems

2018-12-04 Thread Rafael J. Wysocki
From: Rafael J. Wysocki The venerable menu governor does some thigns that are quite questionable in my view. First, it includes timer wakeups in the pattern detection data and mixes them up with wakeups from other sources which in some cases causes it to expect what essentially would be a timer

Re: [Bug] SD card reader in Acer Aspire S5 broken in 4.20-rc

2018-12-04 Thread Rafael J. Wysocki
On Tuesday, December 4, 2018 1:10:09 AM CET Bjorn Helgaas wrote: > On Wed, Nov 28, 2018 at 02:05:21PM -0600, Bjorn Helgaas wrote: > > On Wed, Nov 28, 2018 at 6:13 AM Rafael J. Wysocki > > wrote: > > > On Tuesday, November 27, 2018 9:25:14 PM CET Bjorn Helgaas wrote: >

Re: [PATCH] cpufreq: nforce2: Remove meaningless return

2018-12-04 Thread Rafael J. Wysocki
On Tue, Dec 4, 2018 at 2:15 AM Frank Lee wrote: > > On Mon, Dec 3, 2018 at 5:14 PM Rafael J. Wysocki wrote: > > > > On Fri, Nov 30, 2018 at 3:26 PM Yangtao Li wrote: > > > > > > In a function whose return type is void, returning on the last line is >

Re: [RFC/RFT][PATCH v6] cpuidle: New timer events oriented governor for tickless systems

2018-12-03 Thread Rafael J. Wysocki
On Thursday, November 29, 2018 12:20:07 AM CET Doug Smythies wrote: > On 2018.11.23 02:36 Rafael J. Wysocki wrote: > > v5 -> v6: > * Avoid applying poll_time_limit to non-polling idle states by mistake. > * Use idle duration measured by the governor for everything (as it l

Re: [RFC/RFT][PATCH v6] cpuidle: New timer events oriented governor for tickless systems

2018-12-03 Thread Rafael J. Wysocki
On Friday, November 30, 2018 9:51:19 AM CET Rafael J. Wysocki wrote: > Hi Doug, > > On Fri, Nov 30, 2018 at 8:49 AM Doug Smythies wrote: > > > > Hi Rafael, > > > > On 2018.11.23 02:36 Rafael J. Wysocki wrote: > > > > ... [snip]... > > &

Re: [RFC/RFT][PATCH v6] cpuidle: New timer events oriented governor for tickless systems

2018-12-03 Thread Rafael J. Wysocki
On Saturday, December 1, 2018 3:18:24 PM CET Giovanni Gherdovich wrote: > On Fri, 2018-11-23 at 11:35 +0100, Rafael J. Wysocki wrote: > > From: Rafael J. Wysocki > > [cut] > > > > [snip] > > [NOTE: the tables in this message are quite wide. If this doesn't ge

Re: [PATCH 05/12] PCI: aardvark: add suspend to RAM support

2018-12-03 Thread Rafael J. Wysocki
On Monday, December 3, 2018 4:38:46 PM CET Miquel Raynal wrote: > Hi Lorenzo, > > Lorenzo Pieralisi wrote on Mon, 3 Dec 2018 > 10:27:08 +: > > > [+Rafael, Sudeep] > > > > On Fri, Nov 23, 2018 at 03:18:24PM +0100, Miquel Raynal wrote: > > > Add suspend and resume callbacks. The priority of

Re: [PATCH] Revert "exec: make de_thread() freezable (was: Re: Linux 4.20-rc4)

2018-12-03 Thread Rafael J. Wysocki
On Monday, December 3, 2018 9:39:42 AM CET Michal Hocko wrote: > On Mon 03-12-18 08:47:00, Ingo Molnar wrote: > [...] > > I reviewed the ->cred_guard_mutex code, and the mutex is held across all > > of exec() - and we always did this. > > Yes, this is something that has been pointed out during

Re: [PATCH] Revert "exec: make de_thread() freezable (was: Re: Linux 4.20-rc4)

2018-12-03 Thread Rafael J. Wysocki
On Monday, December 3, 2018 8:47:00 AM CET Ingo Molnar wrote: > > * Linus Torvalds wrote: > > > The patch stats this week look a little bit more normal than last tim, > > probably simply because it's also a normal-sized rc4 rather than the > > unusually small rc3. > > So there's a new

Re: [PATCH] sched/cpufreq: Add the SPDX tags

2018-12-03 Thread Rafael J. Wysocki
On Mon, Dec 3, 2018 at 11:15 AM Daniel Lezcano wrote: > > On 03/12/2018 11:12, Rafael J. Wysocki wrote: > > On Mon, Dec 3, 2018 at 11:07 AM Daniel Lezcano > > wrote: > >> > >> On 18/10/2018 21:55, Daniel Lezcano wrote: > >>> The SPDX tags are

Re: [PATCH] sched/cpufreq: Add the SPDX tags

2018-12-03 Thread Rafael J. Wysocki
On Mon, Dec 3, 2018 at 11:07 AM Daniel Lezcano wrote: > > On 18/10/2018 21:55, Daniel Lezcano wrote: > > The SPDX tags are not present in cpufreq.c and cpufreq_schedutil.c. > > > > Add them and remove the license descriptions > > > > Signed-off-by: Daniel Lezcano > > Hi Rafael, > > I think this

Re: [PATCH] cpufreq: nforce2: Remove meaningless return

2018-12-03 Thread Rafael J. Wysocki
On Fri, Nov 30, 2018 at 3:26 PM Yangtao Li wrote: > > In a function whose return type is void, returning on the last line is > not required.So remove it.Also move the module declaration to the end. The last piece is not reflected by the subject. Also, why do you move the MODULE_ stuff around at

Re: [PATCH] driver core: remove define_genpd_open_function() and define_genpd_debugfs_fops()

2018-12-03 Thread Rafael J. Wysocki
On Sat, Dec 1, 2018 at 2:51 AM Yangtao Li wrote: > > We already have the DEFINE_SHOW_ATTRIBUTE,There is no need to define such > a macro,so remove define_genpd_open_function and define_genpd_debugfs_fops. > Also use DEFINE_SHOW_ATTRIBUTE to simplify somecode. > > Signed-off-by: Yangtao Li It

Re: [PATCH RFC 06/15] cpufreq: replace **** with a hug

2018-12-03 Thread Rafael J. Wysocki
On Fri, Nov 30, 2018 at 8:28 PM Jarkko Sakkinen wrote: > > In order to comply with the CoC, replace with a hug. > > Signed-off-by: Jarkko Sakkinen > --- > drivers/cpufreq/powernow-k7.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/drivers/cpufreq/powernow-k7.c

Re: [RFC/RFT][PATCH v6] cpuidle: New timer events oriented governor for tickless systems

2018-11-30 Thread Rafael J. Wysocki
Hi Doug, On Fri, Nov 30, 2018 at 8:49 AM Doug Smythies wrote: > > Hi Rafael, > > On 2018.11.23 02:36 Rafael J. Wysocki wrote: > > ... [snip]... > > > +/** > > + * teo_find_shallower_state - Find shallower idle state matching given > > duration. > > +

Re: [PATCH v2 0/6] device property: Introducing software nodes

2018-11-29 Thread Rafael J. Wysocki
On Friday, November 9, 2018 3:21:32 PM CET Heikki Krogerus wrote: > Hi, > > This is the second version of my proposal for "software nodes". There > was a "dereferencing freed memory" bug in patch 3/5 which is now > fixed. device_add_properties() and device_remove_properties() no > longer change

Re: [PATCH v3 1/4] PCI / ACPI: Identify untrusted PCI devices

2018-11-29 Thread Rafael J. Wysocki
ware/drivers/pci/dsd-for-pcie-root-ports#identifying-externally-exposed-pcie-root-ports > > Signed-off-by: Mika Westerberg Acked-by: Rafael J. Wysocki > --- > drivers/acpi/property.c | 11 +++ > drivers/pci/pci-acpi.c | 19 +++ > drivers/pci/probe.c

Re: [PATCH v5 14/15] ACPI / scan: Create platform device for INT3515 ACPI nodes

2018-11-29 Thread Rafael J. Wysocki
ly. > > Signed-off-by: Andy Shevchenko > Reviewed-by: Hans de Goede Acked-by: Rafael J. Wysocki and I'm assuming that you will route the whole series through the platform/x86 drivers tree.

[GIT PULL] ACPI fix for v4.20-rc5

2018-11-29 Thread Rafael J. Wysocki
Hi Linus, Please pull from the tag git://git.kernel.org/pub/scm/linux/kernel/git/rafael/linux-pm.git \ acpi-4.20-rc5 with top-most commit c4f784268210ae5e6749d4ba30d117bd301a70a6 Merge branch 'acpica-fixes' on top of commit 2bbb5fa37475d7aa5fa62f34db1623f3da2dfdfa ACPI / platform: Add

[GIT PULL] Power management fixes for v4.20-rc4

2018-11-29 Thread Rafael J. Wysocki
Hi Linus, Please pull from the tag git://git.kernel.org/pub/scm/linux/kernel/git/rafael/linux-pm.git \ pm-4.20-rc5 with top-most commit 36c3aeb4b48d5b058526d606fde14db4fd7e5e6d Merge branch 'opp/fixes-for-4.20' of git://git.kernel.org/pub/scm/linux/kernel/git/vireshk/pm on top of commit

Re: [RFC/RFT][PATCH v6] cpuidle: New timer events oriented governor for tickless systems

2018-11-29 Thread Rafael J. Wysocki
Hi Doug, On Thu, Nov 29, 2018 at 12:20 AM Doug Smythies wrote: > > On 2018.11.23 02:36 Rafael J. Wysocki wrote: > > v5 -> v6: > * Avoid applying poll_time_limit to non-polling idle states by mistake. > * Use idle duration measured by the governor for everything (as i

Re: [Bug] SD card reader in Acer Aspire S5 broken in 4.20-rc

2018-11-28 Thread Rafael J. Wysocki
On Tuesday, November 27, 2018 9:25:14 PM CET Bjorn Helgaas wrote: > On Mon, Nov 26, 2018 at 11:37:20PM +0100, Rafael J. Wysocki wrote: > > On Monday, November 26, 2018 7:03:58 PM CET Rafael J. Wysocki wrote: > > > Hi Bjorn, > > > > > > The SD card read

Re: [Bug] SD card reader in Acer Aspire S5 broken in 4.20-rc

2018-11-27 Thread Rafael J. Wysocki
On Tuesday, November 27, 2018 9:25:14 PM CET Bjorn Helgaas wrote: > On Mon, Nov 26, 2018 at 11:37:20PM +0100, Rafael J. Wysocki wrote: > > On Monday, November 26, 2018 7:03:58 PM CET Rafael J. Wysocki wrote: > > > Hi Bjorn, > > > > > > The SD card read

Re: [Bug] SD card reader in Acer Aspire S5 broken in 4.20-rc

2018-11-26 Thread Rafael J. Wysocki
On Monday, November 26, 2018 7:03:58 PM CET Rafael J. Wysocki wrote: > Hi Bjorn, > > The SD card reader in my Acer Aspire S5 doesn't work with 4.20-rc. > > Here's what lspci -v says about it (in a bad kernel): > > 02:00.0 Unassigned class [ff00]: Realtek Semiconductor

[Bug] SD card reader in Acer Aspire S5 broken in 4.20-rc

2018-11-26 Thread Rafael J. Wysocki
Hi Bjorn, The SD card reader in my Acer Aspire S5 doesn't work with 4.20-rc. Here's what lspci -v says about it (in a bad kernel): 02:00.0 Unassigned class [ff00]: Realtek Semiconductor Co., Ltd. RTS5209 PCI Express Card Reader (rev 01) Subsystem: Acer Incorporated [ALI] Device 0704

Re: [RFC/RFT][PATCH v6] cpuidle: New timer events oriented governor for tickless systems

2018-11-23 Thread Rafael J. Wysocki
On Friday, November 23, 2018 11:35:38 AM CET Rafael J. Wysocki wrote: > From: Rafael J. Wysocki > > The venerable menu governor does some thigns that are quite > questionable in my view. > > First, it includes timer wakeups in the pattern detection data and > mixes them

[RFC/RFT][PATCH v6] cpuidle: New timer events oriented governor for tickless systems

2018-11-23 Thread Rafael J. Wysocki
From: Rafael J. Wysocki The venerable menu governor does some thigns that are quite questionable in my view. First, it includes timer wakeups in the pattern detection data and mixes them up with wakeups from other sources which in some cases causes it to expect what essentially would be a timer

[GIT PULL] ACPI fix for v4.20-rc4

2018-11-23 Thread Rafael J. Wysocki
Hi Linus, Please pull from the tag git://git.kernel.org/pub/scm/linux/kernel/git/rafael/linux-pm.git \ acpi-4.20-rc4 with top-most commit 2bbb5fa37475d7aa5fa62f34db1623f3da2dfdfa ACPI / platform: Add SMB0001 HID to forbidden_id_list on top of commit 9ff01193a20d391e8dbce4403dd5ef87c7eaaca6

[GIT PULL] Power management fixes for v4.20-rc4

2018-11-23 Thread Rafael J. Wysocki
Hi Linus, Please pull from the tag git://git.kernel.org/pub/scm/linux/kernel/git/rafael/linux-pm.git \ pm-4.20-rc4 with top-most commit 1d50088ca3956e5dcd2751a658e7869b9af10bb4 Merge branches 'pm-cpufreq' and 'pm-sleep' on top of commit 9ff01193a20d391e8dbce4403dd5ef87c7eaaca6 Linux

Re: [PATCH v9 09/15] sched: Introduce sched_energy_present static key

2018-11-22 Thread Rafael J. Wysocki
On Thu, Nov 22, 2018 at 4:25 PM Quentin Perret wrote: > > On Thursday 22 Nov 2018 at 11:25:45 (+0100), Peter Zijlstra wrote: > > On Thu, Nov 22, 2018 at 09:32:39AM +, Quentin Perret wrote: > > > Hmm, I went too fast, that's totally broken. But there's still something > > > we can do with

Re: [PATCH v9 08/15] sched/topology: Make Energy Aware Scheduling depend on schedutil

2018-11-22 Thread Rafael J. Wysocki
On Thu, Nov 22, 2018 at 3:05 PM Peter Zijlstra wrote: > > On Mon, Nov 19, 2018 at 02:18:50PM +, Quentin Perret wrote: > > + if (rd->pd) > > + pr_warn("rd %*pbl: Disabling EAS, schedutil > > is mandatory\n", > > +

Re: [RFC/RFT][PATCH v5] cpuidle: New timer events oriented governor for tickless systems

2018-11-21 Thread Rafael J. Wysocki
On Thursday, November 15, 2018 4:15:59 AM CET Rafael J. Wysocki wrote: > On Sunday, November 11, 2018 4:40:17 PM CET Peter Zijlstra wrote: [cut] > > > Anyway; a fair while ago I proposed a different estimator. I've not had > > time to dig through the 4 prior versions so I can

Re: [PATCH v2] exec: make de_thread() freezable

2018-11-21 Thread Rafael J. Wysocki
On Monday, November 12, 2018 9:15:18 AM CET Oleg Nesterov wrote: > On 11/12, Chanho Min wrote: > > > > @@ -1083,7 +1084,7 @@ static int de_thread(struct task_struct *tsk) > > while (sig->notify_count) { > > __set_current_state(TASK_KILLABLE); > > spin_unlock_irq(lock);

Re: [GIT PULL] cpupower update for Linux 4.20-rc4

2018-11-21 Thread Rafael J. Wysocki
On Tue, Nov 20, 2018 at 10:16 PM shuah wrote: > > Hi Rafael, > > Please pull the following update for Linux 4.20-rc4 or rc5 depending on > your pm pull schedule to Linus. > > This cpupower update for Linux 4.20-rc4 consists of compile fixes to > allow use of outside build flags and override of

Re: [PATCH v2 0/4] device property: Add fwnode_get_name() helper

2018-11-20 Thread Rafael J. Wysocki
On Thursday, November 8, 2018 5:51:52 PM CET Heikki Krogerus wrote: > Hi, > > This is the second version of my proposal for this helper. The > first version can be checked here: > https://lkml.org/lkml/2018/11/5/326 > > In order to support also ACPI properly, I decided to change the API. > The

Re: [PATCH v2] cpuidle: big.LITTLE: add of_node_put()

2018-11-20 Thread Rafael J. Wysocki
On Tue, Nov 20, 2018 at 4:46 PM Yangtao Li wrote: > > The of_node_put() is missing.So we call the of_node_put() to release > the refcount. I would say "of_find_node_by_path() acquires a reference to the node returned by it and that reference needs to be dropped by its caller. bl_idle_init()

Re: [PATCH] cpuidle: big.LITTLE: add of_node_put()

2018-11-20 Thread Rafael J. Wysocki
On Tue, Nov 20, 2018 at 2:00 PM Yangtao Li wrote: > > use of_node_put() to release the refcount. I gather that the of_node_put() is missing? If so, that should be stated in the changelog too. > Signed-off-by: Yangtao Li > --- > drivers/cpuidle/cpuidle-big_little.c | 8 ++-- > 1 file

Re: [PATCH 6/7] acpi: Create subtable parsing infrastructure

2018-11-19 Thread Rafael J. Wysocki
On Wed, Nov 14, 2018 at 11:53 PM Keith Busch wrote: > > Parsing entries in an ACPI table had assumed a generic header structure > that is most common. There is no standard ACPI header, though, so less > common types would need custom parsers if they want go walk their > subtable entry list. > >

Re: [RFC/RFT][PATCH v5] cpuidle: New timer events oriented governor for tickless systems

2018-11-14 Thread Rafael J. Wysocki
On Sunday, November 11, 2018 4:40:17 PM CET Peter Zijlstra wrote: > On Thu, Nov 08, 2018 at 06:25:07PM +0100, Rafael J. Wysocki wrote: > > +unsigned int teo_idle_duration(struct cpuidle_driver *drv, > > + struct teo_cpu *cpu_data, > > +

Re: [RFC/RFT][PATCH v5] cpuidle: New timer events oriented governor for tickless systems

2018-11-14 Thread Rafael J. Wysocki
On Sunday, November 11, 2018 4:20:34 PM CET Peter Zijlstra wrote: > On Thu, Nov 08, 2018 at 06:25:07PM +0100, Rafael J. Wysocki wrote: > > +/* > > + * The SPIKE value is added to metrics when they grow and the DECAY_SHIFT > > value > > + * is used for decreasing

Re: [RFC/RFT][PATCH v5] cpuidle: New timer events oriented governor for tickless systems

2018-11-14 Thread Rafael J. Wysocki
On Saturday, November 10, 2018 8:10:01 PM CET Giovanni Gherdovich wrote: > On Thu, 2018-11-08 at 18:25 +0100, Rafael J. Wysocki wrote: > > From: Rafael J. Wysocki > > Subject: [PATCH] cpuidle: New timer events oriented governor for tickless > > systems > >

Re: [RFC/RFT][PATCH v3] cpuidle: New timer events oriented governor for tickless systems

2018-11-14 Thread Rafael J. Wysocki
On Wed, Nov 14, 2018 at 7:26 AM Doug Smythies wrote: > > On 2018.11.08 00:00 Rafael J. Wysocki wrote: > > On Wednesday, November 7, 2018 6:04:12 PM CET Doug Smythies wrote: > >> On 2018.11.04 08:31 Rafael J. Wysocki wrote: > > ...[snip]... > >> The results are:

[GIT PULL] ACPI fix for v4.20-rc3

2018-11-14 Thread Rafael J. Wysocki
Hi Linus, Please pull from the tag git://git.kernel.org/pub/scm/linux/kernel/git/rafael/linux-pm.git \ acpi-4.20-rc3 with top-most commit 017ce359a7187192df5222a00fa3c9055eb3736d ACPI / PMIC: xpower: fix IOSF_MBI dependency on top of commit 651022382c7f8da46cb4872a545ee1da6d097d2a Linux

[RFC/RFT][PATCH v5] cpuidle: New timer events oriented governor for tickless systems

2018-11-08 Thread Rafael J. Wysocki
From: Rafael J. Wysocki Subject: [PATCH] cpuidle: New timer events oriented governor for tickless systems The venerable menu governor does some thigns that are quite questionable in my view. First, it includes timer wakeups in the pattern detection data and mixes them up with wakeups from

Re: [RFC/RFT][PATCH v3] cpuidle: New timer events oriented governor for tickless systems

2018-11-08 Thread Rafael J. Wysocki
On Wednesday, November 7, 2018 6:04:12 PM CET Doug Smythies wrote: > On 2018.11.04 08:31 Rafael J. Wysocki wrote: > > > v2 -> v3: > > * Simplify the pattern detection code and make it return a value > > lower than the time to the closest timer if the majority of re

Re: [PATCH] ACPI / PMIC: xpower: fix IOSF_MBI dependency

2018-11-07 Thread Rafael J. Wysocki
On Fri, Nov 2, 2018 at 12:07 PM Arnd Bergmann wrote: > > We still get a link failure with IOSF_MBI=m when the xpower driver > is built-in: > > drivers/acpi/pmic/intel_pmic_xpower.o: In function > `intel_xpower_pmic_update_power': > intel_pmic_xpower.c:(.text+0x4f2): undefined reference to >

Re: [RFC/RFT][PATCH v3] cpuidle: New timer events oriented governor for tickless systems

2018-11-07 Thread Rafael J. Wysocki
On Wed, Nov 7, 2018 at 9:59 AM Peter Zijlstra wrote: > > On Wed, Nov 07, 2018 at 12:39:31AM +0100, Rafael J. Wysocki wrote: > > On Tue, Nov 6, 2018 at 8:51 PM Peter Zijlstra wrote: > > > > > > On Tue, Nov 06, 2018 at 07:19:24PM +0100, Rafael J. Wysocki wrote: >

[RFC/RFT][PATCH v4] cpuidle: New timer events oriented governor for tickless systems

2018-11-06 Thread Rafael J. Wysocki
From: Rafael J. Wysocki The venerable menu governor does some thigns that are quite questionable in my view. First, it includes timer wakeups in the pattern detection data and mixes them up with wakeups from other sources which in some cases causes it to expect what essentially would be a timer

Re: [RFC/RFT][PATCH v3] cpuidle: New timer events oriented governor for tickless systems

2018-11-06 Thread Rafael J. Wysocki
On Tue, Nov 6, 2018 at 8:51 PM Peter Zijlstra wrote: > > On Tue, Nov 06, 2018 at 07:19:24PM +0100, Rafael J. Wysocki wrote: > > On Tue, Nov 6, 2018 at 6:04 PM Peter Zijlstra wrote: > > > > Instead of this detector; why haven't you used the code from > > > kerne

Re: [RFC/RFT][PATCH v3] cpuidle: New timer events oriented governor for tickless systems

2018-11-06 Thread Rafael J. Wysocki
On Tue, Nov 6, 2018 at 6:04 PM Peter Zijlstra wrote: > > On Sun, Nov 04, 2018 at 05:31:20PM +0100, Rafael J. Wysocki wrote: > > + * - If there is a pattern of 5 or more recent non-timer wakeups earlier > > than > > + * the closest timer event, expect one more

Re: [PATCH] driver core: Add branch prediction hints in really_probe()

2018-11-06 Thread Rafael J. Wysocki
On Tue, Nov 6, 2018 at 3:43 PM Muchun Song wrote: > > Hi Rafael, > > If we want the driver core to test driver remove functions, we can > enable CONFIG_DEBUG_TEST_DRIVER_REMOVE. This option is > just for testing it. So, in most cases, the option is disabled and the if > condition is false. So I

Re: [RFC/RFT][PATCH v3] cpuidle: New timer events oriented governor for tickless systems

2018-11-06 Thread Rafael J. Wysocki
On Monday, November 5, 2018 8:32:51 PM CET Giovanni Gherdovich wrote: > On Sun, 2018-11-04 at 17:31 +0100, Rafael J. Wysocki wrote: > > From: Rafael J. Wysocki > > [cut] > > + > > +/** > > + * teo_update - Update CPU data after wakeup. > > + * @dr

Re: [PATCH] driver core: Add branch prediction hints in really_probe()

2018-11-06 Thread Rafael J. Wysocki
On Tue, Nov 6, 2018 at 2:47 PM Muchun Song wrote: > > If condition is false in most cases. So, add an unlikely() to the if > condition, so that the optimizer assumes that the condition is false. > > Signed-off-by: Muchun Song Have you measured the practical impact of this patch in any way? >

Re: [PATCH v2] kobject: to use pr_warn replace KERN_WARNING

2018-11-06 Thread Rafael J. Wysocki
On Tue, Nov 6, 2018 at 8:58 AM Joe Perches wrote: > > On Tue, 2018-11-06 at 08:49 +0100, Rafael J. Wysocki wrote: > > On Tue, Nov 6, 2018 at 3:42 AM Bo YU wrote: > > > Fix warning form checkpatch, use pr_warn replace KERN_WARNING > > > > > > Signed-off

Re: [PATCH] driver core: fix comments for device_block_probing()

2018-11-05 Thread Rafael J. Wysocki
On Tue, Nov 6, 2018 at 8:41 AM Randy Dunlap wrote: > > From: Randy Dunlap > > Correct function name and spelling/typo for device_block_probing() > in drivers/base/dd.c. > > Signed-off-by: Randy Dunlap > Cc: Greg Kroah-Hartman > Cc: "Rafael J. Wysocki&q

Re: [PATCH v2] kobject: to use pr_warn replace KERN_WARNING

2018-11-05 Thread Rafael J. Wysocki
On Tue, Nov 6, 2018 at 3:42 AM Bo YU wrote: > > Fix warning form checkpatch, use pr_warn replace KERN_WARNING > > Signed-off-by: Bo YU First off, IMO, you should not change the existing code just in order to make checkpatch happy about it. That alone is not a good enough reason for modifying

[RFC/RFT][PATCH v3] cpuidle: New timer events oriented governor for tickless systems

2018-11-04 Thread Rafael J. Wysocki
From: Rafael J. Wysocki The venerable menu governor does some thigns that are quite questionable in my view. First, it includes timer wakeups in the pattern detection data and mixes them up with wakeups from other sources which in some cases causes it to expect what essentially would be a timer

Re: [RFC/RFT][PATCH v2] cpuidle: New timer events oriented governor for tickless systems

2018-11-04 Thread Rafael J. Wysocki
On Friday, November 2, 2018 4:39:42 PM CET Doug Smythies wrote: > On 2018.10.26 02:12 Rafael J. Wysocki wrote: > > ...[snip]... Again, thanks a lot for the feedback, it is appreciated very much! > > The v2 is a re-write of major parts of the original patch. > > >

Re: [RFC/RFT][PATCH v2] cpuidle: New timer events oriented governor for tickless systems

2018-11-04 Thread Rafael J. Wysocki
On Wednesday, October 31, 2018 7:36:21 PM CET Giovanni Gherdovich wrote: > On Fri, 2018-10-26 at 11:12 +0200, Rafael J. Wysocki wrote: > > From: Rafael J. Wysocki [cut] > > Hello Rafael, Hi Giovanni, First off, many thanks for doing this work, it is very very much appreciat

[GIT PULL] More ACPI updates for v4.20-rc1

2018-10-30 Thread Rafael J. Wysocki
Hi Linus, Please pull from the tag git://git.kernel.org/pub/scm/linux/kernel/git/rafael/linux-pm.git \ acpi-4.20-rc1-2 with top-most commit 6a9b593d4b6f5994209456de7a3c2db0974b5dda ACPI / PMIC: xpower: Add depends on IOSF_MBI to Kconfig entry on top of commit

[GIT PULL] More power management updates for v4.20-rc1

2018-10-30 Thread Rafael J. Wysocki
Hi Linus, Please pull from the tag git://git.kernel.org/pub/scm/linux/kernel/git/rafael/linux-pm.git \ pm-4.20-rc1-2 with top-most commit c4ac6889930d027ffa5cf77e0c202e7e97a4be06 Merge branches 'pm-cpuidle' and 'pm-cpufreq' on top of commit bd6bf7c10484f026505814b690104cdef27ed460 Merge

Re: linux-next: manual merge of the pm tree with Linus' tree

2018-10-30 Thread Rafael J. Wysocki
On Monday, October 29, 2018 3:01:24 AM CET Stephen Rothwell wrote: > > --Sig_/X_/swfdki+BZTJ8afk_lQqW > Content-Type: text/plain; charset=US-ASCII > Content-Transfer-Encoding: quoted-printable > > Hi Rafael, > > Today's linux-next merge of the pm tree got a conflict in: > >

Re: linux-next: manual merge of the pm tree with the i2c tree

2018-10-30 Thread Rafael J. Wysocki
On Monday, October 29, 2018 3:09:25 AM CET Stephen Rothwell wrote: > > --Sig_/Yi5UDAd5LU=QdOHo+ui7Syk > Content-Type: text/plain; charset=US-ASCII > Content-Transfer-Encoding: quoted-printable > > Hi Rafael, > > Today's linux-next merge of the pm tree got conflicts in: > >

Re: [RFC/RFT][PATCH v2] cpuidle: New timer events oriented governor for tickless systems

2018-10-30 Thread Rafael J. Wysocki
On Saturday, October 27, 2018 8:37:24 AM CET Doug Smythies wrote: > This is just for anybody else trying to compile: > > On 2018.10.26 02:12 Rafael J. Wysocki wrote: > > > The venerable menu governor does some thigns that are quite > > Typo: thigns -> things > &

Re: [REGRESSION 4.19-rc2] sometimes hangs with black screen when resuming from suspend or hibernation (was: Re: Linux 4.19-rc2)

2018-10-30 Thread Rafael J. Wysocki
On Fri, Oct 26, 2018 at 5:49 PM Martin Steigerwald wrote: > > This regression is gone with 4.19-rc8. Thanks for the update! > Martin Steigerwald - 11.09.18, 09:53: > […] > > Linus Torvalds - 02.09.18, 23:45: > > > As usual, the rc2 release is pretty small. People are taking a > > > > With

Re: [PATCH v2] cpufreq: intel_pstate: Fix compilation for !CONFIG_ACPI

2018-10-26 Thread Rafael J. Wysocki
"cpufreq: intel_pstate: Add base_frequency > > attribute") > > Cc: Srinivas Pandruvada > > Cc: Rafael J. Wysocki > > Signed-off-by: Dominik Brodowski > Acked-by: Srinivas Pandruvada > > > > > diff --git a/drivers/cpufreq/intel_pstate.c &

Re: [PATCH v4] kernel/hung_task.c: disable on suspend

2018-10-26 Thread Rafael J. Wysocki
On Thursday, October 18, 2018 9:32:42 AM CEST Rafael J. Wysocki wrote: > On Wed, Oct 17, 2018 at 1:24 PM Vitaly Kuznetsov wrote: > > > > It is possible to observe hung_task complaints when system goes to > > suspend-to-idle state: > > > > # echo freeze > /

Re: [PATCH V2 1/2] sched: Factor out nr_iowait and nr_iowait_cpu

2018-10-26 Thread Rafael J. Wysocki
On Thursday, October 4, 2018 2:04:02 PM CEST Daniel Lezcano wrote: > The function nr_iowait_cpu() can be used directly by nr_iowait() instead > of duplicating code. > > Call nr_iowait_cpu() from nr_iowait() > > Reviewed-by: Rafael J. Wysocki > Signed-off-by: Daniel Lez

Re: 4.18: early boot crash in thermal_cooling_device_destroy_sysfs

2018-10-26 Thread Rafael J. Wysocki
On Monday, October 22, 2018 8:37:25 PM CEST Randy Dunlap wrote: > > On 8/16/18 2:33 PM, Randy Dunlap wrote: > > Hi, > > > > Sorry for the photo. That's all I have available so far. > > > > https://www.infradead.org/~rdunlap/doc/IMG_20180816_133254743_HDR.jpg > > > > > > Does anyone recognize

[RFC/RFT][PATCH v2] cpuidle: New timer events oriented governor for tickless systems

2018-10-26 Thread Rafael J. Wysocki
From: Rafael J. Wysocki The venerable menu governor does some thigns that are quite questionable in my view. First, it includes timer wakeups in the pattern detection data and mixes them up with wakeups from other sources which in some cases causes it to expect what essentially would be a timer

Re: [RFC/RFT/[PATCH] cpuidle: New timer events oriented governor for tickless systems

2018-10-26 Thread Rafael J. Wysocki
t's not "obvious" > code and comments help a lot. > > On Thu, 2018-10-11 at 23:01 +0200, Rafael J. Wysocki wrote: > > From: Rafael J. Wysocki > > [cut] > > +static void teo_update(struct cpuidle_driver *drv, > > +struct cpuidle_device *dev)

[GIT PULL] ACPI updates for v4.20-rc1

2018-10-22 Thread Rafael J. Wysocki
ACPI/PPTT: Handle architecturally unknown cache types Rafael J. Wysocki (1): ACPI: TAD: Add low-level support for real time capability Ronald Tschalär (2): ACPI / SBS: Fix GPE storm on recent MacBookPro's ACPI / SBS: Fix rare oops when removing modules zhong jiang (1):

[GIT PULL] Power management updates for v4.20-rc1

2018-10-22 Thread Rafael J. Wysocki
n't adjust to user limits in governors PM / devfreq: Make update_devfreq() public Nathan Chancellor (1): cpufreq / CPPC: Mark acpi_ids as used Prarit Bhargava (2): cpupower: Fix AMD Family 0x17 msr_pstate size cpupower: Fix coredump on VMWare Rafael J. Wysocki (12): cpu

Re: [PATCH 0/1] ACPI / scan: Create platform device for INT33FE ACPI nodes

2018-10-19 Thread Rafael J. Wysocki
On Wednesday, October 17, 2018 1:39:54 PM CEST Andy Shevchenko wrote: > On Wed, Oct 17, 2018 at 11:59 AM Hans de Goede wrote: > > > > Hi Rafael, Andy, > > > > For the why and what of this patch see the (somewhat long) commit message. > > > > The single patch in this set both touches

Re: [PATCH 1/2] sched/cpufreq: Reorganize the cpufreq files

2018-10-18 Thread Rafael J. Wysocki
On Thu, Oct 18, 2018 at 11:54 AM Daniel Lezcano wrote: > > On 18/10/2018 11:42, Rafael J. Wysocki wrote: > > On Thu, Oct 18, 2018 at 11:36 AM Daniel Lezcano > > wrote: > >> > >> It was suggested to set the scene for the PM components in the > >&

Re: [PATCH 1/2] sched/cpufreq: Reorganize the cpufreq files

2018-10-18 Thread Rafael J. Wysocki
On Thu, Oct 18, 2018 at 11:36 AM Daniel Lezcano wrote: > > It was suggested to set the scene for the PM components in the > scheduler code organization in the recent discussion about making the > scheduler aware of the capacity capping from the thermal framework. > > Move the cpufreq files into

Re: [PATCH 1/3] x86: baytrail/cherrytrail: Rework and move P-Unit PMIC bus semaphore code

2018-10-18 Thread Rafael J. Wysocki
On Thursday, October 18, 2018 10:34:57 AM CEST Hans de Goede wrote: > Hi, > > On 18-10-18 09:29, Rafael J. Wysocki wrote: > > On Sun, Sep 23, 2018 at 4:45 PM Hans de Goede wrote: > >> > >> On some BYT/CHT systems the SoC's P-Unit shares the I2C bus wit

Re: [RFC PATCH 0/7] Introduce thermal pressure

2018-10-18 Thread Rafael J. Wysocki
On Thu, Oct 18, 2018 at 9:50 AM Ingo Molnar wrote: > > > * Rafael J. Wysocki wrote: > > > > The only long term maintainable solution is to move all high level > > > cpufreq logic and policy handling code into kernel/sched/cpufreq*.c, > > > which has been do

Re: [driver-core PATCH v4 3/6] device core: Consolidate locking and unlocking of parent and device

2018-10-18 Thread Rafael J. Wysocki
m 12 down to 4. > > Signed-off-by: Alexander Duyck Reviewed-by: Rafael J. Wysocki > --- > drivers/base/base.h |2 + > drivers/base/bus.c | 23 ++ > drivers/base/dd.c | 83 > ++- > 3 files changed, 75 i

Re: [PATCH v4] kernel/hung_task.c: disable on suspend

2018-10-18 Thread Rafael J. Wysocki
er a PM notifier to disable the detector on suspend and re-enable > back on wakeup. > > Signed-off-by: Vitaly Kuznetsov Thanks for your patience with this! Are there any objections or concerns regarding this patch? > --- > Changes since v3: > - Handle PM_RESTO

Re: [PATCH 1/3] x86: baytrail/cherrytrail: Rework and move P-Unit PMIC bus semaphore code

2018-10-18 Thread Rafael J. Wysocki
On Sun, Sep 23, 2018 at 4:45 PM Hans de Goede wrote: > > On some BYT/CHT systems the SoC's P-Unit shares the I2C bus with the > kernel. The P-Unit has a semaphore for the PMIC bus which we can take to > block it from accessing the shared bus while the kernel wants to access it. > > Currently we

Re: [RFC PATCH 0/7] Introduce thermal pressure

2018-10-18 Thread Rafael J. Wysocki
On Thu, Oct 18, 2018 at 8:48 AM Ingo Molnar wrote: > > > * Thara Gopinath wrote: > > > On 10/16/2018 03:33 AM, Ingo Molnar wrote: > > > > > > * Thara Gopinath wrote: > > > > > Regarding testing, basic build, boot and sanity testing have been > > performed on hikey960 mainline kernel

Re: [PATCH 0/2] cpuidle: menu: Two more refinements

2018-10-17 Thread Rafael J. Wysocki
On Mon, Oct 15, 2018 at 1:57 PM Rafael J. Wysocki wrote: > > Hi All, > > The following patches are two more refinements of the menu governor (on top > of the recent changes in linux-next now). The are not expected to change the > overall behavior of it. > > Please refer

Re: [PATCH] ACPI: TAD: Add low-level support for real time capability

2018-10-17 Thread Rafael J. Wysocki
On Mon, Oct 15, 2018 at 1:59 PM Rafael J. Wysocki wrote: > > From: Rafael J. Wysocki > > Add low-level support for the (optional) real time capability of the > ACPI Time and Alarm Device (TAD) to the ACPI TAD driver. > > This allows the real time to be acquired or set via

Re: [PATCH v3] kernel/hung_task.c: disable on suspend

2018-10-17 Thread Rafael J. Wysocki
er a PM notifier to disable the detector on suspend and re-enable > back on wakeup. > > Signed-off-by: Vitaly Kuznetsov > --- > Changes since v2: > - Resurrect 'v1' as zeroing timeouts can be racy [Rafael J. Wysocki] > --- > kernel/hung_task.c | 28 +++- &

Re: [PATCH v2] kernel/hung_task.c: disable on suspend

2018-10-16 Thread Rafael J. Wysocki
taly Kuznetsov > --- > Changes since v1: > - Implement detector disabling by zeroing timeout [Rafael J. Wysocki] > --- > kernel/hung_task.c | 36 +++- > 1 file changed, 35 insertions(+), 1 deletion(-) > > diff --git a/kernel/hung_task.c b/kerne

Re: [PATCH V4] cpufreq: imx6q: read OCOTP through nvmem for imx6ul/imx6ull

2018-10-16 Thread Rafael J. Wysocki
On Monday, October 8, 2018 8:15:08 AM CEST Viresh Kumar wrote: > On 08-10-18, 14:07, Anson Huang wrote: > > On i.MX6UL/i.MX6ULL, accessing OCOTP directly is wrong because > > the ocotp clock needs to be enabled first. Add support for reading > > OCOTP through the nvmem API, and keep the old method

Re: [PATCH v2] cpufreq: dt-platdev: allow RK3399 to have separate tunables per cluster

2018-10-16 Thread Rafael J. Wysocki
On Monday, October 8, 2018 7:55:47 AM CEST Viresh Kumar wrote: > On 05-10-18, 12:00, Dmitry Torokhov wrote: > > RK3899 has one cluster with 4 small cores, and another one with 2 big > > cores, with cores in different clusters having different OPPs and thus > > needing separate set of tunables.

Re: [PATCH] ACPI: remove redundant 'default n' from Kconfig

2018-10-16 Thread Rafael J. Wysocki
On Wednesday, October 10, 2018 4:41:30 PM CEST Bartlomiej Zolnierkiewicz wrote: > 'default n' is the default value for any bool or tristate Kconfig > setting so there is no need to write it explicitly. > > Also since commit f467c5640c29 ("kconfig: only write '# CONFIG_FOO > is not set' for

Re: [RFC PATCH 0/5] device property: Introducing software nodes

2018-10-16 Thread Rafael J. Wysocki
On Tue, Oct 16, 2018 at 10:40 AM Heikki Krogerus wrote: > > On Tue, Oct 16, 2018 at 09:36:33AM +0200, Rafael J. Wysocki wrote: > > On Tue, Oct 16, 2018 at 9:35 AM Linus Walleij > > wrote: > > > > > > On Fri, Oct 12, 2018 at 1:39 PM Heikki Krogerus >

Re: [GIT PULL] cpupower update for Linux 4.20-rc1

2018-10-16 Thread Rafael J. Wysocki
Hi Shuah, On Mon, Oct 15, 2018 at 9:21 PM Shuah Khan wrote: > > Hi Rafael, > > Please pull the following cpupower update for Linux 4.20-rc1 > > This cpupower update for Linux 4.20-rc1 consists of fixes for bugs and > compile warnings from Prarit Bhargava and Anders Roxell. > > diff is attached.

  1   2   3   4   5   6   7   8   9   10   >