Re: [PATCH] sound: core: fixed coding style errors

[Rajesh Kumbhakar]

Alright, I will resubmit the patch.

[PATCH] sound: core: fixed coding style errors

[Rajesh Kumbhakar]

fixing ERROR: "foo * bar" should be "foo *bar"
fixing WARNING: Missing a blank line after declarations

Signed-off-by: Rajesh Kumbhakar 
---
 sound/core/hwdep_compat.c | 4 +++-
 1 file changed, 3 insertions(+), 1 deletion(-)

diff --git a/sound/core/hwdep_compat.c b/sound/core/hwdep_compat.c
index a0b76706c..d8624a14a 100644
--- a/sound/core/hwdep_compat.c
+++ b/sound/core/hwdep_compat.c
@@ -36,11 +36,13 @@ enum {
SNDRV_HWDEP_IOCTL_DSP_LOAD32   = _IOW('H', 0x03, struct 
snd_hwdep_dsp_image32)
 };
 
-static long snd_hwdep_ioctl_compat(struct file * file, unsigned int cmd,
+static long snd_hwdep_ioctl_compat(struct file *file, unsigned int cmd,
   unsigned long arg)
 {
struct snd_hwdep *hw = file->private_data;
+
void __user *argp = compat_ptr(arg);
+
switch (cmd) {
case SNDRV_HWDEP_IOCTL_PVERSION:
case SNDRV_HWDEP_IOCTL_INFO:
-- 
2.25.1

[PATCH v3] staging: wimax: i2400m: add space before open parenthesis

[Rajesh Kumbhakar]

fixing ERROR: space required before the open parenthesis '('

Signed-off-by: Rajesh Kumbhakar 
---
Changes in v3:
- Fixed commit message (removed filename).
Changes in v2:
- Removed filename from commit message.

 drivers/staging/wimax/i2400m/netdev.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/staging/wimax/i2400m/netdev.c 
b/drivers/staging/wimax/i2400m/netdev.c
index cd06eaf75e8b..5b53e59084c8 100644
--- a/drivers/staging/wimax/i2400m/netdev.c
+++ b/drivers/staging/wimax/i2400m/netdev.c
@@ -523,7 +523,7 @@ void i2400m_net_erx(struct i2400m *i2400m, struct sk_buff 
*skb,
 
d_fnstart(2, dev, "(i2400m %p skb %p [%u] cs %d)\n",
  i2400m, skb, skb->len, cs);
-   switch(cs) {
+   switch (cs) {
case I2400M_CS_IPV4_0:
case I2400M_CS_IPV4:
i2400m_rx_fake_eth_header(i2400m->wimax_dev.net_dev,
-- 
2.25.1

Re: [PATCH v2] staging: wimax: i2400m: add space before open parenthesis

[Rajesh Kumbhakar]

On 21-02-2021 18:36, Greg KH wrote:

On Sat, Feb 20, 2021 at 05:46:52AM -0800, Rajesh Kumbhakar wrote:

netdev.c

fixing style ERROR: space required before the open parenthesis '('

Signed-off-by: Rajesh Kumbhakar 
---
Changes in v2:
- Removed filename from commit message.

filename is still in commit message :(
aah, not again. please bare with me this last time, will surely never 
repeat this.

[PATCH v2] staging: wimax: i2400m: add space before open parenthesis

[Rajesh Kumbhakar]

netdev.c

fixing style ERROR: space required before the open parenthesis '('

Signed-off-by: Rajesh Kumbhakar 
---
Changes in v2:
- Removed filename from commit message.

 drivers/staging/wimax/i2400m/netdev.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/staging/wimax/i2400m/netdev.c 
b/drivers/staging/wimax/i2400m/netdev.c
index cd06eaf75e8b..5b53e59084c8 100644
--- a/drivers/staging/wimax/i2400m/netdev.c
+++ b/drivers/staging/wimax/i2400m/netdev.c
@@ -523,7 +523,7 @@ void i2400m_net_erx(struct i2400m *i2400m, struct sk_buff 
*skb,
 
d_fnstart(2, dev, "(i2400m %p skb %p [%u] cs %d)\n",
  i2400m, skb, skb->len, cs);
-   switch(cs) {
+   switch (cs) {
case I2400M_CS_IPV4_0:
case I2400M_CS_IPV4:
i2400m_rx_fake_eth_header(i2400m->wimax_dev.net_dev,
-- 
2.25.1

[PATCH] staging: wimax: i2400m: add space before open parenthesis

[Rajesh Kumbhakar]

netdev.c

fixing style ERROR: space required before the open parenthesis '('

Signed-off-by: Rajesh Kumbhakar 
---
 drivers/staging/wimax/i2400m/netdev.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/staging/wimax/i2400m/netdev.c 
b/drivers/staging/wimax/i2400m/netdev.c
index cd06eaf75e8b..5b53e59084c8 100644
--- a/drivers/staging/wimax/i2400m/netdev.c
+++ b/drivers/staging/wimax/i2400m/netdev.c
@@ -523,7 +523,7 @@ void i2400m_net_erx(struct i2400m *i2400m, struct sk_buff 
*skb,
 
d_fnstart(2, dev, "(i2400m %p skb %p [%u] cs %d)\n",
  i2400m, skb, skb->len, cs);
-   switch(cs) {
+   switch (cs) {
case I2400M_CS_IPV4_0:
case I2400M_CS_IPV4:
i2400m_rx_fake_eth_header(i2400m->wimax_dev.net_dev,
-- 
2.25.1