Re: [PATCH v2 1/2] power: supply: sbs-battery: don't assume MANUFACTURER_DATA formats

2018-06-01 Thread Rhyland Klein
tric). > I suppose I could pull the 'return 0' out, but I'm not sure that would > make the code any better. I generally prefer to make checkpatch happy, so I would vote to move the return outside of the if blocks as a minimal way of making it happy. In general though, Acked-by: Rhyland Klein > >> Other than that >> >> Reviewed-by: Guenter Roeck >> >>> + /* SBS spec doesn't have a general health command. */ >>> + val->intval = POWER_SUPPLY_HEALTH_UNKNOWN; >>> + return 0; >>> + } >>> +} >>> + > > Brian > -- nvpublic

Re: [PATCH v2 1/2] power: supply: sbs-battery: don't assume MANUFACTURER_DATA formats

2018-06-01 Thread Rhyland Klein
tric). > I suppose I could pull the 'return 0' out, but I'm not sure that would > make the code any better. I generally prefer to make checkpatch happy, so I would vote to move the return outside of the if blocks as a minimal way of making it happy. In general though, Acked-by: Rhyland Klein > >> Other than that >> >> Reviewed-by: Guenter Roeck >> >>> + /* SBS spec doesn't have a general health command. */ >>> + val->intval = POWER_SUPPLY_HEALTH_UNKNOWN; >>> + return 0; >>> + } >>> +} >>> + > > Brian > -- nvpublic

Re: [PATCH 2/2] dt-bindings: power: sbs-battery: re-document "ti,bq20z75"

2018-06-01 Thread Rhyland Klein
ort this property as an alternative to "sbs,sbs-battery", and > because we've noticed there are some lingering TI specifics (in the > manufacturer-specific portion of the SBS spec), we'd like to start using > this property again to differentiate. > > Cc: Rhyland Klein > Sign

Re: [PATCH 2/2] dt-bindings: power: sbs-battery: re-document "ti,bq20z75"

2018-06-01 Thread Rhyland Klein
ort this property as an alternative to "sbs,sbs-battery", and > because we've noticed there are some lingering TI specifics (in the > manufacturer-specific portion of the SBS spec), we'd like to start using > this property again to differentiate. > > Cc: Rhyland Klein > Sign

Re: [PATCH] mfd: tps65911-comparator: Fix a build error

2018-04-23 Thread Rhyland Klein
@oracle.com> > LGTM Acked-by: Rhyland Klein <rkl...@nvidia.com> -- nvpublic

Re: [PATCH] mfd: tps65911-comparator: Fix a build error

2018-04-23 Thread Rhyland Klein
On 4/20/2018 5:21 AM, Dan Carpenter wrote: > In 2012, we changed the tps65910 API and fixed most drivers but forgot > to update this one. > > Fixes: 3f7e82759c69 ("mfd: Commonize tps65910 regmap access through header") > Signed-off-by: Dan Carpenter > L

Re: [PATCH v2 01/11] clk: tegra: Switch to using critical clks

2016-07-05 Thread Rhyland Klein
On 6/22/2016 8:16 AM, Thierry Reding wrote: > * PGP Signed by an unknown key > > On Fri, May 27, 2016 at 04:38:04PM -0400, Rhyland Klein wrote: >> Mark some of the required-to-be-enabled clks as critical clks. These >> need to be kept on through the disabling of un

Re: [PATCH v2 01/11] clk: tegra: Switch to using critical clks

2016-07-05 Thread Rhyland Klein
On 6/22/2016 8:16 AM, Thierry Reding wrote: > * PGP Signed by an unknown key > > On Fri, May 27, 2016 at 04:38:04PM -0400, Rhyland Klein wrote: >> Mark some of the required-to-be-enabled clks as critical clks. These >> need to be kept on through the disabling of un

Re: [RESEND PATCH] thermal: helpers: Check return value of get_temp

2016-07-05 Thread Rhyland Klein
On 6/6/2016 12:53 PM, Rhyland Klein wrote: > Check the return value of get_temp, which can fail. If it does, then > unlock and return the error code. > > Signed-off-by: Rhyland Klein <rkl...@nvidia.com> > --- > drivers/thermal/thermal_helpers.c | 4 > 1

Re: [RESEND PATCH] thermal: helpers: Check return value of get_temp

2016-07-05 Thread Rhyland Klein
On 6/6/2016 12:53 PM, Rhyland Klein wrote: > Check the return value of get_temp, which can fail. If it does, then > unlock and return the error code. > > Signed-off-by: Rhyland Klein > --- > drivers/thermal/thermal_helpers.c | 4 > 1 file changed, 4 insertions(+) >

Re: [PATCH v2 10/11] clk: Show CRITICAL clks in clk_summary output

2016-06-30 Thread Rhyland Klein
On 6/28/2016 1:40 PM, Stephen Boyd wrote: > On 06/22, Rhyland Klein wrote: >> On 6/22/2016 8:24 AM, Thierry Reding wrote: >>> >>> Maybe output " " instead of "" for CLK_IS_CRITICAL, that way you can >>> omit the second conditional. >

Re: [PATCH v2 10/11] clk: Show CRITICAL clks in clk_summary output

2016-06-30 Thread Rhyland Klein
On 6/28/2016 1:40 PM, Stephen Boyd wrote: > On 06/22, Rhyland Klein wrote: >> On 6/22/2016 8:24 AM, Thierry Reding wrote: >>> >>> Maybe output " " instead of "" for CLK_IS_CRITICAL, that way you can >>> omit the second conditional. >

Re: [PATCH v5] clk: tegra: Initialize UTMIPLL when enabling PLLU

2016-06-30 Thread Rhyland Klein
On 6/30/2016 11:37 AM, Thierry Reding wrote: > * PGP Signed by an unknown key > > On Thu, Jun 30, 2016 at 11:32:14AM -0400, Rhyland Klein wrote: >> On 6/17/2016 11:23 AM, Thierry Reding wrote: >>>> Old Signed by an unknown key >>> >>> On Fri, Jun 1

Re: [PATCH v5] clk: tegra: Initialize UTMIPLL when enabling PLLU

2016-06-30 Thread Rhyland Klein
On 6/30/2016 11:37 AM, Thierry Reding wrote: > * PGP Signed by an unknown key > > On Thu, Jun 30, 2016 at 11:32:14AM -0400, Rhyland Klein wrote: >> On 6/17/2016 11:23 AM, Thierry Reding wrote: >>>> Old Signed by an unknown key >>> >>> On Fri, Jun 1

Re: [PATCH v5] clk: tegra: Initialize UTMIPLL when enabling PLLU

2016-06-30 Thread Rhyland Klein
On 6/17/2016 11:23 AM, Thierry Reding wrote: > * PGP Signed by an unknown key > > On Fri, Jun 17, 2016 at 02:49:41PM +0100, Jon Hunter wrote: >> Hi Thierry, >> >> On 26/05/16 17:41, Rhyland Klein wrote: >>> From: Andrew Bresticker <abres...@chromium.org&g

Re: [PATCH v5] clk: tegra: Initialize UTMIPLL when enabling PLLU

2016-06-30 Thread Rhyland Klein
On 6/17/2016 11:23 AM, Thierry Reding wrote: > * PGP Signed by an unknown key > > On Fri, Jun 17, 2016 at 02:49:41PM +0100, Jon Hunter wrote: >> Hi Thierry, >> >> On 26/05/16 17:41, Rhyland Klein wrote: >>> From: Andrew Bresticker >>> >>>

[RESEND PATCH] arm64: defconfig: Enable cros-ec and battery driver

2016-06-29 Thread Rhyland Klein
Enable the ChromeOS Embedded Controller, its I2C tunnel driver, and the BA27XXX battery driver. These are all used on the Tegra210 Smaug platform. Signed-off-by: Rhyland Klein <rkl...@nvidia.com> --- Resending as the issue with power_supply_core/bq27xxx_battery has been resolved. arch

[RESEND PATCH] arm64: defconfig: Enable cros-ec and battery driver

2016-06-29 Thread Rhyland Klein
Enable the ChromeOS Embedded Controller, its I2C tunnel driver, and the BA27XXX battery driver. These are all used on the Tegra210 Smaug platform. Signed-off-by: Rhyland Klein --- Resending as the issue with power_supply_core/bq27xxx_battery has been resolved. arch/arm64/configs/defconfig | 4

[PATCH v3] ARM64: boot: dts: Add regulators for Tegra210 Smaug

2016-06-28 Thread Rhyland Klein
Add regulators to the Tegra210 Smaug DTS file including support for the max77620 PMIC. Signed-off-by: Rhyland Klein <rkl...@nvidia.com> --- v3: - Fixed up ramp delays - s/maxim,enable-sleep/maxim,device-state-on-disabled-event/ - remove GPIO 3 from pp3300 v2: - Updated reg prop

[PATCH v3] ARM64: boot: dts: Add regulators for Tegra210 Smaug

2016-06-28 Thread Rhyland Klein
Add regulators to the Tegra210 Smaug DTS file including support for the max77620 PMIC. Signed-off-by: Rhyland Klein --- v3: - Fixed up ramp delays - s/maxim,enable-sleep/maxim,device-state-on-disabled-event/ - remove GPIO 3 from pp3300 v2: - Updated reg properties to match current binding

Re: [PATCH v4] power_supply: power_supply_read_temp only if use_cnt > 0

2016-06-28 Thread Rhyland Klein
On 6/28/2016 2:20 PM, Sebastian Reichel wrote: > * PGP Signed by an unknown key > > Hi, > > On Thu, Jun 23, 2016 at 01:43:47PM -0400, Rhyland Klein wrote: >> On 6/22/2016 10:23 AM, Sebastian Reichel wrote: >> Is this also going to go into linux-next? > > https:/

Re: [PATCH v4] power_supply: power_supply_read_temp only if use_cnt > 0

2016-06-28 Thread Rhyland Klein
On 6/28/2016 2:20 PM, Sebastian Reichel wrote: > * PGP Signed by an unknown key > > Hi, > > On Thu, Jun 23, 2016 at 01:43:47PM -0400, Rhyland Klein wrote: >> On 6/22/2016 10:23 AM, Sebastian Reichel wrote: >> Is this also going to go into linux-next? > > https:/

RE: [PATCH v5] clk: tegra: Initialize UTMIPLL when enabling PLLU

2016-06-27 Thread Rhyland Klein
Jonathan, can you confirm replacing usleep_range(100, 200) with udelay(2) works for you? -rhyland -Original Message- From: Thierry Reding [mailto:thierry.red...@gmail.com] Sent: Friday, June 17, 2016 11:24 AM To: Jonathan Hunter Cc: Rhyland Klein; Peter De Schrijver; Mike Turquette

RE: [PATCH v5] clk: tegra: Initialize UTMIPLL when enabling PLLU

2016-06-27 Thread Rhyland Klein
Jonathan, can you confirm replacing usleep_range(100, 200) with udelay(2) works for you? -rhyland -Original Message- From: Thierry Reding [mailto:thierry.red...@gmail.com] Sent: Friday, June 17, 2016 11:24 AM To: Jonathan Hunter Cc: Rhyland Klein; Peter De Schrijver; Mike Turquette

Re: [PATCH v4] power_supply: power_supply_read_temp only if use_cnt > 0

2016-06-23 Thread Rhyland Klein
On 6/22/2016 10:23 AM, Sebastian Reichel wrote: > * PGP Signed by an unknown key > > Hi Rhyland, > > On Tue, Jun 21, 2016 at 02:06:55PM -0400, Rhyland Klein wrote: >> Sebastian, might this be accepted soon? We can't enable the bq27xxx >> driver for Tegra210 Smaug wit

Re: [PATCH v4] power_supply: power_supply_read_temp only if use_cnt > 0

2016-06-23 Thread Rhyland Klein
On 6/22/2016 10:23 AM, Sebastian Reichel wrote: > * PGP Signed by an unknown key > > Hi Rhyland, > > On Tue, Jun 21, 2016 at 02:06:55PM -0400, Rhyland Klein wrote: >> Sebastian, might this be accepted soon? We can't enable the bq27xxx >> driver for Tegra210 Smaug wit

Re: [RESEND PATCH] thermal: helpers: Check return value of get_temp

2016-06-23 Thread Rhyland Klein
On 6/6/2016 12:53 PM, Rhyland Klein wrote: > Check the return value of get_temp, which can fail. If it does, then > unlock and return the error code. > > Signed-off-by: Rhyland Klein <rkl...@nvidia.com> > --- > drivers/thermal/thermal_helpers.c | 4 > 1

Re: [RESEND PATCH] thermal: helpers: Check return value of get_temp

2016-06-23 Thread Rhyland Klein
On 6/6/2016 12:53 PM, Rhyland Klein wrote: > Check the return value of get_temp, which can fail. If it does, then > unlock and return the error code. > > Signed-off-by: Rhyland Klein > --- > drivers/thermal/thermal_helpers.c | 4 > 1 file changed, 4 insertions(+) >

[PATCH v3] power_supply: fix return value of get_property

2016-06-22 Thread Rhyland Klein
to the power_supply struct to simply show if registration is completed. Lastly, modify the check in power_supply_show_property() to also ignore -EAGAIN when so it doesn't complain about not returning the property. Signed-off-by: Rhyland Klein <rkl...@nvidia.com> --- v3: - Moved psy->initiali

[PATCH v3] power_supply: fix return value of get_property

2016-06-22 Thread Rhyland Klein
to the power_supply struct to simply show if registration is completed. Lastly, modify the check in power_supply_show_property() to also ignore -EAGAIN when so it doesn't complain about not returning the property. Signed-off-by: Rhyland Klein --- v3: - Moved psy->initialized after atomic increm

Re: [PATCH v4] power_supply: power_supply_read_temp only if use_cnt > 0

2016-06-22 Thread Rhyland Klein
On 6/22/2016 10:23 AM, Sebastian Reichel wrote: > * PGP Signed by an unknown key > > Hi Rhyland, > > On Tue, Jun 21, 2016 at 02:06:55PM -0400, Rhyland Klein wrote: >> Sebastian, might this be accepted soon? We can't enable the bq27xxx >> driver for Tegra210 Smaug wit

Re: [PATCH v4] power_supply: power_supply_read_temp only if use_cnt > 0

2016-06-22 Thread Rhyland Klein
On 6/22/2016 10:23 AM, Sebastian Reichel wrote: > * PGP Signed by an unknown key > > Hi Rhyland, > > On Tue, Jun 21, 2016 at 02:06:55PM -0400, Rhyland Klein wrote: >> Sebastian, might this be accepted soon? We can't enable the bq27xxx >> driver for Tegra210 Smaug wit

Re: [PATCH v2 10/11] clk: Show CRITICAL clks in clk_summary output

2016-06-22 Thread Rhyland Klein
On 6/22/2016 8:24 AM, Thierry Reding wrote: > * PGP Signed by an unknown key > > On Fri, May 27, 2016 at 04:38:13PM -0400, Rhyland Klein wrote: >> Add a '^' character to the beginning of clk entries that are for >> CRITICAL clks. >> >> Signed-off-by:

Re: [PATCH v2 10/11] clk: Show CRITICAL clks in clk_summary output

2016-06-22 Thread Rhyland Klein
On 6/22/2016 8:24 AM, Thierry Reding wrote: > * PGP Signed by an unknown key > > On Fri, May 27, 2016 at 04:38:13PM -0400, Rhyland Klein wrote: >> Add a '^' character to the beginning of clk entries that are for >> CRITICAL clks. >> >> Signed-off-by: Rhyland Kl

Re: [PATCH v2] power_supply: fix return value of get_property

2016-06-21 Thread Rhyland Klein
On 6/16/2016 11:40 AM, Rhyland Klein wrote: > On 6/16/2016 4:43 AM, Krzysztof Kozlowski wrote: >> On 06/16/2016 12:13 AM, Rhyland Klein wrote: >>> power_supply_get_property() should ideally return -EAGAIN if it is >>> called while the power_supply is being r

Re: [PATCH v2] power_supply: fix return value of get_property

2016-06-21 Thread Rhyland Klein
On 6/16/2016 11:40 AM, Rhyland Klein wrote: > On 6/16/2016 4:43 AM, Krzysztof Kozlowski wrote: >> On 06/16/2016 12:13 AM, Rhyland Klein wrote: >>> power_supply_get_property() should ideally return -EAGAIN if it is >>> called while the power_supply is being r

Re: [PATCH v4] power_supply: power_supply_read_temp only if use_cnt > 0

2016-06-21 Thread Rhyland Klein
On 6/9/2016 5:28 PM, Rhyland Klein wrote: > Change power_supply_read_temp() to use power_supply_get_property() > so that it will check the use_cnt and ensure it is > 0. The use_cnt > will be incremented at the end of __power_supply_register, so this > will block to case where g

Re: [PATCH v4] power_supply: power_supply_read_temp only if use_cnt > 0

2016-06-21 Thread Rhyland Klein
On 6/9/2016 5:28 PM, Rhyland Klein wrote: > Change power_supply_read_temp() to use power_supply_get_property() > so that it will check the use_cnt and ensure it is > 0. The use_cnt > will be incremented at the end of __power_supply_register, so this > will block to case where g

Re: [PATCH v2 00/11] Switch to using CRITICAL clks for Tegra

2016-06-21 Thread Rhyland Klein
On 5/27/2016 4:38 PM, Rhyland Klein wrote: > Switch to defining clks that need to be on as CRITICAL rather than > using the init_tables defined to enable clks. Some of these may be > able to be converted to HAND_OFF clks, when that is supported. > > I added a patch to mar

Re: [PATCH v2 00/11] Switch to using CRITICAL clks for Tegra

2016-06-21 Thread Rhyland Klein
On 5/27/2016 4:38 PM, Rhyland Klein wrote: > Switch to defining clks that need to be on as CRITICAL rather than > using the init_tables defined to enable clks. Some of these may be > able to be converted to HAND_OFF clks, when that is supported. > > I added a patch to mar

Re: [PATCH v5] clk: tegra: Initialize UTMIPLL when enabling PLLU

2016-06-20 Thread Rhyland Klein
On 6/17/2016 11:23 AM, Thierry Reding wrote: > * PGP Signed by an unknown key > > On Fri, Jun 17, 2016 at 02:49:41PM +0100, Jon Hunter wrote: >> Hi Thierry, >> >> On 26/05/16 17:41, Rhyland Klein wrote: >>> From: Andrew Bresticker <abres...@chromium.org&g

Re: [PATCH v5] clk: tegra: Initialize UTMIPLL when enabling PLLU

2016-06-20 Thread Rhyland Klein
On 6/17/2016 11:23 AM, Thierry Reding wrote: > * PGP Signed by an unknown key > > On Fri, Jun 17, 2016 at 02:49:41PM +0100, Jon Hunter wrote: >> Hi Thierry, >> >> On 26/05/16 17:41, Rhyland Klein wrote: >>> From: Andrew Bresticker >>> >>>

Re: [PATCH v2] power_supply: fix return value of get_property

2016-06-16 Thread Rhyland Klein
On 6/16/2016 4:43 AM, Krzysztof Kozlowski wrote: > On 06/16/2016 12:13 AM, Rhyland Klein wrote: >> power_supply_get_property() should ideally return -EAGAIN if it is >> called while the power_supply is being registered. There was no way >> previously to determine

Re: [PATCH v2] power_supply: fix return value of get_property

2016-06-16 Thread Rhyland Klein
On 6/16/2016 4:43 AM, Krzysztof Kozlowski wrote: > On 06/16/2016 12:13 AM, Rhyland Klein wrote: >> power_supply_get_property() should ideally return -EAGAIN if it is >> called while the power_supply is being registered. There was no way >> previously to determine

[PATCH v2] power_supply: fix return value of get_property

2016-06-15 Thread Rhyland Klein
to the power_supply struct to simply show if registration is completed. Lastly, modify the check in power_supply_show_property() to also ignore -EAGAIN when so it doesn't complain about not returning the property. Signed-off-by: Rhyland Klein <rkl...@nvidia.com> --- v2: -

[PATCH v2] power_supply: fix return value of get_property

2016-06-15 Thread Rhyland Klein
to the power_supply struct to simply show if registration is completed. Lastly, modify the check in power_supply_show_property() to also ignore -EAGAIN when so it doesn't complain about not returning the property. Signed-off-by: Rhyland Klein --- v2: - Modify power_supply_show_property() to not complain

Re: [PATCH v4] power_supply: power_supply_read_temp only if use_cnt > 0

2016-06-14 Thread Rhyland Klein
On 6/10/2016 5:43 AM, Krzysztof Kozlowski wrote: > On 06/09/2016 11:28 PM, Rhyland Klein wrote: >> Change power_supply_read_temp() to use power_supply_get_property() >> so that it will check the use_cnt and ensure it is > 0. The use_cnt >> will be incremented at the end of

Re: [PATCH v4] power_supply: power_supply_read_temp only if use_cnt > 0

2016-06-14 Thread Rhyland Klein
On 6/10/2016 5:43 AM, Krzysztof Kozlowski wrote: > On 06/09/2016 11:28 PM, Rhyland Klein wrote: >> Change power_supply_read_temp() to use power_supply_get_property() >> so that it will check the use_cnt and ensure it is > 0. The use_cnt >> will be incremented at the end of

Re: [PATCH] mfd: max77620: Fix FPS switch statements

2016-06-14 Thread Rhyland Klein
On 6/7/2016 4:05 AM, Lee Jones wrote: > On Thu, 12 May 2016, Rhyland Klein wrote: > >> When configuring FPS during probe, assuming a DT node is present for >> FPS, the code can run into a problem with the switch statements in >> max77620_config_fps() and max77620_

Re: [PATCH] mfd: max77620: Fix FPS switch statements

2016-06-14 Thread Rhyland Klein
On 6/7/2016 4:05 AM, Lee Jones wrote: > On Thu, 12 May 2016, Rhyland Klein wrote: > >> When configuring FPS during probe, assuming a DT node is present for >> FPS, the code can run into a problem with the switch statements in >> max77620_config_fps() and max77620_

[PATCH] power_supply: fix return value of get_property

2016-06-13 Thread Rhyland Klein
to the power_supply struct to simply show if registration is completed. Signed-off-by: Rhyland Klein <rkl...@nvidia.com> --- This patch continues what was discussed with the patch "power_supply: power_supply_read_temp only if use_cnt > 0". Looking at the thermal code, it looks like we s

[PATCH] power_supply: fix return value of get_property

2016-06-13 Thread Rhyland Klein
to the power_supply struct to simply show if registration is completed. Signed-off-by: Rhyland Klein --- This patch continues what was discussed with the patch "power_supply: power_supply_read_temp only if use_cnt > 0". Looking at the thermal code, it looks like we should indeed return EAGAI

[PATCH v4] power_supply: power_supply_read_temp only if use_cnt > 0

2016-06-09 Thread Rhyland Klein
AIN from -ENODEV if use_cnt <= 0. Fixes: 297d716f6260 ("power_supply: Change ownership from driver to core") Cc: sta...@vger.kernel.org Signed-off-by: Rhyland Klein <rkl...@nvidia.com> --- v4: - Fixed return check conditions - Removed change to power_supply_get_property

[PATCH v4] power_supply: power_supply_read_temp only if use_cnt > 0

2016-06-09 Thread Rhyland Klein
AIN from -ENODEV if use_cnt <= 0. Fixes: 297d716f6260 ("power_supply: Change ownership from driver to core") Cc: sta...@vger.kernel.org Signed-off-by: Rhyland Klein --- v4: - Fixed return check conditions - Removed change to power_supply_get_property return code - removed white

[PATCH v2] ARM64: boot: dts: Add regulators for Tegra210 Smaug

2016-06-09 Thread Rhyland Klein
Add regulators to the Tegra210 Smaug DTS file including support for the max77620 PMIC. Signed-off-by: Rhyland Klein <rkl...@nvidia.com> --- v2: - Updated reg properties to match current binding arch/arm64/boot/dts/nvidia/tegra210-smaug.dts | 323 ++ 1 file change

[PATCH v2] ARM64: boot: dts: Add regulators for Tegra210 Smaug

2016-06-09 Thread Rhyland Klein
Add regulators to the Tegra210 Smaug DTS file including support for the max77620 PMIC. Signed-off-by: Rhyland Klein --- v2: - Updated reg properties to match current binding arch/arm64/boot/dts/nvidia/tegra210-smaug.dts | 323 ++ 1 file changed, 323 insertions(+) diff

Re: [PATCH v3] power_supply: power_supply_read_temp only if use_cnt > 0

2016-06-09 Thread Rhyland Klein
On 6/9/2016 6:05 AM, Krzysztof Kozlowski wrote: > On 06/08/2016 05:26 PM, Rhyland Klein wrote: >> On 6/8/2016 2:35 AM, Krzysztof Kozlowski wrote: >>> On 06/07/2016 10:26 PM, Rhyland Klein wrote: >>>> Change power_supply_read_temp() to use power_supply_get_propert

Re: [PATCH v3] power_supply: power_supply_read_temp only if use_cnt > 0

2016-06-09 Thread Rhyland Klein
On 6/9/2016 6:05 AM, Krzysztof Kozlowski wrote: > On 06/08/2016 05:26 PM, Rhyland Klein wrote: >> On 6/8/2016 2:35 AM, Krzysztof Kozlowski wrote: >>> On 06/07/2016 10:26 PM, Rhyland Klein wrote: >>>> Change power_supply_read_temp() to use power_supply_get_propert

Re: [PATCH v3] power_supply: power_supply_read_temp only if use_cnt > 0

2016-06-08 Thread Rhyland Klein
On 6/8/2016 2:35 AM, Krzysztof Kozlowski wrote: > On 06/07/2016 10:26 PM, Rhyland Klein wrote: >> Change power_supply_read_temp() to use power_supply_get_property() >> so that it will check the use_cnt and ensure it is > 0. The use_cnt >> will be incremented at the end of

Re: [PATCH v3] power_supply: power_supply_read_temp only if use_cnt > 0

2016-06-08 Thread Rhyland Klein
On 6/8/2016 2:35 AM, Krzysztof Kozlowski wrote: > On 06/07/2016 10:26 PM, Rhyland Klein wrote: >> Change power_supply_read_temp() to use power_supply_get_property() >> so that it will check the use_cnt and ensure it is > 0. The use_cnt >> will be incremented at the end of

[PATCH v3] power_supply: power_supply_read_temp only if use_cnt > 0

2016-06-07 Thread Rhyland Klein
AIN from -ENODEV if use_cnt <= 0. Fixes: 297d716f6260 ("power_supply: Change ownership from driver to core") Cc: sta...@vger.kernel.org Signed-off-by: Rhyland Klein <rkl...@nvidia.com> --- v3: - Changed calls to ->get_property() to use common power_supply_get_property() - re

[PATCH v3] power_supply: power_supply_read_temp only if use_cnt > 0

2016-06-07 Thread Rhyland Klein
AIN from -ENODEV if use_cnt <= 0. Fixes: 297d716f6260 ("power_supply: Change ownership from driver to core") Cc: sta...@vger.kernel.org Signed-off-by: Rhyland Klein --- v3: - Changed calls to ->get_property() to use common power_supply_get_property() - reworded description,

Re: [RESEND PATCH v2] power_supply: power_supply_read_temp only if use_cnt > 0

2016-06-07 Thread Rhyland Klein
On 6/7/2016 3:23 AM, Krzysztof Kozlowski wrote: > On 06/06/2016 06:56 PM, Rhyland Klein wrote: >> Add check to power_supply_read_temp() to only use the power_supply >> get_property() callback if the use_cnt is > 0. The use_cnt will >> be incremented at the end of __p

Re: [RESEND PATCH v2] power_supply: power_supply_read_temp only if use_cnt > 0

2016-06-07 Thread Rhyland Klein
On 6/7/2016 3:23 AM, Krzysztof Kozlowski wrote: > On 06/06/2016 06:56 PM, Rhyland Klein wrote: >> Add check to power_supply_read_temp() to only use the power_supply >> get_property() callback if the use_cnt is > 0. The use_cnt will >> be incremented at the end of __p

Re: [PATCH] ARM64: boot: dts: Add regulators for Tegra210 Smaug

2016-06-06 Thread Rhyland Klein
On 6/6/2016 2:39 AM, Laxman Dewangan wrote: > > On Saturday 04 June 2016 01:52 AM, Rhyland Klein wrote: >> + >> +max77620_default: pinmux@0 { >> +pin_gpio { >> +pins = "g

Re: [PATCH] ARM64: boot: dts: Add regulators for Tegra210 Smaug

2016-06-06 Thread Rhyland Klein
On 6/6/2016 2:39 AM, Laxman Dewangan wrote: > > On Saturday 04 June 2016 01:52 AM, Rhyland Klein wrote: >> + >> +max77620_default: pinmux@0 { >> +pin_gpio { >> +pins = "g

[RESEND PATCH v2] power_supply: power_supply_read_temp only if use_cnt > 0

2016-06-06 Thread Rhyland Klein
886] kernel_init_freeable+0x148/0x1ec [1.566972] kernel_init+0x10/0xfc [1.572101] ret_from_fork+0x10/0x40 Cc: sta...@vger.kernel.org Signed-off-by: Rhyland Klein <rkl...@nvidia.com> --- v2: - Added cc stable - changed return to -EAGAIN in case of use_cnt < 1 - Removed WARNING -

[RESEND PATCH v2] power_supply: power_supply_read_temp only if use_cnt > 0

2016-06-06 Thread Rhyland Klein
886] kernel_init_freeable+0x148/0x1ec [1.566972] kernel_init+0x10/0xfc [1.572101] ret_from_fork+0x10/0x40 Cc: sta...@vger.kernel.org Signed-off-by: Rhyland Klein --- v2: - Added cc stable - changed return to -EAGAIN in case of use_cnt < 1 - Removed WARNING - return value check

[PATCH] power_supply: power_supply_read_temp only if use_cnt > 0

2016-06-06 Thread Rhyland Klein
886] kernel_init_freeable+0x148/0x1ec [1.566972] kernel_init+0x10/0xfc [1.572101] ret_from_fork+0x10/0x40 Cc: sta...@vger.kernel.org Signed-off-by: Rhyland Klein <rkl...@nvidia.com> --- v2: - Added cc stable - changed return to -EAGAIN in case of use_cnt < 1 - Removed WARNING -

[PATCH] power_supply: power_supply_read_temp only if use_cnt > 0

2016-06-06 Thread Rhyland Klein
886] kernel_init_freeable+0x148/0x1ec [1.566972] kernel_init+0x10/0xfc [1.572101] ret_from_fork+0x10/0x40 Cc: sta...@vger.kernel.org Signed-off-by: Rhyland Klein --- v2: - Added cc stable - changed return to -EAGAIN in case of use_cnt < 1 - Removed WARNING - return value check

[RESEND PATCH] thermal: helpers: Check return value of get_temp

2016-06-06 Thread Rhyland Klein
Check the return value of get_temp, which can fail. If it does, then unlock and return the error code. Signed-off-by: Rhyland Klein <rkl...@nvidia.com> --- drivers/thermal/thermal_helpers.c | 4 1 file changed, 4 insertions(+) diff --git a/drivers/thermal/thermal_helpers.c b/d

[RESEND PATCH] thermal: helpers: Check return value of get_temp

2016-06-06 Thread Rhyland Klein
Check the return value of get_temp, which can fail. If it does, then unlock and return the error code. Signed-off-by: Rhyland Klein --- drivers/thermal/thermal_helpers.c | 4 1 file changed, 4 insertions(+) diff --git a/drivers/thermal/thermal_helpers.c b/drivers/thermal

[PATCH 1/2] thermal: helpers: Check return value of get_temp

2016-06-06 Thread Rhyland Klein
Check the return value of get_temp, which can fail. If it does, then unlock and return the error code. Signed-off-by: Rhyland Klein <rkl...@nvidia.com> --- drivers/thermal/thermal_helpers.c | 4 1 file changed, 4 insertions(+) diff --git a/drivers/thermal/thermal_helpers.c b/d

[PATCH 1/2] thermal: helpers: Check return value of get_temp

2016-06-06 Thread Rhyland Klein
Check the return value of get_temp, which can fail. If it does, then unlock and return the error code. Signed-off-by: Rhyland Klein --- drivers/thermal/thermal_helpers.c | 4 1 file changed, 4 insertions(+) diff --git a/drivers/thermal/thermal_helpers.c b/drivers/thermal

Re: [PATCH] power_supply: power_supply_read_temp only if use_cnt > 0

2016-06-06 Thread Rhyland Klein
On 6/4/2016 9:30 AM, Sebastian Reichel wrote: > * PGP Signed by an unknown key > > Hi Rhyland, > > Thanks for the patch. > > On Fri, Jun 03, 2016 at 04:30:50PM -0400, Rhyland Klein wrote: >> Add check to power_supply_read_temp() to only use the power_supply

Re: [PATCH] power_supply: power_supply_read_temp only if use_cnt > 0

2016-06-06 Thread Rhyland Klein
On 6/4/2016 9:30 AM, Sebastian Reichel wrote: > * PGP Signed by an unknown key > > Hi Rhyland, > > Thanks for the patch. > > On Fri, Jun 03, 2016 at 04:30:50PM -0400, Rhyland Klein wrote: >> Add check to power_supply_read_temp() to only use the power_supply

[PATCH] power_supply: power_supply_read_temp only if use_cnt > 0

2016-06-03 Thread Rhyland Klein
886] kernel_init_freeable+0x148/0x1ec [1.566972] kernel_init+0x10/0xfc [1.572101] ret_from_fork+0x10/0x40 Signed-off-by: Rhyland Klein <rkl...@nvidia.com> --- drivers/power/power_supply_core.c | 9 +++-- 1 file changed, 7 insertions(+), 2 deletions(-) diff --git a/driv

[PATCH] power_supply: power_supply_read_temp only if use_cnt > 0

2016-06-03 Thread Rhyland Klein
886] kernel_init_freeable+0x148/0x1ec [1.566972] kernel_init+0x10/0xfc [1.572101] ret_from_fork+0x10/0x40 Signed-off-by: Rhyland Klein --- drivers/power/power_supply_core.c | 9 +++-- 1 file changed, 7 insertions(+), 2 deletions(-) diff --git a/drivers/power/power_supply_core.c b/driv

[PATCH] ARM64: boot: dts: Add regulators for Tegra210 Smaug

2016-06-03 Thread Rhyland Klein
Add regulators to the Tegra210 Smaug DTS file including support for the max77620 PMIC. Signed-off-by: Rhyland Klein <rkl...@nvidia.com> --- arch/arm64/boot/dts/nvidia/tegra210-smaug.dts | 350 ++ 1 file changed, 350 insertions(+) diff --git a/arch/arm64/boot/dts/

[PATCH] ARM64: boot: dts: Add regulators for Tegra210 Smaug

2016-06-03 Thread Rhyland Klein
Add regulators to the Tegra210 Smaug DTS file including support for the max77620 PMIC. Signed-off-by: Rhyland Klein --- arch/arm64/boot/dts/nvidia/tegra210-smaug.dts | 350 ++ 1 file changed, 350 insertions(+) diff --git a/arch/arm64/boot/dts/nvidia/tegra210-smaug.dts

Re: [PATCH] mfd: max77620: Fix FPS switch statements

2016-06-01 Thread Rhyland Klein
On 5/31/2016 3:30 AM, Lee Jones wrote: > On Fri, 27 May 2016, Rhyland Klein wrote: > >> On 5/12/2016 1:52 PM, Laxman Dewangan wrote: >>> >>> On Thursday 12 May 2016 11:15 PM, Rhyland Klein wrote: >>>> When configuring FPS during probe, assuming a DT node

Re: [PATCH] mfd: max77620: Fix FPS switch statements

2016-06-01 Thread Rhyland Klein
On 5/31/2016 3:30 AM, Lee Jones wrote: > On Fri, 27 May 2016, Rhyland Klein wrote: > >> On 5/12/2016 1:52 PM, Laxman Dewangan wrote: >>> >>> On Thursday 12 May 2016 11:15 PM, Rhyland Klein wrote: >>>> When configuring FPS during probe, assuming a DT node

[PATCH v2 04/11] clk: tegra30: Mark certain clks as critical

2016-05-27 Thread Rhyland Klein
Mark the required clks as critical so the core will enable them during registration and therefore they will stay on. Signed-off-by: Rhyland Klein <rkl...@nvidia.com> --- drivers/clk/tegra/clk-tegra30.c | 14 -- 1 file changed, 8 insertions(+), 6 deletions(-) diff --git a/drive

[PATCH v2 04/11] clk: tegra30: Mark certain clks as critical

2016-05-27 Thread Rhyland Klein
Mark the required clks as critical so the core will enable them during registration and therefore they will stay on. Signed-off-by: Rhyland Klein --- drivers/clk/tegra/clk-tegra30.c | 14 -- 1 file changed, 8 insertions(+), 6 deletions(-) diff --git a/drivers/clk/tegra/clk-tegra30

[PATCH v2 03/11] clk: tegra20: clean up init_table

2016-05-27 Thread Rhyland Klein
Remove entries from the init_table where the clks are now defined as CRITICAL clks, if we were only enabling them in the init_table. Remove the flag to signal to enable CRITICAL clks if they are still needed in the init_table to set other properties. Signed-off-by: Rhyland Klein <

[PATCH v2 01/11] clk: tegra: Switch to using critical clks

2016-05-27 Thread Rhyland Klein
Mark some of the required-to-be-enabled clks as critical clks. These need to be kept on through the disabling of unused clks during init. They may not get any reference before or after init, but are required to be on, therefore let the core enable them. Signed-off-by: Rhyland Klein <

[PATCH v2 03/11] clk: tegra20: clean up init_table

2016-05-27 Thread Rhyland Klein
Remove entries from the init_table where the clks are now defined as CRITICAL clks, if we were only enabling them in the init_table. Remove the flag to signal to enable CRITICAL clks if they are still needed in the init_table to set other properties. Signed-off-by: Rhyland Klein --- drivers

[PATCH v2 01/11] clk: tegra: Switch to using critical clks

2016-05-27 Thread Rhyland Klein
Mark some of the required-to-be-enabled clks as critical clks. These need to be kept on through the disabling of unused clks during init. They may not get any reference before or after init, but are required to be on, therefore let the core enable them. Signed-off-by: Rhyland Klein --- v2

[PATCH v2 05/11] clk: tegra30: clean up init_table

2016-05-27 Thread Rhyland Klein
Remove entries from the init_table where the clks are now defined as CRITICAL clks, if we were only enabling them in the init_table. Remove the flag to signal to enable CRITICAL clks if they are still needed in the init_table to set other properties. Signed-off-by: Rhyland Klein <

[PATCH v2 05/11] clk: tegra30: clean up init_table

2016-05-27 Thread Rhyland Klein
Remove entries from the init_table where the clks are now defined as CRITICAL clks, if we were only enabling them in the init_table. Remove the flag to signal to enable CRITICAL clks if they are still needed in the init_table to set other properties. Signed-off-by: Rhyland Klein --- drivers

[PATCH v2 09/11] clk: tegra210: clean up init_table

2016-05-27 Thread Rhyland Klein
Remove entries from the init_table where the clks are now defined as CRITICAL clks, if we were only enabling them in the init_table. Remove the flag to signal to enable CRITICAL clks if they are still needed in the init_table to set other properties. Signed-off-by: Rhyland Klein <

[PATCH v2 08/11] clk: tegra210: Mark required clks as CRITICAL

2016-05-27 Thread Rhyland Klein
Mark clks that are required to be on as CRITICAL clks. Signed-off-by: Rhyland Klein <rkl...@nvidia.com> --- drivers/clk/tegra/clk-tegra210.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/clk/tegra/clk-tegra210.c b/drivers/clk/tegra/clk-tegra210.c index b85518

[PATCH v2 08/11] clk: tegra210: Mark required clks as CRITICAL

2016-05-27 Thread Rhyland Klein
Mark clks that are required to be on as CRITICAL clks. Signed-off-by: Rhyland Klein --- drivers/clk/tegra/clk-tegra210.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/clk/tegra/clk-tegra210.c b/drivers/clk/tegra/clk-tegra210.c index b8551813ec43..156dc8ec6bf6

[PATCH v2 09/11] clk: tegra210: clean up init_table

2016-05-27 Thread Rhyland Klein
Remove entries from the init_table where the clks are now defined as CRITICAL clks, if we were only enabling them in the init_table. Remove the flag to signal to enable CRITICAL clks if they are still needed in the init_table to set other properties. Signed-off-by: Rhyland Klein --- drivers

[PATCH v2 06/11] clk: tegra114: clean up init_table

2016-05-27 Thread Rhyland Klein
Remove entries from the init_table where the clks are now defined as CRITICAL clks, if we were only enabling them in the init_table. Remove the flag to signal to enable CRITICAL clks if they are still needed in the init_table to set other properties. Signed-off-by: Rhyland Klein <

[PATCH v2 06/11] clk: tegra114: clean up init_table

2016-05-27 Thread Rhyland Klein
Remove entries from the init_table where the clks are now defined as CRITICAL clks, if we were only enabling them in the init_table. Remove the flag to signal to enable CRITICAL clks if they are still needed in the init_table to set other properties. Signed-off-by: Rhyland Klein --- drivers

[PATCH v2 10/11] clk: Show CRITICAL clks in clk_summary output

2016-05-27 Thread Rhyland Klein
Add a '^' character to the beginning of clk entries that are for CRITICAL clks. Signed-off-by: Rhyland Klein <rkl...@nvidia.com> --- drivers/clk/clk.c | 7 +-- 1 file changed, 5 insertions(+), 2 deletions(-) diff --git a/drivers/clk/clk.c b/drivers/clk/clk.c index 874c7dd8ef66..22dd0c

[PATCH v2 02/11] clk: tegra20: Mark required clks as CRITICAL

2016-05-27 Thread Rhyland Klein
Mark clks that are required to be on as CRITICAL clks. Signed-off-by: Rhyland Klein <rkl...@nvidia.com> --- drivers/clk/tegra/clk-tegra20.c | 12 +++- 1 file changed, 7 insertions(+), 5 deletions(-) diff --git a/drivers/clk/tegra/clk-tegra20.c b/drivers/clk/tegra/clk-tegra20.c

[PATCH v2 10/11] clk: Show CRITICAL clks in clk_summary output

2016-05-27 Thread Rhyland Klein
Add a '^' character to the beginning of clk entries that are for CRITICAL clks. Signed-off-by: Rhyland Klein --- drivers/clk/clk.c | 7 +-- 1 file changed, 5 insertions(+), 2 deletions(-) diff --git a/drivers/clk/clk.c b/drivers/clk/clk.c index 874c7dd8ef66..22dd0ca1e491 100644

[PATCH v2 02/11] clk: tegra20: Mark required clks as CRITICAL

2016-05-27 Thread Rhyland Klein
Mark clks that are required to be on as CRITICAL clks. Signed-off-by: Rhyland Klein --- drivers/clk/tegra/clk-tegra20.c | 12 +++- 1 file changed, 7 insertions(+), 5 deletions(-) diff --git a/drivers/clk/tegra/clk-tegra20.c b/drivers/clk/tegra/clk-tegra20.c index 837e5cbd60e9

  1   2   3   4   5   6   7   8   >