Hi Miguel,
On 05 Dec 2018 17:47, Miguel Ojeda wrote:> Hi Mans,
>
> [CC'ing a few people involved previously on this]
Thanks for CC'ing me!
On 06 Dec 2018 11:06, Miguel Ojeda wrote [to Mans Rullgard]:
> Are you able to test this?
It's unfortunate that my original comment got ignored back when th
Hi!
I found a dependency issue with gpiochip and pinctrl while using the gpio-hog
feature that was implemented by Benoit
Parrot in f625d4601759f. Relevant device-tree overlay shown below [3].
I ran into a deadlock situation, because adding a gpiochip requires a
registered pinctrl with registere
The current version does not parse x/y commands at all.
Simplify the x/y command syntax to the one indicated in
the comment all along and introduce a parsing function
that handles parsing a sequence of one or two subcommands
where each subcommand must appear at most once.
Signed-off-by: Robert
#x27; home
function.
Implement fast clearing of LCD by going to x0/y0 first, clearing display and
then calling home to possibly unshift display possibly avoiding artifacts by
not unshifting before clearing display.
Signed-off-by: Robert Abel
---
drivers/auxdisplay/char
code to the home and clear_fast functions
and explains their behavior a bit more.
Robert Abel (2):
auxdisplay: charlcd: fix x/y address commands
auxdisplay: charlcd: make home command unshift display
drivers/auxdisplay/charlcd.c | 137 ++-
1 file
Hi Willy,
On 27 Feb 2018 06:19, Willy Tarreau wrote:
> Well actually I don't see a problem there at all. The principle is simply
> to accept any sequence assigning x or y or both. If you write x4y2x6, it
> simply means that you changed your mind regarding x and that the last
> value (6) is the one
On 27 Feb 2018 23:09, Miguel Ojeda wrote:> @@ -469,24 +543,11 @@ static
inline int handle_lcd_special_code(struct charlcd *lcd)
> }
> case 'x': /* gotoxy : LxXXX[yYYY]; */
> case 'y': /* gotoxy : LyYYY[xXXX]; */
> - if (!strchr(esc, ';'))
> -
On 26 Feb 2018 00:54, Robert Abel wrote:> Robert Abel (4):
> auxdisplay: charlcd: fix two-line command ^[[LN not marked as
> processed
> auxdisplay: charlcd: name x/y address struct
> auxdisplay: charlcd: fix x/y address commands
> auxdisplay: charlcd: make home comma
Hi Miguel,
On 26 Feb 2018 17:49, Miguel Ojeda wrote:
> On Mon, Feb 26, 2018 at 12:54 AM, Robert Abel wrote:
>> + /* clamp new x/y coordinates */
>> + if (tmp_addr.x >= lcd->width)
>> + tmp_addr.x = lcd->width - 1;
&g
Hi @ll,
this is a discussion stemming from drivers/auxdisplay about the usage
and possible deprecation of simple_strto* set of functions found in
lib/vsprintf.
I cc'ed everybody who signed off and also everybody who
signed/authored/added/removed more than 20% of lib/vsprintf.
This has come up, be
On 26 Feb 2018 17:49, Miguel Ojeda wrote:
> On a general note, the code seems a bit convoluted for what it does,
> specially without the comment written in the commit message :-) Isn't
> it simpler to use a tiny array in the stack and put the numbers to be
> converted instead of modifying the input
Hi Andy, Hi Miguel,
On 26 Feb 2018 12:44, Andy Shevchenko wrote:
> Can we avoid yoda style of programming?
On 26 Feb 2018 17:49, Miguel Ojeda wrote:
> Please do not change the style of the code w.r.t to the rest of the
> file, which writes tests with the non-lvalue on the right-hand side
> and do
Hi Geert,
On 26 Feb 2018 09:46, Geert Uytterhoeven wrote:
>> +
>> + nxt_cmd = *esc++;
>> + nxt_esc = esc;
>> +
>> + while ('\0' != *esc) {
>> +
>> + cmd = nxt_cmd;
>> + esc = nxt_esc;
>> + n
NUL-terminate each individual number to be parsed.
To do this, the next command character and a pointer to its argument
are found and stored. The command character is then overwritten by NUL
before kstr* functions are called on the buffer.
Signed-off-by: Robert Abel
---
drivers/auxdisplay
Signed-off-by: Robert Abel
---
drivers/auxdisplay/charlcd.c | 1 +
1 file changed, 1 insertion(+)
diff --git a/drivers/auxdisplay/charlcd.c b/drivers/auxdisplay/charlcd.c
index a3486db03d81..e3b2fd15c5a3 100644
--- a/drivers/auxdisplay/charlcd.c
+++ b/drivers/auxdisplay/charlcd.c
@@ -362,6
Signed-off-by: Robert Abel
---
drivers/auxdisplay/charlcd.c | 12 +++-
1 file changed, 7 insertions(+), 5 deletions(-)
diff --git a/drivers/auxdisplay/charlcd.c b/drivers/auxdisplay/charlcd.c
index e3b2fd15c5a3..a3d364e6c666 100644
--- a/drivers/auxdisplay/charlcd.c
+++ b/drivers
#x27; home
function.
Implement fast clearing of LCD by going to x0/y0 first, clearing display and
then calling home to possibly unshift display possibly avoiding artifacts by
not unshifting before clearing display.
Signed-off-by: Robert Abel
---
drivers/auxdisplay/charlcd.c | 10 --
1 fi
xcept for init ^[[LI). So I implemented the HOME
command 0x02
for charlcd_home. The old behavior can be simulated using ^[[Lx0y0; (just reset
x/y, don't
unshift).
I tested on my Raspberry Pi Zero W with a clone 1602 display.
Robert Abel (4):
auxdisplay: charlcd: fix two-line command
xcept for init ^[[LI). So I implemented the HOME
command 0x02
for charlcd_home. The old behavior can be simulated using ^[[Lx0y0; (just reset
x/y, don't
unshift).
I tested on my Raspberry Pi Zero W with a clone 1602 display.
Robert Abel (4):
auxdisplay: charlcd: fix two-line command
Hi Andy,
On 15 Feb 2018 11:57, Andy Shevchenko wrote:
> On Thu, Feb 15, 2018 at 1:17 AM, Robert Abel wrote:
>> hex_to_bin look fine to me, although personally I'm not a big fan of its
>> use of tolower.
>
> Let's duplicate then over and over?
I was speaking m
On 13 Feb 2018 14:36, Andy Shevchenko wrote:
> I understand that we have a huge and hopefully nice library in the
> kernel, but the question still the same, what prevents a developer or
> maintainer to look at it from time to time?
>
> For, I dare to say, ages we have hex_to_bin() and hex2bin().
>
There is no need to resort to octal escape sequence for the form feed character
when an established escape sequence exists.
Signed-off-by: Robert Abel
---
drivers/auxdisplay/charlcd.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/auxdisplay/charlcd.c b/drivers
Using '\0' instead of plain 0 makes the intent clearer that this is indeed a
string and not a series of integers.
Signed-off-by: Robert Abel
---
drivers/auxdisplay/charlcd.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/drivers/auxdisplay/charlcd.c
The graphics command expects 16 hexadecimal literals, but would allow
characters in range [0-9a-zA-Z] instead of [0-9a-fA-F].
Signed-off-by: Robert Abel
---
drivers/auxdisplay/charlcd.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/drivers/auxdisplay/charlcd.c b
While looking at charlcd I noticed some little bits here and there that might
be corrected or improved.
Robert Abel (3):
auxdisplay: charlcd: fix hex literal ranges for graphics command
auxdisplay: charlcd: use null character instead of zero literal to
terminate strings
auxdisplay
This patch prevents a kernel OOPS when removing a DT overlay containing
nodes with reg properties. release_resources is called for these nodes.
However, the resource structs were never initialized, hence the kernel OOPS.
This is obviously a stopgap measure until a proper solution is coded, see [1
Signed-off-by: Robert ABEL
---
kernel/resource.c | 7 +++
1 file changed, 7 insertions(+)
diff --git a/kernel/resource.c b/kernel/resource.c
index 0bcebff..b4c9b27 100644
--- a/kernel/resource.c
+++ b/kernel/resource.c
@@ -236,6 +236,13 @@ static int __release_resource(struct resource *old
pdata char* name => const char* name
Signed-off-by: Robert ABEL
---
include/linux/rfkill-regulator.h | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/include/linux/rfkill-regulator.h b/include/linux/rfkill-regulator.h
index aca36bc..594d8e7 100644
--- a/include/linux/rfk
Hi Roger,
On Tue, Mar 3, 2015 at 1:55 PM, Roger Quadros wrote:
> I'm OK with this version.
>
> Tony, after you ACK these I will queue them for v4.1.
Please use v4 of my patches. The DTS output has been changed and the
comments have their colon.
Regards,
Robert
--
To unsubscribe from this list:
Hi Roger,
On Tue, Mar 3, 2015 at 11:09 AM, Roger Quadros wrote:
> If that is the case then I'd rather not check for return value of
> of_platform_populate().
> Failure in populating GPMC child's children is already out of scope of GPMC
> driver.
Well, I'd rather leave it in for now. If somethi
WAITMONITORINGTIME delay.
This patch correctly computes WAITMONITORINGTIME in GPMC_CLK cycles instead of
GPMC_FCLK cycles,
both during programming (gpmc_cs_set_timings) and during retrieval
(gpmc_cs_show_timings).
Signed-off-by: Robert ABEL
---
drivers/memory/omap-gpmc.c | 128
WAITMONITORINGTIME delay.
Calculate GPMCFCLKDIVIDER independent of gpmc,sync-clk-ps in DT for
pure asynchronous accesses, i.e. both read and write asynchronous.
Signed-off-by: Robert ABEL
---
arch/arm/mach-omap2/gpmc-nand.c| 17
arch/arm/mach-omap2/gpmc-onenand.c | 4 +-
arch/arm/mach
gpmc_cs_show_timings for
-CLKACTIVATIONTIME
-WAITMONITORINGTIME
-DEVICESIZE
-ATTACHEDDEVICEPAGELENGTH
Signed-off-by: Robert ABEL
---
drivers/memory/omap-gpmc.c | 68 ++
1 file changed, 45 insertions(+), 23 deletions(-)
diff --git a/drivers/memory/omap
OMAP2+ GPMC driver undefines DEBUG, which makes it unnecessarily
hard to turn DEBUG on. Remove the offending lines.
Signed-off-by: Robert ABEL
---
drivers/memory/omap-gpmc.c | 2 --
1 file changed, 2 deletions(-)
diff --git a/drivers/memory/omap-gpmc.c b/drivers/memory/omap-gpmc.c
index
lkml.org/lkml/2015/2/24/609
[4]: https://lkml.org/lkml/2015/2/26/387
Robert ABEL (9):
ARM OMAP2+ GPMC: don't undef DEBUG
ARM OMAP2+ GPMC: add bus children
ARM OMAP2+ GPMC: fix debug output alignment
ARM OMAP2+ GPMC: change get_gpmc_timing_reg output for DTS
ARM OMAP2+ GPMC: always
WAITMONITORINGTIME delay.
Signed-off-by: Robert ABEL
---
drivers/memory/omap-gpmc.c | 17 ++---
1 file changed, 6 insertions(+), 11 deletions(-)
diff --git a/drivers/memory/omap-gpmc.c b/drivers/memory/omap-gpmc.c
index 432e638..02e5228 100644
--- a/drivers/memory/omap-gpmc.c
+++ b
DTS output was formatted to require additional work when copy-pasting into DTS.
Nano-second timings were replaced with interval of values that produce the same
number of clock ticks.
Signed-off-by: Robert ABEL
---
drivers/memory/omap-gpmc.c | 38 --
1 file
This patch adds support for spawning buses as children of the GPMC.
Signed-off-by: Robert ABEL
---
drivers/memory/omap-gpmc.c | 17 +++--
1 file changed, 15 insertions(+), 2 deletions(-)
diff --git a/drivers/memory/omap-gpmc.c b/drivers/memory/omap-gpmc.c
index 5cabac8..74a8c52
GPMC debug output is aligned to 10 characters for field names.
However, some fields have bigger names, screwing up the alignment.
Consequently, alignment was changed to longest field name (17 chars) for now.
Signed-off-by: Robert ABEL
---
drivers/memory/omap-gpmc.c | 2 +-
1 file changed, 1
Hi Roger,
On Fri, Feb 27, 2015 at 11:24 AM, Roger Quadros wrote:
>> + /* is child a common bus? */
>> + if (of_match_node(of_default_bus_match_table, child))
>> + /* create children and other common bus children */
>> + if (of_platform_populate(child, of_default_bu
On Thu, Feb 26, 2015 at 4:06 PM, Sergei Shtylyov
wrote:
>Documentation/kernel-doc-nano-HOWTO.txt requires colons after the
> parameter names, doesn't it?
Jesus Christ, you guys are killing me...
I've already spent way more time on this patch series than I intended
to anyway...
>> + mas
Hi Roger,
On Fri, Feb 27, 2015 at 11:43 AM, Roger Quadros wrote:
>> time_ns_min = gpmc_ticks_to_ns(l ? l - 1 : 0);
>
> should be
> time_ns_min = l ? gpmc_ticks_to_ns(l - 1) + 1 : 0;
That's a micro-optimization.
>
> + 1ns since we don't want to fall in
GPMC debug output is aligned to 10 characters for field names.
However, some fields have bigger names, screwing up the alignment.
Consequently, alignment was changed to longest field name (17 chars) for now.
Signed-off-by: Robert ABEL
---
drivers/memory/omap-gpmc.c | 2 +-
1 file changed, 1
This patch adds support for spawning buses as children of the GPMC.
Signed-off-by: Robert ABEL
---
drivers/memory/omap-gpmc.c | 17 +++--
1 file changed, 15 insertions(+), 2 deletions(-)
diff --git a/drivers/memory/omap-gpmc.c b/drivers/memory/omap-gpmc.c
index 5cabac8..74a8c52
DTS output was formatted to require additional work when copy-pasting into DTS.
Nano-second timings were replaced with interval of values that produce the same
number of clock ticks.
Signed-off-by: Robert ABEL
---
drivers/memory/omap-gpmc.c | 35 ++-
1 file
WAITMONITORINGTIME delay.
Calculate GPMCFCLKDIVIDER independent of gpmc,sync-clk-ps in DT for
pure asynchronous accesses, i.e. both read and write asynchronous.
Signed-off-by: Robert ABEL
---
arch/arm/mach-omap2/gpmc-nand.c| 17
arch/arm/mach-omap2/gpmc-onenand.c | 4 +-
arch/arm/mach
WAITMONITORINGTIME delay.
Signed-off-by: Robert ABEL
---
drivers/memory/omap-gpmc.c | 17 ++---
1 file changed, 6 insertions(+), 11 deletions(-)
diff --git a/drivers/memory/omap-gpmc.c b/drivers/memory/omap-gpmc.c
index 9340e7a..4139f0d 100644
--- a/drivers/memory/omap-gpmc.c
+++ b
.
DEVICESIZE, ATTACHEDDEVICEPAGELENGTH, WAITMONITORINGTIME and
CLKACTIVATIONTIME would not be marked as incorrect on DTS output.
--> Fix all of these.
[1]: https://lkml.org/lkml/2015/2/12/495
[2]: https://lkml.org/lkml/2015/2/16/337
[3]: https://lkml.org/lkml/2015/2/24/609
Robert ABEL (9):
WAITMONITORINGTIME delay.
This patch correctly computes WAITMONITORINGTIME in GPMC_CLK cycles instead of
GPMC_FCLK cycles,
both during programming (gpmc_cs_set_timings) and during retrieval
(gpmc_cs_show_timings).
Signed-off-by: Robert ABEL
---
drivers/memory/omap-gpmc.c | 126
OMAP2+ GPMC driver undefines DEBUG, which makes it unnecessarily
hard to turn DEBUG on. Remove the offending lines.
Signed-off-by: Robert ABEL
---
drivers/memory/omap-gpmc.c | 2 --
1 file changed, 2 deletions(-)
diff --git a/drivers/memory/omap-gpmc.c b/drivers/memory/omap-gpmc.c
index
gpmc_cs_show_timings for
-CLKACTIVATIONTIME
-WAITMONITORINGTIME
-DEVICESIZE
-ATTACHEDDEVICEPAGELENGTH
Signed-off-by: Robert ABEL
---
drivers/memory/omap-gpmc.c | 68 ++
1 file changed, 45 insertions(+), 23 deletions(-)
diff --git a/drivers/memory/omap
Hi Roger,
On 25 Feb 2015 18:17, Roger Quadros wrote:
How will the user know by looking at the kernel log that it was really an error?
We don't fail probe if set_gpmc_timing_reg() fails so I feel it is necessary to
clearly show an Error message.
You can probably reword it like "%s: Error!! GPMC
On 25 Feb 2015 18:20, Roger Quadros wrote:
Need to patch mach-omap2/usb-tusb6010.c as well. else we get
arch/arm/mach-omap2/usb-tusb6010.c: In function ‘tusb_set_async_mode’:
arch/arm/mach-omap2/usb-tusb6010.c:74:2: error: too few arguments to function
‘gpmc_cs_set_timings’
In file included fro
Hi Roger,
On 25 Feb 2015 17:33, Roger Quadros wrote:
./scripts/checkpatch.pl detects some styling errors.
Well, there's like a million lines over 80 characters. I'm also a
heathen and don't use an 80 character terminal either.
I'll fix the more serious issues checkpatch finds, but some styling
Hi Roger,
On 25 Feb 2015 17:58, Roger Quadros wrote:
static unsigned int gpmc_ticks_to_ps(unsigned int ticks)
@@ -346,16 +395,22 @@ static void gpmc_cs_bool_timings(int cs, const struct
gpmc_bool_timings *p)
* @st_bit Start Bit
* @end_bit End Bit. Must be >= @st_bit.
* @nameDTS no
Hi Tony,
On 25 Feb 2015 16:23, Tony Lindgren wrote:
* Roger Quadros [150225 05:28]:
On 24/02/15 22:05, Robert ABEL wrote:
DTS output was formatted to require additional work when copy-pasting into DTS.
Nano-second timings were removed, because they were not a confidence interval
nor
an
Hi Roger,
On 25 Feb 2015 17:18, Roger Quadros wrote:
OK. Would be interesting to see how unconditional call to
of_platform_decide_create() behaves
for your case.
I'm not able to test today, so results will be in tomorrow. If that
doesn't work, I'll just resubmit my first patch with the conditi
Hi Roger,
On 25 Feb 2015 11:44, Roger Quadros wrote:
typo ATTCHEDDEVICEPAGELENGTH->ATTACHEDDEVICEPAGELENGTH
Yep.
+/** DEVICESIZE Max Value */
+#define GPMC_CONFIG1_DEVICESIZE_MAX GPMC_CONFIG1_DEVICESIZE_16
Shouldn't this be 1 instead? I'm hoping max value is without the shift
based on GPM
Hi Roger,
On 25 Feb 2015 13:02, Roger Quadros wrote:
This creates platform devices for the children of child, but what
about platform device for the child itself?
It seems my first try in the other patch set wasn't so wrong after all.
Maybe unconditionally call
of_platform_device_create(child
On Tue, Feb 24, 2015 at 9:05 PM, Robert ABEL
wrote:
>
> These are the changes I proposed in two separate patchsets
> #([1], [2]) rebased to 3.19 as well as new changes for little bugs
> I noticed while preparing this patchset.
It seems my m4d s3d sk177z failed me. Disregard the mis
OMAP2+ GPMC driver undefines DEBUG, which makes it unnecessarily
hard to turn DEBUG on. Remove the offending lines.
Signed-off-by: Robert ABEL
---
drivers/memory/omap-gpmc.c | 2 --
1 file changed, 2 deletions(-)
diff --git a/drivers/memory/omap-gpmc.c b/drivers/memory/omap-gpmc.c
index
GPMC debug output is aligned to 10 characters for field names.
However, some fields have bigger names, screwing up the alignment.
Consequently, alignment was changed to longest field name (17 chars) for now.
Signed-off-by: Robert ABEL
---
drivers/memory/omap-gpmc.c | 2 +-
1 file changed, 1
WAITMONITORINGTIME delay.
Calculate GPMCFCLKDIVIDER independent of gpmc,sync-clk-ps in DT for
truly asynchronous accesses, i.e. both read and write asynchronous.
Signed-off-by: Robert ABEL
---
arch/arm/mach-omap2/gpmc-nand.c| 17 -
arch/arm/mach-omap2/gpmc-onenand.c | 4 +--
drivers
gpmc_cs_show_timings for
-CLKACTIVATIONTIME
-WAITMONITORINGTIME
-DEVICESIZE
-ATTACHEDDEVICEPAGELENGTH
Signed-off-by: Robert ABEL
---
drivers/memory/omap-gpmc.c | 69 ++
1 file changed, 46 insertions(+), 23 deletions(-)
diff --git a/drivers/memory/omap
WAITMONITORINGTIME delay.
This patch correctly computes WAITMONITORINGTIME in GPMC_CLK cycles instead of
GPMC_FCLK cycles,
both during programming (gpmc_cs_set_timings) and during retrieval
(gpmc_cs_show_timings).
Signed-off-by: Robert ABEL
---
drivers/memory/omap-gpmc.c | 125
.
DEVICESIZE, ATTACHEDDEVICEPAGELENGTH, WAITMONITORINGTIME and
CLKACTIVATIONTIME would not be marked as incorrect on DTS output.
--> Fix all of these.
[1]: https://lkml.org/lkml/2015/2/12/495
[2]: https://lkml.org/lkml/2015/2/16/337
Robert ABEL (9):
ARM OMAP2+ GPMC: don't undef DEBUG
A
WAITMONITORINGTIME delay.
Signed-off-by: Robert ABEL
---
drivers/memory/omap-gpmc.c | 15 +--
1 file changed, 5 insertions(+), 10 deletions(-)
diff --git a/drivers/memory/omap-gpmc.c b/drivers/memory/omap-gpmc.c
index ff1a1e7..a6abaf0 100644
--- a/drivers/memory/omap-gpmc.c
+++ b/drivers
This patch adds support for spawning busses as children of the GPMC.
Signed-off-by: Robert ABEL
---
drivers/memory/omap-gpmc.c | 3 ++-
1 file changed, 2 insertions(+), 1 deletion(-)
diff --git a/drivers/memory/omap-gpmc.c b/drivers/memory/omap-gpmc.c
index 5cabac8..78b78a64 100644
--- a
DTS output was formatted to require additional work when copy-pasting into DTS.
Nano-second timings were removed, because they were not a confidence interval
nor
an indication what timing values would result in the same #ticks
Signed-off-by: Robert ABEL
---
drivers/memory/omap-gpmc.c | 33
On Tue, Feb 17, 2015 at 3:25 PM, Roger Quadros wrote:
> one more thing to note is that just specifying sync-clk-ps in DT is not
> enough for
> asynchronous devices.
>
> The driver doesn't set gpmc_t->sync_clk if "gpmc,sync-read" or
> "gpmc,sync-write"
> was not set in the DT, which would be the
Hi Roger,
On Tue, Feb 17, 2015 at 2:52 PM, Roger Quadros wrote:
> nobody stops the DT binding from specifying a large enough
> "gpmc,wait-monitoring-ns" value.
> The driver must use that to scale the GPMC_CLK if it doesn't fit in the
> GPMC_FCLK.
> This feature can come separately though. So fo
Hi Roger,
On Tue, Feb 17, 2015 at 10:41 AM, Roger Quadros wrote:>
> Can we simply use only
> of_platform_populate(child, NULL, NULL, &pdev->dev)
>
> That way we get rid of the if..else and let OF core take care of
> creating buses or devices.
Surely, you mean
>of_platform_populate(child, of_def
Hi Roger,
On Tue, Feb 17, 2015 at 10:27 AM, Roger Quadros wrote:
>
> Can you please point out which DT had used this pre-divided workaround? We
> will have to
> fix those then.
I didn't check. A cursory glance reveals all DTS in arch/arm/boot/dts
to use a value of 0.
>
> Can you please rebase
Hi Roger,
On Tue, Feb 17, 2015 at 9:12 AM, Roger Quadros wrote:
>
> Can you use the following wording from TRM instead?
>
> as per am335x TRM (spruh73i.pdf), section 7.1.3.3.8.3.2
>
> The WAITMONITORINGTIME is expressed as a number of GPMC_CLK clock cycles,
> even though the access is defined as
Hi Tony,
On 16 Feb 2015 18:10, Tony Lindgren wrote:
* Robert ABEL [150216 07:52]:
GPMC uses GPMCFCLKDIVIDER during synchronous as well as asynchronous accesses
in conjunction with WAITMONITORINGTIME. Thus, it's wrong to only program it for
synchronous accesses. Remove the conditional.
D
reg = ;
};
... etc. ...
my_subdevN: subdev@0x8000 { /* address 0x8000 */
compatible = "my,driverN";
reg = ;
};
};
};
Robert ABEL (4):
ARM OMAP2+ GPMC: fix debug output alig
This patch adds support for spawning busses as children of the GPMC.
Signed-off-by: Robert ABEL
---
arch/arm/mach-omap2/gpmc.c | 14 +-
1 file changed, 13 insertions(+), 1 deletion(-)
diff --git a/arch/arm/mach-omap2/gpmc.c b/arch/arm/mach-omap2/gpmc.c
index 4fa5ff1..c6c8543 100644
GPMC uses GPMCFCLKDIVIDER during synchronous as well as asynchronous accesses
in conjunction with WAITMONITORINGTIME. Thus, it's wrong to only program it for
synchronous accesses. Remove the conditional.
Signed-off-by: Robert ABEL
---
arch/arm/mach-omap2/gpmc.c | 15 +--
1
GPMC debug output is aligned to 10 characters for field names.
However, some fields have bigger names, screwing up the alignment.
Consequently, alignment was changed to longest field name (17 chars) for now.
Signed-off-by: Robert ABEL
---
arch/arm/mach-omap2/gpmc.c | 4 ++--
1 file changed, 2
and adjusting the divisor for WAITMONITORINGTIME
accordingly.
Signed-off-by: Robert ABEL
---
arch/arm/mach-omap2/gpmc.c | 78 +-
1 file changed, 64 insertions(+), 14 deletions(-)
diff --git a/arch/arm/mach-omap2/gpmc.c b/arch/arm/mach-omap2/gpmc.c
The GPMC driver in OMAP2 undef's DEBUG, which makes it unnecessarily hard to
turn DEBUG on,
because that's not expected behavior.
My proposed patch gets rid of the line undef'ing DEBUG.
Robert ABEL (1):
ARM OMAP2 GPMC: don't undef DEBUG
arch/arm/mach-omap2/gpmc.c | 2 -
Signed-off-by: Robert ABEL
---
arch/arm/mach-omap2/gpmc.c | 2 --
1 file changed, 2 deletions(-)
diff --git a/arch/arm/mach-omap2/gpmc.c b/arch/arm/mach-omap2/gpmc.c
index ab43755..1ab6bc0 100644
--- a/arch/arm/mach-omap2/gpmc.c
+++ b/arch/arm/mach-omap2/gpmc.c
@@ -12,8 +12,6 @@
* it under
Hi Olaf,
On 16.05.2014 19:18, Olaf Hering wrote:
I did unplug an USB stick by accident with 3.14.4, the result is this
warning:
[94414.233882] usb 1-3: USB disconnect, device number 4
[94414.245377] scsi 5:0:0:0: rejecting I/O to offline device
[94414.245383] scsi 5:0:0:0: killing request
[944
Cody Schafer already fixed binary file creation for attribute groups, see [1].
This patch makes the appropriate changes for binary file removal
of attribute groups.
[1]: http://lkml.org/lkml/2014/2/27/832
Signed-off-by: Robert ABEL
---
fs/sysfs/group.c | 10 +-
1 file changed, 5
I sent this patch to the list on 15 Apr 14.
However, no activity since. Should I have sent this patch somewhere else?
Regards,
Robert
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majord...@vger.kernel.org
More majordomo info at http://vge
Cody Schafer already fixed binary file creation for attribute groups, see [1].
This patch makes the appropriate changes for binary file removal
of attribute groups.
[1]: http://lkml.org/lkml/2014/2/27/832
Signed-off-by: Robert ABEL
---
fs/sysfs/group.c | 10 +-
1 file changed, 5
Cody Schafer already fixed binary file creation for attribute groups,
see [1].
This patch makes the appropriate changes for binary file removal
of attribute groups.
[1]: http://lkml.org/lkml/2014/2/27/832
Signed-off-by: Robert ABEL
From 706a652d3653470a5caae589f6945498026c94c1 Mon Sep 17 00:00
87 matches
Mail list logo
