Re: [PATCH] dmaengine: remove DBGFS_FUNC_DECL()

2018-11-30 Thread Robert Jarzmik
>> drivers/dma/amba-pl08x.c | 14 ++ >> drivers/dma/mic_x100_dma.c | 22 +++--- >> drivers/dma/pxa_dma.c| 24 >> drivers/dma/qcom/hidma_dbg.c | 33 ++--- For pxa_dma: Acked-by: Robert Jarzmik Cheers. -- Robert

[PATCH] gpio: pxa: fix legacy non pinctrl aware builds again

2018-11-15 Thread Robert Jarzmik
this direction. Yet in Gregory's case, the matrix-keypad driver changes back and forth the direction dynamically, and this is why he's the first to report it. Fixes: c4e5ffb6f224 ("gpio: pxa: fix legacy non pinctrl aware builds") Tested-by: Greg Signed-off-by: Robert Jarzmik --- drive

Re: [PATCH] spi: pxa2xx: Fix '"CONFIG_OF" is not defined' warning

2018-11-14 Thread Robert Jarzmik
Lubomir Rintel writes: > A careless oversight. Sorry. > > Fixes: 0a897143b7c9 ("spi: pxa2xx: Add slave mode support") > Signed-off-by: Lubomir Rintel > --- > drivers/spi/spi-pxa2xx.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/drivers/spi/spi-pxa2xx.c

Re: [PATCH v3 17/18] USB: phy-mv-usb: use phy-pxa-usb

2018-11-13 Thread Robert Jarzmik
Lubomir Rintel writes: > Use a proper PHY driver, instead of hooks to a board support package. Hi Lubomir, This specific patch caught my attention, because of its title : I don't see what phy-pxa-usb stands for, is it a typo ? I don't think anybody implemented so far a proper phy support for

Re: [PATCH v4] ARM: dts: pxa: add mioa701 board description

2018-11-11 Thread Robert Jarzmik
Robert Jarzmik writes: > Add device-tree description of the Mitac MIO A701 board. > This is aimed at replacing mioa701.c board file, and once stabilized, > the leftover, such as the suspend resume mechanics will rely on a new > IPL, and not the legacy Windows CE one. > > Sig

Re: [PATCH v4] ARM: dts: pxa: add mioa701 board description

2018-11-11 Thread Robert Jarzmik
Robert Jarzmik writes: > Add device-tree description of the Mitac MIO A701 board. > This is aimed at replacing mioa701.c board file, and once stabilized, > the leftover, such as the suspend resume mechanics will rely on a new > IPL, and not the legacy Windows CE one. > > Sig

Re: linux-4.20-rc1/arch/arm/vfp/vfpmodule.c:576: possible cut'n'paste error

2018-11-10 Thread Robert Jarzmik
Russell King - ARM Linux writes: >> Interestingly, more of the same in file >> linux-4.20-rc1/arch/arm/mach-pxa/pxa3xx.c >> >> [linux-4.20-rc1/arch/arm/mach-pxa/pxa3xx.c:84]: (warning) Redundant >> assignment of 'ASCR' to itself. >> [linux-4.20-rc1/arch/arm/mach-pxa/pxa3xx.c:85]: (warning)

Re: [PATCH 3/5] spi: pxa2xx: use an enum for type

2018-09-21 Thread Robert Jarzmik
Lubomir Rintel writes: > That seems to be the correct type. Okay, but what happens here when adev_id->driver_data is a value out of enum range ? Does the following assignment make sense ? > + type = (enum pxa_ssp_type)adev_id->driver_data; As a side note, could you join for the next

[PATCH v4] ARM: dts: pxa: add mioa701 board description

2018-09-15 Thread Robert Jarzmik
Add device-tree description of the Mitac MIO A701 board. This is aimed at replacing mioa701.c board file, and once stabilized, the leftover, such as the suspend resume mechanics will rely on a new IPL, and not the legacy Windows CE one. Signed-off-by: Robert Jarzmik --- Since v1: fix lcd_supply

Re: [PATCH v3] ARM: dts: pxa: add mioa701 board description

2018-09-13 Thread Robert Jarzmik
Marcel Ziswiler writes: > Hi Robert >> arch/arm/boot/dts/Makefile| 2 + >> arch/arm/boot/dts/mioa701.dts | 558 > > Isn't that one supposed to be prefixed by pxa270-? Good point, for v4. >> diff --git a/arch/arm/boot/dts/Makefile b/arch/arm/boot/dts/Makefile ... >>

Re: [PATCH] Input: wm97xx: only unregister wm97xx_driver if it has been registered

2018-09-09 Thread Robert Jarzmik
t supported. >> >> Fixes: ae9d1b5fbd7b ("Input: wm97xx: add new AC97 bus support") >> Signed-off-by: Colin Ian King >> --- > > Acked-by: Charles Keepax Acked-by: Robert Jarzmik Cheers. -- Robert

Re: [PATCH] ARM: dts: pxa: add pincontrol helpers

2018-08-31 Thread Robert Jarzmik
Robert Jarzmik writes: > Add 3 helpers so that pincontrol definitions for pxa25x and pxa27x are > easier, and can be easily converted from old mfp mach-pxa code to > devicetree. As this is exactly the same patch sent out for review July the 7th, queued to pxa/dt. -- Robert

Re: [PATCH] ARM: dts: pxa: fix power i2c base address

2018-08-31 Thread Robert Jarzmik
Marcel Ziswiler writes: > There is one too many zeroes in the Power I2C base address. Fix this. > > Signed-off-by: Marcel Ziswiler Queued to pxa/dt, thanks. Cheers. -- Robert

Re: [PATCH v3] ARM: dts: pxa: add mioa701 board description

2018-08-31 Thread Robert Jarzmik
kbuild test robot writes: > Hi Robert, > > I love your patch! Yet something to improve: This is because you are missing at least this patch submitted earlier : - [PATCH] ARM: dts: pxa: add pincontrol helpers You're also missing the previous patches in the pxa/dt tree, which are already on the

[PATCH v3] ARM: dts: pxa: add mioa701 board description

2018-08-30 Thread Robert Jarzmik
Add device-tree description of the Mitac MIO A701 board. This is aimed at replacing mioa701.c board file, and once stabilized, the leftover, such as the suspend resume mechanics will rely on a new IPL, and not the legacy Windows CE one. Signed-off-by: Robert Jarzmik --- Since v1: fix lcd_supply

[PATCH] ARM: dts: pxa: add pincontrol helpers

2018-08-30 Thread Robert Jarzmik
l once booted in debugfs. Signed-off-by: Robert Jarzmik --- arch/arm/boot/dts/pxa2xx.dtsi | 19 +++ 1 file changed, 19 insertions(+) diff --git a/arch/arm/boot/dts/pxa2xx.dtsi b/arch/arm/boot/dts/pxa2xx.dtsi index a520b4c14ea9..81312a9813f6 100644 --- a/arch/arm/boot/dts/pxa2xx.dtsi

Re: [PATCH] ARM: dts: pxa: change serial node names

2018-08-30 Thread Robert Jarzmik
Robert Jarzmik writes: > Change from xxuart to serial to normalize the devicetree pxa serial > support. > > Signed-off-by: Robert Jarzmik > --- > arch/arm/boot/dts/pxa2xx.dtsi | 8 > 1 file changed, 4 insertions(+), 4 deletions(-) Queued to pxa/dt. -- Robert

[PATCH v9] ASoC: pxa: switch to new ac97 bus support

2018-08-25 Thread Robert Jarzmik
Switch to the new ac97 bus support in sound/ac97 instead of the legacy snd_ac97 one. Signed-off-by: Robert Jarzmik --- Since v8: fixed the trivial compilation error v7 was in https://patchwork.kernel.org/patch/9951919/ --- sound/arm/Kconfig | 1 - sound/soc/pxa/Kconfig

[PATCH] gpio: pxa: handle corner case of unprobed device

2018-08-25 Thread Robert Jarzmik
this in : https://bugzilla.kernel.org/show_bug.cgi?id=200905 Therefore, add a failsafe in these function, and test if a proper probe succeeded and the driver is functional. Signed-off-by: Robert Jarzmik Reported-by: Nicolas Chauvet --- drivers/gpio/gpio-pxa.c | 6 ++ 1 file changed, 6 insertions

Re: linux-next: build failure after merge of the arm-soc tree

2018-07-16 Thread Robert Jarzmik
Olof Johansson writes: > It's a known issue due to dependencies with a driver tree. :( > > Robert, this is unfortunate. What's the dependent patches? We can pick > them up in our tree as duplicates if needed. I'd rather postpone one of the patches, as I explained in the pull request. As Stephen

[PATCH] ARM: dts: pxa: change serial node names

2018-07-15 Thread Robert Jarzmik
Change from xxuart to serial to normalize the devicetree pxa serial support. Signed-off-by: Robert Jarzmik --- arch/arm/boot/dts/pxa2xx.dtsi | 8 1 file changed, 4 insertions(+), 4 deletions(-) diff --git a/arch/arm/boot/dts/pxa2xx.dtsi b/arch/arm/boot/dts/pxa2xx.dtsi index

Re: [PATCH 2/2] ARM: dts: pxa: add mioa701 board description

2018-07-14 Thread Robert Jarzmik
Rob Herring writes: Hi Rob, >> + /* compatible = "mitac,mioa701"; */ >> + compatible = "marvell,pxa270"; > > Why the comment? Leftover, I'll remove it. >> + pstore_region:region@0xa200 { > > Drop the 0x Done. >> + compatible

[PATCH v2 2/2] ARM: dts: pxa: add mioa701 board description

2018-07-07 Thread Robert Jarzmik
Add device-tree description of the Mitac MIO A701 board. This is aimed at replacing mioa701.c board file, and once stabilized, the leftover, such as the suspend resume mechanics will rely on a new IPL, and not the legacy Windows CE one. Signed-off-by: Robert Jarzmik --- Since v1: fix lcd_supply

[PATCH v2 1/2] ARM: dts: pxa: add pincontrol helpers

2018-07-07 Thread Robert Jarzmik
l once booted in debugfs. Signed-off-by: Robert Jarzmik --- arch/arm/boot/dts/pxa2xx.dtsi | 19 +++ 1 file changed, 19 insertions(+) diff --git a/arch/arm/boot/dts/pxa2xx.dtsi b/arch/arm/boot/dts/pxa2xx.dtsi index e4ebcde17837..f609dbb86abf 100644 --- a/arch/arm/boot/dts/pxa2xx.dtsi

Re: [PATCH v4 1/2] clk: pxa: export 32kHz PLL

2018-07-07 Thread Robert Jarzmik
Stephen Boyd writes: > Quoting Robert Jarzmik (2018-07-04 22:34:10) >> Robert Jarzmik writes: >> >> > This clock is especially used by the RTC driver, so export it so that >> > devicetree users can use it. >> > >> > Signed-off-by: Robert Jarzm

Re: linux-next: Tree for Jul 2 (sound/soc/pxa/)

2018-07-02 Thread Robert Jarzmik
Randy Dunlap writes: > [add other maintainers] > on i386 or x86_64: > > builtin: > sound/soc/pxa/pxa-ssp.o:(.rodata+0x228): undefined reference to > `pxa2xx_soc_pcm_new' > sound/soc/pxa/pxa-ssp.o:(.rodata+0x22c): undefined reference to > `pxa2xx_pcm_free_dma_buffers' >

[PATCH 1/2] ARM: dts: pxa: add pincontrol helpers

2018-07-01 Thread Robert Jarzmik
l once booted in debugfs. Signed-off-by: Robert Jarzmik --- arch/arm/boot/dts/pxa2xx.dtsi | 19 +++ 1 file changed, 19 insertions(+) diff --git a/arch/arm/boot/dts/pxa2xx.dtsi b/arch/arm/boot/dts/pxa2xx.dtsi index e4ebcde17837..f609dbb86abf 100644 --- a/arch/arm/boot/dts/pxa2xx.dtsi

[PATCH 2/2] ARM: dts: pxa: add mioa701 board description

2018-07-01 Thread Robert Jarzmik
Add device-tree description of the Mitac MIO A701 board. This is aimed at replacing mioa701.c board file, and once stabilized, the leftover, such as the suspend resume mechanics will rely on a new IPL, and not the legacy Windows CE one. Signed-off-by: Robert Jarzmik --- This patch deserves some

[PATCH v4 2/2] ARM: dts: pxa: fix the rtc controller

2018-06-27 Thread Robert Jarzmik
. Signed-off-by: Robert Jarzmik --- Since v1: change the dummy clock by the actual 32.768kHz Since v3: remove spurious bracket --- arch/arm/boot/dts/pxa25x.dtsi | 4 arch/arm/boot/dts/pxa27x.dtsi | 4 2 files changed, 8 insertions(+) diff --git a/arch/arm/boot/dts/pxa25x.dtsi b/arch/arm

[PATCH v4 1/2] clk: pxa: export 32kHz PLL

2018-06-27 Thread Robert Jarzmik
This clock is especially used by the RTC driver, so export it so that devicetree users can use it. Signed-off-by: Robert Jarzmik --- Since v2: fix missing parenthesis in clk-pxa25x.c and clk-pxa3xx.c --- drivers/clk/pxa/clk-pxa25x.c | 6 -- drivers/clk/pxa/clk-pxa27x.c | 7

Re: [PATCH v3 2/2] ARM: dts: pxa: fix the rtc controller

2018-06-27 Thread Robert Jarzmik
Thomas Petazzoni writes: > Hello, >> +rtc@4090 { >> +clocks = < CLK_OSC32k768>>; > > Double closing bracket, doesn't look good. Rrrr you're right ... I swear this patchset is cursed ... Thanks for spotting that, I'll send a v4. Cheers. -- Robert

Re: [PATCH v3 00/14] ARM: pxa: switch to DMA slave maps

2018-06-27 Thread Robert Jarzmik
Mark Brown writes: > On Mon, Jun 18, 2018 at 09:56:20PM +0200, Robert Jarzmik wrote: > >> I must insist on "Wednesday", as I need to have one last pass from 0-day >> kernel >> checker to be fully covered, and I'd like as well to know which tree the ASoC >&

[PATCH v3 2/2] ARM: dts: pxa: fix the rtc controller

2018-06-27 Thread Robert Jarzmik
. Signed-off-by: Robert Jarzmik --- Since v1: change the dummy clock by the actual 32.768kHz --- arch/arm/boot/dts/pxa25x.dtsi | 4 arch/arm/boot/dts/pxa27x.dtsi | 4 2 files changed, 8 insertions(+) diff --git a/arch/arm/boot/dts/pxa25x.dtsi b/arch/arm/boot/dts/pxa25x.dtsi index

[PATCH v3 1/2] clk: pxa: export 32kHz PLL

2018-06-27 Thread Robert Jarzmik
This clock is especially used by the RTC driver, so export it so that devicetree users can use it. Signed-off-by: Robert Jarzmik --- Since v2: fix missing parenthesis in clk-pxa25x.c and clk-pxa3xx.c --- drivers/clk/pxa/clk-pxa25x.c | 6 -- drivers/clk/pxa/clk-pxa27x.c | 7

Re: [PATCH v2 1/2] clk: pxa: export 32kHz PLL

2018-06-27 Thread Robert Jarzmik
kbuild test robot writes: > All errors (new ones prefixed by >>): > >drivers/clk/pxa/clk-pxa25x.c: In function 'pxa25x_register_plls': >>> drivers/clk/pxa/clk-pxa25x.c:298:17: error: expected ')' before ';' token > 32768); > ^ >>>

[PATCH v2 1/2] clk: pxa: export 32kHz PLL

2018-06-26 Thread Robert Jarzmik
This clock is especially used by the RTC driver, so export it so that devicetree users can use it. Signed-off-by: Robert Jarzmik --- drivers/clk/pxa/clk-pxa25x.c | 6 -- drivers/clk/pxa/clk-pxa27x.c | 7 --- drivers/clk/pxa/clk-pxa3xx.c | 7 --- include/dt

[PATCH v2 2/2] ARM: dts: pxa: fix the rtc controller

2018-06-26 Thread Robert Jarzmik
. Signed-off-by: Robert Jarzmik --- Since v1: change the dummy clock by the actual 32.768kHz --- arch/arm/boot/dts/pxa25x.dtsi | 4 arch/arm/boot/dts/pxa27x.dtsi | 4 2 files changed, 8 insertions(+) diff --git a/arch/arm/boot/dts/pxa25x.dtsi b/arch/arm/boot/dts/pxa25x.dtsi index

[PATCH] ARM: dts: pxa: fix the rtc controller

2018-06-26 Thread Robert Jarzmik
-by: Robert Jarzmik --- arch/arm/boot/dts/pxa25x.dtsi | 4 arch/arm/boot/dts/pxa27x.dtsi | 4 2 files changed, 8 insertions(+) diff --git a/arch/arm/boot/dts/pxa25x.dtsi b/arch/arm/boot/dts/pxa25x.dtsi index 95d59be97213..c6ca07e4626b 100644 --- a/arch/arm/boot/dts/pxa25x.dtsi +++ b/arch

[PATCH v2 2/2] ALSA: ac97: add codecs devicetree binding

2018-06-22 Thread Robert Jarzmik
Add a devicetree binding for codecs. This is especially useful if the AC97 bitclk clock is provided by the codec, as it has to be described in the devicetree description for the ac97 bus code to aquire it. Signed-off-by: Robert Jarzmik --- Since v1: handle of_put_node() in codec removal

[PATCH v2 1/2] ALSA: ac97: add bus binding for codecs

2018-06-22 Thread Robert Jarzmik
Add the generic ac97 bus binding, especially for ac97 codecs discovered by ac97 hardware probing. Signed-off-by: Robert Jarzmik --- .../devicetree/bindings/sound/ac97-bus.txt | 32 ++ 1 file changed, 32 insertions(+) create mode 100644 Documentation/devicetree

Re: [PATCH 2/2] ALSA: ac97: add codecs devicetree binding

2018-06-22 Thread Robert Jarzmik
Takashi Iwai writes: >> Special review query: review the "return of_node_get(node)", which >> assumes that upon device removal, of_put_node(dev.of_node) will be >> called... > > Is it really done automagically? I couldn't spot it. Neither could I ... I based this on

[PATCH 2/2] ALSA: ac97: add codecs devicetree binding

2018-06-21 Thread Robert Jarzmik
Add a devicetree binding for codecs. This is especially useful if the AC97 bitclk clock is provided by the codec, as it has to be described in the devicetree description for the ac97 bus code to aquire it. Signed-off-by: Robert Jarzmik --- Special review query: review the "return of_nod

[PATCH 1/2] ALSA: ac97: add bus binding for codecs

2018-06-21 Thread Robert Jarzmik
Add the generic ac97 bus binding, especially for ac97 codecs discovered by ac97 hardware probing. Signed-off-by: Robert Jarzmik --- .../devicetree/bindings/sound/ac97-bus.txt | 32 ++ 1 file changed, 32 insertions(+) create mode 100644 Documentation/devicetree

Re: [PATCH] ARM: pxa: zylonite: use the new ac97 bus support

2018-06-20 Thread Robert Jarzmik
Robert Jarzmik writes: > Now the PXA is converted to new ac97 bus support, the wm9713 is > automatically detected and probed. Remove it from the platform bus. > > Signed-off-by: Robert Jarzmik > --- > arch/arm/mach-pxa/zylonite.c | 11 --- > 1 file changed, 1

Re: [PATCH] ARM: pxa: add the missing AC97 clocks

2018-06-20 Thread Robert Jarzmik
Robert Jarzmik writes: > The AC97 bit clock is added as the pxa internally generated 13MHz > clock. This is a consequence of the new ac97 framework. > > Signed-off-by: Robert Jarzmik > --- > arch/arm/mach-pxa/devices.c | 13 + > 1 file changed, 13 insert

Re: [PATCH] ARM: pxa: mioa701 convert to the new AC97 bus

2018-06-20 Thread Robert Jarzmik
Robert Jarzmik writes: > This migration implies : > - wm9713 device is removed, it will be auto-probed > > Signed-off-by: Robert Jarzmik > --- > arch/arm/mach-pxa/mioa701.c | 2 -- > 1 file changed, 2 deletions(-) Queued to pxa/for-next. -- Robert

Re: [PATCH] ARM: pxa: hx4700: fix the usb client

2018-06-20 Thread Robert Jarzmik
Robert Jarzmik writes: > The usb client of the hx4700 is not working because no platform data is > declared. Fix it by adding the missing call. > > Signed-off-by: Robert Jarzmik Queued to pxa/for-next. -- Robert

Re: [PATCH v3 00/14] ARM: pxa: switch to DMA slave maps

2018-06-20 Thread Robert Jarzmik
Boris Brezillon writes: > Don't worry, we're not planning to merge it unless it happens to be > required (Stephen Rothwell reporting a merge conflict in next), and we > don't have conflicting changes in the pipeline so far. Ok, great. We're good to go, no screaming from 0-day, my internal

Re: [PATCH v3 00/14] ARM: pxa: switch to DMA slave maps

2018-06-18 Thread Robert Jarzmik
Boris Brezillon writes: > Hi Robert, > > On Sun, 17 Jun 2018 19:02:03 +0200 > Robert Jarzmik wrote: > >> As I gathered almost all the required acks, this is an information only post >> before queuing to the PXA tree. > > We'll need an immutable branch/t

[PATCH v2 2/2] ASoC: pxa: add devicetree support

2018-06-17 Thread Robert Jarzmik
Add the devicetree support, so that the driver can be used in a devictree platform. Signed-off-by: Robert Jarzmik --- Since v1: changed compatible string to pxa250-ac97, pxa270-ac97... --- sound/arm/pxa2xx-ac97-lib.c | 12 sound/soc/pxa/pxa2xx-ac97.c | 12 2 files

[PATCH v2 1/2] ASoC: pxa: add binding for pxa2xx-ac97 audio complex

2018-06-17 Thread Robert Jarzmik
This adds a binding for the Marvell PXA audio complex, available in pxa2xx and pxa3xx variants. Signed-off-by: Robert Jarzmik --- Since v1: Rob's review, compatible string, reset-gpios, status --- .../bindings/sound/marvell,pxa2xx-ac97.txt | 27 ++ 1 file changed, 27

Re: [PATCH 1/2] ASoC: pxa: add binding for pxa2xx-ac97 audio complex

2018-06-13 Thread Robert Jarzmik
Rob Herring writes: > On Mon, Jun 11, 2018 at 10:22:10PM +0200, Robert Jarzmik wrote: >> This adds a binding for the Marvell PXA audio complex, available in >> pxa2xx and pxa3xx variants. >> +Required properties: >> + - compatible: "marvell,pxa2xx-ac97"

[PATCH 2/2] ASoC: pxa: add devicetree support

2018-06-11 Thread Robert Jarzmik
Add the devicetree support, so that the driver can be used in a devictree platform. Signed-off-by: Robert Jarzmik --- sound/arm/pxa2xx-ac97-lib.c | 11 +++ sound/soc/pxa/pxa2xx-ac97.c | 10 ++ 2 files changed, 21 insertions(+) diff --git a/sound/arm/pxa2xx-ac97-lib.c b/sound

[PATCH 1/2] ASoC: pxa: add binding for pxa2xx-ac97 audio complex

2018-06-11 Thread Robert Jarzmik
This adds a binding for the Marvell PXA audio complex, available in pxa2xx and pxa3xx variants. Signed-off-by: Robert Jarzmik --- .../bindings/sound/marvell,pxa2xx-ac97.txt | 25 ++ 1 file changed, 25 insertions(+) create mode 100644 Documentation/devicetree

Re: [RESEND v2] dmaengine: pxa: add a default requestor policy

2018-06-11 Thread Robert Jarzmik
Vinod Koul writes: > On 09-06-18, 14:43, Robert Jarzmik wrote: >> Robert Jarzmik writes: >> >> > As what former drcmr -1 value meant, add a this as a default to each >> > channel, ie. that by default no requestor line is used. >> > >> > T

Re: [RESEND v2] dmaengine: pxa: add a default requestor policy

2018-06-09 Thread Robert Jarzmik
Robert Jarzmik writes: > As what former drcmr -1 value meant, add a this as a default to each > channel, ie. that by default no requestor line is used. > > This is specifically used for network drivers smc91x and smc911x, and > needed for their port to slave maps. > > Cc: Ar

[PATCH] ARM: pxa: zylonite: use the new ac97 bus support

2018-06-03 Thread Robert Jarzmik
Now the PXA is converted to new ac97 bus support, the wm9713 is automatically detected and probed. Remove it from the platform bus. Signed-off-by: Robert Jarzmik --- arch/arm/mach-pxa/zylonite.c | 11 --- 1 file changed, 11 deletions(-) diff --git a/arch/arm/mach-pxa/zylonite.c b/arch

[PATCH] mfd: wm97xx-core: platform data can be NULL

2018-06-03 Thread Robert Jarzmik
t;mfd: wm97xx-core: core support for wm97xx Codec") Signed-off-by: Robert Jarzmik --- drivers/mfd/wm97xx-core.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/mfd/wm97xx-core.c b/drivers/mfd/wm97xx-core.c index 4141ee52a70b..f5a8347f837f 100644 --- a/drivers/mfd/wm9

[PATCH] ARM: pxa: add the missing AC97 clocks

2018-06-03 Thread Robert Jarzmik
The AC97 bit clock is added as the pxa internally generated 13MHz clock. This is a consequence of the new ac97 framework. Signed-off-by: Robert Jarzmik --- arch/arm/mach-pxa/devices.c | 13 + 1 file changed, 13 insertions(+) diff --git a/arch/arm/mach-pxa/devices.c b/arch/arm/mach

[PATCH v9] ASoC: pxa: switch to new ac97 bus support

2018-06-03 Thread Robert Jarzmik
Switch to the new ac97 bus support in sound/ac97 instead of the legacy snd_ac97 one. Signed-off-by: Robert Jarzmik --- Since v8: fixed the trivial compilation error v7 was in https://patchwork.kernel.org/patch/9951919/ --- sound/arm/Kconfig | 1 - sound/soc/pxa/Kconfig

Re: [PATCH v8] ASoC: pxa: switch to new ac97 bus support

2018-06-02 Thread Robert Jarzmik
Robert Jarzmik writes: > Switch to the new ac97 bus support in sound/ac97 instead of the legacy > snd_ac97 one. > + codecs_pdata = pdata ? pdata->codecs_pdata : NULL; It's a shame my automated build and test system didn't catch that : it should have been pdata->codec_pdat

[PATCH v8] ASoC: pxa: switch to new ac97 bus support

2018-06-02 Thread Robert Jarzmik
Switch to the new ac97 bus support in sound/ac97 instead of the legacy snd_ac97 one. Signed-off-by: Robert Jarzmik --- Since v7: added a NULL pointer check v7 was in https://patchwork.kernel.org/patch/9951919/ --- sound/arm/Kconfig | 1 - sound/soc/pxa/Kconfig | 5

[RESEND v2] dmaengine: pxa: add a default requestor policy

2018-05-30 Thread Robert Jarzmik
As what former drcmr -1 value meant, add a this as a default to each channel, ie. that by default no requestor line is used. This is specifically used for network drivers smc91x and smc911x, and needed for their port to slave maps. Cc: Arnd Bergmann Signed-off-by: Robert Jarzmik --- Since v1

[PATCH v2] dmaengine: pxa: add a default requestor policy

2018-05-30 Thread Robert Jarzmik
As what former drcmr -1 value meant, add a this as a default to each channel, ie. that by default no requestor line is used. This is specifically used for network drivers smc91x and smc911x, and needed for their port to slave maps. Cc: Arnd Bergmann Signed-off-by: Robert Jarzmik --- Since v1

Re: [RESEND PATCH] dmaengine: pxa: add a default requestor policy

2018-05-29 Thread Robert Jarzmik
Vinod writes: > On 26-05-18, 11:54, Robert Jarzmik wrote: >> @@ -762,6 +762,8 @@ static void pxad_free_chan_resources(struct dma_chan >> *dchan) >> dma_pool_destroy(chan->desc_pool); >> chan->desc_pool = NULL; >> >> +c

[PATCH] ARM: pxa: add the missing AC97 clocks

2018-05-27 Thread Robert Jarzmik
The AC97 bit clock is added as the pxa internally generated 13MHz clock. This is a consequence of the new ac97 framework. Signed-off-by: Robert Jarzmik <robert.jarz...@free.fr> --- arch/arm/mach-pxa/devices.c | 13 + 1 file changed, 13 insertions(+) diff --git a/arch/arm/ma

[PATCH] ARM: pxa: mioa701 convert to the new AC97 bus

2018-05-27 Thread Robert Jarzmik
This migration implies : - wm9713 device is removed, it will be auto-probed Signed-off-by: Robert Jarzmik <robert.jarz...@free.fr> --- arch/arm/mach-pxa/mioa701.c | 2 -- 1 file changed, 2 deletions(-) diff --git a/arch/arm/mach-pxa/mioa701.c b/arch/arm/mach-pxa/mioa701.c index 9b6c7e

[RESEND PATCH] dmaengine: pxa: add a default requestor policy

2018-05-26 Thread Robert Jarzmik
As what former drcmr -1 value meant, add a this as a default to each channel, ie. that by default no requestor line is used. This is specifically used for network drivers smc91x and smc911x, and needed for their port to slave maps. Cc: Arnd Bergmann <a...@arndb.de> Signed-off-by: Robert J

[PATCH] ARM: pxa: hx4700: fix the usb client

2018-05-26 Thread Robert Jarzmik
The usb client of the hx4700 is not working because no platform data is declared. Fix it by adding the missing call. Signed-off-by: Robert Jarzmik <robert.jarz...@free.fr> --- arch/arm/mach-pxa/hx4700.c | 4 1 file changed, 4 insertions(+) diff --git a/arch/arm/mach-pxa/hx4700.c b/ar

[PATCH] mfd: asic3: Fix the broken MMC card detection

2018-05-26 Thread Robert Jarzmik
The MMC framework requires the ocr_mask to be provided. Without it, the SD card is not detected, especially on the hx4700 platform. Signed-off-by: Robert Jarzmik <robert.jarz...@free.fr> --- drivers/mfd/asic3.c | 3 +++ 1 file changed, 3 insertions(+) diff --git a/drivers/mfd/asic3.c b/d

[PATCH] dmaengine: pxa: add a default requestor policy

2018-05-25 Thread Robert Jarzmik
As what former drcmr -1 value meant, add a this as a default to each channel, ie. that by default no requestor line is used. This is specifically used for network drivers smc91x and smc911x, and needed for their port to slave maps. Cc: Arnd Bergmann <a...@arndb.de> Signed-off-by: Robert J

Re: [PATCH v2 02/13] ARM: pxa: add dma slave map

2018-05-24 Thread Robert Jarzmik
Robert Jarzmik <robert.jarz...@free.fr> writes: > In order to remove the specific knowledge of the dma mapping from PXA > drivers, add a default slave map for pxa architectures. > > This is the first step, and once all drivers are converted, > pxad_filter_fn() will be mad

Re: [PATCH v2 05/13] mtd: rawnand: marvell: remove the dmaengine compat need

2018-05-24 Thread Robert Jarzmik
Miquel Raynal writes: > Hi Robert, Actually, a last time error slipped in this patch here (I'm really doing poorly on the copy paste side): + nfc->dma_chan = dma_request_slave_channel(>dev, "data"); This should rather be : + nfc->dma_chan =

[PATCH v2 10/13] dmaengine: pxa: document pxad_param

2018-05-24 Thread Robert Jarzmik
Add some documentation for the pxad_param structure, and describe the contract behind the minimal required priority of a DMA channel. Signed-off-by: Robert Jarzmik <robert.jarz...@free.fr> --- include/linux/dma/pxa-dma.h | 9 + 1 file changed, 9 insertions(+) diff --git a/include

[PATCH v2 12/13] ARM: pxa: remove the DMA IO resources

2018-05-24 Thread Robert Jarzmik
As the last driver using the former mechanism to acquire the DMA requestor line has be converted to the dma_slave_map, remove all these resources from the PXA devices. Signed-off-by: Robert Jarzmik <robert.jarz...@free.fr> --- arch/arm/mach-pxa/devices.c

[PATCH v2 02/13] ARM: pxa: add dma slave map

2018-05-24 Thread Robert Jarzmik
In order to remove the specific knowledge of the dma mapping from PXA drivers, add a default slave map for pxa architectures. This is the first step, and once all drivers are converted, pxad_filter_fn() will be made static, and the DMA resources removed from device.c. Signed-off-by: Robert

[PATCH v2 08/13] ASoC: pxa: remove the dmaengine compat need

2018-05-24 Thread Robert Jarzmik
-off-by: Robert Jarzmik <robert.jarz...@free.fr> --- sound/arm/pxa2xx-ac97.c | 14 ++ sound/arm/pxa2xx-pcm-lib.c | 6 +++--- sound/soc/pxa/pxa2xx-ac97.c | 32 +--- sound/soc/pxa/pxa2xx-i2s.c | 6 ++ 4 files changed, 12 insertions(+), 46 del

[PATCH v2 06/13] net: smc911x: remove the dmaengine compat need

2018-05-24 Thread Robert Jarzmik
-off-by: Robert Jarzmik <robert.jarz...@free.fr> --- drivers/net/ethernet/smsc/smc911x.c | 16 ++-- 1 file changed, 2 insertions(+), 14 deletions(-) diff --git a/drivers/net/ethernet/smsc/smc911x.c b/drivers/net/ethernet/smsc/smc911x.c index 05157442a980..4c3713bd5caa

[PATCH v2 09/13] ata: pata_pxa: remove the dmaengine compat need

2018-05-24 Thread Robert Jarzmik
-off-by: Robert Jarzmik <robert.jarz...@free.fr> Acked-by: Bartlomiej Zolnierkiewicz <b.zolnier...@samsung.com> --- drivers/ata/pata_pxa.c | 10 +- 1 file changed, 1 insertion(+), 9 deletions(-) diff --git a/drivers/ata/pata_pxa.c b/drivers/ata/pata_pxa.c index f6c46e9a4dc0..

[PATCH v2 01/13] dmaengine: pxa: use a dma slave map

2018-05-24 Thread Robert Jarzmik
, and the DMA resources removed from device.c. Signed-off-by: Robert Jarzmik <robert.jarz...@free.fr> Reported-by: Arnd Bergmann <a...@arndb.de> Acked-by: Vinod Koul <vk...@kernel.org> --- drivers/dma/pxa_dma.c | 10 +- include/linux/platform_data/mmp_

[PATCH v2 05/13] mtd: rawnand: marvell: remove the dmaengine compat need

2018-05-24 Thread Robert Jarzmik
-off-by: Signed-off-by: Daniel Mack <dan...@zonque.org> Signed-off-by: Robert Jarzmik <robert.jarz...@free.fr> --- drivers/mtd/nand/raw/marvell_nand.c | 17 + 1 file changed, 1 insertion(+), 16 deletions(-) diff --git a/drivers/mtd/nand/raw/marvell_nand.c b/drivers/

[PATCH v2 03/13] mmc: pxamci: remove the dmaengine compat need

2018-05-24 Thread Robert Jarzmik
-off-by: Robert Jarzmik <robert.jarz...@free.fr> Acked-by: Ulf Hansson <ulf.hans...@linaro.org> --- drivers/mmc/host/pxamci.c | 29 +++-- 1 file changed, 3 insertions(+), 26 deletions(-) diff --git a/drivers/mmc/host/pxamci.c b/drivers/mmc/host/pxamci.c index

[PATCH v2 04/13] media: pxa_camera: remove the dmaengine compat need

2018-05-24 Thread Robert Jarzmik
-off-by: Robert Jarzmik <robert.jarz...@free.fr> Acked-by: Hans Verkuil <hans.verk...@cisco.com> Acked-by: Mauro Carvalho Chehab <mchehab+sams...@kernel.org> --- drivers/media/platform/pxa_camera.c | 22 +++--- 1 file changed, 3 insertions(+), 19 deletions(-) di

[PATCH v2 11/13] dmaengine: pxa: make the filter function internal

2018-05-24 Thread Robert Jarzmik
As the pxa architecture and all its related drivers do not rely anymore on the filter function, thanks to the slave map conversion, make pxad_filter_fn() static, and remove it from the global namespace. Signed-off-by: Robert Jarzmik <robert.jarz...@free.fr> --- drivers/dma/pxa_dma.c

[PATCH v2 13/13] ARM: pxa: change SSP DMA channels allocation

2018-05-24 Thread Robert Jarzmik
ot;rx" or "tx". - for device tree platforms, the dma node should be hooked into the pxa2xx-ac97 or pxa-ssp-dai node. Signed-off-by: Robert Jarzmik <robert.jarz...@free.fr> --- Since v1: Removed channel names from platform_data --- arch/

[PATCH v2 07/13] net: smc91x: remove the dmaengine compat need

2018-05-24 Thread Robert Jarzmik
-off-by: Robert Jarzmik <robert.jarz...@free.fr> --- drivers/net/ethernet/smsc/smc91x.c | 12 +--- drivers/net/ethernet/smsc/smc91x.h | 1 - 2 files changed, 1 insertion(+), 12 deletions(-) diff --git a/drivers/net/ethernet/smsc/smc91x.c b/drivers/net/ethernet/smsc/smc91x.c

[PATCH v2 00/13] ARM: pxa: switch to DMA slave maps

2018-05-24 Thread Robert Jarzmik
that the cpu device provides the DMA - I added pxa2xx-i2s which was forgotten Therefore I need a new ack - Arnd and Daniel / SSP topic / 0013 Review and ack of this one Happy review. -- Robert Robert Jarzmik (13): dmaengine: pxa: use a dma slave map ARM: pxa: add dma slave map mmc

Re: [PATCH 29/61] mtd: devices: simplify getting .drvdata

2018-04-21 Thread Robert Jarzmik
Wolfram Sang <wsa+rene...@sang-engineering.com> writes: > We should get drvdata from struct device directly. Going via > platform_device is an unneeded step back and forth. > > Signed-off-by: Wolfram Sang <wsa+rene...@sang-engineering.com> Acked-by: Robert Jarzmik <robe

Re: [PATCH 10/15] ata: pata_pxa: remove the dmaengine compat need

2018-04-21 Thread Robert Jarzmik
Robert Jarzmik <robert.jarz...@free.fr> writes: > As the pxa architecture switched towards the dmaengine slave map, the > old compatibility mechanism to acquire the dma requestor line number and > priority are not needed anymore. > > This patch simplifies the dma resour

Re: [PATCH 09/15] net: irda: pxaficp_ir: remove the dmaengine compat need

2018-04-21 Thread Robert Jarzmik
Robert Jarzmik <robert.jarz...@free.fr> writes: > As the pxa architecture switched towards the dmaengine slave map, the > old compatibility mechanism to acquire the dma requestor line number and > priority are not needed anymore. > > This patch simplifies the dma resour

Re: [PATCH 04/15] media: pxa_camera: remove the dmaengine compat need

2018-04-21 Thread Robert Jarzmik
Robert Jarzmik <robert.jarz...@free.fr> writes: > From: Robert Jarzmik <robert.jarz...@renault.com> > > As the pxa architecture switched towards the dmaengine slave map, the > old compatibility mechanism to acquire the dma requestor line number and > prio

Re: [PATCH 1/7] i2c: i2c-gpio: move header to platform_data

2018-04-20 Thread Robert Jarzmik
Wolfram Sang <w...@the-dreams.de> writes: > This header only contains platform_data. Move it to the proper directory. > > Signed-off-by: Wolfram Sang <w...@the-dreams.de> For mach-pxa: Acked-by: Robert Jarzmik <robert.jarz...@free.fr> Take it through your tree,

Re: [PATCH 08/15] ASoC: pxa: remove the dmaengine compat need

2018-04-12 Thread Robert Jarzmik
Mark Brown <broo...@kernel.org> writes: > On Mon, Apr 02, 2018 at 04:26:49PM +0200, Robert Jarzmik wrote: >> As the pxa architecture switched towards the dmaengine slave map, the >> old compatibility mechanism to acquire the dma requestor line number and >> prio

Re: [PATCH 14/15] ARM: pxa: change SSP devices allocation

2018-04-08 Thread Robert Jarzmik
Arnd Bergmann writes: > I don't know exactly how the probing works, but I'd assume that we have > the correct device pointers in pxa2xx_ac97_dev_probe() and > asoc_ssp_probe(), or maybe in pxa2xx_ac97_*_startup() and > pxa_ssp_startup(). Yes, let's try this way, in the former

Re: [RESEND PATCH] ARM: pxa: stargate2: use device properties for at24 eeprom

2018-04-08 Thread Robert Jarzmik
Bartosz Golaszewski <b...@bgdev.pl> writes: > 2018-04-04 21:44 GMT+02:00 Robert Jarzmik <robert.jarz...@free.fr>: >> Bartosz Golaszewski <b...@bgdev.pl> writes: > Yes, it does use the type field from i2c_board_info implicitly over > i2c-core. The type fie

Re: [PATCH 14/15] ARM: pxa: change SSP devices allocation

2018-04-05 Thread Robert Jarzmik
Arnd Bergmann writes: > I'm still unable to follow through that code, but I understand now that > the device you pass to dma_request_slave_channel() is not the one > we'd like it to be here. > > Where exactly does that call to dma_request_chan() happen? Is this > the one in

Re: [PATCH 00/15] ARM: pxa: switch to DMA slave maps

2018-04-04 Thread Robert Jarzmik
Ulf Hansson <ulf.hans...@linaro.org> writes: > On 2 April 2018 at 16:26, Robert Jarzmik <robert.jarz...@free.fr> wrote: >> Hi, >> >> This serie is aimed at removing the dmaengine slave compat use, and transfer >> knowledge of the DMA requestors into a

Re: [RESEND PATCH] ARM: pxa: stargate2: use device properties for at24 eeprom

2018-04-04 Thread Robert Jarzmik
Bartosz Golaszewski writes: > We want to work towards phasing out the at24_platform_data structure. > There are few users and its contents can be represented using generic > device properties. Using device properties only will allow us to > significantly simplify the at24

Re: [PATCH 02/15] ARM: pxa: add dma slave map

2018-04-04 Thread Robert Jarzmik
Arnd Bergmann <a...@arndb.de> writes: > On Tue, Apr 3, 2018 at 10:19 PM, Robert Jarzmik <robert.jarz...@free.fr> > wrote: >> ... chop chop removing unneeded recipients >> >> Arnd Bergmann <a...@arndb.de> writes: >>> It still feel

Re: [PATCH 02/15] ARM: pxa: add dma slave map

2018-04-03 Thread Robert Jarzmik
... chop chop removing unneeded recipients Arnd Bergmann writes: > Ok, I looked at the driver in more detail now and found the scary parts. > So it's using the async DMA interface to do synchronous DMA in > interrupt context in order to transfer the rx data faster than an

  1   2   3   4   5   6   7   8   9   10   >