On Thu, May 16, 2013 at 1:19 PM, Andrew Morton
wrote:
> On Thu, 16 May 2013 13:08:17 -0400 Robert Love wrote:
>> This problem seems a rare proper use of mutex_trylock.
>
> Not really. The need for a trylock is often an indication that a
> subsystem has a locking misdesig
On Thu, May 16, 2013 at 12:45 PM, Andrew Morton
wrote:
> A better approach would be to add a new __GFP_NOSHRINKERS, but it's all
> variations on a theme.
I don't like this proposal, either. Many of the existing GFP flags
already exist to prevent recurse into that flag's respective shrinker.
On Thu, May 16, 2013 at 4:15 AM, Raul Xiong wrote:
> The issue happens in such sequence:
> ashmem_mmap acquired ashmem_mutex --> ashmem_mutex:shmem_file_setup
> called kmem_cache_alloc --> shrink due to low memory --> ashmem_shrink
> tries to acquire the same ashmem_mutex -- it blocks here.
>
> I
On Thu, May 16, 2013 at 4:15 AM, Raul Xiong raulxi...@gmail.com wrote:
The issue happens in such sequence:
ashmem_mmap acquired ashmem_mutex -- ashmem_mutex:shmem_file_setup
called kmem_cache_alloc -- shrink due to low memory -- ashmem_shrink
tries to acquire the same ashmem_mutex -- it blocks
On Thu, May 16, 2013 at 12:45 PM, Andrew Morton
a...@linux-foundation.org wrote:
A better approach would be to add a new __GFP_NOSHRINKERS, but it's all
variations on a theme.
I don't like this proposal, either. Many of the existing GFP flags
already exist to prevent recurse into that flag's
On Thu, May 16, 2013 at 1:19 PM, Andrew Morton
a...@linux-foundation.org wrote:
On Thu, 16 May 2013 13:08:17 -0400 Robert Love rl...@google.com wrote:
This problem seems a rare proper use of mutex_trylock.
Not really. The need for a trylock is often an indication that a
subsystem has
Don't acquire ashmem_mutex in ashmem_shrink if we've somehow recursed into the
shrinker code from within ashmem. Just bail out, avoiding a deadlock. This is
fine, as ashmem cache pruning is advisory anyhow.
Signed-off-by: Robert Love
---
drivers/staging/android/ashmem.c | 6 +-
1 file
Don't acquire ashmem_mutex in ashmem_shrink if we've somehow recursed into the
shrinker code from within ashmem. Just bail out, avoiding a deadlock. This is
fine, as ashmem cache pruning is advisory anyhow.
Signed-off-by: Robert Love rl...@google.com
---
drivers/staging/android/ashmem.c | 6
On Tue, Apr 30, 2013 at 9:29 AM, Shankar Brahadeeswaran
wrote:
> Question:
> On occasions when we return because of the lock unavailability, what
> could be the worst case number of ashmem pages that are left
> unfreed (lru_count). Will it be very huge and have side effects?
On that VM shrink
On Tue, Apr 30, 2013 at 9:29 AM, Shankar Brahadeeswaran
shanko...@gmail.com wrote:
Question:
On occasions when we return because of the lock unavailability, what
could be the worst case number of ashmem pages that are left
unfreed (lru_count). Will it be very huge and have side effects?
On
On Thu, Apr 25, 2013 at 9:54 AM, Shankar Brahadeeswaran
wrote:
> Also, there are other places in the code where ashmem_mutex is held and memory
> allocation functions are called, ex:- range_alloc, calls kmem_cache_zalloc
>
> Since ashmem_shrink holds the ashmem_mutex, any where from ashmem
On Thu, Apr 25, 2013 at 9:54 AM, Shankar Brahadeeswaran
shanko...@gmail.com wrote:
Also, there are other places in the code where ashmem_mutex is held and memory
allocation functions are called, ex:- range_alloc, calls kmem_cache_zalloc
Since ashmem_shrink holds the ashmem_mutex, any where
On Tue, Apr 23, 2013 at 12:20 PM, Shankar Brahadeeswaran
wrote:
> I'm unable to think of a straight forward way to fix this. If you have
> any suggestions please provide the same.
> If we are unable to solve this too with minor mods, as suggested by
> Dan we have to re-look at the locking in
On Tue, Apr 23, 2013 at 12:20 PM, Shankar Brahadeeswaran
shanko...@gmail.com wrote:
I'm unable to think of a straight forward way to fix this. If you have
any suggestions please provide the same.
If we are unable to solve this too with minor mods, as suggested by
Dan we have to re-look at the
On Mon, Apr 22, 2013 at 10:22 AM, Dan Carpenter
wrote:
> Read Al's email again: https://lkml.org/lkml/2013/3/20/458
>
> I don't know much about VFS locking, but the ashmem locking seems
> pretty bogus to me. Why can't multiple threads read() at the same
> time?
ashmem originally did not
On Mon, Apr 22, 2013 at 10:22 AM, Dan Carpenter
dan.carpen...@oracle.com wrote:
Read Al's email again: https://lkml.org/lkml/2013/3/20/458
I don't know much about VFS locking, but the ashmem locking seems
pretty bogus to me. Why can't multiple threads read() at the same
time?
ashmem
On Thu, Mar 21, 2013 at 10:06 AM, Bjorn Bringert wrote:
> I did implement ashmem_read, but I had no idea what I was doing. Calling the
> VFS read function seemed like an obvious way to do it, but it might be
> wrong. If that needs fixing, then the similar VFS call in ashmem_llseek
> probably
On Thu, Mar 21, 2013 at 10:06 AM, Bjorn Bringert bring...@google.com wrote:
I did implement ashmem_read, but I had no idea what I was doing. Calling the
VFS read function seemed like an obvious way to do it, but it might be
wrong. If that needs fixing, then the similar VFS call in ashmem_llseek
Andrew,
Attached patch updates the hdaps driver in 2.6.13-mm2. It is a drop-in
replacement for the current patch.
Changes: bug fixes and an absolute input device.
Thanks,
Robert Love
driver for hdaps
MAINTAINERS|7
drivers/hwmon/Kconfig | 17 +
drivers/hwmon
Andrew,
Attached patch updates the hdaps driver in 2.6.13-mm2. It is a drop-in
replacement for the current patch.
Changes: bug fixes and an absolute input device.
Thanks,
Robert Love
driver for hdaps
MAINTAINERS|7
drivers/hwmon/Kconfig | 17 +
drivers/hwmon
,
Robert Love
Driver for the IBM Hard Drive Active Protection System (HDAPS), an
accelerometer found in most modern ThinkPads.
Signed-off-by: Robert Love <[EMAIL PROTECTED]>
diff -urN linux-2.6.13/drivers/hwmon/hdaps.c linux/drivers/hwmon/hdaps.c
--- linux-2.6.13/drivers/hwmon/hdaps.c 1
,
Robert Love
Driver for the IBM Hard Drive Active Protection System (HDAPS), an
accelerometer found in most modern ThinkPads.
Signed-off-by: Robert Love [EMAIL PROTECTED]
diff -urN linux-2.6.13/drivers/hwmon/hdaps.c linux/drivers/hwmon/hdaps.c
--- linux-2.6.13/drivers/hwmon/hdaps.c 1969-12
t; and when /dev/hda1 is unmounted, you will get
an IN_UNMOUNT on the watch.
Robert Love
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to [EMAIL PROTECTED]
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/
/ (./inotify_test /mnt)
- umount /mnt
results in two events:
1. IN_DELETE_SELF (mask=0x0400)
2. IN_IGNORED (mask=0x8000)
Any ideas?
/mnt is not unmounted, stuff inside of it is.
Watch, say, /mnt/foo/bar and when /dev/hda1 is unmounted, you will get
an IN_UNMOUNT on the watch.
Robert Love
-circuiting.
Robert Love
Signed-off-by: Robert Love <[EMAIL PROTECTED]>
arch/i386/kernel/dmi_scan.c |2 +-
1 files changed, 1 insertion(+), 1 deletion(-)
diff -urN linux-2.6.13/arch/i386/kernel/dmi_scan.c
linux/arch/i386/kernel/dmi_scan.c
--- linux-2.6.13/arch/i386/kernel/dmi_
-circuiting.
Robert Love
Signed-off-by: Robert Love [EMAIL PROTECTED]
arch/i386/kernel/dmi_scan.c |2 +-
1 files changed, 1 insertion(+), 1 deletion(-)
diff -urN linux-2.6.13/arch/i386/kernel/dmi_scan.c
linux/arch/i386/kernel/dmi_scan.c
--- linux-2.6.13/arch/i386/kernel/dmi_scan.c
ive to programmers reading the code.
> input_[un]register_device and del_timer_sync are "long" operations. I
> think a semaphore would be better here.
I was considering moving all locking to a single semaphore, actually.
Robert Love
-
To unsubscribe from this lis
Andrew,
Attached patch provides a driver for the IBM Hard Drive Active
Protection System (hdaps) on top of 2.6.13-rc6-mm2.
Over the previous post, it contains several fixes and improvements,
including a dev->probe() routine and a DMI whitelist.
Robert Love
Driver for the IBM HD
On Fri, 2005-08-26 at 15:39 -0400, Robert Love wrote:
> > This is racy - 2 threads can try to do this simultaneously.
>
> Fixed. Thanks.
Actually, doesn't sysfs and/or the vfs layer serialize the two
simultaneous writes?
Robert Love
-
To unsubscribe from this list: s
On Fri, 2005-08-26 at 15:33 -0400, Jeff Garzik wrote:
> Since such a check is possible, that's definitely a merge-stopper IMO
First, I am not asking that Linus merge this. Everyone needs to relax.
Second, we don't know a DMI-based solution will work. I'll check it out.
Robert L
_create_file(_plat_dev.dev,
> > _attr_mousedev_threshold);
> > + device_create_file(_plat_dev.dev, _attr_mousedev_poll_ms);
> > +
>
> What about using sysfs_attribute_group?
I don't see this in my tree?
Robert Love
-
To unsubscribe from this list: send the line "
out the
requisite hardware.
Robert Love
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to [EMAIL PROTECTED]
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/
of people with a ThinkPad can feel free to
try a DMI-based probe() out, if they want a probe() routine, was my
point.
Robert Love
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to [EMAIL PROTECTED]
More majordomo info at http://vger.k
PUT=n, CONFIG_INPUT_MOUSEDEV=n, etc?
Probably a question you should of asked before merging the patch. ;-)
We just need CONFIG_INPUT.
Thanks,
Robert Love
Depend on CONFIG_INPUT.
Signed-off-by: Robert Love <[EMAIL PROTECTED]>
diff -u linux/drivers/hwmon/Kconfig linux/drivers/hwmo
On Fri, 2005-08-26 at 20:01 +0200, Arjan van de Ven wrote:
> > Not that we've been able to tell. It is a legacy platform device.
> >
> > So, unfortunately, no probe() routine.
>
> dmi surely
Patches accepted.
Robert Love
-
To unsubscribe from
The function name doesn't fit, but it never did.
>
> Signed-off-by: John McCutchan <[EMAIL PROTECTED]>
Signed-off-by: Robert Love <[EMAIL PROTECTED]>
Keeping the current behavior is probably the best way to go.
On Fri, 2005-08-26 at 13:33 -0400, Brian Gerst wrote:
> Is there any way to detect that this device is present (PCI, ACPI, etc.)
> without poking at ports?
Not that we've been able to tell. It is a legacy platform device.
So, unfortunately, no probe() routine.
Rober
On Fri, 2005-08-26 at 13:05 -0400, Bill Nottingham wrote:
> How does this relate to the hdaps driver hosted at sourceforge since
> June?
This driver is what is hosted there.
I thought it was time to push on.
Robert Love
-
To unsubscribe from this list: send the line "
-contained and fairly simple.
Please, apply.
Robert Love
Driver for the IBM HDAPS, an accelerometer
Signed-off-by: Robert Love <[EMAIL PROTECTED]>
MAINTAINERS|7
drivers/hwmon/Kconfig | 17 +
drivers/hwmon/Makefile |1
drivers/hwmon/hdaps.c
-contained and fairly simple.
Please, apply.
Robert Love
Driver for the IBM HDAPS, an accelerometer
Signed-off-by: Robert Love [EMAIL PROTECTED]
MAINTAINERS|7
drivers/hwmon/Kconfig | 17 +
drivers/hwmon/Makefile |1
drivers/hwmon/hdaps.c | 594
On Fri, 2005-08-26 at 13:05 -0400, Bill Nottingham wrote:
How does this relate to the hdaps driver hosted at sourceforge since
June?
This driver is what is hosted there.
I thought it was time to push on.
Robert Love
-
To unsubscribe from this list: send the line unsubscribe linux
On Fri, 2005-08-26 at 13:33 -0400, Brian Gerst wrote:
Is there any way to detect that this device is present (PCI, ACPI, etc.)
without poking at ports?
Not that we've been able to tell. It is a legacy platform device.
So, unfortunately, no probe() routine.
Robert Love
did.
Signed-off-by: John McCutchan [EMAIL PROTECTED]
Signed-off-by: Robert Love [EMAIL PROTECTED]
Keeping the current behavior is probably the best way to go.
Robert Love
Index: linux/fs/inotify.c
===
--- linux.orig/fs
On Fri, 2005-08-26 at 20:01 +0200, Arjan van de Ven wrote:
Not that we've been able to tell. It is a legacy platform device.
So, unfortunately, no probe() routine.
dmi surely
Patches accepted.
Robert Love
-
To unsubscribe from this list: send the line unsubscribe linux
should of asked before merging the patch. ;-)
We just need CONFIG_INPUT.
Thanks,
Robert Love
Depend on CONFIG_INPUT.
Signed-off-by: Robert Love [EMAIL PROTECTED]
diff -u linux/drivers/hwmon/Kconfig linux/drivers/hwmon/Kconfig
--- linux/drivers/hwmon/Kconfig 2005-08-26 11:07
can feel free to
try a DMI-based probe() out, if they want a probe() routine, was my
point.
Robert Love
-
To unsubscribe from this list: send the line unsubscribe linux-kernel in
the body of a message to [EMAIL PROTECTED]
More majordomo info at http://vger.kernel.org/majordomo-info.html
,
dev_attr_mousedev_threshold);
+ device_create_file(hdaps_plat_dev.dev, dev_attr_mousedev_poll_ms);
+
What about using sysfs_attribute_group?
I don't see this in my tree?
Robert Love
-
To unsubscribe from this list: send the line unsubscribe linux-kernel in
the body of a message to [EMAIL
On Fri, 2005-08-26 at 15:33 -0400, Jeff Garzik wrote:
Since such a check is possible, that's definitely a merge-stopper IMO
First, I am not asking that Linus merge this. Everyone needs to relax.
Second, we don't know a DMI-based solution will work. I'll check it out.
Robert Love
On Fri, 2005-08-26 at 15:39 -0400, Robert Love wrote:
This is racy - 2 threads can try to do this simultaneously.
Fixed. Thanks.
Actually, doesn't sysfs and/or the vfs layer serialize the two
simultaneous writes?
Robert Love
-
To unsubscribe from this list: send the line
the
requisite hardware.
Robert Love
-
To unsubscribe from this list: send the line unsubscribe linux-kernel in
the body of a message to [EMAIL PROTECTED]
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/
Andrew,
Attached patch provides a driver for the IBM Hard Drive Active
Protection System (hdaps) on top of 2.6.13-rc6-mm2.
Over the previous post, it contains several fixes and improvements,
including a dev-probe() routine and a DMI whitelist.
Robert Love
Driver for the IBM HDAPS
.
input_[un]register_device and del_timer_sync are long operations. I
think a semaphore would be better here.
I was considering moving all locking to a single semaphore, actually.
Robert Love
-
To unsubscribe from this list: send the line unsubscribe linux-kernel in
the body
with 2.6.12-rc6-mm(1|2) kernel.
> >
> > Robert, John, what do you think? Is this possibly related to the oops
> > seen
> > in the log that I reported earlier? (Which is still showing up 2-3 times
> > per
> > day, btw)
>
> There is definitely somet
ve(),
which is I believe the behavior of the other interface, and see if the
1024-multiple problem goes away. We definitely did not have that
before.
If it does, and we don't have another solution, let's run with that for
2.6.13. I don't want this bug released.
Robert Love
-
To
believe the behavior of the other interface, and see if the
1024-multiple problem goes away. We definitely did not have that
before.
If it does, and we don't have another solution, let's run with that for
2.6.13. I don't want this bug released.
Robert Love
-
To unsubscribe from this list
idr, like, zero, is unallocated, NULL is returned.
This readily manifests itself in inotify, where we recently switched to
using idr_get_new_above() with our last allocated token.
Robert Love
-
To unsubscribe from this list: send the line unsubscribe linux-kernel in
the body of a message
blem was in our court and not the idr layer.
idr_get_new_above() seems to work fine.
One-line patch is attached. Please merge before 2.6.13.
Robert Love
We are saving the wrong thing in ->last_wd. We want the wd, not the return
value.
Signed-off-by: Robert Love <[EMAIL PROTECTED]&g
and not the idr layer.
idr_get_new_above() seems to work fine.
One-line patch is attached. Please merge before 2.6.13.
Robert Love
We are saving the wrong thing in -last_wd. We want the wd, not the return
value.
Signed-off-by: Robert Love [EMAIL PROTECTED]
fs/inotify.c |2 +-
1 files
.6.git;a=commit;h=7a91bf7f5c22c8407a9991cbd9ce5bb87caa6b4a
Should solve this problem?
Robert Love
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to [EMAIL PROTECTED]
More majordomo info at http://vger.kernel.org/majordomo-info.
;a=commit;h=7a91bf7f5c22c8407a9991cbd9ce5bb87caa6b4a
Should solve this problem?
Robert Love
-
To unsubscribe from this list: send the line unsubscribe linux-kernel in
the body of a message to [EMAIL PROTECTED]
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read
Add inotify and ioprio syscall stubs to SH64.
Robert Love
Signed-off-by: Robert Love <[EMAIL PROTECTED]>
arch/sh64/kernel/syscalls.S |5 +
include/asm-sh64/unistd.h |7 ++-
2 files changed, 11 insertions(+), 1 deletion(-)
diff -urN linux-2.6.13-rc6-git2/arc
Add inotify and ioprio syscall stubs to SH.
Robert Love
Signed-off-by: Robert Love <[EMAIL PROTECTED]>
arch/sh/kernel/entry.S |5 +
include/asm-sh/unistd.h |8 +++-
2 files changed, 12 insertions(+), 1 deletion(-)
diff -urN linux-2.6.13-rc6-git2/arch/sh/
Russell,
Hey. Attached patch adds the syscall stubs for the inotify and ioprio
system calls to ARM.
Robert Love
Signed-off-by: Robert Love <[EMAIL PROTECTED]>
arch/arm/kernel/calls.S |6 ++
include/asm-arm/unistd.h |5 +
2 files changed, 11 insertions(+)
dif
Russell,
Hey. Attached patch adds the syscall stubs for the inotify and ioprio
system calls to ARM.
Robert Love
Signed-off-by: Robert Love [EMAIL PROTECTED]
arch/arm/kernel/calls.S |6 ++
include/asm-arm/unistd.h |5 +
2 files changed, 11 insertions(+)
diff -urN
Add inotify and ioprio syscall stubs to SH.
Robert Love
Signed-off-by: Robert Love [EMAIL PROTECTED]
arch/sh/kernel/entry.S |5 +
include/asm-sh/unistd.h |8 +++-
2 files changed, 12 insertions(+), 1 deletion(-)
diff -urN linux-2.6.13-rc6-git2/arch/sh/kernel/entry.S
Add inotify and ioprio syscall stubs to SH64.
Robert Love
Signed-off-by: Robert Love [EMAIL PROTECTED]
arch/sh64/kernel/syscalls.S |5 +
include/asm-sh64/unistd.h |7 ++-
2 files changed, 11 insertions(+), 1 deletion(-)
diff -urN linux-2.6.13-rc6-git2/arch/sh64
lls.
We should.
Robert Love
Add fsnotify_xattr() hook to removexattr().
Signed-off-by: Robert Love <[EMAIL PROTECTED]>
fs/xattr.c |2 ++
1 files changed, 2 insertions(+)
diff -urN linux-2.6.13-rc5/fs/xattr.c linux/fs/xattr.c
--- linux-2.6.13-rc5/fs/xattr.c 2005-08-05 15:
.
Robert Love
Add fsnotify_xattr() hook to removexattr().
Signed-off-by: Robert Love [EMAIL PROTECTED]
fs/xattr.c |2 ++
1 files changed, 2 insertions(+)
diff -urN linux-2.6.13-rc5/fs/xattr.c linux/fs/xattr.c
--- linux-2.6.13-rc5/fs/xattr.c 2005-08-05 15:49:17.0 -0400
+++ linux/fs
The inotify help text still refers to the character device. Update it.
Fixes kernel bug #4993.
Signed-off-by: Robert Love <[EMAIL PROTECTED]>
fs/Kconfig | 11 +++
1 files changed, 7 insertions(+), 4 deletions(-)
--- linux-2.6.13-rc3-git8/fs/Kconfig2005-07-27 10:59:32.000
The inotify help text still refers to the character device. Update it.
Fixes kernel bug #4993.
Signed-off-by: Robert Love [EMAIL PROTECTED]
fs/Kconfig | 11 +++
1 files changed, 7 insertions(+), 4 deletions(-)
--- linux-2.6.13-rc3-git8/fs/Kconfig2005-07-27 10:59:32.0
full stack frame just to sign extend arguments.
Yah, but it looked like they did the sign extend thing for every int but
file descriptors, and fd's are the only int's we have.
Robert Love
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a m
[ I don't think we need sys32 compatibility versions--and if we do, I
failed in life. ]
Robert Love
Signed-off-by: Robert Love <[EMAIL PROTECTED]>
arch/ppc64/kernel/misc.S |6 ++
include/asm-ppc64/unistd.h |5 -
2 files changed, 10 insertions(+), 1 deletion(-)
diff -u
Hi, Tony.
Attached patch adds the inotify syscalls to ia64.
Signed-off-by: Robert Love <[EMAIL PROTECTED]>
arch/ia64/kernel/entry.S |6 +++---
include/asm-ia64/unistd.h |3 +++
2 files changed, 6 insertions(+), 3 deletions(-)
diff -urN linux-2.6.13-rc3-git8/arch/ia64/kernel/e
Hey, Paulus,
Add inotify system call stubs to PPC32.
Signed-off-by: Robert Love <[EMAIL PROTECTED]>
arch/ppc/kernel/misc.S |3 +++
include/asm-ppc/unistd.h |5 -
2 files changed, 7 insertions(+), 1 deletion(-)
diff -urN linux-2.6.13-rc3-git8/arch/ppc/kernel/misc.S
linu
Hey, Paulus,
Add inotify system call stubs to PPC32.
Signed-off-by: Robert Love [EMAIL PROTECTED]
arch/ppc/kernel/misc.S |3 +++
include/asm-ppc/unistd.h |5 -
2 files changed, 7 insertions(+), 1 deletion(-)
diff -urN linux-2.6.13-rc3-git8/arch/ppc/kernel/misc.S
linux/arch/ppc
Hi, Tony.
Attached patch adds the inotify syscalls to ia64.
Signed-off-by: Robert Love [EMAIL PROTECTED]
arch/ia64/kernel/entry.S |6 +++---
include/asm-ia64/unistd.h |3 +++
2 files changed, 6 insertions(+), 3 deletions(-)
diff -urN linux-2.6.13-rc3-git8/arch/ia64/kernel/entry.S
we need sys32 compatibility versions--and if we do, I
failed in life. ]
Robert Love
Signed-off-by: Robert Love [EMAIL PROTECTED]
arch/ppc64/kernel/misc.S |6 ++
include/asm-ppc64/unistd.h |5 -
2 files changed, 10 insertions(+), 1 deletion(-)
diff -urN linux-2.6.13-rc3
extend arguments.
Yah, but it looked like they did the sign extend thing for every int but
file descriptors, and fd's are the only int's we have.
Robert Love
-
To unsubscribe from this list: send the line unsubscribe linux-kernel in
the body of a message to [EMAIL PROTECTED]
More majordomo
On Fri, 2005-07-15 at 22:01 +0200, Andi Kleen wrote:
> It won't work anyways because you forgot to patch the compat
> sys32_open.
Well, "won't work" is a bit harsh, its just one hook. But that was
next.
I usually leave per-arch stuff to the arch folks.
Robert Love
A
Andi,
Attached patch adds the inotify syscall numbers to x86-64. Also adds
the new ioprio_get() and ioprio_set() calls to the IA32 layer.
Robert Love
Add the inotify syscalls to x86-64
Signed-off-by: Robert Love <[EMAIL PROTECTED]>
arch/x86_64/ia32/ia32entry.S
Andi,
Attached patch adds the inotify syscall numbers to x86-64. Also adds
the new ioprio_get() and ioprio_set() calls to the IA32 layer.
Robert Love
Add the inotify syscalls to x86-64
Signed-off-by: Robert Love [EMAIL PROTECTED]
arch/x86_64/ia32/ia32entry.S |8
On Fri, 2005-07-15 at 22:01 +0200, Andi Kleen wrote:
It won't work anyways because you forgot to patch the compat
sys32_open.
Well, won't work is a bit harsh, its just one hook. But that was
next.
I usually leave per-arch stuff to the arch folks.
Robert Love
Add fsnotify_open
Linus,
Trivial documentation update for inotify. Please, apply.
Robert Love
Clean up and expand some of the inotify documentation.
Signed-off-by: Robert Love <[EMAIL PROTECTED]>
Documentation/filesystems/inotify.txt | 77 +++---
1 files chang
Linus,
Real simple, basic cleanup.
Please, apply.
Robert Love
Signed-off-by: Robert Love <[EMAIL PROTECTED]>
fs/inotify.c |9 +++--
include/linux/sched.h |2 +-
kernel/user.c |2 +-
3 files changed, 5 insertions(+), 8 deletions(-)
diff -urN
em call, now. ;-)
> OK - you exported a common underlying function
> inotify_inode_queue_event
> under the inline functions which the network/cluster fs would call to notify
> of remote changes.
> That makes sense. I had missed that.
Nod.
Robert Love
-
To unsubscribe f
l system about changes.
Eh?
They are in .
Robert Love
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to [EMAIL PROTECTED]
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/
Linus,
Real simple, basic cleanup.
Please, apply.
Robert Love
Signed-off-by: Robert Love <[EMAIL PROTECTED]>
fs/inotify.c |9 +++--
include/linux/sched.h |2 +-
kernel/user.c |2 +-
3 files changed, 5 insertions(+), 8 deletions(-)
diff -urN
Linus,
Attached patch rearranges the event ordering for "open" to be consistent
with the ordering of the other events.
Patch is against current git tree. Please, apply.
Robert Love
Signed-off-by: Robert Love <[EMAIL PROTECTED]>
include/linux/fsnotify.h |2 +-
1
Linus,
Attached patch moves the inotify sysctl knobs to "/proc/sys/fs/inotify"
from "/proc/sys/fs". Also some related cleanup.
Patch is against current git tree. Please, apply.
Robert Love
Signed-off-by: Robert Love <[EMAIL PROTECTED]>
fs/
Linus,
Attached patch moves the inotify sysctl knobs to /proc/sys/fs/inotify
from /proc/sys/fs. Also some related cleanup.
Patch is against current git tree. Please, apply.
Robert Love
Signed-off-by: Robert Love [EMAIL PROTECTED]
fs/inotify.c | 49
Linus,
Attached patch rearranges the event ordering for open to be consistent
with the ordering of the other events.
Patch is against current git tree. Please, apply.
Robert Love
Signed-off-by: Robert Love [EMAIL PROTECTED]
include/linux/fsnotify.h |2 +-
1 files changed, 1
Linus,
Real simple, basic cleanup.
Please, apply.
Robert Love
Signed-off-by: Robert Love [EMAIL PROTECTED]
fs/inotify.c |9 +++--
include/linux/sched.h |2 +-
kernel/user.c |2 +-
3 files changed, 5 insertions(+), 8 deletions(-)
diff -urN linux
?
They are in linux/fsnotify.h.
Robert Love
-
To unsubscribe from this list: send the line unsubscribe linux-kernel in
the body of a message to [EMAIL PROTECTED]
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/
underlying function
inotify_inode_queue_event
under the inline functions which the network/cluster fs would call to notify
of remote changes.
That makes sense. I had missed that.
Nod.
Robert Love
-
To unsubscribe from this list: send the line unsubscribe linux-kernel in
the body
Linus,
Real simple, basic cleanup.
Please, apply.
Robert Love
Signed-off-by: Robert Love [EMAIL PROTECTED]
fs/inotify.c |9 +++--
include/linux/sched.h |2 +-
kernel/user.c |2 +-
3 files changed, 5 insertions(+), 8 deletions(-)
diff -urN linux
re code at a lower level, though, as you
pointed out.
I planned to look at redoing dnotify entirely on top of inotify, once
inotify is in the kernel proper, for example.
Robert Love
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a messa
, though, as you
pointed out.
I planned to look at redoing dnotify entirely on top of inotify, once
inotify is in the kernel proper, for example.
Robert Love
-
To unsubscribe from this list: send the line unsubscribe linux-kernel in
the body of a message to [EMAIL PROTECTED]
More majordomo
On Thu, 2005-07-07 at 04:00 -0700, Andrew Morton wrote:
> - Anything which you think needs to go into 2.6.13, please let me know.
Inotify?
Robert Love
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to [EMAIL PROTECTED]
M
On Thu, 2005-07-07 at 04:00 -0700, Andrew Morton wrote:
- Anything which you think needs to go into 2.6.13, please let me know.
Inotify?
Robert Love
-
To unsubscribe from this list: send the line unsubscribe linux-kernel in
the body of a message to [EMAIL PROTECTED]
More majordomo
least
the I_WILL_FREE check.
Anyhow... I'll send out an updated inotify patch after some testing.
Thanks again.
Robert Love
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to [EMAIL PROTECTED]
More majordomo info at http://vger.kern
1 - 100 of 239 matches
Mail list logo
