[PATCH] MAINTAINERS: RAPIDIO: include more rapidio-related content

2019-05-03 Thread Robert P. J. Day
Add missing RAPIDIO-related files and directories to MAINTAINERS entry. Signed-off-by: Robert P. J. Day --- diff --git a/MAINTAINERS b/MAINTAINERS index 5c38f21aee78..1bd2f95c0df6 100644 --- a/MAINTAINERS +++ b/MAINTAINERS @@ -13020,6 +13020,16 @@ M: Matt Porter M: Alexandre

Re: [RESEND PATCH v4 1/2] dt-bindings: at24: Add address-width property

2018-07-05 Thread Robert P. J. Day
/at24.txt | 2 ++ > > 1 file changed, 2 insertions(+) > > Reviewed-by: Rob Herring "... should be added the compatible field ..."?? rday -- Robert P. J. Day

Re: [PATCH v2 0/4] drm/tinydrm: new dirver for ILI9341 displays

2018-05-25 Thread Robert P. J. Day
"dirver"?

[PATCH] PPS: Use surrounding "if PPS" to remove numerous dependency checks

2017-08-26 Thread Robert P. J. Day
Adding high-level "if PPS" makes lower-level dependency tests superfluous. Signed-off-by: Robert P. J. Day --- since this actually changed functional code, i wanted to submit it separately. seems to be equivalent, unless i screwed something up. diff --git a/drivers/pps/Kconfig

[PATCH v2] PPS: Aesthetic tweaks to PPS-related content

2017-08-26 Thread Robert P. J. Day
e/linux/pps_kernel.h | 16 +++- include/uapi/linux/pps.h | 4 ++-- kernel/time/timekeeping.c | 2 +- 7 files changed, 43 insertions(+), 36 deletions(-) Signed-off-by: Robert P. J. Day --- sorry, forgot to add subsystem &quo

[PATCH] Aesthetic tweaks to PPS-related content

2017-08-26 Thread Robert P. J. Day
e/linux/pps_kernel.h | 16 +++- include/uapi/linux/pps.h | 4 ++-- kernel/time/timekeeping.c | 2 +- 7 files changed, 43 insertions(+), 36 deletions(-) Signed-off-by: Robert P. J. Day --- any other changes worth thr

Re: [PATCH 5/7] gpio: use class_groups instead of class_attrs

2017-06-08 Thread Robert P. J. Day
On Thu, 8 Jun 2017, Greg Kroah-Hartman wrote: > The class_attrs pointer is long depreciated, and is about to be finally ^^^ deprecated rday -- ==== Robert P. J.

[PATCH] KBUILD: Drop exporting an empty irqnr.h.

2012-08-29 Thread Robert P. J. Day
Since the content of irqnr.h is entirely wrapped in a __KERNEL__ test, drop exporting it, and remove the single include of that header from random.h. Signed-off-by: Robert P. J. Day --- diff --git a/include/linux/Kbuild b/include/linux/Kbuild index fa21760..b9de555 100644 --- a/include/linux

[PATCH] Documentation/CodingStyle: Numerous pedantic cleanups, nothing major.

2012-07-14 Thread Robert P. J. Day
Signed-off-by: Robert P. J. Day --- while i was perusing CodingStyle, i did some tidying up along the way. i won't take it personally if someone decides not to bother with this, it's all pretty minor. this is all independent of the earlier macro explanation. diff --git a/Doc

[PATCH] Documentation/CodingStyle: Explain using GCC's statement expression extension for defining macros

2012-07-14 Thread Robert P. J. Day
Add an explanation of how to use GCC's statement expression extension for defining multi-line macros. Signed-off-by: Robert P. J. Day --- diff --git a/Documentation/CodingStyle b/Documentation/CodingStyle index cb9258b..c0eec33 100644 --- a/Documentation/CodingStyle +++ b/Document

Re: [PATCH] Documentation/CodingStyle: Mention multi-line macros using expressions

2012-07-13 Thread Robert P. J. Day
On Wed, 11 Jul 2012, Joe Perches wrote: > On Wed, 2012-07-11 at 13:32 -0400, Robert P. J. Day wrote: > [] > > diff --git a/Documentation/CodingStyle b/Documentation/CodingStyle > [] > > +A newer technique is to use the GCC extension of being able to place > > +statem

[PATCH] Documentation/CodingStyle: Mention multi-line macros using expressions

2012-07-11 Thread Robert P. J. Day
Since defining multi-line macros using statements and declarations in expressions is fairly common in the kernel, add this to CodingStyle. Signed-off-by: Robert P. J. Day --- diff --git a/Documentation/CodingStyle b/Documentation/CodingStyle index cb9258b..7eb0734 100644 --- a/Documentation

Re: is "pci_find_subsys" safe to remove?

2008-02-26 Thread Robert P. J. Day
On Tue, 26 Feb 2008, Adrian Bunk wrote: > On Mon, Feb 25, 2008 at 05:15:25PM -0500, Robert P. J. Day wrote: > > > > it's not just that it falls under the category of PCI "legacy" but, > > if you look in drivers/pci/search.c near the bottom: >

[PATCH] Generalize asm-generic/ioctl.h to allow overriding values.

2008-02-26 Thread Robert P. J. Day
. Signed-off-by: Robert P. J. Day <[EMAIL PROTECTED]> --- i'm not sure what kernel subsystem this falls under. this change should not affect anything in the kernel, and the corresponding ioctl.h headers can be tweaked sometime down the road. diff --git a/include/asm-generic/ioctl.h b/

is "pci_find_subsys" safe to remove?

2008-02-25 Thread Robert P. J. Day
ported even *if* you select PCI_LEGACY. i'm guessing that's an oversight but it would certainly suggest that no one can possibly be using it, no? rday -- ============ Robert P. J. Day Linux Consulting, Training and Annoying

Re: [PATCH][RFC] Remove "obsolete" digiepca content.

2008-02-24 Thread Robert P. J. Day
On Sun, 24 Feb 2008, Jiri Slaby wrote: > On 02/09/2008 10:45 PM, Robert P. J. Day wrote: > > Remove the Digi Intl. epca driver for Linux, which is marked as > > "obsolete." > > > > Signed-off-by: Robert P. J. Day <[EMAIL PROTECTED]> > > >

Re: [PATCH] linux/hdsmart.h: fix goofups

2008-02-18 Thread Robert P. J. Day
On Mon, 18 Feb 2008, [EMAIL PROTECTED] wrote: > On Sun, 17 Feb 2008 12:17:20 EST, "Robert P. J. Day" said: > > > if that header file isn't used by any kernel code, why bother having a > > check for __KERNEL__ in the first place? it's being exported to >

Re: [PATCH] linux/hdsmart.h: fix goofups

2008-02-17 Thread Robert P. J. Day
On Sun, 17 Feb 2008, Bartlomiej Zolnierkiewicz wrote: > On Sunday 17 February 2008, Adrian Bunk wrote: > > On Sun, Feb 17, 2008 at 06:40:31PM +0100, Bartlomiej Zolnierkiewicz wrote: > > > On Sunday 17 February 2008, Robert P. J. Day wrote: > > > > On Sun, 17 Feb 2

Re: [PATCH] linux/hdsmart.h: fix goofups

2008-02-17 Thread Robert P. J. Day
On Sun, 17 Feb 2008, Bartlomiej Zolnierkiewicz wrote: > Fix goofups of commit 76166952bbc81dda1c8a8c14e75a2aa06f6c052c > (" is not used by kernel code"). > > Reported-by: "Robert P. J. Day" <[EMAIL PROTECTED]> > Signed-off-by: Bartlomiej Zolnierkiewicz &

Re: latest list of unused Kconfig variables

2008-02-13 Thread Robert P. J. Day
On Wed, 13 Feb 2008, Sam Ravnborg wrote: > On Wed, Feb 13, 2008 at 10:44:27AM -0500, Robert P. J. Day wrote: > > On Wed, 13 Feb 2008, Josh Boyer wrote: > > > > > OK. Well all of your hits for 405EX, 440GRX, 440SPe, and > > > WANT_DEVICE_TREE in arch/powerpc

Re: latest list of unused Kconfig variables

2008-02-13 Thread Robert P. J. Day
s scanning happens only once every release, it's not like it's a burden. and if people want to ignore it, that's fine, too. rday -- Robert P. J. Day Linux Consulting, T

Re: latest list of unused Kconfig variables

2008-02-13 Thread Robert P. J. Day
On Wed, 13 Feb 2008, Sam Ravnborg wrote: > On Wed, Feb 13, 2008 at 10:07:27AM -0500, Robert P. J. Day wrote: > > On Wed, 13 Feb 2008, Josh Boyer wrote: > > > > > On Wed, 13 Feb 2008 03:56:34 -0500 (EST) > > > "Robert P. J. Day" <[EMAIL PROTECTED]>

list of references to non-existent include/linux headers

2008-02-13 Thread Robert P. J. Day
rday -- Robert P. J. Day Linux Consulting, Training and Annoying Kernel Pedantry: Have classroom, will lecture. http://crashcourse.ca Waterloo, Ontario, CANADA -- To unsubscribe from this list: sen

Re: latest list of unused Kconfig variables

2008-02-13 Thread Robert P. J. Day
On Wed, 13 Feb 2008, Josh Boyer wrote: > On Wed, 13 Feb 2008 03:56:34 -0500 (EST) > "Robert P. J. Day" <[EMAIL PROTECTED]> wrote: > > now that 2.6.25-rc1 is out, i can start updating the output from > > my scanning scripts. the first updated output is the li

bad CONFIG variable references in *Makefiles*

2008-02-13 Thread Robert P. J. Day
is not defined anywhere. you get the idea. there are only a couple dozen of these. rday -- ============ Robert P. J. Day Linux Consulting, Training and Annoying Kernel Pedantry: Have classroom, will lecture. http:/

Re: Tests of undefined CONFIG variables.

2008-02-13 Thread Robert P. J. Day
On Wed, 13 Feb 2008, Paul Mundt wrote: > On Wed, Feb 13, 2008 at 05:54:12AM -0500, Robert P. J. Day wrote: > > i've also updated the list of what i call "badref" CONFIG variables > > -- that is, tests of CONFIG_ variables that appear to be undefined > &g

Tests of undefined CONFIG variables.

2008-02-13 Thread Robert P. J. Day
variables rday -- ============ Robert P. J. Day Linux Consulting, Training and Annoying Kernel Pedantry: Have classroom, will lecture. http://crashcourse.ca Waterloo,

Re: latest list of unused Kconfig variables

2008-02-13 Thread Robert P. J. Day
On Wed, 13 Feb 2008, Paul Mundt wrote: > On Wed, Feb 13, 2008 at 03:56:34AM -0500, Robert P. J. Day wrote: > > latest output here, sorted by architecture: > > > > http://www.crashcourse.ca/wiki/index.php/Unused_CONFIG_variables > > > > as always, there will pro

latest list of unused Kconfig variables

2008-02-13 Thread Robert P. J. Day
-- Robert P. J. Day Linux Consulting, Training and Annoying Kernel Pedantry: Have classroom, will lecture. http://crashcourse.ca Waterloo, Ontario, CANADA -- To

can "__setup_null_param" be tossed?

2008-02-11 Thread Robert P. J. Day
* superfluous. rday -- ================ Robert P. J. Day Linux Consulting, Training and Annoying Kernel Pedantry Waterloo, Ontario, CANADA Home page: http://crashcourse.ca Fedora Cookbook:http://crashcourse.ca/wiki/index

some questions about generated headers

2008-02-09 Thread Robert P. J. Day
http://www.sunifdef.strudl.org/ that should do for now. rday -- ============ Robert P. J. Day Linux Consulting, Training and Annoying Kernel Pedantry Waterloo, Ontario, CANADA Home page: http://cr

[PATCH][RFC] Remove manual definition and subsequent testing of BUILD_CRAMDISK.

2008-02-09 Thread Robert P. J. Day
Remove the explicit definition, and subsequent superfluous testing, of BUILD CRAMDISK. Signed-off-by: Robert P. J. Day <[EMAIL PROTECTED]> --- is there any point to this brute-force setting anymore? just curious. diff --git a/init/do_mounts_rd.c b/init/do_mounts_rd.c index ed652f4..5

digi driver removable?

2008-02-09 Thread Robert P. J. Day
rday -- Robert P. J. Day Linux Consulting, Training and Annoying Kernel Pedantry Waterloo, Ontario, CANADA Home page: http://crashcourse.ca Fedora Cookbook:http://crashcourse.ca/wiki/inde

legacy power management to disappear as well?

2008-02-07 Thread Robert P. J. Day
rday -- Robert P. J. Day Linux Consulting, Training and Annoying Kernel Pedantry Waterloo, Ontario, CANADA Home page: http://crashcourse.ca Fedora Cookbook:http://crashcourse.ca/wiki/index.php/Fedora_Coo

Re: feature-removal-schedule.txt is getting out of date again

2008-02-07 Thread Robert P. J. Day
the patch, unless it's already working its way thru the system. rday -- ============ Robert P. J. Day Linux Consulting, Training and Annoying Kernel Pedantry Waterloo, Ontario, CANADA Home page: http://crashcourse.c

Re: feature-removal-schedule.txt is getting out of date again

2008-02-07 Thread Robert P. J. Day
On Wed, 6 Feb 2008, Harvey Harrison wrote: > On Wed, 2008-02-06 at 20:54 +0100, Bartlomiej Zolnierkiewicz wrote: > > Hi, > > > > On Wednesday 06 February 2008, Robert P. J. Day wrote: > > > > > > yes, i realize i'm sounding like a broken record

feature-removal-schedule.txt is getting out of date again

2008-02-06 Thread Robert P. J. Day
rday -- Robert P. J. Day Linux Consulting, Training and Annoying Kernel Pedantry Waterloo, Ontario, CANADA Home page: http://crashcourse.ca Fedora Cookbook:http://crashcourse.ca/wiki/index.php/Fedora_Coo

any point in running the kernel cleanup scripts now?

2008-02-01 Thread Robert P. J. Day
rc1? rday -- ======== Robert P. J. Day Linux Consulting, Training and Annoying Kernel Pedantry Waterloo, Ontario, CANADA Home page: http://crashcourse.ca Fedora Cookbook:http://crashcour

[PATCH] BLOCK: Remove obsolete fd1772.h header file.

2008-02-01 Thread Robert P. J. Day
Given that the entire drivers/acorn/block/ directory no longer exists (which included fd1772.c), there seems to be little reason to keep this unreferenced header file. Signed-off-by: Robert P. J. Day <[EMAIL PROTECTED]> --- diff --git a/include/linux/fd1772.h b/include/linux/fd1772.h d

what constitutes an "unused" include/linux header file?

2008-02-01 Thread Robert P. J. Day
e of these headers, but is it really the responsibility of the kernel to be a helpful storage centre to make userspace programming easier? just curious. (that's not the only header file like that.) rday -- ============ Robert P. J. Day L

Re: Possibly silly Q?

2008-01-14 Thread Robert P. J. Day
kernel, but not *logical* partition changes. or something sort of like that. rday -- ======== Robert P. J. Day Linux Consulting, Training and Annoying Kernel Pedantry Waterloo, Ontario, CANADA Home page:

Re: Possibly silly Q?

2008-01-14 Thread Robert P. J. Day
directory tree? i would try "partprobe". rday -- ================ Robert P. J. Day Linux Consulting, Training and Annoying Kernel Pedantry Waterloo, Ontario, CANADA Home page: http://cr

Re: Updated Kernel Hacker's guide to git

2007-12-24 Thread Robert P. J. Day
you can get the overall idea. new sections should be appearing there as the morning progresses. rday ======== Robert P. J. Day Linux Consulting, Training and Annoying Kernel Pedantry Waterloo, Ontario, CANADA http://cra

Re: Updated Kernel Hacker's guide to git

2007-12-23 Thread Robert P. J. Day
On Sun, 23 Dec 2007, Dieter Ries wrote: > Robert P. J. Day schrieb: > > just to be clear, i'm not complaining about the quality of the > > document above, but when i got started with git, what i really > > wanted was a list of what i (as a simple, non-developer user) &g

Re: Updated Kernel Hacker's guide to git

2007-12-23 Thread Robert P. J. Day
On Sun, 23 Dec 2007, Jeff Garzik wrote: > Robert P. J. Day wrote: > > On Sun, 23 Dec 2007, Jeff Garzik wrote: > > > > > Another year, another update! :) > > > > > > The kernel hacker's guide to git has received some updates: > > > >

Re: Updated Kernel Hacker's guide to git

2007-12-23 Thread Robert P. J. Day
ake some changes to the tree, do a diff, and submit a patch. but in the beginning, they won't be making commits or switching branches, etc. in short, i can see the value of something like a "getting started with git as a basic user" tutorial. does such a thing exist? rday -- ======

Re: [RFC] kobject/kset/ktype documentation and example code updated

2007-12-20 Thread Robert P. J. Day
type controls what happens to the kobject when it is > created and destroyed. i doubt that. i wouldn't say that the ktype "controls" what happens, i would say that it "defines" what happens. to control suggests active participation. rday ===========

should all THREAD_SIZE macros be defined in thread_info.h headers?

2007-12-12 Thread Robert P. J. Day
de/asm-m32r/processor.h:#define THREAD_SIZE (2*PAGE_SIZE) include/asm-m68k/page.h:#define THREAD_SIZE (8192) all other arches seem to define that in their respective thread_info.h headers. rday ==== Robert P. J. Day Linux Cons

Re: The use of KOBJ_NAME_LEN

2007-12-04 Thread Robert P. J. Day
On Mon, 3 Dec 2007, Greg KH wrote: > On Tue, Dec 04, 2007 at 01:50:53AM -0500, Robert P. J. Day wrote: > > On Tue, 4 Dec 2007, Dave Young wrote: > > > > > Hi, > > > Does the KOBJ_NAME_LEN really means the limit of kobject name length? > > > seems not .

kernel newbies list?

2007-12-03 Thread Robert P. J. Day
does anyone know what's happened with the KN list? it seems to have gone utterly dead for the last day or so. rday Robert P. J. Day Linux Consulting, Training and Annoying Kernel Pedantry Waterloo, Ontario, CANADA

Re: The use of KOBJ_NAME_LEN

2007-12-03 Thread Robert P. J. Day
g that @kobj->k_name points to. Otherwise, use the static > * @kobj->name array. > */ the comment seems fairly clear -- if the name is sufficiently short, it's stored in the static array. if not, then it's stored in dynamically allocated space. rday =============

any value in centralizing common 32/64 x86 content in vmlinux.lds.S?

2007-12-02 Thread Robert P. J. Day
ome of the niggling differences between some of that content between the two files. rday ======== Robert P. J. Day Linux Consulting, Training and Annoying Kernel Pedantry Waterloo, Ontario, CANADA http://cras

[PATCH] Remove superfluous checks for CONFIG_BLK_DEV_INITRD from initramfs.c.

2007-12-01 Thread Robert P. J. Day
Given that init/Makefile includes initramfs.c in the build only if CONFIG_BLK_DEV_INITRD is defined, there seems to be no point checking for it yet again. Signed-off-by: Robert P. J. Day <[EMAIL PROTECTED]> --- compile-tested on x86. diff --git a/init/initramfs.c b/init/initramfs.c

Re: [PATCH] Documentation/Changes -> Documentation/Requirements

2007-11-30 Thread Robert P. J. Day
# ld -v > +o Gnu bc 1.06# bc -v you need bc? for what? i just did a defconfig build for x86 with no need for bc. > +o Perl 5.6.0(?)# perl -v if you mention perl, you should also mention sed and awk, no? and perha

Re: [PATCH] ipwireless_cs driver for 4G PC Card

2007-11-30 Thread Robert P. J. Day
s_" prefix from all of those files as well. rday ================ Robert P. J. Day Linux Consulting, Training and Annoying Kernel Pedantry Waterloo, Ontario, CANADA http://crashcourse.ca - To unsubs

Re: does /proc/sys/kernel/modprobe actually do anything?

2007-11-29 Thread Robert P. J. Day
On Thu, 29 Nov 2007, Kay Sievers wrote: > On Nov 29, 2007 1:58 PM, Robert P. J. Day <[EMAIL PROTECTED]> wrote: > > On Thu, 29 Nov 2007, Alexey Dobriyan wrote: > > > > > On 11/29/07, Robert P. J. Day <[EMAIL PROTECTED]> wrote: > > > > echo

Re: does /proc/sys/kernel/modprobe actually do anything?

2007-11-29 Thread Robert P. J. Day
On Thu, 29 Nov 2007, Alexey Dobriyan wrote: > On 11/29/07, Robert P. J. Day <[EMAIL PROTECTED]> wrote: > > echo '#! /bin/sh' > /tmp/modprobe > > echo 'echo "$@" >> /tmp/modprobe.log' >> /tmp/modprobe > > echo 'exec /s

Re: does /proc/sys/kernel/modprobe actually do anything?

2007-11-29 Thread Robert P. J. Day
On Thu, 29 Nov 2007, Alexey Dobriyan wrote: > On 11/29/07, Robert P. J. Day <[EMAIL PROTECTED]> wrote: > > echo '#! /bin/sh' > /tmp/modprobe > > echo 'echo "$@" >> /tmp/modprobe.log' >> /tmp/modprobe > > echo 'exec /s

does /proc/sys/kernel/modprobe actually do anything?

2007-11-29 Thread Robert P. J. Day
tsoever. i ran modprobe under "strace" and it doesn't appear to make any effort to check /proc/sys/kernel/modprobe. i even downloaded the source to the module-init-tools package and scanned the source and ... nothing. so what's up with that? rday ===

[PATCH] SYNCLINK: Standardize format of linux header file include's with "<>".

2007-11-28 Thread Robert P. J. Day
Use the recommended form of "<>" to include linux header files, and move those includes up to join the rest of the linux includes. Signed-off-by: Robert P. J. Day <[EMAIL PROTECTED]> --- outside of the UML stuff, there are precious few examples of including headers out

Re: Linux 2.6 kernel module compilation without using KBUILD

2007-11-28 Thread Robert P. J. Day
ally without kbuild is just making this way more difficult than it has to be. rday ================ Robert P. J. Day Linux Consulting, Training and Annoying Kernel Pedantry

Re: can support for "rpm"-based package building just be dropped?

2007-11-27 Thread Robert P. J. Day
On Mon, 26 Nov 2007, Jan Engelhardt wrote: > > On Nov 26 2007 11:13, Robert P. J. Day wrote: > >> >>>Only on current machines. You'd break building kernel RPMs on older > >> >>>systems that don't have rpmbuild installed. > >> &g

Re: can support for "rpm"-based package building just be dropped?

2007-11-26 Thread Robert P. J. Day
On Mon, 26 Nov 2007, Jan Engelhardt wrote: > > On Nov 26 2007 10:53, Robert P. J. Day wrote: > > > >>>Only on current machines. You'd break building kernel RPMs on older > >>>systems that don't have rpmbuild installed. > >> > >>

Re: can support for "rpm"-based package building just be dropped?

2007-11-26 Thread Robert P. J. Day
On Mon, 26 Nov 2007, Jan Engelhardt wrote: > > On Nov 26 2007 06:58, Ray Lee wrote: > >On Nov 26, 2007 12:54 AM, Robert P. J. Day <[EMAIL PROTECTED]> wrote: > >> on current systems, "rpm" no longer has build capability and will > >> fail thu

Re: can support for "rpm"-based package building just be dropped?

2007-11-26 Thread Robert P. J. Day
On Mon, 26 Nov 2007, Robert P. J. Day wrote: > On Mon, 26 Nov 2007, Ray Lee wrote: > > > On Nov 26, 2007 12:54 AM, Robert P. J. Day <[EMAIL PROTECTED]> wrote: > > > on current systems, "rpm" no longer has build capability and will > > > fail thusl

Re: can support for "rpm"-based package building just be dropped?

2007-11-26 Thread Robert P. J. Day
On Mon, 26 Nov 2007, Ray Lee wrote: > On Nov 26, 2007 12:54 AM, Robert P. J. Day <[EMAIL PROTECTED]> wrote: > > on current systems, "rpm" no longer has build capability and will > > fail thusly: > > > > rpm --target i386 -ta ../kernel-2.6.24rc3g2ffbb8

Re: [PATCH 4/4] atm/ambassador: kmalloc + memset conversion to kzalloc

2007-11-26 Thread Robert P. J. Day
On Mon, 26 Nov 2007, Joonwoo Park wrote: > 2007/11/26, Robert P. J. Day <[EMAIL PROTECTED]>: > > i realized that. but all you can say is that only amb_init() calls > > setup_dev() *currently*. when you're not looking, someone else might > > (for whatever reason)

Re: [PATCH 4/4] atm/ambassador: kmalloc + memset conversion to kzalloc

2007-11-26 Thread Robert P. J. Day
On Mon, 26 Nov 2007, Joonwoo Park wrote: > 2007/11/26, Robert P. J. Day <[EMAIL PROTECTED]>: > > i'm not sure the above is a safe thing to do, as you're zeroing that > > area, then making a function call and assuming, upon entry to the > > function call, tha

Re: [PATCH 4/4] atm/ambassador: kmalloc + memset conversion to kzalloc

2007-11-26 Thread Robert P. J. Day
oppy about it. unless you're prepared to guarantee that there will never be another call to setup_dev() from elsewhere. rday Robert P. J. Day Linux Consulting, Training and Annoying Kernel Pedantry Waterloo, Ontario, CANADA http://crashcourse.ca =

Re: [PATCH 1/4] xfrm_hash: kmalloc + memset conversion to kzalloc

2007-11-26 Thread Robert P. J. Day
memset(n, 0, sz); > + n = kzalloc(sz, GFP_KERNEL); > + else { > + if (hashdist) i believe the more common standard for the above is: else if (hashdist) { to reduce the level of overall indentation, no? rday =

can support for "rpm"-based package building just be dropped?

2007-11-26 Thread Robert P. J. Day
rpmbuild" on the machine, would it not? rday ================ Robert P. J. Day Linux Consulting, Training and Annoying Kernel Pedantry Waterloo, Ontario, CANADA http://crashcourse.ca =

"son of unifdef"

2007-11-24 Thread Robert P. J. Day
nclude/linux/netlink.h sunifdef: /home/rpjday/k/git/include/linux/netlink.h: line 205: warning 0x02070: Garbage following preprocessor directive in "#if PAGE_SIZE < 8192UL" (#if line 152 depth 2) i'm guessing it's that "UL" suffix it doesn't like. rday

Re: 2.6.24-rc3-mm1 make headers_check fails

2007-11-21 Thread Robert P. J. Day
r example. rday -- ============ Robert P. J. Day Linux Consulting, Training and Annoying Kernel Pedantry Waterloo, Ontario, CANADA http://crashcourse.ca - To unsubscribe from this list: send the line "unsubscribe linux-kernel" i

Re: Kernel .config and kconfig general question

2007-11-21 Thread Robert P. J. Day
========== Robert P. J. Day Linux Consulting, Training and Annoying Kernel Pedantry Waterloo, Ontario, CANADA http://crashcourse.ca - To unsubscribe from this list: send the line

Re: 2.6.24-rc3-mm1 make headers_check fails

2007-11-21 Thread Robert P. J. Day
On Wed, 21 Nov 2007, Andrew Morton wrote: > On Wed, 21 Nov 2007 03:52:08 -0500 (EST) "Robert P. J. Day" <[EMAIL > PROTECTED]> wrote: ... snip ... > > i'm sure i'm going to humiliate myself for asking this, but shouldn't > > i be able to reproduce

Re: 2.6.24-rc3-mm1 make headers_check fails

2007-11-21 Thread Robert P. J. Day
RCH=powerpc headers_install/headers_check we've sort of had this discussion before where, IIRC, you should be able to generate the appropriate arch-specific headers without having the corresponding toolchain, no? so why can&

[PATCH] A few corrections to include/linux/Kbuild.

2007-11-19 Thread Robert P. J. Day
Adjustments: auxvec.h, i2c-dev.h and vt.h *should* be unifdef'ed i2o-dev.h does not need unifdef'ing Signed-off-by: Robert P. J. Day <[EMAIL PROTECTED]> --- diff --git a/include/linux/Kbuild b/include/linux/Kbuild index 37bfa19..6a7a525 100644 --- a/include/linux/Kbui

Re: even *more* unused CONFIG variables at no extra charge

2007-11-19 Thread Robert P. J. Day
On Mon, 19 Nov 2007, Paul Mundt wrote: > On Fri, Nov 16, 2007 at 06:15:48AM -0500, Robert P. J. Day wrote: > > sh64 > > >>>>> DEVICE_MEMORY_START > > >>>>> FLASH_MEMORY_START > > >>>>> HDSP253_LED > > >

even *more* unused CONFIG variables at no extra charge

2007-11-16 Thread Robert P. J. Day
C_INC >>>>> RAM16BIT >>>>> RAM32BIT >>>>> RAM8BIT >>>>> ROMFS_FROM_ROM >>>>> WILDFIREMOD mips >>>>> 64BIT_CONTEXT >>>>> ACER_PICA_61 >>>>> CPU_SB1_PASS_2_112x >>>>> CPU_SB1_PASS_2_1250 >>>>> CPU_SB1_PASS_3 &g

Re: [PATCH 1/4] drivers/i2c: Drop redundant includes of moduleparam.h

2007-11-15 Thread Robert P. J. Day
leanable without massive disruption. rday -- ================ Robert P. J. Day Linux Consulting, Training and Annoying Kernel Pedantry Waterloo, Ontario, CANADA http://crashcourse.ca - To

module.h versus moduleparam.h

2007-11-14 Thread Robert P. J. Day
since this topic came up recently: http://www.crashcourse.ca/wiki/index.php/Module.h_and_moduleparam.h rday p.s. we had this discussion some time back but it didn't go anywhere. -- Robert P. J. Day Linux Consu

Re: [PATCH 1/4] drivers/i2c: Drop redundant includes of moduleparam.h

2007-11-14 Thread Robert P. J. Day
t's someone else's decision, not mine. i'm just reporting on how quickly things got unpleasant when *i* tried to do something with this once upon a time. rday -- =

Re: [PATCH 1/4] drivers/i2c: Drop redundant includes of moduleparam.h

2007-11-13 Thread Robert P. J. Day
duleparam.h, there may come a day when those header files are refactored to actually make sense, at which point all those missing moduleparam.h inclusions will cause all sorts of bad things to happen. rday p.s. i tried that cleanup once. it got ugly in a hurry. -- ==============

Re: [PATCH] Include header required for INT_MAX

2007-11-12 Thread Robert P. J. Day
t have to adhere to . It might use > > instead, or whatever. > > Every C compiler has . i'm assuming you mean , no? rday ================ Robert P. J. Day Linux Consulting, Training and Annoying Kernel Pedantry W

[PATCH] log2.h: Define order_base_2() macro for convenience.

2007-11-11 Thread Robert P. J. Day
Given a number of places in the tree that need to calculate this value explicitly, might as well just create a macro for it. Signed-off-by: Robert P. J. Day <[EMAIL PROTECTED]> --- run-time tested for the first several values. note that this macro is defined strictly in terms of ro

Re: [PATCH] log2.h: Define order_base_2() macro for convenience.

2007-11-11 Thread Robert P. J. Day
On Sun, 11 Nov 2007, Randy Dunlap wrote: > On Sat, 10 Nov 2007 22:53:36 -0500 (EST) Robert P. J. Day wrote: > > > > +/** > > + * order_base_2 - calculate the (rounded up) base 2 order of the argument > > + * @n - parameter > > * @n: argument > > (mostl

[PATCH] log2.h: Define order_base_2() macro for convenience.

2007-11-10 Thread Robert P. J. Day
Given a number of places in the tree that need to calculate this value explicitly, might as well just create a macro for it. Signed-off-by: Robert P. J. Day <[EMAIL PROTECTED]> --- run-time tested for the first several values. note that this macro is defined strictly in terms of ro

Re: [PATCH] Add the macro to test if "exactly_one_bit_set" to log2.h.

2007-11-08 Thread Robert P. J. Day
On Thu, 8 Nov 2007, Andrew Morton wrote: > > On Tue, 6 Nov 2007 11:38:52 -0500 (EST) "Robert P. J. Day" <[EMAIL > > PROTECTED]> wrote: > > > > While this macro is defined in terms of "is_power_of_2" and is > > therefore functionally

"dead" CONFIG variables under the include/ directory

2007-11-08 Thread Robert P. J. Day
BUFFER_DEBUG COBALT_MICRO_SERVER HARD_PPS HAS_COMPAT_EPOLL_EVENT IP_NF_NAT_NEEDED SA1100_CT6001 sound SND_CS46XX_DEBUG_GPIO USE_VXLOADER rday -- ============ Robert P. J. Day Linux Consulting, Training and

all of the aforementioned kernel cleanup script output in one place

2007-11-07 Thread Robert P. J. Day
enjoy. http://www.crashcourse.ca/wiki/index.php/Kernel_cleanup rday -- Robert P. J. Day Linux Consulting, Training and Annoying Kernel Pedantry Waterloo, Ontario, CANADA http://crashcourse.ca

Re: [PATCH] Add the macro to test if "exactly_one_bit_set" to log2.h.

2007-11-06 Thread Robert P. J. Day
On Tue, 6 Nov 2007, Boaz Harrosh wrote: > On Tue, Nov 06 2007 at 18:38 +0200, "Robert P. J. Day" <[EMAIL PROTECTED]> > wrote: > > While this macro is defined in terms of "is_power_of_2" and is > > therefore functionally equivalent, the visual semantics

[PATCH] Add the macro to test if "exactly_one_bit_set" to log2.h.

2007-11-06 Thread Robert P. J. Day
While this macro is defined in terms of "is_power_of_2" and is therefore functionally equivalent, the visual semantics are sometimes more appropriate for what is actually being tested. Signed-off-by: Robert P. J. Day <[EMAIL PROTECTED]> --- diff --git a/include/linux/log2.h

[PATCH] MIPS: Delete now-unreferenced i2c-yosemite.h header file.

2007-11-05 Thread Robert P. J. Day
Given that the corresponding source file i2c-yosemite.c file was removed in commit daa4a68f901c4d6491baa1a01f5c869a553c3f6c, and that no one else includes this file, it seems safe to delete it. Signed-off-by: Robert P. J. Day <[EMAIL PROTECTED]> --- diff --git a/arch/mips/pmc-sierra/yo

Re: a list of non-existent but included include/linux header files

2007-11-05 Thread Robert P. J. Day
vers/ide/pci/delkin_cb.c:#include drivers/firmware/dmi-id.c:#include drivers/spi/spi.c:#include drivers/misc/fujitsu-laptop.c:#include drivers/misc/asus-laptop.c:#include drivers/misc/msi-laptop.c:#include rday -- ================ Rober

non-existent CONFIG variables referenced from Makefiles

2007-11-05 Thread Robert P. J. Day
):= custom -- ============ Robert P. J. Day Linux Consulting, Training and Annoying Kernel Pedantry Waterloo, Ontario, CANADA http://crashcourse.ca - To unsubscribe from this list: send the line &qu

a list of non-existent but included include/linux header files

2007-11-05 Thread Robert P. J. Day
: include/linux/usb_sl811.h === arch/blackfin/mach-bf527/boards/ezkit.c:#include -- ============ Robert P. J. Day Linux Consulting, Training and Annoying Kernel Pedantry Waterloo, Ontario, CANADA http:/

the value in exporting unused header files?

2007-11-05 Thread Robert P. J. Day
file for the Sangoma AF_WANPIPE Socket $ in other words, a header file that is not included by any other file in the tree is still being exported to user space. is that normal? rday -- Robert P. J. Day Linux Consulting

[PATCH] Remove unused header file linux/fd1772.h.

2007-11-05 Thread Robert P. J. Day
Given that no one seems to be including this header file, remove it. Signed-off-by: Robert P. J. Day <[EMAIL PROTECTED]> --- diff --git a/include/linux/fd1772.h b/include/linux/fd1772.h deleted file mode 100644 index 871d6e4..000 --- a/include/linux/fd1772.h +++ /dev/null @@ -1,8

Re: [PATCH] CRIS: Remove MTD_AMSTD and MTD_OBSOLETE_CHIPS

2007-11-05 Thread Robert P. J. Day
NFIG_MTD_CFI_AMDSTD=y > -CONFIG_MTD_AMDSTD=y > +# CONFIG_MTD_AMDSTD is not set why are you keeping this around? > -CONFIG_MTD_OBSOLETE_CHIPS=y > -CONFIG_MTD_AMDSTD=y > +# CONFIG_MTD_OBSOLETE_CHIPS is not set > +# CONFIG_MTD_AMDSTD is not set same here. rday -- ==

Re: [PATCH 1/6] ARM: fix memset size error

2007-11-04 Thread Robert P. J. Day
er, no? now, i'm guessing the logic is correct but i figured it's worth noting what the code *used* to do. unless i'm misreading something horribly. rday -- Robert P. J. Day Linux Consulting, Trainin

  1   2   3   4   5   6   7   8   9   10   >