RE: [PATCH] docs: Extend trusted keys documentation for TPM 2.0

2018-11-06 Thread Roberts, William C
om; > alexander.le...@microsoft.com; jmor...@namei.org; linux- > ker...@vger.kernel.org > Cc: Roberts, William C > Subject: Re: [PATCH] docs: Extend trusted keys documentation for TPM 2.0 > > On Tue, 2018-11-06 at 09:00 -0700, Jerry Snitselaar wrote: > > On Mon Nov 05 18, Jerr

RE: [PATCH] vsprintf: avoid misleading "(null)" for %px

2018-02-06 Thread Roberts, William C
> -Original Message- > From: Tobin C. Harding [mailto:m...@tobin.cc] > Sent: Monday, February 5, 2018 2:23 PM > To: Adam Borowski > Cc: Kees Cook ; Petr Mladek ; > Sergey Senozhatsky ; Steven Rostedt > ; LKML ; Andrew Morton > ; Joe Perches ; Roberts, >

RE: [PATCH] tpm: return a TPM_RC_COMMAND_CODE response if a command isn't implemented

2017-12-07 Thread Roberts, William C
p B ; Jason Gunthorpe > ; linux-integr...@vger.kernel.org; Roberts, > William C ; James Bottomley > > Subject: Re: [PATCH] tpm: return a TPM_RC_COMMAND_CODE response if a > command isn't implemented > > On Mon, Nov 27, 2017 at 12:30:12AM +0100, Javier Martinez C

RE: [PATCH V11 4/5] vsprintf: add printk specifier %px

2017-11-29 Thread Roberts, William C
eld > ; Theodore Ts'o ; Paolo Bonzini > ; Tycho Andersen ; Roberts, William C > ; Tejun Heo ; Jordan Glover > ; Greg KH ; > Petr Mladek ; Joe Perches ; Ian > Campbell ; Sergey Senozhatsky > ; Catalin Marinas ; > Will Deacon ; Steven Rostedt ; > Chris Fries ; Dave Weinste

RE: [RFC PATCH] tpm: don't return -EINVAL if TPM command validation fails

2017-11-21 Thread Roberts, William C
gr...@vger.kernel.org; Roberts, > William C > Subject: Re: [RFC PATCH] tpm: don't return -EINVAL if TPM command validation > fails > > On Tue, Nov 21, 2017 at 10:07:34AM +0100, Javier Martinez Canillas wrote: > > As mentioned, I think this should be documented. I guess m

RE: [RFC PATCH] tpm: don't return -EINVAL if TPM command validation fails

2017-11-20 Thread Roberts, William C
> -Original Message- > From: Javier Martinez Canillas [mailto:javi...@redhat.com] > Sent: Monday, November 20, 2017 1:26 AM > To: Jason Gunthorpe > Cc: Roberts, William C ; linux- > ker...@vger.kernel.org; Jarkko Sakkinen ; > Peter Huewe ; Tricca, Phil

RE: [RFC PATCH] tpm: don't return -EINVAL if TPM command validation fails

2017-11-17 Thread Roberts, William C
kernel.org; > Roberts, William C > Subject: Re: [RFC PATCH] tpm: don't return -EINVAL if TPM command validation > fails > > On 11/17/2017 07:17 PM, Jason Gunthorpe wrote: > > On Fri, Nov 17, 2017 at 07:10:09PM +0100, Javier Martinez Canillas wrote: > > > >> Rig

RE: [PATCH V8 0/2] printk: hash addresses printed with %p

2017-11-02 Thread Roberts, William C
foundation.org>; Kees Cook ; Paolo Bonzini > ; Tycho Andersen ; Roberts, > William C ; Tejun Heo ; Jordan > Glover ; Greg KH > ; Petr Mladek ; Joe > Perches ; Ian Campbell ; Catalin > Marinas > ; Will Deacon ; Steven > Rostedt ; Chris Fries ; Dave > Weinstein ; Daniel

RE: [PATCH v2] printk: hash addresses printed with %p

2017-10-17 Thread Roberts, William C
> -Original Message- > From: Tobin C. Harding [mailto:m...@tobin.cc] > Sent: Monday, October 16, 2017 9:53 PM > To: kernel-harden...@lists.openwall.com > Cc: Tobin C. Harding ; Linus Torvalds foundation.org>; Kees Cook ; Paolo Bonzini > ; Tycho Andersen ; Roberts

RE: [PATCH 0/3] add %pX specifier

2017-10-13 Thread Roberts, William C
ook > ; Paolo Bonzini ; Tycho > Andersen ; Roberts, William C > ; Tejun Heo ; Jordan Glover > ; Greg KH ; > Petr Mladek ; Joe Perches ; Ian > Campbell ; Sergey Senozhatsky > ; Catalin Marinas ; > Will Deacon ; Steven Rostedt ; > Chris Fries ; Dave Weinstein ; Daniel > Mic

RE: [kernel-hardening] [RFC V2 4/6] lib: vsprintf: default kptr_restrict to the maximum value

2017-10-04 Thread Roberts, William C
atsky ; kernel- > harden...@lists.openwall.com; LKML ; Catalin > Marinas ; Will Deacon ; > Steven Rostedt ; Roberts, William C > ; Chris Fries ; Dave Weinstein > ; Linus Torvalds > Subject: Re: [kernel-hardening] [RFC V2 4/6] lib: vsprintf: default > kptr_restrict to > the maximum val

RE: [kernel-hardening] [RFC V2 0/6] add more kernel pointer filter options

2017-10-04 Thread Roberts, William C
; ker...@vger.kernel.org; Catalin Marinas ; Will > Deacon ; Steven Rostedt ; > Roberts, William C ; Chris Fries > ; Dave Weinstein > Subject: Re: [kernel-hardening] [RFC V2 0/6] add more kernel pointer filter > options > > On Sun, Oct 01, 2017 at 11:06:44AM +1100, Tobin C. Hardin

RE: [RFC 00/06] printk: add more new kernel pointer filter options.

2017-05-19 Thread Roberts, William C
> -Original Message- > From: Greg KH [mailto:gre...@linuxfoundation.org] > Sent: Thursday, May 18, 2017 7:13 AM > To: Roberts, William C > Cc: Sergey Senozhatsky ; kernel- > harden...@lists.openwall.com; Petr Mladek ; Sergey > Senozhatsky ; linux-kernel@vger.

RE: [RFC 00/06] printk: add more new kernel pointer filter options.

2017-05-16 Thread Roberts, William C
atalin Marinas ; Will > Deacon ; Steven Rostedt ; > Roberts, William C ; Chris Fries > ; Dave Weinstein > Subject: Re: [RFC 00/06] printk: add more new kernel pointer filter options. > > Hello Greg, > > On (05/05/17 21:06), Greg KH wrote: > > Here's a short patch serie

RE: [PATCH v3 1/2] selinux: add brief info to policydb

2017-05-12 Thread Roberts, William C
> -Original Message- > From: owner-linux-security-mod...@vger.kernel.org [mailto:owner-linux- > security-mod...@vger.kernel.org] On Behalf Of Casey Schaufler > Sent: Thursday, May 11, 2017 1:46 PM > To: Stephen Smalley ; Sebastien Buisson > ; linux-security-mod...@vger.kernel.org; linux-

RE: [PATCH] checkpatch: Add ability to find bad uses of vsprintf %p extensions

2017-02-28 Thread Roberts, William C
> -Original Message- > From: Joe Perches [mailto:j...@perches.com] > Sent: Monday, February 27, 2017 12:55 PM > To: Andrew Morton ; Andy Whitcroft > > Cc: Roberts, William C ; kernel- > harden...@lists.openwall.com; linux-kernel@vger.kernel.org > Subject: [PATCH]

RE: [PATCH] checkpatch: add warning on %pk instead of %pK usage

2017-02-27 Thread Roberts, William C
> -Original Message- > From: Roberts, William C [mailto:william.c.robe...@intel.com] > Sent: Wednesday, February 15, 2017 3:49 PM > To: Joe Perches > Cc: linux-kernel@vger.kernel.org; a...@canonical.com; kernel- > harden...@lists.openwall.com > Subject: [kernel-

RE: [PATCH] checkpatch: add warning on %pk instead of %pK usage

2017-02-15 Thread Roberts, William C
> -Original Message- > From: Joe Perches [mailto:j...@perches.com] > Sent: Monday, February 13, 2017 2:21 PM > To: Roberts, William C > Cc: linux-kernel@vger.kernel.org; a...@canonical.com; kernel- > harden...@lists.openwall.com > Subject: Re: [PATCH] checkpatc

RE: [PATCH] checkpatch: add warning on %pk instead of %pK usage

2017-02-13 Thread Roberts, William C
> -Original Message- > From: Joe Perches [mailto:j...@perches.com] > Sent: Friday, February 10, 2017 7:24 PM > To: Roberts, William C ; linux- > ker...@vger.kernel.org; a...@canonical.com > Cc: kernel-harden...@lists.openwall.com > Subject: Re: [PATCH] checkpatc

RE: [PATCH] checkpatch: add warning on %pk instead of %pK usage

2017-02-10 Thread Roberts, William C
> > By "normal" I'm referring to things that call into pointer(), just > > casually looking I see bstr_printf vsnprintf kvasprintf, which would > > be easy enough to add > > > > > What do you think is missing? sn?printf ? That's easy to add. > > > > The problem starts to get hairy when we think o

RE: [PATCH] checkpatch: add warning on %pk instead of %pK usage

2017-02-10 Thread Roberts, William C
> -Original Message- > From: Roberts, William C > Sent: Friday, February 10, 2017 3:32 PM > To: 'Joe Perches' ; linux-kernel@vger.kernel.org; > a...@canonical.com; Andew Morton > Cc: keesc...@chromium.org; kernel-harden...@lists.openwall.com > Subje

RE: [PATCH] checkpatch: add warning on %pk instead of %pK usage

2017-02-10 Thread Roberts, William C
> -Original Message- > From: Joe Perches [mailto:j...@perches.com] > Sent: Friday, February 10, 2017 2:50 PM > To: Roberts, William C ; linux- > ker...@vger.kernel.org; a...@canonical.com; Andew Morton foundation.org> > Cc: keesc...@chromium.org; kernel-harden.

RE: [PATCH] checkpatch: add warning on %pk instead of %pK usage

2017-02-10 Thread Roberts, William C
> > > > On Fri, 2017-02-10 at 11:37 -0800, william.c.robe...@intel.com wrote: > > > From: William Roberts > > > > > > Sample output: > > > WARNING: %pk is close to %pK, did you mean %pK?. > > > \#20: FILE: drivers/char/applicom.c:230: > > > + printk(KERN_INFO "Could not allocate

RE: [PATCH] checkpatch: add warning on %pk instead of %pK usage

2017-02-10 Thread Roberts, William C
> -Original Message- > From: Joe Perches [mailto:j...@perches.com] > Sent: Friday, February 10, 2017 12:12 PM > To: Roberts, William C ; linux- > ker...@vger.kernel.org; a...@canonical.com; Andew Morton foundation.org> > Cc: keesc...@chromium.org; kernel-harden.

RE: [PATCH] printk: introduce kptr_restrict level 3

2016-10-07 Thread Roberts, William C
> > As a _singlular_ argument, "it's for out-of-tree code" is weak. As an > _additional_ > argument, it has value. Saying "this only helps out-of-tree code" doesn't > carry > much weight. Saying "this helps kernel security, even for out-of-tree code" is > perfectly valid. And a wrinkle in this

RE: [PATCH] printk: introduce kptr_restrict level 3

2016-10-06 Thread Roberts, William C
> -Original Message- > From: Christoph Hellwig [mailto:h...@infradead.org] > Sent: Thursday, October 6, 2016 9:56 AM > To: Roberts, William C > Cc: Christoph Hellwig ; kernel- > harden...@lists.openwall.com; cor...@lwn.net; linux-...@vger.kernel.org; > linux-k

RE: [PATCH] printk: introduce kptr_restrict level 3

2016-10-06 Thread Roberts, William C
> -Original Message- > From: Christoph Hellwig [mailto:h...@infradead.org] > Sent: Thursday, October 6, 2016 9:32 AM > To: Roberts, William C > Cc: kernel-harden...@lists.openwall.com; cor...@lwn.net; linux- > d...@vger.kernel.org; linux-kernel@vger.kernel.org >

RE: [PATCH] printk: introduce kptr_restrict level 3

2016-10-06 Thread Roberts, William C
> -Original Message- > From: keesc...@google.com [mailto:keesc...@google.com] On Behalf Of Kees > Cook > Sent: Wednesday, October 5, 2016 3:34 PM > To: Roberts, William C > Cc: kernel-harden...@lists.openwall.com; Jonathan Corbet ; > linux-...@vger.kernel.org; LKML

RE: [PATCH] printk: introduce kptr_restrict level 3

2016-10-06 Thread Roberts, William C
> -Original Message- > From: Rasmus Villemoes [mailto:li...@rasmusvillemoes.dk] > Sent: Wednesday, October 5, 2016 4:53 PM > To: Roberts, William C > Cc: kernel-harden...@lists.openwall.com; cor...@lwn.net; linux- > d...@vger.kernel.org; linux-kernel@vger.kernel

RE: [kernel-hardening] [PATCH] [RFC] Introduce mmap randomization

2016-08-04 Thread Roberts, William C
> -Original Message- > From: Daniel Micay [mailto:danielmi...@gmail.com] > Sent: Thursday, August 4, 2016 9:53 AM > To: kernel-harden...@lists.openwall.com; ja...@lakedaemon.net; linux- > m...@vger.kernel.org; linux-kernel@vger.kernel.org; akpm@linux- > foundation.org > Cc: keesc...@chromiu

RE: [PATCH] [RFC] Introduce mmap randomization

2016-08-03 Thread Roberts, William C
> > > > > I would highly recommend studying those prior use cases and answering > > those concerns before progressing too much further. As I've mentioned > > elsewhere, you'll need to quantify the increased difficulty to the > > attacker that your patch imposes. Personally, I would assess that

RE: [PATCH] [RFC] Introduce mmap randomization

2016-08-02 Thread Roberts, William C
> > > > No, I mean changes to mm/mmap.o. > >From UML build: NEW: 1610 : 1610: 55 push %rbp 1611: 48 89 e5mov%rsp,%rbp 1614: 41 54 push %r12 1616: 48 8d 45 e8 lea-0x

RE: [PATCH] [RFC] Introduce mmap randomization

2016-08-02 Thread Roberts, William C
> -Original Message- > From: Jason Cooper [mailto:ja...@lakedaemon.net] > Sent: Tuesday, July 26, 2016 2:45 PM > To: Roberts, William C > Cc: linux...@kvack.org; linux-kernel@vger.kernel.org; kernel- > harden...@lists.openwall.com; a...@linux-foundation.org; > keesc

RE: [PATCH] [RFC] Introduce mmap randomization

2016-08-02 Thread Roberts, William C
> -Original Message- > From: Nick Kralevich [mailto:n...@google.com] > Sent: Wednesday, July 27, 2016 10:00 AM > To: Jason Cooper > Cc: Roberts, William C ; linux...@kvack.org; > linux-kernel@vger.kernel.org; kernel-harden...@lists.openwall.com; > a...@linux-

RE: [PATCH] [RFC] Introduce mmap randomization

2016-07-26 Thread Roberts, William C
> -Original Message- > From: owner-linux...@kvack.org [mailto:owner-linux...@kvack.org] On > Behalf Of Jason Cooper > Sent: Tuesday, July 26, 2016 2:00 PM > To: Roberts, William C > Cc: linux...@kvack.org; linux-kernel@vger.kernel.org; kernel- > harden...@lists.ope

RE: [PATCH] [RFC] Introduce mmap randomization

2016-07-26 Thread Roberts, William C
> -Original Message- > From: Nick Kralevich [mailto:n...@google.com] > Sent: Tuesday, July 26, 2016 1:41 PM > To: Roberts, William C > Cc: ja...@lakedaemon.net; linux...@vger.kernel.org; lkml ker...@vger.kernel.org>; kernel-harden...@lists.openwall.com; Andrew &g

RE: [kernel-hardening] [PATCH] [RFC] Introduce mmap randomization

2016-07-26 Thread Roberts, William C
keesc...@chromium.org; gre...@linuxfoundation.org; n...@google.com; > je...@google.com; saly...@android.com; dcash...@android.com; Roberts, > William C > Subject: Re: [kernel-hardening] [PATCH] [RFC] Introduce mmap > randomization > > On Tue, 2016-07-26 at 11:22 -0700, will

RE: [PATCH] [RFC] Introduce mmap randomization

2016-07-26 Thread Roberts, William C
RESEND fixing mm-list email > > -Original Message- > > From: Jason Cooper [mailto:ja...@lakedaemon.net] > > Sent: Tuesday, July 26, 2016 1:03 PM > > To: Roberts, William C > > Cc: linux...@vger.kernel.org; linux-kernel@vger.kernel.org; kernel- >

RE: [PATCH] [RFC] Introduce mmap randomization

2016-07-26 Thread Roberts, William C
> -Original Message- > From: Jason Cooper [mailto:ja...@lakedaemon.net] > Sent: Tuesday, July 26, 2016 1:03 PM > To: Roberts, William C > Cc: linux...@vger.kernel.org; linux-kernel@vger.kernel.org; kernel- > harden...@lists.openwall.com; a...@linux-found

RE: [RFC patch 1/6] random: Simplify API for random address requests

2016-07-26 Thread Roberts, William C
> -Original Message- > From: Jason Cooper [mailto:ja...@lakedaemon.net] > Sent: Monday, July 25, 2016 8:31 PM > To: Roberts, William C ; linux- > m...@vger.kernel.org; linux-kernel@vger.kernel.org; kernel- > harden...@lists.openwall.com > Cc: li...@arm.lin

RE: Linux Firmware Signing

2015-09-01 Thread Roberts, William C
> -Original Message- > From: owner-linux-security-mod...@vger.kernel.org [mailto:owner-linux- > security-mod...@vger.kernel.org] On Behalf Of Joshua Brindle > Sent: Tuesday, September 1, 2015 7:13 AM > To: Paul Moore > Cc: Luis R. Rodriguez; Takashi Iwai; Ming Lei; David Howells; Peter Jo

RE: Linux Firmware Signing

2015-08-28 Thread Roberts, William C
> -Original Message- > From: Paul Moore [mailto:p...@paul-moore.com] > Sent: Thursday, August 27, 2015 4:57 PM > To: Luis R. Rodriguez > Cc: David Woodhouse; David Howells; Mimi Zohar; Andy Lutomirski; Kees Cook; > Roberts, William C; linux-security-mod...@vger.kernel