Re: [PATCH] MAINTAINERS: Some SGI-related cleanup

> Signed-off-by: Steve Wahl Acked-by: Robin Holt

Re: [PATCH] MAINTAINERS: Some SGI-related cleanup

> Signed-off-by: Steve Wahl Acked-By: Robin Holt

Re: [PATCH 04/30] misc: sgi-xp: xp_main: Staticify local functions xp_init() and xp_exit()

On Tue, Jun 30, 2020 at 8:51 AM Lee Jones wrote: ... > Signed-off-by: Lee Jones Acked-By: Robin Holt

Re: [PATCH] sgi-xpc: mark expected switch fall-through

On Wed, Mar 20, 2019 at 11:04 AM Gustavo A. R. Silva wrote: ... > Signed-off-by: Gustavo A. R. Silva Acked-by: Robin Holt

Re: [sgi-xp] Missing break or false positive?

could be in the process of being established and a failure could be detected prior to the handling of the establishment message. I added the new open complete message and leveraged the fall-through to mark the connection established. Please let me know if you do not intend to submit a patch for this. Thank you, Robin Holt

Re: [PATCH] misc: remove meaningless null check before kfree

On Thu, Aug 16, 2018 at 10:55 PM zhong jiang wrote: > Signed-off-by: zhong jiang Acked-by: Robin Holt

Re: [PATCH] misc: remove meaningless null check before kfree

On Thu, Aug 16, 2018 at 10:55 PM zhong jiang wrote: > Signed-off-by: zhong jiang Acked-by: Robin Holt

Re: [PATCH] sgi-xp: remove redundant pointers ch and rp

On Tue, Jul 3, 2018 at 2:23 AM Colin King wrote: > Signed-off-by: Colin Ian King Acked-by: Robin Holt

Re: [PATCH] sgi-xp: remove redundant pointers ch and rp

On Tue, Jul 3, 2018 at 2:23 AM Colin King wrote: > Signed-off-by: Colin Ian King Acked-by: Robin Holt

Re: [PATCH] sgi-xp: fix xpnet_dev_hard_start_xmit()'s return type

On Tue, Apr 24, 2018 at 8:15 AM, Luc Van Oostenryck <luc.vanoostenr...@gmail.com> wrote: > Signed-off-by: Luc Van Oostenryck <luc.vanoostenr...@gmail.com> Acked-by: Robin Holt <robinmh...@gmail.com>

Re: [PATCH] sgi-xp: fix xpnet_dev_hard_start_xmit()'s return type

On Tue, Apr 24, 2018 at 8:15 AM, Luc Van Oostenryck wrote: > Signed-off-by: Luc Van Oostenryck Acked-by: Robin Holt

Re: [PATCH 0/3] SGI-XPC: Adjustments for some function implementations

If you need to resubmit, please consider re-ordering the changes to due the comparison to NULL changes in your first patch, followed by the other two in either order. I think it will clear up some of the inconsistency in your first patch. Thanks, Robin

Re: [PATCH 0/3] SGI-XPC: Adjustments for some function implementations

If you need to resubmit, please consider re-ordering the changes to due the comparison to NULL changes in your first patch, followed by the other two in either order. I think it will clear up some of the inconsistency in your first patch. Thanks, Robin

Re: [PATCH 3/3] sgi-xpc: Adjust 27 checks for null pointers

On Wed, Jan 10, 2018 at 8:06 AM, SF Markus Elfring <elfr...@users.sourceforge.net> wrote: > Signed-off-by: Markus Elfring <elfr...@users.sourceforge.net> Acked-by: Robin Holt <robinmh...@gmail.com>

Re: [PATCH 3/3] sgi-xpc: Adjust 27 checks for null pointers

On Wed, Jan 10, 2018 at 8:06 AM, SF Markus Elfring wrote: > Signed-off-by: Markus Elfring Acked-by: Robin Holt

Re: [PATCH 2/3] sgi-xpc: Improve a size determination in two functions

On Wed, Jan 10, 2018 at 8:05 AM, SF Markus Elfring <elfr...@users.sourceforge.net> wrote: > Signed-off-by: Markus Elfring <elfr...@users.sourceforge.net> Acked-by: Robin Holt <robinmh...@gmail.com>

Re: [PATCH 2/3] sgi-xpc: Improve a size determination in two functions

On Wed, Jan 10, 2018 at 8:05 AM, SF Markus Elfring wrote: > Signed-off-by: Markus Elfring Acked-by: Robin Holt

Re: [PATCH 1/3] sgi-xpc: Delete error messages for a failed memory allocation in three functions

is issue was detected by using the Coccinelle software. > > Signed-off-by: Markus Elfring <elfr...@users.sourceforge.net> Acked-by: Robin Holt <robinmh...@gmail.com>

Re: [PATCH 1/3] sgi-xpc: Delete error messages for a failed memory allocation in three functions

d-off-by: Markus Elfring Acked-by: Robin Holt

Re: [PATCH] drivers/sgi-xp: Convert timers to use timer_setup()

On Tue, Oct 24, 2017 at 5:23 AM, Kees Cook <keesc...@chromium.org> wrote: ... > Cc: Robin Holt <robinmh...@gmail.com> Acked-by: Robin Holt <robinmh...@gmail.com>

Re: [PATCH] drivers/sgi-xp: Convert timers to use timer_setup()

On Tue, Oct 24, 2017 at 5:23 AM, Kees Cook wrote: ... > Cc: Robin Holt Acked-by: Robin Holt

Re: [PATCH] sgi-xpc: remove unnecessary static in xpc_setup_msg_structures_uv()

Acked-by: Robin Holt <robinmh...@gmail.com>

Re: [PATCH] sgi-xpc: remove unnecessary static in xpc_setup_msg_structures_uv()

Acked-by: Robin Holt

Re: [PATCH] sgi-xp: convert BUG_ONs to WARN_ONs... sheesh

ying out new releases and live with a WARN_ON() for other instances. > Signed-off-by: Davidlohr Bueso <dbu...@suse.de> Ackd-by: Robin Holt <robinmh...@gmail.com>

Re: [PATCH] sgi-xp: convert BUG_ONs to WARN_ONs... sheesh

d live with a WARN_ON() for other instances. > Signed-off-by: Davidlohr Bueso Ackd-by: Robin Holt

Re: [PATCH] sgi-xp: use designated initializers

Acked-by: Robin Holt <robinmh...@gmail.com> Robin Holt

Re: [PATCH] sgi-xp: use designated initializers

Acked-by: Robin Holt Robin Holt

Re: [PATCH] misc: sgi-xp: Use setup_timer Kernel API instead of

On Sun, Apr 2, 2017 at 10:17 AM, Santosh Kumar Singh <kumar.san1...@gmail.com> wrote: > Replace init_timer function with setup_timer reported by coccinelle > > Signed-off-by: Santosh Kumar Singh <kumar.san1...@gmail.com> Acked-by: Robin Holt <robinmh...@gmail.com>

Re: [PATCH] misc: sgi-xp: Use setup_timer Kernel API instead of

On Sun, Apr 2, 2017 at 10:17 AM, Santosh Kumar Singh wrote: > Replace init_timer function with setup_timer reported by coccinelle > > Signed-off-by: Santosh Kumar Singh Acked-by: Robin Holt

Re: [PATCH] sgi-xp: use designated initializers

On Fri, Dec 16, 2016 at 7:01 PM, Kees Cook wrote: > Prepare to mark sensitive kernel structures for randomization by making > sure they're using designated initializers. These were identified during > allyesconfig builds of x86, arm, and arm64, with most initializer fixes >

Re: [PATCH] sgi-xp: use designated initializers

On Fri, Dec 16, 2016 at 7:01 PM, Kees Cook wrote: > Prepare to mark sensitive kernel structures for randomization by making > sure they're using designated initializers. These were identified during > allyesconfig builds of x86, arm, and arm64, with most initializer fixes > extracted from

Re: [PATCH net-next 6/6] net: use core MTU range checking in misc drivers

On Tue, Oct 18, 2016 at 9:33 PM, Jarod Wilson <ja...@redhat.com> wrote: > CC: net...@vger.kernel.org > CC: Stefan Richter <stef...@s5r6.in-berlin.de> > CC: Faisal Latif <faisal.la...@intel.com> > CC: linux-r...@vger.kernel.org > CC: Cliff Whickman <c...@sgi

Re: [PATCH net-next 6/6] net: use core MTU range checking in misc drivers

On Tue, Oct 18, 2016 at 9:33 PM, Jarod Wilson wrote: > CC: net...@vger.kernel.org > CC: Stefan Richter > CC: Faisal Latif > CC: linux-r...@vger.kernel.org > CC: Cliff Whickman Acked-by: Robin Holt > CC: Jes Sorensen > CC: Marek Lindner > CC: Simon Wunderlich

Re: [PATCH] SGI-XPC: Delete unnecessary checks before unregister_sysctl_table()

On Fri, Nov 6, 2015 at 3:15 AM, SF Markus Elfring wrote: > Signed-off-by: Markus Elfring Acked-by: Robin Holt -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.

Re: [PATCH] SGI-XPC: Delete unnecessary checks before unregister_sysctl_table()

On Fri, Nov 6, 2015 at 3:15 AM, SF Markus Elfring <elfr...@users.sourceforge.net> wrote: > Signed-off-by: Markus Elfring <elfr...@users.sourceforge.net> Acked-by: Robin Holt <robinmh...@gmail.com> -- To unsubscribe from this list: send the line "unsubscribe linux-kernel

Re: [Patch V3 3/9] sgi-xp: Replace cpu_to_node() with cpu_to_mem() to support memoryless node

On Sun, Aug 16, 2015 at 10:19 PM, Jiang Liu wrote: > Function xpc_create_gru_mq_uv() allocates memory with __GFP_THISNODE > flag set, which may cause permanent memory allocation failure on > memoryless node. So replace cpu_to_node() with cpu_to_mem() to better > support memoryless node. For node

Re: [Patch V3 3/9] sgi-xp: Replace cpu_to_node() with cpu_to_mem() to support memoryless node

On Sun, Aug 16, 2015 at 10:19 PM, Jiang Liu jiang@linux.intel.com wrote: Function xpc_create_gru_mq_uv() allocates memory with __GFP_THISNODE flag set, which may cause permanent memory allocation failure on memoryless node. So replace cpu_to_node() with cpu_to_mem() to better support

Re: [PATCH] mm: rename and document alloc_pages_exact_node

t allow the node id > to be -1. Unfortunately the name of the function can easily suggest that the > allocation is restricted to the given node. In truth, the node is only > preferred, unless __GFP_THISNODE is among the gfp flags. > ... > Cc: Robin Holt Acked-by: Robin Holt -- T

Re: [PATCH] mm: rename and document alloc_pages_exact_node

the node id to be -1. Unfortunately the name of the function can easily suggest that the allocation is restricted to the given node. In truth, the node is only preferred, unless __GFP_THISNODE is among the gfp flags. ... Cc: Robin Holt robinmh...@gmail.com Acked-by: Robin Holt robinmh...@gmail.com

Re: [PATCH] sgi-xp: Do not use BUG_ON(!spin_is_locked())

jeev Sharma Acked-by: Robin Holt -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/

Re: [PATCH] sgi-xp: Do not use BUG_ON(!spin_is_locked())

Sharma sanjeev_sha...@mentor.com Acked-by: Robin Holt robinmh...@gmail.com -- To unsubscribe from this list: send the line unsubscribe linux-kernel in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http

Re: [PATCH V5 2/3] mm/memblock: Add support for excluded memory areas

ave looked at the prior discussions and I also don't feel you have addressed the other concerns expressed in those threads. I, of course, reserve the right to be wrong. I nearly always am. Thanks and sorry, Robin Holt On Mon, Jan 20, 2014 at 5:32 AM, Philipp Hachtmann wrote: > Add a new

Re: [PATCH V5 2/3] mm/memblock: Add support for excluded memory areas

at the prior discussions and I also don't feel you have addressed the other concerns expressed in those threads. I, of course, reserve the right to be wrong. I nearly always am. Thanks and sorry, Robin Holt On Mon, Jan 20, 2014 at 5:32 AM, Philipp Hachtmann pha...@linux.vnet.ibm.com wrote: Add

Re: [PATCH V5 1/3] mm/nobootmem: Fix unused variable

On Mon, Jan 20, 2014 at 5:32 AM, Philipp Hachtmann wrote: > This fixes an unused variable warning in nobootmem.c > > Signed-off-by: Philipp Hachtmann > --- > mm/nobootmem.c | 28 +--- > 1 file changed, 17 insertions(+), 11 deletions(-) > > diff --git a/mm/nobootmem.c

Re: [PATCH V5 1/3] mm/nobootmem: Fix unused variable

On Mon, Jan 20, 2014 at 5:32 AM, Philipp Hachtmann pha...@linux.vnet.ibm.com wrote: This fixes an unused variable warning in nobootmem.c Signed-off-by: Philipp Hachtmann pha...@linux.vnet.ibm.com --- mm/nobootmem.c | 28 +--- 1 file changed, 17 insertions(+), 11

Re: [PATCH] mm/nobootmem: Fix unused variable

If the definition of the get_allocated_memblock_reserved_regions_info() function when CONFIG_ARCH_DISCARD_MEMBLOCK simply returns 0, the compiler will see that size is defined, the optimizer will see that it is always 0 and that the if(0) is always false. The net result will be no code will be

Re: [PATCH] mm/nobootmem: Fix unused variable

Argh. Thought I had changed that to plain text mode before sending. Sorry for the noise, Robin On Thu, Jan 16, 2014 at 9:45 AM, Robin Holt wrote: > > I can not see how this works. How is the return from > get_allocated_memblock_reserved_regions_info() stored and used without being &

Re: [PATCH] mm/nobootmem: Fix unused variable

CONFIG_ARCH_DISCARD_MEMBLOCK. That said, I don't have a fundamental objection to #ifdef's inside functions so... Acked-by: Robin Holt On Thu, Jan 16, 2014 at 9:49 AM, Philipp Hachtmann wrote: > Hi Robin, > >> Maybe you are working off a different repo than >> Linus' latest? Your line 116

Re: [PATCH] mm/nobootmem: Fix unused variable

CONFIG_ARCH_DISCARD_MEMBLOCK. That said, I don't have a fundamental objection to #ifdef's inside functions so... Acked-by: Robin Holt robinmh...@gmail.com On Thu, Jan 16, 2014 at 9:49 AM, Philipp Hachtmann pha...@linux.vnet.ibm.com wrote: Hi Robin, Maybe you are working off a different repo than Linus' latest

Re: [PATCH] mm/nobootmem: Fix unused variable

Argh. Thought I had changed that to plain text mode before sending. Sorry for the noise, Robin On Thu, Jan 16, 2014 at 9:45 AM, Robin Holt robinmh...@gmail.com wrote: I can not see how this works. How is the return from get_allocated_memblock_reserved_regions_info() stored and used without

Re: [PATCH] mm/nobootmem: Fix unused variable

If the definition of the get_allocated_memblock_reserved_regions_info() function when CONFIG_ARCH_DISCARD_MEMBLOCK simply returns 0, the compiler will see that size is defined, the optimizer will see that it is always 0 and that the if(0) is always false. The net result will be no code will be

Re: [PATCH, RFC 28/30] sgi-xp: open-code interruptible_sleep_on_timeout

Acked-by: Robin Holt On Thu, Jan 2, 2014 at 6:07 AM, Arnd Bergmann wrote: > interruptible_sleep_on_timeout is deprecated and going away soon. > The use in the sgi-xp driver leaves me puzzled, so I'd prefer not > to touch it. This patch replaces it with an open-coded prepar

Re: [PATCH, RFC 28/30] sgi-xp: open-code interruptible_sleep_on_timeout

Acked-by: Robin Holt robinmh...@gmail.com On Thu, Jan 2, 2014 at 6:07 AM, Arnd Bergmann a...@arndb.de wrote: interruptible_sleep_on_timeout is deprecated and going away soon. The use in the sgi-xp driver leaves me puzzled, so I'd prefer not to touch it. This patch replaces it with an open

Re: [PATCH 3/5] drivers: misc: Mark functions as static in xpc_main.c

[-Wmissing-prototypes] >> >> Signed-off-by: Rashika Kheria > > Reviewed-by: Josh Triplett Acked-by: Robin Holt > >> drivers/misc/sgi-xp/xpc_main.c |4 ++-- >> 1 file changed, 2 insertions(+), 2 deletions(-) >> >> diff --git a/drivers/misc/sgi-xp/xp

Re: [PATCH 2/5] drivers: misc: Mark functions as static in xp_main.c

ing-prototypes] >> >> Signed-off-by: Rashika Kheria > > Reviewed-by: Josh Triplett Acked-by: Robin Holt > >> drivers/misc/sgi-xp/xp_main.c |4 ++-- >> 1 file changed, 2 insertions(+), 2 deletions(-) >> >> diff --git a/drivers/misc/sgi-xp/xp_main

Re: [PATCH 2/5] drivers: misc: Mark functions as static in xp_main.c

rashika.khe...@gmail.com Reviewed-by: Josh Triplett j...@joshtriplett.org Acked-by: Robin Holt robinmh...@gmail.com drivers/misc/sgi-xp/xp_main.c |4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/drivers/misc/sgi-xp/xp_main.c b/drivers/misc/sgi-xp/xp_main.c index 01be66d

Re: [PATCH 3/5] drivers: misc: Mark functions as static in xpc_main.c

Kheria rashika.khe...@gmail.com Reviewed-by: Josh Triplett j...@joshtriplett.org Acked-by: Robin Holt robinmh...@gmail.com drivers/misc/sgi-xp/xpc_main.c |4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/drivers/misc/sgi-xp/xpc_main.c b/drivers/misc/sgi-xp/xpc_main.c

Re: [PATCH] reboot: re-enable the function of variable reboot_default

invalidated. > > The default value of variable reboot_default should be 1, and if command line > reboot= is not set, system will use the default reboot mode. > > Signed-off-by: Li Fei > Signed-off-by: liu chuansheng Acked-by: Robin Holt Thank you for fixing my bug. Note: My email a

Re: [PATCH] reboot: re-enable the function of variable reboot_default

value of variable reboot_default should be 1, and if command line reboot= is not set, system will use the default reboot mode. Signed-off-by: Li Fei fei...@intel.com Signed-off-by: liu chuansheng chuansheng@intel.com Acked-by: Robin Holt robinmh...@linux.com Thank you for fixing my bug

Re: [PATCH 1/8] THP: Use real address for NUMA policy

Alex, Although the explanation seems plausible, have you verified this is actually possible? You could make a simple pthread test case which allocates a getpagesize() * area, prints its address and then each thread migrate and reference their page. Have the task then sleep() before exit. Look

Re: [PATCH 1/8] THP: Use real address for NUMA policy

Alex, Although the explanation seems plausible, have you verified this is actually possible? You could make a simple pthread test case which allocates a getpagesize() * number-of-threads area, prints its address and then each thread migrate and reference their page. Have the task then

[PATCH] MAINTAINERS: Change ownership for SGI specific modules.

family of drivers. Signed-off-by: Robin Holt --- MAINTAINERS | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/MAINTAINERS b/MAINTAINERS index 7cacc88..2bcd7df 100644 --- a/MAINTAINERS +++ b/MAINTAINERS @@ -7366,7 +7366,6 @@ F:drivers/net/ethernet/sfc/ SGI GRU DRIVER

[PATCH] MAINTAINERS: Change ownership for SGI specific modules.

family of drivers. Signed-off-by: Robin Holt h...@sgi.com --- MAINTAINERS | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/MAINTAINERS b/MAINTAINERS index 7cacc88..2bcd7df 100644 --- a/MAINTAINERS +++ b/MAINTAINERS @@ -7366,7 +7366,6 @@ F:drivers/net/ethernet/sfc/ SGI

Re: [RFC 4/4] Sparse initialization of struct page array.

On Thu, Jul 25, 2013 at 05:50:57AM -0700, Yinghai Lu wrote: > On Wed, Jul 24, 2013 at 7:25 PM, Robin Holt wrote: > >> > >> How about holes that is not in memblock.reserved? > >> > >> before this patch: > >> free_area_init_node/free_area_init_core/

Re: [RFC 4/4] Sparse initialization of struct page array.

On Thu, Jul 25, 2013 at 05:50:57AM -0700, Yinghai Lu wrote: On Wed, Jul 24, 2013 at 7:25 PM, Robin Holt h...@sgi.com wrote: How about holes that is not in memblock.reserved? before this patch: free_area_init_node/free_area_init_core/memmap_init_zone will mark all page in node range

Re: [RFC 4/4] Sparse initialization of struct page array.

On Fri, Jul 12, 2013 at 09:19:12PM -0700, Yinghai Lu wrote: > On Thu, Jul 11, 2013 at 7:03 PM, Robin Holt wrote: > > During boot of large memory machines, a significant portion of boot > > is spent initializing the struct page array. The vast majority of > > those pages are

Re: [RFC 4/4] Sparse initialization of struct page array.

On Fri, Jul 12, 2013 at 09:19:12PM -0700, Yinghai Lu wrote: On Thu, Jul 11, 2013 at 7:03 PM, Robin Holt h...@sgi.com wrote: During boot of large memory machines, a significant portion of boot is spent initializing the struct page array. The vast majority of those pages are not referenced

Re: [RFC 4/4] Sparse initialization of struct page array.

On Tue, Jul 23, 2013 at 06:41:50AM -0500, Robin Holt wrote: > On Tue, Jul 23, 2013 at 06:15:49AM -0500, Robin Holt wrote: > > I think the other critical path which is affected is in expand(). > > There, we just call ensure_page_is_initialized() blindly which does > > the ch

Re: [RFC 4/4] Sparse initialization of struct page array.

On Tue, Jul 23, 2013 at 06:15:49AM -0500, Robin Holt wrote: > I think the other critical path which is affected is in expand(). > There, we just call ensure_page_is_initialized() blindly which does > the check against the other page. The below is a nearly zero addition. > Sorry for t

Re: [RFC 4/4] Sparse initialization of struct page array.

, 2013 at 06:09:47AM -0500, Robin Holt wrote: > On Tue, Jul 23, 2013 at 10:32:11AM +0200, Ingo Molnar wrote: > > > > * H. Peter Anvin wrote: > > > > > On 07/15/2013 11:26 AM, Robin Holt wrote: > > > > > > > Is there a fairly cheap way to d

Re: [RFC 4/4] Sparse initialization of struct page array.

On Tue, Jul 23, 2013 at 10:32:11AM +0200, Ingo Molnar wrote: > > * H. Peter Anvin wrote: > > > On 07/15/2013 11:26 AM, Robin Holt wrote: > > > > > Is there a fairly cheap way to determine definitively that the struct > > > page is not initialized

Re: [RFC 4/4] Sparse initialization of struct page array.

On Tue, Jul 23, 2013 at 10:32:11AM +0200, Ingo Molnar wrote: * H. Peter Anvin h...@zytor.com wrote: On 07/15/2013 11:26 AM, Robin Holt wrote: Is there a fairly cheap way to determine definitively that the struct page is not initialized? By definition I would assume

Re: [RFC 4/4] Sparse initialization of struct page array.

, 2013 at 06:09:47AM -0500, Robin Holt wrote: On Tue, Jul 23, 2013 at 10:32:11AM +0200, Ingo Molnar wrote: * H. Peter Anvin h...@zytor.com wrote: On 07/15/2013 11:26 AM, Robin Holt wrote: Is there a fairly cheap way to determine definitively that the struct page

Re: [RFC 4/4] Sparse initialization of struct page array.

On Tue, Jul 23, 2013 at 06:15:49AM -0500, Robin Holt wrote: I think the other critical path which is affected is in expand(). There, we just call ensure_page_is_initialized() blindly which does the check against the other page. The below is a nearly zero addition. Sorry for the confusion. My

Re: [RFC 4/4] Sparse initialization of struct page array.

On Tue, Jul 23, 2013 at 06:41:50AM -0500, Robin Holt wrote: On Tue, Jul 23, 2013 at 06:15:49AM -0500, Robin Holt wrote: I think the other critical path which is affected is in expand(). There, we just call ensure_page_is_initialized() blindly which does the check against the other page

Re: [RFC 0/4] Transparent on-demand struct page initialization embedded in the buddy allocator

On Fri, Jul 19, 2013 at 04:51:49PM -0700, Yinghai Lu wrote: > On Wed, Jul 17, 2013 at 2:30 AM, Robin Holt wrote: > > On Wed, Jul 17, 2013 at 01:17:44PM +0800, Sam Ben wrote: > >> >With this patch, we did boot a 16TiB machine. Without the patches, > >> &

Re: [RFC 0/4] Transparent on-demand struct page initialization embedded in the buddy allocator

On Fri, Jul 19, 2013 at 04:51:49PM -0700, Yinghai Lu wrote: On Wed, Jul 17, 2013 at 2:30 AM, Robin Holt h...@sgi.com wrote: On Wed, Jul 17, 2013 at 01:17:44PM +0800, Sam Ben wrote: With this patch, we did boot a 16TiB machine. Without the patches, the v3.10 kernel with the same

Re: [RFC 0/4] Transparent on-demand struct page initialization embedded in the buddy allocator

On Wed, Jul 17, 2013 at 01:17:44PM +0800, Sam Ben wrote: > On 07/12/2013 10:03 AM, Robin Holt wrote: > >We have been working on this since we returned from shutdown and have > >something to discuss now. We restricted ourselves to 2MiB initialization > >to keep the patch

Re: [RFC 0/4] Transparent on-demand struct page initialization embedded in the buddy allocator

On Wed, Jul 17, 2013 at 01:17:44PM +0800, Sam Ben wrote: On 07/12/2013 10:03 AM, Robin Holt wrote: We have been working on this since we returned from shutdown and have something to discuss now. We restricted ourselves to 2MiB initialization to keep the patch set a little smaller and more

Re: [RFC 4/4] Sparse initialization of struct page array.

On Mon, Jul 15, 2013 at 02:30:37PM -0700, Andrew Morton wrote: > On Thu, 11 Jul 2013 21:03:55 -0500 Robin Holt wrote: > > > During boot of large memory machines, a significant portion of boot > > is spent initializing the struct page array. The vast majority

Re: [RFC 4/4] Sparse initialization of struct page array.

On Fri, Jul 12, 2013 at 09:19:12PM -0700, Yinghai Lu wrote: > On Thu, Jul 11, 2013 at 7:03 PM, Robin Holt wrote: > > During boot of large memory machines, a significant portion of boot > > is spent initializing the struct page array. The vast majority of > > those pages are

Re: [RFC 4/4] Sparse initialization of struct page array.

On Fri, Jul 12, 2013 at 09:19:12PM -0700, Yinghai Lu wrote: On Thu, Jul 11, 2013 at 7:03 PM, Robin Holt h...@sgi.com wrote: During boot of large memory machines, a significant portion of boot is spent initializing the struct page array. The vast majority of those pages are not referenced

Re: [RFC 4/4] Sparse initialization of struct page array.

On Mon, Jul 15, 2013 at 02:30:37PM -0700, Andrew Morton wrote: On Thu, 11 Jul 2013 21:03:55 -0500 Robin Holt h...@sgi.com wrote: During boot of large memory machines, a significant portion of boot is spent initializing the struct page array. The vast majority of those pages

Re: [RFC 4/4] Sparse initialization of struct page array.

On Mon, Jul 15, 2013 at 10:54:38AM -0700, H. Peter Anvin wrote: > On 07/15/2013 10:45 AM, Nathan Zimmer wrote: > > > > I hadn't actually been very happy with having a PG_uninitialized2mib flag. > > It implies if we want to jump to 1Gb pages we would need a second flag, > > PG_uninitialized1gb,

Re: [RFC 0/4] Transparent on-demand struct page initialization embedded in the buddy allocator

On Fri, Jul 12, 2013 at 10:27:56AM +0200, Ingo Molnar wrote: > > * Robin Holt wrote: > > > [...] > > > > With this patch, we did boot a 16TiB machine. Without the patches, the > > v3.10 kernel with the same configuration took 407 seconds for > &

Re: [RFC 0/4] Transparent on-demand struct page initialization embedded in the buddy allocator

On Thu, Jul 11, 2013 at 09:03:51PM -0500, Robin Holt wrote: > We have been working on this since we returned from shutdown and have > something to discuss now. We restricted ourselves to 2MiB initialization > to keep the patch set a little smaller and more clear. > > First,

Re: [RFC 0/4] Transparent on-demand struct page initialization embedded in the buddy allocator

On Thu, Jul 11, 2013 at 09:03:51PM -0500, Robin Holt wrote: We have been working on this since we returned from shutdown and have something to discuss now. We restricted ourselves to 2MiB initialization to keep the patch set a little smaller and more clear. First, I think I want to propose

Re: [RFC 0/4] Transparent on-demand struct page initialization embedded in the buddy allocator

On Fri, Jul 12, 2013 at 10:27:56AM +0200, Ingo Molnar wrote: * Robin Holt h...@sgi.com wrote: [...] With this patch, we did boot a 16TiB machine. Without the patches, the v3.10 kernel with the same configuration took 407 seconds for free_all_bootmem. With the patches

Re: [RFC 4/4] Sparse initialization of struct page array.

On Mon, Jul 15, 2013 at 10:54:38AM -0700, H. Peter Anvin wrote: On 07/15/2013 10:45 AM, Nathan Zimmer wrote: I hadn't actually been very happy with having a PG_uninitialized2mib flag. It implies if we want to jump to 1Gb pages we would need a second flag, PG_uninitialized1gb, for that.

Re: [RFC 3/4] Seperate page initialization into a separate function.

On Fri, Jul 12, 2013 at 08:06:52PM -0700, Yinghai Lu wrote: > On Thu, Jul 11, 2013 at 7:03 PM, Robin Holt wrote: > > Currently, memmap_init_zone() has all the smarts for initializing a > > single page. When we convert to initializing pages in a 2MiB chunk, > > we will need

Re: [RFC 3/4] Seperate page initialization into a separate function.

On Fri, Jul 12, 2013 at 08:06:52PM -0700, Yinghai Lu wrote: On Thu, Jul 11, 2013 at 7:03 PM, Robin Holt h...@sgi.com wrote: Currently, memmap_init_zone() has all the smarts for initializing a single page. When we convert to initializing pages in a 2MiB chunk, we will need to do

Re: [RFC 2/4] Have __free_pages_memory() free in larger chunks.

ffs(start); while (start + (1UL << order) > end) order--; __free_pages_bootmem(start, order); start += (1UL << order); } } Robin On Thu, Jul 11, 2013 at 09:03:53PM -0500, Robin Holt wrote:

Re: [RFC 2/4] Have __free_pages_memory() free in larger chunks.

(start); while (start + (1UL order) end) order--; __free_pages_bootmem(start, order); start += (1UL order); } } Robin On Thu, Jul 11, 2013 at 09:03:53PM -0500, Robin Holt wrote: Currently, when free_all_bootmem

[RFC 2/4] Have __free_pages_memory() free in larger chunks.

. Signed-off-by: Robin Holt Signed-off-by: Nate Zimmer To: "H. Peter Anvin" To: Ingo Molnar Cc: Linux Kernel Cc: Linux MM Cc: Rob Landley Cc: Mike Travis Cc: Daniel J Blueman Cc: Andrew Morton Cc: Greg KH Cc: Yinghai Lu Cc: Mel Gorman --- mm/nobootmem.c | 8 1 file

[RFC 0/4] Transparent on-demand struct page initialization embedded in the buddy allocator

will perform. I am on vacation for the next three days so I am sorry in advance for my infrequent or non-existant responses. Signed-off-by: Robin Holt Signed-off-by: Nate Zimmer To: "H. Peter Anvin" To: Ingo Molnar Cc: Linux Kernel Cc: Linux MM Cc: Rob Landley Cc: Mike Travis Cc

[RFC 1/4] memblock: Introduce a for_each_reserved_mem_region iterator.

As part of initializing struct page's in 2MiB chunks, we noticed that at the end of free_all_bootmem(), there was nothing which had forced the reserved/allocated 4KiB pages to be initialized. This helper function will be used for that expansion. Signed-off-by: Robin Holt Signed-off-by: Nate

[RFC 3/4] Seperate page initialization into a separate function.

Currently, memmap_init_zone() has all the smarts for initializing a single page. When we convert to initializing pages in a 2MiB chunk, we will need to do this equivalent work from two separate places so we are breaking out a helper function. Signed-off-by: Robin Holt Signed-off-by: Nate Zimmer

[RFC 4/4] Sparse initialization of struct page array.

, this allows us the chance to use normal performance monitoring tools to determine where the bulk of time is spent during page initialization. Signed-off-by: Robin Holt Signed-off-by: Nate Zimmer To: "H. Peter Anvin" To: Ingo Molnar Cc: Linux Kernel Cc: Linux MM Cc: Rob Landley

[RFC 4/4] Sparse initialization of struct page array.

, this allows us the chance to use normal performance monitoring tools to determine where the bulk of time is spent during page initialization. Signed-off-by: Robin Holt h...@sgi.com Signed-off-by: Nate Zimmer nzim...@sgi.com To: H. Peter Anvin h...@zytor.com To: Ingo Molnar mi...@kernel.org Cc

[RFC 3/4] Seperate page initialization into a separate function.

Currently, memmap_init_zone() has all the smarts for initializing a single page. When we convert to initializing pages in a 2MiB chunk, we will need to do this equivalent work from two separate places so we are breaking out a helper function. Signed-off-by: Robin Holt h...@sgi.com Signed-off

  1   2   3   4   5   6   7   8   >