Re: [PATCH] [v2] Input: Add "Share" button to Microsoft Xbox One controller.

2021-03-04 Thread Roderick Colenbrander
(resend in plain text) +benjamin in a more explicit way Hi Chris, I see the need for the Record button. I wonder what makes sense from the Linux kernel perspective. For DualShock 4 and DualSense there is a Share button too (it introduced it). For DualShock 4 that was mapped to 'Select' I think

Re: [RFC v2] iio: input-bridge: optionally bridge iio acceleometers to create a /dev/input interface

2019-05-11 Thread Roderick Colenbrander
On Fri, May 10, 2019 at 1:57 AM Bastien Nocera wrote: > > On Sun, 2019-04-14 at 09:26 -0700, Roderick Colenbrander wrote: > > > > > We at the time were one of the first to expose acceleration and gyro > > data through /dev/input for DualShock 4 as supported

Re: [RFC v2] iio: input-bridge: optionally bridge iio acceleometers to create a /dev/input interface

2019-04-14 Thread Roderick Colenbrander
Hi Jonathan and Nikolaus, I would like to jump into this discussion a bit as well. Might be slightly off topic or not... I'm not too familiar with the details of IIO, but as Sony we do report accelerometer / gyroscope data through /dev/input for our DualShock devices through hid-sony. This is

Re: NULL pointer dereference when writing fuzzed data to /dev/uhid

2019-01-04 Thread Roderick Colenbrander
Anatoly > > пт, 4 янв. 2019 г. в 19:38, Roderick Colenbrander : > > > > > > For sony.bin: > > > > > > > > root@kvm-xfstests:~# cat /vtmp/sony.bin > /dev/uhid > > > > [ 16.891931] sony 0003:054C:1000.0001: unknown main item tag 0x0

Re: NULL pointer dereference when writing fuzzed data to /dev/uhid

2019-01-04 Thread Roderick Colenbrander
> > For sony.bin: > > > > root@kvm-xfstests:~# cat /vtmp/sony.bin > /dev/uhid > > [ 16.891931] sony 0003:054C:1000.0001: unknown main item tag 0x0 > > [ 16.892432] sony 0003:054C:1000.0001: unknown main item tag 0x0 > > [ 16.892894] sony 0003:054C:1000.0001: unknown main item tag 0x0 > > [

Re: [PATCH] HID: Add support for 146b:0902 Bigben Interactive Kids' gamepad

2018-05-28 Thread Roderick Colenbrander
Hi Hanno, A few suggestions for your patch based on a quick review (had limited time). In terms of code style, I noticed a lot of C++ style comments which are not part of the kernel code style instead use C comments. To check for potential other issues as well, run your patch through

Re: [PATCH] HID: Add support for 146b:0902 Bigben Interactive Kids' gamepad

2018-05-28 Thread Roderick Colenbrander
Hi Hanno, A few suggestions for your patch based on a quick review (had limited time). In terms of code style, I noticed a lot of C++ style comments which are not part of the kernel code style instead use C comments. To check for potential other issues as well, run your patch through

Re: [PATCH 2/2] Input: add motion-tracking ABS_* bits and docs

2016-11-07 Thread Roderick Colenbrander
On Thu, Sep 29, 2016 at 12:25 AM, Benjamin Tissoires <benjamin.tissoi...@redhat.com> wrote: > > On Sep 28 2016 or thereabouts, Roderick Colenbrander wrote: > > On Wed, Sep 28, 2016 at 10:39 AM, Dmitry Torokhov > > <dmitry.torok...@gmail.com> wrote: > > >

Re: [PATCH 2/2] Input: add motion-tracking ABS_* bits and docs

2016-11-07 Thread Roderick Colenbrander
On Thu, Sep 29, 2016 at 12:25 AM, Benjamin Tissoires wrote: > > On Sep 28 2016 or thereabouts, Roderick Colenbrander wrote: > > On Wed, Sep 28, 2016 at 10:39 AM, Dmitry Torokhov > > wrote: > > > > > > On Tue, Sep 27, 2016 at 4:38 PM, Roderick Colenbrander

Re: [PATCH 2/2] Input: add motion-tracking ABS_* bits and docs

2016-09-29 Thread Roderick Colenbrander
On Thu, Sep 29, 2016 at 1:55 AM, <ji...@jic23.retrosnub.co.uk> wrote: > On 28.09.2016 18:39, Dmitry Torokhov wrote: >> >> On Tue, Sep 27, 2016 at 4:38 PM, Roderick Colenbrander >> <roder...@gaikai.com> wrote: >>> >>> From: Roderick Colenbrander

Re: [PATCH 2/2] Input: add motion-tracking ABS_* bits and docs

2016-09-29 Thread Roderick Colenbrander
On Thu, Sep 29, 2016 at 1:55 AM, wrote: > On 28.09.2016 18:39, Dmitry Torokhov wrote: >> >> On Tue, Sep 27, 2016 at 4:38 PM, Roderick Colenbrander >> wrote: >>> >>> From: Roderick Colenbrander >>> >>> This patch introduces new axes fo

Re: [PATCH 2/2] Input: add motion-tracking ABS_* bits and docs

2016-09-28 Thread Roderick Colenbrander
On Wed, Sep 28, 2016 at 10:39 AM, Dmitry Torokhov <dmitry.torok...@gmail.com> wrote: > > On Tue, Sep 27, 2016 at 4:38 PM, Roderick Colenbrander > <roder...@gaikai.com> wrote: > > From: Roderick Colenbrander <roderick.colenbran...@sony.com> > > > > Th

Re: [PATCH 2/2] Input: add motion-tracking ABS_* bits and docs

2016-09-28 Thread Roderick Colenbrander
On Wed, Sep 28, 2016 at 10:39 AM, Dmitry Torokhov wrote: > > On Tue, Sep 27, 2016 at 4:38 PM, Roderick Colenbrander > wrote: > > From: Roderick Colenbrander > > > > This patch introduces new axes for acceleration and angular velocity. > > David Herrmann's work

[PATCH 1/2] Input: introduce ABS_MAX2/CNT2 and friends

2016-09-27 Thread Roderick Colenbrander
From: Roderick Colenbrander <roderick.colenbran...@sony.com> David Herrmann's original patch was ported over to a modern Linux kernel. In the process, we went over all the feedback to the original patch series and added various improvements: - evdev_handle_get_abs2 returns valid_cnt instea

[PATCH 2/2] Input: add motion-tracking ABS_* bits and docs

2016-09-27 Thread Roderick Colenbrander
From: Roderick Colenbrander <roderick.colenbran...@sony.com> This patch introduces new axes for acceleration and angular velocity. David Herrmann's work served as a base, but we extended the specification with various changes inspired by real devices and challenges we see when doing

[PATCH 1/2] Input: introduce ABS_MAX2/CNT2 and friends

2016-09-27 Thread Roderick Colenbrander
From: Roderick Colenbrander David Herrmann's original patch was ported over to a modern Linux kernel. In the process, we went over all the feedback to the original patch series and added various improvements: - evdev_handle_get_abs2 returns valid_cnt instead of 0 when succesfull - Updated

[PATCH 2/2] Input: add motion-tracking ABS_* bits and docs

2016-09-27 Thread Roderick Colenbrander
From: Roderick Colenbrander This patch introduces new axes for acceleration and angular velocity. David Herrmann's work served as a base, but we extended the specification with various changes inspired by real devices and challenges we see when doing motion tracking. - Changed unit

[PATCH 0/2] Input: ABS2 and motion tracking

2016-09-27 Thread Roderick Colenbrander
From: Roderick Colenbrander <roderick.colenbran...@sony.com> For some input driver work we have been doing, we were limited by not having a wide enough ABS range in evdev. The current ABS range is mostly full and due to limitations on the ioctl design, it can't be extended. About 3 yea

[PATCH 0/2] Input: ABS2 and motion tracking

2016-09-27 Thread Roderick Colenbrander
From: Roderick Colenbrander For some input driver work we have been doing, we were limited by not having a wide enough ABS range in evdev. The current ABS range is mostly full and due to limitations on the ioctl design, it can't be extended. About 3 years ago, David Herrmann did work

[PATCH] HID: uhid: Fixes a bug with userspace bluetooth stacks, which causes hangs during certain operations

2016-05-18 Thread Roderick Colenbrander
issue. Signed-off-by: Roderick Colenbrander <roderick.colenbran...@sony.com> Cc: sta...@vger.kernel.org --- drivers/hid/uhid.c | 33 - 1 file changed, 24 insertions(+), 9 deletions(-) diff --git a/drivers/hid/uhid.c b/drivers/hid/uhid.c index 16b6f11..9

[PATCH] HID: uhid: Fixes a bug with userspace bluetooth stacks, which causes hangs during certain operations

2016-05-18 Thread Roderick Colenbrander
issue. Signed-off-by: Roderick Colenbrander Cc: sta...@vger.kernel.org --- drivers/hid/uhid.c | 33 - 1 file changed, 24 insertions(+), 9 deletions(-) diff --git a/drivers/hid/uhid.c b/drivers/hid/uhid.c index 16b6f11..99ec3ff 100644 --- a/drivers/hid/uhid.c +++ b

Re: [PATCH] HID: uhid: Fixes a bug with userspace bluetooth stacks, which causes hangs during certain operations

2016-04-21 Thread Roderick Colenbrander
p request with compat > pointer. > > --- > 0-DAY kernel test infrastructureOpen Source Technology Center > https://lists.01.org/pipermail/kbuild-all Intel Corporation -- Roderick Colenbrander Manager of Software Engineering Gaikai, a Sony Computer Entertainment Company roder...@gaikai.com

Re: [PATCH] HID: uhid: Fixes a bug with userspace bluetooth stacks, which causes hangs during certain operations

2016-04-21 Thread Roderick Colenbrander
05 >406 if (get_user(type, buffer)) >407 return -EFAULT; >408 >409 if (type == UHID_CREATE) { >410 /* >411 * This is our messed up request with compat