Re: linux-next: manual merge of the block tree with the xfs tree

2015-09-02 Thread Roger Willcocks
On Wed, 2015-09-02 at 23:03 +1000, Stephen Rothwell wrote: > Hi Roger, > > On Wed, 2 Sep 2015 10:45:29 +0100 Roger Willcocks > wrote: > > > > On 2 Sep 2015, at 03:16, Stephen Rothwell wrote: > > > > > ++if (!ioend->io_error) > > >

Re: linux-next: manual merge of the block tree with the xfs tree

2015-09-02 Thread Roger Willcocks
On 2 Sep 2015, at 03:16, Stephen Rothwell wrote: > Hi Jens, > > Today's linux-next merge of the block tree got a conflict in: > > fs/xfs/xfs_aops.c > > between commit: > > c9eb256eda44 ("xfs: return errors from partial I/O failures to files") > > from the xfs tree and commit: > > 4246a0

Re: [fuse-devel] [PATCH v5 7/7] add a flag for per-operation O_DSYNC semantics

2014-11-07 Thread Roger Willcocks
tter, even if it does take an extra couple of nanoseconds. Actually I'd probably write: if (type == READ && (flags & RWF_NONBLOCK)) return -EAGAIN; if (type == WRITE && (flags & RWF_DSYNC)) return -EINVAL; (no 'else' si

Re: [RFC 11/32] xfs: convert to struct inode_time

2014-06-03 Thread Roger Willcocks
On Mon, 2014-06-02 at 19:32 -0400, Theodore Ts'o wrote: > Linux's time(2) can return (time_t) -1 and set errno to EFAULT, per > the Posix specification: > > SYSCALL_DEFINE1(time, time_t __user *, tloc) > { > time_t i = get_seconds(); > > if (tloc) { > if (put_user(i,tl

Re: [RFC 11/32] xfs: convert to struct inode_time

2014-06-02 Thread Roger Willcocks
On Mon, 2014-06-02 at 11:04 -0400, Chuck Lever wrote: > NFSv2/3 timestamps are a pair of unsigned 32-bit values: one value for > seconds since midnight GMT Jan 1, 1970, and one value for nanoseconds. > (See the definition of nfstime3 in RFC 1813). > nfstime3 could be extended by redefining the

Re: [RFC 11/32] xfs: convert to struct inode_time

2014-06-02 Thread Roger Willcocks
On Mon, 2014-06-02 at 10:28 +1000, Dave Chinner wrote: > > The 32 bit second counters in timestamps are too small to represent > time beyond the unix epoch (jan 2038) correctly. Extend the on-disk > format for a timestamp to include an 8-bit epoch counter so that we > can extend time for up to 2

Re: nfsd bug: create file with specific uid/gid

2007-12-01 Thread Roger Willcocks
J. Bruce Fields wrote: On Fri, Nov 30, 2007 at 05:06:03PM +, Roger Willcocks wrote: nfsd/vfs.c:nfsd_create (the v2 version of create) says: "Set file attributes. Mode has already been set and setting uid/gid works only for root" but it doesn't actually tes

nfsd bug: create file with specific uid/gid

2007-11-30 Thread Roger Willcocks
nfsd/vfs.c:nfsd_create (the v2 version of create) says: "Set file attributes. Mode has already been set and setting uid/gid works only for root" but it doesn't actually test for root-ness (which could happen if the access is no-root-squash). There's similar code without the comment in nfsd_cre