Hi Enric
On Wed, May 15, 2019 at 11:23:13PM +0200, Enric Balletbo Serra wrote:
> Missatge de Enric Balletbo i Serra del
> dia dc., 15 de maig 2019 a les 15:00:
> >
> > Hi,
> >
> > On 4/5/19 15:34, Rushikesh S Kadam wrote:
> > > This driver implements a sli
a
client with the ISH Transport Protocol bus (lower layer) to
talk with the ISH firwmare. See description of the ISHTP
protocol at Documentation/hid/intel-ish-hid.txt
Signed-off-by: Rushikesh S Kadam
Acked-by: Srinivas Pandruvada
Acked-by: Enric Balletbo i Serra
Reviewed-by: Jett Rink
Tested-by: Jett
Hi Jiri,
On Thu, May 02, 2019 at 04:44:04PM +0530, Jiri Kosina wrote:
> On Tue, 23 Apr 2019, Srinivas Pandruvada wrote:
>
> > +Jiri
> >
> > He is not copied.
>
> Could you please resubmit the final version, and CC linux-input@ and
> Benjamin Tissories as appropriate?
I just posted teo
a
client with the ISH Transport Protocol bus (lower layer) to
talk with the ISH firwmare. See description of the ISHTP
protocol at Documentation/hid/intel-ish-hid.txt
Signed-off-by: Rushikesh S Kadam
Acked-by: Enric Balletbo i Serra
Acked-by: Srinivas Pandruvada
Reviewed-by: Jett Rink
Tested-by: Jett
a
client with the ISH Transport Protocol bus (lower layer) to
talk with the ISH firwmare. See description of the ISHTP
protocol at Documentation/hid/intel-ish-hid.txt
Signed-off-by: Rushikesh S Kadam
---
The patches are baselined to hid git tree, branch for-5.2/ish
https://git.kernel.org/pub/scm/linux
Hi Enric, Srinivas
On Thu, Apr 11, 2019 at 12:55:13PM +0200, Enric Balletbo i Serra wrote:
> Hi,
>
> On 10/4/19 17:31, Jett Rink wrote:
> > Reviewed-by: Jett Rink
> > Tested-by: Jett Rink
> >
> >
> > On Sun, Apr 7, 2019 at 6:10 AM Rushikesh S
On 3/4/19 10:52, Rushikesh S Kadam wrote:
> > Add ChromeOS EC ISHTP driver.
> >
>
> Could you explain a bit more about what ISHTP is? I suppose is a protocol to
> communicate with the Integrated Sensor Driver, but would be good have a better
> explanation here.
ISH Trans
a
client with the ISH Transport Protocol bus (lower layer) to
talk with the ISH firwmare. See description of the ISHTP
protocol at Documentation/hid/intel-ish-hid.txt
Signed-off-by: Rushikesh S Kadam
---
v3
- Made several changes to improve code readability. Replaced
multiple cl_data_to_dev
On Wed, Apr 03, 2019 at 03:11:02PM +0200, Jiri Kosina wrote:
> On Tue, 2 Apr 2019, Rushikesh S Kadam wrote:
>
> > This driver adds support for loading Intel Integrated
> > Sensor Hub (ISH) firmware from host file system to ISH
> > SRAM and start execution.
> >
>
Add ChromeOS EC ISHTP driver.
Sends ChromeOS EC host commands over ISHTP to ISH firmware.
Signed-off-by: Rushikesh S Kadam
---
v2
- Dropped unused "reset" parameter in function cros_ec_init()
- Change driver name to cros_ec_ishtp to be consistent with other
references i
Hi Jett
On Tue, Apr 02, 2019 at 09:48:12AM -0600, Jett Rink wrote:
> On Sun, Mar 31, 2019 at 1:25 PM Rushikesh S Kadam
> wrote:
> > +
> > +/*
> > + * The Read-Write Semaphore is used to prevent message TX or RX while
> > + * the ishtp client is being i
that communicates
with the Shim ISHTP loader device over the intel-ish-hid
stack, to download the main ISH firmware.
Signed-off-by: Rushikesh S Kadam
Acked-by: Srinivas Pandruvada
Acked-by: Nick Crews
Tested-by: Jett Rink
---
The patches are baselined to hid git tree, branch for-5.2/ish
https
; Ah, I guess I was wrong about logging OOM. I hadn’t hear about the
> recommendations against it, but they make sense. Thanks for the
> clarifications!
>
> On Sat, Mar 30, 2019 at 10:27 AM Joe Perches wrote:
> >
> > On Sat, 2019-03-30 at 15:52 +0530, Rushikesh S Kadam wro
Add ChromeOS EC ISHTP driver.
Sends host commands over ISHTP to ISH firmware.
Signed-off-by: Rushikesh S Kadam
---
drivers/platform/chrome/Kconfig | 13 +
drivers/platform/chrome/Makefile| 1 +
drivers/platform/chrome/cros_ec_ishtp.c | 795
3
that communicates
with the Shim ISHTP loader device over the intel-ish-hid
stack, to download the main ISH firmware.
Signed-off-by: Rushikesh S Kadam
---
The patches are baselined to hid git tree, branch for-5.2/ish
https://git.kernel.org/pub/scm/linux/kernel/git/hid/hid.git/log/?h=for-5.2/ish
v4
Hi Nick
I've few comments below about your suggestions,
On Fri, Mar 29, 2019 at 04:30:18PM -0700, Nick Crews wrote:
> On Fri, Mar 29, 2019 at 1:03 PM Rushikesh S Kadam
> wrote:
> >
> > +/**
> > + * ish_fw_xfer_ishtp() Loads ISH firmware using ishtp interface
> >
that communicates
with the Shim ISHTP loader device over the intel-ish-hid
stack, to download the main ISH firmware.
Signed-off-by: Rushikesh S Kadam
---
The patches are baselined to hid git tree, branch for-5.2/ish
https://git.kernel.org/pub/scm/linux/kernel/git/hid/hid.git/log/?h=for-5.2/ish
v3
Hi Nick
Please see my comments inline below,
On Thu, Mar 28, 2019 at 11:02:52PM -0700, Nick Crews wrote:
> This is so close! There are just one or two tiny things.
>
> On Thu, Mar 28, 2019 at 1:20 PM Rushikesh S Kadam
> wrote:
> > +/**
> > + * loader_cl_send()
that communicates
with the Shim ISHTP loader device over the intel-ish-hid
stack, to download the main ISH firmware.
Signed-off-by: Rushikesh S Kadam
---
The patches are baselined to hid git tree, branch for-5.2/ish
https://git.kernel.org/pub/scm/linux/kernel/git/hid/hid.git/log/?h=for-5.2/ish
Hi Nick
Thanks once again for your time.
I've addressed majority of the comments below.
Will send a v2 shortly. Please see my replies
inline below.
On Tue, Mar 26, 2019 at 06:39:14PM -0600, Nick Crews wrote:
> Hi Rushikesh, I know I've been reviewing this on Chromium, but I have
> some more
that communicates
with the Shim ISHTP loader device over the intel-ish-hid
stack, to download the main ISH firmware.
Signed-off-by: Rushikesh S Kadam
---
The patches are baselined to hid git tree, branch for-5.2/ish
https://git.kernel.org/pub/scm/linux/kernel/git/hid/hid.git/log/?h=for-5.2/ish
Hi Andy
On Fri, Mar 01, 2019 at 09:28:11AM +0200, Andy Shevchenko wrote:
> On Fri, Mar 01, 2019 at 09:36:11AM +0530, Rushikesh S Kadam wrote:
> > Integrated Sensor Hub (ISH) is also a MCU running EC
> > having feature bit EC_FEATURE_ISH. Instantiate it as
> > a special CrOS
Integrated Sensor Hub (ISH) is also a MCU running EC
having feature bit EC_FEATURE_ISH. Instantiate it as
a special CrOS EC device with device name 'cros_ish'.
Signed-off-by: Rushikesh S Kadam
---
v3
- Dropped "Intel" in commments in cros_ec header file. CrOS EC ISH
device is a g
Integrated Sensor Hub (ISH) is also a MCU running EC
having feature bit EC_FEATURE_ISH. Instantiate it as
a special CrOS EC device with device name 'cros_ish'.
Signed-off-by: Rushikesh S Kadam
---
v2
- Addressed review comments to term the CrOS EC device as a generic
Integrated Sensor Hub.
v1
Thanks Enric, Jett, Gwendal & Andy for taking timeout to review
the patch & provide detailed inputs.
Couple of acks below.
On Thu, Feb 28, 2019 at 01:33:09PM +0100, Enric Balletbo Serra wrote:
> Hi,
>
> Based on the discussion we had, only some few comments.
>
> Missat
Intel Integrated Sensor Hub (ISH) is also a MCU running EC
having feature bit EC_FEATURE_ISH. Instantiate it as a special
CrOS EC device with device name 'cros_ish'.
Signed-off-by: Rushikesh S Kadam
---
drivers/mfd/cros_ec_dev.c| 10 ++
include/linux/mfd/cros_ec.h
SPEND flag for the GPIO irq_chip, to
disable the second level interrupts at suspend_noirq stage via the irq_mask
callbacks. The irq_mask callback disables the IRQs in hardware by
programming the corresponding GPIO pad registers. Only IRQs that are not
marked for wake are disabled.
Signed-off-by: Rushike
SPEND flag for the GPIO irq_chip, to
disable the second level interrupts at suspend_noirq stage via the irq_mask
callbacks. The irq_mask callback disables the IRQs in hardware by
programming the corresponding GPIO pad registers. Only IRQs that are not
marked for wake are disabled.
Signed-off-by: Rushike
28 matches
Mail list logo
