Re: [PATCH v2 2/8] phy: mvebu-cp110-comphy: fix port check in ->xlate()

2018-12-02 Thread Russell King - ARM Linux
On Sun, Dec 02, 2018 at 08:35:09PM +0100, Miquel Raynal wrote: > Hi Russell, > > Russell King - ARM Linux wrote on Fri, 30 Nov > 2018 19:00:31 +: > > > On Fri, Nov 30, 2018 at 03:47:37PM +0100, Miquel Raynal wrote: > > > So far the PHY ->xlate()

Re: [PATCH 3.18 14/83] ARM: make lookup_processor_type() non-__init

2018-11-30 Thread Russell King - ARM Linux
On Fri, Nov 30, 2018 at 04:18:43PM +0100, Greg Kroah-Hartman wrote: > On Fri, Nov 30, 2018 at 04:15:54PM +0100, Greg Kroah-Hartman wrote: > > On Thu, Nov 29, 2018 at 02:28:18PM +, Russell King - ARM Linux wrote: > > > Hi, > > > > > > As I've already fed b

Re: [PATCH v2 2/8] phy: mvebu-cp110-comphy: fix port check in ->xlate()

2018-11-30 Thread Russell King - ARM Linux
On Fri, Nov 30, 2018 at 03:47:37PM +0100, Miquel Raynal wrote: > So far the PHY ->xlate() callback was checking if the port was > "invalid" before continuing, meaning that the port has not been used > yet. This check is not correct as there is no opposite call to > ->xlate() once the PHY is

Re: [PATCH v8] clk: Add (devm_)clk_get_optional() functions

2018-11-30 Thread Russell King - ARM Linux
On Fri, Nov 30, 2018 at 10:25:37AM +, Phil Edworthy wrote: > Hi Stephen, > > On 30 November 2018 09:09 Stephen Boyd wrote: > > Quoting Phil Edworthy (2018-11-20 06:14:45) > > > This adds clk_get_optional() and devm_clk_get_optional() functions to > > > get optional clocks. > > > They behave

Re: [PATCH 2/6] phy: add A3700 COMPHY support

2018-11-29 Thread Russell King - ARM Linux
On Thu, Nov 29, 2018 at 05:12:45PM +0100, Miquel Raynal wrote: > Hello, > > Miquel Raynal wrote on Thu, 22 Nov 2018 > 22:04:16 +0100: > > +static struct phy *mvebu_a3700_comphy_xlate(struct device *dev, > > + struct of_phandle_args *args) > > +{ > > +

Re: [PATCH] arm64: io: specify asm operand width for __iormb()

2018-11-29 Thread Russell King - ARM Linux
On Thu, Nov 29, 2018 at 09:10:39AM -0700, Nathan Chancellor wrote: > On Thu, Nov 29, 2018 at 10:49:03AM +, Will Deacon wrote: > > On Thu, Nov 29, 2018 at 09:03:54AM +, Julien Thierry wrote: > > > > > > > > > On 29/11/18 04:19, Nick Desaulniers wrote: > > > > Fixes the warning produced from

Re: [PATCH 3.18 14/83] ARM: make lookup_processor_type() non-__init

2018-11-29 Thread Russell King - ARM Linux
Hi, As I've already fed back to Sascha about this, this patch on its own does not fix anything, and is not a stable kernel candidate without a patch that makes use of it (iow, the spectre fixes.) It is a preparatory patch for mainline commit 383fb3ee8024. Every commit in: $ git rev-list

Re: [PATCH] pci: imx6: support kernels built in Thumb-2 mode

2018-11-28 Thread Russell King - ARM Linux
On Wed, Nov 28, 2018 at 02:25:54PM +0100, Stefan Agner wrote: > Add a fault handler which handles reads in Thumb-2 mode. Install > the appropriate handler depending on which mode the kernel has > been built. This avoids an "Unhandled fault: external abort on > non-linefetch (0x1008) at 0xf0a8"

Re: [PATCH AUTOSEL 4.14 10/21] ARM: make lookup_processor_type() non-__init

2018-11-28 Thread Russell King - ARM Linux
On Wed, Nov 28, 2018 at 09:12:52AM -0500, Sasha Levin wrote: > On Fri, Nov 23, 2018 at 12:02:54AM +0000, Russell King - ARM Linux wrote: > >Hi Sasha, > > > >We need to keep track of which Spectre patches have been backported > >and which haven't. David Long has b

Re: [PATCH] arm: always update thread_info->syscall

2018-11-27 Thread Russell King - ARM Linux
On Tue, Nov 27, 2018 at 10:56:20AM +, Russell King - ARM Linux wrote: > On Tue, Nov 27, 2018 at 08:30:32AM -0200, Rafael David Tinoco wrote: > > On 11/26/18 9:44 PM, Russell King - ARM Linux wrote: > > >On Mon, Nov 26, 2018 at 11:41:11PM +0000, Russell King - ARM Linux wrote:

Re: [PATCH] arm: always update thread_info->syscall

2018-11-27 Thread Russell King - ARM Linux
On Tue, Nov 27, 2018 at 08:30:32AM -0200, Rafael David Tinoco wrote: > On 11/26/18 9:44 PM, Russell King - ARM Linux wrote: > >On Mon, Nov 26, 2018 at 11:41:11PM +, Russell King - ARM Linux wrote: > >>On Mon, Nov 26, 2018 at 11:33:03PM +0000, Russell King - ARM Linux wrote: &

Re: [PATCH] arm: always update thread_info->syscall

2018-11-26 Thread Russell King - ARM Linux
On Mon, Nov 26, 2018 at 11:41:11PM +, Russell King - ARM Linux wrote: > On Mon, Nov 26, 2018 at 11:33:03PM +0000, Russell King - ARM Linux wrote: > > On Mon, Nov 26, 2018 at 08:53:35PM -0200, Rafael David Tinoco wrote: > > > Right now, only way for task->thread_info-&

Re: [PATCH] arm: always update thread_info->syscall

2018-11-26 Thread Russell King - ARM Linux
On Mon, Nov 26, 2018 at 11:33:03PM +, Russell King - ARM Linux wrote: > On Mon, Nov 26, 2018 at 08:53:35PM -0200, Rafael David Tinoco wrote: > > Right now, only way for task->thread_info->syscall to be updated is if > > if _TIF_SYSCALL_WORK is set in current's ta

Re: [PATCH] arm: always update thread_info->syscall

2018-11-26 Thread Russell King - ARM Linux
On Mon, Nov 26, 2018 at 08:53:35PM -0200, Rafael David Tinoco wrote: > Right now, only way for task->thread_info->syscall to be updated is if > if _TIF_SYSCALL_WORK is set in current's task thread_info->flags > (similar to what has_syscall_work() checks for arm64). > > This means that "->syscall"

Re: [PATCH] dmaengine: ti: omap-dma: Configure LCH_TYPE for OMAP1

2018-11-25 Thread Russell King - ARM Linux
On Sun, Nov 25, 2018 at 11:11:05AM +, Russell King - ARM Linux wrote: > On Sat, Nov 24, 2018 at 05:07:17PM -0800, Tony Lindgren wrote: > > * Russell King - ARM Linux [181124 20:10]: > > > On Fri, Nov 23, 2018 at 08:52:15PM +0200, Aaro Koskinen wrote: > > > > Hi

Re: [PATCH] dmaengine: ti: omap-dma: Configure LCH_TYPE for OMAP1

2018-11-25 Thread Russell King - ARM Linux
On Sat, Nov 24, 2018 at 05:07:17PM -0800, Tony Lindgren wrote: > * Russell King - ARM Linux [181124 20:10]: > > On Fri, Nov 23, 2018 at 08:52:15PM +0200, Aaro Koskinen wrote: > > > Hi, > > > > > > On Fri, Nov 23, 2018 at 02:35:04PM +0200, Peter Ujfalus

Re: [PATCH] dmaengine: ti: omap-dma: Configure LCH_TYPE for OMAP1

2018-11-24 Thread Russell King - ARM Linux
On Fri, Nov 23, 2018 at 08:52:15PM +0200, Aaro Koskinen wrote: > Hi, > > On Fri, Nov 23, 2018 at 02:35:04PM +0200, Peter Ujfalusi wrote: > > On 22/11/2018 17.12, Russell King - ARM Linux wrote: > > > I'm also not sure about this: > > >

Re: [PATCH] dmaengine: ti: omap-dma: Configure LCH_TYPE for OMAP1

2018-11-24 Thread Russell King - ARM Linux
On Sat, Nov 24, 2018 at 09:06:48PM +0200, Aaro Koskinen wrote: > Hello, > > On Sat, Nov 24, 2018 at 05:48:23PM +, Russell King - ARM Linux wrote: > > Hmm, there's more questionable stuff in this driver, and the gadget > > layer. > > [...] > > > So, w

Re: [PATCH] dmaengine: ti: omap-dma: Configure LCH_TYPE for OMAP1

2018-11-24 Thread Russell King - ARM Linux
On Sat, Nov 24, 2018 at 02:17:40AM +0200, Aaro Koskinen wrote: > Hi, > > On Fri, Nov 23, 2018 at 01:45:46PM +0200, Peter Ujfalusi wrote: > > On 23/11/2018 0.01, Aaro Koskinen wrote: > > > With that reverted, the DMA works OK (and I can also now confirm that > > > OMAP_DMA_LCH_2D works). I haven't

Re: [PATCH] dmaengine: ti: omap-dma: Configure LCH_TYPE for OMAP1

2018-11-23 Thread Russell King - ARM Linux
On Fri, Nov 23, 2018 at 04:16:59PM +, Russell King - ARM Linux wrote: > Hi Peter, > > Here's the patch, which should now support IN as well as OUT. > Completely untested, as mentioned before. Now compile tested... drivers/usb/gadget/udc/omap

Re: [PATCH] dmaengine: ti: omap-dma: Configure LCH_TYPE for OMAP1

2018-11-23 Thread Russell King - ARM Linux
Hi Peter, Here's the patch, which should now support IN as well as OUT. Completely untested, as mentioned before. drivers/usb/gadget/udc/omap_udc.c | 286 ++ drivers/usb/gadget/udc/omap_udc.h | 3 +- 2 files changed, 135 insertions(+), 154 deletions(-)

Re: [PATCH] dmaengine: ti: omap-dma: Configure LCH_TYPE for OMAP1

2018-11-23 Thread Russell King - ARM Linux
On Fri, Nov 23, 2018 at 02:35:04PM +0200, Peter Ujfalusi wrote: > > Also we can't deal with the omap_set_dma_dest_burst_mode() setting - > > DMAengine always uses a 64 byte burst, but udc wants a smaller burst > > setting. Does this matter? > > The tusb also fiddled with the burst before the

Re: Sleeping in user_access section

2018-11-23 Thread Russell King - ARM Linux
On Fri, Nov 23, 2018 at 11:57:31AM +, Julien Thierry wrote: > > > On 23/11/18 10:50, Russell King - ARM Linux wrote: > >On Fri, Nov 23, 2018 at 01:57:12AM -0800, h...@zytor.com wrote: > >>You should never call a sleeping function from a user_access section. >

Re: Sleeping in user_access section

2018-11-23 Thread Russell King - ARM Linux
On Fri, Nov 23, 2018 at 01:57:12AM -0800, h...@zytor.com wrote: > You should never call a sleeping function from a user_access section. > It is intended for very limited regions. So, what happens if the "unsafe" user access causes a page fault that ends up sleeping? -- RMK's Patch system:

Re: [PATCH] dmaengine: ti: omap-dma: Configure LCH_TYPE for OMAP1

2018-11-22 Thread Russell King - ARM Linux
On Fri, Nov 23, 2018 at 12:24:26AM +0200, Aaro Koskinen wrote: > Hi, > > On Thu, Nov 22, 2018 at 03:12:36PM +, Russell King - ARM Linux wrote: > > On Thu, Nov 22, 2018 at 10:29:48AM +0000, Russell King - ARM Linux wrote: > > > On Tue, Nov 20, 2018 at 11:04:06PM +0

Re: [PATCH AUTOSEL 4.4 3/8] ARM: make lookup_processor_type() non-__init

2018-11-22 Thread Russell King - ARM Linux
Same comments as for the 4.9 version of these patches, and also applies to the two 3.18 patches as well. They aren't fixes, but preparation for fixes, and should not be backported without the actual Spectre fix patch (which probably requires manual backport effort.) On Thu, Nov 22, 2018 at

Re: [PATCH AUTOSEL 4.9 10/15] ARM: split out processor lookup

2018-11-22 Thread Russell King - ARM Linux
Sorry, I meant this patch, not patch 11. On Thu, Nov 22, 2018 at 02:56:16PM -0500, Sasha Levin wrote: > From: Russell King > > [ Upstream commit 65987a8553061515b5851b472081aedb9837a391 ] > > Split out the lookup of the processor type and associated error handling > from the rest of

Re: [PATCH AUTOSEL 4.9 09/15] ARM: make lookup_processor_type() non-__init

2018-11-22 Thread Russell King - ARM Linux
This, and your patch 11 aren't fixes on their own. They're part of a rework for the "ARM: spectre-v2: per-CPU vtables to work around big.Little systems" patch. It doesn't make sense to back port these without that patch, even though they can be applied without. On Thu, Nov 22, 2018 at

Re: [PATCH AUTOSEL 4.14 10/21] ARM: make lookup_processor_type() non-__init

2018-11-22 Thread Russell King - ARM Linux
Hi Sasha, We need to keep track of which Spectre patches have been backported and which haven't. David Long has been doing the backport work, which doesn't include all the patches in my present spectre branch. You've picked up the last five, meaning there's a bunch in the middle of the entire

Re: [PATCH 1/2] module: Overwrite st_size instead of st_info

2018-11-22 Thread Russell King - ARM Linux
On Thu, Nov 22, 2018 at 06:40:45PM +0100, Ard Biesheuvel wrote: > On Thu, 22 Nov 2018 at 17:29, Jessica Yu wrote: > > > > +++ Vincent Whitchurch [22/11/18 13:24 +0100]: > > >On Thu, Nov 22, 2018 at 12:01:54PM +, Dave Martin wrote: > > >> On Mon, Nov 19, 2018 at 05:25:12PM +0100, Vincent

Re: [PATCH] dmaengine: ti: omap-dma: Configure LCH_TYPE for OMAP1

2018-11-22 Thread Russell King - ARM Linux
On Thu, Nov 22, 2018 at 10:29:48AM +, Russell King - ARM Linux wrote: > On Tue, Nov 20, 2018 at 11:04:06PM +0200, Aaro Koskinen wrote: > > I had switched to PIO mode in 2015 since the WARNs about legacy DMA > > API were too annoying and flooding the console. And now that I trie

Re: [PATCH] dmaengine: ti: omap-dma: Configure LCH_TYPE for OMAP1

2018-11-22 Thread Russell King - ARM Linux
On Tue, Nov 20, 2018 at 11:04:06PM +0200, Aaro Koskinen wrote: > I had switched to PIO mode in 2015 since the WARNs about legacy DMA > API were too annoying and flooding the console. And now that I tried > using DMA again with g_ether, it doesn't work anymore. The device get's > recognized on host

Re: [RFC PATCH 01/13] arm: Fix mutual exclusion in arch_gettimeoffset

2018-11-16 Thread Russell King - ARM Linux
On Thu, Nov 15, 2018 at 03:12:17PM +1100, Finn Thain wrote: > The thread went way off-topic when Christoph took the opportunity to > suggest the removal of RPC and EBSA110. That doesn't interest me. I suspect that is the right solution - I've been trying to get 4.19 to boot on my RPC and it's

Re: [RFC PATCH 01/13] arm: Fix mutual exclusion in arch_gettimeoffset

2018-11-14 Thread Russell King - ARM Linux
On Wed, Nov 14, 2018 at 03:58:36PM +0100, Geert Uytterhoeven wrote: > Hi Russell, > > On Wed, Nov 14, 2018 at 3:16 PM Russell King - ARM Linux > wrote: > > On Wed, Nov 14, 2018 at 02:17:09PM +1100, Finn Thain wrote: > > > So, even assuming that you're right about the

Re: [RFC PATCH 01/13] arm: Fix mutual exclusion in arch_gettimeoffset

2018-11-14 Thread Russell King - ARM Linux
On Wed, Nov 14, 2018 at 02:17:09PM +1100, Finn Thain wrote: > On Tue, 13 Nov 2018, Russell King - ARM Linux wrote: > > > > > A clocksource provides a cycle counter that monotonically changes and > > does not wrap between clockevent events. > > > > A cloc

Re: [RFC PATCH 01/13] arm: Fix mutual exclusion in arch_gettimeoffset

2018-11-14 Thread Russell King - ARM Linux
On Mon, Nov 12, 2018 at 03:12:39PM +1100, Finn Thain wrote: > Implementations of arch_gettimeoffset are generally not re-entrant > and assume that interrupts have been disabled. Unfortunately this > pre-condition got broken in v2.6.32. To me, it looks way worse than what you think. The original

Re: [RFC PATCH 01/13] arm: Fix mutual exclusion in arch_gettimeoffset

2018-11-13 Thread Russell King - ARM Linux
On Wed, Nov 14, 2018 at 02:35:29PM +1300, Michael Schmitz wrote: > So we'd still have to use jiffies + interpolation from the current timer > rundown counter as clocksource (since that will be monotonous and won't > wrap)? > > The way Finn did the clocksource for m68k, the clocksource counter

Re: [RFC PATCH 01/13] arm: Fix mutual exclusion in arch_gettimeoffset

2018-11-13 Thread Russell King - ARM Linux
On Wed, Nov 14, 2018 at 08:55:37AM +1100, Finn Thain wrote: > On Tue, 13 Nov 2018, Russell King - ARM Linux wrote: > > > On Tue, Nov 13, 2018 at 02:39:00PM +1100, Finn Thain wrote: > > > > > > You could remove the old arch_gettimeoffset API without

Re: [PATCH] arm64: dts: marvell: armada_8k: reserve memory for ATF

2018-11-13 Thread Russell King - ARM Linux
On Tue, Nov 13, 2018 at 02:48:07PM +0100, Emmanuel Vadot wrote: > Like 4436a371 for 37xx, reserve the PSCI area memory region so kernels > can call the code there. > Region address is taken from the ATF code [1] and is 2MiB aligned. > > [1] plat/marvell/a8k/common/include/platform_def.h > >

Re: [PATCH] ARM: stm32: debug: add low-level debug support

2018-11-13 Thread Russell King - ARM Linux
On Tue, Nov 13, 2018 at 09:16:16AM +, Bich HEMON wrote: > > On 11/12/18 7:22 PM, Olof Johansson wrote: > > On Thu, Jul 27, 2017 at 04:50:20PM +, Bich HEMON wrote: > >> From: Gerald Baeza > >> > >> This adds low-level debug support on USART1 for STM32F4 > >> and STM32F7. > >> Compiled via

Re: [RFC PATCH 01/13] arm: Fix mutual exclusion in arch_gettimeoffset

2018-11-13 Thread Russell King - ARM Linux
On Tue, Nov 13, 2018 at 02:39:00PM +1100, Finn Thain wrote: > On Mon, 12 Nov 2018, Christoph Hellwig wrote: > > > On Mon, Nov 12, 2018 at 03:12:39PM +1100, Finn Thain wrote: > > > Implementations of arch_gettimeoffset are generally not re-entrant and > > > assume that interrupts have been

Re: [PATCH v6 5/9] dt-bindings: ARM: document marvell,ecc-enable binding

2018-11-09 Thread Russell King - ARM Linux
On Fri, Nov 09, 2018 at 12:40:06PM +0100, Arnd Bergmann wrote: > On Fri, Nov 9, 2018 at 8:04 AM Chris Packham > wrote: > > > > Add documentation for the marvell,ecc-enable and marvell,ecc-disable > > properties which can be used to enable/disable ECC on the Marvell aurora > > cache. > > > >

Re: linux-4.20-rc1/arch/arm/vfp/vfpmodule.c:576: possible cut'n'paste error

2018-11-06 Thread Russell King - ARM Linux
On Tue, Nov 06, 2018 at 04:29:54PM +, Julien Thierry wrote: > Hi Russel, David, > > On 06/11/18 16:20, Russell King - ARM Linux wrote: > >On Mon, Nov 05, 2018 at 01:53:13PM +, David Binderman wrote: > >>Hello there, > >> > >>2nd try. Plain

Re: linux-4.20-rc1/arch/arm/vfp/vfpmodule.c:576: possible cut'n'paste error

2018-11-06 Thread Russell King - ARM Linux
On Tue, Nov 06, 2018 at 04:33:26PM +, David Binderman wrote: > hello there Russell, > > > linux-4.20-rc1/arch/arm/vfp/vfpmodule.c:576]: (warning) Redundant > > assignment of >'ufp_exc->fpinst2' to itself. > > >Thanks for the report - it most certainly is a bug introduced by > >Julien's

Re: linux-4.20-rc1/arch/arm/vfp/vfpmodule.c:576: possible cut'n'paste error

2018-11-06 Thread Russell King - ARM Linux
On Mon, Nov 05, 2018 at 01:53:13PM +, David Binderman wrote: > Hello there, > > 2nd try. Plain text might help. Yep, Linux kernel development generally doesn't like wasteful html emails, sorry. > linux-4.20-rc1/arch/arm/vfp/vfpmodule.c:576]: (warning) Redundant assignment > of

Re: [PATCH v2] ARM:kexec:offline panic_smp_self_stop CPU

2018-11-02 Thread Russell King - ARM Linux
On Fri, Nov 02, 2018 at 10:31:27AM +0800, wangyufen wrote: > In case panic() and panic() called at the same time on different CPUS. > For example: > CPU 0: > panic() > __crash_kexec >machine_crash_shutdown > crash_smp_send_stop >machine_kexec >

Re: [PATCH] ARM:kexec:offline panic_smp_self_stop CPU

2018-11-01 Thread Russell King - ARM Linux
On Thu, Nov 01, 2018 at 07:20:49PM +0800, Wang Yufen wrote: > From: Yufen Wang > > In case panic() and panic() called at the same time on different CPUS. > For example: > CPU 0: > panic() > __crash_kexec >machine_crash_shutdown > crash_smp_send_stop >machine_kexec

Re: [PATCH 4/6] of/fdt: Populate phys_initrd_start/phys_initrd_size from FDT

2018-10-30 Thread Russell King - ARM Linux
On Mon, Oct 29, 2018 at 04:52:04PM -0700, Florian Fainelli wrote: > If the architecture implements ARCH_HAS_PHYS_INITRD, make the FDT > scanning code populate the physical address of the start of the FDT and > its size. > > Signed-off-by: Florian Fainelli > --- > arch/arm/mm/init.c | 2 +- >

Re: [PATCH] arm: mm: fault: check ADFSR in case of abort

2018-10-29 Thread Russell King - ARM Linux
On Mon, Oct 29, 2018 at 03:54:36PM +, Mark Rutland wrote: > On Mon, Oct 29, 2018 at 02:20:51PM +, Wiebe, Wladislav (Nokia - DE/Ulm) > wrote: > > When running into situations like: > > "Unhandled fault: synchronous external abort (0x210) at 0xXXX" > > or > > "Unhandled prefetch abort:

Re: [PATCH] arm: mm: fault: check ADFSR in case of abort

2018-10-29 Thread Russell King - ARM Linux
On Mon, Oct 29, 2018 at 02:20:51PM +, Wiebe, Wladislav (Nokia - DE/Ulm) wrote: > When running into situations like: > "Unhandled fault: synchronous external abort (0x210) at 0xXXX" > or > "Unhandled prefetch abort: synchronous external abort (0x210) at 0xXXX" > it is useful to know the

Re: [PATCH] ARM: mm: Facilitate debugging CONFIG_KUSER_HELPERS disabled

2018-10-25 Thread Russell King - ARM Linux
On Fri, Oct 26, 2018 at 12:00:09AM +0530, Souptick Joarder wrote: > On Thu, Oct 25, 2018 at 11:40 PM Florian Fainelli > wrote: > > > > Some software such as perf makes unconditional use of the special > > [vectors] page which is only provided when CONFIG_KUSER_HELPERS is > > enabled in the

Re: [PATCH 2/2] perf tests: Add a test for the ARM 32-bit [vectors] page

2018-10-25 Thread Russell King - ARM Linux
On Thu, Oct 25, 2018 at 10:53:12AM -0700, Florian Fainelli wrote: > Something like this below? It does not have to be an alternative > solution, I would find it useful for perf to make sure the vectors page > is present in the virtual address space by having an explicit test. perf > maintains,

Re: [PATCH 2/2] perf tests: Add a test for the ARM 32-bit [vectors] page

2018-10-25 Thread Russell King - ARM Linux
On Thu, Oct 25, 2018 at 10:19:54AM -0700, Florian Fainelli wrote: > On 10/24/18 7:10 PM, Andrew Lunn wrote: > > On Wed, Oct 24, 2018 at 05:09:05PM -0700, Florian Fainelli wrote: > >> perf on ARM requires CONFIG_KUSER_HELPERS to be turned on to allow some > >> independance with respect to the ARM

Re: [PATCH v3 1/3] of/fdt: Absorb ARM64's __early_init_dt_declare_initrd()

2018-10-25 Thread Russell King - ARM Linux
On Thu, Oct 25, 2018 at 08:25:04AM -0500, Rob Herring wrote: > On Wed, Oct 24, 2018 at 7:17 PM Florian Fainelli wrote: > > > > ARM64 is the only architecture that requires a re-definition of > > __early_init_dt_declare_initrd(), absorb its custom implemention in > > drivers/of/fdt.c. > > > >

Re: [PATCH 1/2] mm/zsmalloc.c: check encoded object value overflow for PAE

2018-10-25 Thread Russell King - ARM Linux
On Thu, Oct 25, 2018 at 09:37:59AM -0300, Rafael David Tinoco wrote: > Is it okay to propose using only MAX_PHYSMEM_BITS for zsmalloc (like > it was before commit 02390b87) instead, and make sure *at least* ARM > 32/64 and x86/x64, for now, have it defined outside sparsemem headers > as well ? It

Re: [PATCH 1/2] mm/zsmalloc.c: check encoded object value overflow for PAE

2018-10-25 Thread Russell King - ARM Linux
On Wed, Oct 24, 2018 at 10:27:44PM -0300, Rafael David Tinoco wrote: > On 32-bit systems, zsmalloc uses HIGHMEM and, when PAE is enabled, the > physical frame number might be so big that zsmalloc obj encoding (to > location) will break IF architecture does not re-define > MAX_PHYSMEM_BITS,

Re: [PATCH] i2c: cadence: Implement timeout

2018-10-24 Thread Russell King - ARM Linux
On Wed, Oct 24, 2018 at 04:20:03PM +0530, shubhrajyoti.da...@gmail.com wrote: > From: Shubhrajyoti Datta > > In some cases we are waiting in a loop. Replace the infinite wait with > the timeout. > > Signed-off-by: Shubhrajyoti Datta > --- > drivers/i2c/busses/i2c-cadence.c | 30

Re: [PATCH v3 0/7] include: add setbits32/clrbits32/clrsetbits32/setbits64/clrbits64/clrsetbits64

2018-10-24 Thread Russell King - ARM Linux
On Wed, Oct 24, 2018 at 07:35:46AM +, Corentin Labbe wrote: > This patchset adds a new set of functions which are open-coded in lot of > place. > Basicly the pattern is always the same, "read, modify a bit, write" > some driver and the powerpc arch already have thoses pattern them as >

Re: [PATCH v2 1/3] ARM: socfpga: Clean unused functions

2018-10-23 Thread Russell King - ARM Linux
On Tue, Oct 23, 2018 at 10:47:05AM +0200, Clément Péron wrote: > Hi Dinh / Russell, > > Could you have a look at these patchs please ? Nothing to do with me - it's up to the socfpga maintainer and arm-soc maintainers. > Thanks, > Clement > > On Tue, 9 Oct 2018 at 13:20, Clément Péron wrote: >

Re: [PATCH] arm: kernel: add support for detecting armv8 cpu cache information

2018-10-18 Thread Russell King - ARM Linux
On Thu, Oct 18, 2018 at 02:16:47PM +0800, Teng Fei Fan wrote: > This patch adds support for cacheinfo on 32bit ARMv8 platform. > Add support for detecting cpu cache information cpu cache information > via sysfs for 32bit armv8 platform. And export to sysfs then userspace > can get from

Re: [PATCH 1/3] driver core: add probe_err log helper

2018-10-17 Thread Russell King - ARM Linux
On Tue, Oct 16, 2018 at 04:55:00PM +0300, Andy Shevchenko wrote: > On Tue, Oct 16, 2018 at 3:55 PM Andrzej Hajda wrote: > > On 16.10.2018 13:29, Andrzej Hajda wrote: > > > On 16.10.2018 13:01, Andy Shevchenko wrote: > > >> On Tue, Oct 16, 2018 at 10:22 AM Andrzej Hajda > > >> wrote: > > >>>

Re: [PATCH] [ALTERNATIVE] ARM: fix copypage functions for clang

2018-10-17 Thread Russell King - ARM Linux
On Wed, Oct 17, 2018 at 11:04:17AM +0200, Arnd Bergmann wrote: > The constraints were originally added in commit 9a40ac86152c ("ARM: > 6164/1: Add kto and kfrom to input operands list.") as a gcc-4.5 > workaround. Another workaround for the same problem was added in commit > 9c695203a7dd

Re: [PATCH 1/2] ARM: copypage-fa: add kto and kfrom to input operands list

2018-10-16 Thread Russell King - ARM Linux
On Tue, Oct 16, 2018 at 10:00:19AM +0200, Linus Walleij wrote: > On Tue, Oct 16, 2018 at 12:16 AM Stefan Agner wrote: > > > When functions incoming parameters are not in input operands list gcc > > 4.5 does not load the parameters into registers before calling this > > function but the inline

Re: [PATCH 2/2] ARM: copypage: do not use naked functions

2018-10-16 Thread Russell King - ARM Linux
On Mon, Oct 15, 2018 at 07:27:43PM -0400, Nicolas Pitre wrote: > It's hard to see what that commit was actually fixing, but the operands > usage is wrong as explained already. Maybe the generated code has been > OK for all those years but that is due to luck rather than correctness. ... > No

Re: [PATCH 1/2] ARM: copypage-fa: add kto and kfrom to input operands list

2018-10-15 Thread Russell King - ARM Linux
On Tue, Oct 16, 2018 at 12:52:58AM +0200, Stefan Agner wrote: > On 16.10.2018 00:46, Russell King - ARM Linux wrote: > > On Tue, Oct 16, 2018 at 12:39:54AM +0200, Stefan Agner wrote: > >> On 16.10.2018 00:23, Russell King - ARM Linux wrote: > >> > On Tue, Oct 16, 20

Re: [PATCH 2/2] ARM: copypage: do not use naked functions

2018-10-15 Thread Russell King - ARM Linux
On Mon, Oct 15, 2018 at 06:54:49PM -0400, Nicolas Pitre wrote: > On Mon, 15 Oct 2018, Russell King - ARM Linux wrote: > > > On Mon, Oct 15, 2018 at 06:35:33PM -0400, Nicolas Pitre wrote: > > > On Tue, 16 Oct 2018, Stefan Agner wrote: > > > > > > > GCC

Re: [PATCH 1/2] ARM: copypage-fa: add kto and kfrom to input operands list

2018-10-15 Thread Russell King - ARM Linux
On Tue, Oct 16, 2018 at 12:39:54AM +0200, Stefan Agner wrote: > On 16.10.2018 00:23, Russell King - ARM Linux wrote: > > On Tue, Oct 16, 2018 at 12:16:29AM +0200, Stefan Agner wrote: > >> When functions incoming parameters are not in input operands list gcc > >> 4.5 d

Re: [PATCH 2/2] ARM: copypage: do not use naked functions

2018-10-15 Thread Russell King - ARM Linux
On Mon, Oct 15, 2018 at 06:35:33PM -0400, Nicolas Pitre wrote: > On Tue, 16 Oct 2018, Stefan Agner wrote: > > > GCC documentation says naked functions should only use basic ASM > > syntax. The extended ASM or mixture of basic ASM and "C" code is > > not guaranteed. Currently it seems to work

Re: [PATCH 1/2] ARM: copypage-fa: add kto and kfrom to input operands list

2018-10-15 Thread Russell King - ARM Linux
On Tue, Oct 16, 2018 at 12:16:29AM +0200, Stefan Agner wrote: > When functions incoming parameters are not in input operands list gcc > 4.5 does not load the parameters into registers before calling this > function but the inline assembly assumes valid addresses inside this > function. This breaks

Re: [PATCH v7] regulator: fixed: Convert to use GPIO descriptor only

2018-10-12 Thread Russell King - ARM Linux
On Fri, Oct 12, 2018 at 11:43:13AM +, Marcel Ziswiler wrote: > I don't think it is that fictitious as it makes it crystal clear that > there is something shared with all its pros and cons. E.g. what happens > if one of them regulators wants to turn off while the other one still > needs power?

Re: [PATCH v7] regulator: fixed: Convert to use GPIO descriptor only

2018-10-12 Thread Russell King - ARM Linux
On Fri, Oct 12, 2018 at 11:39:15AM +0100, Jon Hunter wrote: > We had the same situation for Tegra124 Jetson TK1 but I don't think that > adding a pseudo intermediate regulator is cleaner. If the GPIO controls > more than one regulator, I don't see why is it necessary to change the > DT. There are

Re: [Question] directory for SoC-related DT binding

2018-10-10 Thread Russell King - ARM Linux
On Wed, Oct 10, 2018 at 02:04:14PM +0200, Stefan Wahren wrote: > Hi, > > Am 10.10.2018 um 13:19 schrieb Rob Herring: > > On Wed, Oct 10, 2018 at 6:08 AM Masahiro Yamada > > wrote: > >> Hi, > >> > >> > >> I see a bunch of vendor (or SoC) names in > >> Documentation/device/bindings/arm/ > >> > >>

Re: [Question] directory for SoC-related DT binding

2018-10-10 Thread Russell King - ARM Linux
On Wed, Oct 10, 2018 at 08:07:52PM +0900, Masahiro Yamada wrote: > Hi, > > > I see a bunch of vendor (or SoC) names in > Documentation/device/bindings/arm/ > > ./Documentation/devicetree/bindings/arm/altera > ./Documentation/devicetree/bindings/arm/amlogic >

Re: [PATCH] Doc: lockdep: add information about performance impact

2018-10-10 Thread Russell King - ARM Linux
On Tue, Oct 09, 2018 at 04:58:18PM +0100, Will Deacon wrote: > On Tue, Oct 09, 2018 at 05:43:59PM +0200, Peter Zijlstra wrote: > > On Tue, Oct 09, 2018 at 05:39:27PM +0200, Lukasz Luba wrote: > > > This patch add some warning related to performance drop. > > > It should be mentioned that this is

Re: [PATCH] traps:Recover undefined user instruction on ARM

2018-10-05 Thread Russell King - ARM Linux
On Fri, Oct 05, 2018 at 10:15:57AM +0530, Manjeet Pawar wrote: > From: Rohit Thapliyal > > During user undefined instruction exception, the arm exception > handler currently results in application crash through SIGILL. > The bad instruction can be due to ddr/hardware issue. > For such cases,

Re: [RFC 1/2] reboot: Make restart_handler_list a blocking notifier chain.

2018-10-05 Thread Russell King - ARM Linux
On Fri, Oct 05, 2018 at 10:27:48AM +0200, Nicolas Cavallari wrote: > On 04/10/2018 18:49, Russell King - ARM Linux wrote: > > This isn't going to work. > > > > For example, sysrq processing (which can happen in IRQ context) calls > > emergency_restart() for the reboot

Re: [RFC 1/2] reboot: Make restart_handler_list a blocking notifier chain.

2018-10-04 Thread Russell King - ARM Linux
On Thu, Oct 04, 2018 at 06:23:38PM +0200, Nicolas Cavallari wrote: > Many users of restart_handlers are sleeping in their callbacks. Some > are doing infinite loops or calling driver code that may sleep or > perform operation on slow busses, like i2c. > > This is not allowed in an atomic

Re: [PATCH v2] mm: Introduce new function vm_insert_kmem_page

2018-10-04 Thread Russell King - ARM Linux
On Thu, Oct 04, 2018 at 05:45:13PM +0530, Souptick Joarder wrote: > On Thu, Oct 4, 2018 at 3:45 AM Russell King - ARM Linux > wrote: > > > > On Wed, Oct 03, 2018 at 01:00:03PM -0700, Matthew Wilcox wrote: > > > On Thu, Oct 04, 2018 at 12:28:54AM +0

Re: [PATCH 3/3] ARM: socfpga: Turn on ARM errata for L2 cache

2018-10-04 Thread Russell King - ARM Linux
On Thu, Oct 04, 2018 at 10:54:15AM +0200, Clément Péron wrote: > From: Dinh Nguyen > > Turn on these ARM and PL310 errata for SoCFPGA: > > ARM_ERRATA_754322 > ARM_ERRATA_764369 > ARM_ERRATA_775420 > > PL310_ERRATA_588369 > PL310_ERRATA_727915 > PL310_ERRATA_753970 > PL310_ERRATA_769419 > >

Re: RESEND and REBASE arm+arm64+aarch32 vdso rewrite

2018-10-02 Thread Russell King - ARM Linux
On Mon, Oct 01, 2018 at 01:44:52PM -0700, Mark Salyzyn wrote: > Despite the gain of 0.4% for screen-on battery life, where Android has a mix > of 64 and 32 bit applications, thus still relevant _today_ on 64 bit > architectures (providing vDSO32 for 32-bit applications). I don't think the issue

Re: [PATCH] ARM: makefile: pass -march=armv4 to assembler even on CPU32v3

2018-10-01 Thread Russell King - ARM Linux
On Mon, Oct 01, 2018 at 08:10:26PM +0200, Ard Biesheuvel wrote: > On 1 October 2018 at 19:56, Russell King - ARM Linux > wrote: > > On Sun, Sep 30, 2018 at 04:49:04AM +0200, Jason A. Donenfeld wrote: > >> Per the discussion about half-way down in [1], the kernel doesn't

Re: [PATCH] ARM: makefile: pass -march=armv4 to assembler even on CPU32v3

2018-10-01 Thread Russell King - ARM Linux
On Sun, Sep 30, 2018 at 04:49:04AM +0200, Jason A. Donenfeld wrote: > Per the discussion about half-way down in [1], the kernel doesn't > actually support the ARMv3 ISA, but selects it for some ARMv4 ISA > hardware that benefits from ARMv3 code generation. The issue is to do with the half-word

Re: [PATCH] ARM: disable ARMv6 for Clang older than 8.0

2018-10-01 Thread Russell King - ARM Linux
On Sun, Sep 30, 2018 at 04:48:20PM -0700, Joe Perches wrote: > On Mon, 2018-10-01 at 00:22 +0200, Stefan Agner wrote: > > The kernel passes the ArmV6K architecture to the compiler when > > using the multi platform selection and enabling ARMv6. Clang > > older than version 8.0 emit assembly with an

Re: [BUG] sleep in atomic in 8250 runtime PM code path

2018-09-29 Thread Russell King - ARM Linux
On Sat, Sep 29, 2018 at 01:20:36PM +0800, Jisheng Zhang wrote: > Hi, > > Recently I found I could trigger sleep in atomic bug on berlin after commit > d76c74387e1c ("serial: 8250_dw: Fix runtime PM handling"). The path looks > like: > > dw8250_probe => serial850_register_8250_port =>

Re: [BISECTED] Regression: Solidrun Clearfog Base won't boot since "PCI: mvebu: Only remap I/O space if configured"

2018-09-24 Thread Russell King - ARM Linux
On Mon, Sep 24, 2018 at 12:26:14PM +0200, Thomas Petazzoni wrote: > Hello, > > On Mon, 24 Sep 2018 11:12:13 +0100, Russell King - ARM Linux wrote: > > > > Thanks for the testing. I'll wait for Russell to say if he is happy > > > (or not) with the addition of

Re: [BISECTED] Regression: Solidrun Clearfog Base won't boot since "PCI: mvebu: Only remap I/O space if configured"

2018-09-24 Thread Russell King - ARM Linux
On Thu, Sep 13, 2018 at 10:42:41AM +0200, Thomas Petazzoni wrote: > Hello, > > On Thu, 13 Sep 2018 10:20:45 +0200, Jan Kundrát wrote: > > On čtvrtek 13. září 2018 9:45:15 CEST, Thomas Petazzoni wrote: > > > What about something like the below. I tested it, including the error > > > case by

Re: [PATCH] ARM: add serial.h and set BASE_BAUD to 0

2018-09-21 Thread Russell King - ARM Linux
On Thu, Sep 20, 2018 at 10:13:57PM +0200, Rafał Miłecki wrote: > From: Rafał Miłecki > > For years arm has been using serial.h from asm-generic which sets > BASE_BAUD value to the (1843200 / 16). This is incorrect as: > 1) This value obviously isn't correct for all devices > 2) There are no

Re: [BISECTED] Regression: Solidrun Clearfog Base won't boot since "PCI: mvebu: Only remap I/O space if configured"

2018-09-12 Thread Russell King - ARM Linux
On Wed, Sep 12, 2018 at 09:49:41PM +0300, Baruch Siach wrote: > I reproduced the same Oops on Clearfog Base without any taint: > > [1.476401] Internal error: Oops - undefined instruction: 0 [#1] SMP ARM ... > [1.855954] Code: e2844004 e5972000 e352 0aee (e7f001f2) That is a

Re: [PATCH 1/3] ARM: dts: NSP: Enable SFP on bcm958625hr

2018-08-27 Thread Russell King - ARM Linux
On Mon, Aug 27, 2018 at 01:03:42PM -0700, Florian Fainelli wrote: > Enable the SFP connected to port 5 of the switch and wire up all GPIOs > to the SFP cage. Because of a hardware limitation of the i2c controller > on the iProc SoCs which prevents large i2c (> 256 bytes) transactions to > work, we

Re: [PATCH] ARM: drop experimental mark for ARM stack unwinding

2018-08-11 Thread Russell King - ARM Linux
On Sat, Aug 11, 2018 at 12:31:27PM +0200, Stefan Agner wrote: > ARM stack unwinding is upstream since 2009 and has been proven > working well. At this time it is the preferred stack unwinding > support since it also supports Thumb 2. Do not scare people > and drop the EXPERIMENTAL mark. Actually,

Re: [PATCH v3 7/8] net: phy: Add support to configure clock in Broadcom iProc mdio mux

2018-08-01 Thread Russell King - ARM Linux
On Wed, Aug 01, 2018 at 10:07:12PM +0200, Andrew Lunn wrote: > You might want to consider adding clk_optional_get() and > devm_clk_optional_get(). I think there's attempts to add such APIs but I don't think it's trivial - it seems to require a _lot_ of discussion. I think part of that is because

Re: [PATCH 6/6] arm64: enable RapidIO menu in Kconfig

2018-08-01 Thread Russell King - ARM Linux
On Tue, Jul 31, 2018 at 04:01:27PM -0400, Alex Bounine wrote: > On 2018-07-31 02:18 PM, Russell King - ARM Linux wrote: > >On Tue, Jul 31, 2018 at 01:59:27PM -0400, Alex Bounine wrote: > >>On 2018-07-31 11:52 AM, Russell King - ARM Linux wrote: > >>>On Tue, Jul 31,

Re: [PATCH 6/6] arm64: enable RapidIO menu in Kconfig

2018-07-31 Thread Russell King - ARM Linux
On Tue, Jul 31, 2018 at 01:59:27PM -0400, Alex Bounine wrote: > On 2018-07-31 11:52 AM, Russell King - ARM Linux wrote: > >On Tue, Jul 31, 2018 at 08:54:14AM -0400, Alex Bounine wrote: > >>On 2018-07-31 04:41 AM, Will Deacon wrote: > >>>On Mon, Jul 30, 2018 at 06:50:

Re: [PATCH 6/6] arm64: enable RapidIO menu in Kconfig

2018-07-31 Thread Russell King - ARM Linux
On Tue, Jul 31, 2018 at 08:54:14AM -0400, Alex Bounine wrote: > On 2018-07-31 04:41 AM, Will Deacon wrote: > >On Mon, Jul 30, 2018 at 06:50:34PM -0400, Alexei Colin wrote: > >>Platforms with a PCI bus will be offered the RapidIO menu since they may > >>be want support for a RapidIO PCI device.

Re: [PATCH 5/6] arm: enable RapidIO menu in Kconfig

2018-07-31 Thread Russell King - ARM Linux
On Tue, Jul 31, 2018 at 08:43:02AM -0400, Alex Bounine wrote: > On 2018-07-31 08:04 AM, Christoph Hellwig wrote: > >On Mon, Jul 30, 2018 at 06:50:33PM -0400, Alexei Colin wrote: > >>diff --git a/arch/arm/Kconfig b/arch/arm/Kconfig > >>index afe350e5e3d9..602a61324890 100644 > >>---

Re: [PATCH] PCI: let pci_request_irq properly deal with threaded interrupts

2018-07-31 Thread Russell King - ARM Linux
On Tue, Jul 31, 2018 at 12:50:21AM +0200, Thomas Gleixner wrote: > On Mon, 30 Jul 2018, Bjorn Helgaas wrote: > > > [+cc maintainers of possibly erroneous callers of request_threaded_irq()] > > > > On Mon, Jul 30, 2018 at 04:30:28PM -0500, Bjorn Helgaas wrote: > > > [+cc Thomas, Christoph, LKML]

Re: [PATCH][RESEND 2] component: enhance handling of devres group for master

2018-07-26 Thread Russell King - ARM Linux
On Wed, Jul 25, 2018 at 11:06:28PM -0700, bgosw...@codeaurora.org wrote: > From: Banajit Goswami > > The devres group opened for a master is left open-ended (without > devres_group_close) even after bind() is complete. Similarly, while > releasing the devres resources for master, the most

Re: [PATCH] arm: enable RapidIO config options in Kconfig

2018-07-24 Thread Russell King - ARM Linux
On Tue, Jul 24, 2018 at 09:41:26AM -0400, Alexei Colin wrote: > ARM SoCs with a PCI bus offer the RapiodIO config menu; SoCs with > RapidIO IP blocks but without a PCI bus, need to add "select > HAS_RAPIDIO" to the Kconfig entry for that SoC (e.g. ARCH_*). > > HAS_RAPIDIO was chosen over

Re: Enquiry on unbalanced memory throughput for dual-Cortex A9 core.

2018-07-20 Thread Russell King - ARM Linux
On Fri, Jul 20, 2018 at 08:49:47AM +, Ooi, Tzy Way wrote: > Hi Russell, > > I am trying the memory write operation with the LM benchmark test. I > tried to execute the memory write operation here > > twice to get both Cortex A9

Re: [PATCH] ARM64: smp: Fix cpu_up() racing with sys_reboot

2018-07-19 Thread Russell King - ARM Linux
On Thu, Jul 19, 2018 at 03:18:46PM -0700, Venkata Narendra Kumar Gutta wrote: > Nothing stops a process from hotplugging in a CPU concurrently > with a sys_reboot() call. In such a situation we could have > ipi_cpu_stop() mark a cpu as 'offline' and _cpu_up() ignore the > fact that the CPU is not

  1   2   3   4   5   6   7   8   9   10   >