Re: linux-next: build failures after merge of the drm tree

2014-08-10 Thread Sachin Kamat
On Sun, Aug 10, 2014 at 1:28 PM, Dave Airlie airl...@linux.ie wrote: Been on holidays, but ack for anything DT related, Look I wishI knew how DT worked, and what tree is canonical for changes to it, I'm not sure its well defined enough or sub maintaniers know enough, so I do just trust the

Re: [PATCH RESEND] usb: ehci/ohci-exynos: Fix PHY getting sequence

2014-08-05 Thread Sachin Kamat
the issue with ehci-exynos and ohci-exynos, wherein in the absence of SAMSUNG_USB2PHY config symbol, we end up getting the NOP_USB_XCEIV phy when the same is enabled. And thus the PHYs are not configured properly. Reported-by: Sachin Kamat sachin.ka...@samsung.com Signed-off-by: Vivek Gautam

Re: [PATCH] Input: soc_button_array: Remove kfree on data allocated with devm_zalloc

2014-07-25 Thread Sachin Kamat
was missing and renames a lable from err_free_mem to err_mem. - Adds couple of dev_err on failure to allocate memory CC: Dmitry Torokhov dmitry.torok...@gmail.com CC: Lejun Zhu lejun@linux.intel.com CC: Sachin Kamat sachin.ka...@linaro.org Signed-off-by: Pramod Gurav pramod.gu...@smartplayin.com

Re: [PATCH v2] Input: soc_button_array: Remove kfree on data allocated with devm_zalloc

2014-07-25 Thread Sachin Kamat
which was missing - Removes the error lables and instead releases resources and returns after failures CC: Dmitry Torokhov dmitry.torok...@gmail.com CC: Lejun Zhu lejun@linux.intel.com CC: Sachin Kamat sachin.ka...@linaro.org Signed-off-by: Pramod Gurav pramod.gu...@smartplayin.com

Re: [PATCH 1/1] MAINTAINERS: Update Samsung pin control entry

2014-07-25 Thread Sachin Kamat
On Fri, Jul 11, 2014 at 3:41 PM, Tomasz Figa t.f...@samsung.com wrote: On 11.07.2014 11:57, Sachin Kamat wrote: + Tomasz Sorry for missing the maintainer himself :) On Fri, Jul 11, 2014 at 2:29 PM, Sachin Kamat sachin.ka...@samsung.com wrote: Update to reflect the recent file movement

[PATCH Resend 2/2] mfd: tps65912-spi: Remove unused variable

2014-07-18 Thread Sachin Kamat
‘rx_buf’ is not used in this function. Signed-off-by: Sachin Kamat sachin.ka...@samsung.com --- drivers/mfd/tps65912-spi.c |3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) diff --git a/drivers/mfd/tps65912-spi.c b/drivers/mfd/tps65912-spi.c index 69a5178bf152..de60ad98bd9f 100644

[PATCH 1/2 Resend] mfd: htc-i2cpld: Remove unused code

2014-07-18 Thread Sachin Kamat
Removed code unused in this function. Signed-off-by: Sachin Kamat sachin.ka...@samsung.com Cc: Cory Maccarrone darkstar6...@gmail.com --- Compile tested. --- drivers/mfd/htc-i2cpld.c |5 - 1 file changed, 5 deletions(-) diff --git a/drivers/mfd/htc-i2cpld.c b/drivers/mfd/htc-i2cpld.c

Re: [PATCH 1/4 v2] iio: exyno-adc: use syscon for PMU register access

2014-07-17 Thread Sachin Kamat
Hi Naveen, On Thu, Jul 17, 2014 at 4:49 PM, Naveen Krishna Chatradhi ch.nav...@samsung.com wrote: This patch updates the IIO based ADC driver to use syscon and regmap APIs to access and use PMU registers instead of remapping the PMU registers in the driver. Signed-off-by: Naveen Krishna

Re: [PATCH v2 1/2] phy: Kconfig: Re-organize Exynos USB 2.0 PHY configs

2014-07-14 Thread Sachin Kamat
Hi, On Mon, Jul 14, 2014 at 2:26 PM, Kishon Vijay Abraham I kis...@ti.com wrote: Hi, On Wednesday 09 July 2014 05:19 PM, Sachin Kamat wrote: Since the USB 2.0 PHYs are required with EHCI/OHCI USB drivers and USB gadget controller supported by the DWC2 gadget driver, make it depend on them

Re: [PATCH v2 1/2] phy: Kconfig: Re-organize Exynos USB 2.0 PHY configs

2014-07-14 Thread Sachin Kamat
On Mon, Jul 14, 2014 at 2:32 PM, Kishon Vijay Abraham I kis...@ti.com wrote: On Monday 14 July 2014 02:29 PM, Sachin Kamat wrote: Hi, On Mon, Jul 14, 2014 at 2:26 PM, Kishon Vijay Abraham I kis...@ti.com wrote: Hi, On Wednesday 09 July 2014 05:19 PM, Sachin Kamat wrote: Since the USB

Re: [PATCH v2 1/2] phy: Kconfig: Re-organize Exynos USB 2.0 PHY configs

2014-07-14 Thread Sachin Kamat
On Mon, Jul 14, 2014 at 2:39 PM, Kishon Vijay Abraham I kis...@ti.com wrote: On Monday 14 July 2014 02:36 PM, Sachin Kamat wrote: On Mon, Jul 14, 2014 at 2:32 PM, Kishon Vijay Abraham I kis...@ti.com wrote: On Monday 14 July 2014 02:29 PM, Sachin Kamat wrote: Hi, On Mon, Jul 14, 2014

[PATCH 2/2] phy: Kconfig: Update config for Exynos USB DRD

2014-07-14 Thread Sachin Kamat
USB DWC3 driver on Exynos platform does not work without its corresponding phy driver. Hence make the PHY driver depend on Exynos DWC3 driver and default it to yes to make things easier for the end user. Signed-off-by: Sachin Kamat sachin.ka...@samsung.com Reviewed-by: Jingoo Han jg1

[PATCH v3 1/2] phy: Kconfig: Re-organize Exynos USB 2.0 PHY configs

2014-07-14 Thread Sachin Kamat
that they are meant to work with. This will make life easier for end users who do not have any way knowing the dependencies. Signed-off-by: Sachin Kamat sachin.ka...@samsung.com Reviewed-by: Jingoo Han jg1@samsung.com --- Changes since v3: * Rebased the series on top of latest PHY tree [1]. [1

Re: [PATCH 12/16] i2c: i2c-s3c2410: Drop class based scanning to improve bootup time

2014-07-11 Thread Sachin Kamat
; + i2c-adap.class = I2C_CLASS_DEPRECATED; + i2c-tx_setup = 50; init_waitqueue_head(i2c-wait); -- Tested on Exynos 5250 boards. Tested-by: Sachin Kamat sachin.ka...@samsung.com -- Regards, Sachin. -- To unsubscribe from this list: send the line unsubscribe linux-kernel in the body

[PATCH 1/1] MAINTAINERS: Update Samsung pin control entry

2014-07-11 Thread Sachin Kamat
Update to reflect the recent file movement to a sub-directory. Signed-off-by: Sachin Kamat sachin.ka...@samsung.com --- MAINTAINERS |4 +--- 1 file changed, 1 insertion(+), 3 deletions(-) diff --git a/MAINTAINERS b/MAINTAINERS index e3a517635eb4..898cf76f8837 100644 --- a/MAINTAINERS +++ b

Re: [PATCH 2/4] Documentation: dt-bindings: move exynos-adc.txt to more iio/adc/

2014-07-11 Thread Sachin Kamat
Hi Naveen, On Fri, Jul 11, 2014 at 2:36 PM, Naveen Krishna Chatradhi ch.nav...@samsung.com wrote: The DT bindings in exynos-adc.txt applies to the ADC driver (exynos-adc.c) developed based on IIO framework. The bindings are more appropriate to be under

Re: [PATCH 1/1] MAINTAINERS: Update Samsung pin control entry

2014-07-11 Thread Sachin Kamat
+ Tomasz Sorry for missing the maintainer himself :) On Fri, Jul 11, 2014 at 2:29 PM, Sachin Kamat sachin.ka...@samsung.com wrote: Update to reflect the recent file movement to a sub-directory. Signed-off-by: Sachin Kamat sachin.ka...@samsung.com --- MAINTAINERS |4 +--- 1 file

[PATCH 1/1] mfd: htc-i2cpld: Remove unused code

2014-07-11 Thread Sachin Kamat
Removed code unused in this function. Signed-off-by: Sachin Kamat sachin.ka...@samsung.com --- Compile tested. --- drivers/mfd/htc-i2cpld.c |5 - 1 file changed, 5 deletions(-) diff --git a/drivers/mfd/htc-i2cpld.c b/drivers/mfd/htc-i2cpld.c index d7b2a75aca3e..b44f0203983b 100644

[PATCH 1/1] mfd: tps65912-spi: Remove unused variable

2014-07-11 Thread Sachin Kamat
‘rx_buf’ is not used in this function. Signed-off-by: Sachin Kamat sachin.ka...@samsung.com --- drivers/mfd/tps65912-spi.c |3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) diff --git a/drivers/mfd/tps65912-spi.c b/drivers/mfd/tps65912-spi.c index 69a5178bf152..de60ad98bd9f 100644

[PATCH 1/1] pinctrl: samsung: Group all drivers in a sub-dir

2014-07-10 Thread Sachin Kamat
Group all pin control drivers of Samsung platform together in a sub-directory for easy maintenance. Signed-off-by: Sachin Kamat sachin.ka...@samsung.com --- This patch has been inspired by a similar patch [1] from Linus Walleij for Qualcomm drivers. I have boot tested this patch on Exynos boards

[PATCH v2 2/2] phy: Kconfig: Update config for Exynos USB DRD

2014-07-09 Thread Sachin Kamat
USB DWC3 driver on Exynos platform does not work without its corresponding phy driver. Hence make the PHY driver depend on Exynos DWC3 driver and default it to yes to make things easier for the end user. Signed-off-by: Sachin Kamat sachin.ka...@samsung.com --- No changes since v1. --- drivers

[PATCH v2 1/2] phy: Kconfig: Re-organize Exynos USB 2.0 PHY configs

2014-07-09 Thread Sachin Kamat
that they are meant to work with. This will make life easier for end users who do not have any way knowing the dependencies. Signed-off-by: Sachin Kamat sachin.ka...@samsung.com --- Changes since v1: * Added dependency on DWC2 gadget driver as suggested by Tomasz Figa. --- drivers/phy/Kconfig

Re: [PATCH 1/3] usb: usb3503: fix build warning

2014-07-09 Thread Sachin Kamat
Hi Joonyoung, On Thu, Jul 10, 2014 at 9:53 AM, Joonyoung Shim jy0922.s...@samsung.com wrote: This fixes below build warning. drivers/usb/misc/usb3503.c: In function ‘usb3503_probe’: drivers/usb/misc/usb3503.c:195:11: warning: ‘err’ may be used uninitialized in this function

Re: [PATCH 1/1] ARM: imx: use PTR_ERR_OR_ZERO

2014-07-08 Thread Sachin Kamat
On Tue, Jul 8, 2014 at 10:49 AM, Shawn Guo shawn@freescale.com wrote: On Tue, Jul 08, 2014 at 09:18:56AM +0530, Sachin Kamat wrote: Hi Shawn, On Mon, Jul 7, 2014 at 11:25 AM, Shawn Guo shawn@freescale.com wrote: On Fri, Jul 04, 2014 at 09:03:10PM +0200, Fabian Frederick wrote

Re: [PATCH 1/2] phy: Kconfig: Re-organize Exynos USB 2.0 PHY configs

2014-07-08 Thread Sachin Kamat
Hi Tomasz, On Tue, Jul 8, 2014 at 9:15 PM, Tomasz Figa t.f...@samsung.com wrote: On 30.06.2014 10:56, Sachin Kamat wrote: Since the USB 2.0 PHYs are required only with EHCI/OHCI USB drivers, That's not true. They are also required for USB gadget controller supported by the DWC2 gadget driver

Re: [PATCH 1/1] ARM: imx: use PTR_ERR_OR_ZERO

2014-07-07 Thread Sachin Kamat
Hi Shawn, On Mon, Jul 7, 2014 at 11:25 AM, Shawn Guo shawn@freescale.com wrote: On Fri, Jul 04, 2014 at 09:03:10PM +0200, Fabian Frederick wrote: replace IS_ERR/PTR_ERR Cc: Shawn Guo shawn@freescale.com Cc: Sascha Hauer ker...@pengutronix.de Cc: linux-arm-ker...@lists.infradead.org

Re: [PATCH 1/2] phy: Kconfig: Re-organize Exynos USB 2.0 PHY configs

2014-07-07 Thread Sachin Kamat
On Mon, Jun 30, 2014 at 2:26 PM, Sachin Kamat sachin.ka...@samsung.com wrote: Since the USB 2.0 PHYs are required only with EHCI/OHCI USB drivers, make it depend on them and default to ARCH_EXYNOS as they are meant for Exynos platforms. Also, make the sub-drivers silent options enabling them

Re: linux-next: Tree for Jul 4

2014-07-05 Thread Sachin Kamat
On Fri, Jul 4, 2014 at 8:40 PM, Stephen Rothwell s...@canb.auug.org.au wrote: Hi Sachin, On Fri, 4 Jul 2014 14:12:11 +0530 Sachin Kamat spk.li...@gmail.com wrote: Was bisecting a kernel crash on Arndale octa board (Exynos5420). It points to a merge commit

Re: linux-next: Tree for Jul 4

2014-07-05 Thread Sachin Kamat
On Sat, Jul 5, 2014 at 6:18 AM, J. Bruce Fields bfie...@fieldses.org wrote: On Sat, Jul 05, 2014 at 01:10:58AM +1000, Stephen Rothwell wrote: Hi Sachin, On Fri, 4 Jul 2014 14:12:11 +0530 Sachin Kamat spk.li...@gmail.com wrote: Was bisecting a kernel crash on Arndale octa board (Exynos5420

Re: linux-next: Tree for Jul 4

2014-07-04 Thread Sachin Kamat
Hi Stephen, Was bisecting a kernel crash on Arndale octa board (Exynos5420). It points to a merge commit: 40556a4c485d12d324f1ea196cc30f590e564237 is the first bad commit (Merge remote-tracking branch 'nfsd/nfsd-next'). How do I proceed with this? Bisect log as follows: git bisect start #

Re: [PATCH] iommu/exynos: Select ARM_DMA_USE_IOMMU

2014-07-04 Thread Sachin Kamat
depends on ARCH_EXYNOS select IOMMU_API + select ARM_DMA_USE_IOMMU help Support for the IOMMU (System MMU) of Samsung Exynos application processor family. This enables H/W multimedia accelerators to see -- Reviewed-by: Sachin Kamat sachin.ka

Re: [PATCH 09/16] MAINTAINERS: Update Samsunt MFD drivers pattern

2014-07-03 Thread Sachin Kamat
On Fri, Jul 4, 2014 at 5:23 AM, Sangbeom Kim sbki...@samsung.com wrote: On Friday, July 04, 2014 7:08 AM, Joe Perches wrote: F: drivers/regulator/s2m*.c F: drivers/regulator/s5m*.c -F: drivers/rtc/rtc-sec.c F: include/linux/mfd/samsung/ Yes, You are right. There is no

Re: [PATCH 2/6] irq_work: Implement remote queueing

2014-07-03 Thread Sachin Kamat
on Exynos5420/5800 based boards with bL switcher enabled. FWIW, Tested-by: Sachin Kamat sachin.ka...@samsung.com -- Regards, Sachin. -- To unsubscribe from this list: send the line unsubscribe linux-kernel in the body of a message to majord...@vger.kernel.org More majordomo info at http

Re: [PATCH 1/3] phy: exynos-dp-video: Use PTR_ERR_OR_ZERO

2014-07-02 Thread Sachin Kamat
On Thu, Jun 12, 2014 at 3:27 PM, Kishon Vijay Abraham I kis...@ti.com wrote: On Thursday 12 June 2014 03:19 PM, Sachin Kamat wrote: Hi Kishon, On Mon, Jun 2, 2014 at 7:56 AM, Jingoo Han jg1@samsung.com wrote: On Thursday, May 29, 2014 3:31 PM, Sachin Kamat wrote: PTR_ERR_OR_ZERO

Re: [PATCH 1/1] clk: Fix build warnings

2014-07-01 Thread Sachin Kamat
On Mon, Jun 30, 2014 at 7:07 PM, Peter De Schrijver pdeschrij...@nvidia.com wrote: On Mon, Jun 30, 2014 at 11:40:54AM +0200, Sachin Kamat wrote: ‘all_lists’ and ‘orphan_list’ is accessed only when DEBUG_FS is defined. Thus, make their compilation conditional to fix the below warnings introduced

[PATCH v2 1/1] clk: Fix build warnings

2014-07-01 Thread Sachin Kamat
] drivers/clk/clk.c:46:27: warning: ‘orphan_list’ defined but not used [-Wunused-variable] Signed-off-by: Sachin Kamat sachin.ka...@samsung.com Cc: Peter De Schrijver pdeschrij...@nvidia.com --- Changes since v1: Moved the definitions under already existing #ifdefs. --- drivers/clk/clk.c | 22

Re: [PATCH] ARM: dts: Add TMU dt node to monitor the temperature for Exynos3250

2014-07-01 Thread Sachin Kamat
On Wed, Jul 2, 2014 at 5:22 AM, Chanwoo Choi cw00.c...@samsung.com wrote: On 07/01/2014 01:10 PM, Sachin Kamat wrote: Hi Chanwoo, On Tue, Jul 1, 2014 at 9:34 AM, Chanwoo Choi cw00.c...@samsung.com wrote: Hi Sachin, On 07/01/2014 12:33 PM, Sachin Kamat wrote: Hi Chanwoo, On Tue, Jul 1

[PATCH 1/2] phy: Kconfig: Re-organize Exynos USB 2.0 PHY configs

2014-06-30 Thread Sachin Kamat
easier for end users who do not have any way knowing the dependencies. Signed-off-by: Sachin Kamat sachin.ka...@samsung.com --- drivers/phy/Kconfig | 35 +++ 1 file changed, 11 insertions(+), 24 deletions(-) diff --git a/drivers/phy/Kconfig b/drivers/phy/Kconfig

[PATCH 2/2] phy: Kconfig: Update config for Exynos USB DRD

2014-06-30 Thread Sachin Kamat
USB DWC3 driver on Exynos platform does not work without its corresponding phy driver. Hence make the PHY driver depend on Exynos DWC3 driver and default it to yes to make things easier for the end user. Signed-off-by: Sachin Kamat sachin.ka...@samsung.com --- drivers/phy/Kconfig |2 ++ 1

[PATCH 1/1] clk: Fix build warnings

2014-06-30 Thread Sachin Kamat
] drivers/clk/clk.c:46:27: warning: ‘orphan_list’ defined but not used [-Wunused-variable] Signed-off-by: Sachin Kamat sachin.ka...@samsung.com Cc: Peter De Schrijver pdeschrij...@nvidia.com --- drivers/clk/clk.c |2 ++ 1 file changed, 2 insertions(+) diff --git a/drivers/clk/clk.c b/drivers/clk

Re: [PATCH] ARM: dts: Add TMU dt node to monitor the temperature for Exynos3250

2014-06-30 Thread Sachin Kamat
Hi Chanwoo, On Tue, Jul 1, 2014 at 6:10 AM, Chanwoo Choi cw00.c...@samsung.com wrote: This patch add TMU (Thermal Management Unit) dt node to monitor the high temperature for Exynos3250. Signed-off-by: Chanwoo Choi cw00.c...@samsung.com Acked-by: Kyungmin Park kyungmin.p...@samsung.com ---

Re: [PATCH] ARM: dts: Add TMU dt node to monitor the temperature for Exynos3250

2014-06-30 Thread Sachin Kamat
Hi Chanwoo, On Tue, Jul 1, 2014 at 9:34 AM, Chanwoo Choi cw00.c...@samsung.com wrote: Hi Sachin, On 07/01/2014 12:33 PM, Sachin Kamat wrote: Hi Chanwoo, On Tue, Jul 1, 2014 at 6:10 AM, Chanwoo Choi cw00.c...@samsung.com wrote: This patch add TMU (Thermal Management Unit) dt node to monitor

Re: [PATCH RESEND] ARM: EXYNOS: Do not calculate boot address twice

2014-06-26 Thread Sachin Kamat
cpu_boot_reg() again. Signed-off-by: Krzysztof Kozlowski k.kozlow...@samsung.com --- Thanks for the patch. Reviewed-by: Sachin Kamat sachin.ka...@samsung.com Regards, Sachin. -- To unsubscribe from this list: send the line unsubscribe linux-kernel in the body of a message to majord

Re: [PATCH 2/2] i2c: exynos5: fix minor styling nits

2014-06-25 Thread Sachin Kamat
Hi Naveen, On Wed, Jun 25, 2014 at 4:08 PM, Naveen Krishna Chatradhi ch.nav...@samsung.com wrote: This patch removes an extra line and fixes a styling nit in exynos5_i2c_message_start() Signed-off-by: Naveen Krishna Chatradhi ch.nav...@samsung.com --- drivers/i2c/busses/i2c-exynos5.c |

[PATCH 1/1] regulator: as3722: Fix incorrect parameter initialization

2014-06-24 Thread Sachin Kamat
'name' field was re-initialized and getting overwritten in some cases possibly due to a typo. Code inspection says the second time it should be 'sname' instead of 'name'. Replace it. Signed-off-by: Sachin Kamat sachin.ka...@samsung.com --- Compile tested only. --- drivers/regulator/as3722

[PATCH 2/2] regulator: tps65218: Fix build warnings

2014-06-24 Thread Sachin Kamat
expression 0 is always false [-Wtype-limits] Signed-off-by: Sachin Kamat sachin.ka...@samsung.com --- drivers/regulator/tps65218-regulator.c |4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/drivers/regulator/tps65218-regulator.c b/drivers/regulator/tps65218-regulator.c index

[PATCH 1/2] regulator: tps65217: Fix build warnings

2014-06-24 Thread Sachin Kamat
expression 0 is always false [-Wtype-limits] Signed-off-by: Sachin Kamat sachin.ka...@samsung.com --- Series compile tested. --- drivers/regulator/tps65217-regulator.c |4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/drivers/regulator/tps65217-regulator.c b/drivers/regulator

[PATCH 1/1] regulator: s5m8767: Remove unused variable

2014-06-24 Thread Sachin Kamat
'size' is not used in the function. Remove it. Signed-off-by: Sachin Kamat sachin.ka...@samsung.com --- drivers/regulator/s5m8767.c |4 +--- 1 file changed, 1 insertion(+), 3 deletions(-) diff --git a/drivers/regulator/s5m8767.c b/drivers/regulator/s5m8767.c index c79af943a5c0..0ab5cbeeb797

[PATCH 1/1] mfd: pm8921-core: Remove unused variable

2014-06-24 Thread Sachin Kamat
‘irq_bit’ is unused in the function. Remove it. Signed-off-by: Sachin Kamat sachin.ka...@samsung.com --- Compile tested. --- drivers/mfd/pm8921-core.c |4 1 file changed, 4 deletions(-) diff --git a/drivers/mfd/pm8921-core.c b/drivers/mfd/pm8921-core.c index 959513803542..39904f77c049

Re: [PATCH 1/1] pinctrl: bcm281xx: Staticize bcm281xx_pinctrl_probe

2014-06-23 Thread Sachin Kamat
Hi Sherman, On Mon, Jun 23, 2014 at 11:35 PM, Sherman Yin s...@broadcom.com wrote: Hi Sachin, Looks good, thanks. How did you come across the need for this change? Thanks for the review. Sparse threw up a warning while doing a regular build. Regards, Sachin. -- To unsubscribe from this

Re: [PATCH] serial: samsung: Remove redundant label

2014-06-23 Thread Sachin Kamat
s3c24xx_serial_probe(struct platform_device *pdev) dev_err(pdev-dev, failed to add cpufreq notifier\n); return 0; - - probe_err: - return ret; } static int s3c24xx_serial_remove(struct platform_device *dev) -- Looks good. Reviewed-by: Sachin Kamat sachin.ka

[PATCH 1/1] spmi: Remove duplicate inclusion of module.h

2014-06-23 Thread Sachin Kamat
module.h was included twice. Signed-off-by: Sachin Kamat sachin.ka...@samsung.com --- drivers/spmi/spmi.c |1 - 1 file changed, 1 deletion(-) diff --git a/drivers/spmi/spmi.c b/drivers/spmi/spmi.c index 3b5780710d50..1d92f5103ebf 100644 --- a/drivers/spmi/spmi.c +++ b/drivers/spmi/spmi.c

[PATCH 1/1] pinctrl: bcm281xx: Staticize bcm281xx_pinctrl_probe

2014-06-23 Thread Sachin Kamat
bcm281xx_pinctrl_probe is local to this file. Make it static. Signed-off-by: Sachin Kamat sachin.ka...@samsung.com --- drivers/pinctrl/pinctrl-bcm281xx.c |2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/pinctrl/pinctrl-bcm281xx.c b/drivers/pinctrl/pinctrl

Re: [PATCH 1/4] Documentation: devicetree: Fix s2mps11 and s5m8767 typos

2014-06-22 Thread Sachin Kamat
+ - Example: LDO1, LDO2, LDO28 - BUCKn - valid values for n are 1 to 9. - Example: BUCK1, BUCK2, BUCK9 -- Very keen observation :) Reviewed-by: Sachin Kamat sachin.ka...@samsung.com -- To unsubscribe from this list: send the line

Re: [PATCH 2/4] Documentation: devicetree: Fix s2mps11 example syntax

2014-06-22 Thread Sachin Kamat
{ compatible = samsung,s2mps11-clk; - #clock-cells = 1; + #clock-cells = 1; clock-output-names = xx, yy, zz; }; -- 1.9.3 Reviewed-by: Sachin Kamat sachin.ka...@samsung.com -- To unsubscribe from this list

[PATCH 5/6] thunderbolt: Use NULL instead of 0 in nhi.c

2014-06-20 Thread Sachin Kamat
'descriptors' is a pointer. Use NULL isntead of 0. Signed-off-by: Sachin Kamat sachin.ka...@samsung.com --- drivers/thunderbolt/nhi.c |2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/thunderbolt/nhi.c b/drivers/thunderbolt/nhi.c index 346b41e7d5d1..0fc137af89f5

[PATCH 1/6] thunderbolt: Fix build error in eeprom.c

2014-06-20 Thread Sachin Kamat
Fixes the below error: drivers/thunderbolt/eeprom.c:407:2: error: implicit declaration of function ‘kzalloc’ [-Werror=implicit-function-declaration] drivers/thunderbolt/eeprom.c:444:2: error: implicit declaration of function ‘kfree’ [-Werror=implicit-function-declaration] Signed-off-by: Sachin

[PATCH 4/6] thunderbolt: Use NULL instead of 0 in ctl.c

2014-06-20 Thread Sachin Kamat
The function returns a pointer. Hence return NULL instead of 0. Signed-off-by: Sachin Kamat sachin.ka...@samsung.com --- drivers/thunderbolt/ctl.c |4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/drivers/thunderbolt/ctl.c b/drivers/thunderbolt/ctl.c index d04fee4acb2e

[PATCH 3/6] thunderbolt: Use NULL instead of 0 in switch.c

2014-06-20 Thread Sachin Kamat
The function returns a pointer. Hence return NULL instead of 0. Signed-off-by: Sachin Kamat sachin.ka...@samsung.com --- drivers/thunderbolt/switch.c |6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/drivers/thunderbolt/switch.c b/drivers/thunderbolt/switch.c index

[PATCH 6/6] thunderbolt: Staticize nhi_ids

2014-06-20 Thread Sachin Kamat
'nhi_ids' is local to this file. Signed-off-by: Sachin Kamat sachin.ka...@samsung.com --- drivers/thunderbolt/nhi.c |2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/thunderbolt/nhi.c b/drivers/thunderbolt/nhi.c index 0fc137af89f5..2054fbf8b382 100644 --- a/drivers

[PATCH 2/6] thunderbolt: Fix build error in switch.c

2014-06-20 Thread Sachin Kamat
-by: Sachin Kamat sachin.ka...@samsung.com --- drivers/thunderbolt/switch.c |1 + 1 file changed, 1 insertion(+) diff --git a/drivers/thunderbolt/switch.c b/drivers/thunderbolt/switch.c index 0d50e7e7b29b..26e76e4aa835 100644 --- a/drivers/thunderbolt/switch.c +++ b/drivers/thunderbolt/switch.c @@ -5,6

[PATCH Resend 1/1] regulator: ltc3589: Staticize ltc3589_reg_defaults

2014-06-20 Thread Sachin Kamat
'ltc3589_reg_defaults' is local to this file. Make it static. Signed-off-by: Sachin Kamat sachin.ka...@samsung.com --- drivers/regulator/ltc3589.c |2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/regulator/ltc3589.c b/drivers/regulator/ltc3589.c index c8105182b8b8

Build error - vmlinux.lds [Re: linux-next: Tree for Jun 18]

2014-06-18 Thread Sachin Kamat
Hi, I observe the following build error while building uImage for ARM. Kernel: arch/arm/boot/Image is ready make[2]: *** No rule to make target `arch/arm/boot/compressed/vmlinux.lds', needed by `arch/arm/boot/compressed/vmlinux'. Stop. make[1]: *** [arch/arm/boot/compressed/vmlinux] Error 2

Re: Build error - vmlinux.lds [Re: linux-next: Tree for Jun 18]

2014-06-18 Thread Sachin Kamat
On Wed, Jun 18, 2014 at 5:26 PM, Russell King - ARM Linux li...@arm.linux.org.uk wrote: On Wed, Jun 18, 2014 at 04:50:43PM +0530, Sachin Kamat wrote: Hi, I observe the following build error while building uImage for ARM. Kernel: arch/arm/boot/Image is ready make[2]: *** No rule to make

Re: Build error - vmlinux.lds [Re: linux-next: Tree for Jun 18]

2014-06-18 Thread Sachin Kamat
On Wed, Jun 18, 2014 at 5:50 PM, Russell King - ARM Linux li...@arm.linux.org.uk wrote: On Wed, Jun 18, 2014 at 05:38:14PM +0530, Sachin Kamat wrote: On Wed, Jun 18, 2014 at 5:26 PM, Russell King - ARM Linux li...@arm.linux.org.uk wrote: On Wed, Jun 18, 2014 at 04:50:43PM +0530, Sachin Kamat

Boot warnings on exynos5420 based boards

2014-06-17 Thread Sachin Kamat
Hi, I observe the below warnings while trying to boot Exynos5420 based boards since yesterday's linux-next (next-20140616) using multi_v7_defconfig. Looks like it is triggered by the commit 56e6921829 (CPU hotplug, smp: flush any pending IPI callbacks before CPU offline). Any ideas?

Re: Boot warnings on exynos5420 based boards

2014-06-17 Thread Sachin Kamat
Hi Srivatsa, Thanks for your prompt reply. On Tue, Jun 17, 2014 at 2:48 PM, Srivatsa S. Bhat srivatsa.b...@linux.vnet.ibm.com wrote: Hi Sachin, On 06/17/2014 01:39 PM, Sachin Kamat wrote: Hi, I observe the below warnings while trying to boot Exynos5420 based boards since yesterday's linux

Re: Boot warnings on exynos5420 based boards

2014-06-17 Thread Sachin Kamat
Hi Srivatsa, On Tue, Jun 17, 2014 at 3:24 PM, Srivatsa S. Bhat srivatsa.b...@linux.vnet.ibm.com wrote: On 06/17/2014 03:03 PM, Sachin Kamat wrote: Below is an updated patch, please let me know how it goes. (You'll have to revert c47a9d7cca first, and then 56e692182, before trying this patch

Re: [PATCH] checkpatch: Warn on unnecessary void function return statements

2014-06-16 Thread Sachin Kamat
On Tue, Jun 17, 2014 at 7:30 AM, Joe Perches j...@perches.com wrote: On Mon, 2014-06-16 at 17:44 -0700, Anish Bhatt wrote: My code has multiple exit lables: void function(void) { ... if (err1) goto exit1; ... if (err2) goto exit2;

Re: [PATCH] checkpatch: Warn on unnecessary void function return statements

2014-06-16 Thread Sachin Kamat
On Tue, Jun 17, 2014 at 8:55 AM, Joe Perches j...@perches.com wrote: On Tue, 2014-06-17 at 08:46 +0530, Sachin Kamat wrote: On Tue, Jun 17, 2014 at 7:30 AM, Joe Perches j...@perches.com wrote: On Mon, 2014-06-16 at 17:44 -0700, Anish Bhatt wrote: My code has multiple exit lables: void

Re: [PATCH] serial: samsung: Fix compile error with SERIAL_SAMSUNG_DEBUG

2014-06-15 Thread Sachin Kamat
On Sun, Jun 15, 2014 at 2:03 AM, Joe Perches j...@perches.com wrote: Greg? Can you please apply this soon? A similar patch has already been posted [1]. Probably Greg will apply it once 3.16-rc1 is out. [1] http://www.spinics.net/lists/linux-serial/msg12843.html Regards, Sachin. Thanks.

Re: [PATCH] phy: Fix typo in drivers/phy/phy-exynos5250-sata.c module which fixes the build

2014-06-12 Thread Sachin Kamat
Hi Guillaume, On Thu, Jun 12, 2014 at 1:48 PM, Guillaume Gardet guillaume.gar...@free.fr wrote: Hi, please find in attachment a patch which fixes a typo in drivers/phy/phy-exynos5250-sata.c module license. It fixes the following build error: FATAL: modpost: GPL-incompatible module

Re: [PATCH 1/3] phy: exynos-dp-video: Use PTR_ERR_OR_ZERO

2014-06-12 Thread Sachin Kamat
Hi Kishon, On Mon, Jun 2, 2014 at 7:56 AM, Jingoo Han jg1@samsung.com wrote: On Thursday, May 29, 2014 3:31 PM, Sachin Kamat wrote: PTR_ERR_OR_ZERO simplifies the code. Signed-off-by: Sachin Kamat sachin.ka...@linaro.org Cc: Jingoo Han jg1@samsung.com Acked-by: Jingoo Han jg1

Re: [PATCH 1/3] phy: exynos-dp-video: Use PTR_ERR_OR_ZERO

2014-06-12 Thread Sachin Kamat
On Thu, Jun 12, 2014 at 3:27 PM, Kishon Vijay Abraham I kis...@ti.com wrote: On Thursday 12 June 2014 03:19 PM, Sachin Kamat wrote: Hi Kishon, On Mon, Jun 2, 2014 at 7:56 AM, Jingoo Han jg1@samsung.com wrote: On Thursday, May 29, 2014 3:31 PM, Sachin Kamat wrote: PTR_ERR_OR_ZERO

[PATCH 1/1] regulator: ltc3589: Staticize ltc3589_reg_defaults

2014-06-10 Thread Sachin Kamat
'ltc3589_reg_defaults' is local to this file. Make it static. Signed-off-by: Sachin Kamat sachin.ka...@samsung.com --- drivers/regulator/ltc3589.c |2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/regulator/ltc3589.c b/drivers/regulator/ltc3589.c index 110a99e

[PATCH Resend] mfd: asic3: Fix potential null pointer dereference

2014-06-10 Thread Sachin Kamat
We previously assumed 'mem_sdio' could be null but it is dereferenced in ioremap(). Add a check to avoid a potential null pointer dereference error. Signed-off-by: Sachin Kamat sachin.ka...@linaro.org --- drivers/mfd/asic3.c | 12 +++- 1 file changed, 7 insertions(+), 5 deletions

Re: [PATCH] ARM: Remove ARCH_HAS_CPUFREQ config option

2014-06-03 Thread Sachin Kamat
On Tue, Jun 3, 2014 at 3:37 AM, Stephen Boyd sb...@codeaurora.org wrote: This config exists entirely to hide the cpufreq menu from the kernel configuration unless a platform has selected it. Nothing is actually built if this config is 'Y' and it just leads to more patches that add a select

Re: [PATCH] serial: samsung: fix typo in debug code

2014-06-03 Thread Sachin Kamat
Hi Arnd, On Tue, Jun 3, 2014 at 3:23 PM, Arnd Bergmann a...@arndb.de wrote: commit e4ac92df2791 (serial: samsung: Neaten dbg uses) introduced a regression in the conversion from vsprintf to vsnprintf. This fixes the build error by passing the correct variable name. I submitted a similar

Re: [PATCH V4 2/8] opp: call of_node_{get|put}() from of_init_opp_table()

2014-05-30 Thread Sachin Kamat
Hi Viresh, On 27 May 2014 17:20, Viresh Kumar viresh.ku...@linaro.org wrote: All callers of of_init_opp_table() are required to take reference of dev-of_node, by initiating calls to of_node_{get|put}(), before and after calling of_init_opp_table(). Its better to call these from within

[PATCH 1/1] mfd: asic3: Fix potential null pointer dereference

2014-05-30 Thread Sachin Kamat
We previously assumed 'mem_sdio' could be null but it is dereferenced in ioremap(). Add a check to avoid a potential null pointer dereference error. Signed-off-by: Sachin Kamat sachin.ka...@linaro.org --- drivers/mfd/asic3.c | 12 +++- 1 file changed, 7 insertions(+), 5 deletions

[PATCH 1/1] pinctrl: sunxi: Fix potential null pointer dereference

2014-05-30 Thread Sachin Kamat
kzalloc can fail. Add a null check to avoid null pointer dereference error while accessing the pointer later. Signed-off-by: Sachin Kamat sachin.ka...@linaro.org --- drivers/pinctrl/sunxi/pinctrl-sunxi.c |4 1 file changed, 4 insertions(+) diff --git a/drivers/pinctrl/sunxi/pinctrl

[PATCH 3/3] phy: sun4i-usb: Use PTR_ERR_OR_ZERO

2014-05-29 Thread Sachin Kamat
PTR_ERR_OR_ZERO simplifies the code. Signed-off-by: Sachin Kamat sachin.ka...@linaro.org Cc: Hans de Goede hdego...@redhat.com Cc: Maxime Ripard maxime.rip...@free-electrons.com --- drivers/phy/phy-sun4i-usb.c |5 ++--- 1 file changed, 2 insertions(+), 3 deletions(-) diff --git a/drivers

[PATCH 1/3] phy: exynos-dp-video: Use PTR_ERR_OR_ZERO

2014-05-29 Thread Sachin Kamat
PTR_ERR_OR_ZERO simplifies the code. Signed-off-by: Sachin Kamat sachin.ka...@linaro.org Cc: Jingoo Han jg1@samsung.com --- drivers/phy/phy-exynos-dp-video.c |5 ++--- 1 file changed, 2 insertions(+), 3 deletions(-) diff --git a/drivers/phy/phy-exynos-dp-video.c b/drivers/phy/phy

[PATCH 2/3] phy: exynos-mipi-video: Use PTR_ERR_OR_ZERO

2014-05-29 Thread Sachin Kamat
PTR_ERR_OR_ZERO simplifies the code. Signed-off-by: Sachin Kamat sachin.ka...@linaro.org Cc: Sylwester Nawrocki s.nawro...@samsung.com --- drivers/phy/phy-exynos-mipi-video.c |5 ++--- 1 file changed, 2 insertions(+), 3 deletions(-) diff --git a/drivers/phy/phy-exynos-mipi-video.c b

[PATCH 1/1] mfd: menelaus: Use module_i2c_driver

2014-05-29 Thread Sachin Kamat
module_i2c_driver simplifies the code by eliminating boilerplate code. Signed-off-by: Sachin Kamat sachin.ka...@linaro.org --- drivers/mfd/menelaus.c | 23 +-- 1 file changed, 1 insertion(+), 22 deletions(-) diff --git a/drivers/mfd/menelaus.c b/drivers/mfd/menelaus.c

Re: [PATCH 1/1] ARM: ux500: Staticize ux500_soc_attr

2014-05-28 Thread Sachin Kamat
Hi Lee, On 28 May 2014 14:06, Lee Jones lee.jo...@linaro.org wrote: On Wed, 28 May 2014, Sachin Kamat wrote: 'ux500_soc_attr' is local to this file. While at it also make it const to match the argument list of device_create_file. What's going on Sachin? I Acked v2 of this patch an hour ago

[PATCH 1/2] ARM: ux500: Staticize local symbols in cpu-db8500.c

2014-05-28 Thread Sachin Kamat
Symbols local to this file are made static. Signed-off-by: Sachin Kamat sachin.ka...@linaro.org --- arch/arm/mach-ux500/cpu-db8500.c |8 1 file changed, 4 insertions(+), 4 deletions(-) diff --git a/arch/arm/mach-ux500/cpu-db8500.c b/arch/arm/mach-ux500/cpu-db8500.c index

[PATCH 2/2] ARM: ux500: Staticize ab8505_regulators

2014-05-28 Thread Sachin Kamat
'ab8505_regulators' is used only in this file. Signed-off-by: Sachin Kamat sachin.ka...@linaro.org --- arch/arm/mach-ux500/board-mop500-regulators.c |2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/arch/arm/mach-ux500/board-mop500-regulators.c b/arch/arm/mach-ux500/board

[PATCH 1/1] ARM: ux500: Staticize ux500_soc_attr

2014-05-27 Thread Sachin Kamat
'ux500_soc_attr' is local to this file. While at it also make it const to match the argument list of device_create_file. Signed-off-by: Sachin Kamat sachin.ka...@linaro.org --- arch/arm/mach-ux500/cpu.c |2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/arch/arm/mach-ux500

Re: [RFT PATCH] regulator: s2mpa01: Use correct register for buck[36] ramp delay

2014-05-26 Thread Sachin Kamat
Hi Krzysztof Apologies for the delay. I was on vacation during the early part of this month and got busy with some other stuff later and this mail fell through the cracks. On 23 May 2014 19:49, Krzysztof Kozlowski k.kozlow...@samsung.com wrote: Hi Sachin, The s2mpa01 regulator driver uses

Re: [PATCH v2] regulator: s2mpa01: Use correct register for buck1 ramp delay

2014-05-26 Thread Sachin Kamat
. This lead to updating of ramp delay of buck3 when setting buck1 and actually the ramp delay of buck1 was never set. Cc: sta...@vger.kernel.org Fixes: f18792714608 (regulator: Add support for S2MPA01 regulator) Signed-off-by: Krzysztof Kozlowski k.kozlow...@samsung.com Reviewed-by: Sachin Kamat

[PATCH 1/1] bus: vexpress-config: Export devm_regmap_init_vexpress_config

2014-05-26 Thread Sachin Kamat
Export this symbol to avoid build error when built as module. ERROR: devm_regmap_init_vexpress_config [drivers/regulator/vexpress.ko] undefined! Signed-off-by: Sachin Kamat sachin.ka...@linaro.org --- drivers/bus/vexpress-config.c |1 + 1 file changed, 1 insertion(+) diff --git a/drivers

Re: [PATCH] input: gpio_keys: Add IRQF_NO_SUSPEND flag to wake-up from freeze state

2014-05-25 Thread Sachin Kamat
Hi Chanwoo, On 26 May 2014 10:27, Chanwoo Choi cw00.c...@samsung.com wrote: This patch add IRQF_NO_SUSPEND flag before requesting interrupt handler if button-wakeup is true. If ther interrupt of gpio-keys hasn't included IRQF_NO_SUSPEND, wouldn't wake-up from freeze state when pressing

Re: [PATCH v2] cpufreq: s5pv210: drop check for CONFIG_PM_VERBOSE

2014-05-23 Thread Sachin Kamat
-off-by: Paul Bolle pebo...@tiscali.nl Reviewed-by: Sachin Kamat sachin.ka...@linaro.org -- To unsubscribe from this list: send the line unsubscribe linux-kernel in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read

Re: [PATCH] cpufreq: s5pv210: remove unused call of pr_err()

2014-05-22 Thread Sachin Kamat
Hi Paul, On 22 May 2014 12:11, Paul Bolle pebo...@tiscali.nl wrote: Sachin, On Thu, 2014-05-22 at 08:52 +0530, Sachin Kamat wrote: The config symbol itself is not defined and hence could be removed. However I feel, the error message could be retained after trimming down the arguments a bit

Re: [PATCH] cpufreq: s5pv210: remove unused call of pr_err()

2014-05-21 Thread Sachin Kamat
On 22 May 2014 01:23, Paul Bolle pebo...@tiscali.nl wrote: A call of pr_err() was added in v3.1. It was guarded by a check for CONFIG_PM_VERBOSE. The Kconfig symbol PM_VERBOSE was removed in v3.0. So this call of pr_err() has never been used. Remove it. Signed-off-by: Paul Bolle

Re: [PATCH] cpufreq: s5pv210: remove unused call of pr_err()

2014-05-21 Thread Sachin Kamat
On 22 May 2014 09:44, Viresh Kumar viresh.ku...@linaro.org wrote: On 22 May 2014 08:52, Sachin Kamat sachin.ka...@linaro.org wrote: On 22 May 2014 01:23, Paul Bolle pebo...@tiscali.nl wrote: A call of pr_err() was added in v3.1. It was guarded by a check for CONFIG_PM_VERBOSE. The Kconfig

Re: [PATCH v3 01/12] ARM: EXYNOS: Make exynos machine_ops as static

2014-04-30 Thread Sachin Kamat
Hi Pankaj, On 30 April 2014 10:47, Pankaj Dubey pankaj.du...@samsung.com wrote: As machine function ops are used only in this file let's make them static. Signed-off-by: Pankaj Dubey pankaj.du...@samsung.com --- arch/arm/mach-exynos/exynos.c |6 +++--- 1 file changed, 3 insertions(+),

Re: [PATCH v3 05/12] ARM: EXYNOS: Remove file path from comment section

2014-04-30 Thread Sachin Kamat
Reviewed-by: Tomasz Figa t.f...@samsung.com --- The change is sensible. However Kukjin had refused to accept such patches when I had submitted patches doing such cleanup for all Samsung platform files. Anyway, FWIW Reviewed-by: Sachin Kamat sachin.ka...@linaro.org -- With warm regards, Sachin

Re: Idea: regulator: Merge s2mpa01 with s2mps11

2014-04-30 Thread Sachin Kamat
Hi Krzysztof, On 30 April 2014 18:56, Krzysztof Kozlowski k.kozlow...@samsung.com wrote: Dear Sachin, The S2MPA01 and S2MPS1X PMICs regulator drivers look quite similar to each other. Most of the S2MPA01 driver is the same as S2MPS11 (except changes added for supporting S2MPS14). I would

  1   2   3   4   5   6   7   >