Re: [PATCH] nfc: st21nfca: use setup_timer instead of init_timer

2018-06-03 Thread Samuel Ortiz
Hi Colin, On Fri, Nov 24, 2017 at 01:37:41PM +, Colin King wrote: > From: Colin Ian King > > Use setup_timer function instead of initializing timer with the > function and data fields. > > Signed-off-by: Colin Ian King > --- > drivers/nfc/st21nfca/se.c | 10 -- > 1 file changed,

Re: [PATCH] NFC: fdp: make struct nci_ops static

2017-11-05 Thread Samuel Ortiz
On Thu, Oct 05, 2017 at 10:47:12AM +0100, Colin King wrote: > From: Colin Ian King > > The structure nci_ops is local to the source and does not need to > be in global scope, so make it static. > > Cleans up sparse warning: > symbol 'nci_ops' was not declared. Should

Re: [PATCH] nfc: s3fwrn5: make array match static const, reduces object code size

2017-11-05 Thread Samuel Ortiz
Hi Colin, On Tue, Sep 19, 2017 at 03:25:15PM +0100, Colin King wrote: > From: Colin Ian King > > Don't populate the read-only array match on the stack, instead make > it static const. Makes the object code smaller by over 310 bytes: > > Before: >text

Re: [PATCH 0/8] constify nfc i2c_device_id

2017-11-05 Thread Samuel Ortiz
Hi Arvind, On Mon, Aug 21, 2017 at 10:33:52PM +0530, Arvind Yadav wrote: > i2c_device_id are not supposed to change at runtime. All functions > working with i2c_device_id provided by work with > const i2c_device_id. So mark the non-const structs as const. > > Arvind Yadav (8): > [PATCH 1/8]

Re: [PATCH v4] NFC: trf7970a: Correct register settings for 27MHz clock

2017-06-28 Thread Samuel Ortiz
Hi Geoff, On Thu, Apr 27, 2017 at 05:28:46PM -0400, Geoff Lansberry wrote: > In prior commits the selected clock frequency does not propagate > correctly to what is written to the TRF7970A_MODULATOR_SYS_CLK_CTRL > register. > > Signed-off-by: Geoff Lansberry > --- >

Re: [PATCH] nfc: Add sockaddr length checks before accessing sa_family in bind handlers

2017-06-22 Thread Samuel Ortiz
On Tue, Jun 13, 2017 at 06:44:28PM +0200, Mateusz Jurczyk wrote: > Verify that the caller-provided sockaddr structure is large enough to > contain the sa_family field, before accessing it in bind() handlers of the > AF_NFC socket. Since the syscall doesn't enforce a minimum size of the >

Re: [PATCH] NFC: add NULL checks to avoid potential NULL pointer dereference

2017-06-22 Thread Samuel Ortiz
On Tue, May 30, 2017 at 03:43:07PM -0500, Gustavo A. R. Silva wrote: > NULL checks at line 457: if (!link0 || !link1) {, implies that both > pointers link0 and link1 might be NULL. > Function nfcsim_link_free() dereference pointers link0 and link1. > Add NULL checks before calling

Re: [PATCH] nfc: nci: remove unnecessary null check

2017-06-22 Thread Samuel Ortiz
Hi Gustavo, On Tue, Jun 13, 2017 at 11:37:18AM -0500, Gustavo A. R. Silva wrote: > Remove unnecessary NULL check for pointer conn_info. > conn_info is set in list_for_each_entry() using container_of(), > which is never NULL. > > Addresses-Coverity-ID: 1362349 > Cc: Guenter Roeck

Re: [PATCH] nfc: Ensure presence of required attributes in the activate_target netlink handler

2017-06-22 Thread Samuel Ortiz
Hi Mateusz, On Wed, May 24, 2017 at 12:42:26PM +0200, Mateusz Jurczyk wrote: > Check that the NFC_ATTR_TARGET_INDEX and NFC_ATTR_PROTOCOLS attributes (in > addition to NFC_ATTR_DEVICE_INDEX) are provided by the netlink client > prior to accessing them. This prevents potential unhandled NULL

Re: [PATCH] nfc: Fix the sockaddr length sanitization in llcp_sock_connect

2017-06-22 Thread Samuel Ortiz
Hi Mateusz, On Wed, May 24, 2017 at 12:26:20PM +0200, Mateusz Jurczyk wrote: > Fix the sockaddr length verification in the connect() handler of NFC/LLCP > sockets, to compare against the size of the actual structure expected on > input (sockaddr_nfc_llcp) instead of its shorter version

Re: [PATCH 0/2] NFC-digital: Adjustments for four function implementations

2017-06-22 Thread Samuel Ortiz
Hi Markus, On Mon, May 22, 2017 at 02:57:42PM +0200, SF Markus Elfring wrote: > From: Markus Elfring > Date: Mon, 22 May 2017 14:50:05 +0200 > > Two update suggestions were taken into account > from static source code analysis. > > Markus Elfring (2): > Improve

Re: [PATCH] NFC: trf7970a: fix check of clock frequencies, use && instead of ||

2017-06-22 Thread Samuel Ortiz
Hi Colin, On Mon, Apr 24, 2017 at 02:36:02PM +0100, Colin King wrote: > From: Colin Ian King > > The "or" condition (clk_freq != TRF7970A_27MHZ_CLOCK_FREQUENCY) || > (clk_freq != TRF7970A_13MHZ_CLOCK_FREQUE) will always be true because > clk_freq cannot be equal to two

Re: [PATCH v2 0/8] NFC: fix device allocation and nfcmrvl crashes

2017-04-26 Thread Samuel Ortiz
Hi Johan, On Thu, Mar 30, 2017 at 12:15:34PM +0200, Johan Hovold wrote: > This started out with the observation that the nfcmrvl_uart driver > unconditionally dereferenced the tty class device despite the fact that > not every tty has an associated struct device (Unix98 ptys). Some > further

Re: [PATCH v2 0/8] NFC: fix device allocation and nfcmrvl crashes

2017-04-18 Thread Samuel Ortiz
Hi Johan, On Tue, Apr 18, 2017 at 12:09:16PM +0200, Johan Hovold wrote: > On Thu, Mar 30, 2017 at 12:15:34PM +0200, Johan Hovold wrote: > > This started out with the observation that the nfcmrvl_uart driver > > unconditionally dereferenced the tty class device despite the fact that > > not every

Re: [PATCH] nfc: fix get_unaligned_...() misuses

2017-04-16 Thread Samuel Ortiz
On Thu, Apr 06, 2017 at 05:58:59PM +0100, Al Viro wrote: > On Thu, Apr 06, 2017 at 05:48:47PM +0100, Al Viro wrote: > > * use unaligned.h, not unaligned/access_ok.h > > ... which got misspelled in that patch, sorry... Fixed variant follows: > > commit b3e79ba1708c9b74781079c9f8617448fce36b51 >

Re: [PATCH v3 1/3] NFC: trf7970a: add device tree option for 27MHz clock

2017-04-05 Thread Samuel Ortiz
Hi Geoff, On Wed, Dec 21, 2016 at 11:18:32PM -0500, Geoff Lansberry wrote: > The TRF7970A has configuration options to support hardware designs > which use a 27.12MHz clock. This commit adds a device tree option > 'clock-frequency' to support configuring the this chip for default > 13.56MHz clock

Re: [PATCH] nfc: fdp: fix NULL pointer dereference

2017-04-01 Thread Samuel Ortiz
Hi Sudip, On Tue, Dec 20, 2016 at 09:09:04PM +, Sudip Mukherjee wrote: > We are checking phy after dereferencing it. We can print the debug > information after checking it. If phy is NULL then we will get a good > stack trace to tell us that we are in this irq handler. > > Signed-off-by:

Re: [PATCH] Make EN2 pin optional in the TRF7970A driver

2017-04-01 Thread Samuel Ortiz
Hi Heiko, On Tue, Feb 07, 2017 at 06:22:04AM +0100, Heiko Schocher wrote: > From: Guan Ben > > Make the EN2 pin optional. This is useful for boards, > which have this pin fix wired, for example to ground. > > Signed-off-by: Guan Ben >

Re: [PATCH] nfc: nxp-nci: use msleep for long delays

2017-04-01 Thread Samuel Ortiz
Hi Nicholas, On Sun, Jan 22, 2017 at 01:28:39PM +0100, Nicholas Mc Guire wrote: > ulseep_range() uses hrtimers and provides no advantage over msleep() > for larger delays. For this large delay msleep() is preferable. > > Fixes: commit 6be88670fc59 ("NFC: nxp-nci_i2c: Add I2C support to NXP NCI

Re: [PATCH v2] nfc: don't be making arch specific unaligned decisions at driver level.

2017-04-01 Thread Samuel Ortiz
uot;kernel: add common infrastructure for > unaligned access") as a reference. > > Cc: Lauro Ramos Venancio <lauro.venan...@openbossa.org> > Cc: Aloisio Almeida Jr <aloisio.alme...@openbossa.org> > Cc: Samuel Ortiz <sa...@linux.intel.com> > Cc: T

Re: [PATCH] NFC: st21nfca: Fix potential memory leak

2017-04-01 Thread Samuel Ortiz
Hi Christophe, On Sun, Feb 19, 2017 at 10:58:47AM +0100, Christophe JAILLET wrote: > If all bits of 'dev_mask' are already set, there is a memory leak because > 'info' should be freed before returning. > > While fixing it, 'return -ENOMEM' directly if the first kzalloc fails. > This makes the

Re: [PATCH 1/3] nfc: nxp-nci: Remove unneeded linux/miscdevice.h include

2017-04-01 Thread Samuel Ortiz
Hi Corentin, On Thu, Dec 15, 2016 at 03:22:44PM +0100, Corentin Labbe wrote: > drivers/nfc/nxp-nci/i2c.c does not use any miscdevice, so this patch > remove this unnecessary inclusion. > > Signed-off-by: Corentin Labbe > --- > drivers/nfc/nxp-nci/i2c.c | 1 - > 1

Re: [PATCH] NFC: nfcmrvl: Include unaligned.h instead of access_ok.h

2017-04-01 Thread Samuel Ortiz
Hi Tobias, On Wed, Oct 26, 2016 at 11:00:12AM +0200, Tobias Klauser wrote: > Including linux/unaligned/access_ok.h causes the allmodconfig build on > ia64 (and maybe others) to fail with the following warnings: > > include/linux/unaligned/access_ok.h:7:19: error: redefinition of >

Re: [PATCH] NFC: nfcmrvl: drop duplicate header gpio.h

2017-04-01 Thread Samuel Ortiz
Hi Geliang, On Thu, Nov 24, 2016 at 09:58:34PM +0800, Geliang Tang wrote: > Drop duplicate header gpio.h from nfcmrvl/spi.c. > > Signed-off-by: Geliang Tang > --- > drivers/nfc/nfcmrvl/spi.c | 1 - > 1 file changed, 1 deletion(-) Patch applied, thanks. Cheers, Samuel.

Re: [PATCH v2] nfc: don't be making arch specific unaligned decisions at driver level.

2017-03-29 Thread Samuel Ortiz
Hi Paul, On Tue, Mar 28, 2017 at 06:55:26PM -0400, Paul Gortmaker wrote: > On Mon, Jan 9, 2017 at 12:52 PM, Paul Gortmaker > wrote: > > Currently ia64 fails building allmodconfig with variations of: > > > >In file included from drivers/nfc/nxp-nci/i2c.c:39:0: >

Re: [PATCH resend 1/4] nfc: Add support RC-S380P to port100

2017-02-27 Thread Samuel Ortiz
Hi Hirofumi, On Sat, Feb 04, 2017 at 10:15:22AM +0900, OGAWA Hirofumi wrote: > > > Signed-off-by: OGAWA Hirofumi > --- > > drivers/nfc/port100.c |8 +--- > 1 file changed, 5 insertions(+), 3 deletions(-) All 4 patches applied, thanks. Cheers, Samuel.

Re: [PATCH] NFC: remove TI nfcwilink driver

2017-02-27 Thread Samuel Ortiz
Ilan Elias <il...@ti.com> > Cc: Marcel Holtmann <mar...@holtmann.org> > Cc: Samuel Ortiz <sa...@linux.intel.com> > Cc: Lauro Ramos Venancio <lauro.venan...@openbossa.org> > Cc: Aloisio Almeida Jr <aloisio.alme...@openbossa.org> > Cc: linux-wirel...@vger.ker

Re: [PATCH] NFC: remove TI nfcwilink driver

2017-02-27 Thread Samuel Ortiz
Hi Rob, On Fri, Feb 24, 2017 at 02:56:48PM -0600, Rob Herring wrote: > On Wed, Jan 25, 2017 at 11:54 PM, Marcel Holtmann wrote: > > Hi Rob, > > > >> It appears that TI WiLink devices including NFC (WL185x/WL189x) never > >> shipped. The only information I found were

Re: [PATCH] NFC: nfcmrvl: constify nfcmrvl_if_ops structures

2016-09-19 Thread Samuel Ortiz
Hi Julia, On Tue, Aug 09, 2016 at 07:03:50PM +0200, Julia Lawall wrote: > The nfcmrvl_if_ops structures are never modified, so declare them as const. > > Done with the help of Coccinelle. > > Signed-off-by: Julia Lawall > > --- > drivers/nfc/nfcmrvl/i2c.c |2 +-

Re: [PATCH] NFC: pn533: constify pn533_phy_ops structures

2016-09-19 Thread Samuel Ortiz
Hi Julia, On Tue, Aug 09, 2016 at 06:11:02PM +0200, Julia Lawall wrote: > The pn533_phy_ops are never modified, so declare them as const. > > Done with the help of Coccinelle. > > Signed-off-by: Julia Lawall > > --- > drivers/nfc/pn533/i2c.c |2 +- >

Re: [PATCH] NFC: Delete owner assignment

2016-09-19 Thread Samuel Ortiz
Hi Markus, On Mon, Aug 15, 2016 at 09:12:29AM +0200, SF Markus Elfring wrote: > From: Markus Elfring > Date: Mon, 15 Aug 2016 09:00:26 +0200 > > The field "owner" is set by core. Thus delete an extra initialisation. > > Generated by:

Re: [PATCH] NFC: null-ify info->ram_patch when firmware is released

2016-07-19 Thread Samuel Ortiz
Hi Colin, On Fri, Jul 15, 2016 at 02:00:33PM +0100, Colin King wrote: > From: Colin Ian King > > When the firmware is released for info->ram_patch currently > info->otp_patch is being nullified and not info->ram_patch. > This looks like a cut-n-paste coding error. Fix

Re: [PATCH] drivers: misc: ti-st: Use int instead of fuzzy char for callback status

2016-07-13 Thread Samuel Ortiz
Hi Marcel, On Wed, Jul 13, 2016 at 11:56:02AM +0100, Marcel Holtmann wrote: > Hi Mauro, > > >> On mips and parisc: > >> > >>drivers/bluetooth/btwilink.c: In function 'ti_st_open': > >>drivers/bluetooth/btwilink.c:174:21: warning: overflow in implicit > >> constant conversion

Re: [PATCH 08/11] NFC: pn533: reduce output when stopping poll

2016-05-01 Thread Samuel Ortiz
Hi Michael, On Thu, Apr 21, 2016 at 04:43:56PM +0200, Michael Thalmeier wrote: > @@ -1259,7 +1259,8 @@ static int pn533_rf_complete(struct pn533 *dev, void > *arg, > if (IS_ERR(resp)) { > rc = PTR_ERR(resp); > > - nfc_err(dev->dev, "RF setting error %d\n", rc);

Re: [PATCH 07/11] NFC: pn533: improve cmd queue handling

2016-05-01 Thread Samuel Ortiz
Hi Michael, On Thu, Apr 21, 2016 at 04:43:55PM +0200, Michael Thalmeier wrote: > Make sure cmd is set before a frame is passed to the transport layer for > sending. In addition pn533_send_async_complete checks if cmd is set before > accessing its members. > > Signed-off-by: Michael Thalmeier

Re: [PATCH 06/11] NFC: pn533: usb: fix errors when poll is stopped

2016-05-01 Thread Samuel Ortiz
Hi Michael, On Thu, Apr 21, 2016 at 04:43:54PM +0200, Michael Thalmeier wrote: > When a poll ist stopped we need to kill the out_urb request too before > starting a new request. > > Additionally check if cmd is set in pn533_recv_ack befor accessing its struct > members. I understand those 2

Re: [PATCH 09/11] NFC: pn533: use nfc_alloc_recv_skb for skb allocation

2016-05-01 Thread Samuel Ortiz
Hi Michael, On Thu, Apr 21, 2016 at 04:43:57PM +0200, Michael Thalmeier wrote: > When multiple receive frames need to be put together in pn533_build_response > we need to use nfc_alloc_recv_skb instead of the normal alloc_skb. Otherwise > the nfc core causes an skb error when it tries to push the

Re: [RESEND] nfc: Drop owner assignment from i2c_driver

2016-05-01 Thread Samuel Ortiz
Hi Krzysztof, On Wed, Mar 30, 2016 at 09:51:04AM +0900, Krzysztof Kozlowski wrote: > i2c_driver does not need to set an owner because i2c_register_driver() > will set it. > > Signed-off-by: Krzysztof Kozlowski > > --- > > The coccinelle script which generated the

Re: [PATCH] nfc: pn533: Add device tree documentation for i2c phy

2016-05-01 Thread Samuel Ortiz
Hi Michael, On Mon, Apr 11, 2016 at 04:36:02PM +0200, Michael Thalmeier wrote: > Add pn533-i2c phy devicetree documentation > > Signed-off-by: Michael Thalmeier > --- > .../devicetree/bindings/net/nfc/pn533-i2c.txt | 31 > ++ > 1 file

Re: [RFC 0/4] NFC: pn533: support for pn532 via I2C

2016-04-09 Thread Samuel Ortiz
Hi Michael, On Fri, Mar 25, 2016 at 03:46:50PM +0100, Michael Thalmeier wrote: > Michael Thalmeier (4): > NFC: pn533: Send ATR_REQ only if NFC_PROTO_NFC_DEP bit is set in > poll_protocols > NFC: pn533: fix deadlock when socket is closed while processing > command > NFC: pn533:

Re: [RFC 4/4] NFC: pn533: add I2C phy driver

2016-04-09 Thread Samuel Ortiz
Hi Michael, On Fri, Mar 25, 2016 at 03:46:54PM +0100, Michael Thalmeier wrote: > This adds the I2C phy interface for the pn533 driver. This way the driver can > be used to interact with I2C connected pn532. > > Signed-off-by: Michael Thalmeier > --- >

Re: [PATCH] MAINTAINERS: nfc: s3fwrn5: Add second maintainer

2016-03-10 Thread Samuel Ortiz
Hi Robert, On Thu, Mar 10, 2016 at 03:22:43PM +0100, Robert Baldyga wrote: > Add Krzysztof Opasiak as maintainer of S3FWRN5 driver. > > Signed-off-by: Robert Baldyga > --- > MAINTAINERS | 1 + > 1 file changed, 1 insertion(+) Applied to nfc-next. Cheers, Samuel.

Re: [PATCH 2/3] NFC: trf7970a: use to_spi_device

2015-12-22 Thread Samuel Ortiz
Hi Tang, On Wed, Dec 23, 2015 at 12:18:42AM +0800, Geliang Tang wrote: > Use to_spi_device() instead of open-coding it. > > Signed-off-by: Geliang Tang > --- > drivers/nfc/trf7970a.c | 8 > 1 file changed, 4 insertions(+), 4 deletions(-) Applied and pushed,

Re: [PATCH] NFC: added the rx delay parameter for nfcsim workqueue

2015-12-20 Thread Samuel Ortiz
Hi Saurabh, On Mon, Dec 21, 2015 at 12:29:30AM +0530, Saurabh Sengar wrote: > added the rx delay parameter as a device tunable parameter. > > Signed-off-by: Saurabh Sengar <saurabh.tr...@gmail.com> > --- > This is a follow up patch after the review comments by Samuel Ortiz &

Re: [RESEND PATCH] NFC: added the sysfs entry for nfcsim workqueue delay

2015-12-20 Thread Samuel Ortiz
Hi Saurabh, On Sun, Dec 13, 2015 at 01:34:35PM +0530, Saurabh Sengar wrote: > added the sysfs entry for nfcsim workqueue delay, as tx_delay > > Signed-off-by: Saurabh Sengar > --- > In case this TODO is not expected to be done, please let me know. > I wonder after my

Re: [PATCH] nfc: s3fwrn5: constify s3fwrn5_phy_ops structures

2015-12-20 Thread Samuel Ortiz
Hi Julia, On Fri, Nov 13, 2015 at 01:04:41PM +0100, Julia Lawall wrote: > The s3fwrn5_phy_ops structure is never modified, so declare it as const. > > Done with the help of Coccinelle. Applied to nfc-next, thanks. Cheers, Samuel. -- To unsubscribe from this list: send the line "unsubscribe

Re: [PATCH] NFC: nfcmrvl: fix SPI driver dependencies

2015-11-03 Thread Samuel Ortiz
Hi Arnd, On Tue, Nov 03, 2015 at 03:03:33PM +0100, Arnd Bergmann wrote: > The newly added nfcmrvl_spi driver uses the spi_nci > infrastructure, but does not have a Kconfig dependency on > that, so we can get a link-time error: > > drivers/built-in.o: In function `nfcmrvl_spi_nci_send': >

Re: [PATCH 1/2] NFC: delete null dereference

2015-10-19 Thread Samuel Ortiz
Hi Julia, On Sat, Oct 17, 2015 at 11:32:19AM +0200, Julia Lawall wrote: > The exit label performs device_unlock(>dev);, which will fail when dev > is NULL, and nfc_put_device(dev);, which is not useful when dev is NULL, so > just exit the function immediately. > > Problem found using

Re: [PATCH] NFC: nfcwilink: Drop a useless static qualifier

2015-10-19 Thread Samuel Ortiz
Hi Christophe, On Tue, Oct 13, 2015 at 08:31:04AM +0200, Christophe JAILLET wrote: > There is no need to have the 'struct nfcwilink *drv' variable static in the > probe function. > It only wastes a few bytes of memory. > > Signed-off-by: Christophe JAILLET > --- >

Re: [PATCH] nfc: netlink: avoid NULL pointer dereference on error

2015-10-19 Thread Samuel Ortiz
gt; > ./net/nfc/netlink.c:1175:21-24: ERROR: dev is NULL but dereferenced. > > Signed-off-by: Vincent Stehlé <vincent.ste...@laposte.net> > Cc: Thierry Escande <thierry.esca...@linux.intel.com> > Cc: Samuel Ortiz <sa...@linux.intel.com> > --- > net/nf

Re: [PATCH] NFC: nxp-nci: constify nxp_nci_phy_ops structure

2015-10-19 Thread Samuel Ortiz
Hi Julia, On Sun, Oct 11, 2015 at 01:24:13PM +0200, Julia Lawall wrote: > The only instance of a nxp_nci_phy_ops structure is never modified. Thus > the declaration of the structure and all references to the structure type > can be made const. > > Done with the help of Coccinelle. > >

Re: [RESEND PATCH] NFC: trf7970a: Add OF match table

2015-10-19 Thread Samuel Ortiz
Hi Javier, On Wed, Sep 16, 2015 at 11:08:42AM +0200, Javier Martinez Canillas wrote: > The Documentation/devicetree/bindings/net/nfc/trf7970a.txt DT binding doc > lists "ti,trf7970a" as a compatible string but the corresponding driver > does not have an OF match table. Add the table to the driver

Re: [PATCH] drivers/nfc/s3fwrn5/Makefile: remove superfluous cflags

2015-10-06 Thread Samuel Ortiz
Hi Robert, On Mon, Aug 31, 2015 at 10:02:40AM +0200, Robert Baldyga wrote: > [ +cc Samuel Ortiz and <linux-...@lists.01.org> ] > > Hi Samuel, > > Could you please apply this patch? Applied, thanks. Cheers, Samuel. -- To unsubscribe from this list: send the line &quo

Re: [PATCH v3 0/3] nfc: Add driver for Samsung S3FWRN5 NFC Chip

2015-08-20 Thread Samuel Ortiz
Changelog: v3: - Addressed comments from Samuel Ortiz: - Used nci_prop_cmd and nci_prop_ops to handle proprietary requests - Refactorized s3fwrn5_i2c_nci_read and s3fwrn5_i2c_fw_read - Miscellaneous minor fixes - Added patch NFC: nci: Add post_setup handler - Added patch NFC: nci

Re: [PATCH v2] nfc: s3fwrn5: Add driver for Samsung S3FWRN5 NFC Chip

2015-08-16 Thread Samuel Ortiz
Hi Robert, On Thu, Jul 30, 2015 at 04:26:16PM +0200, Robert Baldyga wrote: +static int s3fwrn5_firmware_update(struct s3fwrn5_info *info) +{ + u32 version; + bool need_update; + int ret; + + ENTER(); We have many tracing tools and frameworks in the kernel, I don't think

Re: [PATCH] Doc:nfc: Fix typo in nfc-hci.txt

2015-06-08 Thread Samuel Ortiz
Hi Msanari, On Fri, Jun 05, 2015 at 09:38:19PM +0900, Masanari Iida wrote: This patch fix a spelling typo in nfc-hci.txt Signed-off-by: Masanari Iida standby2...@gmail.com --- Documentation/nfc/nfc-hci.txt | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) Applied, thanks. Cheers,

Re: [PATCH] NFC: nci: hci: Fix releasing uninitialized skbs

2015-06-08 Thread Samuel Ortiz
Hi Joe, On Sun, May 31, 2015 at 05:44:45PM -0700, Joe Perches wrote: Several of these goto exit; uses should be direct returns as skb is not yet initialized by nci_hci_get_param(). Miscellanea: o Use !memcmp instead of memcmp() == 0 o Remove unnecessary goto from if () {... goto exit;}

Re: [char-misc-next] NFC: microread: drop unused variable

2015-06-08 Thread Samuel Ortiz
Hi Tomas, On Thu, May 07, 2015 at 04:38:30PM +0300, Tomas Winkler wrote: In microread_i2c_irq_thread_fn 'client' set but not used Cc: Lauro Ramos Venancio lauro.venan...@openbossa.org Cc: Aloisio Almeida Jr aloisio.alme...@openbossa.org Signed-off-by: Tomas Winkler tomas.wink...@intel.com

Re: [PATCH] drivers/nfc: remove obsolete setting of DEBUG

2015-06-08 Thread Samuel Ortiz
Hi Valentin, On Tue, Apr 28, 2015 at 11:08:47AM +0200, Valentin Rothberg wrote: The CPP identifier 'DEBUG' is not used in the source code of nfc at all, so we can safely remove setting it in both Makefiles. Signed-off-by: Valentin Rothberg valentinrothb...@gmail.com --- I detected this

Re: [linux-nfc] [PATCH 3/8] NFC: NCI: Adds NCI init and reset API for drivers

2015-05-24 Thread Samuel Ortiz
Hi Robert, On Tue, Mar 31, 2015 at 05:05:53PM +0300, Robert Dolca wrote: On Thu, Mar 26, 2015 at 2:29 AM, Samuel Ortiz sa...@linux.intel.com wrote: Hi Robert, On Tue, Feb 24, 2015 at 12:01:47PM +0200, Robert Dolca wrote: In order to communicate with the device during the setup phase

Re: [linux-nfc] [PATCH 1/8] NFC: NCI: Allow connection close with dev down

2015-05-24 Thread Samuel Ortiz
Hi Robert, On Tue, Mar 31, 2015 at 05:03:42PM +0300, Robert Dolca wrote: On Thu, Mar 26, 2015 at 2:29 AM, Samuel Ortiz sa...@linux.intel.com wrote: Hi Robert, On Tue, Feb 24, 2015 at 12:01:45PM +0200, Robert Dolca wrote: By calling __nci_request instead of nci_request allows the driver

Re: [linux-nfc] [PATCH 8/8] NFC: Add Intel FieldsPeak NFC solution driver

2015-05-24 Thread Samuel Ortiz
Hi Robert, On Wed, Apr 01, 2015 at 06:35:31PM +0300, Robert Dolca wrote: On Thu, Mar 26, 2015 at 2:30 AM, Samuel Ortiz sa...@linux.intel.com wrote: + /* If a patch was applied the new version is checked */ + if (patched) { + r = nci_init(ndev); + if (r

Re: [resend PATCH] nfc: logging neatening

2015-04-07 Thread Samuel Ortiz
Hi Joe, On Tue, Apr 07, 2015 at 12:17:00AM -0700, Joe Perches wrote: Add missing terminating newlines to nfc_info and nfc_err to avoid possible interleaving from other messages. Miscellanea: o typo fix of unknonwn in message o remove unnecessary OOM messages as there's a generic

Re: [PATCH 16/16] NFC: pn533: fix error return code

2015-04-05 Thread Samuel Ortiz
Hi Julia, On Sun, Apr 05, 2015 at 02:06:36PM +0200, Julia Lawall wrote: Return a negative error code on failure. A simplified version of the semantic match that finds this problem is as follows: (http://coccinelle.lip6.fr/) // smpl @@ identifier ret; expression e1,e2; @@ ( if (\(ret

Re: [PATCH v2 0/3] NFC: nxp-nci: Add support for NXP-NCI NFC controllers

2015-03-26 Thread Samuel Ortiz
Hi Clément, On Mon, Mar 09, 2015 at 11:12:02AM +0100, clement.perroch...@effinnov.com wrote: From: Clément Perrochaud clement.perroch...@effinnov.com This patch brings support for the NXP-NCI NFC controllers family. It has been successfully tested on the following SoC boards: -

Re: [PATCH 8/8] NFC: Add Intel FieldsPeak NFC solution driver

2015-03-26 Thread Samuel Ortiz
Robert, Another comment: On Tue, Feb 24, 2015 at 12:01:52PM +0200, Robert Dolca wrote: +static struct i2c_device_id fdp_nci_i2c_id_table[] = { + {INT339A, 0}, + {} +}; + +MODULE_DEVICE_TABLE(i2c, fdp_nci_i2c_id_table); + + +static const struct acpi_device_id

Re: [PATCH 1/8] NFC: NCI: Allow connection close with dev down

2015-03-25 Thread Samuel Ortiz
Hi Robert, On Tue, Feb 24, 2015 at 12:01:45PM +0200, Robert Dolca wrote: By calling __nci_request instead of nci_request allows the driver to use the function while initializing the device (setup stage) Signed-off-by: Robert Dolca robert.do...@intel.com --- net/nfc/nci/core.c | 2 +- 1

Re: [PATCH 8/8] NFC: Add Intel FieldsPeak NFC solution driver

2015-03-25 Thread Samuel Ortiz
Hi Robert, On Tue, Feb 24, 2015 at 12:01:52PM +0200, Robert Dolca wrote: The device can be enumerated using ACPI using the id INT339A. Please give us some more details about the device. NCI ? HCI ? Features ? What does the initial patchset support ? +config NFC_FDP + tristate Intel FDP

Re: [PATCH 4/8] NFC: NCI: Add a special nci_request for driver

2015-03-25 Thread Samuel Ortiz
Hi Robert, On Tue, Feb 24, 2015 at 12:01:48PM +0200, Robert Dolca wrote: This patch adds nci_request_driver and nci_req_complete_driver as a wrapper for __nci_request. When nci_req_complete_driver is called it also sets cmd_cnt to 1. This is done because the response is not sent to the NFC

Re: [PATCH 3/8] NFC: NCI: Adds NCI init and reset API for drivers

2015-03-25 Thread Samuel Ortiz
Hi Robert, On Tue, Feb 24, 2015 at 12:01:47PM +0200, Robert Dolca wrote: In order to communicate with the device during the setup phase, the driver may need to initialize the device. After the setup is done the driver should reset the device to leave it in the same state that it was before

Re: [PATCH 5/8] NFC: NCI: Don't call setup if previous NCI request failed

2015-03-25 Thread Samuel Ortiz
Hi Robert, On Tue, Feb 24, 2015 at 12:01:49PM +0200, Robert Dolca wrote: If the previous nci_request (NCI reset) failed the setup function was being called anyway. It shouldn't be called if the reset failed. The result of the setup function is taken into consideration. If it fails the init

Re: [PATCH 4/4] NFC: nxp-nci: Allow module removal during download

2015-01-29 Thread Samuel Ortiz
Hi Clement, On Thu, Jan 22, 2015 at 04:27:40PM +0100, clement.perroch...@effinnov.com wrote: From: Clément Perrochaud clement.perroch...@nxp.com Signed-off-by: Clément Perrochaud clement.perroch...@nxp.com Signed-off-by: Clément Perrochaud clement.perroch...@effinnov.com ---

Re: [PATCH 1/4] NFC: nci: Add FWDL support

2015-01-29 Thread Samuel Ortiz
Hi Clement, On Thu, Jan 22, 2015 at 04:27:37PM +0100, clement.perroch...@effinnov.com wrote: From: Clément Perrochaud clement.perroch...@nxp.com - It really is not obvious that FWDL actually means firmware download - A small commit message explaining why you need this (Mostly for the NXP

Re: [PATCH 2/4] NFC: nxp-nci: Add support for NXP NCI chips

2015-01-29 Thread Samuel Ortiz
Hi Clement, On Thu, Jan 22, 2015 at 04:27:38PM +0100, clement.perroch...@effinnov.com wrote: @@ -686,7 +686,7 @@ L:alsa-de...@alsa-project.org (moderated for non-subscribers) W: http://blackfin.uclinux.org/ S: Supported F: sound/soc/blackfin/* - + Unneeded change, please

Re: [PATCH 3/4] NFC: nxp-nci_i2c: Add I2C support to NXP NCI driver

2015-01-29 Thread Samuel Ortiz
Hi Clement, On Thu, Jan 22, 2015 at 04:27:39PM +0100, clement.perroch...@effinnov.com wrote: From: Clément Perrochaud clement.perroch...@nxp.com Signed-off-by: Clément Perrochaud clement.perroch...@nxp.com Signed-off-by: Clément Perrochaud clement.perroch...@effinnov.com Are you sure you

Re: [PATCH v2 0/2] Add ACPI support for NXP PN544

2015-01-27 Thread Samuel Ortiz
Hi Robert, On Mon, Jan 26, 2015 at 01:13:35PM +0200, Robert Dolca wrote: This patch set introduces ACPI support for PN544. gpio_set_value was replaced with gpio_set_value_cansleep in order to allow GPIO access that may sleep. This is particularelly useful when GPIO is accessed using busses

Re: [PATCH v2 2/2] NFC: Add ACPI support for NXP PN544

2015-01-27 Thread Samuel Ortiz
Hi Robert, On Mon, Jan 26, 2015 at 01:13:37PM +0200, Robert Dolca wrote: @@ -1022,9 +1127,12 @@ static int pn544_hci_i2c_probe(struct i2c_client *client, PN544_I2C_FRAME_HEADROOM, PN544_I2C_FRAME_TAILROOM, PN544_HCI_I2C_LLC_MAX_PAYLOAD,

Re: [PATCHv2] pinctrl: baytrail: Clear DIRECT_IRQ bit

2014-09-18 Thread Samuel Ortiz
Hi Mika, On Thu, Sep 18, 2014 at 10:49:43AM +0300, Mika Westerberg wrote: On Wed, Sep 17, 2014 at 03:47:01PM +0200, Loic Poulain wrote: Direct Irq En bit can be initialized to a bad value. This bit has to be cleared for io access mode. +Eric I would like to have a bit better

Re: [PATCH RESEND 0/3] mmc: rtsx: fix bug and support nonblocking request

2014-02-16 Thread Samuel Ortiz
Hi Micky, On Mon, Feb 17, 2014 at 10:00:54AM +0800, micky_ch...@realsil.com.cn wrote: From: Micky Ching micky_ch...@realsil.com.cn First we fix the card poweroff bug: the card power is not shutdown when sd/mmc card removed, this will make UHS-card failed to running in high speed mode if we

[GIT] [3.13] MFD fix

2014-01-10 Thread Samuel Ortiz
Hi Linus, This is the 2nd MFD pull request for 3.13 It only contains one fix for the rtsx_pcr driver. Without it we see a kernel panic on some machines, when resuming from suspend to RAM. Thanks in advance for pulling it in. The following changes since commit

Re: 3.12: kernel panic when resuming from suspend to RAM (x86_64)

2014-01-10 Thread Samuel Ortiz
Hi Francis, On Fri, Jan 10, 2014 at 08:26:13AM +0100, Francis Moreau wrote: Hi. On 12/10/2013 09:29 AM, Samuel Ortiz wrote: Hi Micky, On Tue, Dec 10, 2013 at 09:56:48AM +0800, micky wrote: Hi Francis: On 12/10/2013 09:39 AM, wwang wrote: which is based on Thomas' patch. Can

Re: [PATCH] NFC: port100: fix leak of usb_device

2014-01-04 Thread Samuel Ortiz
Hi Alexey, On Sun, Jan 05, 2014 at 12:08:05AM +0400, Alexey Khoroshilov wrote: port100_probe() calls usb_get_dev(), but there is no usb_put_dev() in port100_disconnect(). The patch adds one. Found by Linux Driver Verification project (linuxtesting.org). Signed-off-by: Alexey Khoroshilov

Re: 3.12: kernel panic when resuming from suspend to RAM (x86_64)

2013-12-10 Thread Samuel Ortiz
Hi Micky, On Tue, Dec 10, 2013 at 09:56:48AM +0800, micky wrote: Hi Francis: On 12/10/2013 09:39 AM, wwang wrote: which is based on Thomas' patch. Can you help us test this patch, we disable irq while suspend here. I already pushed a patch from Thomas to mfd-fixes that seems to fix the

Re: 3.12: kernel panic when resuming from suspend to RAM (x86_64)

2013-12-09 Thread Samuel Ortiz
Hi Francis, Adding Lee to the Cc list. On Tue, Dec 03, 2013 at 09:14:14AM +0100, Francis Moreau wrote: Now that you did the hard work, I hope driver's maintainer/developper will care about this issue. I applied Thomas' patch to mfd-fixes. Thanks a lot to you and Thomas for that. Cheers,

Re: 3.12: kernel panic when resuming from suspend to RAM (x86_64)

2013-12-09 Thread Samuel Ortiz
Hi Francis, On Mon, Dec 09, 2013 at 08:33:32PM +0100, Francis Moreau wrote: On 12/03/2013 09:14 AM, Francis Moreau wrote: Hello Thomas, On 12/02/2013 12:20 PM, Thomas Gleixner wrote: On Mon, 2 Dec 2013, Thomas Gleixner wrote: On Sat, 30 Nov 2013, Francis Moreau wrote: Hello Thomas,

[GIT] [3.13] MFD fixes

2013-12-08 Thread Samuel Ortiz
Samuel Ortiz (1): Merge tag 'mfd-lee-3.13-fixes-1' of git://git.linaro.org/people/ljones/mfd drivers/mfd/Kconfig | 2 +- drivers/mfd/lpc_ich.c | 2 +- drivers/mfd/ti-ssp.c | 2 +- 3 files changed, 3 insertions(+), 3 deletions(-) -- Intel Open Source Technology Centre http://oss.intel.com

Re: [PATCH] mfd: ti-ssp: Fix build

2013-11-18 Thread Samuel Ortiz
Hi Geert, On Sun, Nov 17, 2013 at 07:53:55PM +0100, Geert Uytterhoeven wrote: drivers/mfd/ti-ssp.c: In function 'ti_ssp_run': drivers/mfd/ti-ssp.c:286:2: error: implicit declaration of function 'set_current_state' [-Werror=implicit-function-declaration]

[GIT] [3.13] MFD pull request

2013-11-15 Thread Samuel Ortiz
: Include linux/of.h header mfd: max77693: Include linux/of.h header Documentation: mfd: Update s2mps11.txt Samuel Ortiz (3): Merge tag 'range-macro' of git://git.kernel.org/.../broonie/regmap Merge tag 'mfd-lee-3.13-1' of git://git.linaro.org/people/ljones/mfd Merge tag

Re: [GIT PULL] mfd: Patches due for v3.13 merge window

2013-11-11 Thread Samuel Ortiz
Hi Lee, On Mon, Nov 11, 2013 at 11:33:08AM +, Lee Jones wrote: Hi Sam, The following changes since commit 61e6cfa80de5760bbe406f4e815b7739205754d2: Linux 3.12-rc5 (2013-10-13 15:41:28 -0700) are available in the git repository at: git://git.linaro.org/people/ljones/mfd.git

Re: [PATCH 4/4] lpc_ich: Add Device IDs for Intel Wildcat Point-LP PCH

2013-11-04 Thread Samuel Ortiz
Hi James, On Mon, Nov 04, 2013 at 09:31:20AM -0800, James Ralston wrote: This patch adds the TCO Watchdog Device IDs for the Intel Wildcat Point-LP PCH. Signed-off-by: James Ralston james.d.rals...@intel.com --- drivers/mfd/lpc_ich.c | 13 + 1 file changed, 13 insertions(+)

Re: [PATCH] mfd: max77693: Fix up bug of wrong interrupt number

2013-11-04 Thread Samuel Ortiz
Hi Chanwoo, On Mon, Nov 04, 2013 at 10:58:20AM +0900, Chanwoo Choi wrote: Ping! Thanks, Chanwoo Choi On 10/10/2013 10:05 AM, Chanwoo Choi wrote: The max77693 MFD device use irq domain method which has hardware interrupt number and virtual interrupt number getting through irq domain

Re: [PATCH] NFC: mei_phy: using kfree_skb() instead of kfree()

2013-11-01 Thread Samuel Ortiz
Hi Salil, On Thu, Oct 31, 2013 at 11:17:46PM +0530, Salil Kapur wrote: using kfree_skb() instead of kfree() for struct sk_buff Signed-off-by: Salil Kapur salilkapu...@gmail.com --- drivers/nfc/mei_phy.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) Applied to nfc-next, thanks.

Re: [PATCH] mfd: as3722: Don't export the regmap config

2013-10-25 Thread Samuel Ortiz
Hi Mark, On Fri, Oct 25, 2013 at 09:10:00PM +0100, Mark Brown wrote: From: Mark Brown broo...@linaro.org It's not used outside this file so can be static. Signed-off-by: Mark Brown broo...@linaro.org --- drivers/mfd/as3722.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)

Re: [GIT PULL] MFD patches due for v3.13

2013-10-24 Thread Samuel Ortiz
Hi Lee, On Wed, Oct 23, 2013 at 04:35:10PM +0100, Lee Jones wrote: The following changes since commit 61e6cfa80de5760bbe406f4e815b7739205754d2: Linux 3.12-rc5 (2013-10-13 15:41:28 -0700) are available in the git repository at: git://git.linaro.org/people/ljones/mfd.git

Re: [REPOST/PATCH] mfd: tps65910: remove warning during dt node parsing

2013-10-10 Thread Samuel Ortiz
Hi Olof, On Wed, Oct 09, 2013 at 05:51:14PM -0700, Olof Johansson wrote: Hi, On Wed, Sep 26, 2012 at 5:48 AM, Laxman Dewangan ldewan...@nvidia.com wrote: Driver throw the warning message if dt node does not have the info for VMBCH-Threshold and VMBCH2-Threshold. These properties are

Re: [REPOST/PATCH] mfd: tps65910: remove warning during dt node parsing

2013-10-10 Thread Samuel Ortiz
Hi Laxman, On Wed, Sep 26, 2012 at 06:18:04PM +0530, Laxman Dewangan wrote: Driver throw the warning message if dt node does not have the info for VMBCH-Threshold and VMBCH2-Threshold. These properties are optional property and hence it is not mandatory to have these on DT node and in this

Re: [PATCH v2 6/9] mfd: wm8994: convert to use I2C core runtime PM

2013-09-12 Thread Samuel Ortiz
On Thu, Sep 12, 2013 at 12:24:47PM +0300, Mika Westerberg wrote: On Wed, Sep 11, 2013 at 06:12:43PM +0200, Samuel Ortiz wrote: I think it would make more sense for you to merge that one together with the related i2c changes. If you prefer that I take it through MFD, please let me know

Re: [PATCH v2 6/9] mfd: wm8994: convert to use I2C core runtime PM

2013-09-11 Thread Samuel Ortiz
. Signed-off-by: Mika Westerberg mika.westerb...@linux.intel.com Acked-by: Samuel Ortiz sa...@linux.intel.com I think it would make more sense for you to merge that one together with the related i2c changes. If you prefer that I take it through MFD, please let me know. Cheers, Samuel

Re: DA9063 driver development

2013-09-06 Thread Samuel Ortiz
Hi Steve, See my answers below: On Fri, Sep 06, 2013 at 10:47:58AM +, Steve Twiss wrote: Hello, I am late into the discussion about the DA9063 driver because I missed the e-mail thread around 24th July (https://lkml.org/lkml/2013/7/24/460) so I only recently noticed that a DA9063

[GIT] [3.12] MFD pull request

2013-09-05 Thread Samuel Ortiz
local variables mfd: timberdale: Staticize local variables mfd: timberdale: Remove redundant break mfd: timberdale: Use module_pci_driver Samuel Ortiz (4): Merge tag 'regmap-irq-ack-mask' of git://git.kernel.org/.../broonie/regmap Merge tag 'mfd-lee-3.12-1' of git

  1   2   3   4   5   6   7   >