Hi Dan,
Thanks for a patch.
> -Original Message-
> From: Dan Carpenter
> Sent: Monday, January 25, 2021 2:14 PM
> To: Nilesh Javali
> Cc: GR-QLogic-Storage-Upstream upstr...@marvell.com>; James E.J. Bottomley ;
> Martin K. Petersen ; Himanshu Madhani
> ; Sa
Hi,
Thanks for a patch.
> -Original Message-
> From: YANG LI
> Sent: Monday, January 11, 2021 2:59 PM
> To: j...@linux.ibm.com
> Cc: martin.peter...@oracle.com; Saurav Kashyap ;
> Javed Hasan ; GR-QLogic-Storage-Upstream qlogic-storage-upstr...@marvell.com>; li...@a
t cnic_fc_npiv_tbl *npiv_tbl;
> struct fc_lport *lport;
>
> - if (interface->enabled == false) {
> + if (!interface->enabled) {
> if (!ctlr->lp) {
> pr_err(PFX "__bnx2fc_enable: lport not found\n");
> return -ENODEV;
>
Thanks for a patch.
Acked-by: Saurav Kashyap
Thanks,
~Saurav
--
> 2.20.0
Hi Tom,
> -Original Message-
> From: t...@redhat.com
> Sent: Sunday, November 1, 2020 8:08 PM
> To: Saurav Kashyap ; Javed Hasan
> ; j...@linux.ibm.com; martin.peter...@oracle.com
> Cc: GR-QLogic-Storage-Upstream upstr...@marvell.com>; linux-s...@vger.ker
Hi Daniel,
> -Original Message-
> From: Daniel Wagner
> Sent: Tuesday, September 24, 2019 12:54 PM
> To: Saurav Kashyap
> Cc: qlogic-storage-upstr...@cavium.com; linux-s...@vger.kernel.org; linux-
> ker...@vger.kernel.org
> Subject: [EXT] Re: [PATCH] scsi: qed
ost)
> {
> @@ -1996,6 +2003,7 @@ static struct fc_function_template
> qedf_fc_transport_fn = {
> .show_host_active_fc4s = 1,
> .show_host_maxframe_size = 1,
>
> + .get_host_port_id = qedf_get_host_port_id,
> .show_host_port_id = 1,
> .show_host_supported_speeds = 1,
> .get_host_speed = fc_get_host_speed,
> --
> 2.16.4
Thanks for the patch.
Acked-by: Saurav Kashyap
> -Original Message-
> From: linux-scsi-ow...@vger.kernel.org On
> Behalf Of Daniel Wagner
> Sent: Monday, September 23, 2019 4:08 PM
> To: qlogic-storage-upstr...@cavium.com
> Cc: linux-s...@vger.kernel.org; linux-kernel@vger.kernel.org; Daniel Wagner
>
> Subject: [PATCH] scsi: qedf:
rio = qedf_default_prio;
> - else if (tmp_prio < 0 || tmp_prio > 7) {
> + else if (tmp_prio > 7) {
> QEDF_INFO(&(qedf->dbg_ctx), QEDF_LOG_DISC,
> "FIP/FCoE prio %d out of range, setting to %d.\n",
> tmp_prio, QEDF_DEFAULT_PRIO);
> --
> 2.6.2
Hi Austin,
Thanks for the patch.
Acked-by: Saurav Kashyap
c_cmd->sense_buffer, rq_data, fcp_sns_len);
>+ if (sc_cmd->sense_buffer) {
>+ memset(sc_cmd->sense_buffer, 0, SCSI_SENSE_BUFFERSIZE);
>+ if (fcp_sns_len)
>+ memcpy(sc_cmd->sense_buffer, rq_data,
Acked-by: Saurav Kashyap
>Change 'Fimware' to 'Firmware'
>Change 'enalbled' to 'enabled'
>
>Signed-off-by: Yannick Guerrini
>---
> drivers/scsi/qla2xxx/qla_init.c | 4 ++--
> drivers/scsi/qla2xxx/qla_mid.c | 2 +-
> 2 files changed, 3 insertions(+), 3 deletions(-)
>
Acked-by: Saurav Kashyap saurav.kash...@qlogic.com
Change 'Fimware' to 'Firmware'
Change 'enalbled' to 'enabled'
Signed-off-by: Yannick Guerrini yguerr...@tomshardware.fr
---
drivers/scsi/qla2xxx/qla_init.c | 4 ++--
drivers/scsi/qla2xxx/qla_mid.c | 2 +-
2 files changed, 3 insertions(+), 3
Acked-by: Saurav Kashyap
Thanks,
~Saurav
-Original Message-
From: Yannick Guerrini
Date: Tuesday, 24 February 2015 3:56 am
To: Dept-Eng QLA2xxx Upstream
Cc: James Bottomley , "triv...@kernel.org"
, linux-kernel , Yannick
Guerrini
Subject: [PATCH] drivers/scsi/qla2xxx: F
Acked-by: Saurav Kashyap saurav.kash...@qlogic.com
Thanks,
~Saurav
-Original Message-
From: Yannick Guerrini yguerr...@tomshardware.fr
Date: Tuesday, 24 February 2015 3:56 am
To: Dept-Eng QLA2xxx Upstream qla2xxx-upstr...@qlogic.com
Cc: James Bottomley jbottom...@parallels.com, triv
Acked-by: Saurav Kashyap
>Remove 2 redundant extern inline functions: qla8044_set_qsnt_ready() and
>qla8044_need_reset_handler(). At present, within upstream next kernel
>source code, they are only used within "drivers/scsi/qla2xxx/qla_nx2.c".
>
>The r
Acked-by: Saurav Kashyap saurav.kash...@qlogic.com
Remove 2 redundant extern inline functions: qla8044_set_qsnt_ready() and
qla8044_need_reset_handler(). At present, within upstream next kernel
source code, they are only used within drivers/scsi/qla2xxx/qla_nx2.c.
The related error and warnings
Acked-by: Saurav Kashyap
>Use the zeroing function instead of dma_alloc_coherent & memset(,0,)
>
>Signed-off-by: Joe Perches
>---
> drivers/scsi/qla2xxx/qla_init.c | 10 --
> 1 file changed, 4 insertions(+), 6 deletions(-)
>
>diff --git a/drivers/scsi/qla2xx
Acked-by: Saurav Kashyap saurav.kash...@qlogic.com
Use the zeroing function instead of dma_alloc_coherent memset(,0,)
Signed-off-by: Joe Perches j...@perches.com
---
drivers/scsi/qla2xxx/qla_init.c | 10 --
1 file changed, 4 insertions(+), 6 deletions(-)
diff --git a/drivers/scsi
Acked-by: Saurav Kashyap
>This issue was reported by coccicheck using the semantic patch
>at scripts/coccinelle/api/memdup.cocci
>
>Signed-off-by: Benoit Taine
>---
>Tested by compilation without errors.
>
> drivers/scsi/qla2xxx/qla_mbx.c |3 +--
> 1 file
Acked-by: Saurav Kashyap saurav.kash...@qlogic.com
This issue was reported by coccicheck using the semantic patch
at scripts/coccinelle/api/memdup.cocci
Signed-off-by: Benoit Taine benoit.ta...@lip6.fr
---
Tested by compilation without errors.
drivers/scsi/qla2xxx/qla_mbx.c |3 +--
1
Acked-by: Saurav Kashyap
>On Tue, May 20, 2014 at 07:36:48AM +0800, Julia Lawall wrote:
>>
>>
>> On Mon, 19 May 2014, Dan Carpenter wrote:
>>
>> > On Mon, May 19, 2014 at 04:07:52PM +, Saurav Kashyap wrote:
>> > > Hi Julia,
>>
Acked-by: Saurav Kashyap saurav.kash...@qlogic.com
On Tue, May 20, 2014 at 07:36:48AM +0800, Julia Lawall wrote:
On Mon, 19 May 2014, Dan Carpenter wrote:
On Mon, May 19, 2014 at 04:07:52PM +, Saurav Kashyap wrote:
Hi Julia,
Status is already set to 0 at the beginning
Hi Julia,
Status is already set to 0 at the beginning of the function, I think
we should just "return status" here to be consistent with the rest of
the function.
==
diff --git a/drivers/scsi/qla2xxx/qla_init.c
b/drivers/scsi/qla2xxx/qla_init.c
index 76af6b6..e339833 100644
---
Hi Julia,
Status is already set to 0 at the beginning of the function, I think
we should just return status here to be consistent with the rest of
the function.
==
diff --git a/drivers/scsi/qla2xxx/qla_init.c
b/drivers/scsi/qla2xxx/qla_init.c
index 76af6b6..e339833 100644
---
Looks good to me.
Acked-by: Saurav Kashyap
>As result of deprecation of MSI-X/MSI enablement functions
>pci_enable_msix() and pci_enable_msi_block() all drivers
>using these two interfaces need to be updated to use the
>new pci_enable_msi_range() and pci_enable_msix_range()
>int
Looks good to me.
Acked-by: Saurav Kashyap saurav.kash...@qlogic.com
As result of deprecation of MSI-X/MSI enablement functions
pci_enable_msix() and pci_enable_msi_block() all drivers
using these two interfaces need to be updated to use the
new pci_enable_msi_range() and pci_enable_msix_range
>On Mon, 2012-10-08 at 11:15 -0500, Saurav Kashyap wrote:
>> Acked-by: Saurav Kashyap
>>
>> Thanks,
>> ~Saurav
>>
>> >Compiling qla_gs.o (part of the qla2xxx module) triggers two GCC
>> >warnings:
>> >drivers/scsi/qla2xxx/qla
On Mon, 2012-10-08 at 11:15 -0500, Saurav Kashyap wrote:
Acked-by: Saurav Kashyap saurav.kash...@qlogic.com
Thanks,
~Saurav
Compiling qla_gs.o (part of the qla2xxx module) triggers two GCC
warnings:
drivers/scsi/qla2xxx/qla_gs.c: In function Œqla2x00_fdmi_rhba¹:
drivers/scsi
Acked-by: Saurav Kashyap
Thanks,
~Saurav
>Correct spelling typo in debug messages within qla2xxx drivers.
>
>Signed-off-by: Masanari Iida
>---
> drivers/scsi/qla2xxx/qla_iocb.c| 2 +-
> drivers/scsi/qla2xxx/qla_isr.c | 4 ++--
> drivers/scsi/qla2xxx/qla_mid.c
Acked-by: Saurav Kashyap saurav.kash...@qlogic.com
Thanks,
~Saurav
Correct spelling typo in debug messages within qla2xxx drivers.
Signed-off-by: Masanari Iida standby2...@gmail.com
---
drivers/scsi/qla2xxx/qla_iocb.c| 2 +-
drivers/scsi/qla2xxx/qla_isr.c | 4 ++--
drivers/scsi
Acked-by: Saurav Kashyap
Thanks,
~Saurav
>Lockdep reports:
>
>=== [ cut here ] ===
> =
> [ INFO: possible irq lock inversion dependency detected ]
> 3.6.0-0.0.0.28.36b5ec9-defa
Acked-by: Saurav Kashyap
Thanks,
~Saurav
>Compiling qla_gs.o (part of the qla2xxx module) triggers two GCC
>warnings:
>drivers/scsi/qla2xxx/qla_gs.c: In function Œqla2x00_fdmi_rhba¹:
>drivers/scsi/qla2xxx/qla_gs.c:1339:7: warning: array subscript is
>above array bounds
Acked-by: Saurav Kashyap saurav.kash...@qlogic.com
Thanks,
~Saurav
Compiling qla_gs.o (part of the qla2xxx module) triggers two GCC
warnings:
drivers/scsi/qla2xxx/qla_gs.c: In function Œqla2x00_fdmi_rhba¹:
drivers/scsi/qla2xxx/qla_gs.c:1339:7: warning: array subscript is
above array
Acked-by: Saurav Kashyap saurav.kash...@qlogic.com
Thanks,
~Saurav
Lockdep reports:
=== [ cut here ] ===
=
[ INFO: possible irq lock inversion dependency detected ]
3.6.0-0.0.0.28.36b5ec9-default #1 Not tainted
>Compiling qla_gs.o (part of the qla2xxx module) triggers two GCC
>warnings:
>drivers/scsi/qla2xxx/qla_gs.c: In function Œqla2x00_fdmi_rhba¹:
>drivers/scsi/qla2xxx/qla_gs.c:1339:7: warning: array subscript is
>above array bounds [-Warray-bounds]
>drivers/scsi/qla2xxx/qla_gs.c: In
Compiling qla_gs.o (part of the qla2xxx module) triggers two GCC
warnings:
drivers/scsi/qla2xxx/qla_gs.c: In function Œqla2x00_fdmi_rhba¹:
drivers/scsi/qla2xxx/qla_gs.c:1339:7: warning: array subscript is
above array bounds [-Warray-bounds]
drivers/scsi/qla2xxx/qla_gs.c: In
35 matches
Mail list logo
