Friendly ping.
> if ((parser->global.usage_page << 16) != HID_UP_GOOGLEVENDOR)
> return;
I'm a bit worried about adding an early return, as it may cause issues
if someone doesn't notice when adding another case. Looking at this again
I can easily remove the second line break now that I've changed the
Add vivaldi HID driver. This driver allows us to read and report the top
row layout of keyboards which provide a vendor-defined (Google) HID
usage.
Signed-off-by: Sean O'Brien
---
drivers/hid/Kconfig | 9 +++
drivers/hid/Makefile | 1 +
drivers/hid/hid-core.c| 7
?
I'm a bit reluctant to merge them. Partly because I'm not familiar with
the hid-google-hammer driver, but mostly because this driver is intended
to handle non-google products which will use a google-defined usage code.
Perhaps I should drop "google" from the driver name?
Thanks,
Sean O'Brien
Add Google vivaldi HID driver. This driver allows us to read and report
the top row layout of keyboards which provide a vendor-defined HID
usage.
Signed-off-by: Sean O'Brien
---
drivers/hid/Kconfig | 9 ++
drivers/hid/Makefile | 1 +
drivers/hid/hid-core.c
Add Google vivaldi HID driver. This driver allows us to read and report
the top row layout of keyboards which provide a vendor-defined HID
usage.
Signed-off-by: Sean O'Brien
---
drivers/hid/Kconfig | 9 ++
drivers/hid/Makefile | 1 +
drivers/hid/hid-core.c
he patch entirely, or is there a strong argument for
> > > keeping the ETP_FWIDTH_REDUCE around?
> > > I suggest you apply the patch, I have no idea why ETP_FWIDTH_REDUCE
> > > existed.
> > > Our FW team know nothing about ETP_FWIDTH_REDUCE ether.
> > >
> > > The only side effect will happen on Chromebook because such computation
> > > have stayed in ChromeOS' kernel for four years.
> > > Chrome's finger/palm threshold may be different from other Linux
> > > distribution.
> > > We will discuss it with Google once the patch picked by chrome and cause
> > > something wrong.
> >
> > Chrome has logic that contact with maximum major/minor is treated as a
> > palm, so here the driver (which originally came from Chrome OS)
> > artificially reduces the contact size to ensure that palm rejection
> > logic does not trigger.
> >
> > I'm adding Harry to confirm whether we are still using this logic and to
> > see if we can adjust it to be something else.
>
> I'm not very familiar with our touchpad code, so adding Sean O'Brien, who is.
Signed-off-by: Marek Wyborski
Signed-off-by: Sean O'Brien
---
drivers/hid/hid-ids.h| 1 +
drivers/hid/hid-magicmouse.c | 142 ---
2 files changed, 132 insertions(+), 11 deletions(-)
diff --git a/drivers/hid/hid-ids.h b/drivers/hid/hid-ids.h
index
Signed-off-by: Marek Wyborski
Signed-off-by: Sean O'Brien
---
drivers/hid/hid-ids.h| 1 +
drivers/hid/hid-magicmouse.c | 142 ---
2 files changed, 132 insertions(+), 11 deletions(-)
diff --git a/drivers/hid/hid-ids.h b/drivers/hid/hid-ids.h
index
On Mon, Oct 1, 2018 at 1:43 AM Benjamin Tissoires
wrote:
>
> [adding Peter, for the libinput question]
>
> On Fri, Sep 21, 2018 at 1:13 AM Sean O'Brien wrote:
> >
> > USB device
> > Vendor 05ac (Apple)
> > Device 0265 (Magic Trackpad 2)
>
On Mon, Oct 1, 2018 at 1:43 AM Benjamin Tissoires
wrote:
>
> [adding Peter, for the libinput question]
>
> On Fri, Sep 21, 2018 at 1:13 AM Sean O'Brien wrote:
> >
> > USB device
> > Vendor 05ac (Apple)
> > Device 0265 (Magic Trackpad 2)
>
Gentle reminder, thank you!
On Thu, Sep 20, 2018 at 4:13 PM Sean O'Brien wrote:
>
> USB device
> Vendor 05ac (Apple)
> Device 0265 (Magic Trackpad 2)
> Bluetooth device
> Vendor 004c (Apple)
> Device 0265 (Magic Trackpad 2)
>
> Add suppo
Gentle reminder, thank you!
On Thu, Sep 20, 2018 at 4:13 PM Sean O'Brien wrote:
>
> USB device
> Vendor 05ac (Apple)
> Device 0265 (Magic Trackpad 2)
> Bluetooth device
> Vendor 004c (Apple)
> Device 0265 (Magic Trackpad 2)
>
> Add suppo
Signed-off-by: Marek Wyborski
Signed-off-by: Sean O'Brien
---
drivers/hid/hid-ids.h| 1 +
drivers/hid/hid-magicmouse.c | 149 +++
2 files changed, 134 insertions(+), 16 deletions(-)
diff --git a/drivers/hid/hid-ids.h b/drivers/hid/hid-ids.h
index
Signed-off-by: Marek Wyborski
Signed-off-by: Sean O'Brien
---
drivers/hid/hid-ids.h| 1 +
drivers/hid/hid-magicmouse.c | 149 +++
2 files changed, 134 insertions(+), 16 deletions(-)
diff --git a/drivers/hid/hid-ids.h b/drivers/hid/hid-ids.h
index
Signed-off-by: Marek Wyborski
Signed-off-by: Sean O'Brien
---
drivers/hid/hid-ids.h| 2 +
drivers/hid/hid-magicmouse.c | 184 ---
2 files changed, 149 insertions(+), 37 deletions(-)
diff --git a/drivers/hid/hid-ids.h b/drivers/hid/hid-ids.h
index
Signed-off-by: Marek Wyborski
Signed-off-by: Sean O'Brien
---
drivers/hid/hid-ids.h| 2 +
drivers/hid/hid-magicmouse.c | 184 ---
2 files changed, 149 insertions(+), 37 deletions(-)
diff --git a/drivers/hid/hid-ids.h b/drivers/hid/hid-ids.h
index
Signed-off-by: Marek Wyborski
Signed-off-by: Sean O'Brien
---
drivers/hid/hid-ids.h| 2 +
drivers/hid/hid-magicmouse.c | 187 ---
2 files changed, 152 insertions(+), 37 deletions(-)
diff --git a/drivers/hid/hid-ids.h b/drivers/hid/hid-ids.h
index
Signed-off-by: Marek Wyborski
Signed-off-by: Sean O'Brien
---
drivers/hid/hid-ids.h| 2 +
drivers/hid/hid-magicmouse.c | 187 ---
2 files changed, 152 insertions(+), 37 deletions(-)
diff --git a/drivers/hid/hid-ids.h b/drivers/hid/hid-ids.h
index
connection.
Add support for the Magic Keyboard over Bluetooth connection, and for
the Magic Keyboard with Numeric Keypad over Bluetooth and USB
connection.
Signed-off-by: Sean O'Brien
---
drivers/hid/hid-apple.c | 9 -
drivers/hid/hid-ids.h | 2 ++
2 files changed, 10 insertions(+), 1
connection.
Add support for the Magic Keyboard over Bluetooth connection, and for
the Magic Keyboard with Numeric Keypad over Bluetooth and USB
connection.
Signed-off-by: Sean O'Brien
---
drivers/hid/hid-apple.c | 9 -
drivers/hid/hid-ids.h | 2 ++
2 files changed, 10 insertions(+), 1
On Mon, Aug 27, 2018 at 5:19 AM Benjamin Tissoires
wrote:
>
> Hi Sean,
>
> On Thu, Aug 23, 2018 at 6:40 PM Sean O'Brien wrote:
> >
> > USB device
> > Vendor 05ac (Apple)
> > Device 026c (Magic Keyboard with Numeric Keypad)
> >
> >
On Mon, Aug 27, 2018 at 5:19 AM Benjamin Tissoires
wrote:
>
> Hi Sean,
>
> On Thu, Aug 23, 2018 at 6:40 PM Sean O'Brien wrote:
> >
> > USB device
> > Vendor 05ac (Apple)
> > Device 026c (Magic Keyboard with Numeric Keypad)
> >
> >
connection.
This patch adds support for the Magic Keyboard over Bluetooth
connection, and for the Magic Keyboard with Numeric Keypad over
Bluetooth and USB connection.
Signed-off-by: Sean O'Brien
---
drivers/hid/hid-apple.c | 9 -
drivers/hid/hid-ids.h| 2 ++
drivers/hid/hid-quirks.c | 3
connection.
This patch adds support for the Magic Keyboard over Bluetooth
connection, and for the Magic Keyboard with Numeric Keypad over
Bluetooth and USB connection.
Signed-off-by: Sean O'Brien
---
drivers/hid/hid-apple.c | 9 -
drivers/hid/hid-ids.h| 2 ++
drivers/hid/hid-quirks.c | 3
25 matches
Mail list logo
