> -Original Message-
> From: Matt Fleming [mailto:m...@console-pimps.org]
> Sent: Wednesday, November 27, 2013 6:45 AM
> To: Madper Xie
> Cc: 'linux-kernel@vger.kernel.org'; linux-...@vger.kernel.org;
> matt.flem...@intel.com; Seiji Aguchi; rich...@nod.at; Tony
-Original Message-
From: Matt Fleming [mailto:m...@console-pimps.org]
Sent: Wednesday, November 27, 2013 6:45 AM
To: Madper Xie
Cc: 'linux-kernel@vger.kernel.org'; linux-...@vger.kernel.org;
matt.flem...@intel.com; Seiji Aguchi; rich...@nod.at; Tony Luck
Subject: Re: [PATCH v2
> Seiji - are you okay with this? If so I'll just make a quick patch now.
>
I'm OK with it.
Seiji
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majord...@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Seiji - are you okay with this? If so I'll just make a quick patch now.
I'm OK with it.
Seiji
--
To unsubscribe from this list: send the line unsubscribe linux-kernel in
the body of a message to majord...@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Commit-ID: d34603b07c4255b2b00a546d34f297ccd50ae4c6
Gitweb: http://git.kernel.org/tip/d34603b07c4255b2b00a546d34f297ccd50ae4c6
Author: Seiji Aguchi
AuthorDate: Wed, 30 Oct 2013 16:39:03 -0400
Committer: H. Peter Anvin
CommitDate: Fri, 8 Nov 2013 14:15:49 -0800
x86, trace: Add page
Commit-ID: 25c74b10bacead867478480170083f69cfc0db48
Gitweb: http://git.kernel.org/tip/25c74b10bacead867478480170083f69cfc0db48
Author: Seiji Aguchi
AuthorDate: Wed, 30 Oct 2013 16:37:00 -0400
Committer: H. Peter Anvin
CommitDate: Fri, 8 Nov 2013 14:15:45 -0800
x86, trace: Register
Commit-ID: ac7956e2699380b8b10146ec2ba8cbe43a03ff7a
Gitweb: http://git.kernel.org/tip/ac7956e2699380b8b10146ec2ba8cbe43a03ff7a
Author: Seiji Aguchi
AuthorDate: Wed, 30 Oct 2013 16:37:47 -0400
Committer: H. Peter Anvin
CommitDate: Fri, 8 Nov 2013 14:15:47 -0800
x86, trace: Delete
Commit-ID: 959c071f0974cda7702d7574647de7ad9259eb57
Gitweb: http://git.kernel.org/tip/959c071f0974cda7702d7574647de7ad9259eb57
Author: Seiji Aguchi
AuthorDate: Wed, 30 Oct 2013 16:36:08 -0400
Committer: H. Peter Anvin
CommitDate: Fri, 8 Nov 2013 14:15:44 -0800
x86, trace: Remove
Commit-ID: ac7956e2699380b8b10146ec2ba8cbe43a03ff7a
Gitweb: http://git.kernel.org/tip/ac7956e2699380b8b10146ec2ba8cbe43a03ff7a
Author: Seiji Aguchi seiji.agu...@hds.com
AuthorDate: Wed, 30 Oct 2013 16:37:47 -0400
Committer: H. Peter Anvin h...@linux.intel.com
CommitDate: Fri, 8 Nov 2013
Commit-ID: d34603b07c4255b2b00a546d34f297ccd50ae4c6
Gitweb: http://git.kernel.org/tip/d34603b07c4255b2b00a546d34f297ccd50ae4c6
Author: Seiji Aguchi seiji.agu...@hds.com
AuthorDate: Wed, 30 Oct 2013 16:39:03 -0400
Committer: H. Peter Anvin h...@linux.intel.com
CommitDate: Fri, 8 Nov 2013
Commit-ID: 25c74b10bacead867478480170083f69cfc0db48
Gitweb: http://git.kernel.org/tip/25c74b10bacead867478480170083f69cfc0db48
Author: Seiji Aguchi seiji.agu...@hds.com
AuthorDate: Wed, 30 Oct 2013 16:37:00 -0400
Committer: H. Peter Anvin h...@linux.intel.com
CommitDate: Fri, 8 Nov 2013
Commit-ID: 959c071f0974cda7702d7574647de7ad9259eb57
Gitweb: http://git.kernel.org/tip/959c071f0974cda7702d7574647de7ad9259eb57
Author: Seiji Aguchi seiji.agu...@hds.com
AuthorDate: Wed, 30 Oct 2013 16:36:08 -0400
Committer: H. Peter Anvin h...@linux.intel.com
CommitDate: Fri, 8 Nov 2013
> How does efivars backend handle "unlink(2)" in the pstore file system.
> pstore will call the backend->erase function passing the "id". The
> backend should then erase the right record from persistent storage.
>
> With the ((timestamp * 100 + part) * 100 + count function - you can
> easily
How does efivars backend handle unlink(2) in the pstore file system.
pstore will call the backend-erase function passing the id. The
backend should then erase the right record from persistent storage.
With the ((timestamp * 100 + part) * 100 + count function - you can
easily reverse it to
> What about feeding the bytes of all three integers into a non-cryptographic
> hash function?
> Using this way you get a cheap unique id.
It is reasonable to me.
Seiji
> >> +{
> >> + char id_str[64];
> >> + u64 id = 0;
> >> +
> >> + sprintf(id_str, "%lu%u%d", timestamp, part, count);
> >> + if (kstrtoull(id_str, 10, ))
> >> + pr_warn("efi-pstore: failed to generate id\n");
> >> + return id;
> >> +}
> >
> > This is just
+{
+ char id_str[64];
+ u64 id = 0;
+
+ sprintf(id_str, %lu%u%d, timestamp, part, count);
+ if (kstrtoull(id_str, 10, id))
+ pr_warn(efi-pstore: failed to generate id\n);
+ return id;
+}
This is just odd. You make a string from
What about feeding the bytes of all three integers into a non-cryptographic
hash function?
Using this way you get a cheap unique id.
It is reasonable to me.
Seiji
> I also like option 1 ... but I think the "id" should be a persistent value for
> a given saved record. So some func(timestamp, part, count) would be a
> good idea. If we try using "sequential" numbers - and don't manage to
> clear out /sys/fs/pstore each time - then we may have the same
.kernel.org
> [mailto:linux-efi-ow...@vger.kernel.org] On Behalf Of Madper Xie
> Sent: Wednesday, October 30, 2013 11:01 PM
> To: Luck, Tony
> Cc: Seiji Aguchi; Madper Xie; keesc...@chromium.org; ccr...@android.com;
> an...@enomsg.org; linux-...@vger.kernel.org; linux-
> ker...@vg
: Wednesday, October 30, 2013 11:01 PM
To: Luck, Tony
Cc: Seiji Aguchi; Madper Xie; keesc...@chromium.org; ccr...@android.com;
an...@enomsg.org; linux-...@vger.kernel.org; linux-
ker...@vger.kernel.org; bbbo...@gmail.com
Subject: Re: [PATCH 0/2] make all stored entries accessible.
tony.l
I also like option 1 ... but I think the id should be a persistent value for
a given saved record. So some func(timestamp, part, count) would be a
good idea. If we try using sequential numbers - and don't manage to
clear out /sys/fs/pstore each time - then we may have the same dmesg
file
> Ah - I was expecting that the backend driver would have a unique "id" for
> each record stored ... but is seems that this isn't true for efivars.
>
So, do you mean efivars should fix to use the "id" in a proper way?
I acked Madper's patch 2/2 earlier today, but when I look at your test
Currently irq vector handlers for tracing are registered in both set_intr_gate()
and __trace_alloc_intr_gate() in alloc_intr_gate().
But, we don't need to do that twice.
So, let's delete __trace_alloc_intr_gate().
Signed-off-by: Seiji Aguchi
---
arch/x86/include/asm/desc.h | 22
if it comes from the page fault events.
Signed-off-by: Seiji Aguchi
---
arch/x86/include/asm/trace/exceptions.h | 52 +
arch/x86/mm/Makefile| 2 ++
arch/x86/mm/fault.c | 13 +
3 files changed, 67 insertions(+)
create mode
t() to add tracepoints
in a subsequent patch.
Signed-off-by: Seiji Aguchi
---
arch/x86/include/asm/desc.h| 28 +++-
arch/x86/include/asm/hw_irq.h | 3 +++
arch/x86/include/asm/segment.h | 3 +++
arch/x86/include/asm/traps.h | 20
arch/x86/kernel/
Change from v3:
- Separate modifications to make review easy.
- Refactor implementations registering exception/irq_vector
handers. (Patch 1, 2, 3)
This series introduce page fault tracepoints.
Detailed descriptions are explained in each patch.
Any comments are welcome.
Seiji Aguchi (4
Move set_intr_gate() into a macro by removing __alloc_intr_gate().
The purpose is to avoid failing a kernel build after applying
a subsequent patch which changes set_intr_gate() to macro.
Signed-off-by: Seiji Aguchi
---
arch/x86/include/asm/desc.h | 7 +--
1 file changed, 1 insertion(+), 6
[] SyS_mount+0x83/0xc0
[1.158207] [] system_call_fastpath+0x16/0x1b
[1.158207] ---[ end trace 61981bc62de9f6f4 ]---
Signed-off-by: Seiji Aguchi
---
drivers/firmware/efi/efi-pstore.c | 143 +++---
drivers/firmware/efi/efivars.c| 12 ++--
drivers/firmwar
> On Fri, 18 Oct, at 10:30:58PM, Seiji Aguchi wrote:
> > The scanning and deleting logic is still needed. In case an entry(A)
> > is found, the pointer is saved to psi->data. And efi_pstore_read()
> > passes the entry(A) to a pstore filesystem by relea
> -Original Message-
> From: Madper Xie [mailto:c...@redhat.com]
> Sent: Wednesday, October 30, 2013 5:45 AM
> To: tony.l...@intel.com; keesc...@chromium.org; ccr...@android.com;
> an...@enomsg.org; Seiji Aguchi
> Cc: linux-...@vger.kernel.org; linux-kernel@vger.k
> -Original Message-
> From: Madper Xie [mailto:c...@redhat.com]
> Sent: Wednesday, October 30, 2013 5:45 AM
> To: tony.l...@intel.com; keesc...@chromium.org; ccr...@android.com;
> an...@enomsg.org; Seiji Aguchi
> Cc: linux-...@vger.kernel.org; linux-kernel@vger.k
-Original Message-
From: Madper Xie [mailto:c...@redhat.com]
Sent: Wednesday, October 30, 2013 5:45 AM
To: tony.l...@intel.com; keesc...@chromium.org; ccr...@android.com;
an...@enomsg.org; Seiji Aguchi
Cc: linux-...@vger.kernel.org; linux-kernel@vger.kernel.org;
bbbo
-Original Message-
From: Madper Xie [mailto:c...@redhat.com]
Sent: Wednesday, October 30, 2013 5:45 AM
To: tony.l...@intel.com; keesc...@chromium.org; ccr...@android.com;
an...@enomsg.org; Seiji Aguchi
Cc: linux-...@vger.kernel.org; linux-kernel@vger.kernel.org;
bbbo
On Fri, 18 Oct, at 10:30:58PM, Seiji Aguchi wrote:
The scanning and deleting logic is still needed. In case an entry(A)
is found, the pointer is saved to psi-data. And efi_pstore_read()
passes the entry(A) to a pstore filesystem by releasing
__efivars-lock.
And then, the pstore
[1.158207] [8115b51b] ? strndup_user+0x4b/0xf0
[1.158207] [811cc373] SyS_mount+0x83/0xc0
[1.158207] [81673cc2] system_call_fastpath+0x16/0x1b
[1.158207] ---[ end trace 61981bc62de9f6f4 ]---
Signed-off-by: Seiji Aguchi seiji.agu...@hds.com
---
drivers/firmware/efi
Change from v3:
- Separate modifications to make review easy.
- Refactor implementations registering exception/irq_vector
handers. (Patch 1, 2, 3)
This series introduce page fault tracepoints.
Detailed descriptions are explained in each patch.
Any comments are welcome.
Seiji Aguchi (4
in a subsequent patch.
Signed-off-by: Seiji Aguchi seiji.agu...@hds.com
---
arch/x86/include/asm/desc.h| 28 +++-
arch/x86/include/asm/hw_irq.h | 3 +++
arch/x86/include/asm/segment.h | 3 +++
arch/x86/include/asm/traps.h | 20
arch/x86
Move set_intr_gate() into a macro by removing __alloc_intr_gate().
The purpose is to avoid failing a kernel build after applying
a subsequent patch which changes set_intr_gate() to macro.
Signed-off-by: Seiji Aguchi seiji.agu...@hds.com
---
arch/x86/include/asm/desc.h | 7 +--
1 file
Currently irq vector handlers for tracing are registered in both set_intr_gate()
and __trace_alloc_intr_gate() in alloc_intr_gate().
But, we don't need to do that twice.
So, let's delete __trace_alloc_intr_gate().
Signed-off-by: Seiji Aguchi seiji.agu...@hds.com
---
arch/x86/include/asm/desc.h
if it comes from the page fault events.
Signed-off-by: Seiji Aguchi seiji.agu...@hds.com
---
arch/x86/include/asm/trace/exceptions.h | 52 +
arch/x86/mm/Makefile| 2 ++
arch/x86/mm/fault.c | 13 +
3 files changed, 67
Ah - I was expecting that the backend driver would have a unique id for
each record stored ... but is seems that this isn't true for efivars.
So, do you mean efivars should fix to use the id in a proper way?
I acked Madper's patch 2/2 earlier today, but when I look at your test result,
I'm
To distinguish all events more precisely, "count" is needed to add to the name.
Please see the commit below.
755d4fe46529018ae45bc7c86df682de45ace764
Seiji
> -Original Message-
> From: Madper Xie [mailto:c...@redhat.com]
> Sent: Monday, October 28, 2013 9:22 AM
>
To distinguish all events more precisely, count is needed to add to the name.
Please see the commit below.
755d4fe46529018ae45bc7c86df682de45ace764
Seiji
-Original Message-
From: Madper Xie [mailto:c...@redhat.com]
Sent: Monday, October 28, 2013 9:22 AM
To: Tony Luck; Seiji Aguchi
Matt,
> It seems to me that because you're no longer dropping __efivars->lock
> when reading from the EFI variable store, you actually don't need all
> the ->scanning and ->deleting logic because anything that sets those
> flags runs to completion while holding the lock.
The scanning and
Matt,
It seems to me that because you're no longer dropping __efivars-lock
when reading from the EFI variable store, you actually don't need all
the -scanning and -deleting logic because anything that sets those
flags runs to completion while holding the lock.
The scanning and deleting logic
ctober 17, 2013 11:07 AM
> To: Madper Xie
> Cc: Seiji Aguchi; linux-kernel@vger.kernel.org; linux-...@vger.kernel.org;
> matt.flem...@intel.com; tony.l...@intel.com; Tomoki
> Sekiyama; dle-deve...@lists.sourceforge.net
> Subject: Re: [PATCH v3] efivars,efi-pstore: Hold off deletion
Hi Madper,
I tested this patch on 3.12-rc4.
Could you please send me the log when you failed to apply?
Seiji
> -Original Message-
> From: Madper Xie [mailto:c...@redhat.com]
> Sent: Thursday, October 17, 2013 1:54 AM
> To: Seiji Aguchi
> Cc: linux-kernel@vger.ke
Hi Madper,
I tested this patch on 3.12-rc4.
Could you please send me the log when you failed to apply?
Seiji
-Original Message-
From: Madper Xie [mailto:c...@redhat.com]
Sent: Thursday, October 17, 2013 1:54 AM
To: Seiji Aguchi
Cc: linux-kernel@vger.kernel.org; linux
11:07 AM
To: Madper Xie
Cc: Seiji Aguchi; linux-kernel@vger.kernel.org; linux-...@vger.kernel.org;
matt.flem...@intel.com; tony.l...@intel.com; Tomoki
Sekiyama; dle-deve...@lists.sourceforge.net
Subject: Re: [PATCH v3] efivars,efi-pstore: Hold off deletion of sysfs entry
until, the scan
> There's also an "either/or" choice between using efi-capsule with pstore, and
> the
> traditional kexec/kdump method for getting a memory dump from a crash. We
> have to go through a reset to save the capsule - but we don't want a reset for
> kexec. Perhaps we can pass the reset parameters
> +#define efi_call_reset_virt(f, args...)
> \
> +({ \
> + unsigned long __flags; \
> + bool __nmi = in_nmi();
Thank you for reviewing.
> > http://marc.info/?l=linux-mm=136807959830182=2
> > http://marc.info/?l=linux-mm=136807959130175=2
> >
>
> For permanence, please use links of the form:
>
> http://lkml.kernel.org/r/message-id
>
> (Yes, they currently point to marc.info, but can be
Thank you for reviewing.
http://marc.info/?l=linux-mmm=136807959830182w=2
http://marc.info/?l=linux-mmm=136807959130175w=2
For permanence, please use links of the form:
http://lkml.kernel.org/r/message-id
(Yes, they currently point to marc.info, but can be redirected
+#define efi_call_reset_virt(f, args...)
\
+({ \
+ unsigned long __flags; \
+ bool __nmi = in_nmi();
There's also an either/or choice between using efi-capsule with pstore, and
the
traditional kexec/kdump method for getting a memory dump from a crash. We
have to go through a reset to save the capsule - but we don't want a reset for
kexec. Perhaps we can pass the reset parameters through
Peter,
Any comment?
Seiji
> -Original Message-
> From: linux-kernel-ow...@vger.kernel.org
> [mailto:linux-kernel-ow...@vger.kernel.org] On Behalf Of Seiji Aguchi
> Sent: Monday, September 09, 2013 5:56 PM
> To: linux-kernel@vger.kernel.org; x...@kernel.org
> Cc: h.
Matt,
I submitted a v3 patch based on my comment below..
Seiji
> -Original Message-
> From: linux-efi-ow...@vger.kernel.org
> [mailto:linux-efi-ow...@vger.kernel.org] On Behalf Of Seiji Aguchi
> Sent: Wednesday, October 09, 2013 12:37 PM
> To: Matt Fleming
>
__alloc_percpu+0x10/0x20
[1.158207] [] vfs_kern_mount+0x63/0xf0
[1.158207] [] do_mount+0x23e/0xa20
[1.158207] [] ? strndup_user+0x4b/0xf0
[1.158207] [] SyS_mount+0x83/0xc0
[1.158207] [] system_call_fastpath+0x16/0x1b
[1.158207] ---[ end trace 61981bc62de9f6f4 ]---
Si
] system_call_fastpath+0x16/0x1b
[1.158207] ---[ end trace 61981bc62de9f6f4 ]---
Signed-off-by: Seiji Aguchi seiji.agu...@hds.com
---
drivers/firmware/efi/efi-pstore.c | 143 +++---
drivers/firmware/efi/efivars.c| 12 ++--
drivers/firmware/efi/vars.c | 12
Matt,
I submitted a v3 patch based on my comment below..
Seiji
-Original Message-
From: linux-efi-ow...@vger.kernel.org
[mailto:linux-efi-ow...@vger.kernel.org] On Behalf Of Seiji Aguchi
Sent: Wednesday, October 09, 2013 12:37 PM
To: Matt Fleming
Cc: linux-kernel@vger.kernel.org
Peter,
Any comment?
Seiji
-Original Message-
From: linux-kernel-ow...@vger.kernel.org
[mailto:linux-kernel-ow...@vger.kernel.org] On Behalf Of Seiji Aguchi
Sent: Monday, September 09, 2013 5:56 PM
To: linux-kernel@vger.kernel.org; x...@kernel.org
Cc: h...@zytor.com; rost
Thank you for reviewing.
In my understanding, your point is that all accesses to efivar_entry should be
done while holding __efivars->lock.
> > @@ -88,8 +103,9 @@ static int efi_pstore_read_func(struct efivar_entry
> > *entry, void *data)
> > return 0;
> >
> >
Thank you for reviewing.
In my understanding, your point is that all accesses to efivar_entry should be
done while holding __efivars-lock.
@@ -88,8 +103,9 @@ static int efi_pstore_read_func(struct efivar_entry
*entry, void *data)
return 0;
entry-var.DataSize = 1024;
Are there anyone who can review this bugfix?
Seiji
> -Original Message-
> From: linux-kernel-ow...@vger.kernel.org
> [mailto:linux-kernel-ow...@vger.kernel.org] On Behalf Of Seiji Aguchi
> Sent: Friday, September 27, 2013 4:24 PM
> To: linux-kernel@vger.ke
Are there anyone who can review this bugfix?
Seiji
-Original Message-
From: linux-kernel-ow...@vger.kernel.org
[mailto:linux-kernel-ow...@vger.kernel.org] On Behalf Of Seiji Aguchi
Sent: Friday, September 27, 2013 4:24 PM
To: linux-kernel@vger.kernel.org; linux-...@vger.kernel.org
] ---[ end trace 61981bc62de9f6f4 ]---
Signed-off-by: Seiji Aguchi
---
drivers/firmware/efi/efi-pstore.c | 145 +++---
drivers/firmware/efi/efivars.c| 3 +-
drivers/firmware/efi/vars.c | 39 +++---
include/linux/efi.h | 4 +-
4 files
] [811cc373] SyS_mount+0x83/0xc0
[1.158207] [81673cc2] system_call_fastpath+0x16/0x1b
[1.158207] ---[ end trace 61981bc62de9f6f4 ]---
Signed-off-by: Seiji Aguchi seiji.agu...@hds.com
---
drivers/firmware/efi/efi-pstore.c | 145 +++---
drivers
efivars works fine with this v2 patch.
Tested-by: Seiji Aguchi
> -Original Message-
> From: Aruna Balakrishnaiah [mailto:ar...@linux.vnet.ibm.com]
> Sent: Thursday, September 12, 2013 2:51 AM
> To: linuxppc-...@ozlabs.org; tony.l...@intel.com; Seiji Aguchi;
&g
efivars works fine with this v2 patch.
Tested-by: Seiji Aguchi seiji.agu...@hds.com
-Original Message-
From: Aruna Balakrishnaiah [mailto:ar...@linux.vnet.ibm.com]
Sent: Thursday, September 12, 2013 2:51 AM
To: linuxppc-...@ozlabs.org; tony.l...@intel.com; Seiji Aguchi;
linux
add my "Tested-by" to all three patches.
Tested-by: Seiji Aguchi
N�r��yb�X��ǧv�^�){.n�+{zX����ܨ}���Ơz�:+v���zZ+��+zf���h���~i���z� �w���?�&�)ߢf��^jǫy�m��@A�a���
0��h���i
three patches.
Tested-by: Seiji Aguchi seiji.agu...@hds.com
N�r��yb�X��ǧv�^�){.n�+{zX����ܨ}���Ơz�j:+v���zZ+��+zf���h���~i���z� �w���?��)ߢf��^jǫy�m��@A�a���
0��h���i
trace IDT and non-trace handler to normal IDT.
Signed-off-by: Seiji Aguchi
---
arch/x86/include/asm/desc.h | 33 +
arch/x86/include/asm/hw_irq.h | 14 -
arch/x86/include/asm/trace/exceptions.h | 52 +
arch/x86/in
IDT and non-trace handler to normal IDT.
Signed-off-by: Seiji Aguchi seiji.agu...@hds.com
---
arch/x86/include/asm/desc.h | 33 +
arch/x86/include/asm/hw_irq.h | 14 -
arch/x86/include/asm/trace/exceptions.h | 52
> -Original Message-
> From: Steven Rostedt [mailto:rost...@goodmis.org]
> Sent: Friday, September 06, 2013 12:50 PM
> To: Seiji Aguchi
> Cc: linux-kernel@vger.kernel.org; x...@kernel.org; h...@zytor.com;
> mi...@elte.hu; b...@alien8.de; t...@linutronix.de;
&g
Any comment?
> -Original Message-
> From: linux-kernel-ow...@vger.kernel.org
> [mailto:linux-kernel-ow...@vger.kernel.org] On Behalf Of Seiji Aguchi
> Sent: Friday, August 23, 2013 11:38 AM
> To: linux-kernel@vger.kernel.org; x...@kernel.org
> Cc: h...@zytor.com; rost.
Any comment?
-Original Message-
From: linux-kernel-ow...@vger.kernel.org
[mailto:linux-kernel-ow...@vger.kernel.org] On Behalf Of Seiji Aguchi
Sent: Friday, August 23, 2013 11:38 AM
To: linux-kernel@vger.kernel.org; x...@kernel.org
Cc: h...@zytor.com; rost...@goodmis.org; mi
-Original Message-
From: Steven Rostedt [mailto:rost...@goodmis.org]
Sent: Friday, September 06, 2013 12:50 PM
To: Seiji Aguchi
Cc: linux-kernel@vger.kernel.org; x...@kernel.org; h...@zytor.com;
mi...@elte.hu; b...@alien8.de; t...@linutronix.de;
fdesl...@gmail.com; raphael.beamo
tel.com]
> Sent: Wednesday, September 04, 2013 12:11 PM
> To: Aruna Balakrishnaiah; Seiji Aguchi
> Cc: jkeni...@linux.vnet.ibm.com; keesc...@chromium.org;
> mah...@linux.vnet.ibm.com; ccr...@android.com; linux-
> ker...@vger.kernel.org; linuxppc-...@ozlabs.org; cbouatmai...@gmail.com
>
, September 04, 2013 12:11 PM
To: Aruna Balakrishnaiah; Seiji Aguchi
Cc: jkeni...@linux.vnet.ibm.com; keesc...@chromium.org;
mah...@linux.vnet.ibm.com; ccr...@android.com; linux-
ker...@vger.kernel.org; linuxppc-...@ozlabs.org; cbouatmai...@gmail.com
Subject: RE: [RFC PATCH v2 04/11] pstore: Add
Aruna,
Sorry for the late response.
> Seiji,
>
> Could you let us know the efivars buffer size with which the pstore is
> registered when
> the failure occurred.
I looked into the issue today.
I added some debug message just before pstore_compress().
As you can see below, the buffer size is a
Aruna,
Sorry for the late response.
Seiji,
Could you let us know the efivars buffer size with which the pstore is
registered when
the failure occurred.
I looked into the issue today.
I added some debug message just before pstore_compress().
As you can see below, the buffer size is a
non-trace handler to normal IDT.
Signed-off-by: Seiji Aguchi
---
arch/x86/include/asm/desc.h | 33 +
arch/x86/include/asm/hw_irq.h | 14 -
arch/x86/include/asm/trace/exceptions.h | 51 +
arch/x86/include/asm/trap
and non-trace handler to normal IDT.
Signed-off-by: Seiji Aguchi seiji.agu...@hds.com
---
arch/x86/include/asm/desc.h | 33 +
arch/x86/include/asm/hw_irq.h | 14 -
arch/x86/include/asm/trace/exceptions.h | 51 +
arch/x86
> -Original Message-
> From: Luck, Tony [mailto:tony.l...@intel.com]
> Sent: Thursday, August 22, 2013 7:17 PM
> To: Seiji Aguchi; Aruna Balakrishnaiah; linuxppc-...@ozlabs.org;
> linux-kernel@vger.kernel.org; keesc...@chromium.org
> Cc: jkeni...@linux.vnet.ibm.com; an
> * callback from kmsg_dump. (s2,l2) has the most recently
> * written bytes, older bytes are in (s1,l1). Save as much
> @@ -148,23 +243,56 @@ static void pstore_dump(struct kmsg_dumper *dumper,
> char *dst;
> unsigned long size;
> int hsize;
> +
> -Original Message-
> From: linux-kernel-ow...@vger.kernel.org
> [mailto:linux-kernel-ow...@vger.kernel.org] On Behalf Of Aruna Balakrishnaiah
> Sent: Friday, August 16, 2013 9:18 AM
> To: linuxppc-...@ozlabs.org; tony.l...@intel.com;
> linux-kernel@vger.kernel.org;
> Printing the regs pointer is rather useless. This is specific for x86,
> why not print the ip of where it happened and the faulting address
> itself?
Thank you for reviewing.
I will change the regs pointer to ip.
> Note, you only need to change the TP_printk() to do that. For
> efficiency
Printing the regs pointer is rather useless. This is specific for x86,
why not print the ip of where it happened and the faulting address
itself?
Thank you for reviewing.
I will change the regs pointer to ip.
Note, you only need to change the TP_printk() to do that. For
efficiency reasons,
-Original Message-
From: linux-kernel-ow...@vger.kernel.org
[mailto:linux-kernel-ow...@vger.kernel.org] On Behalf Of Aruna Balakrishnaiah
Sent: Friday, August 16, 2013 9:18 AM
To: linuxppc-...@ozlabs.org; tony.l...@intel.com;
linux-kernel@vger.kernel.org; keesc...@chromium.org
* callback from kmsg_dump. (s2,l2) has the most recently
* written bytes, older bytes are in (s1,l1). Save as much
@@ -148,23 +243,56 @@ static void pstore_dump(struct kmsg_dumper *dumper,
char *dst;
unsigned long size;
int hsize;
+
-Original Message-
From: Luck, Tony [mailto:tony.l...@intel.com]
Sent: Thursday, August 22, 2013 7:17 PM
To: Seiji Aguchi; Aruna Balakrishnaiah; linuxppc-...@ozlabs.org;
linux-kernel@vger.kernel.org; keesc...@chromium.org
Cc: jkeni...@linux.vnet.ibm.com; ana...@in.ibm.com; b
]---
Signed-off-by: Seiji Aguchi
---
drivers/firmware/efi/efi-pstore.c | 145 +++---
drivers/firmware/efi/efivars.c| 3 +-
drivers/firmware/efi/vars.c | 39 +++---
include/linux/efi.h | 4 +-
4 files changed, 151 insertions(+), 40
[1.158207] [81673cc2] system_call_fastpath+0x16/0x1b
[1.158207] ---[ end trace 61981bc62de9f6f4 ]---
Signed-off-by: Seiji Aguchi seiji.agu...@hds.com
---
drivers/firmware/efi/efi-pstore.c | 145 +++---
drivers/firmware/efi/efivars.c| 3
Any comment?
> -Original Message-
> From: Seiji Aguchi [mailto:seiji.agu...@hds.com]
> Sent: Tuesday, July 30, 2013 6:53 PM
> To: linux-kernel@vger.kernel.org; x...@kernel.org
> Cc: h...@zytor.com; rost...@goodmis.org; mi...@elte.hu; b...@alien8.de;
> t...@li
Any comment?
-Original Message-
From: Seiji Aguchi [mailto:seiji.agu...@hds.com]
Sent: Tuesday, July 30, 2013 6:53 PM
To: linux-kernel@vger.kernel.org; x...@kernel.org
Cc: h...@zytor.com; rost...@goodmis.org; mi...@elte.hu; b...@alien8.de;
t...@linutronix.de; fdesl...@gmail.com
-trace handler to IDT.
This is used at boot time which tracing is disabled.
- Make set_intr_gate() macro so that it can register trace handler to
trace IDT and non-trace handler to normal IDT.
Signed-off-by: Seiji Aguchi
---
arch/x86/include/asm/desc.h | 33
non-trace handler to IDT.
This is used at boot time which tracing is disabled.
- Make set_intr_gate() macro so that it can register trace handler to
trace IDT and non-trace handler to normal IDT.
Signed-off-by: Seiji Aguchi seiji.agu...@hds.com
---
arch/x86/include/asm/desc.h
> -Original Message-
> From: H. Peter Anvin [mailto:h...@zytor.com]
> Sent: Friday, July 05, 2013 12:41 PM
> To: Thomas Gleixner
> Cc: Dave Jones; Linus Torvalds; Linux Kernel; Ingo Molnar; Peter Zijlstra;
> Seiji Aguchi
> Subject: Re: Yet more softlockups.
>
Commit-ID: 4787c368a9bca39e173d702389ee2eaf0520abc1
Gitweb: http://git.kernel.org/tip/4787c368a9bca39e173d702389ee2eaf0520abc1
Author: Seiji Aguchi
AuthorDate: Fri, 28 Jun 2013 14:02:11 -0400
Committer: Ingo Molnar
CommitDate: Tue, 2 Jul 2013 09:52:31 +0200
x86/tracing: Add irq_enter
1 - 100 of 598 matches
Mail list logo
