Re: [PATCH v2 1/3] mmc: sdhci: add support for using external DMA devices

2018-11-29 Thread Shawn Lin
On 2018/11/29 17:59, Chunyan Zhang wrote: Hi Adrian, On Thu, 29 Nov 2018 at 15:36, Adrian Hunter wrote: On 29/11/18 8:22 AM, Chunyan Zhang wrote: On Tue, 20 Nov 2018 at 21:41, Adrian Hunter wrote: On 12/11/18 9:26 AM, Chunyan Zhang wrote: Some standard SD host controllers can support

Re: [PATCH v3] arm64: dts: rockchip: Add DT for nanopc-t4

2018-11-26 Thread Shawn Lin
On 2018/11/27 7:48, Heiko Stuebner wrote: Hi Tomeu, Am Montag, 26. November 2018, 15:47:49 CET schrieb Tomeu Vizoso: This adds a device tree for the NanoPC-T4 SBC, which is based on the Rockchip RK3399 SoC and marketed by FriendlyELEC. Known working: - Serial - Ethernet - HDMI - USB 2.0 All

Re: dw_mmc: IDMAC Invalidate cache after read

2018-11-26 Thread Shawn Lin
On 2018/11/23 23:29, Robin Murphy wrote: Hi Jan, [repeating some of the discussion from your other thread for the benefit of the MMC audience] On 21/11/2018 07:42, JABLONSKY Jan wrote: CPU may not see most up-to-date and correct copy of DMA buffer, when internal DMA controller is in use.

Re: [PATCH] ARM64: dts: rockchip: add some pins to rk3399

2018-06-13 Thread Shawn Lin
<4 24 RK_FUNC_GPIO _pull_none>; }; }; -- 2.14.4 Could we actually use RK_Pxx for all new pin definitions? Would increase readability a lot. Thanks, Klaus -- Best Regards Shawn Lin

Re: [PATCH] mmc: Move the mmc driver init earlier

2018-06-12 Thread Shawn Lin
mc" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html -- Best Regards Shawn Lin

Re: [PATCH] mmc: dw_mmc: fix card threshold control configuration

2018-06-11 Thread Shawn Lin
On 2018/6/11 20:20, Ulf Hansson wrote: + Shawn Lin, Evgeniy Didin, Doug Andersson On 29 May 2018 at 12:38, Qing Xia wrote: From: x00270170 Card write threshold control is supposed to be set since controller version 2.80a for data write in HS400 mode and data read in HS200/HS400/SDR104 mode

Re: [PATCH] mmc: block: propagate correct returned value in mmc_rpmb_ioctl

2018-05-17 Thread Shawn Lin
On 2018/5/17 14:16, Mathieu Malaterre wrote: On Thu, May 17, 2018 at 4:45 AM, Shawn Lin <shawn@rock-chips.com> wrote: On 2018/5/17 3:20, Mathieu Malaterre wrote: In commit 97548575bef3 ("mmc: block: Convert RPMB to a character device") a new function `mmc_rpmb_ioctl` was

Re: [PATCH] mmc: block: propagate correct returned value in mmc_rpmb_ioctl

2018-05-16 Thread Shawn Lin
warn about this. And it's worth backporting to stable. Reviewed-by: Shawn Lin <shawn@rock-chips.com> Signed-off-by: Mathieu Malaterre <ma...@debian.org> --- drivers/mmc/core/block.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/mmc/core/block.c b/drivers/

Re: [PATCH] ethernet: stmmac: dwmac-rk: Add GMAC support for px30

2018-05-16 Thread Shawn Lin
Hi David, On 2018/5/16 11:38, David Wu wrote: Add constants and callback functions for the dwmac on px30 soc. s/soc/SoC The base structure is the same, but registers and the bits in them moved slightly, and add the clk_mac_speed for the select s/moved/are moved of mac speed. for

Re: [PATCH v7 1/3] mmc: dw_mmc-bluefield: Add driver extension

2018-05-08 Thread Shawn Lin
On 2018/5/9 2:46, Liming Sun wrote: This commit adds extension to the dw_mmc driver for Mellanox BlueField SoC. It updates the UHS_REG_EXT register to bring up the eMMC card on this SoC. Reviewed-by: Shawn Lin <shawn@rock-chips.com>

Re: [PATCH v5 1/3] mmc: dw_mmc-bluefield: Add driver extension

2018-05-03 Thread Shawn Lin
On 2018/5/2 20:45, Liming Sun wrote: Please see response inline. Thanks, Liming -Original Message- From: Shawn Lin [mailto:shawn@rock-chips.com] Sent: Tuesday, May 1, 2018 9:02 PM To: Liming Sun <l...@mellanox.com>; Mark Rutland <mark.rutl...@arm.com>; Jaehoon Ch

Re: [PATCH v5 1/3] mmc: dw_mmc-bluefield: Add driver extension

2018-05-01 Thread Shawn Lin
On 2018/5/2 2:19, Liming Sun wrote: This commit adds extension to the dw_mmc driver for Mellanox BlueField SoC. It updates the UHS_REG_EXT register to bring up the eMMC card on this SoC. Cc: sta...@kernel.org Why? Signed-off-by: Liming Sun Reviewed-by: David Woods

Re: [PATCH v2 1/3] mmc: dw_mmc-bluefield: Add driver extension

2018-04-23 Thread Shawn Lin
Hi Liming, On 2018/4/23 23:32, Liming Sun wrote: This commit adds extension to the dw_mmc driver for Mellanox BlueField SoC. It updates the UHS_REG_EXT register to bring up the eMMC card on this SoC. Signed-off-by: Liming Sun --- drivers/mmc/host/Kconfig| 9

Re: clk: bulk: silently error out on EPROBE_DEFER

2018-04-10 Thread Shawn Lin
finally probed fine. But probably it came from clk_bulk_get, Reviewed-by: Shawn Lin <shawn@rock-chips.com> Signed-off-by: Jerome Brunet <jbru...@baylibre.com> --- drivers/clk/clk-bulk.c | 5 +++-- 1 file changed, 3 insertions(+), 2 deletions(-) diff --git a/drivers/clk/clk-bulk

Re: [PATCH] mmc: dw_mmc-k3: Fix DDR52 mode by setting required clock divisor

2018-04-07 Thread Shawn Lin
On 2018/4/6 21:41, Ryan Grachek wrote: On Wed, Apr 4, 2018 at 7:51 PM, Shawn Lin <shawn@rock-chips.com> wrote: [+ Zhangfei Gao who added support for hi6220] On 2018/4/4 23:31, Ryan Grachek wrote: On Tue, Apr 3, 2018 at 6:31 AM, Shawn Lin <shawn@rock-chips.com <mailto:sh

Re: [PATCH] mmc: dw_mmc-k3: Fix DDR52 mode by setting required clock divisor

2018-04-04 Thread Shawn Lin
[+ Zhangfei Gao who added support for hi6220] On 2018/4/4 23:31, Ryan Grachek wrote: On Tue, Apr 3, 2018 at 6:31 AM, Shawn Lin <shawn@rock-chips.com <mailto:shawn@rock-chips.com>> wrote: On 2018/3/30 2:24, oscardagrach wrote: Need at least one line

Re: [PATCH] mmc: dw_mmc-k3: Fix DDR52 mode by setting required clock divisor

2018-04-03 Thread Shawn Lin
On 2018/3/30 2:24, oscardagrach wrote: Need at least one line commit body. Signed-off-by: oscardagrach --- drivers/mmc/host/dw_mmc-k3.c | 10 -- 1 file changed, 8 insertions(+), 2 deletions(-) diff --git a/drivers/mmc/host/dw_mmc-k3.c b/drivers/mmc/host/dw_mmc-k3.c

Re: [PATCH] [mmc_block] Prevent bus reference leak in mmc_blk_init

2018-03-29 Thread Shawn Lin
unregister(_rpmb_bus_type); Reviewed-by: Shawn Lin <shawn@rock-chips.com> } module_init(mmc_blk_init);

Re: [RFC PATCH] sdhci: arasan: Add runtime PM support

2018-03-29 Thread Shawn Lin
On 2018/3/29 13:48, naraniman...@gmail.com wrote: From: Manish Narani This patch adds runtime PM support in Arasan SD driver. Signed-off-by: Manish Narani --- drivers/mmc/host/sdhci-of-arasan.c | 83 +- 1 file

Re: [PATCH] mmc: Export card RCA register to sysfs.

2018-03-06 Thread Shawn Lin
quot;, card->rca); MMC_DEV_ATTR(cmdq_en, "%d\n", card->ext_csd.cmdq_en); Just a nit that I tried to find some convention here, as RCA is a 16-bit register, so perhaps "0x%04x\n"? Otherwise, Reviewed-by: Shawn Lin <shawn@rock-chips.com> static ssize_t mmc_fwrev

Re: [PATCH v5] mmc: Export host capabilities to debugfs.

2018-03-06 Thread Shawn Lin
BUTE instead? :) -- Best Regards Shawn Lin

Re: [PATCH] mmc: sdhci-of-arasan: Add quirk to avoid erroneous msg

2018-03-05 Thread Shawn Lin
On 2018/3/6 0:47, Phil Edworthy wrote: Hi Shawn, On 28 February 2018 01:53, Shawn Lin wrote: On 2018/2/27 23:05, Phil Edworthy wrote: On 27 February 2018 14:42, Shawn Lin wrote: On 2018/2/27 22:31, Phil Edworthy wrote: On 27 February 2018 14:28, Shawn Lin wrote: 在 2018/2/27 21:55, Phil

Re: [PATCH v3] mmc: Export host capabilities to debugfs.

2018-03-05 Thread Shawn Lin
Reviewed-by: Shawn Lin <shawn@rock-chips.com>

Re: [PATCH] soc: rockchip: power-domain: Add a sanity check on pd->num_clks

2018-03-05 Thread Shawn Lin
ain: use clk_bulk APIs") Reported-by: Shawn Lin <shawn@rock-chips.com> Signed-off-by: Jeffy Chen <jeffy.c...@rock-chips.com> Tested-by: Shawn Lin <shawn@rock-chips.com>

Re: [PATCH] soc: rockchip: power-domain: use clk_bulk APIs

2018-03-05 Thread Shawn Lin
Hi Heiko, On 2018/3/2 23:43, Heiko Stuebner wrote: Hi Jeffy, Am Mittwoch, 28. Februar 2018, 13:41:43 CET schrieb Jeffy Chen: Use clk_bulk APIs, and also add error handling for clk enable. Signed-off-by: Jeffy Chen [...] - for (i = 0; i < clk_cnt; i++) {

Re: [PATCH v2] mmc: Export host capabilities to debugfs.

2018-03-04 Thread Shawn Lin
On 2018/3/5 12:24, Harish Jenny K N wrote: From: Abbas Raza This patch exports the host capabilities to debugfs Signed-off-by: Abbas Raza Signed-off-by: Andrew Gabbasov Signed-off-by: Harish Jenny K N

Re: [PATCH] mmc: sdhci-of-arasan: Add quirk to avoid erroneous msg

2018-02-27 Thread Shawn Lin
On 2018/2/27 23:05, Phil Edworthy wrote: Hi Shawn, On 27 February 2018 14:42, Shawn Lin wrote: On 2018/2/27 22:31, Phil Edworthy wrote: Hi Shawn, On 27 February 2018 14:28, Shawn Lin wrote: 在 2018/2/27 21:55, Phil Edworthy 写道: Since the controller does not support the end-of-busy IRQ

Re: [PATCH] mmc: sdhci-of-arasan: Add quirk to avoid erroneous msg

2018-02-27 Thread Shawn Lin
On 2018/2/27 22:31, Phil Edworthy wrote: Hi Shawn, On 27 February 2018 14:28, Shawn Lin wrote: 在 2018/2/27 21:55, Phil Edworthy 写道: Since the controller does not support the end-of-busy IRQ, don't use it. Otherwise, on older SD cards you will get lots of these messages: "mmc0: Got

Re: [PATCH] mmc: sdhci-of-arasan: Add quirk to avoid erroneous msg

2018-02-27 Thread Shawn Lin
QUIRK2_PRESET_VALUE_BROKEN | - SDHCI_QUIRK2_CLOCK_DIV_ZERO_BROKEN, + SDHCI_QUIRK2_CLOCK_DIV_ZERO_BROKEN | + SDHCI_QUIRK2_STOP_WITH_TC, }; static u32 sdhci_arasan_cqhci_irq(struct sdhci_host *host, u32 intmask) -- Best Regards Shawn Lin

Re: [PATCH] mmc: card: Don't show eMMC RPMB and BOOT areas in /proc/partitions

2018-02-27 Thread Shawn Lin
| GENHD_FL_SUPPRESS_PARTITION_INFO; I would prefer using GENHD_FL_HIDDEN instead of adding all these two flags. /* * As discussed on lkml, GENHD_FL_REMOVABLE should: -- Best Regards Shawn Lin

Re: [PATCH 1/2 v3] mmc: dw_mmc: Fix the DTO timeout overflow calculation for 32-bit systems

2018-02-26 Thread Shawn Lin
Tested-by: Vineet Gupta Fixes: ARC STAR 9001306872 HSDK, sdio: board crashes when copying big files Signed-off-by: Evgeniy Didin CC: Alexey Brodkin CC: Eugeniy Paltsev CC: Douglas Anderson

Re: [PATCH 1/6] mmc: dw_mmc: remove the deprecated "clock-freq-min-max" property

2018-02-23 Thread Shawn Lin
aining that property 3) remove the functionality of the deprecated property from the driver but still leave some warning there 4) remove the left warning finally And for the ABI breakage, we should add something in Documentation/ABI /obsolete or Documentation/ABI/removed ? -- Best Regards Shawn Lin

Re: [PATCH v2] mmc: dw_mmc-k3: Fix out-of-bounds access through DT alias

2018-02-23 Thread Shawn Lin
On 2018/2/23 20:44, Geert Uytterhoeven wrote: The hs_timing_cfg[] array is indexed using a value derived from the "mshcN" alias in DT, which may lead to an out-of-bounds access. Reviewed-by: Shawn Lin <shawn@rock-chips.com> -- Best Regards Shawn Lin

Re: [PATCH] mmc: dw_mmc: update kernel-doc comments for dw_mci

2018-02-22 Thread Shawn Lin
to it description, so no one could miss this slightest detail. Couple of code style fixes as a bonus. Thanks for updating these. Reviewed-by: Shawn Lin <shawn@rock-chips.com> Signed-off-by: Alexey Roslyakov <alexey.roslya...@gmail.com> --- drivers/mmc/host/d

Re: [PATCH 2/5] mmc: add stm32 sdmmc controller driver

2018-02-22 Thread Shawn Lin
PED, + COOKIE_PRE_MAPPED, /* mapped by pre_req() of stm32 */ + COOKIE_MAPPED, /* mapped by prepare_data() of stm32 */ +}; + +struct sdmmc_stat { + unsigned long n_req; + unsigned long n_datareq; + unsigned long n_ctimeout; + unsigned long n_ccrcfail; + unsigned long n_dtimeout; + unsigned long n_dcrcfail; + unsigned long n_txunderrun; + unsigned long n_rxoverrun; + unsigned long nb_dma_err; +}; + +struct sdmmc_host { + void __iomem*base; + struct mmc_host *mmc; + struct clk *clk; + struct reset_control*rst; + + u32 clk_reg_add; + u32 pwr_reg_add; + + struct mmc_request *mrq; + struct mmc_command *cmd; + struct mmc_data *data; + struct mmc_command stop_abort; + booldpsm_abort; + + /* protect host registers access */ + spinlock_t lock; + + unsigned intsdmmcclk; + unsigned intsdmmc_ck; + + u32 size; + + u32 ip_ver; + struct sdmmc_stat stat; +}; -- Best Regards Shawn Lin

[PATCH v2 2/2] phy: rockchip-emmc: use regmap_read_poll_timeout to poll dllrdy

2018-01-10 Thread Shawn Lin
Just use the API instead of open-coding it, no functional change intended. Signed-off-by: Shawn Lin <shawn@rock-chips.com> Reviewed-by: Brian Norris <briannor...@chromium.org> Tested-by: Caesar Wang <w...@rock-chips.com> Tested-by: Ziyuan Xu <xzy...@rock-chips.co

[PATCH v2 1/2] phy: rockchip-emmc: retry calpad busy trimming

2018-01-10 Thread Shawn Lin
It turns out that 5us isn't enough for all cases, so let's retry some more times to wait for caldone. Signed-off-by: Shawn Lin <shawn@rock-chips.com> Reviewed-by: Brian Norris <briannor...@chromium.org> Tested-by: Caesar Wang <w...@rock-chips.com> Tested-by: Ziyuan Xu <

[PATCH 2/2] phy: rockchip-emmc: use regmap_read_poll_timeout to poll dllrdy

2018-01-01 Thread Shawn Lin
Just use the API instead of open-coding it, no functional change intended. Signed-off-by: Shawn Lin <shawn@rock-chips.com> --- drivers/phy/rockchip/phy-rockchip-emmc.c | 21 +++-- 1 file changed, 7 insertions(+), 14 deletions(-) diff --git a/drivers/phy/rockch

[PATCH 1/2] phy: rockchip-emmc: retry calpad busy trimming

2018-01-01 Thread Shawn Lin
It turns out that 5us isn't enough for all cases, so let's retry some more times to wait for caldone. Signed-off-by: Shawn Lin <shawn@rock-chips.com> --- drivers/phy/rockchip/phy-rockchip-emmc.c | 21 + 1 file changed, 13 insertions(+), 8 deletions(-) diff

Re: [PATCH] MAINTAINERS: Add Lorenzo Pieralisi for PCI host bridge drivers

2017-11-09 Thread Shawn Lin
Hi Bjorn, On 2017/11/9 23:05, Bjorn Helgaas wrote: On Thu, Nov 09, 2017 at 11:28:36AM +0530, Kishon Vijay Abraham I wrote: Hi Bjorn, On Thursday 09 November 2017 01:56 AM, Bjorn Helgaas wrote: On Wed, Nov 08, 2017 at 02:15:10PM -0600, Bjorn Helgaas wrote: From: Bjorn Helgaas

Re: [PATCH v2 0/5] mmc: dw_mmc: Fix the CTO timer patch, plus the DTO timer

2017-10-31 Thread Shawn Lin
Hi Ulf, On 2017/10/30 19:40, Ulf Hansson wrote: On 12 October 2017 at 22:11, Douglas Anderson wrote: Recently we landed 03de19212ea3 ("mmc: dw_mmc: introduce timer for broken command transfer over scheme"). I found a bunch of problems with that patch, so this series

Re: [PATCH v2 5/5] mmc: dw_mmc: Cleanup the DTO timer like the CTO one

2017-10-17 Thread Shawn Lin
On 2017/10/17 13:05, Doug Anderson wrote: Hi, On Mon, Oct 16, 2017 at 6:17 PM, Shawn Lin <shawn@rock-chips.com> wrote: Hi Doug On 2017/10/13 4:11, Douglas Anderson wrote: The recent CTO timer introduced in commit 03de19212ea3 ("mmc: dw_mmc: introduce timer for broken comma

Re: [PATCH 0/9] Enable dw-mmc multi-card support

2017-10-16 Thread Shawn Lin
On 2017/10/7 3:21, Liming Sun wrote: This series of commits enables the multi-card support for the dw-mmc controller. It includes two parts as below. The first part (patches 1-7) reverts the series of recent commits that removed the multi-card support with comments saying there was no such use

Re: [PATCH v2 5/5] mmc: dw_mmc: Cleanup the DTO timer like the CTO one

2017-10-16 Thread Shawn Lin
Hi Doug On 2017/10/13 4:11, Douglas Anderson wrote: The recent CTO timer introduced in commit 03de19212ea3 ("mmc: dw_mmc: introduce timer for broken command transfer over scheme") was causing observable problems due to race conditions. Previous patches have fixed those race conditions. It can

Re: [PATCH v2 3/5] mmc: dw_mmc: Add locking to the CTO timer

2017-10-16 Thread Shawn Lin
Hi Doug On 2017/10/13 12:20, Doug Anderson wrote: Shawn, On Thu, Oct 12, 2017 at 6:32 PM, Shawn Lin <shawn@rock-chips.com> wrote: On 2017/10/13 4:11, Douglas Anderson wrote: This attempts to instill a bit of paranoia to the code dealing with the CTO timer. It's be

Re: [PATCH v2 3/5] mmc: dw_mmc: Add locking to the CTO timer

2017-10-12 Thread Shawn Lin
On 2017/10/13 4:11, Douglas Anderson wrote: This attempts to instill a bit of paranoia to the code dealing with the CTO timer. It's believed that this will make the CTO timer more robust in the case that we're having very long interrupt latencies. Ack. It could help fix some problems

Re: [PATCH v2 4/5] mmc: dw_mmc: Fix the DTO timeout calculation

2017-10-12 Thread Shawn Lin
ere with a DIV other an 0. AKA: this problem was found simply by code inspection and I have no failing test cases that are fixed by it. Presumably this could fix real bugs for someone out there, though. Fixes: 16a34574c6ca ("mmc: dw_mmc: remove the quirks flags") Signed-off-by: Douglas Anderson <

Re: [PATCH 3/3] mmc: dw_mmc: Add locking to the CTO timer

2017-10-09 Thread Shawn Lin
Hi Doug, On 2017/9/28 4:56, Douglas Anderson wrote: This attempts to instill a bit of paranoia to the code dealing with the CTO timer. It's believed that this will make the CTO timer more robust in the case that we're having very long interrupt latencies. I have already got reports about

Re: [PATCH 2/3] mmc: dw_mmc: Fix the CTO timeout calculation

2017-10-09 Thread Shawn Lin
ed "bus_hz" but, as far as I can tell, it's supposed to use the card clock. Let's account for the div value, which is documented as 2x the value stored in the register, or 1 if the register is 0. Good catch. Would you mind appending a new patch to fix the drto case? Reviewed-by: Shawn

Re: [PATCH 1/3] mmc: dw_mmc: cancel the CTO timer after a voltage switch

2017-10-09 Thread Shawn Lin
he new CTO timer in the case that a voltage switch was done. Let's promote the cancel into the dw_mci_cmd_interrupt() function to fix this. Reviewed-by: Shawn Lin <shawn@rock-chips.com> Fixes: 03de19212ea3 ("mmc: dw_mmc: introduce timer for broken command transfer over scheme&quo

Re: [PATCH] mmc:host:sdhci-pci: Addition of Arasan PCI controller with integrated phy.

2017-09-26 Thread Shawn Lin
On 2017/9/27 2:59, Atul Garg wrote: The Arasan controller is based on a FPGA platform and has integrated phy with specific phy registers used during the initialization and management of different modes. The phy and the controller are integrated and registers are very specific to Arasan. Arasan

Re: [PATCH v2] mmc: core: add driver strength selection when selecting hs400es

2017-09-26 Thread Shawn Lin
<hankyung...@lge.com> Signed-off-by: Chanho Min <chanho@lge.com> Reviewed-by: Adrian Hunter <adrian.hun...@intel.com> --- Should move changelog out of commit msg and use 12bit SHA-1 ID. Reviewed-by: Shawn Lin <shawn@rock-chips.com&g

Re: 4.13 on thinkpad x220: oops when writing to SD card

2017-09-12 Thread Shawn Lin
On 2017/9/12 17:42, Linus Walleij wrote: On Fri, Sep 8, 2017 at 4:51 AM, Shawn Lin <shawn@rock-chips.com> wrote: On 2017/9/8 4:02, Linus Walleij wrote: On Thu, Sep 7, 2017 at 9:18 AM, Ulf Hansson <ulf.hans...@linaro.org> wrote: Even if this fixes the problem it s

Re: 4.13 on thinkpad x220: oops when writing to SD card

2017-09-07 Thread Shawn Lin
On 2017/9/8 4:02, Linus Walleij wrote: On Thu, Sep 7, 2017 at 9:18 AM, Ulf Hansson wrote: Even if this fixes the problem it seems like we are papering over the real issue, which earlier fixes also did during the release cycle for v4.13. I think this is the real

Re: 4.13 on thinkpad x220: oops when writing to SD card

2017-09-05 Thread Shawn Lin
+ Seraphime On 2017/9/6 3:47, Pavel Machek wrote: Hi! I tried to write to the MMC card; process hung and I got this in the dmesg. A similar report for 4.13 cycle was here: https://lkml.org/lkml/2017/8/10/824 Seems 4.13-rc4 was already broken for that but unfortuantely I didn't reproduce

[PATCH v3 2/2] mmc: dw_mmc: fix potential system abort if activating CONFIG_DEBUG_SHIRQ

2017-08-29 Thread Shawn Lin
r's remove function. And replying on the devm_add_action_or_reset to fire the clock-disabling and reset signal at the appropriate time. Signed-off-by: Shawn Lin <shawn@rock-chips.com> --- Changes in v3: - include a driver core change to fix the genpd issue. drivers/mmc/ho

[PATCH v3 1/2] driver core: detach device's pm_domain after devres_release_all

2017-08-29 Thread Shawn Lin
t or at least shouldn't be used for shared irq case. Meanwhile we don't know how many drivers have this kind of issue and need to fix. So choice (2) makes more sense to me, and that is the reason for why we need to fix it like what this patch does. Signed-off-by: Shawn Lin <shawn...

[PATCH v3 0/2] Avoid system abort by move pm domain's detach after devres_release_all

2017-08-29 Thread Shawn Lin
. Changes in v3: - fix the code path for consolidating the attach for both of driver and bus driver, and then move detach to the error path - rework the changelog - include a driver core change to fix the genpd issue. Shawn Lin (2): driver core: detach device's pm_domain after devres_release_all

Re: [PATCH v2 1/2] driver core: detach device's pm_domain after devres_release_all

2017-08-29 Thread Shawn Lin
Hi Greg, On 2017/8/29 14:42, Greg Kroah-Hartman wrote: On Tue, Aug 15, 2017 at 04:36:56PM +0800, Shawn Lin wrote: Move dev_pm_domain_detach after devres_release_all to avoid accessing device's registers with genpd been powered off. So, what is this going to break that is working already

Re: [PATCH v4 3/4] dt-bindings: PCI: rockchip: Add support for pcie wake irq

2017-08-24 Thread Shawn Lin
On 2017/8/25 10:11, Brian Norris wrote: On Thu, Aug 24, 2017 at 11:53:54AM -0500, Bjorn Helgaas wrote: On Tue, Aug 22, 2017 at 11:19:33AM +0800, Jeffy Chen wrote: Signed-off-by: Jeffy Chen diff --git a/Documentation/devicetree/bindings/pci/rockchip-pcie.txt

Re: [PATCH v1 1/3] arm64: dts: rockchip: add mmc nodes for rk3328 evaluation board

2017-08-23 Thread Shawn Lin
On 2017/8/23 16:40, c...@rock-chips.com wrote: From: Liang Chen Rockchip's rk3328 evaluation board has 3 mmc controllers for sdio/sdmmc/emmc, let's enable them. Signed-off-by: Liang Chen --- arch/arm64/boot/dts/rockchip/rk3328-evb.dts | 74

linux-next-20170823 failed to build for arm64/defconfig

2017-08-23 Thread Shawn Lin
Hi Thierry and Stephen, commit 67e04d1ab19b0cc6d87ca7c44b058edf678bc3a3 Author: Thierry Reding Date: Tue Aug 15 15:41:10 2017 +0200 drm/tegra: dc: Trace register accesses Add tracepoint events for display controller register accesses. Signed-off-by: Thierry

Re: [RFC PATCH v2 1/3] PCI: rockchip: Add support for pcie wake irq

2017-08-18 Thread Shawn Lin
Hi Jeffy On 2017/8/17 20:04, Jeffy Chen wrote: Add support for PCIE_WAKE pin in rockchip pcie driver. Signed-off-by: Jeffy Chen --- Changes in v2: Use dev_pm_set_dedicated_wake_irq -- Suggested by Brian Norris

Re: [PATCH] PCI: Allow PCI express root ports to find themselves

2017-08-17 Thread Shawn Lin
: Thierry Reding <tred...@nvidia.com> Tested-by: Shawn Lin <shawn@rock-chips.com> --- This applies on top of and was tested on next-20170817. Michael, it'd be great if you could test this one again to clarify whether or not the fix that's already in Linus' tree is still needed

Re: [PATCH] iommu: Avoid NULL group dereference

2017-08-17 Thread Shawn Lin
is already attached to an existing domain or not, for which the previous behaviour of iommu_get_domain_for_dev() was ideal, and who now crash if their device does not have an IOMMU. It works, thanks! Tested-by: Shawn Lin <shawn@rock-chips.com> With IOMMU groups now serving as a reliable ind

Re: [PATCH] irqchip/gic-{v2m, v3-its}: check iommu capable before doing iommu map

2017-08-17 Thread Shawn Lin
Hi Marc On 2017/8/17 16:52, Marc Zyngier wrote: On 17/08/17 09:28, Shawn Lin wrote: If a PCIe RC use gic-v2m or gic-v3-its as a msi domain but doesn't have iommu support, we don't need to do iommu_dma_map_msi_msg to get mapped iommu address as all we need is the physical address. Otherwise we

[PATCH] irqchip/gic-{v2m, v3-its}: check iommu capable before doing iommu map

2017-08-17 Thread Shawn Lin
below. Before this commit, iommu has a work around method to fix this but now it doesn't. So we could fix this in gic code but maybe still need a fixes tag here. Fixes: 05f80300dc8b ("iommu: Finish making iommu_group support mandatory") Signed-off-by: Shawn Lin <shawn@r

Re: [RFC PATCH 1/3] PCI: rockchip: Add support for pcie wake irq

2017-08-16 Thread Shawn Lin
Hi Jeffy, On 2017/8/16 15:52, Jeffy Chen wrote: Add support for PCIE_WAKE pin in rockchip pcie driver. Signed-off-by: Jeffy Chen --- drivers/pci/host/pcie-rockchip.c | 58 1 file changed, 58 insertions(+) diff --git

Re: [RFC PATCH 2/3] dt-bindings: PCI: rockchip: Add support for pcie wake irq

2017-08-16 Thread Shawn Lin
Hi Jeffy On 2017/8/16 15:52, Jeffy Chen wrote: Add an optional interrupt for PCIE_WAKE pin. Signed-off-by: Jeffy Chen --- Documentation/devicetree/bindings/pci/rockchip-pcie.txt | 11 +++ 1 file changed, 7 insertions(+), 4 deletions(-) diff --git

Re: [RFC PATCH 3/3] arm64: dts: rockchip: Handle pcie wake in pcie driver for Gru

2017-08-16 Thread Shawn Lin
Hi Jeffy, On 2017/8/16 15:52, Jeffy Chen wrote: Currently we are handling pcie wake irq in mrvl wifi driver. Move it to rockchip pcie driver for Gru boards. Signed-off-by: Jeffy Chen --- arch/arm64/boot/dts/rockchip/rk3399-gru.dtsi | 17 +++-- 1 file

[PATCH v2 1/2] driver core: detach device's pm_domain after devres_release_all

2017-08-15 Thread Shawn Lin
Move dev_pm_domain_detach after devres_release_all to avoid accessing device's registers with genpd been powered off. Signed-off-by: Shawn Lin <shawn@rock-chips.com> --- Changes in v2: None drivers/base/dd.c | 35 ++- drivers/base/platform.

[PATCH v2 2/2] mmc: dw_mmc: fix potential system abort if activating CONFIG_DEBUG_SHIRQ

2017-08-15 Thread Shawn Lin
r's remove function. And replying on the devm_add_action_or_reset to fire the clock-disabling and reset signal at the appropriate time. Signed-off-by: Shawn Lin <shawn@rock-chips.com> --- Changes in v2: - include a driver core change to fix the genpd issue. drivers/mmc/ho

[PATCH v2 0/2] Avoid system abort by moving pm domain's detach after devres_release_all

2017-08-15 Thread Shawn Lin
the best way to fix that, otherwise we may need to fix it everywhere for other drivers. These patchset was tested by hacking the driver to return a failure for probe and also by unbinding the driver and all seem to work fine. Changes in v2: - include a driver core change to fix the genpd issue. Shawn

Re: [PATCH v10 1/2] mmc: dw_mmc: move controller reset before driver init

2017-08-13 Thread Shawn Lin
ing called. LGTM Reviewed-by: Shawn Lin <shawn@rock-chips.com> Signed-off-by: Wei Li <liwei...@huawei.com> Signed-off-by: Guodong Xu <guodong...@linaro.org> Signed-off-by: Chen Jun <chenju...@huawei.com> ---

Re: [RFC PATCH] PCI: rockchip: fix system hang up if activate CONFIG_DEBUG_SHIRQ

2017-08-10 Thread Shawn Lin
Hi Heiko On 2017/8/10 17:27, Heiko Stuebner wrote: Hi Shawn, Am Donnerstag, 10. August 2017, 16:21:13 CEST schrieb Shawn Lin: With CONFIG_DEBUG_SHIRQ enabled, the irq tear down routine would still access the irq handler registed as a shard irq. Per the comment within the function

Re: [RFC PATCH] PCI: rockchip: fix system hang up if activate CONFIG_DEBUG_SHIRQ

2017-08-10 Thread Shawn Lin
Hi Jeffy On 2017/8/10 16:39, jeffy wrote: Hi shawn, On 08/10/2017 04:21 PM, Shawn Lin wrote: With CONFIG_DEBUG_SHIRQ enabled, the irq tear down routine would still access the irq handler registed as a shard irq. Per the comment within the function of __free_irq, it says "It's a share

[RFC PATCH] PCI: rockchip: fix system hang up if activate CONFIG_DEBUG_SHIRQ

2017-08-10 Thread Shawn Lin
_pcie_read, but don't touch rockchip_pcie_write as no case to trigger that from write routine. Signed-off-by: Shawn Lin <shawn@rock-chips.com> --- Hi Bjorn, Thomas and Marc, This fix looks more like a hack, but I don't know the legit way to deal with that case. Just quick look into the

Re: 答复: [PATCH v9 2/2] mmc: dw_mmc-k3: add sd support for hi3660

2017-08-09 Thread Shawn Lin
nd inline your answer in the previous mail so that we could better trace down the issue we are talking about. Thank you again and look forward to your reply! -邮件原件----- 发件人: Shawn Lin [mailto:shawn@rock-chips.com] 发送时间: 2017年8月9日 11:48 收件人: liwei (CM); ulf.hans...@linaro.org; jh80.ch...@sa

Re: [PATCH v9 2/2] mmc: dw_mmc-k3: add sd support for hi3660

2017-08-08 Thread Shawn Lin
On 2017/8/9 11:25, Li Wei wrote: Add sd card support for hi3660 soc Signed-off-by: Li Wei Signed-off-by: Chen Jun I did some comment for your v6 but probably you miss them. And it's still incorrect for your changelog.

Re: [regression] tty console panic for 4.13-rcx

2017-08-07 Thread Shawn Lin
On 2017/8/7 12:00, Shawn Lin wrote: Hi, I saw the log at the bottom and bisect the issue to the commits of 065ea0a7afd64d6c ("tty: improve tty_insert_flip_char() slow path") 979990c628481461 ("tty: improve tty_insert_flip_char() fast path") I nearly could 100% reprodu

[regression] tty console panic for 4.13-rcx

2017-08-06 Thread Shawn Lin
Hi, I saw the log at the bottom and bisect the issue to the commits of 065ea0a7afd64d6c ("tty: improve tty_insert_flip_char() slow path") 979990c628481461 ("tty: improve tty_insert_flip_char() fast path") I nearly could 100% reproduce this. Any thought? [ 154.823106] Unable to handle

Re: rk3288: mmcblk0: error -110 sending status command, retrying

2017-08-03 Thread Shawn Lin
On 2017/8/2 19:09, Jagan Teki wrote: Hi, Did anyone observing error -110 and -84 during boot on rk3288 target? full log here[1] and used dts node is[2]. -100 is -ETIMEDOUT and -84 is CRC error. So that seems much likely HW relevant. Have you check the SI of SD slot? You don't enable UHS

[PATCH] phy: rockchip-typec: remove unused dfp variable

2017-08-02 Thread Shawn Lin
In order to silent the 'W=1' compile warning: drivers/phy/rockchip/phy-rockchip-typec.c: In function 'tcphy_get_mode': drivers/phy/rockchip/phy-rockchip-typec.c:625:7: warning: variable 'dfp' set but not used [-Wunused-but-set-variable] Cc: Chris Zhong <z...@rock-chips.com> Signed-off-by:

Re: [PATCH 058/102] phy: rockchip-pcie: explicitly request exclusive reset control

2017-08-02 Thread Shawn Lin
y: Philipp Zabel <p.za...@pengutronix.de> some changes for phy-rockchip-pcie.c would go via pci tree for 4.14, so is it ok for Bjorn to pick this up if no objection from Kishon, in case of merge conflict? Anyway, Reviewed-by: Shawn Lin <shawn@rock-chips.com> --- drivers/phy/rockc

Re: [PATCH 054/102] PCI: rockchip: explicitly request exclusive reset control

2017-08-02 Thread Shawn Lin
onvert all drivers requesting exclusive resets to the explicit API call so the temporary transition helpers can be removed. No functional changes. Cc: Shawn Lin <shawn@rock-chips.com> Cc: Bjorn Helgaas <bhelg...@google.com> Cc: Heiko Stuebner <he...@sntech.de> Cc: linux-...@vge

Re: [PATCH v6] mmc: dw_mmc-k3: add sd support for hi3660

2017-07-27 Thread Shawn Lin
Trim the CC list On 2017/7/6 15:28, liwei wrote: From: Li Wei Add sd card support for hi3660 soc Signed-off-by: Li Wei Signed-off-by: Chen Jun Major changes in v3: - solve review comments from Heiner Kallweit. *use the

Re: [PATCH 2/2] mmc: Add mmc_force_detect_change_begin / _end functions

2017-07-22 Thread Shawn Lin
_FORCE_DETECT_CHANGE +void mmc_force_detect_change(struct mmc_host *host, unsigned long delay, +bool keep_power); void mmc_request_done(struct mmc_host *, struct mmc_request *); void mmc_command_done(struct mmc_host *host, struct mmc_request *mrq); -- Best Regards Shawn Lin

Re: [PATCH 038/102] mmc: dw_mmc: explicitly request exclusive reset control

2017-07-22 Thread Shawn Lin
lt;p.za...@pengutronix.de> Reviewed-by: Shawn Lin <shawn@rock-chips.com> --- drivers/mmc/host/dw_mmc.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/mmc/host/dw_mmc.c b/drivers/mmc/host/dw_mmc.c index a9dfb26972f21..7c1e2dbc76776 100644 --- a/drivers/mmc/ho

Re: [PATCH 054/102] PCI: rockchip: explicitly request exclusive reset control

2017-07-22 Thread Shawn Lin
r. Convert all drivers requesting exclusive resets to the explicit API call so the temporary transition helpers can be removed. No functional changes. Cc: Shawn Lin <shawn@rock-chips.com> Cc: Bjorn Helgaas <bhelg...@google.com> Cc: Heiko Stuebner <he...@sntech.de> Cc: linux-.

Re: [PATCH 058/102] phy: rockchip-pcie: explicitly request exclusive reset control

2017-07-22 Thread Shawn Lin
if (IS_ERR(rk_phy->phy_rst)) { if (PTR_ERR(rk_phy->phy_rst) != -EPROBE_DEFER) dev_err(dev, -- Best Regards Shawn Lin

Re: [PATCH 1/2] iommu/rockchip: add multi irqs support

2017-07-20 Thread Shawn Lin
Hi Simon, On 2017/7/21 9:35, Simon Xue wrote: From: Simon RK3368 vpu mmu have two irqs, this patch support multi irqs Signed-off-by: Simon --- drivers/iommu/rockchip-iommu.c | 34 -- 1 file changed, 24

Re: [PATCH 2/2] iommu/rockchip: ignore isp mmu reset operation

2017-07-20 Thread Shawn Lin
Hi Simon, On 2017/7/21 9:35, Simon Xue wrote: From: Simon ISP mmu can't support reset operation, it won't get the expected result when reset, but rest functions work normally. Add this patch as a WA for this issue. Signed-off-by: Simon ---

Re: [PATCH 4/4] arm64: dts: add RK3399-Q7 (Puma) SoM

2017-06-28 Thread Shawn Lin
Hi On 2017/6/28 22:01, Klaus Goger wrote: Hi Shawn, On 28 Jun 2017, at 14:41, Shawn Lin <shawn@rock-chips.com> wrote: --8<--- + { + ep-gpios = < RK_PC6 GPIO_ACTIVE_LOW>; + num-lanes = <4>; + pinctrl-names = "default"

Re: [PATCH 4/4] arm64: dts: add RK3399-Q7 (Puma) SoM

2017-06-28 Thread Shawn Lin
n from parsing cd-gpios? + status = "okay"; +}; And I would be more happy here to see the present of vqmmc and vmmc supply if possible. + + double empty line + { + status = "okay"; + + flash: norflash@0 { norflash: flash@0 maybe? You reference the phandle and at the position it gets referenced the specific name might be more helpful. + compatible = "jedec,spi-nor"; + reg = <0>; + spi-max-frequency = <5000>; + }; +}; + { + pinctrl-names = "default"; + pinctrl-0 = <_pin_hog>; + + hog { + puma_pin_hog: puma_pin_hog { puma_pin_hog: puma-pin-hog Same for more defined pinctrl nodes below that. Heiko ___ Linux-rockchip mailing list linux-rockc...@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-rockchip -- Best Regards Shawn Lin

Re: [PATCH 1/2] spi: rockchip: add support for "cs-gpios" dts property

2017-06-12 Thread Shawn Lin
Hi Jeffy, On 2017/6/12 14:14, Jeffy Chen wrote: Support using "cs-gpios" property to specify cs gpios. Signed-off-by: Jeffy Chen --- .../devicetree/bindings/spi/spi-rockchip.txt | 2 + drivers/spi/spi-rockchip.c | 52

Re: [PATCH] PCI: rockchip: Handle return value of clk_prepare_enable

2017-06-02 Thread Shawn Lin
Hi, 在 2017/6/1 18:21, Arvind Yadav 写道: clk_prepare_enable() can fail here and we must check its return value. Signed-off-by: Arvind Yadav <arvind.yadav...@gmail.com> Acked-by: Shawn Lin <shawn@rock-chips.com> --- drivers/pci/host/pcie-roc

Re: [PATCH] ARM: dts: rockchip:remove hs200 support for firefly reload

2017-05-24 Thread Shawn Lin
Hi, On 2017/5/24 15:50, Eddie Cai wrote: due to layout limitation. not all of the reload board can support hs200. so remove hs200 support to make all board can boot up. You now also remove DDR52, so all reload boards run at high speed mode? I'm curious about what was the layout limitation

Re: [PATCH] phy-rockchip-pcie: Mark phy_rd_cfg() as __maybe_unused

2017-05-17 Thread Shawn Lin
'phy_rd_cfg' [-Werror,-Wunused-function] Reviewed-by: Shawn Lin <shawn@rock-chips.com> Thanks. Signed-off-by: Matthias Kaehlcke <m...@chromium.org> --- drivers/phy/phy-rockchip-pcie.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/drivers/phy/

Re: [PATCH] mmc: dw_mmc: Don't allow Runtime PM for SDIO cards

2017-04-13 Thread Shawn Lin
mc: add runtime PM callback") Cc: <sta...@vger.kernel.org> Reported-by: Brian Norris <briannor...@chromium.org> Signed-off-by: Douglas Anderson <diand...@chromium.org> Thanks, Doug, for this fix. Reviewed-by: Shawn Lin <shawn@rock-chips.com> --- drivers/mmc/ho

Re: [PATCH v4 4/6] arm64: dts: rockchip: add core dtsi file for RK3328 SoCs

2017-03-31 Thread Shawn Lin
Hi Liang, On 2017/3/27 17:40, c...@rock-chips.com wrote: From: Liang Chen This patch adds core dtsi file for Rockchip RK3328 SoCs. Signed-off-by: Liang Chen --- 8<-- + + sdmmc1 { + sdmmc1_clk:

  1   2   3   4   5   6   7   8   9   10   >