Hi Sachin,
Looks good, thanks. How did you come across the need for this change?
Regards,
Sherman
On 14-06-23 04:38 AM, Sachin Kamat wrote:
bcm281xx_pinctrl_probe is local to this file. Make it static.
Signed-off-by: Sachin Kamat
---
drivers/pinctrl/pinctrl-bcm281xx.c |2 +-
1 file
Hi Sachin,
Looks good, thanks. How did you come across the need for this change?
Regards,
Sherman
On 14-06-23 04:38 AM, Sachin Kamat wrote:
bcm281xx_pinctrl_probe is local to this file. Make it static.
Signed-off-by: Sachin Kamat sachin.ka...@samsung.com
---
Fixed the missing comma in DT node example.
Signed-off-by: Sherman Yin
---
.../bindings/pinctrl/brcm,bcm11351-pinctrl.txt |2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git
a/Documentation/devicetree/bindings/pinctrl/brcm,bcm11351-pinctrl.txt
b/Documentation/devicetree
To be consistent with other Broadcom drivers, the Broadcom Capri pinctrl
driver and its related CONFIG option are renamed to bcm281xx.
This commit updates the defconfig that enables the pinctrl driver.
Signed-off-by: Sherman Yin
Reviewed-by: Matt Porter
Acked-by: Linus Walleij
---
arch/arm
gs/arm/bcm/bcm11351.txt
This driver supports pinctrl on BCM11130, BCM11140, BCM11351, BCM28145
and BCM28155 SoCs.
Signed-off-by: Sherman Yin
Reviewed-by: Matt Porter
Acked-by: Linus Walleij
---
v3: removed the device tree/compatible string portion of changes which
were already accepted i
/bcm11351.txt
This driver supports pinctrl on BCM11130, BCM11140, BCM11351, BCM28145
and BCM28155 SoCs.
Signed-off-by: Sherman Yin s...@broadcom.com
Reviewed-by: Matt Porter mpor...@linaro.org
Acked-by: Linus Walleij linus.wall...@linaro.org
---
v3: removed the device tree/compatible string portion
Fixed the missing comma in DT node example.
Signed-off-by: Sherman Yin s...@broadcom.com
---
.../bindings/pinctrl/brcm,bcm11351-pinctrl.txt |2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git
a/Documentation/devicetree/bindings/pinctrl/brcm,bcm11351-pinctrl.txt
b
To be consistent with other Broadcom drivers, the Broadcom Capri pinctrl
driver and its related CONFIG option are renamed to bcm281xx.
This commit updates the defconfig that enables the pinctrl driver.
Signed-off-by: Sherman Yin s...@broadcom.com
Reviewed-by: Matt Porter mpor...@linaro.org
Acked
On 14-02-04 12:49 AM, Axel Lin wrote:
Signed-off-by: Axel Lin
---
drivers/pinctrl/pinctrl-capri.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/pinctrl/pinctrl-capri.c b/drivers/pinctrl/pinctrl-capri.c
index 4669c53..b4aa8e3 100644
---
On 14-02-04 12:49 AM, Axel Lin wrote:
Signed-off-by: Axel Lin axel@ingics.com
---
drivers/pinctrl/pinctrl-capri.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/pinctrl/pinctrl-capri.c b/drivers/pinctrl/pinctrl-capri.c
index 4669c53..b4aa8e3 100644
---
gs/arm/bcm/bcm11351.txt
This driver supports pinctrl on BCM11130, BCM11140, BCM11351, BCM28145
and BCM28155 SoCs.
Signed-off-by: Sherman Yin
Reviewed-by: Matt Porter
Acked-by: Linus Walleij
---
v2: split single patch into 4 patches
Sherman Yin (4):
pinctrl: Rename Broadcom Capri pinctrl binding
To be consistent with other Broadcom drivers, the Broadcom Capri pinctrl
driver and its related CONFIG option are renamed to bcm281xx.
This commit updates the defconfig that enables the pinctrl driver.
Signed-off-by: Sherman Yin
Reviewed-by: Matt Porter
Acked-by: Linus Walleij
---
arch/arm
This commit updates bcm11351.dtsi with the new compatible string for
the same driver.
Signed-off-by: Sherman Yin
Reviewed-by: Matt Porter
Acked-by: Linus Walleij
---
arch/arm/boot/dts/bcm11351.dtsi |2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/arch/arm/boot/dts
The compatible string of the Broadcom Capri pinctrl driver is renamed to
"brcm,bcm11351-pinctrl" to match the machine binding here:
Documentation/devicetree/bindings/arm/bcm/bcm11351.txt
Signed-off-by: Sherman Yin
Reviewed-by: Matt Porter
Acked-by: Linus Walleij
---
...capri-p
The compatible string of the Broadcom Capri pinctrl driver is renamed to
brcm,bcm11351-pinctrl to match the machine binding here:
Documentation/devicetree/bindings/arm/bcm/bcm11351.txt
Signed-off-by: Sherman Yin s...@broadcom.com
Reviewed-by: Matt Porter mpor...@linaro.org
Acked-by: Linus Walleij
This commit updates bcm11351.dtsi with the new compatible string for
the same driver.
Signed-off-by: Sherman Yin s...@broadcom.com
Reviewed-by: Matt Porter mpor...@linaro.org
Acked-by: Linus Walleij linus.wall...@linaro.org
---
arch/arm/boot/dts/bcm11351.dtsi |2 +-
1 file changed, 1
To be consistent with other Broadcom drivers, the Broadcom Capri pinctrl
driver and its related CONFIG option are renamed to bcm281xx.
This commit updates the defconfig that enables the pinctrl driver.
Signed-off-by: Sherman Yin s...@broadcom.com
Reviewed-by: Matt Porter mpor...@linaro.org
Acked
/bcm11351.txt
This driver supports pinctrl on BCM11130, BCM11140, BCM11351, BCM28145
and BCM28155 SoCs.
Signed-off-by: Sherman Yin s...@broadcom.com
Reviewed-by: Matt Porter mpor...@linaro.org
Acked-by: Linus Walleij linus.wall...@linaro.org
---
v2: split single patch into 4 patches
Sherman Yin (4
On 14-01-20 12:16 AM, Linus Walleij wrote:
On Sat, Jan 18, 2014 at 3:56 AM, Matt Porter wrote:
I wonder if Linus would accept a rename at this point (too late for 3.14
presumably, but for 3.15) of s/capri/bcm281xx throughout, bcm11351 for
the compatible string, as we have for the machine
On 14-01-20 12:16 AM, Linus Walleij wrote:
On Sat, Jan 18, 2014 at 3:56 AM, Matt Porter mpor...@linaro.org wrote:
I wonder if Linus would accept a rename at this point (too late for 3.14
presumably, but for 3.15) of s/capri/bcm281xx throughout, bcm11351 for
the compatible string, as we have
On 14-01-16 05:19 AM, Linus Walleij wrote:
On Sat, Dec 21, 2013 at 3:13 AM, Sherman Yin wrote:
'> Adds pinctrl driver for Broadcom Capri (BCM281xx) SoCs.
Signed-off-by: Sherman Yin
Reviewed-by: Christian Daudt
Reviewed-by: Matt Porter
---
v4: - PINCTRL selected in Kconfig, PINCTRL_CA
On 14-01-16 02:45 PM, Linus Walleij wrote:
As this driver is using pinconf_generic_dt_node_to_map_pin() it
needs to depend on OF so as not to cause build problems on
archs that do not support OF.
Cc: Sherman Yin
Signed-off-by: Linus Walleij
---
drivers/pinctrl/Kconfig | 1 +
1 file changed
On 14-01-16 02:45 PM, Linus Walleij wrote:
As this driver is using pinconf_generic_dt_node_to_map_pin() it
needs to depend on OF so as not to cause build problems on
archs that do not support OF.
Cc: Sherman Yin s...@broadcom.com
Signed-off-by: Linus Walleij linus.wall...@linaro.org
On 14-01-16 05:19 AM, Linus Walleij wrote:
On Sat, Dec 21, 2013 at 3:13 AM, Sherman Yin s...@broadcom.com wrote:
' Adds pinctrl driver for Broadcom Capri (BCM281xx) SoCs.
Signed-off-by: Sherman Yin s...@broadcom.com
Reviewed-by: Christian Daudt b...@fixthebug.org
Reviewed-by: Matt Porter
On 14-01-14 02:16 AM, Linus Walleij wrote:
On Tue, Jan 7, 2014 at 9:45 PM, Sherman Yin wrote:
On 14-01-07 09:15 AM, Linus Walleij wrote:
Is that what you wanted to see in pinctrl-bindings.txt, or is there
something else you want to see added to that txt file? I didn't want to add
On 14-01-14 02:16 AM, Linus Walleij wrote:
On Tue, Jan 7, 2014 at 9:45 PM, Sherman Yin s...@broadcom.com wrote:
On 14-01-07 09:15 AM, Linus Walleij wrote:
Is that what you wanted to see in pinctrl-bindings.txt, or is there
something else you want to see added to that txt file? I didn't want
On 14-01-07 09:15 AM, Linus Walleij wrote:
On Sat, Dec 21, 2013 at 3:13 AM, Sherman Yin wrote:
+Optional Properties (for standard pins):
+
+- function:String. Specifies the pin mux selection. Values
+ must be one of: "alt1", &qu
On 14-01-07 09:15 AM, Linus Walleij wrote:
On Sat, Dec 21, 2013 at 3:13 AM, Sherman Yin s...@broadcom.com wrote:
+Optional Properties (for standard pins):
+
+- function:String. Specifies the pin mux selection. Values
+ must be one of: alt1, alt2
On 13-12-18 03:56 PM, Sherman Yin wrote:
On 13-12-12 12:54 PM, Linus Walleij wrote:
+/*
+ * Write to the register using the value and mask if current value
is different
+ */
+static void capri_reg_write(struct pinctrl_dev *pctldev,
+ void __iomem *reg
Adds pinctrl driver devicetree binding for Broadcom Capri (BCM281xx) SoCs.
Signed-off-by: Sherman Yin
Reviewed-by: Christian Daudt
Reviewed-by: Matt Porter
---
v4: Changed valid values for "bias-pull-up" property for I2C pins. Expanded
pin configuration node example.
v3: Use g
On 13-12-20 12:58 PM, Arnd Bergmann wrote:
On Friday 20 December 2013, Linus Walleij wrote:
On Tue, Dec 17, 2013 at 1:18 AM, Bjorn Andersson
wrote:
No matter how we build the individual pinctrl drivers we will always
need the pinctrl framework in a multi-soc zImage; so I can't see that
we
changes:
- moved config selection from Kconfig to defconfig
- added slew-rate, input enable, input disable properties for generic
pinconfig
- added a description for PINCTRL config
v2: Use hyphens instead of underscore in DT property names.
Sherman Yin (6):
pinctrl: Add void
drv_data is added to the pinctrl_pin_desc for drivers to define additional
driver-specific per-pin data.
Signed-off-by: Sherman Yin
Reviewed-by: Christian Daudt
Reviewed-by: Matt Porter
---
v4: no change
v3: no change
v2: no change
---
include/linux/pinctrl/pinctrl.h |2 ++
1 file changed
Adds pinctrl driver for Broadcom Capri (BCM281xx) SoCs.
Signed-off-by: Sherman Yin
Reviewed-by: Christian Daudt
Reviewed-by: Matt Porter
---
v4: - PINCTRL selected in Kconfig, PINCTRL_CAPRI selected in bcm_defconfig
- make use of regmap
- change CAPRI_PIN_UPDATE from macro to inline
Enable pinctrl for Broadcom Capri (BCM281xx) SoCs.
Signed-off-by: Sherman Yin
Reviewed-by: Christian Daudt
Reviewed-by: Matt Porter
---
v4: no change
v3: No change.
v2: Use hyphens instead of underscore in DT property names.
---
arch/arm/boot/dts/bcm11351.dtsi |4
1 file changed, 4
Enable pinctrl for Broadcom Capri (BCM281xx) SoCs.
Signed-off-by: Sherman Yin s...@broadcom.com
Reviewed-by: Christian Daudt b...@fixthebug.org
Reviewed-by: Matt Porter matt.por...@linaro.org
---
v4: no change
v3: No change.
v2: Use hyphens instead of underscore in DT property names.
---
arch
Adds pinctrl driver for Broadcom Capri (BCM281xx) SoCs.
Signed-off-by: Sherman Yin s...@broadcom.com
Reviewed-by: Christian Daudt b...@fixthebug.org
Reviewed-by: Matt Porter matt.por...@linaro.org
---
v4: - PINCTRL selected in Kconfig, PINCTRL_CAPRI selected in bcm_defconfig
- make use
drv_data is added to the pinctrl_pin_desc for drivers to define additional
driver-specific per-pin data.
Signed-off-by: Sherman Yin s...@broadcom.com
Reviewed-by: Christian Daudt b...@fixthebug.org
Reviewed-by: Matt Porter matt.por...@linaro.org
---
v4: no change
v3: no change
v2: no change
On 13-12-20 12:58 PM, Arnd Bergmann wrote:
On Friday 20 December 2013, Linus Walleij wrote:
On Tue, Dec 17, 2013 at 1:18 AM, Bjorn Andersson
bjorn.anders...@sonymobile.com wrote:
No matter how we build the individual pinctrl drivers we will always
need the pinctrl framework in a multi-soc
changes:
- moved config selection from Kconfig to defconfig
- added slew-rate, input enable, input disable properties for generic
pinconfig
- added a description for PINCTRL config
v2: Use hyphens instead of underscore in DT property names.
Sherman Yin (6):
pinctrl: Add void
Adds pinctrl driver devicetree binding for Broadcom Capri (BCM281xx) SoCs.
Signed-off-by: Sherman Yin s...@broadcom.com
Reviewed-by: Christian Daudt b...@fixthebug.org
Reviewed-by: Matt Porter matt.por...@linaro.org
---
v4: Changed valid values for bias-pull-up property for I2C pins. Expanded
On 13-12-18 03:56 PM, Sherman Yin wrote:
On 13-12-12 12:54 PM, Linus Walleij wrote:
+/*
+ * Write to the register using the value and mask if current value
is different
+ */
+static void capri_reg_write(struct pinctrl_dev *pctldev,
+ void __iomem *reg
On 13-12-13 02:22 AM, Mark Brown wrote:
On Thu, Dec 12, 2013 at 09:54:50PM +0100, Linus Walleij wrote:
This is a reimplementation of regmap for MMIO.
See drivers/base/regmap/regmap-mmio.c
Notice how regmap_update_bits() is used throughout the
kernel.
If you want to do this, use regmap.
Or
On 13-12-12 12:54 PM, Linus Walleij wrote:
+#define CAPRI_PIN_SHIFT(type, param) \
+ (CAPRI_ ## type ## _PIN_REG_ ## param ## _SHIFT)
+
+#define CAPRI_PIN_MASK(type, param) \
+ (CAPRI_ ## type ## _PIN_REG_ ## param ## _MASK)
+
+/* Macro to update reg with new pin config param */
On 13-12-12 12:54 PM, Linus Walleij wrote:
+#define CAPRI_PIN_SHIFT(type, param) \
+ (CAPRI_ ## type ## _PIN_REG_ ## param ## _SHIFT)
+
+#define CAPRI_PIN_MASK(type, param) \
+ (CAPRI_ ## type ## _PIN_REG_ ## param ## _MASK)
+
+/* Macro to update reg with new pin config param */
On 13-12-13 02:22 AM, Mark Brown wrote:
On Thu, Dec 12, 2013 at 09:54:50PM +0100, Linus Walleij wrote:
This is a reimplementation of regmap for MMIO.
See drivers/base/regmap/regmap-mmio.c
Notice how regmap_update_bits() is used throughout the
kernel.
If you want to do this, use regmap.
Or
On 13-12-16 05:17 AM, Linus Walleij wrote:
On Sat, Dec 14, 2013 at 2:16 AM, Sherman Yin wrote:
+- bias-pull-up:Integer. Pull up strength in Ohm:
+ 1: 1.2 kOhm
+ 2: 1.8 kOhm
On 13-12-16 05:17 AM, Linus Walleij wrote:
On Sat, Dec 14, 2013 at 2:16 AM, Sherman Yin s...@broadcom.com wrote:
+- bias-pull-up:Integer. Pull up strength in Ohm:
+ 1: 1.2 kOhm
+ 2: 1.8 kOhm
On 13-12-12 12:37 PM, Linus Walleij wrote:
On Wed, Dec 11, 2013 at 7:37 PM, Sherman Yin wrote:
Adds pinctrl driver devicetree binding for Broadcom Capri (BCM281xx) SoCs.
Signed-off-by: Sherman Yin
Reviewed-by: Christian Daudt
Reviewed-by: Matt Porter
---
v3: Use generic pin config
On 13-12-12 12:37 PM, Linus Walleij wrote:
On Wed, Dec 11, 2013 at 7:37 PM, Sherman Yin s...@broadcom.com wrote:
Adds pinctrl driver devicetree binding for Broadcom Capri (BCM281xx) SoCs.
Signed-off-by: Sherman Yin s...@broadcom.com
Reviewed-by: Christian Daudt b...@fixthebug.org
Reviewed
Adds pinctrl driver for Broadcom Capri (BCM281xx) SoCs.
Signed-off-by: Sherman Yin
Reviewed-by: Christian Daudt
Reviewed-by: Matt Porter
---
v3: Re-work driver to be based on generic pin config. Moved config selection
from Kconfig to bcm_defconfig.
v2: Use hyphens instead of underscore
This commit adds slew-rate and input-enable/disable support for pinconf
-generic.
Signed-off-by: Sherman Yin
---
v3: added to patchset
.../bindings/pinctrl/pinctrl-bindings.txt |3 +++
drivers/pinctrl/pinconf-generic.c |4
include/linux/pinctrl/pinconf
Enable pinctrl for Broadcom Capri (BCM281xx) SoCs.
Signed-off-by: Sherman Yin
Reviewed-by: Christian Daudt
Reviewed-by: Matt Porter
---
v3: no change
v2: no change
---
arch/arm/boot/dts/bcm11351.dtsi |4
1 file changed, 4 insertions(+)
diff --git a/arch/arm/boot/dts/bcm11351.dtsi b
hyphens instead of underscore in DT property names.
Sherman Yin (6):
pinctrl: Add void * to pinctrl_pin_desc
pinctrl: Adds slew-rate, input-enable/disable
pinctrl: Make PINCTRL selectable by defconfig/menuconfig
pinctrl: Add pinctrl binding for Broadcom Capri SoCs
ARM: pinctrl: Add Broadcom
Adds pinctrl driver devicetree binding for Broadcom Capri (BCM281xx) SoCs.
Signed-off-by: Sherman Yin
Reviewed-by: Christian Daudt
Reviewed-by: Matt Porter
---
v3: Use generic pin config properties instead of brcm-specific ones. Clarified
pin types (standard, i2c, hdmi).
v2: Use hyphens
Adds a string to the PINCTRL config option so that 1) CONFIG_PINCTRL=y would
not be erased by make config, and 2) PINCTRL option would show up in menuconfig.
Signed-off-by: Sherman Yin
---
v3: added to patchset
drivers/pinctrl/Kconfig |2 +-
1 file changed, 1 insertion(+), 1 deletion
drv_data is added to the pinctrl_pin_desc for drivers to define additional
driver-specific per-pin data.
Signed-off-by: Sherman Yin
Reviewed-by: Christian Daudt
Reviewed-by: Matt Porter
---
v3: no change
v2: no change
---
include/linux/pinctrl/pinctrl.h |2 ++
1 file changed, 2 insertions
drv_data is added to the pinctrl_pin_desc for drivers to define additional
driver-specific per-pin data.
Signed-off-by: Sherman Yin s...@broadcom.com
Reviewed-by: Christian Daudt b...@fixthebug.org
Reviewed-by: Matt Porter matt.por...@linaro.org
---
v3: no change
v2: no change
---
include/linux
Adds pinctrl driver devicetree binding for Broadcom Capri (BCM281xx) SoCs.
Signed-off-by: Sherman Yin s...@broadcom.com
Reviewed-by: Christian Daudt b...@fixthebug.org
Reviewed-by: Matt Porter matt.por...@linaro.org
---
v3: Use generic pin config properties instead of brcm-specific ones
Adds a string to the PINCTRL config option so that 1) CONFIG_PINCTRL=y would
not be erased by make config, and 2) PINCTRL option would show up in menuconfig.
Signed-off-by: Sherman Yin s...@broadcom.com
---
v3: added to patchset
drivers/pinctrl/Kconfig |2 +-
1 file changed, 1 insertion
hyphens instead of underscore in DT property names.
Sherman Yin (6):
pinctrl: Add void * to pinctrl_pin_desc
pinctrl: Adds slew-rate, input-enable/disable
pinctrl: Make PINCTRL selectable by defconfig/menuconfig
pinctrl: Add pinctrl binding for Broadcom Capri SoCs
ARM: pinctrl: Add Broadcom
Enable pinctrl for Broadcom Capri (BCM281xx) SoCs.
Signed-off-by: Sherman Yin s...@broadcom.com
Reviewed-by: Christian Daudt b...@fixthebug.org
Reviewed-by: Matt Porter matt.por...@linaro.org
---
v3: no change
v2: no change
---
arch/arm/boot/dts/bcm11351.dtsi |4
1 file changed, 4
This commit adds slew-rate and input-enable/disable support for pinconf
-generic.
Signed-off-by: Sherman Yin s...@broadcom.com
---
v3: added to patchset
.../bindings/pinctrl/pinctrl-bindings.txt |3 +++
drivers/pinctrl/pinconf-generic.c |4
include/linux
Adds pinctrl driver for Broadcom Capri (BCM281xx) SoCs.
Signed-off-by: Sherman Yin s...@broadcom.com
Reviewed-by: Christian Daudt b...@fixthebug.org
Reviewed-by: Matt Porter matt.por...@linaro.org
---
v3: Re-work driver to be based on generic pin config. Moved config selection
from Kconfig
On 13-10-17 08:31 AM, Christian Daudt wrote:
On Thu, Oct 17, 2013 at 7:54 AM, Stephen Warren wrote:
On 10/17/2013 12:03 AM, Christian Daudt wrote:
On Thu, Oct 3, 2013 at 5:23 PM, Sherman Yin wrote:
Adds pinctrl driver for Broadcom Capri (BCM281xx) SoCs.
Signed-off-by: Sherman Yin
Reviewed
On 13-10-17 08:31 AM, Christian Daudt wrote:
On Thu, Oct 17, 2013 at 7:54 AM, Stephen Warren swar...@wwwdotorg.org wrote:
On 10/17/2013 12:03 AM, Christian Daudt wrote:
On Thu, Oct 3, 2013 at 5:23 PM, Sherman Yin s...@broadcom.com wrote:
Adds pinctrl driver for Broadcom Capri (BCM281xx) SoCs
Hi all,
I'm looking for feedback regarding explicitly invalidating the
list_heads in tvec_base.tv1 .. tv5 after a migration, for example by
doing a list_del(head) at the end of migrate_timer_list(). This is not
meant to fix any bugs, but to help catch attempts to add timers to the
migrated
Hi all,
I'm looking for feedback regarding explicitly invalidating the
list_heads in tvec_base.tv1 .. tv5 after a migration, for example by
doing a list_del(head) at the end of migrate_timer_list(). This is not
meant to fix any bugs, but to help catch attempts to add timers to the
migrated
On 13-11-11 02:01 AM, Linus Walleij wrote:
I would imagine that the platform-specific device tree bindings would need
to clearly explain what the valid values are, as they should.
But this is not a platform-specific binding. These are the
generic pin configuration bindings we're talking about.
On 13-11-11 02:01 AM, Linus Walleij wrote:
I would imagine that the platform-specific device tree bindings would need
to clearly explain what the valid values are, as they should.
But this is not a platform-specific binding. These are the
generic pin configuration bindings we're talking about.
On 13-11-06 01:40 AM, Linus Walleij wrote:
On Wed, Nov 6, 2013 at 3:02 AM, Sherman Yin wrote:
When Linus asked me to try using generic pinconf instead, I ran into
problems with this feature due to how the generic pinconf properties are
defined differently than my properties - perhaps
On 13-11-06 09:00 AM, Stephen Warren wrote:
You probably don't want to reference the individual xxx1/2/3 nodes in
the client pinctrl properties, but instead wrap them in a higher-level
node that represents the whole pinctrl state. Then, the client pinctrl
properties can reference just that
On 13-11-06 09:00 AM, Stephen Warren wrote:
You probably don't want to reference the individual xxx1/2/3 nodes in
the client pinctrl properties, but instead wrap them in a higher-level
node that represents the whole pinctrl state. Then, the client pinctrl
properties can reference just that
On 13-11-06 01:40 AM, Linus Walleij wrote:
On Wed, Nov 6, 2013 at 3:02 AM, Sherman Yin s...@broadcom.com wrote:
When Linus asked me to try using generic pinconf instead, I ran into
problems with this feature due to how the generic pinconf properties are
defined differently than my properties
On 13-11-04 04:04 PM, Stephen Warren wrote:
On 11/04/2013 04:26 PM, Heiko Stübner wrote:
I remember we had a discussion about how things like bias-disable explicitly
shouldn't have a value, when they are represented in the list-format:
pcfg_pull_none: pcfg_pull_none {
On 13-11-04 04:04 PM, Stephen Warren wrote:
On 11/04/2013 04:26 PM, Heiko Stübner wrote:
I remember we had a discussion about how things like bias-disable explicitly
shouldn't have a value, when they are represented in the list-format:
pcfg_pull_none: pcfg_pull_none {
>As well as all this stuff...
OK. Will see if I can find something suitable for "input disable" and
"mode"
>>>
>>>Let's discuss this. What exactly does "input disable" and "mode"
>>>mean, in electrical terms?
>>>
>>>When you come down to what actually happens it may turn out
As well as all this stuff...
OK. Will see if I can find something suitable for input disable and
mode
Let's discuss this. What exactly does input disable and mode
mean, in electrical terms?
When you come down to what actually happens it may turn out that
input disable is PIN_CONFIG_OUTPUT,
> +static const struct capri_cfg_param capri_pinconf_params[] = {
> + {"brcm,hysteresis", CAPRI_PINCONF_PARAM_HYST},
> + {"brcm,pull", CAPRI_PINCONF_PARAM_PULL},
> + {"brcm,slew", CAPRI_PINCONF_PARAM_SLEW},
> + {"brcm,input_dis",
+static const struct capri_cfg_param capri_pinconf_params[] = {
+ {brcm,hysteresis, CAPRI_PINCONF_PARAM_HYST},
+ {brcm,pull, CAPRI_PINCONF_PARAM_PULL},
+ {brcm,slew, CAPRI_PINCONF_PARAM_SLEW},
+ {brcm,input_dis,
+static const struct capri_cfg_param capri_pinconf_params[] = {
+ {"brcm,hysteresis", CAPRI_PINCONF_PARAM_HYST},
+ {"brcm,pull", CAPRI_PINCONF_PARAM_PULL},
+ {"brcm,slew", CAPRI_PINCONF_PARAM_SLEW},
+ {"brcm,input_dis",
+static const struct capri_cfg_param capri_pinconf_params[] = {
+ {brcm,hysteresis, CAPRI_PINCONF_PARAM_HYST},
+ {brcm,pull, CAPRI_PINCONF_PARAM_PULL},
+ {brcm,slew, CAPRI_PINCONF_PARAM_SLEW},
+ {brcm,input_dis,
>> +config PINCTRL_CAPRI
>> + bool "Broadcom Capri pinctrl driver"
>> + select PINMUX
>> + select PINCONF
>> + help
>> + Say Y here to support Broadcom Capri pinctrl driver, which is used
>> for
>> + the BCM281xx SoC family, including BCM11130, BCM11140,
>This should *all* be using generic pin config.
>
>For the devicetree side of this, read:
>Documentation/devicetree/bindings/pinctrl/pinctrl-bindings.txt
>
>Your driver should also be selecting GENERIC_PINCONF in
>drivers/pinctrl/Kconfig so you use the generic pinconf
>library.
>
>Read
This should *all* be using generic pin config.
For the devicetree side of this, read:
Documentation/devicetree/bindings/pinctrl/pinctrl-bindings.txt
Your driver should also be selecting GENERIC_PINCONF in
drivers/pinctrl/Kconfig so you use the generic pinconf
library.
Read
+config PINCTRL_CAPRI
+ bool Broadcom Capri pinctrl driver
+ select PINMUX
+ select PINCONF
+ help
+ Say Y here to support Broadcom Capri pinctrl driver, which is used
for
+ the BCM281xx SoC family, including BCM11130, BCM11140, BCM11351,
+
>> ---
>> Change-Id: I78b2c44b93d88b04897fd0af80ffce213e338d6b
>
>Why are you giving me this funky Gerrit stuff along with the patch?
>It's not like I have any use for it, and anything below the three
>dashes will be deleted when applying.
>
>The patch is OK but won't be applied until some driver
---
Change-Id: I78b2c44b93d88b04897fd0af80ffce213e338d6b
Why are you giving me this funky Gerrit stuff along with the patch?
It's not like I have any use for it, and anything below the three
dashes will be deleted when applying.
The patch is OK but won't be applied until some driver is
using
instead of underscore in DT property names.
Sherman Yin (4):
pinctrl: Add void * to pinctrl_pin_desc
pinctrl: Add pinctrl binding for Broadcom Capri SoCs
ARM: pinctrl: Add Broadcom Capri pinctrl driver
pinctrl: Enable pinctrl for Broadcom Capri SoCs
.../bindings/pinctrl/brcm,capri
Enable pinctrl for Broadcom Capri (BCM281xx) SoCs.
Signed-off-by: Sherman Yin
Reviewed-by: Christian Daudt
Reviewed-by: Matt Porter
---
v2: Use hyphens instead of underscore in DT property names.
---
arch/arm/boot/dts/bcm11351.dtsi |4
1 file changed, 4 insertions(+)
diff --git
Adds pinctrl driver for Broadcom Capri (BCM281xx) SoCs.
Signed-off-by: Sherman Yin
Reviewed-by: Christian Daudt
Reviewed-by: Matt Porter
---
v2: Use hyphens instead of underscore in DT property names.
---
arch/arm/mach-bcm/Kconfig |2 +
drivers/pinctrl/Kconfig | 10
Adds pinctrl driver devicetree binding for Broadcom Capri (BCM281xx) SoCs.
Signed-off-by: Sherman Yin
Reviewed-by: Christian Daudt
Reviewed-by: Matt Porter
---
v2: Use hyphens instead of underscore in DT property names.
---
.../bindings/pinctrl/brcm,capri-pinctrl.txt| 419
drv_data is added to the pinctrl_pin_desc for drivers to define additional
driver-specific per-pin data.
Signed-off-by: Sherman Yin
Reviewed-by: Christian Daudt
Reviewed-by: Matt Porter
---
Change-Id: I78b2c44b93d88b04897fd0af80ffce213e338d6b
v2: Use hyphens instead of underscore in DT
drv_data is added to the pinctrl_pin_desc for drivers to define additional
driver-specific per-pin data.
Signed-off-by: Sherman Yin s...@broadcom.com
Reviewed-by: Christian Daudt b...@fixthebug.org
Reviewed-by: Matt Porter matt.por...@linaro.org
---
Change-Id
Adds pinctrl driver devicetree binding for Broadcom Capri (BCM281xx) SoCs.
Signed-off-by: Sherman Yin s...@broadcom.com
Reviewed-by: Christian Daudt b...@fixthebug.org
Reviewed-by: Matt Porter matt.por...@linaro.org
---
v2: Use hyphens instead of underscore in DT property names.
---
.../bindings
Enable pinctrl for Broadcom Capri (BCM281xx) SoCs.
Signed-off-by: Sherman Yin s...@broadcom.com
Reviewed-by: Christian Daudt b...@fixthebug.org
Reviewed-by: Matt Porter matt.por...@linaro.org
---
v2: Use hyphens instead of underscore in DT property names.
---
arch/arm/boot/dts/bcm11351.dtsi
Adds pinctrl driver for Broadcom Capri (BCM281xx) SoCs.
Signed-off-by: Sherman Yin s...@broadcom.com
Reviewed-by: Christian Daudt b...@fixthebug.org
Reviewed-by: Matt Porter matt.por...@linaro.org
---
v2: Use hyphens instead of underscore in DT property names.
---
arch/arm/mach-bcm/Kconfig
instead of underscore in DT property names.
Sherman Yin (4):
pinctrl: Add void * to pinctrl_pin_desc
pinctrl: Add pinctrl binding for Broadcom Capri SoCs
ARM: pinctrl: Add Broadcom Capri pinctrl driver
pinctrl: Enable pinctrl for Broadcom Capri SoCs
.../bindings/pinctrl/brcm,capri
Adds pinctrl driver for Broadcom Capri (BCM281xx) SoCs.
Signed-off-by: Sherman Yin
Reviewed-by: Christian Daudt
Reviewed-by: Matt Porter
---
arch/arm/mach-bcm/Kconfig |2 +
drivers/pinctrl/Kconfig | 10 +
drivers/pinctrl/Makefile|1 +
drivers/pinctrl/pinctrl
The following patches adds a pinctrl driver for Broadcom Capri (BCM281xx) SoCs.
The first patch, adding the void * to pinctrl_pin_desc, has been previously
discussed with LinusW. See this thread:
http://lists.infradead.org/pipermail/linux-arm-kernel/2013-April/165880.html
Sherman Yin (4
1 - 100 of 116 matches
Mail list logo
