On 09/04/21 12:40 am, Gabriel Krisman Bertazi wrote:
Shreeya Patel writes:
utf8data.h_shipped has a large database table which is an auto-generated
decodification trie for the unicode normalization functions.
It is not necessary to load this large table in the kernel if no
filesystem is
calls.
Signed-off-by: Shreeya Patel
---
Changes in v7
- Update the help text in Kconfig
- Handle the unicode_load_static_call function failure by decrementing
the reference.
- Correct the code for handling built-in utf8 option as well.
- Correct the synchronization for accessing ut
encoding module.
Rename the file name from utf8-core to unicode-core for transformation of
utf8-core file into the unicode subsystem layer file and also for better
understanding.
Implementation for unicode-core file to act as layer will be added in the
future patches.
Signed-off-by: Shreeya Patel
the
unicode subsystem layer file.
Signed-off-by: Shreeya Patel
---
fs/ext4/hash.c | 2 +-
fs/ext4/namei.c| 12
fs/ext4/super.c| 6 ++--
fs/f2fs/dir.c | 12
fs/f2fs/super.c| 6 ++--
fs/libfs.c | 6
ike strncpy(), strscpy() always null-terminates the destination string,
hence use strscpy() instead of strncpy().
Fixes: 9d53690f0d4e5 (unicode: implement higher level API for string handling)
Acked-by: Gabriel Krisman Bertazi
Signed-off-by: Shreeya Patel
Reported-by: kernel test robot
---
fs/unicode/utf
ons inline.
- Remove msleep and use try_module_get() and module_put()
for ensuring that module is loaded correctly and also
doesn't get unloaded while in use.
- Resolve the warning reported by kernel test robot.
- Resolve all the checkpatch.pl warnings.
Shreeya Patel (4):
fs:
calls.
Signed-off-by: Shreeya Patel
---
Changes in v6
- Add spinlock to protect utf8mod and avoid NULL pointer
dereference.
- Change the static call function names for being consistent with
kernel coding style.
- Merge the unicode_load_module function with unicode_load as it is
the
unicode subsystem layer file.
Signed-off-by: Shreeya Patel
---
Changes in v6
- Improve the commit message
fs/ext4/hash.c | 2 +-
fs/ext4/namei.c| 12
fs/ext4/super.c| 6 ++--
fs/f2fs/dir.c | 12
fs/f2fs/super.c
encoding module.
Rename the file name from utf8-core to unicode-core for transformation of
utf8-core file into the unicode subsystem layer file and also for better
understanding.
Implementation for unicode-core file to act as layer will be added in the
future patches.
Signed-off-by: Shreeya Patel
put()
for ensuring that module is loaded correctly and also
doesn't get unloaded while in use.
- Resolve the warning reported by kernel test robot.
- Resolve all the checkpatch.pl warnings.
Shreeya Patel (4):
fs: unicode: Use strscpy() instead of strncpy()
fs: unicode: Rename
ike strncpy(), strscpy() always null-terminates the destination string,
hence use strscpy() instead of strncpy().
Fixes: 9d53690f0d4e5 (unicode: implement higher level API for string handling)
Acked-by: Gabriel Krisman Bertazi
Signed-off-by: Shreeya Patel
Reported-by: kernel test robot
---
fs/unicode/utf
On 30/03/21 7:23 am, Eric Biggers wrote:
On Tue, Mar 30, 2021 at 02:12:38AM +0530, Shreeya Patel wrote:
utf8data.h_shipped has a large database table which is an auto-generated
decodification trie for the unicode normalization functions and it is not
necessary to carry this large table in the
On 30/03/21 2:50 am, Gabriel Krisman Bertazi wrote:
Shreeya Patel writes:
utf8data.h_shipped has a large database table which is an auto-generated
decodification trie for the unicode normalization functions.
It is not necessary to load this large table in the kernel if no
filesystem is
se of repeated indirect calls. Static calls
improves the performance by directly calling the functions as opposed to
indirect calls.
Signed-off-by: Shreeya Patel
---
Changes in v5
- Rename global variables and default static call functions for better
understanding
- Make only config UNICODE
the unicode subsystem layer functions and this will also be
the first step towards the transformation of utf8-core file into the
unicode subsystem layer file.
Signed-off-by: Shreeya Patel
---
Changes in v5
- Improve the commit message.
fs/ext4/hash.c | 2 +-
fs/ext4/namei.c
.
Implementation for unicode-core file to act as layer will be added in the
future patches.
Signed-off-by: Shreeya Patel
---
Changes in v5
- Improve the commit message.
fs/unicode/Makefile| 2 +-
fs/unicode/{utf8-core.c => unicode-core.c} | 0
2 files changed
ike strncpy(), strscpy() always null-terminates the destination string,
hence use strscpy() instead of strncpy().
Fixes: 9d53690f0d4e5 (unicode: implement higher level API for string handling)
Acked-by: Gabriel Krisman Bertazi
Signed-off-by: Shreeya Patel
Reported-by: kernel test robot
---
fs/unicode/utf
ule is loaded correctly and also
doesn't get unloaded while in use.
- Resolve the warning reported by kernel test robot.
- Resolve all the checkpatch.pl warnings.
Shreeya Patel (4):
fs: unicode: Use strscpy() instead of strncpy()
fs: unicode: Rename function names from utf8 to unic
On 26/03/21 1:56 am, Shreeya Patel wrote:
On 26/03/21 1:10 am, Eric Biggers wrote:
On Thu, Mar 25, 2021 at 05:38:11AM +0530, Shreeya Patel wrote:
Also, indirect calls using function pointers are easily exploitable by
speculative execution attacks, hence use static_call() in unicode.h and
On 26/03/21 1:10 am, Eric Biggers wrote:
On Thu, Mar 25, 2021 at 05:38:11AM +0530, Shreeya Patel wrote:
Also, indirect calls using function pointers are easily exploitable by
speculative execution attacks, hence use static_call() in unicode.h and
unicode-core.c files inorder to prevent these
e use static_call() in unicode.h and
unicode-core.c files inorder to prevent these attacks by making direct
calls and also to improve the performance of function pointers.
Signed-off-by: Shreeya Patel
---
Changes in v4
- Return error from the static calls instead of doing nothing and
succe
Rename the file name from utf8-core to unicode-core for transformation of
utf8-core file into the unicode subsystem layer file and also for better
understanding.
Acked-by: Gabriel Krisman Bertazi
Signed-off-by: Shreeya Patel
---
fs/unicode/Makefile| 2 +-
fs/unicode
Rename the function names from utf8 to unicode for taking the first step
towards the transformation of utf8-core file into the unicode subsystem
layer file.
Reviewed-by: Gabriel Krisman Bertazi
Signed-off-by: Shreeya Patel
---
fs/ext4/hash.c | 2 +-
fs/ext4/namei.c| 12
add a condition which will check if sb->encoding is NOT NULL
before calling the utf8_unload().
Reviewed-by: Gabriel Krisman Bertazi
Signed-off-by: Shreeya Patel
---
fs/ext4/super.c | 6 --
fs/f2fs/super.c | 9 ++---
2 files changed, 10 insertions(+), 5 deletions(-)
diff --git a/fs/ext4/supe
ike strncpy(), strscpy() always null-terminates the destination string,
hence use strscpy() instead of strncpy().
Fixes: 9d53690f0d4e5 (unicode: implement higher level API for string handling)
Acked-by: Gabriel Krisman Bertazi
Signed-off-by: Shreeya Patel
Reported-by: kernel test robot
---
Changes in v
olve the warning reported by kernel test robot.
- Resolve all the checkpatch.pl warnings.
Shreeya Patel (5):
fs: unicode: Use strscpy() instead of strncpy()
fs: Check if utf8 encoding is loaded before calling utf8_unload()
fs: unicode: Rename function names from utf8 to unicode
fs: unicode
On 24/03/21 1:59 am, Eric Biggers wrote:
On Tue, Mar 23, 2021 at 03:51:44PM -0400, Gabriel Krisman Bertazi wrote:
-int unicode_validate(const struct unicode_map *um, const struct qstr *str)
-{
- const struct utf8data *data = utf8nfdi(um->version);
-
- if (utf8nlen(data, str->name,
On 24/03/21 1:21 am, Gabriel Krisman Bertazi wrote:
Shreeya Patel writes:
utf8data.h_shipped has a large database table which is an auto-generated
decodification trie for the unicode normalization functions.
It is not necessary to load this large table in the kernel if no
file system is
On 19/03/21 2:35 am, Eric Biggers wrote:
On Thu, Mar 18, 2021 at 07:03:05PM +0530, Shreeya Patel wrote:
+struct unicode_ops {
+ struct module *owner;
+ int (*validate)(const struct unicode_map *um, const struct qstr *str);
+ int (*strncmp)(const struct unicode_map *um, const
Rename the file name from utf8-core to unicode-core for transformation of
utf8-core file into the unicode subsystem layer file and also for better
understanding.
Signed-off-by: Shreeya Patel
---
fs/unicode/Makefile| 2 +-
fs/unicode/{utf8-core.c => unicode-core.c} | 0
e use static_call() in unicode.h and
unicode-core.c files inorder to prevent these attacks by making direct
calls and also to improve the performance of function pointers.
Signed-off-by: Shreeya Patel
---
Changes in v3
- Correct the conditions to prevent NULL pointer dereference while
acce
Rename the function names from utf8 to unicode for taking the first step
towards the transformation of utf8-core file into the unicode subsystem
layer file.
Signed-off-by: Shreeya Patel
---
fs/ext4/hash.c | 2 +-
fs/ext4/namei.c| 12
fs/ext4/super.c
add a condition which will check if sb->encoding is NOT NULL
before calling the utf8_unload().
Signed-off-by: Shreeya Patel
---
Changes in v3
- Add this patch to the series which checks if utf8 encoding
was loaded before calling uft8_unload().
fs/ext4/super.c | 6 --
fs/f2fs/sup
ove msleep and use try_module_get() and module_put()
for ensuring that module is loaded correctly and also
doesn't get unloaded while in use.
- Resolve the warning reported by kernel test robot.
- Resolve all the checkpatch.pl warnings.
Shreeya Patel (4):
fs: unicode: Use strscpy() in
ike strncpy(), strscpy() always null-terminates the destination string,
hence use strscpy() instead of strncpy().
Fixes: 9d53690f0d4e5 (unicode: implement higher level API for string handling)
Signed-off-by: Shreeya Patel
Reported-by: kernel test robot
---
Changes in v3
- Return error if strscp
On 19/03/21 2:33 am, Eric Biggers wrote:
On Thu, Mar 18, 2021 at 07:03:04PM +0530, Shreeya Patel wrote:
Following warning was reported by Kernel Test Robot.
In function 'utf8_parse_version',
inlined from 'utf8_load' at fs/unicode/utf8mod.c:195:7:
fs/unicode/utf8
as a layer for
unicode subsystem. It will load the UTF-8 module and access it's functions
whenever any filesystem that needs unicode is mounted.
Signed-off-by: Shreeya Patel
---
Changes in v2
- Remove the duplicate file utf8-core.c
- Make the wrapper functions inline.
- Remove
On 18/03/21 7:03 pm, Shreeya Patel wrote:
Following warning was reported by Kernel Test Robot.
In function 'utf8_parse_version',
inlined from 'utf8_load' at fs/unicode/utf8mod.c:195:7:
fs/unicode/utf8mod.c:175:2: warning: 'strncpy' specified bound 12 equals
-core which will act as a layer for
unicode subsystem. It will load the UTF-8 module and access it's functions
whenever any filesystem that needs unicode is mounted.
Signed-off-by: Shreeya Patel
---
Changes in v2
- Remove the duplicate file utf8-core.c
- Make the wrapper functions i
Rename the file name from utf8-core to unicode-core for transformation of
utf8-core file into the unicode subsystem layer file and also for better
understanding.
Signed-off-by: Shreeya Patel
---
fs/unicode/Makefile| 2 +-
fs/unicode/{utf8-core.c => unicode-core.c} | 0
ike strncpy(), strscpy() always null-terminates the destination string,
hence use strscpy() instead of strncpy().
Signed-off-by: Shreeya Patel
Reported-by: kernel test robot
---
Changes in v2
- Resolve warning of -Wstringop-truncation reported by
kernel test robot.
fs/unicode/unicode-core.c | 2 +
Rename the function names from utf8 to unicode for taking the first step
towards the transformation of utf8-core file into the unicode subsystem
layer file.
Signed-off-by: Shreeya Patel
---
fs/ext4/hash.c | 2 +-
fs/ext4/namei.c| 12
fs/ext4/super.c
msleep and use try_module_get() and module_put()
for ensuring that module is loaded correctly and also
doesn't get unloaded while in use.
- Resolve the warning reported by kernel test robot.
- Resolve all the checkpatch.pl warnings.
Shreeya Patel (4):
fs: unicode: Rename function
On 14/03/21 7:19 am, Gabriel Krisman Bertazi wrote:
Shreeya Patel writes:
utf8data.h_shipped has a large database table which is an auto-generated
decodification trie for the unicode normalization functions.
It is not necessary to carry this large table in the kernel hence make
UTF-8
-core which will act as a layer for
unicode subsystem. It will load the UTF-8 module and access it's functions
whenever any filesystem that needs unicode is mounted.
Signed-off-by: Shreeya Patel
---
fs/unicode/Kconfig| 7 +-
fs/unicode/Makefile | 5 +-
fs/unicode/unicode-c
-core which will act as a layer for
unicode subsystem. It will load the UTF-8 module and access it's functions
whenever any filesystem that needs unicode is mounted.
Signed-off-by: Shreeya Patel
---
fs/unicode/Kconfig| 7 +-
fs/unicode/Makefile | 5 +-
fs/unicode/unicode-c
Rename the file name from utf8-core to unicode-core for transformation of
utf8-core file into the unicode subsystem layer file and also for better
understanding.
Signed-off-by: Shreeya Patel
---
fs/unicode/Makefile| 2 +-
fs/unicode/{utf8-core.c => unicode-core.c} | 0
Rename the function names from utf8 to unicode for taking the first step
towards the transformation of utf8-core file into the unicode subsystem
layer file.
Signed-off-by: Shreeya Patel
---
fs/ext4/hash.c | 2 +-
fs/ext4/namei.c| 12
fs/ext4/super.c
understanding the difference between
UTF-8 module and unicode layer.
Last patch in the series adds the layer and utf8 module.
Shreeya Patel (3):
fs: unicode: Rename function names from utf8 to unicode
fs: unicode: Rename utf8-core file to unicode-core
fs: unicode: Add utf8 module and a unicode layer
On Fri, 2019-07-12 at 14:19 +0200, Greg Kroah-Hartman wrote:
> This is the start of the stable review cycle for the 5.2.1 release.
> There are 61 patches in this series, all will be posted as a response
> to this one. If anyone has any issues with these being applied,
> please
> let me know.
>
>
On Tue, 2019-07-02 at 10:01 +0200, Greg Kroah-Hartman wrote:
> This is the start of the stable review cycle for the 5.1.16 release.
> There are 55 patches in this series, all will be posted as a response
> to this one. If anyone has any issues with these being applied,
> please
> let me know.
>
>
ainst greg's testing branch.
Changes in v3
-Fetch the changes from remote and rebase to have it in
the current working directory.
Changes in v2
-Change the val_bits to 8 and add two more patches
having a different change before the final implemetation
of regmap.
Shreeya Patel (3):
St
Currently, adt7316 doesn't use multi read and multi write
functions hence remove the redundant code and make the
necessary changes in the code.
Signed-off-by: Shreeya Patel
---
drivers/staging/iio/addac/adt7316-i2c.c | 40 -
drivers/staging/iio/addac/adt7316-spi.c
Both i2c and spi drivers have functions for reading and writing
to/from registers. Remove this redundant and common code by using
regmap API.
Signed-off-by: Shreeya Patel
---
drivers/staging/iio/addac/adt7316-i2c.c | 56 +++---
drivers/staging/iio/addac/adt7316-spi.c | 74
interrupt request is not needed to be present in the bus
structure. It is a good option to pass it as a parameter
in the probe function instead of having it in the bus structure.
Signed-off-by: Shreeya Patel
---
drivers/staging/iio/addac/adt7316-i2c.c | 3 +--
drivers/staging/iio/addac/adt7316
On Sat, 2019-01-26 at 10:42 +0530, Shreeya Patel wrote:
> On Fri, 2019-01-25 at 18:22 -0700, Jeremy Fertic wrote:
> > On Sun, Jan 20, 2019 at 09:06:30PM +0530, Shreeya Patel wrote:
> > > This patchset consist of some initial patches for heading
> > > towards the regmap
On Fri, 2019-01-25 at 18:22 -0700, Jeremy Fertic wrote:
> On Sun, Jan 20, 2019 at 09:06:30PM +0530, Shreeya Patel wrote:
> > This patchset consist of some initial patches for heading
> > towards the regmap implementation and also the final patch
> > which enables the driver t
Currently, adt7316 doesn't use multi read and multi write
functions hence remove the redundant code and make the
necessary changes in the code.
Signed-off-by: Shreeya Patel
---
drivers/staging/iio/addac/adt7316-i2c.c | 40 -
drivers/staging/iio/addac/adt7316-spi.c
interrupt request is not needed to be present in the bus
structure. It is a good option to pass it as a parameter
in the probe function instead of having it in the bus structure.
Signed-off-by: Shreeya Patel
---
drivers/staging/iio/addac/adt7316-i2c.c | 3 +--
drivers/staging/iio/addac/adt7316
directory.
Changes in v2
-Change the val_bits to 8 and add two more patches
having a different change before the final implemetation
of regmap.
Shreeya Patel (3):
Staging: iio: adt7316: Remove irq from bus structure
Staging: iio: adt7316: Remove multi read and write functions
Staging: iio
Both i2c and spi drivers have functions for reading and writing
to/from registers. Remove this redundant and common code by using
regmap API.
Signed-off-by: Shreeya Patel
---
drivers/staging/iio/addac/adt7316-i2c.c | 56 +++---
drivers/staging/iio/addac/adt7316-spi.c | 74
On Sat, 2019-01-19 at 19:04 +, Jonathan Cameron wrote:
> On Sun, 20 Jan 2019 00:09:29 +0530
> Shreeya Patel wrote:
>
> > This patchset consist of some initial patches for heading
> > towards the regmap implementation and also the final patch
> > which enables t
Both i2c and spi drivers have functions for reading and writing
to/from registers. Remove this redundant and common code by using
regmap API.
Signed-off-by: Shreeya Patel
---
drivers/staging/iio/addac/adt7316-i2c.c | 60 +++
drivers/staging/iio/addac/adt7316-spi.c | 74
Currently, adt7316 doesn't use multi read and multi write
functions hence remove the redundant code and make the
necessary changes in the code.
Signed-off-by: Shreeya Patel
---
drivers/staging/iio/addac/adt7316-i2c.c | 40 -
drivers/staging/iio/addac/adt7316-spi.c
This patchset consist of some initial patches for heading
towards the regmap implementation and also the final patch
which enables the driver to use regmap API thus removing
the redundant and common code.
Shreeya Patel (3):
Staging: iio: adt7316: Remove irq from bus structure
Staging: iio
interrupt request is not needed to be present in the bus
structure. It is a good option to pass it as a parameter
in the probe function instead of having it in the bus structure.
Signed-off-by: Shreeya Patel
---
drivers/staging/iio/addac/adt7316-i2c.c | 3 +--
drivers/staging/iio/addac/adt7316
Both i2c and spi drivers have functions for reading and writing
to/from registers. Remove this redundant and common code by using
regmap API.
Also remove multi_read and multi_write functions from i2c
and spi driver as they are not being used anywhere.
Signed-off-by: Shreeya Patel
---
drivers
e i.e.
irq_type = IRQF_TRIGGER_LOW
Move devm_request_threaded_irq() and assignment of chip->config1
into the adt7316_setup_irq() to unclutter the code in probe function.
Signed-off-by: Shreeya Patel
---
Changes in v4
- Merge patches *[1/3 v3], *[2/3 v3] and *[3/3 v3] to make it less
complex t
On Sat, 2018-12-08 at 16:12 +, Jonathan Cameron wrote:
> On Sat, 8 Dec 2018 20:46:37 +0530
> Shreeya Patel wrote:
>
> > There is a function adt7316_irq_setup() where irq_type is being
> > set. It would be good to move devm_request_threaded_irq() function
> > and
On Sat, 2018-12-08 at 11:17 +, Jonathan Cameron wrote:
> On Sat, 08 Dec 2018 00:07:21 +0530
> Shreeya Patel wrote:
>
> > On Thu, 2018-12-06 at 15:40 +0300, Dan Carpenter wrote:
> > > On Wed, Dec 05, 2018 at 02:59:53PM -0700, Jeremy Fertic wrote:
> > > >
Add a dev_err() message "failed to request irq" for describing
what went wrong when an error contition is statisfied.
Signed-off-by: Shreeya Patel
---
drivers/staging/iio/addac/adt7316.c | 5 -
1 file changed, 4 insertions(+), 1 deletion(-)
diff --git a/drivers/staging/iio/addac
about the error.
Shreeya Patel (3):
Staging: iio: adt7316: Use device tree data to assign irq_type
Staging: iio: adt7316: Move interrupt related code
Staging: iio: adt7316: Add a dev_err() message
drivers/staging/iio/addac/adt7316.c | 52 +
1 file changed, 38
There is a function adt7316_irq_setup() where irq_type is being
set. It would be good to move devm_request_threaded_irq() function
and assignment of chip->config1 in adt7316_irq_setup() to unclutter
the code in probe function.
Signed-off-by: Shreeya Patel
---
drivers/staging/iio/addac/adt731
is is implemented in a new function called adt7316_setup_irq.
Signed-off-by: Shreeya Patel
---
drivers/staging/iio/addac/adt7316.c | 29 +
1 file changed, 25 insertions(+), 4 deletions(-)
diff --git a/drivers/staging/iio/addac/adt7316.c
b/drivers/staging/iio/addac/adt7316.c
On Thu, 2018-12-06 at 15:40 +0300, Dan Carpenter wrote:
> On Wed, Dec 05, 2018 at 02:59:53PM -0700, Jeremy Fertic wrote:
> > On Thu, Dec 06, 2018 at 01:25:55AM +0530, Shreeya Patel wrote:
> > > On Tue, 2018-12-04 at 18:49 -0700, Jeremy Fertic wrote:
> >
On Tue, 2018-12-04 at 18:49 -0700, Jeremy Fertic wrote:
> This reverts commit 00426e99789357dbff7e719a092ce36a3ce49d94.
>
> i2c_smbus_read_byte() returns 0 when a byte with the value 0 is read
> from
> the device. This is a valid read so revert the check for 0.
>
> Signed-off-by: Jeremy Fertic
>
On Wed, 2018-11-21 at 08:21 +, Ardelean, Alexandru wrote:
> On Tue, 2018-11-20 at 22:30 +0530, Shreeya Patel wrote:
> > ADT7316 driver no more uses platform data and hence use device tree
> > data instead of platform data for assigning irq_type field.
> > Switch case fi
ff-by: Shreeya Patel
---
drivers/staging/iio/addac/adt7316.c | 21 +
1 file changed, 17 insertions(+), 4 deletions(-)
diff --git a/drivers/staging/iio/addac/adt7316.c
b/drivers/staging/iio/addac/adt7316.c
index 9c72538baf9e..c647875a64f5 100644
--- a/drivers/staging/iio/addac/adt7
Most of the drivers in IIO uses irq_type as the name for
storing the interrupt type and hence change the name from
irq_flags to irq_type for maintaining the consistency.
Signed-off-by: Shreeya Patel
---
drivers/staging/iio/addac/adt7316.c | 8
1 file changed, 4 insertions(+), 4
There is no need to store irq_flags into the structure as it
is always set to the same thing. Hence switch irq_flags to a
local variable.
Signed-off-by: Shreeya Patel
---
drivers/staging/iio/addac/adt7316-i2c.c | 1 -
drivers/staging/iio/addac/adt7316-spi.c | 1 -
drivers/staging/iio/addac
Make the driver use device tree instead of the platform data.
Hence, use devm_gpiod_get_optional function to get the data from
device tree for ldac-pin and accordingly make the needed changes
in the driver.
Signed-off-by: Shreeya Patel
---
drivers/staging/iio/addac/adt7316.c | 14
should be a fall back path
with which desired kernel modules can be loaded. Hence, add
of_device_id table in the i2c driver to be able to use when there
is no dt table.
Signed-off-by: Shreeya Patel
---
Changes in v2:
- Make the commit message appropriate and assign of_match_table
in the driver
*[1/5] appropriate.
Shreeya Patel (5):
Staging: iio: adt7316: Add of_device_id table
Staging: iio: adt7316: Use device tree data to set ldac_pin
Staging: iio: adt7316: Switch irq_flags to a local variable
Staging: iio: adt7316: Change the name from irq_flags to irq_type
Staging: iio: adt7316: Use d
ff-by: Shreeya Patel
---
drivers/staging/iio/addac/adt7316.c | 21 +
1 file changed, 17 insertions(+), 4 deletions(-)
diff --git a/drivers/staging/iio/addac/adt7316.c
b/drivers/staging/iio/addac/adt7316.c
index 9c72538baf9e..c647875a64f5 100644
--- a/drivers/staging/iio/addac/adt7
Most of the drivers in IIO uses irq_type as the name for
storing the interrupt type and hence change the name from
irq_flags to irq_type for maintaining the consistency.
Signed-off-by: Shreeya Patel
---
drivers/staging/iio/addac/adt7316.c | 8
1 file changed, 4 insertions(+), 4
There is no need to store irq_flags into the structure as it
is always set to the same thing. Hence switch irq_flags to a
local variable.
Signed-off-by: Shreeya Patel
---
drivers/staging/iio/addac/adt7316-i2c.c | 1 -
drivers/staging/iio/addac/adt7316-spi.c | 1 -
drivers/staging/iio/addac
Make the driver use device tree instead of the platform data.
Hence, use devm_gpiod_get_optional function to get the data from
device tree for ldac-pin and accordingly make the needed changes
in the driver.
Signed-off-by: Shreeya Patel
---
drivers/staging/iio/addac/adt7316.c | 14
ADT7316, add of_device_id
table which specifies the supported devices through compatible
property.
Note that there is a fall back path in i2c that will result
in i2c_device_id table being used if there is no of_devcie_id table.
Signed-off-by: Shreeya Patel
---
drivers/staging/iio/addac/adt7316-i2c.c
ret = 0 indicates a case of no error but no data read from
the bus which is an invalid case. This case doesn't ever happen
in reality. It should perhaps be handled for correctness though.
Signed-off-by: Shreeya Patel
---
drivers/staging/iio/addac/adt7316-i2c.c | 4
1 file chang
adt7316_i2c_read function nowhere sets the data field.
It is necessary to have an appropriate value for it.
Hence, assign the value stored in 'ret' variable to data field.
Signed-off-by: Shreeya Patel
---
drivers/staging/iio/addac/adt7316-i2c.c | 2 ++
1 file changed, 2 insertion
This patchset introduces device tree bindings for adt7316
driver and removes the usage of platform data from it.
Also, it sets the data field to it's appropriate value in
the i2c read function which was nowhere being set before.
Shreeya Patel (7):
Staging: iio: adt7316: Set the data
On Mon, 2018-10-22 at 22:44 +0530, Nishad Kamdar wrote:
> Use the gpiod interface instead of the deprecated old non-descriptor
> interface for ldac_pin.
>
> Signed-off-by: Nishad Kamdar
> ---
Hi Nishad,
I have been working on implementing device tree bindings for this
driver and removing platfo
On Tue, 2018-10-16 at 13:01 -0300, Marcelo Schmitt wrote:
> Fixes close parenthesis alignment to match open parenthesis at
> iio/drivers/staging/iio/adc/ad7606.c line 379.
>
> Signed-of-by: Marcelo Schmitt
Hi Marcelo,
Some suggestions from my side
1) Your subject line should look like "Sta
,flag);
if (to==NULL || ...) S
- memcpy(to, from, size);
Signed-off-by: Shreeya Patel
---
drivers/staging/lustre/lnet/lnet/api-ni.c | 5 ++---
1 file changed, 2 insertions(+), 3 deletions(-)
diff --git a/drivers/staging/lustre/lnet/lnet/api-ni.c
b/drivers/staging/lustre/lnet/lnet/api-ni.c
Move the adis16209 driver out of staging directory and merge to the
mainline IIO subsystem.
Signed-off-by: Shreeya Patel
---
Changes in v6
-Move driver adis16209 from staging to mainline IIO subsystem
after complete cleanup of it.
drivers/iio/accel/Kconfig | 12 ++
drivers/iio
Use GENMASK to improve readability and remove the local
variables used to store intermediate data.
Signed-off-by: Shreeya Patel
---
Changes in v6
-Introduce this new patch in the series.
drivers/staging/iio/accel/adis16209.c | 19 ---
1 file changed, 8 insertions(+), 11
Remove few unused header files since the adis core handles
the sysfs and buffer support.
Signed-off-by: Shreeya Patel
---
Changes in v6
-Introduce this new patch in the series.
drivers/staging/iio/accel/adis16209.c | 3 ---
1 file changed, 3 deletions(-)
diff --git a/drivers/staging/iio
Add a blank line after return statements to improve the code
readability.
Signed-off-by: Shreeya Patel
---
Changes in v6
-Introduce this new patch in the series.
drivers/staging/iio/accel/adis16209.c | 2 ++
1 file changed, 2 insertions(+)
diff --git a/drivers/staging/iio/accel/adis16209.c
Prefer reverse christmas tree ordering of declarations to
improve readability.
Signed-off-by: Shreeya Patel
---
Changes in v6
-Introduce this new patch in the series.
drivers/staging/iio/accel/adis16209.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/drivers
Have indentation in field definitions to make them
clearly different from the register addresses.
Signed-off-by: Shreeya Patel
---
Changes in v5
-Change some macro names and have indentation in the field
definitions.
Changes in v6
-Have indentation in the field definitions and do not
1 - 100 of 195 matches
Mail list logo
