Re: tg3 crashes under high load, when using 100Mbits
On Sat, Apr 14, 2018 at 9:17 PM, Kai-Heng Feng
wrote:
> Hi Satish,
>
>> On 2018Mar21, at 00:57, Kai-Heng Feng wrote:
>>
>> Satish Baddipadige wrote:
>>
>>> On Thu, Feb 15, 2018 at 7:37 PM, Siva Reddy Kallam
>>> wrote:
>>>> On Mon, Feb 12, 2018 at 10:59 AM, Siva Reddy Kallam
>>>> wrote:
>>>>> On Fri, Feb 9, 2018 at 10:41 AM, Kai Heng Feng
>>>>> wrote:
>>>>>> Hi Broadcom folks,
>>>>>>
>>>>>> We are now enabling a new platform with tg3 nic, unfortunately we
>>>>>> observed
>>>>>> the bug [1] that dated back to 2015.
>>>>>> I tried commit 4419bb1cedcd ("tg3: Add workaround to restrict 5762 MRRS
>>>>>> to
>>>>>> 2048”) but it does’t work.
>>>>>>
>>>>>> Do you have any idea how to solve the issue?
>>>>>>
>>>>>> [1] https://bugs.launchpad.net/ubuntu/+source/linux/+bug/1447664
>>>>>>
>>>>>> Kai-Heng
>>>>> Thank you for reporting. We will check and update you.
>>>> With link aware mode, the clock speed could be slow and boot code does not
>>>> complete within the expected time with lower link speeds. Need to override
>>>> and the clock in driver. We are checking the feasibility of adding
>>>> this in driver or firmware.
>>>
>>> Hi Kai-Heng,
>>>
>>> Can you please test the attached patch?
>>
>> I built a kernel and asked affected users to try.
>
> Users reported that the crash still happens with the patch.
>
> Kai-Heng
>
Thanks for the feedback. We will re-work on the patch and soon provide
you the update.
>>
>> Thanks for your work.
>>
>> Kai-Heng
>>
>>>
>>> Thanks,
>>> Satish
>>>
>
Re: NETDEV WATCHDOG: eth0 (tg3): transmit queue 0 timed out
On Sat, Feb 24, 2018 at 3:48 PM, Borislav Petkov wrote: > Hi, > > this didn't happen before but after 4.16-rc1 my tg3 nic stops for > whatever reason and the connection to the machine is dead. It didn't show > anything in dmesg until today. > > The IO pagefaults look like it is trying to access something it > shouldn't and maybe that's why it times out. > > It triggers pretty quickly so I'd call it a reliable reproducer and thus > I can test patches... :-) > > Thx. Thanks for reporting this. Somehow, this mail moved to my spam folder. Hence, delay in response. Looks like this is similar to below issue and it was reported some time back. https://www.spinics.net/lists/netdev/msg482757.html We are actively working on this. We will soon provide you an update on this.
Re: tg3 crashes under high load, when using 100Mbits
On Mon, Feb 12, 2018 at 10:59 AM, Siva Reddy Kallam
wrote:
> On Fri, Feb 9, 2018 at 10:41 AM, Kai Heng Feng
> wrote:
>> Hi Broadcom folks,
>>
>> We are now enabling a new platform with tg3 nic, unfortunately we observed
>> the bug [1] that dated back to 2015.
>> I tried commit 4419bb1cedcd ("tg3: Add workaround to restrict 5762 MRRS to
>> 2048”) but it does’t work.
>>
>> Do you have any idea how to solve the issue?
>>
>> [1] https://bugs.launchpad.net/ubuntu/+source/linux/+bug/1447664
>>
>> Kai-Heng
>>
> Thank you for reporting. We will check and update you.
With link aware mode, the clock speed could be slow and boot code does not
complete within the expected time with lower link speeds. Need to override
and the clock in driver. We are checking the feasibility of adding
this in driver or firmware.
Re: tg3 crashes under high load, when using 100Mbits
On Fri, Feb 9, 2018 at 10:41 AM, Kai Heng Feng
wrote:
> Hi Broadcom folks,
>
> We are now enabling a new platform with tg3 nic, unfortunately we observed
> the bug [1] that dated back to 2015.
> I tried commit 4419bb1cedcd ("tg3: Add workaround to restrict 5762 MRRS to
> 2048”) but it does’t work.
>
> Do you have any idea how to solve the issue?
>
> [1] https://bugs.launchpad.net/ubuntu/+source/linux/+bug/1447664
>
> Kai-Heng
>
Thank you for reporting. We will check and update you.
Re: [PATCH net-next] tg3: Add the ability to conditionally build w/ HWMON
On Tue, Mar 7, 2017 at 2:26 AM, Florian Fainelli wrote:
> Introduce a Kconfig option: CONFIG_TIGON3_HWMON which allows to build
> in/out support for thermal sensors reported by Tigon3 NICs.
>
> Signed-off-by: Florian Fainelli
Acked-by: Siva Reddy Kallam
> ---
> drivers/net/ethernet/broadcom/Kconfig | 8 +++-
> drivers/net/ethernet/broadcom/tg3.c | 7 +++
> 2 files changed, 14 insertions(+), 1 deletion(-)
>
> diff --git a/drivers/net/ethernet/broadcom/Kconfig
> b/drivers/net/ethernet/broadcom/Kconfig
> index 940fb24bba21..96413808c726 100644
> --- a/drivers/net/ethernet/broadcom/Kconfig
> +++ b/drivers/net/ethernet/broadcom/Kconfig
> @@ -109,7 +109,6 @@ config TIGON3
> tristate "Broadcom Tigon3 support"
> depends on PCI
> select PHYLIB
> - select HWMON
> imply PTP_1588_CLOCK
> ---help---
> This driver supports Broadcom Tigon3 based gigabit Ethernet cards.
> @@ -117,6 +116,13 @@ config TIGON3
> To compile this driver as a module, choose M here: the module
> will be called tg3. This is recommended.
>
> +config TIGON3_HWMON
> + bool "Broadcom Tigon3 HWMON support"
> + default y
> + depends on TIGON3 && HWMON && !(TIGON3=y && HWMON=m)
> + ---help---
> + Say Y if you want to expose the thermal sensor on Tigon3 devices.
> +
> config BNX2X
> tristate "Broadcom NetXtremeII 10Gb support"
> depends on PCI
> diff --git a/drivers/net/ethernet/broadcom/tg3.c
> b/drivers/net/ethernet/broadcom/tg3.c
> index 30d1eb9ebec9..f395b951f5e7 100644
> --- a/drivers/net/ethernet/broadcom/tg3.c
> +++ b/drivers/net/ethernet/broadcom/tg3.c
> @@ -825,6 +825,7 @@ static int tg3_ape_event_lock(struct tg3 *tp, u32
> timeout_us)
> return timeout_us ? 0 : -EBUSY;
> }
>
> +#ifdef CONFIG_TIGON3_HWMON
> static int tg3_ape_wait_for_event(struct tg3 *tp, u32 timeout_us)
> {
> u32 i, apedata;
> @@ -904,6 +905,7 @@ static int tg3_ape_scratchpad_read(struct tg3 *tp, u32
> *data, u32 base_off,
>
> return 0;
> }
> +#endif
>
> static int tg3_ape_send_event(struct tg3 *tp, u32 event)
> {
> @@ -10744,6 +10746,7 @@ static int tg3_init_hw(struct tg3 *tp, bool reset_phy)
> return tg3_reset_hw(tp, reset_phy);
> }
>
> +#ifdef CONFIG_TIGON3_HWMON
> static void tg3_sd_scan_scratchpad(struct tg3 *tp, struct tg3_ocir *ocir)
> {
> int i;
> @@ -10826,6 +10829,10 @@ static void tg3_hwmon_open(struct tg3 *tp)
> dev_err(&pdev->dev, "Cannot register hwmon device,
> aborting\n");
> }
> }
> +#else
> +static inline void tg3_hwmon_close(struct tg3 *tp) { }
> +static inline void tg3_hwmon_open(struct tg3 *tp) { }
> +#endif /* CONFIG_TIGON3_HWMON */
>
>
> #define TG3_STAT_ADD32(PSTAT, REG) \
> --
> 2.9.3
>
Re: tg3 BUG: spinlock lockup suspected
On Mon, Oct 17, 2016 at 6:35 PM, Meelis Roos wrote: >> > Now I reproduced the bug even with 4.7-rc1 so it is older than 4.7. Will >> > test further. >> >> It gets stranger and stranger - my old 4.7 image worked fine, freshly >> compiled 4.7 exhibits the same problem. >> >> Toolchain has not changed, that I know for sure. >> >> What may have changed is kernel .config. My old conf was with whatever I >> had during 4.7. Then I upgraded to 4.8-rc3 and then 4.8 and selected >> values for "make oldconfig" new entries. Then went back to 4.7-rc1 and >> then to 4.7 with this config, answering quiestion about new options when >> any appeared. Diff is not available since I do not have the old configs >> archived. > > I did some more digging. Found an older configuration that is working > and recreated a newer one that is bad, for the same 4.7 kernel. This is > reproducible now, from "make clean" state. > > Working config from 4.7-rc4 attached as config-4.7, broken config from > 4.7 attached as config-4.7-bad. > > Will try to bisect the configs as time permits. But looking at the > stack traces, the issue is probably timing related, when ip and dhclient > do something with the same lock. seq_read that outputs stats could be > reading /proc/net/dev that reads counters from each interface. > > ifupdown seems to use the following for dhcp interfaces: > up > [[/bin/ip link set dev %iface% address %hwaddress%]] > /sbin/dhclient -v -pf /run/dhclient.%iface%.pid -lf > /var/lib/dhcp/dhclient.%iface%.leases -I -df > /var/lib/dhcp/dhclient6.%iface%.leases %iface% \ > ... > > so ip link is setting link up, this creates some work for the > background, and the dhclient goes adn reads /proc/net/dev, and lockup is > suspected but not proven? > > I started a loop for test, doing cat /proc/net/dev in a loop and at the > same link link up and down from console, but up and down is slow process > and the loop did not seem to trigger the warning over night, so it was > not so simple. > I am busy with other priority tasks. One of my colleague Deepak will work this with you. I added him to CC list. Thanks. > >> > > [ 83.716570] BUG: spinlock lockup suspected on CPU#0, dhclient/1014 >> > > [ 83.797819] lock: 0xfff000123c8e4a08, .magic: dead4ead, .owner: >> > > ip/1001, .owner_cpu: 1 >> > > [ 83.903130] CPU: 0 PID: 1014 Comm: dhclient Not tainted 4.8.0 #4 >> > > [ 83.982129] Call Trace: >> > > [ 84.014160] [004b7220] spin_dump+0x60/0xa0 >> > > [ 84.078203] [004b73a0] do_raw_spin_lock+0xa0/0x120 >> > > [ 84.106344] IPv6: ADDRCONF(NETDEV_UP): eth0: link is not ready >> > > [ 84.107193] ip (1001) used greatest stack depth: 2168 bytes left >> > > [ 84.306955] [0092c0d0] _raw_spin_lock_bh+0x30/0x40 >> > > [ 84.380188] [100822cc] tg3_get_stats64+0xc/0x80 [tg3] >> > > [ 84.456885] [007fac8c] dev_get_stats+0x2c/0xc0 >> > > [ 84.525506] [0081a4e8] dev_seq_printf_stats+0x8/0xe0 >> > > [ 84.600986] [0081a5e4] dev_seq_show+0x24/0x40 >> > > [ 84.668467] [005cb6c4] seq_read+0x2c4/0x440 >> > > [ 84.733656] [0060b97c] proc_reg_read+0x3c/0x80 >> > > [ 84.802282] [005a219c] __vfs_read+0x1c/0x140 >> > > [ 84.868613] [005a2310] vfs_read+0x50/0x100 >> > > [ 84.932662] [005a265c] SyS_read+0x3c/0xa0 >> > > [ 84.995573] [004061d4] linux_sparc_syscall32+0x34/0x60 >> > > [ 85.073748] * CPU[ 0]: TSTATE[0044f0001a22] >> > > TPC[f79a16b0] TNPC[f79a16b4] TASK[dhclient:1014] >> > > [ 85.208732] TPC[f79a16b0] O7[f79405c8] I7[0] RPC[0] >> > > [ 85.287633] CPU[ 1]: TSTATE[004480001605] >> > > TPC[004b26f0] TNPC[004d0b0c] TASK[swapper/1:0] >> > > [ 85.420338] TPC[trace_hardirqs_off+0x10/0x20] >> > > O7[rcu_idle_enter+0x64/0xa0] I7[cpu_startup_entry+0x1b0/0x240] >> > > RPC[rest_init+0x178/0x1a0] >> > > [ 85.664600] tg3 :00:02.0 eth0: Link is up at 100 Mbps, full duplex >> > > [ 85.750515] tg3 :00:02.0 eth0: Flow control is off for TX and off >> > > for RX >> > > [ 85.843994] IPv6: ADDRCONF(NETDEV_CHANGE): eth0: link becomes ready > > -- > Meelis Roos (mr...@linux.ee)
Re: tg3 BUG: spinlock lockup suspected
On Mon, Oct 10, 2016 at 5:21 PM, Siva Reddy Kallam wrote: > On Sun, Oct 9, 2016 at 12:35 AM, Meelis Roos wrote: >>> > That did not go well - bisect found the following commit but that does >>> > not seem to be related at all. So probably the reproducibility is not >>> > 100% but more random. >>> >>> Now I reproduced the bug even with 4.7-rc1 so it is older than 4.7. Will >>> test further. >> >> It gets stranger and stranger - my old 4.7 image worked fine, freshly >> compiled 4.7 exhibits the same problem. >> >> Toolchain has not changed, that I know for sure. >> >> What may have changed is kernel .config. My old conf was with whatever I >> had during 4.7. Then I upgraded to 4.8-rc3 and then 4.8 and selected >> values for "make oldconfig" new entries. Then went back to 4.7-rc1 and >> then to 4.7 with this config, answering quiestion about new options when >> any appeared. Diff is not available since I do not have the old configs >> archived. >> >> Any ideas where to continue from here? > Probably, You can do fresh system installation if possible. > Any way, I will try to reproduce with 4.7 and 4.8 kernel versions. > Will let you know my response in 1-2 days. We are unable to reproduce with Intel system. we tried with both 4.7 and 4.8 kernel versions. We are trying to get one SPARC system. We will let you know once we are done with reproducing with SPARC system. >> >>> >>> > >>> > >>> > 4c5773f9f5462dcb372857813918bbfe8c0cdcdd is the first bad commit >>> > commit 4c5773f9f5462dcb372857813918bbfe8c0cdcdd >>> > Author: Krzysztof Kozlowski >>> > Date: Sat May 28 11:54:12 2016 +0200 >>> > >>> > dt-bindings: clock: Add license and reformat Exynos5410 clock IDs >>> > >>> > Add license and copyrights (file introduced in 2014) to header with >>> > Exynos5410 clock IDs. Additionally reformat it to improve readability. >>> > >>> > Signed-off-by: Krzysztof Kozlowski >>> > Acked-by: Stephen Boyd >>> > Reviewed-by: Javier Martinez Canillas >>> > Signed-off-by: Sylwester Nawrocki >>> > >>> > :04 04 acbd432e11366a8eb8775942bc7b8caa476226e2 >>> > 08e3a3f98c3d4fa2a93123c3f21b2847c06b4665 M include >>> > >>> > >>> > The whiole bisect log seems to dig around in unrelated places so at best >>> > it just narrows the window by adding some known-bad data points. >>> > >>> > git bisect start >>> > # good: [523d939ef98fd712632d93a5a2b588e477a7565e] Linux 4.7 >>> > git bisect good 523d939ef98fd712632d93a5a2b588e477a7565e >>> > # bad: [ef0e1ea8856bed6ff8394d3dfe77f2cab487ecea] Merge tag >>> > 'arc-4.8-rc4-fixes' of >>> > git://git.kernel.org/pub/scm/linux/kernel/git/vgupta/arc >>> > git bisect bad ef0e1ea8856bed6ff8394d3dfe77f2cab487ecea >>> > # good: [e0b3f595d13b3e9ce9cdf53935e7f304c04b5b2b] affs ->d_compare(): >>> > don't bother with ->d_inode >>> > git bisect good e0b3f595d13b3e9ce9cdf53935e7f304c04b5b2b >>> > # bad: [77a87824ed676ca8ff8482e4157d3adb284fd381] >>> > clocksource/drivers/clps_711x: fixup for "ARM: clps711x: >>> > git bisect bad 77a87824ed676ca8ff8482e4157d3adb284fd381 >>> > # bad: [27acbec338113a75b9d72aeb53149a3538031dda] Merge >>> > git://www.linux-watchdog.org/linux-watchdog >>> > git bisect bad 27acbec338113a75b9d72aeb53149a3538031dda >>> > # bad: [7f155c702677d057d03b192ce652311de5434697] Merge tag >>> > 'nfs-for-4.8-1' of git://git.linux-nfs.org/projects/trondmy/linux-nfs >>> > git bisect bad 7f155c702677d057d03b192ce652311de5434697 >>> > # good: [797cee982eef9195736afc5e7f3b8f613c41d19a] Merge branch >>> > 'stable-4.8' of git://git.infradead.org/users/pcmoore/audit >>> > git bisect good 797cee982eef9195736afc5e7f3b8f613c41d19a >>> > # bad: [1056c9bd2702ea1bb79abf9bd1e78c578589d247] Merge tag >>> > 'clk-for-linus-4.8' of >>> > git://git.kernel.org/pub/scm/linux/kernel/git/clk/linux >>> > git bisect bad 1056c9bd2702ea1bb79abf9bd1e78c578589d247 >>> > # bad: [1ff435d3571199a799ba6ccfe05544dcd21b9fb3] Merge branch >>> > 'clk-st-critical' into clk-next >>> > git bisect bad 1ff435d3571199a799ba6ccfe05544dcd21b9fb3 >>> > # bad: [0e4504470667d355b53ca3c9802fdd2120c9f946] c
Re: tg3 BUG: spinlock lockup suspected
On Sun, Oct 9, 2016 at 12:35 AM, Meelis Roos wrote: >> > That did not go well - bisect found the following commit but that does >> > not seem to be related at all. So probably the reproducibility is not >> > 100% but more random. >> >> Now I reproduced the bug even with 4.7-rc1 so it is older than 4.7. Will >> test further. > > It gets stranger and stranger - my old 4.7 image worked fine, freshly > compiled 4.7 exhibits the same problem. > > Toolchain has not changed, that I know for sure. > > What may have changed is kernel .config. My old conf was with whatever I > had during 4.7. Then I upgraded to 4.8-rc3 and then 4.8 and selected > values for "make oldconfig" new entries. Then went back to 4.7-rc1 and > then to 4.7 with this config, answering quiestion about new options when > any appeared. Diff is not available since I do not have the old configs > archived. > > Any ideas where to continue from here? Probably, You can do fresh system installation if possible. Any way, I will try to reproduce with 4.7 and 4.8 kernel versions. Will let you know my response in 1-2 days. > >> >> > >> > >> > 4c5773f9f5462dcb372857813918bbfe8c0cdcdd is the first bad commit >> > commit 4c5773f9f5462dcb372857813918bbfe8c0cdcdd >> > Author: Krzysztof Kozlowski >> > Date: Sat May 28 11:54:12 2016 +0200 >> > >> > dt-bindings: clock: Add license and reformat Exynos5410 clock IDs >> > >> > Add license and copyrights (file introduced in 2014) to header with >> > Exynos5410 clock IDs. Additionally reformat it to improve readability. >> > >> > Signed-off-by: Krzysztof Kozlowski >> > Acked-by: Stephen Boyd >> > Reviewed-by: Javier Martinez Canillas >> > Signed-off-by: Sylwester Nawrocki >> > >> > :04 04 acbd432e11366a8eb8775942bc7b8caa476226e2 >> > 08e3a3f98c3d4fa2a93123c3f21b2847c06b4665 M include >> > >> > >> > The whiole bisect log seems to dig around in unrelated places so at best >> > it just narrows the window by adding some known-bad data points. >> > >> > git bisect start >> > # good: [523d939ef98fd712632d93a5a2b588e477a7565e] Linux 4.7 >> > git bisect good 523d939ef98fd712632d93a5a2b588e477a7565e >> > # bad: [ef0e1ea8856bed6ff8394d3dfe77f2cab487ecea] Merge tag >> > 'arc-4.8-rc4-fixes' of >> > git://git.kernel.org/pub/scm/linux/kernel/git/vgupta/arc >> > git bisect bad ef0e1ea8856bed6ff8394d3dfe77f2cab487ecea >> > # good: [e0b3f595d13b3e9ce9cdf53935e7f304c04b5b2b] affs ->d_compare(): >> > don't bother with ->d_inode >> > git bisect good e0b3f595d13b3e9ce9cdf53935e7f304c04b5b2b >> > # bad: [77a87824ed676ca8ff8482e4157d3adb284fd381] >> > clocksource/drivers/clps_711x: fixup for "ARM: clps711x: >> > git bisect bad 77a87824ed676ca8ff8482e4157d3adb284fd381 >> > # bad: [27acbec338113a75b9d72aeb53149a3538031dda] Merge >> > git://www.linux-watchdog.org/linux-watchdog >> > git bisect bad 27acbec338113a75b9d72aeb53149a3538031dda >> > # bad: [7f155c702677d057d03b192ce652311de5434697] Merge tag >> > 'nfs-for-4.8-1' of git://git.linux-nfs.org/projects/trondmy/linux-nfs >> > git bisect bad 7f155c702677d057d03b192ce652311de5434697 >> > # good: [797cee982eef9195736afc5e7f3b8f613c41d19a] Merge branch >> > 'stable-4.8' of git://git.infradead.org/users/pcmoore/audit >> > git bisect good 797cee982eef9195736afc5e7f3b8f613c41d19a >> > # bad: [1056c9bd2702ea1bb79abf9bd1e78c578589d247] Merge tag >> > 'clk-for-linus-4.8' of >> > git://git.kernel.org/pub/scm/linux/kernel/git/clk/linux >> > git bisect bad 1056c9bd2702ea1bb79abf9bd1e78c578589d247 >> > # bad: [1ff435d3571199a799ba6ccfe05544dcd21b9fb3] Merge branch >> > 'clk-st-critical' into clk-next >> > git bisect bad 1ff435d3571199a799ba6ccfe05544dcd21b9fb3 >> > # bad: [0e4504470667d355b53ca3c9802fdd2120c9f946] clk: samsung: >> > exynos5433: Add CLK_IGNORE_UNUSED flag to PCIE device >> > git bisect bad 0e4504470667d355b53ca3c9802fdd2120c9f946 >> > # bad: [880c81b3b6604a004d56b5975c8bed47276e8bf6] clk: samsung: >> > exynos5440: Constify all clock initializers >> > git bisect bad 880c81b3b6604a004d56b5975c8bed47276e8bf6 >> > # bad: [b3a96eed8e84780d300b79b58047ea277ba358b7] clk: samsung: >> > exynos3250: Move platform driver and of_device_id to init section >> > git bisect bad b3a96eed8e84780d300b79b58047ea277ba358b7 >> > # bad: [4528dd8ed477bf202bd33ee48d38d656672d37f8] dt-bindings: clock: Add >> > watchdog and SSS clock IDs to Exynos5410 >> > git bisect bad 4528dd8ed477bf202bd33ee48d38d656672d37f8 >> > # bad: [5cd3535a27a7cf8fc4070b499d66e419e7e72b61] dt-bindings: clock: Add >> > PWM and USB clock IDs to Exynos5410 >> > git bisect bad 5cd3535a27a7cf8fc4070b499d66e419e7e72b61 >> > # bad: [4c5773f9f5462dcb372857813918bbfe8c0cdcdd] dt-bindings: clock: Add >> > license and reformat Exynos5410 clock IDs >> > git bisect bad 4c5773f9f5462dcb372857813918bbfe8c0cdcdd >> > # first bad commit: [4c5773f9f5462dcb372857813918bbfe8c0cdcdd] >> > dt-bindings: clock: Add license and reformat Exynos5410 clock IDs >> > >> > >> > > >> > > [ 74.123859] tg
Re: tg3 BUG: spinlock lockup suspected
On Sat, Oct 8, 2016 at 10:15 PM, Meelis Roos wrote: >> That did not go well - bisect found the following commit but that does >> not seem to be related at all. So probably the reproducibility is not >> 100% but more random. > > Now I reproduced the bug even with 4.7-rc1 so it is older than 4.7. Will > test further. > Thanks for reporting this. We will look into this. Any specific steps to reproduce this? >> >> >> 4c5773f9f5462dcb372857813918bbfe8c0cdcdd is the first bad commit >> commit 4c5773f9f5462dcb372857813918bbfe8c0cdcdd >> Author: Krzysztof Kozlowski >> Date: Sat May 28 11:54:12 2016 +0200 >> >> dt-bindings: clock: Add license and reformat Exynos5410 clock IDs >> >> Add license and copyrights (file introduced in 2014) to header with >> Exynos5410 clock IDs. Additionally reformat it to improve readability. >> >> Signed-off-by: Krzysztof Kozlowski >> Acked-by: Stephen Boyd >> Reviewed-by: Javier Martinez Canillas >> Signed-off-by: Sylwester Nawrocki >> >> :04 04 acbd432e11366a8eb8775942bc7b8caa476226e2 >> 08e3a3f98c3d4fa2a93123c3f21b2847c06b4665 M include >> >> >> The whiole bisect log seems to dig around in unrelated places so at best >> it just narrows the window by adding some known-bad data points. >> >> git bisect start >> # good: [523d939ef98fd712632d93a5a2b588e477a7565e] Linux 4.7 >> git bisect good 523d939ef98fd712632d93a5a2b588e477a7565e >> # bad: [ef0e1ea8856bed6ff8394d3dfe77f2cab487ecea] Merge tag >> 'arc-4.8-rc4-fixes' of >> git://git.kernel.org/pub/scm/linux/kernel/git/vgupta/arc >> git bisect bad ef0e1ea8856bed6ff8394d3dfe77f2cab487ecea >> # good: [e0b3f595d13b3e9ce9cdf53935e7f304c04b5b2b] affs ->d_compare(): don't >> bother with ->d_inode >> git bisect good e0b3f595d13b3e9ce9cdf53935e7f304c04b5b2b >> # bad: [77a87824ed676ca8ff8482e4157d3adb284fd381] >> clocksource/drivers/clps_711x: fixup for "ARM: clps711x: >> git bisect bad 77a87824ed676ca8ff8482e4157d3adb284fd381 >> # bad: [27acbec338113a75b9d72aeb53149a3538031dda] Merge >> git://www.linux-watchdog.org/linux-watchdog >> git bisect bad 27acbec338113a75b9d72aeb53149a3538031dda >> # bad: [7f155c702677d057d03b192ce652311de5434697] Merge tag 'nfs-for-4.8-1' >> of git://git.linux-nfs.org/projects/trondmy/linux-nfs >> git bisect bad 7f155c702677d057d03b192ce652311de5434697 >> # good: [797cee982eef9195736afc5e7f3b8f613c41d19a] Merge branch 'stable-4.8' >> of git://git.infradead.org/users/pcmoore/audit >> git bisect good 797cee982eef9195736afc5e7f3b8f613c41d19a >> # bad: [1056c9bd2702ea1bb79abf9bd1e78c578589d247] Merge tag >> 'clk-for-linus-4.8' of >> git://git.kernel.org/pub/scm/linux/kernel/git/clk/linux >> git bisect bad 1056c9bd2702ea1bb79abf9bd1e78c578589d247 >> # bad: [1ff435d3571199a799ba6ccfe05544dcd21b9fb3] Merge branch >> 'clk-st-critical' into clk-next >> git bisect bad 1ff435d3571199a799ba6ccfe05544dcd21b9fb3 >> # bad: [0e4504470667d355b53ca3c9802fdd2120c9f946] clk: samsung: exynos5433: >> Add CLK_IGNORE_UNUSED flag to PCIE device >> git bisect bad 0e4504470667d355b53ca3c9802fdd2120c9f946 >> # bad: [880c81b3b6604a004d56b5975c8bed47276e8bf6] clk: samsung: exynos5440: >> Constify all clock initializers >> git bisect bad 880c81b3b6604a004d56b5975c8bed47276e8bf6 >> # bad: [b3a96eed8e84780d300b79b58047ea277ba358b7] clk: samsung: exynos3250: >> Move platform driver and of_device_id to init section >> git bisect bad b3a96eed8e84780d300b79b58047ea277ba358b7 >> # bad: [4528dd8ed477bf202bd33ee48d38d656672d37f8] dt-bindings: clock: Add >> watchdog and SSS clock IDs to Exynos5410 >> git bisect bad 4528dd8ed477bf202bd33ee48d38d656672d37f8 >> # bad: [5cd3535a27a7cf8fc4070b499d66e419e7e72b61] dt-bindings: clock: Add >> PWM and USB clock IDs to Exynos5410 >> git bisect bad 5cd3535a27a7cf8fc4070b499d66e419e7e72b61 >> # bad: [4c5773f9f5462dcb372857813918bbfe8c0cdcdd] dt-bindings: clock: Add >> license and reformat Exynos5410 clock IDs >> git bisect bad 4c5773f9f5462dcb372857813918bbfe8c0cdcdd >> # first bad commit: [4c5773f9f5462dcb372857813918bbfe8c0cdcdd] dt-bindings: >> clock: Add license and reformat Exynos5410 clock IDs >> >> >> > >> > [ 74.123859] tg3.c:v3.137 (May 11, 2014) >> > [ 74.123880] PCI: Enabling device: (:00:02.0), cmd 2 >> > [ 74.315794] tg3 :00:02.0 (unnamed net_device) (uninitialized): >> > Cannot get nvram lock, tg3_nvram_init failed >> > [ 74.656152] tg3 :00:02.0 eth0: Tigon3 [partno(none) rev 2003] >> > (PCI:66MHz:64-bit) MAC address 00:03:ba:0a:f3:85 >> > [ 74.656160] tg3 :00:02.0 eth0: attached PHY is 5704 >> > (10/100/1000Base-T Ethernet) (WireSpeed[1], EEE[0]) >> > [ 74.656167] tg3 :00:02.0 eth0: RXcsums[1] LinkChgREG[0] MIirq[0] >> > ASF[0] TSOcap[1] >> > [ 74.656172] tg3 :00:02.0 eth0: dma_rwctrl[763f] dma_mask[32-bit] >> > [ 74.656322] PCI: Enabling device: (:00:02.1), cmd 2 >> > [ 74.845325] tg3 :00:02.1 (unnamed net_device) (uninitialized): >> > Cannot get nvram lock, tg3_nvram_init failed >>
Re: [PATCH V3 29/29] ethernet: use parity8 in broadcom/tg3.c
On Thu, Apr 14, 2016 at 8:42 AM, wrote:
>
> From: Zhaoxiu Zeng
>
> Signed-off-by: Zhaoxiu Zeng
Looks good to me.
Acked-by: Siva Reddy Kallam
> ---
> drivers/net/ethernet/broadcom/tg3.c | 6 +-
> 1 file changed, 1 insertion(+), 5 deletions(-)
>
> diff --git a/drivers/net/ethernet/broadcom/tg3.c
> b/drivers/net/ethernet/broadcom/tg3.c
> index 3010080..802a429 100644
> --- a/drivers/net/ethernet/broadcom/tg3.c
> +++ b/drivers/net/ethernet/broadcom/tg3.c
> @@ -12939,11 +12939,7 @@ static int tg3_test_nvram(struct tg3 *tp)
>
> err = -EIO;
> for (i = 0; i < NVRAM_SELFBOOT_DATA_SIZE; i++) {
> - u8 hw8 = hweight8(data[i]);
> -
> - if ((hw8 & 0x1) && parity[i])
> - goto out;
> - else if (!(hw8 & 0x1) && !parity[i])
> + if (parity8(data[i]) == !!parity[i])
> goto out;
> }
> err = 0;
> --
> 2.5.0
>
>
