Re: [PATCH v2] block: ratelimite pr_err on IO path

On Mon, Apr 16, 2018 at 1:46 PM, Jinpu Wang wrote: > On Fri, Apr 13, 2018 at 6:59 PM, Martin K. Petersen > wrote: >> >> Jinpu, >> >> [CC:ed the mpt3sas maintainers] >> >> The ratelimit patch is just an attempt to treat the symptom, not the

Re: [PATCH v2] block: ratelimite pr_err on IO path

On Mon, Apr 16, 2018 at 1:46 PM, Jinpu Wang wrote: > On Fri, Apr 13, 2018 at 6:59 PM, Martin K. Petersen > wrote: >> >> Jinpu, >> >> [CC:ed the mpt3sas maintainers] >> >> The ratelimit patch is just an attempt to treat the symptom, not the >> cause. > Agree. If we can fix the root cause, it will

RE: [PATCH] scsi: mpt3sas: clarify mmio pointer types

-Original Message- From: Arnd Bergmann [mailto:a...@arndb.de] Sent: Thursday, March 1, 2018 6:37 PM To: Suganath Prabu S; Sathya Prakash; Chaitra P B; James E.J. Bottomley; Martin K. Petersen Cc: Arnd Bergmann; Hannes Reinecke; Sreekanth Reddy; mpt-fusionlinux@broadcom.com; linux-s

RE: [PATCH] scsi: mpt3sas: clarify mmio pointer types

-Original Message- From: Arnd Bergmann [mailto:a...@arndb.de] Sent: Thursday, March 1, 2018 6:37 PM To: Suganath Prabu S; Sathya Prakash; Chaitra P B; James E.J. Bottomley; Martin K. Petersen Cc: Arnd Bergmann; Hannes Reinecke; Sreekanth Reddy; mpt-fusionlinux@broadcom.com; linux-s

[PATCH 04/10] mpt3sas: Fix removal and addition of vSES device during host reset

for Virtual SES device instead of HBA's sas address. Signed-off-by: Sreekanth Reddy <sreekanth.re...@broadcom.com> --- drivers/scsi/mpt3sas/mpt3sas_scsih.c | 15 +-- 1 file changed, 9 insertions(+), 6 deletions(-) diff --git a/drivers/scsi/mpt3sas/mpt3sas_scsih.c b/drivers/scsi/m

[PATCH 04/10] mpt3sas: Fix removal and addition of vSES device during host reset

for Virtual SES device instead of HBA's sas address. Signed-off-by: Sreekanth Reddy --- drivers/scsi/mpt3sas/mpt3sas_scsih.c | 15 +-- 1 file changed, 9 insertions(+), 6 deletions(-) diff --git a/drivers/scsi/mpt3sas/mpt3sas_scsih.c b/drivers/scsi/mpt3sas/mpt3sas_scsih.c index 600e8ef

[PATCH 07/10] mpt3sas: Display chassis slot information of the drive

Display chassis slot information along with other drive location parameters such as slot number and connector name in the logs; if chassis slot validity bit is set in 'SAS Enclosure Page 0' while adding the drive. Signed-off-by: Sreekanth Reddy <sreekanth.re...@broadcom.com> --- driver

[PATCH 07/10] mpt3sas: Display chassis slot information of the drive

Display chassis slot information along with other drive location parameters such as slot number and connector name in the logs; if chassis slot validity bit is set in 'SAS Enclosure Page 0' while adding the drive. Signed-off-by: Sreekanth Reddy --- drivers/scsi/mpt3sas/mpt3sas_base.h | 4

[PATCH 09/10] mpt3sas: Adding support for SAS3616 HBA device

Adding PNP ID of Mercator i.e. SAS3616 HBA device. Its device ID is 0xD1 and vendor ID is 0x1000. Signed-off-by: Sreekanth Reddy <sreekanth.re...@broadcom.com> --- drivers/scsi/mpt3sas/mpt3sas_scsih.c | 5 + 1 file changed, 5 insertions(+) diff --git a/drivers/scsi/mpt3sas/mpt3sas_s

[PATCH 09/10] mpt3sas: Adding support for SAS3616 HBA device

Adding PNP ID of Mercator i.e. SAS3616 HBA device. Its device ID is 0xD1 and vendor ID is 0x1000. Signed-off-by: Sreekanth Reddy --- drivers/scsi/mpt3sas/mpt3sas_scsih.c | 5 + 1 file changed, 5 insertions(+) diff --git a/drivers/scsi/mpt3sas/mpt3sas_scsih.c b/drivers/scsi/mpt3sas

[PATCH 06/10] mpt3sas: Updated MPI headers to v2.00.48

Updated MPI headers to v2.00.48 Signed-off-by: Sreekanth Reddy <sreekanth.re...@broadcom.com> --- drivers/scsi/mpt3sas/mpi/mpi2.h | 43 ++- drivers/scsi/mpt3sas/mpi/mpi2_cnfg.h | 564 +-- drivers/scsi/mpt3sas/mpi/mpi2_init.h | 11 +- drivers/scsi/m

[PATCH 10/10] mpt3sas: Bump mpt3sas driver version to v16.100.00.00

Bump mpt3sas driver version to v16.100.00.00 Signed-off-by: Sreekanth Reddy <sreekanth.re...@broadcom.com> --- drivers/scsi/mpt3sas/mpt3sas_base.h | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/drivers/scsi/mpt3sas/mpt3sas_base.h b/drivers/scsi/mpt3sas/mpt3sas_

[PATCH 06/10] mpt3sas: Updated MPI headers to v2.00.48

Updated MPI headers to v2.00.48 Signed-off-by: Sreekanth Reddy --- drivers/scsi/mpt3sas/mpi/mpi2.h | 43 ++- drivers/scsi/mpt3sas/mpi/mpi2_cnfg.h | 564 +-- drivers/scsi/mpt3sas/mpi/mpi2_init.h | 11 +- drivers/scsi/mpt3sas/mpi/mpi2_ioc.h | 282

[PATCH 10/10] mpt3sas: Bump mpt3sas driver version to v16.100.00.00

Bump mpt3sas driver version to v16.100.00.00 Signed-off-by: Sreekanth Reddy --- drivers/scsi/mpt3sas/mpt3sas_base.h | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/drivers/scsi/mpt3sas/mpt3sas_base.h b/drivers/scsi/mpt3sas/mpt3sas_base.h index 75d90f2..0fe3969 100644

[PATCH 08/10] mpt3sas: Fix possibility of using invalid Enclosure Handles for SAS device after host reset

reset to current value, by referring the enclosure handles from corresponding device pages Signed-off-by: Sreekanth Reddy <sreekanth.re...@broadcom.com> --- drivers/scsi/mpt3sas/mpt3sas_scsih.c | 117 --- 1 file changed, 81 insertions(+), 36 deletions(-) diff

[PATCH 08/10] mpt3sas: Fix possibility of using invalid Enclosure Handles for SAS device after host reset

reset to current value, by referring the enclosure handles from corresponding device pages Signed-off-by: Sreekanth Reddy --- drivers/scsi/mpt3sas/mpt3sas_scsih.c | 117 --- 1 file changed, 81 insertions(+), 36 deletions(-) diff --git a/drivers/scsi/mpt3sas

[PATCH 05/10] mpt3sas: Fix IO error occurs on pulling out a drive from RAID1 volume created on two SATA drive

. Earlier driver is returning the IO with "DID_SOFT_ERROR" that reties the IO quickly for five times but still firmware needed some more time and hence IOs were failing. Signed-off-by: Sreekanth Reddy <sreekanth.re...@broadcom.com> --- drivers/scsi/mpt3sas/mpt3sas_scsih.c | 5

[PATCH 05/10] mpt3sas: Fix IO error occurs on pulling out a drive from RAID1 volume created on two SATA drive

. Earlier driver is returning the IO with "DID_SOFT_ERROR" that reties the IO quickly for five times but still firmware needed some more time and hence IOs were failing. Signed-off-by: Sreekanth Reddy --- drivers/scsi/mpt3sas/mpt3sas_scsih.c | 5 + 1 file changed, 5 insertio

[PATCH 01/10] mpt3sas: Processing of Cable Exception events

. MPI 2.5 spec supporting HBAs) earlier this event was enabled only for MPI 2.6 spec supporting HBA devices. Signed-off-by: Sreekanth Reddy <sreekanth.re...@broadcom.com> --- drivers/scsi/mpt3sas/mpt3sas_base.c | 5 ++--- drivers/scsi/mpt3sas/mpt3sas_scsih.c | 20 +++- 2 files ch

[PATCH 01/10] mpt3sas: Processing of Cable Exception events

. MPI 2.5 spec supporting HBAs) earlier this event was enabled only for MPI 2.6 spec supporting HBA devices. Signed-off-by: Sreekanth Reddy --- drivers/scsi/mpt3sas/mpt3sas_base.c | 5 ++--- drivers/scsi/mpt3sas/mpt3sas_scsih.c | 20 +++- 2 files changed, 13 insertions(+), 12 deletions(

[PATCH 02/10] mpt3sas: Fixed memory leaks in driver

structures. Updated the driver to remove the expander device from the list only after freeing all its child devices. Signed-off-by: Sreekanth Reddy <sreekanth.re...@broadcom.com> --- drivers/scsi/mpt3sas/mpt3sas_scsih.c | 9 + 1 file changed, 5 insertions(+), 4 deletions(-) diff

[PATCH 00/10] [SCSI] mpt3sas: Phase15 driver enhancements and fixes

Phase15 driver enhancements and fixes. Sreekanth Reddy (10): mpt3sas: Processing of Cable Exception events mpt3sas: Fixed memory leaks in driver mpt3sas: Reduce memory footprints in kdump kernel mpt3sas: Fix removal and addition of vSES device during host reset mpt3sas: Fix IO error

[PATCH 02/10] mpt3sas: Fixed memory leaks in driver

structures. Updated the driver to remove the expander device from the list only after freeing all its child devices. Signed-off-by: Sreekanth Reddy --- drivers/scsi/mpt3sas/mpt3sas_scsih.c | 9 + 1 file changed, 5 insertions(+), 4 deletions(-) diff --git a/drivers/scsi/mpt3sas

[PATCH 00/10] [SCSI] mpt3sas: Phase15 driver enhancements and fixes

Phase15 driver enhancements and fixes. Sreekanth Reddy (10): mpt3sas: Processing of Cable Exception events mpt3sas: Fixed memory leaks in driver mpt3sas: Reduce memory footprints in kdump kernel mpt3sas: Fix removal and addition of vSES device during host reset mpt3sas: Fix IO error

[PATCH 03/10] mpt3sas: Reduce memory footprints in kdump kernel

To reduce the memory footprints of the driver in kdump kernel, we have made below driver setting when system boots in to kdump kernel, 1. Used single MSI-x vector. 2. Disable RDPQ mode. 3. Set sg_table_size to 32 by default. 4) Set SCSI IO Queue depth to 200. Signed-off-by: Sreekanth Reddy

[PATCH 03/10] mpt3sas: Reduce memory footprints in kdump kernel

To reduce the memory footprints of the driver in kdump kernel, we have made below driver setting when system boots in to kdump kernel, 1. Used single MSI-x vector. 2. Disable RDPQ mode. 3. Set sg_table_size to 32 by default. 4) Set SCSI IO Queue depth to 200. Signed-off-by: Sreekanth Reddy

Re: [PATCH v2 00/13] mpt3sas driver NVMe support:

On Tue, Aug 8, 2017 at 9:34 AM, Keith Busch wrote: > On Mon, Aug 07, 2017 at 08:45:25AM -0700, James Bottomley wrote: >> On Mon, 2017-08-07 at 20:01 +0530, Kashyap Desai wrote: >> > >> > We have to attempt this use case and see how it behaves. I have not >> > tried this, so

Re: [PATCH v2 00/13] mpt3sas driver NVMe support:

On Tue, Aug 8, 2017 at 9:34 AM, Keith Busch wrote: > On Mon, Aug 07, 2017 at 08:45:25AM -0700, James Bottomley wrote: >> On Mon, 2017-08-07 at 20:01 +0530, Kashyap Desai wrote: >> > >> > We have to attempt this use case and see how it behaves. I have not >> > tried this, so not sure if things are

Re: [PATCH v2 09/13] mpt3sas: scan and add nvme device after controller reset

On Thu, Aug 3, 2017 at 12:10 PM, Hannes Reinecke wrote: > On 07/14/2017 03:22 PM, Suganath Prabu S wrote: >> After Controller reset, Scan and add nvme device back to the topology. >> >> Signed-off-by: Chaitra P B >> Signed-off-by: Suganath Prabu S

Re: [PATCH v2 09/13] mpt3sas: scan and add nvme device after controller reset

On Thu, Aug 3, 2017 at 12:10 PM, Hannes Reinecke wrote: > On 07/14/2017 03:22 PM, Suganath Prabu S wrote: >> After Controller reset, Scan and add nvme device back to the topology. >> >> Signed-off-by: Chaitra P B >> Signed-off-by: Suganath Prabu S >> --- >> drivers/scsi/mpt3sas/mpt3sas_scsih.c

Re: [PATCH v2 02/13] mpt3sas: Add nvme device support in slave alloc, target alloc and probe

On Thu, Aug 3, 2017 at 11:57 AM, Hannes Reinecke wrote: > On 07/14/2017 03:22 PM, Suganath Prabu S wrote: >> 1) Added support for probing pcie device and adding NVMe drives to >> SML and driver's internal list pcie_device_list. >> >> 2) Added support for determing NVMe as boot

Re: [PATCH v2 02/13] mpt3sas: Add nvme device support in slave alloc, target alloc and probe

On Thu, Aug 3, 2017 at 11:57 AM, Hannes Reinecke wrote: > On 07/14/2017 03:22 PM, Suganath Prabu S wrote: >> 1) Added support for probing pcie device and adding NVMe drives to >> SML and driver's internal list pcie_device_list. >> >> 2) Added support for determing NVMe as boot device. >> >> 3)

Re: [PATCH v2 08/13] mpt3sas: Set NVMe device queue depth as 128

On Thu, Aug 3, 2017 at 12:09 PM, Hannes Reinecke wrote: > On 07/14/2017 03:22 PM, Suganath Prabu S wrote: >> Sets nvme device queue depth, name and displays device capabilities >> >> Signed-off-by: Chaitra P B >> Signed-off-by: Suganath Prabu S

Re: [PATCH v2 08/13] mpt3sas: Set NVMe device queue depth as 128

On Thu, Aug 3, 2017 at 12:09 PM, Hannes Reinecke wrote: > On 07/14/2017 03:22 PM, Suganath Prabu S wrote: >> Sets nvme device queue depth, name and displays device capabilities >> >> Signed-off-by: Chaitra P B >> Signed-off-by: Suganath Prabu S >> --- >> drivers/scsi/mpt3sas/mpt3sas_base.h |

Re: [PATCH v2 01/13] mpt3sas: Update MPI Header

On Thu, Aug 3, 2017 at 1:25 PM, Johannes Thumshirn wrote: > On Thu, Aug 03, 2017 at 08:24:59AM +0200, Hannes Reinecke wrote: >> > + U32 >> > + IOCLogInfo; /*0x10 */ >> > + U16 >> > + ErrorResponseCount; /*0x14 */ >> > +

Re: [PATCH v2 01/13] mpt3sas: Update MPI Header

On Thu, Aug 3, 2017 at 1:25 PM, Johannes Thumshirn wrote: > On Thu, Aug 03, 2017 at 08:24:59AM +0200, Hannes Reinecke wrote: >> > + U32 >> > + IOCLogInfo; /*0x10 */ >> > + U16 >> > + ErrorResponseCount; /*0x14 */ >> > + U16 >> > +

mpt3sas: driver got task abort request just after it's .shutdown() function is invoked

Hi All, I am using 4.9 kernel and I am observing NULL pointer deference type kernel panic in the below scenario, * Hotplug (i.e. hot add) the HBA (with a set of drives attached to it) to the system just few seconds before issuing "poweroff" command. * Observed that during drives discovery

mpt3sas: driver got task abort request just after it's .shutdown() function is invoked

Hi All, I am using 4.9 kernel and I am observing NULL pointer deference type kernel panic in the below scenario, * Hotplug (i.e. hot add) the HBA (with a set of drives attached to it) to the system just few seconds before issuing "poweroff" command. * Observed that during drives discovery

Re: [RESEND][PATCH 07/10][SCSI]mpt2sas: Added Reply Descriptor Post Queue (RDPQ) Array support

On Thu, Jul 24, 2014 at 1:16 AM, Martin K. Petersen <martin.peter...@oracle.com> wrote: >>>>>> "Sreekanth" == Sreekanth Reddy <sreekanth.re...@avagotech.com> writes: > > Sreekanth, > > Sreekanth> 2. As per MPI Spec, each set of 8 reply descr

Re: [RESEND][PATCH 07/10][SCSI]mpt2sas: Added Reply Descriptor Post Queue (RDPQ) Array support

On Thu, Jul 24, 2014 at 1:16 AM, Martin K. Petersen wrote: >>>>>> "Sreekanth" == Sreekanth Reddy writes: > > Sreekanth, > > Sreekanth> 2. As per MPI Spec, each set of 8 reply descriptor post > Sreekanth> queues must have the same value for the u

Re: [PATCH V2] scsi: mpt3sas: remove redundant wmb

On Thu, Apr 20, 2017 at 7:58 AM, Martin K. Petersen wrote: > Sinan Kaya writes: > >> Due to relaxed ordering requirements on multiple architectures, >> drivers are required to use wmb/rmb/mb combinations when they need to >> guarantee

Re: [PATCH V2] scsi: mpt3sas: remove redundant wmb

On Thu, Apr 20, 2017 at 7:58 AM, Martin K. Petersen wrote: > Sinan Kaya writes: > >> Due to relaxed ordering requirements on multiple architectures, >> drivers are required to use wmb/rmb/mb combinations when they need to >> guarantee observability between the memory and the HW. >> >> The

Re: Getting "Wrong diagnostic page; asked for 7 got 0" error message on HBA's virtual SES device

Hi, Any Update? Thanks, Sreekanth On Mon, Mar 13, 2017 at 12:13 PM, Sreekanth Reddy <sreekanth.re...@broadcom.com> wrote: > Hi, > > Our LSI(Broadcom) SAS3.5 HBA device's support virtual SES device. > > Whenever we load the mpt3sas driver then we are observing below erro

Re: Getting "Wrong diagnostic page; asked for 7 got 0" error message on HBA's virtual SES device

Hi, Any Update? Thanks, Sreekanth On Mon, Mar 13, 2017 at 12:13 PM, Sreekanth Reddy wrote: > Hi, > > Our LSI(Broadcom) SAS3.5 HBA device's support virtual SES device. > > Whenever we load the mpt3sas driver then we are observing below error message, > > "Wrong diagno

Getting "Wrong diagnostic page; asked for 7 got 0" error message on HBA's virtual SES device

Hi, Our LSI(Broadcom) SAS3.5 HBA device's support virtual SES device. Whenever we load the mpt3sas driver then we are observing below error message, "Wrong diagnostic page; asked for 7 got 0" Our virtual SES device doesn't support Diagnostic page 7, it supports only below diagnostic pages, •

Getting "Wrong diagnostic page; asked for 7 got 0" error message on HBA's virtual SES device

Hi, Our LSI(Broadcom) SAS3.5 HBA device's support virtual SES device. Whenever we load the mpt3sas driver then we are observing below error message, "Wrong diagnostic page; asked for 7 got 0" Our virtual SES device doesn't support Diagnostic page 7, it supports only below diagnostic pages, •

Re: [PATCH v2 2/4] mpt3sas: Fix for Crusader to achieve product targets with SAS devices.

On Fri, Jan 20, 2017 at 8:30 PM, Johannes Thumshirn wrote: > On Fri, Jan 20, 2017 at 08:12:11PM +0530, Chaitra P B wrote: >> Small glitch/degraded performance in Crusader is improved with SAS >> drives by removing unnecessary spinlocks while clearing scsi command >> in drivers

Re: [PATCH v2 2/4] mpt3sas: Fix for Crusader to achieve product targets with SAS devices.

On Fri, Jan 20, 2017 at 8:30 PM, Johannes Thumshirn wrote: > On Fri, Jan 20, 2017 at 08:12:11PM +0530, Chaitra P B wrote: >> Small glitch/degraded performance in Crusader is improved with SAS >> drives by removing unnecessary spinlocks while clearing scsi command >> in drivers internal lookup

Re: [PATCH v2 3/4] mpt3sas: Fix Firmware fault state 0x2100 during heavy 4K RR FIO stress test.

On Fri, Jan 20, 2017 at 8:40 PM, Johannes Thumshirn wrote: > On Fri, Jan 20, 2017 at 08:12:12PM +0530, Chaitra P B wrote: >> Due existence of loop in the IO path our HBA will receive heavy IOs and >> also as driver is not updating the Reply Post Host Index frequently, So >>

Re: [PATCH v2 3/4] mpt3sas: Fix Firmware fault state 0x2100 during heavy 4K RR FIO stress test.

On Fri, Jan 20, 2017 at 8:40 PM, Johannes Thumshirn wrote: > On Fri, Jan 20, 2017 at 08:12:12PM +0530, Chaitra P B wrote: >> Due existence of loop in the IO path our HBA will receive heavy IOs and >> also as driver is not updating the Reply Post Host Index frequently, So >> there will be a high

Re: [PATCH] scsi: mpt3sas: fix hang on ata passthru commands

d of "if (sas_device_priv_data->ata_command_pending)". Since while setting & clearing the bit we are using atomic bit operations. I don't see any issue functionality wise. > sas_target_priv_data = sas_device_priv_data->sas_target; > > /* invalid dev

Re: [PATCH] scsi: mpt3sas: fix hang on ata passthru commands

ssue functionality wise. > sas_target_priv_data = sas_device_priv_data->sas_target; > > /* invalid device handle */ > @@ -4650,8 +4663,7 @@ _scsih_io_done(struct MPT3SAS_ADAPTER *ioc, u16 smid, > u8 msix_index, u32 reply) > if (scmd == NULL) > return 1; > > - if (ata_12_16_cmd(scmd)) > - scsi_internal_device_unblock(scmd->device, SDEV_RUNNING); > + _scsih_set_satl_pending(scmd, false); > > mpi_request = mpt3sas_base_get_msg_frame(ioc, smid); > > -- > 2.6.6 > Tested this patch. It is working fine. Please consider this patch as Acked-by: Sreekanth Reddy Thanks, Sreekanth

Re: [PATCH] scsi: mpt3sas: fix hang on ata passthru commands

> > I also like this approach better. > > Broadcom folks: Please comment and test. Matin, We are fine with this patch. Can we rename function 'set_satl_pending()' name to '_scsih_set_satl_pending()' and can add headers to this function. other wise I am OK. Acked-by: Sreekanth Reddy <sreekanth.re...@broadcom.com> > > -- > Martin K. Petersen Oracle Linux Engineering

Re: [PATCH] scsi: mpt3sas: fix hang on ata passthru commands

folks: Please comment and test. Matin, We are fine with this patch. Can we rename function 'set_satl_pending()' name to '_scsih_set_satl_pending()' and can add headers to this function. other wise I am OK. Acked-by: Sreekanth Reddy > > -- > Martin K. Petersen Oracle Linux Engineering

Re: [PATCH v2] mpt3sas: Recognize and act on iopriority info

igned-off-by: Adam Manzanares <adam.manzana...@wdc.com> Acked-by: Sreekanth Reddy <sreekanth.re...@broadcom.com> > --- > drivers/scsi/mpt3sas/mpt3sas_base.h | 6 + > drivers/scsi/mpt3sas/mpt3sas_ctl.c | 43 > ++-- > drivers/scsi

Re: [PATCH v2] mpt3sas: Recognize and act on iopriority info

command priorities in the identify information that is pulled from > the SATL. > > This patch depends on block: Add iocontext priority to request > > v2: > - Get iopriority class only if sysfs variable is set. > > Signed-off-by: Adam Manzanares Acked-by: Sreekanth Reddy &g

[PATCH RESEND] mpt3sas: Fix for block device of raid exists even after deleting raid disk

o above hunk, we are not initializing raid_device's starget for raid volumes, and so during raid disk deletion driver is not calling scsi_remove_target() API as driver observes starget field of raid_device's structure as NULL. Signed-off-by: Sreekanth Reddy <sreekanth.re...@broadcom.com> Cc: <sta

[PATCH RESEND] mpt3sas: Fix for block device of raid exists even after deleting raid disk

o above hunk, we are not initializing raid_device's starget for raid volumes, and so during raid disk deletion driver is not calling scsi_remove_target() API as driver observes starget field of raid_device's structure as NULL. Signed-off-by: Sreekanth Reddy Cc: --- drivers/scsi/mpt3sas/mpt3sas_scsih.c |

[PATCH] mpt3sas: Fix for block device of raid exists even after deleting raid disk

o above hunk, we are not initializing raid_device's starget for raid volumes, and so during raid disk deletion driver is not calling scsi_remove_target() API as driver observes starget field of raid_device's structure as NULL. Signed-off-by: Sreekanth Reddy <sreekanth.re...@broadcom.com> --- drivers/sc

[PATCH] mpt3sas: Fix for block device of raid exists even after deleting raid disk

o above hunk, we are not initializing raid_device's starget for raid volumes, and so during raid disk deletion driver is not calling scsi_remove_target() API as driver observes starget field of raid_device's structure as NULL. Signed-off-by: Sreekanth Reddy --- drivers/scsi/mpt3sas/mpt3sas_scsih.c | 4 ++-

[PATCH v2] block: Fix kernel panic occurs while creating second raid disk

From: Sreekanth Reddy <sreekanth.re...@broadcom.com> Observing below kernel panic while creating second raid disk on LSI SAS3008 HBA card. [ +0.55] [ cut here ] [ +0.07] WARNING: CPU: 2 PID: 281 at fs/sysfs/dir.c:31 sysfs_warn_dup+0x62/0x80 [ +0.02]

[PATCH v2] block: Fix kernel panic occurs while creating second raid disk

From: Sreekanth Reddy Observing below kernel panic while creating second raid disk on LSI SAS3008 HBA card. [ +0.55] [ cut here ] [ +0.07] WARNING: CPU: 2 PID: 281 at fs/sysfs/dir.c:31 sysfs_warn_dup+0x62/0x80 [ +0.02] sysfs: cannot create duplicate

[PATCH] block: Fix kernel panic occurs while creating second raid disk

ries, which are PD's for raid disk /dev/sdk. Now while creating a second raid disk, kernel is trying to use MAJOR:MINOR as 8:32 for second raid disk and we observe above kernel OOPs. By calling bdi_unregister() in del_gendisk() function has resolved this issue. Signed-off-by: Sreekanth R

[PATCH] block: Fix kernel panic occurs while creating second raid disk

ries, which are PD's for raid disk /dev/sdk. Now while creating a second raid disk, kernel is trying to use MAJOR:MINOR as 8:32 for second raid disk and we observe above kernel OOPs. By calling bdi_unregister() in del_gendisk() function has resolved this issue. Signed-off-by: Sreekanth R

Re: Observing Softlockup's while running heavy IOs

On Thu, Sep 8, 2016 at 7:09 PM, Neil Horman <nhor...@tuxdriver.com> wrote: > On Thu, Sep 08, 2016 at 11:12:40AM +0530, Sreekanth Reddy wrote: >> On Wed, Sep 7, 2016 at 6:54 PM, Neil Horman <nhor...@tuxdriver.com> wrote: >> > On Wed, Sep 07, 2016 at 11:30:04A

Re: Observing Softlockup's while running heavy IOs

On Thu, Sep 8, 2016 at 7:09 PM, Neil Horman wrote: > On Thu, Sep 08, 2016 at 11:12:40AM +0530, Sreekanth Reddy wrote: >> On Wed, Sep 7, 2016 at 6:54 PM, Neil Horman wrote: >> > On Wed, Sep 07, 2016 at 11:30:04AM +0530, Sreekanth Reddy wrote: >> >> On Tue, Sep 6

Re: Observing Softlockup's while running heavy IOs

On Wed, Sep 7, 2016 at 6:54 PM, Neil Horman <nhor...@tuxdriver.com> wrote: > On Wed, Sep 07, 2016 at 11:30:04AM +0530, Sreekanth Reddy wrote: >> On Tue, Sep 6, 2016 at 8:36 PM, Neil Horman <nhor...@tuxdriver.com> wrote: >> > On Tue, Sep 06, 2016 at 04:52:37P

Re: Observing Softlockup's while running heavy IOs

On Wed, Sep 7, 2016 at 6:54 PM, Neil Horman wrote: > On Wed, Sep 07, 2016 at 11:30:04AM +0530, Sreekanth Reddy wrote: >> On Tue, Sep 6, 2016 at 8:36 PM, Neil Horman wrote: >> > On Tue, Sep 06, 2016 at 04:52:37PM +0530, Sreekanth Reddy wrote: >> >> On Fri, Sep 2, 20

Re: Observing Softlockup's while running heavy IOs

On Fri, Aug 19, 2016 at 9:26 PM, Bart Van Assche <bart.vanass...@sandisk.com> wrote: > On 08/19/2016 04:44 AM, Sreekanth Reddy wrote: >> >> [ +0.000439] __blk_mq_run_hw_queue() finished after 10058 ms >> [ ... ] >> [ +0.05] [] ? finish_task_switch+0x6b/0x20

Re: Observing Softlockup's while running heavy IOs

On Fri, Aug 19, 2016 at 9:26 PM, Bart Van Assche wrote: > On 08/19/2016 04:44 AM, Sreekanth Reddy wrote: >> >> [ +0.000439] __blk_mq_run_hw_queue() finished after 10058 ms >> [ ... ] >> [ +0.05] [] ? finish_task_switch+0x6b/0x200 >> [ +0.06] [] __sch

Re: Observing Softlockup's while running heavy IOs

19, 2016 at 2:38 AM, Elliott, Robert (Persistent Memory) <elli...@hpe.com> wrote: > > >> -Original Message- >> From: linux-kernel-ow...@vger.kernel.org [mailto:linux-kernel- >> ow...@vger.kernel.org] On Behalf Of Sreekanth Reddy >> Sent: Thursday, August

Re: Observing Softlockup's while running heavy IOs

19, 2016 at 2:38 AM, Elliott, Robert (Persistent Memory) wrote: > > >> -Original Message- >> From: linux-kernel-ow...@vger.kernel.org [mailto:linux-kernel- >> ow...@vger.kernel.org] On Behalf Of Sreekanth Reddy >> Sent: Thursday, August 18, 2016 12:56 AM >>

Observing Softlockup's while running heavy IOs

Hi, Problem statement: Observing softlockups while running heavy IOs on 8 SSD drives connected behind our LSI SAS 3004 HBA. System configuration: OS & kernel version: Fedora 23, v4.2.3-300.fc23.x86_64 NUMA : disabled, CPUs : 24 logical cpus, SCSI_MQ: enabled Driver : mpt3sas, MSIx vectors: we

Observing Softlockup's while running heavy IOs

Hi, Problem statement: Observing softlockups while running heavy IOs on 8 SSD drives connected behind our LSI SAS 3004 HBA. System configuration: OS & kernel version: Fedora 23, v4.2.3-300.fc23.x86_64 NUMA : disabled, CPUs : 24 logical cpus, SCSI_MQ: enabled Driver : mpt3sas, MSIx vectors: we

Re: [PATCH] mpt3sas: Do scsi_remove_host() before deleting SAS PHY objects

, 2016 at 11:19 PM, Calvin Owens <calvinow...@fb.com> wrote: > On Wednesday 05/18 at 18:44 +0530, Sreekanth Reddy wrote: >> On Tue, May 17, 2016 at 8:43 AM, Calvin Owens <calvinow...@fb.com> wrote: >> > On Monday 05/16 at 15:51 -0600, Sathya Prakash Veerichetty

Re: [PATCH] mpt3sas: Do scsi_remove_host() before deleting SAS PHY objects

, 2016 at 11:19 PM, Calvin Owens wrote: > On Wednesday 05/18 at 18:44 +0530, Sreekanth Reddy wrote: >> On Tue, May 17, 2016 at 8:43 AM, Calvin Owens wrote: >> > On Monday 05/16 at 15:51 -0600, Sathya Prakash Veerichetty wrote: >> >> Our understanding is the relationship

Re: [PATCH] mpt3sas: Do scsi_remove_host() before deleting SAS PHY objects

On Tue, May 17, 2016 at 8:43 AM, Calvin Owens wrote: > On Monday 05/16 at 15:51 -0600, Sathya Prakash Veerichetty wrote: >> Our understanding is the relationship between the SCSI host and SAS end >> devices is a parent-child and before ripping of SCSI host we need to rip of >>

Re: [PATCH] mpt3sas: Do scsi_remove_host() before deleting SAS PHY objects

On Tue, May 17, 2016 at 8:43 AM, Calvin Owens wrote: > On Monday 05/16 at 15:51 -0600, Sathya Prakash Veerichetty wrote: >> Our understanding is the relationship between the SCSI host and SAS end >> devices is a parent-child and before ripping of SCSI host we need to rip of >> all the children. >

Re: [PATCH 6/6] mpt3sas: Used "synchronize_irq()"API to synchronize timed-out IO & TMs

On Tue, May 10, 2016 at 6:41 PM, Tomas Henzl wrote: > On 6.5.2016 10:59, Chaitra P B wrote: >> Replaced mpt3sas_base_flush_reply_queues()with >> mpt3sas_base_sync_reply_irqs(),as mpt3sas_base_flush_reply_queues() >> skips over reply queues that are currently busy (i.e. being

Re: [PATCH 6/6] mpt3sas: Used "synchronize_irq()"API to synchronize timed-out IO & TMs

On Tue, May 10, 2016 at 6:41 PM, Tomas Henzl wrote: > On 6.5.2016 10:59, Chaitra P B wrote: >> Replaced mpt3sas_base_flush_reply_queues()with >> mpt3sas_base_sync_reply_irqs(),as mpt3sas_base_flush_reply_queues() >> skips over reply queues that are currently busy (i.e. being handled >> by

Re: [mpt3sas driver 07/10] mpt3sas: Add support for configurable Chain Frame Size

On Thu, Feb 4, 2016 at 8:35 PM, Tomas Henzl wrote: > On 28.1.2016 07:37, Suganath prabu Subaramani wrote: >> From: Suganath prabu Subramani >> >> Added support for configurable Chain Frame Size. Calculate the >> Chain Message Frame size from the IOCMaxChainSegementSize (iocfacts). >> Applicable

Re: [mpt3sas driver 07/10] mpt3sas: Add support for configurable Chain Frame Size

On Thu, Feb 4, 2016 at 8:35 PM, Tomas Henzl wrote: > On 28.1.2016 07:37, Suganath prabu Subaramani wrote: >> From: Suganath prabu Subramani >> >> Added support for configurable Chain Frame Size. Calculate the >> Chain Message Frame size

Re: MPT2SAS boot fail... due to silently loosing the driver

On Mon, Nov 30, 2015 at 10:51 PM, Martin K. Petersen wrote: > > > "Ingo" == Ingo Molnar writes: > > Ingo> So you need to make it interactive, with a short help text that > Ingo> explains to users that this is legacy option only, and that they > Ingo> should enable the MPT3SAS option if they

Re: MPT2SAS boot fail... due to silently loosing the driver

On Mon, Nov 30, 2015 at 10:51 PM, Martin K. Petersen wrote: > > > "Ingo" == Ingo Molnar writes: > > Ingo> So you need to make it interactive, with a short help text that > Ingo> explains to users that this is legacy option only, and that they >

Re: linux-next: build failure after merge of the scsi tree

Thanks Stephen. Please consider this patch as Ack-by: Sreekanth Reddy Thanks, Sreekanth On Fri, Nov 13, 2015 at 7:05 AM, Stephen Rothwell wrote: > Hi James, > > After merging the scsi tree, today's linux-next build (powerpc > allyesconfig) failed like this: > > In file inc

Re: linux-next: build failure after merge of the scsi tree

Thanks Stephen. Please consider this patch as Ack-by: Sreekanth Reddy <sreekanth.re...@avagotech.com> Thanks, Sreekanth On Fri, Nov 13, 2015 at 7:05 AM, Stephen Rothwell <s...@canb.auug.org.au> wrote: > Hi James, > > After merging the scsi tree, today's linux-next build (p

[PATCH] mpt3sas: Fix use sas_is_tlr_enabled API before enabling MPI2_SCSIIO_CONTROL_TLR_ON flag

. sas_is_tlr_enabled() - to check whether TLR is enabled or not. but in scsih_qcmd() we have missed to use sas_is_tlr_enabled() API, instead we checking for TLR bit from flag field of driver's 'struct MPT3SAS_DEVIC' structure. which is corrected with this patch. Signed-off-by: Sreekanth Reddy

[PATCH] mpt3sas: Fix use sas_is_tlr_enabled API before enabling MPI2_SCSIIO_CONTROL_TLR_ON flag

. sas_is_tlr_enabled() - to check whether TLR is enabled or not. but in scsih_qcmd() we have missed to use sas_is_tlr_enabled() API, instead we checking for TLR bit from flag field of driver's 'struct MPT3SAS_DEVIC' structure. which is corrected with this patch. Signed-off-by: Sreekanth Reddy

[PATCH RESEND 02/25] mpt3sas: Added mpt2sas driver definitions

From: Sreekanth Reddy 1. Added mpt2sas driver related macro's in mpt3sas header files 2. Made scsi host's, raid class's, pci's, ioctl's call back functions as a gobal API's, so that both the drivers can use these call back functions. Signed-off-by: Sreekanth Reddy --- drivers/scsi/mpt3sas

[PATCH RESEND 04/25] mpt2sas: Created mpt2sas_module.c file in which Gen2 HBA's are registers with PCI, SML and IOCTLs

From: Sreekanth Reddy 1. Create a mpt2sas_module.c file for mpt2sas driver module where GEN2 HBA devices registers with PCI, SML, IOCTL subsytems. 2. Updated the Makefile to use the object files from mpt3sas folder 3. Defined a compilation defination flag SCSI_MPT2SAS which can be used

[PATCH RESEND 16/25] mpt3sas: Added OEMs Gen2 PnP ID Branding names

From: Sreekanth Reddy Added OEMs Gen2 PnP ID Branding names from mpt2sas driver. Signed-off-by: Sreekanth Reddy --- drivers/scsi/mpt3sas/mpt3sas_base.c | 326 drivers/scsi/mpt3sas/mpt3sas_base.h | 93 +- 2 files changed, 305 insertions(+), 114

[PATCH RESEND 13/25] mpt3sas: Ported the providing sysfs attribute to report Backup Rail Monitor Status

From: Sreekanth Reddy A new sysfs shost attribute called "BMR_status" is implemented to report Backup Rail Monitor status. This attribute is located in the path /sys/class/scsi_host/host#/BMR_status when reading this adapter attribute, then driver will output the state

[PATCH RESEND 06/25] mpt3sas: Define 'hba_mpi_version_belonged' IOC variable

From: Sreekanth Reddy 1. Use 'hba_mpi_version_belonged' IOC varable to uniquely identify each individual generation driver functionality at runtime. 2. Declared global variable 'driver_name' and used this variable while reserving PCI regions and while allocating the IRQ's. Signed-off

[PATCH RESEND 08/25] mpt3sas: For an IO, build MPI SGL LIST on GEN2 HBA's and build IEEE SGL LIST on GEN3 HBA's

From: Sreekanth Reddy Gen2 HBA's uses MPI Scatter Gather Lists where as Gen3 HBA's uses IEEE Scatter Gather Lists. So modify the common code part in such a way that it will build IEEE SGL table for Gen3 HBA's and it will build MPI SGL table for Gen2 HBA's. Signed-off-by: Sreekanth Reddy

[PATCH RESEND 15/25] mpt3sas: Refcount fw_events and fix unsafe list usage

From: Sreekanth Reddy The fw_event_work struct is concurrently referenced at shutdown, so add a refcount to protect it, and refactor the code to use it. Additionally, refactor _scsih_fw_event_cleanup_queue() such that it no longer iterates over the list without holding the lock, since

[PATCH RESEND 07/25] mpt2sas, mpt3sas : Removed SCSI_MPTXSAS_LOGGING entry from Kconfig

From: Sreekanth Reddy Currently there is a logging level option provided for user for each of our drivers in the kernel configuration utility. They can enable this option to get more verbose information. By default this is enabled. When this option is enabled then those functions which displays

[PATCH RESEND 11/25] mpt3sas: fix for driver fails EEH, recovery from injected pci bus error

From: Sreekanth Reddy This patch stops the driver to invoke kthread (which remove the dead ioc) for some time while EEH recovery has started. This changes are ported from below mpt2sas driver patch 'commit b4730fb6e54a634a145c9c71c5cf856f00beb5cd ("mpt2sas: fix for driver fails EEH, rec

[PATCH RESEND 09/25] mpt3sas: Don't send PHYDISK_HIDDEN Raid Action request on SAS2 HBA's

From: Sreekanth Reddy Don't send PHYDISK_HIDDEN Raid Action request for SAS2 HBA's. Since these HBA's doesn't support this Raid Action. Also enable fast_path only for SAS3 HBA's. Signed-off-by: Sreekanth Reddy --- drivers/scsi/mpt3sas/mpt3sas_scsih.c | 19 +-- 1 file changed

[PATCH 25/25] mpt3sas: Bump mpt3sas driver version to 09.102.00.00

Bump mpt3sas driver version to 09.102.00.00 Signed-off-by: Sreekanth Reddy --- drivers/scsi/mpt3sas/mpt3sas_base.h | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/drivers/scsi/mpt3sas/mpt3sas_base.h b/drivers/scsi/mpt3sas/mpt3sas_base.h index 25c141c..a17bea9 100644

[PATCH RESEND 18/25] mpt2sas, mpt3sas: Update the driver versions

From: Sreekanth Reddy Bump the mpt2sas driver version to 20.102.00.00 and Bump the mpt3sas driver version to 9.101.00.00. Signed-off-by: Sreekanth Reddy --- drivers/scsi/mpt3sas/mpt3sas_base.h | 15 ++- 1 file changed, 10 insertions(+), 5 deletions(-) diff --git a/drivers/scsi

  1   2   3   4   5   6   >