Re: IPv6 router advertisement broken on 2.6.20-rc5
I think the following patch [IPV6] MCAST: Fix joining all-node multicast group on device initialization. http://www.spinics.net/lists/netdev/msg22663.html that went in after 2.6.20-rc5 should fix this problem. Thanks Sridhar On 1/16/07, bert hubert <[EMAIL PROTECTED]> wrote: On Tue, Jan 16, 2007 at 10:42:53PM +0100, Aurelien Jarno wrote: > I have just tried a 2.6.20-rc5 kernel (I previously used a 2.6.19 one), > and I have noticed that the IPv6 router advertisement functionality is Can you check if rc1, rc2, rc3 etc do work? Thanks. -- http://www.PowerDNS.com Open source, database driven DNS Software http://netherlabs.nl Open and Closed source services - To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to [EMAIL PROTECTED] More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/ - To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to [EMAIL PROTECTED] More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
Re: IPv6 router advertisement broken on 2.6.20-rc5
I think the following patch [IPV6] MCAST: Fix joining all-node multicast group on device initialization. http://www.spinics.net/lists/netdev/msg22663.html that went in after 2.6.20-rc5 should fix this problem. Thanks Sridhar On 1/16/07, bert hubert [EMAIL PROTECTED] wrote: On Tue, Jan 16, 2007 at 10:42:53PM +0100, Aurelien Jarno wrote: I have just tried a 2.6.20-rc5 kernel (I previously used a 2.6.19 one), and I have noticed that the IPv6 router advertisement functionality is Can you check if rc1, rc2, rc3 etc do work? Thanks. -- http://www.PowerDNS.com Open source, database driven DNS Software http://netherlabs.nl Open and Closed source services - To unsubscribe from this list: send the line unsubscribe linux-kernel in the body of a message to [EMAIL PROTECTED] More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/ - To unsubscribe from this list: send the line unsubscribe linux-kernel in the body of a message to [EMAIL PROTECTED] More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
Re: [2.6 patch] net/sctp/: make 2 functions static
Adrian Bunk wrote:
This patch makes the following needlessly global functions static:
- ipv6.c: sctp_inet6addr_event()
- protocol.c: sctp_inetaddr_event()
Signed-off-by: Adrian Bunk <[EMAIL PROTECTED]>
Acked-by: Sridhar Samudrala <[EMAIL PROTECTED]>
Thanks
Sridhar
---
include/net/sctp/sctp.h |2 --
net/sctp/ipv6.c |4 ++--
net/sctp/protocol.c |4 ++--
3 files changed, 4 insertions(+), 6 deletions(-)
--- linux-2.6.20-rc1-mm1/net/sctp/ipv6.c.old2006-12-16 01:05:15.0
+0100
+++ linux-2.6.20-rc1-mm1/net/sctp/ipv6.c2006-12-16 01:05:40.0
+0100
@@ -79,8 +79,8 @@
#include
/* Event handler for inet6 address addition/deletion events. */
-int sctp_inet6addr_event(struct notifier_block *this, unsigned long ev,
-void *ptr)
+static int sctp_inet6addr_event(struct notifier_block *this, unsigned long ev,
+ void *ptr)
{
struct inet6_ifaddr *ifa = (struct inet6_ifaddr *)ptr;
struct sctp_sockaddr_entry *addr;
--- linux-2.6.20-rc1-mm1/include/net/sctp/sctp.h.old2006-12-16
01:05:47.0 +0100
+++ linux-2.6.20-rc1-mm1/include/net/sctp/sctp.h2006-12-16
01:05:53.0 +0100
@@ -128,8 +128,6 @@
int flags);
extern struct sctp_pf *sctp_get_pf_specific(sa_family_t family);
extern int sctp_register_pf(struct sctp_pf *, sa_family_t);
-int sctp_inetaddr_event(struct notifier_block *this, unsigned long ev,
-void *ptr);
/*
* sctp/socket.c
--- linux-2.6.20-rc1-mm1/net/sctp/protocol.c.old2006-12-16
01:05:59.0 +0100
+++ linux-2.6.20-rc1-mm1/net/sctp/protocol.c2006-12-16 01:06:07.0
+0100
@@ -601,8 +601,8 @@
}
/* Event handler for inet address addition/deletion events. */
-int sctp_inetaddr_event(struct notifier_block *this, unsigned long ev,
-void *ptr)
+static int sctp_inetaddr_event(struct notifier_block *this, unsigned long ev,
+ void *ptr)
{
struct in_ifaddr *ifa = (struct in_ifaddr *)ptr;
struct sctp_sockaddr_entry *addr;
-
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to [EMAIL PROTECTED]
More majordomo info at http://vger.kernel.org/majordomo-info.html
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to [EMAIL PROTECTED]
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/
Re: [2.6 patch] net/sctp/: make 2 functions static
Adrian Bunk wrote:
This patch makes the following needlessly global functions static:
- ipv6.c: sctp_inet6addr_event()
- protocol.c: sctp_inetaddr_event()
Signed-off-by: Adrian Bunk [EMAIL PROTECTED]
Acked-by: Sridhar Samudrala [EMAIL PROTECTED]
Thanks
Sridhar
---
include/net/sctp/sctp.h |2 --
net/sctp/ipv6.c |4 ++--
net/sctp/protocol.c |4 ++--
3 files changed, 4 insertions(+), 6 deletions(-)
--- linux-2.6.20-rc1-mm1/net/sctp/ipv6.c.old2006-12-16 01:05:15.0
+0100
+++ linux-2.6.20-rc1-mm1/net/sctp/ipv6.c2006-12-16 01:05:40.0
+0100
@@ -79,8 +79,8 @@
#include asm/uaccess.h
/* Event handler for inet6 address addition/deletion events. */
-int sctp_inet6addr_event(struct notifier_block *this, unsigned long ev,
-void *ptr)
+static int sctp_inet6addr_event(struct notifier_block *this, unsigned long ev,
+ void *ptr)
{
struct inet6_ifaddr *ifa = (struct inet6_ifaddr *)ptr;
struct sctp_sockaddr_entry *addr;
--- linux-2.6.20-rc1-mm1/include/net/sctp/sctp.h.old2006-12-16
01:05:47.0 +0100
+++ linux-2.6.20-rc1-mm1/include/net/sctp/sctp.h2006-12-16
01:05:53.0 +0100
@@ -128,8 +128,6 @@
int flags);
extern struct sctp_pf *sctp_get_pf_specific(sa_family_t family);
extern int sctp_register_pf(struct sctp_pf *, sa_family_t);
-int sctp_inetaddr_event(struct notifier_block *this, unsigned long ev,
-void *ptr);
/*
* sctp/socket.c
--- linux-2.6.20-rc1-mm1/net/sctp/protocol.c.old2006-12-16
01:05:59.0 +0100
+++ linux-2.6.20-rc1-mm1/net/sctp/protocol.c2006-12-16 01:06:07.0
+0100
@@ -601,8 +601,8 @@
}
/* Event handler for inet address addition/deletion events. */
-int sctp_inetaddr_event(struct notifier_block *this, unsigned long ev,
-void *ptr)
+static int sctp_inetaddr_event(struct notifier_block *this, unsigned long ev,
+ void *ptr)
{
struct in_ifaddr *ifa = (struct in_ifaddr *)ptr;
struct sctp_sockaddr_entry *addr;
-
To unsubscribe from this list: send the line unsubscribe netdev in
the body of a message to [EMAIL PROTECTED]
More majordomo info at http://vger.kernel.org/majordomo-info.html
-
To unsubscribe from this list: send the line unsubscribe linux-kernel in
the body of a message to [EMAIL PROTECTED]
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/
Re: [PATCH] crypto_free_tfm callers do not need to check for NULL
On Tue, 2005-08-30 at 22:45 +0200, Jesper Juhl wrote: > Since the patch to add a NULL short-circuit to crypto_free_tfm() went in, > there's no longer any need for callers of that function to check for NULL. > This patch removes the redundant NULL checks and also a few similar checks > for NULL before calls to kfree() that I ran into while doing the > crypto_free_tfm bits. > > I've posted similar patches in the past, but was asked to first until the > short-circuit patch moved from -mm to mainline - and since it is now > firmly there in 2.6.13 I assume there's no problem there anymore. > I was also asked previously to make the patch against mainline and not -mm, > so this patch is against 2.6.13. > > Feedback, ACK, NACK, etc welcome. sctp change looks fine. A similar check in sctp_endpoint_destroy() can also be removed. Thanks Sridhar - To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to [EMAIL PROTECTED] More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
Re: [PATCH] crypto_free_tfm callers do not need to check for NULL
On Tue, 2005-08-30 at 22:45 +0200, Jesper Juhl wrote: Since the patch to add a NULL short-circuit to crypto_free_tfm() went in, there's no longer any need for callers of that function to check for NULL. This patch removes the redundant NULL checks and also a few similar checks for NULL before calls to kfree() that I ran into while doing the crypto_free_tfm bits. I've posted similar patches in the past, but was asked to first until the short-circuit patch moved from -mm to mainline - and since it is now firmly there in 2.6.13 I assume there's no problem there anymore. I was also asked previously to make the patch against mainline and not -mm, so this patch is against 2.6.13. Feedback, ACK, NACK, etc welcome. sctp change looks fine. A similar check in sctp_endpoint_destroy() can also be removed. Thanks Sridhar - To unsubscribe from this list: send the line unsubscribe linux-kernel in the body of a message to [EMAIL PROTECTED] More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
Re: [PATCH] network configs: disconnect network options from drivers
On Mon, 4 Apr 2005, Sam Ravnborg wrote: Only bit that I am worried about is the statement in SCTP: depends on IPV6 || IPV6=n That looked like a noop to me. It had the sideeffect that SCTP menu entries where idented an extra level which was not desireable with currect layout. No. This is not a noop. This is required to restrict SCTP configured as static when IPV6 is configured as module. Thanks Sridhar - To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to [EMAIL PROTECTED] More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
Re: [PATCH] network configs: disconnect network options from drivers
On Mon, 4 Apr 2005, Sam Ravnborg wrote: Only bit that I am worried about is the statement in SCTP: depends on IPV6 || IPV6=n That looked like a noop to me. It had the sideeffect that SCTP menu entries where idented an extra level which was not desireable with currect layout. No. This is not a noop. This is required to restrict SCTP configured as static when IPV6 is configured as module. Thanks Sridhar - To unsubscribe from this list: send the line unsubscribe linux-kernel in the body of a message to [EMAIL PROTECTED] More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
