Please remove the settings->size check. The driver sometimes just
writes a modified version of the read settings data. This would fail if
stored size is invalid. This value of size is not solely in my hands, I
can't guarantee Windows driver does a sanity check, also cases of flash
data corruption
Am Dienstag, den 19.02.2019, 14:16 +0100 schrieb Jiri Kosina:
> On Mon, 11 Feb 2019, Gustavo A. R. Silva wrote:
>
> > In preparation to enabling -Wimplicit-fallthrough, mark switch
> > cases where we are expecting to fall through.
> >
> > This patch fixes the following warning:
> >
> >
.
The userspace tools don't use these attributes for a year now.
The first Kone is not fully HID-compliant and will still need a module.
Fix: Resubmitting this patch, now done with 'git format-patch -M' like Greg KH
suggested.
Signed-off-by: Stefan Achatz
---
.../sysfs-driver-hid-roccat-arvo
.
The userspace tools don't use these attributes for a year now.
The first Kone is not fully HID-compliant and will still need a module.
Fix: Resubmitting this patch, now done with 'git format-patch -M' like Greg KH
suggested.
Signed-off-by: Stefan Achatz <erazor...@users.sourceforge.net>
---
...
.
The userspace tools don't use these attributes for a year now.
The first Kone is not fully HID-compliant and will still need a module.
Signed-off-by: Stefan Achatz
---
.../ABI/obsolete/sysfs-driver-hid-roccat-arvo | 53 ++
.../ABI/obsolete/sysfs-driver-hid-roccat-isku | 153
.
The userspace tools don't use these attributes for a year now.
The first Kone is not fully HID-compliant and will still need a module.
Signed-off-by: Stefan Achatz <erazor...@users.sourceforge.net>
---
.../ABI/obsolete/sysfs-driver-hid-roccat-arvo | 53 ++
.../ABI/obsolete/sysfs-driver-hid-
Forgot two special driver declarations and sorted the list.
Signed-off-by: Stefan Achatz
---
drivers/hid/hid-core.c |4 +++-
1 files changed, 3 insertions(+), 1 deletions(-)
diff --git a/drivers/hid/hid-core.c b/drivers/hid/hid-core.c
index 0079422..ec6ba50 100644
--- a/drivers/hid/hid
Forgot two special driver declarations and sorted the list.
Signed-off-by: Stefan Achatz erazor...@users.sourceforge.net
---
drivers/hid/hid-core.c |4 +++-
1 files changed, 3 insertions(+), 1 deletions(-)
diff --git a/drivers/hid/hid-core.c b/drivers/hid/hid-core.c
index 0079422..ec6ba50
Signed-off-by: Stefan Achatz
---
drivers/hid/hid-roccat-kovaplus.c |4
1 files changed, 4 insertions(+), 0 deletions(-)
diff --git a/drivers/hid/hid-roccat-kovaplus.c
b/drivers/hid/hid-roccat-kovaplus.c
index 0c8e1ef..9660477 100644
--- a/drivers/hid/hid-roccat-kovaplus.c
+++ b
Signed-off-by: Stefan Achatz erazor...@users.sourceforge.net
---
drivers/hid/hid-roccat-kovaplus.c |4
1 files changed, 4 insertions(+), 0 deletions(-)
diff --git a/drivers/hid/hid-roccat-kovaplus.c
b/drivers/hid/hid-roccat-kovaplus.c
index 0c8e1ef..9660477 100644
--- a/drivers/hid
Reduced some duplicate code by moving it to hid-roccat-common.
Signed-off-by: Stefan Achatz
---
drivers/hid/hid-roccat-common.c | 53
drivers/hid/hid-roccat-common.h | 62 ++
drivers/hid/hid-roccat-konepure.c | 158 +
drivers
Ryos uses a new return value for critical errors, others have been
confirmed.
Signed-off-by: Stefan Achatz
---
drivers/hid/hid-roccat-common.c | 12 ++--
1 files changed, 6 insertions(+), 6 deletions(-)
diff --git a/drivers/hid/hid-roccat-common.c b/drivers/hid/hid-roccat-common.c
Added support for 3 keyboards with increasing illumination capabilities
Signed-off-by: Stefan Achatz
---
.../ABI/testing/sysfs-driver-hid-roccat-ryos | 178 +++
drivers/hid/Makefile |2 +-
drivers/hid/hid-core.c
Ryos uses a new return value for critical errors, others have been
confirmed.
Signed-off-by: Stefan Achatz erazor...@users.sourceforge.net
---
drivers/hid/hid-roccat-common.c | 12 ++--
1 files changed, 6 insertions(+), 6 deletions(-)
diff --git a/drivers/hid/hid-roccat-common.c b
Added support for 3 keyboards with increasing illumination capabilities
Signed-off-by: Stefan Achatz erazor...@users.sourceforge.net
---
.../ABI/testing/sysfs-driver-hid-roccat-ryos | 178 +++
drivers/hid/Makefile |2 +-
drivers/hid/hid-core.c
Reduced some duplicate code by moving it to hid-roccat-common.
Signed-off-by: Stefan Achatz erazor...@users.sourceforge.net
---
drivers/hid/hid-roccat-common.c | 53
drivers/hid/hid-roccat-common.h | 62 ++
drivers/hid/hid-roccat-konepure.c | 158
Fixing some wrong macro stringification/concatenation.
Cc: Greg Kroah-Hartman
Signed-off-by: Stefan Achatz
---
drivers/hid/hid-roccat-kone.c |2 +-
drivers/hid/hid-roccat-koneplus.c |4 ++--
drivers/hid/hid-roccat-kovaplus.c |4 ++--
drivers/hid/hid-roccat-pyra.c |4
Fixing some wrong macro stringification/concatenation.
Cc: Greg Kroah-Hartman gre...@linuxfoundation.org
Signed-off-by: Stefan Achatz erazor...@users.sourceforge.net
---
drivers/hid/hid-roccat-kone.c |2 +-
drivers/hid/hid-roccat-koneplus.c |4 ++--
drivers/hid/hid-roccat-kovaplus.c
Adding maintainer for Roccat hid drivers
I sent this patch some weeks ago, seemingly unnoticed.
Maybe I have more luck via Jiri's hid repo.
Signed-off-by: Stefan Achatz
---
MAINTAINERS |8
1 files changed, 8 insertions(+), 0 deletions(-)
diff --git a/MAINTAINERS b/MAINTAINERS
Adding maintainer for Roccat hid drivers
I sent this patch some weeks ago, seemingly unnoticed.
Maybe I have more luck via Jiri's hid repo.
Signed-off-by: Stefan Achatz erazor...@users.sourceforge.net
---
MAINTAINERS |8
1 files changed, 8 insertions(+), 0 deletions(-)
diff --git
KonePureOptical is a KonePure with different sensor.
Signed-off-by: Stefan Achatz
---
drivers/hid/hid-core.c|1 +
drivers/hid/hid-ids.h |1 +
drivers/hid/hid-roccat-konepure.c |3 ++-
3 files changed, 4 insertions(+), 1 deletions(-)
diff --git a/drivers/hid
KonePureOptical is a KonePure with different sensor.
Signed-off-by: Stefan Achatz erazor...@users.sourceforge.net
---
drivers/hid/hid-core.c|1 +
drivers/hid/hid-ids.h |1 +
drivers/hid/hid-roccat-konepure.c |3 ++-
3 files changed, 4 insertions(+), 1
KonePureOptical is a KonePure with different sensor.
Signed-off-by: Stefan Achatz
---
drivers/hid/hid-ids.h |1 +
drivers/hid/hid-roccat-konepure.c |3 ++-
2 files changed, 3 insertions(+), 1 deletions(-)
diff --git a/drivers/hid/hid-ids.h b/drivers/hid/hid-ids.h
index
KonePureOptical is a KonePure with different sensor.
Signed-off-by: Stefan Achatz erazor...@users.sourceforge.net
---
drivers/hid/hid-ids.h |1 +
drivers/hid/hid-roccat-konepure.c |3 ++-
2 files changed, 3 insertions(+), 1 deletions(-)
diff --git a/drivers/hid/hid-ids.h b
Adding maintainer for Roccat hid drivers
Signed-off-by: Stefan Achatz
---
MAINTAINERS |8
1 files changed, 8 insertions(+), 0 deletions(-)
diff --git a/MAINTAINERS b/MAINTAINERS
index 9705318..55d946b 100644
--- a/MAINTAINERS
+++ b/MAINTAINERS
@@ -6921,6 +6921,14 @@ M: Maxim
Adding maintainer for Roccat hid drivers
Signed-off-by: Stefan Achatz erazor...@users.sourceforge.net
---
MAINTAINERS |8
1 files changed, 8 insertions(+), 0 deletions(-)
diff --git a/MAINTAINERS b/MAINTAINERS
index 9705318..55d946b 100644
--- a/MAINTAINERS
+++ b/MAINTAINERS
Hello Greg,
looking through the patch I found the following:
In hid-roccat-kone.c, PROFILE_ATTR macro:
The line
.private = _numbers[number],
should read
.private = _numbers[number-1],
Regarding the compiler warning about unused pyra_sysfs_write_settings:
The attribute is indeed readwrite,
Hello Greg,
looking through the patch I found the following:
In hid-roccat-kone.c, PROFILE_ATTR macro:
The line
.private = profile_numbers[number],
should read
.private = profile_numbers[number-1],
Regarding the compiler warning about unused pyra_sysfs_write_settings:
The attribute is
Kone now reports media key events through it's chardev to userspace.
Signed-off-by: Stefan Achatz
---
drivers/hid/hid-roccat-kone.c |3 ++-
drivers/hid/hid-roccat-kone.h |1 +
2 files changed, 3 insertions(+), 1 deletions(-)
diff --git a/drivers/hid/hid-roccat-kone.c b/drivers/hid/hid
Kone now reports media key events through it's chardev to userspace.
Signed-off-by: Stefan Achatz erazor...@users.sourceforge.net
---
drivers/hid/hid-roccat-kone.c |3 ++-
drivers/hid/hid-roccat-kone.h |1 +
2 files changed, 3 insertions(+), 1 deletions(-)
diff --git a/drivers/hid/hid
Extending isku module with one additional and one changed sysfs attr. IskuFX has
larger light sysfs attr. Made the code size tolerant so both devices can be
handled.
Signed-off-by: Stefan Achatz
---
.../ABI/testing/sysfs-driver-hid-roccat-isku | 12 +++-
drivers/hid/hid-ids.h
Userland-tools now keep track of actual profile themselves.
Spared out Pyra, which is a harder case.
Signed-off-by: Stefan Achatz
---
drivers/hid/hid-roccat-arvo.c | 25 +++---
drivers/hid/hid-roccat-arvo.h |4 +--
drivers/hid/hid-roccat-isku.c | 48
Userland-tools don't need to be notified about changes they issued themselves
anymore.
Signed-off-by: Stefan Achatz
---
drivers/hid/hid-roccat-isku.c |6 --
drivers/hid/hid-roccat-kone.c | 16 +---
drivers/hid/hid-roccat-koneplus.c |7 ---
drivers/hid/hid
Fixed parameter documentations
Signed-off-by: Stefan Achatz
---
drivers/hid/hid-roccat.c |2 +-
1 files changed, 1 insertions(+), 1 deletions(-)
diff --git a/drivers/hid/hid-roccat.c b/drivers/hid/hid-roccat.c
index d7437ef..b59b3df 100644
--- a/drivers/hid/hid-roccat.c
+++ b/drivers/hid
Userland-tools can already be found at http://sourceforge.net/projects/roccat
Signed-off-by: Stefan Achatz
---
.../ABI/testing/sysfs-driver-hid-roccat-konepure | 105 +++
drivers/hid/Makefile |4 +-
drivers/hid/hid-core.c
This patchset adds support for two new devices.
While more functionality gets moved to userland the code for older modules
gets again stripped down further to minimum functionality.
The userland-tools supporting these changes are up for download nearly a
month now.
--
To unsubscribe from this
This patchset adds support for two new devices.
While more functionality gets moved to userland the code for older modules
gets again stripped down further to minimum functionality.
The userland-tools supporting these changes are up for download nearly a
month now.
--
To unsubscribe from this
Userland-tools can already be found at http://sourceforge.net/projects/roccat
Signed-off-by: Stefan Achatz erazor...@users.sourceforge.net
---
.../ABI/testing/sysfs-driver-hid-roccat-konepure | 105 +++
drivers/hid/Makefile |4 +-
drivers/hid/hid-core.c
Fixed parameter documentations
Signed-off-by: Stefan Achatz erazor...@users.sourceforge.net
---
drivers/hid/hid-roccat.c |2 +-
1 files changed, 1 insertions(+), 1 deletions(-)
diff --git a/drivers/hid/hid-roccat.c b/drivers/hid/hid-roccat.c
index d7437ef..b59b3df 100644
--- a/drivers/hid
Userland-tools don't need to be notified about changes they issued themselves
anymore.
Signed-off-by: Stefan Achatz erazor...@users.sourceforge.net
---
drivers/hid/hid-roccat-isku.c |6 --
drivers/hid/hid-roccat-kone.c | 16 +---
drivers/hid/hid-roccat-koneplus.c
Userland-tools now keep track of actual profile themselves.
Spared out Pyra, which is a harder case.
Signed-off-by: Stefan Achatz erazor...@users.sourceforge.net
---
drivers/hid/hid-roccat-arvo.c | 25 +++---
drivers/hid/hid-roccat-arvo.h |4 +--
drivers/hid/hid-roccat
Extending isku module with one additional and one changed sysfs attr. IskuFX has
larger light sysfs attr. Made the code size tolerant so both devices can be
handled.
Signed-off-by: Stefan Achatz erazor...@users.sourceforge.net
---
.../ABI/testing/sysfs-driver-hid-roccat-isku | 12
More thorough testing revealed a typo in last koneplus cleanups.
Signed-off-by: Stefan Achatz
---
drivers/hid/hid-roccat-koneplus.h |2 +-
1 files changed, 1 insertions(+), 1 deletions(-)
diff --git a/drivers/hid/hid-roccat-koneplus.h
b/drivers/hid/hid-roccat-koneplus.h
index d2b55f2
More thorough testing revealed a typo in last koneplus cleanups.
Signed-off-by: Stefan Achatz erazor...@users.sourceforge.net
---
drivers/hid/hid-roccat-koneplus.h |2 +-
1 files changed, 1 insertions(+), 1 deletions(-)
diff --git a/drivers/hid/hid-roccat-koneplus.h
b/drivers/hid/hid
Partially removed unneeded informations and data caching.
Moved code nearer to format of newer drivers.
Added "info" sysfs attribute to support device reset and deprecate other
attributes.
Signed-off-by: Stefan Achatz
---
.../ABI/obsolete/sysfs-driver-hid-roccat-kovaplus | 41 +++
Introduced attribute "control" and made profile_settings and profile_buttons
readable, which makes profile[1-5]_settings and profile[1-5]_buttons obsolete.
Signed-off-by: Stefan Achatz
---
.../ABI/obsolete/sysfs-driver-hid-roccat-kovaplus | 25 +
.../ABI/testing/sy
Introduced attribute "control" and made profile_settings and profile_buttons
readable, which makes profile[1-5]_settings and profile[1-5]_buttons obsolete.
Signed-off-by: Stefan Achatz
---
.../ABI/obsolete/sysfs-driver-hid-roccat-pyra | 27 ++-
.../ABI/testing/sy
Isku needs an extra sysfs attr to support device reset.
Signed-off-by: Stefan Achatz
---
.../ABI/testing/sysfs-driver-hid-roccat-isku |8
drivers/hid/hid-roccat-isku.c |2 ++
drivers/hid/hid-roccat-isku.h |2 ++
3 files
Introduced attribute "control" and made profile_settings and profile_buttons
readable, which makes profile[1-5]_settings and profile[1-5]_buttons obsolete.
Signed-off-by: Stefan Achatz
---
.../ABI/obsolete/sysfs-driver-hid-roccat-koneplus | 27 ++
.../ABI/testing/sy
Partially removed unneeded informations and data caching.
Moved code nearer to format of newer drivers.
Added "info" sysfs attribute to support device reset and deprecate
"firmware_version" attribute.
Signed-off-by: Stefan Achatz
---
.../ABI/obsolete/sysfs-driver-hid-roc
Removed unneeded structures from header.
Using enums instead of sizeof(struct) to unify drivers.
Signed-off-by: Stefan Achatz
---
drivers/hid/hid-roccat-isku.c | 42 +++---
drivers/hid/hid-roccat-isku.h | 76 +
2 files changed, 37
This patchset finishes current cleanups and unifications.
Device reset is now implemented for all devices that support that
feature.
A couple sysfs attributes have been deprecated and got replaced to unify
the ABI as good as it gets with design decisions made in the past.
The next release of
This patchset finishes current cleanups and unifications.
Device reset is now implemented for all devices that support that
feature.
A couple sysfs attributes have been deprecated and got replaced to unify
the ABI as good as it gets with design decisions made in the past.
The next release of
Removed unneeded structures from header.
Using enums instead of sizeof(struct) to unify drivers.
Signed-off-by: Stefan Achatz erazor...@users.sourceforge.net
---
drivers/hid/hid-roccat-isku.c | 42 +++---
drivers/hid/hid-roccat-isku.h | 76
Partially removed unneeded informations and data caching.
Moved code nearer to format of newer drivers.
Added info sysfs attribute to support device reset and deprecate
firmware_version attribute.
Signed-off-by: Stefan Achatz erazor...@users.sourceforge.net
---
.../ABI/obsolete/sysfs-driver-hid
Introduced attribute control and made profile_settings and profile_buttons
readable, which makes profile[1-5]_settings and profile[1-5]_buttons obsolete.
Signed-off-by: Stefan Achatz erazor...@users.sourceforge.net
---
.../ABI/obsolete/sysfs-driver-hid-roccat-koneplus | 27
Isku needs an extra sysfs attr to support device reset.
Signed-off-by: Stefan Achatz erazor...@users.sourceforge.net
---
.../ABI/testing/sysfs-driver-hid-roccat-isku |8
drivers/hid/hid-roccat-isku.c |2 ++
drivers/hid/hid-roccat-isku.h
Introduced attribute control and made profile_settings and profile_buttons
readable, which makes profile[1-5]_settings and profile[1-5]_buttons obsolete.
Signed-off-by: Stefan Achatz erazor...@users.sourceforge.net
---
.../ABI/obsolete/sysfs-driver-hid-roccat-kovaplus | 25
Introduced attribute control and made profile_settings and profile_buttons
readable, which makes profile[1-5]_settings and profile[1-5]_buttons obsolete.
Signed-off-by: Stefan Achatz erazor...@users.sourceforge.net
---
.../ABI/obsolete/sysfs-driver-hid-roccat-pyra | 27
Partially removed unneeded informations and data caching.
Moved code nearer to format of newer drivers.
Added info sysfs attribute to support device reset and deprecate other
attributes.
Signed-off-by: Stefan Achatz erazor...@users.sourceforge.net
---
.../ABI/obsolete/sysfs-driver-hid-roccat
Removed caching of profile data which lowers memory footprint,
speeds up init and fixes problems with device reset.
Removed unnecessary infos in header.
Code moved nearer to format of newer drivers.
Signed-off-by: Stefan Achatz
---
drivers/hid/hid-roccat-koneplus.c | 371
Device can be reset to factory state by sending a command via info sysfs attr.
Added binary attribute info for this purpose, which obsoletes firmware_version
attribute.
Signed-off-by: Stefan Achatz
---
.../ABI/obsolete/sysfs-driver-hid-roccat-koneplus | 11 ++
.../ABI/testing/sysfs
Device can be reset to factory state by sending a command via info sysfs attr.
Changed from ro to rw to enable this feature.
Signed-off-by: Stefan Achatz
---
.../ABI/testing/sysfs-driver-hid-roccat-savu |3 +--
drivers/hid/hid-roccat-savu.c |4 ++--
2 files
KoneXTD is just a Kone[+] with updated sensor, so it's handled by
koneplus driver.
Signed-off-by: Stefan Achatz
---
drivers/hid/hid-ids.h |1 +
drivers/hid/hid-roccat-koneplus.c |4 +++-
2 files changed, 4 insertions(+), 1 deletions(-)
diff --git a/drivers/hid/hid-ids.h b
koneplus driver now supports updated model KoneXTD.
Added support for device reset for koneplus and savu drivers.
Removed a lot of unnecessary code for koneplus driver, bringing it
nearer to the looks of my newer roccat drivers.
--
To unsubscribe from this list: send the line "unsubscribe
koneplus driver now supports updated model KoneXTD.
Added support for device reset for koneplus and savu drivers.
Removed a lot of unnecessary code for koneplus driver, bringing it
nearer to the looks of my newer roccat drivers.
--
To unsubscribe from this list: send the line unsubscribe
KoneXTD is just a Kone[+] with updated sensor, so it's handled by
koneplus driver.
Signed-off-by: Stefan Achatz erazor...@users.sourceforge.net
---
drivers/hid/hid-ids.h |1 +
drivers/hid/hid-roccat-koneplus.c |4 +++-
2 files changed, 4 insertions(+), 1 deletions(-)
diff
Device can be reset to factory state by sending a command via info sysfs attr.
Changed from ro to rw to enable this feature.
Signed-off-by: Stefan Achatz erazor...@users.sourceforge.net
---
.../ABI/testing/sysfs-driver-hid-roccat-savu |3 +--
drivers/hid/hid-roccat-savu.c
Device can be reset to factory state by sending a command via info sysfs attr.
Added binary attribute info for this purpose, which obsoletes firmware_version
attribute.
Signed-off-by: Stefan Achatz erazor...@users.sourceforge.net
---
.../ABI/obsolete/sysfs-driver-hid-roccat-koneplus | 11
Removed caching of profile data which lowers memory footprint,
speeds up init and fixes problems with device reset.
Removed unnecessary infos in header.
Code moved nearer to format of newer drivers.
Signed-off-by: Stefan Achatz erazor...@users.sourceforge.net
---
drivers/hid/hid-roccat
tcu sysfs attr was used to only control calibration process so far. Reverse
engineering the firmware revealed direct sensor register access. Allowing
readout of tcu permits usage of this feature.
Signed-off-by: Stefan Achatz
---
.../ABI/testing/sysfs-driver-hid-roccat-koneplus |6
tcu sysfs attr was used to only control calibration process so far. Reverse
engineering the firmware revealed direct sensor register access. Allowing
readout of tcu permits usage of this feature.
Signed-off-by: Stefan Achatz erazor...@users.sourceforge.net
---
.../ABI/testing/sysfs-driver-hid
This patch adds support for Roccat Lua gaming mouse.
Userland tools can soon be found at http://sourceforge.net/projects/roccat
Signed-off-by: Stefan Achatz
---
.../ABI/testing/sysfs-driver-hid-roccat-lua|7 +
drivers/hid/Makefile |4 +-
drivers
This patch adds support for Roccat Lua gaming mouse.
Userland tools can soon be found at http://sourceforge.net/projects/roccat
Signed-off-by: Stefan Achatz erazor...@users.sourceforge.net
---
.../ABI/testing/sysfs-driver-hid-roccat-lua|7 +
drivers/hid/Makefile
Roccat devices are standard compatible, specific drivers are only needed
for extended functionality.
If Roccat drivers are not configured, hid-generic binds these devices now.
Signed-off-by: Stefan Achatz
---
drivers/hid/hid-core.c |2 ++
1 files changed, 2 insertions(+), 0 deletions
from generic-usb to hid-generic
anyway, so I would add a rule to also handle the kernel contained modules.
Signed-off-by: Stefan Achatz
---
drivers/hid/hid-core.c |8
1 files changed, 0 insertions(+), 8 deletions(-)
diff --git a/drivers/hid/hid-core.c b/drivers/hid/hid-core.c
index
Roccat devices are standard compatible, specific drivers are only needed
for extended functionality.
If Roccat drivers are not configured, hid-generic binds these devices now.
Signed-off-by: Stefan Achatz erazor...@users.sourceforge.net
---
drivers/hid/hid-core.c |2 ++
1 files changed, 2
from generic-usb to hid-generic
anyway, so I would add a rule to also handle the kernel contained modules.
Signed-off-by: Stefan Achatz erazor...@users.sourceforge.net
---
drivers/hid/hid-core.c |8
1 files changed, 0 insertions(+), 8 deletions(-)
diff --git a/drivers/hid/hid-core.c b
78 matches
Mail list logo
