[GIT PULL] clk fixes for v4.20-rc6

2018-12-07 Thread Stephen Boyd
: zynqmp: Off by one in zynqmp_is_valid_clock() Rajan Vaja (1): clk: zynqmp: handle fixed factor param query error Stephen Boyd (3): dt-bindings: clk: Introduce 'protected-clocks' property clk: qcom: Support 'protected-clocks' property Merge branch 'clk-protected-binding

Re: [PATCH] Revert "clk: fix __clk_init_parent() for single parent clocks"

2018-12-06 Thread Stephen Boyd
800, Stephen Boyd wrote: > > > > Ok. Thanks for the explanation. What do you do to fix this problem in > > the 'ao_cts_cec' clk implementation? > > IMO, there is nothing to fix, the implementation is correct. > > > Sounds like you just rely on > > clk_

[PATCH 2/8] clk: st: Remove usage of CLK_IS_BASIC

2018-12-06 Thread Stephen Boyd
This flag doesn't look to be used by any code, just set in various clk init structures and then never tested again. Remove it from these drivers as it doesn't provide any benefit. Signed-off-by: Stephen Boyd --- drivers/clk/st/clk-flexgen.c | 2 +- drivers/clk/st/clkgen-fsyn.c | 4 ++-- drivers

[PATCH 4/8] clk: h8300: Remove usage of CLK_IS_BASIC

2018-12-06 Thread Stephen Boyd
This flag doesn't look to be used by any code, just set in various clk init structures and then never tested again. Remove it from these drivers as it doesn't provide any benefit. Cc: Yoshinori Sato Cc: Signed-off-by: Stephen Boyd --- drivers/clk/h8300/clk-h8s2678.c | 2 +- 1 file changed, 1

[PATCH 3/8] clk: axm5516: Remove usage of CLK_IS_BASIC

2018-12-06 Thread Stephen Boyd
This flag doesn't look to be used by any code, just set in various clk init structures and then never tested again. Remove it from these drivers as it doesn't provide any benefit. Cc: Anders Berg Signed-off-by: Stephen Boyd --- drivers/clk/clk-axm5516.c | 2 -- 1 file changed, 2 deletions

[PATCH 1/8] clk: renesas: Remove usage of CLK_IS_BASIC

2018-12-06 Thread Stephen Boyd
This flag doesn't look to be used by any code, just set in various clk init structures and then never tested again. Remove it from these drivers as it doesn't provide any benefit. Cc: Geert Uytterhoeven Cc: Signed-off-by: Stephen Boyd --- drivers/clk/renesas/clk-div6.c | 2 +- drivers

[PATCH 5/8] clk: hisilicon: Remove usage of CLK_IS_BASIC

2018-12-06 Thread Stephen Boyd
This flag doesn't look to be used by any code, just set in various clk init structures and then never tested again. Remove it from these drivers as it doesn't provide any benefit. Cc: Jiancheng Xue Cc: Leo Yan Cc: Jianguo Sun Cc: Wei Yongjun Signed-off-by: Stephen Boyd --- drivers/clk

[PATCH 7/8] clk: samsung: s3c2410: Remove usage of CLK_IS_BASIC

2018-12-06 Thread Stephen Boyd
This flag doesn't look to be used by any code, just set in the clk init structure and then never tested again. Remove it from this drivers as it doesn't provide any benefit. Cc: Kukjin Kim Cc: Krzysztof Kozlowski Cc: Sylwester Nawrocki Signed-off-by: Stephen Boyd --- drivers/clk/samsung/clk

[PATCH 8/8] clk: Loongson1: Remove usage of CLK_IS_BASIC

2018-12-06 Thread Stephen Boyd
. Signed-off-by: Stephen Boyd --- drivers/clk/loongson1/clk.c | 8 +--- 1 file changed, 5 insertions(+), 3 deletions(-) diff --git a/drivers/clk/loongson1/clk.c b/drivers/clk/loongson1/clk.c index cfcfd143fccb..983ce9f6edbb 100644 --- a/drivers/clk/loongson1/clk.c +++ b/drivers/clk/loongson1

[PATCH 6/8] clk: versatile: sp810: Remove usage of CLK_IS_BASIC

2018-12-06 Thread Stephen Boyd
This flag doesn't look to be used by any code, just set in the clk init structure and then never tested again. Remove it from this driver as it doesn't provide any benefit. Cc: Linus Walleij Signed-off-by: Stephen Boyd --- drivers/clk/versatile/clk-sp810.c | 2 +- 1 file changed, 1 insertion

Re: [PATCH] clk: qcom: smd: Add support for MSM8998 rpm clocks

2018-12-06 Thread Stephen Boyd
Quoting Jeffrey Hugo (2018-12-06 13:11:06) > Add rpm smd clocks, PMIC and bus clocks which are required on MSM8998 > for clients to vote on. > > Signed-off-by: Jeffrey Hugo > --- > .../devicetree/bindings/clock/qcom,rpmcc.txt | 1 + > drivers/clk/qcom/clk-smd-rpm.c |

Re: [PATCH v2] clk: npcm7xx: get fixed clocks from DT

2018-12-06 Thread Stephen Boyd
Quoting Tali Perry (2018-12-06 00:44:31) > diff --git a/drivers/clk/clk-npcm7xx.c b/drivers/clk/clk-npcm7xx.c > index 27a86b7a34db..4bd2e40997d4 100644 > --- a/drivers/clk/clk-npcm7xx.c > +++ b/drivers/clk/clk-npcm7xx.c > @@ -8,13 +8,19 @@ > */ > > #include > +#include > #include >

Re: [RFC PATCH] clk: qcom: clk-rpmh: Add IPA clock support

2018-12-06 Thread Stephen Boyd
Quoting David Dai (2018-12-05 17:24:18) > > > On 12/4/2018 11:15 PM, Stephen Boyd wrote: > > Quoting David Dai (2018-12-04 17:14:10) > >> On 12/4/2018 2:34 PM, Stephen Boyd wrote: > >>> Quoting Alex Elder (2018-12-04 13:41:47) > >>>> > >

Re: [PATCH v2 3/3] clk: qcom: gcc-msm8998: Add clkref clocks

2018-12-05 Thread Stephen Boyd
Quoting Bjorn Andersson (2018-12-03 10:33:30) > Add clkref clocks for usb3, hdmi, ufs, pcie, and usb2. They are all > sourced off CXO_IN, so parent them off "xo" until a proper link to the > rpmcc can be described in DT. > > Signed-off-by: Bjorn Andersson > --- Applied to clk-next

Re: [PATCH v2 2/3] clk: qcom: gcc-msm8998: Disable halt check of UFS clocks

2018-12-05 Thread Stephen Boyd
Quoting Bjorn Andersson (2018-12-03 10:33:29) > Drop the halt check of the UFS symbol clocks, in accordance with other > platforms. This makes clk_disable_unused() happy and makes it possible > to turn the clocks on again without an error. > > Signed-off-by: Bjorn Andersson > --- Applied to

Re: [PATCH v2 1/3] clk: qcom: gcc-msm8998: Drop hmss_dvm and lpass_at

2018-12-05 Thread Stephen Boyd
Quoting Bjorn Andersson (2018-12-03 10:33:28) > Disabling gcc_hmss_dvm_bus_clk and gcc_lpass_at_clk causes the board to > lock up, and by that preventing the kernel to boot without > clk_ignore_unused. > > gcc_hmss_dvm_bus_clk is marked always-on downstream, but not referenced, > and

Re: [PATCH] clk: qcom: Enumerate remaining msm8998 resets

2018-12-05 Thread Stephen Boyd
Quoting Jeffrey Hugo (2018-12-04 07:13:22) > The current list of defined resets is incomplete compared to what the > hardware implements. Enumerate the remaining resets according to the > hardware documentation. > > Signed-off-by: Jeffrey Hugo > --- Applied to clk-next

Re: [PATCH v5 4/8] soc: qcom: rpmpd: Add support for get/set performance state

2018-12-05 Thread Stephen Boyd
Quoting Rajendra Nayak (2018-12-05 02:11:22) > > On 12/5/2018 12:33 PM, Rajendra Nayak wrote: > >> > >>> +   return 0; > >>> +   } > >>> + > >>> +   of_node_put(np); > >> > >> This same code exists twice. Perhaps a helper needs to exist for > >> qcom_rpm_get_performance() to 

Re: [PATCH v1 1/1] clk: npcm: get fixed input clks from DT

2018-12-05 Thread Stephen Boyd
Quoting Tali Perry (2018-12-05 11:47:02) > --- No commit text? No Signed-off-by? Sorry, I don't understand what this patch is for or what's going on. > drivers/clk/clk-npcm7xx.c | 64 > +++ > 1 file changed, 53 insertions(+), 11 deletions(-) > >

Re: [PATCH] clk: mediatek: fix the PCIe MAC clock parent

2018-12-05 Thread Stephen Boyd
Quoting Ryder Lee (2018-12-04 22:41:10) > The PCIe function doesn't work as the clock tree of MAC layer is wrong. > Hence fix the clock table. > > Fixes: 3b5e748615e7 ("clk: mediatek: add clock support for MT7629 SoC") > Signed-off-by: Ryder Lee > --- Applied to clk-next

RE: [PATCH V6 0/9] clk: add imx7ulp clk support

2018-12-05 Thread Stephen Boyd
Quoting Aisheng DONG (2018-12-03 17:29:29) > > -Original Message- > > From: Stephen Boyd [mailto:sb...@kernel.org] > > Sent: Tuesday, December 4, 2018 3:32 AM > > To: Aisheng DONG ; linux-...@vger.kernel.org > > Cc: linux-kernel@vger.kernel.org; linux-

Re: [PATCH v6 07/10] clk: rk808: use managed version of of_provider registration

2018-12-05 Thread Stephen Boyd
Quoting Matti Vaittinen (2018-12-04 03:38:03) > Simplify clean-up for rk808 by using managed version of of_provider > registration. > > Signed-off-by: Matti Vaittinen > --- Applied to clk-next

Re: [PATCH v11 2/2] cpufreq: qcom-hw: Add support for QCOM cpufreq HW driver

2018-12-05 Thread Stephen Boyd
Quoting Viresh Kumar (2018-12-04 22:16:00) > On 05-12-18, 09:07, Taniya Das wrote: > > Hello Stephen, Viresh > > > > Thanks for the code and suggestions. > > > > Having a NR_DOMAINS '2' makes the driver not scalable for re-use. > > Sure, I didn't like it either and that wasn't really what I was

Re: [PATCH v3 5/5] clk: samsung: exynos5433: add imem clocks

2018-12-05 Thread Stephen Boyd
Quoting Sylwester Nawrocki (2018-12-05 02:57:32) > On 12/4/18 19:40, Stephen Boyd wrote: > > Quoting Kamil Konieczny (2018-12-04 08:52:48) > >> + > >> +static const unsigned long imem_clk_regs[] __initconst = { > >> + ENABLE_ACLK_IMEM, &

Re: [PATCH] clk: qcom: Remove LPASS_CC config for GCC lpass clocks

2018-12-05 Thread Stephen Boyd
Quoting Taniya Das (2018-12-05 00:02:00) > The GCC lpass clocks are updated as protected, so clean up the ifdefers. > > Signed-off-by: Taniya Das > --- Ok. But this will have to wait for a few months until everything is merged together. Was that the intention of sending this now instead of

Re: [PATCH] clk: socfpga: Don't have get_parent for single parent ops

2018-12-05 Thread Stephen Boyd
Quoting Dinh Nguyen (2018-12-05 07:17:41) > Hi Stephen, > > On 12/5/18 1:17 AM, Stephen Boyd wrote: > > (Adding Dinh's korg email) > > > > I also wonder if this driver is even used anymore or maybe we can delete > > it? > > > > The armv7 So

Re: [PATCH v11 2/2] cpufreq: qcom-hw: Add support for QCOM cpufreq HW driver

2018-12-05 Thread Stephen Boyd
Quoting Taniya Das (2018-12-04 19:37:00) > Hello Stephen, Viresh > > Thanks for the code and suggestions. > > Having a NR_DOMAINS '2' makes the driver not scalable for re-use. > This assumption is only true for the current version of the HW and do > not intend to update/clean-up this logic

Re: [PATCH] Revert "clk: fix __clk_init_parent() for single parent clocks"

2018-12-04 Thread Stephen Boyd
Quoting Jerome Brunet (2018-12-04 11:51:17) > On Tue, 2018-12-04 at 10:05 -0800, Stephen Boyd wrote: > > Quoting Jerome Brunet (2018-12-04 08:32:57) > > > This reverts commit 2430a94d1e719b7b4af2a65b781a4c036eb22e64. > > > > > > From the original commit mess

Re: [PATCH] clk: socfpga: Don't have get_parent for single parent ops

2018-12-04 Thread Stephen Boyd
(Adding Dinh's korg email) I also wonder if this driver is even used anymore or maybe we can delete it? Quoting Stephen Boyd (2018-12-04 11:34:16) > This driver creates a gate clk with the possibility to have multiple > parents. That can cause problems if the common clk framework tries to

Re: [RFC PATCH] clk: qcom: clk-rpmh: Add IPA clock support

2018-12-04 Thread Stephen Boyd
Quoting David Dai (2018-12-04 17:14:10) > > On 12/4/2018 2:34 PM, Stephen Boyd wrote: > > Quoting Alex Elder (2018-12-04 13:41:47) > >> On 12/4/18 1:24 PM, Stephen Boyd wrote: > >>> Quoting David Dai (2018-12-03 19:50:13) > >>>> Add IPA clock

Re: [PATCH 07/14] clock: milbeaut: Add Milbeaut M10V clock control

2018-12-04 Thread Stephen Boyd
Quoting Masahiro Yamada (2018-12-04 20:26:06) > On Wed, Dec 5, 2018 at 3:14 AM Stephen Boyd wrote: > > > > Quoting Masahiro Yamada (2018-12-04 03:03:53) > > > Hi Stephen, > > > > > > > > > On Fri, Nov 30, 2018 at 5:31 PM Stephen Boyd wrote: >

Re: [PATCH V2 5/5] PM / Domains: Propagate performance state updates

2018-12-04 Thread Stephen Boyd
Quoting Ulf Hansson (2018-12-03 05:38:35) > + Stephen, Mike, Graham > > On Fri, 30 Nov 2018 at 12:06, Viresh Kumar wrote: > > > > On 30-11-18, 11:18, Ulf Hansson wrote: > There is one a big difference while comparing with clocks, which make > this more difficult. > > That is, in

Re: [PATCH v5 7/8] arm64: dts: sdm845: Add rpmh powercontroller node

2018-12-04 Thread Stephen Boyd
Quoting Rajendra Nayak (2018-12-03 21:21:18) > diff --git a/arch/arm64/boot/dts/qcom/sdm845.dtsi > b/arch/arm64/boot/dts/qcom/sdm845.dtsi > index b72bdb0a31a5..a6d0cd8d17b0 100644 > --- a/arch/arm64/boot/dts/qcom/sdm845.dtsi > +++ b/arch/arm64/boot/dts/qcom/sdm845.dtsi > @@ -1324,6 +1325,56 @@ >

Re: [PATCH v5 4/8] soc: qcom: rpmpd: Add support for get/set performance state

2018-12-04 Thread Stephen Boyd
Quoting Rajendra Nayak (2018-12-03 21:21:15) > @@ -221,6 +224,47 @@ static int rpmpd_power_off(struct generic_pm_domain > *domain) > return ret; > } > > +static int rpmpd_set_performance(struct generic_pm_domain *domain, > +unsigned int state) > +{ > +

Re: [PATCH v5 3/8] soc: qcom: rpmpd: Add a Power domain driver to model corners

2018-12-04 Thread Stephen Boyd
Overall looks good to me, just some nitpicks around modules and includes. Quoting Rajendra Nayak (2018-12-03 21:21:14) > The Power domains for corners just pass the performance state set by the > consumers to the RPM (Remote Power manager) which then takes care > of setting the appropriate

Re: [PATCH v5 1/8] dt-bindings: opp: Introduce qcom-opp bindings

2018-12-04 Thread Stephen Boyd
ross various rails) > based on the value passed. > > Describe these bindings in the qcom-opp bindings document. > > Signed-off-by: Rajendra Nayak > Acked-by: Viresh Kumar > --- Reviewed-by: Stephen Boyd

Re: [PATCH v11 2/2] cpufreq: qcom-hw: Add support for QCOM cpufreq HW driver

2018-12-04 Thread Stephen Boyd
Quoting Stephen Boyd (2018-12-04 14:28:11) > Quoting Viresh Kumar (2018-12-03 21:12:31) > > Hi Taniya, > > > > Sorry that I haven't been reviewing it much from last few iterations as I > > was > > letting others get this into a better shape. Thanks for your effo

Re: [PATCH] clk: fix clk_mux_val_to_index() error value

2018-12-04 Thread Stephen Boyd
Quoting Jerome Brunet (2018-12-04 11:55:10) > On Tue, 2018-12-04 at 10:43 -0800, Stephen Boyd wrote: > > Quoting Jerome Brunet (2018-12-04 08:34:03) > > > clk_mux_val_to_index() is meant to be used by .get_parent(), which > > > returns a u8, so when the value provide

Re: [RFC PATCH] clk: qcom: clk-rpmh: Add IPA clock support

2018-12-04 Thread Stephen Boyd
Quoting Alex Elder (2018-12-04 13:41:47) > On 12/4/18 1:24 PM, Stephen Boyd wrote: > > Quoting David Dai (2018-12-03 19:50:13) > >> Add IPA clock support by extending the current clk rpmh driver to support > >> clocks that are managed by a different type of RPMh resou

Re: [PATCH v11 2/2] cpufreq: qcom-hw: Add support for QCOM cpufreq HW driver

2018-12-04 Thread Stephen Boyd
Quoting Viresh Kumar (2018-12-03 21:12:31) > Hi Taniya, > > Sorry that I haven't been reviewing it much from last few iterations as I was > letting others get this into a better shape. Thanks for your efforts.. > > On 02-12-18, 09:25, Taniya Das wrote: > > +++ b/drivers/cpufreq/qcom-cpufreq-hw.c

Re: [PATCH] clk: meson-gxbb: switch video clocks mux tables to static

2018-12-04 Thread Stephen Boyd
Quoting Jerome Brunet (2018-12-04 12:05:02) > On Tue, 2018-12-04 at 20:33 +0100, Neil Armstrong wrote: > > Le 04/12/2018 18:43, Stephen Boyd a écrit : > > > Quoting Neil Armstrong (2018-12-04 04:58:39) > > > > @@ -1983,7 +1983,7 @@ static struct clk

[PATCH] clk: socfpga: Don't have get_parent for single parent ops

2018-12-04 Thread Stephen Boyd
: Jerome Brunet Cc: Masahiro Yamada Cc: Dinh Nguyen Signed-off-by: Stephen Boyd --- drivers/clk/socfpga/clk-gate.c | 22 +- 1 file changed, 13 insertions(+), 9 deletions(-) diff --git a/drivers/clk/socfpga/clk-gate.c b/drivers/clk/socfpga/clk-gate.c index aa7a6e6a15b6

Re: [PATCH v7 2/4] clk: meson: add DT documentation for emmc clock controller

2018-12-04 Thread Stephen Boyd
Quoting Jianxin Pan (2018-12-03 18:39:34) > Hi Stephen, > > On 2018/12/4 6:45, Stephen Boyd wrote: > > Quoting Jianxin Pan (2018-11-15 04:18:30) > >> diff --git a/include/dt-bindings/clock/amlogic,mmc-clkc.h > >> b/include/dt-bindings/clock/amlogic,mmc-clkc.h >

Re: [RFC PATCH] Add IPA clock support for clk-rpmh

2018-12-04 Thread Stephen Boyd
Quoting David Dai (2018-12-03 19:50:12) > This patch extends the existing clk-rpmh driver to support a different > type of RPMh resource known as Bus Clock Manager(BCM) in order to scale > performance for the Qualcomm IP Accelerator(IPA) core clock. Please don't send cover letters for single

Re: [RFC PATCH] clk: qcom: clk-rpmh: Add IPA clock support

2018-12-04 Thread Stephen Boyd
Quoting David Dai (2018-12-03 19:50:13) > Add IPA clock support by extending the current clk rpmh driver to support > clocks that are managed by a different type of RPMh resource known as > Bus Clock Manager(BCM). Yes, but why? Does the IPA driver need to set clk rates and that somehow doesn't

Re: [PATCH] clk: fix clk_mux_val_to_index() error value

2018-12-04 Thread Stephen Boyd
Quoting Jerome Brunet (2018-12-04 08:34:03) > clk_mux_val_to_index() is meant to be used by .get_parent(), which > returns a u8, so when the value provided does not map to any valid index, > it is not a good idea to return a negative error value. > > Instead, return num_parents which we know is

Re: [PATCH v3 5/5] clk: samsung: exynos5433: add imem clocks

2018-12-04 Thread Stephen Boyd
Quoting Kamil Konieczny (2018-12-04 08:52:48) > + > +static const unsigned long imem_clk_regs[] __initconst = { > + ENABLE_ACLK_IMEM, > + ENABLE_ACLK_IMEM_INT_MEM, > + ENABLE_ACLK_IMEM_SSS, > + ENABLE_ACLK_IMEM_SLIMSSS, > + ENABLE_ACLK_IMEM_RTIC, > +

Re: [PATCH 07/14] clock: milbeaut: Add Milbeaut M10V clock control

2018-12-04 Thread Stephen Boyd
Quoting Sugaya, Taichi (2018-12-04 00:26:16) > On 2018/11/30 17:31, Stephen Boyd wrote: > > Quoting Sugaya Taichi (2018-11-18 17:01:12) > >> +void __init m10v_clk_mux_setup(struct device_node *node) > >> +{ > >> + const char *clk_name = node->name;

Re: [PATCH 07/14] clock: milbeaut: Add Milbeaut M10V clock control

2018-12-04 Thread Stephen Boyd
Quoting Masahiro Yamada (2018-12-04 03:03:53) > Hi Stephen, > > > On Fri, Nov 30, 2018 at 5:31 PM Stephen Boyd wrote: > > > > Quoting Sugaya Taichi (2018-11-18 17:01:12) > > > Add Milbeaut M10V clock ( including PLL ) control. > > > > Please give s

Re: [PATCH] Revert "clk: fix __clk_init_parent() for single parent clocks"

2018-12-04 Thread Stephen Boyd
Quoting Jerome Brunet (2018-12-04 08:32:57) > This reverts commit 2430a94d1e719b7b4af2a65b781a4c036eb22e64. > > From the original commit message: > It turned out a problem because there are some single-parent clocks > that implement .get_parent() callback and return non-zero index. > The

Re: [PATCH] clk: meson-gxbb: switch video clocks mux tables to static

2018-12-04 Thread Stephen Boyd
Quoting Neil Armstrong (2018-12-04 04:58:39) > Makes the following sparse warnings silent: > drivers/clk/meson/vid-pll-div.c:58:26: warning: symbol '_get_table_val' was > not declared. Should it be static? > drivers/clk/meson/gxbb.c:1585:12: warning: symbol 'gxbb_vid_pll_parent_names' > was not

Re: [PATCH v11 1/2] dt-bindings: cpufreq: Introduce QCOM CPUFREQ Firmware bindings

2018-12-03 Thread Stephen Boyd
Quoting Rob Herring (2018-12-03 15:09:07) > On Sun, Dec 02, 2018 at 09:25:02AM +0530, Taniya Das wrote: > > Add QCOM cpufreq firmware device bindings for Qualcomm Technology Inc's > > SoCs. This is required for managing the cpu frequency transitions which are > > controlled by the hardware engine.

Re: [PATCH] arm64: dts: qcom: msm8998: Fix compatible of scm node

2018-12-03 Thread Stephen Boyd
uot;arm64: dts: qcom: msm8998: Add firmware node") > Signed-off-by: Bjorn Andersson > --- Reviewed-by: Stephen Boyd

Re: [RFC v3 2/3] dt-bindings: sdm845-pinctrl: add wakeup interrupt parent for GPIO

2018-12-03 Thread Stephen Boyd
Quoting Lina Iyer (2018-11-30 10:33:17) > On Thu, Nov 29 2018 at 14:45 -0700, Lina Iyer wrote: > >On Wed, Nov 28 2018 at 17:25 -0700, Bjorn Andersson wrote: > >>On Wed 28 Nov 09:39 PST 2018, Lina Iyer wrote: > >> > >>>On Tue, Nov 27 2018 at 14:45 -0700, Steph

Re: [PATCH v4 1/8] clk: clkdev/of_clk - add managed lookup and provider registrations

2018-12-03 Thread Stephen Boyd
Quoting Matti Vaittinen (2018-11-30 02:50:22) > Hello Stephen, > > Thanks a bunch for taking the time and reviewing this! > > On Fri, Nov 30, 2018 at 12:54:10AM -0800, Stephen Boyd wrote: > > Quoting Matti Vaittinen (2018-11-13 03:55:58) > > > With MFD devices the c

Re: [PATCH v7 2/4] clk: meson: add DT documentation for emmc clock controller

2018-12-03 Thread Stephen Boyd
Quoting Jianxin Pan (2018-11-15 04:18:30) > diff --git a/include/dt-bindings/clock/amlogic,mmc-clkc.h > b/include/dt-bindings/clock/amlogic,mmc-clkc.h > new file mode 100644 > index 000..162b949 > --- /dev/null > +++ b/include/dt-bindings/clock/amlogic,mmc-clkc.h > @@ -0,0 +1,17 @@ > +/*

Re: [PATCH v1 4/4] phy: qcom-qmp: Expose provided clocks to DT

2018-12-03 Thread Stephen Boyd
Quoting Evan Green (2018-11-29 14:13:57) > Register a simple clock provider for the PHY pipe clock sources so that > device tree users can point at these clocks via phandles to the lane > nodes. > > Signed-off-by: Evan Green > --- Reviewed-by: Stephen Boyd

Re: [PATCH v1 3/4] arm64: dts: qcom: sdm845: Fix QMP PHY #clock-cells

2018-12-03 Thread Stephen Boyd
-by: Evan Green > --- Reviewed-by: Stephen Boyd

Re: [PATCH v1 2/4] arm64: dts: qcom: msm8996: Fix QMP PHY #clock-cells

2018-12-03 Thread Stephen Boyd
Quoting Evan Green (2018-11-29 14:13:55) > Move #clock-cells into the child node and set it to 0 to conform to the > proper binding specification. > > Signed-off-by: Evan Green > --- Reviewed-by: Stephen Boyd

Re: [PATCH v1 1/4] dt-bindings: phy-qcom-qmp: Move #clock-cells to child

2018-12-03 Thread Stephen Boyd
ls to > zero, since there's nothing to pass to it. > > Signed-off-by: Evan Green > --- Reviewed-by: Stephen Boyd

Re: [PATCH 2/2] clk: core: link consumer with clock driver

2018-12-03 Thread Stephen Boyd
Quoting Miquel Raynal (2018-12-03 14:16:55) > Stephen Boyd wrote on Mon, 03 Dec 2018 11:20:31 > -0800: > > Quoting Miquel Raynal (2018-11-30 02:20:52) > > > Stephen Boyd wrote on Fri, 30 Nov 2018 01:26:20 > > > -0800: > > > > Quoting Miquel Raynal (2018

Re: [PATCH V6 3/9] clk: imx: add pllv4 support

2018-12-03 Thread Stephen Boyd
hile this patch > intends to support the PLL part. > > Cc: Stephen Boyd > Cc: Michael Turquette > Cc: Shawn Guo > Cc: Anson Huang > Cc: Bai Ping > Signed-off-by: Dong Aisheng > > --- Applied to clk-next

Re: [PATCH V6 8/9] clk: imx: implement new clk_hw based APIs

2018-12-03 Thread Stephen Boyd
Quoting A.s. Dong (2018-11-14 05:02:04) > Clock providers are recommended to use the new struct clk_hw based API, > so implement IMX clk_hw based provider helpers functions to the new > approach. > > Signed-off-by: Dong Aisheng > > --- Applied to clk-next

Re: [PATCH V6 9/9] clk: imx: add imx7ulp clk driver

2018-12-03 Thread Stephen Boyd
al cases that scs/ddr/nic mux selecting > different clock source requires that clock to be enabled first, > then we need set CLK_OPS_PARENT_ENABLE flag for them properly. > > Cc: Stephen Boyd > Cc: Michael Turquette > Cc: Shawn Guo > Cc: Anson Huang > Cc: Bai Ping > Signed-off-by: Dong Aisheng > > --- Applied to clk-next

Re: [PATCH V6 6/9] dt-bindings: clock: add imx7ulp clock binding doc

2018-12-03 Thread Stephen Boyd
g doc > is only for A7 clock domain. > > Cc: Rob Herring > Cc: Mark Rutland > Cc: Stephen Boyd > Cc: Michael Turquette > Cc: Shawn Guo > Cc: Anson Huang > Cc: Bai Ping > Signed-off-by: Dong Aisheng > > --- Applied to clk-next

Re: [PATCH V6 7/9] clk: imx: make mux parent strings const

2018-12-03 Thread Stephen Boyd
0, > 1, pll_pre_sels, ARRAY_SIZE(pll_pre_sels), CLK_SET_PARENT_GATE); >^ > In file included from drivers/clk/imx/clk-imx7ulp.c:23:0: > drivers/clk/imx/clk.h:200:27: note: expected 'const char **' but argument is > of type 'const char * const*' &

Re: [PATCH V6 4/9] clk: imx: add pfdv2 support

2018-12-03 Thread Stephen Boyd
Quoting A.s. Dong (2018-11-14 05:01:47) > The pfdv2 is designed for PLL Fractional Divide (PFD) observed in System > Clock Generation (SCG) module in IMX ULP SoC series. e.g. i.MX7ULP. > > NOTE pfdv2 can only be operated when clk is gated. > > Cc: Stephen Boyd > Cc: Mi

Re: [PATCH V6 5/9] clk: imx: add imx7ulp composite clk support

2018-12-03 Thread Stephen Boyd
Quoting A.s. Dong (2018-11-14 05:01:51) > The imx composite clk is designed for Peripheral Clock Control (PCC) > module observed in IMX ULP SoC series. > > NOTE pcc can only be operated when clk is gated. > > Cc: Stephen Boyd > Cc: Michael Turquette > Cc: Shawn Guo

Re: [PATCH V6 2/9] clk: fractional-divider: add CLK_FRAC_DIVIDER_ZERO_BASED flag support

2018-12-03 Thread Stephen Boyd
iv +1)] > where frac/div in register is: > 000b - Divide by 1. > 001b - Divide by 2. > 010b - Divide by 3. > > Cc: Stephen Boyd > Cc: Michael Turquette > Signed-off-by: Dong Aisheng > > --- Applied to clk-next

Re: [PATCH V6 0/9] clk: add imx7ulp clk support

2018-12-03 Thread Stephen Boyd
Quoting A.s. Dong (2018-11-14 05:01:31) > This patch series intends to add imx7ulp clk support. > > i.MX7ULP Clock functions are under joint control of the System > Clock Generation (SCG) modules, Peripheral Clock Control (PCC) > modules, and Core Mode Controller (CMC)1 blocks > > The clocking

Re: [PATCH V6 1/9] clk: imx: add gatable clock divider support

2018-12-03 Thread Stephen Boyd
te. > So to make things work, we'll need to return the cached rate in recalc rate > when the clk is off and read the hardware when the clk is on. > > NOTE for the default off divider, the recalc rate will still return 0 as > there's still no proper preset rate. Enable such divider wil

Re: [PATCH 2/2] clk: core: link consumer with clock driver

2018-12-03 Thread Stephen Boyd
Quoting Miquel Raynal (2018-11-30 02:20:52) > Hi Stephen, > > Stephen Boyd wrote on Fri, 30 Nov 2018 01:26:20 > -0800: > > > Quoting Miquel Raynal (2018-11-23 01:11:32) > > > Would you agree with me adding dummy functions in the #else section > > >

Re: [PATCH 05/12] PCI: aardvark: add suspend to RAM support

2018-12-03 Thread Stephen Boyd
Quoting Lorenzo Pieralisi (2018-12-03 09:18:59) > [+Stephen, Mike] > > On Mon, Dec 03, 2018 at 04:38:46PM +0100, Miquel Raynal wrote: > > Hi Lorenzo, > > > > Lorenzo Pieralisi wrote on Mon, 3 Dec 2018 > > 10:27:08 +: > > > > > [+Rafael, Sudeep] > > > > > > On Fri, Nov 23, 2018 at

Re: [PATCH v15 5/5] clk: imx: Add clock driver for i.MX8MQ CCM

2018-12-03 Thread Stephen Boyd
Quoting Abel Vesa (2018-12-01 02:52:15) > Add driver for the Clock Control Module found on i.MX8MQ. > > Signed-off-by: Anson Huang > Signed-off-by: Bai Ping > Signed-off-by: Lucas Stach > Signed-off-by: Abel Vesa > Reviewed-by: Sascha Hauer > --- Applied to clk-next but checkpatch

Re: [PATCH v15 4/5] clk: imx: Add imx composite clock

2018-12-03 Thread Stephen Boyd
Quoting Abel Vesa (2018-12-01 02:52:14) > Since a lot of clocks on imx8m are formed by a mux, gate, predivider and > divider, the idea here is to combine all of those into one composite clock, > but we need to deal with both predivider and divider at the same time and > therefore we add the

Re: [PATCH v15 3/5] clk: imx: Add SCCG PLL type

2018-12-03 Thread Stephen Boyd
Quoting Abel Vesa (2018-12-01 02:52:13) > From: Lucas Stach > > The SCCG is a new PLL type introduced on i.MX8. > > The description of this SCCG clock can be found here: > > https://www.nxp.com/docs/en/reference-manual/IMX8MDQLQRM.pdf#page=834 > > Signed-off-by: Lucas Stach > Signed-off-by:

Re: [PATCH v15 2/5] clk: imx: Add fractional PLL output clock

2018-12-03 Thread Stephen Boyd
Quoting Abel Vesa (2018-12-01 02:52:11) > From: Lucas Stach > > This is a new fractional clock type introduced on i.MX8. > > The description of this fractional clock can be found here: > > https://www.nxp.com/docs/en/reference-manual/IMX8MDQLQRM.pdf#page=834 > > Signed-off-by: Lucas Stach >

Re: [PATCH v15 1/5] dt-bindings: Add binding for i.MX8MQ CCM

2018-12-03 Thread Stephen Boyd
Quoting Abel Vesa (2018-12-01 02:52:10) > From: Lucas Stach > > This adds the binding for the i.MX8MQ Clock Controller Module. > > Signed-off-by: Lucas Stach > Signed-off-by: Abel Vesa > Reviewed-by: Rob Herring > --- Applied to clk-next

Re: [PATCH v2] clk: qcom: Fix MSM8998 resets

2018-12-03 Thread Stephen Boyd
Quoting Jeffrey Hugo (2018-12-03 08:13:43) > The offsets for the defined BCR reset registers does not match the hardware > documentation. Update the values to match the hardware documentation. > > Fixes: b5f5f525c547 (clk: qcom: Add MSM8998 Global Clock Control (GCC) driver) > Signed-off-by:

Re: [PATCH v3 2/3] dt-bindings: clk: meson: add main controller clock input

2018-12-03 Thread Stephen Boyd
Quoting Jerome Brunet (2018-12-03 09:16:39) > Add the clock input of the main clock controller > > Signed-off-by: Jerome Brunet > --- Reviewed-by: Stephen Boyd

Re: [PATCH v3 1/3] dt-bindings: clk: meson: add ao controller clock inputs

2018-12-03 Thread Stephen Boyd
Quoting Jerome Brunet (2018-12-03 09:16:38) > Add the clock inputs of amlogic AO clock controller > > Signed-off-by: Jerome Brunet > --- Reviewed-by: Stephen Boyd

Re: [PATCH] clk: qcom: Fix MSM8998 resets

2018-12-03 Thread Stephen Boyd
Quoting Jeffrey Hugo (2018-12-03 09:19:20) > On 12/3/2018 10:02 AM, Stephen Boyd wrote: > > Quoting Jeffrey Hugo (2018-12-03 08:08:46) > >> On 12/3/2018 8:55 AM, Bjorn Andersson wrote: > >>> On Mon 03 Dec 07:34 PST 2018, Jeffrey Hugo wrote: > >>> &g

Re: [PATCH v11 3/3] clk: qcom: Add lpass clock controller driver for SDM845

2018-12-03 Thread Stephen Boyd
Quoting Taniya Das (2018-11-30 10:21:29) > Add support for the lpass clock controller found on SDM845 based devices. > This would allow lpass peripheral loader drivers to control the clocks to > bring the subsystem out of reset. > LPASS clocks present on the global clock controller would be

Re: [PATCH v11 2/3] dt-bindings: clock: Introduce QCOM LPASS clock bindings

2018-12-03 Thread Stephen Boyd
Quoting Taniya Das (2018-11-30 10:21:28) > Add device tree bindings for Low Power Audio subsystem clock controller for > Qualcomm Technology Inc's SDM845 SoCs. > > Reviewed-by: Rob Herring > Signed-off-by: Taniya Das > --- Applied to clk-next I noticed that a #define was lost after some

Re: [PATCH v11 1/3] dt-bindings: clock: Update GCC bindings for protected-clocks

2018-12-03 Thread Stephen Boyd
Quoting Taniya Das (2018-11-30 10:21:27) > Add protected-clocks list which could used to specify the clocks to be > bypassed on certain devices. > > Reviewed-by: Rob Herring > Signed-off-by: Taniya Das > --- Applied to clk-next

Re: [PATCH v2 2/3] clk: ti: check clock type before doing autoidle ops

2018-12-03 Thread Stephen Boyd
Quoting Tony Lindgren (2018-12-03 07:39:10) > * Stephen Boyd [181130 23:52]: > > Quoting Tony Lindgren (2018-11-30 07:37:29) > > > * Tero Kristo [181130 09:21]: > > > > On 30/11/2018 09:57, Stephen Boyd wrote: > > > ... > > > > > >

Re: [PATCH] clk: qcom: Fix MSM8998 resets

2018-12-03 Thread Stephen Boyd
Quoting Jeffrey Hugo (2018-12-03 08:08:46) > On 12/3/2018 8:55 AM, Bjorn Andersson wrote: > > On Mon 03 Dec 07:34 PST 2018, Jeffrey Hugo wrote: > > > >> The offsets for the defined BCR reset registers does not match the hardware > >> documentation. Update the values to match the hardware

Re: [PATCH v11 2/2] cpufreq: qcom-hw: Add support for QCOM cpufreq HW driver

2018-12-03 Thread Stephen Boyd
ed-off-by: Stephen Boyd > Signed-off-by: Taniya Das > --- Reviewed-by: Stephen Boyd

Re: [PATCH v11 1/2] dt-bindings: cpufreq: Introduce QCOM CPUFREQ Firmware bindings

2018-12-03 Thread Stephen Boyd
Quoting Taniya Das (2018-12-01 19:55:02) > Add QCOM cpufreq firmware device bindings for Qualcomm Technology Inc's > SoCs. This is required for managing the cpu frequency transitions which are > controlled by the hardware engine. > > Signed-off-by: Taniya Das > --- Reviewed-by: Stephen Boyd

Re: [PATCH v3] tty: serial: qcom_geni_serial: Fix softlock

2018-12-03 Thread Stephen Boyd
drain before adding further data and would also > result in softlocks on large transmissions. > > This patch allows larger transfers with continuous FIFO additions as > space becomes available and removes polling from the interrupt handler. > > Signed-off-by: Ryan Case > --- Reviewed-by: Stephen Boyd

Re: [PATCH v2 2/3] clk: ti: check clock type before doing autoidle ops

2018-11-30 Thread Stephen Boyd
Quoting Tony Lindgren (2018-11-30 07:37:29) > Hi, > > * Tero Kristo [181130 09:21]: > > On 30/11/2018 09:57, Stephen Boyd wrote: > > > No that is not preferred. Can the omap2_clk_deny_idle() function be > > > integrated closer into the clk framework in some wa

Re: [PATCH 2/2] clk: Add Fixed MMIO clock driver

2018-11-30 Thread Stephen Boyd
Quoting Janek Kotas (2018-11-30 01:57:09) > > I tried it. io_remap doesn’t allow RAM to be mapped, > even if it’s marked as a reserved memory. > I got an error, the address couldn’t be mapped. > > ARM64’s memory management has an explicit check for this here: >

Re: [PATCH v8] clk: Add (devm_)clk_get_optional() functions

2018-11-30 Thread Stephen Boyd
Quoting Russell King - ARM Linux (2018-11-30 03:04:46) > On Fri, Nov 30, 2018 at 10:25:37AM +, Phil Edworthy wrote: > > On 30 November 2018 09:09 Stephen Boyd wrote: > > > Quoting Phil Edworthy (2018-11-20 06:14:45) > > > > This adds clk_get_optional() and dev

Re: [PATCH 2/2] clk: core: link consumer with clock driver

2018-11-30 Thread Stephen Boyd
Quoting Miquel Raynal (2018-11-23 01:11:32) > Would you agree with me adding dummy functions in the #else section > like: > > static inline void __clk_device_link(struct device *consumer, struct clk *clk) > { >return; > } > > static inline void __clk_device_unlink(struct clk *clk) > { >

Re: [PATCH 0/2] Link consumer with clock driver

2018-11-30 Thread Stephen Boyd
Quoting Miquel Raynal (2018-11-22 13:22:10) > Hello, > > While working on suspend to RAM feature, I ran into troubles multiple > times when clocks where not suspending/resuming at the desired time. I > had a look at the core and I think the same logic as in the > regulator's core may be applied

Re: [PATCH v8] clk: Add (devm_)clk_get_optional() functions

2018-11-30 Thread Stephen Boyd
Quoting Phil Edworthy (2018-11-20 06:14:45) > This adds clk_get_optional() and devm_clk_get_optional() functions to get > optional clocks. > They behave the same as (devm_)clk_get except where there is no clock > producer. In this case, instead of returning -ENOENT, the function > returns NULL.

Re: [PATCH] dt-bindings: clock: Require #reset-cells in sdm845-videocc

2018-11-30 Thread Stephen Boyd
. > > [1] > https://lkml.kernel.org/r/154330186815.88331.12720647562079303...@swboyd.mtv.corp.google.com > > Fixes: 84b66b211603 ("dt-bindings: clock: Introduce QCOM Video clock > bindings") > Suggested-by: Stephen Boyd > Signed-off-by: Douglas Anderson > --- Applied to clk-next

Re: [PATCH 2/2] clk: Add Fixed MMIO clock driver

2018-11-30 Thread Stephen Boyd
Quoting Janek Kotas (2018-11-30 00:52:16) > > We have a single register in a fixed location which contains > the frequency of the main system clock. > This allows us to use the same image in emulation, FPGA > and simulation without any changes. > We

[PATCH 1/2] clk: mediatek: Drop __init from mtk_clk_register_cpumuxes()

2018-11-30 Thread Stephen Boyd
This function is used from more places than just __init code. Removing __init silences a section mismatch warning here. Cc: Sean Wang Cc: Ryder Lee Cc: Rob Herring Cc: Wenzhen Yu Cc: Weiyi Lu Signed-off-by: Stephen Boyd --- drivers/clk/mediatek/clk-cpumux.c | 8 1 file changed, 4

[PATCH 2/2] clk: mediatek: Drop more __init markings for driver probe

2018-11-30 Thread Stephen Boyd
: add clock support for MT7622 SoC") Signed-off-by: Stephen Boyd --- drivers/clk/mediatek/clk-mt7622.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/drivers/clk/mediatek/clk-mt7622.c b/drivers/clk/mediatek/clk-mt7622.c index 92f7e32770c6..a8aecef1ba89 100644 --- a/d

  1   2   3   4   5   6   7   8   9   10   >