[PATCH 2.6.21] udf: Decrement correct link count in udf_rmdir

2007-05-01 Thread Stephen Mollett
It appears that a minor thinko occurred in udf_rmdir and the (already-cleared) 
link count on the directory that is being removed was being decremented 
instead of the link count on its parent directory. This gives rise to lots of 
kernel messages similar to:

UDF-fs warning (device loop1): udf_rmdir: empty directory has nlink != 2 (8)

when removing directory trees. No other ill effects have been observed but I 
guess it could theoretically result in the link count overflowing on a very 
long-lived, much modified directory.

Signed-off-by: Stephen Mollett [EMAIL PROTECTED]
---

Patch applies cleanly to latest git snapshot and other recent 2.6 kernels.

Please CC: me as I'm not currently subscribed to linux-kernel.

First attempt at formally submitting a kernel patch - apologies if I've cocked 
something up - please be nice :-)


--- linux-2.6.21/fs/udf/namei.c.orig2007-05-01 18:52:02.0 +0100
+++ linux-2.6.21/fs/udf/namei.c 2007-05-01 18:53:00.0 +0100
@@ -878,7 +878,7 @@ static int udf_rmdir(struct inode * dir,
inode-i_nlink);
clear_nlink(inode);
inode-i_size = 0;
-   inode_dec_link_count(inode);
+   inode_dec_link_count(dir);
inode-i_ctime = dir-i_ctime = dir-i_mtime = 
current_fs_time(dir-i_sb);
mark_inode_dirty(dir);
 
-
To unsubscribe from this list: send the line unsubscribe linux-kernel in
the body of a message to [EMAIL PROTECTED]
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/


Re: [Linux-parport] Linux v2.6.21-rc3

2007-03-07 Thread Stephen Mollett
On Wednesday 07 Mar 2007, Michal Piotrowski wrote:
 BTW. Does anyone care about parport console?
 console=lp0 hangs since at least 2.6.18

For the record, I used console=lp0 quite recently (stock 2.6.19 according to 
the printout, running on i386) [to find out what was causing a panic that 
immediately vanished off the top of the screen because of atkbd.c: Spurious 
ACK...s from the flashing kb LEDs] and it worked just fine.

The parport-related lines went:

lp: driver loaded but no devices found
parport: PnPBIOS parport detected.
parport0: PC-style at 0x378, irq 7 [PCSPP,TRISTATE,EPP]
parport0: Printer, EPSON Stylus COLOR 600
lp0: using parport0 (interrupt-driven)
lp0: console ready

... then the kernel continued booting until the panic occurred (it was a silly 
storage-related misconfig on my part).

If anyone wants me to try anything (newer kernel or different parport-related 
BIOS settings, perhaps, to see if I can duplicate the problem?) and report 
back, let me know.

Stephen
-
To unsubscribe from this list: send the line unsubscribe linux-kernel in
the body of a message to [EMAIL PROTECTED]
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/


Re: io mapaddr 0xXXXXX not valid in smc-mca in 2.4.x

2001-02-27 Thread Stephen Mollett

On Monday 26 February 2001  8:15 pm, Alan Cox wrote:
 ... I had a look and a guess at a fix is in ac5 (out RSN)

You'll be glad to hear that the driver is now working perfectly. Thanks!

Regards,
Stephen Mollett
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to [EMAIL PROTECTED]
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/



io mapaddr 0xXXXXX not valid in smc-mca in 2.4.x

2001-02-26 Thread Stephen Mollett

In kernel version 2.4.x (x from 0 to 2-ac3), the
smc-mca driver gives many errors like the following on
the console log:

io mapaddr 0xX not valid at smc-mca.c:YYY!

where X is an address within the shared-memory
assigned to the adapter card, and YYY is 378, 398 or
408.

I have tested the driver on two IBM MCA systems - a
9577 and an 8590. I have tried three different network
adapters in each machine:

WD Ethercard PLUS 10T/A (WD8003W/A)
SMC Ethercard PLUS Elite/A BNC/AUI (WD8013EP/A)
SMC Ethercard PLUS Elite/A UTP/AUI (WD8013WP/A)

All the adapters give the errors, in both machines.
All adapters and both PS/2s are known to be good with
kernel 2.2.17.

* please cc any responses to me [EMAIL PROTECTED]
as I do not subscribe to the list.

Regards,
Stephen Mollett

__
Do You Yahoo!?
Get email at your own domain with Yahoo! Mail. 
http://personal.mail.yahoo.com/
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to [EMAIL PROTECTED]
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/