Re: [alsa-devel][PATCH 2/3] ASoC: TSCS42xx: Remove Playback/Capture in names

2018-06-20 Thread Steven Eckhoff
On Mon, Jun 18, 2018 at 12:31:54PM +0100, Mark Brown wrote: > Really? They're part of the spec so it indicates that the apps have a > problem... I apologize for the delayed response. I am unable to reproduce the issue that I was seeing with controls that had Playback or Capture in their names.

Re: [alsa-devel][PATCH 2/3] ASoC: TSCS42xx: Remove Playback/Capture in names

2018-06-20 Thread Steven Eckhoff
On Mon, Jun 18, 2018 at 12:31:54PM +0100, Mark Brown wrote: > Really? They're part of the spec so it indicates that the apps have a > problem... I apologize for the delayed response. I am unable to reproduce the issue that I was seeing with controls that had Playback or Capture in their names.

[alsa-devel][PATCH 3/3] ASoC: TSCS42xx: Add headphone auto switching

2018-06-04 Thread Steven Eckhoff
Add headphone auto switching controls Signed-off-by: Steven Eckhoff --- sound/soc/codecs/tscs42xx.c | 6 ++ sound/soc/codecs/tscs42xx.h | 8 2 files changed, 14 insertions(+) diff --git a/sound/soc/codecs/tscs42xx.c b/sound/soc/codecs/tscs42xx.c index c79c075228a6..4f56d2937a35

[alsa-devel][PATCH 3/3] ASoC: TSCS42xx: Add headphone auto switching

2018-06-04 Thread Steven Eckhoff
Add headphone auto switching controls Signed-off-by: Steven Eckhoff --- sound/soc/codecs/tscs42xx.c | 6 ++ sound/soc/codecs/tscs42xx.h | 8 2 files changed, 14 insertions(+) diff --git a/sound/soc/codecs/tscs42xx.c b/sound/soc/codecs/tscs42xx.c index c79c075228a6..4f56d2937a35

[alsa-devel][PATCH 2/3] ASoC: TSCS42xx: Remove Playback/Capture in names

2018-06-04 Thread Steven Eckhoff
These aren't needed and some userspace apps don't work consistently with them. Remove Playback/Capture from control names Signed-off-by: Steven Eckhoff --- sound/soc/codecs/tscs42xx.c | 28 ++-- 1 file changed, 14 insertions(+), 14 deletions(-) diff --git a/sound/soc

[alsa-devel][PATCH 2/3] ASoC: TSCS42xx: Remove Playback/Capture in names

2018-06-04 Thread Steven Eckhoff
These aren't needed and some userspace apps don't work consistently with them. Remove Playback/Capture from control names Signed-off-by: Steven Eckhoff --- sound/soc/codecs/tscs42xx.c | 28 ++-- 1 file changed, 14 insertions(+), 14 deletions(-) diff --git a/sound/soc

[alsa-devel][PATCH 1/3] ASoC: TSCS42xx: Add mic bias boost control

2018-06-04 Thread Steven Eckhoff
Add mic bias boost control Signed-off-by: Steven Eckhoff --- sound/soc/codecs/tscs42xx.c | 3 +++ 1 file changed, 3 insertions(+) diff --git a/sound/soc/codecs/tscs42xx.c b/sound/soc/codecs/tscs42xx.c index bbfc73a79b18..15505c3c9ed4 100644 --- a/sound/soc/codecs/tscs42xx.c +++ b/sound/soc

[alsa-devel][PATCH 1/3] ASoC: TSCS42xx: Add mic bias boost control

2018-06-04 Thread Steven Eckhoff
Add mic bias boost control Signed-off-by: Steven Eckhoff --- sound/soc/codecs/tscs42xx.c | 3 +++ 1 file changed, 3 insertions(+) diff --git a/sound/soc/codecs/tscs42xx.c b/sound/soc/codecs/tscs42xx.c index bbfc73a79b18..15505c3c9ed4 100644 --- a/sound/soc/codecs/tscs42xx.c +++ b/sound/soc

[alsa-devel][PATCH 0/3] ASoC: TSCS42xx: Control Improvements

2018-06-04 Thread Steven Eckhoff
Steven Eckhoff (3): Add mic bias boost control Remove Playback/Capture from control names Add headphone auto switching controls sound/soc/codecs/tscs42xx.c | 37 +++-- sound/soc/codecs/tscs42xx.h | 8 2 files changed, 31 insertions(+), 14 deletions

[alsa-devel][PATCH 0/3] ASoC: TSCS42xx: Control Improvements

2018-06-04 Thread Steven Eckhoff
Steven Eckhoff (3): Add mic bias boost control Remove Playback/Capture from control names Add headphone auto switching controls sound/soc/codecs/tscs42xx.c | 37 +++-- sound/soc/codecs/tscs42xx.h | 8 2 files changed, 31 insertions(+), 14 deletions

[alsa-devel][RESEND PATCH 1/3 v3] ASoC: TSCS42xx: Shorten lines and other cleanup

2018-04-04 Thread Steven Eckhoff
Shorten lines greater than 80 chars Add const to struct snd_soc_component_driver Signed-off-by: Steven Eckhoff <steven.eckhoff.opensou...@gmail.com> --- sound/soc/codecs/tscs42xx.c | 87 - 1 file changed, 55 insertions(+), 32 deletions(-) diff

[alsa-devel][RESEND PATCH 1/3 v3] ASoC: TSCS42xx: Shorten lines and other cleanup

2018-04-04 Thread Steven Eckhoff
Shorten lines greater than 80 chars Add const to struct snd_soc_component_driver Signed-off-by: Steven Eckhoff --- sound/soc/codecs/tscs42xx.c | 87 - 1 file changed, 55 insertions(+), 32 deletions(-) diff --git a/sound/soc/codecs/tscs42xx.c b/sound

[alsa-devel][RESEND PATCH 3/3 v3] ASoC: TSCS42xx: Add CCF support to get sysclk

2018-04-04 Thread Steven Eckhoff
The TSCS42xx relies on set_sysclk to get a unique clock id and rate, which prevents it from being used with the simple-card. Remove set_sysclk callback Add CCF support to get clock id and rate Add clocks and clock-names to device tree binding Signed-off-by: Steven Eckhoff <steven.eckhoff.open

[alsa-devel][RESEND PATCH 3/3 v3] ASoC: TSCS42xx: Add CCF support to get sysclk

2018-04-04 Thread Steven Eckhoff
The TSCS42xx relies on set_sysclk to get a unique clock id and rate, which prevents it from being used with the simple-card. Remove set_sysclk callback Add CCF support to get clock id and rate Add clocks and clock-names to device tree binding Signed-off-by: Steven Eckhoff --- .../devicetree

[alsa-devel][RESEND PATCH 2/3 v3] ASoC: TSCS42xx: Cleanup private data members

2018-04-04 Thread Steven Eckhoff
Remove blrcm from private data Remove dev from private data Signed-off-by: Steven Eckhoff <steven.eckhoff.opensou...@gmail.com> --- sound/soc/codecs/tscs42xx.c | 16 ++-- 1 file changed, 6 insertions(+), 10 deletions(-) diff --git a/sound/soc/codecs/tscs42xx.c b/sound/soc/

[alsa-devel][RESEND PATCH 2/3 v3] ASoC: TSCS42xx: Cleanup private data members

2018-04-04 Thread Steven Eckhoff
Remove blrcm from private data Remove dev from private data Signed-off-by: Steven Eckhoff --- sound/soc/codecs/tscs42xx.c | 16 ++-- 1 file changed, 6 insertions(+), 10 deletions(-) diff --git a/sound/soc/codecs/tscs42xx.c b/sound/soc/codecs/tscs42xx.c index 5ad68e5538ae

Re: [alsa-devel][PATCH 1/3 v3] ASoC: TSCS42xx: Shorten lines and other cleanup

2018-04-03 Thread Steven Eckhoff
On Mon, Apr 02, 2018 at 04:23:35PM +0100, Mark Brown wrote: > I only seem to have patches 1 and 2 here (and they aren't threaded with > each other which is a bit odd too). I seem to recall this has been > happening quite a bit with your patches - in general if you're sending > things you should

Re: [alsa-devel][PATCH 1/3 v3] ASoC: TSCS42xx: Shorten lines and other cleanup

2018-04-03 Thread Steven Eckhoff
On Mon, Apr 02, 2018 at 04:23:35PM +0100, Mark Brown wrote: > I only seem to have patches 1 and 2 here (and they aren't threaded with > each other which is a bit odd too). I seem to recall this has been > happening quite a bit with your patches - in general if you're sending > things you should

Re: [alsa-devel][PATCH 3/3 v3] ASoC: TSCS42xx: Add CCF support to get sysclk

2018-03-28 Thread Steven Eckhoff
On Wed, Mar 28, 2018 at 10:44:27AM +0800, Mark Brown wrote: > I'm missing patches 1 and 2 of this resend. I apologize I just sent them.

Re: [alsa-devel][PATCH 3/3 v3] ASoC: TSCS42xx: Add CCF support to get sysclk

2018-03-28 Thread Steven Eckhoff
On Wed, Mar 28, 2018 at 10:44:27AM +0800, Mark Brown wrote: > I'm missing patches 1 and 2 of this resend. I apologize I just sent them.

[alsa-devel][PATCH 2/3 v3] ASoC: TSCS42xx: Cleanup private data members

2018-03-28 Thread Steven Eckhoff
Remove blrcm from private data Remove dev from private data Signed-off-by: Steven Eckhoff <steven.eckhoff.opensou...@gmail.com> --- sound/soc/codecs/tscs42xx.c | 16 ++-- 1 file changed, 6 insertions(+), 10 deletions(-) diff --git a/sound/soc/codecs/tscs42xx.c b/sound/soc/

[alsa-devel][PATCH 2/3 v3] ASoC: TSCS42xx: Cleanup private data members

2018-03-28 Thread Steven Eckhoff
Remove blrcm from private data Remove dev from private data Signed-off-by: Steven Eckhoff --- sound/soc/codecs/tscs42xx.c | 16 ++-- 1 file changed, 6 insertions(+), 10 deletions(-) diff --git a/sound/soc/codecs/tscs42xx.c b/sound/soc/codecs/tscs42xx.c index 37636d6efe60

[alsa-devel][PATCH 1/3 v3] ASoC: TSCS42xx: Shorten lines and other cleanup

2018-03-28 Thread Steven Eckhoff
Shorten lines greater than 80 chars Add const to struct snd_soc_component_driver Signed-off-by: Steven Eckhoff <steven.eckhoff.opensou...@gmail.com> --- sound/soc/codecs/tscs42xx.c | 87 - 1 file changed, 55 insertions(+), 32 deletions(-) diff

[alsa-devel][PATCH 1/3 v3] ASoC: TSCS42xx: Shorten lines and other cleanup

2018-03-28 Thread Steven Eckhoff
Shorten lines greater than 80 chars Add const to struct snd_soc_component_driver Signed-off-by: Steven Eckhoff --- sound/soc/codecs/tscs42xx.c | 87 - 1 file changed, 55 insertions(+), 32 deletions(-) diff --git a/sound/soc/codecs/tscs42xx.c b/sound

[alsa-devel][PATCH 3/3 v3] ASoC: TSCS42xx: Add CCF support to get sysclk

2018-03-27 Thread Steven Eckhoff
The TSCS42xx relies on set_sysclk to get a unique clock id and rate, which prevents it from being used with the simple-card. Remove set_sysclk callback Add CCF support to get clock id and rate Add clocks and clock-names to device tree binding Signed-off-by: Steven Eckhoff <steven.eckhoff.open

[alsa-devel][PATCH 3/3 v3] ASoC: TSCS42xx: Add CCF support to get sysclk

2018-03-27 Thread Steven Eckhoff
The TSCS42xx relies on set_sysclk to get a unique clock id and rate, which prevents it from being used with the simple-card. Remove set_sysclk callback Add CCF support to get clock id and rate Add clocks and clock-names to device tree binding Signed-off-by: Steven Eckhoff --- .../devicetree

[alsa-devel][PATCH 3/3 v2] ASoC: TSCS42xx: Add CCF support to get sysclk

2018-03-27 Thread Steven Eckhoff
The TSCS42xx relies on set_sysclk to get a unique clock id and rate, which prevents it from being used with the simple-card. Remove set_sysclk callback Add CCF support to get clock id and rate Add clocks and clock-names to device tree binding Signed-off-by: Steven Eckhoff <steven.eckhoff.open

[alsa-devel][PATCH 3/3 v2] ASoC: TSCS42xx: Add CCF support to get sysclk

2018-03-27 Thread Steven Eckhoff
The TSCS42xx relies on set_sysclk to get a unique clock id and rate, which prevents it from being used with the simple-card. Remove set_sysclk callback Add CCF support to get clock id and rate Add clocks and clock-names to device tree binding Signed-off-by: Steven Eckhoff --- .../devicetree

[alsa-devel][PATCH 3/3] ASoC: TSCS42xx: Add CCF support to get sysclk

2018-03-23 Thread Steven Eckhoff
The TSCS42xx relies on set_sysclk to get a unique clock id and rate, which prevents it from being used with the simple-card. Remove set_sysclk callback Add CCF support to get clock id and rate Add clocks and clock-names to device tree binding Signed-off-by: Steven Eckhoff <steven.eckhoff.open

[alsa-devel][PATCH 3/3] ASoC: TSCS42xx: Add CCF support to get sysclk

2018-03-23 Thread Steven Eckhoff
The TSCS42xx relies on set_sysclk to get a unique clock id and rate, which prevents it from being used with the simple-card. Remove set_sysclk callback Add CCF support to get clock id and rate Add clocks and clock-names to device tree binding Signed-off-by: Steven Eckhoff --- .../devicetree

[alsa-devel][PATCH 2/3] ASoC: TSCS42xx: Cleanup private data members

2018-03-23 Thread Steven Eckhoff
In the TSCS42xx driver there are some unnecesarry private data members Remove blrcm from private data Remove dev from private data Signed-off-by: Steven Eckhoff <steven.eckhoff.opensou...@gmail.com> --- sound/soc/codecs/tscs42xx.c | 16 ++-- 1 file changed, 6 insertions(

[alsa-devel][PATCH 2/3] ASoC: TSCS42xx: Cleanup private data members

2018-03-23 Thread Steven Eckhoff
In the TSCS42xx driver there are some unnecesarry private data members Remove blrcm from private data Remove dev from private data Signed-off-by: Steven Eckhoff --- sound/soc/codecs/tscs42xx.c | 16 ++-- 1 file changed, 6 insertions(+), 10 deletions(-) diff --git a/sound/soc

[alsa-devel][PATCH 1/3] ASoC: TSCS42xx: Shorten lines and other cleanup

2018-03-23 Thread Steven Eckhoff
Shorten lines greater than 80 chars Add const to struct snd_soc_component_driver Signed-off-by: Steven Eckhoff <steven.eckhoff.opensou...@gmail.com> --- sound/soc/codecs/tscs42xx.c | 87 - 1 file changed, 55 insertions(+), 32 deletions(-) diff

[alsa-devel][PATCH 1/3] ASoC: TSCS42xx: Shorten lines and other cleanup

2018-03-23 Thread Steven Eckhoff
Shorten lines greater than 80 chars Add const to struct snd_soc_component_driver Signed-off-by: Steven Eckhoff --- sound/soc/codecs/tscs42xx.c | 87 - 1 file changed, 55 insertions(+), 32 deletions(-) diff --git a/sound/soc/codecs/tscs42xx.c b/sound

[alsa-devel][PATCH v1] ASoC: TSCS42xx: Add missing headers

2018-03-08 Thread Steven Eckhoff
Add missing headers Signed-off-by: Steven Eckhoff <steven.eckhoff.opensou...@gmail.com> --- sound/soc/codecs/tscs42xx.c | 9 +++-- 1 file changed, 7 insertions(+), 2 deletions(-) diff --git a/sound/soc/codecs/tscs42xx.c b/sound/soc/codecs/tscs42xx.c index e915261fa1cb..cfc71b5411ee

[alsa-devel][PATCH v1] ASoC: TSCS42xx: Add missing headers

2018-03-08 Thread Steven Eckhoff
Add missing headers Signed-off-by: Steven Eckhoff --- sound/soc/codecs/tscs42xx.c | 9 +++-- 1 file changed, 7 insertions(+), 2 deletions(-) diff --git a/sound/soc/codecs/tscs42xx.c b/sound/soc/codecs/tscs42xx.c index e915261fa1cb..cfc71b5411ee 100644 --- a/sound/soc/codecs/tscs42xx.c

Re: [PATCH] ASoC: TSCS42xx: make const array norm_addrs static, reduces object code size

2018-03-08 Thread Steven Eckhoff
overly long. I have tested this on our HAT and it works well. You can add: Reviewed-by: Steven Eckhoff <steven.eckhoff.opensou...@gmail.com> Tested-by: Steven Eckhoff <steven.eckhoff.opensou...@gmail.com> Regards, Steven

Re: [PATCH] ASoC: TSCS42xx: make const array norm_addrs static, reduces object code size

2018-03-08 Thread Steven Eckhoff
overly long. I have tested this on our HAT and it works well. You can add: Reviewed-by: Steven Eckhoff Tested-by: Steven Eckhoff Regards, Steven

Re: [PATCH][next] ASoC: TSCS42xx: make functions pll_event and dac_event static

2018-01-09 Thread Steven Eckhoff
On Mon, Jan 08, 2018 at 11:14:44PM +, Colin King wrote: > The functions pll_event and dac_event are local to the source and do > not need to be in global scope, so make them static. This looks good to me. Thanks for catching this. You can add: Reviewed-by: Steven E

Re: [PATCH][next] ASoC: TSCS42xx: make functions pll_event and dac_event static

2018-01-09 Thread Steven Eckhoff
On Mon, Jan 08, 2018 at 11:14:44PM +, Colin King wrote: > The functions pll_event and dac_event are local to the source and do > not need to be in global scope, so make them static. This looks good to me. Thanks for catching this. You can add: Reviewed-by: Steven Eckhoff

[alsa-devel][PATCH v1] ASoC: TSCS42xx: Fix control names

2018-01-08 Thread Steven Eckhoff
The tscs42xx CODEC driver can confuse userspace with non-standard control names. Remove "Switch" from enum control type names. Add "Switch" to on/off control type names. Signed-off-by: Steven Eckhoff <steven.eckhoff.opensou...@gmail.com> --- sound/

[alsa-devel][PATCH v1] ASoC: TSCS42xx: Fix control names

2018-01-08 Thread Steven Eckhoff
The tscs42xx CODEC driver can confuse userspace with non-standard control names. Remove "Switch" from enum control type names. Add "Switch" to on/off control type names. Signed-off-by: Steven Eckhoff --- sound/soc/codecs/tscs42xx.c | 42 +-

Re: [alsa-devel][PATCH v8] ASoC: TSCS42xx: Add support for Tempo Semiconductor's TSCS42xx audio CODEC

2018-01-08 Thread Steven Eckhoff
On Mon, Jan 08, 2018 at 03:31:07PM +, Mark Brown wrote: > Please don't do that either, if you're submitting a new patch just > submit a new patch. If patches get sorted into the middle of an old > thread it makes it harder to follow what's new and current. Okay that makes sense. I will

Re: [alsa-devel][PATCH v8] ASoC: TSCS42xx: Add support for Tempo Semiconductor's TSCS42xx audio CODEC

2018-01-08 Thread Steven Eckhoff
On Mon, Jan 08, 2018 at 03:31:07PM +, Mark Brown wrote: > Please don't do that either, if you're submitting a new patch just > submit a new patch. If patches get sorted into the middle of an old > thread it makes it harder to follow what's new and current. Okay that makes sense. I will

Re: [alsa-devel][PATCH v8] ASoC: TSCS42xx: Add support for Tempo Semiconductor's TSCS42xx audio CODEC

2018-01-08 Thread Steven Eckhoff
On Mon, Jan 08, 2018 at 11:20:46AM +, Mark Brown wrote: > Please don't resubmit patches that have already been applied, you should > submit patches against current code in the tree you're expecting things > to be applied to. If any updates are needed to a patch that's already > been applied

Re: [alsa-devel][PATCH v8] ASoC: TSCS42xx: Add support for Tempo Semiconductor's TSCS42xx audio CODEC

2018-01-08 Thread Steven Eckhoff
On Mon, Jan 08, 2018 at 11:20:46AM +, Mark Brown wrote: > Please don't resubmit patches that have already been applied, you should > submit patches against current code in the tree you're expecting things > to be applied to. If any updates are needed to a patch that's already > been applied

[alsa-devel][PATCH v8] ASoC: TSCS42xx: Add support for Tempo Semiconductor's TSCS42xx audio CODEC

2018-01-07 Thread Steven Eckhoff
Currently there is no support for TSCS42xx audio CODECs. Add support for TSCS42xx audio CODECs. Reviewed-by: Charles Keepax <ckee...@opensource.cirrus.com> Acked-by: Philippe Ombredanne <pombreda...@nexb.com> Signed-off-by: Steven Eckhoff <steven.eckhoff.opensou...@gmail.com

[alsa-devel][PATCH v8] ASoC: TSCS42xx: Add support for Tempo Semiconductor's TSCS42xx audio CODEC

2018-01-07 Thread Steven Eckhoff
Currently there is no support for TSCS42xx audio CODECs. Add support for TSCS42xx audio CODECs. Reviewed-by: Charles Keepax Acked-by: Philippe Ombredanne Signed-off-by: Steven Eckhoff --- Thank you to everyone involved in improving this driver. In the following history I have attempted

Re: [alsa-devel][PATCH v7] ASoC: TSCS42xx: Add support for Tempo Semiconductor's TSCS42xx audio CODEC

2018-01-07 Thread Steven Eckhoff
On Fri, Jan 05, 2018 at 12:38:03PM +, Mark Brown wrote: > This doesn't apply cleanly against current code, what did you submit > against? :( These aren't trivial things that have just been added to > my tree in this development cycle either, it looks like you're > submitting against some

Re: [alsa-devel][PATCH v7] ASoC: TSCS42xx: Add support for Tempo Semiconductor's TSCS42xx audio CODEC

2018-01-07 Thread Steven Eckhoff
On Fri, Jan 05, 2018 at 12:38:03PM +, Mark Brown wrote: > This doesn't apply cleanly against current code, what did you submit > against? :( These aren't trivial things that have just been added to > my tree in this development cycle either, it looks like you're > submitting against some

Re: [alsa-devel][PATCH v7] ASoC: TSCS42xx: Add support for Tempo Semiconductor's TSCS42xx audio CODEC

2018-01-06 Thread Steven Eckhoff
On Fri, Jan 05, 2018 at 12:22:42PM +, Mark Brown wrote: > > + SOC_ENUM("MBC Band1 Level Detect Switch", > > + mbc_level_detection_enums[0]), > > + SOC_ENUM("MBC Band2 Level Detect Switch", > > + mbc_level_detection_enums[1]), > > + SOC_ENUM("MBC Band3 Level Detect

Re: [alsa-devel][PATCH v7] ASoC: TSCS42xx: Add support for Tempo Semiconductor's TSCS42xx audio CODEC

2018-01-06 Thread Steven Eckhoff
On Fri, Jan 05, 2018 at 12:22:42PM +, Mark Brown wrote: > > + SOC_ENUM("MBC Band1 Level Detect Switch", > > + mbc_level_detection_enums[0]), > > + SOC_ENUM("MBC Band2 Level Detect Switch", > > + mbc_level_detection_enums[1]), > > + SOC_ENUM("MBC Band3 Level Detect

[alsa-devel][PATCH v7] ASoC: TSCS42xx: Add support for Tempo Semiconductor's TSCS42xx audio CODEC

2017-12-19 Thread Steven Eckhoff
Currently there is no support for TSCS42xx audio CODECs. Add support for TSCS42xx audio CODECs. Reviewed-by: Charles Keepax <ckee...@opensource.cirrus.com> Acked-by: Philippe Ombredanne <pombreda...@nexb.com> Signed-off-by: Steven Eckhoff <steven.eckhoff.opensou...@gmail.com

[alsa-devel][PATCH v7] ASoC: TSCS42xx: Add support for Tempo Semiconductor's TSCS42xx audio CODEC

2017-12-19 Thread Steven Eckhoff
Currently there is no support for TSCS42xx audio CODECs. Add support for TSCS42xx audio CODECs. Reviewed-by: Charles Keepax Acked-by: Philippe Ombredanne Signed-off-by: Steven Eckhoff --- Thank you to everyone involved in improving this driver. In the following history I have attempted

Re: [alsa-devel][PATCH v6] ASoC: TSCS42xx: Support Tempo Semiconductor's TSCS42xx audio CODECs

2017-12-18 Thread Steven Eckhoff
On Mon, Dec 18, 2017 at 09:50:48AM +, Charles Keepax wrote: > Is this unused? I apologize I missed this. These were going to be mux controls for two differential inputs. There are two inputs, but only one can be used at a time. We have never seen anybody use the second input, so I will

Re: [alsa-devel][PATCH v6] ASoC: TSCS42xx: Support Tempo Semiconductor's TSCS42xx audio CODECs

2017-12-18 Thread Steven Eckhoff
On Mon, Dec 18, 2017 at 09:50:48AM +, Charles Keepax wrote: > Is this unused? I apologize I missed this. These were going to be mux controls for two differential inputs. There are two inputs, but only one can be used at a time. We have never seen anybody use the second input, so I will

Re: [alsa-devel] [PATCH v5] ASoC: TSCS42xx: Add support for Tempo Semiconductor's TSCS42xx audio CODEC

2017-12-17 Thread Steven Eckhoff
On Thu, Dec 14, 2017 at 09:32:44AM +, Charles Keepax wrote: > Not sure what you mean here but setting up CODEC registers > directly from the machine driver is probably not ideal. You > should probably be looking into regmap_register_patch this lets > you apply a bunch of register settings to

Re: [alsa-devel] [PATCH v5] ASoC: TSCS42xx: Add support for Tempo Semiconductor's TSCS42xx audio CODEC

2017-12-17 Thread Steven Eckhoff
On Thu, Dec 14, 2017 at 09:32:44AM +, Charles Keepax wrote: > Not sure what you mean here but setting up CODEC registers > directly from the machine driver is probably not ideal. You > should probably be looking into regmap_register_patch this lets > you apply a bunch of register settings to

[alsa-devel][PATCH v6] ASoC: TSCS42xx: Support Tempo Semiconductor's TSCS42xx audio CODECs

2017-12-16 Thread Steven Eckhoff
Currently there is no support for TSCS42xx audio CODECs. Add support for TSCS42xx audio CODECs. Acked-by: Philippe Ombredanne <pombreda...@nexb.com> Signed-off-by: Steven Eckhoff <steven.eckhoff.opensou...@gmail.com> --- .../devicetree/bindings/sound/tscs42xx.txt

[alsa-devel][PATCH v6] ASoC: TSCS42xx: Support Tempo Semiconductor's TSCS42xx audio CODECs

2017-12-16 Thread Steven Eckhoff
Currently there is no support for TSCS42xx audio CODECs. Add support for TSCS42xx audio CODECs. Acked-by: Philippe Ombredanne Signed-off-by: Steven Eckhoff --- .../devicetree/bindings/sound/tscs42xx.txt | 16 + .../devicetree/bindings/vendor-prefixes.txt|1 + MAINTAINERS

Re: [alsa-devel] [PATCH v5] ASoC: TSCS42xx: Add support for Tempo Semiconductor's TSCS42xx audio CODEC

2017-12-15 Thread Steven Eckhoff
On Fri, Dec 15, 2017 at 11:36:54AM +, Charles Keepax wrote: > Hmm... might need to think about the case of whether to share a > clock depends a little on what the hardware actually looks like. > > But basically my point is that writing random CODEC registers > from the machine driver is not

Re: [alsa-devel] [PATCH v5] ASoC: TSCS42xx: Add support for Tempo Semiconductor's TSCS42xx audio CODEC

2017-12-15 Thread Steven Eckhoff
On Fri, Dec 15, 2017 at 11:36:54AM +, Charles Keepax wrote: > Hmm... might need to think about the case of whether to share a > clock depends a little on what the hardware actually looks like. > > But basically my point is that writing random CODEC registers > from the machine driver is not

Re: [alsa-devel] [PATCH v5] ASoC: TSCS42xx: Add support for Tempo Semiconductor's TSCS42xx audio CODEC

2017-12-14 Thread Steven Eckhoff
On Thu, Dec 14, 2017 at 04:36:17PM -0600, Steven Eckhoff wrote: > On Thu, Dec 14, 2017 at 09:32:44AM +, Charles Keepax wrote: > > > Not sure what you mean here but setting up CODEC registers > > directly from the machine driver is probably not ideal. You > > sh

Re: [alsa-devel] [PATCH v5] ASoC: TSCS42xx: Add support for Tempo Semiconductor's TSCS42xx audio CODEC

2017-12-14 Thread Steven Eckhoff
On Thu, Dec 14, 2017 at 04:36:17PM -0600, Steven Eckhoff wrote: > On Thu, Dec 14, 2017 at 09:32:44AM +, Charles Keepax wrote: > > > Not sure what you mean here but setting up CODEC registers > > directly from the machine driver is probably not ideal. You > > sh

Re: [alsa-devel] [PATCH v5] ASoC: TSCS42xx: Add support for Tempo Semiconductor's TSCS42xx audio CODEC

2017-12-14 Thread Steven Eckhoff
On Thu, Dec 14, 2017 at 09:32:44AM +, Charles Keepax wrote: > Not sure what you mean here but setting up CODEC registers > directly from the machine driver is probably not ideal. You > should probably be looking into regmap_register_patch this lets > you apply a bunch of register settings to

Re: [alsa-devel] [PATCH v5] ASoC: TSCS42xx: Add support for Tempo Semiconductor's TSCS42xx audio CODEC

2017-12-14 Thread Steven Eckhoff
On Thu, Dec 14, 2017 at 09:32:44AM +, Charles Keepax wrote: > Not sure what you mean here but setting up CODEC registers > directly from the machine driver is probably not ideal. You > should probably be looking into regmap_register_patch this lets > you apply a bunch of register settings to

Re: [PATCH v5] ASoC: TSCS42xx: Add support for Tempo Semiconductor's TSCS42xx audio CODEC

2017-12-13 Thread Steven Eckhoff
On Wed, Dec 13, 2017 at 10:47:32AM +, Mark Brown wrote: > The things the driver is doing automatically to mute the DACs and ADCs > should be moved to user control if they're not suitable for doing > automatically. > The mutes can work normally without the PLL stuff. I have removed the PLL

Re: [PATCH v5] ASoC: TSCS42xx: Add support for Tempo Semiconductor's TSCS42xx audio CODEC

2017-12-13 Thread Steven Eckhoff
On Wed, Dec 13, 2017 at 10:47:32AM +, Mark Brown wrote: > The things the driver is doing automatically to mute the DACs and ADCs > should be moved to user control if they're not suitable for doing > automatically. > The mutes can work normally without the PLL stuff. I have removed the PLL

Re: [PATCH v5] ASoC: TSCS42xx: Add support for Tempo Semiconductor's TSCS42xx audio CODEC

2017-12-12 Thread Steven Eckhoff
On Tue, Dec 12, 2017 at 04:51:35PM -0600, Steven Eckhoff wrote: > > > > +static int tscs42xx_mute_stream(struct snd_soc_dai *dai, int mute, int > > > > stream) > > > > +{ > > > > + struct snd_soc_codec *codec = dai->codec; > >

Re: [PATCH v5] ASoC: TSCS42xx: Add support for Tempo Semiconductor's TSCS42xx audio CODEC

2017-12-12 Thread Steven Eckhoff
On Tue, Dec 12, 2017 at 04:51:35PM -0600, Steven Eckhoff wrote: > > > > +static int tscs42xx_mute_stream(struct snd_soc_dai *dai, int mute, int > > > > stream) > > > > +{ > > > > + struct snd_soc_codec *codec = dai->codec; > >

Re: [PATCH v5] ASoC: TSCS42xx: Add support for Tempo Semiconductor's TSCS42xx audio CODEC

2017-12-12 Thread Steven Eckhoff
On Tue, Dec 12, 2017 at 03:31:16PM -0600, Steven Eckhoff wrote: > On Tue, Dec 12, 2017 at 04:32:54PM +, Mark Brown wrote: > > On Mon, Dec 11, 2017 at 01:54:25PM -0600, Steven Eckhoff wrote: > > > Currently there is no support for the TSCS42xx audio CODEC. > &

Re: [PATCH v5] ASoC: TSCS42xx: Add support for Tempo Semiconductor's TSCS42xx audio CODEC

2017-12-12 Thread Steven Eckhoff
On Tue, Dec 12, 2017 at 03:31:16PM -0600, Steven Eckhoff wrote: > On Tue, Dec 12, 2017 at 04:32:54PM +, Mark Brown wrote: > > On Mon, Dec 11, 2017 at 01:54:25PM -0600, Steven Eckhoff wrote: > > > Currently there is no support for the TSCS42xx audio CODEC. > &

Re: [PATCH v5] ASoC: TSCS42xx: Add support for Tempo Semiconductor's TSCS42xx audio CODEC

2017-12-12 Thread Steven Eckhoff
On Tue, Dec 12, 2017 at 04:32:54PM +, Mark Brown wrote: > On Mon, Dec 11, 2017 at 01:54:25PM -0600, Steven Eckhoff wrote: > > Currently there is no support for the TSCS42xx audio CODEC. > > > > Add support for it. > > > > v5 attempts to address all issu

Re: [PATCH v5] ASoC: TSCS42xx: Add support for Tempo Semiconductor's TSCS42xx audio CODEC

2017-12-12 Thread Steven Eckhoff
On Tue, Dec 12, 2017 at 04:32:54PM +, Mark Brown wrote: > On Mon, Dec 11, 2017 at 01:54:25PM -0600, Steven Eckhoff wrote: > > Currently there is no support for the TSCS42xx audio CODEC. > > > > Add support for it. > > > > v5 attempts to address all issu

Re: [PATCH v5] ASoC: TSCS42xx: Add support for Tempo Semiconductor's TSCS42xx audio CODEC

2017-12-12 Thread Steven Eckhoff
On Tue, Dec 12, 2017 at 02:10:09PM +0100, Takashi Iwai wrote: > On Tue, 12 Dec 2017 14:04:01 +0100, > Charles Keepax wrote: > > > > On Mon, Dec 11, 2017 at 01:54:25PM -0600, Steven Eckhoff wrote: > > > Currently there is no support for the TSCS42xx audio CODE

Re: [PATCH v5] ASoC: TSCS42xx: Add support for Tempo Semiconductor's TSCS42xx audio CODEC

2017-12-12 Thread Steven Eckhoff
On Tue, Dec 12, 2017 at 02:10:09PM +0100, Takashi Iwai wrote: > On Tue, 12 Dec 2017 14:04:01 +0100, > Charles Keepax wrote: > > > > On Mon, Dec 11, 2017 at 01:54:25PM -0600, Steven Eckhoff wrote: > > > Currently there is no support for the TSCS42xx audio CODE

Re: [PATCH v5] ASoC: TSCS42xx: Add support for Tempo Semiconductor's TSCS42xx audio CODEC

2017-12-12 Thread Steven Eckhoff
On Tue, Dec 12, 2017 at 01:04:01PM +, Charles Keepax wrote: > On Mon, Dec 11, 2017 at 01:54:25PM -0600, Steven Eckhoff wrote: > > Currently there is no support for the TSCS42xx audio CODEC. > > > > Add support for it. > > > > v5 attempts to address all issu

Re: [PATCH v5] ASoC: TSCS42xx: Add support for Tempo Semiconductor's TSCS42xx audio CODEC

2017-12-12 Thread Steven Eckhoff
On Tue, Dec 12, 2017 at 01:04:01PM +, Charles Keepax wrote: > On Mon, Dec 11, 2017 at 01:54:25PM -0600, Steven Eckhoff wrote: > > Currently there is no support for the TSCS42xx audio CODEC. > > > > Add support for it. > > > > v5 attempts to address all issu

[PATCH v5] ASoC: TSCS42xx: Add support for Tempo Semiconductor's TSCS42xx audio CODEC

2017-12-11 Thread Steven Eckhoff
ed-off-by: Steven Eckhoff <steven.eckhoff.opensou...@gmail.com> --- .../devicetree/bindings/sound/tscs42xx.txt | 15 + .../devicetree/bindings/vendor-prefixes.txt|1 + MAINTAINERS|5 + sound/soc/codecs/Kconfig

[PATCH v5] ASoC: TSCS42xx: Add support for Tempo Semiconductor's TSCS42xx audio CODEC

2017-12-11 Thread Steven Eckhoff
Currently there is no support for the TSCS42xx audio CODEC. Add support for it. v5 attempts to address all issues raised in the previous reviews. Thank you to everyone who has invested their time reviewing these patches. Acked-by: Philippe Ombredanne Signed-off-by: Steven Eckhoff

Re: [alsa-devel][PATCH v3] ASoC: TSCS42xx: Add support for Tempo Semiconductor's TSCS42xx audio CODEC

2017-12-10 Thread Steven Eckhoff
On Sun, Dec 10, 2017 at 10:00:02AM +0100, Philippe Ombredanne wrote: > Have you considered using the new SPDX ids? I was unaware of this. Thank you for bringing it to my attention. I have added it to v4. You can see it here: https://patchwork.kernel.org/patch/10104003/ Thanks for the review!

Re: [alsa-devel][PATCH v3] ASoC: TSCS42xx: Add support for Tempo Semiconductor's TSCS42xx audio CODEC

2017-12-10 Thread Steven Eckhoff
On Sun, Dec 10, 2017 at 10:00:02AM +0100, Philippe Ombredanne wrote: > Have you considered using the new SPDX ids? I was unaware of this. Thank you for bringing it to my attention. I have added it to v4. You can see it here: https://patchwork.kernel.org/patch/10104003/ Thanks for the review!

[alsa-devel][PATCH v4] ASoC: TSCS42xx: Add support for Tempo Semiconductor's TSCS42xx audio CODEC

2017-12-10 Thread Steven Eckhoff
; > doing and make sure your subject lines visually resemble what they're > > doing. > > I also apologize for this. I hope that the subject line is correct now. > > > > +What:/sys/bus/i2c/devices/.../dsp/eq[n]_ch[n]_[ab][n] > > > +Date:

[alsa-devel][PATCH v4] ASoC: TSCS42xx: Add support for Tempo Semiconductor's TSCS42xx audio CODEC

2017-12-10 Thread Steven Eckhoff
lines visually resemble what they're > > doing. > > I also apologize for this. I hope that the subject line is correct now. > > > > +What:/sys/bus/i2c/devices/.../dsp/eq[n]_ch[n]_[ab][n] > > > +Date:November 2017 > > > +KernelVersion:

[alsa-devel][PATCH v3] ASoC: TSCS42xx: Add support for Tempo Semiconductor's TSCS42xx audio CODEC

2017-12-09 Thread Steven Eckhoff
Currently there is no support for the TSCS42xx audio CODEC. Add support for it. Below is the link to the v2 patch in case the threading is broken. This patch addressed each issue raised in the last review. https://patchwork.kernel.org/patch/10058117/ Signed-off-by: Steven Eckhoff

[alsa-devel][PATCH v3] ASoC: TSCS42xx: Add support for Tempo Semiconductor's TSCS42xx audio CODEC

2017-12-09 Thread Steven Eckhoff
Currently there is no support for the TSCS42xx audio CODEC. Add support for it. Below is the link to the v2 patch in case the threading is broken. This patch addressed each issue raised in the last review. https://patchwork.kernel.org/patch/10058117/ Signed-off-by: Steven Eckhoff Cc: Steven

[PATCH v2] Add support for Tempo Semiconductor's TSCS42xx audio CODEC

2017-11-14 Thread Steven Eckhoff
Currently there is no support for the TSCS42xx audio CODEC. Add support for it. Signed-off-by: Steven Eckhoff <steven.eckhoff.opensou...@gmail.com> Cc: Steven Eckhoff <steven.eckhoff.opensou...@gmail.com> Cc: Liam Girdwood <lgirdw...@gmail.com> Cc: Mark Brown <broo...@ker

[PATCH v2] Add support for Tempo Semiconductor's TSCS42xx audio CODEC

2017-11-14 Thread Steven Eckhoff
Currently there is no support for the TSCS42xx audio CODEC. Add support for it. Signed-off-by: Steven Eckhoff Cc: Steven Eckhoff Cc: Liam Girdwood Cc: Mark Brown Cc: Jaroslav Kysela Cc: Takashi Iwai Cc: alsa-de...@alsa-project.org Cc: linux-kernel@vger.kernel.org --- .../ABI/testing/sysfs

[PATCH] Add support for Tempo Semiconductor's TSCS42xx audio CODEC

2017-11-14 Thread Steven Eckhoff
Currently there is no support for the TSCS42xx audio CODEC. Add support for it. Signed-off-by: Steven Eckhoff <steven.eckhoff.opensou...@gmail.com> Cc: Steven Eckhoff <steven.eckhoff.opensou...@gmail.com> Cc: Liam Girdwood <lgirdw...@gmail.com> Cc: Mark Brown <broo...@ker

[PATCH] Add support for Tempo Semiconductor's TSCS42xx audio CODEC

2017-11-14 Thread Steven Eckhoff
Currently there is no support for the TSCS42xx audio CODEC. Add support for it. Signed-off-by: Steven Eckhoff Cc: Steven Eckhoff Cc: Liam Girdwood Cc: Mark Brown Cc: Jaroslav Kysela Cc: Takashi Iwai Cc: alsa-de...@alsa-project.org Cc: linux-kernel@vger.kernel.org --- .../ABI/testing/sysfs